pspp
7 years agofactor: Fix return type of do_factor_by_matrix().
Ben Pfaff [Tue, 16 May 2017 04:00:56 +0000 (21:00 -0700)]
factor: Fix return type of do_factor_by_matrix().

This function had a "bool" return type but nothing used it.

Fixes GCC warning "'return' with no value, in function returning non-void".

Reported by Jeremy Lavergne.

7 years agoNew Dialog: Non Parametric | K Indepdendent Samples
John Darrington [Sat, 13 May 2017 17:26:17 +0000 (19:26 +0200)]
New Dialog: Non Parametric | K Indepdendent Samples

7 years agoPsppireValueEntry: Use a more reliable way to override parent property.
John Darrington [Mon, 15 May 2017 07:00:45 +0000 (09:00 +0200)]
PsppireValueEntry: Use a more reliable way to override parent property.

Setting the property in the _new function doesn't work if the object is constructed
via GtkBuilder for example.

7 years agoZip Reader: initialise error string earlier.
John Darrington [Sat, 13 May 2017 09:19:58 +0000 (11:19 +0200)]
Zip Reader: initialise error string earlier.

Fixed a bug which could have caused a crash if pspp were presented
with a corrupt zip file.

7 years agoFixed bug which caused a crash in GET DATA
John Darrington [Fri, 12 May 2017 15:03:06 +0000 (17:03 +0200)]
Fixed bug which caused a crash in GET DATA

7 years agoMEANS: Prevent parser from entering infinite loop.
John Darrington [Fri, 12 May 2017 10:25:55 +0000 (12:25 +0200)]
MEANS: Prevent parser from entering infinite loop.

Fixes bug #51008
.

7 years agosrc/math/linreg.c: Don't calculate the intercept for regression through the origin
John Darrington [Fri, 12 May 2017 09:35:09 +0000 (11:35 +0200)]
src/math/linreg.c: Don't calculate the intercept for regression through the origin

7 years agosrc/math/linreg.c: Encapsulate this object better.
John Darrington [Fri, 12 May 2017 06:36:56 +0000 (08:36 +0200)]
src/math/linreg.c: Encapsulate this object better.

7 years agoREGRESSION: Implement /ORIGIN subcommand.
John Darrington [Fri, 12 May 2017 05:42:55 +0000 (07:42 +0200)]
REGRESSION: Implement /ORIGIN subcommand.

7 years agoDESCRIPTIVES: Fix a bug where the parser could enter an infinite loop
John Darrington [Thu, 11 May 2017 14:38:11 +0000 (16:38 +0200)]
DESCRIPTIVES: Fix a bug where the parser could enter an infinite loop

7 years agoFACTOR: Don't try to perform analysis if there are no variables.
John Darrington [Thu, 11 May 2017 12:01:50 +0000 (14:01 +0200)]
FACTOR: Don't try to perform analysis if there are no variables.

7 years agoFACTOR: Do not try to run an analysis if no matrix is present
John Darrington [Thu, 11 May 2017 11:48:31 +0000 (13:48 +0200)]
FACTOR: Do not try to run an analysis if no matrix is present

7 years agoFACTOR: Fix a crash when bad input was presented
John Darrington [Thu, 11 May 2017 11:22:37 +0000 (13:22 +0200)]
FACTOR: Fix a crash when bad input was presented

7 years agoFACTOR: Make idata parameters const where they can be.
John Darrington [Thu, 11 May 2017 10:42:10 +0000 (12:42 +0200)]
FACTOR: Make idata parameters const where they can be.

7 years agoDATA MATRIX: Avoid crash on invalid input
John Darrington [Thu, 11 May 2017 08:40:51 +0000 (10:40 +0200)]
DATA MATRIX: Avoid crash on invalid input

7 years agoFix memory leaks in FACTOR/MATRIX
John Darrington [Wed, 10 May 2017 14:43:39 +0000 (16:43 +0200)]
Fix memory leaks in FACTOR/MATRIX

7 years agoRemove unused variable
John Darrington [Wed, 10 May 2017 10:59:11 +0000 (12:59 +0200)]
Remove unused variable

7 years agoFACTOR: Use consistent indexing when displaying matrices.
John Darrington [Wed, 10 May 2017 10:48:17 +0000 (12:48 +0200)]
FACTOR: Use consistent indexing when displaying matrices.

In any sane use case this will make no difference, since
all covariance and correlation matrices are symetrical.
However for correctness and ease of debugging this helps.

7 years agomatrix reader: Fix bug which incorrectly read in matrix material.
John Darrington [Wed, 10 May 2017 10:41:40 +0000 (12:41 +0200)]
matrix reader: Fix bug which incorrectly read in matrix material.

7 years agoMATRIX DATA: Allow non-symetric matrices if /FORMAT = FULL.
John Darrington [Wed, 10 May 2017 08:50:12 +0000 (10:50 +0200)]
MATRIX DATA: Allow non-symetric matrices if /FORMAT = FULL.

7 years agoMatrix reader, fix comment to reflect reality.
John Darrington [Wed, 10 May 2017 05:54:02 +0000 (07:54 +0200)]
Matrix reader, fix comment to reflect reality.

7 years agoMATRIX DATA: Cope with long variable names
John Darrington [Tue, 9 May 2017 14:41:08 +0000 (16:41 +0200)]
MATRIX DATA: Cope with long variable names

7 years agoFACTOR: Allow an option '=' after MATRIX
John Darrington [Tue, 9 May 2017 13:13:32 +0000 (15:13 +0200)]
FACTOR: Allow an option '=' after MATRIX

7 years agoREGRESSION: Allow independent variables to be specified on the ENTER subcommand.
John Darrington [Tue, 9 May 2017 07:46:29 +0000 (09:46 +0200)]
REGRESSION: Allow independent variables to be specified on the ENTER subcommand.

This is more typical of the syntax that third party software generates.

7 years agoFACTOR: Add printout of the covariance matrix and add a test
John Darrington [Thu, 4 May 2017 16:17:11 +0000 (18:17 +0200)]
FACTOR: Add printout of the covariance matrix and add a test

7 years agoFACTOR: New subcommand: MATRIX IN
John Darrington [Thu, 4 May 2017 15:31:37 +0000 (17:31 +0200)]
FACTOR: New subcommand: MATRIX IN

7 years agoNew function covariance_from_correlation
John Darrington [Thu, 4 May 2017 15:27:31 +0000 (17:27 +0200)]
New function covariance_from_correlation

7 years agoNew module matrix-reader
John Darrington [Thu, 4 May 2017 15:25:49 +0000 (17:25 +0200)]
New module matrix-reader

Added a new module to help read the files created by MATRIX DATA

7 years agoMATRIX DATA: Fix crash when duplicate variables are specified
John Darrington [Mon, 1 May 2017 19:02:22 +0000 (21:02 +0200)]
MATRIX DATA: Fix crash when duplicate variables are specified

7 years agoMATRIX DATA: Handle multiple splits properly
John Darrington [Mon, 1 May 2017 18:30:45 +0000 (20:30 +0200)]
MATRIX DATA: Handle multiple splits properly

7 years agoMATRIX DATA: Rewrite to canonical rowtype values
John Darrington [Sun, 30 Apr 2017 18:35:55 +0000 (20:35 +0200)]
MATRIX DATA: Rewrite to canonical rowtype values

7 years agoUpdated the French translation from translationproject.org
John Darrington [Sun, 30 Apr 2017 07:59:16 +0000 (09:59 +0200)]
Updated the French translation from translationproject.org

7 years agoAdded the MATRIX DATA procedure.
John Darrington [Wed, 26 Apr 2017 17:06:53 +0000 (19:06 +0200)]
Added the MATRIX DATA procedure.

7 years agoparse_DATA_LIST_vars: Reduce scope of variable 'name2'
John Darrington [Wed, 26 Apr 2017 12:47:10 +0000 (14:47 +0200)]
parse_DATA_LIST_vars: Reduce scope of variable 'name2'

7 years agoWhitespace changes only: Remove trailing whitespace
John Darrington [Sat, 22 Apr 2017 18:20:24 +0000 (20:20 +0200)]
Whitespace changes only: Remove trailing whitespace

7 years agoDo not allow value labels dialog to enter a label for an invalid value.
John Darrington [Wed, 19 Apr 2017 16:48:51 +0000 (18:48 +0200)]
Do not allow value labels dialog to enter a label for an invalid value.

Fixes bug #45429

7 years agoRemove inappropriate single selection-mode properties from dialog actions.
John Darrington [Tue, 18 Apr 2017 16:31:50 +0000 (18:31 +0200)]
Remove inappropriate single selection-mode properties from dialog actions.

Closes bug #50029

7 years agoDon't try to use TIOCGWINSZ if termios.h is not available.
John Darrington [Sun, 16 Apr 2017 12:18:29 +0000 (14:18 +0200)]
Don't try to use TIOCGWINSZ if termios.h is not available.

7 years agoFix grammatical error in NEWS
John Darrington [Tue, 28 Mar 2017 05:25:56 +0000 (07:25 +0200)]
Fix grammatical error in NEWS

7 years agotests: Do not delete testsuite on distclean.
Ben Pfaff [Sat, 15 Apr 2017 20:51:37 +0000 (13:51 -0700)]
tests: Do not delete testsuite on distclean.

The testsuite is distributed, so distclean must not delete it.

Thanks to Harry Thijssen <pspp4windows@gmail.com> for reporting the problem.

7 years agoEdit|Options: Add fields to change behaviour of output window.
John Darrington [Mon, 27 Mar 2017 17:30:28 +0000 (19:30 +0200)]
Edit|Options: Add fields to change behaviour of output window.

7 years agoNew menu: Edit|Options
John Darrington [Sat, 25 Mar 2017 21:47:27 +0000 (22:47 +0100)]
New menu: Edit|Options

Add a new menu to set global options.  Currently it only affects the display
of variables in Dictionary Views.

7 years agoHtml Driver: Fix bug when rendering small cells.
John Darrington [Fri, 24 Mar 2017 16:40:39 +0000 (17:40 +0100)]
Html Driver: Fix bug when rendering small cells.

This fix avoids a bug where the driver would enter a tight loop when rendering cells
with zero height or width.

7 years agoUpdated NEWS file.
John Darrington [Fri, 24 Mar 2017 10:38:58 +0000 (11:38 +0100)]
Updated NEWS file.

7 years agoTerminal interface: Remove support for the ncurses library.
John Darrington [Fri, 24 Mar 2017 07:29:31 +0000 (08:29 +0100)]
Terminal interface: Remove support for the ncurses library.

This library was supported for trivial reasons.  It always gave rise
to portability issues and was a pain to support.  Furthermore there
is a simpler way to do what we used it for.  So now we use that way
instead.

7 years agoMann Whitney: Remove unused variable
John Darrington [Wed, 15 Mar 2017 07:52:28 +0000 (08:52 +0100)]
Mann Whitney: Remove unused variable

7 years agoFixed a bug in the Mann-Whitney test vs. missing=analysis.
John Darrington [Tue, 7 Mar 2017 05:31:49 +0000 (06:31 +0100)]
Fixed a bug in the Mann-Whitney test vs. missing=analysis.

When missing values were deleted from the dataset, they were deleted after the
ranks for the U value had been inserted, - thus the wrong rank sum would be
calculated.  This change deletes missing values *before* the ranks are inserted.

The issue this fixes is described at
http://lists.gnu.org/archive/html/pspp-users/2017-03/msg00009.html

7 years agoFREQUENCIES: fixed VARIANCE output - fixes bug #50366
Friedrich Beckmann [Tue, 21 Feb 2017 14:52:41 +0000 (15:52 +0100)]
FREQUENCIES: fixed VARIANCE output - fixes bug #50366

The FREQUENCIES command output the mean instead of variance result when
variance was requested. The bug and a patch was reported on savannah.
I added a test to identify the problem and the proposed patch.

fixes bug #50366

7 years agotests: Avoid infinite loop in test.
John Darrington [Sat, 14 Jan 2017 11:22:13 +0000 (12:22 +0100)]
tests: Avoid infinite loop in test.

7 years agotests: Ensure that the testsuite is of non-zero size
John Darrington [Sat, 14 Jan 2017 10:15:12 +0000 (11:15 +0100)]
tests: Ensure that the testsuite is of non-zero size

7 years agopsppire-import-assistant: Use maximised window instead of full_screen.
John Darrington [Sat, 14 Jan 2017 06:51:18 +0000 (07:51 +0100)]
psppire-import-assistant: Use maximised window instead of full_screen.

A number of users had complained about the full screen window.
Fixes bug #48230

7 years agopo: Add new variable LOCALPOFILES to hold locally managed .po files
John Darrington [Sat, 14 Jan 2017 06:28:52 +0000 (07:28 +0100)]
po: Add new variable LOCALPOFILES to hold locally managed .po files

This variable holds .po files not managed by translationproject.org

7 years agoEnsure that help page manifest is not empty.
John Darrington [Sun, 21 Aug 2016 12:29:21 +0000 (14:29 +0200)]
Ensure that help page manifest is not empty.

For some reason I have found that sometimes doc/help-pages-list
is zero bytes long.   I don't know how this happens, but this
change should catch it and allow us to find out why.

7 years agopo: Update translations from translationproject.org.
Ben Pfaff [Sat, 24 Dec 2016 00:49:15 +0000 (16:49 -0800)]
po: Update translations from translationproject.org.

7 years agoUpdate all translations using "make po-update".
Ben Pfaff [Sun, 4 Dec 2016 21:31:44 +0000 (13:31 -0800)]
Update all translations using "make po-update".

This only adds an "X-Bugs:" line to the translations, which were otherwise
up-to-date except that cs.po and en_GB.po aren't actually in
translationproject.  I'll have to ask John Darrington about that.

7 years agopo: Add po-update rule for updating all translations.
Ben Pfaff [Sun, 4 Dec 2016 21:29:57 +0000 (13:29 -0800)]
po: Add po-update rule for updating all translations.

7 years agopo: Update translations from translationproject.org.
Ben Pfaff [Sun, 4 Dec 2016 21:17:57 +0000 (13:17 -0800)]
po: Update translations from translationproject.org.

7 years agoFix misleadingly indented statements.
Ben Pfaff [Sat, 3 Dec 2016 06:24:06 +0000 (22:24 -0800)]
Fix misleadingly indented statements.

GCC 6.2.1 reported {}-braced blocks that looked like they were guarded by
preceding "if" statements but really weren't.  This fixes the misleading
indentation.

7 years agogui: Remove unused static variables.
Ben Pfaff [Sat, 3 Dec 2016 06:23:12 +0000 (22:23 -0800)]
gui: Remove unused static variables.

Reported by GCC 6.2.1.

7 years agogui: Fix #includes for gtksourceview.
Ben Pfaff [Sat, 3 Dec 2016 06:18:16 +0000 (22:18 -0800)]
gui: Fix #includes for gtksourceview.

Newer versions of gtksourceview only allow gtksource.h to be included
directly, so this commit changes PSPPIRE to only include that header.

7 years agopo: Update German translation from translationproject.org.
Ben Pfaff [Tue, 22 Nov 2016 18:50:16 +0000 (10:50 -0800)]
po: Update German translation from translationproject.org.

7 years agotypo in XEXPORT documentation
pspp.freepost@ordinaryamerican.net [Mon, 7 Nov 2016 13:40:14 +0000 (14:40 +0100)]
typo in XEXPORT documentation

This typo was reported in the mailing list in message:
http://lists.gnu.org/archive/html/bug-gnu-pspp/2016-11/msg00001.html
Thank you for reporting the typo!

7 years agofixed func macro in documentation - closes bug #49549
pspp.freepost@ordinaryamerican.net [Mon, 7 Nov 2016 13:10:48 +0000 (14:10 +0100)]
fixed func macro in documentation - closes bug #49549

The func macro did not handle the argument correctly. All arguments were literally
replaced with NAME. I tested this on MacOS with the generated pdf.

Closes bug #49549

7 years agocompile without gnumeric and odf read support
pspp.freepost@ordinaryamerican.net [Mon, 7 Nov 2016 11:18:35 +0000 (12:18 +0100)]
compile without gnumeric and odf read support

This patch fixes the problem described in bug #49550. When libxml2 is
not installed, the gnumeric and odf read support is disabled. This was
not handled correctly. I changed the compilation requirements and the
error message handling if somebody tries to open a file.

Closes bug #49550.

7 years agoreversed CFLAGS, CPPFLAGS and LDFLAGS addition for q2c.c build
Friedrich Beckmann [Mon, 10 Oct 2016 20:34:08 +0000 (22:34 +0200)]
reversed CFLAGS, CPPFLAGS and LDFLAGS addition for q2c.c build

Ben mentioned that this will break the cross compile build. So
I reverted this change.

7 years agoadded CFLAGS, CPPFLAGS and LDFLAGS for PSPP.C and q2c.c compilation
Friedrich Beckmann [Mon, 10 Oct 2016 17:39:06 +0000 (19:39 +0200)]
added CFLAGS, CPPFLAGS and LDFLAGS for PSPP.C and q2c.c compilation

The hardening check during the debian build process showed that the
hardening compile flags are not issued to the compilation process of
PSPP.c (the perl module) and q2c.c (the lexer). Although q2c.c is only
relevant during the build process hardening this will not hurt.

7 years agoperl - added current directory path to calls
Friedrich Beckmann [Mon, 10 Oct 2016 10:55:01 +0000 (12:55 +0200)]
perl - added current directory path to calls

The perl INC path in debian does not include the current directory
anymore. Therefore I added the current directory path at the places
where a module is called and it is assumed that . is part of INC.

See: https://lwn.net/Articles/698853/

7 years agopo: Update Spanish translation from translationproject.org.
Ben Pfaff [Tue, 20 Sep 2016 18:03:30 +0000 (11:03 -0700)]
po: Update Spanish translation from translationproject.org.

7 years agohelp: added t-test reference to help page
Friedrich Beckmann [Fri, 16 Sep 2016 07:17:40 +0000 (09:17 +0200)]
help: added t-test reference to help page

The help button for the t-test dialogs ended on the main page. I added
a reference such that it lands on the t-test page in the documentation.

7 years agoexamples: t-test.sps fixed make process to include in distribution
Friedrich Beckmann [Thu, 15 Sep 2016 18:25:36 +0000 (20:25 +0200)]
examples: t-test.sps fixed make process to include in distribution

I forgot to add the t-test.sps example in the automake.mk file to
include it in the distribution.

7 years agot-test example: Change some wrong comments
Friedrich Beckmann [Thu, 15 Sep 2016 08:30:10 +0000 (10:30 +0200)]
t-test example: Change some wrong comments

I had some wrong comments describing the code.

7 years agoExamples: Added t-Test example code
Friedrich Beckmann [Thu, 15 Sep 2016 08:20:23 +0000 (10:20 +0200)]
Examples: Added t-Test example code

I added a simple t-Test example code with some plots as a
kind of beginners tutorial.

7 years agopo: Add Greek translation and update Catalan and Spanish translations.
Ben Pfaff [Tue, 6 Sep 2016 14:15:59 +0000 (07:15 -0700)]
po: Add Greek translation and update Catalan and Spanish translations.

From translationproject.org.

7 years agoFix missing buttonbox in frequencies dialog
John Darrington [Thu, 1 Sep 2016 07:21:51 +0000 (09:21 +0200)]
Fix missing buttonbox in frequencies dialog

7 years agopsppire-output-view: Avoid GtkWarnings
John Darrington [Thu, 1 Sep 2016 06:32:04 +0000 (08:32 +0200)]
psppire-output-view: Avoid GtkWarnings

7 years agoPSQL READER: Use the REPEATABLE READ isolation level.
John Darrington [Tue, 23 Aug 2016 19:41:13 +0000 (21:41 +0200)]
PSQL READER: Use the REPEATABLE READ isolation level.

Apparently SERIALIZABLE doesn't work if the server is in
"hot standby" mode.

7 years agoFix bugs in frequencies dialog.
John Darrington [Sat, 20 Aug 2016 15:04:30 +0000 (17:04 +0200)]
Fix bugs in frequencies dialog.

This seems to have crept in, in commit dc6d0e08956c6ad42cc943b7496a192c71bdbe02

Thanks to Harry for reporting it.

7 years agoAdded autoconf check for msgfmt
John Darrington [Sat, 20 Aug 2016 14:10:15 +0000 (16:10 +0200)]
Added autoconf check for msgfmt

7 years agoRe-enable the relocation feature.
John Darrington [Thu, 18 Aug 2016 15:44:47 +0000 (17:44 +0200)]
Re-enable the relocation feature.

Problem reported by Harry

7 years agoDisable deprecation warnings for all sheet related code
John Darrington [Sun, 14 Aug 2016 12:46:34 +0000 (14:46 +0200)]
Disable deprecation warnings for all sheet related code

7 years agoRemove call to gtk_style_context_add_provider_for_screen
John Darrington [Mon, 15 Aug 2016 11:51:42 +0000 (13:51 +0200)]
Remove call to gtk_style_context_add_provider_for_screen

Contrary to advice I was previously given, this is neither necessary nor
desireable.

7 years agoFont Selection: Use a local css_provider instead of the default one
John Darrington [Mon, 15 Aug 2016 11:48:29 +0000 (13:48 +0200)]
Font Selection: Use a local css_provider instead of the default one

7 years agoPrevent the font selection of comment dialog affecting other widgets.
John Darrington [Mon, 15 Aug 2016 06:53:04 +0000 (08:53 +0200)]
Prevent the font selection of comment dialog affecting other widgets.

I had not properly understood how gtk_css_provider worked.  Hopefully my
understanding is now more accurate.

7 years agoVECTOR: Support creating string variables also.
Ben Pfaff [Sun, 14 Aug 2016 16:28:23 +0000 (09:28 -0700)]
VECTOR: Support creating string variables also.

Bug #48763.

7 years agoFix memory leak
John Darrington [Sun, 14 Aug 2016 13:21:53 +0000 (15:21 +0200)]
Fix memory leak

7 years agoUse modern method of setting font, instead of deprecated method
John Darrington [Sun, 14 Aug 2016 12:51:59 +0000 (14:51 +0200)]
Use modern method of setting font, instead of deprecated method

7 years agoAdded "translate" url to pspp.appdata.xml
John Darrington [Sun, 14 Aug 2016 08:45:48 +0000 (10:45 +0200)]
Added "translate" url to pspp.appdata.xml

7 years agoFix typos in comments
John Darrington [Sun, 14 Aug 2016 07:35:39 +0000 (09:35 +0200)]
Fix typos in comments

7 years agoFix compiler warning
John Darrington [Sun, 14 Aug 2016 05:47:48 +0000 (07:47 +0200)]
Fix compiler warning

7 years agoFix bug where the gui was unresponsive after starting with a file as command line...
John Darrington [Sun, 14 Aug 2016 05:38:15 +0000 (07:38 +0200)]
Fix bug where the gui was unresponsive after starting with a file as command line argument

7 years agoFix bug inadvertently introduced by previous commit
John Darrington [Sat, 13 Aug 2016 07:13:42 +0000 (09:13 +0200)]
Fix bug inadvertently introduced by previous commit

7 years agoNew option --no-unique
John Darrington [Sat, 13 Aug 2016 06:25:03 +0000 (08:25 +0200)]
New option --no-unique

7 years agoAUTORECODE now optionally accepts / before INTO
John Darrington [Sat, 13 Aug 2016 05:29:30 +0000 (07:29 +0200)]
AUTORECODE now optionally accepts / before INTO

Fixes Bug #48762

7 years agoAdd markup to the option description strings
John Darrington [Fri, 12 Aug 2016 18:58:03 +0000 (20:58 +0200)]
Add markup to the option description strings

7 years agoFix GtkCriticals when --no-splash is given
John Darrington [Fri, 12 Aug 2016 16:22:14 +0000 (18:22 +0200)]
Fix GtkCriticals when --no-splash is given

7 years agoFix potential null pointer dereference
John Darrington [Fri, 12 Aug 2016 04:53:35 +0000 (06:53 +0200)]
Fix potential null pointer dereference

Found by cppcheck

7 years agoFix possible null pointer dereference
John Darrington [Thu, 11 Aug 2016 20:11:38 +0000 (22:11 +0200)]
Fix possible null pointer dereference

7 years agoFix possible null pointer dereference.
John Darrington [Thu, 11 Aug 2016 19:52:52 +0000 (21:52 +0200)]
Fix possible null pointer dereference.

Found by cppcheck

7 years agoAvoid unnecessary test
John Darrington [Thu, 11 Aug 2016 19:26:51 +0000 (21:26 +0200)]
Avoid unnecessary test

7 years agoFix possible buffer overrun
John Darrington [Thu, 11 Aug 2016 19:19:36 +0000 (21:19 +0200)]
Fix possible buffer overrun

Found by cppcheck