1 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
3 Reduce platform dependence.
5 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
6 Everywhere we using this, we really should have just depended on
7 the shell to expand tildes.
8 (fn_search_path): Simplify, given that we don't do tilde expansion
10 (fn_normalize): Removed. Caller changed to use the canonicalize
12 (fn_get_cwd): Removed. Only user was fn_normalize.
13 (fn_is_absolute): Really only test for absolute names.
14 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
16 (fn_readlink): Removed, as it was only used fn_normalize.
17 (fn_exists): Assume the stat function is available; gnulib does.
18 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
20 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
22 * dictionary.c (dict_create_vector_assert): New function.
24 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
26 * file-name.c (fn_normalize): Correct name of function
27 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
28 for pointing this out.
30 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
32 We are using a single member in struct file_handle, the "name"
33 field, for more than one purpose. When it begins with '"', it's a
34 file name; otherwise, it's a token that can be used to identify
35 it. When that assertion fires, it's because we searched for the
36 name case-sensitively as a file name (so that there was no match),
37 and then we try to insert it case-insensitively as a token, which
38 fails because duplicates aren't allowed.
40 Solution: break the two purposes into two separate fields. This
41 fixes the problem and likely makes the code easier to read too.
43 Fixes bug #18922. Thanks to John Darrington for bug report and
46 * file-handle-def.c (struct file_handle): New `id' member.
47 (fh_from_name): Rename fh_from_id. Update all callers.
48 (create_handle): New `id' parameter. Update all callers.
49 (fh_create_file): Ditto.
50 (fh_get_id): New function.
52 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
54 * case.c (case_is_null): Change return type to bool.
56 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
60 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
61 reference counting to share data. This makes it easy for
62 valgrind, etc. to find accesses to cases that have been destroyed
63 but have been kept around by another user's ref-count. This often
64 happens when the data set is small enough to find in memory; if a
65 bigger data set that would overflow to disk were used, then data
66 corruption would occur.
68 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
72 * case.c (case_unshare): Make it check internally whether the
73 ref_cnt is greater than 1, so that the callers don't have to.
74 Update callers not to check.
76 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
78 Before, I was thinking that I might want to get rid of reference
79 counting at some point. Now, I'm pretty sure that it's here to
80 stay. Thus, because we have to store the value_cnt anyway for
81 reference-counted cases, we might as well expose it to users.
83 * case.c (case_get_value_cnt): New function.
84 (case_resize): Drop OLD_CNT argument. Update all callers. Only
85 resize case if its size actually changed.
87 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
88 instead of peeking inside struct case directly.
89 (casefile_append): Ditto.
91 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
93 Get rid of the inlines for the case functions, which made the
94 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
95 the inlines didn't speed up "make check" at all, which is not a
96 perfect benchmark but seems indicative.)
98 * case.c: Remove #ifdef DEBUGGING...#endif around many function
99 definitions. Remove some assertions on nonnull pointers that were
100 redundant with a pointer dereference soon after in the function.
102 (struct case_data): Move definition here from case.h.
106 (case_data_wr): Ditto.
108 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
110 * automake.mk: Add casedeque.h to sources.
112 * casedeque.h: New file.
114 * procedure.c: (struct dataset) Change lag_count, lag_head,
115 lag_queue member into single struct casedeque member. Update all
116 users to use the casedeque instead.
119 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
121 * procedure.c: Simplify lagged cases interface. Updated all
122 clients--well, the only client--to use the simplified interface.
123 (dataset_n_lag) Removed.
124 (dataset_set_n_lag) Removed.
125 (dataset_need_lag) New function.
127 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
129 * dictionary.c procedure.c: More changes to ensure that callbacks occur
130 whenever appropriate, but only when the dataset/dictionary is in a
133 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
135 * dictionary.c dictionary.h : Added callbacks for change of filter and
136 split variables. Refactored some code to ensure that callbacks get
137 invoked when appropriate.
139 * procedure.c (proc_cancel_temporary_transformations): Make sure that
140 replace_dict callback occurs when permanent_dict replaces the current
143 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
145 * dictionary.c dictionary.h : Added callback for when the weight
146 variable of a dictionary changes.
148 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
150 * dictionary.c dictionary.h : Added replace_source and replace_dict
151 callbacks, and functions to deal with them.
153 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
155 Simplify missing value handling.
157 * missing-values.h (enum mv_class): New type.
158 (enum mv_type): Moved definition into missing-values.c and renamed
159 each MV_* to MVT_*, to distinguish them from the exposed mv_class
160 enums. Updated all uses.
161 (struct missing_values): Changed type of `type' from `enum
162 mv_type' to `int' because the definition is no longer exposed.
164 * missing-values.c (mv_is_value_missing): Add new enum mv_class
165 parameter. Update all callers.
166 (mv_is_num_missing): Ditto.
167 (mv_is_str_missing): Ditto.
168 (mv_is_value_user_missing): Removed. Changed callers to use
170 (mv_is_num_user_missing): Removed. Changed callers to use
172 (mv_is_str_user_missing): Removed. Changed callers to use
174 (mv_is_value_system_missing): Removed. Changed callers to use
176 (mv_set_type): Removed. Changed callers to use mv_clear.
177 (mv_clear): New function.
179 * variable.c (var_is_value_missing): Add new enum mv_class
180 parameter. Update all callers.
181 (var_is_num_missing): Ditto.
182 (var_is_str_missing): Ditto.
183 (var_is_value_user_missing): Removed. Changed callers to use
184 var_is_value_missing.
185 (var_is_num_user_missing): Removed. Changed callers to use
187 (var_is_str_user_missing): Removed. Changed callers to use
189 (var_is_value_system_missing): Removed. Changed callers to use
190 var_is_value_missing.
192 * casefilter.c (struct casefilter): Use enum mv_class in place of
194 (casefilter_variable_missing): Adapt to new member.
195 (casefilter_create): Change signature to take enum mv_class,
198 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
200 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
202 * case-sink.c case-sink.h procedure.c procedure.h
203 storage-stream.c: Now uses the factory.
205 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
207 Make it possible to pull cases from the active file with a
208 function call, instead of requiring indirection through a callback
211 * case-source.h (struct case_source_class): Change ->read function
212 to return a single case, instead of calling a callback function
213 for each case. Change ->destroy function to return an error
216 * case-source.c (free_case_source): Pass along the value returned
217 by the case_source ->destroy function.
219 * procedure.c (struct write_case_data): Removed.
220 (struct dataset): Added some members to track procedure state.
221 (procedure): Optimize the trivial case at this level.
222 (internal_procedure): Re-implement in terms of proc_open,
223 proc_read, proc_close.
224 (proc_open) New function.
225 (proc_read) New function.
226 (proc_close) New function.
227 (write_case) Moved into proc_read.
228 (close_active_file) Moved closing of data source into proc_close.
230 * storage-source.c: Rewrote to conform with modified
231 case_source_class interface.
233 * transformations.c (trns_chain_execute): Added argument to allow
234 starting execution from an arbitrary transformation. Updated
237 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
239 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
241 * sys-file-reader.c (read_display_parameters): Don't assume that
242 MEASURE_* and ALIGN_* have the same values found in system files.
244 * sys-file-writer.c (write_variable_display_parameters): Ditto.
246 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
247 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
248 the value of n_MEASURES, which was off by 1 (at least from my
251 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
253 * dictionary.c dictionary.h vardict.h variable.c: Added optional
254 callbacks which are invoked when the dictionary or its
255 variables are changed.
257 * missing-values.c missing-values.h value-labels.c: Tidied up
258 consistency checks, and made some of them return false
259 instead of assert-failing.
261 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
263 * calendar.c (calendar_days_in_month): New function.
265 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
267 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
268 the value label's width.
270 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
272 * sfm-private.h: Move contents into sys-file-writer.c, which is
273 the only remaining user. Removed Borland C++-specific directives.
275 * sys-file-reader.c: Clean up and rewrite entire file. The
276 rewritten version is simpler and better abstracted, and should be
277 easier to maintain and extend. It avoids using structures to read
278 file data, which is prone to padding variations among compilers.
279 It should also handle non-IEEE 754 system files, although I
280 haven't been able to find any. It has been tested against many
281 .sav files obtained from the Web and found to produce the same
282 results as the earlier version of the code, or in some cases
283 improved results. It is more tolerant of format variations found
286 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
287 member, putting an enum integer_format in its place. New member
288 `float_format'. Changed `compressed' member to type bool.
290 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
292 * dictionary.c (dict_delete_consecutive_vars): New function.
294 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
296 * file-name.c (fn_search_path): Remove prefix arg that was unused
297 by any caller. Updated all callers.
299 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
301 * format.c (fmt_dollar_template): Use user's decimal point
302 character. Add assertion.
304 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
306 * format.c (fmt_dollar_template): New function, based on
307 dollar_format_template from var-type-dialog.c.
309 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
311 * data-out.c (output_scientific): Fix bad assumption that "buf" is
314 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
316 Finish converting struct variable to an opaque type. In this
317 phase, we add remaining setter and getter functions, convert the
318 remaining PSPP code to use them, and do a bunch of cleanup. The
319 resulting changes are pervasive but mostly trivial, and only the
320 notable changes are logged.
322 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
325 * case.c (case_data): Renamed case_data_idx.
326 (case_num): Renamed case_num_idx.
327 (case_str): Renamed case_str_idx.
328 (case_data_rw): Renamed case_data_rw_idx.
330 * case.h (case_data): New function with old name and an interface
331 that takes a variable instead of an index, which is easier to
332 use. Updated all callers to use the new interface, or to use the
333 new *_idx function (see above).
336 (case_data_rw): Ditto.
338 * category.c (cat_stored_values_destroy): Changed interface to
339 take a struct cat_vals * instead of a struct variable *.
341 * dictionary.c (dict_clone): Use new vector_clone function.
342 (dict_clear) Use new var_destroy function.
343 (add_var) New function.
344 (dict_create_var) Rewrite in terms of dict_create_var_assert.
345 (dict_create_var_assert) Rewrite in terms of add_var.
346 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
347 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
348 (dict_lookup_var) Use new var_create, var_destroy functions.
349 (dict_contains_var) Rewrite in terms of new vardict functionality.
350 (set_var_dict_index) New function.
351 (set_var_case_index) New function.
352 (reindex_vars) New function.
353 (dict_delete_var) Rewrite in terms of new vardict functionality.
354 (dict_reorder_var) Ditto.
355 (dict_reorder_vars) Ditto.
356 (rename_var) New function.
357 (dict_rename_var) Use rename_var.
358 (dict_rename_vars) Use pool to simplify code. Use rename_var.
359 (dict_get_compacted_idx_to_fv) Rename
360 dict_get_compacted_dict_index_to_case_index, update callers.
361 (dict_create_vector) Use new vector_create function.
362 (dict_clear_vectors) Use new vector_destroy function.
363 (set_var_short_name_suffix) Move here from variable.c, renamed
364 from var_set_short_name_suffix, make static, update caller.
366 * sys-file-private.c: New file.
367 (sfm_width_to_bytes) Moved here from variable.c, renamed from
368 width_to_bytes, update callers.
370 * sys-file-private.h: New file. Later it will supplant
371 sfm-private.h; for now it supplements it.
372 (macro MIN_VERY_LONG_STRING) New macro.
373 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
375 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
376 MAX_LONG_STRING was used before.
378 * sys-file-writer.c: Ditto.
380 * value-labels.c: Change the paradigm here to be that a null
381 pointer is OK for a struct val_labs * in most cases; it just
382 represents an empty set of value labels.
383 (val_labs_copy) A copy of a null set is a null set.
384 (val_labs_count) A null set has 0 labels.
385 (val_labs_replace) Change return type to void. Rewrite for
387 (val_labs_find) A null set does not contain the value.
388 (value_to_string) Moved to variable.c, renamed var_get_value_name,
389 transposed argument order, updated all callers.
392 (value_dup) Moved here from variable.c.
393 (compare_values) Ditto.
396 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
397 (macro MAX_LONG_STRING) Removed, because it was only interesting
398 for system files, not for general code.
399 (macro MAX_VERY_LONG_STRING) Ditto.
400 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
401 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
403 * vardict.h: New file, for an interface between variables and
406 * variable.c: A lot of functions were moved around, for better
408 (struct variable) Move definition here, from variable.h.
409 (var_type_adj) Removed--makes i18n hard.
410 (var_type_noun) Ditto.
411 (var_create) New function.
412 (var_clone) New function.
413 (var_destroy) New function.
414 (var_set_name) Assert that variable is not in a dictionary.
415 (compare_var_names) Rename compare_vars_by_name and fix a couple
416 of callers who thought the args were strings.
417 (hash_var_name) Rename hash_var_by_name.
418 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
419 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
420 (var_is_very_long_string) Removed, because it was only interesting
422 (var_set_missing_values) Allow the argument to be the wrong width,
423 as long as we can resize it. Simplify callers who were doing the
425 (var_get_value_labels) New function.
426 (var_has_value_labels) New function.
427 (var_set_value_labels) New function.
428 (alloc_value_labels) New function.
429 (var_add_value_label) New function.
430 (var_replace_value_label) New function.
431 (var_clear_value_labels) New function.
432 (var_lookup_value_label) New function.
433 (var_get_value_name) Moved here from variable.c, renamed from
434 var_get_value_name, transposed argument order, updated all
436 (var_to_string) Moved here, from variable-label.c.
437 (var_set_leave) New function.
438 (var_get_leave) New function.
439 (var_must_leave) New function.
440 (var_set_short_name_suffix) Moved to dictionary.c, renamed
441 set_var_short_name_suffix.
442 (var_get_dict_index) New function.
443 (var_get_case_index) New function.
444 (var_get_obs_vals) New function.
445 (var_set_obs_vals) New function.
446 (var_has_obs_vals) New function.
447 (var_get_vardict) New function.
448 (var_set_vardict) New function.
449 (var_has_vardict) New function.
450 (var_clear_vardict) New function.
451 (value_dup) Moved to value.c.
452 (compare_values) Ditto.
455 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
456 (enum ALPHA) Rename VAR_STRING, update all users.
458 * vector.c: New file.
459 (struct vector) Moved here, from variable.h.
460 (check_widths) New function.
461 (vector_create) New function.
462 (vector_clone) New function.
463 (vector_destroy) New function.
464 (vector_get_name) New function.
465 (vector_get_var) New function.
466 (vector_get_var_cnt) New function.
467 (compare_vector_ptrs_by_name) New function.
469 * vector.h: New file.
471 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
473 * casefilter.c (casefilter_variable_missing): Avoided comparision of
474 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
477 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
479 * value-labels.c (destroy_atoms): New function.
480 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
482 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
484 Thanks to Jason Stover for pointing out this problem.
486 * data-out.c (output_number): Use gsl_finite from GSL, which is
487 portable, instead of isfinite, which is not.
490 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
492 * variable.c variable.h (value_dup): New function.
494 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
496 Start converting struct variable to an opaque type. In this
497 phase, we add a bunch of setter and getter functions and convert
498 most of the PSPP code to use them. The resulting changes are
499 pervasive but mostly trivial, and only the notable changes are
502 * format.c (fmt_equal): New function.
504 * variable.c (var_type_is_valid): New function.
505 (measure_is_valid) Moved here, from format.c.
506 (alignment_is_valid) Moved here, from format.c.
507 (var_get_name) New function.
508 (var_set_name) New function.
509 (width_to_type) New function.
510 (var_get_type) New function.
511 (var_get_width) New function.
512 (var_set_width) New function.
513 (var_is_numeric) New function.
514 (var_is_alpha) New function.
515 (var_is_short_string) New function.
516 (var_is_long_string) New function.
517 (var_is_very_long_string) New function.
518 (var_get_missing_values) New function.
519 (var_set_missing_values) New function.
520 (var_clear_missing_values) New function.
521 (var_has_missing_values) New function.
522 (var_is_value_missing) New function.
523 (var_is_num_missing) New function.
524 (var_is_str_missing) New function.
525 (var_is_value_user_missing) New function.
526 (var_is_num_user_missing) New function.
527 (var_is_str_user_missing) New function.
528 (var_is_value_system_missing) New function.
529 (var_get_print_format) New function.
530 (var_set_print_format) New function.
531 (var_get_write_format) New function.
532 (var_set_write_format) New function.
533 (var_set_both_formats) New function.
534 (var_get_label) New function.
535 (var_set_label) New function.
536 (var_clear_label) New function.
537 (var_has_label) New function.
538 (var_get_measure) New function.
539 (var_set_measure) New function.
540 (var_get_display_width) New function.
541 (var_set_display_width) New function.
542 (var_get_alignment) New function.
543 (var_set_alignment) New function.
544 (var_get_value_cnt) New function.
545 (var_get_leave) New function.
546 (var_get_short_name) New function.
548 * variable.h: (struct variable) Removed "type" and "nv" members;
549 they are now computed from "width" where needed.
551 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
553 * missing-values.c (mv_resize): Don't write beyond end of the
554 allocated buffer when resizing a long string.
556 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
558 Clean up identifier code: don't require identifier enumerations to
559 be in a particular order; make better use of string library;
560 expose less of the internals.
562 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
563 change interface. Updated all callers.
564 (lex_id_match) Change interface to use struct substring, update
566 (lex_id_match_len) Removed. Update callers to use lex_id_match.
567 (global array keywords[]) Make static, change form. Update all
568 users to use lex_id_name instead.
569 (lex_is_keyword) New function.
570 (lex_id_to_token) Change interface to use struct substring, update
572 (lex_id_name) New function.
574 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
575 lex_is_keyword instead.
576 (T_LAST_KEYWORD) Removed.
577 (T_N_KEYWORDS) Removed.
579 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
581 * format.c: (fmt_date_template) Distinguish characters for which a
582 space is output and any date delimiter is allowed on input, from
583 those for which a space is output and only a space is allowed on
584 input. The former is represented by X, the latter by a space.
585 Also, drop distinction between h and H, changing the former to the
588 * data-in.c: Completely rewrite internals to conform to SPSS input
589 formats as closely as possible.
590 (data_in) Changed external interface by replacing the structure
591 that was used as a single argument by a set of arguments. Updated
593 (data_in_finite_line) Removed. Converted all callers to use plain
595 (data_in_get_integer_format) New function.
596 (data_in_set_integer_format) New function.
597 (data_in_get_float_format) New function.
598 (data_in_set_float_format) New function.
600 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
601 (struct data_in) Removed.
603 * data-out.c: (output_date) Drop each component from the input as
604 it is output, to allow us to drop the distinction between h (a
605 count of hours) and H (the hour of day) template characters.
606 Also, handle new X template character.
607 (output_scientific) Follow more rational rule on when to drop
608 fraction introduced between SPSS 13 and 15. Updated test case to
611 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
613 Fix buffer overflow reported by John Darrington.
615 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
616 realize that DIGITS is a count of nibbles, not of bytes.
618 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
620 * calendar.c (calendar_offset_to_gregorian) Also return the
621 year-of-day. Change callers to new interface.
623 * data-out.c: Completely rewrite internals to conform to SPSS
624 output formats as completely as possible.
625 (data_out) Change interface to put input parameters before output
626 parameters, for consistency with the style I now prefer. Update
628 (data_out_get_integer_format) New public function.
629 (data_out_set_integer_format) New public function.
630 (data_out_get_float_format) New public function.
631 (data_out_set_float_format) New public function.
633 * data-out.h: New file. Move prototype for data_out here, from
636 * format.c: (fmt_step_width) Use equality comparison instead of
637 bitwise and, for clarity.
638 (fmt_is_string) Ditto.
639 (fmt_input_to_output) Fix categories that are translated to F
642 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
644 * casefilter.c casefilter.h (new files), casefile.c casefile.h
645 casefile-private.h: Added casefilter to assist commands with missing
648 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
650 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
652 * settings.c: (route_errors_to_terminal) New variable.
653 (route_errors_to_listing) New variable.
654 (get_error_routing_to_terminal) New function.
655 (set_error_routing_to_terminal) New function.
656 (get_error_routing_to_listing) New function.
657 (set_error_routing_to_listing) New function.
659 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
661 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
663 * format.c: Completely rewrite, to achieve better abstraction.
664 Rewrite all references to formats in other files.
666 * format.def: Rewrite and reorganize.
668 * settings.c: Move everything related to custom currency formats
669 into format.[ch], changing them in form, so as to group related
670 code and definitions better. Changed all references to use the
672 (static var decimal) Removed.
673 (static var grouping) Removed.
674 (static var cc) Removed.
675 (get_decimal) Removed.
676 (set_decimal) Removed.
677 (get_grouping) Removed.
678 (set_grouping) Removed.
682 * settings.h: (macro CC_CNT) Removed.
683 (macro CC_WIDTH) Removed.
684 (struct custom_currency) Removed.
686 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
688 * data-in.c (data_in): Use switch statement instead of table, to
689 avoid dependence on the order of the FMT_* enums.
691 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
693 * data-out.c: (num_to_string) Removed, because it was dead code.
695 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
697 * data-in.c (parse_trailer): Fix error message.
699 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
701 * format.c (fmt_is_binary): New function.
703 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
705 * procedure.c procedure.h: Encapsulated the static data into a single
708 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
710 * casefile.c (casereader_read_xfer): Always initialize the case,
711 even on an error condition.
713 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
715 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
716 entire function useless.
718 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
720 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
721 casereader method casereader_clone.
723 * procedure.c pransformations.h: Introduced new type casenum_t
725 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
727 * variable.c: (width_to_bytes) Rephrase code for clarify.
729 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
731 * format.c: (fmt_type_from_string) New function.
732 (fmt_to_string) Include decimals in output if the format has
733 decimals, even if the format type does not. This way, we can
734 accurately reproduce incorrect formats in user output.
735 (check_common_specifier) Make the check for a bad format type an
736 assertion, so we get bug reports if they show up. Fix message.
737 Check for decimal places with a format type that doesn't allow
739 (check_input_specifier) Remove check for FMT_X, which has been
741 (check_output_specifier) Ditto.
743 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
745 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
746 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
747 (enum fmt_parse_flags) Removed.
749 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
751 * casefile.c casefile.h: Converted to an abstract base class.
752 * casefile-private.h fastfile.c fastfile.h: New files.
753 * automake.mk procedure.c scratch-writer.c storage-stream.c
755 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
757 * procedure.c (internal_procedure): Create sink_case with only as
758 many values as the compacted dictionary.
760 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
762 Remove "debugging" code that caused plenty of false positives and
765 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
767 * case.c: Remove all references to `this' member.
769 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
771 Fix link error noted by Jason Stover.
773 * storage-stream.c: Include <assert.h>.
775 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
777 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
778 ALL) and additional underlying system file issues.
780 Thanks to John Darrington for review.
782 First problem: var_hash points to variables not owned by the
783 sys-file-reader, which the caller may free or modify. Use an
784 array of sfm_vars instead, as done earlier (e.g. CVS version
787 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
788 members and remove all code that references it. Add vars, var_cnt
789 members. Remove fix_specials member, which was unused.
790 (struct sfm_var) Remove name member, which was unused.
791 (sfm_close_reader) Free vars member instead of var_hash.
792 (compare_var_shortnames) Removed.
793 (hash_var_shortname) Removed.
794 (sfm_open_reader) Fill out vars array.
795 (compare_var_index) Removed.
796 (sfm_read_case) Use vars instead of var_hash.
798 Second problem: we're confused about when we actually have very
799 long strings, causing us to choose incorrectly between slow path
800 and fast path in sfm_read_case.
802 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
803 have very long strings, not when we have long variable names,
804 which is an unrelated feature.
806 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
808 * variable.h: Move var_set and variable parsing declarations to
809 new header, src/language/lexer/variable-parser.h. Modified lots
810 of files to include the new header.
812 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
814 * value-labels.c (value_to_string): When there's no value label,
815 format the variable according to its print format, instead of
816 always effectively using A or F format.
818 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
820 * casefile.c (casefile_get_random_reader): Nasty hack to get around
823 * format.c: Removed tortological assertion.
825 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
827 Reform string library.
829 * file-name.c (fn_interp_vars): Change interface to take a
830 substring as input. Updated all users.
832 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
834 * format.c (measure_is_valid): Really return false when m >=
837 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
839 Implement random access to casefiles, for use in GUI.
841 * casefile.c: (struct casereader) Add `random', `file_ofs',
842 `buffer_ofs' members.
843 (casefile_get_random_reader) New function.
844 (read_open_file) Break part into new function
845 seek_and_fill_buffer().
846 (fill_buffer) Update buffer_ofs, file_ofs.
847 (casereader_seek) New function.
849 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
851 * settings.c: Added call to i18n{done, init}.
853 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
855 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
858 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
860 * casefile.c: Convert many uses of `int' to `bool'.
862 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
864 * transformations.c (trns_chain_destroy): Destroy chain's trns
865 member, to fix memory leak.
867 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
869 * storage-stream.c (storage_source_decapsulate): Destroy case
870 source to fix memory leak.
872 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
874 * scratch-reader.c (scratch_reader_read_case): Copy into existing
875 case passed as argument instead of initializing the argument as a
876 case. Fixes memory leak that showed up in
877 tests/command/aggregate.sh with scratch files.
879 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
881 * procedure.c (proc_done): Destroy default_dict, to fix memory
884 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
886 Simplify procedure_with_splits().
888 * procedure.c (struct split_aux_data): Removed case_count member.
889 (procedure_with_splits) Don't initialize case_count.
890 (split_procedure_case_func) Check whether prev_case is null
891 instead of case_count.
892 (split_procedure_end_func) Ditto.
894 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
896 * case.c (case_move): Do nothing if dst and src are the same
898 (case_try_create) Merge two similar cases.
899 (case_copy) Unshare only if data must be actually copied.
901 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
903 * data-in.c data-out.c dictionary.c sys-file-reader.c
904 sys-file-writer.c variable.c variable.h: Reworked very long string
905 support for better encapsulation.
907 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
909 * value-labels.c (val_labs_can_set_width): New function.
910 (val_labs_set_width) Clear labels if increasing width to long
912 (val_labs_destroy) Remove unneeded test for null.
914 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
916 * value-labels.h: Remove unneeded dependency on variable.h.
918 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
920 Get rid of `char *c' member in union value, for cleanliness.
922 * value.h: (union value) Remove `c' member.
924 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
926 Make dictionary compacting functions a little more general.
928 * sys-file-writer.c (sfm_open_writer): Use
929 dict_compacting_would_change().
930 (does_dict_need_translation) Removed.
932 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
934 Make dictionary compacting functions a little more general.
936 * dictionary.c (dict_needs_compaction): Rename
937 dict_compacting_would_shrink(). Update all callers.
938 (dict_compacting_would_change) New function.
940 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
942 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
943 inverted return value (!).
945 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
947 Continue reforming procedure execution.
949 * procedure.c: Search and replace "vfm" by "proc". Notably:
950 (static var vfm_source) Rename proc_source. Update all
952 (static var vfm_sink) Rename proc_sink. Update all references.
954 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
956 Continue reforming procedure execution. In this phase, remove
957 PROCESS IF, which was deprecated anyway and can be easily
958 simulated with TEMPORARY followed by SELECT IF.
960 * procedure.c: (open_active_file) Don't call
961 add_process_if_trns().
962 (discard_variables) Get rid of redundant call to
963 proc_cancel_all_transformations().
964 (add_process_if_trns) Removed.
965 (process_if_trns_proc) Removed.
966 (process_if_trns_free) Removed.
968 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
970 Continue reforming procedure execution. In this phase, add
971 `const' to the case passed to procedure()'s callback.
973 Updated all users of procedure() as well.
975 * procedure.c: (struct write_case_data) Add "const" to ccase
976 parameter for case_func member.
977 (procedure) Add "const" to ccase parameter for proc_func
979 (multipass_case_func) Make ccase parameter const.
980 (internal_procedure) Add "const" to ccase parameter for case_func
982 (split_procedure_case_func) Make ccase parameter const.
983 (multipass_split_case_func) Make ccase parameter const.
985 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
987 Continue reforming procedure execution. In this phase, get rid of
988 the output code for SPLIT FILE groups in procedure.c, which really
989 shouldn't be doing any output. Move it into the individual
990 procedures instead. This also adds some flexibility.
992 Updated many users of procedure_with_splits() and
993 multipass_procedure_with_splits() to call
994 output_split_file_values() and to deal with increased use of
997 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
998 parameter to begin_func member.
999 (procedure_with_splits) Add "const struct ccase *" parameter to
1000 begin_func parameter. Make ccase parameter const in proc_func
1002 (split_procedure_case_func) Don't dump split file group. Pass
1004 (dump_splits) Moved to language/dictionary/split-file.c as
1005 output_split_file_values().
1006 (struct multipass_split_aux_data) Add "const struct ccase *"
1007 parameter to split_func member.
1008 (multipass_procedure_with_splits) Add "const struct ccase *"
1009 parameter to split_func parameter.
1010 (multipass_split_case_func) Save new SPLIT FILE case before
1012 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1014 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1016 Continue reforming procedure execution. Change
1017 internal_procedure() so that it calls open_active_file() and
1018 close_active_file(), which isolates most of the actual procedure
1021 * procedure.c: (struct write_case_data) Rename `proc_func' member
1022 to `case_func' and update all references.
1023 (procedure) Rewrite as one-line wrapper around
1024 internal_procedure().
1025 (struct multipass_aux_data) New.
1026 (multipass_callback) Renamed multipass_case_func(). Use struct
1027 multipass_aux_data as auxiliary data.
1028 (multipass_end_func) New function.
1029 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1030 that uses multipass_case_func, multipass_end_func.
1031 (internal_procedure) Add `end_func' argument. Move optimization
1032 of trivial case in here. Move call to open_active_file() and
1033 close_active_file() in here. Now assert that vfm_source is
1035 (procedure_with_splits_callback) Rename
1036 split_procedure_case_func().
1037 (split_procedure_end_func) New function.
1038 (multipass_split_callback) Rename multipass_split_case_func.
1039 (multipass_split_end_func) New function.
1040 (discard_variables) No need to test for nonnull vfm_source.
1042 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1044 Continue reforming procedure execution. Get rid of unused member.
1046 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1048 (write_case) Don't increment cases_analyzed.
1050 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1052 Continue reforming procedure execution. In this phase, move
1053 procedure.c and procedure.h from src to src/data. Update
1054 makefiles and #includes accordingly.
1056 * procedure.c: Moved here from src/.
1058 * procedure.h: Moved here from src/.
1060 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1062 Continue reforming procedure execution. In this phase, get rid of
1063 many global variables, consolidating procedure execution in
1064 procedure.c. Encapsulate transformations in new "struct
1065 trns_chain". Also, change implementation of N OF CASES, FILTER,
1066 and PROCESS IF from special cases to transformations.
1068 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1071 * dictionary.c: (global variable default_dict) Move to
1074 * variable.h: (TRNS_*) Move to transformations.h.
1075 (struct transformation) Move to transformations.c.
1077 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1079 * sys-file-reader.c: Fixed invalid read problems.
1081 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1083 * storage-stream.c: Add missing function comments.
1085 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1087 Continue reforming procedure execution. In this phase, add some
1088 new, needed functionality to storage-stream.
1090 * storage-stream.c: (storage_source_decapsulate) New function.
1092 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1094 * variable.c (width_to_bytes): Declarations must precede
1095 statements for C90 compliance.
1097 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1099 * data-out.c, data-in.c, variable.c, variable.h: New functions
1100 copy_mangle and copy_demangle for reading/writing cases; emulates the
1101 way SPSS deals with strings > 255 bytes.
1103 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1104 subtype 14 needed for strings longer than 255 bytes.
1106 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1107 instead of literal values. Also fixed some constness issues.
1109 * format.h: Constness
1111 * sfm-private.h: Renamed the case_size identifier, since I discovered
1112 that SPSS's respect for this variable is very nominal.
1114 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1116 Change case limit type from int to size_t.
1118 * dictionary.c: (struct dictionary) Change type of case_limit
1120 (dict_get_case_limit) Change return type.
1121 (dict_set_case_limit) Change parameter type.
1123 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1125 * variable.h: (struct variable) Rename `reinit' member as `leave'
1126 and invert sense. Fix up all references.
1128 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1130 Continue reforming procedure execution. In this phase, break
1131 procedure.c into multiple files.
1133 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1135 * case-sink.c: New file.
1137 * case-sink.h: New file.
1139 * case-source.c: New file.
1141 * case-source.h: New file.
1143 * storage-stream.c: New file.
1145 * storage-stream.h: New file.
1147 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1149 * variable.h: (struct variable) Remove `init' member and all
1150 references to it from other files. It was initialized in several
1151 places, but nothing really ever used it for anything worthwhile.
1152 Thanks to Jason Stover for pointing out how confusing this
1155 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1157 Continue reforming error message support. In this phase, get rid
1158 of message "titles" and put the message text in `struct error'.
1159 Now `struct error' encapsulates a message more properly.
1161 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1162 Format message ourselves.
1164 * data-in.c: (vdls_error) Ditto.
1166 * por-file-reader.c: (error) Ditto.
1168 * sys-file-reader.c: (corrupt_msg) Ditto.
1170 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1172 GNU standards require "file name" instead of "filename" in
1173 documentation. It's nice for our code to follow the convention
1176 * casefile.c: (struct casefile) Rename `filename' member to
1177 `file_name'. Updated all references.
1179 * file-name.c: [!unix] (struct file_identity) Rename
1180 normalized_filename member to normalized_file_name. Updated all
1183 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1185 We don't really support anything but Unix-like environments well,
1186 so we might as well de-obfuscate by writing directory and path
1187 separators explicitly.
1189 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1191 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1192 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1194 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1197 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1199 GNU standards require "file name" instead of "filename" in
1200 documentation. It's nice for our code to follow the convention
1203 * filename.c: Rename to file-name.c.
1205 * filename.h: Rename to file-name.h. Update all inclusions.
1206 Update header guards.
1208 * automake.mk: Update file names.
1210 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1212 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1214 (fn_basename) Removed (dead code).
1215 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1216 (fn_special_p) Renamed fn_is_special(), all references updated.
1217 (fn_exists_p) Renamed fn_exists(), all references updated.
1219 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1221 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1222 Also, now it only tilde-expands file names, not paths.
1223 (fn_search_path) Tilde-expand one directory at a time.
1225 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1227 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1228 get rid of non-Unixlike version of the code, which has probably
1230 (fn_prepend_dir) Removed (dead code).
1232 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1233 (macro PATH_SEPARATOR_STRING) New.
1234 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1236 Continue reforming error message support. In this phase, we get
1237 rid of VM() and the other msg() support for "verbosity", replacing
1238 it by a new function verbose_msg().
1240 * filename.c: (fn_search_path) Use verbose_msg() instead of
1243 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1245 * sfm-private.h: Get rid of #defines after #error, which makes no
1248 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1250 Get rid of our own int32 type in favor of the standard int32_t
1253 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1256 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1258 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1260 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1262 Remove ill-considered file routines that are no longer used.
1264 * filename.c: (fn_open_ext) Removed.
1265 (fn_close_ext) Removed.
1267 * filename.h: (struct file_ext) Removed.
1269 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1271 * variable.c (var_is_valid_name): Move declarations before code
1274 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1276 * filename.ch (fn_interp_vars): Fixed small buglet.
1278 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1280 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1281 so as to modify the string inline. Thus makeing it easier to
1282 destroy the results when no longer needed.
1284 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1286 * category.c (cat_stored_values_destroy): Fixed memory leak.
1288 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1290 Add some missing frees. Thanks to John Darrington for reporting
1293 * any-writer.c (any_writer_close): Free writer.
1295 * any-reader.c (any_reader_close): Free reader.
1297 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1299 * por-file-reader.c: (error) Mark as NO_RETURN.
1301 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1303 * settings.c: Changed default value of scompress to true.
1305 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1307 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1309 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1312 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1313 here from pref.h.orig.
1315 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1317 * sys-file-reader.c: Fixed bug reading compressed files.
1319 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1321 * Numerous renames. See src/ChangeLog for details.
1323 * Moved files from src directory