1 2007-11-03 John Darrington <john@darrington.wattle.id.au>
3 * gnumeric-reader.c gnumeric-reader.h: New files.
5 Thu May 4 21:47:48 2006 Ben Pfaff <blp@gnu.org>
7 Continue reforming procedure execution. In this phase, move
8 procedure.c and procedure.h from src to src/data. Update
9 makefiles and #includes accordingly.
11 * automake.mk: Remove special rule for src/procedure.o.
13 * procedure.c: Moved to src/data.
15 * procedure.h: Moved to src/data.
17 Wed May 3 22:24:34 2006 Ben Pfaff <blp@gnu.org>
19 Continue reforming procedure execution. In this phase, get rid of
20 many global variables, consolidating procedure execution in
21 procedure.c. Encapsulate transformations in new "struct
22 trns_chain". Also, change implementation of N OF CASES, FILTER,
23 and PROCESS IF from special cases to transformations.
25 * procedure.c: (global var vfm_source) Make static. Changed
26 external references to use in_input_program(), proc_set_source(),
27 or proc_capture_output() instead.
28 (global var vfm_sink) Make static. Changed external references to
29 use proc_set_sink() instead.
30 (global var default_dict) Move here from data/dictionary.c.
31 (static var permanent_trns_chain) New var.
32 (static var temp_dict) Renamed permanent_dict, updated references.
33 (static var temporary_trns_chain) New var.
34 (static var cur_trns_chain) New var.
35 (static var in_procedure) Removed.
36 (global var t_trns) Removed.
37 (global var n_trns) Removed.
38 (global var m_trns) Removed.
39 (global var f_trns) Removed.
40 (procedure) Even if there's "nothing to do" we need to clear
41 PROCESS IF, N OF CASES, vector state. (This should be
43 (multipass_callback) New function.
44 (multipass_procedure) New function.
45 (open_active_file) Add N OF CASES, FILTER, PROCESS IF
46 transformations. Finalize transformations. No need to call
47 ctl_stack_clear() anymore because finalizers will do that.
48 (write_case) Simplify and rewrite.
49 (execute_transformations) Removed.
50 (filter_case) Removed.
51 (close_active_file) Use proc_cancel_temporary_transformations().
52 No need to clear PROCESS IF, N OF CASES here anymore because
54 (multipass_procedure_with_splits) Keep track of success.
55 (multipass_split_callback) Ditto.
56 (multipass_split_output) Ditto.
57 (discard_variables) No need to call ctl_stack_clear() anymore
58 because finalizers will do that.
59 (proc_capture_transformations) New function.
60 (add_transformation) Rewrite in terms of trns_chain_append().
61 (add_transformation_with_finalizer) New function.
62 (next_transformation) Rewrite in terms of trns_chain_next().
63 (proc_in_temporary_transformations) New function.
64 (proc_start_temporary_transformations) New function.
65 (proc_make_temporary_transformations_permanent) New function.
66 (proc_cancel_temporary_transformations) New function.
67 (cancel_transformations) Rename proc_cancel_all_transformations(),
68 rewrite in terms of trns_chain_destroy().
69 (proc_init) New function.
70 (proc_done) New function.
71 (proc_set_sink) New function.
72 (proc_set_source) New function.
73 (proc_has_source) New function.
74 (proc_capture_output) New function.
75 (add_case_limit_trns) New function.
76 (case_limit_trns_proc) New function.
77 (case_limit_trns_free) New function.
78 (add_filter_trns) New function.
79 (filter_trns_proc) New function.
80 (add_process_if_trns) New function.
81 (process_if_trns_proc) New function.
82 (process_if_trns_free) New function.
84 Wed Apr 26 20:00:00 2006 Ben Pfaff <blp@gnu.org>
86 * procedure.c (create_trns_case): Fix inverted decision on whether
87 numeric values should be initialized to 0 or SYSMIS.
89 Wed Apr 26 19:48:52 2006 Ben Pfaff <blp@gnu.org>
91 Continue reforming procedure execution. In this phase, assert
92 that add_transformation() is not called during procedure
93 execution. Thanks to John Darrington for the suggestion.
95 * procedure.c: (static var in_procedure) New var.
96 (internal_procedure) Get rid of recursive_call local var and
98 (open_active_file) Set in_procedure and make sure it wasn't
100 (close_active_file) Reset in_procedure and make sure it was
102 (add_transformation) Make sure we're not in a procedure.
104 Wed Apr 26 19:33:52 2006 Ben Pfaff <blp@gnu.org>
106 Continue reforming procedure execution. In this phase, break
107 procedure.c into multiple files.
109 * procedure.c (vfm_last_invocation): Rename
110 time_of_last_procedure(). Update all references.
111 (struct storage_stream_info) Move to data/storage-stream.c.
112 (storage_sink_open) Ditto.
113 (destroy_storage_stream_info) Ditto.
114 (storage_sink_write) Ditto.
115 (storage_sink_destroy) Ditto.
116 (storage_sink_make_source) Ditto.
117 (var storage_sink_class) Ditto.
118 (storage_source_count) Ditto.
119 (storage_source_read) Ditto.
120 (storage_source_destroy) Ditto.
121 (storage_source_class) Ditto.
122 (storage_source_get_casefile) Ditto.
123 (storage_source_create) Ditto.
124 (null_sink_class) Move to data/case-sink.c.
125 (create_case_source) Move to data/case-source.c.
126 (free_case_source) Ditto.
127 (case_source_is_class) Ditto.
128 (create_case_sink) Move to data/case-sink.c.
129 (free_case_sink) Ditto.
131 * procedure.h: (struct case_source) Move to data/case-source.h.
132 (struct case_source_class) Ditto.
133 (struct case_sink) Move to data/case-sink.h.
134 (struct case_sink_class) Ditto.
136 Thu Apr 27 09:28:25 WST 2006 John Darrington <john@darrington.wattle.id.au>
138 * automake.mk: Removed explicit dependencies for message.o, since
139 that module no longer exists.
141 Wed Apr 26 15:29:45 2006 Ben Pfaff <blp@gnu.org>
143 Start reforming procedure execution. In this phase, get rid of
144 function prototypes for never-defined functions.
146 * procedure.h: Get rid of function prototypes for never-defined
149 Wed Apr 26 12:58:46 2006 Ben Pfaff <blp@gnu.org>
151 Improve the way we handle the various parsing "states". Until now
152 we've hard-coded the state transitions in the command definition
153 file, but that's error-prone and, worse, it's redundant--we can
154 figure out what state we're in anyhow. We can cleanly handle
155 INPUT PROGRAM and FILE TYPE with a nested command-processing loop.
157 * procedure.c (case_source_is_complex): Removed.
158 (discard_variables) No need to set pgm_state anymore.
160 Tue Apr 25 11:06:49 2006 Ben Pfaff <blp@gnu.org>
162 Finish reforming error message support. In this phase, move
163 message.c into libpspp.
165 * message.c: Move to libpspp.
167 Tue Apr 25 10:47:37 2006 Ben Pfaff <blp@gnu.org>
169 Continue reforming error message support. In this phase, drop
170 actual message printing from core code, substituting a callback,
171 and add the callback to each UI. Also, move verbose_msg() into
174 * message.c: (var err_error_count) Renamed error_count and moved
175 to ui/terminal/msg-ui.c.
176 (var err_warning_count) Renamed warning_count and moved to
177 ui/terminal/msg-ui.c.
178 (err_check_count) Renamed check_msg_count() and moved to
179 ui/terminal/msg-ui.c.
180 (dump_message) Rewrote to take stream instead of function pointer
181 and moved to ui/terminal/msg-ui.c.
182 (msg_emit) Moved its guts to ui/terminal/msg-ui.c as handle_msg()
183 and rewrote to just pass message to callback.
185 (var err_verbosity) Renamed "verbosity" and moved to
186 libpspp/verbose-msg.c.
187 (verbose_msg) Moved to libpspp/verbose-msg.c.
189 (var err_already_flagged) Removed.
190 (puts_stdout) Removed.
192 (var msg_handler) New static variable.
193 (msg_init) New function.
194 (msg_get_command_name) New function.
196 Mon Apr 24 17:40:08 2006 Ben Pfaff <blp@gnu.org>
198 Continue reforming error message support. In this phase, rename
199 all the message functions and types to start with "msg", except
200 for the ones that will be moving to other modules anyway.
202 All references to the identifiers below were updated likewise.
204 * message.c: (err_done) Renamed msg_done().
205 (err_push_file_locator) Renamed msg_push_msg_locator().
206 (err_pop_file_locator) Renamed msg_pop_msg_locator().
207 (err_location) Renamed msg_location().
208 (err_set_command_name) Renamed msg_set_command_name().
210 Mon Apr 24 14:11:33 2006 Ben Pfaff <blp@gnu.org>
212 * message.c: Use exit.h from gnulib instead of checking for and
213 defining EXIT_SUCCESS and EXIT_FAILURE by hand.
215 Sun Apr 23 22:00:23 2006 Ben Pfaff <blp@gnu.org>
217 Continue reforming error message support. In this phase, get rid
218 of message "titles" and put the message text in `struct error'.
219 Now `struct error' encapsulates a message more properly.
221 * message.c: (tmsg) Removed.
222 (msg) Use err_msg() instead of err_vmsg(). Format message
224 (err_vmsg) Renamed err_msg(). Changed interface, dropping message
225 and va_list args which are now in the error struct.
227 Sun Apr 23 20:35:28 2006 Ben Pfaff <blp@gnu.org>
229 Continue reforming error message support.
231 * message.c: Use linebreak module from gnulib instead of home-brew
233 (puts_stdout) Rewrote.
234 (dump_message) Rewrote. Changed interface and updated all callers.
235 (compulsory_break) Removed.
236 (char_is_break) Removed.
237 (break_before) Removed.
238 (break_after) Removed.
239 (macro BREAK_LONG_WORD) Removed.
241 Sun Apr 16 20:41:10 2006 Ben Pfaff <blp@gnu.org>
243 Continue reforming error message support. In this phase, we
244 divide the classification of messages along "category" and
247 * message.c: (err_vmsg) Rewrite to deal with categories and
248 severities in a straightforward manner instead of mixing them into
250 [0] (puts_stderr) Removed (dead code).
251 (msg) Changed first argument from `int' to `enum msg_class'.
254 Sun Apr 16 18:53:12 2006 Ben Pfaff <blp@gnu.org>
256 GNU standards require "file name" instead of "filename" in
257 documentation. It's nice for our code to follow the convention
260 Basically did search and replace in the whole source tree. Major
261 changes in function names or struct member names have their own
264 Sun Apr 16 15:58:56 2006 Ben Pfaff <blp@gnu.org>
266 Continue reforming error message support. In this phase, we get
267 rid of VM() and the other msg() support for "verbosity", replacing
268 it by a new function verbose_msg().
270 * message.c: (verbose_msg) New function.
271 (err_vmsg) Remove support for verbosity levels.
273 Sun Apr 16 11:46:51 2006 Ben Pfaff <blp@gnu.org>
275 Start reforming error message support. In this phase, we get rid
276 of "installation errors" and change all uses of msg() in the
277 output drivers to uses of error() or error_at_line().
279 * message.c: (err_vmsg) Get rid of IE, IS support.
281 Sat Mar 11 14:17:47 WST 2006 John Darrington <john@darrington.wattle.id.au>
283 * automake.mk: Changed the pattern specific AM_CPPFLAGS to two target
284 specific ones. Eventually there will be none at all.
286 * automake.mk: Moved the pspp binary to ui/terminal
288 Sat Mar 4 12:59:08 2006 Ben Pfaff <blp@gnu.org>
290 * In many source files, #include "compiler.h" to get GCC attribute
293 Sat Mar 4 12:28:09 2006 Ben Pfaff <blp@gnu.org>
295 * In many source files, replace INT_DIGITS by
296 INT_STRLEN_BOUND(int) and include intprops.h.
300 * Replaced '_' with '-' in most filenames.
302 * Renamed files as follows:
303 vfm.[ch] to procedure.[ch]
304 error.[ch] to message.[ch]
305 getl.[ch] to line-buffer.[ch]
306 mkfile.[ch] to make-file.[ch]
307 pfm-write.h to por-file-writer.h
308 pfm-write.c to por-file-writer.c
309 sfmP.h to sfm-private.h
310 lex-def.c to identifier.c
311 lex-def.h to identifier.h
312 sfm-read.c to sys-file-reader.c
313 sfm-read.h to sys-file-reader.h
314 sfm-write.h to sys-file-writer.h
315 sfm-write.c to sys-file-writer.c
316 chart.[ch] to chart-geometry.[ch]
319 vars-atr.c to variable.c
320 ctl-stack.c to control-stack.c
321 ctl-stack.h to control-stack.h
322 dfm-read.c to data-reader.c
323 dfm-write.c to data-writer.c
324 dfm-write.h to data-writer.h
325 dfm-read.h to data-reader.h
326 apply-dict.c to apply-dictionary.c
327 mis-val.c to missing-values.c
328 sysfile-info.c to sys-file-info.c
329 modify-vars.c to modifiy-variables.c
330 rename-vars.c to rename-variables.c
331 val-labs.c to value-labels.c
332 var-display.c to variable-display.c
333 var-labs.c to variable-label.c
334 format-prs.c to format-parser.c
335 range-prs.c to range-parser.c
336 range-prs.h to range-parser.h
337 subclist.c to subcommand-list.c
338 subclist.h to subcommand-list.h
339 vars-prs.c to variable-parser.c
340 descript.c to descriptives.c
341 sort-prs.c to sort-criteria.c/sort-cases.c
342 sort-prs.h to sort-criteria.h
343 sel-if.c to select-if.c
344 algorithm.c to array.c
345 algorithm.h to array.h
346 bitvector.h to bit-vector.h
351 readln.c to read-line.c
352 readln.h to read-line.h
353 cmdline.c to command-line.c
354 cmdline.h to command-line.h
357 Sat Feb 11 22:35:20 2006 Ben Pfaff <blp@gnu.org>
359 General clean-ups and minor bug fixes.
361 * filename.h: Move DIR_SEPARATOR, PATH_SEPARATOR here from
364 * lex-def.h: (macro CHAR_IS_ID1) Removed. All references changed
366 (macro CHAR_IS_IDN) Removed. All references changed to
369 * lex-def.c: (lex_is_id1) New function.
370 (lex_is_idn) New function.
371 (lex_skip_identifier) New function.
372 (lex_id_match_len) Return bool instead of int.
373 (lex_id_match) Ditto.
375 * command.c: (parse_command_name) Convert parsed words to
376 uppercase to make error messages easier to read.
377 (cmd_host) Fix return value.
379 * dfm-read.c: (read_inline_record) Use tokens to check for BEGIN
380 DATA, not specialized lexical analysis.
382 * print.c: (print_space_trns_proc) Count of lines should be `int',
383 otherwise we might never finish.
384 (print_space_trns_free) Close writer.
386 * lexer.c: (enum string_type) New enum.
387 (lex_get) Remove essentially unused local variable `cp'.
388 Use enum string_type values. Use parse_id().
389 (parse_id) New function.
390 (lex_look_ahead) Recognize octal strings too.
391 (strip_comments) New function.
392 (lex_get_line) Rewrite.
393 (lex_preprocess_line) Removed.
394 (convert_numeric_string_to_char_string) Use enum string_type.
395 (parse_string) Ditto.
397 * autorecode.c: (recode) Clone correct number of bytes based on
400 Sat Feb 11 22:34:38 2006 Ben Pfaff <blp@gnu.org>
402 Reduce dependencies on getl, and of getl.
404 * data-in.c: (vdls_error) Don't output different message depending
405 on whether we're interactive.
407 * getl.h: (struct getl_line_list) Removed.
408 (struct getl_script) Removed.
409 (GETL_PRPT_*) Removed.
410 (GETL_MODE_*) Removed.
411 (GETL_PROMPT_FIRST, GETL_PROMPT_LATER, GETL_PROMPT_DATA,
412 GETL_PROMPT_CNT) New enums.
414 * settings.c: (static var prompt) Removed.
415 (static var cprompt) Removed.
416 (static var dprompt) Removed.
417 (settings_done) Don't initialize prompt, cprompt, dprompt.
418 (get_prompt) Removed.
419 (set_prompt) Removed.
420 (get_dprompt) Removed.
421 (set_dprompt) Removed.
422 (get_cprompt) Removed.
423 (set_cprompt) Removed.
425 * pfm-read.c: (corrupt_msg) Don't show filename and line number,
426 to get rid of getl_location().
428 * sfm-read.c: (corrupt_msg) Ditto.
430 * getl.c: (struct getl_source) New.
431 (static var cur_source) New.
432 (static var last_source) New.
433 (static var DO_REPEAT_level) Removed.
434 (global var getl_head) Removed.
435 (global var getl_tail) Removed.
436 (getl_initialize) Call init_prompts().
437 (getl_add_file) Removed.
438 (getl_include) Removed.
439 (getl_add_DO_REPEAT_file) Removed.
440 (getl_handle_line_buffer) Removed.
441 (getl_close_file) Removed.
442 (getl_close_all) Removed.
443 (getl_is_separate) Removed.
444 (getl_set_separate) Removed.
445 (getl_reading_script) Removed.
446 (append_source) New function.
447 (include_source) New function.
448 (create_source) New function.
449 (create_syntax_file_source) New function.
450 (create_filter_source) New function.
451 (create_function_source) New function.
452 (create_interactive_source) New function.
453 (getl_append_syntax_file) New function.
454 (getl_include_syntax_file) New function.
455 (getl_include_filter) New function.
456 (getl_include_function) New function.
457 (getl_append_interactive) New function.
458 (getl_abort_noninteractive) New function.
459 (getl_is_interactive) New function.
460 (close_source) New function.
461 (getl_location) Use new `cur_source' var.
462 (getl_uninitialize) Use close_source(). Call uninit_prompts().
463 (read_syntax_file) New function.
464 (read_line_from_source) New function.
465 (do_read_line) New function.
466 (getl_read_line) Rewrite.
467 (static var prompts) New.
468 (static var current_style) New.
469 (init_prompts) New function.
470 (uninit_prompts) New function.
471 (getl_get_prompt) New function.
472 (getl_set_prompt) New function.
473 (getl_set_prompt_style) New function.
474 (get_prompt) New function.
476 * command.c: Merge the EXIT (aka Q, aka QUIT) and FINISH commands,
477 and make EXIT undocumented. EXIT was a PSPP extension that never
478 really entirely made sense.
480 (cmd_finish) Return CMD_EOF unconditionally.
481 (cmd_clear_transformations) Drop requirement of interactivity.
483 * command.def: Merge the EXIT (aka Q, aka QUIT) and FINISH
486 * repeat.c: Major changes to match getl revision.
487 (struct line_list) New struct.
488 (enum repeat_entry_type) New.
489 (struct repeat_entry) Made `type' an enum repeat_entry_type.
490 (struct repeat_block) New.
491 (static var repeat_tab) Removed.
492 (static var count) Removed.
493 (static var line_buf_head) Removed.
494 (static var line_buf_tail) Removed.
495 (cmd_do_repeat) Rewritten.
497 (append_record) Removed.
498 (recognize_keyword) New function.
499 (internal_cmd_do_repeat) Removed.
500 (parse_specification) New function.
501 (skip_indentor) New function.
502 (recognize_do_repeat) New function.
503 (recognize_end_repeat) New function.
504 (parse_lines) New function.
505 (create_vars) New function.
506 (parse_ids) Use enum repeat_entry_type.
507 (parse_strings) Ditto.
508 (find_DO_REPEAT_substitution) Renamed find_substitution(),
510 (perform_DO_REPEAT_substitutions) Renamed do_repeat_filter(),
512 (do_repeat_read) New function.
513 (do_repeat_close) New function.
515 * data-list.c: Don't need to keep track of eof from getl anymore,
516 because getl can tell us now.
517 (struct data_list_pgm) Removed `eof' member.
518 (cmd_data_list) Don't assign to `eof'.
519 (get_data_list_read_func) Renamed read_from_data_list(), changed
521 (read_from_data_list_fixed) Changed interface.
522 (read_from_data_list_free) Changed interface.
523 (read_from_data_list_list) Changed interface.
524 (data_list_trns_proc) Rewrote based on dfm_eof() and
526 (data_list_source_read) Check for dfm reader errors.
528 * dfm-read.c: (enum dfm_reader_flags) Removed DFM_EOF in favor of
529 new `eof_cnt' member in struct dfm_reader.
530 (struct dfm_reader) New `eof_cnt' member.
531 (dfm_close_reader) Check `eof_cnt', not DFM_EOF.
532 (dfm_open_reader) Initialize `eof_cnt'.
533 (read_inline_record) Set prompt style with
534 getl_set_prompt_style().
535 (read_record) Rewrite.
536 (cmd_begin_data) Set prompt style with getl_set_prompt_style().
538 * include.c: (cmd_include) Use getl_include_syntax_file().
540 * set.q: (cmd_set) Use getl_set_prompt().
542 * html.c: (postopen) Remove "source-file" expansion variable, to
543 avoid use of getl_location().
545 * postscript.c: (postopen) Remove "source-file" expansion
546 variable, to avoid use of getl_location().
548 * cmdline.c: (parse_command_line) Drop -c command line option,
549 because it wasn't very useful. -i command line option now calls
550 getl_append_interactive(). Use new getl function interfaces.
551 Drop support for clearing dictionary between syntax files and thus
552 the "+" command line syntax.
553 (static var pre_syntax_message) Remove description of now-gone -c
554 option. Remove "+" command line syntax.
556 * main.c: (main) Only call handle_error() if the return value is
558 (execute_command) Use getl_set_prompt_style(). Drop support for
559 clearing dictionary between syntax files.
560 (handle_error) Handle CMD_CASCADING_FAILURE. Don't call err_break().
562 * readln.c: Drop lots of #ifdefs. Now that the Autoconf tests are
563 pickier, we can just use HAVE_READLINE.
564 (static var welcomed) Move into welcome().
565 (welcome) Make `welcomed' a local static var. Check for and read
567 (global var getl_mode) Removed.
568 (global var getl_interactive) Removed.
569 (global var getl_prompt) Removed.
570 (getl_read_line) removed.
571 (readln_read) New function.
572 (read_console) Removed.
575 Sat Feb 11 22:16:21 2006 Ben Pfaff <blp@gnu.org>
577 Try to reduce some of the nastier dependencies on the error
578 module, and at the same time make PSPP nicer to deal with, by
579 getting rid of fatal errors. All the existing calls to msg (FE,
580 ...) or err_cond_fail() or err_failure() have been replaced by
581 propagating an error upward to the command-dispatch layer.
582 Unfortunately this propagation took a fair bit of extra mechanism,
583 because now a lot of functions can fail that couldn't before.
585 New command return value CMD_CASCADING_FAILURE which indicates to
586 the command processor that syntax file processing should be
587 abandoned. Many commands were modified to return
588 CMD_CASCADING_FAILURE. When this modification was trivial it
589 isn't mentioned in detail below.
591 Transformation procedures (trns_proc_func) and free functions
592 (trns_free_func) now have a `bool' return type, which is normally
593 true, but false when an I/O or other serious error occurs. All
594 transformation functions were modified to have this return type.
595 When this modification was trivial it isn't mentioned in detail
598 * pspp-error.h: (FE) Removed this error class.
600 * error.c: (err_failure) Removed.
601 (err_cond_fail) Removed.
602 (err_break) Removed (it was unused).
603 (err_check_count) Don't cause a fatal error--instead, stop reading
605 (err_vmsg) Don't have FE anymore, so no need to call terminate().
607 * any-reader.c: (any_reader_error) New function.
609 * any-writer.c: (any_writer_write) Propagate
610 scratch_writer_write_case()'s new return value.
611 (any_writer_error) New function.
612 (any_writer_close) Propagate underlying function's new return
615 * casefile.c: Add an "error state" to a casefile. A casefile that
616 encounters an I/O error enters the error state, and afterward
617 reading and writing cases fails.
618 (struct casefile) Add `ok' member.
619 (casefile_create) Set `ok' to true.
620 (casefile_destroy) Use io_error().
621 (casefile_error) New function.
622 (casefile_sleep) Now returns bool to indicate success.
623 (casefile_append) Ditto.
624 (casefile_append_xfer) Ditto.
625 (casefile_to_disk) Ditto.
626 (write_case_to_disk) Don't do anything in error state.
627 (flush_buffer) Don't do anything in error state. Use io_error().
628 (reader_open_file) Ditto.
630 (casereader_read) Don't do anything in error state. Handle
632 (casereader_read_xfer_assert) Removed, because now an I/O error
633 can occur even if the caller knows a case exists.
634 (io_error) New function.
636 * mkfile.c: (make_temp_file) Make failure non-fatal.
637 (make_unique_file_stream) Ditto.
639 * pfm-read.c: Add an error state.
640 (struct pfm_reader) Add `ok' member to indicate error state.
641 (error) Set `ok' to false.
642 (pfm_open_reader) Set `ok' to true. Make failure non-fatal.
643 (pfm_read_case) Don't do anything in error state.
644 (pfm_read_error) New function.
646 * pfm-write.c: Postpone most error checking in favor of checking
648 (pfm_open_writer) Make failure non-fatal. Check for write error
649 after writing header.
650 (buf_write) Don't do anything if error has occurred. Postpone
651 error checking. Change return type to void.
652 (write_float) Postpone error checking. Change return type to
655 (write_string) Ditto.
656 (write_header) Ditto.
657 (write_version_data) Ditto.
658 (write_format) Ditto.
660 (write_variables) Ditto.
661 (write_value_labels) Ditto.
662 (pfm_write_case) Don't do anything if error has occurred.
663 (pfm_write_error) New function.
664 (pfm_close_writer) Change return type to bool. Return false if an
667 * scratch-reader.c: (scratch_reader_error) New function.
669 * scratch-writer.c: (scratch_writer_write_case) Change return type
670 to bool. Propagate casefile error return.
671 (scratch_writer_error) New function.
672 (scratch_writer_close) Change return type to bool. Propagate
673 casefile error return.
675 * sfm-read.c: Add an error state.
676 (struct sfm_reader) Add `ok' member.
677 (sfm_open_reader) Initialize `ok'. Make errors non-fatal.
678 (buf_read) Set `ok' to false on error.
679 (buffer_input) Do nothing in error state. Set `ok' to false on
681 (read_compressed_data) Set `ok' false on error.
682 (sfm_read_case) Return false in error state.
683 (fread_ok) Set `ok' false on error.
684 (sfm_read_error) New function.
686 * sfm-write.c: Postpone most error checking in favor of checking
688 (sfm_open_writer) Make failure non-fatal. Check for write error
689 after writing header.
690 (write_header) Postpone error checking. Change return type to
692 (write_variable) Ditto.
693 (write_value_labels) Ditto.
694 (write_documents) Ditto.
695 (write_variable_display_parameters) Ditto.
696 (write_longvar_table) Ditto.
697 (write_rec_7_34) Ditto.
699 (ensure_buf_space) Ditto.
700 (sfm_write_case) Do nothing if write error has occurred.
701 (sfm_write_error) New function.
702 (pfm_close_writer) Change return type to bool. Return false if an
705 * var.h: Introduced a new return value for trns_proc_func that
706 means "a serious error has occurred, so abort the procedure
707 entirely". Because the hard-coded values of -1, -2, etc. were
708 becoming even a worse idea now, also introduced some macros for
709 them: TRNS_CONTINUE, TRNS_DROP_CASE, TRNS_ERROR, TRNS_NEXT_CASE,
710 TRNS_END_FILE. Also replaced all references to the hard-coded
711 values by uses of the macros.
713 * command.h: New command return value CMD_CASCADING_FAILURE which
714 indicates to the command processor that syntax file processing
717 * dfm-read.c: (dfm_open_reader) Make failure non-fatal.
718 (dfm_reader_error) New function.
719 (read_inline_record) Make unexpected end of file nonfatal.
720 (read_file_record) Make read error nonfatal.
721 (dfm_eof) Make second unexpected end of file nonfatal.
722 (cmd_begin_data) Make errors nonfatal.
724 * dfm-write.c: (dfm_open_writer) Make failure non-fatal.
725 (dfm_write_error) New function.
726 (dfm_put_record) Do nothing in error state. Now return error
728 (dfm_close_reader) Now return `bool' indicating error state.
730 * file-type.c: (file_type_source_read) Now return `bool'
731 indicating error state.
733 * get.c: (case_reader_source_read) Now return `bool' indicating
735 (case_writer_destroy) Ditto.
736 (case_writer_write_case) Ditto.
737 (struct mtf_proc) New member `ok' indicating error state.
738 (cmd_match_files) Initialize and deal with `ok'.
739 (mtf_processing_finish) Now return `bool' indicating I/O error.
740 (mtf_free_file) Renamed mtf_close_file(). Now return `bool'
741 indicating I/O error.
742 (mtf_free) Now return `bool' indicating I/O error.
743 (mtf_delete_file_in_place) Ditto.
744 (mtf_read_nonactive_records) Ditto.
745 (mtf_processing) Ditto.
747 * inpt-pgm.c: (input_program_source_read) Now return `bool'
748 indicating I/O error. Handle new TRNS_ERROR transformation return
751 * matrix-data.c: Introduce error state.
752 (cmd_matrix_data) Check error return values.
753 (read_matrices_without_rowtype) Now return `bool' indicating I/O
755 (matrix_data_read_without_rowtype) Ditto.
756 (dump_cell_content) Ditto.
757 (nr_output_data) Ditto.
758 (read_matrices_with_rowtype) Ditto.
759 (matrix_data_read_with_rowtype) Ditto.
760 (wr_output_data) Ditto.
762 * lexer.c: (lex_init) Make unexpected eof non-fatal.
764 (lex_look_ahead) Ditto.
765 (unexpected_eof) Removed.
766 (convert_numeric_string_to_char_string) Make unexpected eof
768 (parse_string) Ditto.
770 * flip.c: Make I/O errors non-fatal.
771 (struct flip_pgm) Add `pool', `output_buf' members.
772 (cmd_flip) Create and use pool. Propagate errors.
773 (destroy_flip_pgm) Rewrite, using pool.
774 (struct flip_sink_info) Removed.
775 (flip_sink_create) Use pool. Make errors non-fatal.
776 (flip_sink_write) Make errors non-fatal.
777 (flip_file) Make errors non-fatal. Make `bool' return type to
779 (flip_sink_destroy) Remove.
780 (static var flip_sink_class) Use NULL as destroy func, not
783 * sort.c: Make I/O errors non-fatal. Propagate errors.
784 (sort_active_file_in_place) Propagate errors.
785 (sort_active_file_to_casefile) Ditto.
786 (do_internal_sort) Ditto.
787 (do_external_sort) Ditto.
789 (destroy_initial_run_state) Propagate errors via new `bool' return
791 (merge) Propagate errors.
794 * output.c: [GLOBAL_DEBUGGING] Remove reentrancy detection,
795 because it used msg (FE, ...) and wasn't very useful.
797 * main.c: (handle_error) Handle CMD_CASCADING_FAILURE.
799 * vfm.c: (struct write_case_data) Change `proc_func' return type
801 (procedure) Add `bool' return type to indicate I/O error.
803 (internal_procedure) Ditto.
805 (execute_transformations) If a transformation returns TRNS_ERROR,
807 (close_active_file) Add `bool' return type to indicate I/O error.
809 (cancel_transformations) Add `bool' return type to indicate I/O
810 error. Propagate errors.
811 (struct split_aux_data) Change `proc_func' return type to bool.
812 (procedure_with_splits) Change `proc_func' return type to bool.
813 Add `bool' return type to indicate I/O error.
814 (multipass_procedure_with_splits) Change `split_func' return type
815 to bool. Add `bool' return type to indicate I/O error.
816 (multipass_split_callback) Add `bool' return type to indicate I/O
817 error. Propagate errors.
819 * vfm.h: (struct case_source_class) Change `read' return type from
820 void to bool to allow reporting I/O errors. Updated all
821 implementations to do so.
822 (struct case_sink_class) Change `write' return type from void to
823 bool to allow reporting I/O errors. Updated all implementations
826 Sun Feb 12 18:12:56 2006 Ben Pfaff <blp@gnu.org>
828 * pool.c: Useful new functions.
829 (pool_tmpfile) New function.
830 (pool_attach_file) New function.
831 (pool_detach_file) New function.
832 (pool_fopen) Reimplement in terms of pool_attach_file().
833 (pool_fclose) Reimplement in terms of pool_detach_file(). Fix
836 * str.c: Useful new functions.
837 (ds_swap) New function.
838 (ds_rtrim_spaces) New function.
839 (ds_chomp) New function.
840 (ds_is_empty) New function.
841 (ds_first) New function.
842 (ds_last) New function.
844 Sat Feb 11 21:51:21 2006 Ben Pfaff <blp@gnu.org>
846 Get rid of finished, start_interactive globals.
848 * command.c: (cmd_exit) Instead of setting `finished', return
852 * command.h: New enum CMD_EOF.
854 * main.c: (global var finished) Removed.
855 (global var start_interactive) Removed.
856 (main) Execute commands until CMD_EOF is the return value.
857 If parse_command_line() returns false, don't execute any commands
860 * cmdline.c: (parse_command_line) If the command line indicates we
861 shouldn't execute syntax files, return false instead of
863 (usage) Don't terminate.
865 Sat Feb 11 21:48:31 2006 Ben Pfaff <blp@gnu.org>
867 Get rid of cur_proc global. Replace by functions in err and tab
868 modules, which were the users.
870 * error.c: (static var command_name) New static var.
871 (err_vmsg) Use command_name.
872 (err_set_command_name) New function.
874 * tab.c: (static var command_name) New static var.
875 (tabi_title) Use command_name.
876 (tab_set_command_name) New function.
878 * command.c: (global var cur_proc) Removed.
879 (cmd_parse) Call err_set_command_name(), tab_set_command_name()
880 around executing command to set and clear command name.
882 Sat Feb 11 21:44:50 2006 Ben Pfaff <blp@gnu.org>
884 Get rid of glob.c, glob.h.
886 * Makefile.am: (pspp_SOURCES) Remove glob.c, glob.h.
888 * dictionary.c: Move default_dict definition here.
891 (global var FILTER_before_TEMPORARY) Variable removed. All
892 references deleted. The info in this var was redundant with
893 temp_dict, so they were changed to use temp_dict where needed.
897 * start-date.c: New file. Moved get_start_date() here.
899 * start-date.h: New file.
901 Fri Feb 3 20:34:52 2006 Ben Pfaff <blp@gnu.org>
903 * font.h: (struct font_set) Removed, because unused.
905 Sat Jan 28 17:45:36 2006 Ben Pfaff <blp@gnu.org>
907 Cleaner (faster?) way to compact cases.
909 * dictionary.c: (dict_compact_case) Removed.
910 (dict_needs_compaction) New function.
911 (struct copy_map) New structure.
912 (struct dict_compactor) New structure.
913 (dict_make_compactor) New function.
914 (dict_compactor_compact) New function.
915 (dict_compactor_destroy) New function.
917 Sat Jan 28 17:24:22 2006 Ben Pfaff <blp@gnu.org>
921 * data-list.c: Make data_list_source_class static.
922 (dump_fixed_table) Use fh_get_name() to describe source of data.
923 (dump_free_table) Ditto.
924 (cmd_repeating_data) Eliminate special cases for inline file.
926 * dictionary.c: (dict_contains_var) Change return value from int to
928 (dict_rename_vars) Ditto.
929 (dict_create_vector) Ditto.
931 Sat Jan 28 17:20:50 2006 Ben Pfaff <blp@gnu.org>
933 Add scratch file handles.
935 Now a file handle can refer to a disk file, to an in-memory
936 structure, or to the "inline" file, instead of just to a disk
937 file. The introduction of new categories means that special cases
938 for the inline file in a few places could be eliminated, but it
939 also means that code that assumed that a handle refers to a file
940 has to check for that.
942 Also, now file handles can be freed, so code now must be sure not
943 to access a handle after closing it (with fh_close()).
945 * Makefile.am: Add any-reader.c, any-reader.h, any-writer.c,
946 any-writer.h, scratch-handle.c, scratch-handle.h,
947 scratch-reader.c, scratch-reader.h, scratch-writer.c,
948 scratch-writer.h to pspp_SOURCES.
950 * any-reader.c: New file.
952 * any-reader.h: New file.
954 * any-writer.c: New file.
956 * any-writer.h: New file.
958 * scratch-handle.c: New file.
960 * scratch-handle.h: New file.
962 * scratch-reader.c: New file.
964 * scratch-reader.h: New file.
966 * scratch-writer.c: New file.
968 * scratch-writer.h: New file.
970 * aggregate.c: Use an any_writer instead of an sfm_writer, to add
973 * apply-dict.c: Use an any_reader instead of an sfm_reader, to add
976 * command.def: Add CLOSE FILE HANDLE command.
978 * dfm-reader.c: Now fewer special cases for inline file.
979 (static var inline_open_cnt) Removed.
980 (static var inline_file) Removed.
981 (dfm_close_reader) Eliminate a special case for inline file.
982 Reorganize to avoid access-after-free.
983 (dfm_open_reader) Eliminate a special case for inline file.
984 (read_inline_record) Use bool instead of int. No need to
985 increment line number.
986 (read_file_record) Use bool instead of int.
987 (read_record) Check whether file handle is inline file, instead of
990 (dfm_expand_tabs) Ditto.
993 (cmd_begin_data) Fix inaccurate check for whether the inline file
994 is in use--now we can tell by checking whether the inline file's
995 open count is positive.
997 * file-handle-def.c: (struct file_handle) Reorder members. Add
998 `deleted' member. Add `referent' member. Add `sh' member.
999 (static var default_handle) New variable.
1000 (static var inline_file) New variable.
1001 (fh_init) Initialize inline file.
1002 (free_handle) New function.
1004 (fh_from_name) Don't return deleted handles.
1005 (fh_from_filename) Ditto.
1006 (fh_create) Removed.
1007 (create_handle) New function.
1008 (fh_create_file) New function.
1009 (fh_create_scratch) New function.
1010 (fh_inline_file) New function.
1012 (fh_open) Now requires a referent type mask and verifies it. All
1014 (fh_close) If open_cnt goes to 0 on a deleted handle, free it.
1015 (fh_is_open) New function.
1016 (fh_get_referent) New function.
1017 (fh_get_filename) Limit to handles that refer to files.
1018 (fh_get_mode) Ditto.
1019 (fh_get_record_width) Limit to handles that refer to files or the
1021 (fh_get_tab_width) Ditto.
1022 (fh_get_scratch_handle) New function.
1023 (fh_set_scratch_handle) New function.
1024 (fh_get_default_handle) New function.
1025 (fh_set_default_handle) New function.
1027 * file-handle.h: (enum fh_referent) New type.
1028 (enum fh_mode) Rename MODE_TEXT to FH_MODE_TEXT, MODE_BINARY to
1029 FH_MODE_BINARY, and update all usages.
1031 * file-handle.q: Add "scratch" as a possible mode.
1032 (cmd_file_handle) Mention CLOSE FILE HANDLE in error message.
1033 Use lex_end_of_command(), lex_sbc_missing(). Support creating
1035 (cmd_close_file_handle) New function.
1036 (referent_name) New function.
1037 (fh_parse) Now takes a referent type mask to specify handles that
1038 can be accepted. Updated all references.
1040 * filename.c: (fn_extension) New function.
1042 * get.c: Use any_reader and any_writer and thereby merge code that
1043 has been duplicated for each kind of file. Also, we had something
1044 here called `any_writer' before, so its name had to be changed to
1046 (enum operation) Removed, because unused.
1047 (struct get_pgm) Removed.
1048 (get_pgm_free) Removed.
1049 (get_source_destroy) Removed.
1050 (get_source_read) Removed.
1051 (global var get_source_class) Removed.
1052 (static var case_reader_source_class) Removed.
1053 (enum reader_command) New enum.
1054 (struct case_reader_pgm) New struct.
1055 (parse_read_command) New function.
1056 (case_reader_pgm_free) New function.
1057 (case_reader_source_destroy) New function.
1058 (case_Reader_source_Read) New function.
1059 (cmd_get) Rewrote as a call to parse_read_command().
1061 (struct any_writer) Rename to case_writer. Drop `writer_type',
1062 `writer' members in favor of an `any_writer' member named
1064 (any_writer_destroy) Rename case_writer_destroy. Use
1066 (parse_write_command) Allow scratch files. Use any_writer.
1067 (any_writer_write_case) Rename case_writer_write_case(). Use
1069 ` (struct mtf_file) Use any_reader.
1070 (cmd_match_files) Allow scratch files. Use any_reader.
1071 (mtf_free_file) Use any_reader_close().
1072 (mtf_read_nonactive_records) Use any_reader_read().
1073 (mtf_processing) Use any_reader_read().
1074 (struct import_pgm) Removed.
1075 (import_pgm_free) Removed.
1076 (import_source_destroy) Removed.
1077 (import_source_read) Removed.
1078 (global var import_source_class) Removed.
1080 * glob.c: (global var default_handle) Removed. Replaced all
1081 references by fh_get_default_handle() or fh_set_default_handle().
1083 * pfm-read.c: (static var portable_to_local) Moved from inside
1084 read_header() to top level.
1085 (pfm_detect) New function.
1087 * pfm-write.c: (pfm_write_case) Make case argument const.
1088 Reorganize to avoid access-after-free.
1090 * print.c: (dump_table) Use fh_get_name() to describe source of
1093 * sfm-read.c: (sfm_close_reader) Reorganize to avoid
1095 (sfm_detect) New function.
1097 * str.c: (str_lowercase) New function.
1099 * vfm.c: Use new compaction interface.
1100 (static var compaction_necessary) Removed.
1101 (static var compactor) New variable.
1102 (open_active_file) Initialize compactor.
1103 (write_case) Use compactor.
1104 (close_active_file) Free compactor.
1106 Wed Jan 11 19:28:39 2006 Ben Pfaff <blp@gnu.org>
1108 Clean up file handle code in preparation to add scratch file
1111 * file-handle-def.c: Lots of formatting cleanup. Added function
1113 (struct file_handle) Renamed `length' member
1114 to `record_width'. All references updated.
1115 (fh_init) New function. Moved here from file-handle.q.
1116 (fh_done) New function. Moved here from file-handle.q and
1118 (get_handle_with_name) Renamed fh_from_name().
1119 (get_handle_for_filename) Renamed fh_from_filename().
1120 (create_file_handle) Renamed fh_create(). Changed to take a
1121 `struct fh_properties' instead of discrete values. Updated all
1123 (create_file_handle_with_defaults) Removed. Updated all
1124 references to use fh_create() with fh_default_properties().
1125 (fh_default_properties) New function.
1126 (destroy_file_handle) Removed. The code is now in fh_done().
1127 (handle_get_name) Renamed fh_get_name().
1128 (handle_get_filename) Renamed fh_get_filename().
1129 (handle_get_record_width) Renamed fh_get_record_width().
1130 (handle_get_tab_width) Renamed fh_get_tab_width().
1132 * file-handle-def.h: Formatting, comment fixes.
1133 (enum file_handle_mode) Renamed struct fh_mode.
1134 (struct fh_properties) New structure.
1135 (fh_init) Move prototype here from file-handle.h.
1139 * file-handle.q: (static var handle_list) Removed.
1140 (fh_parse) Don't add handle to handle_list, because
1141 file-handle-def.c has its own list.
1142 (fh_init) Moved to file-handle-def.c.
1145 Sun Jan 9 01:09 Jason Stover <jason@sakla.net>
1147 * regression.q: (run_regression) Moved coefficient initialization
1148 to the linreg library. Altered other functions accordingly.
1150 Sat Jan 7 13:30:54 WST 2006 John Darrington <john@darrington.wattle.id.au>
1152 * command.c data-in.c main.c: Fixed bug which crept in when
1153 separating getl from readline.
1155 * vars-atr.c value-labels.h: Fixed constness of val_labs_count.
1157 Fri Dec 23 20:59:01 WST 2005 John Darrington <john@darrington.wattle.id.au>
1159 * getl.c error.c: Separated file_loc functionality from error.c
1161 Mon Dec 19 14:01:56 WST 2005 John Darrington <john@darrington.wattle.id.au>
1163 * format.c: Additional error checking.
1164 * getl.[ch]: Separated into getl.c and readln.c
1165 * settings.[ch]: Made CC_CNT public
1167 Fri Dec 16 09:11:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1169 * examine.q: Fixed buglet when cleaning up at end of procedure.
1171 Tue Dec 13 22:34:42 2005 Ben Pfaff <blp@gnu.org>
1173 Move global initialization and cleanup code into main.c.
1174 Remove vestigial log infrastructure.
1175 Minor related cleanups.
1177 * command.c: (shell) When execl() fails, use _exit(), not
1180 * error.c: (err_hcf) Move into main.c, rename terminate(). All
1182 (err_done) New function with just the error.c-specific code for
1183 err_hcf(). Called by terminate().
1185 * glob.c: Removed all Borland C, DJGPP cruft.
1186 (init_glob) Merged into main().
1187 (done_glob) Merged into terminate().
1189 (get_start_date) New function. All users of curdate updated to call
1190 this function instead.
1192 * lexer.c: (lex_init) Moved initialization of tokstr here, from
1194 (lex_done) Moved destruction of tokstr here, from done_glob().
1196 * main.c: (global var pgmname) Removed. Changed all references to
1197 program_name, which is defined by gnulib.
1198 (global var curdate) Removed.
1199 (main) Moved init_glob() code here. Merged parse_script() in
1201 (parse_script) Removed.
1202 (terminate) Moved err_hcf() here from error.c and renamed
1203 terminate(). Merged done_glob() code in here. Call err_done().
1204 All callers updated.
1205 (i18n_init) New function.
1206 (fpu_init) New function.
1208 * output.c: (outp_init) Make void.
1209 (init_default_drivers) New function.
1210 (outp_read_devices) If no drivers are initialized successfully,
1211 call init_default_drivers() to initialize a default driver.
1212 (outp_done) Make void.
1213 (static var prog) Make const.
1214 (parse_options) Make parameter const.
1215 (colon_tokenize) Make return value const.
1216 (configure_driver) Change prototype to take a broken-down driver
1217 configuration instead of a line of text.
1218 (configure_driver_line) New function that does what
1219 configure_driver() did before.
1221 * q2c.c: (global var pgmname) Rename program_name.
1223 * settings.c: (settings_init) Renamed from init_settings().
1224 (settings_done) Renamed from done_settings().
1226 * vfm.c: (global var last_vfm_invocation) Make static.
1227 (vfm_last_invocation) New function. All references to
1228 last_vfm_invocation update to call this.
1229 (procedure) Call update_last_vfm_invocation().
1230 (internal_procedure) Ditto.
1231 (update_last_vfm_invocation) New function.
1233 Sat Dec 10 23:30:19 2005 Ben Pfaff <blp@gnu.org>
1235 Separate random numbers from other settings because of GSL
1238 * Makefile.am: Add random.c, random.h to sources.
1240 * glob.c: (init_glob) Call random_init().
1241 (done_glob) Call random_done().
1243 * settings.c: (static var rng) Move to random.c.
1244 (done_settings) Move freeing of RNG to random_done().
1245 (get_rng) Move to random.c
1248 * random.c: New file.
1250 * random.h: New file.
1252 Sat Dec 10 18:13:36 2005 Ben Pfaff <blp@gnu.org>
1254 Separate settings and the SET command, for modularity.
1256 * Makefile.am: Add settings.c to sources.
1258 * glob.c: (global variable test_mode) Removed.
1260 * set.q: Remove all the set_* variables. Remove a lot of obsolete
1261 SPSS/PC+ settings. Remove the aux_*() routines. Moved the
1262 get_*() functions into settings.c. Rewrite the settings code and
1263 functions to call the new set_*() functions. Rewrite custom
1264 currency parsing. Write new by-hand cmd_show().
1266 * esttings.c: New file. Moved the get_*() functions here from
1267 set.q. Created new set_*() functions to correspond with them.
1268 Regularized the names and types of some functions and updated
1269 their callers. Added static, file-scope variables to support the
1272 * q2c.c: Remove "aux" support, which was only needed by set.q.
1274 Sun Nov 27 06:43:46 WST 2005 John Darrington <john@darrington.wattle.id.au>
1276 * data-out.c format.h: Added return value to data_out function.
1278 * value-labels.c: Fixed bug in val_labs_remove.
1280 Sat Nov 5 18:37:26 2005 Ben Pfaff <blp@gnu.org>
1282 * Makefile.am: Remove devind.c, devind.h from list of source
1285 * devind.c: Removed.
1287 * devind.h: Removed.
1289 * list.q: Removed "support" for devind.
1291 * output.c: Don't add devind class.
1293 Sat Nov 5 18:21:00 2005 Ben Pfaff <blp@gnu.org>
1295 * var.h: (struct variable) Make `init', `reinit' bool values.
1298 Fri Nov 4 19:43:01 2005 Ben Pfaff <blp@gnu.org>
1300 * recode.c: Rewrote whole file, as clean-up.
1302 Fri Nov 4 19:37:50 2005 Ben Pfaff <blp@gnu.org>
1304 * pool.c: Don't make alignment exception for x86.
1305 (pool_alloc) Return null for 0-size blocks.
1306 (pool_alloc_unaligned) New function.
1307 (pool_strndup) Removed. Changed callers to use pool_clone_unaligned().
1308 (pool_clone_unaligned) New function.
1309 (pool_strdup) Use pool_clone_unaligned().
1311 * var.h: (enum var_type) Give the NUMERIC, ALPHA enum this name.
1312 (struct variable) Use `enum var_type' for `type'.
1314 * vars-atr.c: (var_type_adj) New function.
1315 (var_type_noun) New function.
1317 * vars-prs: (parse_mixed_vars) Fix freeing code.
1318 (parse_mixed_vars_pool) New function.
1320 Wed Nov 2 21:24:48 2005 Ben Pfaff <blp@gnu.org>
1322 * file-handle-def.c: Needed another #include, to avoid missing
1325 * file-handle.q: (cmd_file_handle) Declarations must precede
1326 statements. Free parse data on success as well as on failure, to
1329 * get.c: (parse_write_command) Destroy dict on success, to avoid
1332 * data-list.c: (cmd_repeating_data) Fix usage of saw_occurs,
1333 saw_length, saw_continued, saw_id, which were boolean but
1334 incorrectly treated as bitmaps as result of a previous
1335 half-finished cleanup.
1337 * weight.c: (struct weight_trns) Unused, so removed.
1339 * Makefile.am: Add range-prs.h to sources.
1341 Wed Nov 2 21:24:15 2005 Ben Pfaff <blp@gnu.org>
1343 DO IF, LOOP cleanup.
1345 * Makefile.am: Add ctl-stack.c, ctl-stack.h to source files.
1346 Reformat source file list to list one file per file, so that
1347 patches for future changes will be easier to read.
1349 * ctl-stack.c, ctl-stack.h: New files.
1351 * do-if.c: Rewrote whole file.
1353 * do-ifP.h: Removed.
1355 * loop.c: Rewrote whole file.
1357 * glob.c: (global var ctl_stack) Move into ctl-stack.c.
1359 * temporary.c: (cmd_temporary) Use ctl_stack_is_empty().
1361 * vfm.c: (open_active_file) Use ctl_stack_clear().
1363 Wed Nov 2 21:18:13 2005 Ben Pfaff <blp@gnu.org>
1367 * pool.c: (pool_create_at_offset) New function.
1368 (pool_add_subpool) New function.
1370 * pool.h: (pool_create_container) New macro.
1372 * expressions/parse.c: (expr_parse_pool) New function.
1374 * autorecode.c: (recode) Use pool_create_container().
1376 * count.c: (cmd_count) Ditto.
1378 Wed Nov 2 19:59:32 2005 Ben Pfaff <blp@gnu.org>
1380 Clean up transformations, by getting rid of `struct trns_header',
1381 replacing it by `struct transformation' that has a void *
1382 `private' member. Updated all uses of transformations to match,
1383 which was a lot of code. Only major related changes listed below.
1385 * compute.c: (cmd_if) Use get_proc_func().
1386 (cmd_compute) Use get_proc_func().
1387 (get_proc_func) New function.
1389 * glob.c: (global var m_trns) Change type to size_t.
1390 (global var n_trns) Ditto.
1391 (global var f_trns) Ditto.
1392 (global var t_trns) Change type to struct transformation *.
1394 * var.h: (struct trns_header) Removed.
1395 (struct transformation) New.
1396 (typedef trns_proc_func) Takes a void * instead of a struct
1398 (typedef trns_free_func) Ditto.
1400 * vfm.c: (execute_transformations) Takes an array of
1401 transformations instead of trns_headers.
1402 (add_transformation) Change prototype from (trns_header *) to
1403 (trns_proc_func *, trns_free_func *, void *).
1404 (next_transformation) New function.
1406 Sat Oct 29 16:25:36 2005 Ben Pfaff <blp@gnu.org>
1408 * count.c: Major cleanups. Rename practically everything.
1409 Rewrite much of the code. Use pools for memory management. Use
1410 the new parse_num_range().
1412 * mis-val.c: (cmd_missing_values) Use the new parse_num_range().
1413 (parse_number) Removed.
1415 * missing-values.c: (mv_add_num_range) Don't add out-of-order
1416 ranges, e.g. where low > high.
1418 * pool.c: (pool_2nrealloc) New function.
1420 * range-prs.c: New file.
1421 (parse_num_range) New function.
1422 (parse_number) New function.
1424 Fri Oct 28 22:47:48 2005 Ben Pfaff <blp@gnu.org>
1426 Fix up potential overflows in size calculations by replacing
1427 instances of pool_alloc(p, x * sizeof *y) by pool_malloc(p, x,
1428 sizeof *y) everywhere I could find them. Similarly by
1429 pool_malloc(), pool_realloc().
1430 (Order is important: pool_alloc(p, sizeof *y, x) will divide by 0
1433 * pool.c: (pool_nalloc) New function.
1434 (pool_nmalloc) New function.
1435 (pool_nrealloc) New function.
1437 Thu Oct 27 11:16:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
1439 Separated the definition of a file handle object from the stuff
1440 pertaining to the FILE HANDLE command.
1442 * file-handle-def.[ch]: New files.
1444 * dfm-read.c file-handle.h file-handle.q
1446 Tue Oct 25 21:56:23 2005 Ben Pfaff <blp@gnu.org>
1448 Fix up potential overflows in size calculations by replacing
1449 instances of xmalloc(x * sizeof *y) by xnmalloc(x, sizeof *y)
1450 everywhere I could find them. Similarly by xrealloc(), malloc().
1451 (Order is important: xnmalloc(sizeof *y, x) will divide by 0 if x
1454 * alloc.c: (nmalloc) New function.
1455 (out_of_memory) Removed. Replaced references by xalloc_die().
1457 * sort.c: (allocate_cases) Fix segfault if memory allocation
1460 * subclist.c: (subc_list_double_create) Use xnmalloc() instead of
1462 (subc_list_double_push) Use xnrealloc() instead of realloc().
1464 Wed Oct 26 08:43:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1466 Dictionary abstraction part #2
1468 * algorithm.c format.c str.c sysfile-info.c val.h var.h vars-atr.c:
1469 Removed unnecessary #include directives
1471 Mon Oct 24 21:35:08 2005 Ben Pfaff <blp@gnu.org>
1473 * groff-font.c (font_msg): Use err_vmsg() instead of incorrectly
1474 trying to pass a va_list to tmsg(). Thanks to Jason Stover for
1477 Mon Oct 24 21:24:15 2005 Ben Pfaff <blp@gnu.org>
1479 Work to get rid of GCC 4.0 warnings, part 2.
1481 In many files, change `unsigned char' to `char'. This often
1482 requires adding casts to <ctype.h> functions.
1484 * data-in.c: (parse_A) Use buf_copy_rpad().
1486 * str.c: (str_copy_buf_trunc) New function.
1488 * value-labels.c: (value_to_string) Fix mistaken use of strncpy(),
1491 Mon Oct 24 13:42:32 WST 2005 John Darrington <john@darrington.wattle.id.au>
1493 Moved some definitions to make it easier to abstract a dictionary
1494 from the rest of PSPP.
1496 * format-prs.c lex-def.[ch]: New files.
1498 * Makefile.am lexer.[ch] dictionary.c vars-atr.c vfm.c algorithm.c
1499 format.c: Moved some functions between modules.
1501 Sun Oct 23 19:28:08 2005 Ben Pfaff <blp@gnu.org>
1503 Work to get rid of GCC 4.0 warnings, part 1.
1505 In many files, change count parameters to parse_variables(),
1506 etc. from `int' to `size_t'. Also change related variables and
1507 struct members. Also change messages as needed (e.g. %d to %u
1508 with cast to unsigned). Also change arithmetic as necessary
1509 (e.g. n >= m - 1 to n + 1 >= m).
1511 * crosstabs.q: (crs_custom_tables) Check for size_t overflow in
1514 * q2c.c: (dump_declarations) Generate code for size_t instead of
1517 Thu Oct 20 18:18:40 2005 Ben Pfaff <blp@gnu.org>
1519 * output.c: (outp_read_devices) Fix message.
1521 Sat Sep 17 11:13:13 2005 Ben Pfaff <blp@gnu.org>
1523 * matrix-data.c: (cmd_matrix_data) Change type of variable whose
1524 address is passed to dict_get_vars() from size_t to int to match
1525 John's change below.
1527 * modify-vars.c: (validate_var_modification) Ditto.
1529 Mon Sep 12 19:26:06 WST 2005 John Darrington <john@darrington.wattle.id.au>
1531 * dictionary.[ch] Changed cnt from size_t* to int* since that's
1532 what it's called as, and on x86_64 machines they're different sizes.
1534 * str.c: (ds_vprintf) Copied va_list args so they can be re-used
1536 Sun Aug 21 00:12:24 2005 Ben Pfaff <blp@gnu.org>
1538 * lexer.c: (lex_sbc_only_once) New function.
1539 (lex_sbc_missing) New function.
1541 Sun Aug 21 00:00:47 2005 Ben Pfaff <blp@gnu.org>
1543 * case.h: (case_str) Make it return `unsigned char'.
1545 Sat Aug 20 23:56:14 2005 Ben Pfaff <blp@gnu.org>
1547 Revamp SAVE, XSAVE, EXPORT. Add (or at least parse) all the
1548 subcommands that we didn't support. Fix bug 13911. Fix bug
1549 reported by Adam Pierson (COMPRESSED and other subcommands didn't
1550 work on SAVE). Refactor all related code.
1552 * command.def: Add XEXPORT command.
1554 * dictionary.c: (dict_delete_scratch_vars) New function.
1556 * get.c: (cmd_get) Fix parsing.
1557 (struct save_trns) Removed.
1558 (cmd_save_internal) Removed.
1560 (do_write_case) Removed.
1561 (save_write_case_func) Removed.
1562 (save_trns_proc) Removed.
1563 (save_trns_free) Removed.
1564 (trim_dictionary) Removed.
1565 (struct export_proc) Removed.
1566 (cmd_export) Rewrote.
1567 (export_write_case_func) Removed.
1568 (export_proc_free) Removed.
1569 (enum writer_type) New enum.
1570 (enum command_type) New enum.
1571 (struct any_writer) New struct.
1572 (any_writer_destroy) New function.
1573 (parse_write_command) New function.
1574 (any_writer_write_case) New function.
1575 (parse_output_proc) New function.
1576 (output_proc) New function.
1578 (cmd_xsave) Rewrote.
1579 (struct output_trns) New struct.
1580 (parse_output_trns) New function.
1581 (output_trns_proc) New function.
1582 (output_trns_free) New function.
1583 (cmd_xsave) Rewrote.
1584 (cmd_xexport) New function.
1585 (parse_dict_trim) New function.
1586 (struct mtf_proc) Change `by_cnt' member type to `int'.
1587 (cmd_import) Rewrote.
1589 * pfm-write.c: (struct pfm_writer) Add `digits' member.
1590 (pfm_writer_default_options) New function.
1591 (pfm_open_writer) Add `opts' argument and handle options.
1592 (write_float) Write only as many digits as `digits' member says.
1593 (format_trig_double) Limit base-10 precision to LDBL_DIG.
1595 * pfm-write.h: (enum pfm_type) Moved here from pfm-read.h.
1596 (struct pfm_write_options) New struct.
1598 * sfm-write.c: (sfm_writer_default_options) New function.
1599 (sfm_open_writer) Remove `compress', `omit_long_names' args. Add
1600 `opts' argument. Implement options.
1602 * sfm-write.h: (struct sfm_write_options) New struct.
1604 * expressions/helpers.c: (copy_string) Make `old' arg `unsigned
1605 char *' instead of `char *'.
1607 Sat Aug 6 21:29:15 2005 Ben Pfaff <blp@gnu.org>
1609 * factor_stats.c: Needed <config.h> included earlier.
1611 * percentiles.c: Needed to include <config.h>.
1613 * val.h: Don't include "config.h".
1615 Sat Aug 6 21:26:27 2005 Ben Pfaff <blp@gnu.org>
1617 Clean up treatment of missing values by moving all the code into
1618 one place. All references to the missing value function were
1619 updated, but only major changes are detailed below.
1621 * Makefile.am: Add missing-values.c, missing-values.h to sources.
1623 * apply-dict.c: (cmd_apply_dictionary) Use mv_resize().
1625 * dictionary.c: (dict_create_var) Initialize `miss' member with
1627 (dict_clone_var) Copy `miss' member with mv_copy().
1629 * get.c: (mtf_merge_dictionary) Use mv_copy().
1631 * missing-values.c: New file.
1633 * missing-values.h: New file.
1635 * mis-val.c: Rewrite. New version implements updated semantics.
1637 * pfm-read.c: (read_variables) Rewrite missing value handling.
1639 * pfm-write.c: (write_variables) Rewrite missing value handling.
1641 * sfm-read.c: (read_variables) Rewrite missing value handling.
1643 * sfm-write.c: (write_variable) Rewrite missing value handling.
1645 * sfmP.h: Include "magic.h" to get definition of
1646 second_lowest_value.
1648 * sysfile-info.c: (describe_variable) Rewrite missing value
1651 * val.h: Include "magic.h" to get definition of
1652 second_lowest_value.
1654 * var.h: Include "missing-values.h". Drop MISSING_* enums.
1655 (struct variable) Remove `miss_type', `missing'. Add `miss'.
1657 * vars-atr.c: (is_num_user_missing) Removed--use
1658 mv_is_num_user_missing().
1659 (is_str_user_missing) Removed--use mv_is_str_user_missing().
1660 (is_system_missing) Removed--use mv_is_value_system_missing().
1661 (is_missing) Removed--use mv_is_value_missing().
1662 (is_user_missing) Removed--use mv_is_value_user_missing().
1664 Sun Jul 31 14:09:57 2005 Ben Pfaff <blp@gnu.org>
1666 Adopt use of gnulib for portability.
1668 * Make.build: Add $(top_srcdir)/gl and $(top_builddir)/gl to
1671 * Makefile.am: Remove bool.h, stat.h and change getline.[ch] to
1672 getl.[ch] in pspp_SOURCES. Remove libmisc, add libgl in
1675 * In many source files, added an explicit inclusion of gettext.h
1676 and definition of _ macro. These are no longer in pref.h because
1677 it interfered with definitions in a few gnulib source files.
1679 * In many source files, changed #include "bool.h" to #include
1680 <stdbool.h>, which is provided by gnulib.
1682 * alloc.c: Removed functions defined in gnulib:
1687 (out_of_memory) Redefined as wrapper for xalloc_die().
1689 * alloc.h: Replace prototypes by #include "xalloc.h".
1691 * casefile.c: Use full_read() and full_write() from gnulib instead
1692 of our home-grown versions.
1693 (full_read) Removed.
1694 (full_write) Removed.
1696 * getline.c: Renamed getl.c.
1698 * getline.h: Renamed getl.h, updated all references.
1700 * filename.c: (fn_readlink) Change to wrapper around xreadlink()
1703 * glob.c: Just #include <time.h> instead of the crazy rigmarole
1705 (init_glob) Call set_program_name() to initial gnulib progname
1708 * html.c: (postopen) Use getlogin_r(), gethostname() from gnulib.
1710 * permissions.c: Use "stat-macros.h" from gnulib.
1712 * postscript.c: Just #include <time.h> instead of the crazy
1713 rigmarole here before.
1715 * q2c.c: (main) Make generated code #include "gettext.h".
1717 * str.h: Get rid of most explicit declarations of standard
1718 functions, in favor of including gnulib header files.
1720 * expressions/evaluate.c: Ditto.
1722 * expressions/operations.h.pl: Make generated code #include
1723 <stdbool.h>, not "bool.h".
1725 Sat Jul 30 23:13:17 2005 Ben Pfaff <blp@gnu.org>
1727 * expressions/parse.c: (validate_function_args) Fix two msg() bugs
1730 Sat Jul 30 23:10:01 2005 Ben Pfaff <blp@gnu.org>
1732 * expressions/evaluate.c: (expr_debug_print_postfix) Don't pass
1733 null pointer to printf for %.*s.
1735 Sat Jul 30 23:05:33 2005 Ben Pfaff <blp@gnu.org>
1737 * vars-atr.c: (var_is_valid_name) Fix three msg() bugs found by
1740 Sat Jul 30 22:58:33 2005 Ben Pfaff <blp@gnu.org>
1742 * rank.q: (parse_rank_function) Fix msg() bug found by -Wformat.
1744 Sat Jul 30 22:56:12 2005 Ben Pfaff <blp@gnu.org>
1746 * postscript.c: (postopen) Cast `char' to `unsigned char' before
1747 passing to isspace().
1749 Sat Jul 30 22:52:09 2005 Ben Pfaff <blp@gnu.org>
1751 * pfm-read.c: (read_variables) Fix msg() bug found by -Wformat.
1753 Sat Jul 30 22:50:57 2005 Ben Pfaff <blp@gnu.org>
1755 * histogram.c: Include <config.h>.
1757 Sat Jul 30 22:48:50 2005 Ben Pfaff <blp@gnu.org>
1759 * get.c: (cmd_match_files) Fix msg() bug found by -Wformat.
1761 Sat Jul 30 22:46:10 2005 Ben Pfaff <blp@gnu.org>
1763 * format.c: (check_common_specifier) Fix msg() bug found by
1765 (check_output_specifier) Ditto.
1767 Sat Jul 30 22:43:57 2005 Ben Pfaff <blp@gnu.org>
1769 * file-handle.q: (cmd_file_handle) Fix msg() bug found by
1772 Sat Jul 30 22:41:44 2005 Ben Pfaff <blp@gnu.org>
1774 * data-in.c: (parse_Z) [WORDS_BIGENDIAN] Don't declare buf[], to
1775 avoid "unused variable" warning.
1777 Sat Jul 30 22:38:46 2005 Ben Pfaff <blp@gnu.org>
1779 * command.c: (find_word) Cast `char' to `unsigned char' before
1780 passing to isspace().
1782 Sat Jul 30 22:36:29 2005 Ben Pfaff <blp@gnu.org>
1784 * case.c: (case_compare) Implement as delegating to
1785 case_compare_2dict().
1787 Sat Jul 30 22:34:18 2005 Ben Pfaff <blp@gnu.org>
1789 * algorithm.c: Inclusion of <alloca.h> is unneeded.
1791 Sat Jul 30 22:01:32 2005 Ben Pfaff <blp@gnu.org>
1793 * Make.build: Don't append -ansi to AM_CFLAGS for GCC. Using
1794 -ansi changes the behavior of header files significantly. It
1795 causes __STRICT_ANSI__ to be defined, and some headers interpret
1796 that as cause to e.g. not use `long long' or __attribute__. The
1797 former example is bad when off_t is supposed to be `long long',
1798 and the latter prevents -Wformat from working.
1800 Sun Jul 24 20:26:59 2005 Ben Pfaff <blp@gnu.org>
1802 Get rid of dependency on libgmp by writing our own routine for
1803 floating-point base conversion.
1805 * pfm-write.c: (write_float) Rewrote.
1806 (write_int) Rewrote.
1807 (pow30_nonnegative) New function.
1808 (pow30) New function.
1809 (trig_to_char) New function.
1810 (format_trig_digits) New function.
1811 (recurse_format_trig_int) New function.
1812 (format_trig_int) New function.
1813 (should_round_up) New function.
1814 (try_round_up) New function.
1815 (format_trig_double) New function.
1817 Sun Jul 24 18:49:20 2005 Ben Pfaff <blp@gnu.org>
1819 * data-in.c: (parse_numeric) Allow "1+23" even for F format, for
1822 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
1824 * pfm-read.c: (read_version_data) Read and ignore author field.
1826 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
1828 * get.c: (mtf_processing) Don't assume that
1829 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
1830 returns a negative, zero, or positive result. Fixes MATCH FILES
1831 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
1833 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
1835 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
1836 preprocessor test for sys/types.h was accidentally inverted. This
1839 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
1841 * get.c: (cmd_match_files) Fix memory leak on `by' and on
1844 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
1847 * vfm.c: (close_active_file) Remove unnecessary test.
1849 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
1851 Fix NDEBUG compile errors.
1853 * hash.h: Needed explicit #include <assert.h>.
1855 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
1858 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
1860 Implement embedding for PostScript driver. Fixes bug 12970.
1862 * ascii.c: Fix compiler warnings.
1866 * chart.h: Add `file' member.
1868 * output.h: (struct outp_class) initialise_chart, finalise_chart
1869 should take outp_driver *, not outp_class *. Update all
1872 * plot-chart.c: (chart_create) Fix segfault when there are no
1873 output drivers at all.
1874 (chart_submit) Call d->class->finalise_chart.
1876 * postscript.c: (ps_open_page) Set cp_y to 0.
1877 (ps_submit) New function.
1878 (ps_chart_initialise) Implement.
1879 (ps_chart_finalise) Implement.
1880 (static var postscript_class) Add ps_submit.
1881 (static var epsf_class) Add ps_submit.
1884 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
1886 Did some more work on bug 12859 and then realized that a *good*
1887 solution would require some fundamental restructuring. For now,
1888 I'm marking REPEATING DATA unimplemented, and then we can revisit
1891 * command.def: Make REPEATING DATA unimplemented.
1893 * data-list.c: (cmd_repeating_data) Assume inline file is 80
1895 (realize_value) Revert previous changes; no longer needed.
1896 Updated all callers.
1898 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
1899 file_loc, to avoid bad references later.
1903 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
1905 Make some code tolerant of reentry. Should not be needed if other
1906 code is correct but it is good to be generally tolerant.
1908 * error.c: (err_hcf) Set file_loc to null after free().
1910 * output.c: (outp_done) Similar changes.
1912 * str.c: (ds_destroy) Ditto.
1914 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
1916 Continue work on bug 12859, plus some code cleanup.
1918 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
1919 boolean variables. Don't try to compute starts_end, cont_end for
1920 inline file. Calculate length only after parsing variable
1921 specifications. Add proper transformation to list.
1922 (realize_value) If the rpd_num_or_var has no value, return new
1923 DEFAULT_MEMBER argument (for use with inline file).
1924 (repeating_data_trns_proc) Pass default values.
1926 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
1927 open, and only if we actually started reading data.
1929 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
1933 * output.c: (outp_read_devices) Fix message.
1935 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1937 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
1938 of the sort algorithm from the parser for the SORT command.
1940 * rank.q: Added the parser for the RANK command.
1942 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
1946 * sort.c: (sort_parse_criteria) Only set *saw_direction if
1947 saw_direction is non-null. Thanks to John Darrington for
1950 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
1952 * get.c: (mtf_processing) Handle case of a lookup table as the
1953 active file. Thanks to John Darrington for reporting this bug.
1955 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1957 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
1958 POSIX calloc function.
1960 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
1961 reflect new signature.
1963 * sfm-read.c: Now much more robust in the face of badly formed
1966 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
1968 *sfm-read.c: Fixed some bugs regarding long string continuation
1969 records, which the previous fix uncovered.
1971 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
1973 * sfm-read.c, sfmP.h: Allow reading of system files when the
1974 case_size value in the header is -1. Also changed some Errors to
1975 Warnings when reading system files.
1977 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
1979 * data-list.c: (data_list_trns_free) Don't free the argument
1980 because cancel_transformations() will do that itself.
1981 (data_list_source_destroy) Destroy the argument to
1982 data_list_trns_free(), because it no longer does so itself.
1984 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
1986 * data-out.c: (format_and_round) Don't output leading `-' if value
1989 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
1993 * som.c: (output_encodings) If some cell in the table won't fit
1994 with the horizontal or vertical headers, cancel those headers.
1996 * som.h: (struct som_table_class) Add fits_width, fits_length,
1997 set_headers members.
1999 * tab.c: (tabi_fits_width) New function.
2000 (tabi_fits_length) New function.
2001 (tabi_set_headers) New function.
2002 (global var tab_table_class) Add the new functions as appropriate
2005 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
2007 Fix rest of bug 13054.
2009 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
2010 DATETIME, TIME system/portable file values.
2012 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
2014 * data-list.c: (parse_free) Use make_input_format().
2016 * data-out.c: (num_to_string) Use make_output_format().
2018 * dictionary.c: (dict_create_var) Ditto.
2020 * format.c: (global var f8_2) New var.
2021 (make_input_format) New function.
2022 (make_output_format) New function.
2024 * get.c: (cmd_match_files) Use make_output_format().
2026 * list.q: (cmd_list) Ditto.
2028 * matrix-data.c: Ditto.
2030 * sfm-read.c: (parse_format_spec) Check output specifier
2033 * tab.c: (tab_float) Use make_output_format().
2035 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
2037 Fix more of bug 13054.
2039 * format.def: FMT_A should allow 255-character output. FMT_AHEX
2040 should allow 510-character input and output.
2042 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
2043 (convert_E) Handle non-finite values.
2045 (format_and_round) New function.
2046 (convert_infinite) New function used by try_F() and convert_E().
2048 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
2050 Regularize string and buffer function names so that they make some
2053 * str.c: (mm_reverse) Rename buf_reverse(). Update all
2055 (mm_find_reverse) Rename buf_find_reverse(). Update all
2057 (mm_case_compare) Rename buf_compare_case(). Update all
2059 (st_compare_pad) Rename buf_compare_rpad(). Update all
2061 (str_compare_rpad) New function.
2062 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
2064 (buf_copy_str_lpad) New function.
2065 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
2067 (st_pad_copy) Rename str_copy_rpad(). Update all references.
2068 (st_trim_copy) Rename str_copy_trunc(). Update all references.
2069 (st_uppercase) Renamed str_uppercase(). Update all references.
2071 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
2073 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
2076 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
2078 * data-in.c: (data_in) Add assertion to check input specifier.
2080 * data-out.c: (data_out) Add assertion to check output specifier.
2082 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
2084 Start to fix bug 13054.
2086 * format.c: (check_input_specifier) Improve error message.
2087 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
2088 valid decimal places.
2089 (check_output_specifier) Ditto (but different criteria).
2090 (convert_fmt_ItoO) Assert valid input and output specifiers.
2091 Also, if input specifier has *any* decimal places, make the output
2092 specifier 1 place wider.
2094 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
2096 * sysfile-info.c: Fixed bug [# 13024 ]
2098 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
2100 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
2101 actually implement it.
2103 * command.c: (FILE_TYPE_okay) Always return 1.
2105 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
2107 * file-type.c: Add prototypes to get rid of warnings.
2109 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
2111 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
2112 more ISO/IEC 9899:1990 conformance issues.
2114 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
2116 Fix bug 12948. See also new test in
2117 tests/bugs/match-file-scratch.sh.
2119 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
2120 that deletes scratch variables that someone else might be using,
2121 and because we can't reassign our sources' value indexes.
2122 Instead, simply don't copy scratch variables into the master
2125 * dictionary.c: (dict_compact_values) Delete variables from the
2126 dictionary passed in, not from default_dict (!).
2128 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
2130 Improve hash.c comments, error-checking.
2132 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
2133 (hsh_create) size == 0 should *not* return NULL! Set
2135 (hsh_clear) Set hash_ordered.
2136 (locate_matching_entry) Check hash_ordered.
2137 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
2138 (hsh_data) Set hash_ordered. Add const-ness to return value and
2142 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
2144 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
2146 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
2148 * copyleft.c: Updated copyright date.
2150 * Makefile.am: Removed erroneous explicit "-lplot"
2152 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
2154 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
2156 * command.c command.def: Added description string for unimplemented commands.
2158 * oneway.q: Sorted the hash tables before shipping out the results. Closes
2161 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
2165 * data-list.c: (parse_fixed) Use lex_end_of_command().
2167 (cmd_repeating_data) Set cont_end.num in right situations.
2168 (parse_repeating_data) Remove redundant test.
2170 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
2172 Partial fix for bug 12859.
2174 * data-list.c: (cmd_data_list) Add transformation properly in
2175 vfm_source == NULL case.
2177 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
2179 * lexer.c: (lex_error) Improve error messages.
2181 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
2183 * get.c: (cmd_match_files) Check token type before trying to match
2184 tokid. Fixes bug 12923.
2186 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
2188 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
2191 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
2193 * expressions/generate.pl: (get_token) Make use of /g
2194 backward-compatible with Perl 5.6.1.
2196 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
2198 * var-display.c: (cmd_variable_alignment) Fix memory leak.
2199 (cmd_variable_level) Ditto.
2201 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
2203 Hash table had buggy deletion function. The fix required changing
2204 other functions to do probing in the required order.
2206 * hash.c: (locate_matching_entry) Rewrite and change interface.
2207 (hsh_rehash) Rewrite to use locate_matching_entry().
2210 (hsh_delete) Ditto. Also, fix stupid bugs.
2212 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
2214 * dictionary.c: (dict_clone) Properly copy vectors.
2216 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
2218 New implementation of long variable names. Each variable has a
2219 "normal" name, which may be up to 64 bytes long and which is used
2220 for all normal operations. Variables may have a "short" name,
2221 which is limited to 8 bytes and used only for system and portable
2222 file input and output.
2224 Make tokid case-preserving. Update most uses of tokid to treat it
2227 Update many commands to deal with long variable names.
2229 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
2231 * command.c: (cmd_parse) Ditto.
2232 (match_strings) Use toupper() before comparing characters.
2233 (conflicting_3char_prefixes) Use mm_case_compare() instead of
2235 (cmd_match_words) Ditto.
2237 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
2240 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
2241 Use st_trim_copy() instead of strcpy().
2243 * data-in.c: (parse_enum) Use mm_case_compare() instead of
2246 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
2248 (parse_free) Use st_trim_copy() instead of strcpy().
2250 * descript.c: (struct dsc_var) Change z_name[] to fit long var
2252 (try_name) Use strcasecmp() instead of strcmp().
2253 (generate_z_varname) Use st_trim_copy() instead of strcpy().
2254 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
2257 * dictionary.c: (struct dictionary) Removed `long_name_tab'
2259 (compare_long_names) Removed.
2260 (hash_long_name) Removed.
2261 (dict_create) Don't initialize `long_name_tab' member.
2262 (dict_clone) Copy short names into new dictionary.
2263 (dict_clear) Don't clear `long_name_tab' member.
2264 (dict_get_varname_block) Removed.
2265 (dict_add_longvar_entry) Removed.
2267 (dict_destroy) Don't destroy `long_name_tab' member.
2268 (dict_create_var_from_short) Removed.
2269 (dict_create_var_x) Removed.
2270 (dict_create_var) Get rid of longname handling.
2272 (dict_clone_var) Get rid of longname parameter and longname
2274 (dict_lookup_var) Get rid of longname handling.
2275 (dict_reorder_var) New function.
2276 (dict_rename_var) Clear short name.
2277 (dict_rename_vars) Get rid of longname handling. Clear short
2279 (dict_create_vector) Support long vector names.
2280 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
2281 (quasi_base27) Removed.
2282 (make_short_name) Removed.
2283 (compare_strings) New function.
2284 (hash_string) New function.
2285 (dict_assign_short_names) New function.
2287 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
2289 (get_handle_for_filename) Support long handle names.
2291 * file-type.c: (struct col_spec) Make `name' fit long var names.
2292 (cmd_file_type) Use strcasecmp() instead of strcmp().
2294 * flip.c: (make_new_var) Rewrite.
2295 (flip_sink_write) Use st_trim_copy() instead of strncpy().
2297 * format.c: (parse_format_specifier_name) Use mm_case_compare()
2298 instead of memcmp().
2300 * get.c: (cmd_save_internal) Rephrase.
2301 (rename_variables) Drop test for identical variable name.
2302 (struct mtf_proc) Change `first', `last' to fit long var name.
2304 * hash.c: (hsh_hash_case_string) New function for case-insensitive
2307 * lexer.c: (restore_token) Use st_trim_copy() instead of
2309 (lex_get) Don't uppercase string when copying into tokid.
2310 (lex_put_back_id) Use st_trim_copy() instead of
2313 * list.q: (determine_layout) Consider length of variable names in
2314 choosing vertical layout.
2316 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
2318 (string_to_content_type) Ditto.
2320 * modify-vars.c: (compare_variables_given_ordering) Ditto.
2321 (struct var_renaming) Change `new_name' to fit long var name.
2322 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
2325 * pfm-read.c: (read_variables) Disallow system variables in system
2327 (write_variables) Call dict_assign_short_names() and use
2328 short_name[] members.
2330 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
2333 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
2334 map. Reorder variables into same order as long variable map.
2335 (read_variables) Set short name.
2337 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
2338 (write_variable) Use st_bare_pad_copy().
2339 (write_longvar_table) Rewrite.
2341 * str.c: (mm_case_compare) New function.
2343 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
2344 instead of strcmp().
2346 * t-test.q: (tts_custom_groups) Remove redundant test.
2347 (tts_custom_pairs) Ditto.
2349 * var.h: (struct variable) Change `name' to fit long var names.
2350 Remove `longname'. Add `short_name' member. Reorder some
2352 (struct name_table_entry) Removed.
2353 (struct vector) Change `name' to fit long vector names.
2355 * vars-atr.c: (var_is_valid_name) Allow long var names.
2356 (compare_var_names) Use strcasecmp() instead of strcmp().
2357 (compare_var_ptr_names) Ditto.
2358 (hash_var_name) Use hsh_hash_case_string().
2359 (hash_var_ptr_name) Ditto.
2360 (var_set_short_name) New function.
2361 (var_clear_short_name) New function.
2362 (var_set_short_name_suffix) New function.
2364 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
2365 Use strcasecmp() instead of strcmp().
2366 (struct array_var_set) Removed `longname_tab'.
2367 (array_var_set_lookup_var_idx) Drop longname_tab support.
2368 (array_var_set_destroy) Don't destroy `longname_tab'.
2369 (var_set_create_from_array) Don't create `longname_tab'.
2371 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
2374 * expressions/parse.c: (word_matches) Use mm_case_compare()
2375 instead of memcmp().
2376 (compare_strings) New function.
2377 (lookup_function) Use compare_strings() instead of strcmp().
2379 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
2381 * algorithm.c: (move_element) New function.
2383 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
2385 * aggregate.c: (parse_aggregate_functions) Always initialize
2388 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
2390 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
2392 * dictionary.c: (dict_clone) Ditto.
2393 (dict_clone_var_assert) New function.
2395 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
2397 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
2399 * error.c: Added a string for the compiler version to the
2400 request_bug_report_and_abort function.
2402 * groff_font.c, font.c: Removed manpage(1) style references from
2403 comments, because RMS frowns upon them.
2405 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
2407 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
2409 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
2411 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
2412 Fixed bug [#12858] .
2414 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
2416 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
2417 which should be LONG_NAME_LEN
2419 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
2421 * command.def echo.c: Added the ECHO command.
2423 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
2425 Finish fixing MATCH FILES (bug 11677).
2427 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
2428 keep_variables(), rename_variables().
2429 (drop_variables) New function.
2430 (keep_variables) New function.
2431 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
2432 (cmd_match_files) Deal with in_var. Use drop_variables(),
2433 keep_variables(). When IN is specified, require BY. Set master
2434 variables after master dictionary is complete. Add IN variables
2435 after master dictionary is complete.
2436 (mtf_free_file) Free `in_name'.
2437 (mtf_delete_file_in_place) Set in_var value to 0.
2438 (mtf_read_nonactive_records) Rephrase.
2439 (mtf_processing) Support IN. Rephrase. Fix bugs.
2440 (mtf_merge_dictionary) Don't set master variables; we do that
2442 (get_master) Don't insist that there's a master variable.
2444 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
2446 Kluge to make some variable renaming sort of work.
2449 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
2451 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
2453 Add functions for comparing sets of variables between cases.
2456 * case.c: (case_compare) New function.
2457 (case_compare_2dict) New function.
2459 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
2461 (cmd_aggregate) Nullify break_case. Don't call
2462 initialize_aggregate_info().
2463 (agr_destroy) Destroy break_case.
2464 (aggregate_single_case) Rewrite. Use case_compare().
2465 (dump_aggregate_info) Copy from break_case into output.
2466 (initialize_aggregate_info) Copy break_case from input.
2468 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
2470 * vfm.c: (equal_splits) Use case_compare().
2472 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
2474 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
2476 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
2478 Start work on fixing MATCH FILES.
2480 * get.c: (enum operation) Remove OP_MATCH.
2481 (trim_dictionary) Change return value to bool. Don't support
2483 (struct mtf_file) Remove `first', `last' members.
2484 (struct mtf_proc) Add `first', `last' members. Change mtf_case
2485 from `struct ccase *' to `struct ccase'. Remove `by' member.
2486 (cmd_match_files) Essentially rewrite.
2487 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
2488 (mtf_read_nonactive_records) mtf_ parameter is not unused.
2489 (mtf_processing) Ditto. Also rephrase some code.
2490 (mtf_merge_dictionary) Rewrite for easy comprehension.
2492 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
2494 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
2497 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
2499 Thu Apr 14 2005 John Darrington
2501 * var-display.c: New file.
2503 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
2504 display_width, measure and alignment parameters to variables.
2506 * aggregate.c command.def compute.c count.c data-list.c descript.c
2507 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
2508 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
2509 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
2510 vars-prs.c vector.c :
2511 - Replaced literal constants representing maximum variable name
2512 length with macro definitions.
2513 - Added support for long variable names.
2514 - Changed lexer such that it no longer makes tokens upper
2515 case, but relies upon case insensitive behaviour of commands.
2517 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
2519 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
2520 fails, don't dereference the resulting null pointer (bug 12427).
2521 Also, fix double free error.
2523 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
2525 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
2526 (accumulate_aggregate_info) Set int1 to 1 for SUM.
2527 (dump_aggregate_info) Only make SUM non-missing if there was at
2530 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
2532 * aggregate.c: (dump_aggregate_info) Properly test whether the
2533 destination variable is numeric, when making the result
2534 system-missing for columnwise missing values.
2536 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
2538 * misc.h: Remove GCC specializations.
2540 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
2542 Make sort stable (bug 12313).
2544 * sort.c: Don't need to include some headers anymore.
2545 (static var min_buffers) New variable.
2546 (static var max_buffers) New variable.
2547 (static var allow_internal_sort) New variable.
2548 (cmd_sort_cases) Add test mode.
2549 (sort_execute) Rephrase.
2550 (do_internal_sort) Don't try internal sorting if
2551 allow_internal_sort is set.
2552 (struct external_sort) Renamed `initial_runs' to `runs' and
2553 updated all references.
2554 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
2555 (macro MIN_BUFFER_SIZE_BYTES) Removed.
2556 (macro MIN_BUFFER_SIZE_RECS) Removed.
2557 (compare_initial_runs) Removed.
2558 (struct record_run) Add member `idx'.
2559 (write_initial_runs) Pass increasing values to process_case() as
2561 (process_case) Add `idx' parameter and use it to initialize new
2563 (allocate_cases) Limit allocated buffers to max_buffers.
2564 (compare_record_run) Use new `idx' member for last resort
2565 comparison, for stability.
2566 (end_run) Call casefile_sleep() on irs->casefile, to prevent
2567 running out of file descriptors.
2568 (struct merge_state) Removed.
2569 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
2570 unless we have fewer runs left. Always merge consecutive runs,
2571 for stability. Return the final run.
2573 (choose_merge) New function.
2574 (merge_once) Rewritten.
2576 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
2578 * cmdline.c: (static var testing_mode) Move into
2579 parse_command_line().
2581 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
2583 * algorithm.c: (remove_range) New function.
2584 (remove_element) New function.
2586 * dictionary.c: (dict_delete_var) Use remove_element().
2588 * flip.c: (cmd_flip) Ditto.
2590 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
2592 * file-handle.q: (struct file_handle) `open_mode' should not be
2595 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
2597 First phase of making SORT CASES stable (bug 12313).
2599 * sort.c: (struct indexed_case) New structure.
2600 (do_internal_sort) Rewrite to make internal sorting stable.
2601 (compare_case_dblptrs) Removed.
2602 (compare_indexed_cases) New function.
2604 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
2608 * casefile.c: (casereader_read_xfer_assert) New function.
2610 * dictionary.c: (dict_compact_case) New function.
2612 * flip.c: (struct flip_pgm) New member idx_to_fv.
2613 (cmd_flip) Initialize idx_to_fv member.
2614 (destroy_flip_pgm) Free idx_to_fv member.
2615 (flip_sink_write) Use struct flip_pgm member instead of case_sink
2617 (flip_sink_write) Ditto.
2619 * vfm.c: (write_case) Use dict_compact_case() instead of
2621 (compact_case) Removed.
2622 (storage_source_create) Removed `dict' parameter. All references
2625 * vfm.h: (struct case_source) Removed `value_cnt' member. All
2627 (struct case_sink) Removed `dict', `idx_to_fv' members. All
2630 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
2632 More AGGREGATE fixes.
2634 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
2635 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
2637 (initialize_aggregate_info) Fix initialization for MIN, MAX for
2640 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
2642 Start work on testing and debugging AGGREGATE.
2644 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
2645 of a bit-map. Require proper subcommand ordering. Make OUTFILE
2646 subcommand mandatory.
2647 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
2648 functions' arguments are in the correct order and swap them if
2650 (accumulate_aggregate_info) Make SUM include weights. Add various
2652 (dump_aggregate_info) Add various string functions.
2653 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
2655 * sort.c: (sort_parse_criteria) Add parameter for returning
2656 whether any directions were specified. All callers updated.
2658 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
2660 * t-test.q: Fixed erroneous logic in compare_group_binary.
2662 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
2664 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
2665 keywords (bug 11628).
2667 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
2669 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
2670 called *before* close_active_file().
2672 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
2674 * file-handle.q: (struct file_handle) Change open_mode from
2675 character pointer to 3-char array, for safety. Updated all
2678 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
2680 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
2683 * pfm-read.c: (read_header) Improve error message for many cases
2684 in which the input is not actually a portable file.
2686 * file-handle.q: (fh_open) When we give an error message, actually
2689 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
2691 * format.c: (check_common_specifier) New function for checks
2692 common to check_input_specifier() and check_output_specifier().
2693 (check_input_specifier) Use check_common_specifier().
2694 (check_output_specifier) Use check_common_specifier().
2695 (check_string_specifier) Removed.
2696 (check_specifier_type) New function.
2697 (check_specifier_width) New function.
2698 (get_format_var_width) Fix bug.
2700 * formats.c: (internal_cmd_formats) Only accept numeric variables.
2702 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
2703 update all references. Make case-insensitive.
2705 * pfm-read.c: Essentially rewrite the whole file. Now much
2708 * print.c: (check_string_width) New function.
2709 (fixed_parse_compatible) Use check_string_width(),
2710 check_specifier_type().
2711 (dump_fmt_list) Ditto.
2713 * str.c: (st_trim_copy) New function.
2714 (st_uppercase) New function.
2716 * vars-atr.c: (var_is_valid_name) New function.
2718 * expressions/parse.c: (type_coercion_core) Use
2719 check_specifier_type().
2721 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
2723 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
2725 * expressions/parse.c: (no_match) Ditto.
2727 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
2729 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
2731 * expressions/helpers.c: (struct func_params) Removed.
2732 (generalized_idf) Removed.
2735 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
2737 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
2738 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
2739 Implement SIG.F, which I had overlooked previously.
2741 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
2743 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
2744 available only in testing mode.
2746 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
2748 * data-in.c: Use `bool' throughout, where relevant.
2750 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
2752 DATA LIST with free-field formats should not have implied decimal
2753 places (bug 12035). Also clean up data-in.c a bit.
2755 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
2757 * data-in.c: (apply_implied_decimals) New function.
2758 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
2759 set. Also, get rid of gotos.
2760 (parse_Z) Use apply_implied_decimals() if the field doesn't
2761 contain a decimal point.
2762 (parse_N) Use apply_implied_decimals().
2768 (parse_enum) New function.
2769 (macro CHAR_IS_ROMAN) Removed.
2770 (macro ROMAN_VALUE) Removed.
2771 (parse_month) Use parse_enum().
2772 (parse_weekday) Use parse_enum().
2773 (parse_DATETIME) Use long for weekday.
2775 * data-list.c: (read_from_data_list_fixed) Use
2776 DI_IMPLIED_DECIMALS.
2778 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
2780 When the lexer sees something like `-5' in the input, it has to
2781 decide whether it's a negative numeric constant token or a '-'
2782 token followed by a positive numeric constant token. It always
2783 decides on the former, and then the parser can call
2784 lex_negative_to_dash() if it wants the latter. However, this
2785 doesn't work for the case of `-0', because negative zero is
2786 (portably) indistinguishable from positive zero. So now we divide
2787 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
2788 distinction clear. This requires a little bit of extra effort,
2789 because there were several references to T_NUM in the code base.
2791 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
2792 positive and negative numeric constants.
2793 (lex_double_p) Renamed lex_is_number(). Changed return type to
2794 bool. Updated all relevant references to T_NUM to instead use
2796 (lex_double) Renamed lex_number(). All references updated.
2797 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
2798 bool. All references updated.
2799 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
2800 (lex_negative_to_dash) Ditto.
2803 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
2805 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
2807 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
2809 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
2811 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
2812 values as system-missing.
2814 * expressions/parse.c: (parse_vector_element) Fix order of
2815 arguments in call to expr_allocate_binary().
2817 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
2819 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
2822 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
2823 failure, as indicated by function comment.
2824 (parse_binary_operators) Always return NULL on type_coercion()
2825 failure. Should have been doing this anyway, but bug in
2826 type_coercion_core() filtered through.
2827 (parse_add) Fix typo in user message.
2828 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
2830 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
2832 * expressions/operations.def: Add VALUE function.
2834 * expressions/parse.c: (parse_function) Need an unary composite
2835 node for variables in A TO B, not a variable node. Use
2836 allocate_unary_variable().
2837 (parse_primary) Use allocate_unary_variable().
2838 (allocate_unary_variable) New function.
2840 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
2842 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
2843 but fixed the real problem that was preventing the build from a
2844 separate directory. I liked it my way better ;-)
2846 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
2848 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
2849 John Darrington <john@darrington.wattle.id.au> for reporting this
2852 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
2854 * expressions/Makefile.am expressions/evaluate.h.pl
2855 expressions/evaluate.inc.pl expressions/operations.h.pl
2856 expressions/optimize.inc.pl expressions/parse.inc.p:
2858 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
2861 Fixed everything so that it can be built from an arbitrary
2864 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
2866 * Makefile.am : Fixed up CLEANFILES target.
2868 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
2870 * str.h: Changed `struct len_string' to `struct fixed_string', a
2871 more accurate name. Updated all references.
2873 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
2875 Redo calendar support. Should now be bug-for-bug compatible.
2877 * calendar.c: New file.
2879 * calendar.h: New file.
2881 * data-in.c: Use new calendar functions.
2882 (parse_sign) Change sense of return value.
2883 (calendar_error) New function.
2884 (ymd_to_ofs) New function.
2885 (ymd_to_date) New function.
2886 (parse_DATE) Use new function.
2887 (parse_ADATE) Ditto.
2888 (parse_EDATE) Ditto.
2889 (parse_SDATE) Ditto.
2890 (parse_JDATE) Ditto.
2895 (parse_DTIME) Ditto.
2896 (parse_DATETIME) Ditto.
2898 * data-out.c: (convert_date) Use new calendar functions.
2900 * error.c: (err_vmsg) Changed interface to be more sensible.
2901 Updated all callers.
2902 (dump_message) Don't double new-lines (why did we do this
2905 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
2907 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
2908 (macro FLT64_MAX) Moved here from pref.h.orig.
2910 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
2912 * set.q: Support SET EPOCH.
2913 (static var set_epoch) New var.
2914 (aux_stc_custom_epoch) New function.
2915 (stc_custom_epoch) New function.
2916 (get_epoch) New function.
2917 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
2919 * format.c: Make it possible just to check whether a specifier is
2920 valid without emitting an error message.
2921 (parse_format_specifier_name) Change interface, update all
2923 (check_input_specifier) Ditto.
2924 (check_output_specifier) Ditto.
2925 (parse_format_specifier) Ditto.
2927 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
2929 * command.def: Add DEBUG POOL.
2931 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
2933 (pool_clear) Properly account for size of pool gizmo.
2934 (pool_realloc) Ditto.
2935 (pool_clone) New function.
2937 * pool.h: Mark our allocation functions MALLOC_LIKE.
2939 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
2941 * Makefile.am: Move many definitions into new top-level
2942 Make.build. Add expressions to SUBDIRS. Add calendar.c,
2943 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
2946 * case.c: (case_resize) New function.
2947 (case_swap) New function.
2949 * casefile.c: Include mkfile.h.
2951 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
2953 * sfm-read.c: Fixed a buglet which caused a crash when trying
2954 to read a non-existent file.
2956 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
2960 * aggregate.c: (parse_aggregate_functions) Code cleanup.
2961 Important part: get rid of spurious copying of function->format to
2962 destvar->print and destvar->write.
2964 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
2966 Fix bug 11916, which was confusing a variable's `index' member
2967 with the variable's position in a var_set. Although these are
2968 usually the same, they are not for array `var_set's.
2970 Took advantage of this bug as an opportunity to clean up and
2971 rewrite parse_var_set_vars().
2973 * vars-prs.c: (parse_vs_variable_idx) New function.
2974 (parse_vs_variable) Reimplement in terms of
2975 parse_vs_variable_idx().
2976 (parse_var_idx_class) New function.
2977 (add_variable) New function.
2978 (add_variables) New function.
2979 (parse_var_set_vars) Rewritten.
2980 (struct var_set) Change `lookup_var' member that returns a
2981 variable into `lookup_var_idx' member that returns an int.
2982 Updated the var set implementations in obvious corresponding ways.
2983 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
2985 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
2987 Use our global variable compare & hash functions and give them
2988 better names. Add similar functions for dealing with double
2989 pointers to variables.
2991 * vars-atr.c: (compare_variables) Renamed compare_var_names().
2992 (hash_variable) Renamed hash_var_name().
2993 (compare_var_ptr_names) New function.
2994 (hash_var_ptr_name) New function.
2996 * t-test.q: (cmd_t_test) Use global compare_var_names(),
2998 (compare_var_name) Removed.
2999 (hash_var_name) Removed.
3001 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
3005 * dictionary.c: (compare_variable_dblptrs) Rename
3006 compare_var_ptrs() and fix it to properly dereference the double
3009 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
3011 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
3012 declare subcommands as mandatory. Closed bug #11843
3014 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
3016 * getline.c command.[ch] command.def: Added (very rudimentary)
3017 support for line completion when in interactive mode. Partially
3018 addresses bug #11693
3020 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
3022 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
3023 problems revealed by valgrind.
3026 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
3028 * set.q: Affixed a fix to the previous fix such that we'll be OK now
3029 whether or not PAGER is set.
3031 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
3033 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
3034 "invalid free" errors. Hopefully fixes bug #11722
3036 * compute.c expr-prs.c: Check that lvalues are populated before
3037 attempting to destroy them. Closes bug #11676
3039 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
3041 * aggregate.c: Initialised the complete agr_proc structure.
3045 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
3047 * print.c: (print_trns_free) Close the dfm writer if there is one,
3048 fixing a memory leak.
3050 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
3052 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
3056 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
3058 * linked-list.[ch] Added
3060 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
3061 set.q: Yet more memory leaks
3063 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
3065 * t-test.q examine.q : More memory leaks fixed.
3067 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
3069 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
3072 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
3074 * ascii.c cartesian.c casefile.c chart.h devind.c
3075 examine.q frequencies.q
3076 html.c output.h piechart.c plot-chart.c plot-hist.c
3078 Integrated the chart rendering into the output stream
3079 (currently only works for html).
3081 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
3082 dummy-chart.c for compiling without charts.
3084 * mkfile.[ch] Created.
3086 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
3087 Added type element so we can tell if it's a chart or a table.
3089 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
3090 API of charts to be more like that of tables.
3092 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
3094 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
3095 main.c. Removed the handler for SIGQUIT.
3097 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
3099 * casefile.c: Added a signal handler to delete temp files on
3102 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
3104 * command.def Added a lot more unimplemented commands.
3106 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
3108 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
3110 * sort.c: (compare_initial_runs) Needed additional level of
3112 (merge_once) Fix plenty of stupid mistakes.
3114 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
3116 * casefile.c: (casefile_sleep) Need to flush_buffer() after
3117 calling casefile_to_disk() or we will lose the last block in the
3118 file if the casefile started out as disk-based.
3119 (casefile_get_reader) Initialize reader->destructive to 0.
3120 (cmd_debug_casefile) Add new test pattern.
3121 (test_casefile) Define new test pattern to make sure
3122 casefile_sleep() works properly.
3124 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
3126 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
3127 plot-hist.c plot-chart.c (Added) Reorganised these files in an
3128 attempt to seperate the creation and processing of charts from their
3131 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
3134 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
3136 * main.c Added a signal handler for SIGFPE
3138 * sort.c Somewhat more robust fix to the previous entry.
3140 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
3142 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
3143 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
3144 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
3147 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
3149 * case.h Fixed bug # 11307
3151 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
3153 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
3156 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
3158 * pfm-read.c: (read_variables) Remove direct manipulation of
3159 v->aux, which is no longer needed. Fixes bug 11483.
3161 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
3163 * data-list.c Fixed a bug in parsing delimiters.
3165 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
3168 * percentiles.c Properly handled calculation of Tukey hinges where
3169 the number of data is small.
3171 * oneway.q Used the generic value_to_string function for independent
3172 variable instead of trying to do it ourselves.
3174 * box-whisker.c Fixed a buglet which caused a crash if the number of
3178 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
3180 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
3182 * percentiles.c Fixed some bugs when calculating percentiles when
3183 there's a small number of cases.
3185 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
3187 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
3189 * examine.q factor_stats.[ch] Added calculation of percentiles
3191 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
3193 * t-test.q Fixed bug #11227 Made t-test work when the independent
3196 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
3198 * factor_stats.c Fixed calculation of trimmed mean under various
3201 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
3203 * histogram.c chart.[ch] factor_stats.c frequencies.q
3205 Added code to calculate sensible histogram ranges and limits.
3207 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
3209 * chart.h Updated to reflect many API changes.
3211 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
3212 cartesian.c and into chart.c
3214 * factorstats.[ch] Added the histogram calculations
3216 * casefile.c Removed an unused variable.
3218 * frequencies.q examine.q histogram.c Reworked the API for
3221 * piechart.c Revised the API for piecharts.
3223 * var.h Moved the definitions of freq_tab and freq out of var.h
3224 and into frequencies.q where they belong.
3226 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
3228 * flip.c: (flip_file) Check for off_t separately from fseeko(),
3229 using AC_TYPE_OFF_T.
3231 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
3233 * flip.c: (flip_file) If fseeko() is not available, use long int
3234 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
3235 reporting the problem.
3237 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
3239 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
3240 conflict with stdio.
3242 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
3244 * var-labs.c (var_to_string) Now returns null if the variable is null
3246 * value-labels.c (value_to_string) Made it return null if either the
3247 value or the variable is null.
3249 * hash.c (hsh_clear) Fixed a buglet.
3251 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
3252 with the wrong model.
3254 * casefile.[ch] Added a function to return the casereader.case_idx
3257 * examine.q Implemented the extreme values results.
3259 John Darrington <john@darrington.wattle.id.au>
3261 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
3262 output.[ch] getline.c
3264 Plugged some memory leaks
3266 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
3268 Adopt GSL random number generators, paving the way for providing
3269 the complete suite of random number generators on expressions.
3271 * Makefile.am: Remove random.c, random.h.
3273 * random.c: Removed.
3275 * random.h: Removed.
3277 * algorithm.c: (algo_default_random) Use GSL functions.
3279 * casefile.c: (test_casefile) Use GSL RNG functions.
3281 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
3284 * sample.c: (cmd_sample) Use GSL RNG functions.
3285 (sample_trns_proc) Ditto.
3287 * set.q: (static var set_seed) Removed.
3288 (static var seed_flag) Removed.
3289 (static var rng) New variable.
3290 (aux_stc_custom_seed) No seed value anymore, don't print anything.
3291 (stc_custom_seed) Use new seed functions.
3292 (seed_is_set) Removed.
3293 (get_rng) New function that composes the entire external
3295 (set_rng) New function.
3296 (random_seed) New function.
3298 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
3300 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
3301 John Darrington <john@darrington.wattle.id.au> for reporting this
3304 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
3306 * permissions.c command.def Added the PERMISSIONS command
3308 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
3310 * q2c.c: (dump_header) Don't try to emit #includes at very top of
3311 output file because that will precede #include <config.h>, which
3313 (main) Add needed headers to /* (header) */ code.
3315 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
3317 Instead of making system or portable file readers responsible for
3318 dropping and reordering variables, make them read full cases and
3319 let the caller take care of any changes.
3321 * get.c: New "case map" structure to handle this. Use for GET,
3322 IMPORT, MATCH FILES. Essentially rewrite the whole file.
3324 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
3325 changed appropriately.
3327 * sfm-read.c: (sfm_read_case) Ditto.
3329 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
3331 Decided that case_serialize() and case_unserialize() were too
3332 abstract. Also we need a couple more functions to avoid excessive
3333 copying for data in/out fast paths.
3335 * case.c: (case_serial_size) Removed.
3336 (case_serialize) Rename case_to_values() and make its argument
3337 explicitly an array of union values.
3338 (case_unserialize) Rename case_from_values() and make its argument
3339 explicitly an array of union values.
3340 (case_data_all) New function.
3341 (case_data_all_rw) New function.
3343 * casefile.c: (struct casefile) Change buffer from array of
3344 unsigned char to array of union value for better accuracy.
3345 Redefine buffer_used and buffer_size in terms of values, not
3346 bytes. Remove case_size because it is now redundant with
3347 value_cnt. Fix up all references to these members.
3349 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
3351 * barchart.c: (struct subcat) Make `label' member const to silence
3352 GCC warning with -Wwrite-strings.
3354 * cartesian.c: (struct dataset) Ditto.
3356 * case.c: Don't re-define NDEBUG if already defined.
3357 Add lots of comments.
3359 * str.c: Fix includes.
3361 * crosstabs.q: Fix includes.
3363 * examine.q: Fix includes. Fix GCC warning about unused
3366 * frequencies.q: (stat macro) Removed and replaced where used by
3369 * list.q: Fix includes.
3371 * oneway.q: Fix includes.
3373 * piechart.c: Fix includes. Only define M_PI if not already
3376 * sfm-read.c: (bswap) New function.
3377 (bswap_int32) Write in terms of bswap.
3378 (bswap_flt64) Ditto.
3380 * str.c: (ds_data) Add external definition here, needed because
3381 str.h has only an `extern inline' version.
3383 * value-labels.c: Fix includes.
3385 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
3387 Instead of providing a system or portable file writer with a raw
3388 case in the format needed for output, provide it with a regular
3389 case. The writer takes care of any needed translation.
3391 * aggregate.c: Adopt new scheme for AGGREGATE.
3392 (struct agr_proc) sfm_agr_case member removed.
3393 (write_case_to_sfm) Removed because the new interface is easier to
3396 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
3398 * pfm-write.c: Implement new scheme.
3400 * sfm-write.c: Ditto.
3402 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
3404 Instead of treating `struct file_handle' as a class to subclass
3405 into data files, system files, and portable files, instead use it
3406 as a helper that coordinates access. Now it is opaque, too.
3408 This means that most references to a struct file_handle are now
3409 changed into references to one of struct dfm_reader, struct
3410 dfm_writer, struct sfm_reader, struct sfm_writer, struct
3411 pfm_reader, or struct pfm_writer, according to what's being read
3414 Most related changes are only worth summarizing briefly.
3416 * dictionary.c: (dict_clear) Destroy aux data in deleted
3418 (dict_clear_aux) New function.
3419 (dict_create_var) Initialize aux, aux_dtor.
3420 (dict_delete_var) Destroy aux data in deleted variable.
3422 * file-handle.h: (struct fh_ext_class) Removed.
3423 (struct file_handle) Removed.
3424 (fh_init_files) Removed.
3426 * file-handle.q: Changed references to a handle's `private' member
3427 to direct references.
3428 (struct private_file_handle) Renamed file_handle.
3429 Add next, open_cnt, type, open_mode, aux members.
3430 (struct file_handle_list) Removed.
3431 (extern var inline_file) Removed.
3432 (static var file_handles) Changed from file_handle_list * to
3434 (create_file_handle) Initialize new members.
3435 (fh_close_handle) Removed.
3436 (mode_name) New function.
3437 (fh_open) New function.
3438 (fh_close) New function.
3439 (fh_parse_file_handle) Renamed fh_parse().
3441 * glob.c: (init_glob) Remove fh_init_files() call.
3443 * aggregate.c: use sfm_writer.
3444 (create_sysfile) Removed because the new interface is simpler.
3446 * apply-dict.c: Use sfm_reader.
3448 * data-list.c: Use dfm_reader.
3450 * file-type.c: Use dfm_reader.
3452 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
3454 * inpt-pgm.c: Use dfm_reader.
3456 * print.c: Use dfm_writer.
3458 * sysfile-info: Use sfm_reader.
3460 * dfm-read.c: Adopt new file handle infrastructure.
3462 * dfm-write.c: Ditto.
3464 * pfm-read.c: Ditto.
3466 * pfm-write.c: Ditto.
3468 * sfm-read.c: Ditto.
3470 * sfm-write.c: Ditto.
3472 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
3474 Break dictionary functions into separate header file.
3476 * dictionary.h: New file.
3478 * var.h: Moved dict_*() functions to dictionary.h.
3480 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
3482 Get rid of procedure-specific union in struct variable, using
3483 instead a void * pointer and a destructor function.
3485 Most related changes are only worth brief summaries.
3487 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
3488 old p.crs member in struct variable.
3490 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
3491 of old p.frq member in struct variable.
3493 * histogram.c: (draw_histogram) Takes new freq_tab arg because
3494 it's no longer possible to grab this from var->p.frq.
3496 * piechart.c: (draw_piechart) Ditto.
3498 * group.c: (group_proc_get) New function.
3500 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
3507 * main.c: (execute_command) Clear aux data in default_dict after
3508 each command. (It's debatable whether this should be done.)
3510 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
3511 member in struct variable.
3513 * means.q: Get rid of integer mode, which is not included in
3514 recent SPSS and was the only code that wanted per-variable private
3517 * var.h: (struct crosstab_proc) Removed.
3518 (struct frequencies_proc) Removed.
3519 (struct list_proc) Removed.
3520 (struct get_proc) Removed.
3521 (struct means_proc) Removed.
3522 (struct matrix_data_proc) Removed.
3523 (struct match_files_proc) Removed.
3524 (lots of enums) Removed.
3525 (struct variable) Removed members `p', `get'. Add member
3528 * vars-atr.c: (var_attach_aux) New function.
3529 (var_detach_aux) New function.
3530 (var_clear_aux) New function.
3531 (var_dtor_free) New function.
3532 (discard_variables) Use NULL instead of inline_file.
3534 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
3536 * value-labs.c Fixed the implmentation of value_to_string, so
3537 that it properly handles alpha values.
3539 * oneway.q Changed instances where labels were being probed manually,
3540 to use the canonical {var,value}_to_string functions
3542 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
3544 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
3545 plots. Changed the API of the cartesian plot to be a much lower level
3548 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
3550 * examine.q Added some of the parametric calculations
3552 * factor_stats.[ch] Created
3554 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
3556 * examine.q Changed the definition of factors to be a composite, and
3557 dealt with the consequences.
3559 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
3561 * examine.q Fixed problem where examine wasn't dealing properly with
3564 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
3566 * oneway.q Fixed problem where oneway wasn't dealing properly with
3569 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
3571 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
3572 command which had settings didn't get the appropriate code
3575 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
3576 to convert variables/values to strings.
3578 * examine.q Added framework for the EXAMINE command.
3580 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
3582 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
3583 subcommand types. Changed frequencies.q to use it rather then the
3584 custom parser. Dealt with the consequences. Added a test for NTILES
3585 subcommand of frequencies.
3587 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
3589 * oneway.q Fixed up the behaviour when given missing values
3591 * levene.c oneway.q Fixed a buglet with the levene statistic and
3592 incorporated the levene test into the oneway command.
3594 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
3595 global scope, since they're only relevant to T-TEST
3597 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
3599 * group.c group.h group_proc.h levene.c oneway.q t-test.q
3601 Made the t-test more consistent
3602 with the way it handles groups. That is, it now uses a hash instead
3603 of an array of 2. Also, made the levene.c file independent of the
3604 implementation of the t-test. So now levene should be fine for both
3607 * Added an oneway.q file for one way anova
3609 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
3611 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
3614 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
3618 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
3619 (data_list_trns_free) Free dls->delims.
3621 * t-test.q: (tts_custom_pairs) Free vars.
3622 (ssbox_one_sample_init) Fix tab_vline() argument.
3623 (ssbox_independent_samples_init) Ditto.
3624 (trbox_paired_init) Ditto.
3625 (trbox_one_sample_init) Ditto.
3627 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
3629 Generalize casefiles to the extent that we can use them for
3630 sorting and other kinds of data transformations. Change cases to
3631 be copy-on-write to improve memory efficiency in common cases.
3632 Every access to a member of a `struct ccase' was changed to be a
3633 call to a case_*() function, especially case_data(), case_num(),
3634 case_str(), or case_data_rw(). Many instances of a local variable
3635 named "case_num" were changed to "case_idx" as a consequence.
3636 Many `struct ccase *' were changed to actual `struct ccase'
3637 because of copying semantics of cases. In several places there
3638 was a choice between updating debug code to work with the new ADTs
3639 or just deleting it because it was useless; I chose to delete it.
3641 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
3647 * aggregate.c: (struct agr_proc) Change type of `sort' to
3648 sort_criteria *. Add `break_vars', `break_var_cnt' members.
3649 Rename `vars' to `agr_vars', all references updated. Change
3650 `agr_case' to type `struct ccase'.
3651 (cmd_aggregate) Deal with new members. Use case_create(),
3652 sort_active_file_in_place(), sort_active_file_to_casefile().
3653 (agr_destroy) Deal with new members.
3654 (aggregate_single_case) Ditto.
3655 (dump_aggregate_info) Ditto.
3656 (initialize_aggregate_info) Ditto.
3657 (agr_to_active_file) Ditto.
3658 (presorted_agr_to_sysfile) Ditto.
3659 (sort_agr_to_sysfile) Removed.
3661 * alloc.c: (out_of_memory) Make non-static.
3663 * alloc.h: Prototype out_of_memory().
3665 * casefile.c: Switched from a linked list in-memory representation
3666 to a two-level array-style representation. The linked list was
3667 appropriate when we could stick a header onto cases, but that's no
3668 longer the case. Also, the two-level array will allow for random
3669 in-memory access in case that's ever wanted. Also added the
3670 concept of a `destructive casereader', one that destroys cases in
3671 the underlying casefile as they are read out.
3672 (macro CASES_PER_BLOCK) New macro.
3673 (struct casefile) New members `value_cnt', `case_list_size',
3674 `case_acct_size', `being_destroyed', `cases'. Removed `head',
3676 (struct casereader) Removed `cur'. Added `destructive', `c'.
3677 (global var casefiles) Made static.
3678 (static var case_bytes) New var.
3679 (casefile_create) Takes a value count, not a case size in bytes,
3680 to conform to the case interface. All callers updated. Deal with
3681 new and removed members.
3682 (casefile_destroy) Deal with new and removed members.
3683 (casefile_sleep) New function.
3684 (casefile_get_case_size) Removed.
3685 (casefile_get_value_cnt) New function.
3686 (casefile_append) Rewritten to deal with new and removed members.
3687 (casefile_append_xfer) New function.
3688 (write_case_to_disk) Use case_serialize().
3689 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
3690 Couldn't figure out why.
3691 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
3692 deal with new and removed members.
3694 (merge_sort) Removed.
3695 (casefile_sort) Removed.
3696 (casefile_get_reader) Deal with new and removed members.
3697 (casefile_get_destructive_reader) New function.
3698 (reader_open_file) Make code more readable. Create case for
3700 (casereader_get_casefile) New function.
3701 (casereader_read) Deal with new and removed members. Now returns
3702 a copy of the case, so that the caller is responsible for
3703 destroying the returned case.
3704 (casereader_read_xfer) New function.
3705 (casereader_destroy) Destroy reader's case.
3706 (test_casefile) Second arg is now a value count, all callers
3707 updated. Now tests destructive readers too.
3708 (get_random_case) Deal with new case ADT.
3709 (write_random_case) Ditto.
3710 (read_and_verify_random_case) Ditto.
3712 * crosstabs.q: Remove debug code.
3714 * descript.q: (calc_descriptives) Deal with new case, casefile
3717 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
3719 * do-if.c: Remove unneeded header inclusion.
3721 * expr-prs.c: Remove debug code.
3723 * exprP.h: Remove debug code.
3725 * flip.c: (flip_file) Use fseeko() if available.
3727 * formats.c: Remove debug code.
3729 * get.c: Remove debug code.
3730 (struct mtf_file) Change `input' from `union value *' to `struct
3731 ccase', all references updated.
3733 * levene.c: (levene) Deal with new case, casefile ADTs.
3735 * list.q: Remove debug code.
3737 * loop.c: Remove debug code.
3739 * matrix-data.c: Remove debug code.
3741 * means.q: Remove debug code.
3743 * mis-val.c: Remove debug code.
3745 * pfm-read.c: Remove debug code.
3746 (pfm_read_code) Change second arg from `union value *' to `struct
3747 ccase *', all references updated.
3749 * recode.c: (string_to_long) Make first arg const.
3750 (convert_to_double) Ditto.
3752 * repeat.c: Remove debug code.
3754 * sample.c: Remove debug code.
3756 * sfm-read.c: Remove debug code.
3757 (sfm_read_case) Change second arg from `union value *' to `struct
3760 * sort.c: Redone in terms of casefiles.
3761 (enum sort_direction) Moved here from sort.h.
3762 (struct sort_criterion) New structure.
3763 (struct sort_criteria) New structure.
3764 (cmd_sort_cases) Rewritten.
3765 (prepare_to_sort_active_file) New function.
3766 (sort_active_file_in_place) New function.
3767 (sort_active_file_to_casefile) New function.
3768 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
3769 changed, all callers updated.
3770 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
3771 rewritten & interface changed, all callers updated.
3772 (sort_cases) Renamed sort_execute(), rewritten & interface
3773 changed, all callers updated.
3774 (struct internal_sort) Removed.
3775 (do_internal_sort) Rewritten, interface changed.
3776 (destroy_internal_sort) Removed.
3777 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
3778 (struct initial_run) Removed; an initial run is now just a
3780 (compare_initial_runs) Rewritten.
3781 (struct external_sort) Changed almost completely.
3782 (do_external_sort) Rewritten, interface changed.
3783 (destroy_external_sort) Rewritten.
3784 [HAVE_MKDTEMP] (make_temp_dir) Removed.
3785 [!HAVE_MKDTEMP] (do_mkdir) Removed.
3786 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
3787 (init_external_sort) Removed.
3788 (simulate_error) Removed.
3789 (rmdir_temp_dir) Removed.
3790 (get_temp_file_name) Removed.
3791 (open_temp_file) Removed.
3792 (close_temp_file) Removed.
3793 (remove_temp_file) Removed.
3794 (write_temp_file) Removed.
3795 (read_temp_file) Removed.
3796 (struct record_run) Change `record' from `struct case_lit *' to
3798 (struct initial_run_state) Remove `idx_to_fv', `free_list',
3799 `file_idx', `output_file'. Add `run', casefile'. Change
3800 `last_output' from `struct case_list *' to `struct ccase'.
3801 (write_initial_runs) Change interface, rewrite.
3802 (sort_sink_write) Renamed process_case(), changed interfaced,
3804 (destroy_initial_run_state) Rewritten.
3805 (allocate_cases) Rewritten.
3806 (compare_record) Interface changed, rewritten.
3807 (start_run) Rewritten.
3808 (end_run) Rewritten.
3809 (output_record) Rewritten.
3810 (grab_case) Removed.
3811 (release_case) Removed.
3812 (struct merge_case) Change `cases' from double pointer to single
3814 (merge) Deal with new case and casefile ADTs.
3815 (struct run) Removed.
3816 (merge_once) Rewritten, interface changed.
3817 (fill_run_buffer) Removed.
3818 (sort_sink_make_source) Removed.
3819 (sort_sink_class) Removed.
3820 (struct sort_source_aux) Removed.
3821 (sort_source_read_helper) Removed.
3822 (sort_source_read) Removed.
3823 (read_sort_output) Removed.
3824 (read_internal_sort_output) Removed.
3825 (read_external_sort_output) Removed.
3826 (sort_source_destroy) Removed.
3827 (sort_source_class) Removed.
3829 * sort.h: (struct sort_cases_pgm) Removed.
3830 (enum sort_direction) Moved to sort.c.
3832 * t-test.q: (calculate) Deal with new case, casefile ADTs.
3834 * tab.c: Remove debug code.
3836 * var-labs.c: Remove debug code.
3838 * var.h: (struct ccase) Removed.
3839 (struct case_list) Removed.
3841 * vars-atr.c: (discard_variables) Use free_case_source().
3843 * vars-prs.c: (parse_vs_variable) Make arg const.
3844 (parse_dict_variable) Ditto.
3845 (parse_variables) Make struct dictionary * arg const.
3846 (parse_var_set_vars) Make struct var_set * arg const.
3847 (struct var_set) Add const to some of the function pointers' args.
3848 (var_set_get_cnt) Make arg const.
3849 (var_set_get_var) Make first arg const.
3850 (var_set_lookup_var) Make first arg const.
3851 (dict_var_set_get_cnt) Make arg const.
3852 (dict_var_set_get_var) Make first arg const.
3853 (dict_var_set_lookup_var) Make first arg const.
3854 (var_set_create_from_dict) Make arg const. Add cast to aux
3856 (struct array_var_set) Add const to var member.
3857 (array_var_set_get_cnt) Make arg const.
3858 (array_var_set_get_var) Make first arg const.
3859 (array_var_set_lookup_var) Make first arg const.
3860 (var_set_create_from_array) Make first arg const. Insert cast.
3862 * vfm.c: (struct write_case_data) Change trns_case, sink_case
3863 members from `struct ccase *' to `struct ccase'.
3864 (static var lag_queue) Change from double to single pointer.
3865 (procedure) Optimize trivial case.
3866 (internal_procedure) Deal with changed case, case_source ADTs.
3867 (create_trns_case) Changed interface, rewrote.
3868 (open_active_interface) Initialize modified lag queue.
3869 (write_case) Deal with changed case ADT.
3870 (lag_case) Deal with modified lag queue.
3871 (close_active_file) Destroy modified lag queue.
3872 Deal with changed case_source, case_sink ADTs.
3873 (destroy_storage_stream_info) Make null arg into no-op.
3874 (storage_sink_make_source) Set aux in created source.
3875 (storage_source_read) Deal with changed case, casefile ADTs.
3876 (storage_source_create) New function.
3877 (lagged_case) Rewrite.
3878 (free_case_source) New function.
3879 (free_case_sink) Rewrite.
3880 (struct split_aux_data) Changed prev_case from `struct ccase *' to
3882 (procedure_with_splits) Deal with changed prev_case.
3883 (procedure_with_splits_callback) Ditto.
3884 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
3886 (multipass_procedure_with_splits) Deal with changed prev_case.
3887 (multipass_split_callback) Ditto.
3890 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
3892 The workspace idea didn't work out.
3894 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
3896 * workspace.c: Removed.
3898 * workspace.h: Removed.
3900 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
3902 Fully implement arbitrary delimiters on DATA LIST, extending the
3903 half implementation that was already there.
3905 * data-list.c: (struct data_list_pgm) Remove `delim', add
3906 `delims', `delim_cnt'.
3907 (cmd_data_list) Initialize new members. Parse delimiters and
3908 clean up code a bit.
3909 (cut_field) Extract fields with arbitrary delimiters. Also, fix
3910 handling of leading commas.
3911 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
3913 (read_from_data_list_free) Adapt to new DFM interfaces.
3914 (read_from_data_list_list) Ditto.
3915 (repeating_data_trns_proc) Ditto.
3917 * dfm.c: Split up reader and writer into separate code, because
3918 they do different things. Use struct string instead of explicit
3919 allocation code, for clarity.
3920 (enum dfm_reader_flags) New enum.
3921 (struct dfm_fhuser_ext) Removed.
3922 (struct dfm_reader_ext) New.
3923 (get_reader) New function, used by just about all the reader
3925 (dfm_close) Removed.
3926 (close_reader) New function.
3927 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
3928 (dfm_open_for_writing) Ditto.
3929 (macro force_line_buffer_expansion) Removed.
3930 (count_tabs) Removed.
3931 (tabs_to_spaces) Removed.
3932 (read_record) Deal with new dfm_reader_ext. Use struct string
3933 functions. Don't convert tabs to spaces.
3934 (dfm_eof) New function.
3935 (dfm_get_record) Changed interface, rewrote.
3936 (dfm_expand_tabs) New function.
3937 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
3938 dfm_reader_ext, rewritten.
3939 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
3940 dfm_reader_ext, rewritten.
3941 (dfm_set_record) Removed in favor of dfm_forward_columns().
3942 (dfm_forward_columns) New function.
3943 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
3944 dfm_reader_ext, rewritten.
3945 (static var dfm_r_class) Use close_reader for the destructor.
3946 (struct dfm_writer_ext) New.
3947 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
3948 bounce buffer now instead of local allocation.
3949 (close_writer) New function.
3950 (static var dfm_writer_ext) Use close_writer for destructor.
3951 (cmd_begin_data) Adapt to new dfm_reader_ext.
3953 * file-handle.q: Add support for per-file tab width.
3954 (struct private_file_handle) Add tab_width member.
3955 (q2c specifications) Add tabwidth subcommand.
3956 (cmd_file_handle) Put parsed tab width into private_file_handle.
3957 (create_file_handle) Set default tab width.
3958 (handle_get_tab_width) New function.
3960 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
3962 * inpt-pgm.c: (reread_trns_proc) Ditto.
3964 * matrix-data.c: (context) Ditto.
3965 (another_token) Ditto.
3969 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
3971 * casefile.c: (casefile_destroy) Fix memory leak by freeing
3973 (casereader_destroy) Don't close file descriptor -1.
3975 * recode.c: (cmd_recode) Fix memory leak.
3977 * set.q: (q2c specifications) Fix typo in user message.
3979 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
3980 undefined behavior for overlapping arguments.
3982 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
3984 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
3985 don't call it when we're running under valgrind.
3986 (call_posix_fadvise) New function.
3987 (casefile_to_disk) Use call_posix_fadvise().
3988 (reader_open_file) Ditto.
3990 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
3992 Update our string ADTs, struct string and struct len_string. Get
3993 rid of pool support, which was largely unused. Rename lots of
3994 functions to have more obvious or consistent names.
3996 * ascii.c: Get rid of ascii_pool. It was only used for string
3998 (ascii_open_global) Don't create ascii_pool.
3999 (ascii_close_driver) Don't destroy ascii_pool.
4000 (ascii_postopen_driver) Don't use pool.
4001 (ascii_close_driver) Destroy strings manually.
4003 * str.c: (ds_create) Remove pool argument, all references updated.
4005 (ds_replace) Remove pool support, make more efficient when we
4006 don't need to reallocate.
4007 (ds_destroy) Remove pool support.
4008 (ds_rpad) New function.
4009 (ds_size) Renamed ds_capacity(), all references updated.
4010 (ds_value) Renamed ds_c_str(), all references updated.
4011 (ds_concat) Renamed ds_puts(), all references updated.
4012 (ds_concat_buffer) Renamed ds_concat(), all references updated.
4013 (ds_putchar) Renamed ds_putc(), all references updated.
4014 (ds_getline) Renamed ds_gets(), all references updated.
4015 (ls_create) Remove pool argument, all references updated.
4016 (ls_create_buffer) Ditto.
4017 (ls_destroy) Removed pool support.
4018 (ls_value) Renamed ls_c_str(), all references updated.
4020 * str.h: (ls_length) [__GNUC__] Add inline version.
4021 (ls_c_str) [__GNUC__] Add inline version.
4022 (ls_end) [__GNUC__] Add inline version.
4023 (struct string) Remove pool member. Rename `size' to `capacity',
4024 all references updated.
4026 * tab.c: (text_format) Instead of using pool argument to
4027 ls_create_buffer(), call pool_register() on allocated data.
4029 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
4031 We're abusing the current ASCII driver by telling it to allocate a
4032 9999-line, 9999-character page in the tests. This causes some
4033 systems to curl up and die because it allocates 20 MB of
4034 contiguous RAM. This change alleviates at least part of the
4035 problem. It is mostly a stop-gap until the new output system is
4038 * ascii.c: (struct line) New structure.
4039 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
4040 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
4041 (ascii_preopen_driver) Initialize new members, not old ones.
4042 (ascii_close_driver) Destroy new members, not old ones.
4043 (ascii_open_page) Allocate new members, not old ones.
4044 (expand_line) Allocate room in line.
4045 (draw_line) Use new members.
4046 (ascii_line_horz) Ditto.
4047 (ascii_line_vert) Ditto.
4048 (ascii_line_intersection) Ditto.
4050 (output_lines) Ditto.
4051 (ascii_close_page) Ditto.
4053 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
4055 * matrix.c: Dead code. Removed.
4057 * matrix.h: Dead code. Removed.
4059 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
4061 Contrary to what I'd always understood, there is an efficient
4062 algorithm for deletion from a hash table populated via linear
4063 probing. This change implements it.
4065 * hash.c: (hsh_rehash) Probe in increasing order.
4067 (locate_matching_entry) Ditto.
4068 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
4070 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
4072 * moments.c (calc_moments): Adjust calculation of kurtosis to
4073 avoid subtracting huge numbers from huge numbers, on Michael
4076 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
4078 Rework moments routines for improved numerical stability based on
4079 Michael Kiefte's advice. Any bugs or remaining numerical problems
4080 are still mine though.
4082 There is now a struct moments1 for use with one-pass moments. It
4083 uses a provisional means algorithm as an attempt to improve
4084 accuracy of higher moments. The older struct moments now only
4085 handles two-pass moments.
4087 * aggregate.c: Use moments1 instead moments.
4089 * descript.c: Revert previous change, which is no longer needed
4090 due to the moments revision.
4092 * moments.c: (calc_moments) New function for calculating variance,
4094 (moments_pass_one) Only accumulate weights bigger than zero.
4095 (moments_calculate) Allow calculating the mean on pass one, others
4096 require pass two. Implement in terms of calc_moments().
4097 (struct moments1) New structure.
4098 (init_moments1) New function.
4099 (moments1_clear) Ditto.
4100 (moments1_create) Ditto.
4101 (moments1_add) Ditto.
4102 (moments1_calculate) Ditto.
4103 (moments1_destroy) Ditto.
4104 (cmd_debug_moments) Deal with `struct moments' or `struct
4105 moments1' as requested by user.
4107 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
4109 * Makefile.am (pspp_SOURCES): Remove debug.c.
4111 * debug.c: Removed. It was empty anyway.
4113 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
4115 * descript.c (calc_descriptives): Fix assert failure when only
4116 MOMENT_MEAN is needed.
4118 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
4122 fixed problem with parsing in match_statistic() causing
4123 "DESCRIPTIVE STAT=MEAN." to barf.
4125 "MEAN" is now default if "SORT" given without specification.
4127 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
4128 generally less forgiving of syntax errors: better to have it do
4129 nothing and type it in again then to not know what it actually did
4132 z-score transformation now checks score for user-missing values
4133 and checks std_dev for SYSMIS.
4135 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
4137 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
4138 Changed dict_get_case_weight() to accept an additional int * flag
4139 to complain about system-missing, user-missing, zero, or negative
4140 weights and updated existing functions to pass int * to
4141 dict_get_case_weight().
4143 2004-04-05 jmd <jmd@gnu.org>
4145 * main.c: Fixed configuration problems with gsl
4147 * t-test.q: Fixed some problems encountered when compiling under Cygwin
4149 2004-04-03 blp <blp@gnu.org>
4151 * lexer.c, ChangeLog:
4152 Fix infinite loop on comment at end of file, add test.
4154 2004-04-03 jmd <jmd@gnu.org>
4156 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
4157 Fixed the calculation of percentiles and added --syntax and --algorithm options
4159 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
4161 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
4164 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
4166 * frequencies.q: Fixed the calculation of percentiles
4168 * Makefile.am: Added the --ansi flag and dealt with the
4169 consequences. Added some entries to PSPP_sources so that
4170 make distcheck would pass
4172 * cmdline.c: Added the --syntax and --algorithm options
4174 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
4176 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4178 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
4179 use the new multipass_split_... mechanism.
4181 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
4183 * frequencies.q: (calc_stats) Use moments data structure and
4184 calc_seskew(), calc_sekurt() functions.
4186 * set.q main.c settings.h Added support for --syntax and --algorithm
4189 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
4191 * vfm.c: Had to get last call to multipass_split_output() inside
4192 open_active_file()/close_active_file() pairing, so introduce new
4194 (internal_procedure) Move procedure() code here, except for calls
4195 to open_active_file() and close_active_file().
4196 (procedure) Wrap open_active_file() and close_active_file() around
4197 internal_procedure().
4198 (multipass_procedure_with_splits) Wrap open_active_file() and
4199 close_active_file() around internal_procedure().
4201 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
4203 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
4205 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
4207 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
4209 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
4211 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
4213 * algorithm.c: By default turn off some of the more expensive
4215 (expensive_assert) New macro which expands to assert if
4216 EXTRA_CHECKS is defined, to nothing otherwise.
4217 (unique) Use expensive_assert().
4218 (binary_search) Ditto.
4224 * command.c: (conflicting_3char_prefixes) Words that are the same
4225 don't cause conflicts when they are abbreviated to the first three
4228 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
4229 nonterm_node's n earlier.
4230 (generic_str_func) Ditto.
4232 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
4234 Add support for multipass procedures. Rewrite DESCRIPTIVES to
4235 test multipass support, take advantage of new moments
4236 calculation, and to not be such crappy code. Get rid of q2c
4237 processing for DESCRIPTIVES.
4239 * vfm.c: (struct multipass_split_aux_data) New structure.
4240 (multipass_procedure_with_splits) New function.
4241 (multipass_split_callback) New function.
4242 (multipass_split_output) New function.
4243 * descript.q: Removed.
4245 * descript.c: New file.
4247 * var.h: Removed descriptives enums.
4248 (struct descriptives_proc) Removed.
4249 (struct variable) Removed p.dsc.
4251 * Makefile.am: (q_sources_c) Remove descript.c.
4252 (q_sources_q) Removed descript.q.
4254 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
4256 New manager for keeping track of used workspace.
4258 * workspace.c: New file.
4260 * workspace.h: New file.
4262 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
4264 * sort.c: (do_internal_sort) Use workspace_malloc().
4265 (destroy_internal_sort) Use workspace_free().
4267 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
4269 New `struct casefile' for managing sets of cases.
4271 * casefile.c: New file.
4273 * casefile.h: New file.
4275 * command.def: Add DEBUG CASEFILE command.
4277 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
4279 * sort.c: (sort_cases) Move logic for sending storage file to disk
4280 into do_external_sort().
4281 (struct internal_sort) Use an array of ccase pointers instead of a
4283 (do_internal_sort) Rewrite to handle casefiles.
4284 (compare_case_list) Removed.
4285 (compare_cases) New function.
4286 (compare_case_dblptrs) New function.
4287 (read_internal_sort_output) Deal with new struct internal_sort.
4289 * vfm.c: (static var workspace_overflow) Removed.
4290 (struct storage_stream_info) Removed all the members. Added
4291 struct casefile * member.
4292 (storage_sink_open) Use casefile.
4293 (open_storage_file) Removed.
4294 (write_storage_file) Removed.
4295 (storage_to_disk) Removed.
4296 (destroy_storage_stream_info) Use casefile.
4297 (storage_sink_write) Use casefile.
4298 (storage_sink_make_source) Use casefile.
4299 (storage_source_count) Use casefile.
4300 (storage_source_read) Use casefile.
4301 (storage_source_on_disk) Removed.
4302 (storage_source_get_cases) Removed.
4303 (storage_source_set_cases) Removed.
4304 (storage_source_get_casefile) New function.
4306 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
4308 New `struct moments' for calculating moments.
4314 * moments.c: New file.
4316 * moments.h: New file.
4318 * command.def: Add DEBUG MOMENTS command.
4320 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
4323 * aggregate.c: Modify AGGREGATE to use the new moments
4324 calculation, even if not in such a great way.
4325 (struct agr_var) Add `moments' member.
4326 (parse_aggregate_functions) Set `moments' member to null.
4327 (agr_destroy) Destroy `moments' member.
4328 (accumulate_aggregate_info) Use `moments' for standard deviation.
4329 (dump_aggregate_info) Ditto.
4330 (initialize_aggregate_info) Create or clear `moments'.
4332 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
4333 cube(), pow4() that were in stats.h. All references updated.
4335 * crosstabs.q: stats.h had chi-square significance functions. Use
4337 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
4339 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
4340 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
4342 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
4344 * dictionary.c: (dict_compact_values) Compacted values need to
4347 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
4349 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
4350 `/' at start. Check return value of parse_variables() for error
4353 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
4355 Revamp expressions: make the code a little nicer, and fix bugs
4358 * expr-evl.c: (expr_evaluate) Make expression argument const.
4359 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
4360 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
4361 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
4362 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
4363 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
4364 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
4365 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
4366 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
4367 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
4368 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
4369 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
4370 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
4371 Simplify OP_SYSMIS. Remove OP_STR_MIS.
4373 * expr-opt.c: (optimize_expression) Rewrite.
4378 (macro s0l) Removed.
4380 (macro s1l) Removed.
4382 (macro s2l) Removed.
4385 (eq_num_con) New function.
4386 (optimize_tree) New function.
4387 (macro rnc) Removed.
4388 (macro frnc) Removed.
4389 (str_search) Add const to string params.
4390 (str_rsearch) Ditto.
4391 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
4392 str[], str_len[] locals to substitute for most of removed macros.
4393 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
4394 Removed support for missing values because we're never called with
4395 missing values. Use set_number() or set_number_errno() instead of
4396 rnc or frnc. Removed any stuff that caused trouble in testing.
4397 We can re-add it later if it really slows anything. Fix some
4399 (evaluate_tree_with_missing) Not yet supported. To be added later
4401 (repl_num_con) Removed.
4402 (collapse_node) New function.
4403 (force_repl_num_con) Removed.
4404 (set_number) New function.
4405 (set_number_errno) New function.
4406 (repl_str_con) Removed.
4407 (set_string) New function.
4408 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
4410 (dump_node) No special case for OP_AND, OP_OR.
4412 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
4413 (expr_get_type) New function.
4414 (type_check) Rewrite.
4415 (type_coercion) New function.
4416 (struct operator) New structure.
4417 (match_operator New function.
4418 (parse_binary_operators) New function.
4419 (parse_inverting_unary_operator) New function.
4420 (parse_or) Rewritten.
4421 (parse_and) Rewritten.
4422 (parse_not) Rewritten.
4423 (parse_rel) Rewritten.
4424 (parse_add) Rewritten.
4425 (parse_mul) Rewritten.
4426 (parse_neg) Rewritten.
4427 (parse_exp) Rewritten.
4428 (parse_sysvar) Add $TRUE, $FALSE system variables.
4429 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
4430 (parse_primary) Use allocate_var_node(), allocate_num_con(),
4432 (struct function) Remove desc, change `func' prototype.
4433 (unary_func) Remove special cases.
4434 (MISSING_func) Reduce to unary_func() that just returns a boolean.
4435 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
4436 (VALUE_func) Use allocate_var_node().
4437 (nary_num_func) Allow MIN and MAX for strings.
4438 Use allocate_var_node(). Properly clean up.
4440 (generic_str_func) Use local table instead of removed `desc'
4441 member. Mostly rewrite.
4442 (get_num_args) Revise error message.
4443 (parse_function) Return EXPR_ERROR, not 0 on error.
4445 (macro varies) Removed.
4446 (ops[]) Use expr.def.
4447 (free_node) Do nothing if node is null.
4448 (allocate_num_con) New function.
4449 (allocate_str_con) New function.
4450 (allocate_var_node) New function.
4451 (allocate_binary_nonterminal) New function.
4452 (append_nonterminal_arg) Removed.
4453 (static var func_tab[]) Revised.
4454 (expr_debug_print_postfix) Make parameter const.
4455 Use printf() instead of debug_printf().
4457 * expr.def: New file.
4459 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
4460 use named enum instead of unnamed, all references updated. Add
4461 EXPR_ANY, EXPR_NO_OPTIMIZE.
4463 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
4464 instead of defining OP_* directly.
4465 (macro IS_TERMINAL) New macro.
4466 (macro IS_NONTERMINAL) New macro.
4467 (enum OP_NO_FLAGS) New.
4469 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
4471 * error.c: (err_assert_fail) msg variable needs to be non-const.
4473 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
4475 * debug.c: (cmd_debug_evaluate) Rewrite.
4477 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
4479 Fix some CROSSTABS bit rot stupidity.
4481 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
4482 (internal_cmd_crosstabs) Initializes cells[] correctly.
4483 (float_M_suffix) Rename format_cell_entry(), change prototype,
4485 (display_crosstabulation) Fix cell formatting.
4487 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
4489 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
4490 to call lex_discard_line() to do that.
4492 * command.c: (run_command) Call lex_discard_line() after
4495 * lexer.c: (lex_entire_end) Change behavior.
4496 (lex_rest_of_line) Change behavior. Return const char *.
4497 (lex_discard_line) Don't clear getl_buf, don't emit message.
4499 * main.c: (handle_error) Emit message here.
4501 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
4502 instead of lex_entire_line().
4504 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
4506 * title.c: (get_title) Call lex_discard_line() after
4508 (cmd_file_label) Ditto.
4509 (cmd_document) Deal with const char * return value.
4511 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
4513 Removed REMARK command.
4515 * command.c: (extract_prefix) Removed.
4516 (output_line) Removed.
4517 (cmd_remark) Removed.
4519 * command.def: Remove REMARK.
4521 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
4523 Added abort() after lots of assert(0) invocations to avoid some
4524 compiler warnings. We really need a NOT_REACHED macro.
4526 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4528 * sort.c: Added missing call to temp_file_close. Changed error
4529 messages to warnings.
4531 * set.q: Improved setting of set_view{length,width} to be more tolerant
4534 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
4536 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
4537 used with incorrect syntax.
4539 * error.c, error.h et al: Overridden definition of assert for a
4542 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
4543 subcommand was given when it ought to have been.
4545 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
4547 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
4551 (tab_joint_text) Ditto.
4553 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
4555 * levene.c: Add #include.
4557 * set.q: (set_viewport) Add `int' argument to make its prototype
4558 correct for signal().
4560 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
4562 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
4565 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
4567 Changed DFM from open-at-first-access to explicit-open. Before,
4568 calling dfm_get_record() or dfm_put_record() would automatically
4569 open the file. Now, you have to call dfm_open_for_reading() or
4570 dfm_open_for_writing() explicitly. This makes it possible to
4571 check permissions, file existence, etc. earlier.
4573 Also made struct file_handle more opaque, and clean up in general.
4575 * data-list.c: (cmd_data_list) Open handle for reading.
4577 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
4579 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
4580 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
4581 (open_inline_file) Removed.
4582 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
4583 it. Deal with line_number in extension record instead of file
4585 (dfm_get_record) Rewrote.
4586 (dfm_put_record) Rewrote.
4587 (dfm_push) Assert file is open and one of ours. Deal with
4588 line_number in extension record instead of file handle.
4589 (dfm_pop) Assert file is open and one of ours. Deal with
4590 line_number in extension record instead of file handle.
4591 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
4594 * file-handle.h: (enum constants RH_RF_*) Removed.
4595 (enum constants FH_MD_*) Removed.
4596 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
4597 `recform', `lrecl', `mode' members. Public references to
4598 `recform' changed to use handle_get_mode(), references to `lrecl'
4599 changed to use handle_get_record_width(). Added `private' member.
4600 (enum file_handle_mode) New.
4602 * file-handle.q: (struct private_file_handle) New structure.
4603 (struct file_handle_list) New structure.
4604 (static var files) New.
4605 (static var file_handles) Removed.
4606 (init_file_handle) Removed.
4607 (create_file_handle) Removed.
4608 (get_handle_with_name) New function.
4609 (get_handle_for_filename) New function.
4610 (cmd_file_handle) Rewritten.
4611 (hash_file_handle) Removed.
4612 (cmp_file_handle) Removed.
4613 (fh_init_files) Rewritten.
4614 (fh_parse_file_handle) Rewritten. Allows identifiers as
4616 (fh_get_handle_by_name) Renamed handle_get_name(), all references
4618 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
4619 references updated. Rewritten.
4620 (fh_record_width) Renamed handle_get_record_width(), all
4621 references updated. Rewritten.
4622 (handle_get_mode) New function.
4624 * file-type.c: (cmd_file_type) Open handle for reading.
4626 * filename.c: [unix] (struct file_identity) New structure.
4627 [unix] (fn_get_identity) New function.
4628 [unix] (fn_free_identity) New function.
4629 [unix] (fn_compare_file_identities) New function.
4630 [!unix] (struct file_identity) New structure.
4631 [!unix] (fn_get_identity) New function.
4632 [!unix] (fn_free_identity) New function.
4633 [!unix] (fn_compare_file_identities) New function.
4635 * lexer.c: (static var put) Renamed put_token, all references
4637 (static var put_tokstr) New.
4638 (static var put_tokval) New.
4639 (lex_init) Initialize put_tokstr().
4640 (restore_token) New function.
4641 (save_token) New function.
4642 (lex_get) Use restore_token().
4643 (lex_put_back) Use save_token().
4644 (lex_put_back_id) New function.
4645 (lex_put_forward) Removed.
4646 (lex_preprocess_line) Set put_token instead of using
4648 (lex_negative_to_dash) Use save_token(), set put_token directly.
4649 (dump_token) Use stderr instead of stdout.
4651 * main.c: (main) Remove call to cmd_init().
4653 * matrix-data.c: (cmd_matrix_data) Open file for reading.
4655 * pfm-read.c: Use handle_get_filename() instead of trying to use
4656 h->fn directly, all over.
4658 * pfm-write.c: Ditto.
4660 * print.c: (internal_cmd_print) Open handle for writing.
4661 (dump_table) Use handle_get_filename().
4662 (print_trns_proc) Use handle_get_mode().
4663 (cmd_print_space) Use fh_parse_file_handle().
4664 Open handle for writing.
4665 [0] (debug_print) Removed.
4667 * sfm-read.c: Use handle_get_filename() instead of trying to use
4668 h->fn directly, all over.
4670 * sfm-write.c: Ditto.
4672 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
4676 * autorecode.c: (arc_free) Free arc->src_values.
4678 * error.c: (msg) Free buf.
4680 * val-labs.c: (do_value_labels) Always free vars.
4682 * vfm.c: (close_active_file) If sink has no make_source then call
4683 its destroy function.
4685 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
4687 Fixed cmd_parse() so that it always skips past a full command
4688 name. A few special commands for which this would be bad get
4689 special treatment. This lets us drop code for skipping past the
4690 end of a command name in most cmd_*() functions. It's not worth
4691 listing all the commands affected.
4693 * command.c: (struct command) Remove `cmd' member, replace by
4694 `name' member, all references updated. Remove `word', `next',
4695 `skip_entire_name' members.
4696 (macro DEFCMD) Deal with revised `struct command'.
4697 (macro UNIMPL) Ditto.
4698 (macro SPCCMD) New macro for commands whose last word shouldn't be
4700 (static array cmd_table[]) Make const, rename `commands', remove
4702 (macro COMMAND_CNT) New macro.
4703 (split_words) Removed.
4705 (FILE_TYPE_okay) Make parameter const.
4706 (cmd_parse) Improve error messages.
4707 (match_strings) New function.
4708 (next_word) New function.
4709 (enum command_match) New enum.
4710 (conflicting_3char_prefixes) New function.
4711 (conflicting_3char_prefix_command) New function.
4712 (cmd_match_words) New function.
4713 (count_matching_commands) New function.
4714 (get_command_name) New function.
4715 (free_words) New function.
4716 (unknown_command_error) New function.
4717 (figure_out_command) Renamed parse_command_name(), rewritten.
4719 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
4720 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
4721 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
4724 * command.h: (macro SPCCMD) New.
4726 * include.c: (cmd_include_at) Removed.
4727 (cmd_include) Allow identifier to be used as filename.
4729 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
4731 * t-test.q: (cmd_t_test) Command name is now parsed for us.
4734 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
4736 Start work on better test framework.
4738 * Makefile.am: (pspp_sources) Add debug.c.
4740 * debug.c: New file.
4742 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
4743 cmd_debug_evaluate().
4745 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
4747 * expr.h: (enum constant PXP_DUMP) Removed.
4749 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
4751 * set.q: Implemented the SHOW command, and synced it to the existing
4754 Added a handler for SIGWINCH so that viewlength and viewwidth follow
4755 changes as the window size is changed.
4757 Added fallback to set viewlength and viewwidth from LINES and COLUMS
4758 environment variables if other methods are not available.
4760 glob.c: Removed a lot of global variables from glob.c and encapsulated
4763 random.c: Tidied up the way the random seed is set.
4765 str.c: Added a ds_vprintf function.
4767 error.c: Extended dump_message so that messages are always broken at
4770 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
4772 * pfm-write.c: (bufwrite) Write out the correct element for string
4773 variables. From Andreas Streichardt <streichardt@globalpark.de>.
4775 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
4777 Get rid of static and global (!) vars in matrix-data.c.
4779 * matrix-data.c: (static var nr_data) Removed.
4780 (static var nr_factor_values) Removed.
4781 (static var max_cell_index) Removed.
4782 (static var split_values) Removed.
4783 (struct nr_aux_data) New structure.
4784 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
4785 place of static vars, pass to create_case_source() and procedure()
4787 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
4788 struct matrix_data_pgm *.
4789 (nr_read_splits) Ditto.
4790 (nr_read_factors) Ditto.
4791 (nr_output_data) Ditto.
4792 (static var wr_content) Removed.
4793 (global var wr_data) Removed.
4794 (global var wr_current) Removed.
4795 (struct wr_aux_data) New structure.
4796 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
4797 place of static vars, pass to create_case_source() and procedure()
4799 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
4800 instead of matrix_data_pgm *.
4801 (wr_read_splits) Ditto.
4802 (wr_output_data) Ditto.
4803 (wr_read_rowtype) Ditto.
4804 (wr_read_factors) Ditto.
4805 (wr_read_indeps) Ditto.
4807 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
4809 Get rid of static vars in autorecode.c.
4811 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
4812 `n_arc' to `spec_cnt'. All references updated.
4813 (static var v_src) Removed.
4814 (static var v_dest) Removed.
4815 (static var h_trns) Removed.
4816 (static var nv_src) Removed.
4817 (static var descend) Removed.
4818 (static var print) Removed.
4819 (enum direction) New enum.
4820 (struct autorecode_pgm) New structure.
4821 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
4822 Move n_dest local var into struct autorecode_pgm for ease of
4823 clean-up. Use arc_free().
4824 (arc_free) New function.
4825 (recode) Modify to take struct autorecode_pgm * parameter instead
4826 of using statics. Let the caller clean up.
4827 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
4828 instead of statics. Rearrange code a little.
4830 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
4832 Get rid of static, global vars in recode.c. Remove debug code.
4834 * recode.c: (static var head) Removed.
4835 (global var v) Removed.
4836 (global var nv) Removed.
4837 (cmd_recode) New local variables head, v, nv. Initialize and free
4838 v. Don't call debug_print().
4839 [DEBUGGING] (dump_dest) Removed.
4840 [DEBUGGING] (debug_print) Removed.
4842 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
4844 Get rid of static vars in expr-opt.c.
4846 * expr-opt.c: (static var e) Removed.
4847 (static var nop) Removed.
4848 (static var mop) Removed.
4849 (static var ndbl) Removed.
4850 (static var mdbl) Removed.
4851 (static var nstr) Removed.
4852 (static var mstr) Removed.
4853 (static var nvars) Removed.
4854 (static var mvars) Removed.
4855 (struct expr_dump_state) New structure.
4856 (dump_expression) Use new struct expr_dump_state instead of static
4857 vars and pass to functions we call.
4858 (dump_node) Use struct expr_dump_state * parameter.
4860 (emit_num_con) Ditto.
4861 (emit_str_con) Ditto.
4864 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
4866 Get rid of static var in COUNT.
4868 * count.c: (static var head) Move into cmd_count().
4869 (cmd_count) [DEBUGGING] Don't call debug_print.
4870 [DEBUGGING] (debug_print) Removed.
4872 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
4874 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
4876 * val-labs.c: (static var v) Removed.
4877 (static var nv) Removed.
4878 [DEBUGGING] (debug_print) Removed.
4879 (verify_val_labs) Add struct variable **, int parameters.
4880 (get_label) Ditto. Improve error messages, streamline.
4881 (erase_labels) New function for erasing value labels, taking over
4882 part of verify_val_labs()'s function.
4885 (cmd_value_labels) No need to call init() or done() anymore.
4886 (cmd_add_value_labels) Ditto.
4887 (do_value_labels) Add vars, var_cnt local variables. Clean up
4888 after them internally. Call erase_labels() if we should. Don't
4891 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
4893 Get rid of static vars in MATCH FILES.
4895 * get.c: (static var mtf_head) Removed.
4896 (static var mtf_tail) Removed.
4897 (static var mtf_by) Removed.
4898 (static var mtf_n_by) Removed.
4899 (static var mtf_master) Removed.
4900 (static var mtf_seq_num) Removed.
4901 (static var mtf_seq_nums) Removed.
4902 (static var mtf_sink) Removed.
4903 (static var mtf_case) Removed.
4904 (struct mtf_proc) New structure.
4905 (cmd_match_files) Use struct mtf_proc instead of static vars.
4906 (mtf_processing_finish) Ditto.
4908 (mtf_delete_file_in_place) Ditto.
4909 (mtf_read_nonactive_records) Ditto.
4910 (mtf_compare_BY_values) Ditto.
4911 (mtf_processing) Ditto.
4912 (mtf_merge_dictionary) Ditto.
4914 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
4916 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
4918 * dictionary.c: (dict_rename_var) Add assertion.
4919 (dict_contains_var) Check by index instead of name.
4921 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
4923 Get rid of compaction_necessary, compaction_nval, compaction_case.
4924 Redo VFM interface. Replace disk_sink and memory_sink by
4925 storage_sink, disk_source and memory_source by storage_source.
4927 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
4931 (struct write_case_data) Remove `begin_func', `end_func',
4932 `func_aux' members. Add `aux', `trns_case', `sink_case',
4933 `cases_written', `cases_analyzed' members.
4934 (global var compaction_necessary) Make static.
4935 (global var compaction_nval) Removed.
4936 (global var compaction_case) Removed.
4937 (static var case_count) Removed.
4938 (struct procedure_aux_data) Removed.
4939 (struct split_aux_data) Removed.
4940 (procedure) Remove begin_func, end_func parameters. Rewrite.
4941 (static var not_canceled) Removed.
4942 (process_active_file) Removed.
4943 (process_active_file_write_case) Removed.
4944 (process_active_file_output_case) Removed.
4945 (prepare_for_writing) Moved into open_active_file().
4946 (arrange_compaction) Ditto.
4948 (open_active_file) Rewrote.
4949 (write_case) New function.
4950 [DEBUGGING] (index_to_varname) Removed.
4951 (execute_transformations) New function.
4952 (exclude_this_case) Renamed filter_case(), changed interface.
4953 (clear_case) Added struct ccase * parameter to interface.
4954 (close_active_file) Added struct write_case_data * parameter,
4956 (disk_sink_create) Removed.
4957 (disk_sink_destroy) Removed.
4958 (disk_sink_make_source) Removed.
4959 (disk_sink_write) Removed.
4960 (disk_source_count) Removed.
4961 (disk_source_destroy) Removed.
4962 (disk_source_read) Removed.
4963 (global var disk_sink_class) Removed.
4964 (global var disk_source_class) Removed.
4965 (global var memory_sink_class) Removed.
4966 (global var memory_source_class) Removed.
4967 (memory_sink_create) Removed.
4968 (memory_sink_destroy) Removed.
4969 (memory_sink_make_source) Removed.
4970 (memory_sink_write) Removed.
4971 (memory_source_count) Removed.
4972 (memory_source_destroy) Removed.
4973 (memory_source_get_cases) Removed.
4974 (memory_source_read) Removed.
4975 (memory_source_set_cases) Removed.
4976 (struct disk_stream_info) Removed.
4977 (struct memory_sink_info) Removed.
4978 (struct memory_source_info) Removed.
4979 (write_active_file_to_disk) Removed.
4980 (destroy_storage_stream_info) New function.
4981 (global var null_sink_class) New var.
4982 (global var storage_sink_class) New var.
4983 (global var storage_source_class) New var.
4984 (open_storage_file) New function.
4985 (storage_sink_destroy) New function.
4986 (storage_sink_make_source) New function.
4987 (storage_sink_open) New function.
4988 (storage_sink_write) New function.
4989 (storage_source_count) New function.
4990 (storage_source_destroy) New function.
4991 (storage_source_get_cases) New function.
4992 (storage_source_on_disk) New function.
4993 (storage_source_read) New function.
4994 (storage_source_set_cases) New function.
4995 (storage_source_to_disk) New function.
4996 (storage_to_disk) New function.
4997 (struct storage_stream_info) New structure.
4998 (write_storage_file) New function.
4999 (procedure_write_case) Removed.
5000 (create_case_source) Add `struct dictionary *' parameter, all
5002 (create_case_sink) Ditto.
5003 (free_case_sink) New function.
5004 (struct split_aux_data) New structure.
5005 (procedure_with_splits) New function implementing what procedure()
5007 (SPLIT_FILE_proc_func) Removed.
5008 (procedure_with_splits_callback) New function.
5009 (equal_splits) New function.
5011 * aggregate.c: Pass around a struct instead of using statics.
5012 (static var outfile) Remove.
5013 (enum type) Give it tag `missing_treatment'.
5014 (static var missing) Remove.
5015 (static var sort) Remove.
5016 (static var agr_first) Remove.
5017 (static var agr_next) Remove.
5018 (static var case_count) Remove.
5019 (static var prev_case) Remove.
5020 (static var buf64_1xx) Remove.
5021 (static var buf_1xx) Remove.
5022 (struct agr_proc) New structure incorporating the above.
5023 (cmd_aggregate) Use new struct. Clean up error handling using
5024 agr_destroy(). Completely rewrite actual implementation of
5026 (create_sysfile) Add struct agr_proc * parameter, modify
5028 (parse_aggregate_functions) Ditto.
5029 (free_aggregate_functions) Ditto. Rename agr_destroy().
5030 (aggregate_single_case) Add struct agr_proc * parameter, modify
5032 (accumulate_aggregate_info) Ditto.
5033 (dump_aggregate_info) Ditto.
5034 (initialize_aggregate_info) Ditto.
5035 (agr_00x_trns_proc) Removed.
5036 (agr_00x_end_func) Removed.
5037 (agr_10x_trns_proc) Removed.
5038 (agr_10x_trns_free) Removed.
5039 (agr_10x_end_func) Removed.
5040 (agr_11x_read) Removed.
5041 (agr_11x_finish) Removed.
5042 [DEBUGGING] (debug_print) Removed.
5043 (write_case_to_sfm) Add struct agr_proc * parameter, modify
5045 (agr_to_active_file) New function.
5046 (presorted_agr_to_sysfile) New function.
5047 (sort_agr_to_sysfile) New function.
5049 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
5051 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
5053 * descript.q: (cmd_descriptives) Ditto.
5055 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
5056 to new procedure() interface.
5058 * command.c: (cmd_execute) Adapt to new procedure() interface.
5060 * dictionary.c: (dict_compact_values) Also delete scratch
5062 (dict_get_compacted_value_cnt) New function.
5063 (dict_get_compacted_idx_to_fv) New function.
5065 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
5066 (cmd_flip) Adapt to new procedure() interface.
5067 (flip_sink_write) Use sink->idx_to_fv.
5069 * frequencies.q: (internal_cmd_frequencies) Use
5070 procedure_with_splits().
5072 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
5073 (static var mtf_sink) New static var.
5074 (static var mtf_case) New static var.
5075 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
5076 we actually implement the matching.
5077 (mtf_delete_file_in_place) Use mtf_case.
5078 (mtf_processing) Use mtf_case and mtf_sink.
5079 (cmd_export) Adapt to new procedure() interface.
5081 * levene.c: (levene) Use procedure_with_splits().
5083 * list.q: (cmd_list) Use procedure_with_splits().
5085 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
5086 procedure() interface.
5087 (read_matrices_with_rowtype) Ditto.
5089 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
5090 TEMPORARY. Adapt to new procedure() interface.
5092 * rename-vars.c: Warn about and cancel TEMPORARY.
5094 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
5095 (sort_cases) Use dict_get_compacted_value_cnt() instead of
5096 compaction_nval. Adapt to new procedure() interface. Use
5097 storage_source_to_disk().
5098 (do_internal_sort) Don't try to dump the cases to memory.
5099 (compare_case_lists) Pass null idx_to_fv.
5100 (struct initial_run_state) Add `idx_to_fv' member. Remove
5102 (write_initial_runs) Don't initialize irs->case_size. Adapt to
5103 new procedure() interface. Reset irs->idx_to_fv after calling
5105 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
5106 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
5108 (destroy_initial_run_state) Don't dereference irs after freeing
5110 (allocate_cases) Don't calculate case_size locally.
5111 (compare_record) Add idx_to_fv parameter.
5112 (compare_record_run) Change parameter from struct sort_cases_pgm *
5113 to struct initial_run_state *. Pass irs->idx_to_fv to
5115 (compare_record_run) Third parameter now a struct
5116 initial_run_state *.
5117 (output_record) No need for out_case anymore. Pass irs, not
5118 struct sort_cases_pgm to pop_heap(). Use case_size from struct
5120 (merge) Use case_size from struct sort_cases_pgm.
5121 (merge_once) Use case_size from struct sort_cases_pgm.
5122 Pass null pointer to compare_record() as idx_to_fv.
5123 (global var sort_sink_class) Make static.
5125 * t-test.q: (cmd_t_test) Use procedure_with_splits().
5127 * temporary.c: Remove debugging crap.
5129 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
5131 * t-test.q, levene.c: Fixed up the handling of MISSING values
5134 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
5136 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
5139 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
5141 Change explicit variable name checks into use of
5142 dict_class_from_id().
5144 * dictionary.c: (dict_create_var) Change explicit variable name
5145 check into use of dict_class_from_id().
5147 * get.c: (trim_dictionary) Ditto.
5149 * sel-if.c: (cmd_filter) Ditto.
5151 * sysfile-info.c: (cmd_display) Ditto.
5153 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
5155 * vfm.c: (arrange_compaction) Ditto.
5157 * weight.c: (cmd_weight) Ditto.
5159 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
5161 * temporary.c: (cmd_temporary) When TEMPORARY was the first
5162 transformation following the input program, if any, for some
5163 reason we special-cased f_trns. That's just wrong. It should
5164 always be set to n_trns.
5166 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
5168 * format.c: (parse_format_specifier_name) Fix brown-bag bug
5169 introduced in last check-in.
5171 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
5173 * format.c: (global array translate_fmt[]) Removed.
5174 (translate_fmt) New function as replacement.
5175 (parse_format_specifier_name) Rewrite.
5177 * pfm-read.c: (convert_format) Use translate_fmt() instead of
5180 * sfm-read.c: (parse_format_spec) Ditto.
5182 * postscript.c: (text) Fix handling of fonts with missing
5185 * sort.c: (struct external_sort) Add temp_name member.
5186 (destroy_external_sort) Free temp_dir, temp_name members.
5187 (init_external_sort) Allocate temp_name.
5188 (get_temp_file_name) Change prototype.
5189 (open_temp_file) Deal with change to get_temp_file_name().
5190 (close_temp_file) Ditto.
5191 (remove_temp_file) Ditto.
5192 (write_temp_file) Ditto.
5193 (read_temp_file) Ditto.
5194 (sort_sink_destroy) Removed.
5195 (sort_sink_class) Change destroy member to null.
5197 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
5199 Eliminate temp_case.
5201 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
5202 anymore. Use agr_11x_finish().
5203 (aggregate_single_case) Make first param const.
5204 (accumulate_aggregate_info) Ditto.
5205 (agr_00x_end_func) Use compaction_case, not temp_case.
5206 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
5208 * data-list.c: (struct data_list_pgm) Add `case_size' member.
5209 (cmd_data_list) Initialize case_size.
5210 (read_from_data_list_fixed) Add struct ccase * param, use instead
5212 (read_from_data_list_free) Ditto.
5213 (read_from_data_list_list) Ditto.
5214 (read_one_case) Rename data_list_trns_proc(), all references
5215 updated. Add argument in calling above functions. Use c
5216 argument instead of temp_case.
5217 (destroy_dls) Rename data_list_trns_free(), all references
5220 * expr-evl.c: (expr_evaluate) Make second parameter const.
5222 * file-type.c: (struct file_type_pgm) Add `case_size' member.
5223 (cmd_end_file_type) Initialize `case_size'.
5224 (file_type_source_read) Add struct ccase * parameter. Use instead
5227 * flip.c: Rewritten.
5229 * get.c: (struct get_pgm) New structure to keep track of
5231 (cmd_get) Initialize case_size.
5233 (get_source) Deal with struct get_pgm.
5234 (get_source_read) Add struct ccase * parameter, use instead of
5236 (import_source_read) Ditto.
5238 * get.c: Use a null pointer instead of temp_case to represent the
5239 "current case" in a struct mtf_file's input member.
5240 (mtf_processing_finish) Pass null to mtf_processing(), not
5242 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
5243 (mtf_compare_BY_values) Add extra arg, use instead of null input
5245 (mtf_processing) Use c parameter instead of temp_case. Pass
5246 compaction_case to process_active_file_output_case().
5248 * glob.c: (global variable temp_case) Removed.
5250 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
5251 (cmd_input_program) Initialize case_size. Set
5252 vfm_source->value_cnt.
5253 (init_case) Add struct ccase * parameter, use instead of
5256 (input_program_source_read) Ditto.
5258 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
5259 (dump_cell_content) Ditto.
5260 (nr_output_data) Ditto.
5261 (read_matrices_without_rowtype) Ditto.
5262 (matrix_data_read_with_rowtype) Ditto.
5263 (wr_read_splits) Ditto.
5264 (wr_output_data) Ditto.
5266 * sort.h: (struct sort_cases_pgm) New member `case_size'.
5268 * sort.c: (sort_cases) Initialize scp->case_size.
5269 (struct external_sort) Remove `case_size' member.
5270 (write_initial_runs) Only call vfm_sink->class_destroy if
5272 (struct sort_source_aux) New structure.
5273 (sort_source_read_helper) New function.
5274 (sort_source_read) Use sort_source_read_helper().
5275 (read_sort_output) Change interface to be more reasonable.
5276 (read_internal_sort_output) Ditto.
5277 (read_external_sort_output) Ditto.
5279 * vars-prs.c: (dict_class_to_name) Pass return value through
5282 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
5283 (procedure) Initialize trns_case.
5284 (procedure) Pass trns_case to vfm_source->class->read().
5286 (process_active_file) Start using struct procedure_aux_data.
5287 (process_active_file_write_case) Pass trns_case to
5288 transformations, lag_case(), clear_case().
5289 (process_active_file_output_case) Add struct ccase * parameter.
5290 (create_trns_case) New function.
5291 (make_temp_case) Removed.
5292 (vector_initialization) Removed.
5293 (close_active_file) Only call make_source if non-null, otherwise
5294 set vfm_source to null pointer. Don't free temp_case.
5295 (disk_source_read) Add struct ccase * parameter, use instead of
5297 (memory_source_read) Ditto.
5298 (lag_case) Add const struct ccase * member.
5299 (procedure_write_case) Use trns_case instead of temp_case.
5300 (clear_case) Add struct ccase * member, use instead of temp_case.
5301 (exclude_this_case) Ditto.
5302 (create_case_source) Add struct dictionary * parameter, use to
5303 initialize source->value_cnt.
5305 * vfm.h: (struct case_source) Add `value_cnt' member.
5306 (struct case_source_class) Add struct ccase * parameter to `read'
5307 member function pointer.
5308 (struct case_sink_class) Make struct ccase * parameter const in
5309 `write' member function pointer.
5311 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
5313 Fix a lot of "possibly uninitialized variable" warnings. Some of
5314 them are even real bugs. A few of them make me wonder how the
5317 * aggregate.c: (parse_aggregate_functions) Initialize `function.
5319 * ascii.c: (output_lines) Add default case to switch.
5321 * crosstabs.q: Remove static variable `expected' and all
5323 (display_crosstabulation) Always calculate expected value.
5325 (output_pivot_table) Initialize `cmp'.
5326 (display_crosstabulation) New variable `last_row', which is
5329 * data-in.c: (parse_numeric) Always initialize sign. How did this
5332 * data-list.c: (repeating_data_trns_proc) Always initialize code.
5333 Always set info.ofs. (How did this work?!)
5335 * expr-opt.c: (optimize_tree) Always initialize `m'.
5336 (evaluate_tree) Always initialize `c'. (How did this work?)
5338 * frequencies.q: (frq_custom_variables) Always initialize min,
5340 (frq_custom_grouped) Always initialize `dl'.
5342 * groff-font.c: (groff_read_font) Always initialize char_set.
5344 * matrix-data.c: (nr_output_data) Initialize `split'.
5345 (wr_read_splits) Remove shadowing split_cnt declaration.
5346 (wr_output_data) Initialize `split'.
5348 * output.c: (tokener) Skip add character on syntax error.
5350 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
5352 * postscript.c: (read_ps_encodings) Use line.string instead of
5354 (write_text) Add default case to switch.
5355 (text) Always initialize multiple variables. Fix bug with
5358 * print.c: (fixed_parse_fortran) Initialize head.
5359 (alloc_line) Add default case to switch.
5361 * recode.c: (parse_dest_spec) Handle case where nothing matches.
5362 (recode_trns_proc) Move variable declaration inward. Add default
5365 * sfm-read.c: (read_header) Initialize skip_amt.
5367 * sysfile-info.c: (display_variables) Always initialize pc.
5369 * vars-prs.c: Initialized `included'.
5371 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
5373 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
5374 Just use signal() instead.
5376 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
5378 Get rid of vfm_sink_info and vfm_source_info.
5380 * aggregate.c: (agr_00x_end_func) Don't increment
5381 sfm_sink_info.ncases.
5383 * sort.c: (do_internal_sort) Get case count from
5384 vfm_source->class->count().
5385 (struct external_sort) Add `case_size' member.
5386 (do_external_sort) Initialize case_size.
5387 (struct initial_run_state) Add `case_size' member.
5388 (write_initial_runs) Initialize case_size.
5389 (sort_sink_write) Use case_size.
5390 (read_external_sort_output) Use case_size. Get case_cnt from
5393 * vfm.c: (struct write_case_data) Add underscores to existing arg
5394 names, all references updated. Renamed `aux' as `func_aux', all
5395 references updated. Added new `aux' member.
5396 (global var vfm_source_info) Removed.
5397 (global var vfm_sink_info) Removed.
5398 (struct procedure_aux_data) New.
5399 (struct split_aux_data) New.
5400 (procedure) Use `aux' fields for procedure_aux_data,
5402 (process_active_file_write_case) Pass case_count + 1 to
5403 transformation procedures, exclude_this_case().
5404 (process_active_file_output_case) Don't increment
5405 vfm_sink_info.ncases.
5406 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
5407 to send data to disk early.
5408 (make_temp_case) Don't use vfm_sink_info.case_size.
5409 (close_active_file) Don't initialize vfm_source_info.
5410 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
5411 (disk_sink_create) Initialize and/or update disk_stream_info.
5412 (disk_sink_write) Ditto.
5413 (disk_sink_destroy) Ditto.
5414 (disk_sink_make_source) Ditto.
5415 (disk_source_read) Ditto.
5416 (disk_source_destroy) Ditto.
5417 (global var disk_source_class) Add disk_source_count().
5418 (disk_source_count) New function.
5419 (struct memory_sink_info) Add `case_cnt', `case_size' members.
5420 (struct memory_source_info) Ditto.
5421 (memory_sink_create) Deal with case_cnt, case_size.
5422 (memory_sink_write) Ditto.
5423 (memory_sink_make_source) Ditto.
5424 (memory_source_read) Ditto.
5425 (memory_source_count) New function.
5426 (memory_source_class) Add memory_source_count().
5427 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
5428 proc_aux->cases_written, and pass it to transformation procedures
5429 and exclude_this_case ().
5430 (exclude_this_case) Add case_num parameter. Pass it to
5432 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
5435 * vfm.h: (struct case_source_class) Add `count' member.
5437 * vfmP.h: (struct stream_info) Removed.
5438 (global variable vfm_source_info) Removed.
5439 (global variable vfm_sink_info) Removed.
5441 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
5443 * var.h: (typedef trns_proc_func) New typedef.
5444 (trns_free_func) New typedef.
5445 (struct trns_header) Change `proc' to type trns_proc_func, `free'
5446 to type trns_free_func. This only changes the actual type of
5447 trns_proc_func, adding a `case_num' parameter. Updated all
5448 implementations to use the typedefs instead.
5450 * compute.c: (compute_num) Pass case_num to expr_evaluate().
5451 (compute_num_vec) Ditto.
5452 (compute_str) Ditto.
5453 (compute_str_vec) Ditto.
5455 * do-if.c: (do_if_trns_proc) Ditto.
5457 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
5460 * inpt-pgm.c: (input_program_source_read) Maintain case count,
5461 pass to transformation functions.
5462 (reread_trns_proc) Pass case_num arg to expr_evaluate().
5464 * loop.c: (loop_1_trns_proc) Ditto.
5465 (loop_2_trns_proc) Ditto.
5466 (loop_3_trns_proc) Ditto.
5468 * print.c: (print_space_trns_proc) Ditto.
5470 * sel-if.c: (select_if_proc) Ditto.
5472 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
5474 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
5475 destroying hash table.
5477 * glob.c: (read_active_file) Variable not referenced, removed.
5478 (cancel_input_pgm) Ditto.
5480 * levene.c: Add #include <stdlib.h> needed to call free().
5482 * aggregate.c: (parse_aggregate_functions) Make `function'
5485 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
5487 Start working to eliminate VFM dependence on static variables.
5489 * command.c: (cmd_parse) Use case_source_is_class().
5491 * data-list.c: Rewrite to eliminate use of static variables.
5493 * dfm.c: (cmd_begin_data) Use case_source_is_class().
5495 * file-handle.q: (fh_handle_name) Make parameter const.
5497 * file-type.c: Rewrite to eliminate use of static variables.
5499 * flip.c: Rewrite to eliminate use of static variables.
5501 * format.c: (get_format_var_width) New function.
5503 * get.c: Eliminate use of static variables.
5505 * inpt-pgm.c: Eliminate use of static variables.
5507 * matrix-data.c: Eliminate use of static variables.
5509 * set.q: (set_max_workspace) New variable.
5510 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
5512 * var.h: (struct case_list) Move here from vfmP.h.
5514 * vars-atr.c: (discard_variables) Handle new vfm_source type.
5516 * vfm.c: (vfm_source) Change type from struct case_stream to
5518 (vfm_sink) Change type from struct case_stream to struct
5520 (static var paging) Rename workspace_overflow, all references
5522 (procedure) Use new class structures.
5523 (process_active_file) Ditto.
5524 (process_active_file_write_case) Ditto.
5525 (prepare_for_writing) Use set_max_workspace. Use new class
5527 (close_active_file) Use new class structures. Free old sink.
5528 (global var disk_source_file) Removed.
5529 (global var disk_sink_file) Removed.
5530 (disk_stream_init) Removed.
5531 (disk_stream_read) Removed.
5532 (disk_stream_write) Removed.
5533 (disk_stream_mode) Removed.
5534 (disk_stream_destroy_source) Removed.
5535 (disk_stream_destroy_sink) Removed.
5536 (global var vfm_disk_stream) Removed.
5537 (disk_sink_create) New function.
5538 (disk_sink_write) New function.
5539 (disk_sink_destroy) New function.
5540 (disk_sink_make_source) New function.
5541 (disk_sink_class) New static var.
5542 (disk_source_read) New function.
5543 (disk_source_destroy) New function.
5544 (global var vfm_source_class) New var.
5545 (global var memory_source_cases) Removed.
5546 (global var memory_sink_cases) Removed.
5547 (global var memory_sink_max_cases) Removed.
5548 (struct memory_sink_info) New struct.
5549 (memory_stream_init) Removed.
5550 (memory_stream_read) Removed.
5551 (memory_stream_write) Removed.
5552 (memory_stream_mode) Removed.
5553 (memory_stream_destroy_source) Removed.
5554 (memory_stream_destroy_sink) Removed.
5555 (global var vfm_memory_stream) Removed.
5556 (page_to_disk) Renamed write_active_file_to_disk().
5557 (memory_sink_create) New function.
5558 (memory_sink_write) New function.
5559 (memory_sink_destroy) New function.
5560 (memory_sink_make_source) New function.
5561 (memory_sink_class) New static var.
5562 (memory_source_read) New function.
5563 (memory_source_destroy) New function.
5564 (memory_source_get_cases) New function.
5565 (memory_source_set_cases) New function.
5566 (global var vfm_source_class) New var.
5567 (procedure_write_case) Use new class structures.
5568 (create_case_source) New function.
5569 (case_source_is_complex) New function.
5570 (case_source_is_class) New function.
5571 (create_case_sink) New function.
5573 * vfm.h: (global variable reinit_sysmis) Not used, removed.
5574 (global variable reinit_blanks) Not used, removed.
5575 (global variable init_zero) Not used, removed.
5576 (global variable init_blanks) Not used, removed.
5577 (struct case_source) New struct.
5578 (struct case_source_class) New struct.
5579 (struct case_sink) New struct.
5580 (struct case_sink_class) New struct.
5581 (struct case_stream) Removed.
5583 * vfmP.h: (struct case_list) Moved to var.h.
5585 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
5587 * algorithm.c: (count_equal) New function.
5588 (count_if) New function.
5589 (unique) Add assertions.
5590 (partition) Add assertions.
5591 (is_partitioned) New function.
5592 (copy_if) Add assertions.
5593 (remove_equal) Add assertions.
5594 (lexicographical_compare) Rename lexicographical_compare_3way.
5595 (sort) Add assertions. Rephrase some code.
5596 (is_sorted) New function.
5598 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
5602 * sort.c: Completely rewrite.
5604 * sort.h: Expose interface via struct sort_cases_pgm, not via
5607 * aggregate.c: (sort) New static var.
5608 (cmd_aggregate) Use sort.
5609 (create_sysfile) Ditto.
5610 (aggregate_single_case) Ditto.
5611 (dump_aggregate_info) Ditto.
5612 (agr_00x_end_func) Ditto.
5613 (debug_print) Ditto.
5615 * var.h: (enum SRT_ASCEND) Removed.
5616 (enum SRT_DESCEND) Removed.
5617 (struct sort_cases_proc) Removed.
5618 (struct variable) Remove p.srt member.
5620 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
5622 Get rid of the old, crappy heap structure and replace it by a new,
5623 shiny, C++ STL-like heap structure.
5625 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
5627 * algorithm.c: (push_heap) New function.
5638 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
5640 Increase warning level.
5642 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
5644 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
5646 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
5648 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
5650 * dictionary.c: (dict_create_var) Fix root cause of bug worked
5651 around by previous change log entry.
5653 * compute.c: (lvalue_finalize) Remove workaround from previous
5656 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
5658 * compute.c: Fixed a bug where the Format was not getting set for
5659 computed variables (thus causing a crash when SAVEing).
5661 * Added a test to stop this bug ever coming back
5663 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
5665 Got rid of approx.h. In general, replaced all references to
5666 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
5669 * Makefile.am: (pspp_SOURCES) Removed approx.h.
5671 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
5672 test for mag < EPSILON.
5674 * misc.h: Add definition of EPSILON.
5676 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
5678 * vfm.c: (procedure) Add check to prevent recursive call.
5680 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
5682 * Moved the declarations relating to values to their own header file
5685 * Added levene.c and levene.h
5687 * vars-atr.c: Changed the signature of compare_values to
5688 take const * arguments.
5690 * t-test.q: Changed the structure of struct t_test_proc
5691 variables now contain their own group statistics information.
5692 Eventually, t_test_proc might get renamed, because it'd be
5693 applicable to other commands too.
5695 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
5697 * data-out.c: Clean up. Changed interface of convert_*() to take
5698 either a `double' or a `const char *' instead of a `const union
5699 value *'. Update all implementations of those interfaces.
5700 (data_out) Use switch statements instead of a table.
5701 (convert_AHEX) Rewrite.
5703 * format.h: Update comment.
5705 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
5707 * q2c.c: (dump_header) Add an Emacs header line to output files
5708 that makes generated .c files read-only by default, to make it
5709 difficult to accidentally change generated files.
5711 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
5713 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
5714 not bogus a->v.c <=> b->v.c pointer compare.
5715 (compare_freq_alpha_a) Ditto.
5716 (compare_freq_numeric_d) Ditto.
5717 (compare_freq_alpha_d) Ditto.
5719 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
5721 Changed data_out() to store string data directly into a `union
5722 value''s s member, not indirectly into c.
5724 * crosstabs.q: (output_pivot_table) Use format_short() instead of
5726 (table_value_missing) Ditto.
5727 (float_M_suffix) Ditto.
5728 (format_short) New function.
5730 * data-in.h: (data_in_finite_line) Remove inline definition.
5732 * data-list.c: (destroy_dls_var_spec) New function.
5733 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
5734 (data_list_source_destroy_source) Avoid cast.
5735 (struct repeating_data_trns) New field `id_value'. Update
5737 (cmd_repeating_data) Initialize id_value. Use new
5738 repeating_data_trns_free() for freeing REPEATING DATA
5740 (rpd_parse_record) Rewrite support for record ID to be less bogus.
5741 (repeating_data_trns_free) New function.
5743 * data-out.c: (data_out) Change return type to `void' by replacing
5744 error returns by writing a message into the output buffer.
5745 (convert_A) Read from v->s instead of v->c.
5746 (convert_AHEX) Ditto.
5748 * expr-evl.c: Update comment.
5749 (expr_evaluate) Add assertion in OP_STRING case.
5751 * format.h: (macro MAX_FORMATTED_LEN) New macro.
5753 * list.q: (list_cases) Update for new data_out() semantics.
5755 * print.c: (print_trns_proc) Ditto.
5757 * tab.c: (tab_value) Ditto.
5758 (tab_float) Avoid stupid cast.
5760 * var.h: Update comments.
5761 (macro MAX_STRING) New macro.
5762 (macro MAX_ELEMS_PER_VALUE) New macro.
5764 * vars-atr.c: (compare_values) New function.
5766 * vfm.c: (dump_splits) Update for new data_out() semantics.
5768 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
5770 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
5772 (struct crosstab) Rename v[] to vars[]. All references updated.
5773 (hash_table_entry) Replace the hash algorithm and fix a bug at the
5774 same time, which caused the hash value to depend only on a single
5775 value, not all of the variables' values.
5777 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
5779 Clean up struct dictionary's value_cnt usage.
5781 * dictionary.c: Add a function comment to each function.
5782 (struct dictionary) Rename value_cnt to next_value_idx, which more
5783 accurately reflects its meaning. All references updated.
5784 (dict_rename_vars) Add assertion.
5785 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
5787 (dict_get_case_size) New function.
5789 * aggregate.c: (create_sysfile) Use dict_get_case_size().
5791 * get.c: (mtf_read_nonactive_records) Ditto.
5793 * sort.c: (allocate_cases) Ditto.
5794 (write_initial_runs) Ditto.
5798 * vfm.c: (prepare_for_writing) Ditto.
5802 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
5804 Make vfm.c slightly less grotesque.
5806 * vfm.c: (filter_var) Removed.
5807 (filter_index) Removed.
5808 (FILTERED macro) Removed.
5809 (exclude_this_case) New function.
5810 (process_active_file_write_case) Use exclude_this_case() instead
5811 of FILTERED and inline tests.
5812 (procedure_write_case) Ditto.
5813 (setup_filter) Removed.
5814 (open_active_file) Don't call setup_filter().
5815 (close_active_file) Call dict_get_filter() instead of checking
5818 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
5820 * var.h: (struct variable) Update comments.
5822 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
5824 New functions dict_create_var_assert(), dict_lookup_var_assert().
5825 Converted several dict_*_var()/assert pairs into a single
5826 dict_*_var_assert().
5828 * dictionary.c: (dict_create_var_assert) New function.
5829 (dict_lookup_var_assert) New function.
5831 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
5833 Got rid of "struct long_vec", envector(), devector(), etc. Added
5834 two members `init', `reinit' to struct variable as a substitute.
5836 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
5842 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
5845 * autorecode.c: (cmd_autorecode) destvars don't need init.
5847 * compute.c: (lvalue_finalize) Set reinit.
5849 * data-list.c: (fixed_parse_compatible) Don't need init usually.
5850 (dump_fmt_list) Ditto.
5853 * descript.q: (run_z_pass) Don't need init for z-scores.
5855 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
5857 (dict_clone_var) Copy `reinit' member, initialize `init' member.
5859 * glob.c: (init_glob) Remove vec_init() calls.
5861 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
5863 * loop.c: (internal_cmd_loop) Don't need to call envector().
5865 * numeric.c: (cmd_numeric) Ditto.
5867 (cmd_leave) Ditto. Set `init', `reinit' members.
5869 * recode.c: (cmd_recode) Don't need to call envector().
5871 * repeat.c: (internal_cmd_do_repeat) Ditto.
5873 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
5874 (force_create_variable) Removed prototype.
5875 (force_dup_variable) Ditto.
5877 * vector.c: (cmd_vector) Don't need to call envector().
5879 * vfm.c: (reinit_sysmis) Removed.
5880 (reinit_blanks) Removed.
5881 (init_zero) Removed.
5882 (init_blanks) Removed.
5883 (process_active_file_write_case) No need to deal with vectors.
5884 Call clear_temp_case().
5885 (vector_initialization) Rewrite to use `init', `reinit'.
5886 (close_active_file) No need to call vec_clear().
5887 (procedure_write_case) Call clear_temp_case().
5888 (clear_temp_case) New function.
5890 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
5892 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
5895 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
5897 Add auxiliary argument to procedure() interface. Associated small
5898 clean-ups of vfm interface.
5900 * Updated every caller of procedure() and process_active_file() to
5901 reflect modified interface. Simple, ordinary changes not listed
5904 * Updated every function that implements struct case_stream's
5905 `read' function to take a write_case_func and a write_case_data.
5906 Also updated every caller of write_case() to instead call them
5907 through these arguments. In some cases this meant that the extra
5908 args had to be threaded through a couple of extra levels. This
5909 wasn't difficult or interesting so the details won't be given.
5911 * data-list.c: (struct repeating_data_trns) Add members
5912 `write_case', `wc_data' as kluge.
5913 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
5915 (repeating_data_set_write_case) New function.
5917 * data-list.h: New file to declare repeating_data_trns_proc() and
5918 repeating_data_set_write_case().
5920 * inpt-pgm.c: (input_program_source_read) Call
5921 repeating_data_set_write_case() for all the REPEATING DATA
5922 transformations, so that they know where to send their cases.
5923 It's a big kluge. Also kluge in END CASE.
5924 (end_case_trns_proc) Never called anymore, but we still need it,
5927 * sort.c: (read_sort_output) Update to match struct case_stream
5930 * vfm.c: (struct write_case_data) New structure.
5931 (proc_func) Removed.
5932 (virt_proc_func) Removed.
5933 (begin_func) Removed.
5934 (virt_begin_func) Removed.
5936 (write_case) Removed.
5937 (procedure) Added an auxiliary parameter to each function pointer
5938 argument's prototype. Added an auxiliary data parameter.
5940 (process_active_file) Ditto.
5941 (process_active_file_write_case) Pass aux data along.
5942 (close_active_file) Ditto.
5943 (procedure_write_case) Ditto.
5944 (SPLIT_FILE_procfunc) Ditto.
5946 * vfm.h: (typedef write_case_data) New.
5947 (typedef write_case_func) New.
5948 (struct case_stream) Add parameters to `read' member prototype.
5950 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
5952 * t-test.q: Added calculations for independent samples. (But no Levene
5955 * Makefile.am: Moved q_sources_c into own variable
5957 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
5959 Miscellaneous cleanups.
5961 * Change unused to UNUSED in many source files to reflect modified
5962 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
5963 __CYGWIN32__, __unix__, and unix not to assume that they're
5964 defined to a nonzero value. Change use of __attribute__ to use
5965 NO_RETURN or PRINTF_FORMAT instead.
5967 * alloc.h: Move definitions for local_alloc(), local_free() here
5968 from ../pref.h.orig and simplify.
5970 * expr-evl.c: Instead of working differently based on PAGED_STACK,
5971 use a pool allocator unconditionally.
5972 (CHECK_STRING_SPACE) Removed.
5973 (ALLOC_STRING_SPACE) Removed.
5974 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
5977 * expr-opt.c: (dump_expression) Allocate string pool.
5979 * expr-prs.c: (expr_free) Free string pool.
5981 * pool.c: (pool_destroy) This pool must be removed from its
5982 parent's list of gizmos, not from its own. Use free_all_gizmos().
5983 (pool_clear) New function.
5984 (free_all_gizmos) New function.
5985 (pool_alloc) Use space in empty block after this one if any.
5986 (pool_release) Only empty out blocks, don't actually free() them.
5988 * print.c: Get rid of PAGED_STACK special case by always
5989 dynamically allocating line buffers.
5990 (struct print_trns) Always include the `line' member.
5991 (internal_cmd_print) Always initialize the `line' member.
5992 (alloc_line) Always allocate memory for `line'.
5993 (print_trns_proc) Always initialize buf from `line' member.
5994 (print_trns_free) Always free `line' memory.
5996 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
5999 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
6001 * flip.c: Fixed crash from FLIP when a numeric variable is
6002 specified on NEWNAMES and a large value is used, and a couple of
6003 other minor bugs besides.
6004 (struct varname) Make name a 9-character fixed-size array
6005 instead of a 1-character variable size array.
6006 (make_new_var) Allow digits in variable names.
6007 (flip_stream_write) Limit numeric values to 8 characters and
6008 format system missing and very large and small values more
6011 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
6013 * command.c: Fixed test on command return status for the correct
6014 value, which had been causing a crash under certain invalid input.
6016 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
6018 * t-test.q: Added calculations for the one sample variant of the T-TEST
6020 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
6022 * tab.c: (render_strip) Fix bug that sometimes caused joined text
6023 in joined cells to be rendered outside box boundaries.
6025 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
6027 * random.c (rng_create): Fixed seeding so that it gets reseeded after
6028 SET seed=xx has been called.
6030 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
6032 * random.c (rng_get_double): Fix always-returning-zero bug in my
6033 preferred way, and at the same time make sure rounding doesn't
6036 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
6038 * html.c: (change_attributes) Dead code, removed.
6039 (escape_string) Eliminate code to call change_attributes() that
6040 never actually called it.
6041 (output_tab_table) Get rid of dependence on tab_hit
6042 and struct tab_joined_cell's hit member, which are abominations.
6044 * tab.c: (tab_output_text) Don't call
6045 d->class->text_set_font_by_name if it's a null pointer.
6046 (macro UNROLL_LOOP) Eliminate.
6047 (macro UNROLL_3_LOOPS) Eliminate.
6048 (tabi_render) Rewrite not to use the above macros.
6050 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
6052 Start working on a new output driver system, one that doesn't suck
6053 so much, by adding a "device-independent" output driver. The idea
6054 is to write out only a single output stream, then use separate
6055 processes to translate them into whatever formats we want. This
6056 is similar to how "groff" works with its various output drivers
6057 (grops, grotty, grodvi, ...).
6059 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
6061 * list.q: (write_all_headers) Stub out devind class.
6063 (determine_layout) Ditto.
6066 * output.c: (outp_init) Add devind class.
6068 * devind.c: New file.
6070 * devind.h: New file.
6072 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
6074 * frequencies.q: (hash_value_alpha) Fixed up the previous change
6075 to use the proper string length.
6077 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
6079 * Fixed bug where FREQ would crash on alpha values
6081 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
6083 * Removed bletcherous alloca() workarounds for AIX from top of
6084 many files. AIX can use the alternative alloca() implementation
6087 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
6089 * ascii.c: (ascii_option) Fix implementation of headers option.
6091 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
6093 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
6094 multiple blank lines into one.
6095 (struct ascii_driver_ext) Add squeeze_blank_lines option.
6096 (ascii_preopen_driver) Initialize squeeze_blank_lines.
6097 (static var option_tab) Add squeeze entry.
6098 (ascii_option) Set squeeze_blank_lines.
6099 (output_lines) Implement squeezing blank lines.
6101 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
6103 * Removed redundant code from output.h
6105 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
6107 Dictionary classes: each variable is "ordinary", "system", or
6110 * var.h: (enum dict_class) New enum.
6112 * vars-prs.c: (dict_class_from_id) New function.
6113 (dict_class_to_name) New function.
6115 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
6117 * var.h: (struct freq_tab_set) Removed (not used).
6119 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
6121 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
6123 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
6125 * stats.c: (hypercube) Rename pow4(). All references updated.
6127 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
6129 * rename-vars.c: (cmd_rename_variables) Rewritten.
6130 (compare_name) Removed.
6132 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
6134 var_set feature, and code taking advantage of it.
6136 * crosstabs.q: (static var var_dict) Removed.
6137 (static var variables) New variable.
6138 (static var variables_cnt) New variable.
6139 (cmd_crosstabs) Free variables instead of var_dict.
6140 (internal_cmd_crosstabs) Initialize and use variables,
6141 variables_cnt instead of var_dict.
6142 (free_var_dict) Removed.
6143 (crs_custom_tables) Use var_set instead of a copied dictionary.
6144 (crs_custom_variables) Set up variables, variables_cnt instead of
6146 [DEBUGGING] (debug_print) Ditto.
6148 * means.q: (mns_custom_tables) Use var_set instead of a copied
6151 * vars-prs.c: (parse_vs_variable) New function.
6152 (parse_dict_variable) Rewritten.
6153 (parse_variable) Rewritten.
6154 (parse_variables) Renamed parse_var_set_vars(), rewritten.
6155 (parse_variables) New function in terms of parse_var_set_vars().
6156 Now requires its first argument to be non-null. All references
6157 that passed a null pointer updated to pass default_dict instead.
6158 (macro id_dict) Removed.
6159 (parse_DATA_LIST_vars) Add assertions.
6160 (parse_mixed_vars) Ditto.
6161 (struct var_set) New structure.
6162 (var_set_get_cnt) New function.
6163 (var_set_get_var) New function.
6164 (var_set_lookup_var) New function.
6165 (var_set_destroy) New function.
6166 (dict_var_set_get_cnt) New function.
6167 (dict_var_set_get_var) New function.
6168 (dict_var_set_lookup_var) New function.
6169 (dict_var_set_destroy) New function.
6170 (var_set_create_from_dict) New function.
6171 (struct array_var_set) New structure.
6172 (array_var_set_get_cnt) New function.
6173 (array_var_set_get_var) New function.
6174 (array_var_set_lookup_var) New function.
6175 (array_var_set_destroy) New function.
6176 (var_set_create_from_array) New function.
6178 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
6179 instead of parse_variables(NULL, ...) in output code.
6181 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
6183 Change inp_init from a 2-bit vector to an ordinary array.
6184 Initialize it all in cmd_end_input_program() instead of in
6187 * inpt-pgm.c: (enum value_init_type) New enum.
6188 (global var inp_init) Change to `enum value_init_type *', make
6190 (inp_init_size) Removed.
6191 (inp_nval) Change to `size_t', make static.
6192 (cmd_input_program) Don't initialize inp_init or inp_init_size.
6193 (cmd_end_input_program) Initialize inp_init, inp_nval.
6194 (init_case) Rewrite.
6195 (clear_case) Rewrite.
6197 * inpt-pgm.h: Removed.
6199 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
6201 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
6202 Colin Plumb hash. It is simpler and should better resist
6204 (hsh_hash_string) Ditto.
6206 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
6208 * get.c: (export_write_case_func) Remove debug printing code.
6210 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
6212 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
6214 (save_write_case_func) Use &trns->h instead of cast.
6215 (cmd_export) Use &t->h instead of cast.
6217 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
6219 Moved vectors into the dictionary.
6221 * var.h: (struct vector) Moved here from vector.h. `index' member
6222 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
6225 * vector.h: Removed.
6227 * vector.c: (global var vec) Removed.
6228 (global var nvec) Removed.
6229 (cmd_vector) Rewritten.
6230 (find_vector) Removed.
6232 * dictionary.c: (dict_create_vector) New function.
6233 (dict_get_vector) New function, replaces reading global vec[]
6235 (dict_get_vector_cnt) New function, replaces reading global nvec
6237 (dict_lookup_vector) New function, replaces find_vector().
6238 (dict_clear_vectors) New function.
6240 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
6242 Start to move away from `struct variable' p `union' member to void
6245 * var.h: (struct variable) Add `aux' member.
6247 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
6249 Get rid of struct variable `foo' member.
6251 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
6253 (frq_custom_variables) Ditto.
6254 (frq_custom_grouped) Ditto.
6256 * get.c: (struct save_trns) Change `var' member from `int *' to
6257 `struct variable **'.
6258 (cmd_save_internal) Use aux instead of foo.
6259 (save_trns_proc) Use revised `var' member.
6260 (static var mtf_seq_no) Renamed mtf_seq_num.
6261 (static var mtf_seq_nums) New static var.
6262 (cmd_match_files) Initialize mtf_seq_nums.
6263 (mtf_free) Free mtf_seq_nums.
6264 (mtf_processing) Use mtf_seq_nums instead of foo.
6265 (mtf_merge_dictionary) No need to initialize mv->foo.
6266 (cmd_export) Use aux instead of foo. Use revised `var' member.
6267 (mns_custom_tables) Don't use foo to check for duplicates, that's
6268 what PV_NO_DUPLICATE is for.
6270 * var.h: (struct variable) Remove `foo' member.
6271 (struct frequencies_proc) New member.
6273 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
6275 Clean up COMPUTE and IF.
6277 * compute.c: More or less rewrite the darn thing.
6278 (struct compute_trns) Rename and reorder and add and delete
6280 (cmd_compute) Rewrite.
6281 (compute_num) Make conditional on test expression. Now used for
6282 both COMPUTE and IF.
6283 (compute_num_vec) Ditto.
6284 (compute_str) Ditto.
6285 (compute_str_vec) Ditto.
6288 (if_num_vec) Removed.
6290 (if_str_vec) Removed.
6291 (parse_target_expression) Renamed parse_rvalue_expression(),
6293 (new_trns) Renamed compute_trns_create(), rewritten.
6294 (delete_trns) Removed.
6295 (free_trns) Renamed compute_trns_free(), rewritten.
6296 (struct lvalue) New structure.
6297 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
6298 (lvalue_get_type) New function.
6299 (lvalue_is_vector) New function.
6300 (lvalue_finalize) New function.
6301 (lvalue_destroy) New function.
6303 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
6305 * command.def: Disallow MODIFY VARS in input mode, so that
6306 variables can't get dropped and confuse cmd_end_input_program()'s
6307 attempt to fill inp_init[].
6309 * modify-vars.c: (static var forward_positional_ordering) New
6311 (struct var_modification) Entirely changed.
6312 (rearrange_dict) Interface changed, rewritten.
6313 (cmd_modify_vars) Deal with modified struct var_modification, much
6315 (struct var_renaming) New structure.
6316 (compare_var_renaming_by_new_name) New function.
6317 (validate_var_modification) New function.
6319 * var.h: (struct modify_vars_proc) Removed.
6320 (struct variable) Removed member p.mfv.
6322 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
6324 Make EVALUATE a valid command whether we're debugging or not, so
6325 that `make check' can succeed regardless of whether debugging is
6328 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
6330 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
6332 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
6334 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
6335 statement by a simple if test.
6337 * dfm.c: (dfm_get_record) Add assertion.
6339 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
6341 For each file x.c, move #include "x.h" to the very top of the
6342 include list, to catch x.h failing to include the proper headers.
6344 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
6346 * algorithm.c: (find) New function.
6347 (remove_equal) New function.
6348 (set_difference) New function.
6349 (adjacent_find_equal) New function.
6350 [TEST_UNIQUE] Removed test case.
6351 (copy_if) Find end test.
6353 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
6355 * dictionary.c: (dict_get_case_weight) New convenience function.
6357 * aggregate.c: (accumulate_aggregate_info) Use
6358 dict_get_case_weight().
6360 * frequencies.q: (calc_general) Ditto.
6361 (calc_integer) Ditto.
6364 * t-test.q: (groups_calc) Ditto.
6367 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
6369 * glob.c: (global var default_dict) Change from `struct
6370 dictionary' to `struct dictionary *'. All references changed.
6371 (init_glob) Initialize default_dict with dict_create().
6373 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
6375 struct dictionary now made opaque. All related functions:
6377 * get.c: (rename_variables) Removed.
6378 (dict_delete_run) Removed.
6380 * temporary.c: (copy_variable) Removed.
6381 (new_dictionary) Removed.
6382 (save_dictionary) Removed.
6383 (restore_dictionary) Removed.
6384 (free_dictionary) Removed.
6386 * vars-atr.c: (clear_default_dict) Removed.
6387 (find_variable) Removed.
6388 (find_dict_variable) Removed.
6389 (create_variable) Removed.
6390 (delete_variable) Removed.
6391 (common_init_stuff) Removed.
6392 (init_variable) Removed. Updating of inp_init moved into
6393 cmd_end_input_program().
6394 (replace_variable) Removed.
6395 (rename_variable) Removed.
6396 (clear_variable) Removed.
6397 (dup_variable) Removed.
6399 * vars-prs.c: (is_varname) Removed.
6400 (is_dict_varname) Removed.
6401 (fill_all_vars) Removed.
6403 * vector.c: (find_vector) Removed.
6405 * weight.c: (stop_weighting) Removed.
6407 * dictionary.c: New file.
6408 (dict_create) New, replaces new_dictionary().
6409 (dict_clone) New, replaces save_dictionary() and
6410 restore_dictionary().
6411 (dict_clear) New, replaces clear_default_dict().
6412 (dict_destroy) New, replaces free_dictionary().
6413 (dict_get_var_cnt) New function, replaces references to
6415 (dict_get_var) New function, replaces references to dict->var[i].
6416 (dict_get_vars) New function, replaces fill_all_vars().
6417 (dict_create_var) New, replaces create_variable(). Interface
6418 drops `type' parameter, using a zero `width' to designate numeric.
6419 (dict_clone_var) New, replaces dup_variable().
6420 (dict_rename_var) New, replaces rename_variable().
6421 (dict_lookup_var) New, replaces find_variable(),
6422 find_dict_variable(), is_varname().
6423 (dict_contains_var) New function.
6424 (compare_variable_dblptrs) New function.
6425 (dict_delete_var) New function, replaces clear_variable().
6426 (dict_delete_vars) New function, replaces dict_delete_run().
6427 (dict_reorder_vars) New function.
6428 (dict_rename_vars) New function, replaces rename_variables().
6429 (dict_get_weight) New function, replaces reading dict->weight_var.
6430 (dict_set_weight) New function, replaces writing dict->weight_var
6431 or calling stop_weight(dict).
6432 (dict_get_filter) New function, replaces reading dict->filter_var.
6433 (dict_set_filter) New function, replaces writing dict->filter_var.
6434 (dict_get_case_limit) New function, replaces reading dict->N.
6435 (dict_set_case_limit) New function, replaces writing dict->N.
6436 (dict_get_value_cnt) New function, replaces reading dict->nval.
6437 (dict_compact_values) New function, replaces a loop that was
6438 replicated in several places.
6439 (dict_get_split_vars) New function, replaces reading dict->splits.
6440 (dict_get_split_cnt) New function, replaces reading
6442 (dict_set_split_vars) New function, replaces writing dict->splits.
6443 (dict_get_label) New function, replaces reading dict->label.
6444 (dict_set_label) New function, replaces writing dict->label.
6445 (dict_get_documents) New function, replaces reading
6447 (dict_set_documents) New function, replaces writing
6450 All references to above functions updated.
6452 * aggregate.c: (cmd_aggregate) Copy file label and documents from
6453 old dictionary to new by hand, because dict_create() can't do it
6454 itself. Use dict_set_documents(), dict_set_split_vars().
6456 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
6457 calling dict_destroy().
6459 * data-list.c: (dls_var_spec) Remove `type' member, replace by
6461 (fixed_parse_compatible) Some slightly nontrivial changes for
6463 (dump_fmt_list) Ditto.
6466 * file-type.c: (create_col_var) Ditto.
6468 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
6469 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
6470 (rename_variables) Use dict_rename_vars().
6471 (mtf_merge_dictionary) Use dict_get_documents(),
6472 dict_set_documents(), dict_compact_values().
6474 * pfm-read.c: (read_variables) Deal with changes to weighting.
6476 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
6477 is_varname() in output code.
6479 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
6480 other dictionary functions.
6482 * title.c: (add_document_line) Use dict_get_documents(),
6483 dict_set_documents().
6485 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
6486 reset default_handle by hand. dict_clear() will clear vectors so
6487 there's no need for that by hand.
6489 * vfm.c: (close_active_file) Move call to finish_compaction()
6490 earlier, so that we can do the compaction as a single step using
6491 dict_compact_values(). Use dict_clear_vectors().
6492 (finish_compaction) Use dict_delete_var(), dict_compact_values().
6494 Some functions don't have replacements:
6496 * vars-atr.c: (force_create_variable) Removed. All references
6497 updated to dict_create_var() followed by an assertion.
6498 (force_dup_variable) Removed. All references updated to
6499 dict_clone_var() followed by an assertion.
6501 * weight.c: (update_weighting) Removed. No longer necessary, so
6502 all references removed.
6504 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
6508 * aggregate.c: Eliminate separation of weighted and unweighted
6509 case. It made the code too obscure and I doubt it was actually
6510 faster. Instead, all code uses the "weighted" code, because
6511 that's a generalization of the "unweighted" code.
6514 (parse_aggregate_functions) No need to set FWEIGHT.
6515 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
6516 (dump_aggregate_info) Ditto.
6517 (initialize_aggregate_info) No need for special plain_function
6518 that gets rid of FWEIGHT option.
6520 * aggregate.c: Get rid of approximations.
6521 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
6523 (aggregate_single_case) Don't use approx_ne().
6525 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
6527 * ascii.c (ascii_line_width): Dead code, removed.
6529 * postscript.c (ps_line_width): Ditto.
6531 * q2c.c (xrealloc): Ditto.
6533 * count.c (internal_cmd_count): Ditto.
6535 * means.q (validate_dependent_endpoint): Ditto.
6537 * set.q: (cmd_gset) Ditto.
6539 * weight.c: [0] (weight_trns_proc) Ditto.
6541 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
6543 Make the code -Wmissing-prototypes clean.
6545 * Makefile.am (version.c): Add #include "version.h".
6547 * ascii.c: (ascii_open_global) Make static.
6548 (ascii_close_page) Ditto.
6549 (ascii_font_sizes) Ditto.
6550 (ascii_postopen_driver) Ditto.
6551 (ascii_close_driver) Ditto.
6552 (ascii_option) Ditto.
6553 (ascii_open_page) Ditto.
6554 (ascii_line_horz) Ditto.
6555 (ascii_line_vert) Ditto.
6556 (ascii_line_intersection) Ditto.
6558 (ascii_polyline_begin) Ditto.
6559 (ascii_polyline_point) Ditto.
6560 (ascii_polyline_end) Ditto.
6561 (ascii_text_set_font_by_name) Ditto.
6562 (ascii_text_set_font_by_position) Ditto.
6563 (ascii_text_set_font_by_family) Ditto.
6564 (ascii_text_get_font_name) Ditto.
6565 (ascii_text_get_font_family) Ditto.
6566 (ascii_text_set_size) Ditto.
6567 (ascii_text_get_size) Ditto.
6568 (ascii_text_metrics) Ditto.
6569 (ascii_text_draw) Ditto.
6570 (ascii_close_page) Ditto.
6572 * cmdline.h: New header for parse_command_line(). Used where
6575 * command.c: Move prototypes for cmd_*() functions to command.h.
6577 * command.h: Prototypes for cmd_*() functions moved here from
6580 * crosstabs.q: (gamma_int) Ditto.
6582 * file-handle.h: Add fh_init_files() prototype.
6584 * getline.c: (welcome) Ditto.
6586 * glob.h: New header for init_glob(). Used where appropriate.
6588 * hash.c: (comparison_helper) Ditto.
6590 * html.c: (html_open_global) Ditto.
6591 (html_close_global) Ditto.
6592 (html_preopen_driver) Ditto.
6593 (html_postopen_driver) Ditto.
6594 (html_close_driver) Ditto.
6595 (html_option) Ditto.
6596 (html_open_page) Ditto.
6597 (html_close_page) Ditto.
6598 (html_submit) Ditto.
6600 * inpt-pgm.c: (input_program_source_read) Ditto.
6602 * output.c: (find_defn_value) Ditto.
6603 (destroy_list) Ditto.
6605 * pfm-read.c: (read_int) Ditto.
6607 * postscript.c: (ps_open_global) Ditto.
6608 (ps_close_global) Ditto.
6609 (ps_font_sizes) Ditto.
6610 (ps_preopen_driver) Ditto.
6611 (ps_postopen_driver) Ditto.
6612 (ps_close_driver) Ditto.
6614 (ps_open_page) Ditto.
6615 (ps_close_page) Ditto.
6616 (ps_line_horz) Ditto.
6617 (ps_line_vert) Ditto.
6618 (ps_line_intersection) Ditto.
6620 (ps_polyline_begin) Ditto.
6621 (ps_polyline_point) Ditto.
6622 (ps_polyline_end) Ditto.
6623 (ps_text_set_font_by_name) Ditto.
6624 (ps_text_set_font_by_position) Ditto.
6625 (ps_text_set_font_family) Ditto.
6626 (ps_text_get_font_name) Ditto.
6627 (ps_text_get_font_family) Ditto.
6628 (ps_text_set_size) Ditto.
6629 (ps_text_get_size) Ditto.
6630 (ps_text_metrics) Ditto.
6631 (ps_text_draw) Ditto.
6633 * q2c.c: (finish_up) Ditto.
6642 (find_symbol) Ditto.
6645 (force_string) Ditto.
6647 (match_token) Ditto.
6650 (parse_setting) Ditto.
6651 (parse_specifier) Ditto.
6652 (parse_specifiers) Ditto.
6653 (parse_subcommand) Ditto.
6654 (dump_specifier_vars) Ditto.
6656 (make_identifier) Ditto.
6657 (dump_declarations) Ditto.
6658 (dump_specifier_init) Ditto.
6659 (dump_vars_init) Ditto.
6661 (dump_specifier_parse) Ditto.
6662 (dump_subcommand) Ditto.
6663 (dump_parser) Ditto.
6664 (dump_header) Ditto.
6666 (recognize_directive) Ditto.
6668 * recode.c: (string_to_long) Ditto.
6670 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
6672 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
6675 * sort.c: (sort_stream_read) Ditto.
6676 (sort_stream_mode) Ditto.
6678 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
6680 * algorithm.c (binary_search): Fix comparison.
6682 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
6684 * algorithm.c: (binary_search) Fix assertion.
6686 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
6688 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
6690 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
6692 * sort.c: (compare_case_lists) Rewrite.
6694 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
6696 * quicksort.c: Removed (not used).
6698 * quicksort.h: Removed (not used).
6700 * sort.c: Removed blp_quicksort() prototype.
6702 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
6704 * postscript.c: (int_2_compare) Rewrite.
6705 (compare_line) Rewrite.
6707 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
6709 * matrix-data.c (compare_factors) Use lexicographical_compare()
6711 (compare_doubles) New function.
6713 * algorithm.c: (lexicographical_compare) New algorithm.
6715 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
6717 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
6719 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
6721 * expr-prs.c: (cmp_func) Removed.
6722 (parse_function) Use binary_search() algorithm.
6723 (compare_functions) New function.
6724 (init_func_tab) Use sort() algorithm.
6726 * algorithm.c: (binary_search) New algorithm.
6728 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
6730 * descript.q: (display) Use sort() algorithm instead of qsort().
6731 (compare_func) Removed.
6732 (descriptives_compare_variables) New function.
6734 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
6736 Get rid of AVL trees. Hashes are more appropriate for everything
6739 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
6745 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
6747 Much code can be clarified by using C++ STL-like algorithms. Not
6748 all uses of these algorithms are listed below, only the ones where
6749 the change to an algorithm was the only change of interest.
6751 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
6753 * algorithm.c: New file.
6755 * algorithm.h: New file.
6757 * modify-vars.c: (static var forward) Removed.
6758 (static var positional) Removed.
6759 (compare_variables) Removed.
6760 (struct ordering) New.
6761 (cmd_modify_vars) Use sort() algorithm.
6762 (compare_variables_given_ordering) New function.
6763 (rearrange_dict) Use sort() algorithm.
6765 * sysfile-info.c: (cmd_display) Use sort() algorithm.
6766 (cmp_var_by_name) Removed.
6768 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
6770 Make file handles use a hash table.
6772 * file-handle.q: (files) Change to hash table, make static.
6773 (cmd_file_handle) Use hash table functions.
6774 (fh_get_handle_by_filename) Ditto.
6775 (fh_get_handle_by_name) Ditto.
6776 (hash_file_handle) New function.
6777 (cmp_file_handle) Rewrite.
6778 (fh_init_files) Use hash table functions.
6780 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
6782 Clean up FREQUENCIES.
6784 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
6786 * frequencies.q: Remove a lot of old #if'd out code at the end.
6787 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
6788 or calc_weight(). Initialize percentile_values.
6789 (calc) New function based on calc_weight() from frequencies.g.
6790 (precalc) Use hash functions.
6791 (static var comparison_func) Removed.
6792 (static var comparison_param) Removed.
6793 (comparison_helper) Removed.
6794 (get_freq_comparator) New function.
6795 (not_missing) New function.
6797 (postprocess_freq_tab) Use hash table functions, algorithms,
6798 get_freq_comparator(). Rewrite.
6799 (cleanup_freq_tab) Rephrase.
6800 (add_percentile) Clean up spacing.
6801 (hash_value_numeric) New function.
6802 (hash_value_alpha) New function.
6803 (compare_value_numeric_a) Rewrite.
6804 (compare_value_alpha_a) Rewrite.
6805 (compare_value_numeric_d) Rewrite.
6806 (compare_value_alpha_d) Rewrite.
6807 (compare_freq_numeric_a) Rewrite.
6808 (compare_freq_alpha_a) Rewrite.
6809 (compare_freq_numeric_d) Rewrite.
6810 (compare_freq_alpha_d) Rewrite.
6811 (calc_stats) Clean up mode, percentiles, max.
6812 (dump_statistics) Clean up spacing.
6814 * frequencies.g: Removed.
6816 * var.h: (struct freq_tab) Change `data' to hash table.
6818 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
6820 * file-handle.h: Remove declaration of global variable `files',
6821 which wasn't used anywhere.
6823 * postscript.c: (add_encoding) Remove superfluous cast.
6826 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
6829 * temporary.c: [0] (display_tree) Removed.
6831 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
6833 Implement a new random number generator based on the alleged RC4
6836 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
6839 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
6840 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
6842 (static var V[]) Removed.
6843 (static var Y) Removed.
6844 (static var X2) Removed.
6845 (setup_randomize) Removed.
6847 (rand_uniform) Removed.
6848 (rand_normal) Removed.
6849 (struct rng) New structure.
6850 (rng_create) New function.
6851 (rng_destroy) New function.
6852 (swap_byte) New static function.
6853 (rng_seed) New function.
6854 (rng_get_bytes) New function.
6855 (rng_get_int) New function.
6856 (rng_get_unsigned) New function.
6857 (rng_get_double) New function.
6858 (rng_get_double_normal) New function.
6859 (pspp_rng) New function.
6861 * random.h: Sync up to random.c.
6863 * sample.c: (struct sample_trns) Make `frac' unsigned and a
6864 fraction of UINT_MAX, not 65536.
6865 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
6868 * vfm.c: (open_active_file) No need to call setup_randomize() any
6871 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
6873 Change dictionary name indexes to use hash tables instead of AVL
6876 * crosstabs.q: (free_var_dict) Use hash tables.
6877 (crs_custom_tables) Ditto.
6878 (calc_general) Ditto.
6879 (compare_table_entry) Rewrite.
6880 (enum_var_values) Reorder parameters. All references updated.
6883 * get.c: (rename_variable) Use hash tables.
6884 (mtf_merge_dictionary) Ditto.
6886 * glob.c: (init_glob) Use hash tables.
6887 (cmp_variable) Removed.
6889 * means.q: (mns_custom_tables) Use hash tables.
6891 * modify-vars.c: (rearrange_dict) Use hash tables.
6893 * rename-vars.c: (cmd_rename_variables) Use hash tables.
6895 * sfm-read.c: (read_header) Use hash tables.
6896 (read_variables) Ditto.
6898 * temporary.c: (new_dictionary) Use hash tables.
6899 (save_dictionary) Ditto.
6900 (restore_dictionary) Ditto.
6902 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
6903 hash table `name_tab'.
6905 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
6906 [DEBUGGING] (dump_var_tree) Removed.
6907 (find_variable) Use hash tables.
6908 (find_dict_variable) Ditto.
6909 (common_init_stuff) Ditto.
6910 (rename_variable) Ditto.
6911 (clear_variable) Ditto. Also, remove debug code.
6912 (dup_variable) Use hash tables.
6914 * vars-prs.c: (fill_all_vars) Use hash tables.
6915 (is_dict_varname) Ditto.
6916 (parse_dict_variable) Ditto.
6918 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
6920 Change value labels to use hash tables instead of AVL trees, and
6921 change value labels into an ADT.
6923 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
6925 * value-labels.c: New file.
6927 * value-labels.h: New file.
6929 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
6930 Get rid of a stupid use of goto.
6932 * autorecode.c: (compare_alpha_value) Rewrite.
6933 (hash_alpha_value) Ditto.
6934 (compare_numeric_value) Rewrite.
6935 (hash_numeric_value) Ditto.
6937 * frequencies.q: (dump_full) Use value label ADT.
6939 * pfm-read.c: (read_value_label) Use value label ADT.
6941 * pfm-write.c: (write_value_labels) Use value label ADT.
6943 * sfm-read.c: (read_variables) Use value label ADT.
6944 (read_value_labels) Rewrite.
6946 * sfm-write.c: (write_value_labels) Rewrite.
6948 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
6949 (display_variables) Ditto.
6950 (describe_variable) Ditto.
6952 * t-test.q: (print_t_groups) Use value label ADT.
6954 * temporary.c: (copy_variable) Use value label ADT.
6955 (free_dictionary) Ditto.
6957 * val-labs.c: (verify_val_labs) Use value label ADT.
6959 (debug_print) Ditto.
6960 (val_lab_cmp) Removed.
6961 (inc_ref_count) Removed.
6962 (copy_value_labels) Removed.
6964 * var.h: (struct value_label) Removed.
6965 (struct variable) Change AVL tree `val_lab' into hash table
6968 * vars-atr.c: (init_variable) Use value label ADT.
6969 (clear_variable) Ditto.
6970 (free_value_label) Removed.
6971 (free_val_lab) Removed.
6972 (get_val_lab) Removed.
6973 (compare_variables) New function.
6974 (hash_variable) New function.
6976 * vfm.c: (dump_splits) Use value label ADT.
6978 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
6980 Add to the hash table interface.
6982 * hash.c: (hsh_hash_bytes) Add assertion.
6983 (hsh_hash_string) Ditto.
6987 (hsh_create) Ditto. Also make minimum `size'.
6988 (hsh_destroy) Rephrase.
6989 (sort_nulls_last) Removed.
6990 (not_null) New function.
6992 (comparison_helper) Ditto.
6993 (hsh_sort) Rewritten.
6994 (hsh_data_copy) New function.
6995 (hsh_sort_copy) Ditto.
6997 (hsh_replace) Ditto.
6998 (hsh_hash_double) Ditto.
6999 (hsh_delete) Fix stupid bug.
7001 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
7002 * added a calculation of the mode to FREQUENCIES
7004 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
7006 * moved (un)defs of DEBUGGING to config.h
7008 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
7010 * groff-font.c: (add_kern) Fix indentation.
7011 (add_kern) Use & instead of % to take power-of-2 modulus.
7012 (font_get_kern_adjust) Likewise.
7014 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
7016 * autorecode.c: (recode) Replace stupid use of memcpy() by
7018 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
7019 (hash_numeric_value) Ditto.
7020 (autorecode_proc_func) pool_strdup() was wrong here because the
7021 source string was not null-terminated. Use new pool_strndup()
7024 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
7025 use of hsh_iterator_init().
7027 * data-in.c: (parse_N) Initialize i->v->f.
7029 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
7032 * groff-font.c: Use power-of-2 hash table sizes, not prime.
7033 (groff_read_font) Don't call hsh_next_prime(). Don't call
7035 (static var hash) Remove `size_p', `max_used' members.
7036 (font_char_name_to_index) Don't call hsh_next_prime(). Use
7037 hsh_hash_string() instead of hashpjw(), & instead of %.
7038 (default_font) Don't call hsh_next_prime().
7040 * pool.c: (pool_strndup) New function.
7041 (pool_strdup) Reimplement in terms of pool_strndup.
7043 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
7045 (hash_ps_encoding) Use hsh_hash_string().
7046 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
7047 (hash_filename2font) Use hsh_hash_string().
7049 * som.c: Add #include <stdlib.h>.
7051 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
7052 (by destroying its pool).
7054 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
7056 Miscellaneous hash table code cleanup:
7058 * hash.h: (struct hsh_table) Moved into hash.c.
7059 (hsh_count) Ditto, and transformed into function.
7060 (hsh_compare_func) New typedef, used for defining otherwise-long
7061 function types here and in hash.c
7062 (hsh_hash_func) Ditto.
7063 (hsh_free_func) Ditto.
7065 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
7066 `table' to `entries'. Removed `mp'. All references updated.
7067 (hsh_clear) Don't shrink entries array; if the hash was this big
7068 once, it probably will be again.
7069 (hsh_rehash) Made static.
7070 (force_hsh_insert) Renamed hsh_force_insert.
7071 (force_hsh_find) Renamed hsh_force_find.
7073 Made hash table sizes powers of 2, because that's fine with any
7074 reasonable hash function and because taking a power-of-2 modulus
7075 is faster than any other:
7077 (hsh_prime_tab) Removed;
7078 (hsh_next_prime) Ditto.
7079 (next_power_of_2) New function.
7080 (hsh_create) Use next_power_of_2.
7081 (hsh_rehash) Use & instead of %.
7083 Cleaned up hsh_sort:
7085 (internal_comparison_fn) Removed.
7086 (sort_nulls_last) New function.
7087 (hsh_sort) Removed second parameter, switched to using the new
7088 quicksort() function from quicksort.h to avoid using nasty need
7089 for static variables with qsort(). All references updated.
7091 Changed the hash functions offered, because there are better hash
7092 functions than the ones we had, and cleaned up the names to boot:
7094 * hash.c: (hashpjw_d) Removed.
7096 (hsh_hash_bytes) New function.
7097 (hsh_hash_string) New function.
7098 (hsh_hash_int) New function.
7100 Improved the hash table iteration interface:
7102 * hash.h: (hsh_iterator_init) Removed.
7103 (struct hsh_iterator) Removed `init' member, change `next' to
7106 * hash.c: (hsh_foreach) Removed. All references updated to use
7107 hsh_first/hsh_next instead.
7108 (hsh_first) New function. Notably, unlike hsh_foreach() it does
7109 not treat a null pointer as an empty hash table.
7110 (hsh_next) New function.
7112 Made deletion possible, though slow:
7114 * hash.c: (locate_matching_entry) New function.
7115 (hsh_find) Use locate_matching_entry().
7116 (hsh_delete) New function also using locate_matching_entry().
7117 (hsh_force_delete) New function.
7119 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
7121 * quicksort.c: New file implementing a sort routine with a
7122 interface better than qsort() because it passes a user-provided
7123 parameter to the sort routine.
7125 * Makefile.am: Add quicksort.c, quicksort.h.
7127 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
7129 * All source files: Get rid of nasty special cases for Checker,
7130 which is pretty obsolete now.
7132 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
7134 * Fixed a bug apparent when using the FREQUENCIES command with the
7135 html driver. The html driver was incorrectly trying to display
7138 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
7140 * Makefile.am: Reorganized. Put locale dir in version.c instead
7141 of passing it to each compile command. Only put local gmp libs in
7142 LD_ADD if not installed on system. Remove `boast' target.
7144 * All source files: struct and union typedefs eliminated.
7145 `sizeof type' replaced by `sizeof object' where practical. Moved
7146 `unused' qualifiers from start to end of declarations for gcc
7147 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
7148 assertions on pointers strictly compliant. Removed _ prefixes on
7149 some function parameter names.
7151 * alloc.c: New source file, containing these external linkage
7152 functions removed from common.c: xmalloc, xcalloc, xrealloc,
7159 * ascii.c: Migrated from arenas to pools.
7160 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
7161 c_string to len_string. All references changed.
7162 (ascii_option) Signature changed to comply to new output.c
7164 (count_fancy_chars) Removed.
7165 (delineate) Removed support for rich text.
7166 (ascii_text_metrics) Ditto.
7168 (output_shorts) Change `box', `off', `on' from c_string to
7169 len_string. Change `remaining' from int to size_t.
7170 (ascii_close_page) Make page numbering less haphazard.
7172 * autorecode.c: Migrate from arenas to pools.
7174 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
7176 * bitvector.h: New file containing these macros from misc.h:
7177 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
7179 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
7180 word[3]. ncmd removed.
7181 (var empty_string) Removed.
7182 (var cmd_table) Declaration updated.
7183 (var cmdtab) Removed.
7184 (cmp_command) Removed.
7185 (split_words) Rewritten to use strtok_r().
7186 (init_cmd_parser) Renamed cmd_init(). Rewritten.
7187 (find_command) Removed.
7188 (FILE_TYPE_okay) Rewritten.
7189 (cmd_parse) Rewritten. Semantics of the return value of command
7190 handlers has changed: they must now return one of the new CMD_*
7191 enumerals, rather than a magic value. This meant that all
7192 commands had to be modified, and they were.
7193 (figure_out_command) New function.
7195 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
7196 #defines for INIT, INPU, etc.
7198 * command.h: New CMD_* enum series.
7199 (cur_proc) Make const char *, not char *.
7200 (cmd_init) Prototype.
7203 * common.c: Removed.
7205 * common.h: Removed.
7207 * correlations.q: New file.
7209 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
7211 (custom_tables) Renamed crs_custom_tables().
7212 (custom_variables) Renamed crs_custom_variables().
7213 (calc_integer) Add in some `const' qualifiers.
7214 (table_value_missing) Change from a_string to len_string.
7215 (float_M_suffix) Change from a_string to len_string.
7217 * data-in.c: Rewritten. All references to
7218 parse_string_as_format() changed to data_in().
7220 * data-in.h: New file.
7222 * data-list.c: Change DLS_* from #define's to enums. Move from
7223 rpd_msg() to tmsg().
7224 (RPD_ERR) New #define.
7225 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
7227 (read_from_data_list_fixed) Change from old
7228 parse_string_as_format() to new data_in().
7229 (read_from_data_list_free) Ditto.
7230 (read_from_data_list_list) Ditto.
7231 (cmd_repeating_data) Modify approach to checking for end of
7234 (rpd_parse_record) Change from old parse_string_as_format() to new
7235 data_in(). Change from old convert_format_to_string() to new
7237 (read_one_set_of_repetitions) Change dfm_push_cust() to
7238 dfm_push(), pop_cust() to dfm_pop().
7240 * data-out.c: Rewritten. All references to
7241 convert_format_to_string() changed to data_out().
7243 * descript.q: Migrate to new q2c.
7244 (cmd_descriptives) Removed.
7245 (internal_cmd_descriptives) Renamed cmd_descriptives ().
7246 (custom_variables) Renamed dsc_custom_variables().
7248 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
7250 (open_file_r) Initialize h->where.line_number. Migrate to new
7252 (open_file_w) Initialize h->where.line_number.
7253 (read_record) Change from ext->ln to h->where.line_number.
7254 Migrate to struct string.
7255 (dfm_put_record) Rephrased.
7256 (dfm_push_cust) Renamed dfm_push(), rewritten.
7257 (dfm_pop) New function.
7259 * error.c: All references updated.
7260 (glob var error_count) Renamed err_err_count.
7261 (glob var warning_count) Renamed err_warning_count.
7262 (glob var error_already_flagged) Renamed err_already_flagged.
7263 (glob var verbosity) Renamed err_verbosity.
7264 (glob var cust_fn) Removed.
7265 (glob var cust_ln) Removed.
7266 (static var file_loc) New.
7267 (static var nfile_loc) New.
7268 (static var mfile_loc) New.
7269 (tmsg) New function.
7270 (push_cust) Removed.
7273 (static var terminating) Removed.
7274 (failure) Renamed err_failure().
7275 (hcf) Renamed err_hcf().
7276 (err_push_file_locator) New function.
7277 (err_pop_file_locator) New function.
7278 (err_location) New function.
7279 (check_error_count) Renamed err_check_count().
7280 (vmsg) Renamed err_vmsg(). Interface changed.
7281 (verbose_msg) Removed.
7282 (err_cond_fail) New function.
7283 (error_break) Renamed err_break().
7285 * error.h: All references updated.
7286 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
7287 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
7289 (struct file_locator) New.
7291 (macro verbose_msg) Removed.
7292 (macro cond_fail) Removed.
7294 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
7296 * expr-prs.c: Reorganized. All references updated.
7297 (exprtypename) Renamed expr_type_name().
7298 (typename) Renamed type_name().
7299 (free_expression) Renamed expr_free().
7300 (parse_expression) Renamed expr_parse(). Uses new type_check()
7302 (init_functab) Renamed init_func_tab().
7303 (type_check) New function.
7304 (parse_or) Rewritten to use new allocate_nonterminal() and
7305 append_nonterminal_arg() functions.
7308 (parse_rel) Ditto. Also simplified logic.
7313 (SYSMIS_func) Ditto.
7314 (VALUE_func) Rephrased.
7315 (CONCAT_func) Fix memory leak by replacing free by free_node on
7317 (generic_str_func) Ditto.
7318 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
7320 (allocate_nonterminal) New function.
7321 (append_nonterminal_arg) New function.
7322 (static func_tab[]) Now at file level.
7324 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
7326 * expr.h: (enum series OP_*) Moved to exprP.h.
7327 (OP_* defines) Ditto.
7328 (struct op_desc) Ditto.
7329 (global ops[]) Ditto.
7330 (struct num_con_node) Ditto.
7331 (struct str_con_node) Ditto.
7332 (struct var_node) Ditto.
7333 (struct lag_node) Ditto.
7334 (struct casenum_node) Ditto.
7335 (struct nonterm_node) Ditto.
7336 (union any_node) Members renamed.
7337 (struct sys_node) Removed.
7338 (struct val_node) Removed.
7339 (operator typedef) Removed.
7340 (typedef exprtype) Removed.
7341 (enum series EX_*) Moved to exprP.h.
7342 (struct expression) Ditto. Also renamed a lot of the members.
7343 (PXP_* defines) Changed to enums.
7344 (free_node prototype) Moved to exprP.h.
7346 * file-handle.h: (struct file_handle) New member `where'.
7348 * file-handle.q: Migrated to new q2c format.
7349 (prepend_current_directory) Removed (dead code).
7350 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
7351 (fh_get_handle_by_filename) Removed dead code.
7352 Set new `where' member.
7354 * file-type.c: (file_type_source_read) References to
7355 parse_string_as_format() changed to data_in().
7356 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
7358 * filename.c: All references updated.
7359 (init_filename) Renamed fn_init().
7360 (expand_line) Removed.
7361 (macro EXPAND_LINE) Removed.
7362 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
7363 of custom functions.
7364 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
7365 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
7366 (normalize_filename) Renamed fn_normalize().
7367 (search_path) Renamed fn_search_path(), rewritten.
7368 (prepend_dir) Renamed fn_prepend_dir().
7369 (blp_getenv) Renamed fn_getenv().
7370 (blp_dirname) Renamed fn_dirname().
7371 (fn_basename) New function, not used.
7372 (absolute_filename_p) Renamed fn_absolute_p().
7373 (is_special_filename) Renamed fn_special_p().
7374 (file_exists) Renamed fn_exists_p().
7375 (readlink_malloc) Renamed fn_readlink().
7376 (getenv_default) Renamed fn_getenv_default().
7377 (open_file) Renamed fn_open().
7378 (close_file) Renamed fn_close().
7379 (open_file_ext) Renamed fn_open_ext().
7380 (close_file_ext) Renamed fn_close_ext().
7382 * font.h: Migrate from arenas to pools.
7384 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
7386 * frequencies.g: Migrate from arenas to pools.
7388 * frequencies.q: Migrate to new q2c version. Migrate from arenas
7391 * getline.c: All references updated.
7392 (global getl_buf) Changed from char * to struct string.
7393 (static getl_include_path) Ditto.
7394 (global getl_buf_len) Removed.
7395 (global getl_buf_size) Removed.
7396 (getl_include_path) Deal with new getl_buf, getl_include_path.
7397 (getl_uninitialize) New function.
7398 (getl_get_current_directory) Rewritten.
7399 (getl_clear_include_path) Rewritten.
7400 (getl_add_include_dir) Rewritten.
7401 (getl_add_file) Assertion fixed.
7402 (getl_add_virtual_file) Change initial value of `remaining_loops'
7404 (welcome) Rewritten.
7405 (handle_line_buffer) Make static. Change logic to make
7406 getl_add_virtual_file() change sensible. Use ds_*() strings.
7407 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
7408 (getl_close_file) Moved.
7409 (getl_location) New function.
7411 * getline.h: All references updated.
7412 (macro curln) Removed.
7413 (macro curfn) Removed.
7414 (macro am_interactive) Renamed getl_am_interactive.
7415 (macro am_reading_script) Renamed getl_reading_script.
7417 * glob.c: (global fmt_parse_ignore_error) Removed.
7418 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
7419 systems that support it (C99). Turn off SET ECHO by default. No
7420 necessary julcal initialization anymore.
7422 * groff-font.c: Migrate from arenas to pools.
7423 (groff_read_font) Use err_push_file_locator().
7424 (groff_read_DESC) Ditto.
7425 (font_msg) Use tmsg().
7427 * hash.c: (hsh_sort) Fix debug code.
7428 [GLOBAL_DEBUGGING] Include stdio.h.
7430 * hash.h: (macro force_hsh_insert) Rephrase.
7432 * heap.c: Rewritten.
7434 * heap.h: Rewritten.
7436 * html.c: (html_option) Change from outp_value to struct string.
7437 (postopen) Change from curfn to getl_location().
7438 (escape_string) Remove rich-text code. Signature changed.
7439 (output_tab_table) Switch from a_string to struct len_string.
7440 Remove rich text support.
7442 * lexer.c: All references updated. Largely rewritten. Major
7443 changes listed below. Removed tagged quote support. Adapted to
7444 struct string tokstr.
7445 (global tokstr) Changed to struct string.
7446 (global tokstr_size) Removed.
7447 (global tokstr_len) Removed.
7449 (global tokint) Removed.
7450 (global toklongstr) Removed.
7451 (C* defines) Removed.
7452 (static tbl[]) Removed.
7453 (static id[]) Removed.
7454 (static une[]) Removed.
7455 (discard_line) Renamed lex_discard_line().
7456 (get_entire_line) Renamed lex_entire_line().
7457 (get_rest_of_line) Renamed lex_rest_of_line().
7458 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
7459 (make_hexit) Removed.
7460 (syntax_error) Renamed lex_error(). Return value removed.
7461 (get_token_representation) Renamed lex_token_representation().
7462 (putback) Renamed lex_put_back().
7463 (putfwd) Renamed lex_put_forward().
7464 (convert_negative_to_dash) Renamed lex_negative_to_dash().
7465 (set_prog) Renamed lex_set_prog().
7466 (init_lex) Renamed lex_init().
7467 (reset_eof) Renamed lex_reset_eof().
7468 (lookahead) Renamed lex_look_ahead().
7469 (check_id) Rewritten.
7470 (yylex) Renamed lex_get(), rewritten.
7471 (lex_end_of_command) New function. Many commands were rephrased
7473 (lex_integer_p) New function. Replaces compare of tokint against
7475 (lex_integer) New function. Replaces tokint.
7476 (match_tok) Renamed lex_match().
7477 (match_id) Renamed lex_match_id().
7478 (match_int) Renamed lex_match_int().
7479 (force_match_id) Renamed lex_force_match_id(), added return value.
7480 (force_match) Renamed lex_force_match(), added return value.
7481 (force_string) Renamed lex_force_string(), added return value.
7482 (force_int) Renamed lex_force_int(), added return value.
7483 (lex_id_match_len) New function.
7484 (id_match) Renamed lex_id_match(), rewritten.
7485 (get_line) Renamed lex_get_line().
7486 (preprocess_line) Renamed lex_preprocess_line().
7487 (tokname) Renamed lex_token_name().
7488 (bin_value_func) Removed.
7489 (oct_value_func) Removed.
7490 (hex_value_func) Removed.
7491 (unexpected_eof) New function.
7492 (convert_numeric_string_to_char_string) New function.
7493 (parse_string) Rewritten, signature changed.
7494 (add_tokstr_char) Removed.
7495 (add_tokstr_unsigned) Removed.
7496 (add_tokstr_string) Removed.
7497 (parse_tagged_quote) Removed.
7498 (skip_comment) Renamed lex_skip_comment().
7500 * lexer.h: All references updated.
7501 (macro is_id1) Renamed CHAR_IS_ID1.
7502 (macro is_idn) Renamed CHAR_IS_IDN.
7503 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
7504 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
7505 (macro get_token) Removed.
7506 (macro id_match) Removed.
7507 (macro force_match_id) Removed.
7508 (macro force_match) Removed.
7509 (macro force_string) Removed.
7510 (macro force_int) Removed.
7511 (macro force_num) Removed.
7512 (macro force_id) Removed.
7514 * lexerP.h: Removed.
7516 * list.q: Migrated to new q2c format.
7517 (write_line) Deal with struct len_string.
7518 (write_varname) Ditto.
7519 (write_fallback_headers) Ditto.
7521 * magic.c: New file, incorporating the following global variables
7522 previously in other files: endian, second_lowest_value. And both
7523 of those are conditional on #define's.
7525 * magic.h: New file, incorporating the following global variable
7526 declarations: endian, second_lowest_value, and the following macro
7527 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
7529 * main.c: Added declarations of pgmname, finished, curdate,
7531 (main) Call new parse_script() function.
7532 (parse_script) New function.
7533 (execute_command) New function.
7534 (dump_token) Removed.
7535 (handle_error) New function.
7537 * matrix.c: New file.
7539 * matrix.h: New file.
7541 * matrix-data.c: Migrated from arenas to pools.
7542 (mget_token) Change from parse_string_as_format() to data_in().
7544 * means.q: Migrate to new q2c.
7545 (custom_tables) Renamed mns_custom_tables().
7546 (custom_crossbreak) Renamed mns_custom_crossbreak().
7547 (custom_variables) Renamed mns_custom_variables().
7549 * mis-val.c: (static var width) Changed from `int' to `size_t'.
7550 (parse_varnames) Prototype.
7551 (parse_numeric) Rephrasings.
7552 (parse_alpha) Adapt to new struct string tokstr.
7554 * misc.c: (intlog10) Rewritten.
7556 (ansi_rand) Renamed real_rand(), moved into random.c.
7557 (ansi_srand) Renamed real_srand(), moved into random.c.
7558 (setup_randomize) Moved to random.c.
7559 (rand_uniform) Ditto.
7560 (rand_normal) Ditto.
7561 (rand_simple) Ditto.
7562 (get_config_line) Removed.
7563 (reverse) Removed (dead code).
7565 * misc.h: (macro SET_BIT) Moved to bitvector.h.
7566 (macro CLEAR_BIT) Ditto.
7567 (macro TEST_BIT) Ditto.
7568 (macro SET_BIT_TO) Ditto.
7569 (macro BIT_INDEX) Ditto.
7571 * output.c: (outp_read_devices) Move to err_push_file_locator()
7572 from push_cust(). Use struct string.
7573 (expand_op_tokstr) Removed.
7574 (static var op_tokstr) Changed to struct string.
7575 (static var op_tokstr_size) Removed.
7576 (tokener) Rephrasings. Use struct string.
7577 (parse_options) Use struct string.
7578 (destroy_driver) Fix assertion.
7579 (outp_get_paper_size) Move to err_push_file_locator().
7580 [0] Removed dead code.
7581 (outp_string_width) Move to len_string.
7583 * output.h: Comment fixes.
7584 (TAG_* enum series) Removed.
7585 (struct outp_value) Removed.
7586 (enum OUTP_T_FANCY) Removed.
7587 (struct outp_text) `s' changed from a_string to len_string.
7588 (struct outp_class) `option' change arg 3 from outp_value to
7591 * pfm-read.c: (corrupt_msg) Rewritten.
7593 * pfm-write.c: (bufwrite) Fix assertion.
7595 * pool.c: New file, reference version.
7597 * pool.h: New file, reference version.
7599 * postscript.c: (ps_font_sizes) Fix assertion.
7600 (ps_option) Change arg 3 from outp_value to struct string.
7601 Adapt to struct string.
7602 (macro output_line) Removed.
7603 (macro add_string) Removed.
7604 (output_encodings) Adapted to struct string. Moved to
7605 err_push_file_locator().
7606 (find_encoding_file) Fix assertion.
7607 (read_ps_encodings) Move to err_push_file_locator().
7608 (postopen) Use getl_location() instead of curfn.
7609 (out_text_plain) Move to len_string.
7610 (text) Ditto. Remove rich text support.
7612 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
7613 (cmd_print_eject) Ditto.
7615 (internal_cmd_print) Now cleans up after itself. Uses
7616 fh_parse_file_handle() now.
7617 (cmd_print_space) Use PXP_NUMERIC to type-check.
7619 * q2c.c: Overhauled. Removed _("") i18n support. All references
7620 updated. All output functions updated to handle structures rather
7621 than local or static variables. Adapt to new PSPP lex_*()
7625 (macro MAX_N_SBC) Removed.
7626 (global bare) Removed.
7627 (enum STRING) Renamed T_STRING.
7628 (enum ID) Renamed T_ID.
7629 (get_buffer) Buffer size increased.
7630 (strlower) Renamed st_lower(), rephrased.
7631 (strupper) Renamed st_upper(), rephrased.
7632 (skip_ws) New function.
7633 (get_line) Don't special-case any types of lines (like those
7634 beginning with ! or $, for instance).
7635 (get_token) Renamed lex_get(). Rephrased.
7636 (static var `prefix') New.
7637 (parse) New function.
7638 (parse_setting) Minor rephrasing.
7639 (dump_specifier_vars) Ditto.
7640 (make_identifier) Put null terminator on identifier, duh.
7641 (dump_vars) Renamed dump_declarations(). Never indent. Never
7642 static. Output changed entirely.
7643 (dump_specifier_init) Rephrase.
7644 (dump_vars_init) No index variable needed. Other modifications.
7645 (dump_parser) Don't parse command name. Do dump functions instead
7646 of just code fragments.
7647 (dump_free) Dump function instead of code fragment.
7648 (recognize_directive) New function.
7649 (main) Use recognize_directive(). Don't rely on magic $ line
7650 beginning: instead, parse comments. Update list of headers.
7652 * random.c: New file, containing the following functions:
7653 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
7654 rand_normal, rand_simple.
7656 * random.h: New file.
7658 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
7659 function. `max_src_width', `max_dst_width' changed to size_t.
7660 (internal_cmd_recode) Removed.
7661 (parse_dest_spec) Merge similar cases.
7662 (parse_src_spec) Add assertion.
7664 * repeat.c: (recognize_keyword) New function.
7665 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
7666 REPEAT. Improve recognition of END REPEAT (use
7667 recognize_keyword()). Move from curfn to getl_location(). Use
7670 (perform_DO_REPEAT_substitutions) Adapt to struct string.
7672 * set.q: Adapt to new q2c.
7673 (cmd_set) Range-check some values better.
7674 (custom_blanks) Renamed stc_custom_blanks().
7675 (custom_length) Renamed stc_custom_length().
7676 (custom_results) Renamed stc_custom_results().
7677 (custom_seed) Renamed stc_custom_seed().
7678 (custom_width) Renamed stc_custom_width().
7679 (custom_format) Renamed stc_custom_format().
7680 (custom_journal) Renamed stc_custom_journal().
7681 (custom_color) Renamed stc_custom_color().
7682 (custom_listing) Renamed stc_custom_listing().
7683 (custom_disk) Renamed stc_custom_disk().
7684 (custom_log) Renamed stc_custom_log().
7685 (custom_rcolor) Renamed stc_custom_rcolor().
7686 (custom_viewlength) Renamed stc_custom_viewlength().
7687 (custom_workdev) Renamed stc_custom_workdev().
7689 * settings.h: Not necessary to include format.h any longer.
7691 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
7692 (corrupt_msg) Rewritten.
7694 * sort.c: Adapt to rewritten heap ADT.
7696 * str.c: (aa_strcpy) Removed.
7697 (ab_strcpy) Removed.
7698 (ac_strcpy) Removed.
7699 (ba_strcpy) Removed.
7700 (bb_strcpy) Removed.
7701 (ca_strcpy) Removed.
7702 (aa_strdup) Removed.
7703 (aa_strdupcpy) Removed.
7704 (ba_strdup) Removed.
7705 (sa_strdup) Removed.
7706 (memrev) Renamed mm_reverse().
7707 (memrmem) Renamed mm_find_reverse().
7708 (cmp_str) Renamed st_compare_pad().
7709 (strmaxcpy) Removed.
7710 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
7711 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
7713 (strpadcpy) Renamed st_pad_copy(), signature changed.
7714 (blpstrset) Removed.
7715 (ds_create) New function.
7716 (ds_init) New function.
7717 (ds_replace) New function.
7718 (ds_destroy) New function.
7719 (ds_clear) New function.
7720 (ds_extend) New function.
7721 (ds_shrink) New function.
7722 (ds_truncate) New function.
7723 (ds_length) New function.
7724 (ds_size) New function.
7725 (ds_value) New function.
7726 (ds_end) New function.
7727 (ds_concat) New function.
7728 (ds_concat_buffer) New function.
7729 (ds_printf) New function.
7730 (ds_putchar) New function.
7731 (ds_getline) New function.
7732 (ds_get_config_line) New function derived from the old
7733 misc.c:get_config_line().
7734 (ls_create) New function.
7735 (ls_create_buffer) New function.
7736 (ls_init) New function.
7737 (ls_shallow_copy) New function.
7738 (ls_destroy) New function.
7739 (ls_null) New function.
7740 (ls_null_p) New function.
7741 (ls_empty_p) New function.
7742 (ls_length) New function.
7743 (ls_value) New function.
7744 (ls_end) New function.
7746 * str.h: Reformatted.
7747 (struct a_string) Removed.
7748 (struct b_string) Removed.
7749 (struct c_string) Removed.
7750 (struct len_string) New.
7751 (struct string) New.
7752 (macro as_streq) Removed.
7753 (macro bs_streq) Removed.
7754 (macro cs_streq) Removed.
7755 (macro sa_streq) Removed.
7756 (macro sb_streq) Removed.
7757 [__GNUC__] (inline function ds_putchar) New function.
7758 [__GNUC__] (inline function ds_length) New function.
7759 [__GNUC__] (inline function ds_value) New function.
7760 [__GNUC__] (inline function ds_end) New function.
7762 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
7763 (display_vectors) Fix missing i18n.
7765 * t-test.q: Migrate to new q2c.
7767 * tab.c: Migrate from arenas to pools.
7768 (tab_create) Use struct len_string.
7769 (tab_realloc) Ditto.
7770 (text_format) Ditto.
7771 (tab_joint_text) Ditto.
7772 (tab_natural_width) Remove rich text support.
7773 (tab_natural_height) Ditto.
7774 (tab_output_text) Handle TAT_FIX.
7775 (tab_raw) Change arg from a_string to len_string.
7776 (tabi_driver) Fix assertion. Use struct len_string.
7777 (render_strip) Use struct len_string. Remove rich text support.
7778 Add `const' qualifiers.
7780 * tab.h: (enum TAB_RICH) Remove.
7781 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
7782 SOM_COL_* updated to read TAB_COL_*.
7783 (struct tab_table) Change arena to pool. Change a_string to
7786 * temporary.c: (restore_dictionary) Rewrite Checker code.
7788 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
7789 LOWEST, HIGHEST) Moved here from common.h.
7790 (typedef any_trns) Removed. All references changed to `struct
7793 * vars-atr.c: (force_create_variable) Fix assertion.
7794 (force_dup_variable) Fix assertion.
7796 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
7798 Using alphanumeric variables in functions under AGGREGATE
7799 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
7800 <BZN-mdksh@t-online.de> for reporting this bug.
7802 * aggregate.c: (parse_aggregate_functions) When setting the
7803 FSTRING bit, also allocate memory for the `string' member of
7805 (free_aggregate_functions) Free iter->string. Don't use the
7806 non-function bits when indexing the array of functions.
7807 [DEBUGGING] (debug_print) Don't use the non-function bits when
7808 indexing the array of functions.
7810 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
7812 Under certain circumstances, the final case would be omitted from
7813 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
7814 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
7816 * aggregate.c (agr_00x_end_func): Increment number of cases in
7817 sink before writing case. For streams that keep track of how many
7818 cases there are based on this value, this means that the last case
7819 will be read in on the next stream read.
7821 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
7823 Undefined behavior was invoked by referencing a freed pointer.
7825 * vfm.c (memory_stream_write): Free pointer *after* checking for
7828 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
7830 A wrong record size was displayed when paging the active file to
7833 * vfm.c: (memory_stream_write) Fix off-by-one error.
7835 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
7837 Not having enough temporary space for sorting caused a core dump.
7840 * sort.c: (allocate_cases) Initialize i.
7842 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
7844 Syntax errors in function descriptions on AGGREGATE caused core
7847 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
7848 free_aggregate_functions(), since that function already frees
7851 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
7853 A null pointer was dereferenced, causing a core dump, when
7854 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
7855 but PSPP still doesn't calculate percentiles. Thanks to Regnor
7856 Jernsletten <rjernsle@eunet.no> for reporting this problem.
7858 * arena.c: (arena_malloc) If the arena hasn't been initialized
7859 already, initialize it.
7861 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
7863 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
7864 for compilation with Cygnus Windows B20. Not used by other
7867 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
7869 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
7870 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
7872 * sort.c: (compare_case_lists) Reverse sense of comparison if
7873 sorting in descending order.
7874 (compare_record) Ditto.
7876 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
7878 SPLIT FILE with a string variable caused a core dump. Fixed.
7880 * vfm.c: If the variable is a string then make a temporary value
7881 struct pointing to it. The underlying problem is a lot bigger
7882 than this (see TODO) but this is a stopgap for the simple case at
7885 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
7887 Nested INCLUDEs didn't work. Fixed.
7889 * getline.c: (getl_include) Set first_line to NULL in allocated
7892 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
7894 The MATCH FILES procedure set the values of variables not present
7895 to 0. It should have been SYSMIS. This is now fixed.
7897 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
7899 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
7901 The REMARK command was too aggressive about skipping lines. It
7902 didn't like being the last command in a file.
7904 * command.c: (cmd_remark) Call get_entire_line() instead of
7907 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
7909 Comment parsing wasn't consistent with the rest of the code in its
7910 idea of where one command ends and another starts. This meant
7911 that sometimes commands would be mysteriously ignored. Thanks to
7912 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
7914 * command.c: (parse_cmd) Hand off comment parsing to new function
7915 skip_comment() in lexer.c.
7916 * lexer.c: (skip_comment) New function.
7918 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
7920 The TABLE subcommand on MATCH FILES worked only erratically at
7921 best. This fixes it. Thanks to Dr. Dirk Melcher
7922 <BZN-mdksh@t-online.de> for reporting this bug.
7924 * get.c: (mtf_compare_BY_values) When comparing string values, a
7925 difference of 1 is still a difference :-)
7926 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
7927 advance TABLE files automatically when matched. Comment fixes.
7929 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
7931 VARIABLE LABELS rejected a slash before the first variable
7932 specification, contradicting the documentation. Thanks to Walter
7933 M. Gray <graywm@northernc.on.ca> for reporting this bug.
7935 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
7936 command specification.
7938 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
7940 Because of an incorrect optimization in memory allocation,
7941 CROSSTABS sometimes segfaulted when asked to output multiple
7942 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
7945 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
7946 are passed to output_pivot_table() for its use.
7947 (output_pivot_table) Instead of assuming the number of columns is
7948 constant, keep track with maxcols. In general mode, use maxcells
7949 to determine whether more matrix cells need to be allocated.
7951 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
7953 CROSSTABS didn't display value labels for column and row
7954 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
7957 * crosstabs.q: (table_value_missing) If the specified value has a
7958 value label for this variable, then show it instead of the raw
7960 (display_dimensions) Delegate display of value_labels to
7961 table_value_missing.
7963 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
7965 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
7966 <BZN-mdksh@t-online.de> for reporting this bug.
7968 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
7969 if the file isn't declared as binary.
7971 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
7973 MATCH FILES corrupted memory and dumped core on some syntax
7976 * get.c: (cmd_match_files) Set file->handle to NULL before
7978 (mtf_free_file) Don't free a null dictionary.
7980 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
7982 MATCH FILES should set numeric values not available to the
7983 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
7984 <BZN-mdksh@t-online.de> for reporting this bug.
7986 * get.c: (mtf_processing) Set unused records to system-missing,
7989 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
7991 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
7992 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
7994 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
7995 in newly created dictionary, and add each copied variable to the
7998 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
8002 * get.c: (trim_dictionary) Free variable list for KEEP after
8005 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
8007 Some systems didn't like the way open_file was coded. Thanks to
8008 Hankin <hankin@rogue.consultco.com> for pointing this out.
8010 * filename.c: (open_file) Don't try to store stdin, stdout,
8011 stderr as part of an array, because that doesn't always work.
8013 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
8015 The SAVE procedure didn't save long string variables properly.
8016 Fixed by this patch. Thanks to Hankin
8017 <hankin@rogue.consultco.com> for this patch.
8019 * sfm-write.c: (write_variable) Fix off-by-one error in writing
8020 out variable pad records.
8022 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
8024 Previously, if PRINT SPACE were given a negative argument, it
8025 would report an error, then spin in an (almost) infinite loop.
8026 This fixes that behavior.
8028 * print.c: (print_space_trns_proc) After reporting a negative
8029 argument, set number of lines to print to 1.
8031 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
8033 SPSS 8.0 outputs some new record types in its system files, and it
8034 allows longer value labels. Accept these system files.
8036 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
8037 11 emitted by SPSS 8.0.
8039 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
8041 The LIST procedure was too conservative in allocating space for
8042 buffers, which caused a bug that only showed up with very long
8043 output variables. Thanks to Hankin <hankin@dunno.com> for this
8046 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
8048 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
8050 Typo meant string format specifiers weren't checked properly. I
8051 think that Hankin <hankin@dunno.com> sent me this report, but I'm
8052 willing to be corrected on this point.
8054 * format.c: (check_string_specifier) Fix obvious typo.
8056 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
8058 Using $CASENUM in an expression didn't work. Here's a fix.
8059 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
8062 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
8064 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
8066 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
8068 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
8069 other behavior, *sigh*. This patch hopefully fixes that. This
8070 time I've actually tested it.
8072 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
8074 * data-list.c: (read_from_data_list_free,
8075 read_from_data_list_list) Call parse_string_as_format() directly
8076 without mucking around with the field width.
8078 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
8080 Occasionally, you may encounter a script that wants to be
8081 interpreted in interactive mode. Make -i emulate this behavior to
8082 allow such scripts to be executed with PSPP.
8084 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
8086 * cmdline.c: (pre_syntax_message[]) Update -i description.
8088 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
8089 when -i is given on the command line) don't treat unindented lines
8090 as starting a new command.
8092 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
8094 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
8095 mostly caused by local initialized aggregates. After egcs is
8096 fixed upstream these can be removed, but for now they're not a big
8099 * ascii.c: (ascii_postopen_driver) Checker chokes on local
8100 initialized arrays. Avoid this.
8102 * sfm-write.c: (sfm_write_dictionary) Don't use a local
8105 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
8107 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
8108 following changes avoid. Currently I compile sources with egcs
8109 1.1.1 and gcc 2.7.2.3 before sending them out.
8111 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
8113 * ascii.c: (option_tab[]) Initialize all struct members.
8115 * avl.h: (avl_traverser_init) New macro.
8117 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
8120 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
8123 * hash.c: Comment fix.
8125 * hash.h: (hsh_iterator_init) New macro.
8127 * html.c: (option_tab[]) Initialize all struct members.
8129 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
8132 * postscript.c: (option_tab[]) Initialize all struct members.
8133 (output_encodings, preclose, dump_lines) Use new
8134 hsh_iterator_init() macro.
8136 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
8139 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
8142 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
8144 * data-in.c: Examined each of the parsing functions to make sure
8145 that they wouldn't dump core if they were passed a string of the
8146 wrong length, since now the DATA LIST FREE/LIST routines don't
8147 check for field width before passing it to the data parser.
8148 (parse_RBHEX, parse_AHEX) Reject odd length input.
8149 (parse_string_as_format) Reject input that's too short or too
8152 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
8153 a field to its entire declared output width then pass it to the
8154 data-in parsing routines. This contradicted the documented
8155 behavior. This is fixed in these changes. Thanks to Mark H. Wood
8156 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
8157 free-format parsing that differed from SPSS.
8158 (cut_field) Commas and spaces are treated identically. Returns
8159 the proper column instead of a fixed 1 value.
8160 (parse_field) Removed.
8161 (read_from_data_list_free, read_from_data_list_list) Call
8162 parse_string_as_format directly instead of parse_field.
8164 * heap.c: (heap_delete) Stylistic fixes.
8166 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
8168 * loop.c: (loop_2_trns_proc) Formatting fix.
8170 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
8172 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
8174 * vfm.c: (macro FILTERED) New.
8175 (static var filter_var) New.
8176 (process_active_file_write_case) Use FILTERED.
8177 (setup_filter) Set filter_var.
8178 (close_active_file) Delete the filter if not
8179 FILTER_before_TEMPORARY.
8180 (procedure_write_case) Use FILTERED.
8182 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
8184 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
8186 * data-in.c: (parse_day_count) Message fix.
8187 (parse_month) Style fix.
8189 * data-list.c: (struct data_list_pgm) New member eof.
8190 (cmd_data_list) Init eof to 0.
8191 (do_reading) Implement the /END subcommand and read-past-eof
8194 * do-if.c: Include stdio.h when debugging.
8195 (cmd_else_if) Make sure the command is .-terminated.
8197 * glob.c: (init_glob) Capitalize the command prompt.
8199 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
8200 (end_file_trns_proc) Debugging message.
8202 * loop.c: (internal_cmd_loop) Make it work when there's no loop
8204 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
8206 * main.c: (dump_token) Make kwtab[] const.
8208 * set.q: Spelling, comment fixes.
8210 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
8213 * vars-prs.c: (fill_all_vars) Style fix.
8215 * vfm.c: (index_to_varname) Return const.
8217 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
8219 * Changes in many source files for partial -ansi -pedantic and
8220 no-debugging compliance: Remove trailing common in enum
8221 declarations; add `unused' attributes; insert some appropriate
8224 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
8226 * command.c: (shell) Make static.
8227 (run_command) Make static.
8229 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
8231 * dfm.c: (cmd_begin_data) I18n fix.
8233 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
8235 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
8237 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
8240 * file-handle.q: Don't prepend the source file directory name to
8241 the data file name. (Ongoing issue.)
8242 (prepend_current_directory) Comment out.
8243 (internal_cmd_file_handle) Don't call prepend_current_directory().
8244 (fh_get_handle_by_filename) Ditto.
8246 * filename.c: Append zero byte to readlink() return value.
8248 * getline.c: (getl_read_line) I18n fix.
8250 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
8252 * misc.h: Don't use gcc features if __STRICT_ANSI__.
8254 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
8257 * postscript.c: (output_encodings) Don't use local_strdup().
8260 * print.c: Don't use gcc features if __STRICT_ANSI__.
8262 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
8264 * recode.c: (parse_src_spec) Fully brace nested if's.
8266 * set.q: (global var set_testing_mode) New var.
8268 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
8270 * ascii.c: Add some more `unused' attributes that only come into
8271 play when NDEBUG is defined.
8272 (ascii_close_page) Set s_len when reallocating s.
8274 * crosstabs.q: (delete_missing) New function.
8275 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
8276 (make_summary_table) Create summary table reallocable.
8278 * postscript.c: Add more `unused' attributes as above.
8280 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
8281 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
8283 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
8286 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
8287 gratuitous space between parameter definition.
8289 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
8290 complaints about running off the end of functions with NDEBUG
8293 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
8295 * Several source files: Removed some PORTME notes when reflection
8296 revealed that ANSI forbids that sort of breakage. Also, added
8297 lots of `unused' qualifiers here and there.
8299 * aggregate.c: (accumulate_aggregate_info) Remove local var
8300 weighting that turned out not to be used.
8302 * avl.c: Update to version 1.1.0. Add unused specifier.
8303 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
8305 (avl_probe) Replace some instances of 1 with +1 where appropriate.
8306 (avl_find) Cast return value to void *.
8307 (avl_delete) q doesn't need to be initialized at the beginning of
8308 the function. Replace some instances of 1 with +1.
8309 (force_avl_delete) Renamed avl_force_delete, all references changed.
8310 (compare_ints) `param' marked unused.
8311 (print_int) `param' marked unused.
8312 (recurse_tree) Replace some instances of 1 with +1.
8314 * avl.h: Update to version 1.1.0. Only declares avl function
8315 types if not already declared.
8316 (AVL_MAX_HEIGHT) Only define if not already defined.
8317 (struct avl_node) New unused member char pad[2].
8318 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
8319 (force_avl_insert) Renamed avl_force_insert.
8320 (force_avl_delete) Renamed avl_force_delete.
8322 * crosstabs.q: (struct table_entry) Put `freq' into a union with
8324 (struct crosstab) Add new member `ofs'.
8325 (glob var int_tab) Removed.
8326 (custom_tables) In integer mode, assign v[i] properly through the
8328 (custom_variables) Now p.crs.max == max + 1.
8329 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
8330 (precalc) Implement integer mode.
8331 (calc_integer) Implement integer mode.
8332 (compare_table_entry) Remove unused local variable `comparing'.
8333 (make_summary_table) Implement integer mode.
8334 (macro ns_rows) Implemented as static variable now.
8335 (several variables) Made static, from global.
8336 (output_pivot_table) Use table_value_missing() for column heads.
8337 Remove several unused local variables. Implement integer mode
8338 table summing. Count up ns_rows.
8339 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
8340 (find_pivot_extent) Moved into find_pivot_extent_general; now just
8341 calls that function or find_pivot_extent_integer.
8342 (find_pivot_extent_integer) New function.
8343 (enum_var_values) Implemented for integer mode.
8344 (table_value_missing) New function.
8345 (display_dimensions) Call table_value_missing() for heads.
8346 (float_M_suffix) New function.
8347 (display_crosstabulation) Call table_value_missing() for row
8348 heads. Handle missing values in /MISSING=REPORT mode.
8349 (calc_fisher) Remove unused var N.
8350 (calc_r) Remove unused var fact.
8352 * data-list.c: (dump_fixed_table) Fix table dimensioning.
8353 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
8355 * data-out.c: (insert_commas) Remove unused var cp.
8356 (convert_CCx) Remove unused vars save_set_decimal,
8359 * descript.q: (dump_z_table) Fix table dimensioning.
8360 (pre_calc) Remove unused var j.
8361 (display) Remove unused vars title, s. Fix table dimensioning.
8363 * expr-evl.c: Comment fixes.
8365 * frequencies.q: (full_dim) New function.
8366 (dump_full) Fix table dimensioning.
8367 (condensed_dim) New function.
8368 (dump_condensed) Fix table dimensioning.
8370 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
8373 * html.c: (html_close_drive) Remove unused var i.
8374 (postopen) Remove unused vars title, curfn_len, cp.
8375 (preclose) Remove unused vars this, x.
8377 * lexer.c: Comment fixes.
8379 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
8381 * means.q: (custom_tables) Remove unused var m_dim.
8383 * mis-val.c: Format fix.
8385 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
8387 * output.c: (outp_get_paper_size) Remove unused var cp.
8389 * pfm-read.c: (read_float) Remove unused var save, unused label
8391 (read_variables) Remove unused vars cp, j.
8392 (read_value_label) Remove unused var j.
8394 * pfm-write.c: (bufwrite) Remove unused var i.
8396 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
8398 (output_encodings) Remove unused vars char_cp, n_output.
8399 (read_ps_encodings) Remove unused var ep.
8400 (postopen) Remove unused var title.
8401 (preclose) Remove unused var fp.
8402 (ps_open_page) Remove unused vars true, false, orientation,
8403 mirror_horz, mirror_vert, width, length.
8404 (ps_text_metrics) Remove unused var x.
8406 * q2c.c: (find_symbol) Remove unused var y.
8407 (parse_setting) Remove unused parameter sbc, all references
8409 (dump_parser) Remove unused var cp.
8410 (dump_free) Remove unused var i.
8412 * set.q: (static vars args, n) Removed.
8413 (internal_cmd_gset) Removed.
8415 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
8416 (read_machine_flt64_info) Removed unused var file_endian.
8417 (read_documents) Removed unused var i.
8418 (read_compressed_data) Removed unused parameter dict, all
8421 * sfm-write.c: (bufwrite) Removed unused var i.
8422 (sfm_write_case) Removed unused var i.
8424 * sort.c: (merge_once) Remove unused var t.
8425 (write_separate) #if 0 out as dead code.
8427 * split-file.c: (cmd_split_file) Remove unused var i.
8429 * sysfile-info.c: (sysfile_info_dim) New function.
8430 (cmd_sysfile_info) Fix table dimensioning.
8431 (variables_dim) New function.
8432 (display_variables) Fix table dimensioning.
8433 (describe_variable) Remove unused var prev_r.
8435 * t-test.q: (z_postcalc) Removed.
8436 (pairs_calc) Remove unused var bad_weight.
8437 (postcalc) Remove unused vars dfn, dfd.
8439 * tab.c: (tab_create) Set t->dim to NULL.
8440 (tab_dim) Make sure t->dim is NULL first.
8441 (tab_natural_width) Remove parameter `clamp'.
8442 (tab_value) Remove duplicate assertion for table.
8443 (tab_raw) New function.
8444 (nowrap_dim) New function.
8445 (wrap_dim) New function.
8446 (tab_output_text) Fix table dimensioning.
8448 * tab.h: (tab_raw) New macro.
8450 * val-labs.c: (get_label) Remove unused var type.
8451 (copy_value_labels) Remove unused var trav.
8453 * var.h: (struct crosstab_proc) Completely changed.
8455 * vars-prs.c: (parse_dict_variable) Remove unused var v.
8457 * vfm.c: (open_active_file) Remove unused vars i, lp.
8459 * weight.c: (weight_trns_proc) #if 0 out as dead code.
8461 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
8463 * Makefile.am: Add apply-dict.c, flip.c.
8465 * apply-dict.c: New file.
8467 * command.c: (struct command) Make cmd[] larger for CLEAR
8468 TRANSFORMATIONS command name.
8469 (parse_cmd) Make sure we're in a valid state before using it as an
8470 index. Discard variables and reset state on invalid transitions.
8471 (cmd_clear_transformations) New function.
8473 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
8474 Add unimplemented PRESERVE, RESTORE.
8476 * file-handle.h: Include stddef.h.
8480 * pfm-read.c: (parse_value) Pad value label values with spaces,
8483 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
8484 (sfm_close) Decrement reference count, make sure it's zero.
8485 (sfm_maybe_close) New function.
8486 (sfm_read_dictionary) Handle reference counts.
8488 * vars-atr.c: (clear_default_dict) New function.
8489 (discard_variables) Use clear_default_dict().
8491 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
8493 * Makefile.am: Add pfm-write.c.
8494 (LDADD) Add the libgmp2 libraries.
8496 * command.def: Define EXPORT.
8498 * get.c: (cmd_export) New function.
8499 (export_write_case_func) New function.
8501 * pfm-read.c: (static spss2ascii[]) Make it const.
8503 * pfm-write.c: New file.
8505 * sfm-write.c: Formatting, comment fixes.
8507 * var.h: Comment fix.
8509 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
8511 * Makefile.am: Add pfm.h, pfm-read.c.
8513 * command.def: IMPORT is now implemented.
8515 * format.c: (glob var translate_fmt[]) New var.
8517 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
8518 (cmd_import) New function.
8519 (import_source_read) New function.
8520 (glob var import_source) New var.
8522 * pfm-read.c: New file.
8526 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
8528 (dump_dictionary) Disabled printing a couple of items.
8530 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
8532 * crosstabs.q: (postcalc) Call make_summary_table().
8533 (make_summary_table) New function.
8534 (insert_summary) New function.
8535 (display_dimensions) Remove some unnecessary arguments, all
8537 (output_pivot_table) Fix lots of problems with the risk table
8539 (submit) Don't display an empty table.
8540 (display_risk) Fix order of arguments to calc_risk().
8542 * glob.c: Always include assert.h and stdlib.h.
8544 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
8547 * tab.c: (tab_create) Cosmetic changes.
8549 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
8551 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
8555 * crosstabs.q: (output_pivot_table) Headers drawing and submission
8556 code simplified, moved into new function submit().
8557 (submit) New function.
8558 (crosstabs_dim) New function.
8559 (display_directional) Substitute variable names for %s where
8561 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
8562 (calc_symmetric) Initialize parameters only if non-NULL.
8563 Calculate Somers' d.
8564 (calc_directional) Calculate Somers' d (or copy it, really).
8567 * output.c: (outp_string_width) New function.
8569 * postscript.c: (postopen) Calculate font widths based on the
8570 width of the zero '0' character, not the width of the space
8571 character. Set paper-width and paper-length based on points, not
8573 (ps_open_page) Fix page setup string for landscape mode.
8575 * som.h: (struct som_dimension) Removed.
8576 (struct som_table_class) height, width members take int * not
8579 * tab.c: Many functions now have added parameter validation.
8580 (tab_height, tab_width) These functions were removed and merged
8581 into a single function tab_resize(), and all references changed.
8582 (tab_dim) Rewritten since the interface changed; reduced from
8583 hundreds of lines to two. All callers were changed. Currently
8584 most of them just use tab_natural_dimensions as their callback and
8585 await detailed translation of functionality.
8586 (tab_natural_width) New function.
8587 (tab_natural_height) New function.
8588 (tab_natural_dimensions) New function. This is a callback
8589 function, not something that you'd want to call directly.
8590 (tab_nat_dim) Removed.
8591 (tabi_table) Allocates t->w and t->h.
8592 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
8593 dimensions callback.
8594 (evaluate_dimensions) Removed.
8595 (sum_columns) Removed.
8597 * tab.h: (enum TAL_1THIN) Removed.
8598 (enum series t_*) Removed.
8599 (struct tab_table) Members trh, trv changed to unsigned char *
8600 from int *. Member dim changed to a function pointer from a
8601 unsigned char *. Member max_stack_height removed. New members
8603 (macros tab_l, tab_r, tab_t, tab_b) New.
8605 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
8607 * ascii.c: (delineate) Assign last_space_nchars before skipping
8608 spaces, to fix right justification.
8610 * crosstabs.q: (static vars risk, direct) New vars.
8611 (static var pearson_r) Removed.
8612 (glob var chisq_fisher) Made static.
8613 (static vars row_tot[], col_tot[]) Don't include grand total
8615 (static var grand_total) Renamed W, all references changed.
8616 (output_pivot_table) Only make `table' if num_cells != 0. Make
8617 risk and directional tables. Deal with grand total no longer part
8618 of col_tot[]. Free rows and cols after we're done with them.
8619 (display_risk) New function.
8620 (display_directional) New function.
8621 (clac_r) Rewritten so that it stores all its results into its
8622 arguments, so it can be used for Spearman's correlation too.
8623 (calc_symmetric) Added a t[] argument, all references changed.
8624 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
8625 Pearson's r, Cohen's kappa.
8626 (calc_risk) New function.
8627 (calc_directional) New function.
8629 * som.c: (som_submit) Improved debugging code.
8631 * stats.c: (hypercube) New function.
8632 (cube) New function.
8634 (normal_sig) Went back to old implementation, which actually
8637 * stats.h: (macros square, cube, hypercube) Removed. The
8638 equivalent functions in stats.c are inlined here; all references
8639 to square changed to sqr.
8641 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
8643 * crosstabs.q: (N_SYMMETRIC) New define.
8644 (postcalc) Disable debug printing.
8645 (static vars chisq_fisher, pearson_r) New.
8646 (output_pivot_table) Add support for symmetric measures. Add
8647 chi-square output of exact sigs.
8648 (display_chisq) Rewritten.
8649 (display_symmetric) New function.
8650 (gamma_int) New function.
8652 (swap) New function.
8653 (calc_fisher) New function.
8654 (calc_chisq) Check boundary conditions better. Calculate Yates,
8655 Fisher, Mantel-Haenszel tests.
8656 (calc_r) New function.
8657 (calc_symmetric) New function.
8659 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
8661 (chisq_sig) Better boundary conditions. Renamed from
8664 * tab.h: (struct tab_table) New member cf.
8666 * tab.c: (tab_create) Set cf.
8667 (tab_width) New function.
8668 (tab_realloc) Handle cf.
8669 (tab_vline) Handle cf.
8670 (tab_hline) Handle cf.
8671 (tab_box) Handle cf.
8672 (tab_value) Handle cf.
8673 (tab_float) Handle cf.
8674 (tab_text) Handle cf.
8675 (tab_joint_text) Handle cf.
8676 (tab_offset) Handle cf.
8677 (tab_next_row) Handle cf.
8678 (evaluate_dimensions) Handle cf.
8679 (render_strip) Handle cf.
8681 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
8683 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
8684 output_pivot_table().
8685 (output_pivot_table) Moved lots of local variables outside and
8686 made them static. Add beginnings of chi-square statistic
8687 support. Now column and row totals aren't in the main matrix.
8688 Always zero out any leftover rows & columns after we're done with
8689 the table entries. Move all output stuff into
8690 display_dimensions(), display_crosstabs(), display_chisq().
8691 (display_dimensions) New function.
8692 (display_crosstabulation) New function.
8693 (display_chisq) New function.
8694 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
8696 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
8697 references, simplify logic.
8699 * postscript.c: Remove scale, translate-x, translate-y,
8700 mirror-horz, mirror-vert, rotate-180 options.
8701 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
8702 All references deleted.
8703 (macro YT) New macro.
8704 (array option_tab[]) Removed options.
8705 (ps_option) Removed options.
8706 (ps_open_page) Write page setup explicitly to output file, without
8707 using now-deleted BP function.
8708 (macro dump_line) Use YT().
8709 (macro dump_thick_line) Use YT().
8710 (draw_headers) Use YT().
8711 (switch_font) Reorder arguments to SF function.
8712 (write_text) Use YT().
8714 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
8717 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
8719 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
8720 null-debugging code.
8721 (tab_realloc) Remove null-debugging code. Initialize new regions
8723 (tab_vline) Support offsets.
8724 (tab_hline) Support offsets.
8725 (tab_box) Support offsets.
8727 (tab_nulls) Removed.
8730 (evaluate_dimensions) Remove null-debugging code. Understand
8731 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
8732 TAB_EMPTY not present.
8734 * tab.h: New cell attribute TAB_EMPTY.
8735 (macros tab_nr, tab_nc, tab_row, tab_col) New.
8737 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
8738 try to read them from system files.
8740 * vfm.c: (dump_splits) Don't call tab_null().
8742 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
8744 * crosstabs.q: (struct crosstab) Added `missing' member.
8745 (custom_tables) Init missing.
8746 (calc_general) Handle missing values.
8747 (calc_chisq) New function.
8748 (output_pivot_table) Start work on chi-square output. Update for
8749 new tab offset support functions. Shorten statistic names.
8751 * Several files: add in more `const's to placate gcc's warnings.
8753 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
8756 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
8757 tab_null, tab_nulls, tab_value, tab_float, tab_text,
8758 tab_joint_text) Add col_ofs and row_ofs support.
8759 (tab_offset) New function.
8760 (tab_next_row) New function.
8761 (tab_row) New function.
8762 (tab_col) New function.
8763 (tabi_table) Add col_ofs and row_ofs support.
8765 * vars-atr.c: (is_system_missing) New function.
8767 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
8769 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
8770 (static var no_cells) Removed.
8771 (static var num_cells) New.
8772 (static var expected) New.
8773 (static var cells[]) New.
8774 (internal_cmd_crosstabs) Deal with new variables.
8775 (postcalc) Removed most of the meat and put it in new function
8776 output_pivot_table().
8777 (output_pivot_table) Calculates and outputs an entire pivot table.
8779 * postscript.c: (postopen) Fix problems with free()ing addresses
8780 not obtained from malloc().
8782 * som.c: (som_submit) Add assertion.
8784 * sysfile-info.c: (describe_variable) Use new tab_nulls()
8787 * tab.c: (static var tab_names[]) New.
8788 (tab_realloc) -1 for nc or nr indicates no change.
8789 (tab_nulls) New function.
8790 (tab_dim) Use tab_names[].
8791 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
8792 (evaluate_dimensions) Don't terminate on uninited cells, just put
8793 an X in them and emit a notice. Use tab_names[].
8795 * tab.h: Move bits into tab.def.
8797 * tab.def: New. Don't try to declare tab_table_class because then
8798 som.h has to be included.
8800 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
8802 * command.def: New file, contains all the command definitions
8803 previously included bodily in command.c.
8805 * format.def: New file, contains all of the format definitions
8806 previously split across format.h, format.c, and sfm-write.c.
8808 * lexer.h: Renamed from tokens.h in order to match corresponding
8811 * lexerP.h: Moved some rarely used functions exported by lexer.c
8814 * Makefile.am: Commemorate renamed files.
8815 (EXTRA_DIST) Add command.def, format.def.
8817 * command.c: [0] (walk_cmdtable_func) Removed.
8819 * crosstabs.q: (postcalc) Made it work and print out matrices
8821 (enum_column_values) Renamed enum_var_values, generalized for any
8824 * format.h: (struct fmt_desc) New member `spss'.
8826 * q2c.c: (main) Generated code includes lexer.h instead of
8829 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
8830 instead of an independent translation table.
8832 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
8834 * Lots of source files: Added const to declarations.
8836 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
8838 * arena.c: (arena_clear) Set prev pointer to null when done.
8840 * ascii.c: (ascii_option) Rename index as indx.
8842 * avl.c: This is now a separate library called libavl.
8843 (xmalloc) Make static.
8844 (avl_probe) Step A7 can use the cache instead of an explicit
8846 (avl_delete) Don't maintain a q pointer because it's always
8847 available in the pointer stack. Comment fix.
8849 * avl.h: This is now a separate library called libavl.
8851 * command.c: (cmd_table[]) Remove spurious trailing "".
8853 * common.h: Only include random() fix if this system needs it.
8855 * crosstabs.q: Include alloca headers.
8856 (n_sorted_tab) New global var.
8857 (postcalc) Mostly rewritten.
8858 (find_pivot_extent) Rewritten.
8859 (enum_column_values) Rewritten.
8861 * data-out.c: (convert_F) Rename inner n as n_spaces.
8863 * error.c: (dump_message) Don't have an outer var i.
8865 * file-handle.q: (static var f) Removed. All references removed.
8866 (internal_cmd_file_handle) Uses a local variable instead of f.
8868 * get.c: (trim_dictionary) Change scope of i, i1, i2.
8869 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
8872 * getline.h: Declare getl_history as extern. Reported by
8873 palme@uni-wuppertal.de (Hubert Palme).
8875 * postscript.c: (postopen) Some large mods for constness.
8877 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
8880 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
8882 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
8883 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
8886 * avl.c, avl.h: New files. These form a clean-room
8887 reimplementation of avllib. Iterative algorithms are used in
8888 place of recursive ones, so there is no resemblance in the code.
8890 * Lots of headers: Don't include other headers by default.
8892 * Lots of source files: Explicitly include all needed headers.
8894 * arena.c: (arena_clear) New function.
8896 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
8897 (static var ar) Removed.
8898 (staitc vars ar_tc, ar_col) New.
8899 (cmd_crosstabs) Destroy the arenas.
8900 (internal_cmd_crosstabs) Create the arenas.
8901 (precalc) Don't need a free function for the hash.
8902 (calc_general) Make sure to zero out the trailer on the key data
8904 (print_table_entries) Updated.
8905 (postcalc) Worked on actually implementing.
8906 (find_pivot_extent) New function.
8907 (compare_value) New function.
8908 (enum_column_values) New function.
8910 * data-in.c: (parse_month) Make local array `static const'.
8912 * data-out.c: (convert_date) Make local array `static const'.
8913 (convert_WKDAY) Same.
8914 (convert_MONTH) Same.
8916 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
8917 been renamed to avl_walk().
8919 * hash.c: Rewritten more efficiently.
8921 * hash.h: Add attribute const to hsh_next_prime declaration.
8923 * lexer.c: (id_match) Make arguments const.
8925 * postscript.c: (ps_postopen_driver) Make default fonts the
8928 * q2c.c: (main) Generated code needs stdlib.h.
8930 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
8931 initialized to 0 now, not to NULL. All other references to
8932 avl_traverser were updated in the same way.
8934 * tokens.h: Macro version of id_match updated to use const
8937 * val-labs.c: (inc_ref_count) New function.
8938 (copy_value_labels) Simply through use of new avl_copy() function.
8940 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
8942 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
8943 (postcalc) Worked on this.
8945 * postscript.c: (OPO_DOUBLE_LINE) New enum.
8946 (struct ps_driver_ext) New line_width_thick member.
8947 (ps_preopen_drive) Init line_width_thick.
8948 (option_tab[]) Add line-* options.
8949 (ps_option) Parse line-* options.
8950 (postopen) Add line_width_thick support. Strip leading spaces on
8951 prologue output lines.
8952 (ps_open_page) Include line_width_thick in output.
8953 (macro dump_thick_line) New.
8954 (dump_fancy_line) Support thick lines as well as double lines.
8956 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
8958 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
8959 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
8961 * Many source files: Rename `options' to `pv_opts' as appropriate.
8963 * command.c: (static var cmd_table[]) Add CROSSTABS command.
8965 * common.c: (xcalloc) New function.
8967 * crosstabs.q: New file. Not finished yet, though.
8969 * data-list.c: Comment fix.
8971 * error.c: Remove some old Checker cruft.
8973 * frequencies.q: (dump_full) Cumulate valid percent instead of
8976 * getline.c: Comment fix.
8978 * hash.c: Comment fixes.
8980 * hash.h: (struct hsh_table) Make hash functions return unsigned
8981 instead of int to avoid problems with taking the modulo of
8982 negative return values. All references changed.
8984 * misc.c: (intlog10) Make its table static const instead of auto.
8986 * sfm-read.c: (read_header) Make `prefix' static const instead of
8989 * var.h: (union value) Add member `hash'.
8990 (struct variable) Rename prv_index as `foo'--all references
8992 (typedef pv_opts) Removed. All references changed.
8994 * vars-prs.c: (parse_variables) Message fixes.
8996 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
8998 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
8999 they are being inserted. Don't check for BY variables of
9000 different types. Discard variables if the active file isn't
9001 included in the merge.
9002 (mtf_processing) Essentially rewritten.
9003 (mtf_merge_dictionary) Check for master/slave variables of
9004 different types/widths.
9006 * vfm.c: (static var not_canceled) New var.
9007 (process_active_file) Don't call vfm_source->read() if
9008 there's no vfm-source. Initialize not_canceled.
9009 (process_active_file_write_case) Honor and update not_canceled.
9010 (prepare_for_writing) Rollback changes from yesterday, they were
9012 (close_active_file) Don't destroy vfm_source unless it exists.
9014 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
9016 * Lots of source files: Added { } around nested if/else constructs
9017 to avoid new gcc 2.8 warnings.
9019 * data-in.c: (parse_Z) Declare `int' type explicitly.
9022 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
9023 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
9024 prev members. Put TABLEs at the end of the chain and FILEs at the
9025 beginning. Don't allow the active file in STATE_INIT. Use proper
9026 `seen' value for the active file. Fill out the by members and
9027 make sure they're of consistent type. Do the actual merge
9029 (mtf_processing_finish) New function.
9030 (var_type_description) New function.
9031 (mtf_free_file) New function.
9032 (mtf_free) Rewritten.
9033 (mtf_delete_file_in_place) New function.
9034 (mtf_read_nonactive_records) New function.
9035 (mtf_compare_BY_values) New function.
9036 (static var mtf_seq_no) New var.
9037 (mtf_processing) New function.
9038 (mtf_merge_dictionary) Assign nval members for the system file
9039 dictionary. Assign fv values for its variables. Point each slave
9040 variable to the corresponding master variable.
9042 * hash.c: Include str.h.
9044 * mis-val.c: (copy_missing_values) src arg is const.
9046 * misc.c: (spacing) Make `max' var explicitly int.
9048 * sfm-read.c: (dump_dictionary) Message reformatting.
9049 (sfm_read_case) Add assertion.
9051 * sort.c: Esthetic fixes.
9053 * var.h: (struct match_files_proc) New struct.
9054 (struct variable) Add private data match_files_proc.
9056 * vars-atr.c: (delete_variable) Implement. Add argument for the
9057 dictionary that owning the variable.
9058 (dup_variable) Add assertion.
9060 * vfm.c: Comment fixes, hopefully the comments are correct now.
9061 (process_active_file) New function.
9062 (process_active_file_write_case) New function.
9063 (process_active_file_output_case) New function.
9064 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
9066 (write_case) Renamed procedure_write_case(). Now write_case is a
9067 pointer to a function. Style fixes.
9069 1998-03-05 Ben Pfaff <blp@gnu.org>
9071 * Makefile.am: (q2c) Link with libmisc.
9072 (version.c) Define default_config_path, include_path,
9075 * ascii.c: (ascii_postopen_driver) When the default newline string
9076 is requested, open file in text mode. Suggested by
9077 palme@uni-wuppertal.de (Hubert Palme).
9078 (static vars line_buf, line_p) Change from char * to unsigned char
9080 (ascii_close_page) char * to unsigned char *.
9082 * cmdline.c: (parse_command_line) Implement -r option by
9083 prepending ~/.pspp/rc to the list of files to process.
9085 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
9086 before pulling in a final line.
9087 (null_func, null_int_func) Removed (dead code).
9089 * descript.q: (display) Calculate width of variable name column
9090 properly. Calculate number of valid cases properly. Reported by
9091 palme@uni-wuppertal.de (Hubert Palme).
9093 * filename.c: (init_filename) Use default_config_path instead of
9094 now obsolete CONFIG_PATH.
9096 * getline.c: (getl_initialize) Use include_path instead of now
9097 obsolete INCLUDE_PATH.
9098 (getl_add_file) New argument `where'. All references changed.
9100 * groff.c: (find_font_file) Use groff_font_path instead of now
9101 obsolete GROFF_FONT_PATH.
9103 * postscript.c: (find_ps_file) Use groff_font_path instead of now
9104 obsolete GROFF_FONT_PATH. Copy through temporary variable to
9105 avoid problems with constness.
9107 * str.h: (macro cs_streq) New macro.
9109 * version.h: (glob var default_config_path, include_path,
9110 groff_font_path) New vars.
9112 1998-02-23 Ben Pfaff <blp@gnu.org>
9114 * Many source files: Change verbose_msg() priority levels and
9117 * aggregate.c: Include debug-print.h.
9119 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
9121 (static var pre_syntax_message) Document --safer/-s and
9124 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
9126 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
9127 because it's not used but it's still copied.
9128 (open_file_r) Remove gratuitous debug message.
9130 * filename.c: (safety_violation) New function.
9131 (open_file) Remove gratuitous debug messages. Don't allow pipe
9132 files if set_safer is set.
9134 * get.c: Turn off debugging.
9136 * getline.c: (getl_add_virtual_file) New function.
9137 (getl_read_line) Add verbose_msg() call for opening new syntax
9139 (getl_perform_delayed_reset) Add a return value describing whether
9140 any action was taken. Call reset_eof().
9142 * getline.h: Comment fix.
9144 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
9145 place of incorrect `continue'. Use strtok_r() instead of
9146 strtok(). Always check strtok_r() return value.
9147 (groff_read_DESC) Use strtok_r() instead of strtok().
9149 * lexer.c: (reset_eof) New function.
9151 * main.c: (parse) Get a token after performing a delayed reset
9152 action; allow empty syntax files.
9154 * postscript.c: (output_encodings) Use strtok_r() instead of
9157 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
9159 * set.q: Comment fixes.
9160 (glob var set_safer) New var.
9161 (internal_cmd_set) Support SAFER.
9163 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
9165 * temporary.c: (free_dictionary) Set d->splits to NULL after
9168 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
9169 variable deleted, not if it *isn't* deleted.
9171 1998-02-16 Ben Pfaff <blp@gnu.org>
9173 * command.c: (array cmd_table[]) Add MATCH FILES.
9175 * common.c: Comment fixes.
9177 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
9178 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
9179 Include alloca.h. Problem reported by palme@uni-wuppertal.de
9182 * expr-opt.c: Include str.h. Problem reported by
9183 palme@uni-wuppertal.de (Hubert Palme).
9185 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
9186 (static var mtf_by) Change from char ** to variable **.
9187 (static var mtf_master) New var.
9188 (mtf_merge_dictionary) New function.
9189 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
9190 var type. Reorder tests properly. Initialize file->dict. Detect
9191 TABLE= without BY=. Read file dictionaries and merge them. Give
9192 subcommand name with IN, LAST, FIRST error messages. Create IN,
9193 LAST, FIRST variables. Comment fixes.
9194 (mtf_free) Don't free default_dict. Free mtf_master.
9196 * getline.c: Define getl_mode. Change getl_buf_size to size_t
9198 (handle_line_buffer) Cast int to size_t in comparison to avoid
9201 * getline.h: Declare getl_mode extern.
9203 * groff-font.c: (groff_read_font) Type-fix calls to getline.
9204 (groff_read_DESC) Make line_size a size_t.
9205 (match_tok) Parenthesize name to avoid macro expansion.
9207 * mis-val.c: (copy_missing_values) New function.
9209 * postscript.c: (postopen) Make buf_size a size_t.
9211 * sfm-read.c: (dump_dictionary) Make global from static. Print
9212 variable info in parts for easier debugging with Checker.
9214 * temporary.c: (copy_variable) Use copy_value_labels().
9215 (new_dictionary) New arg: whether to copy file label, documents.
9217 * val-labs.c: (copy_value_labels) New function.
9219 * var.h: (enums MISSING_*) Add MISSING_COUNT.
9221 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
9223 (dup_variable) Set prv_index, get.fv, get.nv.
9225 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
9227 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
9229 * Many source files: For ANSI-compliance, add empty statement
9230 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
9231 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
9233 * data-in.c: (parse_numeric) Some header files break on
9234 -DBL_MIN_10_EXP because they get a --; add () for safety.
9235 Reported by palme@uni-wuppertal.de (Hubert Palme).
9237 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
9238 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
9239 (dfm_close) Use close_file_ext.
9240 (open_inline_file) Set file.file to NULL, not file.
9241 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
9242 struct and use open_file_ext().
9243 (read_record) Use file.file.
9245 * file-handle.q: (prepend_current_directory) Pass through special
9248 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
9249 (normalize_filename) Pass through special filenames.
9250 (open_file, close_file) Accept pipe| and |pipe syntaxes as
9252 (dirname) Rename blp_dirname() because of name conflict on some
9253 OS. All references changed. Reported by palme@uni-wuppertal.de
9255 (is_special_filename) New function.
9257 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
9258 (trim_dictionary) Conditionalize some of the options on whether
9259 GTSV_OPT_MATCH_FILES is in *options.
9260 (rename_variables) Don't allow variables to be renamed as scratch
9262 (MTF_*) New enum series.
9263 (struct mtf_file) New struct.
9264 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
9266 (cmd_match_files, mtf_free) New functions.
9268 * lexer.c: (match_int) Needed parentheses around name to escape
9269 macro expansion. Reported by Micah Altman
9270 <maltman@www-vdc.fas.harvard.edu>.
9272 * print.c: Needed to include alloca.h. Reported by Micah Altman
9273 <maltman@www-vdc.fas.harvard.edu>.
9275 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
9276 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
9279 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
9280 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
9282 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
9284 * html.c: (struct html_driver_ext) Move into htmlP.h.
9285 (html_preopen_driver) Initialize cp_x, cp_y.
9286 (html_submit) Implement as call to output_tab_table().
9287 (change_attributes) New function.
9288 (escape_string) New function.
9289 (output_tab_table) New function.
9291 * list.q: (write_all_headers) Add code for writing headers for the
9293 (clean_up) Write out the html close-table tag.
9294 (determine_layout) Ignore html driver.
9295 (list_cases) Write html data.
9297 * som.c: (som_submit) Move more of the code into output_table().
9299 * tab.c: (static var hit) Make a global var and rename tab_hit.
9300 (static var tab_table_class) Make a global var.
9302 * htmlP.h: New file.
9304 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
9306 * dump-sysfile.c: Removed.
9308 * html.c: (preclose) Change comment in emitted code.
9310 * matrix-data.c: Debugging off by default. Comment fixes.
9311 (static var container) New var.
9312 (cmd_matrix_data) Create and destroy container. Initialize
9313 is_per_factor[] to 0s. Move code into new function
9314 string_to_content_type(). Require split values to be present in
9315 the data when ROWTYPE_ is explicit. Call specific function, not
9316 general read_matrices().
9317 (string_to_content_type) New function.
9318 (context) Exclude all whitespace, not just spaces.
9319 (mget_token) A dot is a number. Add assertion.
9320 (static var data) Renamed nr_data.
9321 (static var factor_values) Renamed nr_factor_values.
9322 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
9323 only specific case. Close data_file before exit.
9324 (fill_matrix) New function.
9325 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
9326 printing. Style fixes. Message fixes. Move code into
9328 (read_matrices_without_rowtype) Rename
9329 matrix_data_read_without_rowtype(). Fix off-by-one error on
9330 loops. Allocate nr_data[] memory from arena.
9331 (read_matrices_with_rowtype) Removed.
9332 (read_splits) Renamed nr_read_splits(). Style fixes.
9333 (read_factors) Renamed nr_read_factors().
9334 (dump_cell_content) Comment fixes. Arguments changed. Change
9335 debug printing. All references changed.
9336 (output_data) Renamed nr_output_data().
9337 (static var wr_content) New var.
9338 (struct factor_data) New struct.
9339 (static var wr_data) New var.
9340 (static var wr_current) New var.
9341 (matrix_data_source_destroy_source) Removed.
9342 (read_matrices_with_rowtype) New function.
9343 (matrix_data_read_with_rowtype) New function.
9344 (wr_read_splits) New function.
9345 (compare_factors) New function.
9346 (wr_output_data) New function.
9347 (wr_read_rowtype) New function.
9348 (wr_read_factors) New function.
9349 (wr_read_indeps) New function.
9350 (glob var matrix_data_source) Make destroy_source member NULL as
9353 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
9355 * lexer.c: (syntax_error) Give better error message when at end of
9358 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
9359 N_SCALAR to output as plain N.
9360 (mdump_token) Change output format.
9361 (context) Fix message output interaction with spaces in input.
9362 (another_token) New function.
9363 (force_eol) Improved error message.
9364 (static var max_cell_index) New var.
9365 (read_matrices) Init `cells'. factor_values is now per-cell.
9366 Init max_cell_index.
9367 (read_data_lines) Replace `compare' local with new `compare' arg.
9368 Debugging messages changed. Only read factors if per_factor.
9369 Propagate error return from read_factors(), force_eol().
9370 Copy N_SCALAR values across the N vector.
9371 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
9372 check parentheses manually since we now have is_per_factor[].
9373 Call read_data_lines() with new args. Check for end of data after
9374 looping, using another_token().
9375 (read_factors) Arguments changed. Use max_cell_index to determine
9376 whether to read or compare factors. Message fixes.
9377 (dump_cell_content) New function.
9378 (output_data) Completely rewritten because content types were
9379 supported to be nested inside factor values, not vice versa.
9381 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
9383 * lexer.c: (syntax_error) Support formatted varargs messages.
9385 * matrix-data.c: Turn debugging on by default.
9386 (static content_type[]) New array.
9387 (static content_names[]) New array.
9388 (static rowtype_, varname_) New vars.
9389 (static is_per_factor[]) New array.
9390 (static split_values) Moved declaration.
9391 (static n_continuous, first_continuous) New var.
9392 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
9393 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
9394 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
9395 Check for continuous variables.
9396 [DEBUGGING] (debug_print) Remove content_names[].
9397 (mdump_token) New macro.
9398 (mget_token_dump) New function.
9399 (mdump_token) New function.
9400 (context) New function.
9401 (mget_token) Fix messages.
9402 (static var data, split_values, factor_values) New vars.
9403 (read_matrices) Manage split_values, factor_values.
9404 (read_data_lines) New function.
9405 (read_matrices_without_rowtype) Implemented.
9406 (read_splits) Message fixes. Uses `just_read'.
9407 (read_factors) New function.
9408 (output_data) New function.
9409 (matrix_data_source_destroy_source) Close the file handle.
9410 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
9413 * str.c: (strpadcmp) Removed.
9415 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
9417 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
9419 * Lots of source files: Add cast to unsigned character to calls to
9420 tolower() and toupper().
9422 * aggregate.c: Set default_dict.splits to NULL.
9424 * command.c: (static variable tab[]) Add MATRIX DATA.
9426 * data-in.c: Add debugging defines. Formatting fixes.
9428 * expr-opt.c: Formatting fixes.
9430 * lexer.c: (syntax_error) Message fixes.
9432 * matrix-data.c: New enum series.
9433 (static vars fmt, section, diag, explicit_rowtype, signle_split,
9434 split_values, n_factors, factors, cells, pop_n, contents,
9435 n_contents) New vars.
9436 (cmd_matrix_data) Finished implementation.
9437 (compare_variables_by_mxd_vartype) New function.
9438 [DEBUGGING] (debug_print) New function.
9439 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
9440 (read_matrices) New function.
9441 (read_matrices_without_rowtype) New function.
9442 (read_matrices_with_rowtype) New function.
9443 (read_splits) New function.
9444 (mget_token) New function.
9445 (force_eol) New function.
9446 [0] (test_tokenizer) New function.
9447 (matrix_data_source_destroy_source) New function.
9448 (glob var matrix_data_source) New var.
9450 * misc.h: Include ieeefp.h if present.
9452 * split-file.h: (cmd_split_file) Changes corresponding to struct
9455 * str.h: Fix memmem prototype.
9457 * temporary.c: (save_dictionary, restore_dictionary,
9458 free_dictionary) Changes corresponding to struct dictionary
9461 * var.h: (MXD_* enums) New enum series.
9462 (struct matrix_data_proc) New struct.
9463 (struct split) Removed.
9464 (struct dictionary) Changed `splits' member from `split *' to
9466 (macro force_create_variable) New macro. Replaced lots of
9467 create_variable()/assert() calls with calls to this macro.
9469 * vars-atr.c: (discard_variables) Changed assertion.
9470 [GLOBAL_DEBUGGING] (force_create_variable) New function
9471 called by the macro of the same name.
9472 (clear_variable) Changes to delete splits from the dictionary
9473 corresponding to struct dictionary changes.
9475 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
9476 corrupted variable `index' values in the dictionary passed in
9477 every time this function is called.
9479 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
9480 to struct dictionary changes.
9482 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
9484 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
9486 * command.c: New includes.
9487 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
9488 (cmd_erase) New function.
9489 [unix] (shell) New function.
9490 (run_command) New function.
9491 (cmd_host) New function.
9492 (cmd_new_file) New function.
9494 * expr-prs.c: (parse_primary) Message fix.
9496 * inpt-pgm.c: Formatting fix.
9497 (cmd_reread) Implement the FILE subcommand.
9499 * matrix-data.c: New file.
9501 * q2c.c: (dump_header) Change output commenting style.
9503 * weight.c: Comment fix.
9505 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
9507 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
9509 (buf_10x) Renamed buf_1xx, all references changed.
9510 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
9511 cases now implemented).
9512 (create_sysfile) New function.
9513 (agr_11x_func) New function.
9515 * data-in.c: (parse_numeric) Work properly if there's an
9516 explicitly coded decimal point in the data and decimal places are
9517 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
9518 <el@linux.lisse.na>.
9520 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
9521 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
9522 Eberhard W Lisse <el@linux.lisse.na>.
9524 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
9525 strerror.c. Bug reported by Alexandre Oliva
9526 <oliva@dcc.unicamp.br>.
9528 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
9529 (static var separate_case_tab) New var.
9530 (cmd_sort_cases) Cancel temporary transformations here. Free
9531 v_sort before return.
9532 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
9533 we're reading from a sort stream. Don't cancel temporary
9534 transformations. Offload internal sorting to do_internal_sort().
9535 (do_internal_sort) New function. Handles internal sorting even
9536 when SEPARATE is nonzero. Doesn't free v_sort.
9537 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
9539 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
9540 sink if SEPARATE is zero.
9541 (read_output_cases) Renamed read_sort_output(), all references
9542 changed. Now uses separate_case_tab when it exists.
9543 (write_separate) New function.
9545 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
9546 memory_sink_cases. Don't redundantly call
9547 vfm_source->destroy_source().
9548 (memory_stream_mode) After switching over, set memory_sink_cases
9551 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
9553 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
9555 (static var prev_case) New, moved out of aggregate_single_case()
9557 (static var buf64_10x, buf_10x) New.
9558 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
9559 the 000, 001, 100, and 101 cases. Free prev_case.
9560 (parse_aggregate_functions) Disallow scratch variables.
9561 (free_aggregate_functions) Only free agr_dict if non-null. Use
9562 iter->function to determine numeric/string type, not
9564 (aggregate_single_case) Don't manage prev_case. Initialize
9565 aggregate info after dumping it.
9566 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
9567 mean, stddev, weighted stddev definitions.
9568 (dump_aggregate_info) Implemented.
9569 (initialize_aggregate_info) Renamed from
9570 initialize_aggregate_functions(). Initializes dbl[2].
9571 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
9572 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
9574 * cases.c: (alloc_val) Removed.
9576 * get.c: (cmd_save_internal) Initialize new `dict' member.
9578 * sfm-write.c: (sfm_write_dictionary, write_header,
9579 write_variable, write_value_labels, write_documents) Reorganize,
9580 simplify for new parameter structure.
9581 (write_variable) Only one variable * argument now.
9583 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
9584 replaced by new `dict' member.
9586 * temporary.c: (new_dictionary) Initialize n_documents.
9588 * vars-atr.c: (dup_variable) Allocate `value's from dict into
9590 (init_variable, replace_variable) Eliminate usage of alloc_val().
9592 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
9594 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
9595 signal that AGGREGATE is to be used for forming final cases.
9596 (close_active_file) Call end_func before stopping lagging. Cancel
9597 temporary after finishing compaction.
9598 (write_case) Comment fixes. Cleaned up.
9599 (compact_case) Let AGGREGATE handle compaction when `temporary' is
9602 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
9604 * Makefile.am: (BUILT_SOURCES) Add means.c.
9605 (pspp_SOURCES) Add means.c.
9606 (EXTRA_DIST) Add means.q.
9608 * command.c: (array cmd_table[]) Add MEANS.
9610 * common.h: Esthetic fixes. Comment fixes. Test for
9611 MAX_SHORT_STRING greater than 8.
9612 (macros LOWEST, HIGHEST) New.
9614 * data-in.c, data-list.c, recode.c: Comment fixes.
9616 * means.q: New file, base version.
9618 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
9619 with LOWEST, DBL_MAX with HIGHEST.
9621 * q2c.c: (dump_vars) Add an enum to array types giving the number
9622 of values for the enum.
9624 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
9625 Replace second_lowest_value with second_lowest_flt64.
9627 * sfm-write.c: (write_variable, write_rec_7_34) Replace
9628 second_lowest_value with second_lowest_flt64.
9630 * t-test.q: Comment fix.
9632 * temporary.c: (restore_dictionary) Esthetic fix.
9634 * tokens.h: (force_match_id, force_match, force_string, force_int,
9635 force_num, force_id) Replace msg() with syntax_error().
9637 * var.h: (struct means_proc) New.
9638 (struct variable) Add mns member to `p' union.
9640 * vars-prs.c: (parse_variable, parse_dict_variable,
9641 parse_variables, parse_DATA_LIST_vars) Replace msg() with
9644 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
9646 * Makefile.am: (pspp_SOURCES) Add tab.h.
9648 * Most source files: Added a cast to unsigned char in usages of
9649 the ctype is*() functions. Replaced `end of command expected'
9650 calls to msg() with calls to syntax_error().
9652 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
9654 * lexer.c: (hex_val) Removed (was dead code).
9655 (idmatch) Parenthesize function name to avoid macro expansion.
9657 * postscript.c: Comment fixes.
9658 (ps_preopen_driver) Change default font size to 10pt.
9660 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
9662 (parse_format_spec) Change system-file format spec argument type
9663 to int32. Parse the format spec with bitwise operators.
9665 * sfmP.h: (struct sysfile_format) Removed.
9666 (struct sysfile_variable) Changed print, write members from
9667 sysfile_format to int32.
9669 * tokens.h: Esthetic fixes.
9670 [__GNUC__] (macro id_match) New macro to hopefully speed up
9671 identifier matching.
9672 (macros match_id, match_tok, match_int) Implemented in
9673 compiler-independent manner; no longer GNU C only.
9675 * vfm.h: Include time.h.
9677 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
9679 * data-list.c: (dump_fixed_table) Change tab_dim().
9681 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
9683 * error.c: Include command.h.
9685 * frequencies.g: Formatting fixes.
9687 * frequencies.q: Add tab_dim() calls. Make the total cell a
9690 * glob.c: Include command.h.
9692 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
9694 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
9695 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
9696 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
9697 the other elements (is this right?).
9698 (read_variables) Use lowest, highest members.
9699 (parse_format_spec) New arg `vv' for more stringent checking.
9700 (dump_dictionary) Byteswaps nonexplicit data.
9701 (sfm_read_case) Byteswap numeric data.
9703 * som.c: Initialize table_num to 1.
9704 (render_segments) Remember to increment y_index after each table
9707 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
9708 avl_count() on a NULL tree. No title for the second table.
9709 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
9710 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
9711 fix call to display_variables().
9712 (display_variables) Default to 4 columns, not 3. Set up headers.
9713 Column title is Variable, not Name. Fix index column.
9714 Add joint text. Add tab_dim(). Handle value labels properly.
9715 Handle DISPLAY LABELS properly. Draw boxes correctly.
9716 (describe_variable) Value labels don't need titles. Don't clear
9717 nonexistent index column.
9718 (compare_vectors_by_name) New function.
9719 (display_vectors) New function.
9721 * tab.c: (tab_height) Add assertion.
9722 (tab_null) Add debug code.
9723 (evaluate_dimensions) Add debug code.
9725 * var.h: (struct variable) get_proc data is sometimes used
9726 simultaneously with other per-procedure info, therefore it was
9727 removed from the union. All references changed.
9729 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
9731 * ascii.c: (ascii_close_page) Put title on second line of headers
9732 if there is no subtitle.
9734 * command.c: (glob var cur_proc) Move definition here, from
9736 (cmd_remark) Emit blank line before remarks.
9738 * command.h: (glob var cur_proc) Move declaration here, from
9741 * data-list.c: (dump_fixed_table) Fix messages.
9742 (dump_free_table) Call tab_nat_dim().
9744 * descript.q: (dump_z_table) Modify tab_dim() call.
9746 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
9748 (dump_statistics) Don't output header.
9750 * groff-font.c: Minor format fix.
9752 * html.c: Comment fix.
9754 * list.q: (write_varname) Indent after advancing page.
9756 * output.h: Minor reordering.
9758 * postscript.c: Comment fixes. Many places, '\n' was replaced by
9759 a reference to eol[].
9760 (struct ps_driver_ext) New member eol[].
9761 (ps_preopen_driver) Initialize eol[].
9762 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
9763 defaults. Handle headers. Fix test for minimum page length.
9764 (static var option_tab[]) Add `line-ends'.
9765 (ps_option) Handle line-ends to change eol[].
9766 (postopen) Scale prop_em_width and fixed_width properly. Set the
9767 prologue title to outp_title if applicable. Replace the prologue
9768 line ends with eol[]. Call draw_headers() if headers are enabled.
9769 (text_width) New function.
9770 (out_text_plain) New function.
9771 (draw_headers) New function.
9773 * print.c: (dump_table) Call tab_nat_dim().
9775 * som.c: (som_blank_line) Only advance a line if not at the top of
9777 (som_submit) Move several informational table calls here.
9778 Increment subtable_num if SOMF_NO_TITLE not set.
9779 (output_table) Advance a line if SOMF_NO_SPACING not set.
9780 (render_columns, render_segments, render_simple) Handle spacing
9781 between tables. Handle table titles. Remove debug output.
9783 * som.h: (SOMF_*) New enum series.
9784 (struct som_table_class) New member `flags'.
9786 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
9788 (display_variables) Calls tab_nat_dim().
9789 (describe_variable) Remove restriction on number of value labels.
9790 Make value labels separated by thin lines.
9792 * tab.c: (tab_create) Default `flags' to none.
9793 (tab_float) New arg `w'. All references changed.
9794 (tab_nat_dim) New function.
9795 (tab_output_text) No title or spacing.
9796 (tab_flags) New function.
9797 (tabi_flags) New function.
9798 (tabi_title) New function.
9799 (strip_height) Removed.
9800 (tabi_render) Skip title when necessary.
9801 (static var tab_tab_class) Add tabi_flags, tabi_title.
9802 (evaluate_dimensions) Disable display of column, row size.
9803 (sum_columns) Add title height to top header.
9804 (render_strip) Moved within file.
9806 * tab.h: (struct tab_table) New member `flags'.
9808 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
9810 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
9812 * Most source files: Add `const' attribute in all appropriate
9815 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
9816 column to the variables table for use by describe_variable().
9817 (cmd_display) Disable for the present.
9818 (display_documents) Don't wrap documents.
9819 (display_variables) Table has four columns now.
9820 (describe_variable) Table has four columns now. Don't use a
9821 subtable, use joined cells instead.
9823 * tab.c: (tab_create) Don't set `join'.
9824 (tab_realloc) ct array is not made up of a_string's.
9825 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
9826 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
9827 (text_format) New function.
9828 (tab_title) Rewritten, uses text_format().
9829 (tab_text) Rewritten, uses text_format().
9830 (tab_joint_text) New function.
9832 (static var hit) New variable.
9833 (render_strip) New args r1, r2. Implement joined cells that fit
9835 (tabi_render) Increment hit. Pass new args to render_strip().
9836 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
9837 cells. For t_naw and t_nah, ignore joined cells and null cells in
9840 * tab.h: (struct tab_join_rect) Removed.
9841 (struct tab_table) Removed `join'.
9842 (TAB_JOIN_MAIN) Removed.
9843 (struct tab_joined_cell) New struct.
9844 (TAT_NOWRAP) New enum.
9846 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
9848 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
9850 (ascii_postopen_driver) Fix initialization of *_spacing so that
9851 the TAL_0 bit doesn't count.
9853 * data-list.c: (dump_fixed_table) Use natural width for Format
9856 * glob.c: (rerange) Removed.
9857 (get_date) Formatting fixes. Internationalization fix.
9859 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
9862 * postscript.c: (ps_postopen_driver) Replace
9863 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
9865 * som.c: (som_submit) Don't eject page before every table.
9866 (output_table) Fix order of arguments on call to area().
9867 (render_columns) Fix calculation of max_len.
9869 * tab.c: (tabi_cumulate) Minor change to increase elegance.
9870 (render_strip) New function.
9871 (strip_height) New function.
9872 (tabi_render) Rewrite as calls to render_strip().
9874 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
9875 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
9876 with the TAB_* and OUTP_T_* constants.
9878 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
9880 * Makefile.am: Formatting fixes.
9882 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
9885 * data-list.c: (dump_fixed_table) Add tab_dim() call.
9887 * descript.q: (dump_z_table, display) Add tab_dim() calls.
9889 * dump-sysfile.c: (glob var length) Make type off_t.
9890 (usage) Fix arguments.
9893 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
9894 Now right-justification is the default so many references had to
9896 (struct outp_class) Removed line_width, all references changed.
9897 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
9898 (struct outp_driver) Add elements horiz_line_width,
9899 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
9902 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
9904 (postopen) Initialize all the informational members of
9907 * som.c: (som_blank_line) New function, renamed from blank_line(),
9908 all references changed.
9909 (som_submit) Disables drivers whose pages can't be opened.
9910 (render_columns, render_simple, render_segments) Add debug output.
9911 (render_columns) Fix loop range.
9912 (render_simple) Don't try to render the headers, they're taken
9913 care of automatically. Advance cp_y past the table when done.
9914 (render_segments) Fix loop ranges.
9916 * tab.c: Initialize new members of tab_table.
9917 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
9918 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
9919 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
9922 (tab_dim) New function.
9923 (tab_col_width) Removed.
9924 (tab_row_height) Removed.
9925 (tab_output_text) Call tab_dim().
9926 (tabi_driver) Call evaluate_dimensions(), sum_columns().
9927 (tabi_area) Implemented.
9928 (tabi_cumulate) Implemented.
9929 (tabi_render) Partially implemented, but broken.
9930 (var tab_table_class) Made static.
9931 (evaluate_dimensions) New function.
9932 (sum_columns) New function.
9934 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
9935 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
9936 t_scr, t_srr, t_sentinel. Removed: t_nat.
9937 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
9938 max_stack_height, w, h. Removed: ce, re.
9939 (macro blank_line) Removed.
9940 (glob var zero_length) Removed.
9942 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
9944 * Most source files: include some of the new include files broken
9947 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
9950 * aggregate.c: (glob var outfile) Make static.
9952 * command.c: (glob var pgm_state) Move here.
9954 * common.c: (glob vars endian, second_lowest_value, pgmname,
9955 finished, curdate, cur_proc, start_interactive, history_file) Move
9958 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
9960 * file-handle.q: (glob vars files, inline_file) Move here.
9962 * glob.c: Lost lots of glob vars, detailed in individual file
9964 (init_glob) set_printer, set_screen were obsolete, deleted.
9965 set_cprompt has fewer spaces because pspp has fewer letters than
9968 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
9969 (inp_nval) Made static.
9971 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
9972 tokstr_len, toklongstr, tokint) Move here.
9974 * misc.c: Lost several vars and functions.
9976 * set.q: (all the set_* variables) Move here.
9978 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
9979 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
9982 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
9984 * tab.h: (enum series t_*) New enums.
9985 (struct tab_table) Use arena struct tag. New members ce, re.
9987 * tokens.h: Comment fixes.
9989 * var.h: Move lots of enums and variables and functions and
9990 structures to other files. Use and declare a lot more union and
9991 struct tags. Comment fixes.
9993 * vector.c: (glob vars vec, nvec) Move here.
9995 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
9996 init_blanks, last_vfm_invocation) Move here.
9998 * cases.h: New file.
9999 (struct long_vec) Move here.
10000 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
10003 * command.h: New file.
10004 (STATE_* enums) Move here.
10005 (glob var pgm_state) Move here.
10007 * format.c: New file.
10008 (glob var formats) Move here.
10009 (parse_format_specifier_name, fmt_to_string,
10010 check_input_specifier, check_output_specifier,
10011 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
10014 * format.h: New file. Move functions now in format.c here.
10015 (FMT_* enums) Move here.
10016 (struct fmt_desc) Move here.
10017 (FCAT_* enums) Move here.
10018 (struct fmt_spec) Move here.
10019 (glob vars formats, fmt_parse_ignore_error) Move here.
10021 * inpt-pgm.h: New file.
10022 (INP_* enums) Move here, make #defines into enums.
10023 (glob vars inp_init, inp_init_size) Move here.
10025 * sort.h: New file.
10026 (glob vars v_sort, nv_sort) Move here.
10027 (sort_cases, read_sort_output) Move here.
10029 * vector.h: New file.
10030 (struct vector) Move here, add struct tag.
10031 (glob vars vec, nvec) Move here.
10032 (find_vector) Move here.
10035 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
10036 reinit_blanks, init_zero, init_blanks) Move here.
10037 (struct case_stream) Move here.
10038 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
10039 vfm_disk_stream, sort_stream, data_list_source,
10040 input_program_source, file_type_source, get_source, n_lag) Move
10042 (procedure, write_case, lagged_case, compact_case, page_to_disk)
10045 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
10047 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
10048 (LDADD) Add libdcdflib.
10050 * ascii.c: Comment and formatting fixes. Almost every external
10051 function had an assert added, checking driver_open and page_open.
10052 (ascii_init_driver) Broken into ascii_preopen_driver,
10053 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
10054 (ascii_open_page) Sets page_open.
10055 (ascii_close_page) Clears page_open.
10057 * html.c: Comment and formatting fixes. Almost every external
10058 function had an assert added, checking driver_open and page_open.
10059 (html_init_driver) Broken into html_preopen_driver,
10060 html_postopen_driver, html_close_driver. Manages driver_open.
10061 (html_open_page) Sets page_open.
10062 (html_close_page) Clears page_open.
10063 (html_submit) Disabled.
10065 * lexer.c: (parse_string) Remove debugging printf.
10067 * list.q: (determine_layout) Open a page if one is not yet open.
10069 * output.c: Comment fixes.
10070 (add_class) Set the class member of the new list element.
10071 (parse_options) Don't handle device type.
10072 (colon_tokenize) New function.
10073 (configure_driver) New four-field format with a field for device
10074 type. Now initialize driver_open, page_open, next, and prev
10075 fields. Use new colon_tokenize() function. Don't do a memory
10076 copy to replace a driver, it doesn't work; instead delete the old
10077 driver and insert a new one.
10078 (destroy_driver) Don't call som_destroy_driver(). Close the page
10079 if it's open. Find the class in the list of classes and decrement
10080 that reference count. Remove the driver from the global driver
10082 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
10083 references changed. Rewritten. Don't return a driver that's not
10085 (outp_eject_page) All references to som_internal_eject_page()
10086 changed to use this. Sets cp_x to 0 as well as cp_y.
10088 * output.h: (OUTP_I_* enums) Removed.
10089 (struct som_submission_form) Removed.
10090 (struct outp_class) init_driver broken into preopen_driver,
10091 postopen_driver, and close_driver. submit changed to take a
10092 som_table argument.
10094 * postscript.c: Comment and formatting fixes. Almost every
10095 external function had an assert added, checking driver_open and
10097 (ps_init_driver) Broken into ps_preopen_driver,
10098 ps_postopen_driver, ps_close_driver. Manages driver_open.
10099 (ps_open_page) Sets page_open.
10100 (ps_close_page) Clears page_open.
10102 * som.c: New file, base implementation.
10104 * som.h: (struct som_table) Add struct tag.
10105 (enum SOM_COL_ACROSS) Removed.
10106 (SOM_ROWS, SOM_COLUMNS) New enums.
10107 (struct som_table_class) Add member `cumulate'. Remove `segment';
10108 change `render' arguments.
10109 (struct som_point, struct som_rect) Removed.
10110 (som_submit_table) Fixed typo, should have been som_submit.
10112 * sysfile-info: (describe_variable) Don't try to insert a
10113 subtable; just destroy it for now.
10115 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
10116 references to value labels.
10118 * tab.c: (tab_destroy) New function.
10119 (tab_columns) Change argument.
10120 [0] (tab_submit) Remove dead code.
10121 (tab_title) Allocate string from the table's arena.
10122 (tab_output_text) Only free the buffer if we allocated it.
10123 (tab_submit) New function.
10124 (static vars t, d) New static vars.
10125 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
10126 tabi_headers, tabi_cumulate, tabi_render) New functions.
10127 (glob var tab_table_class) New global var.
10129 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
10130 encapsulate the rectangle. All references changed.
10132 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
10134 * All header files updated to use struct tags in addition to
10135 typedefs for all structures. Don't use word `struct' in struct
10138 * Makefile.am: (pspp_SOURCES) Remove html.c.
10139 (INCLUDES) Replace the lib/* includes with a single lib/ include;
10140 all references updated.
10142 * command.c: (parse_cmd) Remove call to som_check_workspace.
10143 (output_line) Update to new som.
10145 * data-in.c: (parse_numeric) A single dot is not an error; it is
10146 the system-missing value.
10148 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
10151 * data-out.c: Added `const' as appropriate to many prototypes.
10152 (convert_E, convert_F, convert_CCx) Take double argument instead
10153 of value * argument.
10154 (convert_format_to_string) Call changed functions appropriately.
10155 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
10156 make a local copy of the value.
10158 * descript.q: Remove custom_variables() prototype now provided by
10160 (custom_variables) Don't increment sbc_variables, the caller does
10162 (dump_z_table, display) Update to new som.
10164 * error.c: (vmsg) Add const to prototype. Remove code to handle
10165 `too many errors' condition.
10166 (check_error_count) New function.
10167 (msg) Add const to prototype.
10169 * filename.c: (open_file) Rewrite for elegance.
10171 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
10172 (dump_full, dump_condensed, dump_statistics) Update for new som.
10174 * list.q: Don't include somP.h. Change all references to
10175 som_driver_ext to refer to the new members of som_driver. Change
10176 som_internal_eject_page() references to outp_eject_page().
10178 * main.c: (parse) Rewrite for elegance. Add call to
10179 check_error_count().
10181 * output.c: (add_class, outp_list_classes, outp_configure_driver)
10182 Rewrite or revise for new outp_driver_class_list structure.
10183 (outp_iterate_enabled_drivers) Fix comparison between disabled
10184 devices and current device type.
10185 (outp_eject_page) New function.
10187 * output.h: Comment fixes.
10188 (struct outp_driver) New members driver_open, page_open, cp_x,
10189 cp_y, font_height, prop_em_width, fixed_width. Deleted members
10191 (struct outp_driver_class_list) New struct.
10192 (outp_class_list) Changed to type outp_driver_class_list; all
10193 references updated.
10195 * print.c: (dump_table, print_trns_proc) Updated for new som.
10197 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
10198 prototypes for custom subcommands.
10199 (dump_subcommand) Always include the `else'.
10200 (dump_parser) Fix comments in output code.
10202 * set.q: Reordered functions.
10204 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
10206 * som.h: Rewritten from scratch.
10208 * str.h: Remove dead code.
10210 * tab.c, tab.h: New files, base implementation.
10212 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
10215 * t-test.q: New code from John Williams
10216 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
10217 Many many new static vars and defines.
10218 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
10219 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
10220 (struct value_list) New struct.
10221 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
10222 t_crt, t_sig, print_t_groups) New functions.
10223 (cmd_t_test) Implemented.
10225 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
10228 * vfm.c: (dump_splits) Update to new som.
10230 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
10232 * Makefile.am: (fiasco_SOURCES) Add html.c.
10234 * aggregate.c: Base source.
10236 * ascii.c: (postopen, preclose) Reformat.
10238 * data-out.c, expr-evl.c: Comment fixes.
10240 * filename.c: (open_file) When opening a file for writing, use
10241 line buffering instead of full buffering for better interactive
10242 performance. Suggested by Valerio Aimale
10243 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
10244 names `stdin', `stdout', `stderr'.
10246 * groff-font.c: Comment fixes.
10248 * html.c: New file; base version.
10250 * list.q: (write_all_headers, clean_up, determine_layout,
10251 list_cases) Ignore `special' devices for now. Needs to be fixed
10254 * output.c: (outp_init) Add html driver to list; reverse list
10257 * output.h: (struct outp_class_struct) New members `special',
10258 `submit'; comment fixes. All references changed.
10260 * postscript.c: (ps_init_driver) Make defaults for text_opt,
10261 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
10263 (postopen) Comment fix.
10264 (preclose) Comment fixes, formatting fixes. Change x->file.file
10265 references to more proper f->file.
10267 * som-high.c: (som_submit_table) Special classes use their own
10270 * som.h: Comment fixes.
10272 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
10275 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
10277 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
10279 * aggregate.c: Still working on this.
10281 * command.c: (cmd_table[]) Add AGGREGATE back in.
10282 (split_words) Make '-' a legal word separator as well as ' '.
10284 * main.c: Comment fixes.
10286 * q2c.c: (dump_parser) Don't require the procedure's full name to
10287 be present, in the generated source.
10289 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
10290 multiply specified and let it be default; let MISSING, CRITERIA,
10291 FORMAT be multiply specified.
10292 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
10293 (custom_groups) Fix defaults.
10294 (custom_pairs) Check whether this is a PAIRS subcommand before
10295 attempting to parse. Better garbage collection. Proper storage
10297 [DEBUGGING] (debug_print) New function.
10299 * temporary.c: Comment fixes.
10300 (copy_variable) Don't copy variable name and index.
10301 (save_dictionary) Copy variable name and index by hand.
10303 * vars-atr.c: Comment fixes.
10304 (create_variable) New dictionary argument. All references
10306 (common_init_stuff) New dictionary argument. All references
10308 (init_variable) New dictionary argument. All references changed.
10309 (dup_variable) New function.
10311 * vars-prs.c: (parse_variables) If there are any errors, we always
10312 return 0. Previously, it was possible for some types of errors to
10315 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
10317 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
10320 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
10322 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
10325 * q2c.c: Comment fixes.
10326 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
10328 * t-test.q: (cmd_list) Rename cmd_t_test.
10330 * temporary.c: (new_dictionary) Don't declare as static.
10332 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
10334 * aggregate.c: Changes, still not finished.
10336 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
10338 * q2c.c: Comment fixes. Now its output is internationalized.
10339 (get_token) Fix parsing of escapes within literal strings.
10340 (main) Fix bad #line directives in output.
10342 * t-test.q: Base implementation.
10344 * temporary.c: (new_dictionary) New function.
10345 (restore_dictionary) [__CHECKER__] Change fill character to *
10348 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
10350 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
10352 * aggregate.c: Changes, still not finished.
10354 * descript.q, list.q: Comment fixes.
10356 * q2c.c: Almost completely rewritten.
10358 * t-test.q: New file, not complete.
10360 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
10362 * aggregate.c: Changes, still not finished.
10364 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
10367 * temporary.c: (cancel_temporary) New function.
10369 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
10370 of doing it by hand.
10372 * vfm.c: (close_active_file) After restoring a TEMPORARY
10373 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
10374 cancel_temporary().
10375 (SPLIT_FILE_procfunc) Comment fix.
10377 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
10379 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
10381 * aggregate.c: New file, not finished yet.
10383 * command.c: (cmd_table) Add AGGREGATE.
10385 * common.h: (pgm_state) Move declaration to var.h.
10387 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
10389 (parse_string) Message fix.
10391 * recode.c: Comment fix.
10393 * sfm-read.c: (read_variables) Code esthetic fixes.
10394 (write_header) Default date is `Jan', not `JAN'.
10396 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
10398 * sort.c: (cmd_sort_cases) Farm the work out to new function
10399 parse_sort_variables().
10400 (parse_sort_variables) New function.
10401 (sort_cases) New function. Cancels temporary transformations,
10402 which sorting didn't do previously.
10403 (cmd_sort_cases) Better garbage collection on error. Uses
10404 do_external_sort().
10405 (write_initial_runs, merge_once) Improved code esthetics.
10406 (sort_stream_read) Reduced to one call to read_output_cases().
10407 (read_output_cases) New function.
10409 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
10410 variable labels to 120 characters.
10412 * var.h: Comment fixes.
10413 (glob var pgm_state) From common.h.
10415 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
10417 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
10418 options. Set *names to NULL on error.
10420 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
10422 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
10424 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
10425 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
10427 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
10429 * vfm.c: (page_to_disk) Added missing local variables.
10431 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
10433 * get.c: Comment fix.
10435 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
10436 source is anything other than a disk stream, not just if it's in a
10437 memory stream. Call page_to_disk() before external sort.
10438 (allocate_cases) Message fix.
10440 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
10442 (page_to_disk) New function.
10444 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
10446 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
10448 * common.h: (macro strerror) Remove. From Alexandre Oliva
10449 <oliva@dcc.unicamp.br>.
10451 * get.c: (dict_delete_run) The number of variables to delete is
10452 not necessarily the number of variables that need to be shifted
10454 (trim_dictionary) Don't set *options to 0. Fix bug that caused
10455 too many variables to be deleted.
10457 * postscript.c: Comment fix.
10459 * q2c.c: Include strerror.c. From Alexandre Oliva
10460 <oliva@dcc.unicamp.br>.
10462 * set.q: #undef ON and OFF. From Alexandre Oliva
10463 <oliva@dcc.unicamp.br>.
10465 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
10466 early, otherwise errors cause a bad free().
10468 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
10469 Oliva <oliva@dcc.unicamp.br>.
10471 * temporary.c: (save_dictionary) Don't allocate memory if
10474 * vfm.c: (memory_stream_write) Message fix.
10476 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
10478 * command.c: (static var cmd_table[]) Define REPEATING DATA
10481 * common.h: Added support for broken systems that are missing
10482 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
10484 * Many source files: Replace syntax error messages via msg() with
10485 call to syntax_error().
10487 * data-list.c: (dump_fixed_table) Add support for dumping table
10488 for REPEATING DATA as well as DATA LIST FIXED.
10489 (cmd_repeating_data) Allows and requires `/' between subcommands.
10490 Does proper thing with allowing rpd.starts_end to stay 0. Allows
10491 CONTINUED specifications to be omitted. Forces CONTINUED to be
10492 specified if ID is. Calculates starts_end, cont_end from logical
10493 record length as reported by fhp. Calls dump_fixed_table() if
10494 requested. Fixed length of record copied by memcpy.
10495 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
10497 (realize_value) Returns sensible value for out-of-range variable
10499 (rpd_parse_record) New argument `ofs'. Fixed confusion between
10500 length of occurrences and length of line. Added warning for
10501 fields that exceed the line length. Fixed infinite loop.
10502 (read_one_set_of_repetitions) Numerous minor changes for more
10503 complete SPSS compliance. Message fixes.
10505 * dfm.c: (dfm_close) If the file being closed is the inline file,
10506 read all the remaining data before closing it.
10507 (dfm_get_record) Don't close the file on lossage, as either it
10508 has been closed already or it doesn't belong to us.
10510 * error.c: (puts_stdout) New function.
10511 (vmsg) Use puts_stdout instead of puts.
10513 * file-handle.q: (fh_record_width) New function.
10515 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
10517 (clear_case) Ditto.
10518 (input_program_source_read) Made an old kluge an approved method.
10520 * lexer.c: (syntax_error) New function.
10522 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
10525 * output.c: (oupt_get_paper_size) Message fix.
10527 * q2c.c: Numerous fixes to formatting of generated code made to
10528 conform to GNU coding standards. Uses syntax_error() in generated
10529 code. Other miscellaneous generated message fixes. Added support
10530 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
10531 RAND_MAX, and/or strerror().
10533 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
10535 * data-in.c: Comment fixes.
10537 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
10538 (find_variable_input_spec) New function.
10539 (cmd_repeating_data) Initializes id_spec.
10540 (rpd_parse_record) Implemented.
10541 (read_one_set_of_repetitions) Returns -3 by default in order to
10542 kluge out some potential bugs.
10544 * data-out.c: Comment fixes.
10546 * file-type.c: (internal_cmd_record_type) Message fix.
10548 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
10549 for handling -3 return value.
10551 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
10553 * data-list.c: Comment fixes.
10554 (struct dls_var_spec) Reordered members.
10555 (read_from_data_list_fixed) Restructured.
10556 (struct repeating_data_trns) Reordered members. Renamed `starts'
10557 as `starts_beg', `ends' as `starts_end'.
10558 (cmd_repeating_data) Calculates length of repeated data if
10559 necessary and possible.
10560 (parse_num_or_var) Don't allow string variables.
10561 (realize_value) New function.
10562 (rpd_msg) New function.
10563 (rpd_parse_record) New function. Currently stubbed out.
10564 (read_one_set_of_repetitions) Implemented.
10566 * inpt-pgm.c: (input_program_source_read) Comment fix.
10568 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
10570 * command.c: (cmd_end_repeat_p) Removed.
10571 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
10572 (parse_cmd_name) Removed.
10574 * data-list.c: Comment fixes.
10575 (data_list_pgm) Removed `eof' member.
10576 (static var first) New var.
10577 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
10578 FILE TYPE file inside FILE TYPE structures.
10579 (append_var_spec) Appends to *first, not dls.spec.
10580 (parse_fixed) Message fixes.
10581 (struct rpd_num_or_var) New.
10582 (struct repeating_data_trns) New.
10583 (static var rpd) New.
10584 (cmd_repeating_data) New function.
10585 (parse_num_or_var) New function.
10586 (parse_repeating_data) New function.
10587 (read_one_set_of_repetitions) New function.
10589 * file-type.c: (cmd_file_type) Message fixes. Always
10590 default_handle to FILE TYPE file handle.
10591 (internal_cmd_record_type) Message fixes.
10593 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
10595 * repeat.c: Comment fix. Disable debugging.
10597 * temporary.c: (restore_dictionary) Sets splits to NULL and
10598 n_splits to 0 before destroying the variables because now doing
10599 this tries to remove split variables.
10601 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
10602 destroying the dictionary.
10603 (clear_variable) Removes a variable from splits after destroying
10606 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
10608 * cmdline.c: (set_compat) Removed.
10609 (pick_compat) Removed.
10610 (parse_command_line) Removed -c option.
10611 (pre_syntax_message) Removed -c option.
10612 (usage) Remove compatibility code.
10614 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
10615 (glob var compat) Removed.
10617 * compute.c: (type_check) Fixed messages about type mismatches.
10619 * data-list.c: (cmd_data_list) Removed compatibility code.
10620 (fixed_parse_compatible) Calls convert_negative_to_dash().
10621 Fixed bug where it only set the variable in fx.spec if it created
10622 the variable itself.
10623 (dump_fmt_list) Spelling fix.
10624 (cut_field) Removed compatibility code.
10626 * dfm.c: (cmd_begin_data) Don't require a command terminator on
10627 BEGIN DATA command.
10629 * expr-evl.c: (evaluate_expression) Implement LAG.
10631 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
10632 (parse_neg) Calls convert_negative_to_dash().
10633 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
10636 * expr.h: (struct expression_struct) Removed member max_lag.
10638 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
10639 (internal_cmd_record_type) Removed special handling to produce
10640 negative numbers from dash tokens.
10642 * getline.c: (static var DO_REPEAT_level) New var.
10643 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
10644 (handle_line_buffer) Copies the line into getl_buf; doesn't call
10645 copy_with_DO_REPEAT_substitutions().
10646 (getl_read_line) Maintains value of getl_mode. Calls
10647 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
10649 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
10651 * getline.h: (getl_mode) New glob var.
10653 * glob.c: Comment fixes.
10654 (init_glob) Restructured. Sets set_seed.
10655 (init_compat_dependent) Removed. All references removed.
10656 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
10657 (__htonl, __htons) Removed. (What were these for?)
10659 * lexer.c: (static var tbl) Dash set to class CNUM.
10660 (make_hexit) New function from data-out.c.
10661 (get_token_representation) Rewritten.
10662 (convert_negative_to_dash) New function.
10663 (lex_init_compat_dependent) Removed.
10664 (yylex) A dash is parsed as part of a number if it is followed by
10665 a digit. The ASCII representation of a number is copied to
10666 tokstr. String parsing farmed out to parse_string(). Comment
10668 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
10670 (preprocess_line) Line processing depends on interactive/batch
10671 mode, not on compatibility mode. Removed PC+ compatibility code.
10673 * loop.c: (loop_3_trns_proc) Comment fix.
10675 * main.c: Remove dead code.
10676 (main) Remove call to init_compat_dependent().
10678 * misc.c: (convert_fmt_ItoO) Make E format conversion more
10681 * print.c: (parse_string_argument) Calls
10682 convert_negative_to_dash().
10683 (fixed_parse_compatible) Calls convert_negative_to_dash().
10685 * repeat.c: (RPT_* defines) Removed.
10686 (struct rpt_numeric) Removed.
10687 (struct repeat_entry) New member type, changed `replacement' from
10689 (clean_up) Deallocation adapted to new repeat_entry.
10690 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
10691 usage. Creates vars for `type' of 1.
10692 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
10693 (store_numeric) Rewritten, new interface.
10694 (parse_numbers) Rewritten.
10695 (parse_strings) Rewritten.
10696 (find_DO_REPEAT_substitution) New function.
10697 (perform_DO_REPEAT_substitutions) New function.
10698 (copy_with_DO_REPEAT_substitutions) Removed.
10699 (debug_print) Rewritten.
10701 * set.q: Comment fix.
10702 (custom_results) Removed compatibility code.
10703 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
10704 compatibility code.
10706 * sysfile-info.c: (cmd_display) Removed compatibility code.
10708 * tokens.h: Comment fixes.
10709 (token types enum) Removed `toktype' typedef name for this int
10710 type. Removed SUBST. Restructured.
10712 * vars-atr.c: (discard_variables) Sets n_lag to 0.
10714 * vars-prs.c: Comment fix.
10716 * vfm.c: Comment fixes.
10717 (glob var n_lag) New var.
10718 (static vars lag_count, lag_head, lag_queue) New vars.
10719 (procedure) Removed argument nlag.
10720 (setup_lag) New function.
10721 (close_active_file) Discards lagging state.
10722 (lag_case) New function.
10723 (lagged_case) New function.
10724 (write_case) Lags a case if lagging.
10726 * weight.c: (cmd_weight) Removed compatibility code.
10728 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
10730 * getline.h: (struct getl_script) New members loop_index, macros.
10732 * getline.c: (getl_add_file) Sets first_line field to NULL.
10733 (getl_add_DO_REPEAT_file) New function.
10734 (handle_line_buffer) When the current line's length is negative,
10735 set the filename and line number. Increment line number after
10736 reading line. Pass the line to
10737 copy_with_DO_REPEAT_substitutions() for processing.
10738 (getl_close_file) Free DO REPEAT lines before freeing the
10739 filename, and just set the filename to NULL when doing this,
10740 because otherwise the filename gets freed twice.
10742 * glob.c: (glob var queuing) Removed. All references removed.
10744 * lexer.c: Comment fixes.
10745 (get_token_representation) New function.
10747 * repeat.c: Comment fixes.
10748 (struct repeat_entry) Replaced type and v union members with a
10750 (append_record) New function.
10751 (internal_cmd_do_repeat) Started reforming it for the new
10752 repeat_entry struct. Properly records filename changes in the
10753 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
10754 strncasecmp() result usage. Uses append_record() to simplify.
10755 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
10756 to add in the file.
10758 (copy_with_DO_REPEAT_substitutions) Started coding.
10760 [DEBUGGING] (debug_print_lines) New function.
10762 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
10764 * tokens.h: (macro is_id1, is_idn) New macros.
10766 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
10768 * cmdline.c: (static var pre_syntax_message) Changed `win'
10769 compatibility mode to `wnd'.
10771 * data-list.c: (fixed_parse_spss) Renamed
10772 fixed_parse_compatible().
10774 * glob.c: (init_glob) Excise unused code for
10775 program_invocation_short_name.
10777 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
10780 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
10782 * set.q: `win' compatibility renamed `wnd'.
10784 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
10786 * filename.c: [__WIN32__] Change the included Windows header files
10788 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
10789 second character is absolute.
10790 (dirname) Fix logic error. Don't printf() the results.
10791 (prepend_dir) Don't printf() the results.
10793 * getline.c: (handle_line_buffer) New function.
10794 (getl_read_line) Reads line with handle_line_buffer() when
10796 (getl_close_file) Discard line buffer data.
10798 * getline.h: Comment fixes.
10799 (struct getl_line_list) New struct.
10800 (getl_script_struct) Added line buffer members. These are hooks
10801 for use by DO REPEAT to allow it to insert virtual source code
10804 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
10805 Override Borland C++ stupidity that claims Windows has a console
10806 window size of 0x3.
10808 * repeat.c: This is in the process of being restructured from
10809 using a token-buffering approach to the DO REPEAT facility to
10810 using the more flexible approach of a line-buffering approach in
10811 conjunction with the getline module. Comment fixes.
10812 (struct tok_struct) Removed.
10813 (static vars queue_index, queue_head, queue) Removed.
10814 (static vars line_buf_head, line_buf_tail) New vars.
10815 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
10817 (pull_queue, destroy_queue) Removed.
10818 [DEBUGGING] (debug_print_tokens) Removed.
10820 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
10822 * file-handle.q: (prepend_current_directory) New function.
10823 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
10824 current directory before normalizing filename.
10826 * filename.c: (gnu_getcwd) New function.
10827 (absolute_filename_p) New function.
10828 (search_path) New argument, PREPEND. All references changed to
10829 pass NULL except those explicitly mentioned. Uses
10830 absolute_filename_p(). Prepends PREPEND before trying the
10832 (dirname, prepend_dir) New functions.
10834 * getline.c: (getl_get_current_directory) New function.
10835 (getl_include) Passes getl_get_current_directory() as PREPEND arg
10838 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
10840 * In several source files, the term `script' was replaced with
10841 `syntax file' inside error messages. Usage of the term `script'
10842 in the sense of a syntax file is now deprecated.
10844 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
10847 * dump-sysfile.c: (usage) Update message.
10849 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
10851 * getline.h: (glob var getl_include_path) Declare extern.
10853 * list.q: Define EXTERN as extern before #including somP.h.
10855 * var.h: Remove declaration of `disptype' variable.
10857 * vfm.c: (close_active_file) After switching the data sink to a
10858 data source, set vfm_sink to NULL, because it doesn't exist any
10861 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
10863 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
10864 _matherrl() to ignore all math errors.
10866 * sfm-read.c: (read_value_labels) When reading the labels from
10867 disk, read the little parts separately instead of as a struct;
10868 this avoids alignment problems.
10870 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
10871 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
10872 (write_header) Allocates and initializes elem_type.
10873 (sfm_write_case) Uses elem_type to determine how to handle each
10875 (sfm_close) Frees elem_type.
10877 * sfmP.h: Comment fix.
10878 [__BORLANDC__] Uses #pragma -a to adjust structure member
10881 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
10883 * Makefile.am: (fiasco_SOURCES) Remove display.c.
10885 * common.c: Fix typo.
10887 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
10888 sense of the condition.
10890 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
10891 line-continuation backslash.
10893 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
10895 * frequencies.q: (custom_grouped, add_percentile) Don't use a
10896 non-constant expression as an argument to sizeof.
10898 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
10899 undefine gettext macro because that's a conio function.
10901 * hash.h: (hsh_prime_tab declaration) Remove.
10903 * list.q: (write_fallback_headers) Move `leader' allocation out of
10904 main loop. Change to local_alloc() allocation.
10906 * output.h: Formatting fixes. Put __attribute__ in right place on
10907 function prototypes.
10909 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
10910 incorrect `SECOND_LOWEST_VALUE' references to proper
10911 `second_lowest_value'.
10913 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
10914 value. This way 2 out of 3 of the som files define the vars
10915 extern, the correct way, that actually works under BC++.
10916 (som_set_float) Don't use nonconstant initializers for a struct.
10918 * som-high.c: Add the standard alloca() header.
10919 (replicate_table) Add prototype.
10921 Merged DISPLAY routine.
10922 * sysfile-info.c: (AS_*) New enum series.
10923 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
10925 (cmd_display, display_macros, display_documents,
10926 display_variables) Stolen from defunct display.c.
10927 (describe_variable) New function.
10929 * temporary.c: [0] (display_tree) New debug function.
10930 (copy_variable) Performs shallow copy of value labels instead of
10931 deep copy; i.e., just copys the AVL tree and increments the
10934 * val-labs.c: Comment fixes.
10935 (do_value_labels) Optionally skip leading forward slash.
10936 (get_label) Creates only a single value label instead of many
10937 copies of one, and sets the reference count.
10939 * display.c: Removed.
10941 * dump-sysfile.c: New file, not yet complete.
10943 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
10945 For lots of source files I added more verbose_msg's. These aren't
10946 listed below as they have tested as being benign. In some cases
10947 these replaced debug_printf() calls.
10949 * output.c: (outp_read_devices) Message fix.
10951 * postscript.c: (output_encodings) Message fix. Reports errors on
10953 (postopen) Message fix.
10955 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
10957 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
10959 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
10962 * main.c: Remove <malloc.h> #include.
10964 * mis-val.c: (parse_numeric) Set .f member for each missing[]
10965 instead of trying to just set the missing[] itself, which is a
10966 gcc-specific idiom.
10968 * sfm-read.c: (read_variables) Same.
10970 * str.h: Add memmem() prototype.
10972 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
10974 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
10976 * Makefile.am: (q2c) Don't include any libraries in the link.
10978 * dfm.c: (force_line_buffer_extension) New macro.
10979 (count_tabs) New function.
10980 (tabs_To_spaces) New function.
10981 (read_record) Calls tabs_to_spaces() on the line being processed.
10983 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
10984 have to be compiled twice (once for CC, once for LOCAL_CC).
10986 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
10988 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
10989 (LDADD) Add @INTLLIBS@.
10990 (q2c) Add LIBS, @INTLLIBS@ to link step.
10992 * inpt-pgm.c: Turn off debugging.
10994 * postscript.c: (postopen) Format fix. local_free() blocks
10995 returned by local_alloc(); don't free() them.
10997 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
10999 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
11002 * data-list.c: (read_from_data_list_fixed) Pass proper value for
11003 LEN arg, not simply the full string length.
11005 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
11006 directories before generic temp file directories.
11008 * vfm.c: Disable debugging.
11010 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
11012 * get.c: Comment fix.
11013 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
11015 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
11017 * expr-prs.c: (debug_print_postfix) Conditionally included on
11018 GLOBAL_DEBUGGING. Removed out_header() reference.
11020 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
11022 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
11024 * ascii.c: Removed obsolete ascii_close_page() prototype.
11026 * command.c: (output_line) Comment fix.
11028 * data-in.c: Formatting fix.
11029 (parse_string_as_format) Now the `fc' argument is used only for
11030 the purpose of error messages; it is not an index into the string
11031 passed. All references changed.
11033 * data-list.c: Comment fix.
11034 (cut_field) Comment fix. Now returns the column number of the
11035 position of the field cut out on success.
11036 (parse_field) Added `column' argument. Puts the column numbers in
11038 (read_from_data_list_free, read_from_data_list_list) Record the
11039 column number returned by cut_field(), pass it to parse_field().
11041 * dfm.c: Comment fix.
11043 * do-ifP.h: Comment fix.
11045 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
11046 the SYSMIS function.
11048 * expr.h, exprP.h: Comment fix.
11050 * glob.c: (init_glob) Only calls setlocale() and family if
11053 * hash.h: Comment fix.
11055 * include.c: Comment fix.
11057 * output.c: Comment fix.
11059 * postscript.c: (ps_line_intersection) Simplified assertion.
11061 * repeat.c: Comment fix.
11063 * vars-atr.c: Comment fix.
11065 * vars-prs.c: Comment fix.
11067 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
11068 behavior with usage of postincrement.
11069 (memory_stream_read) Discards cases as it goes.
11071 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
11073 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
11076 * Most source files: Includes debug-print.h, related comment
11079 * cases.c: (alloc_val) Removed complex allocation code. Merely
11080 increments default_dict.nval and returns the former value.
11081 (envector, devector) Removed references to lv member of struct
11084 * common.h: (macro VME) Replaced complex definition with simple
11087 * data-list.c: (cmd_data_list) Sets vfm_source instead of
11088 read_active_file and cancel_input_pgm.
11089 (read_from_data_list, cancel_data_list) Removed.
11090 (data_list_source_read, data_list_source_destroy_source) New
11092 (glob var data_list_source) New var.
11094 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
11095 (cmd_begin_data) Improved criteria for an input program accessing
11096 the inline file. Still not perfect.
11098 * do-if.c: (do_if_trns_proc) Simplified debug output.
11100 * expr-prs.c: Comment fixes.
11101 [DEBUGGING] (debug_print_postfix) Simplified debug output.
11103 * file-handle.q: (fh_close_handle) Simplified debug output.
11105 * file-type.c: Comment fixes.
11106 (cmd_file_type) Sets vfm_source instead of read_active_file and
11108 (cmd_end_file_type) On failure, discards variables in place of
11109 just canceling the input program.
11110 (read_from_file_type) Renamed file_type_source_read.
11111 (cancel_file_type) Renamed file_type_source_destroy_source.
11112 (glob var file_type_source) New var.
11114 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
11115 (cmd_get) Initializes options to GTSV_NONE before passing to
11116 trim_dictionary(). Removed `lv' reference. Sets vfm_source
11117 instead of read_active_file and cancel_input_pgm.
11118 (cmd_save_internal) Initializes options before passing to
11119 trim_dictionary(). Local var `nval' removed.
11120 (dict_delete_run) Comment fixes.
11121 (trim_dictionary) Comment fixes. Disallows scratch variables if
11122 GTSV_OPT_SAVE set in options.
11123 (read_from_get) Renamed get_source_read.
11124 (cancel_get) Renamed get_source_destroy_source.
11125 (glob var get_source) New var.
11127 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
11128 read_active_file and cancel_input_pgm.
11129 (read_from_input_program) Renamed input_program_source_read.
11130 Simplified debug output.
11131 (cancel_input_program) Renamed
11132 input_program_source_destroy_source.
11133 (glob var input_program_source) New var.
11135 * loop.c: (loop_1_trns_proc) Simplified debug output.
11137 * main.c: (dump_token) Made eof output more explicit.
11139 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
11142 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
11143 code for always-memory or always-disk cases. malloc's case-list
11144 based on vfm_source_info.ncases. Explicit support for
11145 memory_stream via memory_source_cases.
11146 (do_external_sort) Sets vfm_source instead of read_active_file and
11148 (allocate_file_handles) The temporary directory permissions are
11149 set to 0700 instead of 0777.
11150 (allocate_cases) Formatting fixes. Simplified debug output.
11151 (output_record) Compacts the case if necessary before writing it
11153 (close_handle, open_handle_w) Simplified debug output.
11154 (write_initial_runs) Destroys vfm_sink, then sets it to
11155 sort_stream. Writes records to memory based on
11156 vfm_sink_info.case_size.
11157 (write_to_sort_cases) Renamed sort_stream_write().
11158 (merge) Simplified error handling. Simplified debug output.
11160 (read_from_external_sort) Renamed sort_stream_read().
11161 Reads records based on vfm_source_info.case_size.
11162 (sort_stream_write) Writes records to memory based on
11163 vfm_sink_info.case_size.
11164 (sort_stream_mode) New function.
11165 (glob var sort_stream) New variable.
11167 * temporary.c: (cmd_temporary) Simplified debug output.
11168 (copy_variable) Removed references to `lv'.
11170 * title.c: (get_title) Simplified debug output.
11172 * var.h: Comment fixes.
11173 (struct get_proc) Removed member `lv'.
11174 (struct variable) Removed member `lv'. Comment fixes.
11175 (glob vars read_active_file, write_active_file, cancel_input_pgm)
11177 (struct case_stream) New.
11179 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
11180 read_active_file references to use vfm_source.
11181 (init_variable, replace_variable) Removed references to `lv'.
11183 * vfm.c: Comment fixes.
11184 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
11186 (static var queue, qh, qt, n_lag) Removed. All references
11188 (glob var compaction_necessary, compaction_nval, compaction_case,
11189 paging) New variables.
11190 (record_case) Removed.
11191 (procedure) Comment fixes. Calls vfm_source->read() instead of
11192 read_active_file().
11194 (prepare_for_writing, arrange_compaction, make_temp_case,
11195 vector_initialization, setup_filter) New function.
11196 (open_active_file) Most of the code moved into the abovementioned
11197 new functions. Now sets temp_dict to &default_dict if there is no
11198 temporary dictionary, for convenience. New debug output.
11199 (close_active_file) Deals with changing the sink to the source.
11200 Calls finish_compaction(). Frees compaction_case. Mostly
11202 (glob vars disk_source_file, disk_sink_file) New vars.
11203 (destroy_active_file, read_from_memory) Removed.
11204 (disk_stream_init, disk_stream_read, disk_stream_write,
11205 disk_stream_mode, disk_stream_destroy_source,
11206 disk_stream_destroy_sink) New functions.
11207 (glob var vfm_disk_stream) New var.
11208 (glob vars memory_source_cases, memory_sink_cases,
11209 memory_sink_iter, memory_sink_max_cases) New vars.
11210 (memory_stream_init, memory_stream_read, memory_stream_write,
11211 memory_stream_mode, memory_stream_destroy_source,
11212 memory_stream_destroy_sink) New functions.
11213 (glob var vfm_memory_stream) New var.
11214 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
11215 named `more_cases'. Simplified debug output. Otherwise mostly
11217 (record_case) Moved into the stream drivers. Removed.
11218 (transform) Removed (was dead code).
11219 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
11220 common case that the splits don't change, we don't need to copy
11221 the case into prev_case again--pointless.
11222 (compact_case) New function.
11223 (finish_compaction) New function.
11225 * vfmP.h: Comment fixes.
11226 (DEV_* enum series) Removed.
11227 (struct storage) Renamed `stream_info'. Removed variant record.
11228 Removed `device' member.
11230 * debug-print.h: New file.
11232 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
11234 * autorecode.c: Turned off debugging.
11236 * data-list.c: (destroy_dls) Closes the associated file handle.
11238 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
11239 parse_variables() options.
11241 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
11243 * display.c: (display_variables) Really fixed null cell bug.
11245 * file-handle.q: (fh_close_handle) Changed debugging message.
11247 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
11248 parse_variables() options.
11250 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
11251 (cmd_list) Fails if no variables specified.
11252 (determine_layout) Writes blank lines manually.
11254 * loop.c: (loop_1_trns_proc) Made debugging code only print
11255 messages if debugging.
11257 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
11258 parse_variables() arguments.
11259 (main) Parses optional parenthesized options to varlist
11260 subcommands into sbc->message.
11262 * sfm-read.c: Format fix.
11264 * var.h: (FV_*) New enum series.
11265 (PV_*) New enum PV_NO_SCRATCH.
11267 * vars-prs.c: (find_var) Removed.
11268 (fill_all_vars) Takes FV_* enum instead of boolean third
11269 argument. Rewritten to deal with scratch as well as system
11271 (parse_variables) Error message on scratch variable if
11274 * vfm.c: (static var virt_begin_func) New var.
11275 (procedure) Sets up virt_begin_func.
11276 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
11277 after dump_splits(). For succeeding groups changes, calls
11278 virt_begin_func() instead of begin_func().
11280 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
11282 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
11285 * dfm.c: Added some debugging messages, disabled by default.
11286 (open_file_r) Fixed error message.
11287 (read_record) On eof on inline_file, instead of calling
11288 fh_close_handle(), simply jump to eof label like a normal file.
11291 * display.c: Thin lines between rows for certain kinds of
11292 listing. Fixed `null cell' bug.
11294 * error.c: (failure) Flush stdout, stderr before failing.
11296 * file-handle.q: (fh_close_handle) Added debugging message.
11298 * frequencies.q: (dump_full) Bottom line extends across entire
11299 table width. Changed title formatting.
11300 (dump_condensed) Changed title formatting.
11301 (dump_statistics) Fixed title formatting.
11303 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
11304 Sets default value of set_format.
11306 * list.q: (cmd_list) Calls blank_line() before determine_layout().
11307 Passes write_all_headers() to procedure() as pre-group func.
11308 (write_all_headers) New function.
11309 (determine_layout) Removed calls to write_header().
11310 Calls blank_line() before and after write_fallback_headers().
11312 * recode.c: (recode_trns_free) Only attempts to free head->map if
11315 * sfm-read.c: (read_variables) Allows `#' at beginning of system
11316 file variable names but gives a warning. Sets `left' based on
11317 first character being/not being `#'. On lossage frees dict->var.
11319 * som-high.c: (som_draw_title) Simplified title formatting.
11321 * vfm.c: (dump_splits) Fixed and changed splits formatting.
11323 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
11325 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
11326 beginning. Frees v_src, v_dest on successful exit. Frees
11327 h_trans[*], h_trans on lossage.
11328 (recode) Frees h_trans[*], h_trans.
11330 * dfm.c: (dfm_close) Formatting change.
11331 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
11332 longer allocates its own in inline_file.
11333 (open_file_r) Passes the local dfm_fhuser_ext to
11334 open_inline_file().
11335 (open_file_w) Message fix.
11336 (read_record) Buffer reallocation strategy changed. Frees
11337 ext->line even in inline_file to prevent leaks.
11338 (dfm_put_record) Fixed bug where `ext' was cached before the file
11339 was opened and thus it would be NULL when the file really was
11341 (cmd_begin_data) Sets up inline_file basics itself, then calls
11342 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
11344 * list.q: (write_line) Formatting fix.
11345 (clean_up) Minor strategy change. Sets proportional font after
11347 (determine_layout) Sets fixed font before writing regular headers,
11348 or after writing fallback headers.
11350 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
11351 and KEEP vars after using them.
11353 * postscript.c: (ps_init_driver) Frees x->family.
11354 (postopen) When loading fonts, free the temporary font name buffer
11356 (ps_text_set_font_by_position) Free temporary font name buffer
11358 (text) Fixed code that calculated `lig' so that `lig' always gets
11359 initialized. Formatting fix.
11361 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
11363 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
11364 cells, not xmalloc(), so that the cells will get destroyed
11367 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
11370 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
11372 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
11375 * dfm.c: Comment fix.
11377 * list.q: Comment fixes. Include somP.h. Removed static vars
11378 table, n_columns, n_rows, part. New struct list_ext. New static
11380 (n_lines_remaining, n_chars_width, write_line) New functions.
11381 (cmd_list, list_cases) Rewritten.
11382 (begin_row, end_row, flush_table) Removed.
11383 (write_header, clean_up, write_varname, write_fallback_headers,
11384 determine_layout) New functions.
11386 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
11388 * output.h: Comment fix.
11390 * postscript.c: Comment fix.
11391 (struct ps_driver_ext) Removed prop_size, fixed_size members;
11392 added font_size. All references changed.
11393 (ps_init_driver) Initializes font_size. Simplified space checking
11395 (static var option_tab[]) Removed prop-size, fixed-size; added
11397 (ps_option) Handles font_size.
11399 * som-high.c: Moved prototypes into somP.h.
11400 (som_init_driver) New function.
11401 (som_submit_table) Moved some code into new function
11403 (build_target) Moved some code into new function
11404 som_internal_eject_page().
11405 (som_eject_page) Uses som_internal_eject_page().
11406 (som_internal_eject_page) New function.
11408 * som-low.c: Moved prototypes into somP.h.
11410 * som.h: Formatting fixes.
11412 * somP.h: (struct som_driver_ext) Removed em_width;
11413 added prop_em_width, fixed_width.
11415 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
11417 * Makefile.am: Added `localedir' definition. Added
11418 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
11420 * ascii.c: (macro draw_line) Fixed capitalization.
11422 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
11423 compute.c, count.c, data-in.c, data-list.c, data-out.c,
11424 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
11425 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
11426 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
11427 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
11428 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
11429 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
11430 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
11431 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
11432 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
11433 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
11434 for internationlization.
11436 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
11438 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
11440 * do-if.c, sort.c, val-labs.c: Comment fixes.
11442 * glob.c: (init_glob) Uncommented, updated i18n support.
11444 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
11445 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
11446 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
11447 the declarations of macros taking arguments a lot nicer.
11449 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
11451 * error.h: Removed CE, CW aliases for SE, SW.
11453 * q2c.c: Removed explicit streq() definition since it's duplicated
11456 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
11457 stats.h, str.h, tokens.h: Made the declarations of macros taking
11458 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
11461 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
11463 * cmdline.c: Comment fixes.
11464 (pick_compat) Changed return type to int. Now, instead of setting
11465 glob var `compat' to the emulation, returns the emulation. All
11466 references changed.
11467 (parse_command_line) Added terminating null to end of
11468 `long_options' array definition.
11469 (pre_syntax_message) Fixes.
11470 (usage) Shows the default emulation in the syntax message by
11471 calling pick_compat().
11473 * getline.c: (getl_add_include_dir) Separates paths with
11474 PATH_DELIMITER, not DIR_SEPARATOR.
11476 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
11477 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
11479 * output.c: (outp_configure_macro) Make earlier definitions for a
11480 particular key override later ones for the same key.
11482 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
11484 * ascii.c: Comment fixes.
11486 * output.c: (outp_get_paper_size)
11487 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
11489 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
11491 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
11492 <errno.h>. GNU libc 2 enforces this!
11494 * command.c: (parse_cmd) Fixed problem with `else' clause being
11495 paired with wrong `if'. Comment fix.
11497 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
11499 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
11500 blp_getline() to getline().
11502 * output.c: (outp_eval_dimension) Changed the fix from last time;
11503 there was no variable `a'.
11505 * q2c.c: (get_line) Fixed boundary condition overrun bug.
11507 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
11509 * output.c: (outp_evaluate_dimension) Fixed handling of negative
11510 numbers having fractional parts. Added case of a fraction without
11511 a whole-number part.
11513 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
11515 * ascii.c: (ascii_text_get_font_position) Removed.
11517 * expr.h, exprP.h: Disabled debugging.
11519 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
11522 * output.h: (struct outp_class_struct) Removed
11523 text_get_font_position method. All references deleted.
11525 * postscript.c: Big change here. Fontmaps were completely
11526 eliminated because of a change in philosophy. Comment fixes.
11527 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
11529 (struct ps_driver_ext) `position', `fontmap', `prop_name',
11530 `fixed_name' members removed. New members `prop_family',
11531 `fixed_family'. `family' member changed to type char *.
11532 (static var ps_fontmaps) Removed.
11534 (ps_init_driver) Removed obsolete references, updated.
11535 Initializes `translate_x', `translate_y', `scale'. Doesn't read
11536 fontmap, of course. Refers to font names through internal_name
11537 rather than subversive means. Frees proper items.
11538 (static var option_tab[]) Removed `fontmap-file' option; renamed
11539 `fixed-font', `prop-font'.
11540 (ps_option) Corresponds to option_tab[].
11541 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
11542 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
11543 hash_family) Removed.
11544 (postopen) Generates font names from family names. Gets
11545 PostScript font name properly. New prologue file comment `!!!'
11547 (ps_open_page) Adds translate_x, translate_y to BP prologue
11548 function; gives SF argument floating-point format.
11549 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
11550 font name. Doesn't change font family.
11551 (ps_text_set_font_by_position) Generates Groff font name from font
11552 family name instead of through table lookup.
11553 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
11554 all references changed. Reduced to simple string assignment.
11555 (ps_get_font_name) Removed.
11556 (ps_get_font_family) Reduced to string return.
11557 (text) Doesn't save `position' since it no longer exists. Ugly
11558 kluge to save font family--fix soon?
11559 (load_font) Removed PostScript name argument.
11561 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
11563 * postscript.c: Comment fix.
11564 (ps_open_page) Puts scale factor in PostScript output.
11566 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
11568 * Makefile.am: Distcleans q2c.
11570 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
11572 * ascii.c: (delineate) Sets text size even if width is zero.
11574 * command.c: Comment fix.
11575 (static var cmd_table[]) Re-enabled EVALUATE command.
11576 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
11577 of comments in script files. Now more liberal on criteria for
11578 performing a state transition--if *anything* happened correctly,
11579 not just if *everything* happened correctly.
11581 * data-out.c: (convert_F) Comment fix. Why in the fsck does
11582 Checker segfault on formatting large numbers and why in the fsck
11583 hadn't I noticed this before?
11585 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
11587 * list.q: (cmd_list) Commented out the actual output routine
11588 because of various problems. Probably will abandon the idea of
11589 using the general `crushed tables' for the LIST procedure.
11591 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
11592 clearing it. Allocates a new var_by_name dictionary before trying
11593 to add members to it.
11595 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
11596 `sib'. Changed type of `node' argument.
11597 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
11598 avl_walk_inorder().
11599 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
11600 [DEBUGGING] Only deletes the variable from var_by_name if that var
11603 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
11605 * Makefile.am: Added include files to SOURCES. Added
11606 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
11607 includes rules for q2c. Added `boast' target.
11609 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
11611 * Makefile.am: Maintainer-clean Makefile.in.
11613 * Makefile.am: Fixed redundant EXTRA_DIST line.
11615 * ascii.c: Comment fixes.
11616 (ascii_line_vert) Fixed overly aggressive range check.
11618 * display.c: Removed dead code.
11620 * list.q: Turn debugging on.
11621 (flush_table) New debug code.
11623 * sfm-read.c: (read_value_labels) malloc's the structure before
11624 trying to assign to its members.
11626 * sfm-write.c: Comment fix.
11628 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
11630 (output_table) No arguments anymore--gets them through `som'
11631 global. New debug code. In crushed tables, now sets `htv' as
11632 well as `hv' to avoid bad confusion later.
11633 (dump_crush_page) New debug code.
11635 * som-low.c: (som_dump_crush_page) New debug code.
11637 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
11639 All source files: Broke long lines into multiple lines.
11641 * ascii.c: (ascii_close_page) Uses host_system var in place of
11642 HOST_SYSTEM constant.
11644 * cmdline.c: (var syntax_message[]) Broke into
11645 pre_syntax_message[] and post_syntax_message[].
11646 (usage) Outputs both parts, separated by driver list.
11648 * error.h: Fixed broken formatting.
11650 * expr-opt.c: (str_search, str_rsearch) New functions.
11652 * misc.c: (blp_getdelim) Removed. All references changed to
11654 (str_search, str_rsearch) Removed.
11655 (memrmem) New function.
11657 * misc.h: (blp_getline) Removed. All reference changed to
11660 * stat.h: New file.
11662 * filename.c: Includes "stat.h", not <sys/stat.h>.
11663 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
11665 * output.c: (outp_list_classes) Changed output formatting.
11667 * sfm-write.c: (write_header) Uses host_system var instead of
11668 HOST_SYSTEM constant.
11669 (write_rec_7_34) Extracts version numbers from the version string.
11672 * sort.c: Includes "stat.h", not <sys/stat.h>.
11674 * str.c: (strcasecmp) Removed.
11676 * title.c: (cmd_document) Uses host_system var instead of
11677 HOST_SYSTEM constant.
11679 * version.c: Generated on-the-fly by the Makefile instead of being
11682 * str.h: Comment fixes. Doesn't substitute for missing memmove or
11684 [!HAVE_STRNCASECMP] Declares strncasecmp().
11686 * version.h: Removed stray character. Comment fixes.
11687 (vars host_system, build_system) New vars.
11689 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
11691 * Most source files: Changed formatting of copyright notice; fixed
11692 FSF address; reformatted to better conform to GNU standards;
11693 comment fixes. Added markups to prevent GNU indent from messing
11694 up my beautiful formatting :-).
11696 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
11697 that GNU indent markups can be passed through without problems.
11699 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
11701 * get.c: Turned off debugging.
11703 * glob.c: (init_glob) Turned on save-file compression by default.
11705 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
11706 compression than was possible in save files.
11708 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
11710 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
11712 * frequencies.q: Removed Fiasco extensions. Updated calculation
11713 algorithms. Polished output format.
11714 (struct frq_info_struct) Removed members `max_degree', `min_n',
11715 all references removed.
11716 (macro frq_extensions) Removed.
11717 (static vars min_n, max_degree) Removed, all references removed.
11718 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
11719 calculate `min_n', `max_degree'.
11720 (postcalc) Passes new arg to dump_statistics().
11721 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
11723 (dump_condensed) Adds variable name title.
11724 (sum_freqs) Removed.
11725 (calc_stats) Updated calculation algorithm.
11726 (dump_statistics) Removed warning for too-few observations.
11727 Changed table formatting. Adds variable name title if passed new
11730 * output.h: Comment fix.
11732 * recode.c, sample.c, sort.c: Disabled debug code.
11734 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
11735 Improved debug code.
11737 * var.h: (enum series frq_*) Removed Fiasco extensions.
11739 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
11741 * command.c: Added PROCESS IF to command table.
11743 * Lots & lots of places, removed checks for NULLs preceding calls
11744 to free_expression(), which itself checks.
11746 * descript.q: Removed Fiasco extensions. Removed optimizations
11747 for non-weighted active files. Implemented some options.
11748 Finished polishing output format. Comment fixes. Merged
11750 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
11751 max_degree, min_n) Removed.
11752 (macro dsc_extensions) Removed.
11753 (struct dsc_info_struct) Removed `min_n' member, all references
11755 (internal_cmd_descriptives) Removed calculation of min_n,
11756 max_degree. Only deals with one `calc' routine instead of two
11758 (precalc) Eliminated redundancy. Updated for changes to
11759 descriptives_proc structure.
11760 (calc) Moved here from `descript.g'. Rewritten to calculate
11761 statistics via `moments about the mean' rather than by summing,
11762 summing squares, summing cubes, and so on.
11763 (postcalc) Rewritten for new-style statistical calculation.
11764 (display) Removed support for displaying variables across rows.
11765 No longer crushes the descriptives table. Removed ancient code.
11766 Added display of N, by variable and listwise.
11768 * descript.g: Removed; merged into `descript.q'.
11770 * expr-evl.c: (evaluate_expression) Now returns a double. For
11771 numeric results, it returns the result as well as storing it in
11772 the passed `value' structure if non-NULL. For string results it
11773 just returns 0.0 and it must be passed non-NULL. Many references
11774 to this function were optimized by use of this change, especially
11775 but not exclusively in `compute.c'.
11777 * frequencies.g: Comment fix.
11779 * glob.c: (glob var process_if_expr) New global var.
11781 * postscript.c: (static var option_tab[]) Corrected entry for
11783 (postopen) Sets x->size to x->prop_size.
11784 (ps_text_set_font_by_name) Sets font size as well as typeface for
11785 PROP and FIXED fonts.
11787 * sel-if.c: (cmd_process_if) New function.
11789 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
11790 (sfm_write_dictionary) Sets `n_cases' to 0.
11791 (sfm_write_case) Increments `n_cases'.
11792 (sfm_close) Attempts to seek the system file back to the header
11793 and write the number of cases in its proper slot.
11795 * som-frnt.c: (som_insert_table) Masks off expansion options since
11796 only SOPT_X_NORM seems to work sensibly.
11798 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
11799 with a `fixed' value of 2.
11801 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
11803 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
11804 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
11806 * var.h: (enum series dsc_*) Removed Fiasco extensions.
11807 (struct descriptives_proc) Removed `miss_noweight'; new members
11808 `X_bar', `M2', `M3', `M4', `min', `max'.
11810 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
11812 * vfm.c: (close_active_file) Cancels PROCESS IF.
11813 (write_case) Doesn't process cases unselected by PROCESS IF.
11815 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
11817 * glob.c: (glob var err) Removed.
11819 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
11820 doesn't have to take into account number of value labels since
11821 they're in a subtable anyway. Also, doesn't display more than 10
11822 value labels since we can't yet break pages in subtables.
11824 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
11826 * som-frnt.c: (som_change_table_size) Simple change for elegance
11827 that shouldn't change behavior.
11828 (som_set_value) Comment fix.
11830 * som-high.c: (som_submit_table) Message fix.
11832 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
11834 * command.c: Added SYSFILE INFO to command table.
11836 * file-handle.q: (fh_handle_filename) New function.
11838 * get.c: (save_trns_proc) Fixed a bug in padding of output data
11841 * main.c: (parse) New return value for command functions, -3.
11843 * misc.h: Comment fix.
11845 * output.h: Comment fixes.
11846 (macro COMPONENTS) Removed.
11848 * postscript.c: (write_text) Modified literal_chars[] so that `('
11849 and ')' are not written to the output in strings as literals.
11851 * sfm-read.c: (sfm_read_dictionary) New argument.
11852 (read_header) New argument. Sets the information structure's
11853 values from the header information.
11854 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
11855 bizarre Checker problem, I guess.
11856 (read_variables) Proper cleanup on lossage.
11858 * sfm.h: (struct sfm_read_info) New struct for use by
11859 sfm_read_dictionary().
11861 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
11862 currently used just for tables that can be dynamically resized and
11863 thus have to be allocated with arena_malloc() instead of
11864 arena_alloc(). All references changed.
11865 (som_change_table_size) New function.
11866 (som_insert_table) Bugfix: now inserts `cell', not `c'!
11868 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
11869 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
11872 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
11874 (draw_intersection) Now takes an argument specifying the table in
11875 question. All references changed.
11876 (draw_table_cell) New function.
11877 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
11878 (som_get_table_size) Many nice new explanatory comments.
11879 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
11881 * som.h: New enum series SOM_CREATE_* for use as create flags with
11882 som_create_table().
11884 * str.h: Moved a comment here from TODO.
11886 * sysfile-info.c: New file. Reference implementation.
11888 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
11890 * command.c: Added RENAME VARIABLES to table of commands.
11892 * data-in.c: (dls_error) Sets `cust_field'.
11893 (parse_N) Message fix.
11894 (parse_day_count) New function.
11895 (to_roman) Never outputs VX as a `short form' of V.
11896 (parse_month) Fixed parsing of Roman numerals.
11897 (parse_trailer) Message fix.
11898 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
11899 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
11900 the date is invalid.
11901 (parse_SDATE) Fixed swapped day, year.
11902 (parse_JDATE) Fixed bug for dates in 1582.
11903 (parse_DTIME) Allows days not between 1 and 31.
11904 (parse_numeric) Makes local copy of f.type for easier usage.
11907 * data-out.c: (convert_F) When outputting as scientific, properly
11908 sets f.type as fp->type.
11909 (insert_commas) Fixed operator precedence problem with setting of
11910 nitems. Changed strcpy to memcpy (no null terminator).
11911 (convert_date) Fixed FMT_JDATE: added 1900 to year.
11912 (convert_CCx) Essentially rewritten, but now it works.
11914 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
11915 feature of Fiasco).
11916 (display_documents) Implemented.
11918 * error.c: (glob var cust_field) New var.
11919 (vmsg) Displays cust_field as part of message classes DE and DW.
11921 * formats.c: (debug_print) Fixed to compile under updated
11924 * get.c: (cmd_get, cmd_save_internal) Close file handle on
11927 * misc.c: (parse_format_specifier) Formatting fix.
11929 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
11930 `n_rename' for clarity.
11931 (cmd_modify_vars) Initializes `forward' and `positional' at
11932 appropriate times. Frees lists of vars to rename on failure.
11933 Comment fix. Frees memory on success.
11934 (rearrange_dict) Simplified `for' loop condition.
11936 * rename-vars.c: New file (reference implementation).
11938 * set.q: (internal_cmd_set) Fixed `emu' test condition.
11940 * sfm-read.c: (read_header) File label is created only if file
11941 label in file is not blank.
11942 (read_variables) Initializes `dict' local variable.
11943 (read_documents) Proper behavior on lossage.
11945 * sfm-write.c: (write_header) Doesn't blank out the file label
11946 (why was this here to begin with?!)
11948 * temporary.c: (save_dictionary) File label is copied only if
11949 non-NULL. Doesn't try to xstrdup() dictionary documents.
11950 Adapted so as to not irritate Checker.
11951 (free_dictionary) Only destroys var_by_name if non-NULL.
11953 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
11954 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
11955 lines to the document, indents the document. Also, it works now.
11956 (add_document_line) New function.
11958 * var.h: (struct dictionary) Reordering.
11960 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
11961 bits if it was allocated to begin with.
11963 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
11965 * command.c: Added MODIFY VARS to list of commands.
11967 * configure.in: Updated custom macros for autoconf 2.12. Removed
11968 mmap reference; fixed termcap library reference.
11970 * display.c: (display_variables) Fixed a few bugs although it's
11971 still not well written.
11973 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
11974 (induce_segfault) Calls chkr_disp_call_chain() instead of
11975 inducing an actual SIGSEGV.
11977 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
11978 str_search() and str_rsearch(). Fixed tests for matches on
11979 OP_INDEX and OP_RINDEX.
11981 * filename.c: (good_getcwd) Removed as the new libc for Checker
11982 doesn't contain this bug, apparently.
11984 * misc.c: (str_search, str_rsearch) Changed order of arguments for
11985 consistency with GNU memmem.
11986 (blp_getdelim) Changed `len' from `int' to `size_t'.
11988 * modify-vars.c: Reference implementation.
11990 * som-frnt.c: (zero_length) New global var.
11991 (som_create_table) Message fix.
11993 * som.h: Added gcc attributions to som_set_text(),
11994 som_output_text() prototypes. blank_line() refers to
11995 zero_length[] instead of a literal null string to suppress gcc
11998 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
11999 (allocate_cases) Decrements x_max so the last element of x[] can
12000 be used by the algorithm.
12002 * var.h: Changed minor details of `variable' declaration.
12003 (struct modify_vars_proc) New struct.
12004 (struct variable) Added field p.mfv.
12006 * vars-atr.c: Comment fix.
12008 * vars-prs.c: (fill_all_vars) More optimal implementation.
12010 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
12011 character, which it shouldn't have to do but printf() seems to
12012 read the null byte even though I supply a maximum length...
12014 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
12016 * command.c: Removed command alias X for QUIT.
12017 (parse_cmd) Fixed comment parsing.
12019 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
12021 (read_record) Fixed references to len, size.
12022 (dfm_get_record) Restructured.
12024 * file-handle.h: (struct file_handle) Field `lrecl' now of type
12027 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
12030 * modify-vars.c: New file. Not complete.
12032 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
12035 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
12036 problems caused by int/size_t differences.
12038 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
12041 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
12042 being compared were of equal length.
12044 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
12046 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
12048 * lexer.c: (get_dotted_rest_of_line) New function.
12050 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
12053 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
12054 type 6 records. Frees the dictionary properly.
12055 (read_header) Initializes the dictionary instead of letting
12056 read_variables() do it. Sets the dictionary file label from the
12058 (read_documents) New function.
12060 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
12061 write type 6 record if appropriate.
12062 (write_header) Writes file label from dictionary.
12063 (write_documents) New function.
12065 * temporary.c: (save_dictionary, restore_dictionary,
12066 free_dictionary) Properly handle new fields in dictionary struct.
12068 * title.c: (get_title) Returns after failure().
12069 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
12070 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
12072 * var.h: (struct dictionary) New fields `label', `n_documents',
12075 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
12077 * command.c: Added FILTER to list of commands.
12079 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
12082 * get.c: (cmd_save_internal) Removed weighting code since it's now
12083 handled by sfm-write.c. Properly commented out debug code.
12085 * glob.c: (glob var weighting) Removed.
12087 * sel-if.c: Comment fixes.
12088 (cmd_filter) New function.
12090 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
12091 (sfm_read_dictionary) Sets weighting variable direct in the
12092 created dictionary now. (Apparently we previously didn't support
12094 (read_header) Sets weight_index field in sfm_fhuser_ext from
12095 header read from disk.
12097 * sfm-write.c: (sfm_write_dictionary) Comment fix.
12098 (write_header) Now sets the weighting in the header from the
12099 passed primary dictionary instead of from the sfm_write_info.
12101 * sfm.h: (struct sfm_write_info) Removed field `weight'.
12103 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
12104 broke on boundary conditions.
12106 * var.h: (struct dictionary) New fields `weight_var',
12107 `weight_index', and `filter_var'.
12108 (glob var weighting) Removed. This is now part of struct
12109 dictionary. All references changed; the less mechanical changes
12110 are described above.
12112 * vars-atr.c: (find_dict_variable) New function.
12114 * vfm.c: (static var filter_index) New variable.
12115 (open_active_file) Initializes filter_index from default_dict.
12116 (write_case) Calls proc_func() only if the filter variable is
12117 nonzero; this implements FILTER behavior.
12119 * weight.c: (static var weight_varname) Removed.
12120 (cmd_weight) Modified default_dict instead of glob vars.
12121 (update_weighting) Changed the signature to modify a dictionary
12122 instead of glob vars. Now returns the weighting variable.
12123 (get_weighting_variable) Removed; its function is absorbed by
12124 update_weighting().
12125 (stop_weighting) Operates on a dictionary now.
12127 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
12129 * sort.c: Removed debugging info from messages.
12130 (do_external_sort) Cleans up after itself by deleting the
12131 temporary directory on failure. (On success it is deleted by the
12133 (allocate_cases) Removed debug code. Added clean up code.
12134 (output_record) Removed debug code.
12135 (merge) Added code to close all the input files that are currently
12136 open. This is a likely location for bugs, because I'm not sure
12137 about boundary conditions. Removed an unnecesary heap_delete().
12138 (merge_once) Removed input file "optimization" that in fact
12139 screwed up the rest of the code. Message and comment fixes.
12141 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
12143 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
12145 * heap.c: (heap_delete) New argument.
12147 * sort.c: Finished implementation of external sort.
12149 * vfm.c: (read_from_disk) Returns after a disk error.
12151 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
12153 * sort.c: (static var state) Removed.
12154 (static vars max_handles, tmp_basename, tmp_extname,
12155 huffman_queue) New variables.
12156 (do_external_sort) Moved most code to new functions.
12157 Creates huffman_queue.
12158 (allocate_file_handles, allocate_cases) New functions.
12159 (static vars run_no, run_length, file_index, case_count) New
12161 (output_record) Returns success. Now really writes to the output
12163 (begin_run, end_run) New functions.
12164 (write_initial_runs) Returns success. Initializes run_no to -1.
12165 Calls begin_run(), end_run() at appropriate times. Outputs debug
12167 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
12169 (merge) New function.
12171 * heap.c, heap.h: New files. Hopefully in near-final form.
12173 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
12175 * glob.c: Added write_active_file to global vars.
12177 * sort.c: Several new miscellaneous static variables.
12178 (cmd_sort_cases) Big comment fix.
12179 (perform_case_2) Renamed `do_external_sort' and completely
12181 (case_2_proc_func) Removed.
12182 (output_record, write_initial_runs, write_to_sort_cases,
12183 compare_record) New functions.
12185 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
12187 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
12189 * sort.c: (perform_case_2) Changed the method for allocation of
12190 lots of memory--now allocates one case at a time in hopes that
12191 more cases can be allocated with heavily fragmented memory.
12193 * var.h: (write_active_file) New global var.
12195 * vfm.c: (procedure, close_active_file, write_case,
12196 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
12197 arguments to procedure() to be NULL. All references to
12198 procedure() that made use of dummy functions were changed to NULL
12200 (open_active_file) If write_active_file is non-NULL, the output
12201 device becomes DEV_PGM (a new enum).
12202 (close_active_file) Sets write_active_file to NULL.
12203 (read_from_memory) Comment fix.
12204 (record_case) Calls write_active_file() when the output device is
12207 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
12209 * sort.c: New file.
12211 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
12212 Fixed checking for duplicate varnames.
12213 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
12215 (autorecode_trns_free) Destroys hash tables for each recoding
12217 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
12219 * command.c: Added SORT CASES to cmd_table.
12220 (null_func, null_int_func) Prototyped.
12222 * descript.g: (calc_weight, calc_noweight) Computes own case
12225 * frequencies.q: (dump_statistics) Fixed problem with
12226 too-few-cases warning message.
12228 * get.c: (cmd_save_internal) Handles weighting properly.
12230 * hash.c: (hsh_dump) Output format changed.
12231 (force_hsh_insert) Actually works now, prototype changed.
12233 * list.q: (static var case_num) New variable.
12234 (cmd_list) Initializes case_num.
12235 (list_cases) Increments case_num.
12237 * var.h: Added definitions for SORT CASES. Comment fixes.
12239 * vfm.c: Some definitions moved to new file vfmP.h. Comment
12240 fixes. `active' renamed vfm_active, `rep' renamed
12241 vfm_replacement, all references changed.
12242 (procedure) The procfunc no longer receives a case number. All
12243 references changed.
12244 (write_case) Subtle reordering.
12245 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
12248 * weight.c: (get_weighting_variable) New function.
12250 * vfmP.h: New file with definitions from vfm.c.
12252 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
12254 * command.c: (FILE_TYPE_okay) Commented out some tests because
12255 they're clumsy and not yet needed.
12257 * var.h: Most *_trns structures moved to their respective source
12258 files. Some were moved into a new file, do-ifP.h. Comment fixes.
12259 (union any_trns) Changed to a typedef for trns_header.
12260 (struct input_program_pgm) Removed.
12262 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
12263 was allocated in the first place.
12265 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
12267 * autorecode.c: New file.
12269 * command.c: Added AUTORECODE to command table; re-enabled SET.
12271 * data-out.c: (convert_F) Handles infinities and NaNs properly.
12273 * error.c: (vmsg) Comment fixes.
12275 * hash.c: Comment fix.
12276 (hashpjw_d) New function.
12277 (hashpjw) Reimplemented as call to more general function
12279 (internal_comparison_fn) Initializes pointers properly.
12280 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
12281 (force_hsh_insert, force_hsh_find) New debugging wrapper
12284 * main.c: (main) Message fix.
12286 * output.c: (outp_read_devices) Message fix.
12288 * set.q: Comment fixes.
12289 (custom_results) Implemented Wnd/X form of subcommand.
12290 (set_routing) New function.
12291 (internal_cmd_set) Implemented ERRORS, MESSAGES.
12293 * settings.h: (SET_ROUTE_*) New enum series.
12294 (set_results) Renamed set_results_file, all references changed.
12295 (set_messages) Removed.
12296 (glob vars set_errors, set_messages, set_results) New vars.
12298 * title.c: (get_title) Remembers to xstrdup() the result of
12299 get_rest_of_line().
12301 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
12303 (union any_trns) New element `arc'.
12305 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
12307 * command.c: (output_line) Removed references to set_screen.
12309 * error.c: (static var terminating) New var.
12310 (hcf) Sets terminating to 1.
12311 (vmsg) If terminating is nonzero, does not attempt to call hcf().
12312 This prevents an infinite loop if an error occurs within hcf().
12314 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
12315 statement circumlocution with `case 42000' trick.
12316 (evaluate_expression) New support for OP_STR_MIS.
12318 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
12319 statement circumlocution with `case 42000' trick.
12320 (dump_node) Handles OP_STR_MIS.
12322 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
12323 variables exceptions.
12324 (parse_function) Message fix.
12325 (ops[]) Added OP_STR_MIS.
12327 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
12329 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
12331 * glob.c: Removed set_scrnfile glob var.
12332 (init_glob) set_errorbreak set to 0 by default.
12334 * groff-font.c: Changed included files.
12335 (groff_read_font) Initializes font_arena local var correctly.
12336 (default_font) New function.
12338 * output.c: Comment fixes.
12339 (glob var disabled_devices) New variable.
12340 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
12342 [GLOBAL_DEBUGGING] (reentrancy) New function.
12343 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
12344 outp_iterate_enabled_drivers) Calls to reentrancy().
12345 (destroy_list) New function.
12346 (outp_done) Moved code to destroy_list().
12347 (parse_options) Parses `listing', `screen', `printer' options
12349 (configure_driver) Sets new `device' member of driver.
12350 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
12352 * output.h: Comment fixes. New enum series OUTP_DEV_*.
12353 (struct outp_driver_struct) New member `device'.
12355 * postscript.c: (find_encoding_file) Doesn't display its own error
12357 (default_encoding) New function.
12358 (switch_font) Calls default_encoding() if no encoding can be
12360 (text) Makes up a character metric if none exists for the desired
12362 (load_font) Properly copies a fallback filename. Calls
12363 default_font() for a font if none at all are known.
12365 * set.q: Comment fixes. Removed OUTPUT subcommand.
12366 (custom_listing) Calls outp_enable_device() to enable/disable
12368 (turn_screen_on) Removed.
12369 (internal_cmd_set) Calls outp_enable_device() to enable/disable
12370 screen, printer devices.
12372 * settings.h: Comment fixes.
12373 (glob vars set_output, set_printer, set_screen, set_scrnfile)
12376 * som-high.c: (som_submit_table, som_eject_page) Use
12377 outp_iterate_enabled_drivers() instead of iterating
12378 outp_driver_list directly.
12380 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
12382 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
12383 (parse_string_as_format) Handles new formats.
12384 (parse_numeric) Now handles DOT and PCT formats.
12386 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
12388 (convert_date) Handle EDATE and SDATE formats.
12389 (convert_CCx) Now if there's not room for the currency characters,
12390 converts it as F format if it's positive instead of giving up
12391 quickly. Also fixed save-and-restore bug with decimal point
12393 (convert_format_to_string) Handles new formats.
12395 * misc.c: (formats[]) Added new formats.
12396 (convert_fmt_ItoO) Supports new formats.
12398 * sfm-read.c: (parse_format_spec) Supports new formats. Better
12399 data checking. New argument, all references changed.
12401 * sfm-write.c: (write_format_spec) Supports new formats.
12403 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
12406 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
12408 * cmdline.c: Comment fixes.
12409 (parse_command_line) Changed return type to void.
12411 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
12413 (parse_numeric) Handles international numbers (comma as decimal
12414 point). Some reformatting.
12416 * data-list.c: (parse_free) Default output format is now
12417 set_format instead of hard-coded F8.2.
12418 (read_from_data_list_list) Emits error message on undefined data
12419 only if set_undefined is nonzero.
12421 * data-out.c: (convert_E) Changes decimal point from period to
12422 comma if appropriate. Restructured. Better comments.
12423 (convert_F) Changes decimal point from period to comma if
12425 (insert_commas) Major bug with handling of negative values fixed.
12426 Also, inserts periods instead of commas if appropriate.
12427 (convert_CCx) New function.
12428 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
12429 (num_to_string) Changed `.' to set_decimal.
12431 * dfm.c: Comment fixes.
12432 (dfm_close) Frees ext->line even in inline_file.
12433 (open_inline_file) New function.
12434 (open_file_r) When opening the inline file: now properly
12435 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
12437 (read_record) Calls fh_close_handle() instead of dfm_close() to
12438 close the inline file. Makes a copy of the line getl_buf to avoid
12439 interlock problems.
12440 (dfm_get_record) Restructured. Now checks the return value of
12442 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
12443 checking for use of inline file. No longer tries to close inline
12446 * error.c: (glob var error_already_flagged) New var.
12447 (vmsg) Message change. Now checks max number of errors/warnings,
12450 * file-handle.q: (fh_handle_name) Now allows closing of
12452 (fh_init_files) Reformatted.
12454 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
12456 * getline.c: (getl_include) Fixed bug that popped up when called
12457 when file queue was empty.
12458 (read_console) Resets error_count, warning_count,
12459 error_already_flagged to zero.
12461 * glob.c: Many changes to update list of variables.
12462 (init_compat_dependent) Now this function is called whenever
12463 `compat' changes. It now sets set_seed only if it hasn't
12464 previously been referenced. It now calls
12465 lex_init_compat_dependent().
12467 * include.c: (cmd_include_at) Frees temporary buffer instead of
12469 (cmd_include) Doesn't make copy of include file name.
12471 * lexer.c: Comment fixes.
12472 (init_lex) Moved some code into new function
12473 lex_init_compat_dependent().
12474 (lex_init_compat_dependent) New function.
12475 (hex_val) Simplified.
12476 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
12478 * main.c: Comment fixes.
12479 (main) Reformatted.
12481 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
12482 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
12483 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
12484 (setup_randomize) Sets set_seed_used.
12486 * set.q: Comment fixes.
12487 (custom_results) Conditionalizes on `compat'.
12488 (custom_log) Calls custom_journal().
12489 (set_ccx) New function.
12490 (cmd_set) Calls init_compat_dependent() when `compat' changes.
12491 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
12492 when set_decimal changes. Range-checks values for MITERATE,
12493 MNEST. Message fixes.
12495 * settings.h: Comment fixes.
12496 (struct set_cust_currency) New struct.
12497 (set_cc[], set_grouping, set_seed_used) New global vars.
12499 * var.h: (FMT_CCA...FMT_CCE) New output formats.
12500 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
12502 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
12504 * glob.c: Revised variables to correspond to settings.h.
12505 (init_glob) Initializes variables from settings.h properly.
12507 * set.q: Began long-overdue major revision to correspond to new
12508 philosophy. Most code changed.
12510 * settings.h: Mostly changed; reorganized, reordered, large new
12513 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
12515 * get.c: (cmd_save_internal) No longer forces compression off.
12517 * sfm-read.c: (read_compressed_data) If eof is reached when
12518 reading a new instruction octet, only signal error if we're in the
12521 * sfm-write.c: (COMPRESSION_BIAS) New #define.
12522 (struct sfm_fhuser_ext) New member `end'.
12523 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
12524 (ensure_buf_space) New function.
12525 (sfm_write_case) Reimplemented in order to support compression.
12526 (sfm_close) Writes out the remaining contents of the compression
12529 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
12531 * command.c: Defined SAVE and XSAVE commands in command table.
12533 * common.h: second_lowest_value is of type flt64, not double.
12535 * file-handle.h: Comment fix.
12537 * get.c: Comment fixes.
12538 (static var `trns') New.
12539 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
12540 cmd_save_internal, cmd_save, cmd_xsave) New functions.
12541 (dict_delete_run) Clears the variables and frees them now.
12542 (trim_dictionary) Sets default for compression.
12543 On KEEP subcommand, frees deleted variables as well as clearing
12544 them. Finally got the sense of the test for deleting all
12546 [DEBUGGING] (dump_dict_variables) Message fix.
12548 * glob.c: (init_glob) set_compression set to 1 by default.
12550 * list.q: Properly #includes config.h.
12552 * misc.h: New macro REM_RND_UP.
12554 * settings.h: Comment fix.
12556 * sfm-read.c: (structs sysfile_header, sysfile_format,
12557 sysfile_variable; inline function bswap_int32) Moved to new file
12559 (corrupt_msg) [__CHECKER__] No longer induces segfault.
12560 (sfm_read_dictionary) Fixed bug caused by failing to initialize
12562 (read_machine_flt64_info) Fixed some problems caused by confusion
12563 between flt64 and double types.
12564 (read_header) Message fix.
12565 (read_variables) Fixed set of cases in which we byte-swap sv.print
12566 and sv.write. Fixed confusion of flt64 and double.
12568 * sfm.h: (struct sfm_write_info) New.
12570 * som-high.c: (som_draw_title) Properly frees `s'.
12572 * temporary.c: (save_dictionary) Comment fix.
12574 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
12575 (struct trns_header) Formatting fix.
12576 (struct save_trns) New.
12578 * vars-atr.c: (discard_variables) Comment fix.
12580 * sfm-write.c: New file, baseline release.
12582 * sfmP.h: New file, baseline release.
12584 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
12586 * cmdline.c: (parse_command_line) `--version' output updated.
12587 (glob var syntax_message[]) Added my e-mail address.
12589 * file-handle.q, lexer.c, vfm.c: Changed many instances of
12590 `illegal' to `invalid'.
12592 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
12593 uncompression buffer.
12594 (sfm_close) Frees decompression buffer.
12595 (sfm_read_dictionary) Initializes decompression buffer.
12596 (buffer_input, read_compressed_data) New functions.
12597 (sfm_read_case) Restructured; now calls read_compressed_data() to
12598 handle compressed system file data.
12600 * var.h: Comment fix.
12602 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
12604 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
12607 * get.c: New comments. New static var `get_file'.
12608 (cmd_get) Now fully implemented. Calls discard_variables();
12609 initializes fv and lv for all variables; new debug code; sets
12610 up the dictionary; sets up the input program.
12611 (read_from_get, cancel_get) New functions.
12613 * sfm-read.c: Comment fixes.
12614 (sfm_close) New static function.
12615 (sfm_read_dictionary) Properly sets up the class of the
12616 file_handle. No longer cares what size the data is in records of
12617 type 7. Also, on failure, properly cleans up the file_handle and
12618 free()s some stuff.
12619 (read_variables) No longer thinks it knows `nval' of the
12620 dictionary. Now sets p.get.fv, etc., instead of speculatively
12622 (read_value_labels) Fixed off-by-one error in indexing of
12624 (sfm_read_case) New function.
12625 (sfm_r_class) New static var.
12627 * var.h: (get_proc) New struct.
12628 (struct variable) New member p.get.
12630 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
12632 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
12633 the manual's meaning.
12634 (rename_variables) New function.
12635 (trim_variables) Doesn't try to parse MAP any more. Removed debug
12636 code. Now properly reorders the dictionary on the KEEP keyword.
12638 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
12639 garbage collection.
12641 * vars-atr.c: (clear_variable) New argument `dictionary *'.
12642 (rename_variable) New function.
12643 (free_val_lab) Reformatted.
12645 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
12647 * var.h: Reindented entire file. Comment fixes.
12648 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
12650 (glob var default_dict) New.
12651 (struct indirect_dictionary) Removed.
12653 * Many other source files were changed to add `default_dict.'
12654 before all references to the dictionary of the active file.
12656 * vars-atr.c: (make_indirect_dictionary) Removed.
12658 * glob.c: Reindented all variable declarations. Updated for
12659 changed var.h. Comment fixes.
12661 * temporary.c: (restore_dictionary, save_dictionary) Simplified
12662 because now we can mainly copy dictionary structs.
12664 * vars-prs.c: (is_dict_varname, parse_dict_variable,
12665 parse_variables) Takes dictionary instead of indirect_dictionary
12667 (parse_variables) Instead of calling make_indirect_dictionary,
12668 just sets DICT to &default_dict if DICT is NULL. Of course, lots
12669 of `*dict.' references had to be changed to `dict->'. Removed
12672 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
12674 * get.c: Added GTSV_OPT_* series of enums.
12675 (trim_dictionary, dict_delete_run) New functions.
12676 [DEBUGGING] (dump_dict_variables) New function.
12677 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
12678 [DEBUGGING] Calls dump_dict_variables() to display results.
12680 * glob.c: (cmp_variable) Now a public function declared in var.h.
12682 * sfm-read.c: Turned off debug code. Comment fixes.
12683 (read_machine_int32_info, read_machine_flt64_info) New functions
12684 to parse type 7 records.
12685 (sfm_read_dictionary) Properly byteswaps several fields now.
12686 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
12687 records. [DEBUGGING] Dumps dictionary.
12688 (read_variables) Sets `index' field of variables created properly.
12689 Constructs avl tree of variables in dictionary. [DEBUGGING] No
12690 longer dumps dictionary.
12691 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
12693 [DEBUGGING] (dump_dictionary) No longer stubbed out.
12695 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
12696 var before destroying any variables just to save a little time.
12698 * var.h: (struct variable) Reordered in order to make name[] the
12699 first member; this makes pointers to `variable' pointers to the
12700 variable name, simplifying avl trees, etc.
12701 (struct indirect_dictionary) New struct.
12703 * vars-atr.c: (find_variable) Rewritten for efficiency.
12704 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
12706 (is_varname) Rewritten for efficiency.
12707 (parse_variables) New argument, which is a `dictionary *'. All
12708 references changed. This function now reads variable names from
12709 the dictionary passed, or from the default dictionary if NULL.
12711 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
12713 * misc.h: Added new macro DIV_RND_UP to perform integer division,
12714 rounding up. Changed many references to ROUND_UP to use this
12717 * sfm-read.c: Includes avl.h.
12718 (corrupt_msg) Induces a segfault under Checker.
12719 (macro assertive_bufread) New. Many references to bufread() now
12721 (sfm_read_dictionary) Split up into several functions. Added code
12722 to read dictionary records following the the type 2 records. Not
12723 quite complete. New variable `var_by_index'.
12724 (read_header, read_variables) New functions extracted from
12725 sfm_read_dictionary().
12726 (read_value_labels) New function.
12727 (bufread) Checks ferror() if fread() doesn't return the expected
12728 value; if ferror() is zero it's just EOF.
12729 (dump_dictionary) Stubbed out.
12731 * BTW: The source code now exceeds 50000 lines!
12733 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
12735 * command.c: Added GET to cmd_table[].
12737 * list.q: Removed reference to alloca headers.
12738 (cmd_list) Gave prototype.
12740 * sfm-read.c: Added DEBUGGING comments.
12741 (sfm_read_dictionary) Checks bias correctly. Sets
12742 dict->var_by_name to NULL. Calculates long_string_count
12743 correctly. realloc's dict->var[] array to minimum size.
12744 [DEBUGGING] Calls dump_dictionary.
12745 [DEBUGGING] (dump_dictionary) New function.
12747 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
12748 (restore_dictionary) If the dictionary contains a non-NULL
12749 var_by_name, uses that instead of generating one.
12750 (free_dictionary) Destroys var_by_name.
12752 * var.h: (struct dictionary) Added field `var_by_name'.
12754 * get.c: New file, not complete.
12756 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
12758 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
12759 (parse_num_or_range) New function.
12760 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
12761 <n> THRU HIGH missing values.
12763 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
12764 __attribute__((const)).
12766 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
12768 * sfm-read.c: Finished reference implementation.
12770 * sfm.h: Includes var.h.
12772 * var.h: Comment fixes.
12773 (struct `variable') Reordered some fields.
12775 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
12776 constants added previously.
12778 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
12780 * common.h: Comment fixes. Added declaration of
12781 `second_lowest_value' as variable or macro. Made `compat_type',
12782 `pgm_state_type' into anonymous enums.
12784 * display.c: Comment fix.
12786 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
12788 [!defined SECOND_LOWEST_VALUE] Added definition for
12789 `second_lowest_value' global var.
12790 (compat, pgm_state global vars) Changed types to `int'.
12791 (init_glob) Initializes `second_lowest_value'.
12793 * sfm-read.c: Continued work, not complete.
12795 * var.h: Added new MISSING_* constants to handle LOWEST and
12798 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
12800 * sfm-read.c: New file, not complete.
12802 * cases.c: (vec_insert) Changed vector expansion algorithm.
12803 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
12804 mucking up the RECODE transformation in particular.
12805 (envector) Harmless change in notation.
12807 dfm is now fairly well tested again.
12808 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
12810 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
12812 * recode.c: Comment fix.
12814 * sfm.h: Interface should be fairly final now, or at least for a
12817 * vfm.c: [DEBUGGING] (index_to_varname) New function.
12818 (open_active_file) [DEBUGGING] Translates ccase indices into
12819 variable names now to make it easier to understand what's really
12822 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
12824 * data-in.c: Comment fix.
12826 * data-list.c: Includes dfm.h.
12827 (do_reading) Uses new function dfm_push_cust().
12829 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
12830 `return 1;' at end.
12832 * file-handle.h: Completely changed. Some parts split off into
12833 new file dfm.h. Implemented in file-handle.q.
12834 (enum FH_*) Removed.
12835 (struct fh_ext_class) New struct.
12836 (struct file_handle) Retained only these fields: name, norm_fn,
12837 fn, recform, lrecl, mode. New fields class, ext.
12838 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
12839 close_handle, handle_name) Added `fh_' prefix to name, all
12840 references changed.
12842 * dfm.h: New file, implemented in dfm.c.
12843 (get_record, put_record, fwd_record, bkwd_record, set_record,
12844 get_cur_col) Functions moved from file-handle.h, now prefixed with
12846 (dfm_push_cust) New function.
12848 * sfm.h: New file. Incomplete.
12850 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
12851 interface. Functions reordered, comments changed. Not well
12852 tested, probably full of bugs.
12853 (struct dfm_fhuser_ext) New struct.
12854 (dfm_close) New function.
12855 (open_file_r) Pickier about finding `BEGIN DATA.' line.
12856 (open_file_w) User messages changed.
12857 (get_record) Comment fixed.
12858 (read_record) Increments ext->ln even for inline_file. Calls
12859 dfm_close() for inline_file when `END DATA.' encountered.
12860 (dfm_get_record) Experimental restructuring.
12861 (dfm_push_cust) New function.
12862 (cmd_begin_data) Detects whether the inline file was fully read by
12863 checking whether it is still open; detects whether it was read at
12864 all by checking whether the line number is greater than zero.
12866 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
12867 interface. Functions reordered, comments changed. Not well
12868 tested, probably full of bugs.
12869 (init_file_handle) Removed initializers for obsolete fields, added
12871 (fh_close_handle) Much simpler, now mainly calls the class
12873 (fh_init_files) Renamed inline file internal filename.
12875 * file-type.c: Includes dfm.h.
12876 (read_from_file_type) Doesn't use dfm internal state anymore.
12878 * inpt-pgm.c, print.c: Include dfm.h.
12880 * recode.c: (internal_cmd_recode) Casts strlen() return value to
12881 int in comparison with other int.
12883 * som-high.c: (build_target) Fixed operator precedence problem in
12884 if statement (& versus ==).
12886 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
12888 * dfm.c: (read_record) Can now read fixed-length records; not
12890 (put_record) Can now write fixed-length records; not tested.
12892 * file-handle.h: FH_* defines changed to enums. New enum series
12894 (struct file_handle) New members recform, lrecl, mode.
12896 * file-handle.q: Parser changed.
12897 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
12898 /LRECL subcommands. These are compatible with Windows.
12899 (init_file_handle) Initializes recform, mode fields.
12901 * q2c.c: (get_line) When outputting `!' comment lines, now
12902 increments the output file line number so that `#line' directives
12904 (make_identifier) New function that converts an arbitrary string
12905 into a valid C identifier.
12906 (dump_vars) Calls make_identifier() in two places in order to
12907 suppress some errors for bad identifiers.
12908 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
12909 for NO. Allows numbers to be prefixed by underscores to make them
12910 acceptable C identifiers but still to be parsed as numbers by the
12913 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
12915 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
12917 * dfm.c: Comment fixes. (get_record) Gives error if file handle
12918 was opened for writing.
12919 (open_file_w) New function.
12920 (read_record) Uses strncasecmp if available. Improved error
12921 messages, comments.
12922 (put_record) New function.
12924 * file-handle.h: Moved function comments into dfm.c and
12925 file-handle.q. Comment fixes. Removed declarations of
12926 tilde_expand() and normalize_filename().
12927 (struct file_handle) Changed `open' from boolean to enumerated
12928 field to allow for three states--closed, open for reading, open
12929 for writing--all references changed.
12931 * file-handle.q: Includes filename.h.
12933 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
12934 references changed.
12935 (alloc_line) Makes allowance for line terminator characters in
12937 (print_trns_proc) Now handles OUTFILE, WRITE differences.
12938 (print_space_trns_proc) Handles OUTFILE differences.
12940 * recode.c, sample.c: Comment fixes.
12942 * var.h: (struct print_trns) Changed boolean field `eject' to
12943 bitmapped field `options'; all references changed. New enums
12944 PRT_* for use with this field.
12946 * exception.h, test-exception.c: Removed.
12948 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
12950 * ascii.c: (delineate) Turned off debug output.
12952 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
12955 * data-in.c: (parse_string_as_format) Sets the entire string value
12956 to spaces, not just the short string part of it. Is this correct
12959 * data-out.c: (convert_date) Fixed DATETIME format problems with
12960 decimal places, removed debug code.
12962 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
12963 middle of parsing BEGIN DATA that would cause the lexer to read
12964 from a wild pointer `prog'; now calls new function
12965 preprocess_line() in lexer.c.
12967 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
12969 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
12970 Now call induce_segfault() to induce the segfault.
12971 (induce_segfault) New function.
12973 * expr-opt.c: Comment fix.
12974 (parse_sysvar) New function.
12975 (parse_primary) Added system variable support--calls
12977 (global var ops) Added OP_CASENUM operator.
12979 * expr.h: Comment fixes.
12980 (OP_* enum) added OP_CASENUM operator.
12981 (struct casenum_node) New struct.
12982 (union any_union_union) New member `cas' of type `casenum_node'.
12984 * glob.c: (global var last_vfm_invocation) New var.
12985 (init_glob) Initializes last_vfm_invocation.
12987 * lexer.c: (lookahead) Fixed reversed condition on if statement.
12989 * getline.c: (get_line) Split into get_line() and preprocess_line().
12990 (preprocess_line) New function.
12992 * var.h: Declares last_vfm_invocation.
12994 * vfm.c: (procedure) Sets last_vfm_invocation.
12996 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
12998 * command.c: (parse_cmd) Fixed bad assertion related to
13001 * data-in.c: (parse_month) Implemented to parse months according
13002 to full interpretation of standard.
13003 (to_roman) New function.
13004 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
13005 (parse_weekday) Bug fix (forgot to skip all the day name).
13007 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
13008 up parsing of multirecord data items. Also fixed user message.
13010 * data-out.c: Comment fix.
13011 (year2, year4, convert_date, convert_time, convert_WKDAY,
13012 convert_MONTH) New functions to support time & date output.
13013 (convert_format_to_string) Calls new time & date output routines.
13015 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
13017 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
13020 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
13022 * misc.c: (global var formats) Fixed declarations of DATETIME,
13025 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
13026 the output_char buffer.
13028 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
13029 memory bug. Fixed user messages.
13031 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
13033 * Removed #pragma argsused from lots of places.
13035 * data-in.c: Implemented zoned decimal and time-date formats.
13036 Untested. This is a huge chunk of code--maybe 1000 lines and 50
13039 * data-out.c: Implemented zoned decimal format.
13041 * expr.h: Moved yrmoda() declaration here from exprP.h.
13043 * misc.c: (global var formats) Minor fixes--added
13044 FCAT_SHIFT_DECIMAL to formats N and Z.
13045 (convert_fmt_ItoO) Added support for format Z.
13047 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
13049 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
13051 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
13052 som_check_workspace() that is activated between commands.
13054 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
13057 * list.q: (begin_row) Changed title expansion style from
13058 SOPT_X_VERT to SOPT_X_SHSP.
13060 * som-frnt.c: Now includes `somP.h'.
13061 (som_push_workspace, som_pop_workspace) New functions that, taken
13062 together, form a solution to the recursive table building problem
13063 mentioned yesterday. Surrounded every table output routine
13064 throughout the program with calls to these functions.
13065 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
13066 (som_create_table) Checks that there's an active workspace.
13067 (som_destroy_all_tables, som_crush) Removed.
13069 * som-high.c: (global var som_preserve_tables) Removed, all
13070 references deleted.
13071 (som_submit_table) Checks that there's an active workspace.
13072 (dump_columnated_table) Doesn't columnate tables that would have
13073 just one row per column.
13074 (dump_crush_page, som_dump_crush_page) Removed debugging code.
13075 (som_dump_crush_page) Moved row number labels from left side of
13076 tables to right side.
13077 (som_get_table_size) Added support for SOPT_X_SHSP.
13079 * som.h: New cell expansion type SOPT_X_SHSP.
13081 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
13083 (global var curtab_arena) Moved from som-frnt.c.
13085 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
13087 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
13088 that causes bad location warnings to be suppressed.
13089 (delineate) Saves current font when calling draw_text(); fixed
13090 handling of NULLs when backing up. Also fixed line-wrapping bug.
13092 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
13093 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
13095 * common.c: Added code to cause assertion failure to dump core
13096 when run under Checker.
13098 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
13099 there are still bugs.
13101 * glob.c: (__eprintf) Removed.
13103 * list.q: Inserted som_preserve_tables kluge that prevents tables
13104 from being thrown away due to recursive table building through
13105 som_output_line being called from a transformation during the LIST
13106 procedure invocation. This is a general problem that must be
13107 solved in a better way since it applies to all procedures in
13109 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
13110 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
13112 * numeric.c: Fixed several errors in the form of msg() calls.
13114 * print.c: Updated for use of som.
13115 (dump_table) Reimplemented.
13116 (print_trns_proc) Calls som_eject_page() instead of eject_page().
13117 Calls som_output_text() instead of outs_line().
13119 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
13121 (som_output_text) Function moved from som-low.c. Interface
13124 * som-high.c: (som_preserve_tables) New global public variable
13126 (som_submit_table) Destroys the tables only if som_preserve_tables
13128 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
13129 one subrow per row. Now labels subrows if there's more than one
13131 (dump_crush_table) Added wishlist comment.
13132 (som_eject_page) New public function declared in som.h.
13134 * som-low.c: (som_dump_crush_page) Draws row labels if there's
13135 more than one subrow per row.
13136 (som_output_text) Moved to som-frnt.c.
13138 * som.h: (SOM_TOPT_PRESERVE) Removed.
13140 * title.c: (get_title) Changed interface.
13141 (cmd_title) Changed `title' to `outp_title'.
13142 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
13144 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
13146 * list.q: (flush_table) Conforms to new partial options in
13147 som_submission_form.
13149 * som-high.c: (paginate_horizontally) Changed form of subrow
13151 (build_target) Omits spacing before table if
13152 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
13153 (dump_crush_page) Changed interface. Only trims bottom rule if
13154 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
13155 (dump_crush_table) Handles partial tables.
13156 (output_row_label) New function.
13157 (som_dump_crush_page) Emits subrow number labels. Draws vertical
13158 rule on the right edge of narrow subrows.
13160 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
13161 constants to a series of SOM_TOPT_PARTIAL_* submission options.
13162 All references updated.
13164 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
13166 * misc.c: Comment fix.
13168 * som-high.c: (examine_table) Treats crushed tables separates for
13169 purpose of determining header size.
13170 (paginate_horizontally) Allots space for line numbers in crushed
13171 tables with lots of subrows per row. Calculates the `maximum page
13172 width', the width of the widest horizontal page.
13173 (build_target) Removed trim argument; all references changed.
13174 Stricter assertions. (dump_crush_page) New function.
13175 (dump_crush_table) Reimplemented.
13177 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
13178 (som_dump_crush_page) Reimplemented, interface changed.
13180 * somP.h: Many many new helper macros for use with crushed tables.
13181 (global var som) Removed `tv', `cum_y' members; all references
13182 removed. New members `mpw', `digit_space'.
13184 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
13186 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
13187 variable, changed to constant 1024.
13188 (arena_ca_strdup) Changed `sizeof(a_string)' to
13189 `sizeof(c_string)'.
13190 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
13191 `(c_string *)' to `(char *)'; this fixed some offset problems.
13193 * filename.c: (readlink_malloc) Changed initial allocation from
13195 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
13198 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
13199 &fm->owner in several places.
13201 * som-high.c: (output_table) Changed interface to rest of world.
13202 (examine_crush_table) Removed. Crushed tables are re-broken now,
13203 in preparation for rewrite.
13205 * som.h: Comment fix.
13207 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
13209 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
13210 itself in the cleanup stage.
13212 * descript.q: (display) At least temporarily, changed the table
13213 format to a crushed table.
13215 * list.q: (begin_row) At least temporarily, added horizontal lines
13218 * som-high.c: (examine_crush_table) Sets som.hh to the width of
13219 the horizontal "headers," that is, to the width of the far left
13220 and far right rules.
13221 (justify_pagination) Sets som.th to the width of the widest row
13222 in the crushed table. Fixed inner loop off-by-one error.
13224 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
13227 * somP.h: Comment fix.
13229 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
13231 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
13232 before closing it; also, opens the constructed filename `s'
13233 instead of f->filename.
13235 * postscript.c: Moved initialization of x->loaded, x->prop,
13236 x->fixed, x->current, also the add_encoding() calls, into
13238 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
13239 sets x->last_font to NULL; sets x->next_combo to zero.
13241 * som-high.c: (crushed_row_height) Moved definition farther up.
13242 (som_submit_table) Doesn't calculate line width, font size until
13243 after calling open_page(), to accomodate changes to PostScript
13245 (vert_headers) Removed; equivalent functionality moved to
13246 examine_table(), examine_crush_table().
13247 (justify_pagination) Replaced with different algorithm.
13248 (dump_crush_table) Bugfix that caused tables to fail to be clipped
13249 at the bottom of the page.
13251 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
13253 * command.c: Added cmd_list back into cmd_table.
13255 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
13256 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
13258 * list.q: (flush_table) Updated to new som_submission_form format.
13260 * som-frnt.c: Comment fix.
13262 * som-high.c: Changed `#endif' to `#undef EXTERN'.
13263 (output_table) Calls som_get_table_size() directly; handles
13265 (examine_crush_table) New function; calls vert_headers().
13266 (examine_table) Moved some code into new function, vert_headers().
13267 (justify_pagination) New function.
13268 (dump_plain_table) Removed `static' from `cy'.
13269 (dump_crush_table) New function.
13271 * som-low.c: (som_dump_crush_page) New function.
13273 * som.h: Comment fixes.
13274 (enum SOM_TOPT_CRUSH) New.
13275 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
13276 Temporarily set to zero to make do with LIST procedure.
13278 * somP.h: Re-ordering.
13280 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
13282 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
13284 * somP.h: New file for use by som-high.c, som-low.c.
13286 * q2c.c: Added definition for VME.
13287 (get_line) Now dumps `!' comment lines to the output file
13290 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
13291 set.q: Changed format of `!' comment lines.
13293 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
13295 * All source files: Added copyright notice.
13297 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
13298 longs in msg() calls.
13300 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
13302 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
13304 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
13306 * output.c: (outp_read_devices) Changed criteria for
13307 distinguishing different types of lines.
13309 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
13311 * cmdline.c: Changed syntax message.
13313 * filename.c: (good_getcwd) Bug fix (?).
13314 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
13316 (search_path) Appends DIR_SEPARATOR to directory name only if it
13317 does not already end with one.
13319 * glob.c: Checks STAT_PAGER envvar before PAGER.
13321 * output.c: Checks environment variables instead of just local
13324 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
13326 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
13327 when the pointer passed to the function was within the arena
13328 itself, so that it couldn't properly be set to NULL _after the
13331 * command.c: Re-enabled DISPLAY.
13333 * display.c: Rewritten to handle tables. Untested.
13335 * filename.c: (search_path) Fixed memory leak.
13337 * frequencies.q: (cmd_frequencies) Frees v_variables.
13338 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
13339 (cleanup_freq_tab) New function to garbage collect.
13340 (dump_full) Elegantized.
13342 * main.c: New comment.
13344 * output.h: New tag for tagged quotes: TAG_NEWLINE.
13346 * postscript.c: Comment fix.
13347 (release_fontmap, free_font_entry) New functions.
13348 (ps_init_driver) Sets free_font_entry() as the freefunc for
13349 hashtable `loaded'. Calls release_fontmap() when destroying a
13350 driver; also frees the output filename; also frees the
13351 ps_driver_ext block.
13352 (free_ps_encoding) Frees the filename as well as the encoding
13354 (output_encodings) Frees the line buffer and pops the msg-filename
13356 (read_fontmap) Frees the fontmap filename and the line buffer.
13357 (postopen, preclose) Misc. garbage collection fixes.
13358 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
13359 to NULL; this fixes some output problems.
13360 (text) Handles TAG_NEWLINE. Untested.
13362 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
13363 (som_set_string) Removed. All references changed to
13365 (som_set_text) Rewritten. New interface. More general.
13367 * som.h: Minor format changes.
13368 (struct som_value_cell) Removed; all references changed to
13370 (enums SOT_*) Changed.
13372 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
13374 * command.c: Re-enabled SPLIT FILE.
13376 * postscript.c: Comment fix.
13378 * som.h: Added `SOT_NONE'.
13380 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
13382 * vfm.c: (dump_splits) Reimplemented.
13384 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
13386 * Compiled the project under gcc 2.7.2, which gave some new
13387 warnings. This led to many additions of casts from unsigned to
13388 int sprinkled throughout the code.
13390 * arena.c: Many uses of `unsigned' changed to `size_t'.
13392 * command.c: Added END FILE, END REPEAT to command table.
13393 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
13394 (find_command, FILE_TYPE_okay) Not commented out anymore.
13395 (parse_cmd) Calls FILE_TYPE_okay again.
13396 (output_line) Added calls to som_output_text() to put the line
13397 in the output files.
13399 * common.c: (macro VME) Format changes.
13400 (xstrdup) Asserts that its argument is not NULL.
13402 * data-list.c: Implemented dump_fixed_table().
13404 * inpt-pgm.c: Formatting changes. Comment changes.
13405 (end_case_proc) Renamed end_case_trns_proc.
13406 (cmd_end_file, end_file_trns_proc) New functions.
13408 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
13410 * misc.h: (local_strdup) New macro corresponding to strdup() but
13411 allocating its data through local_alloc() if possible--that is, if
13414 * postscript.c: Comment changes.
13415 (quote_ps_name, quote_ps_string, output_encodings) New functions.
13416 (output_line, add_string) New macros supporting
13417 output_encodings().
13418 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
13419 substitution vars. Calls output_encodings() when a line
13420 consisting of `!encodings' is encountered.
13421 (preclose) Some code moved into quote_ps_string().
13422 (dump_line) Changed into macro supporting dump_fancy_line().
13423 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
13424 command when appropriate.
13425 (write_text) Fixed `literal_char' array (I think it's fixed, at
13427 (text) Fixed bug when width was zero. Now exits immediately on
13428 zero height_left. Now, when executing `goto restart;', checks
13429 that cp<end, so that we don't read beyond end-of-string. Also,
13430 outputs the correct code to the output file by outputting the code
13431 from the metric instead of the internal metric index.
13433 * repeat.c: (cmd_end_repeat) New function.
13435 * som.c: (var som) `headers' renamed `options' and semantics
13436 changed. All references changed.
13437 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
13438 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
13440 (som_text_table) Removed.
13441 (som_output_text) New function.
13443 * som.h: (struct som_submission_form) Removed `header', `reuse',
13444 replaced with bitmapped field `options'.
13445 (SOM_TOPT_*) New enum set for som_submission_form.options.
13446 (SOT_*) New enum set for som_output_text().
13448 * temporary.c: (copy_variable) When copying the var label, only
13449 calls xstrdup() if it's non-NULL.
13451 * var.h: (enum type `vartype') Removed; all references changed to
13454 * vars-atr.c: (init_variable) Changed local var `nbytes' from
13457 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
13459 * font.h: Comment changes.
13461 * groff-font.c: (groff_read_font) Initializes `name' field to
13462 NULL. Handles `encoding' field.
13464 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
13466 * postscript.c: (struct font_entry) Removed `position' field.
13467 (struct ps_font_combo) New struct.
13468 (struct ps_driver_ext) Removed field `next_position'. New fields
13469 `combos', `next_combo'. `last_font' field changed from
13470 `font_entry *' to `ps_font_combo *'.
13471 (ps_init_driver) Reformatted; handles new fields. When
13472 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
13474 (get_encoding, find_encoding_file) New functions.
13475 (add_encoding) Some code moved out into find_encoding_file().
13476 (postopen) Changed value for ${title}.
13477 (preclose) Sets `loaded' field to NULL after destroying the hash
13479 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
13481 (ps_text_set_font_by_position) Figures out the current family if
13483 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
13484 (switch_font) Implemented.
13485 (write_text) Calls switch_font() more often. Format changes.
13486 #undefs its macros after they're no longer useful.
13487 (text) Changed `continue' at one point to a jump to the top of the
13488 loop because we don't want `separate' reset to 0 at that point.
13489 (load_font) No longer sets `position' in the font_entry created.
13491 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
13493 * font.h: (struct font_desc) New member `encoding', which is not
13494 properly handled yet.
13496 * glob.c: (init_glob) Some new i18n code, which is probably
13499 * output.c: (outp_read_devices, outp_get_paper_size) Changed
13500 `size' local from `int' to `size_t'.
13502 * postscript.c: New driver configuration parameter `auto-encode'.
13503 New enums OPO_AUTO_ENCODE, ODA_COUNT.
13504 (struct font_entry) New member `position'.
13505 (struct ps_driver_ext) Reordered. New hash table member
13506 `encodings'; new members `next_position', `next_encoding',
13507 `last_font'. Members `current', `prop', `fixed' changed from type
13508 `font_desc *' to `font_entry *'; all references changed.
13509 (struct ps_encoding) New struct.
13510 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
13511 free_ps_encoding, add_encoding) New functions.
13512 (ps_init_driver) Added OPO_AUTO_ENCODE to default
13513 x->output_options. Initializes new members of ps_driver_ext.
13514 Changed default value for prologue_fn, encoding_fn. Calls
13515 read_ps_encodings after loading default fonts.
13516 (option_tab[], ps_option) Handle new configuration parameter.
13517 (switch_font) New function.
13518 (struct output_char) `font' member changed from `font_desc *' to
13519 `font_entry *'. New member `separate'.
13520 (read_fontmap) Changed `size' from `int' to `size_t'.
13521 (output_line, put_number) New macros for write_text().
13522 (write_text) Optimizes text output by consolidating multiple
13523 calls to PostScript `show' operator.
13524 (text) Keeps track of when text arguments can't be consolidated by
13525 write_text(), and marks those spots in the output stream.
13526 (load_font) Sets `position' of the allocated font_entry to -1, cuz
13527 the font hasn't been switched to by switch_font(), which is where
13528 the position is important--the PostScript is what cares about the
13531 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
13533 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
13534 call a NULL free_func.
13535 (hsh_rehash) Elegantized.
13536 (hsh_probe) Fix bug that manifested when the table was expanded
13537 and thus had to change location in memory. Good thing
13538 too--otherwise could have been much more subtle.
13539 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
13540 (hsh_foreach) New function for hash table iteration.
13542 * hash.h: (struct hsh_iterator) New.
13544 * lexer.c: (parse_tagged_quote) Font and family name strings in
13545 tags are now null-terminated.
13547 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
13549 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
13550 documented. (Never before tested?)
13552 * output.h: Comment changes.
13554 * postscript.c: New driver options `optimize-text-size',
13555 `optimize-line-size', `max-fonts-simult'. New enum set for
13556 specing cached line types. Comment fixes.
13557 (struct line_form) New struct.
13558 (struct ps_driver_struct) New members `text_opt', `line_opt',
13559 `max_fonts', `lines'.
13560 (ps_init_driver) Initializes new members of ps_driver_struct.
13561 (user option type enum set) New member `nonneg_int_arg'.
13562 (static var option_tab[]) Supports new options.
13563 (ps_option) Handles new options.
13564 (find_ps_file) Made static. No longer calls hsh_dump().
13565 (ps_get_var) Made static.
13566 (preclose) Dumps out proper DSC trailer.
13567 (ps_open_page) Elegantized.
13568 (ps_close_page) Calls dump_lines() if appropriate.
13569 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
13570 wrappers around line().
13571 (int_2_compare, compare_line, dump_line, dump_fancy_line,
13572 dump_lines, hash_line, free_line, line) New functions for support
13574 (write_text, text) Made static.
13575 (text) Added to font support, not finished.
13577 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
13579 * font.h: (struct font_desc) New members ascent, descent.
13581 * groff-font.c: (groff_read_font) Calculates font ascent and
13582 descent from the ascent and descent of the `d' and `p' characters,
13583 respectively, as per a suggestion on comp.fonts.
13585 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
13586 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
13588 (write_text) Handles text right-justification and centering (not
13589 full justification). Still very inefficient. (One output line
13591 (struct output_char) Added fields for font and font size.
13592 (text) Many bugfixes.
13594 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
13596 * cmdline.c: (usage) Calls outp_list_classes().
13598 * font.h: Comment fix.
13600 * groff-font.c: New exported global var `space_index'.
13601 (groff_init) New function to initialize `space_index'.
13602 (hash_kern) Casts result to unsigned.
13603 (font_name_to_index) Renamed font_char_name_to_index. All
13604 references changed. Also, now returns the value of `space_index'
13605 when passed an ASCII space character as an argument. Fixed
13607 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
13608 Handles passed NULL pointers properly.
13610 * lexer.c: (parse_tagged_quote) Comment fix. Better range
13613 * output.c: (outp_list_drivers) Removed. Removed all references.
13615 * output.h: Comment fixes.
13617 * postscript.c: (ps_open_global) Calls groff_init().
13618 (output_char) New structure.
13619 (write_text) New function.
13620 (text) No longer stubbed out! Now the output is correct--with a
13621 few exceptions, one of them being that the page has to be held
13622 upside down into a mirror.
13624 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
13626 * font.h: Comment fix.
13628 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
13629 All callers changed.
13630 (number_to_index) Renamed font_number_to_index, made extern. All
13632 (font_get_kern_adjust, font_get_char_metrics) New functions.
13634 * output.h: New constant OUTP_T_INTERNAL_DRAW.
13636 * postscript.c: Changed default line width back to 1/2 point.
13637 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
13638 in the center of the space allotted for them, not just a fixed
13639 offset from the edge of the space; this fixes some bugs.
13640 (ps_line_intersection) Now supports all command line styles.
13641 (ps_text_get_size) Bug fix in computation of em width.
13642 (text) New function, the meat behind ps_text_metrics and
13643 ps_text_draw. Not complete.
13644 (ps_text_metrics, ps_text_draw) Removed the stub taken from
13645 ascii.c; call text().
13647 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
13649 * arena.c: (arena_free) Assert that the argument is non-NULL.
13651 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
13652 only if old_kern is non-NULL.
13654 * postscript.c: (ps_init_driver) Changed default line width to 1
13656 (postopen) New prologue variables.
13657 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
13658 more of the common line styles properly, but not all.
13659 (ps_text_metrics) Fixed problem with this stubbed out version that
13660 kept it from taking font sizes into account.
13662 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
13664 * arena.c: (arena_malloc) Bug fix.
13665 (arena_dump) [GLOBAL_DEBUGGING] New function.
13667 * ascii.c: Comment fix.
13668 (count_fancy_chars, delineate) Now static functions.
13670 * filename.c: (interp_vars) Bug fixes.
13672 * font.h: Comment fixes.
13674 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
13675 beginning in case we have an error message to display before
13676 initializing the display.
13678 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
13680 (groff_read_font) Bug fixes.
13681 (name_to_index) Increments hash.used. Sets `name' field of hash
13683 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
13685 * hash.c: Return type changed.
13687 * postscript.c: Continued development. Now marks lines on the
13688 paper, but very buggy.
13690 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
13692 * Changed comments in many source files from `/* xxx /* yyy */' to
13693 `/* xxx */ /* yyy */' for cleanliness.
13695 * arena.c: (arena_sd_strdup) New function.
13697 * ascii.c: (struct ascii_driver_ext) New member `file'.
13698 (ascii_init_driver) Fills out member `file' for initing; uses
13699 close_file_ext for closing drivers.
13700 (ascii_option) Changed %.*s back to %s because the a_string's are
13701 always null-terminated.
13702 (postopen, preclose) New functions.
13703 (ascii_open_page) Uses new style of open_file_ext.
13704 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
13705 instead of this->output.
13706 (__assert_fail) Removed.
13708 * cmdline.c: Changed syntax_message[].
13710 * error.c: #include's <readline/history.h> only if the history
13711 library is available, not if just the readline library is
13714 * filename.c: (expand_line) Removed alloca() support.
13715 (interp_vars) No longer tilde-expands argument. Limit on output
13717 (tilde_expand) Now treats argument as path rather than filename.
13718 [!unix] Now is a no-op function.
13719 (search_path) Better verbose message formatting.
13720 (open_file, close_file) Comment fixes.
13721 (close_file) [!unix] Doesn't bother with pipes.
13722 (open_file_ext) Completely rewritten, interface revamped.
13723 (close_file_ext) New function.
13725 * font.h: Comment changes.
13727 * frequencies.q: Removed AIX alloca support since it doesn't use
13730 * hash.c: Comment changes & additions.
13731 (hsh_create) Initializes entire table instead of first M entries.
13732 (hsh_probe) Stupid bug fixed. Now it works.
13733 (hsh_dump) [GLOBAL_DEBUGGING] New function.
13735 * main.c: (parse) Detects EOF properly in token-eating loop.
13736 Should the STOP token have its value changed to 0?
13738 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
13739 (blp_getline) Now it's a macro.
13741 * output.h: (struct outp_driver) Removed members output, filename.
13743 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
13744 drivers in driver table.
13745 (outp_read_devices) Frees buf. Warns if there are no active
13747 (outp_configure_clear) Sets outp_configure_vec to NULL after
13748 deleting its elements.
13749 (configure_driver, destroy_driver) Removed references to output,
13750 filename members of outp_driver.
13751 (outp_evaluate_dimension, internal_get_paper_size,
13752 outp_get_paper_size) New functions.
13754 * postscript.c: Continued development. Now links but doesn't make
13755 any marks on the page. Lotsa bugs I suppose.
13757 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
13759 * str.h: Comment changes.
13761 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
13763 * Removed dependencies on non-nested comments in several files.
13764 Also removed references to (unix || __unix__) in #if's since
13765 prefh.orig makes those two equivalent.
13767 * ascii.c: (ascii_open_global) Creates ascii_arena.
13768 (ascii_close_global) Destroys ascii_arena.
13769 (ascii_init_driver) Doesn't create ascii_arena.
13770 (ascii_copy_driver) Removed.
13771 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
13772 (outp_class ascii_class) Removed ascii_copy_driver reference.
13774 * frequencies.q: Now can display all statistics except median.
13775 Still not finished.
13777 * output.c: Handles outp_class.ref_count so output class
13778 destructors are called properly.
13779 (add_class) Sets ref_count to 0.
13780 (configure_driver) Initializes class if ref_count++ is 0.
13781 (destroy_driver) Destructs class if --ref_count is 0. Frees the
13782 class output file name.
13784 * output.h: (struct outp_class) Removed copy_driver, inited.
13787 * postscript.c: Completely replaced but not finished.
13789 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
13791 * approx.h: #includes <float.h>.
13793 * arena.h, arena.c: Many functions changed to take an arena **
13794 instead of an arena *, for consistency. All callers changed.
13795 (arena_alloc) Now creates a new arena if passed *A that is NULL.
13796 (arena_destroy) Sets *A to NULL.
13798 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
13799 assertion that `width' be positive.
13801 * command.c: Removed #if's from cmd_table.
13802 (walk_cmdtable_func) [0] New function (debug code).
13803 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
13804 (parse_cmd) Doesn't return failure for unimplemented commands.
13806 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
13807 (SYSCODE) New constant macro.
13809 * descript.q: Checks for positive n_variables before performing
13812 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
13813 avl_find instead of &fp as arg 2.
13815 * frequencies.g, frequencies.q: Continued updating; now compiles &
13816 works again, but not complete.
13818 * main.c: Changes to user messages.
13820 * misc.c: (reverse) [0] New function.
13822 * settings.h: Comment removed. #includes "common.h".
13824 * som.c: (som_set_null) New function.
13825 (som_set_value, som_set_string, som_set_text) More detailing
13827 (som_set_float) Implemented function.
13828 (dump_columnated_table) Bug fix regarding page breaks.
13829 (draw_cell) Bug fix regarding text that spilled out of a cell.
13830 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
13832 (get_cell_size) Support SCON_EMPTY cells.
13833 (get_table_size) When calculating rules' widths and heights, mask
13834 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
13836 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
13838 (struct som_submission_form) New member `header'; all users
13841 * val-labs.c: (get_label) User messages changed.
13843 * var.h: Changed FREQUENCIES structures.
13845 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
13848 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
13850 * approx.h: Definition of EPSILON now depends on system's
13851 DBL_EPSILON. Removed GNU C specific code.
13852 (cmpapx) Renamed approx_compare.
13854 * frequencies.g, frequencies.q: Continued updating; still doesn't
13857 * groff-font.c: (name_to_index) Fix bug that kept it from
13860 * hash.c, hash.h: Completed work.
13862 * var.h: Changes to freq_tab, frequencies_proc.
13864 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
13867 * hash.c, hash.h: New files. Not completed.
13868 * Makefile.am: Added hash.c to source file list.
13869 * font.h: (struct font_desc) New member kern_size_p.
13870 * groff-font.c: Uses hash.h.
13871 (hashpjw) Moved to hash.c.
13872 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
13874 (static var hash) New member size_p.
13875 * var.h: Includes hash.h.
13876 (struct freq_tab) Changed AVL_TREE to hash_tab.
13878 * vars-prs.c: Comment, formatting fixes.
13880 * frequencies.g, frequencies.q: Continued updating. Not yet
13883 * formats.c: Bug fix.
13885 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
13887 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
13888 * descript.g: Comment fixes.
13889 * descript.q: Comment fixes. Moved some declarations into var.h.
13890 Made dsc_info a static table. Updated FIXMEs.
13891 (internal_cmd_descriptives) Beautified.
13893 * frequencies.q: Started updating into working order.
13894 * frequencies.g: New file analogous to descript.g.
13895 * var.h: Comment fixes. Added structures for FREQUENCIES.
13897 * som.c: Removed vestiges of crushing and partial table support.
13899 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
13901 * Many more changes to som.c especially, but these will not be
13902 documented as I have resolved to remove them. This patchlevel is
13903 being released solely so that I can fall back to it if I decide
13904 that removing the changes is not a good idea.
13906 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
13908 * som.c: (global var som) New member `cum_y'.
13909 (build_target) Properly handles titles for partial tables.
13910 (dump_partial_beg, dump_partial_mid, dump_partial_end)
13911 Merged into single new function dump_partial(). Fixed problem
13912 with titles on partial tables.
13913 (dump_table) Calls dump_partial() for all parts of partial tables.
13914 (dump_page) Criteria for drawing title changed.
13916 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
13918 * command.c: (cmd_table) Added LIST, WEIGHT.
13920 * command.c: (cmd_remark) No longer frees `s' since it's not
13921 dynamically allocated.
13923 * data-out.c: (convert_f) Now correctly handles the case where
13924 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
13925 number of decimals.
13926 (som_destroy_all_tables) Removed argument. All callers changed.
13927 (som_vline, som_hline) Argument validity checking corrected.
13928 (som_set_value) Implemented half-heartedly.
13929 (replicate_table) Copies tables piece-by-piece when using Checker.
13931 * som.h: New line style SLIN_1THIN, currently equivalent to
13932 SLIN_0. New enum set SOM_SUB_*.
13933 (struct som_submission_form) Removed `seq_no'. Added `type'.
13935 * list.q: Newly working file; uses partial tables.
13937 * som.c: (som_reduce_table) Renamed som_set_table_height().
13938 (som_crush) Removed argument `group'.
13939 (global var som) Removed `nt', `seq_no'. Added `type'.
13940 (som_submit_table) Arguments changed.
13941 (output_table) Removed partial table code.
13942 (build_target) New arg; partial table support added. All callers
13944 (dump_plain_table) Removed partial table code.
13945 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
13946 (dump_table) Supports partial tables.
13947 (dump_page) New argument to allow not drawing top and/or bottom
13948 headers. All callers changed. Supports partial tables.
13950 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
13952 * data-out.c: Changed `#include <approx.h>' to `#include
13954 (convert_F) Comment fix. Now won't print `-.000', etc.
13956 * descript.q: Now Z-scores work, although there appears to
13957 be a bug (which might actually be in data-out.c:convert_F()).
13958 (descriptives_trns_proc, descriptives_trns_free) New functions.
13959 (run_z_pass) Implemented.
13961 * var.h: Comment fixes.
13962 (dsc_z_score, descriptives_trns) New structs.
13963 (descriptives_trns) Added to any_trns as `dsc'.
13965 * error.c, error.h: New error class, IS (Installation Script
13966 error), used in those instances where the error is in the
13967 installation, but there is a script file or installation file that
13968 can be usefully referred to.
13970 * output.c: Change many IE classes to IS classes.
13972 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
13973 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
13974 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
13975 include the corresponding header?
13977 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
13978 Don't bail out if termcap can't be read.
13980 * som.c: (som_destroy_table) Removed.
13981 (som_reduce_table, som_destroy_all_tables) New functions.
13982 (som_crush) New function, not implemented.
13984 * som.h: New table option STAB_CRUSH. Comment fix. New struct
13985 som_submission_form. Function prototypes revised.
13987 Outputting huge tables (1000s of rows) a few rows at a time
13988 is supported, though untested. May even break everything.
13989 Actually, the code doesn't even compile right now.
13990 * som.c: (struct som) New fields htv, nt, seq_no.
13991 (som_submit_table) Multiple arguments changed to a single
13992 pointer to struct submission_form. Only increments subtable_num
13993 if seq_no is zero. Only destroys table if it's not going to
13995 (replicate_table) New function.
13996 (output_table) Comment fix.
13997 (examine_table) Changed inline code to code calling
13998 replicate_table(). Calculates htv. Supports partial tables.
13999 (draw_title) Removed comment.
14000 (build_target) Only allows for title on first part of partial
14002 (dump_plain_table) Only resets table chunk number on first part
14003 of partial tables; FIXME: doesn't work quite right. Supports
14005 (dump_page) Titles only on first part of partial tables.
14007 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
14009 * Thanks to an unreliable IDE hard drive, I have spent the last
14010 day reconstructing my Debian GNU/Linux installation and redoing
14011 the previous day's changes--somehow I managed to save every file
14012 except for output.c and output.h. So the following changes could
14013 really be considered independent of the output.c, output.h changes
14016 * output.h, output.c: Moved the outp_configure_vec global var,
14017 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
14018 outp_configure_vec is now static.
14020 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
14022 * The entire philosophy behind configuration of the output drivers
14023 changed. Now there is a termcap-type configuration where drivers
14024 to be read are determined beforehand, rather than parsing the
14025 entire output init file and storing it in memory & deciding what
14026 to actually use later. Faster & more memory-efficient at the same
14029 * output.c: Comment fix. Removed outp_init_drivers global var.
14030 Removed all references to synonyms. New structure outp_defn. New
14031 global vars outp_macros, outp_configure_vec.
14032 (search_name, delete_name, add_name, check_configure_vec,
14033 expand_name, find_defn_value) New static functions.
14034 (outp_configure_clear, outp_configure_add, outp_configure_macro,
14035 outp_read_devices) New extern functions.
14036 (outp_init) Much functionality moved into outp_read_devices.
14037 (outp_read_devices) Format of output init file changed; name of
14038 file is `devices' rather than `output' to avoid Makefile
14040 (outp_clear) Renamed outp_done.
14041 (outp_list_classes) Bug fix, cleaned up.
14042 (outp_list_drivers) Not implemented anymore.
14043 (outp_configure_driver) Now a static function; simplified; now
14044 interpolates macros; supports new structure.
14045 (outp_enable_driver, match_synonym) Removed; all references
14047 (find_driver) First argument removed.
14049 * output.h: Global var outp_init_drivers removed; new structure
14050 outp_names; new enum set OUTP_S_*; new global var
14051 outp_configure_vec; function prototypes for output.c exports
14054 * main.c: (main) Calls outp_read_devices() after parsing the
14057 * cmdline.c: (parse_command_line) New option -v --verbose;
14058 --version changed to -V. --device option changed syntax to just
14059 take a single device name. Accepts key=value declaration of
14060 output init file macros. Syntax message updated.
14062 * filename.c: (expand_line) New function.
14063 (interp_environ_vars) Renamed interp_vars; no longer uses
14065 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
14066 overridden by real environment vars.
14067 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
14068 * filename.h: interp_environ_vars() renamed interp_vars().
14070 * error.c, error.h: Added extern variable `verbosity', message
14073 * error.c: (vmsg) Support message class MM.
14074 (verbose_msg) New function.
14076 * descript.q: (generate_z_varname) Bug fix in generation of
14078 (dump_z_table) Bug fix in column headers.
14080 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
14081 page from 29 to 15. Don't set a default for ops[OPS_INIT,
14082 OPS_DONE]. Writes the uninit string when the driver is closed.
14083 (ascii_open_page) Write the init string before the first page.
14084 (output_shorts) Form of main loop changed from `while' to `for'.
14085 Bug fix with overstrikes: the character is printed *after* the
14086 backspace. Eliminated a lot of `& 0xff' modifiers.
14087 (advance_to_left_margin) New function.
14088 (return_carriage, output_lines) Handle left margin.
14090 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
14092 * ascii.c: New option `carriage-return-style'.
14094 * ascii.c: (count_fancy_chars) New function.
14095 (delineate, text_metrics) Use new function; bug fixes regarding
14097 (text_draw) Bug fix with rich text.
14098 (output_string, output_shorts) Reordered.
14099 (output_shorts) Now handles boxchars and some overstrike font
14101 (output_char, return_carriage) New functions.
14102 (output_lines) Now handles overstriking and font changes properly;
14103 some code moved to output_shorts.
14105 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
14108 * ascii.c: New member `debug' in ascii_driver_ext.
14109 (ascii_init_driver, delineate) Uses new member.
14111 Now you can set a vertical height on writing text.
14112 * ascii.c: (delineate) Keeps track of vertical position.
14113 (text_draw) No longer considers fully justified text an internal
14116 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
14118 Tables' titles are drawn; they can have variable height.
14119 * som.c: `som' struct has new member, title_height.
14120 (draw_title) New argument. Moved within file. All caller
14122 (build_target) New argument, amount of space needed for first row.
14123 Calculates height of title, takes that into account. All callers
14125 (dump_plain_table, dump_columnated_table) Took calculation of y1,
14127 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
14129 (dump_columnated_table) Organized for readability.
14130 (dump_page) Makes use of som.title_height.
14132 * som.c: Many comment bug fixes.
14134 * descript.q: (try_name, generate_z_name) Bug fix regarding
14135 generation of Z-score variable names.
14136 * var.h: Removed num from descriptives_proc; all referents removed.
14138 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
14140 * ascii.c: (ascii_line_horz, ascii_line_vert,
14141 ascii_line_intersection) Added debugging code.
14143 Added a descriptive line above each table to describe it.
14144 * command.c: (parse_cmd) Calls som_new_series.
14146 * som.c: New static vars table_num, subtable_num. New `som'
14148 (dump_page) New arguments.
14149 (som_submit_table) Handle new variables.
14151 * som.c, som.h: (som_submit_table) New arguments. All callers
14153 (som_new_series) New function.
14154 (build_target) Makes room for extra line.
14155 (draw_title) New function.
14156 (dump_page) Calls draw_title. Bug fix: doesn't always set
14159 Columnation of tables support.
14160 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
14162 * som.c: Deleted references to fr, lr, ri.
14163 (som_columnate) Bux fix: sets group member of table.
14164 (som_add_options) Function removed.
14165 (dump_table) Split into three functions; extensively reworked.
14167 * descript.q: (dump_z_table) Better output table formatting; added
14168 title support to correspond to som.h changes.
14169 (display) Title support.
14171 * output.h: Added OUTP_T_NONE.
14173 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
14175 * descript.q: Improved handling of Z scores; still not perfect.
14177 * output.h, ascii.c: Added hook for getting em width of current
14180 * som.c: Uses new em-width hook. Added debugging code to
14182 (som_columnate) New argument.
14183 (som_add_options) Removed.
14185 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
14187 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
14188 rules as a property of the table instead of as a property of the
14191 * ascii.c: Added `header' to table of options.
14193 * descript.q: Added even shorter statistic names; modified to work
14194 with new som interface.
14196 * misc.c (blp_getdelim): Bug fix.
14198 * version.c: includes 'conf.h'.
14200 ----------------------------------------------------------------------
14203 version-control: never
projects / pspp-builds.git / blob