1 Fri Nov 4 19:43:01 2005 Ben Pfaff <blp@gnu.org>
3 * recode.c: Rewrote whole file, as clean-up.
5 Fri Nov 4 19:37:50 2005 Ben Pfaff <blp@gnu.org>
7 * pool.c: Don't make alignment exception for x86.
8 (pool_alloc) Return null for 0-size blocks.
9 (pool_alloc_unaligned) New function.
10 (pool_strndup) Removed. Changed callers to use pool_clone_unaligned().
11 (pool_clone_unaligned) New function.
12 (pool_strdup) Use pool_clone_unaligned().
14 * var.h: (enum var_type) Give the NUMERIC, ALPHA enum this name.
15 (struct variable) Use `enum var_type' for `type'.
17 * vars-atr.c: (var_type_adj) New function.
18 (var_type_noun) New function.
20 * vars-prs: (parse_mixed_vars) Fix freeing code.
21 (parse_mixed_vars_pool) New function.
23 Wed Nov 2 21:24:48 2005 Ben Pfaff <blp@gnu.org>
25 * file-handle-def.c: Needed another #include, to avoid missing
28 * file-handle.q: (cmd_file_handle) Declarations must precede
29 statements. Free parse data on success as well as on failure, to
32 * get.c: (parse_write_command) Destroy dict on success, to avoid
35 * data-list.c: (cmd_repeating_data) Fix usage of saw_occurs,
36 saw_length, saw_continued, saw_id, which were boolean but
37 incorrectly treated as bitmaps as result of a previous
38 half-finished cleanup.
40 * weight.c: (struct weight_trns) Unused, so removed.
42 * Makefile.am: Add range-prs.h to sources.
44 Wed Nov 2 21:24:15 2005 Ben Pfaff <blp@gnu.org>
48 * Makefile.am: Add ctl-stack.c, ctl-stack.h to source files.
49 Reformat source file list to list one file per file, so that
50 patches for future changes will be easier to read.
52 * ctl-stack.c, ctl-stack.h: New files.
54 * do-if.c: Rewrote whole file.
58 * loop.c: Rewrote whole file.
60 * glob.c: (global var ctl_stack) Move into ctl-stack.c.
62 * temporary.c: (cmd_temporary) Use ctl_stack_is_empty().
64 * vfm.c: (open_active_file) Use ctl_stack_clear().
66 Wed Nov 2 21:18:13 2005 Ben Pfaff <blp@gnu.org>
70 * pool.c: (pool_create_at_offset) New function.
71 (pool_add_subpool) New function.
73 * pool.h: (pool_create_container) New macro.
75 * expressions/parse.c: (expr_parse_pool) New function.
77 * autorecode.c: (recode) Use pool_create_container().
79 * count.c: (cmd_count) Ditto.
81 Wed Nov 2 19:59:32 2005 Ben Pfaff <blp@gnu.org>
83 Clean up transformations, by getting rid of `struct trns_header',
84 replacing it by `struct transformation' that has a void *
85 `private' member. Updated all uses of transformations to match,
86 which was a lot of code. Only major related changes listed below.
88 * compute.c: (cmd_if) Use get_proc_func().
89 (cmd_compute) Use get_proc_func().
90 (get_proc_func) New function.
92 * glob.c: (global var m_trns) Change type to size_t.
93 (global var n_trns) Ditto.
94 (global var f_trns) Ditto.
95 (global var t_trns) Change type to struct transformation *.
97 * var.h: (struct trns_header) Removed.
98 (struct transformation) New.
99 (typedef trns_proc_func) Takes a void * instead of a struct
101 (typedef trns_free_func) Ditto.
103 * vfm.c: (execute_transformations) Takes an array of
104 transformations instead of trns_headers.
105 (add_transformation) Change prototype from (trns_header *) to
106 (trns_proc_func *, trns_free_func *, void *).
107 (next_transformation) New function.
109 Sat Oct 29 16:25:36 2005 Ben Pfaff <blp@gnu.org>
111 * count.c: Major cleanups. Rename practically everything.
112 Rewrite much of the code. Use pools for memory management. Use
113 the new parse_num_range().
115 * mis-val.c: (cmd_missing_values) Use the new parse_num_range().
116 (parse_number) Removed.
118 * missing-values.c: (mv_add_num_range) Don't add out-of-order
119 ranges, e.g. where low > high.
121 * pool.c: (pool_2nrealloc) New function.
123 * range-prs.c: New file.
124 (parse_num_range) New function.
125 (parse_number) New function.
127 Fri Oct 28 22:47:48 2005 Ben Pfaff <blp@gnu.org>
129 Fix up potential overflows in size calculations by replacing
130 instances of pool_alloc(p, x * sizeof *y) by pool_malloc(p, x,
131 sizeof *y) everywhere I could find them. Similarly by
132 pool_malloc(), pool_realloc().
133 (Order is important: pool_alloc(p, sizeof *y, x) will divide by 0
136 * pool.c: (pool_nalloc) New function.
137 (pool_nmalloc) New function.
138 (pool_nrealloc) New function.
140 Thu Oct 27 11:16:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
142 Separated the definition of a file handle object from the stuff
143 pertaining to the FILE HANDLE command.
145 * file-handle-def.[ch]: New files.
147 * dfm-read.c file-handle.h file-handle.q
149 Tue Oct 25 21:56:23 2005 Ben Pfaff <blp@gnu.org>
151 Fix up potential overflows in size calculations by replacing
152 instances of xmalloc(x * sizeof *y) by xnmalloc(x, sizeof *y)
153 everywhere I could find them. Similarly by xrealloc(), malloc().
154 (Order is important: xnmalloc(sizeof *y, x) will divide by 0 if x
157 * alloc.c: (nmalloc) New function.
158 (out_of_memory) Removed. Replaced references by xalloc_die().
160 * sort.c: (allocate_cases) Fix segfault if memory allocation
163 * subclist.c: (subc_list_double_create) Use xnmalloc() instead of
165 (subc_list_double_push) Use xnrealloc() instead of realloc().
167 Wed Oct 26 08:43:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
169 Dictionary abstraction part #2
171 * algorithm.c format.c str.c sysfile-info.c val.h var.h vars-atr.c:
172 Removed unnecessary #include directives
174 Mon Oct 24 21:35:08 2005 Ben Pfaff <blp@gnu.org>
176 * groff-font.c (font_msg): Use err_vmsg() instead of incorrectly
177 trying to pass a va_list to tmsg(). Thanks to Jason Stover for
180 Mon Oct 24 21:24:15 2005 Ben Pfaff <blp@gnu.org>
182 Work to get rid of GCC 4.0 warnings, part 2.
184 In many files, change `unsigned char' to `char'. This often
185 requires adding casts to <ctype.h> functions.
187 * data-in.c: (parse_A) Use buf_copy_rpad().
189 * str.c: (str_copy_buf_trunc) New function.
191 * value-labels.c: (value_to_string) Fix mistaken use of strncpy(),
194 Mon Oct 24 13:42:32 WST 2005 John Darrington <john@darrington.wattle.id.au>
196 Moved some definitions to make it easier to abstract a dictionary
197 from the rest of PSPP.
199 * format-prs.c lex-def.[ch]: New files.
201 * Makefile.am lexer.[ch] dictionary.c vars-atr.c vfm.c algorithm.c
202 format.c: Moved some functions between modules.
204 Sun Oct 23 19:28:08 2005 Ben Pfaff <blp@gnu.org>
206 Work to get rid of GCC 4.0 warnings, part 1.
208 In many files, change count parameters to parse_variables(),
209 etc. from `int' to `size_t'. Also change related variables and
210 struct members. Also change messages as needed (e.g. %d to %u
211 with cast to unsigned). Also change arithmetic as necessary
212 (e.g. n >= m - 1 to n + 1 >= m).
214 * crosstabs.q: (crs_custom_tables) Check for size_t overflow in
217 * q2c.c: (dump_declarations) Generate code for size_t instead of
220 Thu Oct 20 18:18:40 2005 Ben Pfaff <blp@gnu.org>
222 * output.c: (outp_read_devices) Fix message.
224 Sat Sep 17 11:13:13 2005 Ben Pfaff <blp@gnu.org>
226 * matrix-data.c: (cmd_matrix_data) Change type of variable whose
227 address is passed to dict_get_vars() from size_t to int to match
230 * modify-vars.c: (validate_var_modification) Ditto.
232 Mon Sep 12 19:26:06 WST 2005 John Darrington <john@darrington.wattle.id.au>
234 * dictionary.[ch] Changed cnt from size_t* to int* since that's
235 what it's called as, and on x86_64 machines they're different sizes.
237 * str.c: (ds_vprintf) Copied va_list args so they can be re-used
239 Sun Aug 21 00:12:24 2005 Ben Pfaff <blp@gnu.org>
241 * lexer.c: (lex_sbc_only_once) New function.
242 (lex_sbc_missing) New function.
244 Sun Aug 21 00:00:47 2005 Ben Pfaff <blp@gnu.org>
246 * case.h: (case_str) Make it return `unsigned char'.
248 Sat Aug 20 23:56:14 2005 Ben Pfaff <blp@gnu.org>
250 Revamp SAVE, XSAVE, EXPORT. Add (or at least parse) all the
251 subcommands that we didn't support. Fix bug 13911. Fix bug
252 reported by Adam Pierson (COMPRESSED and other subcommands didn't
253 work on SAVE). Refactor all related code.
255 * command.def: Add XEXPORT command.
257 * dictionary.c: (dict_delete_scratch_vars) New function.
259 * get.c: (cmd_get) Fix parsing.
260 (struct save_trns) Removed.
261 (cmd_save_internal) Removed.
263 (do_write_case) Removed.
264 (save_write_case_func) Removed.
265 (save_trns_proc) Removed.
266 (save_trns_free) Removed.
267 (trim_dictionary) Removed.
268 (struct export_proc) Removed.
269 (cmd_export) Rewrote.
270 (export_write_case_func) Removed.
271 (export_proc_free) Removed.
272 (enum writer_type) New enum.
273 (enum command_type) New enum.
274 (struct any_writer) New struct.
275 (any_writer_destroy) New function.
276 (parse_write_command) New function.
277 (any_writer_write_case) New function.
278 (parse_output_proc) New function.
279 (output_proc) New function.
282 (struct output_trns) New struct.
283 (parse_output_trns) New function.
284 (output_trns_proc) New function.
285 (output_trns_free) New function.
287 (cmd_xexport) New function.
288 (parse_dict_trim) New function.
289 (struct mtf_proc) Change `by_cnt' member type to `int'.
290 (cmd_import) Rewrote.
292 * pfm-write.c: (struct pfm_writer) Add `digits' member.
293 (pfm_writer_default_options) New function.
294 (pfm_open_writer) Add `opts' argument and handle options.
295 (write_float) Write only as many digits as `digits' member says.
296 (format_trig_double) Limit base-10 precision to LDBL_DIG.
298 * pfm-write.h: (enum pfm_type) Moved here from pfm-read.h.
299 (struct pfm_write_options) New struct.
301 * sfm-write.c: (sfm_writer_default_options) New function.
302 (sfm_open_writer) Remove `compress', `omit_long_names' args. Add
303 `opts' argument. Implement options.
305 * sfm-write.h: (struct sfm_write_options) New struct.
307 * expressions/helpers.c: (copy_string) Make `old' arg `unsigned
308 char *' instead of `char *'.
310 Sat Aug 6 21:29:15 2005 Ben Pfaff <blp@gnu.org>
312 * factor_stats.c: Needed <config.h> included earlier.
314 * percentiles.c: Needed to include <config.h>.
316 * val.h: Don't include "config.h".
318 Sat Aug 6 21:26:27 2005 Ben Pfaff <blp@gnu.org>
320 Clean up treatment of missing values by moving all the code into
321 one place. All references to the missing value function were
322 updated, but only major changes are detailed below.
324 * Makefile.am: Add missing-values.c, missing-values.h to sources.
326 * apply-dict.c: (cmd_apply_dictionary) Use mv_resize().
328 * dictionary.c: (dict_create_var) Initialize `miss' member with
330 (dict_clone_var) Copy `miss' member with mv_copy().
332 * get.c: (mtf_merge_dictionary) Use mv_copy().
334 * missing-values.c: New file.
336 * missing-values.h: New file.
338 * mis-val.c: Rewrite. New version implements updated semantics.
340 * pfm-read.c: (read_variables) Rewrite missing value handling.
342 * pfm-write.c: (write_variables) Rewrite missing value handling.
344 * sfm-read.c: (read_variables) Rewrite missing value handling.
346 * sfm-write.c: (write_variable) Rewrite missing value handling.
348 * sfmP.h: Include "magic.h" to get definition of
351 * sysfile-info.c: (describe_variable) Rewrite missing value
354 * val.h: Include "magic.h" to get definition of
357 * var.h: Include "missing-values.h". Drop MISSING_* enums.
358 (struct variable) Remove `miss_type', `missing'. Add `miss'.
360 * vars-atr.c: (is_num_user_missing) Removed--use
361 mv_is_num_user_missing().
362 (is_str_user_missing) Removed--use mv_is_str_user_missing().
363 (is_system_missing) Removed--use mv_is_value_system_missing().
364 (is_missing) Removed--use mv_is_value_missing().
365 (is_user_missing) Removed--use mv_is_value_user_missing().
367 Sun Jul 31 14:09:57 2005 Ben Pfaff <blp@gnu.org>
369 Adopt use of gnulib for portability.
371 * Make.build: Add $(top_srcdir)/gl and $(top_builddir)/gl to
374 * Makefile.am: Remove bool.h, stat.h and change getline.[ch] to
375 getl.[ch] in pspp_SOURCES. Remove libmisc, add libgl in
378 * In many source files, added an explicit inclusion of gettext.h
379 and definition of _ macro. These are no longer in pref.h because
380 it interfered with definitions in a few gnulib source files.
382 * In many source files, changed #include "bool.h" to #include
383 <stdbool.h>, which is provided by gnulib.
385 * alloc.c: Removed functions defined in gnulib:
390 (out_of_memory) Redefined as wrapper for xalloc_die().
392 * alloc.h: Replace prototypes by #include "xalloc.h".
394 * casefile.c: Use full_read() and full_write() from gnulib instead
395 of our home-grown versions.
397 (full_write) Removed.
399 * getline.c: Renamed getl.c.
401 * getline.h: Renamed getl.h, updated all references.
403 * filename.c: (fn_readlink) Change to wrapper around xreadlink()
406 * glob.c: Just #include <time.h> instead of the crazy rigmarole
408 (init_glob) Call set_program_name() to initial gnulib progname
411 * html.c: (postopen) Use getlogin_r(), gethostname() from gnulib.
413 * permissions.c: Use "stat-macros.h" from gnulib.
415 * postscript.c: Just #include <time.h> instead of the crazy
416 rigmarole here before.
418 * q2c.c: (main) Make generated code #include "gettext.h".
420 * str.h: Get rid of most explicit declarations of standard
421 functions, in favor of including gnulib header files.
423 * expressions/evaluate.c: Ditto.
425 * expressions/operations.h.pl: Make generated code #include
426 <stdbool.h>, not "bool.h".
428 Sat Jul 30 23:13:17 2005 Ben Pfaff <blp@gnu.org>
430 * expressions/parse.c: (validate_function_args) Fix two msg() bugs
433 Sat Jul 30 23:10:01 2005 Ben Pfaff <blp@gnu.org>
435 * expressions/evaluate.c: (expr_debug_print_postfix) Don't pass
436 null pointer to printf for %.*s.
438 Sat Jul 30 23:05:33 2005 Ben Pfaff <blp@gnu.org>
440 * vars-atr.c: (var_is_valid_name) Fix three msg() bugs found by
443 Sat Jul 30 22:58:33 2005 Ben Pfaff <blp@gnu.org>
445 * rank.q: (parse_rank_function) Fix msg() bug found by -Wformat.
447 Sat Jul 30 22:56:12 2005 Ben Pfaff <blp@gnu.org>
449 * postscript.c: (postopen) Cast `char' to `unsigned char' before
450 passing to isspace().
452 Sat Jul 30 22:52:09 2005 Ben Pfaff <blp@gnu.org>
454 * pfm-read.c: (read_variables) Fix msg() bug found by -Wformat.
456 Sat Jul 30 22:50:57 2005 Ben Pfaff <blp@gnu.org>
458 * histogram.c: Include <config.h>.
460 Sat Jul 30 22:48:50 2005 Ben Pfaff <blp@gnu.org>
462 * get.c: (cmd_match_files) Fix msg() bug found by -Wformat.
464 Sat Jul 30 22:46:10 2005 Ben Pfaff <blp@gnu.org>
466 * format.c: (check_common_specifier) Fix msg() bug found by
468 (check_output_specifier) Ditto.
470 Sat Jul 30 22:43:57 2005 Ben Pfaff <blp@gnu.org>
472 * file-handle.q: (cmd_file_handle) Fix msg() bug found by
475 Sat Jul 30 22:41:44 2005 Ben Pfaff <blp@gnu.org>
477 * data-in.c: (parse_Z) [WORDS_BIGENDIAN] Don't declare buf[], to
478 avoid "unused variable" warning.
480 Sat Jul 30 22:38:46 2005 Ben Pfaff <blp@gnu.org>
482 * command.c: (find_word) Cast `char' to `unsigned char' before
483 passing to isspace().
485 Sat Jul 30 22:36:29 2005 Ben Pfaff <blp@gnu.org>
487 * case.c: (case_compare) Implement as delegating to
488 case_compare_2dict().
490 Sat Jul 30 22:34:18 2005 Ben Pfaff <blp@gnu.org>
492 * algorithm.c: Inclusion of <alloca.h> is unneeded.
494 Sat Jul 30 22:01:32 2005 Ben Pfaff <blp@gnu.org>
496 * Make.build: Don't append -ansi to AM_CFLAGS for GCC. Using
497 -ansi changes the behavior of header files significantly. It
498 causes __STRICT_ANSI__ to be defined, and some headers interpret
499 that as cause to e.g. not use `long long' or __attribute__. The
500 former example is bad when off_t is supposed to be `long long',
501 and the latter prevents -Wformat from working.
503 Sun Jul 24 20:26:59 2005 Ben Pfaff <blp@gnu.org>
505 Get rid of dependency on libgmp by writing our own routine for
506 floating-point base conversion.
508 * pfm-write.c: (write_float) Rewrote.
510 (pow30_nonnegative) New function.
511 (pow30) New function.
512 (trig_to_char) New function.
513 (format_trig_digits) New function.
514 (recurse_format_trig_int) New function.
515 (format_trig_int) New function.
516 (should_round_up) New function.
517 (try_round_up) New function.
518 (format_trig_double) New function.
520 Sun Jul 24 18:49:20 2005 Ben Pfaff <blp@gnu.org>
522 * data-in.c: (parse_numeric) Allow "1+23" even for F format, for
525 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
527 * pfm-read.c: (read_version_data) Read and ignore author field.
529 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
531 * get.c: (mtf_processing) Don't assume that
532 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
533 returns a negative, zero, or positive result. Fixes MATCH FILES
534 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
536 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
538 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
539 preprocessor test for sys/types.h was accidentally inverted. This
542 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
544 * get.c: (cmd_match_files) Fix memory leak on `by' and on
547 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
550 * vfm.c: (close_active_file) Remove unnecessary test.
552 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
554 Fix NDEBUG compile errors.
556 * hash.h: Needed explicit #include <assert.h>.
558 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
561 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
563 Implement embedding for PostScript driver. Fixes bug 12970.
565 * ascii.c: Fix compiler warnings.
569 * chart.h: Add `file' member.
571 * output.h: (struct outp_class) initialise_chart, finalise_chart
572 should take outp_driver *, not outp_class *. Update all
575 * plot-chart.c: (chart_create) Fix segfault when there are no
576 output drivers at all.
577 (chart_submit) Call d->class->finalise_chart.
579 * postscript.c: (ps_open_page) Set cp_y to 0.
580 (ps_submit) New function.
581 (ps_chart_initialise) Implement.
582 (ps_chart_finalise) Implement.
583 (static var postscript_class) Add ps_submit.
584 (static var epsf_class) Add ps_submit.
587 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
589 Did some more work on bug 12859 and then realized that a *good*
590 solution would require some fundamental restructuring. For now,
591 I'm marking REPEATING DATA unimplemented, and then we can revisit
594 * command.def: Make REPEATING DATA unimplemented.
596 * data-list.c: (cmd_repeating_data) Assume inline file is 80
598 (realize_value) Revert previous changes; no longer needed.
601 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
602 file_loc, to avoid bad references later.
606 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
608 Make some code tolerant of reentry. Should not be needed if other
609 code is correct but it is good to be generally tolerant.
611 * error.c: (err_hcf) Set file_loc to null after free().
613 * output.c: (outp_done) Similar changes.
615 * str.c: (ds_destroy) Ditto.
617 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
619 Continue work on bug 12859, plus some code cleanup.
621 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
622 boolean variables. Don't try to compute starts_end, cont_end for
623 inline file. Calculate length only after parsing variable
624 specifications. Add proper transformation to list.
625 (realize_value) If the rpd_num_or_var has no value, return new
626 DEFAULT_MEMBER argument (for use with inline file).
627 (repeating_data_trns_proc) Pass default values.
629 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
630 open, and only if we actually started reading data.
632 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
636 * output.c: (outp_read_devices) Fix message.
638 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
640 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
641 of the sort algorithm from the parser for the SORT command.
643 * rank.q: Added the parser for the RANK command.
645 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
649 * sort.c: (sort_parse_criteria) Only set *saw_direction if
650 saw_direction is non-null. Thanks to John Darrington for
653 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
655 * get.c: (mtf_processing) Handle case of a lookup table as the
656 active file. Thanks to John Darrington for reporting this bug.
658 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
660 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
661 POSIX calloc function.
663 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
664 reflect new signature.
666 * sfm-read.c: Now much more robust in the face of badly formed
669 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
671 *sfm-read.c: Fixed some bugs regarding long string continuation
672 records, which the previous fix uncovered.
674 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
676 * sfm-read.c, sfmP.h: Allow reading of system files when the
677 case_size value in the header is -1. Also changed some Errors to
678 Warnings when reading system files.
680 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
682 * data-list.c: (data_list_trns_free) Don't free the argument
683 because cancel_transformations() will do that itself.
684 (data_list_source_destroy) Destroy the argument to
685 data_list_trns_free(), because it no longer does so itself.
687 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
689 * data-out.c: (format_and_round) Don't output leading `-' if value
692 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
696 * som.c: (output_encodings) If some cell in the table won't fit
697 with the horizontal or vertical headers, cancel those headers.
699 * som.h: (struct som_table_class) Add fits_width, fits_length,
702 * tab.c: (tabi_fits_width) New function.
703 (tabi_fits_length) New function.
704 (tabi_set_headers) New function.
705 (global var tab_table_class) Add the new functions as appropriate
708 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
710 Fix rest of bug 13054.
712 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
713 DATETIME, TIME system/portable file values.
715 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
717 * data-list.c: (parse_free) Use make_input_format().
719 * data-out.c: (num_to_string) Use make_output_format().
721 * dictionary.c: (dict_create_var) Ditto.
723 * format.c: (global var f8_2) New var.
724 (make_input_format) New function.
725 (make_output_format) New function.
727 * get.c: (cmd_match_files) Use make_output_format().
729 * list.q: (cmd_list) Ditto.
731 * matrix-data.c: Ditto.
733 * sfm-read.c: (parse_format_spec) Check output specifier
736 * tab.c: (tab_float) Use make_output_format().
738 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
740 Fix more of bug 13054.
742 * format.def: FMT_A should allow 255-character output. FMT_AHEX
743 should allow 510-character input and output.
745 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
746 (convert_E) Handle non-finite values.
748 (format_and_round) New function.
749 (convert_infinite) New function used by try_F() and convert_E().
751 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
753 Regularize string and buffer function names so that they make some
756 * str.c: (mm_reverse) Rename buf_reverse(). Update all
758 (mm_find_reverse) Rename buf_find_reverse(). Update all
760 (mm_case_compare) Rename buf_compare_case(). Update all
762 (st_compare_pad) Rename buf_compare_rpad(). Update all
764 (str_compare_rpad) New function.
765 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
767 (buf_copy_str_lpad) New function.
768 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
770 (st_pad_copy) Rename str_copy_rpad(). Update all references.
771 (st_trim_copy) Rename str_copy_trunc(). Update all references.
772 (st_uppercase) Renamed str_uppercase(). Update all references.
774 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
776 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
779 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
781 * data-in.c: (data_in) Add assertion to check input specifier.
783 * data-out.c: (data_out) Add assertion to check output specifier.
785 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
787 Start to fix bug 13054.
789 * format.c: (check_input_specifier) Improve error message.
790 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
791 valid decimal places.
792 (check_output_specifier) Ditto (but different criteria).
793 (convert_fmt_ItoO) Assert valid input and output specifiers.
794 Also, if input specifier has *any* decimal places, make the output
795 specifier 1 place wider.
797 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
799 * sysfile-info.c: Fixed bug [# 13024 ]
801 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
803 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
804 actually implement it.
806 * command.c: (FILE_TYPE_okay) Always return 1.
808 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
810 * file-type.c: Add prototypes to get rid of warnings.
812 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
814 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
815 more ISO/IEC 9899:1990 conformance issues.
817 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
819 Fix bug 12948. See also new test in
820 tests/bugs/match-file-scratch.sh.
822 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
823 that deletes scratch variables that someone else might be using,
824 and because we can't reassign our sources' value indexes.
825 Instead, simply don't copy scratch variables into the master
828 * dictionary.c: (dict_compact_values) Delete variables from the
829 dictionary passed in, not from default_dict (!).
831 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
833 Improve hash.c comments, error-checking.
835 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
836 (hsh_create) size == 0 should *not* return NULL! Set
838 (hsh_clear) Set hash_ordered.
839 (locate_matching_entry) Check hash_ordered.
840 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
841 (hsh_data) Set hash_ordered. Add const-ness to return value and
845 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
847 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
849 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
851 * copyleft.c: Updated copyright date.
853 * Makefile.am: Removed erroneous explicit "-lplot"
855 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
857 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
859 * command.c command.def: Added description string for unimplemented commands.
861 * oneway.q: Sorted the hash tables before shipping out the results. Closes
864 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
868 * data-list.c: (parse_fixed) Use lex_end_of_command().
870 (cmd_repeating_data) Set cont_end.num in right situations.
871 (parse_repeating_data) Remove redundant test.
873 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
875 Partial fix for bug 12859.
877 * data-list.c: (cmd_data_list) Add transformation properly in
878 vfm_source == NULL case.
880 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
882 * lexer.c: (lex_error) Improve error messages.
884 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
886 * get.c: (cmd_match_files) Check token type before trying to match
887 tokid. Fixes bug 12923.
889 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
891 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
894 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
896 * expressions/generate.pl: (get_token) Make use of /g
897 backward-compatible with Perl 5.6.1.
899 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
901 * var-display.c: (cmd_variable_alignment) Fix memory leak.
902 (cmd_variable_level) Ditto.
904 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
906 Hash table had buggy deletion function. The fix required changing
907 other functions to do probing in the required order.
909 * hash.c: (locate_matching_entry) Rewrite and change interface.
910 (hsh_rehash) Rewrite to use locate_matching_entry().
913 (hsh_delete) Ditto. Also, fix stupid bugs.
915 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
917 * dictionary.c: (dict_clone) Properly copy vectors.
919 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
921 New implementation of long variable names. Each variable has a
922 "normal" name, which may be up to 64 bytes long and which is used
923 for all normal operations. Variables may have a "short" name,
924 which is limited to 8 bytes and used only for system and portable
925 file input and output.
927 Make tokid case-preserving. Update most uses of tokid to treat it
930 Update many commands to deal with long variable names.
932 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
934 * command.c: (cmd_parse) Ditto.
935 (match_strings) Use toupper() before comparing characters.
936 (conflicting_3char_prefixes) Use mm_case_compare() instead of
938 (cmd_match_words) Ditto.
940 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
943 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
944 Use st_trim_copy() instead of strcpy().
946 * data-in.c: (parse_enum) Use mm_case_compare() instead of
949 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
951 (parse_free) Use st_trim_copy() instead of strcpy().
953 * descript.c: (struct dsc_var) Change z_name[] to fit long var
955 (try_name) Use strcasecmp() instead of strcmp().
956 (generate_z_varname) Use st_trim_copy() instead of strcpy().
957 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
960 * dictionary.c: (struct dictionary) Removed `long_name_tab'
962 (compare_long_names) Removed.
963 (hash_long_name) Removed.
964 (dict_create) Don't initialize `long_name_tab' member.
965 (dict_clone) Copy short names into new dictionary.
966 (dict_clear) Don't clear `long_name_tab' member.
967 (dict_get_varname_block) Removed.
968 (dict_add_longvar_entry) Removed.
970 (dict_destroy) Don't destroy `long_name_tab' member.
971 (dict_create_var_from_short) Removed.
972 (dict_create_var_x) Removed.
973 (dict_create_var) Get rid of longname handling.
975 (dict_clone_var) Get rid of longname parameter and longname
977 (dict_lookup_var) Get rid of longname handling.
978 (dict_reorder_var) New function.
979 (dict_rename_var) Clear short name.
980 (dict_rename_vars) Get rid of longname handling. Clear short
982 (dict_create_vector) Support long vector names.
983 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
984 (quasi_base27) Removed.
985 (make_short_name) Removed.
986 (compare_strings) New function.
987 (hash_string) New function.
988 (dict_assign_short_names) New function.
990 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
992 (get_handle_for_filename) Support long handle names.
994 * file-type.c: (struct col_spec) Make `name' fit long var names.
995 (cmd_file_type) Use strcasecmp() instead of strcmp().
997 * flip.c: (make_new_var) Rewrite.
998 (flip_sink_write) Use st_trim_copy() instead of strncpy().
1000 * format.c: (parse_format_specifier_name) Use mm_case_compare()
1001 instead of memcmp().
1003 * get.c: (cmd_save_internal) Rephrase.
1004 (rename_variables) Drop test for identical variable name.
1005 (struct mtf_proc) Change `first', `last' to fit long var name.
1007 * hash.c: (hsh_hash_case_string) New function for case-insensitive
1010 * lexer.c: (restore_token) Use st_trim_copy() instead of
1012 (lex_get) Don't uppercase string when copying into tokid.
1013 (lex_put_back_id) Use st_trim_copy() instead of
1016 * list.q: (determine_layout) Consider length of variable names in
1017 choosing vertical layout.
1019 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
1021 (string_to_content_type) Ditto.
1023 * modify-vars.c: (compare_variables_given_ordering) Ditto.
1024 (struct var_renaming) Change `new_name' to fit long var name.
1025 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
1028 * pfm-read.c: (read_variables) Disallow system variables in system
1030 (write_variables) Call dict_assign_short_names() and use
1031 short_name[] members.
1033 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
1036 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
1037 map. Reorder variables into same order as long variable map.
1038 (read_variables) Set short name.
1040 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
1041 (write_variable) Use st_bare_pad_copy().
1042 (write_longvar_table) Rewrite.
1044 * str.c: (mm_case_compare) New function.
1046 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
1047 instead of strcmp().
1049 * t-test.q: (tts_custom_groups) Remove redundant test.
1050 (tts_custom_pairs) Ditto.
1052 * var.h: (struct variable) Change `name' to fit long var names.
1053 Remove `longname'. Add `short_name' member. Reorder some
1055 (struct name_table_entry) Removed.
1056 (struct vector) Change `name' to fit long vector names.
1058 * vars-atr.c: (var_is_valid_name) Allow long var names.
1059 (compare_var_names) Use strcasecmp() instead of strcmp().
1060 (compare_var_ptr_names) Ditto.
1061 (hash_var_name) Use hsh_hash_case_string().
1062 (hash_var_ptr_name) Ditto.
1063 (var_set_short_name) New function.
1064 (var_clear_short_name) New function.
1065 (var_set_short_name_suffix) New function.
1067 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
1068 Use strcasecmp() instead of strcmp().
1069 (struct array_var_set) Removed `longname_tab'.
1070 (array_var_set_lookup_var_idx) Drop longname_tab support.
1071 (array_var_set_destroy) Don't destroy `longname_tab'.
1072 (var_set_create_from_array) Don't create `longname_tab'.
1074 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
1077 * expressions/parse.c: (word_matches) Use mm_case_compare()
1078 instead of memcmp().
1079 (compare_strings) New function.
1080 (lookup_function) Use compare_strings() instead of strcmp().
1082 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
1084 * algorithm.c: (move_element) New function.
1086 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
1088 * aggregate.c: (parse_aggregate_functions) Always initialize
1091 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
1093 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
1095 * dictionary.c: (dict_clone) Ditto.
1096 (dict_clone_var_assert) New function.
1098 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
1100 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1102 * error.c: Added a string for the compiler version to the
1103 request_bug_report_and_abort function.
1105 * groff_font.c, font.c: Removed manpage(1) style references from
1106 comments, because RMS frowns upon them.
1108 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
1110 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
1112 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
1114 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
1115 Fixed bug [#12858] .
1117 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
1119 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
1120 which should be LONG_NAME_LEN
1122 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
1124 * command.def echo.c: Added the ECHO command.
1126 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
1128 Finish fixing MATCH FILES (bug 11677).
1130 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
1131 keep_variables(), rename_variables().
1132 (drop_variables) New function.
1133 (keep_variables) New function.
1134 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
1135 (cmd_match_files) Deal with in_var. Use drop_variables(),
1136 keep_variables(). When IN is specified, require BY. Set master
1137 variables after master dictionary is complete. Add IN variables
1138 after master dictionary is complete.
1139 (mtf_free_file) Free `in_name'.
1140 (mtf_delete_file_in_place) Set in_var value to 0.
1141 (mtf_read_nonactive_records) Rephrase.
1142 (mtf_processing) Support IN. Rephrase. Fix bugs.
1143 (mtf_merge_dictionary) Don't set master variables; we do that
1145 (get_master) Don't insist that there's a master variable.
1147 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
1149 Kluge to make some variable renaming sort of work.
1152 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
1154 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
1156 Add functions for comparing sets of variables between cases.
1159 * case.c: (case_compare) New function.
1160 (case_compare_2dict) New function.
1162 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
1164 (cmd_aggregate) Nullify break_case. Don't call
1165 initialize_aggregate_info().
1166 (agr_destroy) Destroy break_case.
1167 (aggregate_single_case) Rewrite. Use case_compare().
1168 (dump_aggregate_info) Copy from break_case into output.
1169 (initialize_aggregate_info) Copy break_case from input.
1171 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
1173 * vfm.c: (equal_splits) Use case_compare().
1175 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
1177 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
1179 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
1181 Start work on fixing MATCH FILES.
1183 * get.c: (enum operation) Remove OP_MATCH.
1184 (trim_dictionary) Change return value to bool. Don't support
1186 (struct mtf_file) Remove `first', `last' members.
1187 (struct mtf_proc) Add `first', `last' members. Change mtf_case
1188 from `struct ccase *' to `struct ccase'. Remove `by' member.
1189 (cmd_match_files) Essentially rewrite.
1190 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
1191 (mtf_read_nonactive_records) mtf_ parameter is not unused.
1192 (mtf_processing) Ditto. Also rephrase some code.
1193 (mtf_merge_dictionary) Rewrite for easy comprehension.
1195 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
1197 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
1200 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
1202 Thu Apr 14 2005 John Darrington
1204 * var-display.c: New file.
1206 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
1207 display_width, measure and alignment parameters to variables.
1209 * aggregate.c command.def compute.c count.c data-list.c descript.c
1210 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
1211 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
1212 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
1213 vars-prs.c vector.c :
1214 - Replaced literal constants representing maximum variable name
1215 length with macro definitions.
1216 - Added support for long variable names.
1217 - Changed lexer such that it no longer makes tokens upper
1218 case, but relies upon case insensitive behaviour of commands.
1220 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
1222 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
1223 fails, don't dereference the resulting null pointer (bug 12427).
1224 Also, fix double free error.
1226 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
1228 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
1229 (accumulate_aggregate_info) Set int1 to 1 for SUM.
1230 (dump_aggregate_info) Only make SUM non-missing if there was at
1233 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
1235 * aggregate.c: (dump_aggregate_info) Properly test whether the
1236 destination variable is numeric, when making the result
1237 system-missing for columnwise missing values.
1239 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
1241 * misc.h: Remove GCC specializations.
1243 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
1245 Make sort stable (bug 12313).
1247 * sort.c: Don't need to include some headers anymore.
1248 (static var min_buffers) New variable.
1249 (static var max_buffers) New variable.
1250 (static var allow_internal_sort) New variable.
1251 (cmd_sort_cases) Add test mode.
1252 (sort_execute) Rephrase.
1253 (do_internal_sort) Don't try internal sorting if
1254 allow_internal_sort is set.
1255 (struct external_sort) Renamed `initial_runs' to `runs' and
1256 updated all references.
1257 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
1258 (macro MIN_BUFFER_SIZE_BYTES) Removed.
1259 (macro MIN_BUFFER_SIZE_RECS) Removed.
1260 (compare_initial_runs) Removed.
1261 (struct record_run) Add member `idx'.
1262 (write_initial_runs) Pass increasing values to process_case() as
1264 (process_case) Add `idx' parameter and use it to initialize new
1266 (allocate_cases) Limit allocated buffers to max_buffers.
1267 (compare_record_run) Use new `idx' member for last resort
1268 comparison, for stability.
1269 (end_run) Call casefile_sleep() on irs->casefile, to prevent
1270 running out of file descriptors.
1271 (struct merge_state) Removed.
1272 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
1273 unless we have fewer runs left. Always merge consecutive runs,
1274 for stability. Return the final run.
1276 (choose_merge) New function.
1277 (merge_once) Rewritten.
1279 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
1281 * cmdline.c: (static var testing_mode) Move into
1282 parse_command_line().
1284 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
1286 * algorithm.c: (remove_range) New function.
1287 (remove_element) New function.
1289 * dictionary.c: (dict_delete_var) Use remove_element().
1291 * flip.c: (cmd_flip) Ditto.
1293 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
1295 * file-handle.q: (struct file_handle) `open_mode' should not be
1298 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
1300 First phase of making SORT CASES stable (bug 12313).
1302 * sort.c: (struct indexed_case) New structure.
1303 (do_internal_sort) Rewrite to make internal sorting stable.
1304 (compare_case_dblptrs) Removed.
1305 (compare_indexed_cases) New function.
1307 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
1311 * casefile.c: (casereader_read_xfer_assert) New function.
1313 * dictionary.c: (dict_compact_case) New function.
1315 * flip.c: (struct flip_pgm) New member idx_to_fv.
1316 (cmd_flip) Initialize idx_to_fv member.
1317 (destroy_flip_pgm) Free idx_to_fv member.
1318 (flip_sink_write) Use struct flip_pgm member instead of case_sink
1320 (flip_sink_write) Ditto.
1322 * vfm.c: (write_case) Use dict_compact_case() instead of
1324 (compact_case) Removed.
1325 (storage_source_create) Removed `dict' parameter. All references
1328 * vfm.h: (struct case_source) Removed `value_cnt' member. All
1330 (struct case_sink) Removed `dict', `idx_to_fv' members. All
1333 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
1335 More AGGREGATE fixes.
1337 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
1338 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
1340 (initialize_aggregate_info) Fix initialization for MIN, MAX for
1343 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
1345 Start work on testing and debugging AGGREGATE.
1347 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
1348 of a bit-map. Require proper subcommand ordering. Make OUTFILE
1349 subcommand mandatory.
1350 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
1351 functions' arguments are in the correct order and swap them if
1353 (accumulate_aggregate_info) Make SUM include weights. Add various
1355 (dump_aggregate_info) Add various string functions.
1356 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
1358 * sort.c: (sort_parse_criteria) Add parameter for returning
1359 whether any directions were specified. All callers updated.
1361 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
1363 * t-test.q: Fixed erroneous logic in compare_group_binary.
1365 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
1367 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
1368 keywords (bug 11628).
1370 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
1372 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
1373 called *before* close_active_file().
1375 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
1377 * file-handle.q: (struct file_handle) Change open_mode from
1378 character pointer to 3-char array, for safety. Updated all
1381 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
1383 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
1386 * pfm-read.c: (read_header) Improve error message for many cases
1387 in which the input is not actually a portable file.
1389 * file-handle.q: (fh_open) When we give an error message, actually
1392 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
1394 * format.c: (check_common_specifier) New function for checks
1395 common to check_input_specifier() and check_output_specifier().
1396 (check_input_specifier) Use check_common_specifier().
1397 (check_output_specifier) Use check_common_specifier().
1398 (check_string_specifier) Removed.
1399 (check_specifier_type) New function.
1400 (check_specifier_width) New function.
1401 (get_format_var_width) Fix bug.
1403 * formats.c: (internal_cmd_formats) Only accept numeric variables.
1405 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
1406 update all references. Make case-insensitive.
1408 * pfm-read.c: Essentially rewrite the whole file. Now much
1411 * print.c: (check_string_width) New function.
1412 (fixed_parse_compatible) Use check_string_width(),
1413 check_specifier_type().
1414 (dump_fmt_list) Ditto.
1416 * str.c: (st_trim_copy) New function.
1417 (st_uppercase) New function.
1419 * vars-atr.c: (var_is_valid_name) New function.
1421 * expressions/parse.c: (type_coercion_core) Use
1422 check_specifier_type().
1424 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
1426 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
1428 * expressions/parse.c: (no_match) Ditto.
1430 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
1432 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
1434 * expressions/helpers.c: (struct func_params) Removed.
1435 (generalized_idf) Removed.
1438 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
1440 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
1441 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
1442 Implement SIG.F, which I had overlooked previously.
1444 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
1446 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
1447 available only in testing mode.
1449 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
1451 * data-in.c: Use `bool' throughout, where relevant.
1453 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
1455 DATA LIST with free-field formats should not have implied decimal
1456 places (bug 12035). Also clean up data-in.c a bit.
1458 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
1460 * data-in.c: (apply_implied_decimals) New function.
1461 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
1462 set. Also, get rid of gotos.
1463 (parse_Z) Use apply_implied_decimals() if the field doesn't
1464 contain a decimal point.
1465 (parse_N) Use apply_implied_decimals().
1471 (parse_enum) New function.
1472 (macro CHAR_IS_ROMAN) Removed.
1473 (macro ROMAN_VALUE) Removed.
1474 (parse_month) Use parse_enum().
1475 (parse_weekday) Use parse_enum().
1476 (parse_DATETIME) Use long for weekday.
1478 * data-list.c: (read_from_data_list_fixed) Use
1479 DI_IMPLIED_DECIMALS.
1481 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
1483 When the lexer sees something like `-5' in the input, it has to
1484 decide whether it's a negative numeric constant token or a '-'
1485 token followed by a positive numeric constant token. It always
1486 decides on the former, and then the parser can call
1487 lex_negative_to_dash() if it wants the latter. However, this
1488 doesn't work for the case of `-0', because negative zero is
1489 (portably) indistinguishable from positive zero. So now we divide
1490 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
1491 distinction clear. This requires a little bit of extra effort,
1492 because there were several references to T_NUM in the code base.
1494 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
1495 positive and negative numeric constants.
1496 (lex_double_p) Renamed lex_is_number(). Changed return type to
1497 bool. Updated all relevant references to T_NUM to instead use
1499 (lex_double) Renamed lex_number(). All references updated.
1500 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
1501 bool. All references updated.
1502 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
1503 (lex_negative_to_dash) Ditto.
1506 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
1508 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
1510 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
1512 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
1514 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
1515 values as system-missing.
1517 * expressions/parse.c: (parse_vector_element) Fix order of
1518 arguments in call to expr_allocate_binary().
1520 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
1522 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
1525 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
1526 failure, as indicated by function comment.
1527 (parse_binary_operators) Always return NULL on type_coercion()
1528 failure. Should have been doing this anyway, but bug in
1529 type_coercion_core() filtered through.
1530 (parse_add) Fix typo in user message.
1531 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
1533 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
1535 * expressions/operations.def: Add VALUE function.
1537 * expressions/parse.c: (parse_function) Need an unary composite
1538 node for variables in A TO B, not a variable node. Use
1539 allocate_unary_variable().
1540 (parse_primary) Use allocate_unary_variable().
1541 (allocate_unary_variable) New function.
1543 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
1545 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
1546 but fixed the real problem that was preventing the build from a
1547 separate directory. I liked it my way better ;-)
1549 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
1551 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
1552 John Darrington <john@darrington.wattle.id.au> for reporting this
1555 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
1557 * expressions/Makefile.am expressions/evaluate.h.pl
1558 expressions/evaluate.inc.pl expressions/operations.h.pl
1559 expressions/optimize.inc.pl expressions/parse.inc.p:
1561 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
1564 Fixed everything so that it can be built from an arbitrary
1567 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1569 * Makefile.am : Fixed up CLEANFILES target.
1571 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
1573 * str.h: Changed `struct len_string' to `struct fixed_string', a
1574 more accurate name. Updated all references.
1576 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
1578 Redo calendar support. Should now be bug-for-bug compatible.
1580 * calendar.c: New file.
1582 * calendar.h: New file.
1584 * data-in.c: Use new calendar functions.
1585 (parse_sign) Change sense of return value.
1586 (calendar_error) New function.
1587 (ymd_to_ofs) New function.
1588 (ymd_to_date) New function.
1589 (parse_DATE) Use new function.
1590 (parse_ADATE) Ditto.
1591 (parse_EDATE) Ditto.
1592 (parse_SDATE) Ditto.
1593 (parse_JDATE) Ditto.
1598 (parse_DTIME) Ditto.
1599 (parse_DATETIME) Ditto.
1601 * data-out.c: (convert_date) Use new calendar functions.
1603 * error.c: (err_vmsg) Changed interface to be more sensible.
1604 Updated all callers.
1605 (dump_message) Don't double new-lines (why did we do this
1608 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
1610 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
1611 (macro FLT64_MAX) Moved here from pref.h.orig.
1613 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
1615 * set.q: Support SET EPOCH.
1616 (static var set_epoch) New var.
1617 (aux_stc_custom_epoch) New function.
1618 (stc_custom_epoch) New function.
1619 (get_epoch) New function.
1620 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
1622 * format.c: Make it possible just to check whether a specifier is
1623 valid without emitting an error message.
1624 (parse_format_specifier_name) Change interface, update all
1626 (check_input_specifier) Ditto.
1627 (check_output_specifier) Ditto.
1628 (parse_format_specifier) Ditto.
1630 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
1632 * command.def: Add DEBUG POOL.
1634 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
1636 (pool_clear) Properly account for size of pool gizmo.
1637 (pool_realloc) Ditto.
1638 (pool_clone) New function.
1640 * pool.h: Mark our allocation functions MALLOC_LIKE.
1642 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
1644 * Makefile.am: Move many definitions into new top-level
1645 Make.build. Add expressions to SUBDIRS. Add calendar.c,
1646 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
1649 * case.c: (case_resize) New function.
1650 (case_swap) New function.
1652 * casefile.c: Include mkfile.h.
1654 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1656 * sfm-read.c: Fixed a buglet which caused a crash when trying
1657 to read a non-existent file.
1659 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
1663 * aggregate.c: (parse_aggregate_functions) Code cleanup.
1664 Important part: get rid of spurious copying of function->format to
1665 destvar->print and destvar->write.
1667 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
1669 Fix bug 11916, which was confusing a variable's `index' member
1670 with the variable's position in a var_set. Although these are
1671 usually the same, they are not for array `var_set's.
1673 Took advantage of this bug as an opportunity to clean up and
1674 rewrite parse_var_set_vars().
1676 * vars-prs.c: (parse_vs_variable_idx) New function.
1677 (parse_vs_variable) Reimplement in terms of
1678 parse_vs_variable_idx().
1679 (parse_var_idx_class) New function.
1680 (add_variable) New function.
1681 (add_variables) New function.
1682 (parse_var_set_vars) Rewritten.
1683 (struct var_set) Change `lookup_var' member that returns a
1684 variable into `lookup_var_idx' member that returns an int.
1685 Updated the var set implementations in obvious corresponding ways.
1686 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
1688 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
1690 Use our global variable compare & hash functions and give them
1691 better names. Add similar functions for dealing with double
1692 pointers to variables.
1694 * vars-atr.c: (compare_variables) Renamed compare_var_names().
1695 (hash_variable) Renamed hash_var_name().
1696 (compare_var_ptr_names) New function.
1697 (hash_var_ptr_name) New function.
1699 * t-test.q: (cmd_t_test) Use global compare_var_names(),
1701 (compare_var_name) Removed.
1702 (hash_var_name) Removed.
1704 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
1708 * dictionary.c: (compare_variable_dblptrs) Rename
1709 compare_var_ptrs() and fix it to properly dereference the double
1712 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
1714 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
1715 declare subcommands as mandatory. Closed bug #11843
1717 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
1719 * getline.c command.[ch] command.def: Added (very rudimentary)
1720 support for line completion when in interactive mode. Partially
1721 addresses bug #11693
1723 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1725 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
1726 problems revealed by valgrind.
1729 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1731 * set.q: Affixed a fix to the previous fix such that we'll be OK now
1732 whether or not PAGER is set.
1734 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1736 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
1737 "invalid free" errors. Hopefully fixes bug #11722
1739 * compute.c expr-prs.c: Check that lvalues are populated before
1740 attempting to destroy them. Closes bug #11676
1742 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1744 * aggregate.c: Initialised the complete agr_proc structure.
1748 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
1750 * print.c: (print_trns_free) Close the dfm writer if there is one,
1751 fixing a memory leak.
1753 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
1755 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
1759 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
1761 * linked-list.[ch] Added
1763 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
1764 set.q: Yet more memory leaks
1766 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
1768 * t-test.q examine.q : More memory leaks fixed.
1770 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
1772 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
1775 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1777 * ascii.c cartesian.c casefile.c chart.h devind.c
1778 examine.q frequencies.q
1779 html.c output.h piechart.c plot-chart.c plot-hist.c
1781 Integrated the chart rendering into the output stream
1782 (currently only works for html).
1784 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
1785 dummy-chart.c for compiling without charts.
1787 * mkfile.[ch] Created.
1789 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
1790 Added type element so we can tell if it's a chart or a table.
1792 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
1793 API of charts to be more like that of tables.
1795 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1797 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
1798 main.c. Removed the handler for SIGQUIT.
1800 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1802 * casefile.c: Added a signal handler to delete temp files on
1805 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
1807 * command.def Added a lot more unimplemented commands.
1809 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
1811 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
1813 * sort.c: (compare_initial_runs) Needed additional level of
1815 (merge_once) Fix plenty of stupid mistakes.
1817 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
1819 * casefile.c: (casefile_sleep) Need to flush_buffer() after
1820 calling casefile_to_disk() or we will lose the last block in the
1821 file if the casefile started out as disk-based.
1822 (casefile_get_reader) Initialize reader->destructive to 0.
1823 (cmd_debug_casefile) Add new test pattern.
1824 (test_casefile) Define new test pattern to make sure
1825 casefile_sleep() works properly.
1827 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
1829 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
1830 plot-hist.c plot-chart.c (Added) Reorganised these files in an
1831 attempt to seperate the creation and processing of charts from their
1834 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
1837 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
1839 * main.c Added a signal handler for SIGFPE
1841 * sort.c Somewhat more robust fix to the previous entry.
1843 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
1845 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
1846 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
1847 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
1850 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1852 * case.h Fixed bug # 11307
1854 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1856 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
1859 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
1861 * pfm-read.c: (read_variables) Remove direct manipulation of
1862 v->aux, which is no longer needed. Fixes bug 11483.
1864 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
1866 * data-list.c Fixed a bug in parsing delimiters.
1868 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
1871 * percentiles.c Properly handled calculation of Tukey hinges where
1872 the number of data is small.
1874 * oneway.q Used the generic value_to_string function for independent
1875 variable instead of trying to do it ourselves.
1877 * box-whisker.c Fixed a buglet which caused a crash if the number of
1881 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1883 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
1885 * percentiles.c Fixed some bugs when calculating percentiles when
1886 there's a small number of cases.
1888 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
1890 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
1892 * examine.q factor_stats.[ch] Added calculation of percentiles
1894 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1896 * t-test.q Fixed bug #11227 Made t-test work when the independent
1899 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1901 * factor_stats.c Fixed calculation of trimmed mean under various
1904 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1906 * histogram.c chart.[ch] factor_stats.c frequencies.q
1908 Added code to calculate sensible histogram ranges and limits.
1910 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
1912 * chart.h Updated to reflect many API changes.
1914 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
1915 cartesian.c and into chart.c
1917 * factorstats.[ch] Added the histogram calculations
1919 * casefile.c Removed an unused variable.
1921 * frequencies.q examine.q histogram.c Reworked the API for
1924 * piechart.c Revised the API for piecharts.
1926 * var.h Moved the definitions of freq_tab and freq out of var.h
1927 and into frequencies.q where they belong.
1929 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
1931 * flip.c: (flip_file) Check for off_t separately from fseeko(),
1932 using AC_TYPE_OFF_T.
1934 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
1936 * flip.c: (flip_file) If fseeko() is not available, use long int
1937 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
1938 reporting the problem.
1940 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
1942 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
1943 conflict with stdio.
1945 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
1947 * var-labs.c (var_to_string) Now returns null if the variable is null
1949 * value-labels.c (value_to_string) Made it return null if either the
1950 value or the variable is null.
1952 * hash.c (hsh_clear) Fixed a buglet.
1954 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
1955 with the wrong model.
1957 * casefile.[ch] Added a function to return the casereader.case_idx
1960 * examine.q Implemented the extreme values results.
1962 John Darrington <john@darrington.wattle.id.au>
1964 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
1965 output.[ch] getline.c
1967 Plugged some memory leaks
1969 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
1971 Adopt GSL random number generators, paving the way for providing
1972 the complete suite of random number generators on expressions.
1974 * Makefile.am: Remove random.c, random.h.
1976 * random.c: Removed.
1978 * random.h: Removed.
1980 * algorithm.c: (algo_default_random) Use GSL functions.
1982 * casefile.c: (test_casefile) Use GSL RNG functions.
1984 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
1987 * sample.c: (cmd_sample) Use GSL RNG functions.
1988 (sample_trns_proc) Ditto.
1990 * set.q: (static var set_seed) Removed.
1991 (static var seed_flag) Removed.
1992 (static var rng) New variable.
1993 (aux_stc_custom_seed) No seed value anymore, don't print anything.
1994 (stc_custom_seed) Use new seed functions.
1995 (seed_is_set) Removed.
1996 (get_rng) New function that composes the entire external
1998 (set_rng) New function.
1999 (random_seed) New function.
2001 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
2003 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
2004 John Darrington <john@darrington.wattle.id.au> for reporting this
2007 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2009 * permissions.c command.def Added the PERMISSIONS command
2011 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
2013 * q2c.c: (dump_header) Don't try to emit #includes at very top of
2014 output file because that will precede #include <config.h>, which
2016 (main) Add needed headers to /* (header) */ code.
2018 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
2020 Instead of making system or portable file readers responsible for
2021 dropping and reordering variables, make them read full cases and
2022 let the caller take care of any changes.
2024 * get.c: New "case map" structure to handle this. Use for GET,
2025 IMPORT, MATCH FILES. Essentially rewrite the whole file.
2027 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
2028 changed appropriately.
2030 * sfm-read.c: (sfm_read_case) Ditto.
2032 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
2034 Decided that case_serialize() and case_unserialize() were too
2035 abstract. Also we need a couple more functions to avoid excessive
2036 copying for data in/out fast paths.
2038 * case.c: (case_serial_size) Removed.
2039 (case_serialize) Rename case_to_values() and make its argument
2040 explicitly an array of union values.
2041 (case_unserialize) Rename case_from_values() and make its argument
2042 explicitly an array of union values.
2043 (case_data_all) New function.
2044 (case_data_all_rw) New function.
2046 * casefile.c: (struct casefile) Change buffer from array of
2047 unsigned char to array of union value for better accuracy.
2048 Redefine buffer_used and buffer_size in terms of values, not
2049 bytes. Remove case_size because it is now redundant with
2050 value_cnt. Fix up all references to these members.
2052 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
2054 * barchart.c: (struct subcat) Make `label' member const to silence
2055 GCC warning with -Wwrite-strings.
2057 * cartesian.c: (struct dataset) Ditto.
2059 * case.c: Don't re-define NDEBUG if already defined.
2060 Add lots of comments.
2062 * str.c: Fix includes.
2064 * crosstabs.q: Fix includes.
2066 * examine.q: Fix includes. Fix GCC warning about unused
2069 * frequencies.q: (stat macro) Removed and replaced where used by
2072 * list.q: Fix includes.
2074 * oneway.q: Fix includes.
2076 * piechart.c: Fix includes. Only define M_PI if not already
2079 * sfm-read.c: (bswap) New function.
2080 (bswap_int32) Write in terms of bswap.
2081 (bswap_flt64) Ditto.
2083 * str.c: (ds_data) Add external definition here, needed because
2084 str.h has only an `extern inline' version.
2086 * value-labels.c: Fix includes.
2088 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
2090 Instead of providing a system or portable file writer with a raw
2091 case in the format needed for output, provide it with a regular
2092 case. The writer takes care of any needed translation.
2094 * aggregate.c: Adopt new scheme for AGGREGATE.
2095 (struct agr_proc) sfm_agr_case member removed.
2096 (write_case_to_sfm) Removed because the new interface is easier to
2099 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
2101 * pfm-write.c: Implement new scheme.
2103 * sfm-write.c: Ditto.
2105 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
2107 Instead of treating `struct file_handle' as a class to subclass
2108 into data files, system files, and portable files, instead use it
2109 as a helper that coordinates access. Now it is opaque, too.
2111 This means that most references to a struct file_handle are now
2112 changed into references to one of struct dfm_reader, struct
2113 dfm_writer, struct sfm_reader, struct sfm_writer, struct
2114 pfm_reader, or struct pfm_writer, according to what's being read
2117 Most related changes are only worth summarizing briefly.
2119 * dictionary.c: (dict_clear) Destroy aux data in deleted
2121 (dict_clear_aux) New function.
2122 (dict_create_var) Initialize aux, aux_dtor.
2123 (dict_delete_var) Destroy aux data in deleted variable.
2125 * file-handle.h: (struct fh_ext_class) Removed.
2126 (struct file_handle) Removed.
2127 (fh_init_files) Removed.
2129 * file-handle.q: Changed references to a handle's `private' member
2130 to direct references.
2131 (struct private_file_handle) Renamed file_handle.
2132 Add next, open_cnt, type, open_mode, aux members.
2133 (struct file_handle_list) Removed.
2134 (extern var inline_file) Removed.
2135 (static var file_handles) Changed from file_handle_list * to
2137 (create_file_handle) Initialize new members.
2138 (fh_close_handle) Removed.
2139 (mode_name) New function.
2140 (fh_open) New function.
2141 (fh_close) New function.
2142 (fh_parse_file_handle) Renamed fh_parse().
2144 * glob.c: (init_glob) Remove fh_init_files() call.
2146 * aggregate.c: use sfm_writer.
2147 (create_sysfile) Removed because the new interface is simpler.
2149 * apply-dict.c: Use sfm_reader.
2151 * data-list.c: Use dfm_reader.
2153 * file-type.c: Use dfm_reader.
2155 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
2157 * inpt-pgm.c: Use dfm_reader.
2159 * print.c: Use dfm_writer.
2161 * sysfile-info: Use sfm_reader.
2163 * dfm-read.c: Adopt new file handle infrastructure.
2165 * dfm-write.c: Ditto.
2167 * pfm-read.c: Ditto.
2169 * pfm-write.c: Ditto.
2171 * sfm-read.c: Ditto.
2173 * sfm-write.c: Ditto.
2175 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
2177 Break dictionary functions into separate header file.
2179 * dictionary.h: New file.
2181 * var.h: Moved dict_*() functions to dictionary.h.
2183 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
2185 Get rid of procedure-specific union in struct variable, using
2186 instead a void * pointer and a destructor function.
2188 Most related changes are only worth brief summaries.
2190 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
2191 old p.crs member in struct variable.
2193 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
2194 of old p.frq member in struct variable.
2196 * histogram.c: (draw_histogram) Takes new freq_tab arg because
2197 it's no longer possible to grab this from var->p.frq.
2199 * piechart.c: (draw_piechart) Ditto.
2201 * group.c: (group_proc_get) New function.
2203 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
2210 * main.c: (execute_command) Clear aux data in default_dict after
2211 each command. (It's debatable whether this should be done.)
2213 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
2214 member in struct variable.
2216 * means.q: Get rid of integer mode, which is not included in
2217 recent SPSS and was the only code that wanted per-variable private
2220 * var.h: (struct crosstab_proc) Removed.
2221 (struct frequencies_proc) Removed.
2222 (struct list_proc) Removed.
2223 (struct get_proc) Removed.
2224 (struct means_proc) Removed.
2225 (struct matrix_data_proc) Removed.
2226 (struct match_files_proc) Removed.
2227 (lots of enums) Removed.
2228 (struct variable) Removed members `p', `get'. Add member
2231 * vars-atr.c: (var_attach_aux) New function.
2232 (var_detach_aux) New function.
2233 (var_clear_aux) New function.
2234 (var_dtor_free) New function.
2235 (discard_variables) Use NULL instead of inline_file.
2237 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2239 * value-labs.c Fixed the implmentation of value_to_string, so
2240 that it properly handles alpha values.
2242 * oneway.q Changed instances where labels were being probed manually,
2243 to use the canonical {var,value}_to_string functions
2245 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
2247 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
2248 plots. Changed the API of the cartesian plot to be a much lower level
2251 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
2253 * examine.q Added some of the parametric calculations
2255 * factor_stats.[ch] Created
2257 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
2259 * examine.q Changed the definition of factors to be a composite, and
2260 dealt with the consequences.
2262 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
2264 * examine.q Fixed problem where examine wasn't dealing properly with
2267 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
2269 * oneway.q Fixed problem where oneway wasn't dealing properly with
2272 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
2274 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
2275 command which had settings didn't get the appropriate code
2278 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
2279 to convert variables/values to strings.
2281 * examine.q Added framework for the EXAMINE command.
2283 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
2285 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
2286 subcommand types. Changed frequencies.q to use it rather then the
2287 custom parser. Dealt with the consequences. Added a test for NTILES
2288 subcommand of frequencies.
2290 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
2292 * oneway.q Fixed up the behaviour when given missing values
2294 * levene.c oneway.q Fixed a buglet with the levene statistic and
2295 incorporated the levene test into the oneway command.
2297 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
2298 global scope, since they're only relevant to T-TEST
2300 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
2302 * group.c group.h group_proc.h levene.c oneway.q t-test.q
2304 Made the t-test more consistent
2305 with the way it handles groups. That is, it now uses a hash instead
2306 of an array of 2. Also, made the levene.c file independent of the
2307 implementation of the t-test. So now levene should be fine for both
2310 * Added an oneway.q file for one way anova
2312 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
2314 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
2317 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
2321 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
2322 (data_list_trns_free) Free dls->delims.
2324 * t-test.q: (tts_custom_pairs) Free vars.
2325 (ssbox_one_sample_init) Fix tab_vline() argument.
2326 (ssbox_independent_samples_init) Ditto.
2327 (trbox_paired_init) Ditto.
2328 (trbox_one_sample_init) Ditto.
2330 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
2332 Generalize casefiles to the extent that we can use them for
2333 sorting and other kinds of data transformations. Change cases to
2334 be copy-on-write to improve memory efficiency in common cases.
2335 Every access to a member of a `struct ccase' was changed to be a
2336 call to a case_*() function, especially case_data(), case_num(),
2337 case_str(), or case_data_rw(). Many instances of a local variable
2338 named "case_num" were changed to "case_idx" as a consequence.
2339 Many `struct ccase *' were changed to actual `struct ccase'
2340 because of copying semantics of cases. In several places there
2341 was a choice between updating debug code to work with the new ADTs
2342 or just deleting it because it was useless; I chose to delete it.
2344 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
2350 * aggregate.c: (struct agr_proc) Change type of `sort' to
2351 sort_criteria *. Add `break_vars', `break_var_cnt' members.
2352 Rename `vars' to `agr_vars', all references updated. Change
2353 `agr_case' to type `struct ccase'.
2354 (cmd_aggregate) Deal with new members. Use case_create(),
2355 sort_active_file_in_place(), sort_active_file_to_casefile().
2356 (agr_destroy) Deal with new members.
2357 (aggregate_single_case) Ditto.
2358 (dump_aggregate_info) Ditto.
2359 (initialize_aggregate_info) Ditto.
2360 (agr_to_active_file) Ditto.
2361 (presorted_agr_to_sysfile) Ditto.
2362 (sort_agr_to_sysfile) Removed.
2364 * alloc.c: (out_of_memory) Make non-static.
2366 * alloc.h: Prototype out_of_memory().
2368 * casefile.c: Switched from a linked list in-memory representation
2369 to a two-level array-style representation. The linked list was
2370 appropriate when we could stick a header onto cases, but that's no
2371 longer the case. Also, the two-level array will allow for random
2372 in-memory access in case that's ever wanted. Also added the
2373 concept of a `destructive casereader', one that destroys cases in
2374 the underlying casefile as they are read out.
2375 (macro CASES_PER_BLOCK) New macro.
2376 (struct casefile) New members `value_cnt', `case_list_size',
2377 `case_acct_size', `being_destroyed', `cases'. Removed `head',
2379 (struct casereader) Removed `cur'. Added `destructive', `c'.
2380 (global var casefiles) Made static.
2381 (static var case_bytes) New var.
2382 (casefile_create) Takes a value count, not a case size in bytes,
2383 to conform to the case interface. All callers updated. Deal with
2384 new and removed members.
2385 (casefile_destroy) Deal with new and removed members.
2386 (casefile_sleep) New function.
2387 (casefile_get_case_size) Removed.
2388 (casefile_get_value_cnt) New function.
2389 (casefile_append) Rewritten to deal with new and removed members.
2390 (casefile_append_xfer) New function.
2391 (write_case_to_disk) Use case_serialize().
2392 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
2393 Couldn't figure out why.
2394 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
2395 deal with new and removed members.
2397 (merge_sort) Removed.
2398 (casefile_sort) Removed.
2399 (casefile_get_reader) Deal with new and removed members.
2400 (casefile_get_destructive_reader) New function.
2401 (reader_open_file) Make code more readable. Create case for
2403 (casereader_get_casefile) New function.
2404 (casereader_read) Deal with new and removed members. Now returns
2405 a copy of the case, so that the caller is responsible for
2406 destroying the returned case.
2407 (casereader_read_xfer) New function.
2408 (casereader_destroy) Destroy reader's case.
2409 (test_casefile) Second arg is now a value count, all callers
2410 updated. Now tests destructive readers too.
2411 (get_random_case) Deal with new case ADT.
2412 (write_random_case) Ditto.
2413 (read_and_verify_random_case) Ditto.
2415 * crosstabs.q: Remove debug code.
2417 * descript.q: (calc_descriptives) Deal with new case, casefile
2420 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
2422 * do-if.c: Remove unneeded header inclusion.
2424 * expr-prs.c: Remove debug code.
2426 * exprP.h: Remove debug code.
2428 * flip.c: (flip_file) Use fseeko() if available.
2430 * formats.c: Remove debug code.
2432 * get.c: Remove debug code.
2433 (struct mtf_file) Change `input' from `union value *' to `struct
2434 ccase', all references updated.
2436 * levene.c: (levene) Deal with new case, casefile ADTs.
2438 * list.q: Remove debug code.
2440 * loop.c: Remove debug code.
2442 * matrix-data.c: Remove debug code.
2444 * means.q: Remove debug code.
2446 * mis-val.c: Remove debug code.
2448 * pfm-read.c: Remove debug code.
2449 (pfm_read_code) Change second arg from `union value *' to `struct
2450 ccase *', all references updated.
2452 * recode.c: (string_to_long) Make first arg const.
2453 (convert_to_double) Ditto.
2455 * repeat.c: Remove debug code.
2457 * sample.c: Remove debug code.
2459 * sfm-read.c: Remove debug code.
2460 (sfm_read_case) Change second arg from `union value *' to `struct
2463 * sort.c: Redone in terms of casefiles.
2464 (enum sort_direction) Moved here from sort.h.
2465 (struct sort_criterion) New structure.
2466 (struct sort_criteria) New structure.
2467 (cmd_sort_cases) Rewritten.
2468 (prepare_to_sort_active_file) New function.
2469 (sort_active_file_in_place) New function.
2470 (sort_active_file_to_casefile) New function.
2471 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
2472 changed, all callers updated.
2473 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
2474 rewritten & interface changed, all callers updated.
2475 (sort_cases) Renamed sort_execute(), rewritten & interface
2476 changed, all callers updated.
2477 (struct internal_sort) Removed.
2478 (do_internal_sort) Rewritten, interface changed.
2479 (destroy_internal_sort) Removed.
2480 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
2481 (struct initial_run) Removed; an initial run is now just a
2483 (compare_initial_runs) Rewritten.
2484 (struct external_sort) Changed almost completely.
2485 (do_external_sort) Rewritten, interface changed.
2486 (destroy_external_sort) Rewritten.
2487 [HAVE_MKDTEMP] (make_temp_dir) Removed.
2488 [!HAVE_MKDTEMP] (do_mkdir) Removed.
2489 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
2490 (init_external_sort) Removed.
2491 (simulate_error) Removed.
2492 (rmdir_temp_dir) Removed.
2493 (get_temp_file_name) Removed.
2494 (open_temp_file) Removed.
2495 (close_temp_file) Removed.
2496 (remove_temp_file) Removed.
2497 (write_temp_file) Removed.
2498 (read_temp_file) Removed.
2499 (struct record_run) Change `record' from `struct case_lit *' to
2501 (struct initial_run_state) Remove `idx_to_fv', `free_list',
2502 `file_idx', `output_file'. Add `run', casefile'. Change
2503 `last_output' from `struct case_list *' to `struct ccase'.
2504 (write_initial_runs) Change interface, rewrite.
2505 (sort_sink_write) Renamed process_case(), changed interfaced,
2507 (destroy_initial_run_state) Rewritten.
2508 (allocate_cases) Rewritten.
2509 (compare_record) Interface changed, rewritten.
2510 (start_run) Rewritten.
2511 (end_run) Rewritten.
2512 (output_record) Rewritten.
2513 (grab_case) Removed.
2514 (release_case) Removed.
2515 (struct merge_case) Change `cases' from double pointer to single
2517 (merge) Deal with new case and casefile ADTs.
2518 (struct run) Removed.
2519 (merge_once) Rewritten, interface changed.
2520 (fill_run_buffer) Removed.
2521 (sort_sink_make_source) Removed.
2522 (sort_sink_class) Removed.
2523 (struct sort_source_aux) Removed.
2524 (sort_source_read_helper) Removed.
2525 (sort_source_read) Removed.
2526 (read_sort_output) Removed.
2527 (read_internal_sort_output) Removed.
2528 (read_external_sort_output) Removed.
2529 (sort_source_destroy) Removed.
2530 (sort_source_class) Removed.
2532 * sort.h: (struct sort_cases_pgm) Removed.
2533 (enum sort_direction) Moved to sort.c.
2535 * t-test.q: (calculate) Deal with new case, casefile ADTs.
2537 * tab.c: Remove debug code.
2539 * var-labs.c: Remove debug code.
2541 * var.h: (struct ccase) Removed.
2542 (struct case_list) Removed.
2544 * vars-atr.c: (discard_variables) Use free_case_source().
2546 * vars-prs.c: (parse_vs_variable) Make arg const.
2547 (parse_dict_variable) Ditto.
2548 (parse_variables) Make struct dictionary * arg const.
2549 (parse_var_set_vars) Make struct var_set * arg const.
2550 (struct var_set) Add const to some of the function pointers' args.
2551 (var_set_get_cnt) Make arg const.
2552 (var_set_get_var) Make first arg const.
2553 (var_set_lookup_var) Make first arg const.
2554 (dict_var_set_get_cnt) Make arg const.
2555 (dict_var_set_get_var) Make first arg const.
2556 (dict_var_set_lookup_var) Make first arg const.
2557 (var_set_create_from_dict) Make arg const. Add cast to aux
2559 (struct array_var_set) Add const to var member.
2560 (array_var_set_get_cnt) Make arg const.
2561 (array_var_set_get_var) Make first arg const.
2562 (array_var_set_lookup_var) Make first arg const.
2563 (var_set_create_from_array) Make first arg const. Insert cast.
2565 * vfm.c: (struct write_case_data) Change trns_case, sink_case
2566 members from `struct ccase *' to `struct ccase'.
2567 (static var lag_queue) Change from double to single pointer.
2568 (procedure) Optimize trivial case.
2569 (internal_procedure) Deal with changed case, case_source ADTs.
2570 (create_trns_case) Changed interface, rewrote.
2571 (open_active_interface) Initialize modified lag queue.
2572 (write_case) Deal with changed case ADT.
2573 (lag_case) Deal with modified lag queue.
2574 (close_active_file) Destroy modified lag queue.
2575 Deal with changed case_source, case_sink ADTs.
2576 (destroy_storage_stream_info) Make null arg into no-op.
2577 (storage_sink_make_source) Set aux in created source.
2578 (storage_source_read) Deal with changed case, casefile ADTs.
2579 (storage_source_create) New function.
2580 (lagged_case) Rewrite.
2581 (free_case_source) New function.
2582 (free_case_sink) Rewrite.
2583 (struct split_aux_data) Changed prev_case from `struct ccase *' to
2585 (procedure_with_splits) Deal with changed prev_case.
2586 (procedure_with_splits_callback) Ditto.
2587 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
2589 (multipass_procedure_with_splits) Deal with changed prev_case.
2590 (multipass_split_callback) Ditto.
2593 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
2595 The workspace idea didn't work out.
2597 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
2599 * workspace.c: Removed.
2601 * workspace.h: Removed.
2603 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
2605 Fully implement arbitrary delimiters on DATA LIST, extending the
2606 half implementation that was already there.
2608 * data-list.c: (struct data_list_pgm) Remove `delim', add
2609 `delims', `delim_cnt'.
2610 (cmd_data_list) Initialize new members. Parse delimiters and
2611 clean up code a bit.
2612 (cut_field) Extract fields with arbitrary delimiters. Also, fix
2613 handling of leading commas.
2614 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
2616 (read_from_data_list_free) Adapt to new DFM interfaces.
2617 (read_from_data_list_list) Ditto.
2618 (repeating_data_trns_proc) Ditto.
2620 * dfm.c: Split up reader and writer into separate code, because
2621 they do different things. Use struct string instead of explicit
2622 allocation code, for clarity.
2623 (enum dfm_reader_flags) New enum.
2624 (struct dfm_fhuser_ext) Removed.
2625 (struct dfm_reader_ext) New.
2626 (get_reader) New function, used by just about all the reader
2628 (dfm_close) Removed.
2629 (close_reader) New function.
2630 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
2631 (dfm_open_for_writing) Ditto.
2632 (macro force_line_buffer_expansion) Removed.
2633 (count_tabs) Removed.
2634 (tabs_to_spaces) Removed.
2635 (read_record) Deal with new dfm_reader_ext. Use struct string
2636 functions. Don't convert tabs to spaces.
2637 (dfm_eof) New function.
2638 (dfm_get_record) Changed interface, rewrote.
2639 (dfm_expand_tabs) New function.
2640 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
2641 dfm_reader_ext, rewritten.
2642 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
2643 dfm_reader_ext, rewritten.
2644 (dfm_set_record) Removed in favor of dfm_forward_columns().
2645 (dfm_forward_columns) New function.
2646 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
2647 dfm_reader_ext, rewritten.
2648 (static var dfm_r_class) Use close_reader for the destructor.
2649 (struct dfm_writer_ext) New.
2650 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
2651 bounce buffer now instead of local allocation.
2652 (close_writer) New function.
2653 (static var dfm_writer_ext) Use close_writer for destructor.
2654 (cmd_begin_data) Adapt to new dfm_reader_ext.
2656 * file-handle.q: Add support for per-file tab width.
2657 (struct private_file_handle) Add tab_width member.
2658 (q2c specifications) Add tabwidth subcommand.
2659 (cmd_file_handle) Put parsed tab width into private_file_handle.
2660 (create_file_handle) Set default tab width.
2661 (handle_get_tab_width) New function.
2663 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
2665 * inpt-pgm.c: (reread_trns_proc) Ditto.
2667 * matrix-data.c: (context) Ditto.
2668 (another_token) Ditto.
2672 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
2674 * casefile.c: (casefile_destroy) Fix memory leak by freeing
2676 (casereader_destroy) Don't close file descriptor -1.
2678 * recode.c: (cmd_recode) Fix memory leak.
2680 * set.q: (q2c specifications) Fix typo in user message.
2682 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
2683 undefined behavior for overlapping arguments.
2685 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
2687 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
2688 don't call it when we're running under valgrind.
2689 (call_posix_fadvise) New function.
2690 (casefile_to_disk) Use call_posix_fadvise().
2691 (reader_open_file) Ditto.
2693 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
2695 Update our string ADTs, struct string and struct len_string. Get
2696 rid of pool support, which was largely unused. Rename lots of
2697 functions to have more obvious or consistent names.
2699 * ascii.c: Get rid of ascii_pool. It was only used for string
2701 (ascii_open_global) Don't create ascii_pool.
2702 (ascii_close_driver) Don't destroy ascii_pool.
2703 (ascii_postopen_driver) Don't use pool.
2704 (ascii_close_driver) Destroy strings manually.
2706 * str.c: (ds_create) Remove pool argument, all references updated.
2708 (ds_replace) Remove pool support, make more efficient when we
2709 don't need to reallocate.
2710 (ds_destroy) Remove pool support.
2711 (ds_rpad) New function.
2712 (ds_size) Renamed ds_capacity(), all references updated.
2713 (ds_value) Renamed ds_c_str(), all references updated.
2714 (ds_concat) Renamed ds_puts(), all references updated.
2715 (ds_concat_buffer) Renamed ds_concat(), all references updated.
2716 (ds_putchar) Renamed ds_putc(), all references updated.
2717 (ds_getline) Renamed ds_gets(), all references updated.
2718 (ls_create) Remove pool argument, all references updated.
2719 (ls_create_buffer) Ditto.
2720 (ls_destroy) Removed pool support.
2721 (ls_value) Renamed ls_c_str(), all references updated.
2723 * str.h: (ls_length) [__GNUC__] Add inline version.
2724 (ls_c_str) [__GNUC__] Add inline version.
2725 (ls_end) [__GNUC__] Add inline version.
2726 (struct string) Remove pool member. Rename `size' to `capacity',
2727 all references updated.
2729 * tab.c: (text_format) Instead of using pool argument to
2730 ls_create_buffer(), call pool_register() on allocated data.
2732 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
2734 We're abusing the current ASCII driver by telling it to allocate a
2735 9999-line, 9999-character page in the tests. This causes some
2736 systems to curl up and die because it allocates 20 MB of
2737 contiguous RAM. This change alleviates at least part of the
2738 problem. It is mostly a stop-gap until the new output system is
2741 * ascii.c: (struct line) New structure.
2742 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
2743 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
2744 (ascii_preopen_driver) Initialize new members, not old ones.
2745 (ascii_close_driver) Destroy new members, not old ones.
2746 (ascii_open_page) Allocate new members, not old ones.
2747 (expand_line) Allocate room in line.
2748 (draw_line) Use new members.
2749 (ascii_line_horz) Ditto.
2750 (ascii_line_vert) Ditto.
2751 (ascii_line_intersection) Ditto.
2753 (output_lines) Ditto.
2754 (ascii_close_page) Ditto.
2756 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
2758 * matrix.c: Dead code. Removed.
2760 * matrix.h: Dead code. Removed.
2762 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
2764 Contrary to what I'd always understood, there is an efficient
2765 algorithm for deletion from a hash table populated via linear
2766 probing. This change implements it.
2768 * hash.c: (hsh_rehash) Probe in increasing order.
2770 (locate_matching_entry) Ditto.
2771 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
2773 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
2775 * moments.c (calc_moments): Adjust calculation of kurtosis to
2776 avoid subtracting huge numbers from huge numbers, on Michael
2779 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
2781 Rework moments routines for improved numerical stability based on
2782 Michael Kiefte's advice. Any bugs or remaining numerical problems
2783 are still mine though.
2785 There is now a struct moments1 for use with one-pass moments. It
2786 uses a provisional means algorithm as an attempt to improve
2787 accuracy of higher moments. The older struct moments now only
2788 handles two-pass moments.
2790 * aggregate.c: Use moments1 instead moments.
2792 * descript.c: Revert previous change, which is no longer needed
2793 due to the moments revision.
2795 * moments.c: (calc_moments) New function for calculating variance,
2797 (moments_pass_one) Only accumulate weights bigger than zero.
2798 (moments_calculate) Allow calculating the mean on pass one, others
2799 require pass two. Implement in terms of calc_moments().
2800 (struct moments1) New structure.
2801 (init_moments1) New function.
2802 (moments1_clear) Ditto.
2803 (moments1_create) Ditto.
2804 (moments1_add) Ditto.
2805 (moments1_calculate) Ditto.
2806 (moments1_destroy) Ditto.
2807 (cmd_debug_moments) Deal with `struct moments' or `struct
2808 moments1' as requested by user.
2810 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
2812 * Makefile.am (pspp_SOURCES): Remove debug.c.
2814 * debug.c: Removed. It was empty anyway.
2816 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
2818 * descript.c (calc_descriptives): Fix assert failure when only
2819 MOMENT_MEAN is needed.
2821 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
2825 fixed problem with parsing in match_statistic() causing
2826 "DESCRIPTIVE STAT=MEAN." to barf.
2828 "MEAN" is now default if "SORT" given without specification.
2830 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
2831 generally less forgiving of syntax errors: better to have it do
2832 nothing and type it in again then to not know what it actually did
2835 z-score transformation now checks score for user-missing values
2836 and checks std_dev for SYSMIS.
2838 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
2840 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
2841 Changed dict_get_case_weight() to accept an additional int * flag
2842 to complain about system-missing, user-missing, zero, or negative
2843 weights and updated existing functions to pass int * to
2844 dict_get_case_weight().
2846 2004-04-05 jmd <jmd@gnu.org>
2848 * main.c: Fixed configuration problems with gsl
2850 * t-test.q: Fixed some problems encountered when compiling under Cygwin
2852 2004-04-03 blp <blp@gnu.org>
2854 * lexer.c, ChangeLog:
2855 Fix infinite loop on comment at end of file, add test.
2857 2004-04-03 jmd <jmd@gnu.org>
2859 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
2860 Fixed the calculation of percentiles and added --syntax and --algorithm options
2862 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
2864 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
2867 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2869 * frequencies.q: Fixed the calculation of percentiles
2871 * Makefile.am: Added the --ansi flag and dealt with the
2872 consequences. Added some entries to PSPP_sources so that
2873 make distcheck would pass
2875 * cmdline.c: Added the --syntax and --algorithm options
2877 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
2879 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2881 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
2882 use the new multipass_split_... mechanism.
2884 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
2886 * frequencies.q: (calc_stats) Use moments data structure and
2887 calc_seskew(), calc_sekurt() functions.
2889 * set.q main.c settings.h Added support for --syntax and --algorithm
2892 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
2894 * vfm.c: Had to get last call to multipass_split_output() inside
2895 open_active_file()/close_active_file() pairing, so introduce new
2897 (internal_procedure) Move procedure() code here, except for calls
2898 to open_active_file() and close_active_file().
2899 (procedure) Wrap open_active_file() and close_active_file() around
2900 internal_procedure().
2901 (multipass_procedure_with_splits) Wrap open_active_file() and
2902 close_active_file() around internal_procedure().
2904 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
2906 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
2908 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
2910 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
2912 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
2914 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
2916 * algorithm.c: By default turn off some of the more expensive
2918 (expensive_assert) New macro which expands to assert if
2919 EXTRA_CHECKS is defined, to nothing otherwise.
2920 (unique) Use expensive_assert().
2921 (binary_search) Ditto.
2927 * command.c: (conflicting_3char_prefixes) Words that are the same
2928 don't cause conflicts when they are abbreviated to the first three
2931 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
2932 nonterm_node's n earlier.
2933 (generic_str_func) Ditto.
2935 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
2937 Add support for multipass procedures. Rewrite DESCRIPTIVES to
2938 test multipass support, take advantage of new moments
2939 calculation, and to not be such crappy code. Get rid of q2c
2940 processing for DESCRIPTIVES.
2942 * vfm.c: (struct multipass_split_aux_data) New structure.
2943 (multipass_procedure_with_splits) New function.
2944 (multipass_split_callback) New function.
2945 (multipass_split_output) New function.
2946 * descript.q: Removed.
2948 * descript.c: New file.
2950 * var.h: Removed descriptives enums.
2951 (struct descriptives_proc) Removed.
2952 (struct variable) Removed p.dsc.
2954 * Makefile.am: (q_sources_c) Remove descript.c.
2955 (q_sources_q) Removed descript.q.
2957 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
2959 New manager for keeping track of used workspace.
2961 * workspace.c: New file.
2963 * workspace.h: New file.
2965 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
2967 * sort.c: (do_internal_sort) Use workspace_malloc().
2968 (destroy_internal_sort) Use workspace_free().
2970 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
2972 New `struct casefile' for managing sets of cases.
2974 * casefile.c: New file.
2976 * casefile.h: New file.
2978 * command.def: Add DEBUG CASEFILE command.
2980 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
2982 * sort.c: (sort_cases) Move logic for sending storage file to disk
2983 into do_external_sort().
2984 (struct internal_sort) Use an array of ccase pointers instead of a
2986 (do_internal_sort) Rewrite to handle casefiles.
2987 (compare_case_list) Removed.
2988 (compare_cases) New function.
2989 (compare_case_dblptrs) New function.
2990 (read_internal_sort_output) Deal with new struct internal_sort.
2992 * vfm.c: (static var workspace_overflow) Removed.
2993 (struct storage_stream_info) Removed all the members. Added
2994 struct casefile * member.
2995 (storage_sink_open) Use casefile.
2996 (open_storage_file) Removed.
2997 (write_storage_file) Removed.
2998 (storage_to_disk) Removed.
2999 (destroy_storage_stream_info) Use casefile.
3000 (storage_sink_write) Use casefile.
3001 (storage_sink_make_source) Use casefile.
3002 (storage_source_count) Use casefile.
3003 (storage_source_read) Use casefile.
3004 (storage_source_on_disk) Removed.
3005 (storage_source_get_cases) Removed.
3006 (storage_source_set_cases) Removed.
3007 (storage_source_get_casefile) New function.
3009 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
3011 New `struct moments' for calculating moments.
3017 * moments.c: New file.
3019 * moments.h: New file.
3021 * command.def: Add DEBUG MOMENTS command.
3023 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
3026 * aggregate.c: Modify AGGREGATE to use the new moments
3027 calculation, even if not in such a great way.
3028 (struct agr_var) Add `moments' member.
3029 (parse_aggregate_functions) Set `moments' member to null.
3030 (agr_destroy) Destroy `moments' member.
3031 (accumulate_aggregate_info) Use `moments' for standard deviation.
3032 (dump_aggregate_info) Ditto.
3033 (initialize_aggregate_info) Create or clear `moments'.
3035 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
3036 cube(), pow4() that were in stats.h. All references updated.
3038 * crosstabs.q: stats.h had chi-square significance functions. Use
3040 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
3042 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
3043 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
3045 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
3047 * dictionary.c: (dict_compact_values) Compacted values need to
3050 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
3052 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
3053 `/' at start. Check return value of parse_variables() for error
3056 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
3058 Revamp expressions: make the code a little nicer, and fix bugs
3061 * expr-evl.c: (expr_evaluate) Make expression argument const.
3062 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
3063 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
3064 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
3065 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
3066 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
3067 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
3068 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
3069 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
3070 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
3071 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
3072 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
3073 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
3074 Simplify OP_SYSMIS. Remove OP_STR_MIS.
3076 * expr-opt.c: (optimize_expression) Rewrite.
3081 (macro s0l) Removed.
3083 (macro s1l) Removed.
3085 (macro s2l) Removed.
3088 (eq_num_con) New function.
3089 (optimize_tree) New function.
3090 (macro rnc) Removed.
3091 (macro frnc) Removed.
3092 (str_search) Add const to string params.
3093 (str_rsearch) Ditto.
3094 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
3095 str[], str_len[] locals to substitute for most of removed macros.
3096 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
3097 Removed support for missing values because we're never called with
3098 missing values. Use set_number() or set_number_errno() instead of
3099 rnc or frnc. Removed any stuff that caused trouble in testing.
3100 We can re-add it later if it really slows anything. Fix some
3102 (evaluate_tree_with_missing) Not yet supported. To be added later
3104 (repl_num_con) Removed.
3105 (collapse_node) New function.
3106 (force_repl_num_con) Removed.
3107 (set_number) New function.
3108 (set_number_errno) New function.
3109 (repl_str_con) Removed.
3110 (set_string) New function.
3111 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
3113 (dump_node) No special case for OP_AND, OP_OR.
3115 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
3116 (expr_get_type) New function.
3117 (type_check) Rewrite.
3118 (type_coercion) New function.
3119 (struct operator) New structure.
3120 (match_operator New function.
3121 (parse_binary_operators) New function.
3122 (parse_inverting_unary_operator) New function.
3123 (parse_or) Rewritten.
3124 (parse_and) Rewritten.
3125 (parse_not) Rewritten.
3126 (parse_rel) Rewritten.
3127 (parse_add) Rewritten.
3128 (parse_mul) Rewritten.
3129 (parse_neg) Rewritten.
3130 (parse_exp) Rewritten.
3131 (parse_sysvar) Add $TRUE, $FALSE system variables.
3132 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
3133 (parse_primary) Use allocate_var_node(), allocate_num_con(),
3135 (struct function) Remove desc, change `func' prototype.
3136 (unary_func) Remove special cases.
3137 (MISSING_func) Reduce to unary_func() that just returns a boolean.
3138 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
3139 (VALUE_func) Use allocate_var_node().
3140 (nary_num_func) Allow MIN and MAX for strings.
3141 Use allocate_var_node(). Properly clean up.
3143 (generic_str_func) Use local table instead of removed `desc'
3144 member. Mostly rewrite.
3145 (get_num_args) Revise error message.
3146 (parse_function) Return EXPR_ERROR, not 0 on error.
3148 (macro varies) Removed.
3149 (ops[]) Use expr.def.
3150 (free_node) Do nothing if node is null.
3151 (allocate_num_con) New function.
3152 (allocate_str_con) New function.
3153 (allocate_var_node) New function.
3154 (allocate_binary_nonterminal) New function.
3155 (append_nonterminal_arg) Removed.
3156 (static var func_tab[]) Revised.
3157 (expr_debug_print_postfix) Make parameter const.
3158 Use printf() instead of debug_printf().
3160 * expr.def: New file.
3162 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
3163 use named enum instead of unnamed, all references updated. Add
3164 EXPR_ANY, EXPR_NO_OPTIMIZE.
3166 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
3167 instead of defining OP_* directly.
3168 (macro IS_TERMINAL) New macro.
3169 (macro IS_NONTERMINAL) New macro.
3170 (enum OP_NO_FLAGS) New.
3172 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
3174 * error.c: (err_assert_fail) msg variable needs to be non-const.
3176 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
3178 * debug.c: (cmd_debug_evaluate) Rewrite.
3180 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
3182 Fix some CROSSTABS bit rot stupidity.
3184 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
3185 (internal_cmd_crosstabs) Initializes cells[] correctly.
3186 (float_M_suffix) Rename format_cell_entry(), change prototype,
3188 (display_crosstabulation) Fix cell formatting.
3190 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
3192 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
3193 to call lex_discard_line() to do that.
3195 * command.c: (run_command) Call lex_discard_line() after
3198 * lexer.c: (lex_entire_end) Change behavior.
3199 (lex_rest_of_line) Change behavior. Return const char *.
3200 (lex_discard_line) Don't clear getl_buf, don't emit message.
3202 * main.c: (handle_error) Emit message here.
3204 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
3205 instead of lex_entire_line().
3207 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
3209 * title.c: (get_title) Call lex_discard_line() after
3211 (cmd_file_label) Ditto.
3212 (cmd_document) Deal with const char * return value.
3214 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
3216 Removed REMARK command.
3218 * command.c: (extract_prefix) Removed.
3219 (output_line) Removed.
3220 (cmd_remark) Removed.
3222 * command.def: Remove REMARK.
3224 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
3226 Added abort() after lots of assert(0) invocations to avoid some
3227 compiler warnings. We really need a NOT_REACHED macro.
3229 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3231 * sort.c: Added missing call to temp_file_close. Changed error
3232 messages to warnings.
3234 * set.q: Improved setting of set_view{length,width} to be more tolerant
3237 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
3239 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
3240 used with incorrect syntax.
3242 * error.c, error.h et al: Overridden definition of assert for a
3245 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
3246 subcommand was given when it ought to have been.
3248 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
3250 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
3254 (tab_joint_text) Ditto.
3256 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
3258 * levene.c: Add #include.
3260 * set.q: (set_viewport) Add `int' argument to make its prototype
3261 correct for signal().
3263 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
3265 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
3268 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
3270 Changed DFM from open-at-first-access to explicit-open. Before,
3271 calling dfm_get_record() or dfm_put_record() would automatically
3272 open the file. Now, you have to call dfm_open_for_reading() or
3273 dfm_open_for_writing() explicitly. This makes it possible to
3274 check permissions, file existence, etc. earlier.
3276 Also made struct file_handle more opaque, and clean up in general.
3278 * data-list.c: (cmd_data_list) Open handle for reading.
3280 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
3282 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
3283 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
3284 (open_inline_file) Removed.
3285 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
3286 it. Deal with line_number in extension record instead of file
3288 (dfm_get_record) Rewrote.
3289 (dfm_put_record) Rewrote.
3290 (dfm_push) Assert file is open and one of ours. Deal with
3291 line_number in extension record instead of file handle.
3292 (dfm_pop) Assert file is open and one of ours. Deal with
3293 line_number in extension record instead of file handle.
3294 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
3297 * file-handle.h: (enum constants RH_RF_*) Removed.
3298 (enum constants FH_MD_*) Removed.
3299 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
3300 `recform', `lrecl', `mode' members. Public references to
3301 `recform' changed to use handle_get_mode(), references to `lrecl'
3302 changed to use handle_get_record_width(). Added `private' member.
3303 (enum file_handle_mode) New.
3305 * file-handle.q: (struct private_file_handle) New structure.
3306 (struct file_handle_list) New structure.
3307 (static var files) New.
3308 (static var file_handles) Removed.
3309 (init_file_handle) Removed.
3310 (create_file_handle) Removed.
3311 (get_handle_with_name) New function.
3312 (get_handle_for_filename) New function.
3313 (cmd_file_handle) Rewritten.
3314 (hash_file_handle) Removed.
3315 (cmp_file_handle) Removed.
3316 (fh_init_files) Rewritten.
3317 (fh_parse_file_handle) Rewritten. Allows identifiers as
3319 (fh_get_handle_by_name) Renamed handle_get_name(), all references
3321 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
3322 references updated. Rewritten.
3323 (fh_record_width) Renamed handle_get_record_width(), all
3324 references updated. Rewritten.
3325 (handle_get_mode) New function.
3327 * file-type.c: (cmd_file_type) Open handle for reading.
3329 * filename.c: [unix] (struct file_identity) New structure.
3330 [unix] (fn_get_identity) New function.
3331 [unix] (fn_free_identity) New function.
3332 [unix] (fn_compare_file_identities) New function.
3333 [!unix] (struct file_identity) New structure.
3334 [!unix] (fn_get_identity) New function.
3335 [!unix] (fn_free_identity) New function.
3336 [!unix] (fn_compare_file_identities) New function.
3338 * lexer.c: (static var put) Renamed put_token, all references
3340 (static var put_tokstr) New.
3341 (static var put_tokval) New.
3342 (lex_init) Initialize put_tokstr().
3343 (restore_token) New function.
3344 (save_token) New function.
3345 (lex_get) Use restore_token().
3346 (lex_put_back) Use save_token().
3347 (lex_put_back_id) New function.
3348 (lex_put_forward) Removed.
3349 (lex_preprocess_line) Set put_token instead of using
3351 (lex_negative_to_dash) Use save_token(), set put_token directly.
3352 (dump_token) Use stderr instead of stdout.
3354 * main.c: (main) Remove call to cmd_init().
3356 * matrix-data.c: (cmd_matrix_data) Open file for reading.
3358 * pfm-read.c: Use handle_get_filename() instead of trying to use
3359 h->fn directly, all over.
3361 * pfm-write.c: Ditto.
3363 * print.c: (internal_cmd_print) Open handle for writing.
3364 (dump_table) Use handle_get_filename().
3365 (print_trns_proc) Use handle_get_mode().
3366 (cmd_print_space) Use fh_parse_file_handle().
3367 Open handle for writing.
3368 [0] (debug_print) Removed.
3370 * sfm-read.c: Use handle_get_filename() instead of trying to use
3371 h->fn directly, all over.
3373 * sfm-write.c: Ditto.
3375 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
3379 * autorecode.c: (arc_free) Free arc->src_values.
3381 * error.c: (msg) Free buf.
3383 * val-labs.c: (do_value_labels) Always free vars.
3385 * vfm.c: (close_active_file) If sink has no make_source then call
3386 its destroy function.
3388 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
3390 Fixed cmd_parse() so that it always skips past a full command
3391 name. A few special commands for which this would be bad get
3392 special treatment. This lets us drop code for skipping past the
3393 end of a command name in most cmd_*() functions. It's not worth
3394 listing all the commands affected.
3396 * command.c: (struct command) Remove `cmd' member, replace by
3397 `name' member, all references updated. Remove `word', `next',
3398 `skip_entire_name' members.
3399 (macro DEFCMD) Deal with revised `struct command'.
3400 (macro UNIMPL) Ditto.
3401 (macro SPCCMD) New macro for commands whose last word shouldn't be
3403 (static array cmd_table[]) Make const, rename `commands', remove
3405 (macro COMMAND_CNT) New macro.
3406 (split_words) Removed.
3408 (FILE_TYPE_okay) Make parameter const.
3409 (cmd_parse) Improve error messages.
3410 (match_strings) New function.
3411 (next_word) New function.
3412 (enum command_match) New enum.
3413 (conflicting_3char_prefixes) New function.
3414 (conflicting_3char_prefix_command) New function.
3415 (cmd_match_words) New function.
3416 (count_matching_commands) New function.
3417 (get_command_name) New function.
3418 (free_words) New function.
3419 (unknown_command_error) New function.
3420 (figure_out_command) Renamed parse_command_name(), rewritten.
3422 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
3423 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
3424 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
3427 * command.h: (macro SPCCMD) New.
3429 * include.c: (cmd_include_at) Removed.
3430 (cmd_include) Allow identifier to be used as filename.
3432 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
3434 * t-test.q: (cmd_t_test) Command name is now parsed for us.
3437 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
3439 Start work on better test framework.
3441 * Makefile.am: (pspp_sources) Add debug.c.
3443 * debug.c: New file.
3445 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
3446 cmd_debug_evaluate().
3448 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
3450 * expr.h: (enum constant PXP_DUMP) Removed.
3452 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
3454 * set.q: Implemented the SHOW command, and synced it to the existing
3457 Added a handler for SIGWINCH so that viewlength and viewwidth follow
3458 changes as the window size is changed.
3460 Added fallback to set viewlength and viewwidth from LINES and COLUMS
3461 environment variables if other methods are not available.
3463 glob.c: Removed a lot of global variables from glob.c and encapsulated
3466 random.c: Tidied up the way the random seed is set.
3468 str.c: Added a ds_vprintf function.
3470 error.c: Extended dump_message so that messages are always broken at
3473 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
3475 * pfm-write.c: (bufwrite) Write out the correct element for string
3476 variables. From Andreas Streichardt <streichardt@globalpark.de>.
3478 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
3480 Get rid of static and global (!) vars in matrix-data.c.
3482 * matrix-data.c: (static var nr_data) Removed.
3483 (static var nr_factor_values) Removed.
3484 (static var max_cell_index) Removed.
3485 (static var split_values) Removed.
3486 (struct nr_aux_data) New structure.
3487 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
3488 place of static vars, pass to create_case_source() and procedure()
3490 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
3491 struct matrix_data_pgm *.
3492 (nr_read_splits) Ditto.
3493 (nr_read_factors) Ditto.
3494 (nr_output_data) Ditto.
3495 (static var wr_content) Removed.
3496 (global var wr_data) Removed.
3497 (global var wr_current) Removed.
3498 (struct wr_aux_data) New structure.
3499 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
3500 place of static vars, pass to create_case_source() and procedure()
3502 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
3503 instead of matrix_data_pgm *.
3504 (wr_read_splits) Ditto.
3505 (wr_output_data) Ditto.
3506 (wr_read_rowtype) Ditto.
3507 (wr_read_factors) Ditto.
3508 (wr_read_indeps) Ditto.
3510 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
3512 Get rid of static vars in autorecode.c.
3514 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
3515 `n_arc' to `spec_cnt'. All references updated.
3516 (static var v_src) Removed.
3517 (static var v_dest) Removed.
3518 (static var h_trns) Removed.
3519 (static var nv_src) Removed.
3520 (static var descend) Removed.
3521 (static var print) Removed.
3522 (enum direction) New enum.
3523 (struct autorecode_pgm) New structure.
3524 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
3525 Move n_dest local var into struct autorecode_pgm for ease of
3526 clean-up. Use arc_free().
3527 (arc_free) New function.
3528 (recode) Modify to take struct autorecode_pgm * parameter instead
3529 of using statics. Let the caller clean up.
3530 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
3531 instead of statics. Rearrange code a little.
3533 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
3535 Get rid of static, global vars in recode.c. Remove debug code.
3537 * recode.c: (static var head) Removed.
3538 (global var v) Removed.
3539 (global var nv) Removed.
3540 (cmd_recode) New local variables head, v, nv. Initialize and free
3541 v. Don't call debug_print().
3542 [DEBUGGING] (dump_dest) Removed.
3543 [DEBUGGING] (debug_print) Removed.
3545 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
3547 Get rid of static vars in expr-opt.c.
3549 * expr-opt.c: (static var e) Removed.
3550 (static var nop) Removed.
3551 (static var mop) Removed.
3552 (static var ndbl) Removed.
3553 (static var mdbl) Removed.
3554 (static var nstr) Removed.
3555 (static var mstr) Removed.
3556 (static var nvars) Removed.
3557 (static var mvars) Removed.
3558 (struct expr_dump_state) New structure.
3559 (dump_expression) Use new struct expr_dump_state instead of static
3560 vars and pass to functions we call.
3561 (dump_node) Use struct expr_dump_state * parameter.
3563 (emit_num_con) Ditto.
3564 (emit_str_con) Ditto.
3567 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
3569 Get rid of static var in COUNT.
3571 * count.c: (static var head) Move into cmd_count().
3572 (cmd_count) [DEBUGGING] Don't call debug_print.
3573 [DEBUGGING] (debug_print) Removed.
3575 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
3577 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
3579 * val-labs.c: (static var v) Removed.
3580 (static var nv) Removed.
3581 [DEBUGGING] (debug_print) Removed.
3582 (verify_val_labs) Add struct variable **, int parameters.
3583 (get_label) Ditto. Improve error messages, streamline.
3584 (erase_labels) New function for erasing value labels, taking over
3585 part of verify_val_labs()'s function.
3588 (cmd_value_labels) No need to call init() or done() anymore.
3589 (cmd_add_value_labels) Ditto.
3590 (do_value_labels) Add vars, var_cnt local variables. Clean up
3591 after them internally. Call erase_labels() if we should. Don't
3594 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
3596 Get rid of static vars in MATCH FILES.
3598 * get.c: (static var mtf_head) Removed.
3599 (static var mtf_tail) Removed.
3600 (static var mtf_by) Removed.
3601 (static var mtf_n_by) Removed.
3602 (static var mtf_master) Removed.
3603 (static var mtf_seq_num) Removed.
3604 (static var mtf_seq_nums) Removed.
3605 (static var mtf_sink) Removed.
3606 (static var mtf_case) Removed.
3607 (struct mtf_proc) New structure.
3608 (cmd_match_files) Use struct mtf_proc instead of static vars.
3609 (mtf_processing_finish) Ditto.
3611 (mtf_delete_file_in_place) Ditto.
3612 (mtf_read_nonactive_records) Ditto.
3613 (mtf_compare_BY_values) Ditto.
3614 (mtf_processing) Ditto.
3615 (mtf_merge_dictionary) Ditto.
3617 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
3619 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
3621 * dictionary.c: (dict_rename_var) Add assertion.
3622 (dict_contains_var) Check by index instead of name.
3624 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
3626 Get rid of compaction_necessary, compaction_nval, compaction_case.
3627 Redo VFM interface. Replace disk_sink and memory_sink by
3628 storage_sink, disk_source and memory_source by storage_source.
3630 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
3634 (struct write_case_data) Remove `begin_func', `end_func',
3635 `func_aux' members. Add `aux', `trns_case', `sink_case',
3636 `cases_written', `cases_analyzed' members.
3637 (global var compaction_necessary) Make static.
3638 (global var compaction_nval) Removed.
3639 (global var compaction_case) Removed.
3640 (static var case_count) Removed.
3641 (struct procedure_aux_data) Removed.
3642 (struct split_aux_data) Removed.
3643 (procedure) Remove begin_func, end_func parameters. Rewrite.
3644 (static var not_canceled) Removed.
3645 (process_active_file) Removed.
3646 (process_active_file_write_case) Removed.
3647 (process_active_file_output_case) Removed.
3648 (prepare_for_writing) Moved into open_active_file().
3649 (arrange_compaction) Ditto.
3651 (open_active_file) Rewrote.
3652 (write_case) New function.
3653 [DEBUGGING] (index_to_varname) Removed.
3654 (execute_transformations) New function.
3655 (exclude_this_case) Renamed filter_case(), changed interface.
3656 (clear_case) Added struct ccase * parameter to interface.
3657 (close_active_file) Added struct write_case_data * parameter,
3659 (disk_sink_create) Removed.
3660 (disk_sink_destroy) Removed.
3661 (disk_sink_make_source) Removed.
3662 (disk_sink_write) Removed.
3663 (disk_source_count) Removed.
3664 (disk_source_destroy) Removed.
3665 (disk_source_read) Removed.
3666 (global var disk_sink_class) Removed.
3667 (global var disk_source_class) Removed.
3668 (global var memory_sink_class) Removed.
3669 (global var memory_source_class) Removed.
3670 (memory_sink_create) Removed.
3671 (memory_sink_destroy) Removed.
3672 (memory_sink_make_source) Removed.
3673 (memory_sink_write) Removed.
3674 (memory_source_count) Removed.
3675 (memory_source_destroy) Removed.
3676 (memory_source_get_cases) Removed.
3677 (memory_source_read) Removed.
3678 (memory_source_set_cases) Removed.
3679 (struct disk_stream_info) Removed.
3680 (struct memory_sink_info) Removed.
3681 (struct memory_source_info) Removed.
3682 (write_active_file_to_disk) Removed.
3683 (destroy_storage_stream_info) New function.
3684 (global var null_sink_class) New var.
3685 (global var storage_sink_class) New var.
3686 (global var storage_source_class) New var.
3687 (open_storage_file) New function.
3688 (storage_sink_destroy) New function.
3689 (storage_sink_make_source) New function.
3690 (storage_sink_open) New function.
3691 (storage_sink_write) New function.
3692 (storage_source_count) New function.
3693 (storage_source_destroy) New function.
3694 (storage_source_get_cases) New function.
3695 (storage_source_on_disk) New function.
3696 (storage_source_read) New function.
3697 (storage_source_set_cases) New function.
3698 (storage_source_to_disk) New function.
3699 (storage_to_disk) New function.
3700 (struct storage_stream_info) New structure.
3701 (write_storage_file) New function.
3702 (procedure_write_case) Removed.
3703 (create_case_source) Add `struct dictionary *' parameter, all
3705 (create_case_sink) Ditto.
3706 (free_case_sink) New function.
3707 (struct split_aux_data) New structure.
3708 (procedure_with_splits) New function implementing what procedure()
3710 (SPLIT_FILE_proc_func) Removed.
3711 (procedure_with_splits_callback) New function.
3712 (equal_splits) New function.
3714 * aggregate.c: Pass around a struct instead of using statics.
3715 (static var outfile) Remove.
3716 (enum type) Give it tag `missing_treatment'.
3717 (static var missing) Remove.
3718 (static var sort) Remove.
3719 (static var agr_first) Remove.
3720 (static var agr_next) Remove.
3721 (static var case_count) Remove.
3722 (static var prev_case) Remove.
3723 (static var buf64_1xx) Remove.
3724 (static var buf_1xx) Remove.
3725 (struct agr_proc) New structure incorporating the above.
3726 (cmd_aggregate) Use new struct. Clean up error handling using
3727 agr_destroy(). Completely rewrite actual implementation of
3729 (create_sysfile) Add struct agr_proc * parameter, modify
3731 (parse_aggregate_functions) Ditto.
3732 (free_aggregate_functions) Ditto. Rename agr_destroy().
3733 (aggregate_single_case) Add struct agr_proc * parameter, modify
3735 (accumulate_aggregate_info) Ditto.
3736 (dump_aggregate_info) Ditto.
3737 (initialize_aggregate_info) Ditto.
3738 (agr_00x_trns_proc) Removed.
3739 (agr_00x_end_func) Removed.
3740 (agr_10x_trns_proc) Removed.
3741 (agr_10x_trns_free) Removed.
3742 (agr_10x_end_func) Removed.
3743 (agr_11x_read) Removed.
3744 (agr_11x_finish) Removed.
3745 [DEBUGGING] (debug_print) Removed.
3746 (write_case_to_sfm) Add struct agr_proc * parameter, modify
3748 (agr_to_active_file) New function.
3749 (presorted_agr_to_sysfile) New function.
3750 (sort_agr_to_sysfile) New function.
3752 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
3754 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
3756 * descript.q: (cmd_descriptives) Ditto.
3758 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
3759 to new procedure() interface.
3761 * command.c: (cmd_execute) Adapt to new procedure() interface.
3763 * dictionary.c: (dict_compact_values) Also delete scratch
3765 (dict_get_compacted_value_cnt) New function.
3766 (dict_get_compacted_idx_to_fv) New function.
3768 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
3769 (cmd_flip) Adapt to new procedure() interface.
3770 (flip_sink_write) Use sink->idx_to_fv.
3772 * frequencies.q: (internal_cmd_frequencies) Use
3773 procedure_with_splits().
3775 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
3776 (static var mtf_sink) New static var.
3777 (static var mtf_case) New static var.
3778 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
3779 we actually implement the matching.
3780 (mtf_delete_file_in_place) Use mtf_case.
3781 (mtf_processing) Use mtf_case and mtf_sink.
3782 (cmd_export) Adapt to new procedure() interface.
3784 * levene.c: (levene) Use procedure_with_splits().
3786 * list.q: (cmd_list) Use procedure_with_splits().
3788 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
3789 procedure() interface.
3790 (read_matrices_with_rowtype) Ditto.
3792 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
3793 TEMPORARY. Adapt to new procedure() interface.
3795 * rename-vars.c: Warn about and cancel TEMPORARY.
3797 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
3798 (sort_cases) Use dict_get_compacted_value_cnt() instead of
3799 compaction_nval. Adapt to new procedure() interface. Use
3800 storage_source_to_disk().
3801 (do_internal_sort) Don't try to dump the cases to memory.
3802 (compare_case_lists) Pass null idx_to_fv.
3803 (struct initial_run_state) Add `idx_to_fv' member. Remove
3805 (write_initial_runs) Don't initialize irs->case_size. Adapt to
3806 new procedure() interface. Reset irs->idx_to_fv after calling
3808 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
3809 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
3811 (destroy_initial_run_state) Don't dereference irs after freeing
3813 (allocate_cases) Don't calculate case_size locally.
3814 (compare_record) Add idx_to_fv parameter.
3815 (compare_record_run) Change parameter from struct sort_cases_pgm *
3816 to struct initial_run_state *. Pass irs->idx_to_fv to
3818 (compare_record_run) Third parameter now a struct
3819 initial_run_state *.
3820 (output_record) No need for out_case anymore. Pass irs, not
3821 struct sort_cases_pgm to pop_heap(). Use case_size from struct
3823 (merge) Use case_size from struct sort_cases_pgm.
3824 (merge_once) Use case_size from struct sort_cases_pgm.
3825 Pass null pointer to compare_record() as idx_to_fv.
3826 (global var sort_sink_class) Make static.
3828 * t-test.q: (cmd_t_test) Use procedure_with_splits().
3830 * temporary.c: Remove debugging crap.
3832 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
3834 * t-test.q, levene.c: Fixed up the handling of MISSING values
3837 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
3839 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
3842 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
3844 Change explicit variable name checks into use of
3845 dict_class_from_id().
3847 * dictionary.c: (dict_create_var) Change explicit variable name
3848 check into use of dict_class_from_id().
3850 * get.c: (trim_dictionary) Ditto.
3852 * sel-if.c: (cmd_filter) Ditto.
3854 * sysfile-info.c: (cmd_display) Ditto.
3856 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
3858 * vfm.c: (arrange_compaction) Ditto.
3860 * weight.c: (cmd_weight) Ditto.
3862 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
3864 * temporary.c: (cmd_temporary) When TEMPORARY was the first
3865 transformation following the input program, if any, for some
3866 reason we special-cased f_trns. That's just wrong. It should
3867 always be set to n_trns.
3869 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
3871 * format.c: (parse_format_specifier_name) Fix brown-bag bug
3872 introduced in last check-in.
3874 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
3876 * format.c: (global array translate_fmt[]) Removed.
3877 (translate_fmt) New function as replacement.
3878 (parse_format_specifier_name) Rewrite.
3880 * pfm-read.c: (convert_format) Use translate_fmt() instead of
3883 * sfm-read.c: (parse_format_spec) Ditto.
3885 * postscript.c: (text) Fix handling of fonts with missing
3888 * sort.c: (struct external_sort) Add temp_name member.
3889 (destroy_external_sort) Free temp_dir, temp_name members.
3890 (init_external_sort) Allocate temp_name.
3891 (get_temp_file_name) Change prototype.
3892 (open_temp_file) Deal with change to get_temp_file_name().
3893 (close_temp_file) Ditto.
3894 (remove_temp_file) Ditto.
3895 (write_temp_file) Ditto.
3896 (read_temp_file) Ditto.
3897 (sort_sink_destroy) Removed.
3898 (sort_sink_class) Change destroy member to null.
3900 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
3902 Eliminate temp_case.
3904 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
3905 anymore. Use agr_11x_finish().
3906 (aggregate_single_case) Make first param const.
3907 (accumulate_aggregate_info) Ditto.
3908 (agr_00x_end_func) Use compaction_case, not temp_case.
3909 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
3911 * data-list.c: (struct data_list_pgm) Add `case_size' member.
3912 (cmd_data_list) Initialize case_size.
3913 (read_from_data_list_fixed) Add struct ccase * param, use instead
3915 (read_from_data_list_free) Ditto.
3916 (read_from_data_list_list) Ditto.
3917 (read_one_case) Rename data_list_trns_proc(), all references
3918 updated. Add argument in calling above functions. Use c
3919 argument instead of temp_case.
3920 (destroy_dls) Rename data_list_trns_free(), all references
3923 * expr-evl.c: (expr_evaluate) Make second parameter const.
3925 * file-type.c: (struct file_type_pgm) Add `case_size' member.
3926 (cmd_end_file_type) Initialize `case_size'.
3927 (file_type_source_read) Add struct ccase * parameter. Use instead
3930 * flip.c: Rewritten.
3932 * get.c: (struct get_pgm) New structure to keep track of
3934 (cmd_get) Initialize case_size.
3936 (get_source) Deal with struct get_pgm.
3937 (get_source_read) Add struct ccase * parameter, use instead of
3939 (import_source_read) Ditto.
3941 * get.c: Use a null pointer instead of temp_case to represent the
3942 "current case" in a struct mtf_file's input member.
3943 (mtf_processing_finish) Pass null to mtf_processing(), not
3945 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
3946 (mtf_compare_BY_values) Add extra arg, use instead of null input
3948 (mtf_processing) Use c parameter instead of temp_case. Pass
3949 compaction_case to process_active_file_output_case().
3951 * glob.c: (global variable temp_case) Removed.
3953 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
3954 (cmd_input_program) Initialize case_size. Set
3955 vfm_source->value_cnt.
3956 (init_case) Add struct ccase * parameter, use instead of
3959 (input_program_source_read) Ditto.
3961 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
3962 (dump_cell_content) Ditto.
3963 (nr_output_data) Ditto.
3964 (read_matrices_without_rowtype) Ditto.
3965 (matrix_data_read_with_rowtype) Ditto.
3966 (wr_read_splits) Ditto.
3967 (wr_output_data) Ditto.
3969 * sort.h: (struct sort_cases_pgm) New member `case_size'.
3971 * sort.c: (sort_cases) Initialize scp->case_size.
3972 (struct external_sort) Remove `case_size' member.
3973 (write_initial_runs) Only call vfm_sink->class_destroy if
3975 (struct sort_source_aux) New structure.
3976 (sort_source_read_helper) New function.
3977 (sort_source_read) Use sort_source_read_helper().
3978 (read_sort_output) Change interface to be more reasonable.
3979 (read_internal_sort_output) Ditto.
3980 (read_external_sort_output) Ditto.
3982 * vars-prs.c: (dict_class_to_name) Pass return value through
3985 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
3986 (procedure) Initialize trns_case.
3987 (procedure) Pass trns_case to vfm_source->class->read().
3989 (process_active_file) Start using struct procedure_aux_data.
3990 (process_active_file_write_case) Pass trns_case to
3991 transformations, lag_case(), clear_case().
3992 (process_active_file_output_case) Add struct ccase * parameter.
3993 (create_trns_case) New function.
3994 (make_temp_case) Removed.
3995 (vector_initialization) Removed.
3996 (close_active_file) Only call make_source if non-null, otherwise
3997 set vfm_source to null pointer. Don't free temp_case.
3998 (disk_source_read) Add struct ccase * parameter, use instead of
4000 (memory_source_read) Ditto.
4001 (lag_case) Add const struct ccase * member.
4002 (procedure_write_case) Use trns_case instead of temp_case.
4003 (clear_case) Add struct ccase * member, use instead of temp_case.
4004 (exclude_this_case) Ditto.
4005 (create_case_source) Add struct dictionary * parameter, use to
4006 initialize source->value_cnt.
4008 * vfm.h: (struct case_source) Add `value_cnt' member.
4009 (struct case_source_class) Add struct ccase * parameter to `read'
4010 member function pointer.
4011 (struct case_sink_class) Make struct ccase * parameter const in
4012 `write' member function pointer.
4014 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
4016 Fix a lot of "possibly uninitialized variable" warnings. Some of
4017 them are even real bugs. A few of them make me wonder how the
4020 * aggregate.c: (parse_aggregate_functions) Initialize `function.
4022 * ascii.c: (output_lines) Add default case to switch.
4024 * crosstabs.q: Remove static variable `expected' and all
4026 (display_crosstabulation) Always calculate expected value.
4028 (output_pivot_table) Initialize `cmp'.
4029 (display_crosstabulation) New variable `last_row', which is
4032 * data-in.c: (parse_numeric) Always initialize sign. How did this
4035 * data-list.c: (repeating_data_trns_proc) Always initialize code.
4036 Always set info.ofs. (How did this work?!)
4038 * expr-opt.c: (optimize_tree) Always initialize `m'.
4039 (evaluate_tree) Always initialize `c'. (How did this work?)
4041 * frequencies.q: (frq_custom_variables) Always initialize min,
4043 (frq_custom_grouped) Always initialize `dl'.
4045 * groff-font.c: (groff_read_font) Always initialize char_set.
4047 * matrix-data.c: (nr_output_data) Initialize `split'.
4048 (wr_read_splits) Remove shadowing split_cnt declaration.
4049 (wr_output_data) Initialize `split'.
4051 * output.c: (tokener) Skip add character on syntax error.
4053 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
4055 * postscript.c: (read_ps_encodings) Use line.string instead of
4057 (write_text) Add default case to switch.
4058 (text) Always initialize multiple variables. Fix bug with
4061 * print.c: (fixed_parse_fortran) Initialize head.
4062 (alloc_line) Add default case to switch.
4064 * recode.c: (parse_dest_spec) Handle case where nothing matches.
4065 (recode_trns_proc) Move variable declaration inward. Add default
4068 * sfm-read.c: (read_header) Initialize skip_amt.
4070 * sysfile-info.c: (display_variables) Always initialize pc.
4072 * vars-prs.c: Initialized `included'.
4074 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
4076 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
4077 Just use signal() instead.
4079 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
4081 Get rid of vfm_sink_info and vfm_source_info.
4083 * aggregate.c: (agr_00x_end_func) Don't increment
4084 sfm_sink_info.ncases.
4086 * sort.c: (do_internal_sort) Get case count from
4087 vfm_source->class->count().
4088 (struct external_sort) Add `case_size' member.
4089 (do_external_sort) Initialize case_size.
4090 (struct initial_run_state) Add `case_size' member.
4091 (write_initial_runs) Initialize case_size.
4092 (sort_sink_write) Use case_size.
4093 (read_external_sort_output) Use case_size. Get case_cnt from
4096 * vfm.c: (struct write_case_data) Add underscores to existing arg
4097 names, all references updated. Renamed `aux' as `func_aux', all
4098 references updated. Added new `aux' member.
4099 (global var vfm_source_info) Removed.
4100 (global var vfm_sink_info) Removed.
4101 (struct procedure_aux_data) New.
4102 (struct split_aux_data) New.
4103 (procedure) Use `aux' fields for procedure_aux_data,
4105 (process_active_file_write_case) Pass case_count + 1 to
4106 transformation procedures, exclude_this_case().
4107 (process_active_file_output_case) Don't increment
4108 vfm_sink_info.ncases.
4109 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
4110 to send data to disk early.
4111 (make_temp_case) Don't use vfm_sink_info.case_size.
4112 (close_active_file) Don't initialize vfm_source_info.
4113 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
4114 (disk_sink_create) Initialize and/or update disk_stream_info.
4115 (disk_sink_write) Ditto.
4116 (disk_sink_destroy) Ditto.
4117 (disk_sink_make_source) Ditto.
4118 (disk_source_read) Ditto.
4119 (disk_source_destroy) Ditto.
4120 (global var disk_source_class) Add disk_source_count().
4121 (disk_source_count) New function.
4122 (struct memory_sink_info) Add `case_cnt', `case_size' members.
4123 (struct memory_source_info) Ditto.
4124 (memory_sink_create) Deal with case_cnt, case_size.
4125 (memory_sink_write) Ditto.
4126 (memory_sink_make_source) Ditto.
4127 (memory_source_read) Ditto.
4128 (memory_source_count) New function.
4129 (memory_source_class) Add memory_source_count().
4130 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
4131 proc_aux->cases_written, and pass it to transformation procedures
4132 and exclude_this_case ().
4133 (exclude_this_case) Add case_num parameter. Pass it to
4135 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
4138 * vfm.h: (struct case_source_class) Add `count' member.
4140 * vfmP.h: (struct stream_info) Removed.
4141 (global variable vfm_source_info) Removed.
4142 (global variable vfm_sink_info) Removed.
4144 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
4146 * var.h: (typedef trns_proc_func) New typedef.
4147 (trns_free_func) New typedef.
4148 (struct trns_header) Change `proc' to type trns_proc_func, `free'
4149 to type trns_free_func. This only changes the actual type of
4150 trns_proc_func, adding a `case_num' parameter. Updated all
4151 implementations to use the typedefs instead.
4153 * compute.c: (compute_num) Pass case_num to expr_evaluate().
4154 (compute_num_vec) Ditto.
4155 (compute_str) Ditto.
4156 (compute_str_vec) Ditto.
4158 * do-if.c: (do_if_trns_proc) Ditto.
4160 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
4163 * inpt-pgm.c: (input_program_source_read) Maintain case count,
4164 pass to transformation functions.
4165 (reread_trns_proc) Pass case_num arg to expr_evaluate().
4167 * loop.c: (loop_1_trns_proc) Ditto.
4168 (loop_2_trns_proc) Ditto.
4169 (loop_3_trns_proc) Ditto.
4171 * print.c: (print_space_trns_proc) Ditto.
4173 * sel-if.c: (select_if_proc) Ditto.
4175 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
4177 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
4178 destroying hash table.
4180 * glob.c: (read_active_file) Variable not referenced, removed.
4181 (cancel_input_pgm) Ditto.
4183 * levene.c: Add #include <stdlib.h> needed to call free().
4185 * aggregate.c: (parse_aggregate_functions) Make `function'
4188 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
4190 Start working to eliminate VFM dependence on static variables.
4192 * command.c: (cmd_parse) Use case_source_is_class().
4194 * data-list.c: Rewrite to eliminate use of static variables.
4196 * dfm.c: (cmd_begin_data) Use case_source_is_class().
4198 * file-handle.q: (fh_handle_name) Make parameter const.
4200 * file-type.c: Rewrite to eliminate use of static variables.
4202 * flip.c: Rewrite to eliminate use of static variables.
4204 * format.c: (get_format_var_width) New function.
4206 * get.c: Eliminate use of static variables.
4208 * inpt-pgm.c: Eliminate use of static variables.
4210 * matrix-data.c: Eliminate use of static variables.
4212 * set.q: (set_max_workspace) New variable.
4213 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
4215 * var.h: (struct case_list) Move here from vfmP.h.
4217 * vars-atr.c: (discard_variables) Handle new vfm_source type.
4219 * vfm.c: (vfm_source) Change type from struct case_stream to
4221 (vfm_sink) Change type from struct case_stream to struct
4223 (static var paging) Rename workspace_overflow, all references
4225 (procedure) Use new class structures.
4226 (process_active_file) Ditto.
4227 (process_active_file_write_case) Ditto.
4228 (prepare_for_writing) Use set_max_workspace. Use new class
4230 (close_active_file) Use new class structures. Free old sink.
4231 (global var disk_source_file) Removed.
4232 (global var disk_sink_file) Removed.
4233 (disk_stream_init) Removed.
4234 (disk_stream_read) Removed.
4235 (disk_stream_write) Removed.
4236 (disk_stream_mode) Removed.
4237 (disk_stream_destroy_source) Removed.
4238 (disk_stream_destroy_sink) Removed.
4239 (global var vfm_disk_stream) Removed.
4240 (disk_sink_create) New function.
4241 (disk_sink_write) New function.
4242 (disk_sink_destroy) New function.
4243 (disk_sink_make_source) New function.
4244 (disk_sink_class) New static var.
4245 (disk_source_read) New function.
4246 (disk_source_destroy) New function.
4247 (global var vfm_source_class) New var.
4248 (global var memory_source_cases) Removed.
4249 (global var memory_sink_cases) Removed.
4250 (global var memory_sink_max_cases) Removed.
4251 (struct memory_sink_info) New struct.
4252 (memory_stream_init) Removed.
4253 (memory_stream_read) Removed.
4254 (memory_stream_write) Removed.
4255 (memory_stream_mode) Removed.
4256 (memory_stream_destroy_source) Removed.
4257 (memory_stream_destroy_sink) Removed.
4258 (global var vfm_memory_stream) Removed.
4259 (page_to_disk) Renamed write_active_file_to_disk().
4260 (memory_sink_create) New function.
4261 (memory_sink_write) New function.
4262 (memory_sink_destroy) New function.
4263 (memory_sink_make_source) New function.
4264 (memory_sink_class) New static var.
4265 (memory_source_read) New function.
4266 (memory_source_destroy) New function.
4267 (memory_source_get_cases) New function.
4268 (memory_source_set_cases) New function.
4269 (global var vfm_source_class) New var.
4270 (procedure_write_case) Use new class structures.
4271 (create_case_source) New function.
4272 (case_source_is_complex) New function.
4273 (case_source_is_class) New function.
4274 (create_case_sink) New function.
4276 * vfm.h: (global variable reinit_sysmis) Not used, removed.
4277 (global variable reinit_blanks) Not used, removed.
4278 (global variable init_zero) Not used, removed.
4279 (global variable init_blanks) Not used, removed.
4280 (struct case_source) New struct.
4281 (struct case_source_class) New struct.
4282 (struct case_sink) New struct.
4283 (struct case_sink_class) New struct.
4284 (struct case_stream) Removed.
4286 * vfmP.h: (struct case_list) Moved to var.h.
4288 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
4290 * algorithm.c: (count_equal) New function.
4291 (count_if) New function.
4292 (unique) Add assertions.
4293 (partition) Add assertions.
4294 (is_partitioned) New function.
4295 (copy_if) Add assertions.
4296 (remove_equal) Add assertions.
4297 (lexicographical_compare) Rename lexicographical_compare_3way.
4298 (sort) Add assertions. Rephrase some code.
4299 (is_sorted) New function.
4301 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
4305 * sort.c: Completely rewrite.
4307 * sort.h: Expose interface via struct sort_cases_pgm, not via
4310 * aggregate.c: (sort) New static var.
4311 (cmd_aggregate) Use sort.
4312 (create_sysfile) Ditto.
4313 (aggregate_single_case) Ditto.
4314 (dump_aggregate_info) Ditto.
4315 (agr_00x_end_func) Ditto.
4316 (debug_print) Ditto.
4318 * var.h: (enum SRT_ASCEND) Removed.
4319 (enum SRT_DESCEND) Removed.
4320 (struct sort_cases_proc) Removed.
4321 (struct variable) Remove p.srt member.
4323 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
4325 Get rid of the old, crappy heap structure and replace it by a new,
4326 shiny, C++ STL-like heap structure.
4328 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
4330 * algorithm.c: (push_heap) New function.
4341 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
4343 Increase warning level.
4345 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
4347 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
4349 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
4351 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
4353 * dictionary.c: (dict_create_var) Fix root cause of bug worked
4354 around by previous change log entry.
4356 * compute.c: (lvalue_finalize) Remove workaround from previous
4359 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4361 * compute.c: Fixed a bug where the Format was not getting set for
4362 computed variables (thus causing a crash when SAVEing).
4364 * Added a test to stop this bug ever coming back
4366 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
4368 Got rid of approx.h. In general, replaced all references to
4369 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
4372 * Makefile.am: (pspp_SOURCES) Removed approx.h.
4374 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
4375 test for mag < EPSILON.
4377 * misc.h: Add definition of EPSILON.
4379 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
4381 * vfm.c: (procedure) Add check to prevent recursive call.
4383 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
4385 * Moved the declarations relating to values to their own header file
4388 * Added levene.c and levene.h
4390 * vars-atr.c: Changed the signature of compare_values to
4391 take const * arguments.
4393 * t-test.q: Changed the structure of struct t_test_proc
4394 variables now contain their own group statistics information.
4395 Eventually, t_test_proc might get renamed, because it'd be
4396 applicable to other commands too.
4398 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
4400 * data-out.c: Clean up. Changed interface of convert_*() to take
4401 either a `double' or a `const char *' instead of a `const union
4402 value *'. Update all implementations of those interfaces.
4403 (data_out) Use switch statements instead of a table.
4404 (convert_AHEX) Rewrite.
4406 * format.h: Update comment.
4408 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
4410 * q2c.c: (dump_header) Add an Emacs header line to output files
4411 that makes generated .c files read-only by default, to make it
4412 difficult to accidentally change generated files.
4414 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
4416 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
4417 not bogus a->v.c <=> b->v.c pointer compare.
4418 (compare_freq_alpha_a) Ditto.
4419 (compare_freq_numeric_d) Ditto.
4420 (compare_freq_alpha_d) Ditto.
4422 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
4424 Changed data_out() to store string data directly into a `union
4425 value''s s member, not indirectly into c.
4427 * crosstabs.q: (output_pivot_table) Use format_short() instead of
4429 (table_value_missing) Ditto.
4430 (float_M_suffix) Ditto.
4431 (format_short) New function.
4433 * data-in.h: (data_in_finite_line) Remove inline definition.
4435 * data-list.c: (destroy_dls_var_spec) New function.
4436 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
4437 (data_list_source_destroy_source) Avoid cast.
4438 (struct repeating_data_trns) New field `id_value'. Update
4440 (cmd_repeating_data) Initialize id_value. Use new
4441 repeating_data_trns_free() for freeing REPEATING DATA
4443 (rpd_parse_record) Rewrite support for record ID to be less bogus.
4444 (repeating_data_trns_free) New function.
4446 * data-out.c: (data_out) Change return type to `void' by replacing
4447 error returns by writing a message into the output buffer.
4448 (convert_A) Read from v->s instead of v->c.
4449 (convert_AHEX) Ditto.
4451 * expr-evl.c: Update comment.
4452 (expr_evaluate) Add assertion in OP_STRING case.
4454 * format.h: (macro MAX_FORMATTED_LEN) New macro.
4456 * list.q: (list_cases) Update for new data_out() semantics.
4458 * print.c: (print_trns_proc) Ditto.
4460 * tab.c: (tab_value) Ditto.
4461 (tab_float) Avoid stupid cast.
4463 * var.h: Update comments.
4464 (macro MAX_STRING) New macro.
4465 (macro MAX_ELEMS_PER_VALUE) New macro.
4467 * vars-atr.c: (compare_values) New function.
4469 * vfm.c: (dump_splits) Update for new data_out() semantics.
4471 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
4473 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
4475 (struct crosstab) Rename v[] to vars[]. All references updated.
4476 (hash_table_entry) Replace the hash algorithm and fix a bug at the
4477 same time, which caused the hash value to depend only on a single
4478 value, not all of the variables' values.
4480 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
4482 Clean up struct dictionary's value_cnt usage.
4484 * dictionary.c: Add a function comment to each function.
4485 (struct dictionary) Rename value_cnt to next_value_idx, which more
4486 accurately reflects its meaning. All references updated.
4487 (dict_rename_vars) Add assertion.
4488 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
4490 (dict_get_case_size) New function.
4492 * aggregate.c: (create_sysfile) Use dict_get_case_size().
4494 * get.c: (mtf_read_nonactive_records) Ditto.
4496 * sort.c: (allocate_cases) Ditto.
4497 (write_initial_runs) Ditto.
4501 * vfm.c: (prepare_for_writing) Ditto.
4505 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
4507 Make vfm.c slightly less grotesque.
4509 * vfm.c: (filter_var) Removed.
4510 (filter_index) Removed.
4511 (FILTERED macro) Removed.
4512 (exclude_this_case) New function.
4513 (process_active_file_write_case) Use exclude_this_case() instead
4514 of FILTERED and inline tests.
4515 (procedure_write_case) Ditto.
4516 (setup_filter) Removed.
4517 (open_active_file) Don't call setup_filter().
4518 (close_active_file) Call dict_get_filter() instead of checking
4521 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
4523 * var.h: (struct variable) Update comments.
4525 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
4527 New functions dict_create_var_assert(), dict_lookup_var_assert().
4528 Converted several dict_*_var()/assert pairs into a single
4529 dict_*_var_assert().
4531 * dictionary.c: (dict_create_var_assert) New function.
4532 (dict_lookup_var_assert) New function.
4534 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
4536 Got rid of "struct long_vec", envector(), devector(), etc. Added
4537 two members `init', `reinit' to struct variable as a substitute.
4539 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
4545 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
4548 * autorecode.c: (cmd_autorecode) destvars don't need init.
4550 * compute.c: (lvalue_finalize) Set reinit.
4552 * data-list.c: (fixed_parse_compatible) Don't need init usually.
4553 (dump_fmt_list) Ditto.
4556 * descript.q: (run_z_pass) Don't need init for z-scores.
4558 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
4560 (dict_clone_var) Copy `reinit' member, initialize `init' member.
4562 * glob.c: (init_glob) Remove vec_init() calls.
4564 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
4566 * loop.c: (internal_cmd_loop) Don't need to call envector().
4568 * numeric.c: (cmd_numeric) Ditto.
4570 (cmd_leave) Ditto. Set `init', `reinit' members.
4572 * recode.c: (cmd_recode) Don't need to call envector().
4574 * repeat.c: (internal_cmd_do_repeat) Ditto.
4576 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
4577 (force_create_variable) Removed prototype.
4578 (force_dup_variable) Ditto.
4580 * vector.c: (cmd_vector) Don't need to call envector().
4582 * vfm.c: (reinit_sysmis) Removed.
4583 (reinit_blanks) Removed.
4584 (init_zero) Removed.
4585 (init_blanks) Removed.
4586 (process_active_file_write_case) No need to deal with vectors.
4587 Call clear_temp_case().
4588 (vector_initialization) Rewrite to use `init', `reinit'.
4589 (close_active_file) No need to call vec_clear().
4590 (procedure_write_case) Call clear_temp_case().
4591 (clear_temp_case) New function.
4593 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
4595 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
4598 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
4600 Add auxiliary argument to procedure() interface. Associated small
4601 clean-ups of vfm interface.
4603 * Updated every caller of procedure() and process_active_file() to
4604 reflect modified interface. Simple, ordinary changes not listed
4607 * Updated every function that implements struct case_stream's
4608 `read' function to take a write_case_func and a write_case_data.
4609 Also updated every caller of write_case() to instead call them
4610 through these arguments. In some cases this meant that the extra
4611 args had to be threaded through a couple of extra levels. This
4612 wasn't difficult or interesting so the details won't be given.
4614 * data-list.c: (struct repeating_data_trns) Add members
4615 `write_case', `wc_data' as kluge.
4616 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
4618 (repeating_data_set_write_case) New function.
4620 * data-list.h: New file to declare repeating_data_trns_proc() and
4621 repeating_data_set_write_case().
4623 * inpt-pgm.c: (input_program_source_read) Call
4624 repeating_data_set_write_case() for all the REPEATING DATA
4625 transformations, so that they know where to send their cases.
4626 It's a big kluge. Also kluge in END CASE.
4627 (end_case_trns_proc) Never called anymore, but we still need it,
4630 * sort.c: (read_sort_output) Update to match struct case_stream
4633 * vfm.c: (struct write_case_data) New structure.
4634 (proc_func) Removed.
4635 (virt_proc_func) Removed.
4636 (begin_func) Removed.
4637 (virt_begin_func) Removed.
4639 (write_case) Removed.
4640 (procedure) Added an auxiliary parameter to each function pointer
4641 argument's prototype. Added an auxiliary data parameter.
4643 (process_active_file) Ditto.
4644 (process_active_file_write_case) Pass aux data along.
4645 (close_active_file) Ditto.
4646 (procedure_write_case) Ditto.
4647 (SPLIT_FILE_procfunc) Ditto.
4649 * vfm.h: (typedef write_case_data) New.
4650 (typedef write_case_func) New.
4651 (struct case_stream) Add parameters to `read' member prototype.
4653 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
4655 * t-test.q: Added calculations for independent samples. (But no Levene
4658 * Makefile.am: Moved q_sources_c into own variable
4660 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
4662 Miscellaneous cleanups.
4664 * Change unused to UNUSED in many source files to reflect modified
4665 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
4666 __CYGWIN32__, __unix__, and unix not to assume that they're
4667 defined to a nonzero value. Change use of __attribute__ to use
4668 NO_RETURN or PRINTF_FORMAT instead.
4670 * alloc.h: Move definitions for local_alloc(), local_free() here
4671 from ../pref.h.orig and simplify.
4673 * expr-evl.c: Instead of working differently based on PAGED_STACK,
4674 use a pool allocator unconditionally.
4675 (CHECK_STRING_SPACE) Removed.
4676 (ALLOC_STRING_SPACE) Removed.
4677 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
4680 * expr-opt.c: (dump_expression) Allocate string pool.
4682 * expr-prs.c: (expr_free) Free string pool.
4684 * pool.c: (pool_destroy) This pool must be removed from its
4685 parent's list of gizmos, not from its own. Use free_all_gizmos().
4686 (pool_clear) New function.
4687 (free_all_gizmos) New function.
4688 (pool_alloc) Use space in empty block after this one if any.
4689 (pool_release) Only empty out blocks, don't actually free() them.
4691 * print.c: Get rid of PAGED_STACK special case by always
4692 dynamically allocating line buffers.
4693 (struct print_trns) Always include the `line' member.
4694 (internal_cmd_print) Always initialize the `line' member.
4695 (alloc_line) Always allocate memory for `line'.
4696 (print_trns_proc) Always initialize buf from `line' member.
4697 (print_trns_free) Always free `line' memory.
4699 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
4702 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
4704 * flip.c: Fixed crash from FLIP when a numeric variable is
4705 specified on NEWNAMES and a large value is used, and a couple of
4706 other minor bugs besides.
4707 (struct varname) Make name a 9-character fixed-size array
4708 instead of a 1-character variable size array.
4709 (make_new_var) Allow digits in variable names.
4710 (flip_stream_write) Limit numeric values to 8 characters and
4711 format system missing and very large and small values more
4714 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4716 * command.c: Fixed test on command return status for the correct
4717 value, which had been causing a crash under certain invalid input.
4719 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
4721 * t-test.q: Added calculations for the one sample variant of the T-TEST
4723 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
4725 * tab.c: (render_strip) Fix bug that sometimes caused joined text
4726 in joined cells to be rendered outside box boundaries.
4728 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
4730 * random.c (rng_create): Fixed seeding so that it gets reseeded after
4731 SET seed=xx has been called.
4733 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
4735 * random.c (rng_get_double): Fix always-returning-zero bug in my
4736 preferred way, and at the same time make sure rounding doesn't
4739 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
4741 * html.c: (change_attributes) Dead code, removed.
4742 (escape_string) Eliminate code to call change_attributes() that
4743 never actually called it.
4744 (output_tab_table) Get rid of dependence on tab_hit
4745 and struct tab_joined_cell's hit member, which are abominations.
4747 * tab.c: (tab_output_text) Don't call
4748 d->class->text_set_font_by_name if it's a null pointer.
4749 (macro UNROLL_LOOP) Eliminate.
4750 (macro UNROLL_3_LOOPS) Eliminate.
4751 (tabi_render) Rewrite not to use the above macros.
4753 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
4755 Start working on a new output driver system, one that doesn't suck
4756 so much, by adding a "device-independent" output driver. The idea
4757 is to write out only a single output stream, then use separate
4758 processes to translate them into whatever formats we want. This
4759 is similar to how "groff" works with its various output drivers
4760 (grops, grotty, grodvi, ...).
4762 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
4764 * list.q: (write_all_headers) Stub out devind class.
4766 (determine_layout) Ditto.
4769 * output.c: (outp_init) Add devind class.
4771 * devind.c: New file.
4773 * devind.h: New file.
4775 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
4777 * frequencies.q: (hash_value_alpha) Fixed up the previous change
4778 to use the proper string length.
4780 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4782 * Fixed bug where FREQ would crash on alpha values
4784 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
4786 * Removed bletcherous alloca() workarounds for AIX from top of
4787 many files. AIX can use the alternative alloca() implementation
4790 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
4792 * ascii.c: (ascii_option) Fix implementation of headers option.
4794 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
4796 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
4797 multiple blank lines into one.
4798 (struct ascii_driver_ext) Add squeeze_blank_lines option.
4799 (ascii_preopen_driver) Initialize squeeze_blank_lines.
4800 (static var option_tab) Add squeeze entry.
4801 (ascii_option) Set squeeze_blank_lines.
4802 (output_lines) Implement squeezing blank lines.
4804 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
4806 * Removed redundant code from output.h
4808 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
4810 Dictionary classes: each variable is "ordinary", "system", or
4813 * var.h: (enum dict_class) New enum.
4815 * vars-prs.c: (dict_class_from_id) New function.
4816 (dict_class_to_name) New function.
4818 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
4820 * var.h: (struct freq_tab_set) Removed (not used).
4822 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
4824 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
4826 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
4828 * stats.c: (hypercube) Rename pow4(). All references updated.
4830 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
4832 * rename-vars.c: (cmd_rename_variables) Rewritten.
4833 (compare_name) Removed.
4835 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
4837 var_set feature, and code taking advantage of it.
4839 * crosstabs.q: (static var var_dict) Removed.
4840 (static var variables) New variable.
4841 (static var variables_cnt) New variable.
4842 (cmd_crosstabs) Free variables instead of var_dict.
4843 (internal_cmd_crosstabs) Initialize and use variables,
4844 variables_cnt instead of var_dict.
4845 (free_var_dict) Removed.
4846 (crs_custom_tables) Use var_set instead of a copied dictionary.
4847 (crs_custom_variables) Set up variables, variables_cnt instead of
4849 [DEBUGGING] (debug_print) Ditto.
4851 * means.q: (mns_custom_tables) Use var_set instead of a copied
4854 * vars-prs.c: (parse_vs_variable) New function.
4855 (parse_dict_variable) Rewritten.
4856 (parse_variable) Rewritten.
4857 (parse_variables) Renamed parse_var_set_vars(), rewritten.
4858 (parse_variables) New function in terms of parse_var_set_vars().
4859 Now requires its first argument to be non-null. All references
4860 that passed a null pointer updated to pass default_dict instead.
4861 (macro id_dict) Removed.
4862 (parse_DATA_LIST_vars) Add assertions.
4863 (parse_mixed_vars) Ditto.
4864 (struct var_set) New structure.
4865 (var_set_get_cnt) New function.
4866 (var_set_get_var) New function.
4867 (var_set_lookup_var) New function.
4868 (var_set_destroy) New function.
4869 (dict_var_set_get_cnt) New function.
4870 (dict_var_set_get_var) New function.
4871 (dict_var_set_lookup_var) New function.
4872 (dict_var_set_destroy) New function.
4873 (var_set_create_from_dict) New function.
4874 (struct array_var_set) New structure.
4875 (array_var_set_get_cnt) New function.
4876 (array_var_set_get_var) New function.
4877 (array_var_set_lookup_var) New function.
4878 (array_var_set_destroy) New function.
4879 (var_set_create_from_array) New function.
4881 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
4882 instead of parse_variables(NULL, ...) in output code.
4884 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
4886 Change inp_init from a 2-bit vector to an ordinary array.
4887 Initialize it all in cmd_end_input_program() instead of in
4890 * inpt-pgm.c: (enum value_init_type) New enum.
4891 (global var inp_init) Change to `enum value_init_type *', make
4893 (inp_init_size) Removed.
4894 (inp_nval) Change to `size_t', make static.
4895 (cmd_input_program) Don't initialize inp_init or inp_init_size.
4896 (cmd_end_input_program) Initialize inp_init, inp_nval.
4897 (init_case) Rewrite.
4898 (clear_case) Rewrite.
4900 * inpt-pgm.h: Removed.
4902 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
4904 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
4905 Colin Plumb hash. It is simpler and should better resist
4907 (hsh_hash_string) Ditto.
4909 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
4911 * get.c: (export_write_case_func) Remove debug printing code.
4913 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
4915 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
4917 (save_write_case_func) Use &trns->h instead of cast.
4918 (cmd_export) Use &t->h instead of cast.
4920 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
4922 Moved vectors into the dictionary.
4924 * var.h: (struct vector) Moved here from vector.h. `index' member
4925 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
4928 * vector.h: Removed.
4930 * vector.c: (global var vec) Removed.
4931 (global var nvec) Removed.
4932 (cmd_vector) Rewritten.
4933 (find_vector) Removed.
4935 * dictionary.c: (dict_create_vector) New function.
4936 (dict_get_vector) New function, replaces reading global vec[]
4938 (dict_get_vector_cnt) New function, replaces reading global nvec
4940 (dict_lookup_vector) New function, replaces find_vector().
4941 (dict_clear_vectors) New function.
4943 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
4945 Start to move away from `struct variable' p `union' member to void
4948 * var.h: (struct variable) Add `aux' member.
4950 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
4952 Get rid of struct variable `foo' member.
4954 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
4956 (frq_custom_variables) Ditto.
4957 (frq_custom_grouped) Ditto.
4959 * get.c: (struct save_trns) Change `var' member from `int *' to
4960 `struct variable **'.
4961 (cmd_save_internal) Use aux instead of foo.
4962 (save_trns_proc) Use revised `var' member.
4963 (static var mtf_seq_no) Renamed mtf_seq_num.
4964 (static var mtf_seq_nums) New static var.
4965 (cmd_match_files) Initialize mtf_seq_nums.
4966 (mtf_free) Free mtf_seq_nums.
4967 (mtf_processing) Use mtf_seq_nums instead of foo.
4968 (mtf_merge_dictionary) No need to initialize mv->foo.
4969 (cmd_export) Use aux instead of foo. Use revised `var' member.
4970 (mns_custom_tables) Don't use foo to check for duplicates, that's
4971 what PV_NO_DUPLICATE is for.
4973 * var.h: (struct variable) Remove `foo' member.
4974 (struct frequencies_proc) New member.
4976 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
4978 Clean up COMPUTE and IF.
4980 * compute.c: More or less rewrite the darn thing.
4981 (struct compute_trns) Rename and reorder and add and delete
4983 (cmd_compute) Rewrite.
4984 (compute_num) Make conditional on test expression. Now used for
4985 both COMPUTE and IF.
4986 (compute_num_vec) Ditto.
4987 (compute_str) Ditto.
4988 (compute_str_vec) Ditto.
4991 (if_num_vec) Removed.
4993 (if_str_vec) Removed.
4994 (parse_target_expression) Renamed parse_rvalue_expression(),
4996 (new_trns) Renamed compute_trns_create(), rewritten.
4997 (delete_trns) Removed.
4998 (free_trns) Renamed compute_trns_free(), rewritten.
4999 (struct lvalue) New structure.
5000 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
5001 (lvalue_get_type) New function.
5002 (lvalue_is_vector) New function.
5003 (lvalue_finalize) New function.
5004 (lvalue_destroy) New function.
5006 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
5008 * command.def: Disallow MODIFY VARS in input mode, so that
5009 variables can't get dropped and confuse cmd_end_input_program()'s
5010 attempt to fill inp_init[].
5012 * modify-vars.c: (static var forward_positional_ordering) New
5014 (struct var_modification) Entirely changed.
5015 (rearrange_dict) Interface changed, rewritten.
5016 (cmd_modify_vars) Deal with modified struct var_modification, much
5018 (struct var_renaming) New structure.
5019 (compare_var_renaming_by_new_name) New function.
5020 (validate_var_modification) New function.
5022 * var.h: (struct modify_vars_proc) Removed.
5023 (struct variable) Removed member p.mfv.
5025 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
5027 Make EVALUATE a valid command whether we're debugging or not, so
5028 that `make check' can succeed regardless of whether debugging is
5031 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
5033 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
5035 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
5037 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
5038 statement by a simple if test.
5040 * dfm.c: (dfm_get_record) Add assertion.
5042 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
5044 For each file x.c, move #include "x.h" to the very top of the
5045 include list, to catch x.h failing to include the proper headers.
5047 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
5049 * algorithm.c: (find) New function.
5050 (remove_equal) New function.
5051 (set_difference) New function.
5052 (adjacent_find_equal) New function.
5053 [TEST_UNIQUE] Removed test case.
5054 (copy_if) Find end test.
5056 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
5058 * dictionary.c: (dict_get_case_weight) New convenience function.
5060 * aggregate.c: (accumulate_aggregate_info) Use
5061 dict_get_case_weight().
5063 * frequencies.q: (calc_general) Ditto.
5064 (calc_integer) Ditto.
5067 * t-test.q: (groups_calc) Ditto.
5070 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
5072 * glob.c: (global var default_dict) Change from `struct
5073 dictionary' to `struct dictionary *'. All references changed.
5074 (init_glob) Initialize default_dict with dict_create().
5076 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
5078 struct dictionary now made opaque. All related functions:
5080 * get.c: (rename_variables) Removed.
5081 (dict_delete_run) Removed.
5083 * temporary.c: (copy_variable) Removed.
5084 (new_dictionary) Removed.
5085 (save_dictionary) Removed.
5086 (restore_dictionary) Removed.
5087 (free_dictionary) Removed.
5089 * vars-atr.c: (clear_default_dict) Removed.
5090 (find_variable) Removed.
5091 (find_dict_variable) Removed.
5092 (create_variable) Removed.
5093 (delete_variable) Removed.
5094 (common_init_stuff) Removed.
5095 (init_variable) Removed. Updating of inp_init moved into
5096 cmd_end_input_program().
5097 (replace_variable) Removed.
5098 (rename_variable) Removed.
5099 (clear_variable) Removed.
5100 (dup_variable) Removed.
5102 * vars-prs.c: (is_varname) Removed.
5103 (is_dict_varname) Removed.
5104 (fill_all_vars) Removed.
5106 * vector.c: (find_vector) Removed.
5108 * weight.c: (stop_weighting) Removed.
5110 * dictionary.c: New file.
5111 (dict_create) New, replaces new_dictionary().
5112 (dict_clone) New, replaces save_dictionary() and
5113 restore_dictionary().
5114 (dict_clear) New, replaces clear_default_dict().
5115 (dict_destroy) New, replaces free_dictionary().
5116 (dict_get_var_cnt) New function, replaces references to
5118 (dict_get_var) New function, replaces references to dict->var[i].
5119 (dict_get_vars) New function, replaces fill_all_vars().
5120 (dict_create_var) New, replaces create_variable(). Interface
5121 drops `type' parameter, using a zero `width' to designate numeric.
5122 (dict_clone_var) New, replaces dup_variable().
5123 (dict_rename_var) New, replaces rename_variable().
5124 (dict_lookup_var) New, replaces find_variable(),
5125 find_dict_variable(), is_varname().
5126 (dict_contains_var) New function.
5127 (compare_variable_dblptrs) New function.
5128 (dict_delete_var) New function, replaces clear_variable().
5129 (dict_delete_vars) New function, replaces dict_delete_run().
5130 (dict_reorder_vars) New function.
5131 (dict_rename_vars) New function, replaces rename_variables().
5132 (dict_get_weight) New function, replaces reading dict->weight_var.
5133 (dict_set_weight) New function, replaces writing dict->weight_var
5134 or calling stop_weight(dict).
5135 (dict_get_filter) New function, replaces reading dict->filter_var.
5136 (dict_set_filter) New function, replaces writing dict->filter_var.
5137 (dict_get_case_limit) New function, replaces reading dict->N.
5138 (dict_set_case_limit) New function, replaces writing dict->N.
5139 (dict_get_value_cnt) New function, replaces reading dict->nval.
5140 (dict_compact_values) New function, replaces a loop that was
5141 replicated in several places.
5142 (dict_get_split_vars) New function, replaces reading dict->splits.
5143 (dict_get_split_cnt) New function, replaces reading
5145 (dict_set_split_vars) New function, replaces writing dict->splits.
5146 (dict_get_label) New function, replaces reading dict->label.
5147 (dict_set_label) New function, replaces writing dict->label.
5148 (dict_get_documents) New function, replaces reading
5150 (dict_set_documents) New function, replaces writing
5153 All references to above functions updated.
5155 * aggregate.c: (cmd_aggregate) Copy file label and documents from
5156 old dictionary to new by hand, because dict_create() can't do it
5157 itself. Use dict_set_documents(), dict_set_split_vars().
5159 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
5160 calling dict_destroy().
5162 * data-list.c: (dls_var_spec) Remove `type' member, replace by
5164 (fixed_parse_compatible) Some slightly nontrivial changes for
5166 (dump_fmt_list) Ditto.
5169 * file-type.c: (create_col_var) Ditto.
5171 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
5172 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
5173 (rename_variables) Use dict_rename_vars().
5174 (mtf_merge_dictionary) Use dict_get_documents(),
5175 dict_set_documents(), dict_compact_values().
5177 * pfm-read.c: (read_variables) Deal with changes to weighting.
5179 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
5180 is_varname() in output code.
5182 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
5183 other dictionary functions.
5185 * title.c: (add_document_line) Use dict_get_documents(),
5186 dict_set_documents().
5188 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
5189 reset default_handle by hand. dict_clear() will clear vectors so
5190 there's no need for that by hand.
5192 * vfm.c: (close_active_file) Move call to finish_compaction()
5193 earlier, so that we can do the compaction as a single step using
5194 dict_compact_values(). Use dict_clear_vectors().
5195 (finish_compaction) Use dict_delete_var(), dict_compact_values().
5197 Some functions don't have replacements:
5199 * vars-atr.c: (force_create_variable) Removed. All references
5200 updated to dict_create_var() followed by an assertion.
5201 (force_dup_variable) Removed. All references updated to
5202 dict_clone_var() followed by an assertion.
5204 * weight.c: (update_weighting) Removed. No longer necessary, so
5205 all references removed.
5207 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
5211 * aggregate.c: Eliminate separation of weighted and unweighted
5212 case. It made the code too obscure and I doubt it was actually
5213 faster. Instead, all code uses the "weighted" code, because
5214 that's a generalization of the "unweighted" code.
5217 (parse_aggregate_functions) No need to set FWEIGHT.
5218 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
5219 (dump_aggregate_info) Ditto.
5220 (initialize_aggregate_info) No need for special plain_function
5221 that gets rid of FWEIGHT option.
5223 * aggregate.c: Get rid of approximations.
5224 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
5226 (aggregate_single_case) Don't use approx_ne().
5228 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
5230 * ascii.c (ascii_line_width): Dead code, removed.
5232 * postscript.c (ps_line_width): Ditto.
5234 * q2c.c (xrealloc): Ditto.
5236 * count.c (internal_cmd_count): Ditto.
5238 * means.q (validate_dependent_endpoint): Ditto.
5240 * set.q: (cmd_gset) Ditto.
5242 * weight.c: [0] (weight_trns_proc) Ditto.
5244 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
5246 Make the code -Wmissing-prototypes clean.
5248 * Makefile.am (version.c): Add #include "version.h".
5250 * ascii.c: (ascii_open_global) Make static.
5251 (ascii_close_page) Ditto.
5252 (ascii_font_sizes) Ditto.
5253 (ascii_postopen_driver) Ditto.
5254 (ascii_close_driver) Ditto.
5255 (ascii_option) Ditto.
5256 (ascii_open_page) Ditto.
5257 (ascii_line_horz) Ditto.
5258 (ascii_line_vert) Ditto.
5259 (ascii_line_intersection) Ditto.
5261 (ascii_polyline_begin) Ditto.
5262 (ascii_polyline_point) Ditto.
5263 (ascii_polyline_end) Ditto.
5264 (ascii_text_set_font_by_name) Ditto.
5265 (ascii_text_set_font_by_position) Ditto.
5266 (ascii_text_set_font_by_family) Ditto.
5267 (ascii_text_get_font_name) Ditto.
5268 (ascii_text_get_font_family) Ditto.
5269 (ascii_text_set_size) Ditto.
5270 (ascii_text_get_size) Ditto.
5271 (ascii_text_metrics) Ditto.
5272 (ascii_text_draw) Ditto.
5273 (ascii_close_page) Ditto.
5275 * cmdline.h: New header for parse_command_line(). Used where
5278 * command.c: Move prototypes for cmd_*() functions to command.h.
5280 * command.h: Prototypes for cmd_*() functions moved here from
5283 * crosstabs.q: (gamma_int) Ditto.
5285 * file-handle.h: Add fh_init_files() prototype.
5287 * getline.c: (welcome) Ditto.
5289 * glob.h: New header for init_glob(). Used where appropriate.
5291 * hash.c: (comparison_helper) Ditto.
5293 * html.c: (html_open_global) Ditto.
5294 (html_close_global) Ditto.
5295 (html_preopen_driver) Ditto.
5296 (html_postopen_driver) Ditto.
5297 (html_close_driver) Ditto.
5298 (html_option) Ditto.
5299 (html_open_page) Ditto.
5300 (html_close_page) Ditto.
5301 (html_submit) Ditto.
5303 * inpt-pgm.c: (input_program_source_read) Ditto.
5305 * output.c: (find_defn_value) Ditto.
5306 (destroy_list) Ditto.
5308 * pfm-read.c: (read_int) Ditto.
5310 * postscript.c: (ps_open_global) Ditto.
5311 (ps_close_global) Ditto.
5312 (ps_font_sizes) Ditto.
5313 (ps_preopen_driver) Ditto.
5314 (ps_postopen_driver) Ditto.
5315 (ps_close_driver) Ditto.
5317 (ps_open_page) Ditto.
5318 (ps_close_page) Ditto.
5319 (ps_line_horz) Ditto.
5320 (ps_line_vert) Ditto.
5321 (ps_line_intersection) Ditto.
5323 (ps_polyline_begin) Ditto.
5324 (ps_polyline_point) Ditto.
5325 (ps_polyline_end) Ditto.
5326 (ps_text_set_font_by_name) Ditto.
5327 (ps_text_set_font_by_position) Ditto.
5328 (ps_text_set_font_family) Ditto.
5329 (ps_text_get_font_name) Ditto.
5330 (ps_text_get_font_family) Ditto.
5331 (ps_text_set_size) Ditto.
5332 (ps_text_get_size) Ditto.
5333 (ps_text_metrics) Ditto.
5334 (ps_text_draw) Ditto.
5336 * q2c.c: (finish_up) Ditto.
5345 (find_symbol) Ditto.
5348 (force_string) Ditto.
5350 (match_token) Ditto.
5353 (parse_setting) Ditto.
5354 (parse_specifier) Ditto.
5355 (parse_specifiers) Ditto.
5356 (parse_subcommand) Ditto.
5357 (dump_specifier_vars) Ditto.
5359 (make_identifier) Ditto.
5360 (dump_declarations) Ditto.
5361 (dump_specifier_init) Ditto.
5362 (dump_vars_init) Ditto.
5364 (dump_specifier_parse) Ditto.
5365 (dump_subcommand) Ditto.
5366 (dump_parser) Ditto.
5367 (dump_header) Ditto.
5369 (recognize_directive) Ditto.
5371 * recode.c: (string_to_long) Ditto.
5373 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
5375 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
5378 * sort.c: (sort_stream_read) Ditto.
5379 (sort_stream_mode) Ditto.
5381 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
5383 * algorithm.c (binary_search): Fix comparison.
5385 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
5387 * algorithm.c: (binary_search) Fix assertion.
5389 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
5391 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
5393 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
5395 * sort.c: (compare_case_lists) Rewrite.
5397 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
5399 * quicksort.c: Removed (not used).
5401 * quicksort.h: Removed (not used).
5403 * sort.c: Removed blp_quicksort() prototype.
5405 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
5407 * postscript.c: (int_2_compare) Rewrite.
5408 (compare_line) Rewrite.
5410 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
5412 * matrix-data.c (compare_factors) Use lexicographical_compare()
5414 (compare_doubles) New function.
5416 * algorithm.c: (lexicographical_compare) New algorithm.
5418 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
5420 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
5422 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
5424 * expr-prs.c: (cmp_func) Removed.
5425 (parse_function) Use binary_search() algorithm.
5426 (compare_functions) New function.
5427 (init_func_tab) Use sort() algorithm.
5429 * algorithm.c: (binary_search) New algorithm.
5431 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
5433 * descript.q: (display) Use sort() algorithm instead of qsort().
5434 (compare_func) Removed.
5435 (descriptives_compare_variables) New function.
5437 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
5439 Get rid of AVL trees. Hashes are more appropriate for everything
5442 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
5448 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
5450 Much code can be clarified by using C++ STL-like algorithms. Not
5451 all uses of these algorithms are listed below, only the ones where
5452 the change to an algorithm was the only change of interest.
5454 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
5456 * algorithm.c: New file.
5458 * algorithm.h: New file.
5460 * modify-vars.c: (static var forward) Removed.
5461 (static var positional) Removed.
5462 (compare_variables) Removed.
5463 (struct ordering) New.
5464 (cmd_modify_vars) Use sort() algorithm.
5465 (compare_variables_given_ordering) New function.
5466 (rearrange_dict) Use sort() algorithm.
5468 * sysfile-info.c: (cmd_display) Use sort() algorithm.
5469 (cmp_var_by_name) Removed.
5471 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
5473 Make file handles use a hash table.
5475 * file-handle.q: (files) Change to hash table, make static.
5476 (cmd_file_handle) Use hash table functions.
5477 (fh_get_handle_by_filename) Ditto.
5478 (fh_get_handle_by_name) Ditto.
5479 (hash_file_handle) New function.
5480 (cmp_file_handle) Rewrite.
5481 (fh_init_files) Use hash table functions.
5483 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
5485 Clean up FREQUENCIES.
5487 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
5489 * frequencies.q: Remove a lot of old #if'd out code at the end.
5490 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
5491 or calc_weight(). Initialize percentile_values.
5492 (calc) New function based on calc_weight() from frequencies.g.
5493 (precalc) Use hash functions.
5494 (static var comparison_func) Removed.
5495 (static var comparison_param) Removed.
5496 (comparison_helper) Removed.
5497 (get_freq_comparator) New function.
5498 (not_missing) New function.
5500 (postprocess_freq_tab) Use hash table functions, algorithms,
5501 get_freq_comparator(). Rewrite.
5502 (cleanup_freq_tab) Rephrase.
5503 (add_percentile) Clean up spacing.
5504 (hash_value_numeric) New function.
5505 (hash_value_alpha) New function.
5506 (compare_value_numeric_a) Rewrite.
5507 (compare_value_alpha_a) Rewrite.
5508 (compare_value_numeric_d) Rewrite.
5509 (compare_value_alpha_d) Rewrite.
5510 (compare_freq_numeric_a) Rewrite.
5511 (compare_freq_alpha_a) Rewrite.
5512 (compare_freq_numeric_d) Rewrite.
5513 (compare_freq_alpha_d) Rewrite.
5514 (calc_stats) Clean up mode, percentiles, max.
5515 (dump_statistics) Clean up spacing.
5517 * frequencies.g: Removed.
5519 * var.h: (struct freq_tab) Change `data' to hash table.
5521 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
5523 * file-handle.h: Remove declaration of global variable `files',
5524 which wasn't used anywhere.
5526 * postscript.c: (add_encoding) Remove superfluous cast.
5529 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
5532 * temporary.c: [0] (display_tree) Removed.
5534 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
5536 Implement a new random number generator based on the alleged RC4
5539 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
5542 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
5543 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
5545 (static var V[]) Removed.
5546 (static var Y) Removed.
5547 (static var X2) Removed.
5548 (setup_randomize) Removed.
5550 (rand_uniform) Removed.
5551 (rand_normal) Removed.
5552 (struct rng) New structure.
5553 (rng_create) New function.
5554 (rng_destroy) New function.
5555 (swap_byte) New static function.
5556 (rng_seed) New function.
5557 (rng_get_bytes) New function.
5558 (rng_get_int) New function.
5559 (rng_get_unsigned) New function.
5560 (rng_get_double) New function.
5561 (rng_get_double_normal) New function.
5562 (pspp_rng) New function.
5564 * random.h: Sync up to random.c.
5566 * sample.c: (struct sample_trns) Make `frac' unsigned and a
5567 fraction of UINT_MAX, not 65536.
5568 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
5571 * vfm.c: (open_active_file) No need to call setup_randomize() any
5574 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
5576 Change dictionary name indexes to use hash tables instead of AVL
5579 * crosstabs.q: (free_var_dict) Use hash tables.
5580 (crs_custom_tables) Ditto.
5581 (calc_general) Ditto.
5582 (compare_table_entry) Rewrite.
5583 (enum_var_values) Reorder parameters. All references updated.
5586 * get.c: (rename_variable) Use hash tables.
5587 (mtf_merge_dictionary) Ditto.
5589 * glob.c: (init_glob) Use hash tables.
5590 (cmp_variable) Removed.
5592 * means.q: (mns_custom_tables) Use hash tables.
5594 * modify-vars.c: (rearrange_dict) Use hash tables.
5596 * rename-vars.c: (cmd_rename_variables) Use hash tables.
5598 * sfm-read.c: (read_header) Use hash tables.
5599 (read_variables) Ditto.
5601 * temporary.c: (new_dictionary) Use hash tables.
5602 (save_dictionary) Ditto.
5603 (restore_dictionary) Ditto.
5605 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
5606 hash table `name_tab'.
5608 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
5609 [DEBUGGING] (dump_var_tree) Removed.
5610 (find_variable) Use hash tables.
5611 (find_dict_variable) Ditto.
5612 (common_init_stuff) Ditto.
5613 (rename_variable) Ditto.
5614 (clear_variable) Ditto. Also, remove debug code.
5615 (dup_variable) Use hash tables.
5617 * vars-prs.c: (fill_all_vars) Use hash tables.
5618 (is_dict_varname) Ditto.
5619 (parse_dict_variable) Ditto.
5621 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
5623 Change value labels to use hash tables instead of AVL trees, and
5624 change value labels into an ADT.
5626 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
5628 * value-labels.c: New file.
5630 * value-labels.h: New file.
5632 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
5633 Get rid of a stupid use of goto.
5635 * autorecode.c: (compare_alpha_value) Rewrite.
5636 (hash_alpha_value) Ditto.
5637 (compare_numeric_value) Rewrite.
5638 (hash_numeric_value) Ditto.
5640 * frequencies.q: (dump_full) Use value label ADT.
5642 * pfm-read.c: (read_value_label) Use value label ADT.
5644 * pfm-write.c: (write_value_labels) Use value label ADT.
5646 * sfm-read.c: (read_variables) Use value label ADT.
5647 (read_value_labels) Rewrite.
5649 * sfm-write.c: (write_value_labels) Rewrite.
5651 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
5652 (display_variables) Ditto.
5653 (describe_variable) Ditto.
5655 * t-test.q: (print_t_groups) Use value label ADT.
5657 * temporary.c: (copy_variable) Use value label ADT.
5658 (free_dictionary) Ditto.
5660 * val-labs.c: (verify_val_labs) Use value label ADT.
5662 (debug_print) Ditto.
5663 (val_lab_cmp) Removed.
5664 (inc_ref_count) Removed.
5665 (copy_value_labels) Removed.
5667 * var.h: (struct value_label) Removed.
5668 (struct variable) Change AVL tree `val_lab' into hash table
5671 * vars-atr.c: (init_variable) Use value label ADT.
5672 (clear_variable) Ditto.
5673 (free_value_label) Removed.
5674 (free_val_lab) Removed.
5675 (get_val_lab) Removed.
5676 (compare_variables) New function.
5677 (hash_variable) New function.
5679 * vfm.c: (dump_splits) Use value label ADT.
5681 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
5683 Add to the hash table interface.
5685 * hash.c: (hsh_hash_bytes) Add assertion.
5686 (hsh_hash_string) Ditto.
5690 (hsh_create) Ditto. Also make minimum `size'.
5691 (hsh_destroy) Rephrase.
5692 (sort_nulls_last) Removed.
5693 (not_null) New function.
5695 (comparison_helper) Ditto.
5696 (hsh_sort) Rewritten.
5697 (hsh_data_copy) New function.
5698 (hsh_sort_copy) Ditto.
5700 (hsh_replace) Ditto.
5701 (hsh_hash_double) Ditto.
5702 (hsh_delete) Fix stupid bug.
5704 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5705 * added a calculation of the mode to FREQUENCIES
5707 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5709 * moved (un)defs of DEBUGGING to config.h
5711 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
5713 * groff-font.c: (add_kern) Fix indentation.
5714 (add_kern) Use & instead of % to take power-of-2 modulus.
5715 (font_get_kern_adjust) Likewise.
5717 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
5719 * autorecode.c: (recode) Replace stupid use of memcpy() by
5721 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
5722 (hash_numeric_value) Ditto.
5723 (autorecode_proc_func) pool_strdup() was wrong here because the
5724 source string was not null-terminated. Use new pool_strndup()
5727 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
5728 use of hsh_iterator_init().
5730 * data-in.c: (parse_N) Initialize i->v->f.
5732 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
5735 * groff-font.c: Use power-of-2 hash table sizes, not prime.
5736 (groff_read_font) Don't call hsh_next_prime(). Don't call
5738 (static var hash) Remove `size_p', `max_used' members.
5739 (font_char_name_to_index) Don't call hsh_next_prime(). Use
5740 hsh_hash_string() instead of hashpjw(), & instead of %.
5741 (default_font) Don't call hsh_next_prime().
5743 * pool.c: (pool_strndup) New function.
5744 (pool_strdup) Reimplement in terms of pool_strndup.
5746 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
5748 (hash_ps_encoding) Use hsh_hash_string().
5749 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
5750 (hash_filename2font) Use hsh_hash_string().
5752 * som.c: Add #include <stdlib.h>.
5754 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
5755 (by destroying its pool).
5757 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
5759 Miscellaneous hash table code cleanup:
5761 * hash.h: (struct hsh_table) Moved into hash.c.
5762 (hsh_count) Ditto, and transformed into function.
5763 (hsh_compare_func) New typedef, used for defining otherwise-long
5764 function types here and in hash.c
5765 (hsh_hash_func) Ditto.
5766 (hsh_free_func) Ditto.
5768 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
5769 `table' to `entries'. Removed `mp'. All references updated.
5770 (hsh_clear) Don't shrink entries array; if the hash was this big
5771 once, it probably will be again.
5772 (hsh_rehash) Made static.
5773 (force_hsh_insert) Renamed hsh_force_insert.
5774 (force_hsh_find) Renamed hsh_force_find.
5776 Made hash table sizes powers of 2, because that's fine with any
5777 reasonable hash function and because taking a power-of-2 modulus
5778 is faster than any other:
5780 (hsh_prime_tab) Removed;
5781 (hsh_next_prime) Ditto.
5782 (next_power_of_2) New function.
5783 (hsh_create) Use next_power_of_2.
5784 (hsh_rehash) Use & instead of %.
5786 Cleaned up hsh_sort:
5788 (internal_comparison_fn) Removed.
5789 (sort_nulls_last) New function.
5790 (hsh_sort) Removed second parameter, switched to using the new
5791 quicksort() function from quicksort.h to avoid using nasty need
5792 for static variables with qsort(). All references updated.
5794 Changed the hash functions offered, because there are better hash
5795 functions than the ones we had, and cleaned up the names to boot:
5797 * hash.c: (hashpjw_d) Removed.
5799 (hsh_hash_bytes) New function.
5800 (hsh_hash_string) New function.
5801 (hsh_hash_int) New function.
5803 Improved the hash table iteration interface:
5805 * hash.h: (hsh_iterator_init) Removed.
5806 (struct hsh_iterator) Removed `init' member, change `next' to
5809 * hash.c: (hsh_foreach) Removed. All references updated to use
5810 hsh_first/hsh_next instead.
5811 (hsh_first) New function. Notably, unlike hsh_foreach() it does
5812 not treat a null pointer as an empty hash table.
5813 (hsh_next) New function.
5815 Made deletion possible, though slow:
5817 * hash.c: (locate_matching_entry) New function.
5818 (hsh_find) Use locate_matching_entry().
5819 (hsh_delete) New function also using locate_matching_entry().
5820 (hsh_force_delete) New function.
5822 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
5824 * quicksort.c: New file implementing a sort routine with a
5825 interface better than qsort() because it passes a user-provided
5826 parameter to the sort routine.
5828 * Makefile.am: Add quicksort.c, quicksort.h.
5830 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
5832 * All source files: Get rid of nasty special cases for Checker,
5833 which is pretty obsolete now.
5835 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
5837 * Fixed a bug apparent when using the FREQUENCIES command with the
5838 html driver. The html driver was incorrectly trying to display
5841 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
5843 * Makefile.am: Reorganized. Put locale dir in version.c instead
5844 of passing it to each compile command. Only put local gmp libs in
5845 LD_ADD if not installed on system. Remove `boast' target.
5847 * All source files: struct and union typedefs eliminated.
5848 `sizeof type' replaced by `sizeof object' where practical. Moved
5849 `unused' qualifiers from start to end of declarations for gcc
5850 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
5851 assertions on pointers strictly compliant. Removed _ prefixes on
5852 some function parameter names.
5854 * alloc.c: New source file, containing these external linkage
5855 functions removed from common.c: xmalloc, xcalloc, xrealloc,
5862 * ascii.c: Migrated from arenas to pools.
5863 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
5864 c_string to len_string. All references changed.
5865 (ascii_option) Signature changed to comply to new output.c
5867 (count_fancy_chars) Removed.
5868 (delineate) Removed support for rich text.
5869 (ascii_text_metrics) Ditto.
5871 (output_shorts) Change `box', `off', `on' from c_string to
5872 len_string. Change `remaining' from int to size_t.
5873 (ascii_close_page) Make page numbering less haphazard.
5875 * autorecode.c: Migrate from arenas to pools.
5877 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
5879 * bitvector.h: New file containing these macros from misc.h:
5880 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
5882 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
5883 word[3]. ncmd removed.
5884 (var empty_string) Removed.
5885 (var cmd_table) Declaration updated.
5886 (var cmdtab) Removed.
5887 (cmp_command) Removed.
5888 (split_words) Rewritten to use strtok_r().
5889 (init_cmd_parser) Renamed cmd_init(). Rewritten.
5890 (find_command) Removed.
5891 (FILE_TYPE_okay) Rewritten.
5892 (cmd_parse) Rewritten. Semantics of the return value of command
5893 handlers has changed: they must now return one of the new CMD_*
5894 enumerals, rather than a magic value. This meant that all
5895 commands had to be modified, and they were.
5896 (figure_out_command) New function.
5898 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
5899 #defines for INIT, INPU, etc.
5901 * command.h: New CMD_* enum series.
5902 (cur_proc) Make const char *, not char *.
5903 (cmd_init) Prototype.
5906 * common.c: Removed.
5908 * common.h: Removed.
5910 * correlations.q: New file.
5912 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
5914 (custom_tables) Renamed crs_custom_tables().
5915 (custom_variables) Renamed crs_custom_variables().
5916 (calc_integer) Add in some `const' qualifiers.
5917 (table_value_missing) Change from a_string to len_string.
5918 (float_M_suffix) Change from a_string to len_string.
5920 * data-in.c: Rewritten. All references to
5921 parse_string_as_format() changed to data_in().
5923 * data-in.h: New file.
5925 * data-list.c: Change DLS_* from #define's to enums. Move from
5926 rpd_msg() to tmsg().
5927 (RPD_ERR) New #define.
5928 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
5930 (read_from_data_list_fixed) Change from old
5931 parse_string_as_format() to new data_in().
5932 (read_from_data_list_free) Ditto.
5933 (read_from_data_list_list) Ditto.
5934 (cmd_repeating_data) Modify approach to checking for end of
5937 (rpd_parse_record) Change from old parse_string_as_format() to new
5938 data_in(). Change from old convert_format_to_string() to new
5940 (read_one_set_of_repetitions) Change dfm_push_cust() to
5941 dfm_push(), pop_cust() to dfm_pop().
5943 * data-out.c: Rewritten. All references to
5944 convert_format_to_string() changed to data_out().
5946 * descript.q: Migrate to new q2c.
5947 (cmd_descriptives) Removed.
5948 (internal_cmd_descriptives) Renamed cmd_descriptives ().
5949 (custom_variables) Renamed dsc_custom_variables().
5951 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
5953 (open_file_r) Initialize h->where.line_number. Migrate to new
5955 (open_file_w) Initialize h->where.line_number.
5956 (read_record) Change from ext->ln to h->where.line_number.
5957 Migrate to struct string.
5958 (dfm_put_record) Rephrased.
5959 (dfm_push_cust) Renamed dfm_push(), rewritten.
5960 (dfm_pop) New function.
5962 * error.c: All references updated.
5963 (glob var error_count) Renamed err_err_count.
5964 (glob var warning_count) Renamed err_warning_count.
5965 (glob var error_already_flagged) Renamed err_already_flagged.
5966 (glob var verbosity) Renamed err_verbosity.
5967 (glob var cust_fn) Removed.
5968 (glob var cust_ln) Removed.
5969 (static var file_loc) New.
5970 (static var nfile_loc) New.
5971 (static var mfile_loc) New.
5972 (tmsg) New function.
5973 (push_cust) Removed.
5976 (static var terminating) Removed.
5977 (failure) Renamed err_failure().
5978 (hcf) Renamed err_hcf().
5979 (err_push_file_locator) New function.
5980 (err_pop_file_locator) New function.
5981 (err_location) New function.
5982 (check_error_count) Renamed err_check_count().
5983 (vmsg) Renamed err_vmsg(). Interface changed.
5984 (verbose_msg) Removed.
5985 (err_cond_fail) New function.
5986 (error_break) Renamed err_break().
5988 * error.h: All references updated.
5989 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
5990 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
5992 (struct file_locator) New.
5994 (macro verbose_msg) Removed.
5995 (macro cond_fail) Removed.
5997 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
5999 * expr-prs.c: Reorganized. All references updated.
6000 (exprtypename) Renamed expr_type_name().
6001 (typename) Renamed type_name().
6002 (free_expression) Renamed expr_free().
6003 (parse_expression) Renamed expr_parse(). Uses new type_check()
6005 (init_functab) Renamed init_func_tab().
6006 (type_check) New function.
6007 (parse_or) Rewritten to use new allocate_nonterminal() and
6008 append_nonterminal_arg() functions.
6011 (parse_rel) Ditto. Also simplified logic.
6016 (SYSMIS_func) Ditto.
6017 (VALUE_func) Rephrased.
6018 (CONCAT_func) Fix memory leak by replacing free by free_node on
6020 (generic_str_func) Ditto.
6021 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
6023 (allocate_nonterminal) New function.
6024 (append_nonterminal_arg) New function.
6025 (static func_tab[]) Now at file level.
6027 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
6029 * expr.h: (enum series OP_*) Moved to exprP.h.
6030 (OP_* defines) Ditto.
6031 (struct op_desc) Ditto.
6032 (global ops[]) Ditto.
6033 (struct num_con_node) Ditto.
6034 (struct str_con_node) Ditto.
6035 (struct var_node) Ditto.
6036 (struct lag_node) Ditto.
6037 (struct casenum_node) Ditto.
6038 (struct nonterm_node) Ditto.
6039 (union any_node) Members renamed.
6040 (struct sys_node) Removed.
6041 (struct val_node) Removed.
6042 (operator typedef) Removed.
6043 (typedef exprtype) Removed.
6044 (enum series EX_*) Moved to exprP.h.
6045 (struct expression) Ditto. Also renamed a lot of the members.
6046 (PXP_* defines) Changed to enums.
6047 (free_node prototype) Moved to exprP.h.
6049 * file-handle.h: (struct file_handle) New member `where'.
6051 * file-handle.q: Migrated to new q2c format.
6052 (prepend_current_directory) Removed (dead code).
6053 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
6054 (fh_get_handle_by_filename) Removed dead code.
6055 Set new `where' member.
6057 * file-type.c: (file_type_source_read) References to
6058 parse_string_as_format() changed to data_in().
6059 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
6061 * filename.c: All references updated.
6062 (init_filename) Renamed fn_init().
6063 (expand_line) Removed.
6064 (macro EXPAND_LINE) Removed.
6065 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
6066 of custom functions.
6067 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
6068 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
6069 (normalize_filename) Renamed fn_normalize().
6070 (search_path) Renamed fn_search_path(), rewritten.
6071 (prepend_dir) Renamed fn_prepend_dir().
6072 (blp_getenv) Renamed fn_getenv().
6073 (blp_dirname) Renamed fn_dirname().
6074 (fn_basename) New function, not used.
6075 (absolute_filename_p) Renamed fn_absolute_p().
6076 (is_special_filename) Renamed fn_special_p().
6077 (file_exists) Renamed fn_exists_p().
6078 (readlink_malloc) Renamed fn_readlink().
6079 (getenv_default) Renamed fn_getenv_default().
6080 (open_file) Renamed fn_open().
6081 (close_file) Renamed fn_close().
6082 (open_file_ext) Renamed fn_open_ext().
6083 (close_file_ext) Renamed fn_close_ext().
6085 * font.h: Migrate from arenas to pools.
6087 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
6089 * frequencies.g: Migrate from arenas to pools.
6091 * frequencies.q: Migrate to new q2c version. Migrate from arenas
6094 * getline.c: All references updated.
6095 (global getl_buf) Changed from char * to struct string.
6096 (static getl_include_path) Ditto.
6097 (global getl_buf_len) Removed.
6098 (global getl_buf_size) Removed.
6099 (getl_include_path) Deal with new getl_buf, getl_include_path.
6100 (getl_uninitialize) New function.
6101 (getl_get_current_directory) Rewritten.
6102 (getl_clear_include_path) Rewritten.
6103 (getl_add_include_dir) Rewritten.
6104 (getl_add_file) Assertion fixed.
6105 (getl_add_virtual_file) Change initial value of `remaining_loops'
6107 (welcome) Rewritten.
6108 (handle_line_buffer) Make static. Change logic to make
6109 getl_add_virtual_file() change sensible. Use ds_*() strings.
6110 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
6111 (getl_close_file) Moved.
6112 (getl_location) New function.
6114 * getline.h: All references updated.
6115 (macro curln) Removed.
6116 (macro curfn) Removed.
6117 (macro am_interactive) Renamed getl_am_interactive.
6118 (macro am_reading_script) Renamed getl_reading_script.
6120 * glob.c: (global fmt_parse_ignore_error) Removed.
6121 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
6122 systems that support it (C99). Turn off SET ECHO by default. No
6123 necessary julcal initialization anymore.
6125 * groff-font.c: Migrate from arenas to pools.
6126 (groff_read_font) Use err_push_file_locator().
6127 (groff_read_DESC) Ditto.
6128 (font_msg) Use tmsg().
6130 * hash.c: (hsh_sort) Fix debug code.
6131 [GLOBAL_DEBUGGING] Include stdio.h.
6133 * hash.h: (macro force_hsh_insert) Rephrase.
6135 * heap.c: Rewritten.
6137 * heap.h: Rewritten.
6139 * html.c: (html_option) Change from outp_value to struct string.
6140 (postopen) Change from curfn to getl_location().
6141 (escape_string) Remove rich-text code. Signature changed.
6142 (output_tab_table) Switch from a_string to struct len_string.
6143 Remove rich text support.
6145 * lexer.c: All references updated. Largely rewritten. Major
6146 changes listed below. Removed tagged quote support. Adapted to
6147 struct string tokstr.
6148 (global tokstr) Changed to struct string.
6149 (global tokstr_size) Removed.
6150 (global tokstr_len) Removed.
6152 (global tokint) Removed.
6153 (global toklongstr) Removed.
6154 (C* defines) Removed.
6155 (static tbl[]) Removed.
6156 (static id[]) Removed.
6157 (static une[]) Removed.
6158 (discard_line) Renamed lex_discard_line().
6159 (get_entire_line) Renamed lex_entire_line().
6160 (get_rest_of_line) Renamed lex_rest_of_line().
6161 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
6162 (make_hexit) Removed.
6163 (syntax_error) Renamed lex_error(). Return value removed.
6164 (get_token_representation) Renamed lex_token_representation().
6165 (putback) Renamed lex_put_back().
6166 (putfwd) Renamed lex_put_forward().
6167 (convert_negative_to_dash) Renamed lex_negative_to_dash().
6168 (set_prog) Renamed lex_set_prog().
6169 (init_lex) Renamed lex_init().
6170 (reset_eof) Renamed lex_reset_eof().
6171 (lookahead) Renamed lex_look_ahead().
6172 (check_id) Rewritten.
6173 (yylex) Renamed lex_get(), rewritten.
6174 (lex_end_of_command) New function. Many commands were rephrased
6176 (lex_integer_p) New function. Replaces compare of tokint against
6178 (lex_integer) New function. Replaces tokint.
6179 (match_tok) Renamed lex_match().
6180 (match_id) Renamed lex_match_id().
6181 (match_int) Renamed lex_match_int().
6182 (force_match_id) Renamed lex_force_match_id(), added return value.
6183 (force_match) Renamed lex_force_match(), added return value.
6184 (force_string) Renamed lex_force_string(), added return value.
6185 (force_int) Renamed lex_force_int(), added return value.
6186 (lex_id_match_len) New function.
6187 (id_match) Renamed lex_id_match(), rewritten.
6188 (get_line) Renamed lex_get_line().
6189 (preprocess_line) Renamed lex_preprocess_line().
6190 (tokname) Renamed lex_token_name().
6191 (bin_value_func) Removed.
6192 (oct_value_func) Removed.
6193 (hex_value_func) Removed.
6194 (unexpected_eof) New function.
6195 (convert_numeric_string_to_char_string) New function.
6196 (parse_string) Rewritten, signature changed.
6197 (add_tokstr_char) Removed.
6198 (add_tokstr_unsigned) Removed.
6199 (add_tokstr_string) Removed.
6200 (parse_tagged_quote) Removed.
6201 (skip_comment) Renamed lex_skip_comment().
6203 * lexer.h: All references updated.
6204 (macro is_id1) Renamed CHAR_IS_ID1.
6205 (macro is_idn) Renamed CHAR_IS_IDN.
6206 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
6207 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
6208 (macro get_token) Removed.
6209 (macro id_match) Removed.
6210 (macro force_match_id) Removed.
6211 (macro force_match) Removed.
6212 (macro force_string) Removed.
6213 (macro force_int) Removed.
6214 (macro force_num) Removed.
6215 (macro force_id) Removed.
6217 * lexerP.h: Removed.
6219 * list.q: Migrated to new q2c format.
6220 (write_line) Deal with struct len_string.
6221 (write_varname) Ditto.
6222 (write_fallback_headers) Ditto.
6224 * magic.c: New file, incorporating the following global variables
6225 previously in other files: endian, second_lowest_value. And both
6226 of those are conditional on #define's.
6228 * magic.h: New file, incorporating the following global variable
6229 declarations: endian, second_lowest_value, and the following macro
6230 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
6232 * main.c: Added declarations of pgmname, finished, curdate,
6234 (main) Call new parse_script() function.
6235 (parse_script) New function.
6236 (execute_command) New function.
6237 (dump_token) Removed.
6238 (handle_error) New function.
6240 * matrix.c: New file.
6242 * matrix.h: New file.
6244 * matrix-data.c: Migrated from arenas to pools.
6245 (mget_token) Change from parse_string_as_format() to data_in().
6247 * means.q: Migrate to new q2c.
6248 (custom_tables) Renamed mns_custom_tables().
6249 (custom_crossbreak) Renamed mns_custom_crossbreak().
6250 (custom_variables) Renamed mns_custom_variables().
6252 * mis-val.c: (static var width) Changed from `int' to `size_t'.
6253 (parse_varnames) Prototype.
6254 (parse_numeric) Rephrasings.
6255 (parse_alpha) Adapt to new struct string tokstr.
6257 * misc.c: (intlog10) Rewritten.
6259 (ansi_rand) Renamed real_rand(), moved into random.c.
6260 (ansi_srand) Renamed real_srand(), moved into random.c.
6261 (setup_randomize) Moved to random.c.
6262 (rand_uniform) Ditto.
6263 (rand_normal) Ditto.
6264 (rand_simple) Ditto.
6265 (get_config_line) Removed.
6266 (reverse) Removed (dead code).
6268 * misc.h: (macro SET_BIT) Moved to bitvector.h.
6269 (macro CLEAR_BIT) Ditto.
6270 (macro TEST_BIT) Ditto.
6271 (macro SET_BIT_TO) Ditto.
6272 (macro BIT_INDEX) Ditto.
6274 * output.c: (outp_read_devices) Move to err_push_file_locator()
6275 from push_cust(). Use struct string.
6276 (expand_op_tokstr) Removed.
6277 (static var op_tokstr) Changed to struct string.
6278 (static var op_tokstr_size) Removed.
6279 (tokener) Rephrasings. Use struct string.
6280 (parse_options) Use struct string.
6281 (destroy_driver) Fix assertion.
6282 (outp_get_paper_size) Move to err_push_file_locator().
6283 [0] Removed dead code.
6284 (outp_string_width) Move to len_string.
6286 * output.h: Comment fixes.
6287 (TAG_* enum series) Removed.
6288 (struct outp_value) Removed.
6289 (enum OUTP_T_FANCY) Removed.
6290 (struct outp_text) `s' changed from a_string to len_string.
6291 (struct outp_class) `option' change arg 3 from outp_value to
6294 * pfm-read.c: (corrupt_msg) Rewritten.
6296 * pfm-write.c: (bufwrite) Fix assertion.
6298 * pool.c: New file, reference version.
6300 * pool.h: New file, reference version.
6302 * postscript.c: (ps_font_sizes) Fix assertion.
6303 (ps_option) Change arg 3 from outp_value to struct string.
6304 Adapt to struct string.
6305 (macro output_line) Removed.
6306 (macro add_string) Removed.
6307 (output_encodings) Adapted to struct string. Moved to
6308 err_push_file_locator().
6309 (find_encoding_file) Fix assertion.
6310 (read_ps_encodings) Move to err_push_file_locator().
6311 (postopen) Use getl_location() instead of curfn.
6312 (out_text_plain) Move to len_string.
6313 (text) Ditto. Remove rich text support.
6315 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
6316 (cmd_print_eject) Ditto.
6318 (internal_cmd_print) Now cleans up after itself. Uses
6319 fh_parse_file_handle() now.
6320 (cmd_print_space) Use PXP_NUMERIC to type-check.
6322 * q2c.c: Overhauled. Removed _("") i18n support. All references
6323 updated. All output functions updated to handle structures rather
6324 than local or static variables. Adapt to new PSPP lex_*()
6328 (macro MAX_N_SBC) Removed.
6329 (global bare) Removed.
6330 (enum STRING) Renamed T_STRING.
6331 (enum ID) Renamed T_ID.
6332 (get_buffer) Buffer size increased.
6333 (strlower) Renamed st_lower(), rephrased.
6334 (strupper) Renamed st_upper(), rephrased.
6335 (skip_ws) New function.
6336 (get_line) Don't special-case any types of lines (like those
6337 beginning with ! or $, for instance).
6338 (get_token) Renamed lex_get(). Rephrased.
6339 (static var `prefix') New.
6340 (parse) New function.
6341 (parse_setting) Minor rephrasing.
6342 (dump_specifier_vars) Ditto.
6343 (make_identifier) Put null terminator on identifier, duh.
6344 (dump_vars) Renamed dump_declarations(). Never indent. Never
6345 static. Output changed entirely.
6346 (dump_specifier_init) Rephrase.
6347 (dump_vars_init) No index variable needed. Other modifications.
6348 (dump_parser) Don't parse command name. Do dump functions instead
6349 of just code fragments.
6350 (dump_free) Dump function instead of code fragment.
6351 (recognize_directive) New function.
6352 (main) Use recognize_directive(). Don't rely on magic $ line
6353 beginning: instead, parse comments. Update list of headers.
6355 * random.c: New file, containing the following functions:
6356 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
6357 rand_normal, rand_simple.
6359 * random.h: New file.
6361 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
6362 function. `max_src_width', `max_dst_width' changed to size_t.
6363 (internal_cmd_recode) Removed.
6364 (parse_dest_spec) Merge similar cases.
6365 (parse_src_spec) Add assertion.
6367 * repeat.c: (recognize_keyword) New function.
6368 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
6369 REPEAT. Improve recognition of END REPEAT (use
6370 recognize_keyword()). Move from curfn to getl_location(). Use
6373 (perform_DO_REPEAT_substitutions) Adapt to struct string.
6375 * set.q: Adapt to new q2c.
6376 (cmd_set) Range-check some values better.
6377 (custom_blanks) Renamed stc_custom_blanks().
6378 (custom_length) Renamed stc_custom_length().
6379 (custom_results) Renamed stc_custom_results().
6380 (custom_seed) Renamed stc_custom_seed().
6381 (custom_width) Renamed stc_custom_width().
6382 (custom_format) Renamed stc_custom_format().
6383 (custom_journal) Renamed stc_custom_journal().
6384 (custom_color) Renamed stc_custom_color().
6385 (custom_listing) Renamed stc_custom_listing().
6386 (custom_disk) Renamed stc_custom_disk().
6387 (custom_log) Renamed stc_custom_log().
6388 (custom_rcolor) Renamed stc_custom_rcolor().
6389 (custom_viewlength) Renamed stc_custom_viewlength().
6390 (custom_workdev) Renamed stc_custom_workdev().
6392 * settings.h: Not necessary to include format.h any longer.
6394 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
6395 (corrupt_msg) Rewritten.
6397 * sort.c: Adapt to rewritten heap ADT.
6399 * str.c: (aa_strcpy) Removed.
6400 (ab_strcpy) Removed.
6401 (ac_strcpy) Removed.
6402 (ba_strcpy) Removed.
6403 (bb_strcpy) Removed.
6404 (ca_strcpy) Removed.
6405 (aa_strdup) Removed.
6406 (aa_strdupcpy) Removed.
6407 (ba_strdup) Removed.
6408 (sa_strdup) Removed.
6409 (memrev) Renamed mm_reverse().
6410 (memrmem) Renamed mm_find_reverse().
6411 (cmp_str) Renamed st_compare_pad().
6412 (strmaxcpy) Removed.
6413 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
6414 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
6416 (strpadcpy) Renamed st_pad_copy(), signature changed.
6417 (blpstrset) Removed.
6418 (ds_create) New function.
6419 (ds_init) New function.
6420 (ds_replace) New function.
6421 (ds_destroy) New function.
6422 (ds_clear) New function.
6423 (ds_extend) New function.
6424 (ds_shrink) New function.
6425 (ds_truncate) New function.
6426 (ds_length) New function.
6427 (ds_size) New function.
6428 (ds_value) New function.
6429 (ds_end) New function.
6430 (ds_concat) New function.
6431 (ds_concat_buffer) New function.
6432 (ds_printf) New function.
6433 (ds_putchar) New function.
6434 (ds_getline) New function.
6435 (ds_get_config_line) New function derived from the old
6436 misc.c:get_config_line().
6437 (ls_create) New function.
6438 (ls_create_buffer) New function.
6439 (ls_init) New function.
6440 (ls_shallow_copy) New function.
6441 (ls_destroy) New function.
6442 (ls_null) New function.
6443 (ls_null_p) New function.
6444 (ls_empty_p) New function.
6445 (ls_length) New function.
6446 (ls_value) New function.
6447 (ls_end) New function.
6449 * str.h: Reformatted.
6450 (struct a_string) Removed.
6451 (struct b_string) Removed.
6452 (struct c_string) Removed.
6453 (struct len_string) New.
6454 (struct string) New.
6455 (macro as_streq) Removed.
6456 (macro bs_streq) Removed.
6457 (macro cs_streq) Removed.
6458 (macro sa_streq) Removed.
6459 (macro sb_streq) Removed.
6460 [__GNUC__] (inline function ds_putchar) New function.
6461 [__GNUC__] (inline function ds_length) New function.
6462 [__GNUC__] (inline function ds_value) New function.
6463 [__GNUC__] (inline function ds_end) New function.
6465 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
6466 (display_vectors) Fix missing i18n.
6468 * t-test.q: Migrate to new q2c.
6470 * tab.c: Migrate from arenas to pools.
6471 (tab_create) Use struct len_string.
6472 (tab_realloc) Ditto.
6473 (text_format) Ditto.
6474 (tab_joint_text) Ditto.
6475 (tab_natural_width) Remove rich text support.
6476 (tab_natural_height) Ditto.
6477 (tab_output_text) Handle TAT_FIX.
6478 (tab_raw) Change arg from a_string to len_string.
6479 (tabi_driver) Fix assertion. Use struct len_string.
6480 (render_strip) Use struct len_string. Remove rich text support.
6481 Add `const' qualifiers.
6483 * tab.h: (enum TAB_RICH) Remove.
6484 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
6485 SOM_COL_* updated to read TAB_COL_*.
6486 (struct tab_table) Change arena to pool. Change a_string to
6489 * temporary.c: (restore_dictionary) Rewrite Checker code.
6491 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
6492 LOWEST, HIGHEST) Moved here from common.h.
6493 (typedef any_trns) Removed. All references changed to `struct
6496 * vars-atr.c: (force_create_variable) Fix assertion.
6497 (force_dup_variable) Fix assertion.
6499 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
6501 Using alphanumeric variables in functions under AGGREGATE
6502 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
6503 <BZN-mdksh@t-online.de> for reporting this bug.
6505 * aggregate.c: (parse_aggregate_functions) When setting the
6506 FSTRING bit, also allocate memory for the `string' member of
6508 (free_aggregate_functions) Free iter->string. Don't use the
6509 non-function bits when indexing the array of functions.
6510 [DEBUGGING] (debug_print) Don't use the non-function bits when
6511 indexing the array of functions.
6513 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
6515 Under certain circumstances, the final case would be omitted from
6516 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
6517 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6519 * aggregate.c (agr_00x_end_func): Increment number of cases in
6520 sink before writing case. For streams that keep track of how many
6521 cases there are based on this value, this means that the last case
6522 will be read in on the next stream read.
6524 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
6526 Undefined behavior was invoked by referencing a freed pointer.
6528 * vfm.c (memory_stream_write): Free pointer *after* checking for
6531 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
6533 A wrong record size was displayed when paging the active file to
6536 * vfm.c: (memory_stream_write) Fix off-by-one error.
6538 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
6540 Not having enough temporary space for sorting caused a core dump.
6543 * sort.c: (allocate_cases) Initialize i.
6545 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
6547 Syntax errors in function descriptions on AGGREGATE caused core
6550 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
6551 free_aggregate_functions(), since that function already frees
6554 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
6556 A null pointer was dereferenced, causing a core dump, when
6557 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
6558 but PSPP still doesn't calculate percentiles. Thanks to Regnor
6559 Jernsletten <rjernsle@eunet.no> for reporting this problem.
6561 * arena.c: (arena_malloc) If the arena hasn't been initialized
6562 already, initialize it.
6564 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
6566 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
6567 for compilation with Cygnus Windows B20. Not used by other
6570 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
6572 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
6573 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6575 * sort.c: (compare_case_lists) Reverse sense of comparison if
6576 sorting in descending order.
6577 (compare_record) Ditto.
6579 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
6581 SPLIT FILE with a string variable caused a core dump. Fixed.
6583 * vfm.c: If the variable is a string then make a temporary value
6584 struct pointing to it. The underlying problem is a lot bigger
6585 than this (see TODO) but this is a stopgap for the simple case at
6588 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
6590 Nested INCLUDEs didn't work. Fixed.
6592 * getline.c: (getl_include) Set first_line to NULL in allocated
6595 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
6597 The MATCH FILES procedure set the values of variables not present
6598 to 0. It should have been SYSMIS. This is now fixed.
6600 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
6602 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
6604 The REMARK command was too aggressive about skipping lines. It
6605 didn't like being the last command in a file.
6607 * command.c: (cmd_remark) Call get_entire_line() instead of
6610 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
6612 Comment parsing wasn't consistent with the rest of the code in its
6613 idea of where one command ends and another starts. This meant
6614 that sometimes commands would be mysteriously ignored. Thanks to
6615 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6617 * command.c: (parse_cmd) Hand off comment parsing to new function
6618 skip_comment() in lexer.c.
6619 * lexer.c: (skip_comment) New function.
6621 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
6623 The TABLE subcommand on MATCH FILES worked only erratically at
6624 best. This fixes it. Thanks to Dr. Dirk Melcher
6625 <BZN-mdksh@t-online.de> for reporting this bug.
6627 * get.c: (mtf_compare_BY_values) When comparing string values, a
6628 difference of 1 is still a difference :-)
6629 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
6630 advance TABLE files automatically when matched. Comment fixes.
6632 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
6634 VARIABLE LABELS rejected a slash before the first variable
6635 specification, contradicting the documentation. Thanks to Walter
6636 M. Gray <graywm@northernc.on.ca> for reporting this bug.
6638 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
6639 command specification.
6641 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
6643 Because of an incorrect optimization in memory allocation,
6644 CROSSTABS sometimes segfaulted when asked to output multiple
6645 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6648 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
6649 are passed to output_pivot_table() for its use.
6650 (output_pivot_table) Instead of assuming the number of columns is
6651 constant, keep track with maxcols. In general mode, use maxcells
6652 to determine whether more matrix cells need to be allocated.
6654 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
6656 CROSSTABS didn't display value labels for column and row
6657 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6660 * crosstabs.q: (table_value_missing) If the specified value has a
6661 value label for this variable, then show it instead of the raw
6663 (display_dimensions) Delegate display of value_labels to
6664 table_value_missing.
6666 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
6668 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
6669 <BZN-mdksh@t-online.de> for reporting this bug.
6671 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
6672 if the file isn't declared as binary.
6674 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
6676 MATCH FILES corrupted memory and dumped core on some syntax
6679 * get.c: (cmd_match_files) Set file->handle to NULL before
6681 (mtf_free_file) Don't free a null dictionary.
6683 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
6685 MATCH FILES should set numeric values not available to the
6686 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
6687 <BZN-mdksh@t-online.de> for reporting this bug.
6689 * get.c: (mtf_processing) Set unused records to system-missing,
6692 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
6694 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
6695 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
6697 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
6698 in newly created dictionary, and add each copied variable to the
6701 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
6705 * get.c: (trim_dictionary) Free variable list for KEEP after
6708 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
6710 Some systems didn't like the way open_file was coded. Thanks to
6711 Hankin <hankin@rogue.consultco.com> for pointing this out.
6713 * filename.c: (open_file) Don't try to store stdin, stdout,
6714 stderr as part of an array, because that doesn't always work.
6716 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
6718 The SAVE procedure didn't save long string variables properly.
6719 Fixed by this patch. Thanks to Hankin
6720 <hankin@rogue.consultco.com> for this patch.
6722 * sfm-write.c: (write_variable) Fix off-by-one error in writing
6723 out variable pad records.
6725 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
6727 Previously, if PRINT SPACE were given a negative argument, it
6728 would report an error, then spin in an (almost) infinite loop.
6729 This fixes that behavior.
6731 * print.c: (print_space_trns_proc) After reporting a negative
6732 argument, set number of lines to print to 1.
6734 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
6736 SPSS 8.0 outputs some new record types in its system files, and it
6737 allows longer value labels. Accept these system files.
6739 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
6740 11 emitted by SPSS 8.0.
6742 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
6744 The LIST procedure was too conservative in allocating space for
6745 buffers, which caused a bug that only showed up with very long
6746 output variables. Thanks to Hankin <hankin@dunno.com> for this
6749 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
6751 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
6753 Typo meant string format specifiers weren't checked properly. I
6754 think that Hankin <hankin@dunno.com> sent me this report, but I'm
6755 willing to be corrected on this point.
6757 * format.c: (check_string_specifier) Fix obvious typo.
6759 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
6761 Using $CASENUM in an expression didn't work. Here's a fix.
6762 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
6765 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
6767 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
6769 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
6771 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
6772 other behavior, *sigh*. This patch hopefully fixes that. This
6773 time I've actually tested it.
6775 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
6777 * data-list.c: (read_from_data_list_free,
6778 read_from_data_list_list) Call parse_string_as_format() directly
6779 without mucking around with the field width.
6781 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
6783 Occasionally, you may encounter a script that wants to be
6784 interpreted in interactive mode. Make -i emulate this behavior to
6785 allow such scripts to be executed with PSPP.
6787 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
6789 * cmdline.c: (pre_syntax_message[]) Update -i description.
6791 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
6792 when -i is given on the command line) don't treat unindented lines
6793 as starting a new command.
6795 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
6797 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
6798 mostly caused by local initialized aggregates. After egcs is
6799 fixed upstream these can be removed, but for now they're not a big
6802 * ascii.c: (ascii_postopen_driver) Checker chokes on local
6803 initialized arrays. Avoid this.
6805 * sfm-write.c: (sfm_write_dictionary) Don't use a local
6808 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
6810 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
6811 following changes avoid. Currently I compile sources with egcs
6812 1.1.1 and gcc 2.7.2.3 before sending them out.
6814 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
6816 * ascii.c: (option_tab[]) Initialize all struct members.
6818 * avl.h: (avl_traverser_init) New macro.
6820 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
6823 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
6826 * hash.c: Comment fix.
6828 * hash.h: (hsh_iterator_init) New macro.
6830 * html.c: (option_tab[]) Initialize all struct members.
6832 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
6835 * postscript.c: (option_tab[]) Initialize all struct members.
6836 (output_encodings, preclose, dump_lines) Use new
6837 hsh_iterator_init() macro.
6839 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
6842 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
6845 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
6847 * data-in.c: Examined each of the parsing functions to make sure
6848 that they wouldn't dump core if they were passed a string of the
6849 wrong length, since now the DATA LIST FREE/LIST routines don't
6850 check for field width before passing it to the data parser.
6851 (parse_RBHEX, parse_AHEX) Reject odd length input.
6852 (parse_string_as_format) Reject input that's too short or too
6855 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
6856 a field to its entire declared output width then pass it to the
6857 data-in parsing routines. This contradicted the documented
6858 behavior. This is fixed in these changes. Thanks to Mark H. Wood
6859 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
6860 free-format parsing that differed from SPSS.
6861 (cut_field) Commas and spaces are treated identically. Returns
6862 the proper column instead of a fixed 1 value.
6863 (parse_field) Removed.
6864 (read_from_data_list_free, read_from_data_list_list) Call
6865 parse_string_as_format directly instead of parse_field.
6867 * heap.c: (heap_delete) Stylistic fixes.
6869 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
6871 * loop.c: (loop_2_trns_proc) Formatting fix.
6873 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
6875 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
6877 * vfm.c: (macro FILTERED) New.
6878 (static var filter_var) New.
6879 (process_active_file_write_case) Use FILTERED.
6880 (setup_filter) Set filter_var.
6881 (close_active_file) Delete the filter if not
6882 FILTER_before_TEMPORARY.
6883 (procedure_write_case) Use FILTERED.
6885 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
6887 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
6889 * data-in.c: (parse_day_count) Message fix.
6890 (parse_month) Style fix.
6892 * data-list.c: (struct data_list_pgm) New member eof.
6893 (cmd_data_list) Init eof to 0.
6894 (do_reading) Implement the /END subcommand and read-past-eof
6897 * do-if.c: Include stdio.h when debugging.
6898 (cmd_else_if) Make sure the command is .-terminated.
6900 * glob.c: (init_glob) Capitalize the command prompt.
6902 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
6903 (end_file_trns_proc) Debugging message.
6905 * loop.c: (internal_cmd_loop) Make it work when there's no loop
6907 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
6909 * main.c: (dump_token) Make kwtab[] const.
6911 * set.q: Spelling, comment fixes.
6913 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
6916 * vars-prs.c: (fill_all_vars) Style fix.
6918 * vfm.c: (index_to_varname) Return const.
6920 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
6922 * Changes in many source files for partial -ansi -pedantic and
6923 no-debugging compliance: Remove trailing common in enum
6924 declarations; add `unused' attributes; insert some appropriate
6927 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
6929 * command.c: (shell) Make static.
6930 (run_command) Make static.
6932 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
6934 * dfm.c: (cmd_begin_data) I18n fix.
6936 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
6938 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
6940 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
6943 * file-handle.q: Don't prepend the source file directory name to
6944 the data file name. (Ongoing issue.)
6945 (prepend_current_directory) Comment out.
6946 (internal_cmd_file_handle) Don't call prepend_current_directory().
6947 (fh_get_handle_by_filename) Ditto.
6949 * filename.c: Append zero byte to readlink() return value.
6951 * getline.c: (getl_read_line) I18n fix.
6953 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
6955 * misc.h: Don't use gcc features if __STRICT_ANSI__.
6957 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
6960 * postscript.c: (output_encodings) Don't use local_strdup().
6963 * print.c: Don't use gcc features if __STRICT_ANSI__.
6965 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
6967 * recode.c: (parse_src_spec) Fully brace nested if's.
6969 * set.q: (global var set_testing_mode) New var.
6971 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
6973 * ascii.c: Add some more `unused' attributes that only come into
6974 play when NDEBUG is defined.
6975 (ascii_close_page) Set s_len when reallocating s.
6977 * crosstabs.q: (delete_missing) New function.
6978 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
6979 (make_summary_table) Create summary table reallocable.
6981 * postscript.c: Add more `unused' attributes as above.
6983 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
6984 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
6986 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
6989 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
6990 gratuitous space between parameter definition.
6992 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
6993 complaints about running off the end of functions with NDEBUG
6996 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
6998 * Several source files: Removed some PORTME notes when reflection
6999 revealed that ANSI forbids that sort of breakage. Also, added
7000 lots of `unused' qualifiers here and there.
7002 * aggregate.c: (accumulate_aggregate_info) Remove local var
7003 weighting that turned out not to be used.
7005 * avl.c: Update to version 1.1.0. Add unused specifier.
7006 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
7008 (avl_probe) Replace some instances of 1 with +1 where appropriate.
7009 (avl_find) Cast return value to void *.
7010 (avl_delete) q doesn't need to be initialized at the beginning of
7011 the function. Replace some instances of 1 with +1.
7012 (force_avl_delete) Renamed avl_force_delete, all references changed.
7013 (compare_ints) `param' marked unused.
7014 (print_int) `param' marked unused.
7015 (recurse_tree) Replace some instances of 1 with +1.
7017 * avl.h: Update to version 1.1.0. Only declares avl function
7018 types if not already declared.
7019 (AVL_MAX_HEIGHT) Only define if not already defined.
7020 (struct avl_node) New unused member char pad[2].
7021 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
7022 (force_avl_insert) Renamed avl_force_insert.
7023 (force_avl_delete) Renamed avl_force_delete.
7025 * crosstabs.q: (struct table_entry) Put `freq' into a union with
7027 (struct crosstab) Add new member `ofs'.
7028 (glob var int_tab) Removed.
7029 (custom_tables) In integer mode, assign v[i] properly through the
7031 (custom_variables) Now p.crs.max == max + 1.
7032 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
7033 (precalc) Implement integer mode.
7034 (calc_integer) Implement integer mode.
7035 (compare_table_entry) Remove unused local variable `comparing'.
7036 (make_summary_table) Implement integer mode.
7037 (macro ns_rows) Implemented as static variable now.
7038 (several variables) Made static, from global.
7039 (output_pivot_table) Use table_value_missing() for column heads.
7040 Remove several unused local variables. Implement integer mode
7041 table summing. Count up ns_rows.
7042 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
7043 (find_pivot_extent) Moved into find_pivot_extent_general; now just
7044 calls that function or find_pivot_extent_integer.
7045 (find_pivot_extent_integer) New function.
7046 (enum_var_values) Implemented for integer mode.
7047 (table_value_missing) New function.
7048 (display_dimensions) Call table_value_missing() for heads.
7049 (float_M_suffix) New function.
7050 (display_crosstabulation) Call table_value_missing() for row
7051 heads. Handle missing values in /MISSING=REPORT mode.
7052 (calc_fisher) Remove unused var N.
7053 (calc_r) Remove unused var fact.
7055 * data-list.c: (dump_fixed_table) Fix table dimensioning.
7056 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
7058 * data-out.c: (insert_commas) Remove unused var cp.
7059 (convert_CCx) Remove unused vars save_set_decimal,
7062 * descript.q: (dump_z_table) Fix table dimensioning.
7063 (pre_calc) Remove unused var j.
7064 (display) Remove unused vars title, s. Fix table dimensioning.
7066 * expr-evl.c: Comment fixes.
7068 * frequencies.q: (full_dim) New function.
7069 (dump_full) Fix table dimensioning.
7070 (condensed_dim) New function.
7071 (dump_condensed) Fix table dimensioning.
7073 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
7076 * html.c: (html_close_drive) Remove unused var i.
7077 (postopen) Remove unused vars title, curfn_len, cp.
7078 (preclose) Remove unused vars this, x.
7080 * lexer.c: Comment fixes.
7082 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
7084 * means.q: (custom_tables) Remove unused var m_dim.
7086 * mis-val.c: Format fix.
7088 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
7090 * output.c: (outp_get_paper_size) Remove unused var cp.
7092 * pfm-read.c: (read_float) Remove unused var save, unused label
7094 (read_variables) Remove unused vars cp, j.
7095 (read_value_label) Remove unused var j.
7097 * pfm-write.c: (bufwrite) Remove unused var i.
7099 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
7101 (output_encodings) Remove unused vars char_cp, n_output.
7102 (read_ps_encodings) Remove unused var ep.
7103 (postopen) Remove unused var title.
7104 (preclose) Remove unused var fp.
7105 (ps_open_page) Remove unused vars true, false, orientation,
7106 mirror_horz, mirror_vert, width, length.
7107 (ps_text_metrics) Remove unused var x.
7109 * q2c.c: (find_symbol) Remove unused var y.
7110 (parse_setting) Remove unused parameter sbc, all references
7112 (dump_parser) Remove unused var cp.
7113 (dump_free) Remove unused var i.
7115 * set.q: (static vars args, n) Removed.
7116 (internal_cmd_gset) Removed.
7118 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
7119 (read_machine_flt64_info) Removed unused var file_endian.
7120 (read_documents) Removed unused var i.
7121 (read_compressed_data) Removed unused parameter dict, all
7124 * sfm-write.c: (bufwrite) Removed unused var i.
7125 (sfm_write_case) Removed unused var i.
7127 * sort.c: (merge_once) Remove unused var t.
7128 (write_separate) #if 0 out as dead code.
7130 * split-file.c: (cmd_split_file) Remove unused var i.
7132 * sysfile-info.c: (sysfile_info_dim) New function.
7133 (cmd_sysfile_info) Fix table dimensioning.
7134 (variables_dim) New function.
7135 (display_variables) Fix table dimensioning.
7136 (describe_variable) Remove unused var prev_r.
7138 * t-test.q: (z_postcalc) Removed.
7139 (pairs_calc) Remove unused var bad_weight.
7140 (postcalc) Remove unused vars dfn, dfd.
7142 * tab.c: (tab_create) Set t->dim to NULL.
7143 (tab_dim) Make sure t->dim is NULL first.
7144 (tab_natural_width) Remove parameter `clamp'.
7145 (tab_value) Remove duplicate assertion for table.
7146 (tab_raw) New function.
7147 (nowrap_dim) New function.
7148 (wrap_dim) New function.
7149 (tab_output_text) Fix table dimensioning.
7151 * tab.h: (tab_raw) New macro.
7153 * val-labs.c: (get_label) Remove unused var type.
7154 (copy_value_labels) Remove unused var trav.
7156 * var.h: (struct crosstab_proc) Completely changed.
7158 * vars-prs.c: (parse_dict_variable) Remove unused var v.
7160 * vfm.c: (open_active_file) Remove unused vars i, lp.
7162 * weight.c: (weight_trns_proc) #if 0 out as dead code.
7164 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
7166 * Makefile.am: Add apply-dict.c, flip.c.
7168 * apply-dict.c: New file.
7170 * command.c: (struct command) Make cmd[] larger for CLEAR
7171 TRANSFORMATIONS command name.
7172 (parse_cmd) Make sure we're in a valid state before using it as an
7173 index. Discard variables and reset state on invalid transitions.
7174 (cmd_clear_transformations) New function.
7176 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
7177 Add unimplemented PRESERVE, RESTORE.
7179 * file-handle.h: Include stddef.h.
7183 * pfm-read.c: (parse_value) Pad value label values with spaces,
7186 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
7187 (sfm_close) Decrement reference count, make sure it's zero.
7188 (sfm_maybe_close) New function.
7189 (sfm_read_dictionary) Handle reference counts.
7191 * vars-atr.c: (clear_default_dict) New function.
7192 (discard_variables) Use clear_default_dict().
7194 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
7196 * Makefile.am: Add pfm-write.c.
7197 (LDADD) Add the libgmp2 libraries.
7199 * command.def: Define EXPORT.
7201 * get.c: (cmd_export) New function.
7202 (export_write_case_func) New function.
7204 * pfm-read.c: (static spss2ascii[]) Make it const.
7206 * pfm-write.c: New file.
7208 * sfm-write.c: Formatting, comment fixes.
7210 * var.h: Comment fix.
7212 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
7214 * Makefile.am: Add pfm.h, pfm-read.c.
7216 * command.def: IMPORT is now implemented.
7218 * format.c: (glob var translate_fmt[]) New var.
7220 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
7221 (cmd_import) New function.
7222 (import_source_read) New function.
7223 (glob var import_source) New var.
7225 * pfm-read.c: New file.
7229 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
7231 (dump_dictionary) Disabled printing a couple of items.
7233 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
7235 * crosstabs.q: (postcalc) Call make_summary_table().
7236 (make_summary_table) New function.
7237 (insert_summary) New function.
7238 (display_dimensions) Remove some unnecessary arguments, all
7240 (output_pivot_table) Fix lots of problems with the risk table
7242 (submit) Don't display an empty table.
7243 (display_risk) Fix order of arguments to calc_risk().
7245 * glob.c: Always include assert.h and stdlib.h.
7247 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
7250 * tab.c: (tab_create) Cosmetic changes.
7252 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
7254 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
7258 * crosstabs.q: (output_pivot_table) Headers drawing and submission
7259 code simplified, moved into new function submit().
7260 (submit) New function.
7261 (crosstabs_dim) New function.
7262 (display_directional) Substitute variable names for %s where
7264 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
7265 (calc_symmetric) Initialize parameters only if non-NULL.
7266 Calculate Somers' d.
7267 (calc_directional) Calculate Somers' d (or copy it, really).
7270 * output.c: (outp_string_width) New function.
7272 * postscript.c: (postopen) Calculate font widths based on the
7273 width of the zero '0' character, not the width of the space
7274 character. Set paper-width and paper-length based on points, not
7276 (ps_open_page) Fix page setup string for landscape mode.
7278 * som.h: (struct som_dimension) Removed.
7279 (struct som_table_class) height, width members take int * not
7282 * tab.c: Many functions now have added parameter validation.
7283 (tab_height, tab_width) These functions were removed and merged
7284 into a single function tab_resize(), and all references changed.
7285 (tab_dim) Rewritten since the interface changed; reduced from
7286 hundreds of lines to two. All callers were changed. Currently
7287 most of them just use tab_natural_dimensions as their callback and
7288 await detailed translation of functionality.
7289 (tab_natural_width) New function.
7290 (tab_natural_height) New function.
7291 (tab_natural_dimensions) New function. This is a callback
7292 function, not something that you'd want to call directly.
7293 (tab_nat_dim) Removed.
7294 (tabi_table) Allocates t->w and t->h.
7295 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
7296 dimensions callback.
7297 (evaluate_dimensions) Removed.
7298 (sum_columns) Removed.
7300 * tab.h: (enum TAL_1THIN) Removed.
7301 (enum series t_*) Removed.
7302 (struct tab_table) Members trh, trv changed to unsigned char *
7303 from int *. Member dim changed to a function pointer from a
7304 unsigned char *. Member max_stack_height removed. New members
7306 (macros tab_l, tab_r, tab_t, tab_b) New.
7308 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
7310 * ascii.c: (delineate) Assign last_space_nchars before skipping
7311 spaces, to fix right justification.
7313 * crosstabs.q: (static vars risk, direct) New vars.
7314 (static var pearson_r) Removed.
7315 (glob var chisq_fisher) Made static.
7316 (static vars row_tot[], col_tot[]) Don't include grand total
7318 (static var grand_total) Renamed W, all references changed.
7319 (output_pivot_table) Only make `table' if num_cells != 0. Make
7320 risk and directional tables. Deal with grand total no longer part
7321 of col_tot[]. Free rows and cols after we're done with them.
7322 (display_risk) New function.
7323 (display_directional) New function.
7324 (clac_r) Rewritten so that it stores all its results into its
7325 arguments, so it can be used for Spearman's correlation too.
7326 (calc_symmetric) Added a t[] argument, all references changed.
7327 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
7328 Pearson's r, Cohen's kappa.
7329 (calc_risk) New function.
7330 (calc_directional) New function.
7332 * som.c: (som_submit) Improved debugging code.
7334 * stats.c: (hypercube) New function.
7335 (cube) New function.
7337 (normal_sig) Went back to old implementation, which actually
7340 * stats.h: (macros square, cube, hypercube) Removed. The
7341 equivalent functions in stats.c are inlined here; all references
7342 to square changed to sqr.
7344 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
7346 * crosstabs.q: (N_SYMMETRIC) New define.
7347 (postcalc) Disable debug printing.
7348 (static vars chisq_fisher, pearson_r) New.
7349 (output_pivot_table) Add support for symmetric measures. Add
7350 chi-square output of exact sigs.
7351 (display_chisq) Rewritten.
7352 (display_symmetric) New function.
7353 (gamma_int) New function.
7355 (swap) New function.
7356 (calc_fisher) New function.
7357 (calc_chisq) Check boundary conditions better. Calculate Yates,
7358 Fisher, Mantel-Haenszel tests.
7359 (calc_r) New function.
7360 (calc_symmetric) New function.
7362 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
7364 (chisq_sig) Better boundary conditions. Renamed from
7367 * tab.h: (struct tab_table) New member cf.
7369 * tab.c: (tab_create) Set cf.
7370 (tab_width) New function.
7371 (tab_realloc) Handle cf.
7372 (tab_vline) Handle cf.
7373 (tab_hline) Handle cf.
7374 (tab_box) Handle cf.
7375 (tab_value) Handle cf.
7376 (tab_float) Handle cf.
7377 (tab_text) Handle cf.
7378 (tab_joint_text) Handle cf.
7379 (tab_offset) Handle cf.
7380 (tab_next_row) Handle cf.
7381 (evaluate_dimensions) Handle cf.
7382 (render_strip) Handle cf.
7384 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
7386 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
7387 output_pivot_table().
7388 (output_pivot_table) Moved lots of local variables outside and
7389 made them static. Add beginnings of chi-square statistic
7390 support. Now column and row totals aren't in the main matrix.
7391 Always zero out any leftover rows & columns after we're done with
7392 the table entries. Move all output stuff into
7393 display_dimensions(), display_crosstabs(), display_chisq().
7394 (display_dimensions) New function.
7395 (display_crosstabulation) New function.
7396 (display_chisq) New function.
7397 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
7399 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
7400 references, simplify logic.
7402 * postscript.c: Remove scale, translate-x, translate-y,
7403 mirror-horz, mirror-vert, rotate-180 options.
7404 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
7405 All references deleted.
7406 (macro YT) New macro.
7407 (array option_tab[]) Removed options.
7408 (ps_option) Removed options.
7409 (ps_open_page) Write page setup explicitly to output file, without
7410 using now-deleted BP function.
7411 (macro dump_line) Use YT().
7412 (macro dump_thick_line) Use YT().
7413 (draw_headers) Use YT().
7414 (switch_font) Reorder arguments to SF function.
7415 (write_text) Use YT().
7417 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
7420 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
7422 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
7423 null-debugging code.
7424 (tab_realloc) Remove null-debugging code. Initialize new regions
7426 (tab_vline) Support offsets.
7427 (tab_hline) Support offsets.
7428 (tab_box) Support offsets.
7430 (tab_nulls) Removed.
7433 (evaluate_dimensions) Remove null-debugging code. Understand
7434 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
7435 TAB_EMPTY not present.
7437 * tab.h: New cell attribute TAB_EMPTY.
7438 (macros tab_nr, tab_nc, tab_row, tab_col) New.
7440 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
7441 try to read them from system files.
7443 * vfm.c: (dump_splits) Don't call tab_null().
7445 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
7447 * crosstabs.q: (struct crosstab) Added `missing' member.
7448 (custom_tables) Init missing.
7449 (calc_general) Handle missing values.
7450 (calc_chisq) New function.
7451 (output_pivot_table) Start work on chi-square output. Update for
7452 new tab offset support functions. Shorten statistic names.
7454 * Several files: add in more `const's to placate gcc's warnings.
7456 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
7459 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
7460 tab_null, tab_nulls, tab_value, tab_float, tab_text,
7461 tab_joint_text) Add col_ofs and row_ofs support.
7462 (tab_offset) New function.
7463 (tab_next_row) New function.
7464 (tab_row) New function.
7465 (tab_col) New function.
7466 (tabi_table) Add col_ofs and row_ofs support.
7468 * vars-atr.c: (is_system_missing) New function.
7470 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
7472 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
7473 (static var no_cells) Removed.
7474 (static var num_cells) New.
7475 (static var expected) New.
7476 (static var cells[]) New.
7477 (internal_cmd_crosstabs) Deal with new variables.
7478 (postcalc) Removed most of the meat and put it in new function
7479 output_pivot_table().
7480 (output_pivot_table) Calculates and outputs an entire pivot table.
7482 * postscript.c: (postopen) Fix problems with free()ing addresses
7483 not obtained from malloc().
7485 * som.c: (som_submit) Add assertion.
7487 * sysfile-info.c: (describe_variable) Use new tab_nulls()
7490 * tab.c: (static var tab_names[]) New.
7491 (tab_realloc) -1 for nc or nr indicates no change.
7492 (tab_nulls) New function.
7493 (tab_dim) Use tab_names[].
7494 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
7495 (evaluate_dimensions) Don't terminate on uninited cells, just put
7496 an X in them and emit a notice. Use tab_names[].
7498 * tab.h: Move bits into tab.def.
7500 * tab.def: New. Don't try to declare tab_table_class because then
7501 som.h has to be included.
7503 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
7505 * command.def: New file, contains all the command definitions
7506 previously included bodily in command.c.
7508 * format.def: New file, contains all of the format definitions
7509 previously split across format.h, format.c, and sfm-write.c.
7511 * lexer.h: Renamed from tokens.h in order to match corresponding
7514 * lexerP.h: Moved some rarely used functions exported by lexer.c
7517 * Makefile.am: Commemorate renamed files.
7518 (EXTRA_DIST) Add command.def, format.def.
7520 * command.c: [0] (walk_cmdtable_func) Removed.
7522 * crosstabs.q: (postcalc) Made it work and print out matrices
7524 (enum_column_values) Renamed enum_var_values, generalized for any
7527 * format.h: (struct fmt_desc) New member `spss'.
7529 * q2c.c: (main) Generated code includes lexer.h instead of
7532 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
7533 instead of an independent translation table.
7535 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
7537 * Lots of source files: Added const to declarations.
7539 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
7541 * arena.c: (arena_clear) Set prev pointer to null when done.
7543 * ascii.c: (ascii_option) Rename index as indx.
7545 * avl.c: This is now a separate library called libavl.
7546 (xmalloc) Make static.
7547 (avl_probe) Step A7 can use the cache instead of an explicit
7549 (avl_delete) Don't maintain a q pointer because it's always
7550 available in the pointer stack. Comment fix.
7552 * avl.h: This is now a separate library called libavl.
7554 * command.c: (cmd_table[]) Remove spurious trailing "".
7556 * common.h: Only include random() fix if this system needs it.
7558 * crosstabs.q: Include alloca headers.
7559 (n_sorted_tab) New global var.
7560 (postcalc) Mostly rewritten.
7561 (find_pivot_extent) Rewritten.
7562 (enum_column_values) Rewritten.
7564 * data-out.c: (convert_F) Rename inner n as n_spaces.
7566 * error.c: (dump_message) Don't have an outer var i.
7568 * file-handle.q: (static var f) Removed. All references removed.
7569 (internal_cmd_file_handle) Uses a local variable instead of f.
7571 * get.c: (trim_dictionary) Change scope of i, i1, i2.
7572 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
7575 * getline.h: Declare getl_history as extern. Reported by
7576 palme@uni-wuppertal.de (Hubert Palme).
7578 * postscript.c: (postopen) Some large mods for constness.
7580 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
7583 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
7585 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
7586 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
7589 * avl.c, avl.h: New files. These form a clean-room
7590 reimplementation of avllib. Iterative algorithms are used in
7591 place of recursive ones, so there is no resemblance in the code.
7593 * Lots of headers: Don't include other headers by default.
7595 * Lots of source files: Explicitly include all needed headers.
7597 * arena.c: (arena_clear) New function.
7599 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
7600 (static var ar) Removed.
7601 (staitc vars ar_tc, ar_col) New.
7602 (cmd_crosstabs) Destroy the arenas.
7603 (internal_cmd_crosstabs) Create the arenas.
7604 (precalc) Don't need a free function for the hash.
7605 (calc_general) Make sure to zero out the trailer on the key data
7607 (print_table_entries) Updated.
7608 (postcalc) Worked on actually implementing.
7609 (find_pivot_extent) New function.
7610 (compare_value) New function.
7611 (enum_column_values) New function.
7613 * data-in.c: (parse_month) Make local array `static const'.
7615 * data-out.c: (convert_date) Make local array `static const'.
7616 (convert_WKDAY) Same.
7617 (convert_MONTH) Same.
7619 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
7620 been renamed to avl_walk().
7622 * hash.c: Rewritten more efficiently.
7624 * hash.h: Add attribute const to hsh_next_prime declaration.
7626 * lexer.c: (id_match) Make arguments const.
7628 * postscript.c: (ps_postopen_driver) Make default fonts the
7631 * q2c.c: (main) Generated code needs stdlib.h.
7633 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
7634 initialized to 0 now, not to NULL. All other references to
7635 avl_traverser were updated in the same way.
7637 * tokens.h: Macro version of id_match updated to use const
7640 * val-labs.c: (inc_ref_count) New function.
7641 (copy_value_labels) Simply through use of new avl_copy() function.
7643 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
7645 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
7646 (postcalc) Worked on this.
7648 * postscript.c: (OPO_DOUBLE_LINE) New enum.
7649 (struct ps_driver_ext) New line_width_thick member.
7650 (ps_preopen_drive) Init line_width_thick.
7651 (option_tab[]) Add line-* options.
7652 (ps_option) Parse line-* options.
7653 (postopen) Add line_width_thick support. Strip leading spaces on
7654 prologue output lines.
7655 (ps_open_page) Include line_width_thick in output.
7656 (macro dump_thick_line) New.
7657 (dump_fancy_line) Support thick lines as well as double lines.
7659 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
7661 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
7662 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
7664 * Many source files: Rename `options' to `pv_opts' as appropriate.
7666 * command.c: (static var cmd_table[]) Add CROSSTABS command.
7668 * common.c: (xcalloc) New function.
7670 * crosstabs.q: New file. Not finished yet, though.
7672 * data-list.c: Comment fix.
7674 * error.c: Remove some old Checker cruft.
7676 * frequencies.q: (dump_full) Cumulate valid percent instead of
7679 * getline.c: Comment fix.
7681 * hash.c: Comment fixes.
7683 * hash.h: (struct hsh_table) Make hash functions return unsigned
7684 instead of int to avoid problems with taking the modulo of
7685 negative return values. All references changed.
7687 * misc.c: (intlog10) Make its table static const instead of auto.
7689 * sfm-read.c: (read_header) Make `prefix' static const instead of
7692 * var.h: (union value) Add member `hash'.
7693 (struct variable) Rename prv_index as `foo'--all references
7695 (typedef pv_opts) Removed. All references changed.
7697 * vars-prs.c: (parse_variables) Message fixes.
7699 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
7701 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
7702 they are being inserted. Don't check for BY variables of
7703 different types. Discard variables if the active file isn't
7704 included in the merge.
7705 (mtf_processing) Essentially rewritten.
7706 (mtf_merge_dictionary) Check for master/slave variables of
7707 different types/widths.
7709 * vfm.c: (static var not_canceled) New var.
7710 (process_active_file) Don't call vfm_source->read() if
7711 there's no vfm-source. Initialize not_canceled.
7712 (process_active_file_write_case) Honor and update not_canceled.
7713 (prepare_for_writing) Rollback changes from yesterday, they were
7715 (close_active_file) Don't destroy vfm_source unless it exists.
7717 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
7719 * Lots of source files: Added { } around nested if/else constructs
7720 to avoid new gcc 2.8 warnings.
7722 * data-in.c: (parse_Z) Declare `int' type explicitly.
7725 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
7726 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
7727 prev members. Put TABLEs at the end of the chain and FILEs at the
7728 beginning. Don't allow the active file in STATE_INIT. Use proper
7729 `seen' value for the active file. Fill out the by members and
7730 make sure they're of consistent type. Do the actual merge
7732 (mtf_processing_finish) New function.
7733 (var_type_description) New function.
7734 (mtf_free_file) New function.
7735 (mtf_free) Rewritten.
7736 (mtf_delete_file_in_place) New function.
7737 (mtf_read_nonactive_records) New function.
7738 (mtf_compare_BY_values) New function.
7739 (static var mtf_seq_no) New var.
7740 (mtf_processing) New function.
7741 (mtf_merge_dictionary) Assign nval members for the system file
7742 dictionary. Assign fv values for its variables. Point each slave
7743 variable to the corresponding master variable.
7745 * hash.c: Include str.h.
7747 * mis-val.c: (copy_missing_values) src arg is const.
7749 * misc.c: (spacing) Make `max' var explicitly int.
7751 * sfm-read.c: (dump_dictionary) Message reformatting.
7752 (sfm_read_case) Add assertion.
7754 * sort.c: Esthetic fixes.
7756 * var.h: (struct match_files_proc) New struct.
7757 (struct variable) Add private data match_files_proc.
7759 * vars-atr.c: (delete_variable) Implement. Add argument for the
7760 dictionary that owning the variable.
7761 (dup_variable) Add assertion.
7763 * vfm.c: Comment fixes, hopefully the comments are correct now.
7764 (process_active_file) New function.
7765 (process_active_file_write_case) New function.
7766 (process_active_file_output_case) New function.
7767 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
7769 (write_case) Renamed procedure_write_case(). Now write_case is a
7770 pointer to a function. Style fixes.
7772 1998-03-05 Ben Pfaff <blp@gnu.org>
7774 * Makefile.am: (q2c) Link with libmisc.
7775 (version.c) Define default_config_path, include_path,
7778 * ascii.c: (ascii_postopen_driver) When the default newline string
7779 is requested, open file in text mode. Suggested by
7780 palme@uni-wuppertal.de (Hubert Palme).
7781 (static vars line_buf, line_p) Change from char * to unsigned char
7783 (ascii_close_page) char * to unsigned char *.
7785 * cmdline.c: (parse_command_line) Implement -r option by
7786 prepending ~/.pspp/rc to the list of files to process.
7788 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
7789 before pulling in a final line.
7790 (null_func, null_int_func) Removed (dead code).
7792 * descript.q: (display) Calculate width of variable name column
7793 properly. Calculate number of valid cases properly. Reported by
7794 palme@uni-wuppertal.de (Hubert Palme).
7796 * filename.c: (init_filename) Use default_config_path instead of
7797 now obsolete CONFIG_PATH.
7799 * getline.c: (getl_initialize) Use include_path instead of now
7800 obsolete INCLUDE_PATH.
7801 (getl_add_file) New argument `where'. All references changed.
7803 * groff.c: (find_font_file) Use groff_font_path instead of now
7804 obsolete GROFF_FONT_PATH.
7806 * postscript.c: (find_ps_file) Use groff_font_path instead of now
7807 obsolete GROFF_FONT_PATH. Copy through temporary variable to
7808 avoid problems with constness.
7810 * str.h: (macro cs_streq) New macro.
7812 * version.h: (glob var default_config_path, include_path,
7813 groff_font_path) New vars.
7815 1998-02-23 Ben Pfaff <blp@gnu.org>
7817 * Many source files: Change verbose_msg() priority levels and
7820 * aggregate.c: Include debug-print.h.
7822 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
7824 (static var pre_syntax_message) Document --safer/-s and
7827 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
7829 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
7830 because it's not used but it's still copied.
7831 (open_file_r) Remove gratuitous debug message.
7833 * filename.c: (safety_violation) New function.
7834 (open_file) Remove gratuitous debug messages. Don't allow pipe
7835 files if set_safer is set.
7837 * get.c: Turn off debugging.
7839 * getline.c: (getl_add_virtual_file) New function.
7840 (getl_read_line) Add verbose_msg() call for opening new syntax
7842 (getl_perform_delayed_reset) Add a return value describing whether
7843 any action was taken. Call reset_eof().
7845 * getline.h: Comment fix.
7847 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
7848 place of incorrect `continue'. Use strtok_r() instead of
7849 strtok(). Always check strtok_r() return value.
7850 (groff_read_DESC) Use strtok_r() instead of strtok().
7852 * lexer.c: (reset_eof) New function.
7854 * main.c: (parse) Get a token after performing a delayed reset
7855 action; allow empty syntax files.
7857 * postscript.c: (output_encodings) Use strtok_r() instead of
7860 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
7862 * set.q: Comment fixes.
7863 (glob var set_safer) New var.
7864 (internal_cmd_set) Support SAFER.
7866 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
7868 * temporary.c: (free_dictionary) Set d->splits to NULL after
7871 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
7872 variable deleted, not if it *isn't* deleted.
7874 1998-02-16 Ben Pfaff <blp@gnu.org>
7876 * command.c: (array cmd_table[]) Add MATCH FILES.
7878 * common.c: Comment fixes.
7880 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
7881 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
7882 Include alloca.h. Problem reported by palme@uni-wuppertal.de
7885 * expr-opt.c: Include str.h. Problem reported by
7886 palme@uni-wuppertal.de (Hubert Palme).
7888 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
7889 (static var mtf_by) Change from char ** to variable **.
7890 (static var mtf_master) New var.
7891 (mtf_merge_dictionary) New function.
7892 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
7893 var type. Reorder tests properly. Initialize file->dict. Detect
7894 TABLE= without BY=. Read file dictionaries and merge them. Give
7895 subcommand name with IN, LAST, FIRST error messages. Create IN,
7896 LAST, FIRST variables. Comment fixes.
7897 (mtf_free) Don't free default_dict. Free mtf_master.
7899 * getline.c: Define getl_mode. Change getl_buf_size to size_t
7901 (handle_line_buffer) Cast int to size_t in comparison to avoid
7904 * getline.h: Declare getl_mode extern.
7906 * groff-font.c: (groff_read_font) Type-fix calls to getline.
7907 (groff_read_DESC) Make line_size a size_t.
7908 (match_tok) Parenthesize name to avoid macro expansion.
7910 * mis-val.c: (copy_missing_values) New function.
7912 * postscript.c: (postopen) Make buf_size a size_t.
7914 * sfm-read.c: (dump_dictionary) Make global from static. Print
7915 variable info in parts for easier debugging with Checker.
7917 * temporary.c: (copy_variable) Use copy_value_labels().
7918 (new_dictionary) New arg: whether to copy file label, documents.
7920 * val-labs.c: (copy_value_labels) New function.
7922 * var.h: (enums MISSING_*) Add MISSING_COUNT.
7924 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
7926 (dup_variable) Set prv_index, get.fv, get.nv.
7928 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
7930 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
7932 * Many source files: For ANSI-compliance, add empty statement
7933 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
7934 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7936 * data-in.c: (parse_numeric) Some header files break on
7937 -DBL_MIN_10_EXP because they get a --; add () for safety.
7938 Reported by palme@uni-wuppertal.de (Hubert Palme).
7940 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
7941 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
7942 (dfm_close) Use close_file_ext.
7943 (open_inline_file) Set file.file to NULL, not file.
7944 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
7945 struct and use open_file_ext().
7946 (read_record) Use file.file.
7948 * file-handle.q: (prepend_current_directory) Pass through special
7951 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
7952 (normalize_filename) Pass through special filenames.
7953 (open_file, close_file) Accept pipe| and |pipe syntaxes as
7955 (dirname) Rename blp_dirname() because of name conflict on some
7956 OS. All references changed. Reported by palme@uni-wuppertal.de
7958 (is_special_filename) New function.
7960 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
7961 (trim_dictionary) Conditionalize some of the options on whether
7962 GTSV_OPT_MATCH_FILES is in *options.
7963 (rename_variables) Don't allow variables to be renamed as scratch
7965 (MTF_*) New enum series.
7966 (struct mtf_file) New struct.
7967 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
7969 (cmd_match_files, mtf_free) New functions.
7971 * lexer.c: (match_int) Needed parentheses around name to escape
7972 macro expansion. Reported by Micah Altman
7973 <maltman@www-vdc.fas.harvard.edu>.
7975 * print.c: Needed to include alloca.h. Reported by Micah Altman
7976 <maltman@www-vdc.fas.harvard.edu>.
7978 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
7979 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
7982 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
7983 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7985 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
7987 * html.c: (struct html_driver_ext) Move into htmlP.h.
7988 (html_preopen_driver) Initialize cp_x, cp_y.
7989 (html_submit) Implement as call to output_tab_table().
7990 (change_attributes) New function.
7991 (escape_string) New function.
7992 (output_tab_table) New function.
7994 * list.q: (write_all_headers) Add code for writing headers for the
7996 (clean_up) Write out the html close-table tag.
7997 (determine_layout) Ignore html driver.
7998 (list_cases) Write html data.
8000 * som.c: (som_submit) Move more of the code into output_table().
8002 * tab.c: (static var hit) Make a global var and rename tab_hit.
8003 (static var tab_table_class) Make a global var.
8005 * htmlP.h: New file.
8007 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
8009 * dump-sysfile.c: Removed.
8011 * html.c: (preclose) Change comment in emitted code.
8013 * matrix-data.c: Debugging off by default. Comment fixes.
8014 (static var container) New var.
8015 (cmd_matrix_data) Create and destroy container. Initialize
8016 is_per_factor[] to 0s. Move code into new function
8017 string_to_content_type(). Require split values to be present in
8018 the data when ROWTYPE_ is explicit. Call specific function, not
8019 general read_matrices().
8020 (string_to_content_type) New function.
8021 (context) Exclude all whitespace, not just spaces.
8022 (mget_token) A dot is a number. Add assertion.
8023 (static var data) Renamed nr_data.
8024 (static var factor_values) Renamed nr_factor_values.
8025 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
8026 only specific case. Close data_file before exit.
8027 (fill_matrix) New function.
8028 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
8029 printing. Style fixes. Message fixes. Move code into
8031 (read_matrices_without_rowtype) Rename
8032 matrix_data_read_without_rowtype(). Fix off-by-one error on
8033 loops. Allocate nr_data[] memory from arena.
8034 (read_matrices_with_rowtype) Removed.
8035 (read_splits) Renamed nr_read_splits(). Style fixes.
8036 (read_factors) Renamed nr_read_factors().
8037 (dump_cell_content) Comment fixes. Arguments changed. Change
8038 debug printing. All references changed.
8039 (output_data) Renamed nr_output_data().
8040 (static var wr_content) New var.
8041 (struct factor_data) New struct.
8042 (static var wr_data) New var.
8043 (static var wr_current) New var.
8044 (matrix_data_source_destroy_source) Removed.
8045 (read_matrices_with_rowtype) New function.
8046 (matrix_data_read_with_rowtype) New function.
8047 (wr_read_splits) New function.
8048 (compare_factors) New function.
8049 (wr_output_data) New function.
8050 (wr_read_rowtype) New function.
8051 (wr_read_factors) New function.
8052 (wr_read_indeps) New function.
8053 (glob var matrix_data_source) Make destroy_source member NULL as
8056 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
8058 * lexer.c: (syntax_error) Give better error message when at end of
8061 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
8062 N_SCALAR to output as plain N.
8063 (mdump_token) Change output format.
8064 (context) Fix message output interaction with spaces in input.
8065 (another_token) New function.
8066 (force_eol) Improved error message.
8067 (static var max_cell_index) New var.
8068 (read_matrices) Init `cells'. factor_values is now per-cell.
8069 Init max_cell_index.
8070 (read_data_lines) Replace `compare' local with new `compare' arg.
8071 Debugging messages changed. Only read factors if per_factor.
8072 Propagate error return from read_factors(), force_eol().
8073 Copy N_SCALAR values across the N vector.
8074 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
8075 check parentheses manually since we now have is_per_factor[].
8076 Call read_data_lines() with new args. Check for end of data after
8077 looping, using another_token().
8078 (read_factors) Arguments changed. Use max_cell_index to determine
8079 whether to read or compare factors. Message fixes.
8080 (dump_cell_content) New function.
8081 (output_data) Completely rewritten because content types were
8082 supported to be nested inside factor values, not vice versa.
8084 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
8086 * lexer.c: (syntax_error) Support formatted varargs messages.
8088 * matrix-data.c: Turn debugging on by default.
8089 (static content_type[]) New array.
8090 (static content_names[]) New array.
8091 (static rowtype_, varname_) New vars.
8092 (static is_per_factor[]) New array.
8093 (static split_values) Moved declaration.
8094 (static n_continuous, first_continuous) New var.
8095 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
8096 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
8097 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
8098 Check for continuous variables.
8099 [DEBUGGING] (debug_print) Remove content_names[].
8100 (mdump_token) New macro.
8101 (mget_token_dump) New function.
8102 (mdump_token) New function.
8103 (context) New function.
8104 (mget_token) Fix messages.
8105 (static var data, split_values, factor_values) New vars.
8106 (read_matrices) Manage split_values, factor_values.
8107 (read_data_lines) New function.
8108 (read_matrices_without_rowtype) Implemented.
8109 (read_splits) Message fixes. Uses `just_read'.
8110 (read_factors) New function.
8111 (output_data) New function.
8112 (matrix_data_source_destroy_source) Close the file handle.
8113 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
8116 * str.c: (strpadcmp) Removed.
8118 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
8120 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
8122 * Lots of source files: Add cast to unsigned character to calls to
8123 tolower() and toupper().
8125 * aggregate.c: Set default_dict.splits to NULL.
8127 * command.c: (static variable tab[]) Add MATRIX DATA.
8129 * data-in.c: Add debugging defines. Formatting fixes.
8131 * expr-opt.c: Formatting fixes.
8133 * lexer.c: (syntax_error) Message fixes.
8135 * matrix-data.c: New enum series.
8136 (static vars fmt, section, diag, explicit_rowtype, signle_split,
8137 split_values, n_factors, factors, cells, pop_n, contents,
8138 n_contents) New vars.
8139 (cmd_matrix_data) Finished implementation.
8140 (compare_variables_by_mxd_vartype) New function.
8141 [DEBUGGING] (debug_print) New function.
8142 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
8143 (read_matrices) New function.
8144 (read_matrices_without_rowtype) New function.
8145 (read_matrices_with_rowtype) New function.
8146 (read_splits) New function.
8147 (mget_token) New function.
8148 (force_eol) New function.
8149 [0] (test_tokenizer) New function.
8150 (matrix_data_source_destroy_source) New function.
8151 (glob var matrix_data_source) New var.
8153 * misc.h: Include ieeefp.h if present.
8155 * split-file.h: (cmd_split_file) Changes corresponding to struct
8158 * str.h: Fix memmem prototype.
8160 * temporary.c: (save_dictionary, restore_dictionary,
8161 free_dictionary) Changes corresponding to struct dictionary
8164 * var.h: (MXD_* enums) New enum series.
8165 (struct matrix_data_proc) New struct.
8166 (struct split) Removed.
8167 (struct dictionary) Changed `splits' member from `split *' to
8169 (macro force_create_variable) New macro. Replaced lots of
8170 create_variable()/assert() calls with calls to this macro.
8172 * vars-atr.c: (discard_variables) Changed assertion.
8173 [GLOBAL_DEBUGGING] (force_create_variable) New function
8174 called by the macro of the same name.
8175 (clear_variable) Changes to delete splits from the dictionary
8176 corresponding to struct dictionary changes.
8178 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
8179 corrupted variable `index' values in the dictionary passed in
8180 every time this function is called.
8182 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
8183 to struct dictionary changes.
8185 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
8187 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
8189 * command.c: New includes.
8190 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
8191 (cmd_erase) New function.
8192 [unix] (shell) New function.
8193 (run_command) New function.
8194 (cmd_host) New function.
8195 (cmd_new_file) New function.
8197 * expr-prs.c: (parse_primary) Message fix.
8199 * inpt-pgm.c: Formatting fix.
8200 (cmd_reread) Implement the FILE subcommand.
8202 * matrix-data.c: New file.
8204 * q2c.c: (dump_header) Change output commenting style.
8206 * weight.c: Comment fix.
8208 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
8210 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
8212 (buf_10x) Renamed buf_1xx, all references changed.
8213 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
8214 cases now implemented).
8215 (create_sysfile) New function.
8216 (agr_11x_func) New function.
8218 * data-in.c: (parse_numeric) Work properly if there's an
8219 explicitly coded decimal point in the data and decimal places are
8220 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
8221 <el@linux.lisse.na>.
8223 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
8224 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
8225 Eberhard W Lisse <el@linux.lisse.na>.
8227 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
8228 strerror.c. Bug reported by Alexandre Oliva
8229 <oliva@dcc.unicamp.br>.
8231 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
8232 (static var separate_case_tab) New var.
8233 (cmd_sort_cases) Cancel temporary transformations here. Free
8234 v_sort before return.
8235 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
8236 we're reading from a sort stream. Don't cancel temporary
8237 transformations. Offload internal sorting to do_internal_sort().
8238 (do_internal_sort) New function. Handles internal sorting even
8239 when SEPARATE is nonzero. Doesn't free v_sort.
8240 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
8242 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
8243 sink if SEPARATE is zero.
8244 (read_output_cases) Renamed read_sort_output(), all references
8245 changed. Now uses separate_case_tab when it exists.
8246 (write_separate) New function.
8248 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
8249 memory_sink_cases. Don't redundantly call
8250 vfm_source->destroy_source().
8251 (memory_stream_mode) After switching over, set memory_sink_cases
8254 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
8256 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
8258 (static var prev_case) New, moved out of aggregate_single_case()
8260 (static var buf64_10x, buf_10x) New.
8261 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
8262 the 000, 001, 100, and 101 cases. Free prev_case.
8263 (parse_aggregate_functions) Disallow scratch variables.
8264 (free_aggregate_functions) Only free agr_dict if non-null. Use
8265 iter->function to determine numeric/string type, not
8267 (aggregate_single_case) Don't manage prev_case. Initialize
8268 aggregate info after dumping it.
8269 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
8270 mean, stddev, weighted stddev definitions.
8271 (dump_aggregate_info) Implemented.
8272 (initialize_aggregate_info) Renamed from
8273 initialize_aggregate_functions(). Initializes dbl[2].
8274 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
8275 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
8277 * cases.c: (alloc_val) Removed.
8279 * get.c: (cmd_save_internal) Initialize new `dict' member.
8281 * sfm-write.c: (sfm_write_dictionary, write_header,
8282 write_variable, write_value_labels, write_documents) Reorganize,
8283 simplify for new parameter structure.
8284 (write_variable) Only one variable * argument now.
8286 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
8287 replaced by new `dict' member.
8289 * temporary.c: (new_dictionary) Initialize n_documents.
8291 * vars-atr.c: (dup_variable) Allocate `value's from dict into
8293 (init_variable, replace_variable) Eliminate usage of alloc_val().
8295 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
8297 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
8298 signal that AGGREGATE is to be used for forming final cases.
8299 (close_active_file) Call end_func before stopping lagging. Cancel
8300 temporary after finishing compaction.
8301 (write_case) Comment fixes. Cleaned up.
8302 (compact_case) Let AGGREGATE handle compaction when `temporary' is
8305 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
8307 * Makefile.am: (BUILT_SOURCES) Add means.c.
8308 (pspp_SOURCES) Add means.c.
8309 (EXTRA_DIST) Add means.q.
8311 * command.c: (array cmd_table[]) Add MEANS.
8313 * common.h: Esthetic fixes. Comment fixes. Test for
8314 MAX_SHORT_STRING greater than 8.
8315 (macros LOWEST, HIGHEST) New.
8317 * data-in.c, data-list.c, recode.c: Comment fixes.
8319 * means.q: New file, base version.
8321 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
8322 with LOWEST, DBL_MAX with HIGHEST.
8324 * q2c.c: (dump_vars) Add an enum to array types giving the number
8325 of values for the enum.
8327 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
8328 Replace second_lowest_value with second_lowest_flt64.
8330 * sfm-write.c: (write_variable, write_rec_7_34) Replace
8331 second_lowest_value with second_lowest_flt64.
8333 * t-test.q: Comment fix.
8335 * temporary.c: (restore_dictionary) Esthetic fix.
8337 * tokens.h: (force_match_id, force_match, force_string, force_int,
8338 force_num, force_id) Replace msg() with syntax_error().
8340 * var.h: (struct means_proc) New.
8341 (struct variable) Add mns member to `p' union.
8343 * vars-prs.c: (parse_variable, parse_dict_variable,
8344 parse_variables, parse_DATA_LIST_vars) Replace msg() with
8347 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
8349 * Makefile.am: (pspp_SOURCES) Add tab.h.
8351 * Most source files: Added a cast to unsigned char in usages of
8352 the ctype is*() functions. Replaced `end of command expected'
8353 calls to msg() with calls to syntax_error().
8355 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
8357 * lexer.c: (hex_val) Removed (was dead code).
8358 (idmatch) Parenthesize function name to avoid macro expansion.
8360 * postscript.c: Comment fixes.
8361 (ps_preopen_driver) Change default font size to 10pt.
8363 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
8365 (parse_format_spec) Change system-file format spec argument type
8366 to int32. Parse the format spec with bitwise operators.
8368 * sfmP.h: (struct sysfile_format) Removed.
8369 (struct sysfile_variable) Changed print, write members from
8370 sysfile_format to int32.
8372 * tokens.h: Esthetic fixes.
8373 [__GNUC__] (macro id_match) New macro to hopefully speed up
8374 identifier matching.
8375 (macros match_id, match_tok, match_int) Implemented in
8376 compiler-independent manner; no longer GNU C only.
8378 * vfm.h: Include time.h.
8380 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
8382 * data-list.c: (dump_fixed_table) Change tab_dim().
8384 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
8386 * error.c: Include command.h.
8388 * frequencies.g: Formatting fixes.
8390 * frequencies.q: Add tab_dim() calls. Make the total cell a
8393 * glob.c: Include command.h.
8395 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
8397 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
8398 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
8399 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
8400 the other elements (is this right?).
8401 (read_variables) Use lowest, highest members.
8402 (parse_format_spec) New arg `vv' for more stringent checking.
8403 (dump_dictionary) Byteswaps nonexplicit data.
8404 (sfm_read_case) Byteswap numeric data.
8406 * som.c: Initialize table_num to 1.
8407 (render_segments) Remember to increment y_index after each table
8410 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
8411 avl_count() on a NULL tree. No title for the second table.
8412 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
8413 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
8414 fix call to display_variables().
8415 (display_variables) Default to 4 columns, not 3. Set up headers.
8416 Column title is Variable, not Name. Fix index column.
8417 Add joint text. Add tab_dim(). Handle value labels properly.
8418 Handle DISPLAY LABELS properly. Draw boxes correctly.
8419 (describe_variable) Value labels don't need titles. Don't clear
8420 nonexistent index column.
8421 (compare_vectors_by_name) New function.
8422 (display_vectors) New function.
8424 * tab.c: (tab_height) Add assertion.
8425 (tab_null) Add debug code.
8426 (evaluate_dimensions) Add debug code.
8428 * var.h: (struct variable) get_proc data is sometimes used
8429 simultaneously with other per-procedure info, therefore it was
8430 removed from the union. All references changed.
8432 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
8434 * ascii.c: (ascii_close_page) Put title on second line of headers
8435 if there is no subtitle.
8437 * command.c: (glob var cur_proc) Move definition here, from
8439 (cmd_remark) Emit blank line before remarks.
8441 * command.h: (glob var cur_proc) Move declaration here, from
8444 * data-list.c: (dump_fixed_table) Fix messages.
8445 (dump_free_table) Call tab_nat_dim().
8447 * descript.q: (dump_z_table) Modify tab_dim() call.
8449 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
8451 (dump_statistics) Don't output header.
8453 * groff-font.c: Minor format fix.
8455 * html.c: Comment fix.
8457 * list.q: (write_varname) Indent after advancing page.
8459 * output.h: Minor reordering.
8461 * postscript.c: Comment fixes. Many places, '\n' was replaced by
8462 a reference to eol[].
8463 (struct ps_driver_ext) New member eol[].
8464 (ps_preopen_driver) Initialize eol[].
8465 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
8466 defaults. Handle headers. Fix test for minimum page length.
8467 (static var option_tab[]) Add `line-ends'.
8468 (ps_option) Handle line-ends to change eol[].
8469 (postopen) Scale prop_em_width and fixed_width properly. Set the
8470 prologue title to outp_title if applicable. Replace the prologue
8471 line ends with eol[]. Call draw_headers() if headers are enabled.
8472 (text_width) New function.
8473 (out_text_plain) New function.
8474 (draw_headers) New function.
8476 * print.c: (dump_table) Call tab_nat_dim().
8478 * som.c: (som_blank_line) Only advance a line if not at the top of
8480 (som_submit) Move several informational table calls here.
8481 Increment subtable_num if SOMF_NO_TITLE not set.
8482 (output_table) Advance a line if SOMF_NO_SPACING not set.
8483 (render_columns, render_segments, render_simple) Handle spacing
8484 between tables. Handle table titles. Remove debug output.
8486 * som.h: (SOMF_*) New enum series.
8487 (struct som_table_class) New member `flags'.
8489 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
8491 (display_variables) Calls tab_nat_dim().
8492 (describe_variable) Remove restriction on number of value labels.
8493 Make value labels separated by thin lines.
8495 * tab.c: (tab_create) Default `flags' to none.
8496 (tab_float) New arg `w'. All references changed.
8497 (tab_nat_dim) New function.
8498 (tab_output_text) No title or spacing.
8499 (tab_flags) New function.
8500 (tabi_flags) New function.
8501 (tabi_title) New function.
8502 (strip_height) Removed.
8503 (tabi_render) Skip title when necessary.
8504 (static var tab_tab_class) Add tabi_flags, tabi_title.
8505 (evaluate_dimensions) Disable display of column, row size.
8506 (sum_columns) Add title height to top header.
8507 (render_strip) Moved within file.
8509 * tab.h: (struct tab_table) New member `flags'.
8511 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
8513 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
8515 * Most source files: Add `const' attribute in all appropriate
8518 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
8519 column to the variables table for use by describe_variable().
8520 (cmd_display) Disable for the present.
8521 (display_documents) Don't wrap documents.
8522 (display_variables) Table has four columns now.
8523 (describe_variable) Table has four columns now. Don't use a
8524 subtable, use joined cells instead.
8526 * tab.c: (tab_create) Don't set `join'.
8527 (tab_realloc) ct array is not made up of a_string's.
8528 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
8529 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
8530 (text_format) New function.
8531 (tab_title) Rewritten, uses text_format().
8532 (tab_text) Rewritten, uses text_format().
8533 (tab_joint_text) New function.
8535 (static var hit) New variable.
8536 (render_strip) New args r1, r2. Implement joined cells that fit
8538 (tabi_render) Increment hit. Pass new args to render_strip().
8539 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
8540 cells. For t_naw and t_nah, ignore joined cells and null cells in
8543 * tab.h: (struct tab_join_rect) Removed.
8544 (struct tab_table) Removed `join'.
8545 (TAB_JOIN_MAIN) Removed.
8546 (struct tab_joined_cell) New struct.
8547 (TAT_NOWRAP) New enum.
8549 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
8551 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
8553 (ascii_postopen_driver) Fix initialization of *_spacing so that
8554 the TAL_0 bit doesn't count.
8556 * data-list.c: (dump_fixed_table) Use natural width for Format
8559 * glob.c: (rerange) Removed.
8560 (get_date) Formatting fixes. Internationalization fix.
8562 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
8565 * postscript.c: (ps_postopen_driver) Replace
8566 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
8568 * som.c: (som_submit) Don't eject page before every table.
8569 (output_table) Fix order of arguments on call to area().
8570 (render_columns) Fix calculation of max_len.
8572 * tab.c: (tabi_cumulate) Minor change to increase elegance.
8573 (render_strip) New function.
8574 (strip_height) New function.
8575 (tabi_render) Rewrite as calls to render_strip().
8577 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
8578 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
8579 with the TAB_* and OUTP_T_* constants.
8581 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
8583 * Makefile.am: Formatting fixes.
8585 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
8588 * data-list.c: (dump_fixed_table) Add tab_dim() call.
8590 * descript.q: (dump_z_table, display) Add tab_dim() calls.
8592 * dump-sysfile.c: (glob var length) Make type off_t.
8593 (usage) Fix arguments.
8596 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
8597 Now right-justification is the default so many references had to
8599 (struct outp_class) Removed line_width, all references changed.
8600 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
8601 (struct outp_driver) Add elements horiz_line_width,
8602 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
8605 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
8607 (postopen) Initialize all the informational members of
8610 * som.c: (som_blank_line) New function, renamed from blank_line(),
8611 all references changed.
8612 (som_submit) Disables drivers whose pages can't be opened.
8613 (render_columns, render_simple, render_segments) Add debug output.
8614 (render_columns) Fix loop range.
8615 (render_simple) Don't try to render the headers, they're taken
8616 care of automatically. Advance cp_y past the table when done.
8617 (render_segments) Fix loop ranges.
8619 * tab.c: Initialize new members of tab_table.
8620 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
8621 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
8622 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
8625 (tab_dim) New function.
8626 (tab_col_width) Removed.
8627 (tab_row_height) Removed.
8628 (tab_output_text) Call tab_dim().
8629 (tabi_driver) Call evaluate_dimensions(), sum_columns().
8630 (tabi_area) Implemented.
8631 (tabi_cumulate) Implemented.
8632 (tabi_render) Partially implemented, but broken.
8633 (var tab_table_class) Made static.
8634 (evaluate_dimensions) New function.
8635 (sum_columns) New function.
8637 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
8638 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
8639 t_scr, t_srr, t_sentinel. Removed: t_nat.
8640 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
8641 max_stack_height, w, h. Removed: ce, re.
8642 (macro blank_line) Removed.
8643 (glob var zero_length) Removed.
8645 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
8647 * Most source files: include some of the new include files broken
8650 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
8653 * aggregate.c: (glob var outfile) Make static.
8655 * command.c: (glob var pgm_state) Move here.
8657 * common.c: (glob vars endian, second_lowest_value, pgmname,
8658 finished, curdate, cur_proc, start_interactive, history_file) Move
8661 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
8663 * file-handle.q: (glob vars files, inline_file) Move here.
8665 * glob.c: Lost lots of glob vars, detailed in individual file
8667 (init_glob) set_printer, set_screen were obsolete, deleted.
8668 set_cprompt has fewer spaces because pspp has fewer letters than
8671 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
8672 (inp_nval) Made static.
8674 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
8675 tokstr_len, toklongstr, tokint) Move here.
8677 * misc.c: Lost several vars and functions.
8679 * set.q: (all the set_* variables) Move here.
8681 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
8682 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
8685 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
8687 * tab.h: (enum series t_*) New enums.
8688 (struct tab_table) Use arena struct tag. New members ce, re.
8690 * tokens.h: Comment fixes.
8692 * var.h: Move lots of enums and variables and functions and
8693 structures to other files. Use and declare a lot more union and
8694 struct tags. Comment fixes.
8696 * vector.c: (glob vars vec, nvec) Move here.
8698 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
8699 init_blanks, last_vfm_invocation) Move here.
8701 * cases.h: New file.
8702 (struct long_vec) Move here.
8703 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
8706 * command.h: New file.
8707 (STATE_* enums) Move here.
8708 (glob var pgm_state) Move here.
8710 * format.c: New file.
8711 (glob var formats) Move here.
8712 (parse_format_specifier_name, fmt_to_string,
8713 check_input_specifier, check_output_specifier,
8714 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
8717 * format.h: New file. Move functions now in format.c here.
8718 (FMT_* enums) Move here.
8719 (struct fmt_desc) Move here.
8720 (FCAT_* enums) Move here.
8721 (struct fmt_spec) Move here.
8722 (glob vars formats, fmt_parse_ignore_error) Move here.
8724 * inpt-pgm.h: New file.
8725 (INP_* enums) Move here, make #defines into enums.
8726 (glob vars inp_init, inp_init_size) Move here.
8729 (glob vars v_sort, nv_sort) Move here.
8730 (sort_cases, read_sort_output) Move here.
8732 * vector.h: New file.
8733 (struct vector) Move here, add struct tag.
8734 (glob vars vec, nvec) Move here.
8735 (find_vector) Move here.
8738 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
8739 reinit_blanks, init_zero, init_blanks) Move here.
8740 (struct case_stream) Move here.
8741 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
8742 vfm_disk_stream, sort_stream, data_list_source,
8743 input_program_source, file_type_source, get_source, n_lag) Move
8745 (procedure, write_case, lagged_case, compact_case, page_to_disk)
8748 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
8750 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
8751 (LDADD) Add libdcdflib.
8753 * ascii.c: Comment and formatting fixes. Almost every external
8754 function had an assert added, checking driver_open and page_open.
8755 (ascii_init_driver) Broken into ascii_preopen_driver,
8756 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
8757 (ascii_open_page) Sets page_open.
8758 (ascii_close_page) Clears page_open.
8760 * html.c: Comment and formatting fixes. Almost every external
8761 function had an assert added, checking driver_open and page_open.
8762 (html_init_driver) Broken into html_preopen_driver,
8763 html_postopen_driver, html_close_driver. Manages driver_open.
8764 (html_open_page) Sets page_open.
8765 (html_close_page) Clears page_open.
8766 (html_submit) Disabled.
8768 * lexer.c: (parse_string) Remove debugging printf.
8770 * list.q: (determine_layout) Open a page if one is not yet open.
8772 * output.c: Comment fixes.
8773 (add_class) Set the class member of the new list element.
8774 (parse_options) Don't handle device type.
8775 (colon_tokenize) New function.
8776 (configure_driver) New four-field format with a field for device
8777 type. Now initialize driver_open, page_open, next, and prev
8778 fields. Use new colon_tokenize() function. Don't do a memory
8779 copy to replace a driver, it doesn't work; instead delete the old
8780 driver and insert a new one.
8781 (destroy_driver) Don't call som_destroy_driver(). Close the page
8782 if it's open. Find the class in the list of classes and decrement
8783 that reference count. Remove the driver from the global driver
8785 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
8786 references changed. Rewritten. Don't return a driver that's not
8788 (outp_eject_page) All references to som_internal_eject_page()
8789 changed to use this. Sets cp_x to 0 as well as cp_y.
8791 * output.h: (OUTP_I_* enums) Removed.
8792 (struct som_submission_form) Removed.
8793 (struct outp_class) init_driver broken into preopen_driver,
8794 postopen_driver, and close_driver. submit changed to take a
8797 * postscript.c: Comment and formatting fixes. Almost every
8798 external function had an assert added, checking driver_open and
8800 (ps_init_driver) Broken into ps_preopen_driver,
8801 ps_postopen_driver, ps_close_driver. Manages driver_open.
8802 (ps_open_page) Sets page_open.
8803 (ps_close_page) Clears page_open.
8805 * som.c: New file, base implementation.
8807 * som.h: (struct som_table) Add struct tag.
8808 (enum SOM_COL_ACROSS) Removed.
8809 (SOM_ROWS, SOM_COLUMNS) New enums.
8810 (struct som_table_class) Add member `cumulate'. Remove `segment';
8811 change `render' arguments.
8812 (struct som_point, struct som_rect) Removed.
8813 (som_submit_table) Fixed typo, should have been som_submit.
8815 * sysfile-info: (describe_variable) Don't try to insert a
8816 subtable; just destroy it for now.
8818 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
8819 references to value labels.
8821 * tab.c: (tab_destroy) New function.
8822 (tab_columns) Change argument.
8823 [0] (tab_submit) Remove dead code.
8824 (tab_title) Allocate string from the table's arena.
8825 (tab_output_text) Only free the buffer if we allocated it.
8826 (tab_submit) New function.
8827 (static vars t, d) New static vars.
8828 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
8829 tabi_headers, tabi_cumulate, tabi_render) New functions.
8830 (glob var tab_table_class) New global var.
8832 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
8833 encapsulate the rectangle. All references changed.
8835 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
8837 * All header files updated to use struct tags in addition to
8838 typedefs for all structures. Don't use word `struct' in struct
8841 * Makefile.am: (pspp_SOURCES) Remove html.c.
8842 (INCLUDES) Replace the lib/* includes with a single lib/ include;
8843 all references updated.
8845 * command.c: (parse_cmd) Remove call to som_check_workspace.
8846 (output_line) Update to new som.
8848 * data-in.c: (parse_numeric) A single dot is not an error; it is
8849 the system-missing value.
8851 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
8854 * data-out.c: Added `const' as appropriate to many prototypes.
8855 (convert_E, convert_F, convert_CCx) Take double argument instead
8856 of value * argument.
8857 (convert_format_to_string) Call changed functions appropriately.
8858 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
8859 make a local copy of the value.
8861 * descript.q: Remove custom_variables() prototype now provided by
8863 (custom_variables) Don't increment sbc_variables, the caller does
8865 (dump_z_table, display) Update to new som.
8867 * error.c: (vmsg) Add const to prototype. Remove code to handle
8868 `too many errors' condition.
8869 (check_error_count) New function.
8870 (msg) Add const to prototype.
8872 * filename.c: (open_file) Rewrite for elegance.
8874 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
8875 (dump_full, dump_condensed, dump_statistics) Update for new som.
8877 * list.q: Don't include somP.h. Change all references to
8878 som_driver_ext to refer to the new members of som_driver. Change
8879 som_internal_eject_page() references to outp_eject_page().
8881 * main.c: (parse) Rewrite for elegance. Add call to
8882 check_error_count().
8884 * output.c: (add_class, outp_list_classes, outp_configure_driver)
8885 Rewrite or revise for new outp_driver_class_list structure.
8886 (outp_iterate_enabled_drivers) Fix comparison between disabled
8887 devices and current device type.
8888 (outp_eject_page) New function.
8890 * output.h: Comment fixes.
8891 (struct outp_driver) New members driver_open, page_open, cp_x,
8892 cp_y, font_height, prop_em_width, fixed_width. Deleted members
8894 (struct outp_driver_class_list) New struct.
8895 (outp_class_list) Changed to type outp_driver_class_list; all
8898 * print.c: (dump_table, print_trns_proc) Updated for new som.
8900 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
8901 prototypes for custom subcommands.
8902 (dump_subcommand) Always include the `else'.
8903 (dump_parser) Fix comments in output code.
8905 * set.q: Reordered functions.
8907 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
8909 * som.h: Rewritten from scratch.
8911 * str.h: Remove dead code.
8913 * tab.c, tab.h: New files, base implementation.
8915 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
8918 * t-test.q: New code from John Williams
8919 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
8920 Many many new static vars and defines.
8921 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
8922 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
8923 (struct value_list) New struct.
8924 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
8925 t_crt, t_sig, print_t_groups) New functions.
8926 (cmd_t_test) Implemented.
8928 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
8931 * vfm.c: (dump_splits) Update to new som.
8933 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
8935 * Makefile.am: (fiasco_SOURCES) Add html.c.
8937 * aggregate.c: Base source.
8939 * ascii.c: (postopen, preclose) Reformat.
8941 * data-out.c, expr-evl.c: Comment fixes.
8943 * filename.c: (open_file) When opening a file for writing, use
8944 line buffering instead of full buffering for better interactive
8945 performance. Suggested by Valerio Aimale
8946 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
8947 names `stdin', `stdout', `stderr'.
8949 * groff-font.c: Comment fixes.
8951 * html.c: New file; base version.
8953 * list.q: (write_all_headers, clean_up, determine_layout,
8954 list_cases) Ignore `special' devices for now. Needs to be fixed
8957 * output.c: (outp_init) Add html driver to list; reverse list
8960 * output.h: (struct outp_class_struct) New members `special',
8961 `submit'; comment fixes. All references changed.
8963 * postscript.c: (ps_init_driver) Make defaults for text_opt,
8964 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
8966 (postopen) Comment fix.
8967 (preclose) Comment fixes, formatting fixes. Change x->file.file
8968 references to more proper f->file.
8970 * som-high.c: (som_submit_table) Special classes use their own
8973 * som.h: Comment fixes.
8975 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
8978 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
8980 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
8982 * aggregate.c: Still working on this.
8984 * command.c: (cmd_table[]) Add AGGREGATE back in.
8985 (split_words) Make '-' a legal word separator as well as ' '.
8987 * main.c: Comment fixes.
8989 * q2c.c: (dump_parser) Don't require the procedure's full name to
8990 be present, in the generated source.
8992 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
8993 multiply specified and let it be default; let MISSING, CRITERIA,
8994 FORMAT be multiply specified.
8995 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
8996 (custom_groups) Fix defaults.
8997 (custom_pairs) Check whether this is a PAIRS subcommand before
8998 attempting to parse. Better garbage collection. Proper storage
9000 [DEBUGGING] (debug_print) New function.
9002 * temporary.c: Comment fixes.
9003 (copy_variable) Don't copy variable name and index.
9004 (save_dictionary) Copy variable name and index by hand.
9006 * vars-atr.c: Comment fixes.
9007 (create_variable) New dictionary argument. All references
9009 (common_init_stuff) New dictionary argument. All references
9011 (init_variable) New dictionary argument. All references changed.
9012 (dup_variable) New function.
9014 * vars-prs.c: (parse_variables) If there are any errors, we always
9015 return 0. Previously, it was possible for some types of errors to
9018 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
9020 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
9023 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
9025 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
9028 * q2c.c: Comment fixes.
9029 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
9031 * t-test.q: (cmd_list) Rename cmd_t_test.
9033 * temporary.c: (new_dictionary) Don't declare as static.
9035 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
9037 * aggregate.c: Changes, still not finished.
9039 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
9041 * q2c.c: Comment fixes. Now its output is internationalized.
9042 (get_token) Fix parsing of escapes within literal strings.
9043 (main) Fix bad #line directives in output.
9045 * t-test.q: Base implementation.
9047 * temporary.c: (new_dictionary) New function.
9048 (restore_dictionary) [__CHECKER__] Change fill character to *
9051 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
9053 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
9055 * aggregate.c: Changes, still not finished.
9057 * descript.q, list.q: Comment fixes.
9059 * q2c.c: Almost completely rewritten.
9061 * t-test.q: New file, not complete.
9063 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
9065 * aggregate.c: Changes, still not finished.
9067 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
9070 * temporary.c: (cancel_temporary) New function.
9072 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
9073 of doing it by hand.
9075 * vfm.c: (close_active_file) After restoring a TEMPORARY
9076 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
9078 (SPLIT_FILE_procfunc) Comment fix.
9080 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
9082 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
9084 * aggregate.c: New file, not finished yet.
9086 * command.c: (cmd_table) Add AGGREGATE.
9088 * common.h: (pgm_state) Move declaration to var.h.
9090 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
9092 (parse_string) Message fix.
9094 * recode.c: Comment fix.
9096 * sfm-read.c: (read_variables) Code esthetic fixes.
9097 (write_header) Default date is `Jan', not `JAN'.
9099 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
9101 * sort.c: (cmd_sort_cases) Farm the work out to new function
9102 parse_sort_variables().
9103 (parse_sort_variables) New function.
9104 (sort_cases) New function. Cancels temporary transformations,
9105 which sorting didn't do previously.
9106 (cmd_sort_cases) Better garbage collection on error. Uses
9108 (write_initial_runs, merge_once) Improved code esthetics.
9109 (sort_stream_read) Reduced to one call to read_output_cases().
9110 (read_output_cases) New function.
9112 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
9113 variable labels to 120 characters.
9115 * var.h: Comment fixes.
9116 (glob var pgm_state) From common.h.
9118 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
9120 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
9121 options. Set *names to NULL on error.
9123 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
9125 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
9127 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
9128 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
9130 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
9132 * vfm.c: (page_to_disk) Added missing local variables.
9134 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
9136 * get.c: Comment fix.
9138 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
9139 source is anything other than a disk stream, not just if it's in a
9140 memory stream. Call page_to_disk() before external sort.
9141 (allocate_cases) Message fix.
9143 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
9145 (page_to_disk) New function.
9147 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
9149 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
9151 * common.h: (macro strerror) Remove. From Alexandre Oliva
9152 <oliva@dcc.unicamp.br>.
9154 * get.c: (dict_delete_run) The number of variables to delete is
9155 not necessarily the number of variables that need to be shifted
9157 (trim_dictionary) Don't set *options to 0. Fix bug that caused
9158 too many variables to be deleted.
9160 * postscript.c: Comment fix.
9162 * q2c.c: Include strerror.c. From Alexandre Oliva
9163 <oliva@dcc.unicamp.br>.
9165 * set.q: #undef ON and OFF. From Alexandre Oliva
9166 <oliva@dcc.unicamp.br>.
9168 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
9169 early, otherwise errors cause a bad free().
9171 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
9172 Oliva <oliva@dcc.unicamp.br>.
9174 * temporary.c: (save_dictionary) Don't allocate memory if
9177 * vfm.c: (memory_stream_write) Message fix.
9179 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
9181 * command.c: (static var cmd_table[]) Define REPEATING DATA
9184 * common.h: Added support for broken systems that are missing
9185 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
9187 * Many source files: Replace syntax error messages via msg() with
9188 call to syntax_error().
9190 * data-list.c: (dump_fixed_table) Add support for dumping table
9191 for REPEATING DATA as well as DATA LIST FIXED.
9192 (cmd_repeating_data) Allows and requires `/' between subcommands.
9193 Does proper thing with allowing rpd.starts_end to stay 0. Allows
9194 CONTINUED specifications to be omitted. Forces CONTINUED to be
9195 specified if ID is. Calculates starts_end, cont_end from logical
9196 record length as reported by fhp. Calls dump_fixed_table() if
9197 requested. Fixed length of record copied by memcpy.
9198 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
9200 (realize_value) Returns sensible value for out-of-range variable
9202 (rpd_parse_record) New argument `ofs'. Fixed confusion between
9203 length of occurrences and length of line. Added warning for
9204 fields that exceed the line length. Fixed infinite loop.
9205 (read_one_set_of_repetitions) Numerous minor changes for more
9206 complete SPSS compliance. Message fixes.
9208 * dfm.c: (dfm_close) If the file being closed is the inline file,
9209 read all the remaining data before closing it.
9210 (dfm_get_record) Don't close the file on lossage, as either it
9211 has been closed already or it doesn't belong to us.
9213 * error.c: (puts_stdout) New function.
9214 (vmsg) Use puts_stdout instead of puts.
9216 * file-handle.q: (fh_record_width) New function.
9218 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
9221 (input_program_source_read) Made an old kluge an approved method.
9223 * lexer.c: (syntax_error) New function.
9225 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
9228 * output.c: (oupt_get_paper_size) Message fix.
9230 * q2c.c: Numerous fixes to formatting of generated code made to
9231 conform to GNU coding standards. Uses syntax_error() in generated
9232 code. Other miscellaneous generated message fixes. Added support
9233 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
9234 RAND_MAX, and/or strerror().
9236 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
9238 * data-in.c: Comment fixes.
9240 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
9241 (find_variable_input_spec) New function.
9242 (cmd_repeating_data) Initializes id_spec.
9243 (rpd_parse_record) Implemented.
9244 (read_one_set_of_repetitions) Returns -3 by default in order to
9245 kluge out some potential bugs.
9247 * data-out.c: Comment fixes.
9249 * file-type.c: (internal_cmd_record_type) Message fix.
9251 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
9252 for handling -3 return value.
9254 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
9256 * data-list.c: Comment fixes.
9257 (struct dls_var_spec) Reordered members.
9258 (read_from_data_list_fixed) Restructured.
9259 (struct repeating_data_trns) Reordered members. Renamed `starts'
9260 as `starts_beg', `ends' as `starts_end'.
9261 (cmd_repeating_data) Calculates length of repeated data if
9262 necessary and possible.
9263 (parse_num_or_var) Don't allow string variables.
9264 (realize_value) New function.
9265 (rpd_msg) New function.
9266 (rpd_parse_record) New function. Currently stubbed out.
9267 (read_one_set_of_repetitions) Implemented.
9269 * inpt-pgm.c: (input_program_source_read) Comment fix.
9271 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
9273 * command.c: (cmd_end_repeat_p) Removed.
9274 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
9275 (parse_cmd_name) Removed.
9277 * data-list.c: Comment fixes.
9278 (data_list_pgm) Removed `eof' member.
9279 (static var first) New var.
9280 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
9281 FILE TYPE file inside FILE TYPE structures.
9282 (append_var_spec) Appends to *first, not dls.spec.
9283 (parse_fixed) Message fixes.
9284 (struct rpd_num_or_var) New.
9285 (struct repeating_data_trns) New.
9286 (static var rpd) New.
9287 (cmd_repeating_data) New function.
9288 (parse_num_or_var) New function.
9289 (parse_repeating_data) New function.
9290 (read_one_set_of_repetitions) New function.
9292 * file-type.c: (cmd_file_type) Message fixes. Always
9293 default_handle to FILE TYPE file handle.
9294 (internal_cmd_record_type) Message fixes.
9296 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
9298 * repeat.c: Comment fix. Disable debugging.
9300 * temporary.c: (restore_dictionary) Sets splits to NULL and
9301 n_splits to 0 before destroying the variables because now doing
9302 this tries to remove split variables.
9304 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
9305 destroying the dictionary.
9306 (clear_variable) Removes a variable from splits after destroying
9309 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
9311 * cmdline.c: (set_compat) Removed.
9312 (pick_compat) Removed.
9313 (parse_command_line) Removed -c option.
9314 (pre_syntax_message) Removed -c option.
9315 (usage) Remove compatibility code.
9317 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
9318 (glob var compat) Removed.
9320 * compute.c: (type_check) Fixed messages about type mismatches.
9322 * data-list.c: (cmd_data_list) Removed compatibility code.
9323 (fixed_parse_compatible) Calls convert_negative_to_dash().
9324 Fixed bug where it only set the variable in fx.spec if it created
9325 the variable itself.
9326 (dump_fmt_list) Spelling fix.
9327 (cut_field) Removed compatibility code.
9329 * dfm.c: (cmd_begin_data) Don't require a command terminator on
9332 * expr-evl.c: (evaluate_expression) Implement LAG.
9334 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
9335 (parse_neg) Calls convert_negative_to_dash().
9336 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
9339 * expr.h: (struct expression_struct) Removed member max_lag.
9341 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
9342 (internal_cmd_record_type) Removed special handling to produce
9343 negative numbers from dash tokens.
9345 * getline.c: (static var DO_REPEAT_level) New var.
9346 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
9347 (handle_line_buffer) Copies the line into getl_buf; doesn't call
9348 copy_with_DO_REPEAT_substitutions().
9349 (getl_read_line) Maintains value of getl_mode. Calls
9350 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
9352 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
9354 * getline.h: (getl_mode) New glob var.
9356 * glob.c: Comment fixes.
9357 (init_glob) Restructured. Sets set_seed.
9358 (init_compat_dependent) Removed. All references removed.
9359 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
9360 (__htonl, __htons) Removed. (What were these for?)
9362 * lexer.c: (static var tbl) Dash set to class CNUM.
9363 (make_hexit) New function from data-out.c.
9364 (get_token_representation) Rewritten.
9365 (convert_negative_to_dash) New function.
9366 (lex_init_compat_dependent) Removed.
9367 (yylex) A dash is parsed as part of a number if it is followed by
9368 a digit. The ASCII representation of a number is copied to
9369 tokstr. String parsing farmed out to parse_string(). Comment
9371 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
9373 (preprocess_line) Line processing depends on interactive/batch
9374 mode, not on compatibility mode. Removed PC+ compatibility code.
9376 * loop.c: (loop_3_trns_proc) Comment fix.
9378 * main.c: Remove dead code.
9379 (main) Remove call to init_compat_dependent().
9381 * misc.c: (convert_fmt_ItoO) Make E format conversion more
9384 * print.c: (parse_string_argument) Calls
9385 convert_negative_to_dash().
9386 (fixed_parse_compatible) Calls convert_negative_to_dash().
9388 * repeat.c: (RPT_* defines) Removed.
9389 (struct rpt_numeric) Removed.
9390 (struct repeat_entry) New member type, changed `replacement' from
9392 (clean_up) Deallocation adapted to new repeat_entry.
9393 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
9394 usage. Creates vars for `type' of 1.
9395 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
9396 (store_numeric) Rewritten, new interface.
9397 (parse_numbers) Rewritten.
9398 (parse_strings) Rewritten.
9399 (find_DO_REPEAT_substitution) New function.
9400 (perform_DO_REPEAT_substitutions) New function.
9401 (copy_with_DO_REPEAT_substitutions) Removed.
9402 (debug_print) Rewritten.
9404 * set.q: Comment fix.
9405 (custom_results) Removed compatibility code.
9406 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
9409 * sysfile-info.c: (cmd_display) Removed compatibility code.
9411 * tokens.h: Comment fixes.
9412 (token types enum) Removed `toktype' typedef name for this int
9413 type. Removed SUBST. Restructured.
9415 * vars-atr.c: (discard_variables) Sets n_lag to 0.
9417 * vars-prs.c: Comment fix.
9419 * vfm.c: Comment fixes.
9420 (glob var n_lag) New var.
9421 (static vars lag_count, lag_head, lag_queue) New vars.
9422 (procedure) Removed argument nlag.
9423 (setup_lag) New function.
9424 (close_active_file) Discards lagging state.
9425 (lag_case) New function.
9426 (lagged_case) New function.
9427 (write_case) Lags a case if lagging.
9429 * weight.c: (cmd_weight) Removed compatibility code.
9431 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
9433 * getline.h: (struct getl_script) New members loop_index, macros.
9435 * getline.c: (getl_add_file) Sets first_line field to NULL.
9436 (getl_add_DO_REPEAT_file) New function.
9437 (handle_line_buffer) When the current line's length is negative,
9438 set the filename and line number. Increment line number after
9439 reading line. Pass the line to
9440 copy_with_DO_REPEAT_substitutions() for processing.
9441 (getl_close_file) Free DO REPEAT lines before freeing the
9442 filename, and just set the filename to NULL when doing this,
9443 because otherwise the filename gets freed twice.
9445 * glob.c: (glob var queuing) Removed. All references removed.
9447 * lexer.c: Comment fixes.
9448 (get_token_representation) New function.
9450 * repeat.c: Comment fixes.
9451 (struct repeat_entry) Replaced type and v union members with a
9453 (append_record) New function.
9454 (internal_cmd_do_repeat) Started reforming it for the new
9455 repeat_entry struct. Properly records filename changes in the
9456 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
9457 strncasecmp() result usage. Uses append_record() to simplify.
9458 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
9461 (copy_with_DO_REPEAT_substitutions) Started coding.
9463 [DEBUGGING] (debug_print_lines) New function.
9465 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
9467 * tokens.h: (macro is_id1, is_idn) New macros.
9469 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
9471 * cmdline.c: (static var pre_syntax_message) Changed `win'
9472 compatibility mode to `wnd'.
9474 * data-list.c: (fixed_parse_spss) Renamed
9475 fixed_parse_compatible().
9477 * glob.c: (init_glob) Excise unused code for
9478 program_invocation_short_name.
9480 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
9483 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
9485 * set.q: `win' compatibility renamed `wnd'.
9487 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
9489 * filename.c: [__WIN32__] Change the included Windows header files
9491 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
9492 second character is absolute.
9493 (dirname) Fix logic error. Don't printf() the results.
9494 (prepend_dir) Don't printf() the results.
9496 * getline.c: (handle_line_buffer) New function.
9497 (getl_read_line) Reads line with handle_line_buffer() when
9499 (getl_close_file) Discard line buffer data.
9501 * getline.h: Comment fixes.
9502 (struct getl_line_list) New struct.
9503 (getl_script_struct) Added line buffer members. These are hooks
9504 for use by DO REPEAT to allow it to insert virtual source code
9507 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
9508 Override Borland C++ stupidity that claims Windows has a console
9511 * repeat.c: This is in the process of being restructured from
9512 using a token-buffering approach to the DO REPEAT facility to
9513 using the more flexible approach of a line-buffering approach in
9514 conjunction with the getline module. Comment fixes.
9515 (struct tok_struct) Removed.
9516 (static vars queue_index, queue_head, queue) Removed.
9517 (static vars line_buf_head, line_buf_tail) New vars.
9518 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
9520 (pull_queue, destroy_queue) Removed.
9521 [DEBUGGING] (debug_print_tokens) Removed.
9523 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
9525 * file-handle.q: (prepend_current_directory) New function.
9526 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
9527 current directory before normalizing filename.
9529 * filename.c: (gnu_getcwd) New function.
9530 (absolute_filename_p) New function.
9531 (search_path) New argument, PREPEND. All references changed to
9532 pass NULL except those explicitly mentioned. Uses
9533 absolute_filename_p(). Prepends PREPEND before trying the
9535 (dirname, prepend_dir) New functions.
9537 * getline.c: (getl_get_current_directory) New function.
9538 (getl_include) Passes getl_get_current_directory() as PREPEND arg
9541 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
9543 * In several source files, the term `script' was replaced with
9544 `syntax file' inside error messages. Usage of the term `script'
9545 in the sense of a syntax file is now deprecated.
9547 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
9550 * dump-sysfile.c: (usage) Update message.
9552 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
9554 * getline.h: (glob var getl_include_path) Declare extern.
9556 * list.q: Define EXTERN as extern before #including somP.h.
9558 * var.h: Remove declaration of `disptype' variable.
9560 * vfm.c: (close_active_file) After switching the data sink to a
9561 data source, set vfm_sink to NULL, because it doesn't exist any
9564 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
9566 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
9567 _matherrl() to ignore all math errors.
9569 * sfm-read.c: (read_value_labels) When reading the labels from
9570 disk, read the little parts separately instead of as a struct;
9571 this avoids alignment problems.
9573 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
9574 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
9575 (write_header) Allocates and initializes elem_type.
9576 (sfm_write_case) Uses elem_type to determine how to handle each
9578 (sfm_close) Frees elem_type.
9580 * sfmP.h: Comment fix.
9581 [__BORLANDC__] Uses #pragma -a to adjust structure member
9584 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
9586 * Makefile.am: (fiasco_SOURCES) Remove display.c.
9588 * common.c: Fix typo.
9590 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
9591 sense of the condition.
9593 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
9594 line-continuation backslash.
9596 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
9598 * frequencies.q: (custom_grouped, add_percentile) Don't use a
9599 non-constant expression as an argument to sizeof.
9601 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
9602 undefine gettext macro because that's a conio function.
9604 * hash.h: (hsh_prime_tab declaration) Remove.
9606 * list.q: (write_fallback_headers) Move `leader' allocation out of
9607 main loop. Change to local_alloc() allocation.
9609 * output.h: Formatting fixes. Put __attribute__ in right place on
9610 function prototypes.
9612 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
9613 incorrect `SECOND_LOWEST_VALUE' references to proper
9614 `second_lowest_value'.
9616 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
9617 value. This way 2 out of 3 of the som files define the vars
9618 extern, the correct way, that actually works under BC++.
9619 (som_set_float) Don't use nonconstant initializers for a struct.
9621 * som-high.c: Add the standard alloca() header.
9622 (replicate_table) Add prototype.
9624 Merged DISPLAY routine.
9625 * sysfile-info.c: (AS_*) New enum series.
9626 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
9628 (cmd_display, display_macros, display_documents,
9629 display_variables) Stolen from defunct display.c.
9630 (describe_variable) New function.
9632 * temporary.c: [0] (display_tree) New debug function.
9633 (copy_variable) Performs shallow copy of value labels instead of
9634 deep copy; i.e., just copys the AVL tree and increments the
9637 * val-labs.c: Comment fixes.
9638 (do_value_labels) Optionally skip leading forward slash.
9639 (get_label) Creates only a single value label instead of many
9640 copies of one, and sets the reference count.
9642 * display.c: Removed.
9644 * dump-sysfile.c: New file, not yet complete.
9646 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
9648 For lots of source files I added more verbose_msg's. These aren't
9649 listed below as they have tested as being benign. In some cases
9650 these replaced debug_printf() calls.
9652 * output.c: (outp_read_devices) Message fix.
9654 * postscript.c: (output_encodings) Message fix. Reports errors on
9656 (postopen) Message fix.
9658 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
9660 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
9662 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
9665 * main.c: Remove <malloc.h> #include.
9667 * mis-val.c: (parse_numeric) Set .f member for each missing[]
9668 instead of trying to just set the missing[] itself, which is a
9671 * sfm-read.c: (read_variables) Same.
9673 * str.h: Add memmem() prototype.
9675 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
9677 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
9679 * Makefile.am: (q2c) Don't include any libraries in the link.
9681 * dfm.c: (force_line_buffer_extension) New macro.
9682 (count_tabs) New function.
9683 (tabs_To_spaces) New function.
9684 (read_record) Calls tabs_to_spaces() on the line being processed.
9686 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
9687 have to be compiled twice (once for CC, once for LOCAL_CC).
9689 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
9691 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
9692 (LDADD) Add @INTLLIBS@.
9693 (q2c) Add LIBS, @INTLLIBS@ to link step.
9695 * inpt-pgm.c: Turn off debugging.
9697 * postscript.c: (postopen) Format fix. local_free() blocks
9698 returned by local_alloc(); don't free() them.
9700 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
9702 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
9705 * data-list.c: (read_from_data_list_fixed) Pass proper value for
9706 LEN arg, not simply the full string length.
9708 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
9709 directories before generic temp file directories.
9711 * vfm.c: Disable debugging.
9713 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
9715 * get.c: Comment fix.
9716 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
9718 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
9720 * expr-prs.c: (debug_print_postfix) Conditionally included on
9721 GLOBAL_DEBUGGING. Removed out_header() reference.
9723 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
9725 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
9727 * ascii.c: Removed obsolete ascii_close_page() prototype.
9729 * command.c: (output_line) Comment fix.
9731 * data-in.c: Formatting fix.
9732 (parse_string_as_format) Now the `fc' argument is used only for
9733 the purpose of error messages; it is not an index into the string
9734 passed. All references changed.
9736 * data-list.c: Comment fix.
9737 (cut_field) Comment fix. Now returns the column number of the
9738 position of the field cut out on success.
9739 (parse_field) Added `column' argument. Puts the column numbers in
9741 (read_from_data_list_free, read_from_data_list_list) Record the
9742 column number returned by cut_field(), pass it to parse_field().
9744 * dfm.c: Comment fix.
9746 * do-ifP.h: Comment fix.
9748 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
9749 the SYSMIS function.
9751 * expr.h, exprP.h: Comment fix.
9753 * glob.c: (init_glob) Only calls setlocale() and family if
9756 * hash.h: Comment fix.
9758 * include.c: Comment fix.
9760 * output.c: Comment fix.
9762 * postscript.c: (ps_line_intersection) Simplified assertion.
9764 * repeat.c: Comment fix.
9766 * vars-atr.c: Comment fix.
9768 * vars-prs.c: Comment fix.
9770 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
9771 behavior with usage of postincrement.
9772 (memory_stream_read) Discards cases as it goes.
9774 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
9776 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
9779 * Most source files: Includes debug-print.h, related comment
9782 * cases.c: (alloc_val) Removed complex allocation code. Merely
9783 increments default_dict.nval and returns the former value.
9784 (envector, devector) Removed references to lv member of struct
9787 * common.h: (macro VME) Replaced complex definition with simple
9790 * data-list.c: (cmd_data_list) Sets vfm_source instead of
9791 read_active_file and cancel_input_pgm.
9792 (read_from_data_list, cancel_data_list) Removed.
9793 (data_list_source_read, data_list_source_destroy_source) New
9795 (glob var data_list_source) New var.
9797 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
9798 (cmd_begin_data) Improved criteria for an input program accessing
9799 the inline file. Still not perfect.
9801 * do-if.c: (do_if_trns_proc) Simplified debug output.
9803 * expr-prs.c: Comment fixes.
9804 [DEBUGGING] (debug_print_postfix) Simplified debug output.
9806 * file-handle.q: (fh_close_handle) Simplified debug output.
9808 * file-type.c: Comment fixes.
9809 (cmd_file_type) Sets vfm_source instead of read_active_file and
9811 (cmd_end_file_type) On failure, discards variables in place of
9812 just canceling the input program.
9813 (read_from_file_type) Renamed file_type_source_read.
9814 (cancel_file_type) Renamed file_type_source_destroy_source.
9815 (glob var file_type_source) New var.
9817 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
9818 (cmd_get) Initializes options to GTSV_NONE before passing to
9819 trim_dictionary(). Removed `lv' reference. Sets vfm_source
9820 instead of read_active_file and cancel_input_pgm.
9821 (cmd_save_internal) Initializes options before passing to
9822 trim_dictionary(). Local var `nval' removed.
9823 (dict_delete_run) Comment fixes.
9824 (trim_dictionary) Comment fixes. Disallows scratch variables if
9825 GTSV_OPT_SAVE set in options.
9826 (read_from_get) Renamed get_source_read.
9827 (cancel_get) Renamed get_source_destroy_source.
9828 (glob var get_source) New var.
9830 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
9831 read_active_file and cancel_input_pgm.
9832 (read_from_input_program) Renamed input_program_source_read.
9833 Simplified debug output.
9834 (cancel_input_program) Renamed
9835 input_program_source_destroy_source.
9836 (glob var input_program_source) New var.
9838 * loop.c: (loop_1_trns_proc) Simplified debug output.
9840 * main.c: (dump_token) Made eof output more explicit.
9842 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
9845 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
9846 code for always-memory or always-disk cases. malloc's case-list
9847 based on vfm_source_info.ncases. Explicit support for
9848 memory_stream via memory_source_cases.
9849 (do_external_sort) Sets vfm_source instead of read_active_file and
9851 (allocate_file_handles) The temporary directory permissions are
9852 set to 0700 instead of 0777.
9853 (allocate_cases) Formatting fixes. Simplified debug output.
9854 (output_record) Compacts the case if necessary before writing it
9856 (close_handle, open_handle_w) Simplified debug output.
9857 (write_initial_runs) Destroys vfm_sink, then sets it to
9858 sort_stream. Writes records to memory based on
9859 vfm_sink_info.case_size.
9860 (write_to_sort_cases) Renamed sort_stream_write().
9861 (merge) Simplified error handling. Simplified debug output.
9863 (read_from_external_sort) Renamed sort_stream_read().
9864 Reads records based on vfm_source_info.case_size.
9865 (sort_stream_write) Writes records to memory based on
9866 vfm_sink_info.case_size.
9867 (sort_stream_mode) New function.
9868 (glob var sort_stream) New variable.
9870 * temporary.c: (cmd_temporary) Simplified debug output.
9871 (copy_variable) Removed references to `lv'.
9873 * title.c: (get_title) Simplified debug output.
9875 * var.h: Comment fixes.
9876 (struct get_proc) Removed member `lv'.
9877 (struct variable) Removed member `lv'. Comment fixes.
9878 (glob vars read_active_file, write_active_file, cancel_input_pgm)
9880 (struct case_stream) New.
9882 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
9883 read_active_file references to use vfm_source.
9884 (init_variable, replace_variable) Removed references to `lv'.
9886 * vfm.c: Comment fixes.
9887 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
9889 (static var queue, qh, qt, n_lag) Removed. All references
9891 (glob var compaction_necessary, compaction_nval, compaction_case,
9892 paging) New variables.
9893 (record_case) Removed.
9894 (procedure) Comment fixes. Calls vfm_source->read() instead of
9897 (prepare_for_writing, arrange_compaction, make_temp_case,
9898 vector_initialization, setup_filter) New function.
9899 (open_active_file) Most of the code moved into the abovementioned
9900 new functions. Now sets temp_dict to &default_dict if there is no
9901 temporary dictionary, for convenience. New debug output.
9902 (close_active_file) Deals with changing the sink to the source.
9903 Calls finish_compaction(). Frees compaction_case. Mostly
9905 (glob vars disk_source_file, disk_sink_file) New vars.
9906 (destroy_active_file, read_from_memory) Removed.
9907 (disk_stream_init, disk_stream_read, disk_stream_write,
9908 disk_stream_mode, disk_stream_destroy_source,
9909 disk_stream_destroy_sink) New functions.
9910 (glob var vfm_disk_stream) New var.
9911 (glob vars memory_source_cases, memory_sink_cases,
9912 memory_sink_iter, memory_sink_max_cases) New vars.
9913 (memory_stream_init, memory_stream_read, memory_stream_write,
9914 memory_stream_mode, memory_stream_destroy_source,
9915 memory_stream_destroy_sink) New functions.
9916 (glob var vfm_memory_stream) New var.
9917 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
9918 named `more_cases'. Simplified debug output. Otherwise mostly
9920 (record_case) Moved into the stream drivers. Removed.
9921 (transform) Removed (was dead code).
9922 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
9923 common case that the splits don't change, we don't need to copy
9924 the case into prev_case again--pointless.
9925 (compact_case) New function.
9926 (finish_compaction) New function.
9928 * vfmP.h: Comment fixes.
9929 (DEV_* enum series) Removed.
9930 (struct storage) Renamed `stream_info'. Removed variant record.
9931 Removed `device' member.
9933 * debug-print.h: New file.
9935 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
9937 * autorecode.c: Turned off debugging.
9939 * data-list.c: (destroy_dls) Closes the associated file handle.
9941 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
9942 parse_variables() options.
9944 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
9946 * display.c: (display_variables) Really fixed null cell bug.
9948 * file-handle.q: (fh_close_handle) Changed debugging message.
9950 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
9951 parse_variables() options.
9953 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
9954 (cmd_list) Fails if no variables specified.
9955 (determine_layout) Writes blank lines manually.
9957 * loop.c: (loop_1_trns_proc) Made debugging code only print
9958 messages if debugging.
9960 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
9961 parse_variables() arguments.
9962 (main) Parses optional parenthesized options to varlist
9963 subcommands into sbc->message.
9965 * sfm-read.c: Format fix.
9967 * var.h: (FV_*) New enum series.
9968 (PV_*) New enum PV_NO_SCRATCH.
9970 * vars-prs.c: (find_var) Removed.
9971 (fill_all_vars) Takes FV_* enum instead of boolean third
9972 argument. Rewritten to deal with scratch as well as system
9974 (parse_variables) Error message on scratch variable if
9977 * vfm.c: (static var virt_begin_func) New var.
9978 (procedure) Sets up virt_begin_func.
9979 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
9980 after dump_splits(). For succeeding groups changes, calls
9981 virt_begin_func() instead of begin_func().
9983 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
9985 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
9988 * dfm.c: Added some debugging messages, disabled by default.
9989 (open_file_r) Fixed error message.
9990 (read_record) On eof on inline_file, instead of calling
9991 fh_close_handle(), simply jump to eof label like a normal file.
9994 * display.c: Thin lines between rows for certain kinds of
9995 listing. Fixed `null cell' bug.
9997 * error.c: (failure) Flush stdout, stderr before failing.
9999 * file-handle.q: (fh_close_handle) Added debugging message.
10001 * frequencies.q: (dump_full) Bottom line extends across entire
10002 table width. Changed title formatting.
10003 (dump_condensed) Changed title formatting.
10004 (dump_statistics) Fixed title formatting.
10006 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
10007 Sets default value of set_format.
10009 * list.q: (cmd_list) Calls blank_line() before determine_layout().
10010 Passes write_all_headers() to procedure() as pre-group func.
10011 (write_all_headers) New function.
10012 (determine_layout) Removed calls to write_header().
10013 Calls blank_line() before and after write_fallback_headers().
10015 * recode.c: (recode_trns_free) Only attempts to free head->map if
10018 * sfm-read.c: (read_variables) Allows `#' at beginning of system
10019 file variable names but gives a warning. Sets `left' based on
10020 first character being/not being `#'. On lossage frees dict->var.
10022 * som-high.c: (som_draw_title) Simplified title formatting.
10024 * vfm.c: (dump_splits) Fixed and changed splits formatting.
10026 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
10028 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
10029 beginning. Frees v_src, v_dest on successful exit. Frees
10030 h_trans[*], h_trans on lossage.
10031 (recode) Frees h_trans[*], h_trans.
10033 * dfm.c: (dfm_close) Formatting change.
10034 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
10035 longer allocates its own in inline_file.
10036 (open_file_r) Passes the local dfm_fhuser_ext to
10037 open_inline_file().
10038 (open_file_w) Message fix.
10039 (read_record) Buffer reallocation strategy changed. Frees
10040 ext->line even in inline_file to prevent leaks.
10041 (dfm_put_record) Fixed bug where `ext' was cached before the file
10042 was opened and thus it would be NULL when the file really was
10044 (cmd_begin_data) Sets up inline_file basics itself, then calls
10045 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
10047 * list.q: (write_line) Formatting fix.
10048 (clean_up) Minor strategy change. Sets proportional font after
10050 (determine_layout) Sets fixed font before writing regular headers,
10051 or after writing fallback headers.
10053 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
10054 and KEEP vars after using them.
10056 * postscript.c: (ps_init_driver) Frees x->family.
10057 (postopen) When loading fonts, free the temporary font name buffer
10059 (ps_text_set_font_by_position) Free temporary font name buffer
10061 (text) Fixed code that calculated `lig' so that `lig' always gets
10062 initialized. Formatting fix.
10064 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
10066 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
10067 cells, not xmalloc(), so that the cells will get destroyed
10070 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
10073 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
10075 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
10078 * dfm.c: Comment fix.
10080 * list.q: Comment fixes. Include somP.h. Removed static vars
10081 table, n_columns, n_rows, part. New struct list_ext. New static
10083 (n_lines_remaining, n_chars_width, write_line) New functions.
10084 (cmd_list, list_cases) Rewritten.
10085 (begin_row, end_row, flush_table) Removed.
10086 (write_header, clean_up, write_varname, write_fallback_headers,
10087 determine_layout) New functions.
10089 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
10091 * output.h: Comment fix.
10093 * postscript.c: Comment fix.
10094 (struct ps_driver_ext) Removed prop_size, fixed_size members;
10095 added font_size. All references changed.
10096 (ps_init_driver) Initializes font_size. Simplified space checking
10098 (static var option_tab[]) Removed prop-size, fixed-size; added
10100 (ps_option) Handles font_size.
10102 * som-high.c: Moved prototypes into somP.h.
10103 (som_init_driver) New function.
10104 (som_submit_table) Moved some code into new function
10106 (build_target) Moved some code into new function
10107 som_internal_eject_page().
10108 (som_eject_page) Uses som_internal_eject_page().
10109 (som_internal_eject_page) New function.
10111 * som-low.c: Moved prototypes into somP.h.
10113 * som.h: Formatting fixes.
10115 * somP.h: (struct som_driver_ext) Removed em_width;
10116 added prop_em_width, fixed_width.
10118 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
10120 * Makefile.am: Added `localedir' definition. Added
10121 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
10123 * ascii.c: (macro draw_line) Fixed capitalization.
10125 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
10126 compute.c, count.c, data-in.c, data-list.c, data-out.c,
10127 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
10128 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
10129 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
10130 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
10131 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
10132 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
10133 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
10134 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
10135 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
10136 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
10137 for internationlization.
10139 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
10141 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
10143 * do-if.c, sort.c, val-labs.c: Comment fixes.
10145 * glob.c: (init_glob) Uncommented, updated i18n support.
10147 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
10148 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
10149 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
10150 the declarations of macros taking arguments a lot nicer.
10152 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
10154 * error.h: Removed CE, CW aliases for SE, SW.
10156 * q2c.c: Removed explicit streq() definition since it's duplicated
10159 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
10160 stats.h, str.h, tokens.h: Made the declarations of macros taking
10161 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
10164 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
10166 * cmdline.c: Comment fixes.
10167 (pick_compat) Changed return type to int. Now, instead of setting
10168 glob var `compat' to the emulation, returns the emulation. All
10169 references changed.
10170 (parse_command_line) Added terminating null to end of
10171 `long_options' array definition.
10172 (pre_syntax_message) Fixes.
10173 (usage) Shows the default emulation in the syntax message by
10174 calling pick_compat().
10176 * getline.c: (getl_add_include_dir) Separates paths with
10177 PATH_DELIMITER, not DIR_SEPARATOR.
10179 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
10180 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
10182 * output.c: (outp_configure_macro) Make earlier definitions for a
10183 particular key override later ones for the same key.
10185 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
10187 * ascii.c: Comment fixes.
10189 * output.c: (outp_get_paper_size)
10190 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
10192 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
10194 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
10195 <errno.h>. GNU libc 2 enforces this!
10197 * command.c: (parse_cmd) Fixed problem with `else' clause being
10198 paired with wrong `if'. Comment fix.
10200 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
10202 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
10203 blp_getline() to getline().
10205 * output.c: (outp_eval_dimension) Changed the fix from last time;
10206 there was no variable `a'.
10208 * q2c.c: (get_line) Fixed boundary condition overrun bug.
10210 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
10212 * output.c: (outp_evaluate_dimension) Fixed handling of negative
10213 numbers having fractional parts. Added case of a fraction without
10214 a whole-number part.
10216 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
10218 * ascii.c: (ascii_text_get_font_position) Removed.
10220 * expr.h, exprP.h: Disabled debugging.
10222 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
10225 * output.h: (struct outp_class_struct) Removed
10226 text_get_font_position method. All references deleted.
10228 * postscript.c: Big change here. Fontmaps were completely
10229 eliminated because of a change in philosophy. Comment fixes.
10230 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
10232 (struct ps_driver_ext) `position', `fontmap', `prop_name',
10233 `fixed_name' members removed. New members `prop_family',
10234 `fixed_family'. `family' member changed to type char *.
10235 (static var ps_fontmaps) Removed.
10237 (ps_init_driver) Removed obsolete references, updated.
10238 Initializes `translate_x', `translate_y', `scale'. Doesn't read
10239 fontmap, of course. Refers to font names through internal_name
10240 rather than subversive means. Frees proper items.
10241 (static var option_tab[]) Removed `fontmap-file' option; renamed
10242 `fixed-font', `prop-font'.
10243 (ps_option) Corresponds to option_tab[].
10244 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
10245 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
10246 hash_family) Removed.
10247 (postopen) Generates font names from family names. Gets
10248 PostScript font name properly. New prologue file comment `!!!'
10250 (ps_open_page) Adds translate_x, translate_y to BP prologue
10251 function; gives SF argument floating-point format.
10252 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
10253 font name. Doesn't change font family.
10254 (ps_text_set_font_by_position) Generates Groff font name from font
10255 family name instead of through table lookup.
10256 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
10257 all references changed. Reduced to simple string assignment.
10258 (ps_get_font_name) Removed.
10259 (ps_get_font_family) Reduced to string return.
10260 (text) Doesn't save `position' since it no longer exists. Ugly
10261 kluge to save font family--fix soon?
10262 (load_font) Removed PostScript name argument.
10264 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
10266 * postscript.c: Comment fix.
10267 (ps_open_page) Puts scale factor in PostScript output.
10269 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
10271 * Makefile.am: Distcleans q2c.
10273 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
10275 * ascii.c: (delineate) Sets text size even if width is zero.
10277 * command.c: Comment fix.
10278 (static var cmd_table[]) Re-enabled EVALUATE command.
10279 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
10280 of comments in script files. Now more liberal on criteria for
10281 performing a state transition--if *anything* happened correctly,
10282 not just if *everything* happened correctly.
10284 * data-out.c: (convert_F) Comment fix. Why in the fsck does
10285 Checker segfault on formatting large numbers and why in the fsck
10286 hadn't I noticed this before?
10288 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
10290 * list.q: (cmd_list) Commented out the actual output routine
10291 because of various problems. Probably will abandon the idea of
10292 using the general `crushed tables' for the LIST procedure.
10294 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
10295 clearing it. Allocates a new var_by_name dictionary before trying
10296 to add members to it.
10298 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
10299 `sib'. Changed type of `node' argument.
10300 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
10301 avl_walk_inorder().
10302 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
10303 [DEBUGGING] Only deletes the variable from var_by_name if that var
10306 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
10308 * Makefile.am: Added include files to SOURCES. Added
10309 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
10310 includes rules for q2c. Added `boast' target.
10312 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
10314 * Makefile.am: Maintainer-clean Makefile.in.
10316 * Makefile.am: Fixed redundant EXTRA_DIST line.
10318 * ascii.c: Comment fixes.
10319 (ascii_line_vert) Fixed overly aggressive range check.
10321 * display.c: Removed dead code.
10323 * list.q: Turn debugging on.
10324 (flush_table) New debug code.
10326 * sfm-read.c: (read_value_labels) malloc's the structure before
10327 trying to assign to its members.
10329 * sfm-write.c: Comment fix.
10331 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
10333 (output_table) No arguments anymore--gets them through `som'
10334 global. New debug code. In crushed tables, now sets `htv' as
10335 well as `hv' to avoid bad confusion later.
10336 (dump_crush_page) New debug code.
10338 * som-low.c: (som_dump_crush_page) New debug code.
10340 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
10342 All source files: Broke long lines into multiple lines.
10344 * ascii.c: (ascii_close_page) Uses host_system var in place of
10345 HOST_SYSTEM constant.
10347 * cmdline.c: (var syntax_message[]) Broke into
10348 pre_syntax_message[] and post_syntax_message[].
10349 (usage) Outputs both parts, separated by driver list.
10351 * error.h: Fixed broken formatting.
10353 * expr-opt.c: (str_search, str_rsearch) New functions.
10355 * misc.c: (blp_getdelim) Removed. All references changed to
10357 (str_search, str_rsearch) Removed.
10358 (memrmem) New function.
10360 * misc.h: (blp_getline) Removed. All reference changed to
10363 * stat.h: New file.
10365 * filename.c: Includes "stat.h", not <sys/stat.h>.
10366 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
10368 * output.c: (outp_list_classes) Changed output formatting.
10370 * sfm-write.c: (write_header) Uses host_system var instead of
10371 HOST_SYSTEM constant.
10372 (write_rec_7_34) Extracts version numbers from the version string.
10375 * sort.c: Includes "stat.h", not <sys/stat.h>.
10377 * str.c: (strcasecmp) Removed.
10379 * title.c: (cmd_document) Uses host_system var instead of
10380 HOST_SYSTEM constant.
10382 * version.c: Generated on-the-fly by the Makefile instead of being
10385 * str.h: Comment fixes. Doesn't substitute for missing memmove or
10387 [!HAVE_STRNCASECMP] Declares strncasecmp().
10389 * version.h: Removed stray character. Comment fixes.
10390 (vars host_system, build_system) New vars.
10392 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
10394 * Most source files: Changed formatting of copyright notice; fixed
10395 FSF address; reformatted to better conform to GNU standards;
10396 comment fixes. Added markups to prevent GNU indent from messing
10397 up my beautiful formatting :-).
10399 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
10400 that GNU indent markups can be passed through without problems.
10402 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
10404 * get.c: Turned off debugging.
10406 * glob.c: (init_glob) Turned on save-file compression by default.
10408 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
10409 compression than was possible in save files.
10411 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
10413 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
10415 * frequencies.q: Removed Fiasco extensions. Updated calculation
10416 algorithms. Polished output format.
10417 (struct frq_info_struct) Removed members `max_degree', `min_n',
10418 all references removed.
10419 (macro frq_extensions) Removed.
10420 (static vars min_n, max_degree) Removed, all references removed.
10421 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
10422 calculate `min_n', `max_degree'.
10423 (postcalc) Passes new arg to dump_statistics().
10424 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
10426 (dump_condensed) Adds variable name title.
10427 (sum_freqs) Removed.
10428 (calc_stats) Updated calculation algorithm.
10429 (dump_statistics) Removed warning for too-few observations.
10430 Changed table formatting. Adds variable name title if passed new
10433 * output.h: Comment fix.
10435 * recode.c, sample.c, sort.c: Disabled debug code.
10437 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
10438 Improved debug code.
10440 * var.h: (enum series frq_*) Removed Fiasco extensions.
10442 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
10444 * command.c: Added PROCESS IF to command table.
10446 * Lots & lots of places, removed checks for NULLs preceding calls
10447 to free_expression(), which itself checks.
10449 * descript.q: Removed Fiasco extensions. Removed optimizations
10450 for non-weighted active files. Implemented some options.
10451 Finished polishing output format. Comment fixes. Merged
10453 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
10454 max_degree, min_n) Removed.
10455 (macro dsc_extensions) Removed.
10456 (struct dsc_info_struct) Removed `min_n' member, all references
10458 (internal_cmd_descriptives) Removed calculation of min_n,
10459 max_degree. Only deals with one `calc' routine instead of two
10461 (precalc) Eliminated redundancy. Updated for changes to
10462 descriptives_proc structure.
10463 (calc) Moved here from `descript.g'. Rewritten to calculate
10464 statistics via `moments about the mean' rather than by summing,
10465 summing squares, summing cubes, and so on.
10466 (postcalc) Rewritten for new-style statistical calculation.
10467 (display) Removed support for displaying variables across rows.
10468 No longer crushes the descriptives table. Removed ancient code.
10469 Added display of N, by variable and listwise.
10471 * descript.g: Removed; merged into `descript.q'.
10473 * expr-evl.c: (evaluate_expression) Now returns a double. For
10474 numeric results, it returns the result as well as storing it in
10475 the passed `value' structure if non-NULL. For string results it
10476 just returns 0.0 and it must be passed non-NULL. Many references
10477 to this function were optimized by use of this change, especially
10478 but not exclusively in `compute.c'.
10480 * frequencies.g: Comment fix.
10482 * glob.c: (glob var process_if_expr) New global var.
10484 * postscript.c: (static var option_tab[]) Corrected entry for
10486 (postopen) Sets x->size to x->prop_size.
10487 (ps_text_set_font_by_name) Sets font size as well as typeface for
10488 PROP and FIXED fonts.
10490 * sel-if.c: (cmd_process_if) New function.
10492 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
10493 (sfm_write_dictionary) Sets `n_cases' to 0.
10494 (sfm_write_case) Increments `n_cases'.
10495 (sfm_close) Attempts to seek the system file back to the header
10496 and write the number of cases in its proper slot.
10498 * som-frnt.c: (som_insert_table) Masks off expansion options since
10499 only SOPT_X_NORM seems to work sensibly.
10501 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
10502 with a `fixed' value of 2.
10504 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
10506 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
10507 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
10509 * var.h: (enum series dsc_*) Removed Fiasco extensions.
10510 (struct descriptives_proc) Removed `miss_noweight'; new members
10511 `X_bar', `M2', `M3', `M4', `min', `max'.
10513 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
10515 * vfm.c: (close_active_file) Cancels PROCESS IF.
10516 (write_case) Doesn't process cases unselected by PROCESS IF.
10518 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
10520 * glob.c: (glob var err) Removed.
10522 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
10523 doesn't have to take into account number of value labels since
10524 they're in a subtable anyway. Also, doesn't display more than 10
10525 value labels since we can't yet break pages in subtables.
10527 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
10529 * som-frnt.c: (som_change_table_size) Simple change for elegance
10530 that shouldn't change behavior.
10531 (som_set_value) Comment fix.
10533 * som-high.c: (som_submit_table) Message fix.
10535 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
10537 * command.c: Added SYSFILE INFO to command table.
10539 * file-handle.q: (fh_handle_filename) New function.
10541 * get.c: (save_trns_proc) Fixed a bug in padding of output data
10544 * main.c: (parse) New return value for command functions, -3.
10546 * misc.h: Comment fix.
10548 * output.h: Comment fixes.
10549 (macro COMPONENTS) Removed.
10551 * postscript.c: (write_text) Modified literal_chars[] so that `('
10552 and ')' are not written to the output in strings as literals.
10554 * sfm-read.c: (sfm_read_dictionary) New argument.
10555 (read_header) New argument. Sets the information structure's
10556 values from the header information.
10557 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
10558 bizarre Checker problem, I guess.
10559 (read_variables) Proper cleanup on lossage.
10561 * sfm.h: (struct sfm_read_info) New struct for use by
10562 sfm_read_dictionary().
10564 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
10565 currently used just for tables that can be dynamically resized and
10566 thus have to be allocated with arena_malloc() instead of
10567 arena_alloc(). All references changed.
10568 (som_change_table_size) New function.
10569 (som_insert_table) Bugfix: now inserts `cell', not `c'!
10571 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
10572 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
10575 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
10577 (draw_intersection) Now takes an argument specifying the table in
10578 question. All references changed.
10579 (draw_table_cell) New function.
10580 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
10581 (som_get_table_size) Many nice new explanatory comments.
10582 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
10584 * som.h: New enum series SOM_CREATE_* for use as create flags with
10585 som_create_table().
10587 * str.h: Moved a comment here from TODO.
10589 * sysfile-info.c: New file. Reference implementation.
10591 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
10593 * command.c: Added RENAME VARIABLES to table of commands.
10595 * data-in.c: (dls_error) Sets `cust_field'.
10596 (parse_N) Message fix.
10597 (parse_day_count) New function.
10598 (to_roman) Never outputs VX as a `short form' of V.
10599 (parse_month) Fixed parsing of Roman numerals.
10600 (parse_trailer) Message fix.
10601 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
10602 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
10603 the date is invalid.
10604 (parse_SDATE) Fixed swapped day, year.
10605 (parse_JDATE) Fixed bug for dates in 1582.
10606 (parse_DTIME) Allows days not between 1 and 31.
10607 (parse_numeric) Makes local copy of f.type for easier usage.
10610 * data-out.c: (convert_F) When outputting as scientific, properly
10611 sets f.type as fp->type.
10612 (insert_commas) Fixed operator precedence problem with setting of
10613 nitems. Changed strcpy to memcpy (no null terminator).
10614 (convert_date) Fixed FMT_JDATE: added 1900 to year.
10615 (convert_CCx) Essentially rewritten, but now it works.
10617 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
10618 feature of Fiasco).
10619 (display_documents) Implemented.
10621 * error.c: (glob var cust_field) New var.
10622 (vmsg) Displays cust_field as part of message classes DE and DW.
10624 * formats.c: (debug_print) Fixed to compile under updated
10627 * get.c: (cmd_get, cmd_save_internal) Close file handle on
10630 * misc.c: (parse_format_specifier) Formatting fix.
10632 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
10633 `n_rename' for clarity.
10634 (cmd_modify_vars) Initializes `forward' and `positional' at
10635 appropriate times. Frees lists of vars to rename on failure.
10636 Comment fix. Frees memory on success.
10637 (rearrange_dict) Simplified `for' loop condition.
10639 * rename-vars.c: New file (reference implementation).
10641 * set.q: (internal_cmd_set) Fixed `emu' test condition.
10643 * sfm-read.c: (read_header) File label is created only if file
10644 label in file is not blank.
10645 (read_variables) Initializes `dict' local variable.
10646 (read_documents) Proper behavior on lossage.
10648 * sfm-write.c: (write_header) Doesn't blank out the file label
10649 (why was this here to begin with?!)
10651 * temporary.c: (save_dictionary) File label is copied only if
10652 non-NULL. Doesn't try to xstrdup() dictionary documents.
10653 Adapted so as to not irritate Checker.
10654 (free_dictionary) Only destroys var_by_name if non-NULL.
10656 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
10657 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
10658 lines to the document, indents the document. Also, it works now.
10659 (add_document_line) New function.
10661 * var.h: (struct dictionary) Reordering.
10663 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
10664 bits if it was allocated to begin with.
10666 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
10668 * command.c: Added MODIFY VARS to list of commands.
10670 * configure.in: Updated custom macros for autoconf 2.12. Removed
10671 mmap reference; fixed termcap library reference.
10673 * display.c: (display_variables) Fixed a few bugs although it's
10674 still not well written.
10676 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
10677 (induce_segfault) Calls chkr_disp_call_chain() instead of
10678 inducing an actual SIGSEGV.
10680 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
10681 str_search() and str_rsearch(). Fixed tests for matches on
10682 OP_INDEX and OP_RINDEX.
10684 * filename.c: (good_getcwd) Removed as the new libc for Checker
10685 doesn't contain this bug, apparently.
10687 * misc.c: (str_search, str_rsearch) Changed order of arguments for
10688 consistency with GNU memmem.
10689 (blp_getdelim) Changed `len' from `int' to `size_t'.
10691 * modify-vars.c: Reference implementation.
10693 * som-frnt.c: (zero_length) New global var.
10694 (som_create_table) Message fix.
10696 * som.h: Added gcc attributions to som_set_text(),
10697 som_output_text() prototypes. blank_line() refers to
10698 zero_length[] instead of a literal null string to suppress gcc
10701 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
10702 (allocate_cases) Decrements x_max so the last element of x[] can
10703 be used by the algorithm.
10705 * var.h: Changed minor details of `variable' declaration.
10706 (struct modify_vars_proc) New struct.
10707 (struct variable) Added field p.mfv.
10709 * vars-atr.c: Comment fix.
10711 * vars-prs.c: (fill_all_vars) More optimal implementation.
10713 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
10714 character, which it shouldn't have to do but printf() seems to
10715 read the null byte even though I supply a maximum length...
10717 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
10719 * command.c: Removed command alias X for QUIT.
10720 (parse_cmd) Fixed comment parsing.
10722 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
10724 (read_record) Fixed references to len, size.
10725 (dfm_get_record) Restructured.
10727 * file-handle.h: (struct file_handle) Field `lrecl' now of type
10730 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
10733 * modify-vars.c: New file. Not complete.
10735 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
10738 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
10739 problems caused by int/size_t differences.
10741 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
10744 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
10745 being compared were of equal length.
10747 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
10749 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
10751 * lexer.c: (get_dotted_rest_of_line) New function.
10753 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
10756 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
10757 type 6 records. Frees the dictionary properly.
10758 (read_header) Initializes the dictionary instead of letting
10759 read_variables() do it. Sets the dictionary file label from the
10761 (read_documents) New function.
10763 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
10764 write type 6 record if appropriate.
10765 (write_header) Writes file label from dictionary.
10766 (write_documents) New function.
10768 * temporary.c: (save_dictionary, restore_dictionary,
10769 free_dictionary) Properly handle new fields in dictionary struct.
10771 * title.c: (get_title) Returns after failure().
10772 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
10773 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
10775 * var.h: (struct dictionary) New fields `label', `n_documents',
10778 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
10780 * command.c: Added FILTER to list of commands.
10782 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
10785 * get.c: (cmd_save_internal) Removed weighting code since it's now
10786 handled by sfm-write.c. Properly commented out debug code.
10788 * glob.c: (glob var weighting) Removed.
10790 * sel-if.c: Comment fixes.
10791 (cmd_filter) New function.
10793 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
10794 (sfm_read_dictionary) Sets weighting variable direct in the
10795 created dictionary now. (Apparently we previously didn't support
10797 (read_header) Sets weight_index field in sfm_fhuser_ext from
10798 header read from disk.
10800 * sfm-write.c: (sfm_write_dictionary) Comment fix.
10801 (write_header) Now sets the weighting in the header from the
10802 passed primary dictionary instead of from the sfm_write_info.
10804 * sfm.h: (struct sfm_write_info) Removed field `weight'.
10806 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
10807 broke on boundary conditions.
10809 * var.h: (struct dictionary) New fields `weight_var',
10810 `weight_index', and `filter_var'.
10811 (glob var weighting) Removed. This is now part of struct
10812 dictionary. All references changed; the less mechanical changes
10813 are described above.
10815 * vars-atr.c: (find_dict_variable) New function.
10817 * vfm.c: (static var filter_index) New variable.
10818 (open_active_file) Initializes filter_index from default_dict.
10819 (write_case) Calls proc_func() only if the filter variable is
10820 nonzero; this implements FILTER behavior.
10822 * weight.c: (static var weight_varname) Removed.
10823 (cmd_weight) Modified default_dict instead of glob vars.
10824 (update_weighting) Changed the signature to modify a dictionary
10825 instead of glob vars. Now returns the weighting variable.
10826 (get_weighting_variable) Removed; its function is absorbed by
10827 update_weighting().
10828 (stop_weighting) Operates on a dictionary now.
10830 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
10832 * sort.c: Removed debugging info from messages.
10833 (do_external_sort) Cleans up after itself by deleting the
10834 temporary directory on failure. (On success it is deleted by the
10836 (allocate_cases) Removed debug code. Added clean up code.
10837 (output_record) Removed debug code.
10838 (merge) Added code to close all the input files that are currently
10839 open. This is a likely location for bugs, because I'm not sure
10840 about boundary conditions. Removed an unnecesary heap_delete().
10841 (merge_once) Removed input file "optimization" that in fact
10842 screwed up the rest of the code. Message and comment fixes.
10844 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
10846 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
10848 * heap.c: (heap_delete) New argument.
10850 * sort.c: Finished implementation of external sort.
10852 * vfm.c: (read_from_disk) Returns after a disk error.
10854 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
10856 * sort.c: (static var state) Removed.
10857 (static vars max_handles, tmp_basename, tmp_extname,
10858 huffman_queue) New variables.
10859 (do_external_sort) Moved most code to new functions.
10860 Creates huffman_queue.
10861 (allocate_file_handles, allocate_cases) New functions.
10862 (static vars run_no, run_length, file_index, case_count) New
10864 (output_record) Returns success. Now really writes to the output
10866 (begin_run, end_run) New functions.
10867 (write_initial_runs) Returns success. Initializes run_no to -1.
10868 Calls begin_run(), end_run() at appropriate times. Outputs debug
10870 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
10872 (merge) New function.
10874 * heap.c, heap.h: New files. Hopefully in near-final form.
10876 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
10878 * glob.c: Added write_active_file to global vars.
10880 * sort.c: Several new miscellaneous static variables.
10881 (cmd_sort_cases) Big comment fix.
10882 (perform_case_2) Renamed `do_external_sort' and completely
10884 (case_2_proc_func) Removed.
10885 (output_record, write_initial_runs, write_to_sort_cases,
10886 compare_record) New functions.
10888 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
10890 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
10892 * sort.c: (perform_case_2) Changed the method for allocation of
10893 lots of memory--now allocates one case at a time in hopes that
10894 more cases can be allocated with heavily fragmented memory.
10896 * var.h: (write_active_file) New global var.
10898 * vfm.c: (procedure, close_active_file, write_case,
10899 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
10900 arguments to procedure() to be NULL. All references to
10901 procedure() that made use of dummy functions were changed to NULL
10903 (open_active_file) If write_active_file is non-NULL, the output
10904 device becomes DEV_PGM (a new enum).
10905 (close_active_file) Sets write_active_file to NULL.
10906 (read_from_memory) Comment fix.
10907 (record_case) Calls write_active_file() when the output device is
10910 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
10912 * sort.c: New file.
10914 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
10915 Fixed checking for duplicate varnames.
10916 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
10918 (autorecode_trns_free) Destroys hash tables for each recoding
10920 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
10922 * command.c: Added SORT CASES to cmd_table.
10923 (null_func, null_int_func) Prototyped.
10925 * descript.g: (calc_weight, calc_noweight) Computes own case
10928 * frequencies.q: (dump_statistics) Fixed problem with
10929 too-few-cases warning message.
10931 * get.c: (cmd_save_internal) Handles weighting properly.
10933 * hash.c: (hsh_dump) Output format changed.
10934 (force_hsh_insert) Actually works now, prototype changed.
10936 * list.q: (static var case_num) New variable.
10937 (cmd_list) Initializes case_num.
10938 (list_cases) Increments case_num.
10940 * var.h: Added definitions for SORT CASES. Comment fixes.
10942 * vfm.c: Some definitions moved to new file vfmP.h. Comment
10943 fixes. `active' renamed vfm_active, `rep' renamed
10944 vfm_replacement, all references changed.
10945 (procedure) The procfunc no longer receives a case number. All
10946 references changed.
10947 (write_case) Subtle reordering.
10948 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
10951 * weight.c: (get_weighting_variable) New function.
10953 * vfmP.h: New file with definitions from vfm.c.
10955 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
10957 * command.c: (FILE_TYPE_okay) Commented out some tests because
10958 they're clumsy and not yet needed.
10960 * var.h: Most *_trns structures moved to their respective source
10961 files. Some were moved into a new file, do-ifP.h. Comment fixes.
10962 (union any_trns) Changed to a typedef for trns_header.
10963 (struct input_program_pgm) Removed.
10965 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
10966 was allocated in the first place.
10968 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
10970 * autorecode.c: New file.
10972 * command.c: Added AUTORECODE to command table; re-enabled SET.
10974 * data-out.c: (convert_F) Handles infinities and NaNs properly.
10976 * error.c: (vmsg) Comment fixes.
10978 * hash.c: Comment fix.
10979 (hashpjw_d) New function.
10980 (hashpjw) Reimplemented as call to more general function
10982 (internal_comparison_fn) Initializes pointers properly.
10983 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
10984 (force_hsh_insert, force_hsh_find) New debugging wrapper
10987 * main.c: (main) Message fix.
10989 * output.c: (outp_read_devices) Message fix.
10991 * set.q: Comment fixes.
10992 (custom_results) Implemented Wnd/X form of subcommand.
10993 (set_routing) New function.
10994 (internal_cmd_set) Implemented ERRORS, MESSAGES.
10996 * settings.h: (SET_ROUTE_*) New enum series.
10997 (set_results) Renamed set_results_file, all references changed.
10998 (set_messages) Removed.
10999 (glob vars set_errors, set_messages, set_results) New vars.
11001 * title.c: (get_title) Remembers to xstrdup() the result of
11002 get_rest_of_line().
11004 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
11006 (union any_trns) New element `arc'.
11008 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
11010 * command.c: (output_line) Removed references to set_screen.
11012 * error.c: (static var terminating) New var.
11013 (hcf) Sets terminating to 1.
11014 (vmsg) If terminating is nonzero, does not attempt to call hcf().
11015 This prevents an infinite loop if an error occurs within hcf().
11017 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
11018 statement circumlocution with `case 42000' trick.
11019 (evaluate_expression) New support for OP_STR_MIS.
11021 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
11022 statement circumlocution with `case 42000' trick.
11023 (dump_node) Handles OP_STR_MIS.
11025 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
11026 variables exceptions.
11027 (parse_function) Message fix.
11028 (ops[]) Added OP_STR_MIS.
11030 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
11032 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
11034 * glob.c: Removed set_scrnfile glob var.
11035 (init_glob) set_errorbreak set to 0 by default.
11037 * groff-font.c: Changed included files.
11038 (groff_read_font) Initializes font_arena local var correctly.
11039 (default_font) New function.
11041 * output.c: Comment fixes.
11042 (glob var disabled_devices) New variable.
11043 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
11045 [GLOBAL_DEBUGGING] (reentrancy) New function.
11046 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
11047 outp_iterate_enabled_drivers) Calls to reentrancy().
11048 (destroy_list) New function.
11049 (outp_done) Moved code to destroy_list().
11050 (parse_options) Parses `listing', `screen', `printer' options
11052 (configure_driver) Sets new `device' member of driver.
11053 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
11055 * output.h: Comment fixes. New enum series OUTP_DEV_*.
11056 (struct outp_driver_struct) New member `device'.
11058 * postscript.c: (find_encoding_file) Doesn't display its own error
11060 (default_encoding) New function.
11061 (switch_font) Calls default_encoding() if no encoding can be
11063 (text) Makes up a character metric if none exists for the desired
11065 (load_font) Properly copies a fallback filename. Calls
11066 default_font() for a font if none at all are known.
11068 * set.q: Comment fixes. Removed OUTPUT subcommand.
11069 (custom_listing) Calls outp_enable_device() to enable/disable
11071 (turn_screen_on) Removed.
11072 (internal_cmd_set) Calls outp_enable_device() to enable/disable
11073 screen, printer devices.
11075 * settings.h: Comment fixes.
11076 (glob vars set_output, set_printer, set_screen, set_scrnfile)
11079 * som-high.c: (som_submit_table, som_eject_page) Use
11080 outp_iterate_enabled_drivers() instead of iterating
11081 outp_driver_list directly.
11083 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
11085 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
11086 (parse_string_as_format) Handles new formats.
11087 (parse_numeric) Now handles DOT and PCT formats.
11089 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
11091 (convert_date) Handle EDATE and SDATE formats.
11092 (convert_CCx) Now if there's not room for the currency characters,
11093 converts it as F format if it's positive instead of giving up
11094 quickly. Also fixed save-and-restore bug with decimal point
11096 (convert_format_to_string) Handles new formats.
11098 * misc.c: (formats[]) Added new formats.
11099 (convert_fmt_ItoO) Supports new formats.
11101 * sfm-read.c: (parse_format_spec) Supports new formats. Better
11102 data checking. New argument, all references changed.
11104 * sfm-write.c: (write_format_spec) Supports new formats.
11106 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
11109 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
11111 * cmdline.c: Comment fixes.
11112 (parse_command_line) Changed return type to void.
11114 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
11116 (parse_numeric) Handles international numbers (comma as decimal
11117 point). Some reformatting.
11119 * data-list.c: (parse_free) Default output format is now
11120 set_format instead of hard-coded F8.2.
11121 (read_from_data_list_list) Emits error message on undefined data
11122 only if set_undefined is nonzero.
11124 * data-out.c: (convert_E) Changes decimal point from period to
11125 comma if appropriate. Restructured. Better comments.
11126 (convert_F) Changes decimal point from period to comma if
11128 (insert_commas) Major bug with handling of negative values fixed.
11129 Also, inserts periods instead of commas if appropriate.
11130 (convert_CCx) New function.
11131 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
11132 (num_to_string) Changed `.' to set_decimal.
11134 * dfm.c: Comment fixes.
11135 (dfm_close) Frees ext->line even in inline_file.
11136 (open_inline_file) New function.
11137 (open_file_r) When opening the inline file: now properly
11138 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
11140 (read_record) Calls fh_close_handle() instead of dfm_close() to
11141 close the inline file. Makes a copy of the line getl_buf to avoid
11142 interlock problems.
11143 (dfm_get_record) Restructured. Now checks the return value of
11145 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
11146 checking for use of inline file. No longer tries to close inline
11149 * error.c: (glob var error_already_flagged) New var.
11150 (vmsg) Message change. Now checks max number of errors/warnings,
11153 * file-handle.q: (fh_handle_name) Now allows closing of
11155 (fh_init_files) Reformatted.
11157 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
11159 * getline.c: (getl_include) Fixed bug that popped up when called
11160 when file queue was empty.
11161 (read_console) Resets error_count, warning_count,
11162 error_already_flagged to zero.
11164 * glob.c: Many changes to update list of variables.
11165 (init_compat_dependent) Now this function is called whenever
11166 `compat' changes. It now sets set_seed only if it hasn't
11167 previously been referenced. It now calls
11168 lex_init_compat_dependent().
11170 * include.c: (cmd_include_at) Frees temporary buffer instead of
11172 (cmd_include) Doesn't make copy of include file name.
11174 * lexer.c: Comment fixes.
11175 (init_lex) Moved some code into new function
11176 lex_init_compat_dependent().
11177 (lex_init_compat_dependent) New function.
11178 (hex_val) Simplified.
11179 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
11181 * main.c: Comment fixes.
11182 (main) Reformatted.
11184 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
11185 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
11186 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
11187 (setup_randomize) Sets set_seed_used.
11189 * set.q: Comment fixes.
11190 (custom_results) Conditionalizes on `compat'.
11191 (custom_log) Calls custom_journal().
11192 (set_ccx) New function.
11193 (cmd_set) Calls init_compat_dependent() when `compat' changes.
11194 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
11195 when set_decimal changes. Range-checks values for MITERATE,
11196 MNEST. Message fixes.
11198 * settings.h: Comment fixes.
11199 (struct set_cust_currency) New struct.
11200 (set_cc[], set_grouping, set_seed_used) New global vars.
11202 * var.h: (FMT_CCA...FMT_CCE) New output formats.
11203 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
11205 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
11207 * glob.c: Revised variables to correspond to settings.h.
11208 (init_glob) Initializes variables from settings.h properly.
11210 * set.q: Began long-overdue major revision to correspond to new
11211 philosophy. Most code changed.
11213 * settings.h: Mostly changed; reorganized, reordered, large new
11216 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
11218 * get.c: (cmd_save_internal) No longer forces compression off.
11220 * sfm-read.c: (read_compressed_data) If eof is reached when
11221 reading a new instruction octet, only signal error if we're in the
11224 * sfm-write.c: (COMPRESSION_BIAS) New #define.
11225 (struct sfm_fhuser_ext) New member `end'.
11226 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
11227 (ensure_buf_space) New function.
11228 (sfm_write_case) Reimplemented in order to support compression.
11229 (sfm_close) Writes out the remaining contents of the compression
11232 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
11234 * command.c: Defined SAVE and XSAVE commands in command table.
11236 * common.h: second_lowest_value is of type flt64, not double.
11238 * file-handle.h: Comment fix.
11240 * get.c: Comment fixes.
11241 (static var `trns') New.
11242 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
11243 cmd_save_internal, cmd_save, cmd_xsave) New functions.
11244 (dict_delete_run) Clears the variables and frees them now.
11245 (trim_dictionary) Sets default for compression.
11246 On KEEP subcommand, frees deleted variables as well as clearing
11247 them. Finally got the sense of the test for deleting all
11249 [DEBUGGING] (dump_dict_variables) Message fix.
11251 * glob.c: (init_glob) set_compression set to 1 by default.
11253 * list.q: Properly #includes config.h.
11255 * misc.h: New macro REM_RND_UP.
11257 * settings.h: Comment fix.
11259 * sfm-read.c: (structs sysfile_header, sysfile_format,
11260 sysfile_variable; inline function bswap_int32) Moved to new file
11262 (corrupt_msg) [__CHECKER__] No longer induces segfault.
11263 (sfm_read_dictionary) Fixed bug caused by failing to initialize
11265 (read_machine_flt64_info) Fixed some problems caused by confusion
11266 between flt64 and double types.
11267 (read_header) Message fix.
11268 (read_variables) Fixed set of cases in which we byte-swap sv.print
11269 and sv.write. Fixed confusion of flt64 and double.
11271 * sfm.h: (struct sfm_write_info) New.
11273 * som-high.c: (som_draw_title) Properly frees `s'.
11275 * temporary.c: (save_dictionary) Comment fix.
11277 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
11278 (struct trns_header) Formatting fix.
11279 (struct save_trns) New.
11281 * vars-atr.c: (discard_variables) Comment fix.
11283 * sfm-write.c: New file, baseline release.
11285 * sfmP.h: New file, baseline release.
11287 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
11289 * cmdline.c: (parse_command_line) `--version' output updated.
11290 (glob var syntax_message[]) Added my e-mail address.
11292 * file-handle.q, lexer.c, vfm.c: Changed many instances of
11293 `illegal' to `invalid'.
11295 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
11296 uncompression buffer.
11297 (sfm_close) Frees decompression buffer.
11298 (sfm_read_dictionary) Initializes decompression buffer.
11299 (buffer_input, read_compressed_data) New functions.
11300 (sfm_read_case) Restructured; now calls read_compressed_data() to
11301 handle compressed system file data.
11303 * var.h: Comment fix.
11305 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
11307 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
11310 * get.c: New comments. New static var `get_file'.
11311 (cmd_get) Now fully implemented. Calls discard_variables();
11312 initializes fv and lv for all variables; new debug code; sets
11313 up the dictionary; sets up the input program.
11314 (read_from_get, cancel_get) New functions.
11316 * sfm-read.c: Comment fixes.
11317 (sfm_close) New static function.
11318 (sfm_read_dictionary) Properly sets up the class of the
11319 file_handle. No longer cares what size the data is in records of
11320 type 7. Also, on failure, properly cleans up the file_handle and
11321 free()s some stuff.
11322 (read_variables) No longer thinks it knows `nval' of the
11323 dictionary. Now sets p.get.fv, etc., instead of speculatively
11325 (read_value_labels) Fixed off-by-one error in indexing of
11327 (sfm_read_case) New function.
11328 (sfm_r_class) New static var.
11330 * var.h: (get_proc) New struct.
11331 (struct variable) New member p.get.
11333 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
11335 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
11336 the manual's meaning.
11337 (rename_variables) New function.
11338 (trim_variables) Doesn't try to parse MAP any more. Removed debug
11339 code. Now properly reorders the dictionary on the KEEP keyword.
11341 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
11342 garbage collection.
11344 * vars-atr.c: (clear_variable) New argument `dictionary *'.
11345 (rename_variable) New function.
11346 (free_val_lab) Reformatted.
11348 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
11350 * var.h: Reindented entire file. Comment fixes.
11351 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
11353 (glob var default_dict) New.
11354 (struct indirect_dictionary) Removed.
11356 * Many other source files were changed to add `default_dict.'
11357 before all references to the dictionary of the active file.
11359 * vars-atr.c: (make_indirect_dictionary) Removed.
11361 * glob.c: Reindented all variable declarations. Updated for
11362 changed var.h. Comment fixes.
11364 * temporary.c: (restore_dictionary, save_dictionary) Simplified
11365 because now we can mainly copy dictionary structs.
11367 * vars-prs.c: (is_dict_varname, parse_dict_variable,
11368 parse_variables) Takes dictionary instead of indirect_dictionary
11370 (parse_variables) Instead of calling make_indirect_dictionary,
11371 just sets DICT to &default_dict if DICT is NULL. Of course, lots
11372 of `*dict.' references had to be changed to `dict->'. Removed
11375 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
11377 * get.c: Added GTSV_OPT_* series of enums.
11378 (trim_dictionary, dict_delete_run) New functions.
11379 [DEBUGGING] (dump_dict_variables) New function.
11380 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
11381 [DEBUGGING] Calls dump_dict_variables() to display results.
11383 * glob.c: (cmp_variable) Now a public function declared in var.h.
11385 * sfm-read.c: Turned off debug code. Comment fixes.
11386 (read_machine_int32_info, read_machine_flt64_info) New functions
11387 to parse type 7 records.
11388 (sfm_read_dictionary) Properly byteswaps several fields now.
11389 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
11390 records. [DEBUGGING] Dumps dictionary.
11391 (read_variables) Sets `index' field of variables created properly.
11392 Constructs avl tree of variables in dictionary. [DEBUGGING] No
11393 longer dumps dictionary.
11394 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
11396 [DEBUGGING] (dump_dictionary) No longer stubbed out.
11398 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
11399 var before destroying any variables just to save a little time.
11401 * var.h: (struct variable) Reordered in order to make name[] the
11402 first member; this makes pointers to `variable' pointers to the
11403 variable name, simplifying avl trees, etc.
11404 (struct indirect_dictionary) New struct.
11406 * vars-atr.c: (find_variable) Rewritten for efficiency.
11407 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
11409 (is_varname) Rewritten for efficiency.
11410 (parse_variables) New argument, which is a `dictionary *'. All
11411 references changed. This function now reads variable names from
11412 the dictionary passed, or from the default dictionary if NULL.
11414 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
11416 * misc.h: Added new macro DIV_RND_UP to perform integer division,
11417 rounding up. Changed many references to ROUND_UP to use this
11420 * sfm-read.c: Includes avl.h.
11421 (corrupt_msg) Induces a segfault under Checker.
11422 (macro assertive_bufread) New. Many references to bufread() now
11424 (sfm_read_dictionary) Split up into several functions. Added code
11425 to read dictionary records following the the type 2 records. Not
11426 quite complete. New variable `var_by_index'.
11427 (read_header, read_variables) New functions extracted from
11428 sfm_read_dictionary().
11429 (read_value_labels) New function.
11430 (bufread) Checks ferror() if fread() doesn't return the expected
11431 value; if ferror() is zero it's just EOF.
11432 (dump_dictionary) Stubbed out.
11434 * BTW: The source code now exceeds 50000 lines!
11436 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
11438 * command.c: Added GET to cmd_table[].
11440 * list.q: Removed reference to alloca headers.
11441 (cmd_list) Gave prototype.
11443 * sfm-read.c: Added DEBUGGING comments.
11444 (sfm_read_dictionary) Checks bias correctly. Sets
11445 dict->var_by_name to NULL. Calculates long_string_count
11446 correctly. realloc's dict->var[] array to minimum size.
11447 [DEBUGGING] Calls dump_dictionary.
11448 [DEBUGGING] (dump_dictionary) New function.
11450 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
11451 (restore_dictionary) If the dictionary contains a non-NULL
11452 var_by_name, uses that instead of generating one.
11453 (free_dictionary) Destroys var_by_name.
11455 * var.h: (struct dictionary) Added field `var_by_name'.
11457 * get.c: New file, not complete.
11459 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
11461 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
11462 (parse_num_or_range) New function.
11463 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
11464 <n> THRU HIGH missing values.
11466 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
11467 __attribute__((const)).
11469 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
11471 * sfm-read.c: Finished reference implementation.
11473 * sfm.h: Includes var.h.
11475 * var.h: Comment fixes.
11476 (struct `variable') Reordered some fields.
11478 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
11479 constants added previously.
11481 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
11483 * common.h: Comment fixes. Added declaration of
11484 `second_lowest_value' as variable or macro. Made `compat_type',
11485 `pgm_state_type' into anonymous enums.
11487 * display.c: Comment fix.
11489 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
11491 [!defined SECOND_LOWEST_VALUE] Added definition for
11492 `second_lowest_value' global var.
11493 (compat, pgm_state global vars) Changed types to `int'.
11494 (init_glob) Initializes `second_lowest_value'.
11496 * sfm-read.c: Continued work, not complete.
11498 * var.h: Added new MISSING_* constants to handle LOWEST and
11501 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
11503 * sfm-read.c: New file, not complete.
11505 * cases.c: (vec_insert) Changed vector expansion algorithm.
11506 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
11507 mucking up the RECODE transformation in particular.
11508 (envector) Harmless change in notation.
11510 dfm is now fairly well tested again.
11511 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
11513 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
11515 * recode.c: Comment fix.
11517 * sfm.h: Interface should be fairly final now, or at least for a
11520 * vfm.c: [DEBUGGING] (index_to_varname) New function.
11521 (open_active_file) [DEBUGGING] Translates ccase indices into
11522 variable names now to make it easier to understand what's really
11525 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
11527 * data-in.c: Comment fix.
11529 * data-list.c: Includes dfm.h.
11530 (do_reading) Uses new function dfm_push_cust().
11532 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
11533 `return 1;' at end.
11535 * file-handle.h: Completely changed. Some parts split off into
11536 new file dfm.h. Implemented in file-handle.q.
11537 (enum FH_*) Removed.
11538 (struct fh_ext_class) New struct.
11539 (struct file_handle) Retained only these fields: name, norm_fn,
11540 fn, recform, lrecl, mode. New fields class, ext.
11541 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
11542 close_handle, handle_name) Added `fh_' prefix to name, all
11543 references changed.
11545 * dfm.h: New file, implemented in dfm.c.
11546 (get_record, put_record, fwd_record, bkwd_record, set_record,
11547 get_cur_col) Functions moved from file-handle.h, now prefixed with
11549 (dfm_push_cust) New function.
11551 * sfm.h: New file. Incomplete.
11553 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
11554 interface. Functions reordered, comments changed. Not well
11555 tested, probably full of bugs.
11556 (struct dfm_fhuser_ext) New struct.
11557 (dfm_close) New function.
11558 (open_file_r) Pickier about finding `BEGIN DATA.' line.
11559 (open_file_w) User messages changed.
11560 (get_record) Comment fixed.
11561 (read_record) Increments ext->ln even for inline_file. Calls
11562 dfm_close() for inline_file when `END DATA.' encountered.
11563 (dfm_get_record) Experimental restructuring.
11564 (dfm_push_cust) New function.
11565 (cmd_begin_data) Detects whether the inline file was fully read by
11566 checking whether it is still open; detects whether it was read at
11567 all by checking whether the line number is greater than zero.
11569 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
11570 interface. Functions reordered, comments changed. Not well
11571 tested, probably full of bugs.
11572 (init_file_handle) Removed initializers for obsolete fields, added
11574 (fh_close_handle) Much simpler, now mainly calls the class
11576 (fh_init_files) Renamed inline file internal filename.
11578 * file-type.c: Includes dfm.h.
11579 (read_from_file_type) Doesn't use dfm internal state anymore.
11581 * inpt-pgm.c, print.c: Include dfm.h.
11583 * recode.c: (internal_cmd_recode) Casts strlen() return value to
11584 int in comparison with other int.
11586 * som-high.c: (build_target) Fixed operator precedence problem in
11587 if statement (& versus ==).
11589 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
11591 * dfm.c: (read_record) Can now read fixed-length records; not
11593 (put_record) Can now write fixed-length records; not tested.
11595 * file-handle.h: FH_* defines changed to enums. New enum series
11597 (struct file_handle) New members recform, lrecl, mode.
11599 * file-handle.q: Parser changed.
11600 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
11601 /LRECL subcommands. These are compatible with Windows.
11602 (init_file_handle) Initializes recform, mode fields.
11604 * q2c.c: (get_line) When outputting `!' comment lines, now
11605 increments the output file line number so that `#line' directives
11607 (make_identifier) New function that converts an arbitrary string
11608 into a valid C identifier.
11609 (dump_vars) Calls make_identifier() in two places in order to
11610 suppress some errors for bad identifiers.
11611 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
11612 for NO. Allows numbers to be prefixed by underscores to make them
11613 acceptable C identifiers but still to be parsed as numbers by the
11616 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
11618 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
11620 * dfm.c: Comment fixes. (get_record) Gives error if file handle
11621 was opened for writing.
11622 (open_file_w) New function.
11623 (read_record) Uses strncasecmp if available. Improved error
11624 messages, comments.
11625 (put_record) New function.
11627 * file-handle.h: Moved function comments into dfm.c and
11628 file-handle.q. Comment fixes. Removed declarations of
11629 tilde_expand() and normalize_filename().
11630 (struct file_handle) Changed `open' from boolean to enumerated
11631 field to allow for three states--closed, open for reading, open
11632 for writing--all references changed.
11634 * file-handle.q: Includes filename.h.
11636 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
11637 references changed.
11638 (alloc_line) Makes allowance for line terminator characters in
11640 (print_trns_proc) Now handles OUTFILE, WRITE differences.
11641 (print_space_trns_proc) Handles OUTFILE differences.
11643 * recode.c, sample.c: Comment fixes.
11645 * var.h: (struct print_trns) Changed boolean field `eject' to
11646 bitmapped field `options'; all references changed. New enums
11647 PRT_* for use with this field.
11649 * exception.h, test-exception.c: Removed.
11651 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
11653 * ascii.c: (delineate) Turned off debug output.
11655 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
11658 * data-in.c: (parse_string_as_format) Sets the entire string value
11659 to spaces, not just the short string part of it. Is this correct
11662 * data-out.c: (convert_date) Fixed DATETIME format problems with
11663 decimal places, removed debug code.
11665 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
11666 middle of parsing BEGIN DATA that would cause the lexer to read
11667 from a wild pointer `prog'; now calls new function
11668 preprocess_line() in lexer.c.
11670 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
11672 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
11673 Now call induce_segfault() to induce the segfault.
11674 (induce_segfault) New function.
11676 * expr-opt.c: Comment fix.
11677 (parse_sysvar) New function.
11678 (parse_primary) Added system variable support--calls
11680 (global var ops) Added OP_CASENUM operator.
11682 * expr.h: Comment fixes.
11683 (OP_* enum) added OP_CASENUM operator.
11684 (struct casenum_node) New struct.
11685 (union any_union_union) New member `cas' of type `casenum_node'.
11687 * glob.c: (global var last_vfm_invocation) New var.
11688 (init_glob) Initializes last_vfm_invocation.
11690 * lexer.c: (lookahead) Fixed reversed condition on if statement.
11692 * getline.c: (get_line) Split into get_line() and preprocess_line().
11693 (preprocess_line) New function.
11695 * var.h: Declares last_vfm_invocation.
11697 * vfm.c: (procedure) Sets last_vfm_invocation.
11699 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
11701 * command.c: (parse_cmd) Fixed bad assertion related to
11704 * data-in.c: (parse_month) Implemented to parse months according
11705 to full interpretation of standard.
11706 (to_roman) New function.
11707 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
11708 (parse_weekday) Bug fix (forgot to skip all the day name).
11710 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
11711 up parsing of multirecord data items. Also fixed user message.
11713 * data-out.c: Comment fix.
11714 (year2, year4, convert_date, convert_time, convert_WKDAY,
11715 convert_MONTH) New functions to support time & date output.
11716 (convert_format_to_string) Calls new time & date output routines.
11718 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
11720 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
11723 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
11725 * misc.c: (global var formats) Fixed declarations of DATETIME,
11728 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
11729 the output_char buffer.
11731 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
11732 memory bug. Fixed user messages.
11734 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
11736 * Removed #pragma argsused from lots of places.
11738 * data-in.c: Implemented zoned decimal and time-date formats.
11739 Untested. This is a huge chunk of code--maybe 1000 lines and 50
11742 * data-out.c: Implemented zoned decimal format.
11744 * expr.h: Moved yrmoda() declaration here from exprP.h.
11746 * misc.c: (global var formats) Minor fixes--added
11747 FCAT_SHIFT_DECIMAL to formats N and Z.
11748 (convert_fmt_ItoO) Added support for format Z.
11750 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
11752 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
11754 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
11755 som_check_workspace() that is activated between commands.
11757 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
11760 * list.q: (begin_row) Changed title expansion style from
11761 SOPT_X_VERT to SOPT_X_SHSP.
11763 * som-frnt.c: Now includes `somP.h'.
11764 (som_push_workspace, som_pop_workspace) New functions that, taken
11765 together, form a solution to the recursive table building problem
11766 mentioned yesterday. Surrounded every table output routine
11767 throughout the program with calls to these functions.
11768 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
11769 (som_create_table) Checks that there's an active workspace.
11770 (som_destroy_all_tables, som_crush) Removed.
11772 * som-high.c: (global var som_preserve_tables) Removed, all
11773 references deleted.
11774 (som_submit_table) Checks that there's an active workspace.
11775 (dump_columnated_table) Doesn't columnate tables that would have
11776 just one row per column.
11777 (dump_crush_page, som_dump_crush_page) Removed debugging code.
11778 (som_dump_crush_page) Moved row number labels from left side of
11779 tables to right side.
11780 (som_get_table_size) Added support for SOPT_X_SHSP.
11782 * som.h: New cell expansion type SOPT_X_SHSP.
11784 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
11786 (global var curtab_arena) Moved from som-frnt.c.
11788 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
11790 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
11791 that causes bad location warnings to be suppressed.
11792 (delineate) Saves current font when calling draw_text(); fixed
11793 handling of NULLs when backing up. Also fixed line-wrapping bug.
11795 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
11796 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
11798 * common.c: Added code to cause assertion failure to dump core
11799 when run under Checker.
11801 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
11802 there are still bugs.
11804 * glob.c: (__eprintf) Removed.
11806 * list.q: Inserted som_preserve_tables kluge that prevents tables
11807 from being thrown away due to recursive table building through
11808 som_output_line being called from a transformation during the LIST
11809 procedure invocation. This is a general problem that must be
11810 solved in a better way since it applies to all procedures in
11812 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
11813 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
11815 * numeric.c: Fixed several errors in the form of msg() calls.
11817 * print.c: Updated for use of som.
11818 (dump_table) Reimplemented.
11819 (print_trns_proc) Calls som_eject_page() instead of eject_page().
11820 Calls som_output_text() instead of outs_line().
11822 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
11824 (som_output_text) Function moved from som-low.c. Interface
11827 * som-high.c: (som_preserve_tables) New global public variable
11829 (som_submit_table) Destroys the tables only if som_preserve_tables
11831 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
11832 one subrow per row. Now labels subrows if there's more than one
11834 (dump_crush_table) Added wishlist comment.
11835 (som_eject_page) New public function declared in som.h.
11837 * som-low.c: (som_dump_crush_page) Draws row labels if there's
11838 more than one subrow per row.
11839 (som_output_text) Moved to som-frnt.c.
11841 * som.h: (SOM_TOPT_PRESERVE) Removed.
11843 * title.c: (get_title) Changed interface.
11844 (cmd_title) Changed `title' to `outp_title'.
11845 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
11847 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
11849 * list.q: (flush_table) Conforms to new partial options in
11850 som_submission_form.
11852 * som-high.c: (paginate_horizontally) Changed form of subrow
11854 (build_target) Omits spacing before table if
11855 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
11856 (dump_crush_page) Changed interface. Only trims bottom rule if
11857 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
11858 (dump_crush_table) Handles partial tables.
11859 (output_row_label) New function.
11860 (som_dump_crush_page) Emits subrow number labels. Draws vertical
11861 rule on the right edge of narrow subrows.
11863 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
11864 constants to a series of SOM_TOPT_PARTIAL_* submission options.
11865 All references updated.
11867 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
11869 * misc.c: Comment fix.
11871 * som-high.c: (examine_table) Treats crushed tables separates for
11872 purpose of determining header size.
11873 (paginate_horizontally) Allots space for line numbers in crushed
11874 tables with lots of subrows per row. Calculates the `maximum page
11875 width', the width of the widest horizontal page.
11876 (build_target) Removed trim argument; all references changed.
11877 Stricter assertions. (dump_crush_page) New function.
11878 (dump_crush_table) Reimplemented.
11880 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
11881 (som_dump_crush_page) Reimplemented, interface changed.
11883 * somP.h: Many many new helper macros for use with crushed tables.
11884 (global var som) Removed `tv', `cum_y' members; all references
11885 removed. New members `mpw', `digit_space'.
11887 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
11889 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
11890 variable, changed to constant 1024.
11891 (arena_ca_strdup) Changed `sizeof(a_string)' to
11892 `sizeof(c_string)'.
11893 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
11894 `(c_string *)' to `(char *)'; this fixed some offset problems.
11896 * filename.c: (readlink_malloc) Changed initial allocation from
11898 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
11901 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
11902 &fm->owner in several places.
11904 * som-high.c: (output_table) Changed interface to rest of world.
11905 (examine_crush_table) Removed. Crushed tables are re-broken now,
11906 in preparation for rewrite.
11908 * som.h: Comment fix.
11910 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
11912 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
11913 itself in the cleanup stage.
11915 * descript.q: (display) At least temporarily, changed the table
11916 format to a crushed table.
11918 * list.q: (begin_row) At least temporarily, added horizontal lines
11921 * som-high.c: (examine_crush_table) Sets som.hh to the width of
11922 the horizontal "headers," that is, to the width of the far left
11923 and far right rules.
11924 (justify_pagination) Sets som.th to the width of the widest row
11925 in the crushed table. Fixed inner loop off-by-one error.
11927 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
11930 * somP.h: Comment fix.
11932 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
11934 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
11935 before closing it; also, opens the constructed filename `s'
11936 instead of f->filename.
11938 * postscript.c: Moved initialization of x->loaded, x->prop,
11939 x->fixed, x->current, also the add_encoding() calls, into
11941 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
11942 sets x->last_font to NULL; sets x->next_combo to zero.
11944 * som-high.c: (crushed_row_height) Moved definition farther up.
11945 (som_submit_table) Doesn't calculate line width, font size until
11946 after calling open_page(), to accomodate changes to PostScript
11948 (vert_headers) Removed; equivalent functionality moved to
11949 examine_table(), examine_crush_table().
11950 (justify_pagination) Replaced with different algorithm.
11951 (dump_crush_table) Bugfix that caused tables to fail to be clipped
11952 at the bottom of the page.
11954 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
11956 * command.c: Added cmd_list back into cmd_table.
11958 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
11959 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
11961 * list.q: (flush_table) Updated to new som_submission_form format.
11963 * som-frnt.c: Comment fix.
11965 * som-high.c: Changed `#endif' to `#undef EXTERN'.
11966 (output_table) Calls som_get_table_size() directly; handles
11968 (examine_crush_table) New function; calls vert_headers().
11969 (examine_table) Moved some code into new function, vert_headers().
11970 (justify_pagination) New function.
11971 (dump_plain_table) Removed `static' from `cy'.
11972 (dump_crush_table) New function.
11974 * som-low.c: (som_dump_crush_page) New function.
11976 * som.h: Comment fixes.
11977 (enum SOM_TOPT_CRUSH) New.
11978 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
11979 Temporarily set to zero to make do with LIST procedure.
11981 * somP.h: Re-ordering.
11983 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
11985 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
11987 * somP.h: New file for use by som-high.c, som-low.c.
11989 * q2c.c: Added definition for VME.
11990 (get_line) Now dumps `!' comment lines to the output file
11993 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
11994 set.q: Changed format of `!' comment lines.
11996 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
11998 * All source files: Added copyright notice.
12000 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
12001 longs in msg() calls.
12003 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
12005 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
12007 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
12009 * output.c: (outp_read_devices) Changed criteria for
12010 distinguishing different types of lines.
12012 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
12014 * cmdline.c: Changed syntax message.
12016 * filename.c: (good_getcwd) Bug fix (?).
12017 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
12019 (search_path) Appends DIR_SEPARATOR to directory name only if it
12020 does not already end with one.
12022 * glob.c: Checks STAT_PAGER envvar before PAGER.
12024 * output.c: Checks environment variables instead of just local
12027 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
12029 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
12030 when the pointer passed to the function was within the arena
12031 itself, so that it couldn't properly be set to NULL _after the
12034 * command.c: Re-enabled DISPLAY.
12036 * display.c: Rewritten to handle tables. Untested.
12038 * filename.c: (search_path) Fixed memory leak.
12040 * frequencies.q: (cmd_frequencies) Frees v_variables.
12041 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
12042 (cleanup_freq_tab) New function to garbage collect.
12043 (dump_full) Elegantized.
12045 * main.c: New comment.
12047 * output.h: New tag for tagged quotes: TAG_NEWLINE.
12049 * postscript.c: Comment fix.
12050 (release_fontmap, free_font_entry) New functions.
12051 (ps_init_driver) Sets free_font_entry() as the freefunc for
12052 hashtable `loaded'. Calls release_fontmap() when destroying a
12053 driver; also frees the output filename; also frees the
12054 ps_driver_ext block.
12055 (free_ps_encoding) Frees the filename as well as the encoding
12057 (output_encodings) Frees the line buffer and pops the msg-filename
12059 (read_fontmap) Frees the fontmap filename and the line buffer.
12060 (postopen, preclose) Misc. garbage collection fixes.
12061 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
12062 to NULL; this fixes some output problems.
12063 (text) Handles TAG_NEWLINE. Untested.
12065 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
12066 (som_set_string) Removed. All references changed to
12068 (som_set_text) Rewritten. New interface. More general.
12070 * som.h: Minor format changes.
12071 (struct som_value_cell) Removed; all references changed to
12073 (enums SOT_*) Changed.
12075 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
12077 * command.c: Re-enabled SPLIT FILE.
12079 * postscript.c: Comment fix.
12081 * som.h: Added `SOT_NONE'.
12083 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
12085 * vfm.c: (dump_splits) Reimplemented.
12087 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
12089 * Compiled the project under gcc 2.7.2, which gave some new
12090 warnings. This led to many additions of casts from unsigned to
12091 int sprinkled throughout the code.
12093 * arena.c: Many uses of `unsigned' changed to `size_t'.
12095 * command.c: Added END FILE, END REPEAT to command table.
12096 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
12097 (find_command, FILE_TYPE_okay) Not commented out anymore.
12098 (parse_cmd) Calls FILE_TYPE_okay again.
12099 (output_line) Added calls to som_output_text() to put the line
12100 in the output files.
12102 * common.c: (macro VME) Format changes.
12103 (xstrdup) Asserts that its argument is not NULL.
12105 * data-list.c: Implemented dump_fixed_table().
12107 * inpt-pgm.c: Formatting changes. Comment changes.
12108 (end_case_proc) Renamed end_case_trns_proc.
12109 (cmd_end_file, end_file_trns_proc) New functions.
12111 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
12113 * misc.h: (local_strdup) New macro corresponding to strdup() but
12114 allocating its data through local_alloc() if possible--that is, if
12117 * postscript.c: Comment changes.
12118 (quote_ps_name, quote_ps_string, output_encodings) New functions.
12119 (output_line, add_string) New macros supporting
12120 output_encodings().
12121 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
12122 substitution vars. Calls output_encodings() when a line
12123 consisting of `!encodings' is encountered.
12124 (preclose) Some code moved into quote_ps_string().
12125 (dump_line) Changed into macro supporting dump_fancy_line().
12126 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
12127 command when appropriate.
12128 (write_text) Fixed `literal_char' array (I think it's fixed, at
12130 (text) Fixed bug when width was zero. Now exits immediately on
12131 zero height_left. Now, when executing `goto restart;', checks
12132 that cp<end, so that we don't read beyond end-of-string. Also,
12133 outputs the correct code to the output file by outputting the code
12134 from the metric instead of the internal metric index.
12136 * repeat.c: (cmd_end_repeat) New function.
12138 * som.c: (var som) `headers' renamed `options' and semantics
12139 changed. All references changed.
12140 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
12141 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
12143 (som_text_table) Removed.
12144 (som_output_text) New function.
12146 * som.h: (struct som_submission_form) Removed `header', `reuse',
12147 replaced with bitmapped field `options'.
12148 (SOM_TOPT_*) New enum set for som_submission_form.options.
12149 (SOT_*) New enum set for som_output_text().
12151 * temporary.c: (copy_variable) When copying the var label, only
12152 calls xstrdup() if it's non-NULL.
12154 * var.h: (enum type `vartype') Removed; all references changed to
12157 * vars-atr.c: (init_variable) Changed local var `nbytes' from
12160 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
12162 * font.h: Comment changes.
12164 * groff-font.c: (groff_read_font) Initializes `name' field to
12165 NULL. Handles `encoding' field.
12167 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
12169 * postscript.c: (struct font_entry) Removed `position' field.
12170 (struct ps_font_combo) New struct.
12171 (struct ps_driver_ext) Removed field `next_position'. New fields
12172 `combos', `next_combo'. `last_font' field changed from
12173 `font_entry *' to `ps_font_combo *'.
12174 (ps_init_driver) Reformatted; handles new fields. When
12175 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
12177 (get_encoding, find_encoding_file) New functions.
12178 (add_encoding) Some code moved out into find_encoding_file().
12179 (postopen) Changed value for ${title}.
12180 (preclose) Sets `loaded' field to NULL after destroying the hash
12182 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
12184 (ps_text_set_font_by_position) Figures out the current family if
12186 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
12187 (switch_font) Implemented.
12188 (write_text) Calls switch_font() more often. Format changes.
12189 #undefs its macros after they're no longer useful.
12190 (text) Changed `continue' at one point to a jump to the top of the
12191 loop because we don't want `separate' reset to 0 at that point.
12192 (load_font) No longer sets `position' in the font_entry created.
12194 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
12196 * font.h: (struct font_desc) New member `encoding', which is not
12197 properly handled yet.
12199 * glob.c: (init_glob) Some new i18n code, which is probably
12202 * output.c: (outp_read_devices, outp_get_paper_size) Changed
12203 `size' local from `int' to `size_t'.
12205 * postscript.c: New driver configuration parameter `auto-encode'.
12206 New enums OPO_AUTO_ENCODE, ODA_COUNT.
12207 (struct font_entry) New member `position'.
12208 (struct ps_driver_ext) Reordered. New hash table member
12209 `encodings'; new members `next_position', `next_encoding',
12210 `last_font'. Members `current', `prop', `fixed' changed from type
12211 `font_desc *' to `font_entry *'; all references changed.
12212 (struct ps_encoding) New struct.
12213 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
12214 free_ps_encoding, add_encoding) New functions.
12215 (ps_init_driver) Added OPO_AUTO_ENCODE to default
12216 x->output_options. Initializes new members of ps_driver_ext.
12217 Changed default value for prologue_fn, encoding_fn. Calls
12218 read_ps_encodings after loading default fonts.
12219 (option_tab[], ps_option) Handle new configuration parameter.
12220 (switch_font) New function.
12221 (struct output_char) `font' member changed from `font_desc *' to
12222 `font_entry *'. New member `separate'.
12223 (read_fontmap) Changed `size' from `int' to `size_t'.
12224 (output_line, put_number) New macros for write_text().
12225 (write_text) Optimizes text output by consolidating multiple
12226 calls to PostScript `show' operator.
12227 (text) Keeps track of when text arguments can't be consolidated by
12228 write_text(), and marks those spots in the output stream.
12229 (load_font) Sets `position' of the allocated font_entry to -1, cuz
12230 the font hasn't been switched to by switch_font(), which is where
12231 the position is important--the PostScript is what cares about the
12234 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
12236 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
12237 call a NULL free_func.
12238 (hsh_rehash) Elegantized.
12239 (hsh_probe) Fix bug that manifested when the table was expanded
12240 and thus had to change location in memory. Good thing
12241 too--otherwise could have been much more subtle.
12242 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
12243 (hsh_foreach) New function for hash table iteration.
12245 * hash.h: (struct hsh_iterator) New.
12247 * lexer.c: (parse_tagged_quote) Font and family name strings in
12248 tags are now null-terminated.
12250 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
12252 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
12253 documented. (Never before tested?)
12255 * output.h: Comment changes.
12257 * postscript.c: New driver options `optimize-text-size',
12258 `optimize-line-size', `max-fonts-simult'. New enum set for
12259 specing cached line types. Comment fixes.
12260 (struct line_form) New struct.
12261 (struct ps_driver_struct) New members `text_opt', `line_opt',
12262 `max_fonts', `lines'.
12263 (ps_init_driver) Initializes new members of ps_driver_struct.
12264 (user option type enum set) New member `nonneg_int_arg'.
12265 (static var option_tab[]) Supports new options.
12266 (ps_option) Handles new options.
12267 (find_ps_file) Made static. No longer calls hsh_dump().
12268 (ps_get_var) Made static.
12269 (preclose) Dumps out proper DSC trailer.
12270 (ps_open_page) Elegantized.
12271 (ps_close_page) Calls dump_lines() if appropriate.
12272 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
12273 wrappers around line().
12274 (int_2_compare, compare_line, dump_line, dump_fancy_line,
12275 dump_lines, hash_line, free_line, line) New functions for support
12277 (write_text, text) Made static.
12278 (text) Added to font support, not finished.
12280 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
12282 * font.h: (struct font_desc) New members ascent, descent.
12284 * groff-font.c: (groff_read_font) Calculates font ascent and
12285 descent from the ascent and descent of the `d' and `p' characters,
12286 respectively, as per a suggestion on comp.fonts.
12288 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
12289 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
12291 (write_text) Handles text right-justification and centering (not
12292 full justification). Still very inefficient. (One output line
12294 (struct output_char) Added fields for font and font size.
12295 (text) Many bugfixes.
12297 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
12299 * cmdline.c: (usage) Calls outp_list_classes().
12301 * font.h: Comment fix.
12303 * groff-font.c: New exported global var `space_index'.
12304 (groff_init) New function to initialize `space_index'.
12305 (hash_kern) Casts result to unsigned.
12306 (font_name_to_index) Renamed font_char_name_to_index. All
12307 references changed. Also, now returns the value of `space_index'
12308 when passed an ASCII space character as an argument. Fixed
12310 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
12311 Handles passed NULL pointers properly.
12313 * lexer.c: (parse_tagged_quote) Comment fix. Better range
12316 * output.c: (outp_list_drivers) Removed. Removed all references.
12318 * output.h: Comment fixes.
12320 * postscript.c: (ps_open_global) Calls groff_init().
12321 (output_char) New structure.
12322 (write_text) New function.
12323 (text) No longer stubbed out! Now the output is correct--with a
12324 few exceptions, one of them being that the page has to be held
12325 upside down into a mirror.
12327 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
12329 * font.h: Comment fix.
12331 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
12332 All callers changed.
12333 (number_to_index) Renamed font_number_to_index, made extern. All
12335 (font_get_kern_adjust, font_get_char_metrics) New functions.
12337 * output.h: New constant OUTP_T_INTERNAL_DRAW.
12339 * postscript.c: Changed default line width back to 1/2 point.
12340 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
12341 in the center of the space allotted for them, not just a fixed
12342 offset from the edge of the space; this fixes some bugs.
12343 (ps_line_intersection) Now supports all command line styles.
12344 (ps_text_get_size) Bug fix in computation of em width.
12345 (text) New function, the meat behind ps_text_metrics and
12346 ps_text_draw. Not complete.
12347 (ps_text_metrics, ps_text_draw) Removed the stub taken from
12348 ascii.c; call text().
12350 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
12352 * arena.c: (arena_free) Assert that the argument is non-NULL.
12354 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
12355 only if old_kern is non-NULL.
12357 * postscript.c: (ps_init_driver) Changed default line width to 1
12359 (postopen) New prologue variables.
12360 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
12361 more of the common line styles properly, but not all.
12362 (ps_text_metrics) Fixed problem with this stubbed out version that
12363 kept it from taking font sizes into account.
12365 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
12367 * arena.c: (arena_malloc) Bug fix.
12368 (arena_dump) [GLOBAL_DEBUGGING] New function.
12370 * ascii.c: Comment fix.
12371 (count_fancy_chars, delineate) Now static functions.
12373 * filename.c: (interp_vars) Bug fixes.
12375 * font.h: Comment fixes.
12377 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
12378 beginning in case we have an error message to display before
12379 initializing the display.
12381 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
12383 (groff_read_font) Bug fixes.
12384 (name_to_index) Increments hash.used. Sets `name' field of hash
12386 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
12388 * hash.c: Return type changed.
12390 * postscript.c: Continued development. Now marks lines on the
12391 paper, but very buggy.
12393 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
12395 * Changed comments in many source files from `/* xxx /* yyy */' to
12396 `/* xxx */ /* yyy */' for cleanliness.
12398 * arena.c: (arena_sd_strdup) New function.
12400 * ascii.c: (struct ascii_driver_ext) New member `file'.
12401 (ascii_init_driver) Fills out member `file' for initing; uses
12402 close_file_ext for closing drivers.
12403 (ascii_option) Changed %.*s back to %s because the a_string's are
12404 always null-terminated.
12405 (postopen, preclose) New functions.
12406 (ascii_open_page) Uses new style of open_file_ext.
12407 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
12408 instead of this->output.
12409 (__assert_fail) Removed.
12411 * cmdline.c: Changed syntax_message[].
12413 * error.c: #include's <readline/history.h> only if the history
12414 library is available, not if just the readline library is
12417 * filename.c: (expand_line) Removed alloca() support.
12418 (interp_vars) No longer tilde-expands argument. Limit on output
12420 (tilde_expand) Now treats argument as path rather than filename.
12421 [!unix] Now is a no-op function.
12422 (search_path) Better verbose message formatting.
12423 (open_file, close_file) Comment fixes.
12424 (close_file) [!unix] Doesn't bother with pipes.
12425 (open_file_ext) Completely rewritten, interface revamped.
12426 (close_file_ext) New function.
12428 * font.h: Comment changes.
12430 * frequencies.q: Removed AIX alloca support since it doesn't use
12433 * hash.c: Comment changes & additions.
12434 (hsh_create) Initializes entire table instead of first M entries.
12435 (hsh_probe) Stupid bug fixed. Now it works.
12436 (hsh_dump) [GLOBAL_DEBUGGING] New function.
12438 * main.c: (parse) Detects EOF properly in token-eating loop.
12439 Should the STOP token have its value changed to 0?
12441 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
12442 (blp_getline) Now it's a macro.
12444 * output.h: (struct outp_driver) Removed members output, filename.
12446 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
12447 drivers in driver table.
12448 (outp_read_devices) Frees buf. Warns if there are no active
12450 (outp_configure_clear) Sets outp_configure_vec to NULL after
12451 deleting its elements.
12452 (configure_driver, destroy_driver) Removed references to output,
12453 filename members of outp_driver.
12454 (outp_evaluate_dimension, internal_get_paper_size,
12455 outp_get_paper_size) New functions.
12457 * postscript.c: Continued development. Now links but doesn't make
12458 any marks on the page. Lotsa bugs I suppose.
12460 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
12462 * str.h: Comment changes.
12464 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
12466 * Removed dependencies on non-nested comments in several files.
12467 Also removed references to (unix || __unix__) in #if's since
12468 prefh.orig makes those two equivalent.
12470 * ascii.c: (ascii_open_global) Creates ascii_arena.
12471 (ascii_close_global) Destroys ascii_arena.
12472 (ascii_init_driver) Doesn't create ascii_arena.
12473 (ascii_copy_driver) Removed.
12474 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
12475 (outp_class ascii_class) Removed ascii_copy_driver reference.
12477 * frequencies.q: Now can display all statistics except median.
12478 Still not finished.
12480 * output.c: Handles outp_class.ref_count so output class
12481 destructors are called properly.
12482 (add_class) Sets ref_count to 0.
12483 (configure_driver) Initializes class if ref_count++ is 0.
12484 (destroy_driver) Destructs class if --ref_count is 0. Frees the
12485 class output file name.
12487 * output.h: (struct outp_class) Removed copy_driver, inited.
12490 * postscript.c: Completely replaced but not finished.
12492 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
12494 * approx.h: #includes <float.h>.
12496 * arena.h, arena.c: Many functions changed to take an arena **
12497 instead of an arena *, for consistency. All callers changed.
12498 (arena_alloc) Now creates a new arena if passed *A that is NULL.
12499 (arena_destroy) Sets *A to NULL.
12501 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
12502 assertion that `width' be positive.
12504 * command.c: Removed #if's from cmd_table.
12505 (walk_cmdtable_func) [0] New function (debug code).
12506 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
12507 (parse_cmd) Doesn't return failure for unimplemented commands.
12509 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
12510 (SYSCODE) New constant macro.
12512 * descript.q: Checks for positive n_variables before performing
12515 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
12516 avl_find instead of &fp as arg 2.
12518 * frequencies.g, frequencies.q: Continued updating; now compiles &
12519 works again, but not complete.
12521 * main.c: Changes to user messages.
12523 * misc.c: (reverse) [0] New function.
12525 * settings.h: Comment removed. #includes "common.h".
12527 * som.c: (som_set_null) New function.
12528 (som_set_value, som_set_string, som_set_text) More detailing
12530 (som_set_float) Implemented function.
12531 (dump_columnated_table) Bug fix regarding page breaks.
12532 (draw_cell) Bug fix regarding text that spilled out of a cell.
12533 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
12535 (get_cell_size) Support SCON_EMPTY cells.
12536 (get_table_size) When calculating rules' widths and heights, mask
12537 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
12539 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
12541 (struct som_submission_form) New member `header'; all users
12544 * val-labs.c: (get_label) User messages changed.
12546 * var.h: Changed FREQUENCIES structures.
12548 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
12551 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
12553 * approx.h: Definition of EPSILON now depends on system's
12554 DBL_EPSILON. Removed GNU C specific code.
12555 (cmpapx) Renamed approx_compare.
12557 * frequencies.g, frequencies.q: Continued updating; still doesn't
12560 * groff-font.c: (name_to_index) Fix bug that kept it from
12563 * hash.c, hash.h: Completed work.
12565 * var.h: Changes to freq_tab, frequencies_proc.
12567 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
12570 * hash.c, hash.h: New files. Not completed.
12571 * Makefile.am: Added hash.c to source file list.
12572 * font.h: (struct font_desc) New member kern_size_p.
12573 * groff-font.c: Uses hash.h.
12574 (hashpjw) Moved to hash.c.
12575 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
12577 (static var hash) New member size_p.
12578 * var.h: Includes hash.h.
12579 (struct freq_tab) Changed AVL_TREE to hash_tab.
12581 * vars-prs.c: Comment, formatting fixes.
12583 * frequencies.g, frequencies.q: Continued updating. Not yet
12586 * formats.c: Bug fix.
12588 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
12590 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
12591 * descript.g: Comment fixes.
12592 * descript.q: Comment fixes. Moved some declarations into var.h.
12593 Made dsc_info a static table. Updated FIXMEs.
12594 (internal_cmd_descriptives) Beautified.
12596 * frequencies.q: Started updating into working order.
12597 * frequencies.g: New file analogous to descript.g.
12598 * var.h: Comment fixes. Added structures for FREQUENCIES.
12600 * som.c: Removed vestiges of crushing and partial table support.
12602 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
12604 * Many more changes to som.c especially, but these will not be
12605 documented as I have resolved to remove them. This patchlevel is
12606 being released solely so that I can fall back to it if I decide
12607 that removing the changes is not a good idea.
12609 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
12611 * som.c: (global var som) New member `cum_y'.
12612 (build_target) Properly handles titles for partial tables.
12613 (dump_partial_beg, dump_partial_mid, dump_partial_end)
12614 Merged into single new function dump_partial(). Fixed problem
12615 with titles on partial tables.
12616 (dump_table) Calls dump_partial() for all parts of partial tables.
12617 (dump_page) Criteria for drawing title changed.
12619 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
12621 * command.c: (cmd_table) Added LIST, WEIGHT.
12623 * command.c: (cmd_remark) No longer frees `s' since it's not
12624 dynamically allocated.
12626 * data-out.c: (convert_f) Now correctly handles the case where
12627 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
12628 number of decimals.
12629 (som_destroy_all_tables) Removed argument. All callers changed.
12630 (som_vline, som_hline) Argument validity checking corrected.
12631 (som_set_value) Implemented half-heartedly.
12632 (replicate_table) Copies tables piece-by-piece when using Checker.
12634 * som.h: New line style SLIN_1THIN, currently equivalent to
12635 SLIN_0. New enum set SOM_SUB_*.
12636 (struct som_submission_form) Removed `seq_no'. Added `type'.
12638 * list.q: Newly working file; uses partial tables.
12640 * som.c: (som_reduce_table) Renamed som_set_table_height().
12641 (som_crush) Removed argument `group'.
12642 (global var som) Removed `nt', `seq_no'. Added `type'.
12643 (som_submit_table) Arguments changed.
12644 (output_table) Removed partial table code.
12645 (build_target) New arg; partial table support added. All callers
12647 (dump_plain_table) Removed partial table code.
12648 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
12649 (dump_table) Supports partial tables.
12650 (dump_page) New argument to allow not drawing top and/or bottom
12651 headers. All callers changed. Supports partial tables.
12653 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
12655 * data-out.c: Changed `#include <approx.h>' to `#include
12657 (convert_F) Comment fix. Now won't print `-.000', etc.
12659 * descript.q: Now Z-scores work, although there appears to
12660 be a bug (which might actually be in data-out.c:convert_F()).
12661 (descriptives_trns_proc, descriptives_trns_free) New functions.
12662 (run_z_pass) Implemented.
12664 * var.h: Comment fixes.
12665 (dsc_z_score, descriptives_trns) New structs.
12666 (descriptives_trns) Added to any_trns as `dsc'.
12668 * error.c, error.h: New error class, IS (Installation Script
12669 error), used in those instances where the error is in the
12670 installation, but there is a script file or installation file that
12671 can be usefully referred to.
12673 * output.c: Change many IE classes to IS classes.
12675 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
12676 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
12677 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
12678 include the corresponding header?
12680 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
12681 Don't bail out if termcap can't be read.
12683 * som.c: (som_destroy_table) Removed.
12684 (som_reduce_table, som_destroy_all_tables) New functions.
12685 (som_crush) New function, not implemented.
12687 * som.h: New table option STAB_CRUSH. Comment fix. New struct
12688 som_submission_form. Function prototypes revised.
12690 Outputting huge tables (1000s of rows) a few rows at a time
12691 is supported, though untested. May even break everything.
12692 Actually, the code doesn't even compile right now.
12693 * som.c: (struct som) New fields htv, nt, seq_no.
12694 (som_submit_table) Multiple arguments changed to a single
12695 pointer to struct submission_form. Only increments subtable_num
12696 if seq_no is zero. Only destroys table if it's not going to
12698 (replicate_table) New function.
12699 (output_table) Comment fix.
12700 (examine_table) Changed inline code to code calling
12701 replicate_table(). Calculates htv. Supports partial tables.
12702 (draw_title) Removed comment.
12703 (build_target) Only allows for title on first part of partial
12705 (dump_plain_table) Only resets table chunk number on first part
12706 of partial tables; FIXME: doesn't work quite right. Supports
12708 (dump_page) Titles only on first part of partial tables.
12710 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
12712 * Thanks to an unreliable IDE hard drive, I have spent the last
12713 day reconstructing my Debian GNU/Linux installation and redoing
12714 the previous day's changes--somehow I managed to save every file
12715 except for output.c and output.h. So the following changes could
12716 really be considered independent of the output.c, output.h changes
12719 * output.h, output.c: Moved the outp_configure_vec global var,
12720 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
12721 outp_configure_vec is now static.
12723 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
12725 * The entire philosophy behind configuration of the output drivers
12726 changed. Now there is a termcap-type configuration where drivers
12727 to be read are determined beforehand, rather than parsing the
12728 entire output init file and storing it in memory & deciding what
12729 to actually use later. Faster & more memory-efficient at the same
12732 * output.c: Comment fix. Removed outp_init_drivers global var.
12733 Removed all references to synonyms. New structure outp_defn. New
12734 global vars outp_macros, outp_configure_vec.
12735 (search_name, delete_name, add_name, check_configure_vec,
12736 expand_name, find_defn_value) New static functions.
12737 (outp_configure_clear, outp_configure_add, outp_configure_macro,
12738 outp_read_devices) New extern functions.
12739 (outp_init) Much functionality moved into outp_read_devices.
12740 (outp_read_devices) Format of output init file changed; name of
12741 file is `devices' rather than `output' to avoid Makefile
12743 (outp_clear) Renamed outp_done.
12744 (outp_list_classes) Bug fix, cleaned up.
12745 (outp_list_drivers) Not implemented anymore.
12746 (outp_configure_driver) Now a static function; simplified; now
12747 interpolates macros; supports new structure.
12748 (outp_enable_driver, match_synonym) Removed; all references
12750 (find_driver) First argument removed.
12752 * output.h: Global var outp_init_drivers removed; new structure
12753 outp_names; new enum set OUTP_S_*; new global var
12754 outp_configure_vec; function prototypes for output.c exports
12757 * main.c: (main) Calls outp_read_devices() after parsing the
12760 * cmdline.c: (parse_command_line) New option -v --verbose;
12761 --version changed to -V. --device option changed syntax to just
12762 take a single device name. Accepts key=value declaration of
12763 output init file macros. Syntax message updated.
12765 * filename.c: (expand_line) New function.
12766 (interp_environ_vars) Renamed interp_vars; no longer uses
12768 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
12769 overridden by real environment vars.
12770 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
12771 * filename.h: interp_environ_vars() renamed interp_vars().
12773 * error.c, error.h: Added extern variable `verbosity', message
12776 * error.c: (vmsg) Support message class MM.
12777 (verbose_msg) New function.
12779 * descript.q: (generate_z_varname) Bug fix in generation of
12781 (dump_z_table) Bug fix in column headers.
12783 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
12784 page from 29 to 15. Don't set a default for ops[OPS_INIT,
12785 OPS_DONE]. Writes the uninit string when the driver is closed.
12786 (ascii_open_page) Write the init string before the first page.
12787 (output_shorts) Form of main loop changed from `while' to `for'.
12788 Bug fix with overstrikes: the character is printed *after* the
12789 backspace. Eliminated a lot of `& 0xff' modifiers.
12790 (advance_to_left_margin) New function.
12791 (return_carriage, output_lines) Handle left margin.
12793 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
12795 * ascii.c: New option `carriage-return-style'.
12797 * ascii.c: (count_fancy_chars) New function.
12798 (delineate, text_metrics) Use new function; bug fixes regarding
12800 (text_draw) Bug fix with rich text.
12801 (output_string, output_shorts) Reordered.
12802 (output_shorts) Now handles boxchars and some overstrike font
12804 (output_char, return_carriage) New functions.
12805 (output_lines) Now handles overstriking and font changes properly;
12806 some code moved to output_shorts.
12808 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
12811 * ascii.c: New member `debug' in ascii_driver_ext.
12812 (ascii_init_driver, delineate) Uses new member.
12814 Now you can set a vertical height on writing text.
12815 * ascii.c: (delineate) Keeps track of vertical position.
12816 (text_draw) No longer considers fully justified text an internal
12819 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
12821 Tables' titles are drawn; they can have variable height.
12822 * som.c: `som' struct has new member, title_height.
12823 (draw_title) New argument. Moved within file. All caller
12825 (build_target) New argument, amount of space needed for first row.
12826 Calculates height of title, takes that into account. All callers
12828 (dump_plain_table, dump_columnated_table) Took calculation of y1,
12830 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
12832 (dump_columnated_table) Organized for readability.
12833 (dump_page) Makes use of som.title_height.
12835 * som.c: Many comment bug fixes.
12837 * descript.q: (try_name, generate_z_name) Bug fix regarding
12838 generation of Z-score variable names.
12839 * var.h: Removed num from descriptives_proc; all referents removed.
12841 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
12843 * ascii.c: (ascii_line_horz, ascii_line_vert,
12844 ascii_line_intersection) Added debugging code.
12846 Added a descriptive line above each table to describe it.
12847 * command.c: (parse_cmd) Calls som_new_series.
12849 * som.c: New static vars table_num, subtable_num. New `som'
12851 (dump_page) New arguments.
12852 (som_submit_table) Handle new variables.
12854 * som.c, som.h: (som_submit_table) New arguments. All callers
12856 (som_new_series) New function.
12857 (build_target) Makes room for extra line.
12858 (draw_title) New function.
12859 (dump_page) Calls draw_title. Bug fix: doesn't always set
12862 Columnation of tables support.
12863 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
12865 * som.c: Deleted references to fr, lr, ri.
12866 (som_columnate) Bux fix: sets group member of table.
12867 (som_add_options) Function removed.
12868 (dump_table) Split into three functions; extensively reworked.
12870 * descript.q: (dump_z_table) Better output table formatting; added
12871 title support to correspond to som.h changes.
12872 (display) Title support.
12874 * output.h: Added OUTP_T_NONE.
12876 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
12878 * descript.q: Improved handling of Z scores; still not perfect.
12880 * output.h, ascii.c: Added hook for getting em width of current
12883 * som.c: Uses new em-width hook. Added debugging code to
12885 (som_columnate) New argument.
12886 (som_add_options) Removed.
12888 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
12890 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
12891 rules as a property of the table instead of as a property of the
12894 * ascii.c: Added `header' to table of options.
12896 * descript.q: Added even shorter statistic names; modified to work
12897 with new som interface.
12899 * misc.c (blp_getdelim): Bug fix.
12901 * version.c: includes 'conf.h'.
12903 ----------------------------------------------------------------------
12906 version-control: never
projects / pspp-builds.git / blob