1 Sun Jul 31 14:09:57 2005 Ben Pfaff <blp@gnu.org>
3 Adopt use of gnulib for portability.
5 * Make.build: Add $(top_srcdir)/gl and $(top_builddir)/gl to
8 * Makefile.am: Remove bool.h, stat.h and change getline.[ch] to
9 getl.[ch] in pspp_SOURCES. Remove libmisc, add libgl in
12 * In many source files, added an explicit inclusion of gettext.h
13 and definition of _ macro. These are no longer in pref.h because
14 it interfered with definitions in a few gnulib source files.
16 * In many source files, changed #include "bool.h" to #include
17 <stdbool.h>, which is provided by gnulib.
19 * alloc.c: Removed functions defined in gnulib:
24 (out_of_memory) Redefined as wrapper for xalloc_die().
26 * alloc.h: Replace prototypes by #include "xalloc.h".
28 * casefile.c: Use full_read() and full_write() from gnulib instead
29 of our home-grown versions.
33 * getline.c: Renamed getl.c.
35 * getline.h: Renamed getl.h, updated all references.
37 * filename.c: (fn_readlink) Change to wrapper around xreadlink()
40 * glob.c: Just #include <time.h> instead of the crazy rigmarole
42 (init_glob) Call set_program_name() to initial gnulib progname
45 * html.c: (postopen) Use getlogin_r(), gethostname() from gnulib.
47 * permissions.c: Use "stat-macros.h" from gnulib.
49 * postscript.c: Just #include <time.h> instead of the crazy
50 rigmarole here before.
52 * q2c.c: (main) Make generated code #include "gettext.h".
54 * str.h: Get rid of most explicit declarations of standard
55 functions, in favor of including gnulib header files.
57 * expressions/evaluate.c: Ditto.
59 * expressions/operations.h.pl: Make generated code #include
60 <stdbool.h>, not "bool.h".
62 Sat Jul 30 23:13:17 2005 Ben Pfaff <blp@gnu.org>
64 * expressions/parse.c: (validate_function_args) Fix two msg() bugs
67 Sat Jul 30 23:10:01 2005 Ben Pfaff <blp@gnu.org>
69 * expressions/evaluate.c: (expr_debug_print_postfix) Don't pass
70 null pointer to printf for %.*s.
72 Sat Jul 30 23:05:33 2005 Ben Pfaff <blp@gnu.org>
74 * vars-atr.c: (var_is_valid_name) Fix three msg() bugs found by
77 Sat Jul 30 22:58:33 2005 Ben Pfaff <blp@gnu.org>
79 * rank.q: (parse_rank_function) Fix msg() bug found by -Wformat.
81 Sat Jul 30 22:56:12 2005 Ben Pfaff <blp@gnu.org>
83 * postscript.c: (postopen) Cast `char' to `unsigned char' before
86 Sat Jul 30 22:52:09 2005 Ben Pfaff <blp@gnu.org>
88 * pfm-read.c: (read_variables) Fix msg() bug found by -Wformat.
90 Sat Jul 30 22:50:57 2005 Ben Pfaff <blp@gnu.org>
92 * histogram.c: Include <config.h>.
94 Sat Jul 30 22:48:50 2005 Ben Pfaff <blp@gnu.org>
96 * get.c: (cmd_match_files) Fix msg() bug found by -Wformat.
98 Sat Jul 30 22:46:10 2005 Ben Pfaff <blp@gnu.org>
100 * format.c: (check_common_specifier) Fix msg() bug found by
102 (check_output_specifier) Ditto.
104 Sat Jul 30 22:43:57 2005 Ben Pfaff <blp@gnu.org>
106 * file-handle.q: (cmd_file_handle) Fix msg() bug found by
109 Sat Jul 30 22:41:44 2005 Ben Pfaff <blp@gnu.org>
111 * data-in.c: (parse_Z) [WORDS_BIGENDIAN] Don't declare buf[], to
112 avoid "unused variable" warning.
114 Sat Jul 30 22:38:46 2005 Ben Pfaff <blp@gnu.org>
116 * command.c: (find_word) Cast `char' to `unsigned char' before
117 passing to isspace().
119 Sat Jul 30 22:36:29 2005 Ben Pfaff <blp@gnu.org>
121 * case.c: (case_compare) Implement as delegating to
122 case_compare_2dict().
124 Sat Jul 30 22:34:18 2005 Ben Pfaff <blp@gnu.org>
126 * algorithm.c: Inclusion of <alloca.h> is unneeded.
128 Sat Jul 30 22:01:32 2005 Ben Pfaff <blp@gnu.org>
130 * Make.build: Don't append -ansi to AM_CFLAGS for GCC. Using
131 -ansi changes the behavior of header files significantly. It
132 causes __STRICT_ANSI__ to be defined, and some headers interpret
133 that as cause to e.g. not use `long long' or __attribute__. The
134 former example is bad when off_t is supposed to be `long long',
135 and the latter prevents -Wformat from working.
137 Sun Jul 24 20:26:59 2005 Ben Pfaff <blp@gnu.org>
139 Get rid of dependency on libgmp by writing our own routine for
140 floating-point base conversion.
142 * pfm-write.c: (write_float) Rewrote.
144 (pow30_nonnegative) New function.
145 (pow30) New function.
146 (trig_to_char) New function.
147 (format_trig_digits) New function.
148 (recurse_format_trig_int) New function.
149 (format_trig_int) New function.
150 (should_round_up) New function.
151 (try_round_up) New function.
152 (format_trig_double) New function.
154 Sun Jul 24 18:49:20 2005 Ben Pfaff <blp@gnu.org>
156 * data-in.c: (parse_numeric) Allow "1+23" even for F format, for
159 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
161 * pfm-read.c: (read_version_data) Read and ignore author field.
163 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
165 * get.c: (mtf_processing) Don't assume that
166 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
167 returns a negative, zero, or positive result. Fixes MATCH FILES
168 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
170 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
172 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
173 preprocessor test for sys/types.h was accidentally inverted. This
176 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
178 * get.c: (cmd_match_files) Fix memory leak on `by' and on
181 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
184 * vfm.c: (close_active_file) Remove unnecessary test.
186 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
188 Fix NDEBUG compile errors.
190 * hash.h: Needed explicit #include <assert.h>.
192 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
195 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
197 Implement embedding for PostScript driver. Fixes bug 12970.
199 * ascii.c: Fix compiler warnings.
203 * chart.h: Add `file' member.
205 * output.h: (struct outp_class) initialise_chart, finalise_chart
206 should take outp_driver *, not outp_class *. Update all
209 * plot-chart.c: (chart_create) Fix segfault when there are no
210 output drivers at all.
211 (chart_submit) Call d->class->finalise_chart.
213 * postscript.c: (ps_open_page) Set cp_y to 0.
214 (ps_submit) New function.
215 (ps_chart_initialise) Implement.
216 (ps_chart_finalise) Implement.
217 (static var postscript_class) Add ps_submit.
218 (static var epsf_class) Add ps_submit.
221 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
223 Did some more work on bug 12859 and then realized that a *good*
224 solution would require some fundamental restructuring. For now,
225 I'm marking REPEATING DATA unimplemented, and then we can revisit
228 * command.def: Make REPEATING DATA unimplemented.
230 * data-list.c: (cmd_repeating_data) Assume inline file is 80
232 (realize_value) Revert previous changes; no longer needed.
235 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
236 file_loc, to avoid bad references later.
240 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
242 Make some code tolerant of reentry. Should not be needed if other
243 code is correct but it is good to be generally tolerant.
245 * error.c: (err_hcf) Set file_loc to null after free().
247 * output.c: (outp_done) Similar changes.
249 * str.c: (ds_destroy) Ditto.
251 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
253 Continue work on bug 12859, plus some code cleanup.
255 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
256 boolean variables. Don't try to compute starts_end, cont_end for
257 inline file. Calculate length only after parsing variable
258 specifications. Add proper transformation to list.
259 (realize_value) If the rpd_num_or_var has no value, return new
260 DEFAULT_MEMBER argument (for use with inline file).
261 (repeating_data_trns_proc) Pass default values.
263 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
264 open, and only if we actually started reading data.
266 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
270 * output.c: (outp_read_devices) Fix message.
272 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
274 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
275 of the sort algorithm from the parser for the SORT command.
277 * rank.q: Added the parser for the RANK command.
279 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
283 * sort.c: (sort_parse_criteria) Only set *saw_direction if
284 saw_direction is non-null. Thanks to John Darrington for
287 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
289 * get.c: (mtf_processing) Handle case of a lookup table as the
290 active file. Thanks to John Darrington for reporting this bug.
292 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
294 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
295 POSIX calloc function.
297 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
298 reflect new signature.
300 * sfm-read.c: Now much more robust in the face of badly formed
303 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
305 *sfm-read.c: Fixed some bugs regarding long string continuation
306 records, which the previous fix uncovered.
308 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
310 * sfm-read.c, sfmP.h: Allow reading of system files when the
311 case_size value in the header is -1. Also changed some Errors to
312 Warnings when reading system files.
314 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
316 * data-list.c: (data_list_trns_free) Don't free the argument
317 because cancel_transformations() will do that itself.
318 (data_list_source_destroy) Destroy the argument to
319 data_list_trns_free(), because it no longer does so itself.
321 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
323 * data-out.c: (format_and_round) Don't output leading `-' if value
326 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
330 * som.c: (output_encodings) If some cell in the table won't fit
331 with the horizontal or vertical headers, cancel those headers.
333 * som.h: (struct som_table_class) Add fits_width, fits_length,
336 * tab.c: (tabi_fits_width) New function.
337 (tabi_fits_length) New function.
338 (tabi_set_headers) New function.
339 (global var tab_table_class) Add the new functions as appropriate
342 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
344 Fix rest of bug 13054.
346 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
347 DATETIME, TIME system/portable file values.
349 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
351 * data-list.c: (parse_free) Use make_input_format().
353 * data-out.c: (num_to_string) Use make_output_format().
355 * dictionary.c: (dict_create_var) Ditto.
357 * format.c: (global var f8_2) New var.
358 (make_input_format) New function.
359 (make_output_format) New function.
361 * get.c: (cmd_match_files) Use make_output_format().
363 * list.q: (cmd_list) Ditto.
365 * matrix-data.c: Ditto.
367 * sfm-read.c: (parse_format_spec) Check output specifier
370 * tab.c: (tab_float) Use make_output_format().
372 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
374 Fix more of bug 13054.
376 * format.def: FMT_A should allow 255-character output. FMT_AHEX
377 should allow 510-character input and output.
379 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
380 (convert_E) Handle non-finite values.
382 (format_and_round) New function.
383 (convert_infinite) New function used by try_F() and convert_E().
385 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
387 Regularize string and buffer function names so that they make some
390 * str.c: (mm_reverse) Rename buf_reverse(). Update all
392 (mm_find_reverse) Rename buf_find_reverse(). Update all
394 (mm_case_compare) Rename buf_compare_case(). Update all
396 (st_compare_pad) Rename buf_compare_rpad(). Update all
398 (str_compare_rpad) New function.
399 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
401 (buf_copy_str_lpad) New function.
402 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
404 (st_pad_copy) Rename str_copy_rpad(). Update all references.
405 (st_trim_copy) Rename str_copy_trunc(). Update all references.
406 (st_uppercase) Renamed str_uppercase(). Update all references.
408 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
410 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
413 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
415 * data-in.c: (data_in) Add assertion to check input specifier.
417 * data-out.c: (data_out) Add assertion to check output specifier.
419 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
421 Start to fix bug 13054.
423 * format.c: (check_input_specifier) Improve error message.
424 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
425 valid decimal places.
426 (check_output_specifier) Ditto (but different criteria).
427 (convert_fmt_ItoO) Assert valid input and output specifiers.
428 Also, if input specifier has *any* decimal places, make the output
429 specifier 1 place wider.
431 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
433 * sysfile-info.c: Fixed bug [# 13024 ]
435 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
437 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
438 actually implement it.
440 * command.c: (FILE_TYPE_okay) Always return 1.
442 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
444 * file-type.c: Add prototypes to get rid of warnings.
446 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
448 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
449 more ISO/IEC 9899:1990 conformance issues.
451 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
453 Fix bug 12948. See also new test in
454 tests/bugs/match-file-scratch.sh.
456 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
457 that deletes scratch variables that someone else might be using,
458 and because we can't reassign our sources' value indexes.
459 Instead, simply don't copy scratch variables into the master
462 * dictionary.c: (dict_compact_values) Delete variables from the
463 dictionary passed in, not from default_dict (!).
465 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
467 Improve hash.c comments, error-checking.
469 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
470 (hsh_create) size == 0 should *not* return NULL! Set
472 (hsh_clear) Set hash_ordered.
473 (locate_matching_entry) Check hash_ordered.
474 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
475 (hsh_data) Set hash_ordered. Add const-ness to return value and
479 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
481 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
483 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
485 * copyleft.c: Updated copyright date.
487 * Makefile.am: Removed erroneous explicit "-lplot"
489 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
491 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
493 * command.c command.def: Added description string for unimplemented commands.
495 * oneway.q: Sorted the hash tables before shipping out the results. Closes
498 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
502 * data-list.c: (parse_fixed) Use lex_end_of_command().
504 (cmd_repeating_data) Set cont_end.num in right situations.
505 (parse_repeating_data) Remove redundant test.
507 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
509 Partial fix for bug 12859.
511 * data-list.c: (cmd_data_list) Add transformation properly in
512 vfm_source == NULL case.
514 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
516 * lexer.c: (lex_error) Improve error messages.
518 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
520 * get.c: (cmd_match_files) Check token type before trying to match
521 tokid. Fixes bug 12923.
523 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
525 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
528 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
530 * expressions/generate.pl: (get_token) Make use of /g
531 backward-compatible with Perl 5.6.1.
533 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
535 * var-display.c: (cmd_variable_alignment) Fix memory leak.
536 (cmd_variable_level) Ditto.
538 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
540 Hash table had buggy deletion function. The fix required changing
541 other functions to do probing in the required order.
543 * hash.c: (locate_matching_entry) Rewrite and change interface.
544 (hsh_rehash) Rewrite to use locate_matching_entry().
547 (hsh_delete) Ditto. Also, fix stupid bugs.
549 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
551 * dictionary.c: (dict_clone) Properly copy vectors.
553 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
555 New implementation of long variable names. Each variable has a
556 "normal" name, which may be up to 64 bytes long and which is used
557 for all normal operations. Variables may have a "short" name,
558 which is limited to 8 bytes and used only for system and portable
559 file input and output.
561 Make tokid case-preserving. Update most uses of tokid to treat it
564 Update many commands to deal with long variable names.
566 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
568 * command.c: (cmd_parse) Ditto.
569 (match_strings) Use toupper() before comparing characters.
570 (conflicting_3char_prefixes) Use mm_case_compare() instead of
572 (cmd_match_words) Ditto.
574 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
577 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
578 Use st_trim_copy() instead of strcpy().
580 * data-in.c: (parse_enum) Use mm_case_compare() instead of
583 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
585 (parse_free) Use st_trim_copy() instead of strcpy().
587 * descript.c: (struct dsc_var) Change z_name[] to fit long var
589 (try_name) Use strcasecmp() instead of strcmp().
590 (generate_z_varname) Use st_trim_copy() instead of strcpy().
591 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
594 * dictionary.c: (struct dictionary) Removed `long_name_tab'
596 (compare_long_names) Removed.
597 (hash_long_name) Removed.
598 (dict_create) Don't initialize `long_name_tab' member.
599 (dict_clone) Copy short names into new dictionary.
600 (dict_clear) Don't clear `long_name_tab' member.
601 (dict_get_varname_block) Removed.
602 (dict_add_longvar_entry) Removed.
604 (dict_destroy) Don't destroy `long_name_tab' member.
605 (dict_create_var_from_short) Removed.
606 (dict_create_var_x) Removed.
607 (dict_create_var) Get rid of longname handling.
609 (dict_clone_var) Get rid of longname parameter and longname
611 (dict_lookup_var) Get rid of longname handling.
612 (dict_reorder_var) New function.
613 (dict_rename_var) Clear short name.
614 (dict_rename_vars) Get rid of longname handling. Clear short
616 (dict_create_vector) Support long vector names.
617 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
618 (quasi_base27) Removed.
619 (make_short_name) Removed.
620 (compare_strings) New function.
621 (hash_string) New function.
622 (dict_assign_short_names) New function.
624 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
626 (get_handle_for_filename) Support long handle names.
628 * file-type.c: (struct col_spec) Make `name' fit long var names.
629 (cmd_file_type) Use strcasecmp() instead of strcmp().
631 * flip.c: (make_new_var) Rewrite.
632 (flip_sink_write) Use st_trim_copy() instead of strncpy().
634 * format.c: (parse_format_specifier_name) Use mm_case_compare()
637 * get.c: (cmd_save_internal) Rephrase.
638 (rename_variables) Drop test for identical variable name.
639 (struct mtf_proc) Change `first', `last' to fit long var name.
641 * hash.c: (hsh_hash_case_string) New function for case-insensitive
644 * lexer.c: (restore_token) Use st_trim_copy() instead of
646 (lex_get) Don't uppercase string when copying into tokid.
647 (lex_put_back_id) Use st_trim_copy() instead of
650 * list.q: (determine_layout) Consider length of variable names in
651 choosing vertical layout.
653 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
655 (string_to_content_type) Ditto.
657 * modify-vars.c: (compare_variables_given_ordering) Ditto.
658 (struct var_renaming) Change `new_name' to fit long var name.
659 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
662 * pfm-read.c: (read_variables) Disallow system variables in system
664 (write_variables) Call dict_assign_short_names() and use
665 short_name[] members.
667 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
670 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
671 map. Reorder variables into same order as long variable map.
672 (read_variables) Set short name.
674 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
675 (write_variable) Use st_bare_pad_copy().
676 (write_longvar_table) Rewrite.
678 * str.c: (mm_case_compare) New function.
680 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
683 * t-test.q: (tts_custom_groups) Remove redundant test.
684 (tts_custom_pairs) Ditto.
686 * var.h: (struct variable) Change `name' to fit long var names.
687 Remove `longname'. Add `short_name' member. Reorder some
689 (struct name_table_entry) Removed.
690 (struct vector) Change `name' to fit long vector names.
692 * vars-atr.c: (var_is_valid_name) Allow long var names.
693 (compare_var_names) Use strcasecmp() instead of strcmp().
694 (compare_var_ptr_names) Ditto.
695 (hash_var_name) Use hsh_hash_case_string().
696 (hash_var_ptr_name) Ditto.
697 (var_set_short_name) New function.
698 (var_clear_short_name) New function.
699 (var_set_short_name_suffix) New function.
701 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
702 Use strcasecmp() instead of strcmp().
703 (struct array_var_set) Removed `longname_tab'.
704 (array_var_set_lookup_var_idx) Drop longname_tab support.
705 (array_var_set_destroy) Don't destroy `longname_tab'.
706 (var_set_create_from_array) Don't create `longname_tab'.
708 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
711 * expressions/parse.c: (word_matches) Use mm_case_compare()
713 (compare_strings) New function.
714 (lookup_function) Use compare_strings() instead of strcmp().
716 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
718 * algorithm.c: (move_element) New function.
720 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
722 * aggregate.c: (parse_aggregate_functions) Always initialize
725 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
727 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
729 * dictionary.c: (dict_clone) Ditto.
730 (dict_clone_var_assert) New function.
732 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
734 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
736 * error.c: Added a string for the compiler version to the
737 request_bug_report_and_abort function.
739 * groff_font.c, font.c: Removed manpage(1) style references from
740 comments, because RMS frowns upon them.
742 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
744 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
746 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
748 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
751 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
753 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
754 which should be LONG_NAME_LEN
756 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
758 * command.def echo.c: Added the ECHO command.
760 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
762 Finish fixing MATCH FILES (bug 11677).
764 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
765 keep_variables(), rename_variables().
766 (drop_variables) New function.
767 (keep_variables) New function.
768 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
769 (cmd_match_files) Deal with in_var. Use drop_variables(),
770 keep_variables(). When IN is specified, require BY. Set master
771 variables after master dictionary is complete. Add IN variables
772 after master dictionary is complete.
773 (mtf_free_file) Free `in_name'.
774 (mtf_delete_file_in_place) Set in_var value to 0.
775 (mtf_read_nonactive_records) Rephrase.
776 (mtf_processing) Support IN. Rephrase. Fix bugs.
777 (mtf_merge_dictionary) Don't set master variables; we do that
779 (get_master) Don't insist that there's a master variable.
781 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
783 Kluge to make some variable renaming sort of work.
786 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
788 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
790 Add functions for comparing sets of variables between cases.
793 * case.c: (case_compare) New function.
794 (case_compare_2dict) New function.
796 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
798 (cmd_aggregate) Nullify break_case. Don't call
799 initialize_aggregate_info().
800 (agr_destroy) Destroy break_case.
801 (aggregate_single_case) Rewrite. Use case_compare().
802 (dump_aggregate_info) Copy from break_case into output.
803 (initialize_aggregate_info) Copy break_case from input.
805 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
807 * vfm.c: (equal_splits) Use case_compare().
809 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
811 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
813 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
815 Start work on fixing MATCH FILES.
817 * get.c: (enum operation) Remove OP_MATCH.
818 (trim_dictionary) Change return value to bool. Don't support
820 (struct mtf_file) Remove `first', `last' members.
821 (struct mtf_proc) Add `first', `last' members. Change mtf_case
822 from `struct ccase *' to `struct ccase'. Remove `by' member.
823 (cmd_match_files) Essentially rewrite.
824 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
825 (mtf_read_nonactive_records) mtf_ parameter is not unused.
826 (mtf_processing) Ditto. Also rephrase some code.
827 (mtf_merge_dictionary) Rewrite for easy comprehension.
829 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
831 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
834 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
836 Thu Apr 14 2005 John Darrington
838 * var-display.c: New file.
840 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
841 display_width, measure and alignment parameters to variables.
843 * aggregate.c command.def compute.c count.c data-list.c descript.c
844 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
845 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
846 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
847 vars-prs.c vector.c :
848 - Replaced literal constants representing maximum variable name
849 length with macro definitions.
850 - Added support for long variable names.
851 - Changed lexer such that it no longer makes tokens upper
852 case, but relies upon case insensitive behaviour of commands.
854 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
856 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
857 fails, don't dereference the resulting null pointer (bug 12427).
858 Also, fix double free error.
860 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
862 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
863 (accumulate_aggregate_info) Set int1 to 1 for SUM.
864 (dump_aggregate_info) Only make SUM non-missing if there was at
867 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
869 * aggregate.c: (dump_aggregate_info) Properly test whether the
870 destination variable is numeric, when making the result
871 system-missing for columnwise missing values.
873 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
875 * misc.h: Remove GCC specializations.
877 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
879 Make sort stable (bug 12313).
881 * sort.c: Don't need to include some headers anymore.
882 (static var min_buffers) New variable.
883 (static var max_buffers) New variable.
884 (static var allow_internal_sort) New variable.
885 (cmd_sort_cases) Add test mode.
886 (sort_execute) Rephrase.
887 (do_internal_sort) Don't try internal sorting if
888 allow_internal_sort is set.
889 (struct external_sort) Renamed `initial_runs' to `runs' and
890 updated all references.
891 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
892 (macro MIN_BUFFER_SIZE_BYTES) Removed.
893 (macro MIN_BUFFER_SIZE_RECS) Removed.
894 (compare_initial_runs) Removed.
895 (struct record_run) Add member `idx'.
896 (write_initial_runs) Pass increasing values to process_case() as
898 (process_case) Add `idx' parameter and use it to initialize new
900 (allocate_cases) Limit allocated buffers to max_buffers.
901 (compare_record_run) Use new `idx' member for last resort
902 comparison, for stability.
903 (end_run) Call casefile_sleep() on irs->casefile, to prevent
904 running out of file descriptors.
905 (struct merge_state) Removed.
906 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
907 unless we have fewer runs left. Always merge consecutive runs,
908 for stability. Return the final run.
910 (choose_merge) New function.
911 (merge_once) Rewritten.
913 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
915 * cmdline.c: (static var testing_mode) Move into
916 parse_command_line().
918 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
920 * algorithm.c: (remove_range) New function.
921 (remove_element) New function.
923 * dictionary.c: (dict_delete_var) Use remove_element().
925 * flip.c: (cmd_flip) Ditto.
927 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
929 * file-handle.q: (struct file_handle) `open_mode' should not be
932 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
934 First phase of making SORT CASES stable (bug 12313).
936 * sort.c: (struct indexed_case) New structure.
937 (do_internal_sort) Rewrite to make internal sorting stable.
938 (compare_case_dblptrs) Removed.
939 (compare_indexed_cases) New function.
941 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
945 * casefile.c: (casereader_read_xfer_assert) New function.
947 * dictionary.c: (dict_compact_case) New function.
949 * flip.c: (struct flip_pgm) New member idx_to_fv.
950 (cmd_flip) Initialize idx_to_fv member.
951 (destroy_flip_pgm) Free idx_to_fv member.
952 (flip_sink_write) Use struct flip_pgm member instead of case_sink
954 (flip_sink_write) Ditto.
956 * vfm.c: (write_case) Use dict_compact_case() instead of
958 (compact_case) Removed.
959 (storage_source_create) Removed `dict' parameter. All references
962 * vfm.h: (struct case_source) Removed `value_cnt' member. All
964 (struct case_sink) Removed `dict', `idx_to_fv' members. All
967 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
969 More AGGREGATE fixes.
971 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
972 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
974 (initialize_aggregate_info) Fix initialization for MIN, MAX for
977 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
979 Start work on testing and debugging AGGREGATE.
981 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
982 of a bit-map. Require proper subcommand ordering. Make OUTFILE
983 subcommand mandatory.
984 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
985 functions' arguments are in the correct order and swap them if
987 (accumulate_aggregate_info) Make SUM include weights. Add various
989 (dump_aggregate_info) Add various string functions.
990 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
992 * sort.c: (sort_parse_criteria) Add parameter for returning
993 whether any directions were specified. All callers updated.
995 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
997 * t-test.q: Fixed erroneous logic in compare_group_binary.
999 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
1001 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
1002 keywords (bug 11628).
1004 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
1006 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
1007 called *before* close_active_file().
1009 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
1011 * file-handle.q: (struct file_handle) Change open_mode from
1012 character pointer to 3-char array, for safety. Updated all
1015 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
1017 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
1020 * pfm-read.c: (read_header) Improve error message for many cases
1021 in which the input is not actually a portable file.
1023 * file-handle.q: (fh_open) When we give an error message, actually
1026 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
1028 * format.c: (check_common_specifier) New function for checks
1029 common to check_input_specifier() and check_output_specifier().
1030 (check_input_specifier) Use check_common_specifier().
1031 (check_output_specifier) Use check_common_specifier().
1032 (check_string_specifier) Removed.
1033 (check_specifier_type) New function.
1034 (check_specifier_width) New function.
1035 (get_format_var_width) Fix bug.
1037 * formats.c: (internal_cmd_formats) Only accept numeric variables.
1039 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
1040 update all references. Make case-insensitive.
1042 * pfm-read.c: Essentially rewrite the whole file. Now much
1045 * print.c: (check_string_width) New function.
1046 (fixed_parse_compatible) Use check_string_width(),
1047 check_specifier_type().
1048 (dump_fmt_list) Ditto.
1050 * str.c: (st_trim_copy) New function.
1051 (st_uppercase) New function.
1053 * vars-atr.c: (var_is_valid_name) New function.
1055 * expressions/parse.c: (type_coercion_core) Use
1056 check_specifier_type().
1058 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
1060 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
1062 * expressions/parse.c: (no_match) Ditto.
1064 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
1066 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
1068 * expressions/helpers.c: (struct func_params) Removed.
1069 (generalized_idf) Removed.
1072 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
1074 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
1075 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
1076 Implement SIG.F, which I had overlooked previously.
1078 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
1080 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
1081 available only in testing mode.
1083 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
1085 * data-in.c: Use `bool' throughout, where relevant.
1087 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
1089 DATA LIST with free-field formats should not have implied decimal
1090 places (bug 12035). Also clean up data-in.c a bit.
1092 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
1094 * data-in.c: (apply_implied_decimals) New function.
1095 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
1096 set. Also, get rid of gotos.
1097 (parse_Z) Use apply_implied_decimals() if the field doesn't
1098 contain a decimal point.
1099 (parse_N) Use apply_implied_decimals().
1105 (parse_enum) New function.
1106 (macro CHAR_IS_ROMAN) Removed.
1107 (macro ROMAN_VALUE) Removed.
1108 (parse_month) Use parse_enum().
1109 (parse_weekday) Use parse_enum().
1110 (parse_DATETIME) Use long for weekday.
1112 * data-list.c: (read_from_data_list_fixed) Use
1113 DI_IMPLIED_DECIMALS.
1115 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
1117 When the lexer sees something like `-5' in the input, it has to
1118 decide whether it's a negative numeric constant token or a '-'
1119 token followed by a positive numeric constant token. It always
1120 decides on the former, and then the parser can call
1121 lex_negative_to_dash() if it wants the latter. However, this
1122 doesn't work for the case of `-0', because negative zero is
1123 (portably) indistinguishable from positive zero. So now we divide
1124 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
1125 distinction clear. This requires a little bit of extra effort,
1126 because there were several references to T_NUM in the code base.
1128 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
1129 positive and negative numeric constants.
1130 (lex_double_p) Renamed lex_is_number(). Changed return type to
1131 bool. Updated all relevant references to T_NUM to instead use
1133 (lex_double) Renamed lex_number(). All references updated.
1134 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
1135 bool. All references updated.
1136 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
1137 (lex_negative_to_dash) Ditto.
1140 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
1142 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
1144 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
1146 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
1148 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
1149 values as system-missing.
1151 * expressions/parse.c: (parse_vector_element) Fix order of
1152 arguments in call to expr_allocate_binary().
1154 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
1156 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
1159 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
1160 failure, as indicated by function comment.
1161 (parse_binary_operators) Always return NULL on type_coercion()
1162 failure. Should have been doing this anyway, but bug in
1163 type_coercion_core() filtered through.
1164 (parse_add) Fix typo in user message.
1165 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
1167 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
1169 * expressions/operations.def: Add VALUE function.
1171 * expressions/parse.c: (parse_function) Need an unary composite
1172 node for variables in A TO B, not a variable node. Use
1173 allocate_unary_variable().
1174 (parse_primary) Use allocate_unary_variable().
1175 (allocate_unary_variable) New function.
1177 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
1179 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
1180 but fixed the real problem that was preventing the build from a
1181 separate directory. I liked it my way better ;-)
1183 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
1185 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
1186 John Darrington <john@darrington.wattle.id.au> for reporting this
1189 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
1191 * expressions/Makefile.am expressions/evaluate.h.pl
1192 expressions/evaluate.inc.pl expressions/operations.h.pl
1193 expressions/optimize.inc.pl expressions/parse.inc.p:
1195 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
1198 Fixed everything so that it can be built from an arbitrary
1201 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1203 * Makefile.am : Fixed up CLEANFILES target.
1205 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
1207 * str.h: Changed `struct len_string' to `struct fixed_string', a
1208 more accurate name. Updated all references.
1210 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
1212 Redo calendar support. Should now be bug-for-bug compatible.
1214 * calendar.c: New file.
1216 * calendar.h: New file.
1218 * data-in.c: Use new calendar functions.
1219 (parse_sign) Change sense of return value.
1220 (calendar_error) New function.
1221 (ymd_to_ofs) New function.
1222 (ymd_to_date) New function.
1223 (parse_DATE) Use new function.
1224 (parse_ADATE) Ditto.
1225 (parse_EDATE) Ditto.
1226 (parse_SDATE) Ditto.
1227 (parse_JDATE) Ditto.
1232 (parse_DTIME) Ditto.
1233 (parse_DATETIME) Ditto.
1235 * data-out.c: (convert_date) Use new calendar functions.
1237 * error.c: (err_vmsg) Changed interface to be more sensible.
1238 Updated all callers.
1239 (dump_message) Don't double new-lines (why did we do this
1242 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
1244 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
1245 (macro FLT64_MAX) Moved here from pref.h.orig.
1247 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
1249 * set.q: Support SET EPOCH.
1250 (static var set_epoch) New var.
1251 (aux_stc_custom_epoch) New function.
1252 (stc_custom_epoch) New function.
1253 (get_epoch) New function.
1254 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
1256 * format.c: Make it possible just to check whether a specifier is
1257 valid without emitting an error message.
1258 (parse_format_specifier_name) Change interface, update all
1260 (check_input_specifier) Ditto.
1261 (check_output_specifier) Ditto.
1262 (parse_format_specifier) Ditto.
1264 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
1266 * command.def: Add DEBUG POOL.
1268 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
1270 (pool_clear) Properly account for size of pool gizmo.
1271 (pool_realloc) Ditto.
1272 (pool_clone) New function.
1274 * pool.h: Mark our allocation functions MALLOC_LIKE.
1276 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
1278 * Makefile.am: Move many definitions into new top-level
1279 Make.build. Add expressions to SUBDIRS. Add calendar.c,
1280 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
1283 * case.c: (case_resize) New function.
1284 (case_swap) New function.
1286 * casefile.c: Include mkfile.h.
1288 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1290 * sfm-read.c: Fixed a buglet which caused a crash when trying
1291 to read a non-existent file.
1293 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
1297 * aggregate.c: (parse_aggregate_functions) Code cleanup.
1298 Important part: get rid of spurious copying of function->format to
1299 destvar->print and destvar->write.
1301 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
1303 Fix bug 11916, which was confusing a variable's `index' member
1304 with the variable's position in a var_set. Although these are
1305 usually the same, they are not for array `var_set's.
1307 Took advantage of this bug as an opportunity to clean up and
1308 rewrite parse_var_set_vars().
1310 * vars-prs.c: (parse_vs_variable_idx) New function.
1311 (parse_vs_variable) Reimplement in terms of
1312 parse_vs_variable_idx().
1313 (parse_var_idx_class) New function.
1314 (add_variable) New function.
1315 (add_variables) New function.
1316 (parse_var_set_vars) Rewritten.
1317 (struct var_set) Change `lookup_var' member that returns a
1318 variable into `lookup_var_idx' member that returns an int.
1319 Updated the var set implementations in obvious corresponding ways.
1320 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
1322 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
1324 Use our global variable compare & hash functions and give them
1325 better names. Add similar functions for dealing with double
1326 pointers to variables.
1328 * vars-atr.c: (compare_variables) Renamed compare_var_names().
1329 (hash_variable) Renamed hash_var_name().
1330 (compare_var_ptr_names) New function.
1331 (hash_var_ptr_name) New function.
1333 * t-test.q: (cmd_t_test) Use global compare_var_names(),
1335 (compare_var_name) Removed.
1336 (hash_var_name) Removed.
1338 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
1342 * dictionary.c: (compare_variable_dblptrs) Rename
1343 compare_var_ptrs() and fix it to properly dereference the double
1346 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
1348 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
1349 declare subcommands as mandatory. Closed bug #11843
1351 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
1353 * getline.c command.[ch] command.def: Added (very rudimentary)
1354 support for line completion when in interactive mode. Partially
1355 addresses bug #11693
1357 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1359 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
1360 problems revealed by valgrind.
1363 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1365 * set.q: Affixed a fix to the previous fix such that we'll be OK now
1366 whether or not PAGER is set.
1368 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1370 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
1371 "invalid free" errors. Hopefully fixes bug #11722
1373 * compute.c expr-prs.c: Check that lvalues are populated before
1374 attempting to destroy them. Closes bug #11676
1376 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1378 * aggregate.c: Initialised the complete agr_proc structure.
1382 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
1384 * print.c: (print_trns_free) Close the dfm writer if there is one,
1385 fixing a memory leak.
1387 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
1389 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
1393 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
1395 * linked-list.[ch] Added
1397 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
1398 set.q: Yet more memory leaks
1400 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
1402 * t-test.q examine.q : More memory leaks fixed.
1404 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
1406 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
1409 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1411 * ascii.c cartesian.c casefile.c chart.h devind.c
1412 examine.q frequencies.q
1413 html.c output.h piechart.c plot-chart.c plot-hist.c
1415 Integrated the chart rendering into the output stream
1416 (currently only works for html).
1418 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
1419 dummy-chart.c for compiling without charts.
1421 * mkfile.[ch] Created.
1423 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
1424 Added type element so we can tell if it's a chart or a table.
1426 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
1427 API of charts to be more like that of tables.
1429 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1431 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
1432 main.c. Removed the handler for SIGQUIT.
1434 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1436 * casefile.c: Added a signal handler to delete temp files on
1439 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
1441 * command.def Added a lot more unimplemented commands.
1443 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
1445 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
1447 * sort.c: (compare_initial_runs) Needed additional level of
1449 (merge_once) Fix plenty of stupid mistakes.
1451 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
1453 * casefile.c: (casefile_sleep) Need to flush_buffer() after
1454 calling casefile_to_disk() or we will lose the last block in the
1455 file if the casefile started out as disk-based.
1456 (casefile_get_reader) Initialize reader->destructive to 0.
1457 (cmd_debug_casefile) Add new test pattern.
1458 (test_casefile) Define new test pattern to make sure
1459 casefile_sleep() works properly.
1461 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
1463 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
1464 plot-hist.c plot-chart.c (Added) Reorganised these files in an
1465 attempt to seperate the creation and processing of charts from their
1468 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
1471 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
1473 * main.c Added a signal handler for SIGFPE
1475 * sort.c Somewhat more robust fix to the previous entry.
1477 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
1479 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
1480 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
1481 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
1484 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1486 * case.h Fixed bug # 11307
1488 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1490 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
1493 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
1495 * pfm-read.c: (read_variables) Remove direct manipulation of
1496 v->aux, which is no longer needed. Fixes bug 11483.
1498 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
1500 * data-list.c Fixed a bug in parsing delimiters.
1502 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
1505 * percentiles.c Properly handled calculation of Tukey hinges where
1506 the number of data is small.
1508 * oneway.q Used the generic value_to_string function for independent
1509 variable instead of trying to do it ourselves.
1511 * box-whisker.c Fixed a buglet which caused a crash if the number of
1515 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1517 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
1519 * percentiles.c Fixed some bugs when calculating percentiles when
1520 there's a small number of cases.
1522 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
1524 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
1526 * examine.q factor_stats.[ch] Added calculation of percentiles
1528 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1530 * t-test.q Fixed bug #11227 Made t-test work when the independent
1533 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1535 * factor_stats.c Fixed calculation of trimmed mean under various
1538 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1540 * histogram.c chart.[ch] factor_stats.c frequencies.q
1542 Added code to calculate sensible histogram ranges and limits.
1544 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
1546 * chart.h Updated to reflect many API changes.
1548 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
1549 cartesian.c and into chart.c
1551 * factorstats.[ch] Added the histogram calculations
1553 * casefile.c Removed an unused variable.
1555 * frequencies.q examine.q histogram.c Reworked the API for
1558 * piechart.c Revised the API for piecharts.
1560 * var.h Moved the definitions of freq_tab and freq out of var.h
1561 and into frequencies.q where they belong.
1563 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
1565 * flip.c: (flip_file) Check for off_t separately from fseeko(),
1566 using AC_TYPE_OFF_T.
1568 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
1570 * flip.c: (flip_file) If fseeko() is not available, use long int
1571 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
1572 reporting the problem.
1574 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
1576 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
1577 conflict with stdio.
1579 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
1581 * var-labs.c (var_to_string) Now returns null if the variable is null
1583 * value-labels.c (value_to_string) Made it return null if either the
1584 value or the variable is null.
1586 * hash.c (hsh_clear) Fixed a buglet.
1588 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
1589 with the wrong model.
1591 * casefile.[ch] Added a function to return the casereader.case_idx
1594 * examine.q Implemented the extreme values results.
1596 John Darrington <john@darrington.wattle.id.au>
1598 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
1599 output.[ch] getline.c
1601 Plugged some memory leaks
1603 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
1605 Adopt GSL random number generators, paving the way for providing
1606 the complete suite of random number generators on expressions.
1608 * Makefile.am: Remove random.c, random.h.
1610 * random.c: Removed.
1612 * random.h: Removed.
1614 * algorithm.c: (algo_default_random) Use GSL functions.
1616 * casefile.c: (test_casefile) Use GSL RNG functions.
1618 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
1621 * sample.c: (cmd_sample) Use GSL RNG functions.
1622 (sample_trns_proc) Ditto.
1624 * set.q: (static var set_seed) Removed.
1625 (static var seed_flag) Removed.
1626 (static var rng) New variable.
1627 (aux_stc_custom_seed) No seed value anymore, don't print anything.
1628 (stc_custom_seed) Use new seed functions.
1629 (seed_is_set) Removed.
1630 (get_rng) New function that composes the entire external
1632 (set_rng) New function.
1633 (random_seed) New function.
1635 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
1637 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
1638 John Darrington <john@darrington.wattle.id.au> for reporting this
1641 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1643 * permissions.c command.def Added the PERMISSIONS command
1645 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
1647 * q2c.c: (dump_header) Don't try to emit #includes at very top of
1648 output file because that will precede #include <config.h>, which
1650 (main) Add needed headers to /* (header) */ code.
1652 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
1654 Instead of making system or portable file readers responsible for
1655 dropping and reordering variables, make them read full cases and
1656 let the caller take care of any changes.
1658 * get.c: New "case map" structure to handle this. Use for GET,
1659 IMPORT, MATCH FILES. Essentially rewrite the whole file.
1661 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
1662 changed appropriately.
1664 * sfm-read.c: (sfm_read_case) Ditto.
1666 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
1668 Decided that case_serialize() and case_unserialize() were too
1669 abstract. Also we need a couple more functions to avoid excessive
1670 copying for data in/out fast paths.
1672 * case.c: (case_serial_size) Removed.
1673 (case_serialize) Rename case_to_values() and make its argument
1674 explicitly an array of union values.
1675 (case_unserialize) Rename case_from_values() and make its argument
1676 explicitly an array of union values.
1677 (case_data_all) New function.
1678 (case_data_all_rw) New function.
1680 * casefile.c: (struct casefile) Change buffer from array of
1681 unsigned char to array of union value for better accuracy.
1682 Redefine buffer_used and buffer_size in terms of values, not
1683 bytes. Remove case_size because it is now redundant with
1684 value_cnt. Fix up all references to these members.
1686 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
1688 * barchart.c: (struct subcat) Make `label' member const to silence
1689 GCC warning with -Wwrite-strings.
1691 * cartesian.c: (struct dataset) Ditto.
1693 * case.c: Don't re-define NDEBUG if already defined.
1694 Add lots of comments.
1696 * str.c: Fix includes.
1698 * crosstabs.q: Fix includes.
1700 * examine.q: Fix includes. Fix GCC warning about unused
1703 * frequencies.q: (stat macro) Removed and replaced where used by
1706 * list.q: Fix includes.
1708 * oneway.q: Fix includes.
1710 * piechart.c: Fix includes. Only define M_PI if not already
1713 * sfm-read.c: (bswap) New function.
1714 (bswap_int32) Write in terms of bswap.
1715 (bswap_flt64) Ditto.
1717 * str.c: (ds_data) Add external definition here, needed because
1718 str.h has only an `extern inline' version.
1720 * value-labels.c: Fix includes.
1722 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
1724 Instead of providing a system or portable file writer with a raw
1725 case in the format needed for output, provide it with a regular
1726 case. The writer takes care of any needed translation.
1728 * aggregate.c: Adopt new scheme for AGGREGATE.
1729 (struct agr_proc) sfm_agr_case member removed.
1730 (write_case_to_sfm) Removed because the new interface is easier to
1733 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
1735 * pfm-write.c: Implement new scheme.
1737 * sfm-write.c: Ditto.
1739 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
1741 Instead of treating `struct file_handle' as a class to subclass
1742 into data files, system files, and portable files, instead use it
1743 as a helper that coordinates access. Now it is opaque, too.
1745 This means that most references to a struct file_handle are now
1746 changed into references to one of struct dfm_reader, struct
1747 dfm_writer, struct sfm_reader, struct sfm_writer, struct
1748 pfm_reader, or struct pfm_writer, according to what's being read
1751 Most related changes are only worth summarizing briefly.
1753 * dictionary.c: (dict_clear) Destroy aux data in deleted
1755 (dict_clear_aux) New function.
1756 (dict_create_var) Initialize aux, aux_dtor.
1757 (dict_delete_var) Destroy aux data in deleted variable.
1759 * file-handle.h: (struct fh_ext_class) Removed.
1760 (struct file_handle) Removed.
1761 (fh_init_files) Removed.
1763 * file-handle.q: Changed references to a handle's `private' member
1764 to direct references.
1765 (struct private_file_handle) Renamed file_handle.
1766 Add next, open_cnt, type, open_mode, aux members.
1767 (struct file_handle_list) Removed.
1768 (extern var inline_file) Removed.
1769 (static var file_handles) Changed from file_handle_list * to
1771 (create_file_handle) Initialize new members.
1772 (fh_close_handle) Removed.
1773 (mode_name) New function.
1774 (fh_open) New function.
1775 (fh_close) New function.
1776 (fh_parse_file_handle) Renamed fh_parse().
1778 * glob.c: (init_glob) Remove fh_init_files() call.
1780 * aggregate.c: use sfm_writer.
1781 (create_sysfile) Removed because the new interface is simpler.
1783 * apply-dict.c: Use sfm_reader.
1785 * data-list.c: Use dfm_reader.
1787 * file-type.c: Use dfm_reader.
1789 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
1791 * inpt-pgm.c: Use dfm_reader.
1793 * print.c: Use dfm_writer.
1795 * sysfile-info: Use sfm_reader.
1797 * dfm-read.c: Adopt new file handle infrastructure.
1799 * dfm-write.c: Ditto.
1801 * pfm-read.c: Ditto.
1803 * pfm-write.c: Ditto.
1805 * sfm-read.c: Ditto.
1807 * sfm-write.c: Ditto.
1809 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
1811 Break dictionary functions into separate header file.
1813 * dictionary.h: New file.
1815 * var.h: Moved dict_*() functions to dictionary.h.
1817 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
1819 Get rid of procedure-specific union in struct variable, using
1820 instead a void * pointer and a destructor function.
1822 Most related changes are only worth brief summaries.
1824 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
1825 old p.crs member in struct variable.
1827 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
1828 of old p.frq member in struct variable.
1830 * histogram.c: (draw_histogram) Takes new freq_tab arg because
1831 it's no longer possible to grab this from var->p.frq.
1833 * piechart.c: (draw_piechart) Ditto.
1835 * group.c: (group_proc_get) New function.
1837 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
1844 * main.c: (execute_command) Clear aux data in default_dict after
1845 each command. (It's debatable whether this should be done.)
1847 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
1848 member in struct variable.
1850 * means.q: Get rid of integer mode, which is not included in
1851 recent SPSS and was the only code that wanted per-variable private
1854 * var.h: (struct crosstab_proc) Removed.
1855 (struct frequencies_proc) Removed.
1856 (struct list_proc) Removed.
1857 (struct get_proc) Removed.
1858 (struct means_proc) Removed.
1859 (struct matrix_data_proc) Removed.
1860 (struct match_files_proc) Removed.
1861 (lots of enums) Removed.
1862 (struct variable) Removed members `p', `get'. Add member
1865 * vars-atr.c: (var_attach_aux) New function.
1866 (var_detach_aux) New function.
1867 (var_clear_aux) New function.
1868 (var_dtor_free) New function.
1869 (discard_variables) Use NULL instead of inline_file.
1871 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1873 * value-labs.c Fixed the implmentation of value_to_string, so
1874 that it properly handles alpha values.
1876 * oneway.q Changed instances where labels were being probed manually,
1877 to use the canonical {var,value}_to_string functions
1879 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1881 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
1882 plots. Changed the API of the cartesian plot to be a much lower level
1885 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
1887 * examine.q Added some of the parametric calculations
1889 * factor_stats.[ch] Created
1891 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1893 * examine.q Changed the definition of factors to be a composite, and
1894 dealt with the consequences.
1896 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
1898 * examine.q Fixed problem where examine wasn't dealing properly with
1901 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
1903 * oneway.q Fixed problem where oneway wasn't dealing properly with
1906 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
1908 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
1909 command which had settings didn't get the appropriate code
1912 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
1913 to convert variables/values to strings.
1915 * examine.q Added framework for the EXAMINE command.
1917 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
1919 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
1920 subcommand types. Changed frequencies.q to use it rather then the
1921 custom parser. Dealt with the consequences. Added a test for NTILES
1922 subcommand of frequencies.
1924 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
1926 * oneway.q Fixed up the behaviour when given missing values
1928 * levene.c oneway.q Fixed a buglet with the levene statistic and
1929 incorporated the levene test into the oneway command.
1931 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
1932 global scope, since they're only relevant to T-TEST
1934 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
1936 * group.c group.h group_proc.h levene.c oneway.q t-test.q
1938 Made the t-test more consistent
1939 with the way it handles groups. That is, it now uses a hash instead
1940 of an array of 2. Also, made the levene.c file independent of the
1941 implementation of the t-test. So now levene should be fine for both
1944 * Added an oneway.q file for one way anova
1946 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
1948 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
1951 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
1955 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
1956 (data_list_trns_free) Free dls->delims.
1958 * t-test.q: (tts_custom_pairs) Free vars.
1959 (ssbox_one_sample_init) Fix tab_vline() argument.
1960 (ssbox_independent_samples_init) Ditto.
1961 (trbox_paired_init) Ditto.
1962 (trbox_one_sample_init) Ditto.
1964 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
1966 Generalize casefiles to the extent that we can use them for
1967 sorting and other kinds of data transformations. Change cases to
1968 be copy-on-write to improve memory efficiency in common cases.
1969 Every access to a member of a `struct ccase' was changed to be a
1970 call to a case_*() function, especially case_data(), case_num(),
1971 case_str(), or case_data_rw(). Many instances of a local variable
1972 named "case_num" were changed to "case_idx" as a consequence.
1973 Many `struct ccase *' were changed to actual `struct ccase'
1974 because of copying semantics of cases. In several places there
1975 was a choice between updating debug code to work with the new ADTs
1976 or just deleting it because it was useless; I chose to delete it.
1978 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
1984 * aggregate.c: (struct agr_proc) Change type of `sort' to
1985 sort_criteria *. Add `break_vars', `break_var_cnt' members.
1986 Rename `vars' to `agr_vars', all references updated. Change
1987 `agr_case' to type `struct ccase'.
1988 (cmd_aggregate) Deal with new members. Use case_create(),
1989 sort_active_file_in_place(), sort_active_file_to_casefile().
1990 (agr_destroy) Deal with new members.
1991 (aggregate_single_case) Ditto.
1992 (dump_aggregate_info) Ditto.
1993 (initialize_aggregate_info) Ditto.
1994 (agr_to_active_file) Ditto.
1995 (presorted_agr_to_sysfile) Ditto.
1996 (sort_agr_to_sysfile) Removed.
1998 * alloc.c: (out_of_memory) Make non-static.
2000 * alloc.h: Prototype out_of_memory().
2002 * casefile.c: Switched from a linked list in-memory representation
2003 to a two-level array-style representation. The linked list was
2004 appropriate when we could stick a header onto cases, but that's no
2005 longer the case. Also, the two-level array will allow for random
2006 in-memory access in case that's ever wanted. Also added the
2007 concept of a `destructive casereader', one that destroys cases in
2008 the underlying casefile as they are read out.
2009 (macro CASES_PER_BLOCK) New macro.
2010 (struct casefile) New members `value_cnt', `case_list_size',
2011 `case_acct_size', `being_destroyed', `cases'. Removed `head',
2013 (struct casereader) Removed `cur'. Added `destructive', `c'.
2014 (global var casefiles) Made static.
2015 (static var case_bytes) New var.
2016 (casefile_create) Takes a value count, not a case size in bytes,
2017 to conform to the case interface. All callers updated. Deal with
2018 new and removed members.
2019 (casefile_destroy) Deal with new and removed members.
2020 (casefile_sleep) New function.
2021 (casefile_get_case_size) Removed.
2022 (casefile_get_value_cnt) New function.
2023 (casefile_append) Rewritten to deal with new and removed members.
2024 (casefile_append_xfer) New function.
2025 (write_case_to_disk) Use case_serialize().
2026 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
2027 Couldn't figure out why.
2028 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
2029 deal with new and removed members.
2031 (merge_sort) Removed.
2032 (casefile_sort) Removed.
2033 (casefile_get_reader) Deal with new and removed members.
2034 (casefile_get_destructive_reader) New function.
2035 (reader_open_file) Make code more readable. Create case for
2037 (casereader_get_casefile) New function.
2038 (casereader_read) Deal with new and removed members. Now returns
2039 a copy of the case, so that the caller is responsible for
2040 destroying the returned case.
2041 (casereader_read_xfer) New function.
2042 (casereader_destroy) Destroy reader's case.
2043 (test_casefile) Second arg is now a value count, all callers
2044 updated. Now tests destructive readers too.
2045 (get_random_case) Deal with new case ADT.
2046 (write_random_case) Ditto.
2047 (read_and_verify_random_case) Ditto.
2049 * crosstabs.q: Remove debug code.
2051 * descript.q: (calc_descriptives) Deal with new case, casefile
2054 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
2056 * do-if.c: Remove unneeded header inclusion.
2058 * expr-prs.c: Remove debug code.
2060 * exprP.h: Remove debug code.
2062 * flip.c: (flip_file) Use fseeko() if available.
2064 * formats.c: Remove debug code.
2066 * get.c: Remove debug code.
2067 (struct mtf_file) Change `input' from `union value *' to `struct
2068 ccase', all references updated.
2070 * levene.c: (levene) Deal with new case, casefile ADTs.
2072 * list.q: Remove debug code.
2074 * loop.c: Remove debug code.
2076 * matrix-data.c: Remove debug code.
2078 * means.q: Remove debug code.
2080 * mis-val.c: Remove debug code.
2082 * pfm-read.c: Remove debug code.
2083 (pfm_read_code) Change second arg from `union value *' to `struct
2084 ccase *', all references updated.
2086 * recode.c: (string_to_long) Make first arg const.
2087 (convert_to_double) Ditto.
2089 * repeat.c: Remove debug code.
2091 * sample.c: Remove debug code.
2093 * sfm-read.c: Remove debug code.
2094 (sfm_read_case) Change second arg from `union value *' to `struct
2097 * sort.c: Redone in terms of casefiles.
2098 (enum sort_direction) Moved here from sort.h.
2099 (struct sort_criterion) New structure.
2100 (struct sort_criteria) New structure.
2101 (cmd_sort_cases) Rewritten.
2102 (prepare_to_sort_active_file) New function.
2103 (sort_active_file_in_place) New function.
2104 (sort_active_file_to_casefile) New function.
2105 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
2106 changed, all callers updated.
2107 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
2108 rewritten & interface changed, all callers updated.
2109 (sort_cases) Renamed sort_execute(), rewritten & interface
2110 changed, all callers updated.
2111 (struct internal_sort) Removed.
2112 (do_internal_sort) Rewritten, interface changed.
2113 (destroy_internal_sort) Removed.
2114 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
2115 (struct initial_run) Removed; an initial run is now just a
2117 (compare_initial_runs) Rewritten.
2118 (struct external_sort) Changed almost completely.
2119 (do_external_sort) Rewritten, interface changed.
2120 (destroy_external_sort) Rewritten.
2121 [HAVE_MKDTEMP] (make_temp_dir) Removed.
2122 [!HAVE_MKDTEMP] (do_mkdir) Removed.
2123 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
2124 (init_external_sort) Removed.
2125 (simulate_error) Removed.
2126 (rmdir_temp_dir) Removed.
2127 (get_temp_file_name) Removed.
2128 (open_temp_file) Removed.
2129 (close_temp_file) Removed.
2130 (remove_temp_file) Removed.
2131 (write_temp_file) Removed.
2132 (read_temp_file) Removed.
2133 (struct record_run) Change `record' from `struct case_lit *' to
2135 (struct initial_run_state) Remove `idx_to_fv', `free_list',
2136 `file_idx', `output_file'. Add `run', casefile'. Change
2137 `last_output' from `struct case_list *' to `struct ccase'.
2138 (write_initial_runs) Change interface, rewrite.
2139 (sort_sink_write) Renamed process_case(), changed interfaced,
2141 (destroy_initial_run_state) Rewritten.
2142 (allocate_cases) Rewritten.
2143 (compare_record) Interface changed, rewritten.
2144 (start_run) Rewritten.
2145 (end_run) Rewritten.
2146 (output_record) Rewritten.
2147 (grab_case) Removed.
2148 (release_case) Removed.
2149 (struct merge_case) Change `cases' from double pointer to single
2151 (merge) Deal with new case and casefile ADTs.
2152 (struct run) Removed.
2153 (merge_once) Rewritten, interface changed.
2154 (fill_run_buffer) Removed.
2155 (sort_sink_make_source) Removed.
2156 (sort_sink_class) Removed.
2157 (struct sort_source_aux) Removed.
2158 (sort_source_read_helper) Removed.
2159 (sort_source_read) Removed.
2160 (read_sort_output) Removed.
2161 (read_internal_sort_output) Removed.
2162 (read_external_sort_output) Removed.
2163 (sort_source_destroy) Removed.
2164 (sort_source_class) Removed.
2166 * sort.h: (struct sort_cases_pgm) Removed.
2167 (enum sort_direction) Moved to sort.c.
2169 * t-test.q: (calculate) Deal with new case, casefile ADTs.
2171 * tab.c: Remove debug code.
2173 * var-labs.c: Remove debug code.
2175 * var.h: (struct ccase) Removed.
2176 (struct case_list) Removed.
2178 * vars-atr.c: (discard_variables) Use free_case_source().
2180 * vars-prs.c: (parse_vs_variable) Make arg const.
2181 (parse_dict_variable) Ditto.
2182 (parse_variables) Make struct dictionary * arg const.
2183 (parse_var_set_vars) Make struct var_set * arg const.
2184 (struct var_set) Add const to some of the function pointers' args.
2185 (var_set_get_cnt) Make arg const.
2186 (var_set_get_var) Make first arg const.
2187 (var_set_lookup_var) Make first arg const.
2188 (dict_var_set_get_cnt) Make arg const.
2189 (dict_var_set_get_var) Make first arg const.
2190 (dict_var_set_lookup_var) Make first arg const.
2191 (var_set_create_from_dict) Make arg const. Add cast to aux
2193 (struct array_var_set) Add const to var member.
2194 (array_var_set_get_cnt) Make arg const.
2195 (array_var_set_get_var) Make first arg const.
2196 (array_var_set_lookup_var) Make first arg const.
2197 (var_set_create_from_array) Make first arg const. Insert cast.
2199 * vfm.c: (struct write_case_data) Change trns_case, sink_case
2200 members from `struct ccase *' to `struct ccase'.
2201 (static var lag_queue) Change from double to single pointer.
2202 (procedure) Optimize trivial case.
2203 (internal_procedure) Deal with changed case, case_source ADTs.
2204 (create_trns_case) Changed interface, rewrote.
2205 (open_active_interface) Initialize modified lag queue.
2206 (write_case) Deal with changed case ADT.
2207 (lag_case) Deal with modified lag queue.
2208 (close_active_file) Destroy modified lag queue.
2209 Deal with changed case_source, case_sink ADTs.
2210 (destroy_storage_stream_info) Make null arg into no-op.
2211 (storage_sink_make_source) Set aux in created source.
2212 (storage_source_read) Deal with changed case, casefile ADTs.
2213 (storage_source_create) New function.
2214 (lagged_case) Rewrite.
2215 (free_case_source) New function.
2216 (free_case_sink) Rewrite.
2217 (struct split_aux_data) Changed prev_case from `struct ccase *' to
2219 (procedure_with_splits) Deal with changed prev_case.
2220 (procedure_with_splits_callback) Ditto.
2221 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
2223 (multipass_procedure_with_splits) Deal with changed prev_case.
2224 (multipass_split_callback) Ditto.
2227 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
2229 The workspace idea didn't work out.
2231 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
2233 * workspace.c: Removed.
2235 * workspace.h: Removed.
2237 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
2239 Fully implement arbitrary delimiters on DATA LIST, extending the
2240 half implementation that was already there.
2242 * data-list.c: (struct data_list_pgm) Remove `delim', add
2243 `delims', `delim_cnt'.
2244 (cmd_data_list) Initialize new members. Parse delimiters and
2245 clean up code a bit.
2246 (cut_field) Extract fields with arbitrary delimiters. Also, fix
2247 handling of leading commas.
2248 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
2250 (read_from_data_list_free) Adapt to new DFM interfaces.
2251 (read_from_data_list_list) Ditto.
2252 (repeating_data_trns_proc) Ditto.
2254 * dfm.c: Split up reader and writer into separate code, because
2255 they do different things. Use struct string instead of explicit
2256 allocation code, for clarity.
2257 (enum dfm_reader_flags) New enum.
2258 (struct dfm_fhuser_ext) Removed.
2259 (struct dfm_reader_ext) New.
2260 (get_reader) New function, used by just about all the reader
2262 (dfm_close) Removed.
2263 (close_reader) New function.
2264 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
2265 (dfm_open_for_writing) Ditto.
2266 (macro force_line_buffer_expansion) Removed.
2267 (count_tabs) Removed.
2268 (tabs_to_spaces) Removed.
2269 (read_record) Deal with new dfm_reader_ext. Use struct string
2270 functions. Don't convert tabs to spaces.
2271 (dfm_eof) New function.
2272 (dfm_get_record) Changed interface, rewrote.
2273 (dfm_expand_tabs) New function.
2274 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
2275 dfm_reader_ext, rewritten.
2276 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
2277 dfm_reader_ext, rewritten.
2278 (dfm_set_record) Removed in favor of dfm_forward_columns().
2279 (dfm_forward_columns) New function.
2280 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
2281 dfm_reader_ext, rewritten.
2282 (static var dfm_r_class) Use close_reader for the destructor.
2283 (struct dfm_writer_ext) New.
2284 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
2285 bounce buffer now instead of local allocation.
2286 (close_writer) New function.
2287 (static var dfm_writer_ext) Use close_writer for destructor.
2288 (cmd_begin_data) Adapt to new dfm_reader_ext.
2290 * file-handle.q: Add support for per-file tab width.
2291 (struct private_file_handle) Add tab_width member.
2292 (q2c specifications) Add tabwidth subcommand.
2293 (cmd_file_handle) Put parsed tab width into private_file_handle.
2294 (create_file_handle) Set default tab width.
2295 (handle_get_tab_width) New function.
2297 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
2299 * inpt-pgm.c: (reread_trns_proc) Ditto.
2301 * matrix-data.c: (context) Ditto.
2302 (another_token) Ditto.
2306 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
2308 * casefile.c: (casefile_destroy) Fix memory leak by freeing
2310 (casereader_destroy) Don't close file descriptor -1.
2312 * recode.c: (cmd_recode) Fix memory leak.
2314 * set.q: (q2c specifications) Fix typo in user message.
2316 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
2317 undefined behavior for overlapping arguments.
2319 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
2321 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
2322 don't call it when we're running under valgrind.
2323 (call_posix_fadvise) New function.
2324 (casefile_to_disk) Use call_posix_fadvise().
2325 (reader_open_file) Ditto.
2327 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
2329 Update our string ADTs, struct string and struct len_string. Get
2330 rid of pool support, which was largely unused. Rename lots of
2331 functions to have more obvious or consistent names.
2333 * ascii.c: Get rid of ascii_pool. It was only used for string
2335 (ascii_open_global) Don't create ascii_pool.
2336 (ascii_close_driver) Don't destroy ascii_pool.
2337 (ascii_postopen_driver) Don't use pool.
2338 (ascii_close_driver) Destroy strings manually.
2340 * str.c: (ds_create) Remove pool argument, all references updated.
2342 (ds_replace) Remove pool support, make more efficient when we
2343 don't need to reallocate.
2344 (ds_destroy) Remove pool support.
2345 (ds_rpad) New function.
2346 (ds_size) Renamed ds_capacity(), all references updated.
2347 (ds_value) Renamed ds_c_str(), all references updated.
2348 (ds_concat) Renamed ds_puts(), all references updated.
2349 (ds_concat_buffer) Renamed ds_concat(), all references updated.
2350 (ds_putchar) Renamed ds_putc(), all references updated.
2351 (ds_getline) Renamed ds_gets(), all references updated.
2352 (ls_create) Remove pool argument, all references updated.
2353 (ls_create_buffer) Ditto.
2354 (ls_destroy) Removed pool support.
2355 (ls_value) Renamed ls_c_str(), all references updated.
2357 * str.h: (ls_length) [__GNUC__] Add inline version.
2358 (ls_c_str) [__GNUC__] Add inline version.
2359 (ls_end) [__GNUC__] Add inline version.
2360 (struct string) Remove pool member. Rename `size' to `capacity',
2361 all references updated.
2363 * tab.c: (text_format) Instead of using pool argument to
2364 ls_create_buffer(), call pool_register() on allocated data.
2366 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
2368 We're abusing the current ASCII driver by telling it to allocate a
2369 9999-line, 9999-character page in the tests. This causes some
2370 systems to curl up and die because it allocates 20 MB of
2371 contiguous RAM. This change alleviates at least part of the
2372 problem. It is mostly a stop-gap until the new output system is
2375 * ascii.c: (struct line) New structure.
2376 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
2377 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
2378 (ascii_preopen_driver) Initialize new members, not old ones.
2379 (ascii_close_driver) Destroy new members, not old ones.
2380 (ascii_open_page) Allocate new members, not old ones.
2381 (expand_line) Allocate room in line.
2382 (draw_line) Use new members.
2383 (ascii_line_horz) Ditto.
2384 (ascii_line_vert) Ditto.
2385 (ascii_line_intersection) Ditto.
2387 (output_lines) Ditto.
2388 (ascii_close_page) Ditto.
2390 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
2392 * matrix.c: Dead code. Removed.
2394 * matrix.h: Dead code. Removed.
2396 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
2398 Contrary to what I'd always understood, there is an efficient
2399 algorithm for deletion from a hash table populated via linear
2400 probing. This change implements it.
2402 * hash.c: (hsh_rehash) Probe in increasing order.
2404 (locate_matching_entry) Ditto.
2405 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
2407 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
2409 * moments.c (calc_moments): Adjust calculation of kurtosis to
2410 avoid subtracting huge numbers from huge numbers, on Michael
2413 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
2415 Rework moments routines for improved numerical stability based on
2416 Michael Kiefte's advice. Any bugs or remaining numerical problems
2417 are still mine though.
2419 There is now a struct moments1 for use with one-pass moments. It
2420 uses a provisional means algorithm as an attempt to improve
2421 accuracy of higher moments. The older struct moments now only
2422 handles two-pass moments.
2424 * aggregate.c: Use moments1 instead moments.
2426 * descript.c: Revert previous change, which is no longer needed
2427 due to the moments revision.
2429 * moments.c: (calc_moments) New function for calculating variance,
2431 (moments_pass_one) Only accumulate weights bigger than zero.
2432 (moments_calculate) Allow calculating the mean on pass one, others
2433 require pass two. Implement in terms of calc_moments().
2434 (struct moments1) New structure.
2435 (init_moments1) New function.
2436 (moments1_clear) Ditto.
2437 (moments1_create) Ditto.
2438 (moments1_add) Ditto.
2439 (moments1_calculate) Ditto.
2440 (moments1_destroy) Ditto.
2441 (cmd_debug_moments) Deal with `struct moments' or `struct
2442 moments1' as requested by user.
2444 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
2446 * Makefile.am (pspp_SOURCES): Remove debug.c.
2448 * debug.c: Removed. It was empty anyway.
2450 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
2452 * descript.c (calc_descriptives): Fix assert failure when only
2453 MOMENT_MEAN is needed.
2455 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
2459 fixed problem with parsing in match_statistic() causing
2460 "DESCRIPTIVE STAT=MEAN." to barf.
2462 "MEAN" is now default if "SORT" given without specification.
2464 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
2465 generally less forgiving of syntax errors: better to have it do
2466 nothing and type it in again then to not know what it actually did
2469 z-score transformation now checks score for user-missing values
2470 and checks std_dev for SYSMIS.
2472 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
2474 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
2475 Changed dict_get_case_weight() to accept an additional int * flag
2476 to complain about system-missing, user-missing, zero, or negative
2477 weights and updated existing functions to pass int * to
2478 dict_get_case_weight().
2480 2004-04-05 jmd <jmd@gnu.org>
2482 * main.c: Fixed configuration problems with gsl
2484 * t-test.q: Fixed some problems encountered when compiling under Cygwin
2486 2004-04-03 blp <blp@gnu.org>
2488 * lexer.c, ChangeLog:
2489 Fix infinite loop on comment at end of file, add test.
2491 2004-04-03 jmd <jmd@gnu.org>
2493 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
2494 Fixed the calculation of percentiles and added --syntax and --algorithm options
2496 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
2498 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
2501 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2503 * frequencies.q: Fixed the calculation of percentiles
2505 * Makefile.am: Added the --ansi flag and dealt with the
2506 consequences. Added some entries to PSPP_sources so that
2507 make distcheck would pass
2509 * cmdline.c: Added the --syntax and --algorithm options
2511 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
2513 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2515 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
2516 use the new multipass_split_... mechanism.
2518 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
2520 * frequencies.q: (calc_stats) Use moments data structure and
2521 calc_seskew(), calc_sekurt() functions.
2523 * set.q main.c settings.h Added support for --syntax and --algorithm
2526 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
2528 * vfm.c: Had to get last call to multipass_split_output() inside
2529 open_active_file()/close_active_file() pairing, so introduce new
2531 (internal_procedure) Move procedure() code here, except for calls
2532 to open_active_file() and close_active_file().
2533 (procedure) Wrap open_active_file() and close_active_file() around
2534 internal_procedure().
2535 (multipass_procedure_with_splits) Wrap open_active_file() and
2536 close_active_file() around internal_procedure().
2538 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
2540 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
2542 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
2544 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
2546 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
2548 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
2550 * algorithm.c: By default turn off some of the more expensive
2552 (expensive_assert) New macro which expands to assert if
2553 EXTRA_CHECKS is defined, to nothing otherwise.
2554 (unique) Use expensive_assert().
2555 (binary_search) Ditto.
2561 * command.c: (conflicting_3char_prefixes) Words that are the same
2562 don't cause conflicts when they are abbreviated to the first three
2565 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
2566 nonterm_node's n earlier.
2567 (generic_str_func) Ditto.
2569 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
2571 Add support for multipass procedures. Rewrite DESCRIPTIVES to
2572 test multipass support, take advantage of new moments
2573 calculation, and to not be such crappy code. Get rid of q2c
2574 processing for DESCRIPTIVES.
2576 * vfm.c: (struct multipass_split_aux_data) New structure.
2577 (multipass_procedure_with_splits) New function.
2578 (multipass_split_callback) New function.
2579 (multipass_split_output) New function.
2580 * descript.q: Removed.
2582 * descript.c: New file.
2584 * var.h: Removed descriptives enums.
2585 (struct descriptives_proc) Removed.
2586 (struct variable) Removed p.dsc.
2588 * Makefile.am: (q_sources_c) Remove descript.c.
2589 (q_sources_q) Removed descript.q.
2591 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
2593 New manager for keeping track of used workspace.
2595 * workspace.c: New file.
2597 * workspace.h: New file.
2599 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
2601 * sort.c: (do_internal_sort) Use workspace_malloc().
2602 (destroy_internal_sort) Use workspace_free().
2604 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
2606 New `struct casefile' for managing sets of cases.
2608 * casefile.c: New file.
2610 * casefile.h: New file.
2612 * command.def: Add DEBUG CASEFILE command.
2614 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
2616 * sort.c: (sort_cases) Move logic for sending storage file to disk
2617 into do_external_sort().
2618 (struct internal_sort) Use an array of ccase pointers instead of a
2620 (do_internal_sort) Rewrite to handle casefiles.
2621 (compare_case_list) Removed.
2622 (compare_cases) New function.
2623 (compare_case_dblptrs) New function.
2624 (read_internal_sort_output) Deal with new struct internal_sort.
2626 * vfm.c: (static var workspace_overflow) Removed.
2627 (struct storage_stream_info) Removed all the members. Added
2628 struct casefile * member.
2629 (storage_sink_open) Use casefile.
2630 (open_storage_file) Removed.
2631 (write_storage_file) Removed.
2632 (storage_to_disk) Removed.
2633 (destroy_storage_stream_info) Use casefile.
2634 (storage_sink_write) Use casefile.
2635 (storage_sink_make_source) Use casefile.
2636 (storage_source_count) Use casefile.
2637 (storage_source_read) Use casefile.
2638 (storage_source_on_disk) Removed.
2639 (storage_source_get_cases) Removed.
2640 (storage_source_set_cases) Removed.
2641 (storage_source_get_casefile) New function.
2643 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
2645 New `struct moments' for calculating moments.
2651 * moments.c: New file.
2653 * moments.h: New file.
2655 * command.def: Add DEBUG MOMENTS command.
2657 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
2660 * aggregate.c: Modify AGGREGATE to use the new moments
2661 calculation, even if not in such a great way.
2662 (struct agr_var) Add `moments' member.
2663 (parse_aggregate_functions) Set `moments' member to null.
2664 (agr_destroy) Destroy `moments' member.
2665 (accumulate_aggregate_info) Use `moments' for standard deviation.
2666 (dump_aggregate_info) Ditto.
2667 (initialize_aggregate_info) Create or clear `moments'.
2669 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
2670 cube(), pow4() that were in stats.h. All references updated.
2672 * crosstabs.q: stats.h had chi-square significance functions. Use
2674 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
2676 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
2677 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
2679 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
2681 * dictionary.c: (dict_compact_values) Compacted values need to
2684 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
2686 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
2687 `/' at start. Check return value of parse_variables() for error
2690 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
2692 Revamp expressions: make the code a little nicer, and fix bugs
2695 * expr-evl.c: (expr_evaluate) Make expression argument const.
2696 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2697 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
2698 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
2699 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
2700 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
2701 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
2702 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
2703 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
2704 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
2705 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
2706 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
2707 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
2708 Simplify OP_SYSMIS. Remove OP_STR_MIS.
2710 * expr-opt.c: (optimize_expression) Rewrite.
2715 (macro s0l) Removed.
2717 (macro s1l) Removed.
2719 (macro s2l) Removed.
2722 (eq_num_con) New function.
2723 (optimize_tree) New function.
2724 (macro rnc) Removed.
2725 (macro frnc) Removed.
2726 (str_search) Add const to string params.
2727 (str_rsearch) Ditto.
2728 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
2729 str[], str_len[] locals to substitute for most of removed macros.
2730 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2731 Removed support for missing values because we're never called with
2732 missing values. Use set_number() or set_number_errno() instead of
2733 rnc or frnc. Removed any stuff that caused trouble in testing.
2734 We can re-add it later if it really slows anything. Fix some
2736 (evaluate_tree_with_missing) Not yet supported. To be added later
2738 (repl_num_con) Removed.
2739 (collapse_node) New function.
2740 (force_repl_num_con) Removed.
2741 (set_number) New function.
2742 (set_number_errno) New function.
2743 (repl_str_con) Removed.
2744 (set_string) New function.
2745 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
2747 (dump_node) No special case for OP_AND, OP_OR.
2749 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
2750 (expr_get_type) New function.
2751 (type_check) Rewrite.
2752 (type_coercion) New function.
2753 (struct operator) New structure.
2754 (match_operator New function.
2755 (parse_binary_operators) New function.
2756 (parse_inverting_unary_operator) New function.
2757 (parse_or) Rewritten.
2758 (parse_and) Rewritten.
2759 (parse_not) Rewritten.
2760 (parse_rel) Rewritten.
2761 (parse_add) Rewritten.
2762 (parse_mul) Rewritten.
2763 (parse_neg) Rewritten.
2764 (parse_exp) Rewritten.
2765 (parse_sysvar) Add $TRUE, $FALSE system variables.
2766 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
2767 (parse_primary) Use allocate_var_node(), allocate_num_con(),
2769 (struct function) Remove desc, change `func' prototype.
2770 (unary_func) Remove special cases.
2771 (MISSING_func) Reduce to unary_func() that just returns a boolean.
2772 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
2773 (VALUE_func) Use allocate_var_node().
2774 (nary_num_func) Allow MIN and MAX for strings.
2775 Use allocate_var_node(). Properly clean up.
2777 (generic_str_func) Use local table instead of removed `desc'
2778 member. Mostly rewrite.
2779 (get_num_args) Revise error message.
2780 (parse_function) Return EXPR_ERROR, not 0 on error.
2782 (macro varies) Removed.
2783 (ops[]) Use expr.def.
2784 (free_node) Do nothing if node is null.
2785 (allocate_num_con) New function.
2786 (allocate_str_con) New function.
2787 (allocate_var_node) New function.
2788 (allocate_binary_nonterminal) New function.
2789 (append_nonterminal_arg) Removed.
2790 (static var func_tab[]) Revised.
2791 (expr_debug_print_postfix) Make parameter const.
2792 Use printf() instead of debug_printf().
2794 * expr.def: New file.
2796 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
2797 use named enum instead of unnamed, all references updated. Add
2798 EXPR_ANY, EXPR_NO_OPTIMIZE.
2800 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
2801 instead of defining OP_* directly.
2802 (macro IS_TERMINAL) New macro.
2803 (macro IS_NONTERMINAL) New macro.
2804 (enum OP_NO_FLAGS) New.
2806 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
2808 * error.c: (err_assert_fail) msg variable needs to be non-const.
2810 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
2812 * debug.c: (cmd_debug_evaluate) Rewrite.
2814 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
2816 Fix some CROSSTABS bit rot stupidity.
2818 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
2819 (internal_cmd_crosstabs) Initializes cells[] correctly.
2820 (float_M_suffix) Rename format_cell_entry(), change prototype,
2822 (display_crosstabulation) Fix cell formatting.
2824 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
2826 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
2827 to call lex_discard_line() to do that.
2829 * command.c: (run_command) Call lex_discard_line() after
2832 * lexer.c: (lex_entire_end) Change behavior.
2833 (lex_rest_of_line) Change behavior. Return const char *.
2834 (lex_discard_line) Don't clear getl_buf, don't emit message.
2836 * main.c: (handle_error) Emit message here.
2838 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
2839 instead of lex_entire_line().
2841 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
2843 * title.c: (get_title) Call lex_discard_line() after
2845 (cmd_file_label) Ditto.
2846 (cmd_document) Deal with const char * return value.
2848 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
2850 Removed REMARK command.
2852 * command.c: (extract_prefix) Removed.
2853 (output_line) Removed.
2854 (cmd_remark) Removed.
2856 * command.def: Remove REMARK.
2858 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
2860 Added abort() after lots of assert(0) invocations to avoid some
2861 compiler warnings. We really need a NOT_REACHED macro.
2863 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2865 * sort.c: Added missing call to temp_file_close. Changed error
2866 messages to warnings.
2868 * set.q: Improved setting of set_view{length,width} to be more tolerant
2871 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
2873 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
2874 used with incorrect syntax.
2876 * error.c, error.h et al: Overridden definition of assert for a
2879 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
2880 subcommand was given when it ought to have been.
2882 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
2884 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
2888 (tab_joint_text) Ditto.
2890 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
2892 * levene.c: Add #include.
2894 * set.q: (set_viewport) Add `int' argument to make its prototype
2895 correct for signal().
2897 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
2899 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
2902 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
2904 Changed DFM from open-at-first-access to explicit-open. Before,
2905 calling dfm_get_record() or dfm_put_record() would automatically
2906 open the file. Now, you have to call dfm_open_for_reading() or
2907 dfm_open_for_writing() explicitly. This makes it possible to
2908 check permissions, file existence, etc. earlier.
2910 Also made struct file_handle more opaque, and clean up in general.
2912 * data-list.c: (cmd_data_list) Open handle for reading.
2914 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
2916 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
2917 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
2918 (open_inline_file) Removed.
2919 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
2920 it. Deal with line_number in extension record instead of file
2922 (dfm_get_record) Rewrote.
2923 (dfm_put_record) Rewrote.
2924 (dfm_push) Assert file is open and one of ours. Deal with
2925 line_number in extension record instead of file handle.
2926 (dfm_pop) Assert file is open and one of ours. Deal with
2927 line_number in extension record instead of file handle.
2928 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
2931 * file-handle.h: (enum constants RH_RF_*) Removed.
2932 (enum constants FH_MD_*) Removed.
2933 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
2934 `recform', `lrecl', `mode' members. Public references to
2935 `recform' changed to use handle_get_mode(), references to `lrecl'
2936 changed to use handle_get_record_width(). Added `private' member.
2937 (enum file_handle_mode) New.
2939 * file-handle.q: (struct private_file_handle) New structure.
2940 (struct file_handle_list) New structure.
2941 (static var files) New.
2942 (static var file_handles) Removed.
2943 (init_file_handle) Removed.
2944 (create_file_handle) Removed.
2945 (get_handle_with_name) New function.
2946 (get_handle_for_filename) New function.
2947 (cmd_file_handle) Rewritten.
2948 (hash_file_handle) Removed.
2949 (cmp_file_handle) Removed.
2950 (fh_init_files) Rewritten.
2951 (fh_parse_file_handle) Rewritten. Allows identifiers as
2953 (fh_get_handle_by_name) Renamed handle_get_name(), all references
2955 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
2956 references updated. Rewritten.
2957 (fh_record_width) Renamed handle_get_record_width(), all
2958 references updated. Rewritten.
2959 (handle_get_mode) New function.
2961 * file-type.c: (cmd_file_type) Open handle for reading.
2963 * filename.c: [unix] (struct file_identity) New structure.
2964 [unix] (fn_get_identity) New function.
2965 [unix] (fn_free_identity) New function.
2966 [unix] (fn_compare_file_identities) New function.
2967 [!unix] (struct file_identity) New structure.
2968 [!unix] (fn_get_identity) New function.
2969 [!unix] (fn_free_identity) New function.
2970 [!unix] (fn_compare_file_identities) New function.
2972 * lexer.c: (static var put) Renamed put_token, all references
2974 (static var put_tokstr) New.
2975 (static var put_tokval) New.
2976 (lex_init) Initialize put_tokstr().
2977 (restore_token) New function.
2978 (save_token) New function.
2979 (lex_get) Use restore_token().
2980 (lex_put_back) Use save_token().
2981 (lex_put_back_id) New function.
2982 (lex_put_forward) Removed.
2983 (lex_preprocess_line) Set put_token instead of using
2985 (lex_negative_to_dash) Use save_token(), set put_token directly.
2986 (dump_token) Use stderr instead of stdout.
2988 * main.c: (main) Remove call to cmd_init().
2990 * matrix-data.c: (cmd_matrix_data) Open file for reading.
2992 * pfm-read.c: Use handle_get_filename() instead of trying to use
2993 h->fn directly, all over.
2995 * pfm-write.c: Ditto.
2997 * print.c: (internal_cmd_print) Open handle for writing.
2998 (dump_table) Use handle_get_filename().
2999 (print_trns_proc) Use handle_get_mode().
3000 (cmd_print_space) Use fh_parse_file_handle().
3001 Open handle for writing.
3002 [0] (debug_print) Removed.
3004 * sfm-read.c: Use handle_get_filename() instead of trying to use
3005 h->fn directly, all over.
3007 * sfm-write.c: Ditto.
3009 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
3013 * autorecode.c: (arc_free) Free arc->src_values.
3015 * error.c: (msg) Free buf.
3017 * val-labs.c: (do_value_labels) Always free vars.
3019 * vfm.c: (close_active_file) If sink has no make_source then call
3020 its destroy function.
3022 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
3024 Fixed cmd_parse() so that it always skips past a full command
3025 name. A few special commands for which this would be bad get
3026 special treatment. This lets us drop code for skipping past the
3027 end of a command name in most cmd_*() functions. It's not worth
3028 listing all the commands affected.
3030 * command.c: (struct command) Remove `cmd' member, replace by
3031 `name' member, all references updated. Remove `word', `next',
3032 `skip_entire_name' members.
3033 (macro DEFCMD) Deal with revised `struct command'.
3034 (macro UNIMPL) Ditto.
3035 (macro SPCCMD) New macro for commands whose last word shouldn't be
3037 (static array cmd_table[]) Make const, rename `commands', remove
3039 (macro COMMAND_CNT) New macro.
3040 (split_words) Removed.
3042 (FILE_TYPE_okay) Make parameter const.
3043 (cmd_parse) Improve error messages.
3044 (match_strings) New function.
3045 (next_word) New function.
3046 (enum command_match) New enum.
3047 (conflicting_3char_prefixes) New function.
3048 (conflicting_3char_prefix_command) New function.
3049 (cmd_match_words) New function.
3050 (count_matching_commands) New function.
3051 (get_command_name) New function.
3052 (free_words) New function.
3053 (unknown_command_error) New function.
3054 (figure_out_command) Renamed parse_command_name(), rewritten.
3056 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
3057 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
3058 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
3061 * command.h: (macro SPCCMD) New.
3063 * include.c: (cmd_include_at) Removed.
3064 (cmd_include) Allow identifier to be used as filename.
3066 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
3068 * t-test.q: (cmd_t_test) Command name is now parsed for us.
3071 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
3073 Start work on better test framework.
3075 * Makefile.am: (pspp_sources) Add debug.c.
3077 * debug.c: New file.
3079 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
3080 cmd_debug_evaluate().
3082 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
3084 * expr.h: (enum constant PXP_DUMP) Removed.
3086 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
3088 * set.q: Implemented the SHOW command, and synced it to the existing
3091 Added a handler for SIGWINCH so that viewlength and viewwidth follow
3092 changes as the window size is changed.
3094 Added fallback to set viewlength and viewwidth from LINES and COLUMS
3095 environment variables if other methods are not available.
3097 glob.c: Removed a lot of global variables from glob.c and encapsulated
3100 random.c: Tidied up the way the random seed is set.
3102 str.c: Added a ds_vprintf function.
3104 error.c: Extended dump_message so that messages are always broken at
3107 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
3109 * pfm-write.c: (bufwrite) Write out the correct element for string
3110 variables. From Andreas Streichardt <streichardt@globalpark.de>.
3112 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
3114 Get rid of static and global (!) vars in matrix-data.c.
3116 * matrix-data.c: (static var nr_data) Removed.
3117 (static var nr_factor_values) Removed.
3118 (static var max_cell_index) Removed.
3119 (static var split_values) Removed.
3120 (struct nr_aux_data) New structure.
3121 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
3122 place of static vars, pass to create_case_source() and procedure()
3124 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
3125 struct matrix_data_pgm *.
3126 (nr_read_splits) Ditto.
3127 (nr_read_factors) Ditto.
3128 (nr_output_data) Ditto.
3129 (static var wr_content) Removed.
3130 (global var wr_data) Removed.
3131 (global var wr_current) Removed.
3132 (struct wr_aux_data) New structure.
3133 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
3134 place of static vars, pass to create_case_source() and procedure()
3136 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
3137 instead of matrix_data_pgm *.
3138 (wr_read_splits) Ditto.
3139 (wr_output_data) Ditto.
3140 (wr_read_rowtype) Ditto.
3141 (wr_read_factors) Ditto.
3142 (wr_read_indeps) Ditto.
3144 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
3146 Get rid of static vars in autorecode.c.
3148 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
3149 `n_arc' to `spec_cnt'. All references updated.
3150 (static var v_src) Removed.
3151 (static var v_dest) Removed.
3152 (static var h_trns) Removed.
3153 (static var nv_src) Removed.
3154 (static var descend) Removed.
3155 (static var print) Removed.
3156 (enum direction) New enum.
3157 (struct autorecode_pgm) New structure.
3158 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
3159 Move n_dest local var into struct autorecode_pgm for ease of
3160 clean-up. Use arc_free().
3161 (arc_free) New function.
3162 (recode) Modify to take struct autorecode_pgm * parameter instead
3163 of using statics. Let the caller clean up.
3164 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
3165 instead of statics. Rearrange code a little.
3167 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
3169 Get rid of static, global vars in recode.c. Remove debug code.
3171 * recode.c: (static var head) Removed.
3172 (global var v) Removed.
3173 (global var nv) Removed.
3174 (cmd_recode) New local variables head, v, nv. Initialize and free
3175 v. Don't call debug_print().
3176 [DEBUGGING] (dump_dest) Removed.
3177 [DEBUGGING] (debug_print) Removed.
3179 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
3181 Get rid of static vars in expr-opt.c.
3183 * expr-opt.c: (static var e) Removed.
3184 (static var nop) Removed.
3185 (static var mop) Removed.
3186 (static var ndbl) Removed.
3187 (static var mdbl) Removed.
3188 (static var nstr) Removed.
3189 (static var mstr) Removed.
3190 (static var nvars) Removed.
3191 (static var mvars) Removed.
3192 (struct expr_dump_state) New structure.
3193 (dump_expression) Use new struct expr_dump_state instead of static
3194 vars and pass to functions we call.
3195 (dump_node) Use struct expr_dump_state * parameter.
3197 (emit_num_con) Ditto.
3198 (emit_str_con) Ditto.
3201 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
3203 Get rid of static var in COUNT.
3205 * count.c: (static var head) Move into cmd_count().
3206 (cmd_count) [DEBUGGING] Don't call debug_print.
3207 [DEBUGGING] (debug_print) Removed.
3209 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
3211 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
3213 * val-labs.c: (static var v) Removed.
3214 (static var nv) Removed.
3215 [DEBUGGING] (debug_print) Removed.
3216 (verify_val_labs) Add struct variable **, int parameters.
3217 (get_label) Ditto. Improve error messages, streamline.
3218 (erase_labels) New function for erasing value labels, taking over
3219 part of verify_val_labs()'s function.
3222 (cmd_value_labels) No need to call init() or done() anymore.
3223 (cmd_add_value_labels) Ditto.
3224 (do_value_labels) Add vars, var_cnt local variables. Clean up
3225 after them internally. Call erase_labels() if we should. Don't
3228 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
3230 Get rid of static vars in MATCH FILES.
3232 * get.c: (static var mtf_head) Removed.
3233 (static var mtf_tail) Removed.
3234 (static var mtf_by) Removed.
3235 (static var mtf_n_by) Removed.
3236 (static var mtf_master) Removed.
3237 (static var mtf_seq_num) Removed.
3238 (static var mtf_seq_nums) Removed.
3239 (static var mtf_sink) Removed.
3240 (static var mtf_case) Removed.
3241 (struct mtf_proc) New structure.
3242 (cmd_match_files) Use struct mtf_proc instead of static vars.
3243 (mtf_processing_finish) Ditto.
3245 (mtf_delete_file_in_place) Ditto.
3246 (mtf_read_nonactive_records) Ditto.
3247 (mtf_compare_BY_values) Ditto.
3248 (mtf_processing) Ditto.
3249 (mtf_merge_dictionary) Ditto.
3251 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
3253 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
3255 * dictionary.c: (dict_rename_var) Add assertion.
3256 (dict_contains_var) Check by index instead of name.
3258 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
3260 Get rid of compaction_necessary, compaction_nval, compaction_case.
3261 Redo VFM interface. Replace disk_sink and memory_sink by
3262 storage_sink, disk_source and memory_source by storage_source.
3264 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
3268 (struct write_case_data) Remove `begin_func', `end_func',
3269 `func_aux' members. Add `aux', `trns_case', `sink_case',
3270 `cases_written', `cases_analyzed' members.
3271 (global var compaction_necessary) Make static.
3272 (global var compaction_nval) Removed.
3273 (global var compaction_case) Removed.
3274 (static var case_count) Removed.
3275 (struct procedure_aux_data) Removed.
3276 (struct split_aux_data) Removed.
3277 (procedure) Remove begin_func, end_func parameters. Rewrite.
3278 (static var not_canceled) Removed.
3279 (process_active_file) Removed.
3280 (process_active_file_write_case) Removed.
3281 (process_active_file_output_case) Removed.
3282 (prepare_for_writing) Moved into open_active_file().
3283 (arrange_compaction) Ditto.
3285 (open_active_file) Rewrote.
3286 (write_case) New function.
3287 [DEBUGGING] (index_to_varname) Removed.
3288 (execute_transformations) New function.
3289 (exclude_this_case) Renamed filter_case(), changed interface.
3290 (clear_case) Added struct ccase * parameter to interface.
3291 (close_active_file) Added struct write_case_data * parameter,
3293 (disk_sink_create) Removed.
3294 (disk_sink_destroy) Removed.
3295 (disk_sink_make_source) Removed.
3296 (disk_sink_write) Removed.
3297 (disk_source_count) Removed.
3298 (disk_source_destroy) Removed.
3299 (disk_source_read) Removed.
3300 (global var disk_sink_class) Removed.
3301 (global var disk_source_class) Removed.
3302 (global var memory_sink_class) Removed.
3303 (global var memory_source_class) Removed.
3304 (memory_sink_create) Removed.
3305 (memory_sink_destroy) Removed.
3306 (memory_sink_make_source) Removed.
3307 (memory_sink_write) Removed.
3308 (memory_source_count) Removed.
3309 (memory_source_destroy) Removed.
3310 (memory_source_get_cases) Removed.
3311 (memory_source_read) Removed.
3312 (memory_source_set_cases) Removed.
3313 (struct disk_stream_info) Removed.
3314 (struct memory_sink_info) Removed.
3315 (struct memory_source_info) Removed.
3316 (write_active_file_to_disk) Removed.
3317 (destroy_storage_stream_info) New function.
3318 (global var null_sink_class) New var.
3319 (global var storage_sink_class) New var.
3320 (global var storage_source_class) New var.
3321 (open_storage_file) New function.
3322 (storage_sink_destroy) New function.
3323 (storage_sink_make_source) New function.
3324 (storage_sink_open) New function.
3325 (storage_sink_write) New function.
3326 (storage_source_count) New function.
3327 (storage_source_destroy) New function.
3328 (storage_source_get_cases) New function.
3329 (storage_source_on_disk) New function.
3330 (storage_source_read) New function.
3331 (storage_source_set_cases) New function.
3332 (storage_source_to_disk) New function.
3333 (storage_to_disk) New function.
3334 (struct storage_stream_info) New structure.
3335 (write_storage_file) New function.
3336 (procedure_write_case) Removed.
3337 (create_case_source) Add `struct dictionary *' parameter, all
3339 (create_case_sink) Ditto.
3340 (free_case_sink) New function.
3341 (struct split_aux_data) New structure.
3342 (procedure_with_splits) New function implementing what procedure()
3344 (SPLIT_FILE_proc_func) Removed.
3345 (procedure_with_splits_callback) New function.
3346 (equal_splits) New function.
3348 * aggregate.c: Pass around a struct instead of using statics.
3349 (static var outfile) Remove.
3350 (enum type) Give it tag `missing_treatment'.
3351 (static var missing) Remove.
3352 (static var sort) Remove.
3353 (static var agr_first) Remove.
3354 (static var agr_next) Remove.
3355 (static var case_count) Remove.
3356 (static var prev_case) Remove.
3357 (static var buf64_1xx) Remove.
3358 (static var buf_1xx) Remove.
3359 (struct agr_proc) New structure incorporating the above.
3360 (cmd_aggregate) Use new struct. Clean up error handling using
3361 agr_destroy(). Completely rewrite actual implementation of
3363 (create_sysfile) Add struct agr_proc * parameter, modify
3365 (parse_aggregate_functions) Ditto.
3366 (free_aggregate_functions) Ditto. Rename agr_destroy().
3367 (aggregate_single_case) Add struct agr_proc * parameter, modify
3369 (accumulate_aggregate_info) Ditto.
3370 (dump_aggregate_info) Ditto.
3371 (initialize_aggregate_info) Ditto.
3372 (agr_00x_trns_proc) Removed.
3373 (agr_00x_end_func) Removed.
3374 (agr_10x_trns_proc) Removed.
3375 (agr_10x_trns_free) Removed.
3376 (agr_10x_end_func) Removed.
3377 (agr_11x_read) Removed.
3378 (agr_11x_finish) Removed.
3379 [DEBUGGING] (debug_print) Removed.
3380 (write_case_to_sfm) Add struct agr_proc * parameter, modify
3382 (agr_to_active_file) New function.
3383 (presorted_agr_to_sysfile) New function.
3384 (sort_agr_to_sysfile) New function.
3386 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
3388 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
3390 * descript.q: (cmd_descriptives) Ditto.
3392 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
3393 to new procedure() interface.
3395 * command.c: (cmd_execute) Adapt to new procedure() interface.
3397 * dictionary.c: (dict_compact_values) Also delete scratch
3399 (dict_get_compacted_value_cnt) New function.
3400 (dict_get_compacted_idx_to_fv) New function.
3402 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
3403 (cmd_flip) Adapt to new procedure() interface.
3404 (flip_sink_write) Use sink->idx_to_fv.
3406 * frequencies.q: (internal_cmd_frequencies) Use
3407 procedure_with_splits().
3409 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
3410 (static var mtf_sink) New static var.
3411 (static var mtf_case) New static var.
3412 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
3413 we actually implement the matching.
3414 (mtf_delete_file_in_place) Use mtf_case.
3415 (mtf_processing) Use mtf_case and mtf_sink.
3416 (cmd_export) Adapt to new procedure() interface.
3418 * levene.c: (levene) Use procedure_with_splits().
3420 * list.q: (cmd_list) Use procedure_with_splits().
3422 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
3423 procedure() interface.
3424 (read_matrices_with_rowtype) Ditto.
3426 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
3427 TEMPORARY. Adapt to new procedure() interface.
3429 * rename-vars.c: Warn about and cancel TEMPORARY.
3431 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
3432 (sort_cases) Use dict_get_compacted_value_cnt() instead of
3433 compaction_nval. Adapt to new procedure() interface. Use
3434 storage_source_to_disk().
3435 (do_internal_sort) Don't try to dump the cases to memory.
3436 (compare_case_lists) Pass null idx_to_fv.
3437 (struct initial_run_state) Add `idx_to_fv' member. Remove
3439 (write_initial_runs) Don't initialize irs->case_size. Adapt to
3440 new procedure() interface. Reset irs->idx_to_fv after calling
3442 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
3443 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
3445 (destroy_initial_run_state) Don't dereference irs after freeing
3447 (allocate_cases) Don't calculate case_size locally.
3448 (compare_record) Add idx_to_fv parameter.
3449 (compare_record_run) Change parameter from struct sort_cases_pgm *
3450 to struct initial_run_state *. Pass irs->idx_to_fv to
3452 (compare_record_run) Third parameter now a struct
3453 initial_run_state *.
3454 (output_record) No need for out_case anymore. Pass irs, not
3455 struct sort_cases_pgm to pop_heap(). Use case_size from struct
3457 (merge) Use case_size from struct sort_cases_pgm.
3458 (merge_once) Use case_size from struct sort_cases_pgm.
3459 Pass null pointer to compare_record() as idx_to_fv.
3460 (global var sort_sink_class) Make static.
3462 * t-test.q: (cmd_t_test) Use procedure_with_splits().
3464 * temporary.c: Remove debugging crap.
3466 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
3468 * t-test.q, levene.c: Fixed up the handling of MISSING values
3471 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
3473 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
3476 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
3478 Change explicit variable name checks into use of
3479 dict_class_from_id().
3481 * dictionary.c: (dict_create_var) Change explicit variable name
3482 check into use of dict_class_from_id().
3484 * get.c: (trim_dictionary) Ditto.
3486 * sel-if.c: (cmd_filter) Ditto.
3488 * sysfile-info.c: (cmd_display) Ditto.
3490 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
3492 * vfm.c: (arrange_compaction) Ditto.
3494 * weight.c: (cmd_weight) Ditto.
3496 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
3498 * temporary.c: (cmd_temporary) When TEMPORARY was the first
3499 transformation following the input program, if any, for some
3500 reason we special-cased f_trns. That's just wrong. It should
3501 always be set to n_trns.
3503 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
3505 * format.c: (parse_format_specifier_name) Fix brown-bag bug
3506 introduced in last check-in.
3508 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
3510 * format.c: (global array translate_fmt[]) Removed.
3511 (translate_fmt) New function as replacement.
3512 (parse_format_specifier_name) Rewrite.
3514 * pfm-read.c: (convert_format) Use translate_fmt() instead of
3517 * sfm-read.c: (parse_format_spec) Ditto.
3519 * postscript.c: (text) Fix handling of fonts with missing
3522 * sort.c: (struct external_sort) Add temp_name member.
3523 (destroy_external_sort) Free temp_dir, temp_name members.
3524 (init_external_sort) Allocate temp_name.
3525 (get_temp_file_name) Change prototype.
3526 (open_temp_file) Deal with change to get_temp_file_name().
3527 (close_temp_file) Ditto.
3528 (remove_temp_file) Ditto.
3529 (write_temp_file) Ditto.
3530 (read_temp_file) Ditto.
3531 (sort_sink_destroy) Removed.
3532 (sort_sink_class) Change destroy member to null.
3534 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
3536 Eliminate temp_case.
3538 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
3539 anymore. Use agr_11x_finish().
3540 (aggregate_single_case) Make first param const.
3541 (accumulate_aggregate_info) Ditto.
3542 (agr_00x_end_func) Use compaction_case, not temp_case.
3543 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
3545 * data-list.c: (struct data_list_pgm) Add `case_size' member.
3546 (cmd_data_list) Initialize case_size.
3547 (read_from_data_list_fixed) Add struct ccase * param, use instead
3549 (read_from_data_list_free) Ditto.
3550 (read_from_data_list_list) Ditto.
3551 (read_one_case) Rename data_list_trns_proc(), all references
3552 updated. Add argument in calling above functions. Use c
3553 argument instead of temp_case.
3554 (destroy_dls) Rename data_list_trns_free(), all references
3557 * expr-evl.c: (expr_evaluate) Make second parameter const.
3559 * file-type.c: (struct file_type_pgm) Add `case_size' member.
3560 (cmd_end_file_type) Initialize `case_size'.
3561 (file_type_source_read) Add struct ccase * parameter. Use instead
3564 * flip.c: Rewritten.
3566 * get.c: (struct get_pgm) New structure to keep track of
3568 (cmd_get) Initialize case_size.
3570 (get_source) Deal with struct get_pgm.
3571 (get_source_read) Add struct ccase * parameter, use instead of
3573 (import_source_read) Ditto.
3575 * get.c: Use a null pointer instead of temp_case to represent the
3576 "current case" in a struct mtf_file's input member.
3577 (mtf_processing_finish) Pass null to mtf_processing(), not
3579 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
3580 (mtf_compare_BY_values) Add extra arg, use instead of null input
3582 (mtf_processing) Use c parameter instead of temp_case. Pass
3583 compaction_case to process_active_file_output_case().
3585 * glob.c: (global variable temp_case) Removed.
3587 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
3588 (cmd_input_program) Initialize case_size. Set
3589 vfm_source->value_cnt.
3590 (init_case) Add struct ccase * parameter, use instead of
3593 (input_program_source_read) Ditto.
3595 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
3596 (dump_cell_content) Ditto.
3597 (nr_output_data) Ditto.
3598 (read_matrices_without_rowtype) Ditto.
3599 (matrix_data_read_with_rowtype) Ditto.
3600 (wr_read_splits) Ditto.
3601 (wr_output_data) Ditto.
3603 * sort.h: (struct sort_cases_pgm) New member `case_size'.
3605 * sort.c: (sort_cases) Initialize scp->case_size.
3606 (struct external_sort) Remove `case_size' member.
3607 (write_initial_runs) Only call vfm_sink->class_destroy if
3609 (struct sort_source_aux) New structure.
3610 (sort_source_read_helper) New function.
3611 (sort_source_read) Use sort_source_read_helper().
3612 (read_sort_output) Change interface to be more reasonable.
3613 (read_internal_sort_output) Ditto.
3614 (read_external_sort_output) Ditto.
3616 * vars-prs.c: (dict_class_to_name) Pass return value through
3619 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
3620 (procedure) Initialize trns_case.
3621 (procedure) Pass trns_case to vfm_source->class->read().
3623 (process_active_file) Start using struct procedure_aux_data.
3624 (process_active_file_write_case) Pass trns_case to
3625 transformations, lag_case(), clear_case().
3626 (process_active_file_output_case) Add struct ccase * parameter.
3627 (create_trns_case) New function.
3628 (make_temp_case) Removed.
3629 (vector_initialization) Removed.
3630 (close_active_file) Only call make_source if non-null, otherwise
3631 set vfm_source to null pointer. Don't free temp_case.
3632 (disk_source_read) Add struct ccase * parameter, use instead of
3634 (memory_source_read) Ditto.
3635 (lag_case) Add const struct ccase * member.
3636 (procedure_write_case) Use trns_case instead of temp_case.
3637 (clear_case) Add struct ccase * member, use instead of temp_case.
3638 (exclude_this_case) Ditto.
3639 (create_case_source) Add struct dictionary * parameter, use to
3640 initialize source->value_cnt.
3642 * vfm.h: (struct case_source) Add `value_cnt' member.
3643 (struct case_source_class) Add struct ccase * parameter to `read'
3644 member function pointer.
3645 (struct case_sink_class) Make struct ccase * parameter const in
3646 `write' member function pointer.
3648 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
3650 Fix a lot of "possibly uninitialized variable" warnings. Some of
3651 them are even real bugs. A few of them make me wonder how the
3654 * aggregate.c: (parse_aggregate_functions) Initialize `function.
3656 * ascii.c: (output_lines) Add default case to switch.
3658 * crosstabs.q: Remove static variable `expected' and all
3660 (display_crosstabulation) Always calculate expected value.
3662 (output_pivot_table) Initialize `cmp'.
3663 (display_crosstabulation) New variable `last_row', which is
3666 * data-in.c: (parse_numeric) Always initialize sign. How did this
3669 * data-list.c: (repeating_data_trns_proc) Always initialize code.
3670 Always set info.ofs. (How did this work?!)
3672 * expr-opt.c: (optimize_tree) Always initialize `m'.
3673 (evaluate_tree) Always initialize `c'. (How did this work?)
3675 * frequencies.q: (frq_custom_variables) Always initialize min,
3677 (frq_custom_grouped) Always initialize `dl'.
3679 * groff-font.c: (groff_read_font) Always initialize char_set.
3681 * matrix-data.c: (nr_output_data) Initialize `split'.
3682 (wr_read_splits) Remove shadowing split_cnt declaration.
3683 (wr_output_data) Initialize `split'.
3685 * output.c: (tokener) Skip add character on syntax error.
3687 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
3689 * postscript.c: (read_ps_encodings) Use line.string instead of
3691 (write_text) Add default case to switch.
3692 (text) Always initialize multiple variables. Fix bug with
3695 * print.c: (fixed_parse_fortran) Initialize head.
3696 (alloc_line) Add default case to switch.
3698 * recode.c: (parse_dest_spec) Handle case where nothing matches.
3699 (recode_trns_proc) Move variable declaration inward. Add default
3702 * sfm-read.c: (read_header) Initialize skip_amt.
3704 * sysfile-info.c: (display_variables) Always initialize pc.
3706 * vars-prs.c: Initialized `included'.
3708 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
3710 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
3711 Just use signal() instead.
3713 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
3715 Get rid of vfm_sink_info and vfm_source_info.
3717 * aggregate.c: (agr_00x_end_func) Don't increment
3718 sfm_sink_info.ncases.
3720 * sort.c: (do_internal_sort) Get case count from
3721 vfm_source->class->count().
3722 (struct external_sort) Add `case_size' member.
3723 (do_external_sort) Initialize case_size.
3724 (struct initial_run_state) Add `case_size' member.
3725 (write_initial_runs) Initialize case_size.
3726 (sort_sink_write) Use case_size.
3727 (read_external_sort_output) Use case_size. Get case_cnt from
3730 * vfm.c: (struct write_case_data) Add underscores to existing arg
3731 names, all references updated. Renamed `aux' as `func_aux', all
3732 references updated. Added new `aux' member.
3733 (global var vfm_source_info) Removed.
3734 (global var vfm_sink_info) Removed.
3735 (struct procedure_aux_data) New.
3736 (struct split_aux_data) New.
3737 (procedure) Use `aux' fields for procedure_aux_data,
3739 (process_active_file_write_case) Pass case_count + 1 to
3740 transformation procedures, exclude_this_case().
3741 (process_active_file_output_case) Don't increment
3742 vfm_sink_info.ncases.
3743 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
3744 to send data to disk early.
3745 (make_temp_case) Don't use vfm_sink_info.case_size.
3746 (close_active_file) Don't initialize vfm_source_info.
3747 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
3748 (disk_sink_create) Initialize and/or update disk_stream_info.
3749 (disk_sink_write) Ditto.
3750 (disk_sink_destroy) Ditto.
3751 (disk_sink_make_source) Ditto.
3752 (disk_source_read) Ditto.
3753 (disk_source_destroy) Ditto.
3754 (global var disk_source_class) Add disk_source_count().
3755 (disk_source_count) New function.
3756 (struct memory_sink_info) Add `case_cnt', `case_size' members.
3757 (struct memory_source_info) Ditto.
3758 (memory_sink_create) Deal with case_cnt, case_size.
3759 (memory_sink_write) Ditto.
3760 (memory_sink_make_source) Ditto.
3761 (memory_source_read) Ditto.
3762 (memory_source_count) New function.
3763 (memory_source_class) Add memory_source_count().
3764 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
3765 proc_aux->cases_written, and pass it to transformation procedures
3766 and exclude_this_case ().
3767 (exclude_this_case) Add case_num parameter. Pass it to
3769 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
3772 * vfm.h: (struct case_source_class) Add `count' member.
3774 * vfmP.h: (struct stream_info) Removed.
3775 (global variable vfm_source_info) Removed.
3776 (global variable vfm_sink_info) Removed.
3778 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
3780 * var.h: (typedef trns_proc_func) New typedef.
3781 (trns_free_func) New typedef.
3782 (struct trns_header) Change `proc' to type trns_proc_func, `free'
3783 to type trns_free_func. This only changes the actual type of
3784 trns_proc_func, adding a `case_num' parameter. Updated all
3785 implementations to use the typedefs instead.
3787 * compute.c: (compute_num) Pass case_num to expr_evaluate().
3788 (compute_num_vec) Ditto.
3789 (compute_str) Ditto.
3790 (compute_str_vec) Ditto.
3792 * do-if.c: (do_if_trns_proc) Ditto.
3794 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
3797 * inpt-pgm.c: (input_program_source_read) Maintain case count,
3798 pass to transformation functions.
3799 (reread_trns_proc) Pass case_num arg to expr_evaluate().
3801 * loop.c: (loop_1_trns_proc) Ditto.
3802 (loop_2_trns_proc) Ditto.
3803 (loop_3_trns_proc) Ditto.
3805 * print.c: (print_space_trns_proc) Ditto.
3807 * sel-if.c: (select_if_proc) Ditto.
3809 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
3811 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
3812 destroying hash table.
3814 * glob.c: (read_active_file) Variable not referenced, removed.
3815 (cancel_input_pgm) Ditto.
3817 * levene.c: Add #include <stdlib.h> needed to call free().
3819 * aggregate.c: (parse_aggregate_functions) Make `function'
3822 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
3824 Start working to eliminate VFM dependence on static variables.
3826 * command.c: (cmd_parse) Use case_source_is_class().
3828 * data-list.c: Rewrite to eliminate use of static variables.
3830 * dfm.c: (cmd_begin_data) Use case_source_is_class().
3832 * file-handle.q: (fh_handle_name) Make parameter const.
3834 * file-type.c: Rewrite to eliminate use of static variables.
3836 * flip.c: Rewrite to eliminate use of static variables.
3838 * format.c: (get_format_var_width) New function.
3840 * get.c: Eliminate use of static variables.
3842 * inpt-pgm.c: Eliminate use of static variables.
3844 * matrix-data.c: Eliminate use of static variables.
3846 * set.q: (set_max_workspace) New variable.
3847 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
3849 * var.h: (struct case_list) Move here from vfmP.h.
3851 * vars-atr.c: (discard_variables) Handle new vfm_source type.
3853 * vfm.c: (vfm_source) Change type from struct case_stream to
3855 (vfm_sink) Change type from struct case_stream to struct
3857 (static var paging) Rename workspace_overflow, all references
3859 (procedure) Use new class structures.
3860 (process_active_file) Ditto.
3861 (process_active_file_write_case) Ditto.
3862 (prepare_for_writing) Use set_max_workspace. Use new class
3864 (close_active_file) Use new class structures. Free old sink.
3865 (global var disk_source_file) Removed.
3866 (global var disk_sink_file) Removed.
3867 (disk_stream_init) Removed.
3868 (disk_stream_read) Removed.
3869 (disk_stream_write) Removed.
3870 (disk_stream_mode) Removed.
3871 (disk_stream_destroy_source) Removed.
3872 (disk_stream_destroy_sink) Removed.
3873 (global var vfm_disk_stream) Removed.
3874 (disk_sink_create) New function.
3875 (disk_sink_write) New function.
3876 (disk_sink_destroy) New function.
3877 (disk_sink_make_source) New function.
3878 (disk_sink_class) New static var.
3879 (disk_source_read) New function.
3880 (disk_source_destroy) New function.
3881 (global var vfm_source_class) New var.
3882 (global var memory_source_cases) Removed.
3883 (global var memory_sink_cases) Removed.
3884 (global var memory_sink_max_cases) Removed.
3885 (struct memory_sink_info) New struct.
3886 (memory_stream_init) Removed.
3887 (memory_stream_read) Removed.
3888 (memory_stream_write) Removed.
3889 (memory_stream_mode) Removed.
3890 (memory_stream_destroy_source) Removed.
3891 (memory_stream_destroy_sink) Removed.
3892 (global var vfm_memory_stream) Removed.
3893 (page_to_disk) Renamed write_active_file_to_disk().
3894 (memory_sink_create) New function.
3895 (memory_sink_write) New function.
3896 (memory_sink_destroy) New function.
3897 (memory_sink_make_source) New function.
3898 (memory_sink_class) New static var.
3899 (memory_source_read) New function.
3900 (memory_source_destroy) New function.
3901 (memory_source_get_cases) New function.
3902 (memory_source_set_cases) New function.
3903 (global var vfm_source_class) New var.
3904 (procedure_write_case) Use new class structures.
3905 (create_case_source) New function.
3906 (case_source_is_complex) New function.
3907 (case_source_is_class) New function.
3908 (create_case_sink) New function.
3910 * vfm.h: (global variable reinit_sysmis) Not used, removed.
3911 (global variable reinit_blanks) Not used, removed.
3912 (global variable init_zero) Not used, removed.
3913 (global variable init_blanks) Not used, removed.
3914 (struct case_source) New struct.
3915 (struct case_source_class) New struct.
3916 (struct case_sink) New struct.
3917 (struct case_sink_class) New struct.
3918 (struct case_stream) Removed.
3920 * vfmP.h: (struct case_list) Moved to var.h.
3922 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
3924 * algorithm.c: (count_equal) New function.
3925 (count_if) New function.
3926 (unique) Add assertions.
3927 (partition) Add assertions.
3928 (is_partitioned) New function.
3929 (copy_if) Add assertions.
3930 (remove_equal) Add assertions.
3931 (lexicographical_compare) Rename lexicographical_compare_3way.
3932 (sort) Add assertions. Rephrase some code.
3933 (is_sorted) New function.
3935 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
3939 * sort.c: Completely rewrite.
3941 * sort.h: Expose interface via struct sort_cases_pgm, not via
3944 * aggregate.c: (sort) New static var.
3945 (cmd_aggregate) Use sort.
3946 (create_sysfile) Ditto.
3947 (aggregate_single_case) Ditto.
3948 (dump_aggregate_info) Ditto.
3949 (agr_00x_end_func) Ditto.
3950 (debug_print) Ditto.
3952 * var.h: (enum SRT_ASCEND) Removed.
3953 (enum SRT_DESCEND) Removed.
3954 (struct sort_cases_proc) Removed.
3955 (struct variable) Remove p.srt member.
3957 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
3959 Get rid of the old, crappy heap structure and replace it by a new,
3960 shiny, C++ STL-like heap structure.
3962 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
3964 * algorithm.c: (push_heap) New function.
3975 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
3977 Increase warning level.
3979 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
3981 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
3983 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
3985 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
3987 * dictionary.c: (dict_create_var) Fix root cause of bug worked
3988 around by previous change log entry.
3990 * compute.c: (lvalue_finalize) Remove workaround from previous
3993 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3995 * compute.c: Fixed a bug where the Format was not getting set for
3996 computed variables (thus causing a crash when SAVEing).
3998 * Added a test to stop this bug ever coming back
4000 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
4002 Got rid of approx.h. In general, replaced all references to
4003 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
4006 * Makefile.am: (pspp_SOURCES) Removed approx.h.
4008 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
4009 test for mag < EPSILON.
4011 * misc.h: Add definition of EPSILON.
4013 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
4015 * vfm.c: (procedure) Add check to prevent recursive call.
4017 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
4019 * Moved the declarations relating to values to their own header file
4022 * Added levene.c and levene.h
4024 * vars-atr.c: Changed the signature of compare_values to
4025 take const * arguments.
4027 * t-test.q: Changed the structure of struct t_test_proc
4028 variables now contain their own group statistics information.
4029 Eventually, t_test_proc might get renamed, because it'd be
4030 applicable to other commands too.
4032 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
4034 * data-out.c: Clean up. Changed interface of convert_*() to take
4035 either a `double' or a `const char *' instead of a `const union
4036 value *'. Update all implementations of those interfaces.
4037 (data_out) Use switch statements instead of a table.
4038 (convert_AHEX) Rewrite.
4040 * format.h: Update comment.
4042 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
4044 * q2c.c: (dump_header) Add an Emacs header line to output files
4045 that makes generated .c files read-only by default, to make it
4046 difficult to accidentally change generated files.
4048 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
4050 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
4051 not bogus a->v.c <=> b->v.c pointer compare.
4052 (compare_freq_alpha_a) Ditto.
4053 (compare_freq_numeric_d) Ditto.
4054 (compare_freq_alpha_d) Ditto.
4056 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
4058 Changed data_out() to store string data directly into a `union
4059 value''s s member, not indirectly into c.
4061 * crosstabs.q: (output_pivot_table) Use format_short() instead of
4063 (table_value_missing) Ditto.
4064 (float_M_suffix) Ditto.
4065 (format_short) New function.
4067 * data-in.h: (data_in_finite_line) Remove inline definition.
4069 * data-list.c: (destroy_dls_var_spec) New function.
4070 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
4071 (data_list_source_destroy_source) Avoid cast.
4072 (struct repeating_data_trns) New field `id_value'. Update
4074 (cmd_repeating_data) Initialize id_value. Use new
4075 repeating_data_trns_free() for freeing REPEATING DATA
4077 (rpd_parse_record) Rewrite support for record ID to be less bogus.
4078 (repeating_data_trns_free) New function.
4080 * data-out.c: (data_out) Change return type to `void' by replacing
4081 error returns by writing a message into the output buffer.
4082 (convert_A) Read from v->s instead of v->c.
4083 (convert_AHEX) Ditto.
4085 * expr-evl.c: Update comment.
4086 (expr_evaluate) Add assertion in OP_STRING case.
4088 * format.h: (macro MAX_FORMATTED_LEN) New macro.
4090 * list.q: (list_cases) Update for new data_out() semantics.
4092 * print.c: (print_trns_proc) Ditto.
4094 * tab.c: (tab_value) Ditto.
4095 (tab_float) Avoid stupid cast.
4097 * var.h: Update comments.
4098 (macro MAX_STRING) New macro.
4099 (macro MAX_ELEMS_PER_VALUE) New macro.
4101 * vars-atr.c: (compare_values) New function.
4103 * vfm.c: (dump_splits) Update for new data_out() semantics.
4105 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
4107 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
4109 (struct crosstab) Rename v[] to vars[]. All references updated.
4110 (hash_table_entry) Replace the hash algorithm and fix a bug at the
4111 same time, which caused the hash value to depend only on a single
4112 value, not all of the variables' values.
4114 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
4116 Clean up struct dictionary's value_cnt usage.
4118 * dictionary.c: Add a function comment to each function.
4119 (struct dictionary) Rename value_cnt to next_value_idx, which more
4120 accurately reflects its meaning. All references updated.
4121 (dict_rename_vars) Add assertion.
4122 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
4124 (dict_get_case_size) New function.
4126 * aggregate.c: (create_sysfile) Use dict_get_case_size().
4128 * get.c: (mtf_read_nonactive_records) Ditto.
4130 * sort.c: (allocate_cases) Ditto.
4131 (write_initial_runs) Ditto.
4135 * vfm.c: (prepare_for_writing) Ditto.
4139 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
4141 Make vfm.c slightly less grotesque.
4143 * vfm.c: (filter_var) Removed.
4144 (filter_index) Removed.
4145 (FILTERED macro) Removed.
4146 (exclude_this_case) New function.
4147 (process_active_file_write_case) Use exclude_this_case() instead
4148 of FILTERED and inline tests.
4149 (procedure_write_case) Ditto.
4150 (setup_filter) Removed.
4151 (open_active_file) Don't call setup_filter().
4152 (close_active_file) Call dict_get_filter() instead of checking
4155 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
4157 * var.h: (struct variable) Update comments.
4159 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
4161 New functions dict_create_var_assert(), dict_lookup_var_assert().
4162 Converted several dict_*_var()/assert pairs into a single
4163 dict_*_var_assert().
4165 * dictionary.c: (dict_create_var_assert) New function.
4166 (dict_lookup_var_assert) New function.
4168 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
4170 Got rid of "struct long_vec", envector(), devector(), etc. Added
4171 two members `init', `reinit' to struct variable as a substitute.
4173 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
4179 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
4182 * autorecode.c: (cmd_autorecode) destvars don't need init.
4184 * compute.c: (lvalue_finalize) Set reinit.
4186 * data-list.c: (fixed_parse_compatible) Don't need init usually.
4187 (dump_fmt_list) Ditto.
4190 * descript.q: (run_z_pass) Don't need init for z-scores.
4192 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
4194 (dict_clone_var) Copy `reinit' member, initialize `init' member.
4196 * glob.c: (init_glob) Remove vec_init() calls.
4198 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
4200 * loop.c: (internal_cmd_loop) Don't need to call envector().
4202 * numeric.c: (cmd_numeric) Ditto.
4204 (cmd_leave) Ditto. Set `init', `reinit' members.
4206 * recode.c: (cmd_recode) Don't need to call envector().
4208 * repeat.c: (internal_cmd_do_repeat) Ditto.
4210 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
4211 (force_create_variable) Removed prototype.
4212 (force_dup_variable) Ditto.
4214 * vector.c: (cmd_vector) Don't need to call envector().
4216 * vfm.c: (reinit_sysmis) Removed.
4217 (reinit_blanks) Removed.
4218 (init_zero) Removed.
4219 (init_blanks) Removed.
4220 (process_active_file_write_case) No need to deal with vectors.
4221 Call clear_temp_case().
4222 (vector_initialization) Rewrite to use `init', `reinit'.
4223 (close_active_file) No need to call vec_clear().
4224 (procedure_write_case) Call clear_temp_case().
4225 (clear_temp_case) New function.
4227 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
4229 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
4232 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
4234 Add auxiliary argument to procedure() interface. Associated small
4235 clean-ups of vfm interface.
4237 * Updated every caller of procedure() and process_active_file() to
4238 reflect modified interface. Simple, ordinary changes not listed
4241 * Updated every function that implements struct case_stream's
4242 `read' function to take a write_case_func and a write_case_data.
4243 Also updated every caller of write_case() to instead call them
4244 through these arguments. In some cases this meant that the extra
4245 args had to be threaded through a couple of extra levels. This
4246 wasn't difficult or interesting so the details won't be given.
4248 * data-list.c: (struct repeating_data_trns) Add members
4249 `write_case', `wc_data' as kluge.
4250 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
4252 (repeating_data_set_write_case) New function.
4254 * data-list.h: New file to declare repeating_data_trns_proc() and
4255 repeating_data_set_write_case().
4257 * inpt-pgm.c: (input_program_source_read) Call
4258 repeating_data_set_write_case() for all the REPEATING DATA
4259 transformations, so that they know where to send their cases.
4260 It's a big kluge. Also kluge in END CASE.
4261 (end_case_trns_proc) Never called anymore, but we still need it,
4264 * sort.c: (read_sort_output) Update to match struct case_stream
4267 * vfm.c: (struct write_case_data) New structure.
4268 (proc_func) Removed.
4269 (virt_proc_func) Removed.
4270 (begin_func) Removed.
4271 (virt_begin_func) Removed.
4273 (write_case) Removed.
4274 (procedure) Added an auxiliary parameter to each function pointer
4275 argument's prototype. Added an auxiliary data parameter.
4277 (process_active_file) Ditto.
4278 (process_active_file_write_case) Pass aux data along.
4279 (close_active_file) Ditto.
4280 (procedure_write_case) Ditto.
4281 (SPLIT_FILE_procfunc) Ditto.
4283 * vfm.h: (typedef write_case_data) New.
4284 (typedef write_case_func) New.
4285 (struct case_stream) Add parameters to `read' member prototype.
4287 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
4289 * t-test.q: Added calculations for independent samples. (But no Levene
4292 * Makefile.am: Moved q_sources_c into own variable
4294 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
4296 Miscellaneous cleanups.
4298 * Change unused to UNUSED in many source files to reflect modified
4299 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
4300 __CYGWIN32__, __unix__, and unix not to assume that they're
4301 defined to a nonzero value. Change use of __attribute__ to use
4302 NO_RETURN or PRINTF_FORMAT instead.
4304 * alloc.h: Move definitions for local_alloc(), local_free() here
4305 from ../pref.h.orig and simplify.
4307 * expr-evl.c: Instead of working differently based on PAGED_STACK,
4308 use a pool allocator unconditionally.
4309 (CHECK_STRING_SPACE) Removed.
4310 (ALLOC_STRING_SPACE) Removed.
4311 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
4314 * expr-opt.c: (dump_expression) Allocate string pool.
4316 * expr-prs.c: (expr_free) Free string pool.
4318 * pool.c: (pool_destroy) This pool must be removed from its
4319 parent's list of gizmos, not from its own. Use free_all_gizmos().
4320 (pool_clear) New function.
4321 (free_all_gizmos) New function.
4322 (pool_alloc) Use space in empty block after this one if any.
4323 (pool_release) Only empty out blocks, don't actually free() them.
4325 * print.c: Get rid of PAGED_STACK special case by always
4326 dynamically allocating line buffers.
4327 (struct print_trns) Always include the `line' member.
4328 (internal_cmd_print) Always initialize the `line' member.
4329 (alloc_line) Always allocate memory for `line'.
4330 (print_trns_proc) Always initialize buf from `line' member.
4331 (print_trns_free) Always free `line' memory.
4333 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
4336 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
4338 * flip.c: Fixed crash from FLIP when a numeric variable is
4339 specified on NEWNAMES and a large value is used, and a couple of
4340 other minor bugs besides.
4341 (struct varname) Make name a 9-character fixed-size array
4342 instead of a 1-character variable size array.
4343 (make_new_var) Allow digits in variable names.
4344 (flip_stream_write) Limit numeric values to 8 characters and
4345 format system missing and very large and small values more
4348 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4350 * command.c: Fixed test on command return status for the correct
4351 value, which had been causing a crash under certain invalid input.
4353 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
4355 * t-test.q: Added calculations for the one sample variant of the T-TEST
4357 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
4359 * tab.c: (render_strip) Fix bug that sometimes caused joined text
4360 in joined cells to be rendered outside box boundaries.
4362 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
4364 * random.c (rng_create): Fixed seeding so that it gets reseeded after
4365 SET seed=xx has been called.
4367 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
4369 * random.c (rng_get_double): Fix always-returning-zero bug in my
4370 preferred way, and at the same time make sure rounding doesn't
4373 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
4375 * html.c: (change_attributes) Dead code, removed.
4376 (escape_string) Eliminate code to call change_attributes() that
4377 never actually called it.
4378 (output_tab_table) Get rid of dependence on tab_hit
4379 and struct tab_joined_cell's hit member, which are abominations.
4381 * tab.c: (tab_output_text) Don't call
4382 d->class->text_set_font_by_name if it's a null pointer.
4383 (macro UNROLL_LOOP) Eliminate.
4384 (macro UNROLL_3_LOOPS) Eliminate.
4385 (tabi_render) Rewrite not to use the above macros.
4387 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
4389 Start working on a new output driver system, one that doesn't suck
4390 so much, by adding a "device-independent" output driver. The idea
4391 is to write out only a single output stream, then use separate
4392 processes to translate them into whatever formats we want. This
4393 is similar to how "groff" works with its various output drivers
4394 (grops, grotty, grodvi, ...).
4396 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
4398 * list.q: (write_all_headers) Stub out devind class.
4400 (determine_layout) Ditto.
4403 * output.c: (outp_init) Add devind class.
4405 * devind.c: New file.
4407 * devind.h: New file.
4409 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
4411 * frequencies.q: (hash_value_alpha) Fixed up the previous change
4412 to use the proper string length.
4414 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4416 * Fixed bug where FREQ would crash on alpha values
4418 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
4420 * Removed bletcherous alloca() workarounds for AIX from top of
4421 many files. AIX can use the alternative alloca() implementation
4424 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
4426 * ascii.c: (ascii_option) Fix implementation of headers option.
4428 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
4430 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
4431 multiple blank lines into one.
4432 (struct ascii_driver_ext) Add squeeze_blank_lines option.
4433 (ascii_preopen_driver) Initialize squeeze_blank_lines.
4434 (static var option_tab) Add squeeze entry.
4435 (ascii_option) Set squeeze_blank_lines.
4436 (output_lines) Implement squeezing blank lines.
4438 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
4440 * Removed redundant code from output.h
4442 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
4444 Dictionary classes: each variable is "ordinary", "system", or
4447 * var.h: (enum dict_class) New enum.
4449 * vars-prs.c: (dict_class_from_id) New function.
4450 (dict_class_to_name) New function.
4452 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
4454 * var.h: (struct freq_tab_set) Removed (not used).
4456 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
4458 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
4460 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
4462 * stats.c: (hypercube) Rename pow4(). All references updated.
4464 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
4466 * rename-vars.c: (cmd_rename_variables) Rewritten.
4467 (compare_name) Removed.
4469 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
4471 var_set feature, and code taking advantage of it.
4473 * crosstabs.q: (static var var_dict) Removed.
4474 (static var variables) New variable.
4475 (static var variables_cnt) New variable.
4476 (cmd_crosstabs) Free variables instead of var_dict.
4477 (internal_cmd_crosstabs) Initialize and use variables,
4478 variables_cnt instead of var_dict.
4479 (free_var_dict) Removed.
4480 (crs_custom_tables) Use var_set instead of a copied dictionary.
4481 (crs_custom_variables) Set up variables, variables_cnt instead of
4483 [DEBUGGING] (debug_print) Ditto.
4485 * means.q: (mns_custom_tables) Use var_set instead of a copied
4488 * vars-prs.c: (parse_vs_variable) New function.
4489 (parse_dict_variable) Rewritten.
4490 (parse_variable) Rewritten.
4491 (parse_variables) Renamed parse_var_set_vars(), rewritten.
4492 (parse_variables) New function in terms of parse_var_set_vars().
4493 Now requires its first argument to be non-null. All references
4494 that passed a null pointer updated to pass default_dict instead.
4495 (macro id_dict) Removed.
4496 (parse_DATA_LIST_vars) Add assertions.
4497 (parse_mixed_vars) Ditto.
4498 (struct var_set) New structure.
4499 (var_set_get_cnt) New function.
4500 (var_set_get_var) New function.
4501 (var_set_lookup_var) New function.
4502 (var_set_destroy) New function.
4503 (dict_var_set_get_cnt) New function.
4504 (dict_var_set_get_var) New function.
4505 (dict_var_set_lookup_var) New function.
4506 (dict_var_set_destroy) New function.
4507 (var_set_create_from_dict) New function.
4508 (struct array_var_set) New structure.
4509 (array_var_set_get_cnt) New function.
4510 (array_var_set_get_var) New function.
4511 (array_var_set_lookup_var) New function.
4512 (array_var_set_destroy) New function.
4513 (var_set_create_from_array) New function.
4515 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
4516 instead of parse_variables(NULL, ...) in output code.
4518 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
4520 Change inp_init from a 2-bit vector to an ordinary array.
4521 Initialize it all in cmd_end_input_program() instead of in
4524 * inpt-pgm.c: (enum value_init_type) New enum.
4525 (global var inp_init) Change to `enum value_init_type *', make
4527 (inp_init_size) Removed.
4528 (inp_nval) Change to `size_t', make static.
4529 (cmd_input_program) Don't initialize inp_init or inp_init_size.
4530 (cmd_end_input_program) Initialize inp_init, inp_nval.
4531 (init_case) Rewrite.
4532 (clear_case) Rewrite.
4534 * inpt-pgm.h: Removed.
4536 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
4538 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
4539 Colin Plumb hash. It is simpler and should better resist
4541 (hsh_hash_string) Ditto.
4543 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
4545 * get.c: (export_write_case_func) Remove debug printing code.
4547 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
4549 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
4551 (save_write_case_func) Use &trns->h instead of cast.
4552 (cmd_export) Use &t->h instead of cast.
4554 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
4556 Moved vectors into the dictionary.
4558 * var.h: (struct vector) Moved here from vector.h. `index' member
4559 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
4562 * vector.h: Removed.
4564 * vector.c: (global var vec) Removed.
4565 (global var nvec) Removed.
4566 (cmd_vector) Rewritten.
4567 (find_vector) Removed.
4569 * dictionary.c: (dict_create_vector) New function.
4570 (dict_get_vector) New function, replaces reading global vec[]
4572 (dict_get_vector_cnt) New function, replaces reading global nvec
4574 (dict_lookup_vector) New function, replaces find_vector().
4575 (dict_clear_vectors) New function.
4577 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
4579 Start to move away from `struct variable' p `union' member to void
4582 * var.h: (struct variable) Add `aux' member.
4584 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
4586 Get rid of struct variable `foo' member.
4588 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
4590 (frq_custom_variables) Ditto.
4591 (frq_custom_grouped) Ditto.
4593 * get.c: (struct save_trns) Change `var' member from `int *' to
4594 `struct variable **'.
4595 (cmd_save_internal) Use aux instead of foo.
4596 (save_trns_proc) Use revised `var' member.
4597 (static var mtf_seq_no) Renamed mtf_seq_num.
4598 (static var mtf_seq_nums) New static var.
4599 (cmd_match_files) Initialize mtf_seq_nums.
4600 (mtf_free) Free mtf_seq_nums.
4601 (mtf_processing) Use mtf_seq_nums instead of foo.
4602 (mtf_merge_dictionary) No need to initialize mv->foo.
4603 (cmd_export) Use aux instead of foo. Use revised `var' member.
4604 (mns_custom_tables) Don't use foo to check for duplicates, that's
4605 what PV_NO_DUPLICATE is for.
4607 * var.h: (struct variable) Remove `foo' member.
4608 (struct frequencies_proc) New member.
4610 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
4612 Clean up COMPUTE and IF.
4614 * compute.c: More or less rewrite the darn thing.
4615 (struct compute_trns) Rename and reorder and add and delete
4617 (cmd_compute) Rewrite.
4618 (compute_num) Make conditional on test expression. Now used for
4619 both COMPUTE and IF.
4620 (compute_num_vec) Ditto.
4621 (compute_str) Ditto.
4622 (compute_str_vec) Ditto.
4625 (if_num_vec) Removed.
4627 (if_str_vec) Removed.
4628 (parse_target_expression) Renamed parse_rvalue_expression(),
4630 (new_trns) Renamed compute_trns_create(), rewritten.
4631 (delete_trns) Removed.
4632 (free_trns) Renamed compute_trns_free(), rewritten.
4633 (struct lvalue) New structure.
4634 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
4635 (lvalue_get_type) New function.
4636 (lvalue_is_vector) New function.
4637 (lvalue_finalize) New function.
4638 (lvalue_destroy) New function.
4640 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
4642 * command.def: Disallow MODIFY VARS in input mode, so that
4643 variables can't get dropped and confuse cmd_end_input_program()'s
4644 attempt to fill inp_init[].
4646 * modify-vars.c: (static var forward_positional_ordering) New
4648 (struct var_modification) Entirely changed.
4649 (rearrange_dict) Interface changed, rewritten.
4650 (cmd_modify_vars) Deal with modified struct var_modification, much
4652 (struct var_renaming) New structure.
4653 (compare_var_renaming_by_new_name) New function.
4654 (validate_var_modification) New function.
4656 * var.h: (struct modify_vars_proc) Removed.
4657 (struct variable) Removed member p.mfv.
4659 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
4661 Make EVALUATE a valid command whether we're debugging or not, so
4662 that `make check' can succeed regardless of whether debugging is
4665 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
4667 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
4669 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
4671 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
4672 statement by a simple if test.
4674 * dfm.c: (dfm_get_record) Add assertion.
4676 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
4678 For each file x.c, move #include "x.h" to the very top of the
4679 include list, to catch x.h failing to include the proper headers.
4681 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
4683 * algorithm.c: (find) New function.
4684 (remove_equal) New function.
4685 (set_difference) New function.
4686 (adjacent_find_equal) New function.
4687 [TEST_UNIQUE] Removed test case.
4688 (copy_if) Find end test.
4690 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
4692 * dictionary.c: (dict_get_case_weight) New convenience function.
4694 * aggregate.c: (accumulate_aggregate_info) Use
4695 dict_get_case_weight().
4697 * frequencies.q: (calc_general) Ditto.
4698 (calc_integer) Ditto.
4701 * t-test.q: (groups_calc) Ditto.
4704 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
4706 * glob.c: (global var default_dict) Change from `struct
4707 dictionary' to `struct dictionary *'. All references changed.
4708 (init_glob) Initialize default_dict with dict_create().
4710 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
4712 struct dictionary now made opaque. All related functions:
4714 * get.c: (rename_variables) Removed.
4715 (dict_delete_run) Removed.
4717 * temporary.c: (copy_variable) Removed.
4718 (new_dictionary) Removed.
4719 (save_dictionary) Removed.
4720 (restore_dictionary) Removed.
4721 (free_dictionary) Removed.
4723 * vars-atr.c: (clear_default_dict) Removed.
4724 (find_variable) Removed.
4725 (find_dict_variable) Removed.
4726 (create_variable) Removed.
4727 (delete_variable) Removed.
4728 (common_init_stuff) Removed.
4729 (init_variable) Removed. Updating of inp_init moved into
4730 cmd_end_input_program().
4731 (replace_variable) Removed.
4732 (rename_variable) Removed.
4733 (clear_variable) Removed.
4734 (dup_variable) Removed.
4736 * vars-prs.c: (is_varname) Removed.
4737 (is_dict_varname) Removed.
4738 (fill_all_vars) Removed.
4740 * vector.c: (find_vector) Removed.
4742 * weight.c: (stop_weighting) Removed.
4744 * dictionary.c: New file.
4745 (dict_create) New, replaces new_dictionary().
4746 (dict_clone) New, replaces save_dictionary() and
4747 restore_dictionary().
4748 (dict_clear) New, replaces clear_default_dict().
4749 (dict_destroy) New, replaces free_dictionary().
4750 (dict_get_var_cnt) New function, replaces references to
4752 (dict_get_var) New function, replaces references to dict->var[i].
4753 (dict_get_vars) New function, replaces fill_all_vars().
4754 (dict_create_var) New, replaces create_variable(). Interface
4755 drops `type' parameter, using a zero `width' to designate numeric.
4756 (dict_clone_var) New, replaces dup_variable().
4757 (dict_rename_var) New, replaces rename_variable().
4758 (dict_lookup_var) New, replaces find_variable(),
4759 find_dict_variable(), is_varname().
4760 (dict_contains_var) New function.
4761 (compare_variable_dblptrs) New function.
4762 (dict_delete_var) New function, replaces clear_variable().
4763 (dict_delete_vars) New function, replaces dict_delete_run().
4764 (dict_reorder_vars) New function.
4765 (dict_rename_vars) New function, replaces rename_variables().
4766 (dict_get_weight) New function, replaces reading dict->weight_var.
4767 (dict_set_weight) New function, replaces writing dict->weight_var
4768 or calling stop_weight(dict).
4769 (dict_get_filter) New function, replaces reading dict->filter_var.
4770 (dict_set_filter) New function, replaces writing dict->filter_var.
4771 (dict_get_case_limit) New function, replaces reading dict->N.
4772 (dict_set_case_limit) New function, replaces writing dict->N.
4773 (dict_get_value_cnt) New function, replaces reading dict->nval.
4774 (dict_compact_values) New function, replaces a loop that was
4775 replicated in several places.
4776 (dict_get_split_vars) New function, replaces reading dict->splits.
4777 (dict_get_split_cnt) New function, replaces reading
4779 (dict_set_split_vars) New function, replaces writing dict->splits.
4780 (dict_get_label) New function, replaces reading dict->label.
4781 (dict_set_label) New function, replaces writing dict->label.
4782 (dict_get_documents) New function, replaces reading
4784 (dict_set_documents) New function, replaces writing
4787 All references to above functions updated.
4789 * aggregate.c: (cmd_aggregate) Copy file label and documents from
4790 old dictionary to new by hand, because dict_create() can't do it
4791 itself. Use dict_set_documents(), dict_set_split_vars().
4793 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
4794 calling dict_destroy().
4796 * data-list.c: (dls_var_spec) Remove `type' member, replace by
4798 (fixed_parse_compatible) Some slightly nontrivial changes for
4800 (dump_fmt_list) Ditto.
4803 * file-type.c: (create_col_var) Ditto.
4805 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
4806 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
4807 (rename_variables) Use dict_rename_vars().
4808 (mtf_merge_dictionary) Use dict_get_documents(),
4809 dict_set_documents(), dict_compact_values().
4811 * pfm-read.c: (read_variables) Deal with changes to weighting.
4813 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
4814 is_varname() in output code.
4816 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
4817 other dictionary functions.
4819 * title.c: (add_document_line) Use dict_get_documents(),
4820 dict_set_documents().
4822 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
4823 reset default_handle by hand. dict_clear() will clear vectors so
4824 there's no need for that by hand.
4826 * vfm.c: (close_active_file) Move call to finish_compaction()
4827 earlier, so that we can do the compaction as a single step using
4828 dict_compact_values(). Use dict_clear_vectors().
4829 (finish_compaction) Use dict_delete_var(), dict_compact_values().
4831 Some functions don't have replacements:
4833 * vars-atr.c: (force_create_variable) Removed. All references
4834 updated to dict_create_var() followed by an assertion.
4835 (force_dup_variable) Removed. All references updated to
4836 dict_clone_var() followed by an assertion.
4838 * weight.c: (update_weighting) Removed. No longer necessary, so
4839 all references removed.
4841 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
4845 * aggregate.c: Eliminate separation of weighted and unweighted
4846 case. It made the code too obscure and I doubt it was actually
4847 faster. Instead, all code uses the "weighted" code, because
4848 that's a generalization of the "unweighted" code.
4851 (parse_aggregate_functions) No need to set FWEIGHT.
4852 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
4853 (dump_aggregate_info) Ditto.
4854 (initialize_aggregate_info) No need for special plain_function
4855 that gets rid of FWEIGHT option.
4857 * aggregate.c: Get rid of approximations.
4858 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
4860 (aggregate_single_case) Don't use approx_ne().
4862 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
4864 * ascii.c (ascii_line_width): Dead code, removed.
4866 * postscript.c (ps_line_width): Ditto.
4868 * q2c.c (xrealloc): Ditto.
4870 * count.c (internal_cmd_count): Ditto.
4872 * means.q (validate_dependent_endpoint): Ditto.
4874 * set.q: (cmd_gset) Ditto.
4876 * weight.c: [0] (weight_trns_proc) Ditto.
4878 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
4880 Make the code -Wmissing-prototypes clean.
4882 * Makefile.am (version.c): Add #include "version.h".
4884 * ascii.c: (ascii_open_global) Make static.
4885 (ascii_close_page) Ditto.
4886 (ascii_font_sizes) Ditto.
4887 (ascii_postopen_driver) Ditto.
4888 (ascii_close_driver) Ditto.
4889 (ascii_option) Ditto.
4890 (ascii_open_page) Ditto.
4891 (ascii_line_horz) Ditto.
4892 (ascii_line_vert) Ditto.
4893 (ascii_line_intersection) Ditto.
4895 (ascii_polyline_begin) Ditto.
4896 (ascii_polyline_point) Ditto.
4897 (ascii_polyline_end) Ditto.
4898 (ascii_text_set_font_by_name) Ditto.
4899 (ascii_text_set_font_by_position) Ditto.
4900 (ascii_text_set_font_by_family) Ditto.
4901 (ascii_text_get_font_name) Ditto.
4902 (ascii_text_get_font_family) Ditto.
4903 (ascii_text_set_size) Ditto.
4904 (ascii_text_get_size) Ditto.
4905 (ascii_text_metrics) Ditto.
4906 (ascii_text_draw) Ditto.
4907 (ascii_close_page) Ditto.
4909 * cmdline.h: New header for parse_command_line(). Used where
4912 * command.c: Move prototypes for cmd_*() functions to command.h.
4914 * command.h: Prototypes for cmd_*() functions moved here from
4917 * crosstabs.q: (gamma_int) Ditto.
4919 * file-handle.h: Add fh_init_files() prototype.
4921 * getline.c: (welcome) Ditto.
4923 * glob.h: New header for init_glob(). Used where appropriate.
4925 * hash.c: (comparison_helper) Ditto.
4927 * html.c: (html_open_global) Ditto.
4928 (html_close_global) Ditto.
4929 (html_preopen_driver) Ditto.
4930 (html_postopen_driver) Ditto.
4931 (html_close_driver) Ditto.
4932 (html_option) Ditto.
4933 (html_open_page) Ditto.
4934 (html_close_page) Ditto.
4935 (html_submit) Ditto.
4937 * inpt-pgm.c: (input_program_source_read) Ditto.
4939 * output.c: (find_defn_value) Ditto.
4940 (destroy_list) Ditto.
4942 * pfm-read.c: (read_int) Ditto.
4944 * postscript.c: (ps_open_global) Ditto.
4945 (ps_close_global) Ditto.
4946 (ps_font_sizes) Ditto.
4947 (ps_preopen_driver) Ditto.
4948 (ps_postopen_driver) Ditto.
4949 (ps_close_driver) Ditto.
4951 (ps_open_page) Ditto.
4952 (ps_close_page) Ditto.
4953 (ps_line_horz) Ditto.
4954 (ps_line_vert) Ditto.
4955 (ps_line_intersection) Ditto.
4957 (ps_polyline_begin) Ditto.
4958 (ps_polyline_point) Ditto.
4959 (ps_polyline_end) Ditto.
4960 (ps_text_set_font_by_name) Ditto.
4961 (ps_text_set_font_by_position) Ditto.
4962 (ps_text_set_font_family) Ditto.
4963 (ps_text_get_font_name) Ditto.
4964 (ps_text_get_font_family) Ditto.
4965 (ps_text_set_size) Ditto.
4966 (ps_text_get_size) Ditto.
4967 (ps_text_metrics) Ditto.
4968 (ps_text_draw) Ditto.
4970 * q2c.c: (finish_up) Ditto.
4979 (find_symbol) Ditto.
4982 (force_string) Ditto.
4984 (match_token) Ditto.
4987 (parse_setting) Ditto.
4988 (parse_specifier) Ditto.
4989 (parse_specifiers) Ditto.
4990 (parse_subcommand) Ditto.
4991 (dump_specifier_vars) Ditto.
4993 (make_identifier) Ditto.
4994 (dump_declarations) Ditto.
4995 (dump_specifier_init) Ditto.
4996 (dump_vars_init) Ditto.
4998 (dump_specifier_parse) Ditto.
4999 (dump_subcommand) Ditto.
5000 (dump_parser) Ditto.
5001 (dump_header) Ditto.
5003 (recognize_directive) Ditto.
5005 * recode.c: (string_to_long) Ditto.
5007 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
5009 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
5012 * sort.c: (sort_stream_read) Ditto.
5013 (sort_stream_mode) Ditto.
5015 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
5017 * algorithm.c (binary_search): Fix comparison.
5019 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
5021 * algorithm.c: (binary_search) Fix assertion.
5023 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
5025 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
5027 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
5029 * sort.c: (compare_case_lists) Rewrite.
5031 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
5033 * quicksort.c: Removed (not used).
5035 * quicksort.h: Removed (not used).
5037 * sort.c: Removed blp_quicksort() prototype.
5039 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
5041 * postscript.c: (int_2_compare) Rewrite.
5042 (compare_line) Rewrite.
5044 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
5046 * matrix-data.c (compare_factors) Use lexicographical_compare()
5048 (compare_doubles) New function.
5050 * algorithm.c: (lexicographical_compare) New algorithm.
5052 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
5054 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
5056 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
5058 * expr-prs.c: (cmp_func) Removed.
5059 (parse_function) Use binary_search() algorithm.
5060 (compare_functions) New function.
5061 (init_func_tab) Use sort() algorithm.
5063 * algorithm.c: (binary_search) New algorithm.
5065 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
5067 * descript.q: (display) Use sort() algorithm instead of qsort().
5068 (compare_func) Removed.
5069 (descriptives_compare_variables) New function.
5071 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
5073 Get rid of AVL trees. Hashes are more appropriate for everything
5076 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
5082 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
5084 Much code can be clarified by using C++ STL-like algorithms. Not
5085 all uses of these algorithms are listed below, only the ones where
5086 the change to an algorithm was the only change of interest.
5088 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
5090 * algorithm.c: New file.
5092 * algorithm.h: New file.
5094 * modify-vars.c: (static var forward) Removed.
5095 (static var positional) Removed.
5096 (compare_variables) Removed.
5097 (struct ordering) New.
5098 (cmd_modify_vars) Use sort() algorithm.
5099 (compare_variables_given_ordering) New function.
5100 (rearrange_dict) Use sort() algorithm.
5102 * sysfile-info.c: (cmd_display) Use sort() algorithm.
5103 (cmp_var_by_name) Removed.
5105 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
5107 Make file handles use a hash table.
5109 * file-handle.q: (files) Change to hash table, make static.
5110 (cmd_file_handle) Use hash table functions.
5111 (fh_get_handle_by_filename) Ditto.
5112 (fh_get_handle_by_name) Ditto.
5113 (hash_file_handle) New function.
5114 (cmp_file_handle) Rewrite.
5115 (fh_init_files) Use hash table functions.
5117 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
5119 Clean up FREQUENCIES.
5121 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
5123 * frequencies.q: Remove a lot of old #if'd out code at the end.
5124 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
5125 or calc_weight(). Initialize percentile_values.
5126 (calc) New function based on calc_weight() from frequencies.g.
5127 (precalc) Use hash functions.
5128 (static var comparison_func) Removed.
5129 (static var comparison_param) Removed.
5130 (comparison_helper) Removed.
5131 (get_freq_comparator) New function.
5132 (not_missing) New function.
5134 (postprocess_freq_tab) Use hash table functions, algorithms,
5135 get_freq_comparator(). Rewrite.
5136 (cleanup_freq_tab) Rephrase.
5137 (add_percentile) Clean up spacing.
5138 (hash_value_numeric) New function.
5139 (hash_value_alpha) New function.
5140 (compare_value_numeric_a) Rewrite.
5141 (compare_value_alpha_a) Rewrite.
5142 (compare_value_numeric_d) Rewrite.
5143 (compare_value_alpha_d) Rewrite.
5144 (compare_freq_numeric_a) Rewrite.
5145 (compare_freq_alpha_a) Rewrite.
5146 (compare_freq_numeric_d) Rewrite.
5147 (compare_freq_alpha_d) Rewrite.
5148 (calc_stats) Clean up mode, percentiles, max.
5149 (dump_statistics) Clean up spacing.
5151 * frequencies.g: Removed.
5153 * var.h: (struct freq_tab) Change `data' to hash table.
5155 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
5157 * file-handle.h: Remove declaration of global variable `files',
5158 which wasn't used anywhere.
5160 * postscript.c: (add_encoding) Remove superfluous cast.
5163 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
5166 * temporary.c: [0] (display_tree) Removed.
5168 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
5170 Implement a new random number generator based on the alleged RC4
5173 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
5176 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
5177 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
5179 (static var V[]) Removed.
5180 (static var Y) Removed.
5181 (static var X2) Removed.
5182 (setup_randomize) Removed.
5184 (rand_uniform) Removed.
5185 (rand_normal) Removed.
5186 (struct rng) New structure.
5187 (rng_create) New function.
5188 (rng_destroy) New function.
5189 (swap_byte) New static function.
5190 (rng_seed) New function.
5191 (rng_get_bytes) New function.
5192 (rng_get_int) New function.
5193 (rng_get_unsigned) New function.
5194 (rng_get_double) New function.
5195 (rng_get_double_normal) New function.
5196 (pspp_rng) New function.
5198 * random.h: Sync up to random.c.
5200 * sample.c: (struct sample_trns) Make `frac' unsigned and a
5201 fraction of UINT_MAX, not 65536.
5202 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
5205 * vfm.c: (open_active_file) No need to call setup_randomize() any
5208 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
5210 Change dictionary name indexes to use hash tables instead of AVL
5213 * crosstabs.q: (free_var_dict) Use hash tables.
5214 (crs_custom_tables) Ditto.
5215 (calc_general) Ditto.
5216 (compare_table_entry) Rewrite.
5217 (enum_var_values) Reorder parameters. All references updated.
5220 * get.c: (rename_variable) Use hash tables.
5221 (mtf_merge_dictionary) Ditto.
5223 * glob.c: (init_glob) Use hash tables.
5224 (cmp_variable) Removed.
5226 * means.q: (mns_custom_tables) Use hash tables.
5228 * modify-vars.c: (rearrange_dict) Use hash tables.
5230 * rename-vars.c: (cmd_rename_variables) Use hash tables.
5232 * sfm-read.c: (read_header) Use hash tables.
5233 (read_variables) Ditto.
5235 * temporary.c: (new_dictionary) Use hash tables.
5236 (save_dictionary) Ditto.
5237 (restore_dictionary) Ditto.
5239 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
5240 hash table `name_tab'.
5242 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
5243 [DEBUGGING] (dump_var_tree) Removed.
5244 (find_variable) Use hash tables.
5245 (find_dict_variable) Ditto.
5246 (common_init_stuff) Ditto.
5247 (rename_variable) Ditto.
5248 (clear_variable) Ditto. Also, remove debug code.
5249 (dup_variable) Use hash tables.
5251 * vars-prs.c: (fill_all_vars) Use hash tables.
5252 (is_dict_varname) Ditto.
5253 (parse_dict_variable) Ditto.
5255 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
5257 Change value labels to use hash tables instead of AVL trees, and
5258 change value labels into an ADT.
5260 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
5262 * value-labels.c: New file.
5264 * value-labels.h: New file.
5266 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
5267 Get rid of a stupid use of goto.
5269 * autorecode.c: (compare_alpha_value) Rewrite.
5270 (hash_alpha_value) Ditto.
5271 (compare_numeric_value) Rewrite.
5272 (hash_numeric_value) Ditto.
5274 * frequencies.q: (dump_full) Use value label ADT.
5276 * pfm-read.c: (read_value_label) Use value label ADT.
5278 * pfm-write.c: (write_value_labels) Use value label ADT.
5280 * sfm-read.c: (read_variables) Use value label ADT.
5281 (read_value_labels) Rewrite.
5283 * sfm-write.c: (write_value_labels) Rewrite.
5285 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
5286 (display_variables) Ditto.
5287 (describe_variable) Ditto.
5289 * t-test.q: (print_t_groups) Use value label ADT.
5291 * temporary.c: (copy_variable) Use value label ADT.
5292 (free_dictionary) Ditto.
5294 * val-labs.c: (verify_val_labs) Use value label ADT.
5296 (debug_print) Ditto.
5297 (val_lab_cmp) Removed.
5298 (inc_ref_count) Removed.
5299 (copy_value_labels) Removed.
5301 * var.h: (struct value_label) Removed.
5302 (struct variable) Change AVL tree `val_lab' into hash table
5305 * vars-atr.c: (init_variable) Use value label ADT.
5306 (clear_variable) Ditto.
5307 (free_value_label) Removed.
5308 (free_val_lab) Removed.
5309 (get_val_lab) Removed.
5310 (compare_variables) New function.
5311 (hash_variable) New function.
5313 * vfm.c: (dump_splits) Use value label ADT.
5315 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
5317 Add to the hash table interface.
5319 * hash.c: (hsh_hash_bytes) Add assertion.
5320 (hsh_hash_string) Ditto.
5324 (hsh_create) Ditto. Also make minimum `size'.
5325 (hsh_destroy) Rephrase.
5326 (sort_nulls_last) Removed.
5327 (not_null) New function.
5329 (comparison_helper) Ditto.
5330 (hsh_sort) Rewritten.
5331 (hsh_data_copy) New function.
5332 (hsh_sort_copy) Ditto.
5334 (hsh_replace) Ditto.
5335 (hsh_hash_double) Ditto.
5336 (hsh_delete) Fix stupid bug.
5338 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5339 * added a calculation of the mode to FREQUENCIES
5341 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5343 * moved (un)defs of DEBUGGING to config.h
5345 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
5347 * groff-font.c: (add_kern) Fix indentation.
5348 (add_kern) Use & instead of % to take power-of-2 modulus.
5349 (font_get_kern_adjust) Likewise.
5351 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
5353 * autorecode.c: (recode) Replace stupid use of memcpy() by
5355 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
5356 (hash_numeric_value) Ditto.
5357 (autorecode_proc_func) pool_strdup() was wrong here because the
5358 source string was not null-terminated. Use new pool_strndup()
5361 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
5362 use of hsh_iterator_init().
5364 * data-in.c: (parse_N) Initialize i->v->f.
5366 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
5369 * groff-font.c: Use power-of-2 hash table sizes, not prime.
5370 (groff_read_font) Don't call hsh_next_prime(). Don't call
5372 (static var hash) Remove `size_p', `max_used' members.
5373 (font_char_name_to_index) Don't call hsh_next_prime(). Use
5374 hsh_hash_string() instead of hashpjw(), & instead of %.
5375 (default_font) Don't call hsh_next_prime().
5377 * pool.c: (pool_strndup) New function.
5378 (pool_strdup) Reimplement in terms of pool_strndup.
5380 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
5382 (hash_ps_encoding) Use hsh_hash_string().
5383 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
5384 (hash_filename2font) Use hsh_hash_string().
5386 * som.c: Add #include <stdlib.h>.
5388 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
5389 (by destroying its pool).
5391 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
5393 Miscellaneous hash table code cleanup:
5395 * hash.h: (struct hsh_table) Moved into hash.c.
5396 (hsh_count) Ditto, and transformed into function.
5397 (hsh_compare_func) New typedef, used for defining otherwise-long
5398 function types here and in hash.c
5399 (hsh_hash_func) Ditto.
5400 (hsh_free_func) Ditto.
5402 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
5403 `table' to `entries'. Removed `mp'. All references updated.
5404 (hsh_clear) Don't shrink entries array; if the hash was this big
5405 once, it probably will be again.
5406 (hsh_rehash) Made static.
5407 (force_hsh_insert) Renamed hsh_force_insert.
5408 (force_hsh_find) Renamed hsh_force_find.
5410 Made hash table sizes powers of 2, because that's fine with any
5411 reasonable hash function and because taking a power-of-2 modulus
5412 is faster than any other:
5414 (hsh_prime_tab) Removed;
5415 (hsh_next_prime) Ditto.
5416 (next_power_of_2) New function.
5417 (hsh_create) Use next_power_of_2.
5418 (hsh_rehash) Use & instead of %.
5420 Cleaned up hsh_sort:
5422 (internal_comparison_fn) Removed.
5423 (sort_nulls_last) New function.
5424 (hsh_sort) Removed second parameter, switched to using the new
5425 quicksort() function from quicksort.h to avoid using nasty need
5426 for static variables with qsort(). All references updated.
5428 Changed the hash functions offered, because there are better hash
5429 functions than the ones we had, and cleaned up the names to boot:
5431 * hash.c: (hashpjw_d) Removed.
5433 (hsh_hash_bytes) New function.
5434 (hsh_hash_string) New function.
5435 (hsh_hash_int) New function.
5437 Improved the hash table iteration interface:
5439 * hash.h: (hsh_iterator_init) Removed.
5440 (struct hsh_iterator) Removed `init' member, change `next' to
5443 * hash.c: (hsh_foreach) Removed. All references updated to use
5444 hsh_first/hsh_next instead.
5445 (hsh_first) New function. Notably, unlike hsh_foreach() it does
5446 not treat a null pointer as an empty hash table.
5447 (hsh_next) New function.
5449 Made deletion possible, though slow:
5451 * hash.c: (locate_matching_entry) New function.
5452 (hsh_find) Use locate_matching_entry().
5453 (hsh_delete) New function also using locate_matching_entry().
5454 (hsh_force_delete) New function.
5456 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
5458 * quicksort.c: New file implementing a sort routine with a
5459 interface better than qsort() because it passes a user-provided
5460 parameter to the sort routine.
5462 * Makefile.am: Add quicksort.c, quicksort.h.
5464 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
5466 * All source files: Get rid of nasty special cases for Checker,
5467 which is pretty obsolete now.
5469 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
5471 * Fixed a bug apparent when using the FREQUENCIES command with the
5472 html driver. The html driver was incorrectly trying to display
5475 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
5477 * Makefile.am: Reorganized. Put locale dir in version.c instead
5478 of passing it to each compile command. Only put local gmp libs in
5479 LD_ADD if not installed on system. Remove `boast' target.
5481 * All source files: struct and union typedefs eliminated.
5482 `sizeof type' replaced by `sizeof object' where practical. Moved
5483 `unused' qualifiers from start to end of declarations for gcc
5484 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
5485 assertions on pointers strictly compliant. Removed _ prefixes on
5486 some function parameter names.
5488 * alloc.c: New source file, containing these external linkage
5489 functions removed from common.c: xmalloc, xcalloc, xrealloc,
5496 * ascii.c: Migrated from arenas to pools.
5497 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
5498 c_string to len_string. All references changed.
5499 (ascii_option) Signature changed to comply to new output.c
5501 (count_fancy_chars) Removed.
5502 (delineate) Removed support for rich text.
5503 (ascii_text_metrics) Ditto.
5505 (output_shorts) Change `box', `off', `on' from c_string to
5506 len_string. Change `remaining' from int to size_t.
5507 (ascii_close_page) Make page numbering less haphazard.
5509 * autorecode.c: Migrate from arenas to pools.
5511 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
5513 * bitvector.h: New file containing these macros from misc.h:
5514 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
5516 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
5517 word[3]. ncmd removed.
5518 (var empty_string) Removed.
5519 (var cmd_table) Declaration updated.
5520 (var cmdtab) Removed.
5521 (cmp_command) Removed.
5522 (split_words) Rewritten to use strtok_r().
5523 (init_cmd_parser) Renamed cmd_init(). Rewritten.
5524 (find_command) Removed.
5525 (FILE_TYPE_okay) Rewritten.
5526 (cmd_parse) Rewritten. Semantics of the return value of command
5527 handlers has changed: they must now return one of the new CMD_*
5528 enumerals, rather than a magic value. This meant that all
5529 commands had to be modified, and they were.
5530 (figure_out_command) New function.
5532 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
5533 #defines for INIT, INPU, etc.
5535 * command.h: New CMD_* enum series.
5536 (cur_proc) Make const char *, not char *.
5537 (cmd_init) Prototype.
5540 * common.c: Removed.
5542 * common.h: Removed.
5544 * correlations.q: New file.
5546 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
5548 (custom_tables) Renamed crs_custom_tables().
5549 (custom_variables) Renamed crs_custom_variables().
5550 (calc_integer) Add in some `const' qualifiers.
5551 (table_value_missing) Change from a_string to len_string.
5552 (float_M_suffix) Change from a_string to len_string.
5554 * data-in.c: Rewritten. All references to
5555 parse_string_as_format() changed to data_in().
5557 * data-in.h: New file.
5559 * data-list.c: Change DLS_* from #define's to enums. Move from
5560 rpd_msg() to tmsg().
5561 (RPD_ERR) New #define.
5562 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
5564 (read_from_data_list_fixed) Change from old
5565 parse_string_as_format() to new data_in().
5566 (read_from_data_list_free) Ditto.
5567 (read_from_data_list_list) Ditto.
5568 (cmd_repeating_data) Modify approach to checking for end of
5571 (rpd_parse_record) Change from old parse_string_as_format() to new
5572 data_in(). Change from old convert_format_to_string() to new
5574 (read_one_set_of_repetitions) Change dfm_push_cust() to
5575 dfm_push(), pop_cust() to dfm_pop().
5577 * data-out.c: Rewritten. All references to
5578 convert_format_to_string() changed to data_out().
5580 * descript.q: Migrate to new q2c.
5581 (cmd_descriptives) Removed.
5582 (internal_cmd_descriptives) Renamed cmd_descriptives ().
5583 (custom_variables) Renamed dsc_custom_variables().
5585 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
5587 (open_file_r) Initialize h->where.line_number. Migrate to new
5589 (open_file_w) Initialize h->where.line_number.
5590 (read_record) Change from ext->ln to h->where.line_number.
5591 Migrate to struct string.
5592 (dfm_put_record) Rephrased.
5593 (dfm_push_cust) Renamed dfm_push(), rewritten.
5594 (dfm_pop) New function.
5596 * error.c: All references updated.
5597 (glob var error_count) Renamed err_err_count.
5598 (glob var warning_count) Renamed err_warning_count.
5599 (glob var error_already_flagged) Renamed err_already_flagged.
5600 (glob var verbosity) Renamed err_verbosity.
5601 (glob var cust_fn) Removed.
5602 (glob var cust_ln) Removed.
5603 (static var file_loc) New.
5604 (static var nfile_loc) New.
5605 (static var mfile_loc) New.
5606 (tmsg) New function.
5607 (push_cust) Removed.
5610 (static var terminating) Removed.
5611 (failure) Renamed err_failure().
5612 (hcf) Renamed err_hcf().
5613 (err_push_file_locator) New function.
5614 (err_pop_file_locator) New function.
5615 (err_location) New function.
5616 (check_error_count) Renamed err_check_count().
5617 (vmsg) Renamed err_vmsg(). Interface changed.
5618 (verbose_msg) Removed.
5619 (err_cond_fail) New function.
5620 (error_break) Renamed err_break().
5622 * error.h: All references updated.
5623 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
5624 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
5626 (struct file_locator) New.
5628 (macro verbose_msg) Removed.
5629 (macro cond_fail) Removed.
5631 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
5633 * expr-prs.c: Reorganized. All references updated.
5634 (exprtypename) Renamed expr_type_name().
5635 (typename) Renamed type_name().
5636 (free_expression) Renamed expr_free().
5637 (parse_expression) Renamed expr_parse(). Uses new type_check()
5639 (init_functab) Renamed init_func_tab().
5640 (type_check) New function.
5641 (parse_or) Rewritten to use new allocate_nonterminal() and
5642 append_nonterminal_arg() functions.
5645 (parse_rel) Ditto. Also simplified logic.
5650 (SYSMIS_func) Ditto.
5651 (VALUE_func) Rephrased.
5652 (CONCAT_func) Fix memory leak by replacing free by free_node on
5654 (generic_str_func) Ditto.
5655 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
5657 (allocate_nonterminal) New function.
5658 (append_nonterminal_arg) New function.
5659 (static func_tab[]) Now at file level.
5661 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
5663 * expr.h: (enum series OP_*) Moved to exprP.h.
5664 (OP_* defines) Ditto.
5665 (struct op_desc) Ditto.
5666 (global ops[]) Ditto.
5667 (struct num_con_node) Ditto.
5668 (struct str_con_node) Ditto.
5669 (struct var_node) Ditto.
5670 (struct lag_node) Ditto.
5671 (struct casenum_node) Ditto.
5672 (struct nonterm_node) Ditto.
5673 (union any_node) Members renamed.
5674 (struct sys_node) Removed.
5675 (struct val_node) Removed.
5676 (operator typedef) Removed.
5677 (typedef exprtype) Removed.
5678 (enum series EX_*) Moved to exprP.h.
5679 (struct expression) Ditto. Also renamed a lot of the members.
5680 (PXP_* defines) Changed to enums.
5681 (free_node prototype) Moved to exprP.h.
5683 * file-handle.h: (struct file_handle) New member `where'.
5685 * file-handle.q: Migrated to new q2c format.
5686 (prepend_current_directory) Removed (dead code).
5687 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
5688 (fh_get_handle_by_filename) Removed dead code.
5689 Set new `where' member.
5691 * file-type.c: (file_type_source_read) References to
5692 parse_string_as_format() changed to data_in().
5693 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
5695 * filename.c: All references updated.
5696 (init_filename) Renamed fn_init().
5697 (expand_line) Removed.
5698 (macro EXPAND_LINE) Removed.
5699 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
5700 of custom functions.
5701 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
5702 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
5703 (normalize_filename) Renamed fn_normalize().
5704 (search_path) Renamed fn_search_path(), rewritten.
5705 (prepend_dir) Renamed fn_prepend_dir().
5706 (blp_getenv) Renamed fn_getenv().
5707 (blp_dirname) Renamed fn_dirname().
5708 (fn_basename) New function, not used.
5709 (absolute_filename_p) Renamed fn_absolute_p().
5710 (is_special_filename) Renamed fn_special_p().
5711 (file_exists) Renamed fn_exists_p().
5712 (readlink_malloc) Renamed fn_readlink().
5713 (getenv_default) Renamed fn_getenv_default().
5714 (open_file) Renamed fn_open().
5715 (close_file) Renamed fn_close().
5716 (open_file_ext) Renamed fn_open_ext().
5717 (close_file_ext) Renamed fn_close_ext().
5719 * font.h: Migrate from arenas to pools.
5721 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
5723 * frequencies.g: Migrate from arenas to pools.
5725 * frequencies.q: Migrate to new q2c version. Migrate from arenas
5728 * getline.c: All references updated.
5729 (global getl_buf) Changed from char * to struct string.
5730 (static getl_include_path) Ditto.
5731 (global getl_buf_len) Removed.
5732 (global getl_buf_size) Removed.
5733 (getl_include_path) Deal with new getl_buf, getl_include_path.
5734 (getl_uninitialize) New function.
5735 (getl_get_current_directory) Rewritten.
5736 (getl_clear_include_path) Rewritten.
5737 (getl_add_include_dir) Rewritten.
5738 (getl_add_file) Assertion fixed.
5739 (getl_add_virtual_file) Change initial value of `remaining_loops'
5741 (welcome) Rewritten.
5742 (handle_line_buffer) Make static. Change logic to make
5743 getl_add_virtual_file() change sensible. Use ds_*() strings.
5744 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
5745 (getl_close_file) Moved.
5746 (getl_location) New function.
5748 * getline.h: All references updated.
5749 (macro curln) Removed.
5750 (macro curfn) Removed.
5751 (macro am_interactive) Renamed getl_am_interactive.
5752 (macro am_reading_script) Renamed getl_reading_script.
5754 * glob.c: (global fmt_parse_ignore_error) Removed.
5755 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
5756 systems that support it (C99). Turn off SET ECHO by default. No
5757 necessary julcal initialization anymore.
5759 * groff-font.c: Migrate from arenas to pools.
5760 (groff_read_font) Use err_push_file_locator().
5761 (groff_read_DESC) Ditto.
5762 (font_msg) Use tmsg().
5764 * hash.c: (hsh_sort) Fix debug code.
5765 [GLOBAL_DEBUGGING] Include stdio.h.
5767 * hash.h: (macro force_hsh_insert) Rephrase.
5769 * heap.c: Rewritten.
5771 * heap.h: Rewritten.
5773 * html.c: (html_option) Change from outp_value to struct string.
5774 (postopen) Change from curfn to getl_location().
5775 (escape_string) Remove rich-text code. Signature changed.
5776 (output_tab_table) Switch from a_string to struct len_string.
5777 Remove rich text support.
5779 * lexer.c: All references updated. Largely rewritten. Major
5780 changes listed below. Removed tagged quote support. Adapted to
5781 struct string tokstr.
5782 (global tokstr) Changed to struct string.
5783 (global tokstr_size) Removed.
5784 (global tokstr_len) Removed.
5786 (global tokint) Removed.
5787 (global toklongstr) Removed.
5788 (C* defines) Removed.
5789 (static tbl[]) Removed.
5790 (static id[]) Removed.
5791 (static une[]) Removed.
5792 (discard_line) Renamed lex_discard_line().
5793 (get_entire_line) Renamed lex_entire_line().
5794 (get_rest_of_line) Renamed lex_rest_of_line().
5795 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
5796 (make_hexit) Removed.
5797 (syntax_error) Renamed lex_error(). Return value removed.
5798 (get_token_representation) Renamed lex_token_representation().
5799 (putback) Renamed lex_put_back().
5800 (putfwd) Renamed lex_put_forward().
5801 (convert_negative_to_dash) Renamed lex_negative_to_dash().
5802 (set_prog) Renamed lex_set_prog().
5803 (init_lex) Renamed lex_init().
5804 (reset_eof) Renamed lex_reset_eof().
5805 (lookahead) Renamed lex_look_ahead().
5806 (check_id) Rewritten.
5807 (yylex) Renamed lex_get(), rewritten.
5808 (lex_end_of_command) New function. Many commands were rephrased
5810 (lex_integer_p) New function. Replaces compare of tokint against
5812 (lex_integer) New function. Replaces tokint.
5813 (match_tok) Renamed lex_match().
5814 (match_id) Renamed lex_match_id().
5815 (match_int) Renamed lex_match_int().
5816 (force_match_id) Renamed lex_force_match_id(), added return value.
5817 (force_match) Renamed lex_force_match(), added return value.
5818 (force_string) Renamed lex_force_string(), added return value.
5819 (force_int) Renamed lex_force_int(), added return value.
5820 (lex_id_match_len) New function.
5821 (id_match) Renamed lex_id_match(), rewritten.
5822 (get_line) Renamed lex_get_line().
5823 (preprocess_line) Renamed lex_preprocess_line().
5824 (tokname) Renamed lex_token_name().
5825 (bin_value_func) Removed.
5826 (oct_value_func) Removed.
5827 (hex_value_func) Removed.
5828 (unexpected_eof) New function.
5829 (convert_numeric_string_to_char_string) New function.
5830 (parse_string) Rewritten, signature changed.
5831 (add_tokstr_char) Removed.
5832 (add_tokstr_unsigned) Removed.
5833 (add_tokstr_string) Removed.
5834 (parse_tagged_quote) Removed.
5835 (skip_comment) Renamed lex_skip_comment().
5837 * lexer.h: All references updated.
5838 (macro is_id1) Renamed CHAR_IS_ID1.
5839 (macro is_idn) Renamed CHAR_IS_IDN.
5840 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
5841 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
5842 (macro get_token) Removed.
5843 (macro id_match) Removed.
5844 (macro force_match_id) Removed.
5845 (macro force_match) Removed.
5846 (macro force_string) Removed.
5847 (macro force_int) Removed.
5848 (macro force_num) Removed.
5849 (macro force_id) Removed.
5851 * lexerP.h: Removed.
5853 * list.q: Migrated to new q2c format.
5854 (write_line) Deal with struct len_string.
5855 (write_varname) Ditto.
5856 (write_fallback_headers) Ditto.
5858 * magic.c: New file, incorporating the following global variables
5859 previously in other files: endian, second_lowest_value. And both
5860 of those are conditional on #define's.
5862 * magic.h: New file, incorporating the following global variable
5863 declarations: endian, second_lowest_value, and the following macro
5864 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
5866 * main.c: Added declarations of pgmname, finished, curdate,
5868 (main) Call new parse_script() function.
5869 (parse_script) New function.
5870 (execute_command) New function.
5871 (dump_token) Removed.
5872 (handle_error) New function.
5874 * matrix.c: New file.
5876 * matrix.h: New file.
5878 * matrix-data.c: Migrated from arenas to pools.
5879 (mget_token) Change from parse_string_as_format() to data_in().
5881 * means.q: Migrate to new q2c.
5882 (custom_tables) Renamed mns_custom_tables().
5883 (custom_crossbreak) Renamed mns_custom_crossbreak().
5884 (custom_variables) Renamed mns_custom_variables().
5886 * mis-val.c: (static var width) Changed from `int' to `size_t'.
5887 (parse_varnames) Prototype.
5888 (parse_numeric) Rephrasings.
5889 (parse_alpha) Adapt to new struct string tokstr.
5891 * misc.c: (intlog10) Rewritten.
5893 (ansi_rand) Renamed real_rand(), moved into random.c.
5894 (ansi_srand) Renamed real_srand(), moved into random.c.
5895 (setup_randomize) Moved to random.c.
5896 (rand_uniform) Ditto.
5897 (rand_normal) Ditto.
5898 (rand_simple) Ditto.
5899 (get_config_line) Removed.
5900 (reverse) Removed (dead code).
5902 * misc.h: (macro SET_BIT) Moved to bitvector.h.
5903 (macro CLEAR_BIT) Ditto.
5904 (macro TEST_BIT) Ditto.
5905 (macro SET_BIT_TO) Ditto.
5906 (macro BIT_INDEX) Ditto.
5908 * output.c: (outp_read_devices) Move to err_push_file_locator()
5909 from push_cust(). Use struct string.
5910 (expand_op_tokstr) Removed.
5911 (static var op_tokstr) Changed to struct string.
5912 (static var op_tokstr_size) Removed.
5913 (tokener) Rephrasings. Use struct string.
5914 (parse_options) Use struct string.
5915 (destroy_driver) Fix assertion.
5916 (outp_get_paper_size) Move to err_push_file_locator().
5917 [0] Removed dead code.
5918 (outp_string_width) Move to len_string.
5920 * output.h: Comment fixes.
5921 (TAG_* enum series) Removed.
5922 (struct outp_value) Removed.
5923 (enum OUTP_T_FANCY) Removed.
5924 (struct outp_text) `s' changed from a_string to len_string.
5925 (struct outp_class) `option' change arg 3 from outp_value to
5928 * pfm-read.c: (corrupt_msg) Rewritten.
5930 * pfm-write.c: (bufwrite) Fix assertion.
5932 * pool.c: New file, reference version.
5934 * pool.h: New file, reference version.
5936 * postscript.c: (ps_font_sizes) Fix assertion.
5937 (ps_option) Change arg 3 from outp_value to struct string.
5938 Adapt to struct string.
5939 (macro output_line) Removed.
5940 (macro add_string) Removed.
5941 (output_encodings) Adapted to struct string. Moved to
5942 err_push_file_locator().
5943 (find_encoding_file) Fix assertion.
5944 (read_ps_encodings) Move to err_push_file_locator().
5945 (postopen) Use getl_location() instead of curfn.
5946 (out_text_plain) Move to len_string.
5947 (text) Ditto. Remove rich text support.
5949 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
5950 (cmd_print_eject) Ditto.
5952 (internal_cmd_print) Now cleans up after itself. Uses
5953 fh_parse_file_handle() now.
5954 (cmd_print_space) Use PXP_NUMERIC to type-check.
5956 * q2c.c: Overhauled. Removed _("") i18n support. All references
5957 updated. All output functions updated to handle structures rather
5958 than local or static variables. Adapt to new PSPP lex_*()
5962 (macro MAX_N_SBC) Removed.
5963 (global bare) Removed.
5964 (enum STRING) Renamed T_STRING.
5965 (enum ID) Renamed T_ID.
5966 (get_buffer) Buffer size increased.
5967 (strlower) Renamed st_lower(), rephrased.
5968 (strupper) Renamed st_upper(), rephrased.
5969 (skip_ws) New function.
5970 (get_line) Don't special-case any types of lines (like those
5971 beginning with ! or $, for instance).
5972 (get_token) Renamed lex_get(). Rephrased.
5973 (static var `prefix') New.
5974 (parse) New function.
5975 (parse_setting) Minor rephrasing.
5976 (dump_specifier_vars) Ditto.
5977 (make_identifier) Put null terminator on identifier, duh.
5978 (dump_vars) Renamed dump_declarations(). Never indent. Never
5979 static. Output changed entirely.
5980 (dump_specifier_init) Rephrase.
5981 (dump_vars_init) No index variable needed. Other modifications.
5982 (dump_parser) Don't parse command name. Do dump functions instead
5983 of just code fragments.
5984 (dump_free) Dump function instead of code fragment.
5985 (recognize_directive) New function.
5986 (main) Use recognize_directive(). Don't rely on magic $ line
5987 beginning: instead, parse comments. Update list of headers.
5989 * random.c: New file, containing the following functions:
5990 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
5991 rand_normal, rand_simple.
5993 * random.h: New file.
5995 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
5996 function. `max_src_width', `max_dst_width' changed to size_t.
5997 (internal_cmd_recode) Removed.
5998 (parse_dest_spec) Merge similar cases.
5999 (parse_src_spec) Add assertion.
6001 * repeat.c: (recognize_keyword) New function.
6002 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
6003 REPEAT. Improve recognition of END REPEAT (use
6004 recognize_keyword()). Move from curfn to getl_location(). Use
6007 (perform_DO_REPEAT_substitutions) Adapt to struct string.
6009 * set.q: Adapt to new q2c.
6010 (cmd_set) Range-check some values better.
6011 (custom_blanks) Renamed stc_custom_blanks().
6012 (custom_length) Renamed stc_custom_length().
6013 (custom_results) Renamed stc_custom_results().
6014 (custom_seed) Renamed stc_custom_seed().
6015 (custom_width) Renamed stc_custom_width().
6016 (custom_format) Renamed stc_custom_format().
6017 (custom_journal) Renamed stc_custom_journal().
6018 (custom_color) Renamed stc_custom_color().
6019 (custom_listing) Renamed stc_custom_listing().
6020 (custom_disk) Renamed stc_custom_disk().
6021 (custom_log) Renamed stc_custom_log().
6022 (custom_rcolor) Renamed stc_custom_rcolor().
6023 (custom_viewlength) Renamed stc_custom_viewlength().
6024 (custom_workdev) Renamed stc_custom_workdev().
6026 * settings.h: Not necessary to include format.h any longer.
6028 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
6029 (corrupt_msg) Rewritten.
6031 * sort.c: Adapt to rewritten heap ADT.
6033 * str.c: (aa_strcpy) Removed.
6034 (ab_strcpy) Removed.
6035 (ac_strcpy) Removed.
6036 (ba_strcpy) Removed.
6037 (bb_strcpy) Removed.
6038 (ca_strcpy) Removed.
6039 (aa_strdup) Removed.
6040 (aa_strdupcpy) Removed.
6041 (ba_strdup) Removed.
6042 (sa_strdup) Removed.
6043 (memrev) Renamed mm_reverse().
6044 (memrmem) Renamed mm_find_reverse().
6045 (cmp_str) Renamed st_compare_pad().
6046 (strmaxcpy) Removed.
6047 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
6048 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
6050 (strpadcpy) Renamed st_pad_copy(), signature changed.
6051 (blpstrset) Removed.
6052 (ds_create) New function.
6053 (ds_init) New function.
6054 (ds_replace) New function.
6055 (ds_destroy) New function.
6056 (ds_clear) New function.
6057 (ds_extend) New function.
6058 (ds_shrink) New function.
6059 (ds_truncate) New function.
6060 (ds_length) New function.
6061 (ds_size) New function.
6062 (ds_value) New function.
6063 (ds_end) New function.
6064 (ds_concat) New function.
6065 (ds_concat_buffer) New function.
6066 (ds_printf) New function.
6067 (ds_putchar) New function.
6068 (ds_getline) New function.
6069 (ds_get_config_line) New function derived from the old
6070 misc.c:get_config_line().
6071 (ls_create) New function.
6072 (ls_create_buffer) New function.
6073 (ls_init) New function.
6074 (ls_shallow_copy) New function.
6075 (ls_destroy) New function.
6076 (ls_null) New function.
6077 (ls_null_p) New function.
6078 (ls_empty_p) New function.
6079 (ls_length) New function.
6080 (ls_value) New function.
6081 (ls_end) New function.
6083 * str.h: Reformatted.
6084 (struct a_string) Removed.
6085 (struct b_string) Removed.
6086 (struct c_string) Removed.
6087 (struct len_string) New.
6088 (struct string) New.
6089 (macro as_streq) Removed.
6090 (macro bs_streq) Removed.
6091 (macro cs_streq) Removed.
6092 (macro sa_streq) Removed.
6093 (macro sb_streq) Removed.
6094 [__GNUC__] (inline function ds_putchar) New function.
6095 [__GNUC__] (inline function ds_length) New function.
6096 [__GNUC__] (inline function ds_value) New function.
6097 [__GNUC__] (inline function ds_end) New function.
6099 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
6100 (display_vectors) Fix missing i18n.
6102 * t-test.q: Migrate to new q2c.
6104 * tab.c: Migrate from arenas to pools.
6105 (tab_create) Use struct len_string.
6106 (tab_realloc) Ditto.
6107 (text_format) Ditto.
6108 (tab_joint_text) Ditto.
6109 (tab_natural_width) Remove rich text support.
6110 (tab_natural_height) Ditto.
6111 (tab_output_text) Handle TAT_FIX.
6112 (tab_raw) Change arg from a_string to len_string.
6113 (tabi_driver) Fix assertion. Use struct len_string.
6114 (render_strip) Use struct len_string. Remove rich text support.
6115 Add `const' qualifiers.
6117 * tab.h: (enum TAB_RICH) Remove.
6118 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
6119 SOM_COL_* updated to read TAB_COL_*.
6120 (struct tab_table) Change arena to pool. Change a_string to
6123 * temporary.c: (restore_dictionary) Rewrite Checker code.
6125 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
6126 LOWEST, HIGHEST) Moved here from common.h.
6127 (typedef any_trns) Removed. All references changed to `struct
6130 * vars-atr.c: (force_create_variable) Fix assertion.
6131 (force_dup_variable) Fix assertion.
6133 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
6135 Using alphanumeric variables in functions under AGGREGATE
6136 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
6137 <BZN-mdksh@t-online.de> for reporting this bug.
6139 * aggregate.c: (parse_aggregate_functions) When setting the
6140 FSTRING bit, also allocate memory for the `string' member of
6142 (free_aggregate_functions) Free iter->string. Don't use the
6143 non-function bits when indexing the array of functions.
6144 [DEBUGGING] (debug_print) Don't use the non-function bits when
6145 indexing the array of functions.
6147 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
6149 Under certain circumstances, the final case would be omitted from
6150 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
6151 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6153 * aggregate.c (agr_00x_end_func): Increment number of cases in
6154 sink before writing case. For streams that keep track of how many
6155 cases there are based on this value, this means that the last case
6156 will be read in on the next stream read.
6158 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
6160 Undefined behavior was invoked by referencing a freed pointer.
6162 * vfm.c (memory_stream_write): Free pointer *after* checking for
6165 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
6167 A wrong record size was displayed when paging the active file to
6170 * vfm.c: (memory_stream_write) Fix off-by-one error.
6172 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
6174 Not having enough temporary space for sorting caused a core dump.
6177 * sort.c: (allocate_cases) Initialize i.
6179 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
6181 Syntax errors in function descriptions on AGGREGATE caused core
6184 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
6185 free_aggregate_functions(), since that function already frees
6188 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
6190 A null pointer was dereferenced, causing a core dump, when
6191 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
6192 but PSPP still doesn't calculate percentiles. Thanks to Regnor
6193 Jernsletten <rjernsle@eunet.no> for reporting this problem.
6195 * arena.c: (arena_malloc) If the arena hasn't been initialized
6196 already, initialize it.
6198 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
6200 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
6201 for compilation with Cygnus Windows B20. Not used by other
6204 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
6206 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
6207 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6209 * sort.c: (compare_case_lists) Reverse sense of comparison if
6210 sorting in descending order.
6211 (compare_record) Ditto.
6213 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
6215 SPLIT FILE with a string variable caused a core dump. Fixed.
6217 * vfm.c: If the variable is a string then make a temporary value
6218 struct pointing to it. The underlying problem is a lot bigger
6219 than this (see TODO) but this is a stopgap for the simple case at
6222 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
6224 Nested INCLUDEs didn't work. Fixed.
6226 * getline.c: (getl_include) Set first_line to NULL in allocated
6229 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
6231 The MATCH FILES procedure set the values of variables not present
6232 to 0. It should have been SYSMIS. This is now fixed.
6234 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
6236 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
6238 The REMARK command was too aggressive about skipping lines. It
6239 didn't like being the last command in a file.
6241 * command.c: (cmd_remark) Call get_entire_line() instead of
6244 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
6246 Comment parsing wasn't consistent with the rest of the code in its
6247 idea of where one command ends and another starts. This meant
6248 that sometimes commands would be mysteriously ignored. Thanks to
6249 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6251 * command.c: (parse_cmd) Hand off comment parsing to new function
6252 skip_comment() in lexer.c.
6253 * lexer.c: (skip_comment) New function.
6255 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
6257 The TABLE subcommand on MATCH FILES worked only erratically at
6258 best. This fixes it. Thanks to Dr. Dirk Melcher
6259 <BZN-mdksh@t-online.de> for reporting this bug.
6261 * get.c: (mtf_compare_BY_values) When comparing string values, a
6262 difference of 1 is still a difference :-)
6263 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
6264 advance TABLE files automatically when matched. Comment fixes.
6266 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
6268 VARIABLE LABELS rejected a slash before the first variable
6269 specification, contradicting the documentation. Thanks to Walter
6270 M. Gray <graywm@northernc.on.ca> for reporting this bug.
6272 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
6273 command specification.
6275 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
6277 Because of an incorrect optimization in memory allocation,
6278 CROSSTABS sometimes segfaulted when asked to output multiple
6279 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6282 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
6283 are passed to output_pivot_table() for its use.
6284 (output_pivot_table) Instead of assuming the number of columns is
6285 constant, keep track with maxcols. In general mode, use maxcells
6286 to determine whether more matrix cells need to be allocated.
6288 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
6290 CROSSTABS didn't display value labels for column and row
6291 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6294 * crosstabs.q: (table_value_missing) If the specified value has a
6295 value label for this variable, then show it instead of the raw
6297 (display_dimensions) Delegate display of value_labels to
6298 table_value_missing.
6300 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
6302 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
6303 <BZN-mdksh@t-online.de> for reporting this bug.
6305 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
6306 if the file isn't declared as binary.
6308 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
6310 MATCH FILES corrupted memory and dumped core on some syntax
6313 * get.c: (cmd_match_files) Set file->handle to NULL before
6315 (mtf_free_file) Don't free a null dictionary.
6317 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
6319 MATCH FILES should set numeric values not available to the
6320 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
6321 <BZN-mdksh@t-online.de> for reporting this bug.
6323 * get.c: (mtf_processing) Set unused records to system-missing,
6326 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
6328 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
6329 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
6331 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
6332 in newly created dictionary, and add each copied variable to the
6335 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
6339 * get.c: (trim_dictionary) Free variable list for KEEP after
6342 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
6344 Some systems didn't like the way open_file was coded. Thanks to
6345 Hankin <hankin@rogue.consultco.com> for pointing this out.
6347 * filename.c: (open_file) Don't try to store stdin, stdout,
6348 stderr as part of an array, because that doesn't always work.
6350 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
6352 The SAVE procedure didn't save long string variables properly.
6353 Fixed by this patch. Thanks to Hankin
6354 <hankin@rogue.consultco.com> for this patch.
6356 * sfm-write.c: (write_variable) Fix off-by-one error in writing
6357 out variable pad records.
6359 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
6361 Previously, if PRINT SPACE were given a negative argument, it
6362 would report an error, then spin in an (almost) infinite loop.
6363 This fixes that behavior.
6365 * print.c: (print_space_trns_proc) After reporting a negative
6366 argument, set number of lines to print to 1.
6368 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
6370 SPSS 8.0 outputs some new record types in its system files, and it
6371 allows longer value labels. Accept these system files.
6373 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
6374 11 emitted by SPSS 8.0.
6376 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
6378 The LIST procedure was too conservative in allocating space for
6379 buffers, which caused a bug that only showed up with very long
6380 output variables. Thanks to Hankin <hankin@dunno.com> for this
6383 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
6385 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
6387 Typo meant string format specifiers weren't checked properly. I
6388 think that Hankin <hankin@dunno.com> sent me this report, but I'm
6389 willing to be corrected on this point.
6391 * format.c: (check_string_specifier) Fix obvious typo.
6393 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
6395 Using $CASENUM in an expression didn't work. Here's a fix.
6396 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
6399 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
6401 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
6403 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
6405 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
6406 other behavior, *sigh*. This patch hopefully fixes that. This
6407 time I've actually tested it.
6409 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
6411 * data-list.c: (read_from_data_list_free,
6412 read_from_data_list_list) Call parse_string_as_format() directly
6413 without mucking around with the field width.
6415 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
6417 Occasionally, you may encounter a script that wants to be
6418 interpreted in interactive mode. Make -i emulate this behavior to
6419 allow such scripts to be executed with PSPP.
6421 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
6423 * cmdline.c: (pre_syntax_message[]) Update -i description.
6425 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
6426 when -i is given on the command line) don't treat unindented lines
6427 as starting a new command.
6429 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
6431 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
6432 mostly caused by local initialized aggregates. After egcs is
6433 fixed upstream these can be removed, but for now they're not a big
6436 * ascii.c: (ascii_postopen_driver) Checker chokes on local
6437 initialized arrays. Avoid this.
6439 * sfm-write.c: (sfm_write_dictionary) Don't use a local
6442 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
6444 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
6445 following changes avoid. Currently I compile sources with egcs
6446 1.1.1 and gcc 2.7.2.3 before sending them out.
6448 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
6450 * ascii.c: (option_tab[]) Initialize all struct members.
6452 * avl.h: (avl_traverser_init) New macro.
6454 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
6457 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
6460 * hash.c: Comment fix.
6462 * hash.h: (hsh_iterator_init) New macro.
6464 * html.c: (option_tab[]) Initialize all struct members.
6466 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
6469 * postscript.c: (option_tab[]) Initialize all struct members.
6470 (output_encodings, preclose, dump_lines) Use new
6471 hsh_iterator_init() macro.
6473 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
6476 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
6479 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
6481 * data-in.c: Examined each of the parsing functions to make sure
6482 that they wouldn't dump core if they were passed a string of the
6483 wrong length, since now the DATA LIST FREE/LIST routines don't
6484 check for field width before passing it to the data parser.
6485 (parse_RBHEX, parse_AHEX) Reject odd length input.
6486 (parse_string_as_format) Reject input that's too short or too
6489 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
6490 a field to its entire declared output width then pass it to the
6491 data-in parsing routines. This contradicted the documented
6492 behavior. This is fixed in these changes. Thanks to Mark H. Wood
6493 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
6494 free-format parsing that differed from SPSS.
6495 (cut_field) Commas and spaces are treated identically. Returns
6496 the proper column instead of a fixed 1 value.
6497 (parse_field) Removed.
6498 (read_from_data_list_free, read_from_data_list_list) Call
6499 parse_string_as_format directly instead of parse_field.
6501 * heap.c: (heap_delete) Stylistic fixes.
6503 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
6505 * loop.c: (loop_2_trns_proc) Formatting fix.
6507 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
6509 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
6511 * vfm.c: (macro FILTERED) New.
6512 (static var filter_var) New.
6513 (process_active_file_write_case) Use FILTERED.
6514 (setup_filter) Set filter_var.
6515 (close_active_file) Delete the filter if not
6516 FILTER_before_TEMPORARY.
6517 (procedure_write_case) Use FILTERED.
6519 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
6521 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
6523 * data-in.c: (parse_day_count) Message fix.
6524 (parse_month) Style fix.
6526 * data-list.c: (struct data_list_pgm) New member eof.
6527 (cmd_data_list) Init eof to 0.
6528 (do_reading) Implement the /END subcommand and read-past-eof
6531 * do-if.c: Include stdio.h when debugging.
6532 (cmd_else_if) Make sure the command is .-terminated.
6534 * glob.c: (init_glob) Capitalize the command prompt.
6536 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
6537 (end_file_trns_proc) Debugging message.
6539 * loop.c: (internal_cmd_loop) Make it work when there's no loop
6541 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
6543 * main.c: (dump_token) Make kwtab[] const.
6545 * set.q: Spelling, comment fixes.
6547 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
6550 * vars-prs.c: (fill_all_vars) Style fix.
6552 * vfm.c: (index_to_varname) Return const.
6554 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
6556 * Changes in many source files for partial -ansi -pedantic and
6557 no-debugging compliance: Remove trailing common in enum
6558 declarations; add `unused' attributes; insert some appropriate
6561 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
6563 * command.c: (shell) Make static.
6564 (run_command) Make static.
6566 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
6568 * dfm.c: (cmd_begin_data) I18n fix.
6570 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
6572 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
6574 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
6577 * file-handle.q: Don't prepend the source file directory name to
6578 the data file name. (Ongoing issue.)
6579 (prepend_current_directory) Comment out.
6580 (internal_cmd_file_handle) Don't call prepend_current_directory().
6581 (fh_get_handle_by_filename) Ditto.
6583 * filename.c: Append zero byte to readlink() return value.
6585 * getline.c: (getl_read_line) I18n fix.
6587 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
6589 * misc.h: Don't use gcc features if __STRICT_ANSI__.
6591 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
6594 * postscript.c: (output_encodings) Don't use local_strdup().
6597 * print.c: Don't use gcc features if __STRICT_ANSI__.
6599 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
6601 * recode.c: (parse_src_spec) Fully brace nested if's.
6603 * set.q: (global var set_testing_mode) New var.
6605 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
6607 * ascii.c: Add some more `unused' attributes that only come into
6608 play when NDEBUG is defined.
6609 (ascii_close_page) Set s_len when reallocating s.
6611 * crosstabs.q: (delete_missing) New function.
6612 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
6613 (make_summary_table) Create summary table reallocable.
6615 * postscript.c: Add more `unused' attributes as above.
6617 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
6618 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
6620 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
6623 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
6624 gratuitous space between parameter definition.
6626 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
6627 complaints about running off the end of functions with NDEBUG
6630 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
6632 * Several source files: Removed some PORTME notes when reflection
6633 revealed that ANSI forbids that sort of breakage. Also, added
6634 lots of `unused' qualifiers here and there.
6636 * aggregate.c: (accumulate_aggregate_info) Remove local var
6637 weighting that turned out not to be used.
6639 * avl.c: Update to version 1.1.0. Add unused specifier.
6640 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
6642 (avl_probe) Replace some instances of 1 with +1 where appropriate.
6643 (avl_find) Cast return value to void *.
6644 (avl_delete) q doesn't need to be initialized at the beginning of
6645 the function. Replace some instances of 1 with +1.
6646 (force_avl_delete) Renamed avl_force_delete, all references changed.
6647 (compare_ints) `param' marked unused.
6648 (print_int) `param' marked unused.
6649 (recurse_tree) Replace some instances of 1 with +1.
6651 * avl.h: Update to version 1.1.0. Only declares avl function
6652 types if not already declared.
6653 (AVL_MAX_HEIGHT) Only define if not already defined.
6654 (struct avl_node) New unused member char pad[2].
6655 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
6656 (force_avl_insert) Renamed avl_force_insert.
6657 (force_avl_delete) Renamed avl_force_delete.
6659 * crosstabs.q: (struct table_entry) Put `freq' into a union with
6661 (struct crosstab) Add new member `ofs'.
6662 (glob var int_tab) Removed.
6663 (custom_tables) In integer mode, assign v[i] properly through the
6665 (custom_variables) Now p.crs.max == max + 1.
6666 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
6667 (precalc) Implement integer mode.
6668 (calc_integer) Implement integer mode.
6669 (compare_table_entry) Remove unused local variable `comparing'.
6670 (make_summary_table) Implement integer mode.
6671 (macro ns_rows) Implemented as static variable now.
6672 (several variables) Made static, from global.
6673 (output_pivot_table) Use table_value_missing() for column heads.
6674 Remove several unused local variables. Implement integer mode
6675 table summing. Count up ns_rows.
6676 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
6677 (find_pivot_extent) Moved into find_pivot_extent_general; now just
6678 calls that function or find_pivot_extent_integer.
6679 (find_pivot_extent_integer) New function.
6680 (enum_var_values) Implemented for integer mode.
6681 (table_value_missing) New function.
6682 (display_dimensions) Call table_value_missing() for heads.
6683 (float_M_suffix) New function.
6684 (display_crosstabulation) Call table_value_missing() for row
6685 heads. Handle missing values in /MISSING=REPORT mode.
6686 (calc_fisher) Remove unused var N.
6687 (calc_r) Remove unused var fact.
6689 * data-list.c: (dump_fixed_table) Fix table dimensioning.
6690 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
6692 * data-out.c: (insert_commas) Remove unused var cp.
6693 (convert_CCx) Remove unused vars save_set_decimal,
6696 * descript.q: (dump_z_table) Fix table dimensioning.
6697 (pre_calc) Remove unused var j.
6698 (display) Remove unused vars title, s. Fix table dimensioning.
6700 * expr-evl.c: Comment fixes.
6702 * frequencies.q: (full_dim) New function.
6703 (dump_full) Fix table dimensioning.
6704 (condensed_dim) New function.
6705 (dump_condensed) Fix table dimensioning.
6707 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
6710 * html.c: (html_close_drive) Remove unused var i.
6711 (postopen) Remove unused vars title, curfn_len, cp.
6712 (preclose) Remove unused vars this, x.
6714 * lexer.c: Comment fixes.
6716 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
6718 * means.q: (custom_tables) Remove unused var m_dim.
6720 * mis-val.c: Format fix.
6722 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
6724 * output.c: (outp_get_paper_size) Remove unused var cp.
6726 * pfm-read.c: (read_float) Remove unused var save, unused label
6728 (read_variables) Remove unused vars cp, j.
6729 (read_value_label) Remove unused var j.
6731 * pfm-write.c: (bufwrite) Remove unused var i.
6733 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
6735 (output_encodings) Remove unused vars char_cp, n_output.
6736 (read_ps_encodings) Remove unused var ep.
6737 (postopen) Remove unused var title.
6738 (preclose) Remove unused var fp.
6739 (ps_open_page) Remove unused vars true, false, orientation,
6740 mirror_horz, mirror_vert, width, length.
6741 (ps_text_metrics) Remove unused var x.
6743 * q2c.c: (find_symbol) Remove unused var y.
6744 (parse_setting) Remove unused parameter sbc, all references
6746 (dump_parser) Remove unused var cp.
6747 (dump_free) Remove unused var i.
6749 * set.q: (static vars args, n) Removed.
6750 (internal_cmd_gset) Removed.
6752 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
6753 (read_machine_flt64_info) Removed unused var file_endian.
6754 (read_documents) Removed unused var i.
6755 (read_compressed_data) Removed unused parameter dict, all
6758 * sfm-write.c: (bufwrite) Removed unused var i.
6759 (sfm_write_case) Removed unused var i.
6761 * sort.c: (merge_once) Remove unused var t.
6762 (write_separate) #if 0 out as dead code.
6764 * split-file.c: (cmd_split_file) Remove unused var i.
6766 * sysfile-info.c: (sysfile_info_dim) New function.
6767 (cmd_sysfile_info) Fix table dimensioning.
6768 (variables_dim) New function.
6769 (display_variables) Fix table dimensioning.
6770 (describe_variable) Remove unused var prev_r.
6772 * t-test.q: (z_postcalc) Removed.
6773 (pairs_calc) Remove unused var bad_weight.
6774 (postcalc) Remove unused vars dfn, dfd.
6776 * tab.c: (tab_create) Set t->dim to NULL.
6777 (tab_dim) Make sure t->dim is NULL first.
6778 (tab_natural_width) Remove parameter `clamp'.
6779 (tab_value) Remove duplicate assertion for table.
6780 (tab_raw) New function.
6781 (nowrap_dim) New function.
6782 (wrap_dim) New function.
6783 (tab_output_text) Fix table dimensioning.
6785 * tab.h: (tab_raw) New macro.
6787 * val-labs.c: (get_label) Remove unused var type.
6788 (copy_value_labels) Remove unused var trav.
6790 * var.h: (struct crosstab_proc) Completely changed.
6792 * vars-prs.c: (parse_dict_variable) Remove unused var v.
6794 * vfm.c: (open_active_file) Remove unused vars i, lp.
6796 * weight.c: (weight_trns_proc) #if 0 out as dead code.
6798 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
6800 * Makefile.am: Add apply-dict.c, flip.c.
6802 * apply-dict.c: New file.
6804 * command.c: (struct command) Make cmd[] larger for CLEAR
6805 TRANSFORMATIONS command name.
6806 (parse_cmd) Make sure we're in a valid state before using it as an
6807 index. Discard variables and reset state on invalid transitions.
6808 (cmd_clear_transformations) New function.
6810 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
6811 Add unimplemented PRESERVE, RESTORE.
6813 * file-handle.h: Include stddef.h.
6817 * pfm-read.c: (parse_value) Pad value label values with spaces,
6820 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
6821 (sfm_close) Decrement reference count, make sure it's zero.
6822 (sfm_maybe_close) New function.
6823 (sfm_read_dictionary) Handle reference counts.
6825 * vars-atr.c: (clear_default_dict) New function.
6826 (discard_variables) Use clear_default_dict().
6828 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
6830 * Makefile.am: Add pfm-write.c.
6831 (LDADD) Add the libgmp2 libraries.
6833 * command.def: Define EXPORT.
6835 * get.c: (cmd_export) New function.
6836 (export_write_case_func) New function.
6838 * pfm-read.c: (static spss2ascii[]) Make it const.
6840 * pfm-write.c: New file.
6842 * sfm-write.c: Formatting, comment fixes.
6844 * var.h: Comment fix.
6846 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
6848 * Makefile.am: Add pfm.h, pfm-read.c.
6850 * command.def: IMPORT is now implemented.
6852 * format.c: (glob var translate_fmt[]) New var.
6854 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
6855 (cmd_import) New function.
6856 (import_source_read) New function.
6857 (glob var import_source) New var.
6859 * pfm-read.c: New file.
6863 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
6865 (dump_dictionary) Disabled printing a couple of items.
6867 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
6869 * crosstabs.q: (postcalc) Call make_summary_table().
6870 (make_summary_table) New function.
6871 (insert_summary) New function.
6872 (display_dimensions) Remove some unnecessary arguments, all
6874 (output_pivot_table) Fix lots of problems with the risk table
6876 (submit) Don't display an empty table.
6877 (display_risk) Fix order of arguments to calc_risk().
6879 * glob.c: Always include assert.h and stdlib.h.
6881 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
6884 * tab.c: (tab_create) Cosmetic changes.
6886 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
6888 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
6892 * crosstabs.q: (output_pivot_table) Headers drawing and submission
6893 code simplified, moved into new function submit().
6894 (submit) New function.
6895 (crosstabs_dim) New function.
6896 (display_directional) Substitute variable names for %s where
6898 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
6899 (calc_symmetric) Initialize parameters only if non-NULL.
6900 Calculate Somers' d.
6901 (calc_directional) Calculate Somers' d (or copy it, really).
6904 * output.c: (outp_string_width) New function.
6906 * postscript.c: (postopen) Calculate font widths based on the
6907 width of the zero '0' character, not the width of the space
6908 character. Set paper-width and paper-length based on points, not
6910 (ps_open_page) Fix page setup string for landscape mode.
6912 * som.h: (struct som_dimension) Removed.
6913 (struct som_table_class) height, width members take int * not
6916 * tab.c: Many functions now have added parameter validation.
6917 (tab_height, tab_width) These functions were removed and merged
6918 into a single function tab_resize(), and all references changed.
6919 (tab_dim) Rewritten since the interface changed; reduced from
6920 hundreds of lines to two. All callers were changed. Currently
6921 most of them just use tab_natural_dimensions as their callback and
6922 await detailed translation of functionality.
6923 (tab_natural_width) New function.
6924 (tab_natural_height) New function.
6925 (tab_natural_dimensions) New function. This is a callback
6926 function, not something that you'd want to call directly.
6927 (tab_nat_dim) Removed.
6928 (tabi_table) Allocates t->w and t->h.
6929 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
6930 dimensions callback.
6931 (evaluate_dimensions) Removed.
6932 (sum_columns) Removed.
6934 * tab.h: (enum TAL_1THIN) Removed.
6935 (enum series t_*) Removed.
6936 (struct tab_table) Members trh, trv changed to unsigned char *
6937 from int *. Member dim changed to a function pointer from a
6938 unsigned char *. Member max_stack_height removed. New members
6940 (macros tab_l, tab_r, tab_t, tab_b) New.
6942 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
6944 * ascii.c: (delineate) Assign last_space_nchars before skipping
6945 spaces, to fix right justification.
6947 * crosstabs.q: (static vars risk, direct) New vars.
6948 (static var pearson_r) Removed.
6949 (glob var chisq_fisher) Made static.
6950 (static vars row_tot[], col_tot[]) Don't include grand total
6952 (static var grand_total) Renamed W, all references changed.
6953 (output_pivot_table) Only make `table' if num_cells != 0. Make
6954 risk and directional tables. Deal with grand total no longer part
6955 of col_tot[]. Free rows and cols after we're done with them.
6956 (display_risk) New function.
6957 (display_directional) New function.
6958 (clac_r) Rewritten so that it stores all its results into its
6959 arguments, so it can be used for Spearman's correlation too.
6960 (calc_symmetric) Added a t[] argument, all references changed.
6961 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
6962 Pearson's r, Cohen's kappa.
6963 (calc_risk) New function.
6964 (calc_directional) New function.
6966 * som.c: (som_submit) Improved debugging code.
6968 * stats.c: (hypercube) New function.
6969 (cube) New function.
6971 (normal_sig) Went back to old implementation, which actually
6974 * stats.h: (macros square, cube, hypercube) Removed. The
6975 equivalent functions in stats.c are inlined here; all references
6976 to square changed to sqr.
6978 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
6980 * crosstabs.q: (N_SYMMETRIC) New define.
6981 (postcalc) Disable debug printing.
6982 (static vars chisq_fisher, pearson_r) New.
6983 (output_pivot_table) Add support for symmetric measures. Add
6984 chi-square output of exact sigs.
6985 (display_chisq) Rewritten.
6986 (display_symmetric) New function.
6987 (gamma_int) New function.
6989 (swap) New function.
6990 (calc_fisher) New function.
6991 (calc_chisq) Check boundary conditions better. Calculate Yates,
6992 Fisher, Mantel-Haenszel tests.
6993 (calc_r) New function.
6994 (calc_symmetric) New function.
6996 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
6998 (chisq_sig) Better boundary conditions. Renamed from
7001 * tab.h: (struct tab_table) New member cf.
7003 * tab.c: (tab_create) Set cf.
7004 (tab_width) New function.
7005 (tab_realloc) Handle cf.
7006 (tab_vline) Handle cf.
7007 (tab_hline) Handle cf.
7008 (tab_box) Handle cf.
7009 (tab_value) Handle cf.
7010 (tab_float) Handle cf.
7011 (tab_text) Handle cf.
7012 (tab_joint_text) Handle cf.
7013 (tab_offset) Handle cf.
7014 (tab_next_row) Handle cf.
7015 (evaluate_dimensions) Handle cf.
7016 (render_strip) Handle cf.
7018 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
7020 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
7021 output_pivot_table().
7022 (output_pivot_table) Moved lots of local variables outside and
7023 made them static. Add beginnings of chi-square statistic
7024 support. Now column and row totals aren't in the main matrix.
7025 Always zero out any leftover rows & columns after we're done with
7026 the table entries. Move all output stuff into
7027 display_dimensions(), display_crosstabs(), display_chisq().
7028 (display_dimensions) New function.
7029 (display_crosstabulation) New function.
7030 (display_chisq) New function.
7031 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
7033 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
7034 references, simplify logic.
7036 * postscript.c: Remove scale, translate-x, translate-y,
7037 mirror-horz, mirror-vert, rotate-180 options.
7038 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
7039 All references deleted.
7040 (macro YT) New macro.
7041 (array option_tab[]) Removed options.
7042 (ps_option) Removed options.
7043 (ps_open_page) Write page setup explicitly to output file, without
7044 using now-deleted BP function.
7045 (macro dump_line) Use YT().
7046 (macro dump_thick_line) Use YT().
7047 (draw_headers) Use YT().
7048 (switch_font) Reorder arguments to SF function.
7049 (write_text) Use YT().
7051 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
7054 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
7056 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
7057 null-debugging code.
7058 (tab_realloc) Remove null-debugging code. Initialize new regions
7060 (tab_vline) Support offsets.
7061 (tab_hline) Support offsets.
7062 (tab_box) Support offsets.
7064 (tab_nulls) Removed.
7067 (evaluate_dimensions) Remove null-debugging code. Understand
7068 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
7069 TAB_EMPTY not present.
7071 * tab.h: New cell attribute TAB_EMPTY.
7072 (macros tab_nr, tab_nc, tab_row, tab_col) New.
7074 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
7075 try to read them from system files.
7077 * vfm.c: (dump_splits) Don't call tab_null().
7079 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
7081 * crosstabs.q: (struct crosstab) Added `missing' member.
7082 (custom_tables) Init missing.
7083 (calc_general) Handle missing values.
7084 (calc_chisq) New function.
7085 (output_pivot_table) Start work on chi-square output. Update for
7086 new tab offset support functions. Shorten statistic names.
7088 * Several files: add in more `const's to placate gcc's warnings.
7090 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
7093 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
7094 tab_null, tab_nulls, tab_value, tab_float, tab_text,
7095 tab_joint_text) Add col_ofs and row_ofs support.
7096 (tab_offset) New function.
7097 (tab_next_row) New function.
7098 (tab_row) New function.
7099 (tab_col) New function.
7100 (tabi_table) Add col_ofs and row_ofs support.
7102 * vars-atr.c: (is_system_missing) New function.
7104 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
7106 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
7107 (static var no_cells) Removed.
7108 (static var num_cells) New.
7109 (static var expected) New.
7110 (static var cells[]) New.
7111 (internal_cmd_crosstabs) Deal with new variables.
7112 (postcalc) Removed most of the meat and put it in new function
7113 output_pivot_table().
7114 (output_pivot_table) Calculates and outputs an entire pivot table.
7116 * postscript.c: (postopen) Fix problems with free()ing addresses
7117 not obtained from malloc().
7119 * som.c: (som_submit) Add assertion.
7121 * sysfile-info.c: (describe_variable) Use new tab_nulls()
7124 * tab.c: (static var tab_names[]) New.
7125 (tab_realloc) -1 for nc or nr indicates no change.
7126 (tab_nulls) New function.
7127 (tab_dim) Use tab_names[].
7128 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
7129 (evaluate_dimensions) Don't terminate on uninited cells, just put
7130 an X in them and emit a notice. Use tab_names[].
7132 * tab.h: Move bits into tab.def.
7134 * tab.def: New. Don't try to declare tab_table_class because then
7135 som.h has to be included.
7137 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
7139 * command.def: New file, contains all the command definitions
7140 previously included bodily in command.c.
7142 * format.def: New file, contains all of the format definitions
7143 previously split across format.h, format.c, and sfm-write.c.
7145 * lexer.h: Renamed from tokens.h in order to match corresponding
7148 * lexerP.h: Moved some rarely used functions exported by lexer.c
7151 * Makefile.am: Commemorate renamed files.
7152 (EXTRA_DIST) Add command.def, format.def.
7154 * command.c: [0] (walk_cmdtable_func) Removed.
7156 * crosstabs.q: (postcalc) Made it work and print out matrices
7158 (enum_column_values) Renamed enum_var_values, generalized for any
7161 * format.h: (struct fmt_desc) New member `spss'.
7163 * q2c.c: (main) Generated code includes lexer.h instead of
7166 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
7167 instead of an independent translation table.
7169 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
7171 * Lots of source files: Added const to declarations.
7173 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
7175 * arena.c: (arena_clear) Set prev pointer to null when done.
7177 * ascii.c: (ascii_option) Rename index as indx.
7179 * avl.c: This is now a separate library called libavl.
7180 (xmalloc) Make static.
7181 (avl_probe) Step A7 can use the cache instead of an explicit
7183 (avl_delete) Don't maintain a q pointer because it's always
7184 available in the pointer stack. Comment fix.
7186 * avl.h: This is now a separate library called libavl.
7188 * command.c: (cmd_table[]) Remove spurious trailing "".
7190 * common.h: Only include random() fix if this system needs it.
7192 * crosstabs.q: Include alloca headers.
7193 (n_sorted_tab) New global var.
7194 (postcalc) Mostly rewritten.
7195 (find_pivot_extent) Rewritten.
7196 (enum_column_values) Rewritten.
7198 * data-out.c: (convert_F) Rename inner n as n_spaces.
7200 * error.c: (dump_message) Don't have an outer var i.
7202 * file-handle.q: (static var f) Removed. All references removed.
7203 (internal_cmd_file_handle) Uses a local variable instead of f.
7205 * get.c: (trim_dictionary) Change scope of i, i1, i2.
7206 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
7209 * getline.h: Declare getl_history as extern. Reported by
7210 palme@uni-wuppertal.de (Hubert Palme).
7212 * postscript.c: (postopen) Some large mods for constness.
7214 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
7217 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
7219 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
7220 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
7223 * avl.c, avl.h: New files. These form a clean-room
7224 reimplementation of avllib. Iterative algorithms are used in
7225 place of recursive ones, so there is no resemblance in the code.
7227 * Lots of headers: Don't include other headers by default.
7229 * Lots of source files: Explicitly include all needed headers.
7231 * arena.c: (arena_clear) New function.
7233 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
7234 (static var ar) Removed.
7235 (staitc vars ar_tc, ar_col) New.
7236 (cmd_crosstabs) Destroy the arenas.
7237 (internal_cmd_crosstabs) Create the arenas.
7238 (precalc) Don't need a free function for the hash.
7239 (calc_general) Make sure to zero out the trailer on the key data
7241 (print_table_entries) Updated.
7242 (postcalc) Worked on actually implementing.
7243 (find_pivot_extent) New function.
7244 (compare_value) New function.
7245 (enum_column_values) New function.
7247 * data-in.c: (parse_month) Make local array `static const'.
7249 * data-out.c: (convert_date) Make local array `static const'.
7250 (convert_WKDAY) Same.
7251 (convert_MONTH) Same.
7253 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
7254 been renamed to avl_walk().
7256 * hash.c: Rewritten more efficiently.
7258 * hash.h: Add attribute const to hsh_next_prime declaration.
7260 * lexer.c: (id_match) Make arguments const.
7262 * postscript.c: (ps_postopen_driver) Make default fonts the
7265 * q2c.c: (main) Generated code needs stdlib.h.
7267 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
7268 initialized to 0 now, not to NULL. All other references to
7269 avl_traverser were updated in the same way.
7271 * tokens.h: Macro version of id_match updated to use const
7274 * val-labs.c: (inc_ref_count) New function.
7275 (copy_value_labels) Simply through use of new avl_copy() function.
7277 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
7279 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
7280 (postcalc) Worked on this.
7282 * postscript.c: (OPO_DOUBLE_LINE) New enum.
7283 (struct ps_driver_ext) New line_width_thick member.
7284 (ps_preopen_drive) Init line_width_thick.
7285 (option_tab[]) Add line-* options.
7286 (ps_option) Parse line-* options.
7287 (postopen) Add line_width_thick support. Strip leading spaces on
7288 prologue output lines.
7289 (ps_open_page) Include line_width_thick in output.
7290 (macro dump_thick_line) New.
7291 (dump_fancy_line) Support thick lines as well as double lines.
7293 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
7295 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
7296 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
7298 * Many source files: Rename `options' to `pv_opts' as appropriate.
7300 * command.c: (static var cmd_table[]) Add CROSSTABS command.
7302 * common.c: (xcalloc) New function.
7304 * crosstabs.q: New file. Not finished yet, though.
7306 * data-list.c: Comment fix.
7308 * error.c: Remove some old Checker cruft.
7310 * frequencies.q: (dump_full) Cumulate valid percent instead of
7313 * getline.c: Comment fix.
7315 * hash.c: Comment fixes.
7317 * hash.h: (struct hsh_table) Make hash functions return unsigned
7318 instead of int to avoid problems with taking the modulo of
7319 negative return values. All references changed.
7321 * misc.c: (intlog10) Make its table static const instead of auto.
7323 * sfm-read.c: (read_header) Make `prefix' static const instead of
7326 * var.h: (union value) Add member `hash'.
7327 (struct variable) Rename prv_index as `foo'--all references
7329 (typedef pv_opts) Removed. All references changed.
7331 * vars-prs.c: (parse_variables) Message fixes.
7333 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
7335 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
7336 they are being inserted. Don't check for BY variables of
7337 different types. Discard variables if the active file isn't
7338 included in the merge.
7339 (mtf_processing) Essentially rewritten.
7340 (mtf_merge_dictionary) Check for master/slave variables of
7341 different types/widths.
7343 * vfm.c: (static var not_canceled) New var.
7344 (process_active_file) Don't call vfm_source->read() if
7345 there's no vfm-source. Initialize not_canceled.
7346 (process_active_file_write_case) Honor and update not_canceled.
7347 (prepare_for_writing) Rollback changes from yesterday, they were
7349 (close_active_file) Don't destroy vfm_source unless it exists.
7351 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
7353 * Lots of source files: Added { } around nested if/else constructs
7354 to avoid new gcc 2.8 warnings.
7356 * data-in.c: (parse_Z) Declare `int' type explicitly.
7359 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
7360 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
7361 prev members. Put TABLEs at the end of the chain and FILEs at the
7362 beginning. Don't allow the active file in STATE_INIT. Use proper
7363 `seen' value for the active file. Fill out the by members and
7364 make sure they're of consistent type. Do the actual merge
7366 (mtf_processing_finish) New function.
7367 (var_type_description) New function.
7368 (mtf_free_file) New function.
7369 (mtf_free) Rewritten.
7370 (mtf_delete_file_in_place) New function.
7371 (mtf_read_nonactive_records) New function.
7372 (mtf_compare_BY_values) New function.
7373 (static var mtf_seq_no) New var.
7374 (mtf_processing) New function.
7375 (mtf_merge_dictionary) Assign nval members for the system file
7376 dictionary. Assign fv values for its variables. Point each slave
7377 variable to the corresponding master variable.
7379 * hash.c: Include str.h.
7381 * mis-val.c: (copy_missing_values) src arg is const.
7383 * misc.c: (spacing) Make `max' var explicitly int.
7385 * sfm-read.c: (dump_dictionary) Message reformatting.
7386 (sfm_read_case) Add assertion.
7388 * sort.c: Esthetic fixes.
7390 * var.h: (struct match_files_proc) New struct.
7391 (struct variable) Add private data match_files_proc.
7393 * vars-atr.c: (delete_variable) Implement. Add argument for the
7394 dictionary that owning the variable.
7395 (dup_variable) Add assertion.
7397 * vfm.c: Comment fixes, hopefully the comments are correct now.
7398 (process_active_file) New function.
7399 (process_active_file_write_case) New function.
7400 (process_active_file_output_case) New function.
7401 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
7403 (write_case) Renamed procedure_write_case(). Now write_case is a
7404 pointer to a function. Style fixes.
7406 1998-03-05 Ben Pfaff <blp@gnu.org>
7408 * Makefile.am: (q2c) Link with libmisc.
7409 (version.c) Define default_config_path, include_path,
7412 * ascii.c: (ascii_postopen_driver) When the default newline string
7413 is requested, open file in text mode. Suggested by
7414 palme@uni-wuppertal.de (Hubert Palme).
7415 (static vars line_buf, line_p) Change from char * to unsigned char
7417 (ascii_close_page) char * to unsigned char *.
7419 * cmdline.c: (parse_command_line) Implement -r option by
7420 prepending ~/.pspp/rc to the list of files to process.
7422 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
7423 before pulling in a final line.
7424 (null_func, null_int_func) Removed (dead code).
7426 * descript.q: (display) Calculate width of variable name column
7427 properly. Calculate number of valid cases properly. Reported by
7428 palme@uni-wuppertal.de (Hubert Palme).
7430 * filename.c: (init_filename) Use default_config_path instead of
7431 now obsolete CONFIG_PATH.
7433 * getline.c: (getl_initialize) Use include_path instead of now
7434 obsolete INCLUDE_PATH.
7435 (getl_add_file) New argument `where'. All references changed.
7437 * groff.c: (find_font_file) Use groff_font_path instead of now
7438 obsolete GROFF_FONT_PATH.
7440 * postscript.c: (find_ps_file) Use groff_font_path instead of now
7441 obsolete GROFF_FONT_PATH. Copy through temporary variable to
7442 avoid problems with constness.
7444 * str.h: (macro cs_streq) New macro.
7446 * version.h: (glob var default_config_path, include_path,
7447 groff_font_path) New vars.
7449 1998-02-23 Ben Pfaff <blp@gnu.org>
7451 * Many source files: Change verbose_msg() priority levels and
7454 * aggregate.c: Include debug-print.h.
7456 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
7458 (static var pre_syntax_message) Document --safer/-s and
7461 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
7463 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
7464 because it's not used but it's still copied.
7465 (open_file_r) Remove gratuitous debug message.
7467 * filename.c: (safety_violation) New function.
7468 (open_file) Remove gratuitous debug messages. Don't allow pipe
7469 files if set_safer is set.
7471 * get.c: Turn off debugging.
7473 * getline.c: (getl_add_virtual_file) New function.
7474 (getl_read_line) Add verbose_msg() call for opening new syntax
7476 (getl_perform_delayed_reset) Add a return value describing whether
7477 any action was taken. Call reset_eof().
7479 * getline.h: Comment fix.
7481 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
7482 place of incorrect `continue'. Use strtok_r() instead of
7483 strtok(). Always check strtok_r() return value.
7484 (groff_read_DESC) Use strtok_r() instead of strtok().
7486 * lexer.c: (reset_eof) New function.
7488 * main.c: (parse) Get a token after performing a delayed reset
7489 action; allow empty syntax files.
7491 * postscript.c: (output_encodings) Use strtok_r() instead of
7494 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
7496 * set.q: Comment fixes.
7497 (glob var set_safer) New var.
7498 (internal_cmd_set) Support SAFER.
7500 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
7502 * temporary.c: (free_dictionary) Set d->splits to NULL after
7505 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
7506 variable deleted, not if it *isn't* deleted.
7508 1998-02-16 Ben Pfaff <blp@gnu.org>
7510 * command.c: (array cmd_table[]) Add MATCH FILES.
7512 * common.c: Comment fixes.
7514 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
7515 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
7516 Include alloca.h. Problem reported by palme@uni-wuppertal.de
7519 * expr-opt.c: Include str.h. Problem reported by
7520 palme@uni-wuppertal.de (Hubert Palme).
7522 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
7523 (static var mtf_by) Change from char ** to variable **.
7524 (static var mtf_master) New var.
7525 (mtf_merge_dictionary) New function.
7526 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
7527 var type. Reorder tests properly. Initialize file->dict. Detect
7528 TABLE= without BY=. Read file dictionaries and merge them. Give
7529 subcommand name with IN, LAST, FIRST error messages. Create IN,
7530 LAST, FIRST variables. Comment fixes.
7531 (mtf_free) Don't free default_dict. Free mtf_master.
7533 * getline.c: Define getl_mode. Change getl_buf_size to size_t
7535 (handle_line_buffer) Cast int to size_t in comparison to avoid
7538 * getline.h: Declare getl_mode extern.
7540 * groff-font.c: (groff_read_font) Type-fix calls to getline.
7541 (groff_read_DESC) Make line_size a size_t.
7542 (match_tok) Parenthesize name to avoid macro expansion.
7544 * mis-val.c: (copy_missing_values) New function.
7546 * postscript.c: (postopen) Make buf_size a size_t.
7548 * sfm-read.c: (dump_dictionary) Make global from static. Print
7549 variable info in parts for easier debugging with Checker.
7551 * temporary.c: (copy_variable) Use copy_value_labels().
7552 (new_dictionary) New arg: whether to copy file label, documents.
7554 * val-labs.c: (copy_value_labels) New function.
7556 * var.h: (enums MISSING_*) Add MISSING_COUNT.
7558 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
7560 (dup_variable) Set prv_index, get.fv, get.nv.
7562 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
7564 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
7566 * Many source files: For ANSI-compliance, add empty statement
7567 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
7568 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7570 * data-in.c: (parse_numeric) Some header files break on
7571 -DBL_MIN_10_EXP because they get a --; add () for safety.
7572 Reported by palme@uni-wuppertal.de (Hubert Palme).
7574 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
7575 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
7576 (dfm_close) Use close_file_ext.
7577 (open_inline_file) Set file.file to NULL, not file.
7578 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
7579 struct and use open_file_ext().
7580 (read_record) Use file.file.
7582 * file-handle.q: (prepend_current_directory) Pass through special
7585 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
7586 (normalize_filename) Pass through special filenames.
7587 (open_file, close_file) Accept pipe| and |pipe syntaxes as
7589 (dirname) Rename blp_dirname() because of name conflict on some
7590 OS. All references changed. Reported by palme@uni-wuppertal.de
7592 (is_special_filename) New function.
7594 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
7595 (trim_dictionary) Conditionalize some of the options on whether
7596 GTSV_OPT_MATCH_FILES is in *options.
7597 (rename_variables) Don't allow variables to be renamed as scratch
7599 (MTF_*) New enum series.
7600 (struct mtf_file) New struct.
7601 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
7603 (cmd_match_files, mtf_free) New functions.
7605 * lexer.c: (match_int) Needed parentheses around name to escape
7606 macro expansion. Reported by Micah Altman
7607 <maltman@www-vdc.fas.harvard.edu>.
7609 * print.c: Needed to include alloca.h. Reported by Micah Altman
7610 <maltman@www-vdc.fas.harvard.edu>.
7612 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
7613 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
7616 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
7617 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7619 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
7621 * html.c: (struct html_driver_ext) Move into htmlP.h.
7622 (html_preopen_driver) Initialize cp_x, cp_y.
7623 (html_submit) Implement as call to output_tab_table().
7624 (change_attributes) New function.
7625 (escape_string) New function.
7626 (output_tab_table) New function.
7628 * list.q: (write_all_headers) Add code for writing headers for the
7630 (clean_up) Write out the html close-table tag.
7631 (determine_layout) Ignore html driver.
7632 (list_cases) Write html data.
7634 * som.c: (som_submit) Move more of the code into output_table().
7636 * tab.c: (static var hit) Make a global var and rename tab_hit.
7637 (static var tab_table_class) Make a global var.
7639 * htmlP.h: New file.
7641 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
7643 * dump-sysfile.c: Removed.
7645 * html.c: (preclose) Change comment in emitted code.
7647 * matrix-data.c: Debugging off by default. Comment fixes.
7648 (static var container) New var.
7649 (cmd_matrix_data) Create and destroy container. Initialize
7650 is_per_factor[] to 0s. Move code into new function
7651 string_to_content_type(). Require split values to be present in
7652 the data when ROWTYPE_ is explicit. Call specific function, not
7653 general read_matrices().
7654 (string_to_content_type) New function.
7655 (context) Exclude all whitespace, not just spaces.
7656 (mget_token) A dot is a number. Add assertion.
7657 (static var data) Renamed nr_data.
7658 (static var factor_values) Renamed nr_factor_values.
7659 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
7660 only specific case. Close data_file before exit.
7661 (fill_matrix) New function.
7662 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
7663 printing. Style fixes. Message fixes. Move code into
7665 (read_matrices_without_rowtype) Rename
7666 matrix_data_read_without_rowtype(). Fix off-by-one error on
7667 loops. Allocate nr_data[] memory from arena.
7668 (read_matrices_with_rowtype) Removed.
7669 (read_splits) Renamed nr_read_splits(). Style fixes.
7670 (read_factors) Renamed nr_read_factors().
7671 (dump_cell_content) Comment fixes. Arguments changed. Change
7672 debug printing. All references changed.
7673 (output_data) Renamed nr_output_data().
7674 (static var wr_content) New var.
7675 (struct factor_data) New struct.
7676 (static var wr_data) New var.
7677 (static var wr_current) New var.
7678 (matrix_data_source_destroy_source) Removed.
7679 (read_matrices_with_rowtype) New function.
7680 (matrix_data_read_with_rowtype) New function.
7681 (wr_read_splits) New function.
7682 (compare_factors) New function.
7683 (wr_output_data) New function.
7684 (wr_read_rowtype) New function.
7685 (wr_read_factors) New function.
7686 (wr_read_indeps) New function.
7687 (glob var matrix_data_source) Make destroy_source member NULL as
7690 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
7692 * lexer.c: (syntax_error) Give better error message when at end of
7695 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
7696 N_SCALAR to output as plain N.
7697 (mdump_token) Change output format.
7698 (context) Fix message output interaction with spaces in input.
7699 (another_token) New function.
7700 (force_eol) Improved error message.
7701 (static var max_cell_index) New var.
7702 (read_matrices) Init `cells'. factor_values is now per-cell.
7703 Init max_cell_index.
7704 (read_data_lines) Replace `compare' local with new `compare' arg.
7705 Debugging messages changed. Only read factors if per_factor.
7706 Propagate error return from read_factors(), force_eol().
7707 Copy N_SCALAR values across the N vector.
7708 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
7709 check parentheses manually since we now have is_per_factor[].
7710 Call read_data_lines() with new args. Check for end of data after
7711 looping, using another_token().
7712 (read_factors) Arguments changed. Use max_cell_index to determine
7713 whether to read or compare factors. Message fixes.
7714 (dump_cell_content) New function.
7715 (output_data) Completely rewritten because content types were
7716 supported to be nested inside factor values, not vice versa.
7718 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
7720 * lexer.c: (syntax_error) Support formatted varargs messages.
7722 * matrix-data.c: Turn debugging on by default.
7723 (static content_type[]) New array.
7724 (static content_names[]) New array.
7725 (static rowtype_, varname_) New vars.
7726 (static is_per_factor[]) New array.
7727 (static split_values) Moved declaration.
7728 (static n_continuous, first_continuous) New var.
7729 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
7730 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
7731 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
7732 Check for continuous variables.
7733 [DEBUGGING] (debug_print) Remove content_names[].
7734 (mdump_token) New macro.
7735 (mget_token_dump) New function.
7736 (mdump_token) New function.
7737 (context) New function.
7738 (mget_token) Fix messages.
7739 (static var data, split_values, factor_values) New vars.
7740 (read_matrices) Manage split_values, factor_values.
7741 (read_data_lines) New function.
7742 (read_matrices_without_rowtype) Implemented.
7743 (read_splits) Message fixes. Uses `just_read'.
7744 (read_factors) New function.
7745 (output_data) New function.
7746 (matrix_data_source_destroy_source) Close the file handle.
7747 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
7750 * str.c: (strpadcmp) Removed.
7752 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
7754 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
7756 * Lots of source files: Add cast to unsigned character to calls to
7757 tolower() and toupper().
7759 * aggregate.c: Set default_dict.splits to NULL.
7761 * command.c: (static variable tab[]) Add MATRIX DATA.
7763 * data-in.c: Add debugging defines. Formatting fixes.
7765 * expr-opt.c: Formatting fixes.
7767 * lexer.c: (syntax_error) Message fixes.
7769 * matrix-data.c: New enum series.
7770 (static vars fmt, section, diag, explicit_rowtype, signle_split,
7771 split_values, n_factors, factors, cells, pop_n, contents,
7772 n_contents) New vars.
7773 (cmd_matrix_data) Finished implementation.
7774 (compare_variables_by_mxd_vartype) New function.
7775 [DEBUGGING] (debug_print) New function.
7776 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
7777 (read_matrices) New function.
7778 (read_matrices_without_rowtype) New function.
7779 (read_matrices_with_rowtype) New function.
7780 (read_splits) New function.
7781 (mget_token) New function.
7782 (force_eol) New function.
7783 [0] (test_tokenizer) New function.
7784 (matrix_data_source_destroy_source) New function.
7785 (glob var matrix_data_source) New var.
7787 * misc.h: Include ieeefp.h if present.
7789 * split-file.h: (cmd_split_file) Changes corresponding to struct
7792 * str.h: Fix memmem prototype.
7794 * temporary.c: (save_dictionary, restore_dictionary,
7795 free_dictionary) Changes corresponding to struct dictionary
7798 * var.h: (MXD_* enums) New enum series.
7799 (struct matrix_data_proc) New struct.
7800 (struct split) Removed.
7801 (struct dictionary) Changed `splits' member from `split *' to
7803 (macro force_create_variable) New macro. Replaced lots of
7804 create_variable()/assert() calls with calls to this macro.
7806 * vars-atr.c: (discard_variables) Changed assertion.
7807 [GLOBAL_DEBUGGING] (force_create_variable) New function
7808 called by the macro of the same name.
7809 (clear_variable) Changes to delete splits from the dictionary
7810 corresponding to struct dictionary changes.
7812 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
7813 corrupted variable `index' values in the dictionary passed in
7814 every time this function is called.
7816 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
7817 to struct dictionary changes.
7819 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
7821 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
7823 * command.c: New includes.
7824 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
7825 (cmd_erase) New function.
7826 [unix] (shell) New function.
7827 (run_command) New function.
7828 (cmd_host) New function.
7829 (cmd_new_file) New function.
7831 * expr-prs.c: (parse_primary) Message fix.
7833 * inpt-pgm.c: Formatting fix.
7834 (cmd_reread) Implement the FILE subcommand.
7836 * matrix-data.c: New file.
7838 * q2c.c: (dump_header) Change output commenting style.
7840 * weight.c: Comment fix.
7842 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
7844 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
7846 (buf_10x) Renamed buf_1xx, all references changed.
7847 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
7848 cases now implemented).
7849 (create_sysfile) New function.
7850 (agr_11x_func) New function.
7852 * data-in.c: (parse_numeric) Work properly if there's an
7853 explicitly coded decimal point in the data and decimal places are
7854 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
7855 <el@linux.lisse.na>.
7857 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
7858 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
7859 Eberhard W Lisse <el@linux.lisse.na>.
7861 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
7862 strerror.c. Bug reported by Alexandre Oliva
7863 <oliva@dcc.unicamp.br>.
7865 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
7866 (static var separate_case_tab) New var.
7867 (cmd_sort_cases) Cancel temporary transformations here. Free
7868 v_sort before return.
7869 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
7870 we're reading from a sort stream. Don't cancel temporary
7871 transformations. Offload internal sorting to do_internal_sort().
7872 (do_internal_sort) New function. Handles internal sorting even
7873 when SEPARATE is nonzero. Doesn't free v_sort.
7874 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
7876 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
7877 sink if SEPARATE is zero.
7878 (read_output_cases) Renamed read_sort_output(), all references
7879 changed. Now uses separate_case_tab when it exists.
7880 (write_separate) New function.
7882 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
7883 memory_sink_cases. Don't redundantly call
7884 vfm_source->destroy_source().
7885 (memory_stream_mode) After switching over, set memory_sink_cases
7888 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
7890 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
7892 (static var prev_case) New, moved out of aggregate_single_case()
7894 (static var buf64_10x, buf_10x) New.
7895 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
7896 the 000, 001, 100, and 101 cases. Free prev_case.
7897 (parse_aggregate_functions) Disallow scratch variables.
7898 (free_aggregate_functions) Only free agr_dict if non-null. Use
7899 iter->function to determine numeric/string type, not
7901 (aggregate_single_case) Don't manage prev_case. Initialize
7902 aggregate info after dumping it.
7903 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
7904 mean, stddev, weighted stddev definitions.
7905 (dump_aggregate_info) Implemented.
7906 (initialize_aggregate_info) Renamed from
7907 initialize_aggregate_functions(). Initializes dbl[2].
7908 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
7909 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
7911 * cases.c: (alloc_val) Removed.
7913 * get.c: (cmd_save_internal) Initialize new `dict' member.
7915 * sfm-write.c: (sfm_write_dictionary, write_header,
7916 write_variable, write_value_labels, write_documents) Reorganize,
7917 simplify for new parameter structure.
7918 (write_variable) Only one variable * argument now.
7920 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
7921 replaced by new `dict' member.
7923 * temporary.c: (new_dictionary) Initialize n_documents.
7925 * vars-atr.c: (dup_variable) Allocate `value's from dict into
7927 (init_variable, replace_variable) Eliminate usage of alloc_val().
7929 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
7931 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
7932 signal that AGGREGATE is to be used for forming final cases.
7933 (close_active_file) Call end_func before stopping lagging. Cancel
7934 temporary after finishing compaction.
7935 (write_case) Comment fixes. Cleaned up.
7936 (compact_case) Let AGGREGATE handle compaction when `temporary' is
7939 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
7941 * Makefile.am: (BUILT_SOURCES) Add means.c.
7942 (pspp_SOURCES) Add means.c.
7943 (EXTRA_DIST) Add means.q.
7945 * command.c: (array cmd_table[]) Add MEANS.
7947 * common.h: Esthetic fixes. Comment fixes. Test for
7948 MAX_SHORT_STRING greater than 8.
7949 (macros LOWEST, HIGHEST) New.
7951 * data-in.c, data-list.c, recode.c: Comment fixes.
7953 * means.q: New file, base version.
7955 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
7956 with LOWEST, DBL_MAX with HIGHEST.
7958 * q2c.c: (dump_vars) Add an enum to array types giving the number
7959 of values for the enum.
7961 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
7962 Replace second_lowest_value with second_lowest_flt64.
7964 * sfm-write.c: (write_variable, write_rec_7_34) Replace
7965 second_lowest_value with second_lowest_flt64.
7967 * t-test.q: Comment fix.
7969 * temporary.c: (restore_dictionary) Esthetic fix.
7971 * tokens.h: (force_match_id, force_match, force_string, force_int,
7972 force_num, force_id) Replace msg() with syntax_error().
7974 * var.h: (struct means_proc) New.
7975 (struct variable) Add mns member to `p' union.
7977 * vars-prs.c: (parse_variable, parse_dict_variable,
7978 parse_variables, parse_DATA_LIST_vars) Replace msg() with
7981 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
7983 * Makefile.am: (pspp_SOURCES) Add tab.h.
7985 * Most source files: Added a cast to unsigned char in usages of
7986 the ctype is*() functions. Replaced `end of command expected'
7987 calls to msg() with calls to syntax_error().
7989 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
7991 * lexer.c: (hex_val) Removed (was dead code).
7992 (idmatch) Parenthesize function name to avoid macro expansion.
7994 * postscript.c: Comment fixes.
7995 (ps_preopen_driver) Change default font size to 10pt.
7997 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
7999 (parse_format_spec) Change system-file format spec argument type
8000 to int32. Parse the format spec with bitwise operators.
8002 * sfmP.h: (struct sysfile_format) Removed.
8003 (struct sysfile_variable) Changed print, write members from
8004 sysfile_format to int32.
8006 * tokens.h: Esthetic fixes.
8007 [__GNUC__] (macro id_match) New macro to hopefully speed up
8008 identifier matching.
8009 (macros match_id, match_tok, match_int) Implemented in
8010 compiler-independent manner; no longer GNU C only.
8012 * vfm.h: Include time.h.
8014 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
8016 * data-list.c: (dump_fixed_table) Change tab_dim().
8018 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
8020 * error.c: Include command.h.
8022 * frequencies.g: Formatting fixes.
8024 * frequencies.q: Add tab_dim() calls. Make the total cell a
8027 * glob.c: Include command.h.
8029 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
8031 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
8032 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
8033 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
8034 the other elements (is this right?).
8035 (read_variables) Use lowest, highest members.
8036 (parse_format_spec) New arg `vv' for more stringent checking.
8037 (dump_dictionary) Byteswaps nonexplicit data.
8038 (sfm_read_case) Byteswap numeric data.
8040 * som.c: Initialize table_num to 1.
8041 (render_segments) Remember to increment y_index after each table
8044 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
8045 avl_count() on a NULL tree. No title for the second table.
8046 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
8047 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
8048 fix call to display_variables().
8049 (display_variables) Default to 4 columns, not 3. Set up headers.
8050 Column title is Variable, not Name. Fix index column.
8051 Add joint text. Add tab_dim(). Handle value labels properly.
8052 Handle DISPLAY LABELS properly. Draw boxes correctly.
8053 (describe_variable) Value labels don't need titles. Don't clear
8054 nonexistent index column.
8055 (compare_vectors_by_name) New function.
8056 (display_vectors) New function.
8058 * tab.c: (tab_height) Add assertion.
8059 (tab_null) Add debug code.
8060 (evaluate_dimensions) Add debug code.
8062 * var.h: (struct variable) get_proc data is sometimes used
8063 simultaneously with other per-procedure info, therefore it was
8064 removed from the union. All references changed.
8066 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
8068 * ascii.c: (ascii_close_page) Put title on second line of headers
8069 if there is no subtitle.
8071 * command.c: (glob var cur_proc) Move definition here, from
8073 (cmd_remark) Emit blank line before remarks.
8075 * command.h: (glob var cur_proc) Move declaration here, from
8078 * data-list.c: (dump_fixed_table) Fix messages.
8079 (dump_free_table) Call tab_nat_dim().
8081 * descript.q: (dump_z_table) Modify tab_dim() call.
8083 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
8085 (dump_statistics) Don't output header.
8087 * groff-font.c: Minor format fix.
8089 * html.c: Comment fix.
8091 * list.q: (write_varname) Indent after advancing page.
8093 * output.h: Minor reordering.
8095 * postscript.c: Comment fixes. Many places, '\n' was replaced by
8096 a reference to eol[].
8097 (struct ps_driver_ext) New member eol[].
8098 (ps_preopen_driver) Initialize eol[].
8099 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
8100 defaults. Handle headers. Fix test for minimum page length.
8101 (static var option_tab[]) Add `line-ends'.
8102 (ps_option) Handle line-ends to change eol[].
8103 (postopen) Scale prop_em_width and fixed_width properly. Set the
8104 prologue title to outp_title if applicable. Replace the prologue
8105 line ends with eol[]. Call draw_headers() if headers are enabled.
8106 (text_width) New function.
8107 (out_text_plain) New function.
8108 (draw_headers) New function.
8110 * print.c: (dump_table) Call tab_nat_dim().
8112 * som.c: (som_blank_line) Only advance a line if not at the top of
8114 (som_submit) Move several informational table calls here.
8115 Increment subtable_num if SOMF_NO_TITLE not set.
8116 (output_table) Advance a line if SOMF_NO_SPACING not set.
8117 (render_columns, render_segments, render_simple) Handle spacing
8118 between tables. Handle table titles. Remove debug output.
8120 * som.h: (SOMF_*) New enum series.
8121 (struct som_table_class) New member `flags'.
8123 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
8125 (display_variables) Calls tab_nat_dim().
8126 (describe_variable) Remove restriction on number of value labels.
8127 Make value labels separated by thin lines.
8129 * tab.c: (tab_create) Default `flags' to none.
8130 (tab_float) New arg `w'. All references changed.
8131 (tab_nat_dim) New function.
8132 (tab_output_text) No title or spacing.
8133 (tab_flags) New function.
8134 (tabi_flags) New function.
8135 (tabi_title) New function.
8136 (strip_height) Removed.
8137 (tabi_render) Skip title when necessary.
8138 (static var tab_tab_class) Add tabi_flags, tabi_title.
8139 (evaluate_dimensions) Disable display of column, row size.
8140 (sum_columns) Add title height to top header.
8141 (render_strip) Moved within file.
8143 * tab.h: (struct tab_table) New member `flags'.
8145 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
8147 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
8149 * Most source files: Add `const' attribute in all appropriate
8152 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
8153 column to the variables table for use by describe_variable().
8154 (cmd_display) Disable for the present.
8155 (display_documents) Don't wrap documents.
8156 (display_variables) Table has four columns now.
8157 (describe_variable) Table has four columns now. Don't use a
8158 subtable, use joined cells instead.
8160 * tab.c: (tab_create) Don't set `join'.
8161 (tab_realloc) ct array is not made up of a_string's.
8162 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
8163 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
8164 (text_format) New function.
8165 (tab_title) Rewritten, uses text_format().
8166 (tab_text) Rewritten, uses text_format().
8167 (tab_joint_text) New function.
8169 (static var hit) New variable.
8170 (render_strip) New args r1, r2. Implement joined cells that fit
8172 (tabi_render) Increment hit. Pass new args to render_strip().
8173 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
8174 cells. For t_naw and t_nah, ignore joined cells and null cells in
8177 * tab.h: (struct tab_join_rect) Removed.
8178 (struct tab_table) Removed `join'.
8179 (TAB_JOIN_MAIN) Removed.
8180 (struct tab_joined_cell) New struct.
8181 (TAT_NOWRAP) New enum.
8183 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
8185 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
8187 (ascii_postopen_driver) Fix initialization of *_spacing so that
8188 the TAL_0 bit doesn't count.
8190 * data-list.c: (dump_fixed_table) Use natural width for Format
8193 * glob.c: (rerange) Removed.
8194 (get_date) Formatting fixes. Internationalization fix.
8196 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
8199 * postscript.c: (ps_postopen_driver) Replace
8200 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
8202 * som.c: (som_submit) Don't eject page before every table.
8203 (output_table) Fix order of arguments on call to area().
8204 (render_columns) Fix calculation of max_len.
8206 * tab.c: (tabi_cumulate) Minor change to increase elegance.
8207 (render_strip) New function.
8208 (strip_height) New function.
8209 (tabi_render) Rewrite as calls to render_strip().
8211 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
8212 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
8213 with the TAB_* and OUTP_T_* constants.
8215 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
8217 * Makefile.am: Formatting fixes.
8219 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
8222 * data-list.c: (dump_fixed_table) Add tab_dim() call.
8224 * descript.q: (dump_z_table, display) Add tab_dim() calls.
8226 * dump-sysfile.c: (glob var length) Make type off_t.
8227 (usage) Fix arguments.
8230 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
8231 Now right-justification is the default so many references had to
8233 (struct outp_class) Removed line_width, all references changed.
8234 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
8235 (struct outp_driver) Add elements horiz_line_width,
8236 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
8239 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
8241 (postopen) Initialize all the informational members of
8244 * som.c: (som_blank_line) New function, renamed from blank_line(),
8245 all references changed.
8246 (som_submit) Disables drivers whose pages can't be opened.
8247 (render_columns, render_simple, render_segments) Add debug output.
8248 (render_columns) Fix loop range.
8249 (render_simple) Don't try to render the headers, they're taken
8250 care of automatically. Advance cp_y past the table when done.
8251 (render_segments) Fix loop ranges.
8253 * tab.c: Initialize new members of tab_table.
8254 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
8255 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
8256 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
8259 (tab_dim) New function.
8260 (tab_col_width) Removed.
8261 (tab_row_height) Removed.
8262 (tab_output_text) Call tab_dim().
8263 (tabi_driver) Call evaluate_dimensions(), sum_columns().
8264 (tabi_area) Implemented.
8265 (tabi_cumulate) Implemented.
8266 (tabi_render) Partially implemented, but broken.
8267 (var tab_table_class) Made static.
8268 (evaluate_dimensions) New function.
8269 (sum_columns) New function.
8271 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
8272 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
8273 t_scr, t_srr, t_sentinel. Removed: t_nat.
8274 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
8275 max_stack_height, w, h. Removed: ce, re.
8276 (macro blank_line) Removed.
8277 (glob var zero_length) Removed.
8279 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
8281 * Most source files: include some of the new include files broken
8284 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
8287 * aggregate.c: (glob var outfile) Make static.
8289 * command.c: (glob var pgm_state) Move here.
8291 * common.c: (glob vars endian, second_lowest_value, pgmname,
8292 finished, curdate, cur_proc, start_interactive, history_file) Move
8295 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
8297 * file-handle.q: (glob vars files, inline_file) Move here.
8299 * glob.c: Lost lots of glob vars, detailed in individual file
8301 (init_glob) set_printer, set_screen were obsolete, deleted.
8302 set_cprompt has fewer spaces because pspp has fewer letters than
8305 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
8306 (inp_nval) Made static.
8308 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
8309 tokstr_len, toklongstr, tokint) Move here.
8311 * misc.c: Lost several vars and functions.
8313 * set.q: (all the set_* variables) Move here.
8315 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
8316 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
8319 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
8321 * tab.h: (enum series t_*) New enums.
8322 (struct tab_table) Use arena struct tag. New members ce, re.
8324 * tokens.h: Comment fixes.
8326 * var.h: Move lots of enums and variables and functions and
8327 structures to other files. Use and declare a lot more union and
8328 struct tags. Comment fixes.
8330 * vector.c: (glob vars vec, nvec) Move here.
8332 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
8333 init_blanks, last_vfm_invocation) Move here.
8335 * cases.h: New file.
8336 (struct long_vec) Move here.
8337 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
8340 * command.h: New file.
8341 (STATE_* enums) Move here.
8342 (glob var pgm_state) Move here.
8344 * format.c: New file.
8345 (glob var formats) Move here.
8346 (parse_format_specifier_name, fmt_to_string,
8347 check_input_specifier, check_output_specifier,
8348 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
8351 * format.h: New file. Move functions now in format.c here.
8352 (FMT_* enums) Move here.
8353 (struct fmt_desc) Move here.
8354 (FCAT_* enums) Move here.
8355 (struct fmt_spec) Move here.
8356 (glob vars formats, fmt_parse_ignore_error) Move here.
8358 * inpt-pgm.h: New file.
8359 (INP_* enums) Move here, make #defines into enums.
8360 (glob vars inp_init, inp_init_size) Move here.
8363 (glob vars v_sort, nv_sort) Move here.
8364 (sort_cases, read_sort_output) Move here.
8366 * vector.h: New file.
8367 (struct vector) Move here, add struct tag.
8368 (glob vars vec, nvec) Move here.
8369 (find_vector) Move here.
8372 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
8373 reinit_blanks, init_zero, init_blanks) Move here.
8374 (struct case_stream) Move here.
8375 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
8376 vfm_disk_stream, sort_stream, data_list_source,
8377 input_program_source, file_type_source, get_source, n_lag) Move
8379 (procedure, write_case, lagged_case, compact_case, page_to_disk)
8382 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
8384 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
8385 (LDADD) Add libdcdflib.
8387 * ascii.c: Comment and formatting fixes. Almost every external
8388 function had an assert added, checking driver_open and page_open.
8389 (ascii_init_driver) Broken into ascii_preopen_driver,
8390 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
8391 (ascii_open_page) Sets page_open.
8392 (ascii_close_page) Clears page_open.
8394 * html.c: Comment and formatting fixes. Almost every external
8395 function had an assert added, checking driver_open and page_open.
8396 (html_init_driver) Broken into html_preopen_driver,
8397 html_postopen_driver, html_close_driver. Manages driver_open.
8398 (html_open_page) Sets page_open.
8399 (html_close_page) Clears page_open.
8400 (html_submit) Disabled.
8402 * lexer.c: (parse_string) Remove debugging printf.
8404 * list.q: (determine_layout) Open a page if one is not yet open.
8406 * output.c: Comment fixes.
8407 (add_class) Set the class member of the new list element.
8408 (parse_options) Don't handle device type.
8409 (colon_tokenize) New function.
8410 (configure_driver) New four-field format with a field for device
8411 type. Now initialize driver_open, page_open, next, and prev
8412 fields. Use new colon_tokenize() function. Don't do a memory
8413 copy to replace a driver, it doesn't work; instead delete the old
8414 driver and insert a new one.
8415 (destroy_driver) Don't call som_destroy_driver(). Close the page
8416 if it's open. Find the class in the list of classes and decrement
8417 that reference count. Remove the driver from the global driver
8419 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
8420 references changed. Rewritten. Don't return a driver that's not
8422 (outp_eject_page) All references to som_internal_eject_page()
8423 changed to use this. Sets cp_x to 0 as well as cp_y.
8425 * output.h: (OUTP_I_* enums) Removed.
8426 (struct som_submission_form) Removed.
8427 (struct outp_class) init_driver broken into preopen_driver,
8428 postopen_driver, and close_driver. submit changed to take a
8431 * postscript.c: Comment and formatting fixes. Almost every
8432 external function had an assert added, checking driver_open and
8434 (ps_init_driver) Broken into ps_preopen_driver,
8435 ps_postopen_driver, ps_close_driver. Manages driver_open.
8436 (ps_open_page) Sets page_open.
8437 (ps_close_page) Clears page_open.
8439 * som.c: New file, base implementation.
8441 * som.h: (struct som_table) Add struct tag.
8442 (enum SOM_COL_ACROSS) Removed.
8443 (SOM_ROWS, SOM_COLUMNS) New enums.
8444 (struct som_table_class) Add member `cumulate'. Remove `segment';
8445 change `render' arguments.
8446 (struct som_point, struct som_rect) Removed.
8447 (som_submit_table) Fixed typo, should have been som_submit.
8449 * sysfile-info: (describe_variable) Don't try to insert a
8450 subtable; just destroy it for now.
8452 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
8453 references to value labels.
8455 * tab.c: (tab_destroy) New function.
8456 (tab_columns) Change argument.
8457 [0] (tab_submit) Remove dead code.
8458 (tab_title) Allocate string from the table's arena.
8459 (tab_output_text) Only free the buffer if we allocated it.
8460 (tab_submit) New function.
8461 (static vars t, d) New static vars.
8462 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
8463 tabi_headers, tabi_cumulate, tabi_render) New functions.
8464 (glob var tab_table_class) New global var.
8466 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
8467 encapsulate the rectangle. All references changed.
8469 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
8471 * All header files updated to use struct tags in addition to
8472 typedefs for all structures. Don't use word `struct' in struct
8475 * Makefile.am: (pspp_SOURCES) Remove html.c.
8476 (INCLUDES) Replace the lib/* includes with a single lib/ include;
8477 all references updated.
8479 * command.c: (parse_cmd) Remove call to som_check_workspace.
8480 (output_line) Update to new som.
8482 * data-in.c: (parse_numeric) A single dot is not an error; it is
8483 the system-missing value.
8485 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
8488 * data-out.c: Added `const' as appropriate to many prototypes.
8489 (convert_E, convert_F, convert_CCx) Take double argument instead
8490 of value * argument.
8491 (convert_format_to_string) Call changed functions appropriately.
8492 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
8493 make a local copy of the value.
8495 * descript.q: Remove custom_variables() prototype now provided by
8497 (custom_variables) Don't increment sbc_variables, the caller does
8499 (dump_z_table, display) Update to new som.
8501 * error.c: (vmsg) Add const to prototype. Remove code to handle
8502 `too many errors' condition.
8503 (check_error_count) New function.
8504 (msg) Add const to prototype.
8506 * filename.c: (open_file) Rewrite for elegance.
8508 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
8509 (dump_full, dump_condensed, dump_statistics) Update for new som.
8511 * list.q: Don't include somP.h. Change all references to
8512 som_driver_ext to refer to the new members of som_driver. Change
8513 som_internal_eject_page() references to outp_eject_page().
8515 * main.c: (parse) Rewrite for elegance. Add call to
8516 check_error_count().
8518 * output.c: (add_class, outp_list_classes, outp_configure_driver)
8519 Rewrite or revise for new outp_driver_class_list structure.
8520 (outp_iterate_enabled_drivers) Fix comparison between disabled
8521 devices and current device type.
8522 (outp_eject_page) New function.
8524 * output.h: Comment fixes.
8525 (struct outp_driver) New members driver_open, page_open, cp_x,
8526 cp_y, font_height, prop_em_width, fixed_width. Deleted members
8528 (struct outp_driver_class_list) New struct.
8529 (outp_class_list) Changed to type outp_driver_class_list; all
8532 * print.c: (dump_table, print_trns_proc) Updated for new som.
8534 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
8535 prototypes for custom subcommands.
8536 (dump_subcommand) Always include the `else'.
8537 (dump_parser) Fix comments in output code.
8539 * set.q: Reordered functions.
8541 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
8543 * som.h: Rewritten from scratch.
8545 * str.h: Remove dead code.
8547 * tab.c, tab.h: New files, base implementation.
8549 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
8552 * t-test.q: New code from John Williams
8553 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
8554 Many many new static vars and defines.
8555 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
8556 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
8557 (struct value_list) New struct.
8558 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
8559 t_crt, t_sig, print_t_groups) New functions.
8560 (cmd_t_test) Implemented.
8562 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
8565 * vfm.c: (dump_splits) Update to new som.
8567 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
8569 * Makefile.am: (fiasco_SOURCES) Add html.c.
8571 * aggregate.c: Base source.
8573 * ascii.c: (postopen, preclose) Reformat.
8575 * data-out.c, expr-evl.c: Comment fixes.
8577 * filename.c: (open_file) When opening a file for writing, use
8578 line buffering instead of full buffering for better interactive
8579 performance. Suggested by Valerio Aimale
8580 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
8581 names `stdin', `stdout', `stderr'.
8583 * groff-font.c: Comment fixes.
8585 * html.c: New file; base version.
8587 * list.q: (write_all_headers, clean_up, determine_layout,
8588 list_cases) Ignore `special' devices for now. Needs to be fixed
8591 * output.c: (outp_init) Add html driver to list; reverse list
8594 * output.h: (struct outp_class_struct) New members `special',
8595 `submit'; comment fixes. All references changed.
8597 * postscript.c: (ps_init_driver) Make defaults for text_opt,
8598 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
8600 (postopen) Comment fix.
8601 (preclose) Comment fixes, formatting fixes. Change x->file.file
8602 references to more proper f->file.
8604 * som-high.c: (som_submit_table) Special classes use their own
8607 * som.h: Comment fixes.
8609 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
8612 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
8614 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
8616 * aggregate.c: Still working on this.
8618 * command.c: (cmd_table[]) Add AGGREGATE back in.
8619 (split_words) Make '-' a legal word separator as well as ' '.
8621 * main.c: Comment fixes.
8623 * q2c.c: (dump_parser) Don't require the procedure's full name to
8624 be present, in the generated source.
8626 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
8627 multiply specified and let it be default; let MISSING, CRITERIA,
8628 FORMAT be multiply specified.
8629 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
8630 (custom_groups) Fix defaults.
8631 (custom_pairs) Check whether this is a PAIRS subcommand before
8632 attempting to parse. Better garbage collection. Proper storage
8634 [DEBUGGING] (debug_print) New function.
8636 * temporary.c: Comment fixes.
8637 (copy_variable) Don't copy variable name and index.
8638 (save_dictionary) Copy variable name and index by hand.
8640 * vars-atr.c: Comment fixes.
8641 (create_variable) New dictionary argument. All references
8643 (common_init_stuff) New dictionary argument. All references
8645 (init_variable) New dictionary argument. All references changed.
8646 (dup_variable) New function.
8648 * vars-prs.c: (parse_variables) If there are any errors, we always
8649 return 0. Previously, it was possible for some types of errors to
8652 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
8654 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
8657 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
8659 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
8662 * q2c.c: Comment fixes.
8663 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
8665 * t-test.q: (cmd_list) Rename cmd_t_test.
8667 * temporary.c: (new_dictionary) Don't declare as static.
8669 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
8671 * aggregate.c: Changes, still not finished.
8673 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
8675 * q2c.c: Comment fixes. Now its output is internationalized.
8676 (get_token) Fix parsing of escapes within literal strings.
8677 (main) Fix bad #line directives in output.
8679 * t-test.q: Base implementation.
8681 * temporary.c: (new_dictionary) New function.
8682 (restore_dictionary) [__CHECKER__] Change fill character to *
8685 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
8687 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
8689 * aggregate.c: Changes, still not finished.
8691 * descript.q, list.q: Comment fixes.
8693 * q2c.c: Almost completely rewritten.
8695 * t-test.q: New file, not complete.
8697 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
8699 * aggregate.c: Changes, still not finished.
8701 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
8704 * temporary.c: (cancel_temporary) New function.
8706 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
8707 of doing it by hand.
8709 * vfm.c: (close_active_file) After restoring a TEMPORARY
8710 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
8712 (SPLIT_FILE_procfunc) Comment fix.
8714 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
8716 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
8718 * aggregate.c: New file, not finished yet.
8720 * command.c: (cmd_table) Add AGGREGATE.
8722 * common.h: (pgm_state) Move declaration to var.h.
8724 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
8726 (parse_string) Message fix.
8728 * recode.c: Comment fix.
8730 * sfm-read.c: (read_variables) Code esthetic fixes.
8731 (write_header) Default date is `Jan', not `JAN'.
8733 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
8735 * sort.c: (cmd_sort_cases) Farm the work out to new function
8736 parse_sort_variables().
8737 (parse_sort_variables) New function.
8738 (sort_cases) New function. Cancels temporary transformations,
8739 which sorting didn't do previously.
8740 (cmd_sort_cases) Better garbage collection on error. Uses
8742 (write_initial_runs, merge_once) Improved code esthetics.
8743 (sort_stream_read) Reduced to one call to read_output_cases().
8744 (read_output_cases) New function.
8746 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
8747 variable labels to 120 characters.
8749 * var.h: Comment fixes.
8750 (glob var pgm_state) From common.h.
8752 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
8754 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
8755 options. Set *names to NULL on error.
8757 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
8759 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
8761 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
8762 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
8764 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
8766 * vfm.c: (page_to_disk) Added missing local variables.
8768 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
8770 * get.c: Comment fix.
8772 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
8773 source is anything other than a disk stream, not just if it's in a
8774 memory stream. Call page_to_disk() before external sort.
8775 (allocate_cases) Message fix.
8777 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
8779 (page_to_disk) New function.
8781 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
8783 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
8785 * common.h: (macro strerror) Remove. From Alexandre Oliva
8786 <oliva@dcc.unicamp.br>.
8788 * get.c: (dict_delete_run) The number of variables to delete is
8789 not necessarily the number of variables that need to be shifted
8791 (trim_dictionary) Don't set *options to 0. Fix bug that caused
8792 too many variables to be deleted.
8794 * postscript.c: Comment fix.
8796 * q2c.c: Include strerror.c. From Alexandre Oliva
8797 <oliva@dcc.unicamp.br>.
8799 * set.q: #undef ON and OFF. From Alexandre Oliva
8800 <oliva@dcc.unicamp.br>.
8802 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
8803 early, otherwise errors cause a bad free().
8805 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
8806 Oliva <oliva@dcc.unicamp.br>.
8808 * temporary.c: (save_dictionary) Don't allocate memory if
8811 * vfm.c: (memory_stream_write) Message fix.
8813 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
8815 * command.c: (static var cmd_table[]) Define REPEATING DATA
8818 * common.h: Added support for broken systems that are missing
8819 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
8821 * Many source files: Replace syntax error messages via msg() with
8822 call to syntax_error().
8824 * data-list.c: (dump_fixed_table) Add support for dumping table
8825 for REPEATING DATA as well as DATA LIST FIXED.
8826 (cmd_repeating_data) Allows and requires `/' between subcommands.
8827 Does proper thing with allowing rpd.starts_end to stay 0. Allows
8828 CONTINUED specifications to be omitted. Forces CONTINUED to be
8829 specified if ID is. Calculates starts_end, cont_end from logical
8830 record length as reported by fhp. Calls dump_fixed_table() if
8831 requested. Fixed length of record copied by memcpy.
8832 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
8834 (realize_value) Returns sensible value for out-of-range variable
8836 (rpd_parse_record) New argument `ofs'. Fixed confusion between
8837 length of occurrences and length of line. Added warning for
8838 fields that exceed the line length. Fixed infinite loop.
8839 (read_one_set_of_repetitions) Numerous minor changes for more
8840 complete SPSS compliance. Message fixes.
8842 * dfm.c: (dfm_close) If the file being closed is the inline file,
8843 read all the remaining data before closing it.
8844 (dfm_get_record) Don't close the file on lossage, as either it
8845 has been closed already or it doesn't belong to us.
8847 * error.c: (puts_stdout) New function.
8848 (vmsg) Use puts_stdout instead of puts.
8850 * file-handle.q: (fh_record_width) New function.
8852 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
8855 (input_program_source_read) Made an old kluge an approved method.
8857 * lexer.c: (syntax_error) New function.
8859 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
8862 * output.c: (oupt_get_paper_size) Message fix.
8864 * q2c.c: Numerous fixes to formatting of generated code made to
8865 conform to GNU coding standards. Uses syntax_error() in generated
8866 code. Other miscellaneous generated message fixes. Added support
8867 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
8868 RAND_MAX, and/or strerror().
8870 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
8872 * data-in.c: Comment fixes.
8874 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
8875 (find_variable_input_spec) New function.
8876 (cmd_repeating_data) Initializes id_spec.
8877 (rpd_parse_record) Implemented.
8878 (read_one_set_of_repetitions) Returns -3 by default in order to
8879 kluge out some potential bugs.
8881 * data-out.c: Comment fixes.
8883 * file-type.c: (internal_cmd_record_type) Message fix.
8885 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
8886 for handling -3 return value.
8888 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
8890 * data-list.c: Comment fixes.
8891 (struct dls_var_spec) Reordered members.
8892 (read_from_data_list_fixed) Restructured.
8893 (struct repeating_data_trns) Reordered members. Renamed `starts'
8894 as `starts_beg', `ends' as `starts_end'.
8895 (cmd_repeating_data) Calculates length of repeated data if
8896 necessary and possible.
8897 (parse_num_or_var) Don't allow string variables.
8898 (realize_value) New function.
8899 (rpd_msg) New function.
8900 (rpd_parse_record) New function. Currently stubbed out.
8901 (read_one_set_of_repetitions) Implemented.
8903 * inpt-pgm.c: (input_program_source_read) Comment fix.
8905 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
8907 * command.c: (cmd_end_repeat_p) Removed.
8908 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
8909 (parse_cmd_name) Removed.
8911 * data-list.c: Comment fixes.
8912 (data_list_pgm) Removed `eof' member.
8913 (static var first) New var.
8914 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
8915 FILE TYPE file inside FILE TYPE structures.
8916 (append_var_spec) Appends to *first, not dls.spec.
8917 (parse_fixed) Message fixes.
8918 (struct rpd_num_or_var) New.
8919 (struct repeating_data_trns) New.
8920 (static var rpd) New.
8921 (cmd_repeating_data) New function.
8922 (parse_num_or_var) New function.
8923 (parse_repeating_data) New function.
8924 (read_one_set_of_repetitions) New function.
8926 * file-type.c: (cmd_file_type) Message fixes. Always
8927 default_handle to FILE TYPE file handle.
8928 (internal_cmd_record_type) Message fixes.
8930 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
8932 * repeat.c: Comment fix. Disable debugging.
8934 * temporary.c: (restore_dictionary) Sets splits to NULL and
8935 n_splits to 0 before destroying the variables because now doing
8936 this tries to remove split variables.
8938 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
8939 destroying the dictionary.
8940 (clear_variable) Removes a variable from splits after destroying
8943 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
8945 * cmdline.c: (set_compat) Removed.
8946 (pick_compat) Removed.
8947 (parse_command_line) Removed -c option.
8948 (pre_syntax_message) Removed -c option.
8949 (usage) Remove compatibility code.
8951 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
8952 (glob var compat) Removed.
8954 * compute.c: (type_check) Fixed messages about type mismatches.
8956 * data-list.c: (cmd_data_list) Removed compatibility code.
8957 (fixed_parse_compatible) Calls convert_negative_to_dash().
8958 Fixed bug where it only set the variable in fx.spec if it created
8959 the variable itself.
8960 (dump_fmt_list) Spelling fix.
8961 (cut_field) Removed compatibility code.
8963 * dfm.c: (cmd_begin_data) Don't require a command terminator on
8966 * expr-evl.c: (evaluate_expression) Implement LAG.
8968 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
8969 (parse_neg) Calls convert_negative_to_dash().
8970 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
8973 * expr.h: (struct expression_struct) Removed member max_lag.
8975 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
8976 (internal_cmd_record_type) Removed special handling to produce
8977 negative numbers from dash tokens.
8979 * getline.c: (static var DO_REPEAT_level) New var.
8980 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
8981 (handle_line_buffer) Copies the line into getl_buf; doesn't call
8982 copy_with_DO_REPEAT_substitutions().
8983 (getl_read_line) Maintains value of getl_mode. Calls
8984 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
8986 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
8988 * getline.h: (getl_mode) New glob var.
8990 * glob.c: Comment fixes.
8991 (init_glob) Restructured. Sets set_seed.
8992 (init_compat_dependent) Removed. All references removed.
8993 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
8994 (__htonl, __htons) Removed. (What were these for?)
8996 * lexer.c: (static var tbl) Dash set to class CNUM.
8997 (make_hexit) New function from data-out.c.
8998 (get_token_representation) Rewritten.
8999 (convert_negative_to_dash) New function.
9000 (lex_init_compat_dependent) Removed.
9001 (yylex) A dash is parsed as part of a number if it is followed by
9002 a digit. The ASCII representation of a number is copied to
9003 tokstr. String parsing farmed out to parse_string(). Comment
9005 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
9007 (preprocess_line) Line processing depends on interactive/batch
9008 mode, not on compatibility mode. Removed PC+ compatibility code.
9010 * loop.c: (loop_3_trns_proc) Comment fix.
9012 * main.c: Remove dead code.
9013 (main) Remove call to init_compat_dependent().
9015 * misc.c: (convert_fmt_ItoO) Make E format conversion more
9018 * print.c: (parse_string_argument) Calls
9019 convert_negative_to_dash().
9020 (fixed_parse_compatible) Calls convert_negative_to_dash().
9022 * repeat.c: (RPT_* defines) Removed.
9023 (struct rpt_numeric) Removed.
9024 (struct repeat_entry) New member type, changed `replacement' from
9026 (clean_up) Deallocation adapted to new repeat_entry.
9027 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
9028 usage. Creates vars for `type' of 1.
9029 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
9030 (store_numeric) Rewritten, new interface.
9031 (parse_numbers) Rewritten.
9032 (parse_strings) Rewritten.
9033 (find_DO_REPEAT_substitution) New function.
9034 (perform_DO_REPEAT_substitutions) New function.
9035 (copy_with_DO_REPEAT_substitutions) Removed.
9036 (debug_print) Rewritten.
9038 * set.q: Comment fix.
9039 (custom_results) Removed compatibility code.
9040 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
9043 * sysfile-info.c: (cmd_display) Removed compatibility code.
9045 * tokens.h: Comment fixes.
9046 (token types enum) Removed `toktype' typedef name for this int
9047 type. Removed SUBST. Restructured.
9049 * vars-atr.c: (discard_variables) Sets n_lag to 0.
9051 * vars-prs.c: Comment fix.
9053 * vfm.c: Comment fixes.
9054 (glob var n_lag) New var.
9055 (static vars lag_count, lag_head, lag_queue) New vars.
9056 (procedure) Removed argument nlag.
9057 (setup_lag) New function.
9058 (close_active_file) Discards lagging state.
9059 (lag_case) New function.
9060 (lagged_case) New function.
9061 (write_case) Lags a case if lagging.
9063 * weight.c: (cmd_weight) Removed compatibility code.
9065 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
9067 * getline.h: (struct getl_script) New members loop_index, macros.
9069 * getline.c: (getl_add_file) Sets first_line field to NULL.
9070 (getl_add_DO_REPEAT_file) New function.
9071 (handle_line_buffer) When the current line's length is negative,
9072 set the filename and line number. Increment line number after
9073 reading line. Pass the line to
9074 copy_with_DO_REPEAT_substitutions() for processing.
9075 (getl_close_file) Free DO REPEAT lines before freeing the
9076 filename, and just set the filename to NULL when doing this,
9077 because otherwise the filename gets freed twice.
9079 * glob.c: (glob var queuing) Removed. All references removed.
9081 * lexer.c: Comment fixes.
9082 (get_token_representation) New function.
9084 * repeat.c: Comment fixes.
9085 (struct repeat_entry) Replaced type and v union members with a
9087 (append_record) New function.
9088 (internal_cmd_do_repeat) Started reforming it for the new
9089 repeat_entry struct. Properly records filename changes in the
9090 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
9091 strncasecmp() result usage. Uses append_record() to simplify.
9092 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
9095 (copy_with_DO_REPEAT_substitutions) Started coding.
9097 [DEBUGGING] (debug_print_lines) New function.
9099 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
9101 * tokens.h: (macro is_id1, is_idn) New macros.
9103 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
9105 * cmdline.c: (static var pre_syntax_message) Changed `win'
9106 compatibility mode to `wnd'.
9108 * data-list.c: (fixed_parse_spss) Renamed
9109 fixed_parse_compatible().
9111 * glob.c: (init_glob) Excise unused code for
9112 program_invocation_short_name.
9114 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
9117 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
9119 * set.q: `win' compatibility renamed `wnd'.
9121 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
9123 * filename.c: [__WIN32__] Change the included Windows header files
9125 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
9126 second character is absolute.
9127 (dirname) Fix logic error. Don't printf() the results.
9128 (prepend_dir) Don't printf() the results.
9130 * getline.c: (handle_line_buffer) New function.
9131 (getl_read_line) Reads line with handle_line_buffer() when
9133 (getl_close_file) Discard line buffer data.
9135 * getline.h: Comment fixes.
9136 (struct getl_line_list) New struct.
9137 (getl_script_struct) Added line buffer members. These are hooks
9138 for use by DO REPEAT to allow it to insert virtual source code
9141 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
9142 Override Borland C++ stupidity that claims Windows has a console
9145 * repeat.c: This is in the process of being restructured from
9146 using a token-buffering approach to the DO REPEAT facility to
9147 using the more flexible approach of a line-buffering approach in
9148 conjunction with the getline module. Comment fixes.
9149 (struct tok_struct) Removed.
9150 (static vars queue_index, queue_head, queue) Removed.
9151 (static vars line_buf_head, line_buf_tail) New vars.
9152 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
9154 (pull_queue, destroy_queue) Removed.
9155 [DEBUGGING] (debug_print_tokens) Removed.
9157 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
9159 * file-handle.q: (prepend_current_directory) New function.
9160 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
9161 current directory before normalizing filename.
9163 * filename.c: (gnu_getcwd) New function.
9164 (absolute_filename_p) New function.
9165 (search_path) New argument, PREPEND. All references changed to
9166 pass NULL except those explicitly mentioned. Uses
9167 absolute_filename_p(). Prepends PREPEND before trying the
9169 (dirname, prepend_dir) New functions.
9171 * getline.c: (getl_get_current_directory) New function.
9172 (getl_include) Passes getl_get_current_directory() as PREPEND arg
9175 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
9177 * In several source files, the term `script' was replaced with
9178 `syntax file' inside error messages. Usage of the term `script'
9179 in the sense of a syntax file is now deprecated.
9181 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
9184 * dump-sysfile.c: (usage) Update message.
9186 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
9188 * getline.h: (glob var getl_include_path) Declare extern.
9190 * list.q: Define EXTERN as extern before #including somP.h.
9192 * var.h: Remove declaration of `disptype' variable.
9194 * vfm.c: (close_active_file) After switching the data sink to a
9195 data source, set vfm_sink to NULL, because it doesn't exist any
9198 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
9200 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
9201 _matherrl() to ignore all math errors.
9203 * sfm-read.c: (read_value_labels) When reading the labels from
9204 disk, read the little parts separately instead of as a struct;
9205 this avoids alignment problems.
9207 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
9208 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
9209 (write_header) Allocates and initializes elem_type.
9210 (sfm_write_case) Uses elem_type to determine how to handle each
9212 (sfm_close) Frees elem_type.
9214 * sfmP.h: Comment fix.
9215 [__BORLANDC__] Uses #pragma -a to adjust structure member
9218 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
9220 * Makefile.am: (fiasco_SOURCES) Remove display.c.
9222 * common.c: Fix typo.
9224 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
9225 sense of the condition.
9227 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
9228 line-continuation backslash.
9230 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
9232 * frequencies.q: (custom_grouped, add_percentile) Don't use a
9233 non-constant expression as an argument to sizeof.
9235 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
9236 undefine gettext macro because that's a conio function.
9238 * hash.h: (hsh_prime_tab declaration) Remove.
9240 * list.q: (write_fallback_headers) Move `leader' allocation out of
9241 main loop. Change to local_alloc() allocation.
9243 * output.h: Formatting fixes. Put __attribute__ in right place on
9244 function prototypes.
9246 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
9247 incorrect `SECOND_LOWEST_VALUE' references to proper
9248 `second_lowest_value'.
9250 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
9251 value. This way 2 out of 3 of the som files define the vars
9252 extern, the correct way, that actually works under BC++.
9253 (som_set_float) Don't use nonconstant initializers for a struct.
9255 * som-high.c: Add the standard alloca() header.
9256 (replicate_table) Add prototype.
9258 Merged DISPLAY routine.
9259 * sysfile-info.c: (AS_*) New enum series.
9260 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
9262 (cmd_display, display_macros, display_documents,
9263 display_variables) Stolen from defunct display.c.
9264 (describe_variable) New function.
9266 * temporary.c: [0] (display_tree) New debug function.
9267 (copy_variable) Performs shallow copy of value labels instead of
9268 deep copy; i.e., just copys the AVL tree and increments the
9271 * val-labs.c: Comment fixes.
9272 (do_value_labels) Optionally skip leading forward slash.
9273 (get_label) Creates only a single value label instead of many
9274 copies of one, and sets the reference count.
9276 * display.c: Removed.
9278 * dump-sysfile.c: New file, not yet complete.
9280 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
9282 For lots of source files I added more verbose_msg's. These aren't
9283 listed below as they have tested as being benign. In some cases
9284 these replaced debug_printf() calls.
9286 * output.c: (outp_read_devices) Message fix.
9288 * postscript.c: (output_encodings) Message fix. Reports errors on
9290 (postopen) Message fix.
9292 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
9294 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
9296 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
9299 * main.c: Remove <malloc.h> #include.
9301 * mis-val.c: (parse_numeric) Set .f member for each missing[]
9302 instead of trying to just set the missing[] itself, which is a
9305 * sfm-read.c: (read_variables) Same.
9307 * str.h: Add memmem() prototype.
9309 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
9311 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
9313 * Makefile.am: (q2c) Don't include any libraries in the link.
9315 * dfm.c: (force_line_buffer_extension) New macro.
9316 (count_tabs) New function.
9317 (tabs_To_spaces) New function.
9318 (read_record) Calls tabs_to_spaces() on the line being processed.
9320 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
9321 have to be compiled twice (once for CC, once for LOCAL_CC).
9323 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
9325 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
9326 (LDADD) Add @INTLLIBS@.
9327 (q2c) Add LIBS, @INTLLIBS@ to link step.
9329 * inpt-pgm.c: Turn off debugging.
9331 * postscript.c: (postopen) Format fix. local_free() blocks
9332 returned by local_alloc(); don't free() them.
9334 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
9336 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
9339 * data-list.c: (read_from_data_list_fixed) Pass proper value for
9340 LEN arg, not simply the full string length.
9342 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
9343 directories before generic temp file directories.
9345 * vfm.c: Disable debugging.
9347 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
9349 * get.c: Comment fix.
9350 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
9352 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
9354 * expr-prs.c: (debug_print_postfix) Conditionally included on
9355 GLOBAL_DEBUGGING. Removed out_header() reference.
9357 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
9359 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
9361 * ascii.c: Removed obsolete ascii_close_page() prototype.
9363 * command.c: (output_line) Comment fix.
9365 * data-in.c: Formatting fix.
9366 (parse_string_as_format) Now the `fc' argument is used only for
9367 the purpose of error messages; it is not an index into the string
9368 passed. All references changed.
9370 * data-list.c: Comment fix.
9371 (cut_field) Comment fix. Now returns the column number of the
9372 position of the field cut out on success.
9373 (parse_field) Added `column' argument. Puts the column numbers in
9375 (read_from_data_list_free, read_from_data_list_list) Record the
9376 column number returned by cut_field(), pass it to parse_field().
9378 * dfm.c: Comment fix.
9380 * do-ifP.h: Comment fix.
9382 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
9383 the SYSMIS function.
9385 * expr.h, exprP.h: Comment fix.
9387 * glob.c: (init_glob) Only calls setlocale() and family if
9390 * hash.h: Comment fix.
9392 * include.c: Comment fix.
9394 * output.c: Comment fix.
9396 * postscript.c: (ps_line_intersection) Simplified assertion.
9398 * repeat.c: Comment fix.
9400 * vars-atr.c: Comment fix.
9402 * vars-prs.c: Comment fix.
9404 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
9405 behavior with usage of postincrement.
9406 (memory_stream_read) Discards cases as it goes.
9408 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
9410 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
9413 * Most source files: Includes debug-print.h, related comment
9416 * cases.c: (alloc_val) Removed complex allocation code. Merely
9417 increments default_dict.nval and returns the former value.
9418 (envector, devector) Removed references to lv member of struct
9421 * common.h: (macro VME) Replaced complex definition with simple
9424 * data-list.c: (cmd_data_list) Sets vfm_source instead of
9425 read_active_file and cancel_input_pgm.
9426 (read_from_data_list, cancel_data_list) Removed.
9427 (data_list_source_read, data_list_source_destroy_source) New
9429 (glob var data_list_source) New var.
9431 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
9432 (cmd_begin_data) Improved criteria for an input program accessing
9433 the inline file. Still not perfect.
9435 * do-if.c: (do_if_trns_proc) Simplified debug output.
9437 * expr-prs.c: Comment fixes.
9438 [DEBUGGING] (debug_print_postfix) Simplified debug output.
9440 * file-handle.q: (fh_close_handle) Simplified debug output.
9442 * file-type.c: Comment fixes.
9443 (cmd_file_type) Sets vfm_source instead of read_active_file and
9445 (cmd_end_file_type) On failure, discards variables in place of
9446 just canceling the input program.
9447 (read_from_file_type) Renamed file_type_source_read.
9448 (cancel_file_type) Renamed file_type_source_destroy_source.
9449 (glob var file_type_source) New var.
9451 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
9452 (cmd_get) Initializes options to GTSV_NONE before passing to
9453 trim_dictionary(). Removed `lv' reference. Sets vfm_source
9454 instead of read_active_file and cancel_input_pgm.
9455 (cmd_save_internal) Initializes options before passing to
9456 trim_dictionary(). Local var `nval' removed.
9457 (dict_delete_run) Comment fixes.
9458 (trim_dictionary) Comment fixes. Disallows scratch variables if
9459 GTSV_OPT_SAVE set in options.
9460 (read_from_get) Renamed get_source_read.
9461 (cancel_get) Renamed get_source_destroy_source.
9462 (glob var get_source) New var.
9464 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
9465 read_active_file and cancel_input_pgm.
9466 (read_from_input_program) Renamed input_program_source_read.
9467 Simplified debug output.
9468 (cancel_input_program) Renamed
9469 input_program_source_destroy_source.
9470 (glob var input_program_source) New var.
9472 * loop.c: (loop_1_trns_proc) Simplified debug output.
9474 * main.c: (dump_token) Made eof output more explicit.
9476 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
9479 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
9480 code for always-memory or always-disk cases. malloc's case-list
9481 based on vfm_source_info.ncases. Explicit support for
9482 memory_stream via memory_source_cases.
9483 (do_external_sort) Sets vfm_source instead of read_active_file and
9485 (allocate_file_handles) The temporary directory permissions are
9486 set to 0700 instead of 0777.
9487 (allocate_cases) Formatting fixes. Simplified debug output.
9488 (output_record) Compacts the case if necessary before writing it
9490 (close_handle, open_handle_w) Simplified debug output.
9491 (write_initial_runs) Destroys vfm_sink, then sets it to
9492 sort_stream. Writes records to memory based on
9493 vfm_sink_info.case_size.
9494 (write_to_sort_cases) Renamed sort_stream_write().
9495 (merge) Simplified error handling. Simplified debug output.
9497 (read_from_external_sort) Renamed sort_stream_read().
9498 Reads records based on vfm_source_info.case_size.
9499 (sort_stream_write) Writes records to memory based on
9500 vfm_sink_info.case_size.
9501 (sort_stream_mode) New function.
9502 (glob var sort_stream) New variable.
9504 * temporary.c: (cmd_temporary) Simplified debug output.
9505 (copy_variable) Removed references to `lv'.
9507 * title.c: (get_title) Simplified debug output.
9509 * var.h: Comment fixes.
9510 (struct get_proc) Removed member `lv'.
9511 (struct variable) Removed member `lv'. Comment fixes.
9512 (glob vars read_active_file, write_active_file, cancel_input_pgm)
9514 (struct case_stream) New.
9516 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
9517 read_active_file references to use vfm_source.
9518 (init_variable, replace_variable) Removed references to `lv'.
9520 * vfm.c: Comment fixes.
9521 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
9523 (static var queue, qh, qt, n_lag) Removed. All references
9525 (glob var compaction_necessary, compaction_nval, compaction_case,
9526 paging) New variables.
9527 (record_case) Removed.
9528 (procedure) Comment fixes. Calls vfm_source->read() instead of
9531 (prepare_for_writing, arrange_compaction, make_temp_case,
9532 vector_initialization, setup_filter) New function.
9533 (open_active_file) Most of the code moved into the abovementioned
9534 new functions. Now sets temp_dict to &default_dict if there is no
9535 temporary dictionary, for convenience. New debug output.
9536 (close_active_file) Deals with changing the sink to the source.
9537 Calls finish_compaction(). Frees compaction_case. Mostly
9539 (glob vars disk_source_file, disk_sink_file) New vars.
9540 (destroy_active_file, read_from_memory) Removed.
9541 (disk_stream_init, disk_stream_read, disk_stream_write,
9542 disk_stream_mode, disk_stream_destroy_source,
9543 disk_stream_destroy_sink) New functions.
9544 (glob var vfm_disk_stream) New var.
9545 (glob vars memory_source_cases, memory_sink_cases,
9546 memory_sink_iter, memory_sink_max_cases) New vars.
9547 (memory_stream_init, memory_stream_read, memory_stream_write,
9548 memory_stream_mode, memory_stream_destroy_source,
9549 memory_stream_destroy_sink) New functions.
9550 (glob var vfm_memory_stream) New var.
9551 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
9552 named `more_cases'. Simplified debug output. Otherwise mostly
9554 (record_case) Moved into the stream drivers. Removed.
9555 (transform) Removed (was dead code).
9556 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
9557 common case that the splits don't change, we don't need to copy
9558 the case into prev_case again--pointless.
9559 (compact_case) New function.
9560 (finish_compaction) New function.
9562 * vfmP.h: Comment fixes.
9563 (DEV_* enum series) Removed.
9564 (struct storage) Renamed `stream_info'. Removed variant record.
9565 Removed `device' member.
9567 * debug-print.h: New file.
9569 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
9571 * autorecode.c: Turned off debugging.
9573 * data-list.c: (destroy_dls) Closes the associated file handle.
9575 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
9576 parse_variables() options.
9578 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
9580 * display.c: (display_variables) Really fixed null cell bug.
9582 * file-handle.q: (fh_close_handle) Changed debugging message.
9584 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
9585 parse_variables() options.
9587 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
9588 (cmd_list) Fails if no variables specified.
9589 (determine_layout) Writes blank lines manually.
9591 * loop.c: (loop_1_trns_proc) Made debugging code only print
9592 messages if debugging.
9594 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
9595 parse_variables() arguments.
9596 (main) Parses optional parenthesized options to varlist
9597 subcommands into sbc->message.
9599 * sfm-read.c: Format fix.
9601 * var.h: (FV_*) New enum series.
9602 (PV_*) New enum PV_NO_SCRATCH.
9604 * vars-prs.c: (find_var) Removed.
9605 (fill_all_vars) Takes FV_* enum instead of boolean third
9606 argument. Rewritten to deal with scratch as well as system
9608 (parse_variables) Error message on scratch variable if
9611 * vfm.c: (static var virt_begin_func) New var.
9612 (procedure) Sets up virt_begin_func.
9613 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
9614 after dump_splits(). For succeeding groups changes, calls
9615 virt_begin_func() instead of begin_func().
9617 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
9619 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
9622 * dfm.c: Added some debugging messages, disabled by default.
9623 (open_file_r) Fixed error message.
9624 (read_record) On eof on inline_file, instead of calling
9625 fh_close_handle(), simply jump to eof label like a normal file.
9628 * display.c: Thin lines between rows for certain kinds of
9629 listing. Fixed `null cell' bug.
9631 * error.c: (failure) Flush stdout, stderr before failing.
9633 * file-handle.q: (fh_close_handle) Added debugging message.
9635 * frequencies.q: (dump_full) Bottom line extends across entire
9636 table width. Changed title formatting.
9637 (dump_condensed) Changed title formatting.
9638 (dump_statistics) Fixed title formatting.
9640 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
9641 Sets default value of set_format.
9643 * list.q: (cmd_list) Calls blank_line() before determine_layout().
9644 Passes write_all_headers() to procedure() as pre-group func.
9645 (write_all_headers) New function.
9646 (determine_layout) Removed calls to write_header().
9647 Calls blank_line() before and after write_fallback_headers().
9649 * recode.c: (recode_trns_free) Only attempts to free head->map if
9652 * sfm-read.c: (read_variables) Allows `#' at beginning of system
9653 file variable names but gives a warning. Sets `left' based on
9654 first character being/not being `#'. On lossage frees dict->var.
9656 * som-high.c: (som_draw_title) Simplified title formatting.
9658 * vfm.c: (dump_splits) Fixed and changed splits formatting.
9660 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
9662 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
9663 beginning. Frees v_src, v_dest on successful exit. Frees
9664 h_trans[*], h_trans on lossage.
9665 (recode) Frees h_trans[*], h_trans.
9667 * dfm.c: (dfm_close) Formatting change.
9668 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
9669 longer allocates its own in inline_file.
9670 (open_file_r) Passes the local dfm_fhuser_ext to
9672 (open_file_w) Message fix.
9673 (read_record) Buffer reallocation strategy changed. Frees
9674 ext->line even in inline_file to prevent leaks.
9675 (dfm_put_record) Fixed bug where `ext' was cached before the file
9676 was opened and thus it would be NULL when the file really was
9678 (cmd_begin_data) Sets up inline_file basics itself, then calls
9679 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
9681 * list.q: (write_line) Formatting fix.
9682 (clean_up) Minor strategy change. Sets proportional font after
9684 (determine_layout) Sets fixed font before writing regular headers,
9685 or after writing fallback headers.
9687 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
9688 and KEEP vars after using them.
9690 * postscript.c: (ps_init_driver) Frees x->family.
9691 (postopen) When loading fonts, free the temporary font name buffer
9693 (ps_text_set_font_by_position) Free temporary font name buffer
9695 (text) Fixed code that calculated `lig' so that `lig' always gets
9696 initialized. Formatting fix.
9698 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
9700 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
9701 cells, not xmalloc(), so that the cells will get destroyed
9704 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
9707 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
9709 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
9712 * dfm.c: Comment fix.
9714 * list.q: Comment fixes. Include somP.h. Removed static vars
9715 table, n_columns, n_rows, part. New struct list_ext. New static
9717 (n_lines_remaining, n_chars_width, write_line) New functions.
9718 (cmd_list, list_cases) Rewritten.
9719 (begin_row, end_row, flush_table) Removed.
9720 (write_header, clean_up, write_varname, write_fallback_headers,
9721 determine_layout) New functions.
9723 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
9725 * output.h: Comment fix.
9727 * postscript.c: Comment fix.
9728 (struct ps_driver_ext) Removed prop_size, fixed_size members;
9729 added font_size. All references changed.
9730 (ps_init_driver) Initializes font_size. Simplified space checking
9732 (static var option_tab[]) Removed prop-size, fixed-size; added
9734 (ps_option) Handles font_size.
9736 * som-high.c: Moved prototypes into somP.h.
9737 (som_init_driver) New function.
9738 (som_submit_table) Moved some code into new function
9740 (build_target) Moved some code into new function
9741 som_internal_eject_page().
9742 (som_eject_page) Uses som_internal_eject_page().
9743 (som_internal_eject_page) New function.
9745 * som-low.c: Moved prototypes into somP.h.
9747 * som.h: Formatting fixes.
9749 * somP.h: (struct som_driver_ext) Removed em_width;
9750 added prop_em_width, fixed_width.
9752 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
9754 * Makefile.am: Added `localedir' definition. Added
9755 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
9757 * ascii.c: (macro draw_line) Fixed capitalization.
9759 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
9760 compute.c, count.c, data-in.c, data-list.c, data-out.c,
9761 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
9762 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
9763 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
9764 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
9765 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
9766 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
9767 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
9768 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
9769 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
9770 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
9771 for internationlization.
9773 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
9775 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
9777 * do-if.c, sort.c, val-labs.c: Comment fixes.
9779 * glob.c: (init_glob) Uncommented, updated i18n support.
9781 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
9782 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
9783 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
9784 the declarations of macros taking arguments a lot nicer.
9786 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
9788 * error.h: Removed CE, CW aliases for SE, SW.
9790 * q2c.c: Removed explicit streq() definition since it's duplicated
9793 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
9794 stats.h, str.h, tokens.h: Made the declarations of macros taking
9795 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
9798 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
9800 * cmdline.c: Comment fixes.
9801 (pick_compat) Changed return type to int. Now, instead of setting
9802 glob var `compat' to the emulation, returns the emulation. All
9804 (parse_command_line) Added terminating null to end of
9805 `long_options' array definition.
9806 (pre_syntax_message) Fixes.
9807 (usage) Shows the default emulation in the syntax message by
9808 calling pick_compat().
9810 * getline.c: (getl_add_include_dir) Separates paths with
9811 PATH_DELIMITER, not DIR_SEPARATOR.
9813 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
9814 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
9816 * output.c: (outp_configure_macro) Make earlier definitions for a
9817 particular key override later ones for the same key.
9819 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
9821 * ascii.c: Comment fixes.
9823 * output.c: (outp_get_paper_size)
9824 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
9826 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
9828 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
9829 <errno.h>. GNU libc 2 enforces this!
9831 * command.c: (parse_cmd) Fixed problem with `else' clause being
9832 paired with wrong `if'. Comment fix.
9834 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
9836 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
9837 blp_getline() to getline().
9839 * output.c: (outp_eval_dimension) Changed the fix from last time;
9840 there was no variable `a'.
9842 * q2c.c: (get_line) Fixed boundary condition overrun bug.
9844 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
9846 * output.c: (outp_evaluate_dimension) Fixed handling of negative
9847 numbers having fractional parts. Added case of a fraction without
9848 a whole-number part.
9850 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
9852 * ascii.c: (ascii_text_get_font_position) Removed.
9854 * expr.h, exprP.h: Disabled debugging.
9856 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
9859 * output.h: (struct outp_class_struct) Removed
9860 text_get_font_position method. All references deleted.
9862 * postscript.c: Big change here. Fontmaps were completely
9863 eliminated because of a change in philosophy. Comment fixes.
9864 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
9866 (struct ps_driver_ext) `position', `fontmap', `prop_name',
9867 `fixed_name' members removed. New members `prop_family',
9868 `fixed_family'. `family' member changed to type char *.
9869 (static var ps_fontmaps) Removed.
9871 (ps_init_driver) Removed obsolete references, updated.
9872 Initializes `translate_x', `translate_y', `scale'. Doesn't read
9873 fontmap, of course. Refers to font names through internal_name
9874 rather than subversive means. Frees proper items.
9875 (static var option_tab[]) Removed `fontmap-file' option; renamed
9876 `fixed-font', `prop-font'.
9877 (ps_option) Corresponds to option_tab[].
9878 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
9879 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
9880 hash_family) Removed.
9881 (postopen) Generates font names from family names. Gets
9882 PostScript font name properly. New prologue file comment `!!!'
9884 (ps_open_page) Adds translate_x, translate_y to BP prologue
9885 function; gives SF argument floating-point format.
9886 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
9887 font name. Doesn't change font family.
9888 (ps_text_set_font_by_position) Generates Groff font name from font
9889 family name instead of through table lookup.
9890 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
9891 all references changed. Reduced to simple string assignment.
9892 (ps_get_font_name) Removed.
9893 (ps_get_font_family) Reduced to string return.
9894 (text) Doesn't save `position' since it no longer exists. Ugly
9895 kluge to save font family--fix soon?
9896 (load_font) Removed PostScript name argument.
9898 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
9900 * postscript.c: Comment fix.
9901 (ps_open_page) Puts scale factor in PostScript output.
9903 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
9905 * Makefile.am: Distcleans q2c.
9907 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
9909 * ascii.c: (delineate) Sets text size even if width is zero.
9911 * command.c: Comment fix.
9912 (static var cmd_table[]) Re-enabled EVALUATE command.
9913 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
9914 of comments in script files. Now more liberal on criteria for
9915 performing a state transition--if *anything* happened correctly,
9916 not just if *everything* happened correctly.
9918 * data-out.c: (convert_F) Comment fix. Why in the fsck does
9919 Checker segfault on formatting large numbers and why in the fsck
9920 hadn't I noticed this before?
9922 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
9924 * list.q: (cmd_list) Commented out the actual output routine
9925 because of various problems. Probably will abandon the idea of
9926 using the general `crushed tables' for the LIST procedure.
9928 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
9929 clearing it. Allocates a new var_by_name dictionary before trying
9930 to add members to it.
9932 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
9933 `sib'. Changed type of `node' argument.
9934 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
9936 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
9937 [DEBUGGING] Only deletes the variable from var_by_name if that var
9940 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
9942 * Makefile.am: Added include files to SOURCES. Added
9943 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
9944 includes rules for q2c. Added `boast' target.
9946 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
9948 * Makefile.am: Maintainer-clean Makefile.in.
9950 * Makefile.am: Fixed redundant EXTRA_DIST line.
9952 * ascii.c: Comment fixes.
9953 (ascii_line_vert) Fixed overly aggressive range check.
9955 * display.c: Removed dead code.
9957 * list.q: Turn debugging on.
9958 (flush_table) New debug code.
9960 * sfm-read.c: (read_value_labels) malloc's the structure before
9961 trying to assign to its members.
9963 * sfm-write.c: Comment fix.
9965 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
9967 (output_table) No arguments anymore--gets them through `som'
9968 global. New debug code. In crushed tables, now sets `htv' as
9969 well as `hv' to avoid bad confusion later.
9970 (dump_crush_page) New debug code.
9972 * som-low.c: (som_dump_crush_page) New debug code.
9974 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
9976 All source files: Broke long lines into multiple lines.
9978 * ascii.c: (ascii_close_page) Uses host_system var in place of
9979 HOST_SYSTEM constant.
9981 * cmdline.c: (var syntax_message[]) Broke into
9982 pre_syntax_message[] and post_syntax_message[].
9983 (usage) Outputs both parts, separated by driver list.
9985 * error.h: Fixed broken formatting.
9987 * expr-opt.c: (str_search, str_rsearch) New functions.
9989 * misc.c: (blp_getdelim) Removed. All references changed to
9991 (str_search, str_rsearch) Removed.
9992 (memrmem) New function.
9994 * misc.h: (blp_getline) Removed. All reference changed to
9999 * filename.c: Includes "stat.h", not <sys/stat.h>.
10000 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
10002 * output.c: (outp_list_classes) Changed output formatting.
10004 * sfm-write.c: (write_header) Uses host_system var instead of
10005 HOST_SYSTEM constant.
10006 (write_rec_7_34) Extracts version numbers from the version string.
10009 * sort.c: Includes "stat.h", not <sys/stat.h>.
10011 * str.c: (strcasecmp) Removed.
10013 * title.c: (cmd_document) Uses host_system var instead of
10014 HOST_SYSTEM constant.
10016 * version.c: Generated on-the-fly by the Makefile instead of being
10019 * str.h: Comment fixes. Doesn't substitute for missing memmove or
10021 [!HAVE_STRNCASECMP] Declares strncasecmp().
10023 * version.h: Removed stray character. Comment fixes.
10024 (vars host_system, build_system) New vars.
10026 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
10028 * Most source files: Changed formatting of copyright notice; fixed
10029 FSF address; reformatted to better conform to GNU standards;
10030 comment fixes. Added markups to prevent GNU indent from messing
10031 up my beautiful formatting :-).
10033 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
10034 that GNU indent markups can be passed through without problems.
10036 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
10038 * get.c: Turned off debugging.
10040 * glob.c: (init_glob) Turned on save-file compression by default.
10042 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
10043 compression than was possible in save files.
10045 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
10047 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
10049 * frequencies.q: Removed Fiasco extensions. Updated calculation
10050 algorithms. Polished output format.
10051 (struct frq_info_struct) Removed members `max_degree', `min_n',
10052 all references removed.
10053 (macro frq_extensions) Removed.
10054 (static vars min_n, max_degree) Removed, all references removed.
10055 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
10056 calculate `min_n', `max_degree'.
10057 (postcalc) Passes new arg to dump_statistics().
10058 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
10060 (dump_condensed) Adds variable name title.
10061 (sum_freqs) Removed.
10062 (calc_stats) Updated calculation algorithm.
10063 (dump_statistics) Removed warning for too-few observations.
10064 Changed table formatting. Adds variable name title if passed new
10067 * output.h: Comment fix.
10069 * recode.c, sample.c, sort.c: Disabled debug code.
10071 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
10072 Improved debug code.
10074 * var.h: (enum series frq_*) Removed Fiasco extensions.
10076 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
10078 * command.c: Added PROCESS IF to command table.
10080 * Lots & lots of places, removed checks for NULLs preceding calls
10081 to free_expression(), which itself checks.
10083 * descript.q: Removed Fiasco extensions. Removed optimizations
10084 for non-weighted active files. Implemented some options.
10085 Finished polishing output format. Comment fixes. Merged
10087 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
10088 max_degree, min_n) Removed.
10089 (macro dsc_extensions) Removed.
10090 (struct dsc_info_struct) Removed `min_n' member, all references
10092 (internal_cmd_descriptives) Removed calculation of min_n,
10093 max_degree. Only deals with one `calc' routine instead of two
10095 (precalc) Eliminated redundancy. Updated for changes to
10096 descriptives_proc structure.
10097 (calc) Moved here from `descript.g'. Rewritten to calculate
10098 statistics via `moments about the mean' rather than by summing,
10099 summing squares, summing cubes, and so on.
10100 (postcalc) Rewritten for new-style statistical calculation.
10101 (display) Removed support for displaying variables across rows.
10102 No longer crushes the descriptives table. Removed ancient code.
10103 Added display of N, by variable and listwise.
10105 * descript.g: Removed; merged into `descript.q'.
10107 * expr-evl.c: (evaluate_expression) Now returns a double. For
10108 numeric results, it returns the result as well as storing it in
10109 the passed `value' structure if non-NULL. For string results it
10110 just returns 0.0 and it must be passed non-NULL. Many references
10111 to this function were optimized by use of this change, especially
10112 but not exclusively in `compute.c'.
10114 * frequencies.g: Comment fix.
10116 * glob.c: (glob var process_if_expr) New global var.
10118 * postscript.c: (static var option_tab[]) Corrected entry for
10120 (postopen) Sets x->size to x->prop_size.
10121 (ps_text_set_font_by_name) Sets font size as well as typeface for
10122 PROP and FIXED fonts.
10124 * sel-if.c: (cmd_process_if) New function.
10126 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
10127 (sfm_write_dictionary) Sets `n_cases' to 0.
10128 (sfm_write_case) Increments `n_cases'.
10129 (sfm_close) Attempts to seek the system file back to the header
10130 and write the number of cases in its proper slot.
10132 * som-frnt.c: (som_insert_table) Masks off expansion options since
10133 only SOPT_X_NORM seems to work sensibly.
10135 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
10136 with a `fixed' value of 2.
10138 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
10140 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
10141 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
10143 * var.h: (enum series dsc_*) Removed Fiasco extensions.
10144 (struct descriptives_proc) Removed `miss_noweight'; new members
10145 `X_bar', `M2', `M3', `M4', `min', `max'.
10147 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
10149 * vfm.c: (close_active_file) Cancels PROCESS IF.
10150 (write_case) Doesn't process cases unselected by PROCESS IF.
10152 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
10154 * glob.c: (glob var err) Removed.
10156 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
10157 doesn't have to take into account number of value labels since
10158 they're in a subtable anyway. Also, doesn't display more than 10
10159 value labels since we can't yet break pages in subtables.
10161 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
10163 * som-frnt.c: (som_change_table_size) Simple change for elegance
10164 that shouldn't change behavior.
10165 (som_set_value) Comment fix.
10167 * som-high.c: (som_submit_table) Message fix.
10169 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
10171 * command.c: Added SYSFILE INFO to command table.
10173 * file-handle.q: (fh_handle_filename) New function.
10175 * get.c: (save_trns_proc) Fixed a bug in padding of output data
10178 * main.c: (parse) New return value for command functions, -3.
10180 * misc.h: Comment fix.
10182 * output.h: Comment fixes.
10183 (macro COMPONENTS) Removed.
10185 * postscript.c: (write_text) Modified literal_chars[] so that `('
10186 and ')' are not written to the output in strings as literals.
10188 * sfm-read.c: (sfm_read_dictionary) New argument.
10189 (read_header) New argument. Sets the information structure's
10190 values from the header information.
10191 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
10192 bizarre Checker problem, I guess.
10193 (read_variables) Proper cleanup on lossage.
10195 * sfm.h: (struct sfm_read_info) New struct for use by
10196 sfm_read_dictionary().
10198 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
10199 currently used just for tables that can be dynamically resized and
10200 thus have to be allocated with arena_malloc() instead of
10201 arena_alloc(). All references changed.
10202 (som_change_table_size) New function.
10203 (som_insert_table) Bugfix: now inserts `cell', not `c'!
10205 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
10206 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
10209 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
10211 (draw_intersection) Now takes an argument specifying the table in
10212 question. All references changed.
10213 (draw_table_cell) New function.
10214 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
10215 (som_get_table_size) Many nice new explanatory comments.
10216 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
10218 * som.h: New enum series SOM_CREATE_* for use as create flags with
10219 som_create_table().
10221 * str.h: Moved a comment here from TODO.
10223 * sysfile-info.c: New file. Reference implementation.
10225 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
10227 * command.c: Added RENAME VARIABLES to table of commands.
10229 * data-in.c: (dls_error) Sets `cust_field'.
10230 (parse_N) Message fix.
10231 (parse_day_count) New function.
10232 (to_roman) Never outputs VX as a `short form' of V.
10233 (parse_month) Fixed parsing of Roman numerals.
10234 (parse_trailer) Message fix.
10235 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
10236 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
10237 the date is invalid.
10238 (parse_SDATE) Fixed swapped day, year.
10239 (parse_JDATE) Fixed bug for dates in 1582.
10240 (parse_DTIME) Allows days not between 1 and 31.
10241 (parse_numeric) Makes local copy of f.type for easier usage.
10244 * data-out.c: (convert_F) When outputting as scientific, properly
10245 sets f.type as fp->type.
10246 (insert_commas) Fixed operator precedence problem with setting of
10247 nitems. Changed strcpy to memcpy (no null terminator).
10248 (convert_date) Fixed FMT_JDATE: added 1900 to year.
10249 (convert_CCx) Essentially rewritten, but now it works.
10251 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
10252 feature of Fiasco).
10253 (display_documents) Implemented.
10255 * error.c: (glob var cust_field) New var.
10256 (vmsg) Displays cust_field as part of message classes DE and DW.
10258 * formats.c: (debug_print) Fixed to compile under updated
10261 * get.c: (cmd_get, cmd_save_internal) Close file handle on
10264 * misc.c: (parse_format_specifier) Formatting fix.
10266 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
10267 `n_rename' for clarity.
10268 (cmd_modify_vars) Initializes `forward' and `positional' at
10269 appropriate times. Frees lists of vars to rename on failure.
10270 Comment fix. Frees memory on success.
10271 (rearrange_dict) Simplified `for' loop condition.
10273 * rename-vars.c: New file (reference implementation).
10275 * set.q: (internal_cmd_set) Fixed `emu' test condition.
10277 * sfm-read.c: (read_header) File label is created only if file
10278 label in file is not blank.
10279 (read_variables) Initializes `dict' local variable.
10280 (read_documents) Proper behavior on lossage.
10282 * sfm-write.c: (write_header) Doesn't blank out the file label
10283 (why was this here to begin with?!)
10285 * temporary.c: (save_dictionary) File label is copied only if
10286 non-NULL. Doesn't try to xstrdup() dictionary documents.
10287 Adapted so as to not irritate Checker.
10288 (free_dictionary) Only destroys var_by_name if non-NULL.
10290 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
10291 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
10292 lines to the document, indents the document. Also, it works now.
10293 (add_document_line) New function.
10295 * var.h: (struct dictionary) Reordering.
10297 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
10298 bits if it was allocated to begin with.
10300 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
10302 * command.c: Added MODIFY VARS to list of commands.
10304 * configure.in: Updated custom macros for autoconf 2.12. Removed
10305 mmap reference; fixed termcap library reference.
10307 * display.c: (display_variables) Fixed a few bugs although it's
10308 still not well written.
10310 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
10311 (induce_segfault) Calls chkr_disp_call_chain() instead of
10312 inducing an actual SIGSEGV.
10314 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
10315 str_search() and str_rsearch(). Fixed tests for matches on
10316 OP_INDEX and OP_RINDEX.
10318 * filename.c: (good_getcwd) Removed as the new libc for Checker
10319 doesn't contain this bug, apparently.
10321 * misc.c: (str_search, str_rsearch) Changed order of arguments for
10322 consistency with GNU memmem.
10323 (blp_getdelim) Changed `len' from `int' to `size_t'.
10325 * modify-vars.c: Reference implementation.
10327 * som-frnt.c: (zero_length) New global var.
10328 (som_create_table) Message fix.
10330 * som.h: Added gcc attributions to som_set_text(),
10331 som_output_text() prototypes. blank_line() refers to
10332 zero_length[] instead of a literal null string to suppress gcc
10335 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
10336 (allocate_cases) Decrements x_max so the last element of x[] can
10337 be used by the algorithm.
10339 * var.h: Changed minor details of `variable' declaration.
10340 (struct modify_vars_proc) New struct.
10341 (struct variable) Added field p.mfv.
10343 * vars-atr.c: Comment fix.
10345 * vars-prs.c: (fill_all_vars) More optimal implementation.
10347 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
10348 character, which it shouldn't have to do but printf() seems to
10349 read the null byte even though I supply a maximum length...
10351 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
10353 * command.c: Removed command alias X for QUIT.
10354 (parse_cmd) Fixed comment parsing.
10356 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
10358 (read_record) Fixed references to len, size.
10359 (dfm_get_record) Restructured.
10361 * file-handle.h: (struct file_handle) Field `lrecl' now of type
10364 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
10367 * modify-vars.c: New file. Not complete.
10369 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
10372 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
10373 problems caused by int/size_t differences.
10375 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
10378 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
10379 being compared were of equal length.
10381 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
10383 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
10385 * lexer.c: (get_dotted_rest_of_line) New function.
10387 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
10390 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
10391 type 6 records. Frees the dictionary properly.
10392 (read_header) Initializes the dictionary instead of letting
10393 read_variables() do it. Sets the dictionary file label from the
10395 (read_documents) New function.
10397 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
10398 write type 6 record if appropriate.
10399 (write_header) Writes file label from dictionary.
10400 (write_documents) New function.
10402 * temporary.c: (save_dictionary, restore_dictionary,
10403 free_dictionary) Properly handle new fields in dictionary struct.
10405 * title.c: (get_title) Returns after failure().
10406 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
10407 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
10409 * var.h: (struct dictionary) New fields `label', `n_documents',
10412 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
10414 * command.c: Added FILTER to list of commands.
10416 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
10419 * get.c: (cmd_save_internal) Removed weighting code since it's now
10420 handled by sfm-write.c. Properly commented out debug code.
10422 * glob.c: (glob var weighting) Removed.
10424 * sel-if.c: Comment fixes.
10425 (cmd_filter) New function.
10427 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
10428 (sfm_read_dictionary) Sets weighting variable direct in the
10429 created dictionary now. (Apparently we previously didn't support
10431 (read_header) Sets weight_index field in sfm_fhuser_ext from
10432 header read from disk.
10434 * sfm-write.c: (sfm_write_dictionary) Comment fix.
10435 (write_header) Now sets the weighting in the header from the
10436 passed primary dictionary instead of from the sfm_write_info.
10438 * sfm.h: (struct sfm_write_info) Removed field `weight'.
10440 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
10441 broke on boundary conditions.
10443 * var.h: (struct dictionary) New fields `weight_var',
10444 `weight_index', and `filter_var'.
10445 (glob var weighting) Removed. This is now part of struct
10446 dictionary. All references changed; the less mechanical changes
10447 are described above.
10449 * vars-atr.c: (find_dict_variable) New function.
10451 * vfm.c: (static var filter_index) New variable.
10452 (open_active_file) Initializes filter_index from default_dict.
10453 (write_case) Calls proc_func() only if the filter variable is
10454 nonzero; this implements FILTER behavior.
10456 * weight.c: (static var weight_varname) Removed.
10457 (cmd_weight) Modified default_dict instead of glob vars.
10458 (update_weighting) Changed the signature to modify a dictionary
10459 instead of glob vars. Now returns the weighting variable.
10460 (get_weighting_variable) Removed; its function is absorbed by
10461 update_weighting().
10462 (stop_weighting) Operates on a dictionary now.
10464 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
10466 * sort.c: Removed debugging info from messages.
10467 (do_external_sort) Cleans up after itself by deleting the
10468 temporary directory on failure. (On success it is deleted by the
10470 (allocate_cases) Removed debug code. Added clean up code.
10471 (output_record) Removed debug code.
10472 (merge) Added code to close all the input files that are currently
10473 open. This is a likely location for bugs, because I'm not sure
10474 about boundary conditions. Removed an unnecesary heap_delete().
10475 (merge_once) Removed input file "optimization" that in fact
10476 screwed up the rest of the code. Message and comment fixes.
10478 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
10480 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
10482 * heap.c: (heap_delete) New argument.
10484 * sort.c: Finished implementation of external sort.
10486 * vfm.c: (read_from_disk) Returns after a disk error.
10488 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
10490 * sort.c: (static var state) Removed.
10491 (static vars max_handles, tmp_basename, tmp_extname,
10492 huffman_queue) New variables.
10493 (do_external_sort) Moved most code to new functions.
10494 Creates huffman_queue.
10495 (allocate_file_handles, allocate_cases) New functions.
10496 (static vars run_no, run_length, file_index, case_count) New
10498 (output_record) Returns success. Now really writes to the output
10500 (begin_run, end_run) New functions.
10501 (write_initial_runs) Returns success. Initializes run_no to -1.
10502 Calls begin_run(), end_run() at appropriate times. Outputs debug
10504 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
10506 (merge) New function.
10508 * heap.c, heap.h: New files. Hopefully in near-final form.
10510 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
10512 * glob.c: Added write_active_file to global vars.
10514 * sort.c: Several new miscellaneous static variables.
10515 (cmd_sort_cases) Big comment fix.
10516 (perform_case_2) Renamed `do_external_sort' and completely
10518 (case_2_proc_func) Removed.
10519 (output_record, write_initial_runs, write_to_sort_cases,
10520 compare_record) New functions.
10522 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
10524 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
10526 * sort.c: (perform_case_2) Changed the method for allocation of
10527 lots of memory--now allocates one case at a time in hopes that
10528 more cases can be allocated with heavily fragmented memory.
10530 * var.h: (write_active_file) New global var.
10532 * vfm.c: (procedure, close_active_file, write_case,
10533 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
10534 arguments to procedure() to be NULL. All references to
10535 procedure() that made use of dummy functions were changed to NULL
10537 (open_active_file) If write_active_file is non-NULL, the output
10538 device becomes DEV_PGM (a new enum).
10539 (close_active_file) Sets write_active_file to NULL.
10540 (read_from_memory) Comment fix.
10541 (record_case) Calls write_active_file() when the output device is
10544 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
10546 * sort.c: New file.
10548 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
10549 Fixed checking for duplicate varnames.
10550 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
10552 (autorecode_trns_free) Destroys hash tables for each recoding
10554 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
10556 * command.c: Added SORT CASES to cmd_table.
10557 (null_func, null_int_func) Prototyped.
10559 * descript.g: (calc_weight, calc_noweight) Computes own case
10562 * frequencies.q: (dump_statistics) Fixed problem with
10563 too-few-cases warning message.
10565 * get.c: (cmd_save_internal) Handles weighting properly.
10567 * hash.c: (hsh_dump) Output format changed.
10568 (force_hsh_insert) Actually works now, prototype changed.
10570 * list.q: (static var case_num) New variable.
10571 (cmd_list) Initializes case_num.
10572 (list_cases) Increments case_num.
10574 * var.h: Added definitions for SORT CASES. Comment fixes.
10576 * vfm.c: Some definitions moved to new file vfmP.h. Comment
10577 fixes. `active' renamed vfm_active, `rep' renamed
10578 vfm_replacement, all references changed.
10579 (procedure) The procfunc no longer receives a case number. All
10580 references changed.
10581 (write_case) Subtle reordering.
10582 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
10585 * weight.c: (get_weighting_variable) New function.
10587 * vfmP.h: New file with definitions from vfm.c.
10589 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
10591 * command.c: (FILE_TYPE_okay) Commented out some tests because
10592 they're clumsy and not yet needed.
10594 * var.h: Most *_trns structures moved to their respective source
10595 files. Some were moved into a new file, do-ifP.h. Comment fixes.
10596 (union any_trns) Changed to a typedef for trns_header.
10597 (struct input_program_pgm) Removed.
10599 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
10600 was allocated in the first place.
10602 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
10604 * autorecode.c: New file.
10606 * command.c: Added AUTORECODE to command table; re-enabled SET.
10608 * data-out.c: (convert_F) Handles infinities and NaNs properly.
10610 * error.c: (vmsg) Comment fixes.
10612 * hash.c: Comment fix.
10613 (hashpjw_d) New function.
10614 (hashpjw) Reimplemented as call to more general function
10616 (internal_comparison_fn) Initializes pointers properly.
10617 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
10618 (force_hsh_insert, force_hsh_find) New debugging wrapper
10621 * main.c: (main) Message fix.
10623 * output.c: (outp_read_devices) Message fix.
10625 * set.q: Comment fixes.
10626 (custom_results) Implemented Wnd/X form of subcommand.
10627 (set_routing) New function.
10628 (internal_cmd_set) Implemented ERRORS, MESSAGES.
10630 * settings.h: (SET_ROUTE_*) New enum series.
10631 (set_results) Renamed set_results_file, all references changed.
10632 (set_messages) Removed.
10633 (glob vars set_errors, set_messages, set_results) New vars.
10635 * title.c: (get_title) Remembers to xstrdup() the result of
10636 get_rest_of_line().
10638 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
10640 (union any_trns) New element `arc'.
10642 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
10644 * command.c: (output_line) Removed references to set_screen.
10646 * error.c: (static var terminating) New var.
10647 (hcf) Sets terminating to 1.
10648 (vmsg) If terminating is nonzero, does not attempt to call hcf().
10649 This prevents an infinite loop if an error occurs within hcf().
10651 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
10652 statement circumlocution with `case 42000' trick.
10653 (evaluate_expression) New support for OP_STR_MIS.
10655 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
10656 statement circumlocution with `case 42000' trick.
10657 (dump_node) Handles OP_STR_MIS.
10659 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
10660 variables exceptions.
10661 (parse_function) Message fix.
10662 (ops[]) Added OP_STR_MIS.
10664 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
10666 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
10668 * glob.c: Removed set_scrnfile glob var.
10669 (init_glob) set_errorbreak set to 0 by default.
10671 * groff-font.c: Changed included files.
10672 (groff_read_font) Initializes font_arena local var correctly.
10673 (default_font) New function.
10675 * output.c: Comment fixes.
10676 (glob var disabled_devices) New variable.
10677 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
10679 [GLOBAL_DEBUGGING] (reentrancy) New function.
10680 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
10681 outp_iterate_enabled_drivers) Calls to reentrancy().
10682 (destroy_list) New function.
10683 (outp_done) Moved code to destroy_list().
10684 (parse_options) Parses `listing', `screen', `printer' options
10686 (configure_driver) Sets new `device' member of driver.
10687 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
10689 * output.h: Comment fixes. New enum series OUTP_DEV_*.
10690 (struct outp_driver_struct) New member `device'.
10692 * postscript.c: (find_encoding_file) Doesn't display its own error
10694 (default_encoding) New function.
10695 (switch_font) Calls default_encoding() if no encoding can be
10697 (text) Makes up a character metric if none exists for the desired
10699 (load_font) Properly copies a fallback filename. Calls
10700 default_font() for a font if none at all are known.
10702 * set.q: Comment fixes. Removed OUTPUT subcommand.
10703 (custom_listing) Calls outp_enable_device() to enable/disable
10705 (turn_screen_on) Removed.
10706 (internal_cmd_set) Calls outp_enable_device() to enable/disable
10707 screen, printer devices.
10709 * settings.h: Comment fixes.
10710 (glob vars set_output, set_printer, set_screen, set_scrnfile)
10713 * som-high.c: (som_submit_table, som_eject_page) Use
10714 outp_iterate_enabled_drivers() instead of iterating
10715 outp_driver_list directly.
10717 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
10719 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
10720 (parse_string_as_format) Handles new formats.
10721 (parse_numeric) Now handles DOT and PCT formats.
10723 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
10725 (convert_date) Handle EDATE and SDATE formats.
10726 (convert_CCx) Now if there's not room for the currency characters,
10727 converts it as F format if it's positive instead of giving up
10728 quickly. Also fixed save-and-restore bug with decimal point
10730 (convert_format_to_string) Handles new formats.
10732 * misc.c: (formats[]) Added new formats.
10733 (convert_fmt_ItoO) Supports new formats.
10735 * sfm-read.c: (parse_format_spec) Supports new formats. Better
10736 data checking. New argument, all references changed.
10738 * sfm-write.c: (write_format_spec) Supports new formats.
10740 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
10743 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
10745 * cmdline.c: Comment fixes.
10746 (parse_command_line) Changed return type to void.
10748 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
10750 (parse_numeric) Handles international numbers (comma as decimal
10751 point). Some reformatting.
10753 * data-list.c: (parse_free) Default output format is now
10754 set_format instead of hard-coded F8.2.
10755 (read_from_data_list_list) Emits error message on undefined data
10756 only if set_undefined is nonzero.
10758 * data-out.c: (convert_E) Changes decimal point from period to
10759 comma if appropriate. Restructured. Better comments.
10760 (convert_F) Changes decimal point from period to comma if
10762 (insert_commas) Major bug with handling of negative values fixed.
10763 Also, inserts periods instead of commas if appropriate.
10764 (convert_CCx) New function.
10765 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
10766 (num_to_string) Changed `.' to set_decimal.
10768 * dfm.c: Comment fixes.
10769 (dfm_close) Frees ext->line even in inline_file.
10770 (open_inline_file) New function.
10771 (open_file_r) When opening the inline file: now properly
10772 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
10774 (read_record) Calls fh_close_handle() instead of dfm_close() to
10775 close the inline file. Makes a copy of the line getl_buf to avoid
10776 interlock problems.
10777 (dfm_get_record) Restructured. Now checks the return value of
10779 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
10780 checking for use of inline file. No longer tries to close inline
10783 * error.c: (glob var error_already_flagged) New var.
10784 (vmsg) Message change. Now checks max number of errors/warnings,
10787 * file-handle.q: (fh_handle_name) Now allows closing of
10789 (fh_init_files) Reformatted.
10791 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
10793 * getline.c: (getl_include) Fixed bug that popped up when called
10794 when file queue was empty.
10795 (read_console) Resets error_count, warning_count,
10796 error_already_flagged to zero.
10798 * glob.c: Many changes to update list of variables.
10799 (init_compat_dependent) Now this function is called whenever
10800 `compat' changes. It now sets set_seed only if it hasn't
10801 previously been referenced. It now calls
10802 lex_init_compat_dependent().
10804 * include.c: (cmd_include_at) Frees temporary buffer instead of
10806 (cmd_include) Doesn't make copy of include file name.
10808 * lexer.c: Comment fixes.
10809 (init_lex) Moved some code into new function
10810 lex_init_compat_dependent().
10811 (lex_init_compat_dependent) New function.
10812 (hex_val) Simplified.
10813 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
10815 * main.c: Comment fixes.
10816 (main) Reformatted.
10818 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
10819 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
10820 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
10821 (setup_randomize) Sets set_seed_used.
10823 * set.q: Comment fixes.
10824 (custom_results) Conditionalizes on `compat'.
10825 (custom_log) Calls custom_journal().
10826 (set_ccx) New function.
10827 (cmd_set) Calls init_compat_dependent() when `compat' changes.
10828 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
10829 when set_decimal changes. Range-checks values for MITERATE,
10830 MNEST. Message fixes.
10832 * settings.h: Comment fixes.
10833 (struct set_cust_currency) New struct.
10834 (set_cc[], set_grouping, set_seed_used) New global vars.
10836 * var.h: (FMT_CCA...FMT_CCE) New output formats.
10837 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
10839 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
10841 * glob.c: Revised variables to correspond to settings.h.
10842 (init_glob) Initializes variables from settings.h properly.
10844 * set.q: Began long-overdue major revision to correspond to new
10845 philosophy. Most code changed.
10847 * settings.h: Mostly changed; reorganized, reordered, large new
10850 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
10852 * get.c: (cmd_save_internal) No longer forces compression off.
10854 * sfm-read.c: (read_compressed_data) If eof is reached when
10855 reading a new instruction octet, only signal error if we're in the
10858 * sfm-write.c: (COMPRESSION_BIAS) New #define.
10859 (struct sfm_fhuser_ext) New member `end'.
10860 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
10861 (ensure_buf_space) New function.
10862 (sfm_write_case) Reimplemented in order to support compression.
10863 (sfm_close) Writes out the remaining contents of the compression
10866 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
10868 * command.c: Defined SAVE and XSAVE commands in command table.
10870 * common.h: second_lowest_value is of type flt64, not double.
10872 * file-handle.h: Comment fix.
10874 * get.c: Comment fixes.
10875 (static var `trns') New.
10876 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
10877 cmd_save_internal, cmd_save, cmd_xsave) New functions.
10878 (dict_delete_run) Clears the variables and frees them now.
10879 (trim_dictionary) Sets default for compression.
10880 On KEEP subcommand, frees deleted variables as well as clearing
10881 them. Finally got the sense of the test for deleting all
10883 [DEBUGGING] (dump_dict_variables) Message fix.
10885 * glob.c: (init_glob) set_compression set to 1 by default.
10887 * list.q: Properly #includes config.h.
10889 * misc.h: New macro REM_RND_UP.
10891 * settings.h: Comment fix.
10893 * sfm-read.c: (structs sysfile_header, sysfile_format,
10894 sysfile_variable; inline function bswap_int32) Moved to new file
10896 (corrupt_msg) [__CHECKER__] No longer induces segfault.
10897 (sfm_read_dictionary) Fixed bug caused by failing to initialize
10899 (read_machine_flt64_info) Fixed some problems caused by confusion
10900 between flt64 and double types.
10901 (read_header) Message fix.
10902 (read_variables) Fixed set of cases in which we byte-swap sv.print
10903 and sv.write. Fixed confusion of flt64 and double.
10905 * sfm.h: (struct sfm_write_info) New.
10907 * som-high.c: (som_draw_title) Properly frees `s'.
10909 * temporary.c: (save_dictionary) Comment fix.
10911 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
10912 (struct trns_header) Formatting fix.
10913 (struct save_trns) New.
10915 * vars-atr.c: (discard_variables) Comment fix.
10917 * sfm-write.c: New file, baseline release.
10919 * sfmP.h: New file, baseline release.
10921 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
10923 * cmdline.c: (parse_command_line) `--version' output updated.
10924 (glob var syntax_message[]) Added my e-mail address.
10926 * file-handle.q, lexer.c, vfm.c: Changed many instances of
10927 `illegal' to `invalid'.
10929 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
10930 uncompression buffer.
10931 (sfm_close) Frees decompression buffer.
10932 (sfm_read_dictionary) Initializes decompression buffer.
10933 (buffer_input, read_compressed_data) New functions.
10934 (sfm_read_case) Restructured; now calls read_compressed_data() to
10935 handle compressed system file data.
10937 * var.h: Comment fix.
10939 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
10941 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
10944 * get.c: New comments. New static var `get_file'.
10945 (cmd_get) Now fully implemented. Calls discard_variables();
10946 initializes fv and lv for all variables; new debug code; sets
10947 up the dictionary; sets up the input program.
10948 (read_from_get, cancel_get) New functions.
10950 * sfm-read.c: Comment fixes.
10951 (sfm_close) New static function.
10952 (sfm_read_dictionary) Properly sets up the class of the
10953 file_handle. No longer cares what size the data is in records of
10954 type 7. Also, on failure, properly cleans up the file_handle and
10955 free()s some stuff.
10956 (read_variables) No longer thinks it knows `nval' of the
10957 dictionary. Now sets p.get.fv, etc., instead of speculatively
10959 (read_value_labels) Fixed off-by-one error in indexing of
10961 (sfm_read_case) New function.
10962 (sfm_r_class) New static var.
10964 * var.h: (get_proc) New struct.
10965 (struct variable) New member p.get.
10967 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
10969 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
10970 the manual's meaning.
10971 (rename_variables) New function.
10972 (trim_variables) Doesn't try to parse MAP any more. Removed debug
10973 code. Now properly reorders the dictionary on the KEEP keyword.
10975 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
10976 garbage collection.
10978 * vars-atr.c: (clear_variable) New argument `dictionary *'.
10979 (rename_variable) New function.
10980 (free_val_lab) Reformatted.
10982 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
10984 * var.h: Reindented entire file. Comment fixes.
10985 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
10987 (glob var default_dict) New.
10988 (struct indirect_dictionary) Removed.
10990 * Many other source files were changed to add `default_dict.'
10991 before all references to the dictionary of the active file.
10993 * vars-atr.c: (make_indirect_dictionary) Removed.
10995 * glob.c: Reindented all variable declarations. Updated for
10996 changed var.h. Comment fixes.
10998 * temporary.c: (restore_dictionary, save_dictionary) Simplified
10999 because now we can mainly copy dictionary structs.
11001 * vars-prs.c: (is_dict_varname, parse_dict_variable,
11002 parse_variables) Takes dictionary instead of indirect_dictionary
11004 (parse_variables) Instead of calling make_indirect_dictionary,
11005 just sets DICT to &default_dict if DICT is NULL. Of course, lots
11006 of `*dict.' references had to be changed to `dict->'. Removed
11009 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
11011 * get.c: Added GTSV_OPT_* series of enums.
11012 (trim_dictionary, dict_delete_run) New functions.
11013 [DEBUGGING] (dump_dict_variables) New function.
11014 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
11015 [DEBUGGING] Calls dump_dict_variables() to display results.
11017 * glob.c: (cmp_variable) Now a public function declared in var.h.
11019 * sfm-read.c: Turned off debug code. Comment fixes.
11020 (read_machine_int32_info, read_machine_flt64_info) New functions
11021 to parse type 7 records.
11022 (sfm_read_dictionary) Properly byteswaps several fields now.
11023 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
11024 records. [DEBUGGING] Dumps dictionary.
11025 (read_variables) Sets `index' field of variables created properly.
11026 Constructs avl tree of variables in dictionary. [DEBUGGING] No
11027 longer dumps dictionary.
11028 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
11030 [DEBUGGING] (dump_dictionary) No longer stubbed out.
11032 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
11033 var before destroying any variables just to save a little time.
11035 * var.h: (struct variable) Reordered in order to make name[] the
11036 first member; this makes pointers to `variable' pointers to the
11037 variable name, simplifying avl trees, etc.
11038 (struct indirect_dictionary) New struct.
11040 * vars-atr.c: (find_variable) Rewritten for efficiency.
11041 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
11043 (is_varname) Rewritten for efficiency.
11044 (parse_variables) New argument, which is a `dictionary *'. All
11045 references changed. This function now reads variable names from
11046 the dictionary passed, or from the default dictionary if NULL.
11048 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
11050 * misc.h: Added new macro DIV_RND_UP to perform integer division,
11051 rounding up. Changed many references to ROUND_UP to use this
11054 * sfm-read.c: Includes avl.h.
11055 (corrupt_msg) Induces a segfault under Checker.
11056 (macro assertive_bufread) New. Many references to bufread() now
11058 (sfm_read_dictionary) Split up into several functions. Added code
11059 to read dictionary records following the the type 2 records. Not
11060 quite complete. New variable `var_by_index'.
11061 (read_header, read_variables) New functions extracted from
11062 sfm_read_dictionary().
11063 (read_value_labels) New function.
11064 (bufread) Checks ferror() if fread() doesn't return the expected
11065 value; if ferror() is zero it's just EOF.
11066 (dump_dictionary) Stubbed out.
11068 * BTW: The source code now exceeds 50000 lines!
11070 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
11072 * command.c: Added GET to cmd_table[].
11074 * list.q: Removed reference to alloca headers.
11075 (cmd_list) Gave prototype.
11077 * sfm-read.c: Added DEBUGGING comments.
11078 (sfm_read_dictionary) Checks bias correctly. Sets
11079 dict->var_by_name to NULL. Calculates long_string_count
11080 correctly. realloc's dict->var[] array to minimum size.
11081 [DEBUGGING] Calls dump_dictionary.
11082 [DEBUGGING] (dump_dictionary) New function.
11084 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
11085 (restore_dictionary) If the dictionary contains a non-NULL
11086 var_by_name, uses that instead of generating one.
11087 (free_dictionary) Destroys var_by_name.
11089 * var.h: (struct dictionary) Added field `var_by_name'.
11091 * get.c: New file, not complete.
11093 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
11095 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
11096 (parse_num_or_range) New function.
11097 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
11098 <n> THRU HIGH missing values.
11100 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
11101 __attribute__((const)).
11103 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
11105 * sfm-read.c: Finished reference implementation.
11107 * sfm.h: Includes var.h.
11109 * var.h: Comment fixes.
11110 (struct `variable') Reordered some fields.
11112 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
11113 constants added previously.
11115 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
11117 * common.h: Comment fixes. Added declaration of
11118 `second_lowest_value' as variable or macro. Made `compat_type',
11119 `pgm_state_type' into anonymous enums.
11121 * display.c: Comment fix.
11123 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
11125 [!defined SECOND_LOWEST_VALUE] Added definition for
11126 `second_lowest_value' global var.
11127 (compat, pgm_state global vars) Changed types to `int'.
11128 (init_glob) Initializes `second_lowest_value'.
11130 * sfm-read.c: Continued work, not complete.
11132 * var.h: Added new MISSING_* constants to handle LOWEST and
11135 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
11137 * sfm-read.c: New file, not complete.
11139 * cases.c: (vec_insert) Changed vector expansion algorithm.
11140 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
11141 mucking up the RECODE transformation in particular.
11142 (envector) Harmless change in notation.
11144 dfm is now fairly well tested again.
11145 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
11147 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
11149 * recode.c: Comment fix.
11151 * sfm.h: Interface should be fairly final now, or at least for a
11154 * vfm.c: [DEBUGGING] (index_to_varname) New function.
11155 (open_active_file) [DEBUGGING] Translates ccase indices into
11156 variable names now to make it easier to understand what's really
11159 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
11161 * data-in.c: Comment fix.
11163 * data-list.c: Includes dfm.h.
11164 (do_reading) Uses new function dfm_push_cust().
11166 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
11167 `return 1;' at end.
11169 * file-handle.h: Completely changed. Some parts split off into
11170 new file dfm.h. Implemented in file-handle.q.
11171 (enum FH_*) Removed.
11172 (struct fh_ext_class) New struct.
11173 (struct file_handle) Retained only these fields: name, norm_fn,
11174 fn, recform, lrecl, mode. New fields class, ext.
11175 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
11176 close_handle, handle_name) Added `fh_' prefix to name, all
11177 references changed.
11179 * dfm.h: New file, implemented in dfm.c.
11180 (get_record, put_record, fwd_record, bkwd_record, set_record,
11181 get_cur_col) Functions moved from file-handle.h, now prefixed with
11183 (dfm_push_cust) New function.
11185 * sfm.h: New file. Incomplete.
11187 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
11188 interface. Functions reordered, comments changed. Not well
11189 tested, probably full of bugs.
11190 (struct dfm_fhuser_ext) New struct.
11191 (dfm_close) New function.
11192 (open_file_r) Pickier about finding `BEGIN DATA.' line.
11193 (open_file_w) User messages changed.
11194 (get_record) Comment fixed.
11195 (read_record) Increments ext->ln even for inline_file. Calls
11196 dfm_close() for inline_file when `END DATA.' encountered.
11197 (dfm_get_record) Experimental restructuring.
11198 (dfm_push_cust) New function.
11199 (cmd_begin_data) Detects whether the inline file was fully read by
11200 checking whether it is still open; detects whether it was read at
11201 all by checking whether the line number is greater than zero.
11203 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
11204 interface. Functions reordered, comments changed. Not well
11205 tested, probably full of bugs.
11206 (init_file_handle) Removed initializers for obsolete fields, added
11208 (fh_close_handle) Much simpler, now mainly calls the class
11210 (fh_init_files) Renamed inline file internal filename.
11212 * file-type.c: Includes dfm.h.
11213 (read_from_file_type) Doesn't use dfm internal state anymore.
11215 * inpt-pgm.c, print.c: Include dfm.h.
11217 * recode.c: (internal_cmd_recode) Casts strlen() return value to
11218 int in comparison with other int.
11220 * som-high.c: (build_target) Fixed operator precedence problem in
11221 if statement (& versus ==).
11223 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
11225 * dfm.c: (read_record) Can now read fixed-length records; not
11227 (put_record) Can now write fixed-length records; not tested.
11229 * file-handle.h: FH_* defines changed to enums. New enum series
11231 (struct file_handle) New members recform, lrecl, mode.
11233 * file-handle.q: Parser changed.
11234 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
11235 /LRECL subcommands. These are compatible with Windows.
11236 (init_file_handle) Initializes recform, mode fields.
11238 * q2c.c: (get_line) When outputting `!' comment lines, now
11239 increments the output file line number so that `#line' directives
11241 (make_identifier) New function that converts an arbitrary string
11242 into a valid C identifier.
11243 (dump_vars) Calls make_identifier() in two places in order to
11244 suppress some errors for bad identifiers.
11245 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
11246 for NO. Allows numbers to be prefixed by underscores to make them
11247 acceptable C identifiers but still to be parsed as numbers by the
11250 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
11252 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
11254 * dfm.c: Comment fixes. (get_record) Gives error if file handle
11255 was opened for writing.
11256 (open_file_w) New function.
11257 (read_record) Uses strncasecmp if available. Improved error
11258 messages, comments.
11259 (put_record) New function.
11261 * file-handle.h: Moved function comments into dfm.c and
11262 file-handle.q. Comment fixes. Removed declarations of
11263 tilde_expand() and normalize_filename().
11264 (struct file_handle) Changed `open' from boolean to enumerated
11265 field to allow for three states--closed, open for reading, open
11266 for writing--all references changed.
11268 * file-handle.q: Includes filename.h.
11270 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
11271 references changed.
11272 (alloc_line) Makes allowance for line terminator characters in
11274 (print_trns_proc) Now handles OUTFILE, WRITE differences.
11275 (print_space_trns_proc) Handles OUTFILE differences.
11277 * recode.c, sample.c: Comment fixes.
11279 * var.h: (struct print_trns) Changed boolean field `eject' to
11280 bitmapped field `options'; all references changed. New enums
11281 PRT_* for use with this field.
11283 * exception.h, test-exception.c: Removed.
11285 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
11287 * ascii.c: (delineate) Turned off debug output.
11289 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
11292 * data-in.c: (parse_string_as_format) Sets the entire string value
11293 to spaces, not just the short string part of it. Is this correct
11296 * data-out.c: (convert_date) Fixed DATETIME format problems with
11297 decimal places, removed debug code.
11299 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
11300 middle of parsing BEGIN DATA that would cause the lexer to read
11301 from a wild pointer `prog'; now calls new function
11302 preprocess_line() in lexer.c.
11304 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
11306 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
11307 Now call induce_segfault() to induce the segfault.
11308 (induce_segfault) New function.
11310 * expr-opt.c: Comment fix.
11311 (parse_sysvar) New function.
11312 (parse_primary) Added system variable support--calls
11314 (global var ops) Added OP_CASENUM operator.
11316 * expr.h: Comment fixes.
11317 (OP_* enum) added OP_CASENUM operator.
11318 (struct casenum_node) New struct.
11319 (union any_union_union) New member `cas' of type `casenum_node'.
11321 * glob.c: (global var last_vfm_invocation) New var.
11322 (init_glob) Initializes last_vfm_invocation.
11324 * lexer.c: (lookahead) Fixed reversed condition on if statement.
11326 * getline.c: (get_line) Split into get_line() and preprocess_line().
11327 (preprocess_line) New function.
11329 * var.h: Declares last_vfm_invocation.
11331 * vfm.c: (procedure) Sets last_vfm_invocation.
11333 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
11335 * command.c: (parse_cmd) Fixed bad assertion related to
11338 * data-in.c: (parse_month) Implemented to parse months according
11339 to full interpretation of standard.
11340 (to_roman) New function.
11341 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
11342 (parse_weekday) Bug fix (forgot to skip all the day name).
11344 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
11345 up parsing of multirecord data items. Also fixed user message.
11347 * data-out.c: Comment fix.
11348 (year2, year4, convert_date, convert_time, convert_WKDAY,
11349 convert_MONTH) New functions to support time & date output.
11350 (convert_format_to_string) Calls new time & date output routines.
11352 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
11354 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
11357 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
11359 * misc.c: (global var formats) Fixed declarations of DATETIME,
11362 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
11363 the output_char buffer.
11365 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
11366 memory bug. Fixed user messages.
11368 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
11370 * Removed #pragma argsused from lots of places.
11372 * data-in.c: Implemented zoned decimal and time-date formats.
11373 Untested. This is a huge chunk of code--maybe 1000 lines and 50
11376 * data-out.c: Implemented zoned decimal format.
11378 * expr.h: Moved yrmoda() declaration here from exprP.h.
11380 * misc.c: (global var formats) Minor fixes--added
11381 FCAT_SHIFT_DECIMAL to formats N and Z.
11382 (convert_fmt_ItoO) Added support for format Z.
11384 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
11386 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
11388 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
11389 som_check_workspace() that is activated between commands.
11391 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
11394 * list.q: (begin_row) Changed title expansion style from
11395 SOPT_X_VERT to SOPT_X_SHSP.
11397 * som-frnt.c: Now includes `somP.h'.
11398 (som_push_workspace, som_pop_workspace) New functions that, taken
11399 together, form a solution to the recursive table building problem
11400 mentioned yesterday. Surrounded every table output routine
11401 throughout the program with calls to these functions.
11402 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
11403 (som_create_table) Checks that there's an active workspace.
11404 (som_destroy_all_tables, som_crush) Removed.
11406 * som-high.c: (global var som_preserve_tables) Removed, all
11407 references deleted.
11408 (som_submit_table) Checks that there's an active workspace.
11409 (dump_columnated_table) Doesn't columnate tables that would have
11410 just one row per column.
11411 (dump_crush_page, som_dump_crush_page) Removed debugging code.
11412 (som_dump_crush_page) Moved row number labels from left side of
11413 tables to right side.
11414 (som_get_table_size) Added support for SOPT_X_SHSP.
11416 * som.h: New cell expansion type SOPT_X_SHSP.
11418 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
11420 (global var curtab_arena) Moved from som-frnt.c.
11422 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
11424 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
11425 that causes bad location warnings to be suppressed.
11426 (delineate) Saves current font when calling draw_text(); fixed
11427 handling of NULLs when backing up. Also fixed line-wrapping bug.
11429 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
11430 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
11432 * common.c: Added code to cause assertion failure to dump core
11433 when run under Checker.
11435 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
11436 there are still bugs.
11438 * glob.c: (__eprintf) Removed.
11440 * list.q: Inserted som_preserve_tables kluge that prevents tables
11441 from being thrown away due to recursive table building through
11442 som_output_line being called from a transformation during the LIST
11443 procedure invocation. This is a general problem that must be
11444 solved in a better way since it applies to all procedures in
11446 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
11447 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
11449 * numeric.c: Fixed several errors in the form of msg() calls.
11451 * print.c: Updated for use of som.
11452 (dump_table) Reimplemented.
11453 (print_trns_proc) Calls som_eject_page() instead of eject_page().
11454 Calls som_output_text() instead of outs_line().
11456 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
11458 (som_output_text) Function moved from som-low.c. Interface
11461 * som-high.c: (som_preserve_tables) New global public variable
11463 (som_submit_table) Destroys the tables only if som_preserve_tables
11465 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
11466 one subrow per row. Now labels subrows if there's more than one
11468 (dump_crush_table) Added wishlist comment.
11469 (som_eject_page) New public function declared in som.h.
11471 * som-low.c: (som_dump_crush_page) Draws row labels if there's
11472 more than one subrow per row.
11473 (som_output_text) Moved to som-frnt.c.
11475 * som.h: (SOM_TOPT_PRESERVE) Removed.
11477 * title.c: (get_title) Changed interface.
11478 (cmd_title) Changed `title' to `outp_title'.
11479 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
11481 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
11483 * list.q: (flush_table) Conforms to new partial options in
11484 som_submission_form.
11486 * som-high.c: (paginate_horizontally) Changed form of subrow
11488 (build_target) Omits spacing before table if
11489 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
11490 (dump_crush_page) Changed interface. Only trims bottom rule if
11491 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
11492 (dump_crush_table) Handles partial tables.
11493 (output_row_label) New function.
11494 (som_dump_crush_page) Emits subrow number labels. Draws vertical
11495 rule on the right edge of narrow subrows.
11497 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
11498 constants to a series of SOM_TOPT_PARTIAL_* submission options.
11499 All references updated.
11501 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
11503 * misc.c: Comment fix.
11505 * som-high.c: (examine_table) Treats crushed tables separates for
11506 purpose of determining header size.
11507 (paginate_horizontally) Allots space for line numbers in crushed
11508 tables with lots of subrows per row. Calculates the `maximum page
11509 width', the width of the widest horizontal page.
11510 (build_target) Removed trim argument; all references changed.
11511 Stricter assertions. (dump_crush_page) New function.
11512 (dump_crush_table) Reimplemented.
11514 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
11515 (som_dump_crush_page) Reimplemented, interface changed.
11517 * somP.h: Many many new helper macros for use with crushed tables.
11518 (global var som) Removed `tv', `cum_y' members; all references
11519 removed. New members `mpw', `digit_space'.
11521 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
11523 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
11524 variable, changed to constant 1024.
11525 (arena_ca_strdup) Changed `sizeof(a_string)' to
11526 `sizeof(c_string)'.
11527 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
11528 `(c_string *)' to `(char *)'; this fixed some offset problems.
11530 * filename.c: (readlink_malloc) Changed initial allocation from
11532 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
11535 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
11536 &fm->owner in several places.
11538 * som-high.c: (output_table) Changed interface to rest of world.
11539 (examine_crush_table) Removed. Crushed tables are re-broken now,
11540 in preparation for rewrite.
11542 * som.h: Comment fix.
11544 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
11546 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
11547 itself in the cleanup stage.
11549 * descript.q: (display) At least temporarily, changed the table
11550 format to a crushed table.
11552 * list.q: (begin_row) At least temporarily, added horizontal lines
11555 * som-high.c: (examine_crush_table) Sets som.hh to the width of
11556 the horizontal "headers," that is, to the width of the far left
11557 and far right rules.
11558 (justify_pagination) Sets som.th to the width of the widest row
11559 in the crushed table. Fixed inner loop off-by-one error.
11561 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
11564 * somP.h: Comment fix.
11566 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
11568 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
11569 before closing it; also, opens the constructed filename `s'
11570 instead of f->filename.
11572 * postscript.c: Moved initialization of x->loaded, x->prop,
11573 x->fixed, x->current, also the add_encoding() calls, into
11575 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
11576 sets x->last_font to NULL; sets x->next_combo to zero.
11578 * som-high.c: (crushed_row_height) Moved definition farther up.
11579 (som_submit_table) Doesn't calculate line width, font size until
11580 after calling open_page(), to accomodate changes to PostScript
11582 (vert_headers) Removed; equivalent functionality moved to
11583 examine_table(), examine_crush_table().
11584 (justify_pagination) Replaced with different algorithm.
11585 (dump_crush_table) Bugfix that caused tables to fail to be clipped
11586 at the bottom of the page.
11588 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
11590 * command.c: Added cmd_list back into cmd_table.
11592 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
11593 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
11595 * list.q: (flush_table) Updated to new som_submission_form format.
11597 * som-frnt.c: Comment fix.
11599 * som-high.c: Changed `#endif' to `#undef EXTERN'.
11600 (output_table) Calls som_get_table_size() directly; handles
11602 (examine_crush_table) New function; calls vert_headers().
11603 (examine_table) Moved some code into new function, vert_headers().
11604 (justify_pagination) New function.
11605 (dump_plain_table) Removed `static' from `cy'.
11606 (dump_crush_table) New function.
11608 * som-low.c: (som_dump_crush_page) New function.
11610 * som.h: Comment fixes.
11611 (enum SOM_TOPT_CRUSH) New.
11612 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
11613 Temporarily set to zero to make do with LIST procedure.
11615 * somP.h: Re-ordering.
11617 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
11619 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
11621 * somP.h: New file for use by som-high.c, som-low.c.
11623 * q2c.c: Added definition for VME.
11624 (get_line) Now dumps `!' comment lines to the output file
11627 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
11628 set.q: Changed format of `!' comment lines.
11630 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
11632 * All source files: Added copyright notice.
11634 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
11635 longs in msg() calls.
11637 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
11639 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
11641 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
11643 * output.c: (outp_read_devices) Changed criteria for
11644 distinguishing different types of lines.
11646 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
11648 * cmdline.c: Changed syntax message.
11650 * filename.c: (good_getcwd) Bug fix (?).
11651 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
11653 (search_path) Appends DIR_SEPARATOR to directory name only if it
11654 does not already end with one.
11656 * glob.c: Checks STAT_PAGER envvar before PAGER.
11658 * output.c: Checks environment variables instead of just local
11661 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
11663 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
11664 when the pointer passed to the function was within the arena
11665 itself, so that it couldn't properly be set to NULL _after the
11668 * command.c: Re-enabled DISPLAY.
11670 * display.c: Rewritten to handle tables. Untested.
11672 * filename.c: (search_path) Fixed memory leak.
11674 * frequencies.q: (cmd_frequencies) Frees v_variables.
11675 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
11676 (cleanup_freq_tab) New function to garbage collect.
11677 (dump_full) Elegantized.
11679 * main.c: New comment.
11681 * output.h: New tag for tagged quotes: TAG_NEWLINE.
11683 * postscript.c: Comment fix.
11684 (release_fontmap, free_font_entry) New functions.
11685 (ps_init_driver) Sets free_font_entry() as the freefunc for
11686 hashtable `loaded'. Calls release_fontmap() when destroying a
11687 driver; also frees the output filename; also frees the
11688 ps_driver_ext block.
11689 (free_ps_encoding) Frees the filename as well as the encoding
11691 (output_encodings) Frees the line buffer and pops the msg-filename
11693 (read_fontmap) Frees the fontmap filename and the line buffer.
11694 (postopen, preclose) Misc. garbage collection fixes.
11695 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
11696 to NULL; this fixes some output problems.
11697 (text) Handles TAG_NEWLINE. Untested.
11699 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
11700 (som_set_string) Removed. All references changed to
11702 (som_set_text) Rewritten. New interface. More general.
11704 * som.h: Minor format changes.
11705 (struct som_value_cell) Removed; all references changed to
11707 (enums SOT_*) Changed.
11709 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
11711 * command.c: Re-enabled SPLIT FILE.
11713 * postscript.c: Comment fix.
11715 * som.h: Added `SOT_NONE'.
11717 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
11719 * vfm.c: (dump_splits) Reimplemented.
11721 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
11723 * Compiled the project under gcc 2.7.2, which gave some new
11724 warnings. This led to many additions of casts from unsigned to
11725 int sprinkled throughout the code.
11727 * arena.c: Many uses of `unsigned' changed to `size_t'.
11729 * command.c: Added END FILE, END REPEAT to command table.
11730 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
11731 (find_command, FILE_TYPE_okay) Not commented out anymore.
11732 (parse_cmd) Calls FILE_TYPE_okay again.
11733 (output_line) Added calls to som_output_text() to put the line
11734 in the output files.
11736 * common.c: (macro VME) Format changes.
11737 (xstrdup) Asserts that its argument is not NULL.
11739 * data-list.c: Implemented dump_fixed_table().
11741 * inpt-pgm.c: Formatting changes. Comment changes.
11742 (end_case_proc) Renamed end_case_trns_proc.
11743 (cmd_end_file, end_file_trns_proc) New functions.
11745 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
11747 * misc.h: (local_strdup) New macro corresponding to strdup() but
11748 allocating its data through local_alloc() if possible--that is, if
11751 * postscript.c: Comment changes.
11752 (quote_ps_name, quote_ps_string, output_encodings) New functions.
11753 (output_line, add_string) New macros supporting
11754 output_encodings().
11755 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
11756 substitution vars. Calls output_encodings() when a line
11757 consisting of `!encodings' is encountered.
11758 (preclose) Some code moved into quote_ps_string().
11759 (dump_line) Changed into macro supporting dump_fancy_line().
11760 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
11761 command when appropriate.
11762 (write_text) Fixed `literal_char' array (I think it's fixed, at
11764 (text) Fixed bug when width was zero. Now exits immediately on
11765 zero height_left. Now, when executing `goto restart;', checks
11766 that cp<end, so that we don't read beyond end-of-string. Also,
11767 outputs the correct code to the output file by outputting the code
11768 from the metric instead of the internal metric index.
11770 * repeat.c: (cmd_end_repeat) New function.
11772 * som.c: (var som) `headers' renamed `options' and semantics
11773 changed. All references changed.
11774 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
11775 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
11777 (som_text_table) Removed.
11778 (som_output_text) New function.
11780 * som.h: (struct som_submission_form) Removed `header', `reuse',
11781 replaced with bitmapped field `options'.
11782 (SOM_TOPT_*) New enum set for som_submission_form.options.
11783 (SOT_*) New enum set for som_output_text().
11785 * temporary.c: (copy_variable) When copying the var label, only
11786 calls xstrdup() if it's non-NULL.
11788 * var.h: (enum type `vartype') Removed; all references changed to
11791 * vars-atr.c: (init_variable) Changed local var `nbytes' from
11794 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
11796 * font.h: Comment changes.
11798 * groff-font.c: (groff_read_font) Initializes `name' field to
11799 NULL. Handles `encoding' field.
11801 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
11803 * postscript.c: (struct font_entry) Removed `position' field.
11804 (struct ps_font_combo) New struct.
11805 (struct ps_driver_ext) Removed field `next_position'. New fields
11806 `combos', `next_combo'. `last_font' field changed from
11807 `font_entry *' to `ps_font_combo *'.
11808 (ps_init_driver) Reformatted; handles new fields. When
11809 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
11811 (get_encoding, find_encoding_file) New functions.
11812 (add_encoding) Some code moved out into find_encoding_file().
11813 (postopen) Changed value for ${title}.
11814 (preclose) Sets `loaded' field to NULL after destroying the hash
11816 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
11818 (ps_text_set_font_by_position) Figures out the current family if
11820 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
11821 (switch_font) Implemented.
11822 (write_text) Calls switch_font() more often. Format changes.
11823 #undefs its macros after they're no longer useful.
11824 (text) Changed `continue' at one point to a jump to the top of the
11825 loop because we don't want `separate' reset to 0 at that point.
11826 (load_font) No longer sets `position' in the font_entry created.
11828 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
11830 * font.h: (struct font_desc) New member `encoding', which is not
11831 properly handled yet.
11833 * glob.c: (init_glob) Some new i18n code, which is probably
11836 * output.c: (outp_read_devices, outp_get_paper_size) Changed
11837 `size' local from `int' to `size_t'.
11839 * postscript.c: New driver configuration parameter `auto-encode'.
11840 New enums OPO_AUTO_ENCODE, ODA_COUNT.
11841 (struct font_entry) New member `position'.
11842 (struct ps_driver_ext) Reordered. New hash table member
11843 `encodings'; new members `next_position', `next_encoding',
11844 `last_font'. Members `current', `prop', `fixed' changed from type
11845 `font_desc *' to `font_entry *'; all references changed.
11846 (struct ps_encoding) New struct.
11847 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
11848 free_ps_encoding, add_encoding) New functions.
11849 (ps_init_driver) Added OPO_AUTO_ENCODE to default
11850 x->output_options. Initializes new members of ps_driver_ext.
11851 Changed default value for prologue_fn, encoding_fn. Calls
11852 read_ps_encodings after loading default fonts.
11853 (option_tab[], ps_option) Handle new configuration parameter.
11854 (switch_font) New function.
11855 (struct output_char) `font' member changed from `font_desc *' to
11856 `font_entry *'. New member `separate'.
11857 (read_fontmap) Changed `size' from `int' to `size_t'.
11858 (output_line, put_number) New macros for write_text().
11859 (write_text) Optimizes text output by consolidating multiple
11860 calls to PostScript `show' operator.
11861 (text) Keeps track of when text arguments can't be consolidated by
11862 write_text(), and marks those spots in the output stream.
11863 (load_font) Sets `position' of the allocated font_entry to -1, cuz
11864 the font hasn't been switched to by switch_font(), which is where
11865 the position is important--the PostScript is what cares about the
11868 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
11870 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
11871 call a NULL free_func.
11872 (hsh_rehash) Elegantized.
11873 (hsh_probe) Fix bug that manifested when the table was expanded
11874 and thus had to change location in memory. Good thing
11875 too--otherwise could have been much more subtle.
11876 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
11877 (hsh_foreach) New function for hash table iteration.
11879 * hash.h: (struct hsh_iterator) New.
11881 * lexer.c: (parse_tagged_quote) Font and family name strings in
11882 tags are now null-terminated.
11884 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
11886 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
11887 documented. (Never before tested?)
11889 * output.h: Comment changes.
11891 * postscript.c: New driver options `optimize-text-size',
11892 `optimize-line-size', `max-fonts-simult'. New enum set for
11893 specing cached line types. Comment fixes.
11894 (struct line_form) New struct.
11895 (struct ps_driver_struct) New members `text_opt', `line_opt',
11896 `max_fonts', `lines'.
11897 (ps_init_driver) Initializes new members of ps_driver_struct.
11898 (user option type enum set) New member `nonneg_int_arg'.
11899 (static var option_tab[]) Supports new options.
11900 (ps_option) Handles new options.
11901 (find_ps_file) Made static. No longer calls hsh_dump().
11902 (ps_get_var) Made static.
11903 (preclose) Dumps out proper DSC trailer.
11904 (ps_open_page) Elegantized.
11905 (ps_close_page) Calls dump_lines() if appropriate.
11906 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
11907 wrappers around line().
11908 (int_2_compare, compare_line, dump_line, dump_fancy_line,
11909 dump_lines, hash_line, free_line, line) New functions for support
11911 (write_text, text) Made static.
11912 (text) Added to font support, not finished.
11914 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
11916 * font.h: (struct font_desc) New members ascent, descent.
11918 * groff-font.c: (groff_read_font) Calculates font ascent and
11919 descent from the ascent and descent of the `d' and `p' characters,
11920 respectively, as per a suggestion on comp.fonts.
11922 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
11923 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
11925 (write_text) Handles text right-justification and centering (not
11926 full justification). Still very inefficient. (One output line
11928 (struct output_char) Added fields for font and font size.
11929 (text) Many bugfixes.
11931 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
11933 * cmdline.c: (usage) Calls outp_list_classes().
11935 * font.h: Comment fix.
11937 * groff-font.c: New exported global var `space_index'.
11938 (groff_init) New function to initialize `space_index'.
11939 (hash_kern) Casts result to unsigned.
11940 (font_name_to_index) Renamed font_char_name_to_index. All
11941 references changed. Also, now returns the value of `space_index'
11942 when passed an ASCII space character as an argument. Fixed
11944 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
11945 Handles passed NULL pointers properly.
11947 * lexer.c: (parse_tagged_quote) Comment fix. Better range
11950 * output.c: (outp_list_drivers) Removed. Removed all references.
11952 * output.h: Comment fixes.
11954 * postscript.c: (ps_open_global) Calls groff_init().
11955 (output_char) New structure.
11956 (write_text) New function.
11957 (text) No longer stubbed out! Now the output is correct--with a
11958 few exceptions, one of them being that the page has to be held
11959 upside down into a mirror.
11961 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
11963 * font.h: Comment fix.
11965 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
11966 All callers changed.
11967 (number_to_index) Renamed font_number_to_index, made extern. All
11969 (font_get_kern_adjust, font_get_char_metrics) New functions.
11971 * output.h: New constant OUTP_T_INTERNAL_DRAW.
11973 * postscript.c: Changed default line width back to 1/2 point.
11974 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
11975 in the center of the space allotted for them, not just a fixed
11976 offset from the edge of the space; this fixes some bugs.
11977 (ps_line_intersection) Now supports all command line styles.
11978 (ps_text_get_size) Bug fix in computation of em width.
11979 (text) New function, the meat behind ps_text_metrics and
11980 ps_text_draw. Not complete.
11981 (ps_text_metrics, ps_text_draw) Removed the stub taken from
11982 ascii.c; call text().
11984 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
11986 * arena.c: (arena_free) Assert that the argument is non-NULL.
11988 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
11989 only if old_kern is non-NULL.
11991 * postscript.c: (ps_init_driver) Changed default line width to 1
11993 (postopen) New prologue variables.
11994 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
11995 more of the common line styles properly, but not all.
11996 (ps_text_metrics) Fixed problem with this stubbed out version that
11997 kept it from taking font sizes into account.
11999 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
12001 * arena.c: (arena_malloc) Bug fix.
12002 (arena_dump) [GLOBAL_DEBUGGING] New function.
12004 * ascii.c: Comment fix.
12005 (count_fancy_chars, delineate) Now static functions.
12007 * filename.c: (interp_vars) Bug fixes.
12009 * font.h: Comment fixes.
12011 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
12012 beginning in case we have an error message to display before
12013 initializing the display.
12015 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
12017 (groff_read_font) Bug fixes.
12018 (name_to_index) Increments hash.used. Sets `name' field of hash
12020 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
12022 * hash.c: Return type changed.
12024 * postscript.c: Continued development. Now marks lines on the
12025 paper, but very buggy.
12027 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
12029 * Changed comments in many source files from `/* xxx /* yyy */' to
12030 `/* xxx */ /* yyy */' for cleanliness.
12032 * arena.c: (arena_sd_strdup) New function.
12034 * ascii.c: (struct ascii_driver_ext) New member `file'.
12035 (ascii_init_driver) Fills out member `file' for initing; uses
12036 close_file_ext for closing drivers.
12037 (ascii_option) Changed %.*s back to %s because the a_string's are
12038 always null-terminated.
12039 (postopen, preclose) New functions.
12040 (ascii_open_page) Uses new style of open_file_ext.
12041 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
12042 instead of this->output.
12043 (__assert_fail) Removed.
12045 * cmdline.c: Changed syntax_message[].
12047 * error.c: #include's <readline/history.h> only if the history
12048 library is available, not if just the readline library is
12051 * filename.c: (expand_line) Removed alloca() support.
12052 (interp_vars) No longer tilde-expands argument. Limit on output
12054 (tilde_expand) Now treats argument as path rather than filename.
12055 [!unix] Now is a no-op function.
12056 (search_path) Better verbose message formatting.
12057 (open_file, close_file) Comment fixes.
12058 (close_file) [!unix] Doesn't bother with pipes.
12059 (open_file_ext) Completely rewritten, interface revamped.
12060 (close_file_ext) New function.
12062 * font.h: Comment changes.
12064 * frequencies.q: Removed AIX alloca support since it doesn't use
12067 * hash.c: Comment changes & additions.
12068 (hsh_create) Initializes entire table instead of first M entries.
12069 (hsh_probe) Stupid bug fixed. Now it works.
12070 (hsh_dump) [GLOBAL_DEBUGGING] New function.
12072 * main.c: (parse) Detects EOF properly in token-eating loop.
12073 Should the STOP token have its value changed to 0?
12075 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
12076 (blp_getline) Now it's a macro.
12078 * output.h: (struct outp_driver) Removed members output, filename.
12080 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
12081 drivers in driver table.
12082 (outp_read_devices) Frees buf. Warns if there are no active
12084 (outp_configure_clear) Sets outp_configure_vec to NULL after
12085 deleting its elements.
12086 (configure_driver, destroy_driver) Removed references to output,
12087 filename members of outp_driver.
12088 (outp_evaluate_dimension, internal_get_paper_size,
12089 outp_get_paper_size) New functions.
12091 * postscript.c: Continued development. Now links but doesn't make
12092 any marks on the page. Lotsa bugs I suppose.
12094 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
12096 * str.h: Comment changes.
12098 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
12100 * Removed dependencies on non-nested comments in several files.
12101 Also removed references to (unix || __unix__) in #if's since
12102 prefh.orig makes those two equivalent.
12104 * ascii.c: (ascii_open_global) Creates ascii_arena.
12105 (ascii_close_global) Destroys ascii_arena.
12106 (ascii_init_driver) Doesn't create ascii_arena.
12107 (ascii_copy_driver) Removed.
12108 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
12109 (outp_class ascii_class) Removed ascii_copy_driver reference.
12111 * frequencies.q: Now can display all statistics except median.
12112 Still not finished.
12114 * output.c: Handles outp_class.ref_count so output class
12115 destructors are called properly.
12116 (add_class) Sets ref_count to 0.
12117 (configure_driver) Initializes class if ref_count++ is 0.
12118 (destroy_driver) Destructs class if --ref_count is 0. Frees the
12119 class output file name.
12121 * output.h: (struct outp_class) Removed copy_driver, inited.
12124 * postscript.c: Completely replaced but not finished.
12126 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
12128 * approx.h: #includes <float.h>.
12130 * arena.h, arena.c: Many functions changed to take an arena **
12131 instead of an arena *, for consistency. All callers changed.
12132 (arena_alloc) Now creates a new arena if passed *A that is NULL.
12133 (arena_destroy) Sets *A to NULL.
12135 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
12136 assertion that `width' be positive.
12138 * command.c: Removed #if's from cmd_table.
12139 (walk_cmdtable_func) [0] New function (debug code).
12140 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
12141 (parse_cmd) Doesn't return failure for unimplemented commands.
12143 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
12144 (SYSCODE) New constant macro.
12146 * descript.q: Checks for positive n_variables before performing
12149 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
12150 avl_find instead of &fp as arg 2.
12152 * frequencies.g, frequencies.q: Continued updating; now compiles &
12153 works again, but not complete.
12155 * main.c: Changes to user messages.
12157 * misc.c: (reverse) [0] New function.
12159 * settings.h: Comment removed. #includes "common.h".
12161 * som.c: (som_set_null) New function.
12162 (som_set_value, som_set_string, som_set_text) More detailing
12164 (som_set_float) Implemented function.
12165 (dump_columnated_table) Bug fix regarding page breaks.
12166 (draw_cell) Bug fix regarding text that spilled out of a cell.
12167 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
12169 (get_cell_size) Support SCON_EMPTY cells.
12170 (get_table_size) When calculating rules' widths and heights, mask
12171 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
12173 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
12175 (struct som_submission_form) New member `header'; all users
12178 * val-labs.c: (get_label) User messages changed.
12180 * var.h: Changed FREQUENCIES structures.
12182 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
12185 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
12187 * approx.h: Definition of EPSILON now depends on system's
12188 DBL_EPSILON. Removed GNU C specific code.
12189 (cmpapx) Renamed approx_compare.
12191 * frequencies.g, frequencies.q: Continued updating; still doesn't
12194 * groff-font.c: (name_to_index) Fix bug that kept it from
12197 * hash.c, hash.h: Completed work.
12199 * var.h: Changes to freq_tab, frequencies_proc.
12201 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
12204 * hash.c, hash.h: New files. Not completed.
12205 * Makefile.am: Added hash.c to source file list.
12206 * font.h: (struct font_desc) New member kern_size_p.
12207 * groff-font.c: Uses hash.h.
12208 (hashpjw) Moved to hash.c.
12209 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
12211 (static var hash) New member size_p.
12212 * var.h: Includes hash.h.
12213 (struct freq_tab) Changed AVL_TREE to hash_tab.
12215 * vars-prs.c: Comment, formatting fixes.
12217 * frequencies.g, frequencies.q: Continued updating. Not yet
12220 * formats.c: Bug fix.
12222 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
12224 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
12225 * descript.g: Comment fixes.
12226 * descript.q: Comment fixes. Moved some declarations into var.h.
12227 Made dsc_info a static table. Updated FIXMEs.
12228 (internal_cmd_descriptives) Beautified.
12230 * frequencies.q: Started updating into working order.
12231 * frequencies.g: New file analogous to descript.g.
12232 * var.h: Comment fixes. Added structures for FREQUENCIES.
12234 * som.c: Removed vestiges of crushing and partial table support.
12236 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
12238 * Many more changes to som.c especially, but these will not be
12239 documented as I have resolved to remove them. This patchlevel is
12240 being released solely so that I can fall back to it if I decide
12241 that removing the changes is not a good idea.
12243 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
12245 * som.c: (global var som) New member `cum_y'.
12246 (build_target) Properly handles titles for partial tables.
12247 (dump_partial_beg, dump_partial_mid, dump_partial_end)
12248 Merged into single new function dump_partial(). Fixed problem
12249 with titles on partial tables.
12250 (dump_table) Calls dump_partial() for all parts of partial tables.
12251 (dump_page) Criteria for drawing title changed.
12253 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
12255 * command.c: (cmd_table) Added LIST, WEIGHT.
12257 * command.c: (cmd_remark) No longer frees `s' since it's not
12258 dynamically allocated.
12260 * data-out.c: (convert_f) Now correctly handles the case where
12261 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
12262 number of decimals.
12263 (som_destroy_all_tables) Removed argument. All callers changed.
12264 (som_vline, som_hline) Argument validity checking corrected.
12265 (som_set_value) Implemented half-heartedly.
12266 (replicate_table) Copies tables piece-by-piece when using Checker.
12268 * som.h: New line style SLIN_1THIN, currently equivalent to
12269 SLIN_0. New enum set SOM_SUB_*.
12270 (struct som_submission_form) Removed `seq_no'. Added `type'.
12272 * list.q: Newly working file; uses partial tables.
12274 * som.c: (som_reduce_table) Renamed som_set_table_height().
12275 (som_crush) Removed argument `group'.
12276 (global var som) Removed `nt', `seq_no'. Added `type'.
12277 (som_submit_table) Arguments changed.
12278 (output_table) Removed partial table code.
12279 (build_target) New arg; partial table support added. All callers
12281 (dump_plain_table) Removed partial table code.
12282 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
12283 (dump_table) Supports partial tables.
12284 (dump_page) New argument to allow not drawing top and/or bottom
12285 headers. All callers changed. Supports partial tables.
12287 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
12289 * data-out.c: Changed `#include <approx.h>' to `#include
12291 (convert_F) Comment fix. Now won't print `-.000', etc.
12293 * descript.q: Now Z-scores work, although there appears to
12294 be a bug (which might actually be in data-out.c:convert_F()).
12295 (descriptives_trns_proc, descriptives_trns_free) New functions.
12296 (run_z_pass) Implemented.
12298 * var.h: Comment fixes.
12299 (dsc_z_score, descriptives_trns) New structs.
12300 (descriptives_trns) Added to any_trns as `dsc'.
12302 * error.c, error.h: New error class, IS (Installation Script
12303 error), used in those instances where the error is in the
12304 installation, but there is a script file or installation file that
12305 can be usefully referred to.
12307 * output.c: Change many IE classes to IS classes.
12309 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
12310 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
12311 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
12312 include the corresponding header?
12314 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
12315 Don't bail out if termcap can't be read.
12317 * som.c: (som_destroy_table) Removed.
12318 (som_reduce_table, som_destroy_all_tables) New functions.
12319 (som_crush) New function, not implemented.
12321 * som.h: New table option STAB_CRUSH. Comment fix. New struct
12322 som_submission_form. Function prototypes revised.
12324 Outputting huge tables (1000s of rows) a few rows at a time
12325 is supported, though untested. May even break everything.
12326 Actually, the code doesn't even compile right now.
12327 * som.c: (struct som) New fields htv, nt, seq_no.
12328 (som_submit_table) Multiple arguments changed to a single
12329 pointer to struct submission_form. Only increments subtable_num
12330 if seq_no is zero. Only destroys table if it's not going to
12332 (replicate_table) New function.
12333 (output_table) Comment fix.
12334 (examine_table) Changed inline code to code calling
12335 replicate_table(). Calculates htv. Supports partial tables.
12336 (draw_title) Removed comment.
12337 (build_target) Only allows for title on first part of partial
12339 (dump_plain_table) Only resets table chunk number on first part
12340 of partial tables; FIXME: doesn't work quite right. Supports
12342 (dump_page) Titles only on first part of partial tables.
12344 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
12346 * Thanks to an unreliable IDE hard drive, I have spent the last
12347 day reconstructing my Debian GNU/Linux installation and redoing
12348 the previous day's changes--somehow I managed to save every file
12349 except for output.c and output.h. So the following changes could
12350 really be considered independent of the output.c, output.h changes
12353 * output.h, output.c: Moved the outp_configure_vec global var,
12354 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
12355 outp_configure_vec is now static.
12357 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
12359 * The entire philosophy behind configuration of the output drivers
12360 changed. Now there is a termcap-type configuration where drivers
12361 to be read are determined beforehand, rather than parsing the
12362 entire output init file and storing it in memory & deciding what
12363 to actually use later. Faster & more memory-efficient at the same
12366 * output.c: Comment fix. Removed outp_init_drivers global var.
12367 Removed all references to synonyms. New structure outp_defn. New
12368 global vars outp_macros, outp_configure_vec.
12369 (search_name, delete_name, add_name, check_configure_vec,
12370 expand_name, find_defn_value) New static functions.
12371 (outp_configure_clear, outp_configure_add, outp_configure_macro,
12372 outp_read_devices) New extern functions.
12373 (outp_init) Much functionality moved into outp_read_devices.
12374 (outp_read_devices) Format of output init file changed; name of
12375 file is `devices' rather than `output' to avoid Makefile
12377 (outp_clear) Renamed outp_done.
12378 (outp_list_classes) Bug fix, cleaned up.
12379 (outp_list_drivers) Not implemented anymore.
12380 (outp_configure_driver) Now a static function; simplified; now
12381 interpolates macros; supports new structure.
12382 (outp_enable_driver, match_synonym) Removed; all references
12384 (find_driver) First argument removed.
12386 * output.h: Global var outp_init_drivers removed; new structure
12387 outp_names; new enum set OUTP_S_*; new global var
12388 outp_configure_vec; function prototypes for output.c exports
12391 * main.c: (main) Calls outp_read_devices() after parsing the
12394 * cmdline.c: (parse_command_line) New option -v --verbose;
12395 --version changed to -V. --device option changed syntax to just
12396 take a single device name. Accepts key=value declaration of
12397 output init file macros. Syntax message updated.
12399 * filename.c: (expand_line) New function.
12400 (interp_environ_vars) Renamed interp_vars; no longer uses
12402 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
12403 overridden by real environment vars.
12404 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
12405 * filename.h: interp_environ_vars() renamed interp_vars().
12407 * error.c, error.h: Added extern variable `verbosity', message
12410 * error.c: (vmsg) Support message class MM.
12411 (verbose_msg) New function.
12413 * descript.q: (generate_z_varname) Bug fix in generation of
12415 (dump_z_table) Bug fix in column headers.
12417 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
12418 page from 29 to 15. Don't set a default for ops[OPS_INIT,
12419 OPS_DONE]. Writes the uninit string when the driver is closed.
12420 (ascii_open_page) Write the init string before the first page.
12421 (output_shorts) Form of main loop changed from `while' to `for'.
12422 Bug fix with overstrikes: the character is printed *after* the
12423 backspace. Eliminated a lot of `& 0xff' modifiers.
12424 (advance_to_left_margin) New function.
12425 (return_carriage, output_lines) Handle left margin.
12427 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
12429 * ascii.c: New option `carriage-return-style'.
12431 * ascii.c: (count_fancy_chars) New function.
12432 (delineate, text_metrics) Use new function; bug fixes regarding
12434 (text_draw) Bug fix with rich text.
12435 (output_string, output_shorts) Reordered.
12436 (output_shorts) Now handles boxchars and some overstrike font
12438 (output_char, return_carriage) New functions.
12439 (output_lines) Now handles overstriking and font changes properly;
12440 some code moved to output_shorts.
12442 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
12445 * ascii.c: New member `debug' in ascii_driver_ext.
12446 (ascii_init_driver, delineate) Uses new member.
12448 Now you can set a vertical height on writing text.
12449 * ascii.c: (delineate) Keeps track of vertical position.
12450 (text_draw) No longer considers fully justified text an internal
12453 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
12455 Tables' titles are drawn; they can have variable height.
12456 * som.c: `som' struct has new member, title_height.
12457 (draw_title) New argument. Moved within file. All caller
12459 (build_target) New argument, amount of space needed for first row.
12460 Calculates height of title, takes that into account. All callers
12462 (dump_plain_table, dump_columnated_table) Took calculation of y1,
12464 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
12466 (dump_columnated_table) Organized for readability.
12467 (dump_page) Makes use of som.title_height.
12469 * som.c: Many comment bug fixes.
12471 * descript.q: (try_name, generate_z_name) Bug fix regarding
12472 generation of Z-score variable names.
12473 * var.h: Removed num from descriptives_proc; all referents removed.
12475 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
12477 * ascii.c: (ascii_line_horz, ascii_line_vert,
12478 ascii_line_intersection) Added debugging code.
12480 Added a descriptive line above each table to describe it.
12481 * command.c: (parse_cmd) Calls som_new_series.
12483 * som.c: New static vars table_num, subtable_num. New `som'
12485 (dump_page) New arguments.
12486 (som_submit_table) Handle new variables.
12488 * som.c, som.h: (som_submit_table) New arguments. All callers
12490 (som_new_series) New function.
12491 (build_target) Makes room for extra line.
12492 (draw_title) New function.
12493 (dump_page) Calls draw_title. Bug fix: doesn't always set
12496 Columnation of tables support.
12497 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
12499 * som.c: Deleted references to fr, lr, ri.
12500 (som_columnate) Bux fix: sets group member of table.
12501 (som_add_options) Function removed.
12502 (dump_table) Split into three functions; extensively reworked.
12504 * descript.q: (dump_z_table) Better output table formatting; added
12505 title support to correspond to som.h changes.
12506 (display) Title support.
12508 * output.h: Added OUTP_T_NONE.
12510 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
12512 * descript.q: Improved handling of Z scores; still not perfect.
12514 * output.h, ascii.c: Added hook for getting em width of current
12517 * som.c: Uses new em-width hook. Added debugging code to
12519 (som_columnate) New argument.
12520 (som_add_options) Removed.
12522 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
12524 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
12525 rules as a property of the table instead of as a property of the
12528 * ascii.c: Added `header' to table of options.
12530 * descript.q: Added even shorter statistic names; modified to work
12531 with new som interface.
12533 * misc.c (blp_getdelim): Bug fix.
12535 * version.c: includes 'conf.h'.
12537 ----------------------------------------------------------------------
12540 version-control: never
projects / pspp-builds.git / blob