1 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
3 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
5 * expressions/helpers.c: (struct func_params) Removed.
6 (generalized_idf) Removed.
9 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
11 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
12 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
13 Implement SIG.F, which I had overlooked previously.
15 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
17 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
18 available only in testing mode.
20 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
22 * data-in.c: Use `bool' throughout, where relevant.
24 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
26 DATA LIST with free-field formats should not have implied decimal
27 places (bug #12035). Also clean up data-in.c a bit.
29 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
31 * data-in.c: (apply_implied_decimals) New function.
32 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
33 set. Also, get rid of gotos.
34 (parse_Z) Use apply_implied_decimals() if the field doesn't
35 contain a decimal point.
36 (parse_N) Use apply_implied_decimals().
42 (parse_enum) New function.
43 (macro CHAR_IS_ROMAN) Removed.
44 (macro ROMAN_VALUE) Removed.
45 (parse_month) Use parse_enum().
46 (parse_weekday) Use parse_enum().
47 (parse_DATETIME) Use long for weekday.
49 * data-list.c: (read_from_data_list_fixed) Use
52 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
54 When the lexer sees something like `-5' in the input, it has to
55 decide whether it's a negative numeric constant token or a '-'
56 token followed by a positive numeric constant token. It always
57 decides on the former, and then the parser can call
58 lex_negative_to_dash() if it wants the latter. However, this
59 doesn't work for the case of `-0', because negative zero is
60 (portably) indistinguishable from positive zero. So now we divide
61 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
62 distinction clear. This requires a little bit of extra effort,
63 because there were several references to T_NUM in the code base.
65 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
66 positive and negative numeric constants.
67 (lex_double_p) Renamed lex_is_number(). Changed return type to
68 bool. Updated all relevant references to T_NUM to instead use
70 (lex_double) Renamed lex_number(). All references updated.
71 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
72 bool. All references updated.
73 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
74 (lex_negative_to_dash) Ditto.
77 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
79 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
81 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
83 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
85 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
86 values as system-missing.
88 * expressions/parse.c: (parse_vector_element) Fix order of
89 arguments in call to expr_allocate_binary().
91 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
93 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
96 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
97 failure, as indicated by function comment.
98 (parse_binary_operators) Always return NULL on type_coercion()
99 failure. Should have been doing this anyway, but bug in
100 type_coercion_core() filtered through.
101 (parse_add) Fix typo in user message.
102 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
104 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
106 * expressions/operations.def: Add VALUE function.
108 * expressions/parse.c: (parse_function) Need an unary composite
109 node for variables in A TO B, not a variable node. Use
110 allocate_unary_variable().
111 (parse_primary) Use allocate_unary_variable().
112 (allocate_unary_variable) New function.
114 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
116 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
117 but fixed the real problem that was preventing the build from a
118 separate directory. I liked it my way better ;-)
120 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
122 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
123 John Darrington <john@darrington.wattle.id.au> for reporting this
126 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
128 * expressions/Makefile.am expressions/evaluate.h.pl
129 expressions/evaluate.inc.pl expressions/operations.h.pl
130 expressions/optimize.inc.pl expressions/parse.inc.p:
132 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
135 Fixed everything so that it can be built from an arbitrary
138 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
140 * Makefile.am : Fixed up CLEANFILES target.
142 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
144 * str.h: Changed `struct len_string' to `struct fixed_string', a
145 more accurate name. Updated all references.
147 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
149 Redo calendar support. Should now be bug-for-bug compatible.
151 * calendar.c: New file.
153 * calendar.h: New file.
155 * data-in.c: Use new calendar functions.
156 (parse_sign) Change sense of return value.
157 (calendar_error) New function.
158 (ymd_to_ofs) New function.
159 (ymd_to_date) New function.
160 (parse_DATE) Use new function.
170 (parse_DATETIME) Ditto.
172 * data-out.c: (convert_date) Use new calendar functions.
174 * error.c: (err_vmsg) Changed interface to be more sensible.
176 (dump_message) Don't double new-lines (why did we do this
179 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
181 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
182 (macro FLT64_MAX) Moved here from pref.h.orig.
184 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
186 * set.q: Support SET EPOCH.
187 (static var set_epoch) New var.
188 (aux_stc_custom_epoch) New function.
189 (stc_custom_epoch) New function.
190 (get_epoch) New function.
191 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
193 * format.c: Make it possible just to check whether a specifier is
194 valid without emitting an error message.
195 (parse_format_specifier_name) Change interface, update all
197 (check_input_specifier) Ditto.
198 (check_output_specifier) Ditto.
199 (parse_format_specifier) Ditto.
201 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
203 * command.def: Add DEBUG POOL.
205 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
207 (pool_clear) Properly account for size of pool gizmo.
208 (pool_realloc) Ditto.
209 (pool_clone) New function.
211 * pool.h: Mark our allocation functions MALLOC_LIKE.
213 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
215 * Makefile.am: Move many definitions into new top-level
216 Make.build. Add expressions to SUBDIRS. Add calendar.c,
217 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
220 * case.c: (case_resize) New function.
221 (case_swap) New function.
223 * casefile.c: Include mkfile.h.
225 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
227 * sfm-read.c: Fixed a buglet which caused a crash when trying
228 to read a non-existent file.
230 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
234 * aggregate.c: (parse_aggregate_functions) Code cleanup.
235 Important part: get rid of spurious copying of function->format to
236 destvar->print and destvar->write.
238 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
240 Fix Bug #11916, which was confusing a variable's `index' member
241 with the variable's position in a var_set. Although these are
242 usually the same, they are not for array `var_set's.
244 Took advantage of this bug as an opportunity to clean up and
245 rewrite parse_var_set_vars().
247 * vars-prs.c: (parse_vs_variable_idx) New function.
248 (parse_vs_variable) Reimplement in terms of
249 parse_vs_variable_idx().
250 (parse_var_idx_class) New function.
251 (add_variable) New function.
252 (add_variables) New function.
253 (parse_var_set_vars) Rewritten.
254 (struct var_set) Change `lookup_var' member that returns a
255 variable into `lookup_var_idx' member that returns an int.
256 Updated the var set implementations in obvious corresponding ways.
257 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
259 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
261 Use our global variable compare & hash functions and give them
262 better names. Add similar functions for dealing with double
263 pointers to variables.
265 * vars-atr.c: (compare_variables) Renamed compare_var_names().
266 (hash_variable) Renamed hash_var_name().
267 (compare_var_ptr_names) New function.
268 (hash_var_ptr_name) New function.
270 * t-test.q: (cmd_t_test) Use global compare_var_names(),
272 (compare_var_name) Removed.
273 (hash_var_name) Removed.
275 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
279 * dictionary.c: (compare_variable_dblptrs) Rename
280 compare_var_ptrs() and fix it to properly dereference the double
283 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
285 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
286 declare subcommands as mandatory. Closed bug #11843
288 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
290 * getline.c command.[ch] command.def: Added (very rudimentary)
291 support for line completion when in interactive mode. Partially
294 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
296 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
297 problems revealed by valgrind.
300 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
302 * set.q: Affixed a fix to the previous fix such that we'll be OK now
303 whether or not PAGER is set.
305 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
307 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
308 "invalid free" errors. Hopefully fixes bug #11722
310 * compute.c expr-prs.c: Check that lvalues are populated before
311 attempting to destroy them. Closes bug #11676
313 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
315 * aggregate.c: Initialised the complete agr_proc structure.
319 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
321 * print.c: (print_trns_free) Close the dfm writer if there is one,
322 fixing a memory leak.
324 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
326 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
330 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
332 * linked-list.[ch] Added
334 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
335 set.q: Yet more memory leaks
337 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
339 * t-test.q examine.q : More memory leaks fixed.
341 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
343 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
346 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
348 * ascii.c cartesian.c casefile.c chart.h devind.c
349 examine.q frequencies.q
350 html.c output.h piechart.c plot-chart.c plot-hist.c
352 Integrated the chart rendering into the output stream
353 (currently only works for html).
355 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
356 dummy-chart.c for compiling without charts.
358 * mkfile.[ch] Created.
360 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
361 Added type element so we can tell if it's a chart or a table.
363 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
364 API of charts to be more like that of tables.
366 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
368 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
369 main.c. Removed the handler for SIGQUIT.
371 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
373 * casefile.c: Added a signal handler to delete temp files on
376 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
378 * command.def Added a lot more unimplemented commands.
380 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
382 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
384 * sort.c: (compare_initial_runs) Needed additional level of
386 (merge_once) Fix plenty of stupid mistakes.
388 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
390 * casefile.c: (casefile_sleep) Need to flush_buffer() after
391 calling casefile_to_disk() or we will lose the last block in the
392 file if the casefile started out as disk-based.
393 (casefile_get_reader) Initialize reader->destructive to 0.
394 (cmd_debug_casefile) Add new test pattern.
395 (test_casefile) Define new test pattern to make sure
396 casefile_sleep() works properly.
398 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
400 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
401 plot-hist.c plot-chart.c (Added) Reorganised these files in an
402 attempt to seperate the creation and processing of charts from their
405 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
408 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
410 * main.c Added a signal handler for SIGFPE
412 * sort.c Somewhat more robust fix to the previous entry.
414 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
416 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
417 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
418 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
421 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
423 * case.h Fixed bug # 11307
425 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
427 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
430 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
432 * pfm-read.c: (read_variables) Remove direct manipulation of
433 v->aux, which is no longer needed. Fixes Bug #11483.
435 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
437 * data-list.c Fixed a bug in parsing delimiters.
439 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
442 * percentiles.c Properly handled calculation of Tukey hinges where
443 the number of data is small.
445 * oneway.q Used the generic value_to_string function for independent
446 variable instead of trying to do it ourselves.
448 * box-whisker.c Fixed a buglet which caused a crash if the number of
452 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
454 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
456 * percentiles.c Fixed some bugs when calculating percentiles when
457 there's a small number of cases.
459 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
461 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
463 * examine.q factor_stats.[ch] Added calculation of percentiles
465 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
467 * t-test.q Fixed bug #11227 Made t-test work when the independent
470 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
472 * factor_stats.c Fixed calculation of trimmed mean under various
475 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
477 * histogram.c chart.[ch] factor_stats.c frequencies.q
479 Added code to calculate sensible histogram ranges and limits.
481 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
483 * chart.h Updated to reflect many API changes.
485 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
486 cartesian.c and into chart.c
488 * factorstats.[ch] Added the histogram calculations
490 * casefile.c Removed an unused variable.
492 * frequencies.q examine.q histogram.c Reworked the API for
495 * piechart.c Revised the API for piecharts.
497 * var.h Moved the definitions of freq_tab and freq out of var.h
498 and into frequencies.q where they belong.
500 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
502 * flip.c: (flip_file) Check for off_t separately from fseeko(),
505 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
507 * flip.c: (flip_file) If fseeko() is not available, use long int
508 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
509 reporting the problem.
511 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
513 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
516 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
518 * var-labs.c (var_to_string) Now returns null if the variable is null
520 * value-labels.c (value_to_string) Made it return null if either the
521 value or the variable is null.
523 * hash.c (hsh_clear) Fixed a buglet.
525 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
526 with the wrong model.
528 * casefile.[ch] Added a function to return the casereader.case_idx
531 * examine.q Implemented the extreme values results.
533 John Darrington <john@darrington.wattle.id.au>
535 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
536 output.[ch] getline.c
538 Plugged some memory leaks
540 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
542 Adopt GSL random number generators, paving the way for providing
543 the complete suite of random number generators on expressions.
545 * Makefile.am: Remove random.c, random.h.
551 * algorithm.c: (algo_default_random) Use GSL functions.
553 * casefile.c: (test_casefile) Use GSL RNG functions.
555 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
558 * sample.c: (cmd_sample) Use GSL RNG functions.
559 (sample_trns_proc) Ditto.
561 * set.q: (static var set_seed) Removed.
562 (static var seed_flag) Removed.
563 (static var rng) New variable.
564 (aux_stc_custom_seed) No seed value anymore, don't print anything.
565 (stc_custom_seed) Use new seed functions.
566 (seed_is_set) Removed.
567 (get_rng) New function that composes the entire external
569 (set_rng) New function.
570 (random_seed) New function.
572 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
574 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
575 John Darrington <john@darrington.wattle.id.au> for reporting this
578 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
580 * permissions.c command.def Added the PERMISSIONS command
582 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
584 * q2c.c: (dump_header) Don't try to emit #includes at very top of
585 output file because that will precede #include <config.h>, which
587 (main) Add needed headers to /* (header) */ code.
589 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
591 Instead of making system or portable file readers responsible for
592 dropping and reordering variables, make them read full cases and
593 let the caller take care of any changes.
595 * get.c: New "case map" structure to handle this. Use for GET,
596 IMPORT, MATCH FILES. Essentially rewrite the whole file.
598 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
599 changed appropriately.
601 * sfm-read.c: (sfm_read_case) Ditto.
603 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
605 Decided that case_serialize() and case_unserialize() were too
606 abstract. Also we need a couple more functions to avoid excessive
607 copying for data in/out fast paths.
609 * case.c: (case_serial_size) Removed.
610 (case_serialize) Rename case_to_values() and make its argument
611 explicitly an array of union values.
612 (case_unserialize) Rename case_from_values() and make its argument
613 explicitly an array of union values.
614 (case_data_all) New function.
615 (case_data_all_rw) New function.
617 * casefile.c: (struct casefile) Change buffer from array of
618 unsigned char to array of union value for better accuracy.
619 Redefine buffer_used and buffer_size in terms of values, not
620 bytes. Remove case_size because it is now redundant with
621 value_cnt. Fix up all references to these members.
623 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
625 * barchart.c: (struct subcat) Make `label' member const to silence
626 GCC warning with -Wwrite-strings.
628 * cartesian.c: (struct dataset) Ditto.
630 * case.c: Don't re-define NDEBUG if already defined.
631 Add lots of comments.
633 * str.c: Fix includes.
635 * crosstabs.q: Fix includes.
637 * examine.q: Fix includes. Fix GCC warning about unused
640 * frequencies.q: (stat macro) Removed and replaced where used by
643 * list.q: Fix includes.
645 * oneway.q: Fix includes.
647 * piechart.c: Fix includes. Only define M_PI if not already
650 * sfm-read.c: (bswap) New function.
651 (bswap_int32) Write in terms of bswap.
654 * str.c: (ds_data) Add external definition here, needed because
655 str.h has only an `extern inline' version.
657 * value-labels.c: Fix includes.
659 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
661 Instead of providing a system or portable file writer with a raw
662 case in the format needed for output, provide it with a regular
663 case. The writer takes care of any needed translation.
665 * aggregate.c: Adopt new scheme for AGGREGATE.
666 (struct agr_proc) sfm_agr_case member removed.
667 (write_case_to_sfm) Removed because the new interface is easier to
670 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
672 * pfm-write.c: Implement new scheme.
674 * sfm-write.c: Ditto.
676 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
678 Instead of treating `struct file_handle' as a class to subclass
679 into data files, system files, and portable files, instead use it
680 as a helper that coordinates access. Now it is opaque, too.
682 This means that most references to a struct file_handle are now
683 changed into references to one of struct dfm_reader, struct
684 dfm_writer, struct sfm_reader, struct sfm_writer, struct
685 pfm_reader, or struct pfm_writer, according to what's being read
688 Most related changes are only worth summarizing briefly.
690 * dictionary.c: (dict_clear) Destroy aux data in deleted
692 (dict_clear_aux) New function.
693 (dict_create_var) Initialize aux, aux_dtor.
694 (dict_delete_var) Destroy aux data in deleted variable.
696 * file-handle.h: (struct fh_ext_class) Removed.
697 (struct file_handle) Removed.
698 (fh_init_files) Removed.
700 * file-handle.q: Changed references to a handle's `private' member
701 to direct references.
702 (struct private_file_handle) Renamed file_handle.
703 Add next, open_cnt, type, open_mode, aux members.
704 (struct file_handle_list) Removed.
705 (extern var inline_file) Removed.
706 (static var file_handles) Changed from file_handle_list * to
708 (create_file_handle) Initialize new members.
709 (fh_close_handle) Removed.
710 (mode_name) New function.
711 (fh_open) New function.
712 (fh_close) New function.
713 (fh_parse_file_handle) Renamed fh_parse().
715 * glob.c: (init_glob) Remove fh_init_files() call.
717 * aggregate.c: use sfm_writer.
718 (create_sysfile) Removed because the new interface is simpler.
720 * apply-dict.c: Use sfm_reader.
722 * data-list.c: Use dfm_reader.
724 * file-type.c: Use dfm_reader.
726 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
728 * inpt-pgm.c: Use dfm_reader.
730 * print.c: Use dfm_writer.
732 * sysfile-info: Use sfm_reader.
734 * dfm-read.c: Adopt new file handle infrastructure.
736 * dfm-write.c: Ditto.
740 * pfm-write.c: Ditto.
744 * sfm-write.c: Ditto.
746 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
748 Break dictionary functions into separate header file.
750 * dictionary.h: New file.
752 * var.h: Moved dict_*() functions to dictionary.h.
754 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
756 Get rid of procedure-specific union in struct variable, using
757 instead a void * pointer and a destructor function.
759 Most related changes are only worth brief summaries.
761 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
762 old p.crs member in struct variable.
764 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
765 of old p.frq member in struct variable.
767 * histogram.c: (draw_histogram) Takes new freq_tab arg because
768 it's no longer possible to grab this from var->p.frq.
770 * piechart.c: (draw_piechart) Ditto.
772 * group.c: (group_proc_get) New function.
774 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
781 * main.c: (execute_command) Clear aux data in default_dict after
782 each command. (It's debatable whether this should be done.)
784 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
785 member in struct variable.
787 * means.q: Get rid of integer mode, which is not included in
788 recent SPSS and was the only code that wanted per-variable private
791 * var.h: (struct crosstab_proc) Removed.
792 (struct frequencies_proc) Removed.
793 (struct list_proc) Removed.
794 (struct get_proc) Removed.
795 (struct means_proc) Removed.
796 (struct matrix_data_proc) Removed.
797 (struct match_files_proc) Removed.
798 (lots of enums) Removed.
799 (struct variable) Removed members `p', `get'. Add member
802 * vars-atr.c: (var_attach_aux) New function.
803 (var_detach_aux) New function.
804 (var_clear_aux) New function.
805 (var_dtor_free) New function.
806 (discard_variables) Use NULL instead of inline_file.
808 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
810 * value-labs.c Fixed the implmentation of value_to_string, so
811 that it properly handles alpha values.
813 * oneway.q Changed instances where labels were being probed manually,
814 to use the canonical {var,value}_to_string functions
816 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
818 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
819 plots. Changed the API of the cartesian plot to be a much lower level
822 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
824 * examine.q Added some of the parametric calculations
826 * factor_stats.[ch] Created
828 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
830 * examine.q Changed the definition of factors to be a composite, and
831 dealt with the consequences.
833 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
835 * examine.q Fixed problem where examine wasn't dealing properly with
838 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
840 * oneway.q Fixed problem where oneway wasn't dealing properly with
843 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
845 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
846 command which had settings didn't get the appropriate code
849 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
850 to convert variables/values to strings.
852 * examine.q Added framework for the EXAMINE command.
854 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
856 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
857 subcommand types. Changed frequencies.q to use it rather then the
858 custom parser. Dealt with the consequences. Added a test for NTILES
859 subcommand of frequencies.
861 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
863 * oneway.q Fixed up the behaviour when given missing values
865 * levene.c oneway.q Fixed a buglet with the levene statistic and
866 incorporated the levene test into the oneway command.
868 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
869 global scope, since they're only relevant to T-TEST
871 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
873 * group.c group.h group_proc.h levene.c oneway.q t-test.q
875 Made the t-test more consistent
876 with the way it handles groups. That is, it now uses a hash instead
877 of an array of 2. Also, made the levene.c file independent of the
878 implementation of the t-test. So now levene should be fine for both
881 * Added an oneway.q file for one way anova
883 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
885 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
888 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
892 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
893 (data_list_trns_free) Free dls->delims.
895 * t-test.q: (tts_custom_pairs) Free vars.
896 (ssbox_one_sample_init) Fix tab_vline() argument.
897 (ssbox_independent_samples_init) Ditto.
898 (trbox_paired_init) Ditto.
899 (trbox_one_sample_init) Ditto.
901 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
903 Generalize casefiles to the extent that we can use them for
904 sorting and other kinds of data transformations. Change cases to
905 be copy-on-write to improve memory efficiency in common cases.
906 Every access to a member of a `struct ccase' was changed to be a
907 call to a case_*() function, especially case_data(), case_num(),
908 case_str(), or case_data_rw(). Many instances of a local variable
909 named "case_num" were changed to "case_idx" as a consequence.
910 Many `struct ccase *' were changed to actual `struct ccase'
911 because of copying semantics of cases. In several places there
912 was a choice between updating debug code to work with the new ADTs
913 or just deleting it because it was useless; I chose to delete it.
915 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
921 * aggregate.c: (struct agr_proc) Change type of `sort' to
922 sort_criteria *. Add `break_vars', `break_var_cnt' members.
923 Rename `vars' to `agr_vars', all references updated. Change
924 `agr_case' to type `struct ccase'.
925 (cmd_aggregate) Deal with new members. Use case_create(),
926 sort_active_file_in_place(), sort_active_file_to_casefile().
927 (agr_destroy) Deal with new members.
928 (aggregate_single_case) Ditto.
929 (dump_aggregate_info) Ditto.
930 (initialize_aggregate_info) Ditto.
931 (agr_to_active_file) Ditto.
932 (presorted_agr_to_sysfile) Ditto.
933 (sort_agr_to_sysfile) Removed.
935 * alloc.c: (out_of_memory) Make non-static.
937 * alloc.h: Prototype out_of_memory().
939 * casefile.c: Switched from a linked list in-memory representation
940 to a two-level array-style representation. The linked list was
941 appropriate when we could stick a header onto cases, but that's no
942 longer the case. Also, the two-level array will allow for random
943 in-memory access in case that's ever wanted. Also added the
944 concept of a `destructive casereader', one that destroys cases in
945 the underlying casefile as they are read out.
946 (macro CASES_PER_BLOCK) New macro.
947 (struct casefile) New members `value_cnt', `case_list_size',
948 `case_acct_size', `being_destroyed', `cases'. Removed `head',
950 (struct casereader) Removed `cur'. Added `destructive', `c'.
951 (global var casefiles) Made static.
952 (static var case_bytes) New var.
953 (casefile_create) Takes a value count, not a case size in bytes,
954 to conform to the case interface. All callers updated. Deal with
955 new and removed members.
956 (casefile_destroy) Deal with new and removed members.
957 (casefile_sleep) New function.
958 (casefile_get_case_size) Removed.
959 (casefile_get_value_cnt) New function.
960 (casefile_append) Rewritten to deal with new and removed members.
961 (casefile_append_xfer) New function.
962 (write_case_to_disk) Use case_serialize().
963 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
964 Couldn't figure out why.
965 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
966 deal with new and removed members.
968 (merge_sort) Removed.
969 (casefile_sort) Removed.
970 (casefile_get_reader) Deal with new and removed members.
971 (casefile_get_destructive_reader) New function.
972 (reader_open_file) Make code more readable. Create case for
974 (casereader_get_casefile) New function.
975 (casereader_read) Deal with new and removed members. Now returns
976 a copy of the case, so that the caller is responsible for
977 destroying the returned case.
978 (casereader_read_xfer) New function.
979 (casereader_destroy) Destroy reader's case.
980 (test_casefile) Second arg is now a value count, all callers
981 updated. Now tests destructive readers too.
982 (get_random_case) Deal with new case ADT.
983 (write_random_case) Ditto.
984 (read_and_verify_random_case) Ditto.
986 * crosstabs.q: Remove debug code.
988 * descript.q: (calc_descriptives) Deal with new case, casefile
991 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
993 * do-if.c: Remove unneeded header inclusion.
995 * expr-prs.c: Remove debug code.
997 * exprP.h: Remove debug code.
999 * flip.c: (flip_file) Use fseeko() if available.
1001 * formats.c: Remove debug code.
1003 * get.c: Remove debug code.
1004 (struct mtf_file) Change `input' from `union value *' to `struct
1005 ccase', all references updated.
1007 * levene.c: (levene) Deal with new case, casefile ADTs.
1009 * list.q: Remove debug code.
1011 * loop.c: Remove debug code.
1013 * matrix-data.c: Remove debug code.
1015 * means.q: Remove debug code.
1017 * mis-val.c: Remove debug code.
1019 * pfm-read.c: Remove debug code.
1020 (pfm_read_code) Change second arg from `union value *' to `struct
1021 ccase *', all references updated.
1023 * recode.c: (string_to_long) Make first arg const.
1024 (convert_to_double) Ditto.
1026 * repeat.c: Remove debug code.
1028 * sample.c: Remove debug code.
1030 * sfm-read.c: Remove debug code.
1031 (sfm_read_case) Change second arg from `union value *' to `struct
1034 * sort.c: Redone in terms of casefiles.
1035 (enum sort_direction) Moved here from sort.h.
1036 (struct sort_criterion) New structure.
1037 (struct sort_criteria) New structure.
1038 (cmd_sort_cases) Rewritten.
1039 (prepare_to_sort_active_file) New function.
1040 (sort_active_file_in_place) New function.
1041 (sort_active_file_to_casefile) New function.
1042 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
1043 changed, all callers updated.
1044 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
1045 rewritten & interface changed, all callers updated.
1046 (sort_cases) Renamed sort_execute(), rewritten & interface
1047 changed, all callers updated.
1048 (struct internal_sort) Removed.
1049 (do_internal_sort) Rewritten, interface changed.
1050 (destroy_internal_sort) Removed.
1051 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
1052 (struct initial_run) Removed; an initial run is now just a
1054 (compare_initial_runs) Rewritten.
1055 (struct external_sort) Changed almost completely.
1056 (do_external_sort) Rewritten, interface changed.
1057 (destroy_external_sort) Rewritten.
1058 [HAVE_MKDTEMP] (make_temp_dir) Removed.
1059 [!HAVE_MKDTEMP] (do_mkdir) Removed.
1060 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
1061 (init_external_sort) Removed.
1062 (simulate_error) Removed.
1063 (rmdir_temp_dir) Removed.
1064 (get_temp_file_name) Removed.
1065 (open_temp_file) Removed.
1066 (close_temp_file) Removed.
1067 (remove_temp_file) Removed.
1068 (write_temp_file) Removed.
1069 (read_temp_file) Removed.
1070 (struct record_run) Change `record' from `struct case_lit *' to
1072 (struct initial_run_state) Remove `idx_to_fv', `free_list',
1073 `file_idx', `output_file'. Add `run', casefile'. Change
1074 `last_output' from `struct case_list *' to `struct ccase'.
1075 (write_initial_runs) Change interface, rewrite.
1076 (sort_sink_write) Renamed process_case(), changed interfaced,
1078 (destroy_initial_run_state) Rewritten.
1079 (allocate_cases) Rewritten.
1080 (compare_record) Interface changed, rewritten.
1081 (start_run) Rewritten.
1082 (end_run) Rewritten.
1083 (output_record) Rewritten.
1084 (grab_case) Removed.
1085 (release_case) Removed.
1086 (struct merge_case) Change `cases' from double pointer to single
1088 (merge) Deal with new case and casefile ADTs.
1089 (struct run) Removed.
1090 (merge_once) Rewritten, interface changed.
1091 (fill_run_buffer) Removed.
1092 (sort_sink_make_source) Removed.
1093 (sort_sink_class) Removed.
1094 (struct sort_source_aux) Removed.
1095 (sort_source_read_helper) Removed.
1096 (sort_source_read) Removed.
1097 (read_sort_output) Removed.
1098 (read_internal_sort_output) Removed.
1099 (read_external_sort_output) Removed.
1100 (sort_source_destroy) Removed.
1101 (sort_source_class) Removed.
1103 * sort.h: (struct sort_cases_pgm) Removed.
1104 (enum sort_direction) Moved to sort.c.
1106 * t-test.q: (calculate) Deal with new case, casefile ADTs.
1108 * tab.c: Remove debug code.
1110 * var-labs.c: Remove debug code.
1112 * var.h: (struct ccase) Removed.
1113 (struct case_list) Removed.
1115 * vars-atr.c: (discard_variables) Use free_case_source().
1117 * vars-prs.c: (parse_vs_variable) Make arg const.
1118 (parse_dict_variable) Ditto.
1119 (parse_variables) Make struct dictionary * arg const.
1120 (parse_var_set_vars) Make struct var_set * arg const.
1121 (struct var_set) Add const to some of the function pointers' args.
1122 (var_set_get_cnt) Make arg const.
1123 (var_set_get_var) Make first arg const.
1124 (var_set_lookup_var) Make first arg const.
1125 (dict_var_set_get_cnt) Make arg const.
1126 (dict_var_set_get_var) Make first arg const.
1127 (dict_var_set_lookup_var) Make first arg const.
1128 (var_set_create_from_dict) Make arg const. Add cast to aux
1130 (struct array_var_set) Add const to var member.
1131 (array_var_set_get_cnt) Make arg const.
1132 (array_var_set_get_var) Make first arg const.
1133 (array_var_set_lookup_var) Make first arg const.
1134 (var_set_create_from_array) Make first arg const. Insert cast.
1136 * vfm.c: (struct write_case_data) Change trns_case, sink_case
1137 members from `struct ccase *' to `struct ccase'.
1138 (static var lag_queue) Change from double to single pointer.
1139 (procedure) Optimize trivial case.
1140 (internal_procedure) Deal with changed case, case_source ADTs.
1141 (create_trns_case) Changed interface, rewrote.
1142 (open_active_interface) Initialize modified lag queue.
1143 (write_case) Deal with changed case ADT.
1144 (lag_case) Deal with modified lag queue.
1145 (close_active_file) Destroy modified lag queue.
1146 Deal with changed case_source, case_sink ADTs.
1147 (destroy_storage_stream_info) Make null arg into no-op.
1148 (storage_sink_make_source) Set aux in created source.
1149 (storage_source_read) Deal with changed case, casefile ADTs.
1150 (storage_source_create) New function.
1151 (lagged_case) Rewrite.
1152 (free_case_source) New function.
1153 (free_case_sink) Rewrite.
1154 (struct split_aux_data) Changed prev_case from `struct ccase *' to
1156 (procedure_with_splits) Deal with changed prev_case.
1157 (procedure_with_splits_callback) Ditto.
1158 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
1160 (multipass_procedure_with_splits) Deal with changed prev_case.
1161 (multipass_split_callback) Ditto.
1164 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
1166 The workspace idea didn't work out.
1168 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
1170 * workspace.c: Removed.
1172 * workspace.h: Removed.
1174 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
1176 Fully implement arbitrary delimiters on DATA LIST, extending the
1177 half implementation that was already there.
1179 * data-list.c: (struct data_list_pgm) Remove `delim', add
1180 `delims', `delim_cnt'.
1181 (cmd_data_list) Initialize new members. Parse delimiters and
1182 clean up code a bit.
1183 (cut_field) Extract fields with arbitrary delimiters. Also, fix
1184 handling of leading commas.
1185 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
1187 (read_from_data_list_free) Adapt to new DFM interfaces.
1188 (read_from_data_list_list) Ditto.
1189 (repeating_data_trns_proc) Ditto.
1191 * dfm.c: Split up reader and writer into separate code, because
1192 they do different things. Use struct string instead of explicit
1193 allocation code, for clarity.
1194 (enum dfm_reader_flags) New enum.
1195 (struct dfm_fhuser_ext) Removed.
1196 (struct dfm_reader_ext) New.
1197 (get_reader) New function, used by just about all the reader
1199 (dfm_close) Removed.
1200 (close_reader) New function.
1201 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
1202 (dfm_open_for_writing) Ditto.
1203 (macro force_line_buffer_expansion) Removed.
1204 (count_tabs) Removed.
1205 (tabs_to_spaces) Removed.
1206 (read_record) Deal with new dfm_reader_ext. Use struct string
1207 functions. Don't convert tabs to spaces.
1208 (dfm_eof) New function.
1209 (dfm_get_record) Changed interface, rewrote.
1210 (dfm_expand_tabs) New function.
1211 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
1212 dfm_reader_ext, rewritten.
1213 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
1214 dfm_reader_ext, rewritten.
1215 (dfm_set_record) Removed in favor of dfm_forward_columns().
1216 (dfm_forward_columns) New function.
1217 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
1218 dfm_reader_ext, rewritten.
1219 (static var dfm_r_class) Use close_reader for the destructor.
1220 (struct dfm_writer_ext) New.
1221 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
1222 bounce buffer now instead of local allocation.
1223 (close_writer) New function.
1224 (static var dfm_writer_ext) Use close_writer for destructor.
1225 (cmd_begin_data) Adapt to new dfm_reader_ext.
1227 * file-handle.q: Add support for per-file tab width.
1228 (struct private_file_handle) Add tab_width member.
1229 (q2c specifications) Add tabwidth subcommand.
1230 (cmd_file_handle) Put parsed tab width into private_file_handle.
1231 (create_file_handle) Set default tab width.
1232 (handle_get_tab_width) New function.
1234 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
1236 * inpt-pgm.c: (reread_trns_proc) Ditto.
1238 * matrix-data.c: (context) Ditto.
1239 (another_token) Ditto.
1243 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
1245 * casefile.c: (casefile_destroy) Fix memory leak by freeing
1247 (casereader_destroy) Don't close file descriptor -1.
1249 * recode.c: (cmd_recode) Fix memory leak.
1251 * set.q: (q2c specifications) Fix typo in user message.
1253 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
1254 undefined behavior for overlapping arguments.
1256 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
1258 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
1259 don't call it when we're running under valgrind.
1260 (call_posix_fadvise) New function.
1261 (casefile_to_disk) Use call_posix_fadvise().
1262 (reader_open_file) Ditto.
1264 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
1266 Update our string ADTs, struct string and struct len_string. Get
1267 rid of pool support, which was largely unused. Rename lots of
1268 functions to have more obvious or consistent names.
1270 * ascii.c: Get rid of ascii_pool. It was only used for string
1272 (ascii_open_global) Don't create ascii_pool.
1273 (ascii_close_driver) Don't destroy ascii_pool.
1274 (ascii_postopen_driver) Don't use pool.
1275 (ascii_close_driver) Destroy strings manually.
1277 * str.c: (ds_create) Remove pool argument, all references updated.
1279 (ds_replace) Remove pool support, make more efficient when we
1280 don't need to reallocate.
1281 (ds_destroy) Remove pool support.
1282 (ds_rpad) New function.
1283 (ds_size) Renamed ds_capacity(), all references updated.
1284 (ds_value) Renamed ds_c_str(), all references updated.
1285 (ds_concat) Renamed ds_puts(), all references updated.
1286 (ds_concat_buffer) Renamed ds_concat(), all references updated.
1287 (ds_putchar) Renamed ds_putc(), all references updated.
1288 (ds_getline) Renamed ds_gets(), all references updated.
1289 (ls_create) Remove pool argument, all references updated.
1290 (ls_create_buffer) Ditto.
1291 (ls_destroy) Removed pool support.
1292 (ls_value) Renamed ls_c_str(), all references updated.
1294 * str.h: (ls_length) [__GNUC__] Add inline version.
1295 (ls_c_str) [__GNUC__] Add inline version.
1296 (ls_end) [__GNUC__] Add inline version.
1297 (struct string) Remove pool member. Rename `size' to `capacity',
1298 all references updated.
1300 * tab.c: (text_format) Instead of using pool argument to
1301 ls_create_buffer(), call pool_register() on allocated data.
1303 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
1305 We're abusing the current ASCII driver by telling it to allocate a
1306 9999-line, 9999-character page in the tests. This causes some
1307 systems to curl up and die because it allocates 20 MB of
1308 contiguous RAM. This change alleviates at least part of the
1309 problem. It is mostly a stop-gap until the new output system is
1312 * ascii.c: (struct line) New structure.
1313 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
1314 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
1315 (ascii_preopen_driver) Initialize new members, not old ones.
1316 (ascii_close_driver) Destroy new members, not old ones.
1317 (ascii_open_page) Allocate new members, not old ones.
1318 (expand_line) Allocate room in line.
1319 (draw_line) Use new members.
1320 (ascii_line_horz) Ditto.
1321 (ascii_line_vert) Ditto.
1322 (ascii_line_intersection) Ditto.
1324 (output_lines) Ditto.
1325 (ascii_close_page) Ditto.
1327 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
1329 * matrix.c: Dead code. Removed.
1331 * matrix.h: Dead code. Removed.
1333 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
1335 Contrary to what I'd always understood, there is an efficient
1336 algorithm for deletion from a hash table populated via linear
1337 probing. This change implements it.
1339 * hash.c: (hsh_rehash) Probe in increasing order.
1341 (locate_matching_entry) Ditto.
1342 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
1344 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
1346 * moments.c (calc_moments): Adjust calculation of kurtosis to
1347 avoid subtracting huge numbers from huge numbers, on Michael
1350 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
1352 Rework moments routines for improved numerical stability based on
1353 Michael Kiefte's advice. Any bugs or remaining numerical problems
1354 are still mine though.
1356 There is now a struct moments1 for use with one-pass moments. It
1357 uses a provisional means algorithm as an attempt to improve
1358 accuracy of higher moments. The older struct moments now only
1359 handles two-pass moments.
1361 * aggregate.c: Use moments1 instead moments.
1363 * descript.c: Revert previous change, which is no longer needed
1364 due to the moments revision.
1366 * moments.c: (calc_moments) New function for calculating variance,
1368 (moments_pass_one) Only accumulate weights bigger than zero.
1369 (moments_calculate) Allow calculating the mean on pass one, others
1370 require pass two. Implement in terms of calc_moments().
1371 (struct moments1) New structure.
1372 (init_moments1) New function.
1373 (moments1_clear) Ditto.
1374 (moments1_create) Ditto.
1375 (moments1_add) Ditto.
1376 (moments1_calculate) Ditto.
1377 (moments1_destroy) Ditto.
1378 (cmd_debug_moments) Deal with `struct moments' or `struct
1379 moments1' as requested by user.
1381 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
1383 * Makefile.am (pspp_SOURCES): Remove debug.c.
1385 * debug.c: Removed. It was empty anyway.
1387 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
1389 * descript.c (calc_descriptives): Fix assert failure when only
1390 MOMENT_MEAN is needed.
1392 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
1396 fixed problem with parsing in match_statistic() causing
1397 "DESCRIPTIVE STAT=MEAN." to barf.
1399 "MEAN" is now default if "SORT" given without specification.
1401 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
1402 generally less forgiving of syntax errors: better to have it do
1403 nothing and type it in again then to not know what it actually did
1406 z-score transformation now checks score for user-missing values
1407 and checks std_dev for SYSMIS.
1409 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
1411 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
1412 Changed dict_get_case_weight() to accept an additional int * flag
1413 to complain about system-missing, user-missing, zero, or negative
1414 weights and updated existing functions to pass int * to
1415 dict_get_case_weight().
1417 2004-04-05 jmd <jmd@gnu.org>
1419 * main.c: Fixed configuration problems with gsl
1421 * t-test.q: Fixed some problems encountered when compiling under Cygwin
1423 2004-04-03 blp <blp@gnu.org>
1425 * lexer.c, ChangeLog:
1426 Fix infinite loop on comment at end of file, add test.
1428 2004-04-03 jmd <jmd@gnu.org>
1430 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
1431 Fixed the calculation of percentiles and added --syntax and --algorithm options
1433 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
1435 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
1438 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1440 * frequencies.q: Fixed the calculation of percentiles
1442 * Makefile.am: Added the --ansi flag and dealt with the
1443 consequences. Added some entries to PSPP_sources so that
1444 make distcheck would pass
1446 * cmdline.c: Added the --syntax and --algorithm options
1448 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
1450 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
1452 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
1453 use the new multipass_split_... mechanism.
1455 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
1457 * frequencies.q: (calc_stats) Use moments data structure and
1458 calc_seskew(), calc_sekurt() functions.
1460 * set.q main.c settings.h Added support for --syntax and --algorithm
1463 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
1465 * vfm.c: Had to get last call to multipass_split_output() inside
1466 open_active_file()/close_active_file() pairing, so introduce new
1468 (internal_procedure) Move procedure() code here, except for calls
1469 to open_active_file() and close_active_file().
1470 (procedure) Wrap open_active_file() and close_active_file() around
1471 internal_procedure().
1472 (multipass_procedure_with_splits) Wrap open_active_file() and
1473 close_active_file() around internal_procedure().
1475 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
1477 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
1479 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
1481 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
1483 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
1485 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
1487 * algorithm.c: By default turn off some of the more expensive
1489 (expensive_assert) New macro which expands to assert if
1490 EXTRA_CHECKS is defined, to nothing otherwise.
1491 (unique) Use expensive_assert().
1492 (binary_search) Ditto.
1498 * command.c: (conflicting_3char_prefixes) Words that are the same
1499 don't cause conflicts when they are abbreviated to the first three
1502 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
1503 nonterm_node's n earlier.
1504 (generic_str_func) Ditto.
1506 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
1508 Add support for multipass procedures. Rewrite DESCRIPTIVES to
1509 test multipass support, take advantage of new moments
1510 calculation, and to not be such crappy code. Get rid of q2c
1511 processing for DESCRIPTIVES.
1513 * vfm.c: (struct multipass_split_aux_data) New structure.
1514 (multipass_procedure_with_splits) New function.
1515 (multipass_split_callback) New function.
1516 (multipass_split_output) New function.
1517 * descript.q: Removed.
1519 * descript.c: New file.
1521 * var.h: Removed descriptives enums.
1522 (struct descriptives_proc) Removed.
1523 (struct variable) Removed p.dsc.
1525 * Makefile.am: (q_sources_c) Remove descript.c.
1526 (q_sources_q) Removed descript.q.
1528 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
1530 New manager for keeping track of used workspace.
1532 * workspace.c: New file.
1534 * workspace.h: New file.
1536 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
1538 * sort.c: (do_internal_sort) Use workspace_malloc().
1539 (destroy_internal_sort) Use workspace_free().
1541 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
1543 New `struct casefile' for managing sets of cases.
1545 * casefile.c: New file.
1547 * casefile.h: New file.
1549 * command.def: Add DEBUG CASEFILE command.
1551 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
1553 * sort.c: (sort_cases) Move logic for sending storage file to disk
1554 into do_external_sort().
1555 (struct internal_sort) Use an array of ccase pointers instead of a
1557 (do_internal_sort) Rewrite to handle casefiles.
1558 (compare_case_list) Removed.
1559 (compare_cases) New function.
1560 (compare_case_dblptrs) New function.
1561 (read_internal_sort_output) Deal with new struct internal_sort.
1563 * vfm.c: (static var workspace_overflow) Removed.
1564 (struct storage_stream_info) Removed all the members. Added
1565 struct casefile * member.
1566 (storage_sink_open) Use casefile.
1567 (open_storage_file) Removed.
1568 (write_storage_file) Removed.
1569 (storage_to_disk) Removed.
1570 (destroy_storage_stream_info) Use casefile.
1571 (storage_sink_write) Use casefile.
1572 (storage_sink_make_source) Use casefile.
1573 (storage_source_count) Use casefile.
1574 (storage_source_read) Use casefile.
1575 (storage_source_on_disk) Removed.
1576 (storage_source_get_cases) Removed.
1577 (storage_source_set_cases) Removed.
1578 (storage_source_get_casefile) New function.
1580 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
1582 New `struct moments' for calculating moments.
1588 * moments.c: New file.
1590 * moments.h: New file.
1592 * command.def: Add DEBUG MOMENTS command.
1594 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
1597 * aggregate.c: Modify AGGREGATE to use the new moments
1598 calculation, even if not in such a great way.
1599 (struct agr_var) Add `moments' member.
1600 (parse_aggregate_functions) Set `moments' member to null.
1601 (agr_destroy) Destroy `moments' member.
1602 (accumulate_aggregate_info) Use `moments' for standard deviation.
1603 (dump_aggregate_info) Ditto.
1604 (initialize_aggregate_info) Create or clear `moments'.
1606 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
1607 cube(), pow4() that were in stats.h. All references updated.
1609 * crosstabs.q: stats.h had chi-square significance functions. Use
1611 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
1613 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
1614 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
1616 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
1618 * dictionary.c: (dict_compact_values) Compacted values need to
1621 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
1623 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
1624 `/' at start. Check return value of parse_variables() for error
1627 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
1629 Revamp expressions: make the code a little nicer, and fix bugs
1632 * expr-evl.c: (expr_evaluate) Make expression argument const.
1633 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1634 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
1635 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
1636 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
1637 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
1638 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
1639 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
1640 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
1641 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
1642 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
1643 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
1644 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
1645 Simplify OP_SYSMIS. Remove OP_STR_MIS.
1647 * expr-opt.c: (optimize_expression) Rewrite.
1652 (macro s0l) Removed.
1654 (macro s1l) Removed.
1656 (macro s2l) Removed.
1659 (eq_num_con) New function.
1660 (optimize_tree) New function.
1661 (macro rnc) Removed.
1662 (macro frnc) Removed.
1663 (str_search) Add const to string params.
1664 (str_rsearch) Ditto.
1665 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
1666 str[], str_len[] locals to substitute for most of removed macros.
1667 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1668 Removed support for missing values because we're never called with
1669 missing values. Use set_number() or set_number_errno() instead of
1670 rnc or frnc. Removed any stuff that caused trouble in testing.
1671 We can re-add it later if it really slows anything. Fix some
1673 (evaluate_tree_with_missing) Not yet supported. To be added later
1675 (repl_num_con) Removed.
1676 (collapse_node) New function.
1677 (force_repl_num_con) Removed.
1678 (set_number) New function.
1679 (set_number_errno) New function.
1680 (repl_str_con) Removed.
1681 (set_string) New function.
1682 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
1684 (dump_node) No special case for OP_AND, OP_OR.
1686 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
1687 (expr_get_type) New function.
1688 (type_check) Rewrite.
1689 (type_coercion) New function.
1690 (struct operator) New structure.
1691 (match_operator New function.
1692 (parse_binary_operators) New function.
1693 (parse_inverting_unary_operator) New function.
1694 (parse_or) Rewritten.
1695 (parse_and) Rewritten.
1696 (parse_not) Rewritten.
1697 (parse_rel) Rewritten.
1698 (parse_add) Rewritten.
1699 (parse_mul) Rewritten.
1700 (parse_neg) Rewritten.
1701 (parse_exp) Rewritten.
1702 (parse_sysvar) Add $TRUE, $FALSE system variables.
1703 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
1704 (parse_primary) Use allocate_var_node(), allocate_num_con(),
1706 (struct function) Remove desc, change `func' prototype.
1707 (unary_func) Remove special cases.
1708 (MISSING_func) Reduce to unary_func() that just returns a boolean.
1709 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
1710 (VALUE_func) Use allocate_var_node().
1711 (nary_num_func) Allow MIN and MAX for strings.
1712 Use allocate_var_node(). Properly clean up.
1714 (generic_str_func) Use local table instead of removed `desc'
1715 member. Mostly rewrite.
1716 (get_num_args) Revise error message.
1717 (parse_function) Return EXPR_ERROR, not 0 on error.
1719 (macro varies) Removed.
1720 (ops[]) Use expr.def.
1721 (free_node) Do nothing if node is null.
1722 (allocate_num_con) New function.
1723 (allocate_str_con) New function.
1724 (allocate_var_node) New function.
1725 (allocate_binary_nonterminal) New function.
1726 (append_nonterminal_arg) Removed.
1727 (static var func_tab[]) Revised.
1728 (expr_debug_print_postfix) Make parameter const.
1729 Use printf() instead of debug_printf().
1731 * expr.def: New file.
1733 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
1734 use named enum instead of unnamed, all references updated. Add
1735 EXPR_ANY, EXPR_NO_OPTIMIZE.
1737 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
1738 instead of defining OP_* directly.
1739 (macro IS_TERMINAL) New macro.
1740 (macro IS_NONTERMINAL) New macro.
1741 (enum OP_NO_FLAGS) New.
1743 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
1745 * error.c: (err_assert_fail) msg variable needs to be non-const.
1747 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
1749 * debug.c: (cmd_debug_evaluate) Rewrite.
1751 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
1753 Fix some CROSSTABS bit rot stupidity.
1755 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
1756 (internal_cmd_crosstabs) Initializes cells[] correctly.
1757 (float_M_suffix) Rename format_cell_entry(), change prototype,
1759 (display_crosstabulation) Fix cell formatting.
1761 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
1763 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
1764 to call lex_discard_line() to do that.
1766 * command.c: (run_command) Call lex_discard_line() after
1769 * lexer.c: (lex_entire_end) Change behavior.
1770 (lex_rest_of_line) Change behavior. Return const char *.
1771 (lex_discard_line) Don't clear getl_buf, don't emit message.
1773 * main.c: (handle_error) Emit message here.
1775 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
1776 instead of lex_entire_line().
1778 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
1780 * title.c: (get_title) Call lex_discard_line() after
1782 (cmd_file_label) Ditto.
1783 (cmd_document) Deal with const char * return value.
1785 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
1787 Removed REMARK command.
1789 * command.c: (extract_prefix) Removed.
1790 (output_line) Removed.
1791 (cmd_remark) Removed.
1793 * command.def: Remove REMARK.
1795 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
1797 Added abort() after lots of assert(0) invocations to avoid some
1798 compiler warnings. We really need a NOT_REACHED macro.
1800 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
1802 * sort.c: Added missing call to temp_file_close. Changed error
1803 messages to warnings.
1805 * set.q: Improved setting of set_view{length,width} to be more tolerant
1808 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
1810 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
1811 used with incorrect syntax.
1813 * error.c, error.h et al: Overridden definition of assert for a
1816 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
1817 subcommand was given when it ought to have been.
1819 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
1821 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
1825 (tab_joint_text) Ditto.
1827 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
1829 * levene.c: Add #include.
1831 * set.q: (set_viewport) Add `int' argument to make its prototype
1832 correct for signal().
1834 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
1836 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
1839 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
1841 Changed DFM from open-at-first-access to explicit-open. Before,
1842 calling dfm_get_record() or dfm_put_record() would automatically
1843 open the file. Now, you have to call dfm_open_for_reading() or
1844 dfm_open_for_writing() explicitly. This makes it possible to
1845 check permissions, file existence, etc. earlier.
1847 Also made struct file_handle more opaque, and clean up in general.
1849 * data-list.c: (cmd_data_list) Open handle for reading.
1851 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
1853 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
1854 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
1855 (open_inline_file) Removed.
1856 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
1857 it. Deal with line_number in extension record instead of file
1859 (dfm_get_record) Rewrote.
1860 (dfm_put_record) Rewrote.
1861 (dfm_push) Assert file is open and one of ours. Deal with
1862 line_number in extension record instead of file handle.
1863 (dfm_pop) Assert file is open and one of ours. Deal with
1864 line_number in extension record instead of file handle.
1865 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
1868 * file-handle.h: (enum constants RH_RF_*) Removed.
1869 (enum constants FH_MD_*) Removed.
1870 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
1871 `recform', `lrecl', `mode' members. Public references to
1872 `recform' changed to use handle_get_mode(), references to `lrecl'
1873 changed to use handle_get_record_width(). Added `private' member.
1874 (enum file_handle_mode) New.
1876 * file-handle.q: (struct private_file_handle) New structure.
1877 (struct file_handle_list) New structure.
1878 (static var files) New.
1879 (static var file_handles) Removed.
1880 (init_file_handle) Removed.
1881 (create_file_handle) Removed.
1882 (get_handle_with_name) New function.
1883 (get_handle_for_filename) New function.
1884 (cmd_file_handle) Rewritten.
1885 (hash_file_handle) Removed.
1886 (cmp_file_handle) Removed.
1887 (fh_init_files) Rewritten.
1888 (fh_parse_file_handle) Rewritten. Allows identifiers as
1890 (fh_get_handle_by_name) Renamed handle_get_name(), all references
1892 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
1893 references updated. Rewritten.
1894 (fh_record_width) Renamed handle_get_record_width(), all
1895 references updated. Rewritten.
1896 (handle_get_mode) New function.
1898 * file-type.c: (cmd_file_type) Open handle for reading.
1900 * filename.c: [unix] (struct file_identity) New structure.
1901 [unix] (fn_get_identity) New function.
1902 [unix] (fn_free_identity) New function.
1903 [unix] (fn_compare_file_identities) New function.
1904 [!unix] (struct file_identity) New structure.
1905 [!unix] (fn_get_identity) New function.
1906 [!unix] (fn_free_identity) New function.
1907 [!unix] (fn_compare_file_identities) New function.
1909 * lexer.c: (static var put) Renamed put_token, all references
1911 (static var put_tokstr) New.
1912 (static var put_tokval) New.
1913 (lex_init) Initialize put_tokstr().
1914 (restore_token) New function.
1915 (save_token) New function.
1916 (lex_get) Use restore_token().
1917 (lex_put_back) Use save_token().
1918 (lex_put_back_id) New function.
1919 (lex_put_forward) Removed.
1920 (lex_preprocess_line) Set put_token instead of using
1922 (lex_negative_to_dash) Use save_token(), set put_token directly.
1923 (dump_token) Use stderr instead of stdout.
1925 * main.c: (main) Remove call to cmd_init().
1927 * matrix-data.c: (cmd_matrix_data) Open file for reading.
1929 * pfm-read.c: Use handle_get_filename() instead of trying to use
1930 h->fn directly, all over.
1932 * pfm-write.c: Ditto.
1934 * print.c: (internal_cmd_print) Open handle for writing.
1935 (dump_table) Use handle_get_filename().
1936 (print_trns_proc) Use handle_get_mode().
1937 (cmd_print_space) Use fh_parse_file_handle().
1938 Open handle for writing.
1939 [0] (debug_print) Removed.
1941 * sfm-read.c: Use handle_get_filename() instead of trying to use
1942 h->fn directly, all over.
1944 * sfm-write.c: Ditto.
1946 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
1950 * autorecode.c: (arc_free) Free arc->src_values.
1952 * error.c: (msg) Free buf.
1954 * val-labs.c: (do_value_labels) Always free vars.
1956 * vfm.c: (close_active_file) If sink has no make_source then call
1957 its destroy function.
1959 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
1961 Fixed cmd_parse() so that it always skips past a full command
1962 name. A few special commands for which this would be bad get
1963 special treatment. This lets us drop code for skipping past the
1964 end of a command name in most cmd_*() functions. It's not worth
1965 listing all the commands affected.
1967 * command.c: (struct command) Remove `cmd' member, replace by
1968 `name' member, all references updated. Remove `word', `next',
1969 `skip_entire_name' members.
1970 (macro DEFCMD) Deal with revised `struct command'.
1971 (macro UNIMPL) Ditto.
1972 (macro SPCCMD) New macro for commands whose last word shouldn't be
1974 (static array cmd_table[]) Make const, rename `commands', remove
1976 (macro COMMAND_CNT) New macro.
1977 (split_words) Removed.
1979 (FILE_TYPE_okay) Make parameter const.
1980 (cmd_parse) Improve error messages.
1981 (match_strings) New function.
1982 (next_word) New function.
1983 (enum command_match) New enum.
1984 (conflicting_3char_prefixes) New function.
1985 (conflicting_3char_prefix_command) New function.
1986 (cmd_match_words) New function.
1987 (count_matching_commands) New function.
1988 (get_command_name) New function.
1989 (free_words) New function.
1990 (unknown_command_error) New function.
1991 (figure_out_command) Renamed parse_command_name(), rewritten.
1993 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
1994 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
1995 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
1998 * command.h: (macro SPCCMD) New.
2000 * include.c: (cmd_include_at) Removed.
2001 (cmd_include) Allow identifier to be used as filename.
2003 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
2005 * t-test.q: (cmd_t_test) Command name is now parsed for us.
2008 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
2010 Start work on better test framework.
2012 * Makefile.am: (pspp_sources) Add debug.c.
2014 * debug.c: New file.
2016 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
2017 cmd_debug_evaluate().
2019 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
2021 * expr.h: (enum constant PXP_DUMP) Removed.
2023 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
2025 * set.q: Implemented the SHOW command, and synced it to the existing
2028 Added a handler for SIGWINCH so that viewlength and viewwidth follow
2029 changes as the window size is changed.
2031 Added fallback to set viewlength and viewwidth from LINES and COLUMS
2032 environment variables if other methods are not available.
2034 glob.c: Removed a lot of global variables from glob.c and encapsulated
2037 random.c: Tidied up the way the random seed is set.
2039 str.c: Added a ds_vprintf function.
2041 error.c: Extended dump_message so that messages are always broken at
2044 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
2046 * pfm-write.c: (bufwrite) Write out the correct element for string
2047 variables. From Andreas Streichardt <streichardt@globalpark.de>.
2049 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
2051 Get rid of static and global (!) vars in matrix-data.c.
2053 * matrix-data.c: (static var nr_data) Removed.
2054 (static var nr_factor_values) Removed.
2055 (static var max_cell_index) Removed.
2056 (static var split_values) Removed.
2057 (struct nr_aux_data) New structure.
2058 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
2059 place of static vars, pass to create_case_source() and procedure()
2061 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
2062 struct matrix_data_pgm *.
2063 (nr_read_splits) Ditto.
2064 (nr_read_factors) Ditto.
2065 (nr_output_data) Ditto.
2066 (static var wr_content) Removed.
2067 (global var wr_data) Removed.
2068 (global var wr_current) Removed.
2069 (struct wr_aux_data) New structure.
2070 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
2071 place of static vars, pass to create_case_source() and procedure()
2073 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
2074 instead of matrix_data_pgm *.
2075 (wr_read_splits) Ditto.
2076 (wr_output_data) Ditto.
2077 (wr_read_rowtype) Ditto.
2078 (wr_read_factors) Ditto.
2079 (wr_read_indeps) Ditto.
2081 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
2083 Get rid of static vars in autorecode.c.
2085 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
2086 `n_arc' to `spec_cnt'. All references updated.
2087 (static var v_src) Removed.
2088 (static var v_dest) Removed.
2089 (static var h_trns) Removed.
2090 (static var nv_src) Removed.
2091 (static var descend) Removed.
2092 (static var print) Removed.
2093 (enum direction) New enum.
2094 (struct autorecode_pgm) New structure.
2095 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
2096 Move n_dest local var into struct autorecode_pgm for ease of
2097 clean-up. Use arc_free().
2098 (arc_free) New function.
2099 (recode) Modify to take struct autorecode_pgm * parameter instead
2100 of using statics. Let the caller clean up.
2101 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
2102 instead of statics. Rearrange code a little.
2104 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
2106 Get rid of static, global vars in recode.c. Remove debug code.
2108 * recode.c: (static var head) Removed.
2109 (global var v) Removed.
2110 (global var nv) Removed.
2111 (cmd_recode) New local variables head, v, nv. Initialize and free
2112 v. Don't call debug_print().
2113 [DEBUGGING] (dump_dest) Removed.
2114 [DEBUGGING] (debug_print) Removed.
2116 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
2118 Get rid of static vars in expr-opt.c.
2120 * expr-opt.c: (static var e) Removed.
2121 (static var nop) Removed.
2122 (static var mop) Removed.
2123 (static var ndbl) Removed.
2124 (static var mdbl) Removed.
2125 (static var nstr) Removed.
2126 (static var mstr) Removed.
2127 (static var nvars) Removed.
2128 (static var mvars) Removed.
2129 (struct expr_dump_state) New structure.
2130 (dump_expression) Use new struct expr_dump_state instead of static
2131 vars and pass to functions we call.
2132 (dump_node) Use struct expr_dump_state * parameter.
2134 (emit_num_con) Ditto.
2135 (emit_str_con) Ditto.
2138 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
2140 Get rid of static var in COUNT.
2142 * count.c: (static var head) Move into cmd_count().
2143 (cmd_count) [DEBUGGING] Don't call debug_print.
2144 [DEBUGGING] (debug_print) Removed.
2146 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
2148 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
2150 * val-labs.c: (static var v) Removed.
2151 (static var nv) Removed.
2152 [DEBUGGING] (debug_print) Removed.
2153 (verify_val_labs) Add struct variable **, int parameters.
2154 (get_label) Ditto. Improve error messages, streamline.
2155 (erase_labels) New function for erasing value labels, taking over
2156 part of verify_val_labs()'s function.
2159 (cmd_value_labels) No need to call init() or done() anymore.
2160 (cmd_add_value_labels) Ditto.
2161 (do_value_labels) Add vars, var_cnt local variables. Clean up
2162 after them internally. Call erase_labels() if we should. Don't
2165 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
2167 Get rid of static vars in MATCH FILES.
2169 * get.c: (static var mtf_head) Removed.
2170 (static var mtf_tail) Removed.
2171 (static var mtf_by) Removed.
2172 (static var mtf_n_by) Removed.
2173 (static var mtf_master) Removed.
2174 (static var mtf_seq_num) Removed.
2175 (static var mtf_seq_nums) Removed.
2176 (static var mtf_sink) Removed.
2177 (static var mtf_case) Removed.
2178 (struct mtf_proc) New structure.
2179 (cmd_match_files) Use struct mtf_proc instead of static vars.
2180 (mtf_processing_finish) Ditto.
2182 (mtf_delete_file_in_place) Ditto.
2183 (mtf_read_nonactive_records) Ditto.
2184 (mtf_compare_BY_values) Ditto.
2185 (mtf_processing) Ditto.
2186 (mtf_merge_dictionary) Ditto.
2188 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
2190 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
2192 * dictionary.c: (dict_rename_var) Add assertion.
2193 (dict_contains_var) Check by index instead of name.
2195 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
2197 Get rid of compaction_necessary, compaction_nval, compaction_case.
2198 Redo VFM interface. Replace disk_sink and memory_sink by
2199 storage_sink, disk_source and memory_source by storage_source.
2201 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
2205 (struct write_case_data) Remove `begin_func', `end_func',
2206 `func_aux' members. Add `aux', `trns_case', `sink_case',
2207 `cases_written', `cases_analyzed' members.
2208 (global var compaction_necessary) Make static.
2209 (global var compaction_nval) Removed.
2210 (global var compaction_case) Removed.
2211 (static var case_count) Removed.
2212 (struct procedure_aux_data) Removed.
2213 (struct split_aux_data) Removed.
2214 (procedure) Remove begin_func, end_func parameters. Rewrite.
2215 (static var not_canceled) Removed.
2216 (process_active_file) Removed.
2217 (process_active_file_write_case) Removed.
2218 (process_active_file_output_case) Removed.
2219 (prepare_for_writing) Moved into open_active_file().
2220 (arrange_compaction) Ditto.
2222 (open_active_file) Rewrote.
2223 (write_case) New function.
2224 [DEBUGGING] (index_to_varname) Removed.
2225 (execute_transformations) New function.
2226 (exclude_this_case) Renamed filter_case(), changed interface.
2227 (clear_case) Added struct ccase * parameter to interface.
2228 (close_active_file) Added struct write_case_data * parameter,
2230 (disk_sink_create) Removed.
2231 (disk_sink_destroy) Removed.
2232 (disk_sink_make_source) Removed.
2233 (disk_sink_write) Removed.
2234 (disk_source_count) Removed.
2235 (disk_source_destroy) Removed.
2236 (disk_source_read) Removed.
2237 (global var disk_sink_class) Removed.
2238 (global var disk_source_class) Removed.
2239 (global var memory_sink_class) Removed.
2240 (global var memory_source_class) Removed.
2241 (memory_sink_create) Removed.
2242 (memory_sink_destroy) Removed.
2243 (memory_sink_make_source) Removed.
2244 (memory_sink_write) Removed.
2245 (memory_source_count) Removed.
2246 (memory_source_destroy) Removed.
2247 (memory_source_get_cases) Removed.
2248 (memory_source_read) Removed.
2249 (memory_source_set_cases) Removed.
2250 (struct disk_stream_info) Removed.
2251 (struct memory_sink_info) Removed.
2252 (struct memory_source_info) Removed.
2253 (write_active_file_to_disk) Removed.
2254 (destroy_storage_stream_info) New function.
2255 (global var null_sink_class) New var.
2256 (global var storage_sink_class) New var.
2257 (global var storage_source_class) New var.
2258 (open_storage_file) New function.
2259 (storage_sink_destroy) New function.
2260 (storage_sink_make_source) New function.
2261 (storage_sink_open) New function.
2262 (storage_sink_write) New function.
2263 (storage_source_count) New function.
2264 (storage_source_destroy) New function.
2265 (storage_source_get_cases) New function.
2266 (storage_source_on_disk) New function.
2267 (storage_source_read) New function.
2268 (storage_source_set_cases) New function.
2269 (storage_source_to_disk) New function.
2270 (storage_to_disk) New function.
2271 (struct storage_stream_info) New structure.
2272 (write_storage_file) New function.
2273 (procedure_write_case) Removed.
2274 (create_case_source) Add `struct dictionary *' parameter, all
2276 (create_case_sink) Ditto.
2277 (free_case_sink) New function.
2278 (struct split_aux_data) New structure.
2279 (procedure_with_splits) New function implementing what procedure()
2281 (SPLIT_FILE_proc_func) Removed.
2282 (procedure_with_splits_callback) New function.
2283 (equal_splits) New function.
2285 * aggregate.c: Pass around a struct instead of using statics.
2286 (static var outfile) Remove.
2287 (enum type) Give it tag `missing_treatment'.
2288 (static var missing) Remove.
2289 (static var sort) Remove.
2290 (static var agr_first) Remove.
2291 (static var agr_next) Remove.
2292 (static var case_count) Remove.
2293 (static var prev_case) Remove.
2294 (static var buf64_1xx) Remove.
2295 (static var buf_1xx) Remove.
2296 (struct agr_proc) New structure incorporating the above.
2297 (cmd_aggregate) Use new struct. Clean up error handling using
2298 agr_destroy(). Completely rewrite actual implementation of
2300 (create_sysfile) Add struct agr_proc * parameter, modify
2302 (parse_aggregate_functions) Ditto.
2303 (free_aggregate_functions) Ditto. Rename agr_destroy().
2304 (aggregate_single_case) Add struct agr_proc * parameter, modify
2306 (accumulate_aggregate_info) Ditto.
2307 (dump_aggregate_info) Ditto.
2308 (initialize_aggregate_info) Ditto.
2309 (agr_00x_trns_proc) Removed.
2310 (agr_00x_end_func) Removed.
2311 (agr_10x_trns_proc) Removed.
2312 (agr_10x_trns_free) Removed.
2313 (agr_10x_end_func) Removed.
2314 (agr_11x_read) Removed.
2315 (agr_11x_finish) Removed.
2316 [DEBUGGING] (debug_print) Removed.
2317 (write_case_to_sfm) Add struct agr_proc * parameter, modify
2319 (agr_to_active_file) New function.
2320 (presorted_agr_to_sysfile) New function.
2321 (sort_agr_to_sysfile) New function.
2323 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
2325 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
2327 * descript.q: (cmd_descriptives) Ditto.
2329 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
2330 to new procedure() interface.
2332 * command.c: (cmd_execute) Adapt to new procedure() interface.
2334 * dictionary.c: (dict_compact_values) Also delete scratch
2336 (dict_get_compacted_value_cnt) New function.
2337 (dict_get_compacted_idx_to_fv) New function.
2339 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
2340 (cmd_flip) Adapt to new procedure() interface.
2341 (flip_sink_write) Use sink->idx_to_fv.
2343 * frequencies.q: (internal_cmd_frequencies) Use
2344 procedure_with_splits().
2346 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
2347 (static var mtf_sink) New static var.
2348 (static var mtf_case) New static var.
2349 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
2350 we actually implement the matching.
2351 (mtf_delete_file_in_place) Use mtf_case.
2352 (mtf_processing) Use mtf_case and mtf_sink.
2353 (cmd_export) Adapt to new procedure() interface.
2355 * levene.c: (levene) Use procedure_with_splits().
2357 * list.q: (cmd_list) Use procedure_with_splits().
2359 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
2360 procedure() interface.
2361 (read_matrices_with_rowtype) Ditto.
2363 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
2364 TEMPORARY. Adapt to new procedure() interface.
2366 * rename-vars.c: Warn about and cancel TEMPORARY.
2368 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
2369 (sort_cases) Use dict_get_compacted_value_cnt() instead of
2370 compaction_nval. Adapt to new procedure() interface. Use
2371 storage_source_to_disk().
2372 (do_internal_sort) Don't try to dump the cases to memory.
2373 (compare_case_lists) Pass null idx_to_fv.
2374 (struct initial_run_state) Add `idx_to_fv' member. Remove
2376 (write_initial_runs) Don't initialize irs->case_size. Adapt to
2377 new procedure() interface. Reset irs->idx_to_fv after calling
2379 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
2380 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
2382 (destroy_initial_run_state) Don't dereference irs after freeing
2384 (allocate_cases) Don't calculate case_size locally.
2385 (compare_record) Add idx_to_fv parameter.
2386 (compare_record_run) Change parameter from struct sort_cases_pgm *
2387 to struct initial_run_state *. Pass irs->idx_to_fv to
2389 (compare_record_run) Third parameter now a struct
2390 initial_run_state *.
2391 (output_record) No need for out_case anymore. Pass irs, not
2392 struct sort_cases_pgm to pop_heap(). Use case_size from struct
2394 (merge) Use case_size from struct sort_cases_pgm.
2395 (merge_once) Use case_size from struct sort_cases_pgm.
2396 Pass null pointer to compare_record() as idx_to_fv.
2397 (global var sort_sink_class) Make static.
2399 * t-test.q: (cmd_t_test) Use procedure_with_splits().
2401 * temporary.c: Remove debugging crap.
2403 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
2405 * t-test.q, levene.c: Fixed up the handling of MISSING values
2408 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
2410 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
2413 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
2415 Change explicit variable name checks into use of
2416 dict_class_from_id().
2418 * dictionary.c: (dict_create_var) Change explicit variable name
2419 check into use of dict_class_from_id().
2421 * get.c: (trim_dictionary) Ditto.
2423 * sel-if.c: (cmd_filter) Ditto.
2425 * sysfile-info.c: (cmd_display) Ditto.
2427 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
2429 * vfm.c: (arrange_compaction) Ditto.
2431 * weight.c: (cmd_weight) Ditto.
2433 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
2435 * temporary.c: (cmd_temporary) When TEMPORARY was the first
2436 transformation following the input program, if any, for some
2437 reason we special-cased f_trns. That's just wrong. It should
2438 always be set to n_trns.
2440 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
2442 * format.c: (parse_format_specifier_name) Fix brown-bag bug
2443 introduced in last check-in.
2445 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
2447 * format.c: (global array translate_fmt[]) Removed.
2448 (translate_fmt) New function as replacement.
2449 (parse_format_specifier_name) Rewrite.
2451 * pfm-read.c: (convert_format) Use translate_fmt() instead of
2454 * sfm-read.c: (parse_format_spec) Ditto.
2456 * postscript.c: (text) Fix handling of fonts with missing
2459 * sort.c: (struct external_sort) Add temp_name member.
2460 (destroy_external_sort) Free temp_dir, temp_name members.
2461 (init_external_sort) Allocate temp_name.
2462 (get_temp_file_name) Change prototype.
2463 (open_temp_file) Deal with change to get_temp_file_name().
2464 (close_temp_file) Ditto.
2465 (remove_temp_file) Ditto.
2466 (write_temp_file) Ditto.
2467 (read_temp_file) Ditto.
2468 (sort_sink_destroy) Removed.
2469 (sort_sink_class) Change destroy member to null.
2471 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
2473 Eliminate temp_case.
2475 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
2476 anymore. Use agr_11x_finish().
2477 (aggregate_single_case) Make first param const.
2478 (accumulate_aggregate_info) Ditto.
2479 (agr_00x_end_func) Use compaction_case, not temp_case.
2480 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
2482 * data-list.c: (struct data_list_pgm) Add `case_size' member.
2483 (cmd_data_list) Initialize case_size.
2484 (read_from_data_list_fixed) Add struct ccase * param, use instead
2486 (read_from_data_list_free) Ditto.
2487 (read_from_data_list_list) Ditto.
2488 (read_one_case) Rename data_list_trns_proc(), all references
2489 updated. Add argument in calling above functions. Use c
2490 argument instead of temp_case.
2491 (destroy_dls) Rename data_list_trns_free(), all references
2494 * expr-evl.c: (expr_evaluate) Make second parameter const.
2496 * file-type.c: (struct file_type_pgm) Add `case_size' member.
2497 (cmd_end_file_type) Initialize `case_size'.
2498 (file_type_source_read) Add struct ccase * parameter. Use instead
2501 * flip.c: Rewritten.
2503 * get.c: (struct get_pgm) New structure to keep track of
2505 (cmd_get) Initialize case_size.
2507 (get_source) Deal with struct get_pgm.
2508 (get_source_read) Add struct ccase * parameter, use instead of
2510 (import_source_read) Ditto.
2512 * get.c: Use a null pointer instead of temp_case to represent the
2513 "current case" in a struct mtf_file's input member.
2514 (mtf_processing_finish) Pass null to mtf_processing(), not
2516 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
2517 (mtf_compare_BY_values) Add extra arg, use instead of null input
2519 (mtf_processing) Use c parameter instead of temp_case. Pass
2520 compaction_case to process_active_file_output_case().
2522 * glob.c: (global variable temp_case) Removed.
2524 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
2525 (cmd_input_program) Initialize case_size. Set
2526 vfm_source->value_cnt.
2527 (init_case) Add struct ccase * parameter, use instead of
2530 (input_program_source_read) Ditto.
2532 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
2533 (dump_cell_content) Ditto.
2534 (nr_output_data) Ditto.
2535 (read_matrices_without_rowtype) Ditto.
2536 (matrix_data_read_with_rowtype) Ditto.
2537 (wr_read_splits) Ditto.
2538 (wr_output_data) Ditto.
2540 * sort.h: (struct sort_cases_pgm) New member `case_size'.
2542 * sort.c: (sort_cases) Initialize scp->case_size.
2543 (struct external_sort) Remove `case_size' member.
2544 (write_initial_runs) Only call vfm_sink->class_destroy if
2546 (struct sort_source_aux) New structure.
2547 (sort_source_read_helper) New function.
2548 (sort_source_read) Use sort_source_read_helper().
2549 (read_sort_output) Change interface to be more reasonable.
2550 (read_internal_sort_output) Ditto.
2551 (read_external_sort_output) Ditto.
2553 * vars-prs.c: (dict_class_to_name) Pass return value through
2556 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
2557 (procedure) Initialize trns_case.
2558 (procedure) Pass trns_case to vfm_source->class->read().
2560 (process_active_file) Start using struct procedure_aux_data.
2561 (process_active_file_write_case) Pass trns_case to
2562 transformations, lag_case(), clear_case().
2563 (process_active_file_output_case) Add struct ccase * parameter.
2564 (create_trns_case) New function.
2565 (make_temp_case) Removed.
2566 (vector_initialization) Removed.
2567 (close_active_file) Only call make_source if non-null, otherwise
2568 set vfm_source to null pointer. Don't free temp_case.
2569 (disk_source_read) Add struct ccase * parameter, use instead of
2571 (memory_source_read) Ditto.
2572 (lag_case) Add const struct ccase * member.
2573 (procedure_write_case) Use trns_case instead of temp_case.
2574 (clear_case) Add struct ccase * member, use instead of temp_case.
2575 (exclude_this_case) Ditto.
2576 (create_case_source) Add struct dictionary * parameter, use to
2577 initialize source->value_cnt.
2579 * vfm.h: (struct case_source) Add `value_cnt' member.
2580 (struct case_source_class) Add struct ccase * parameter to `read'
2581 member function pointer.
2582 (struct case_sink_class) Make struct ccase * parameter const in
2583 `write' member function pointer.
2585 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
2587 Fix a lot of "possibly uninitialized variable" warnings. Some of
2588 them are even real bugs. A few of them make me wonder how the
2591 * aggregate.c: (parse_aggregate_functions) Initialize `function.
2593 * ascii.c: (output_lines) Add default case to switch.
2595 * crosstabs.q: Remove static variable `expected' and all
2597 (display_crosstabulation) Always calculate expected value.
2599 (output_pivot_table) Initialize `cmp'.
2600 (display_crosstabulation) New variable `last_row', which is
2603 * data-in.c: (parse_numeric) Always initialize sign. How did this
2606 * data-list.c: (repeating_data_trns_proc) Always initialize code.
2607 Always set info.ofs. (How did this work?!)
2609 * expr-opt.c: (optimize_tree) Always initialize `m'.
2610 (evaluate_tree) Always initialize `c'. (How did this work?)
2612 * frequencies.q: (frq_custom_variables) Always initialize min,
2614 (frq_custom_grouped) Always initialize `dl'.
2616 * groff-font.c: (groff_read_font) Always initialize char_set.
2618 * matrix-data.c: (nr_output_data) Initialize `split'.
2619 (wr_read_splits) Remove shadowing split_cnt declaration.
2620 (wr_output_data) Initialize `split'.
2622 * output.c: (tokener) Skip add character on syntax error.
2624 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
2626 * postscript.c: (read_ps_encodings) Use line.string instead of
2628 (write_text) Add default case to switch.
2629 (text) Always initialize multiple variables. Fix bug with
2632 * print.c: (fixed_parse_fortran) Initialize head.
2633 (alloc_line) Add default case to switch.
2635 * recode.c: (parse_dest_spec) Handle case where nothing matches.
2636 (recode_trns_proc) Move variable declaration inward. Add default
2639 * sfm-read.c: (read_header) Initialize skip_amt.
2641 * sysfile-info.c: (display_variables) Always initialize pc.
2643 * vars-prs.c: Initialized `included'.
2645 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
2647 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
2648 Just use signal() instead.
2650 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
2652 Get rid of vfm_sink_info and vfm_source_info.
2654 * aggregate.c: (agr_00x_end_func) Don't increment
2655 sfm_sink_info.ncases.
2657 * sort.c: (do_internal_sort) Get case count from
2658 vfm_source->class->count().
2659 (struct external_sort) Add `case_size' member.
2660 (do_external_sort) Initialize case_size.
2661 (struct initial_run_state) Add `case_size' member.
2662 (write_initial_runs) Initialize case_size.
2663 (sort_sink_write) Use case_size.
2664 (read_external_sort_output) Use case_size. Get case_cnt from
2667 * vfm.c: (struct write_case_data) Add underscores to existing arg
2668 names, all references updated. Renamed `aux' as `func_aux', all
2669 references updated. Added new `aux' member.
2670 (global var vfm_source_info) Removed.
2671 (global var vfm_sink_info) Removed.
2672 (struct procedure_aux_data) New.
2673 (struct split_aux_data) New.
2674 (procedure) Use `aux' fields for procedure_aux_data,
2676 (process_active_file_write_case) Pass case_count + 1 to
2677 transformation procedures, exclude_this_case().
2678 (process_active_file_output_case) Don't increment
2679 vfm_sink_info.ncases.
2680 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
2681 to send data to disk early.
2682 (make_temp_case) Don't use vfm_sink_info.case_size.
2683 (close_active_file) Don't initialize vfm_source_info.
2684 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
2685 (disk_sink_create) Initialize and/or update disk_stream_info.
2686 (disk_sink_write) Ditto.
2687 (disk_sink_destroy) Ditto.
2688 (disk_sink_make_source) Ditto.
2689 (disk_source_read) Ditto.
2690 (disk_source_destroy) Ditto.
2691 (global var disk_source_class) Add disk_source_count().
2692 (disk_source_count) New function.
2693 (struct memory_sink_info) Add `case_cnt', `case_size' members.
2694 (struct memory_source_info) Ditto.
2695 (memory_sink_create) Deal with case_cnt, case_size.
2696 (memory_sink_write) Ditto.
2697 (memory_sink_make_source) Ditto.
2698 (memory_source_read) Ditto.
2699 (memory_source_count) New function.
2700 (memory_source_class) Add memory_source_count().
2701 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
2702 proc_aux->cases_written, and pass it to transformation procedures
2703 and exclude_this_case ().
2704 (exclude_this_case) Add case_num parameter. Pass it to
2706 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
2709 * vfm.h: (struct case_source_class) Add `count' member.
2711 * vfmP.h: (struct stream_info) Removed.
2712 (global variable vfm_source_info) Removed.
2713 (global variable vfm_sink_info) Removed.
2715 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
2717 * var.h: (typedef trns_proc_func) New typedef.
2718 (trns_free_func) New typedef.
2719 (struct trns_header) Change `proc' to type trns_proc_func, `free'
2720 to type trns_free_func. This only changes the actual type of
2721 trns_proc_func, adding a `case_num' parameter. Updated all
2722 implementations to use the typedefs instead.
2724 * compute.c: (compute_num) Pass case_num to expr_evaluate().
2725 (compute_num_vec) Ditto.
2726 (compute_str) Ditto.
2727 (compute_str_vec) Ditto.
2729 * do-if.c: (do_if_trns_proc) Ditto.
2731 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
2734 * inpt-pgm.c: (input_program_source_read) Maintain case count,
2735 pass to transformation functions.
2736 (reread_trns_proc) Pass case_num arg to expr_evaluate().
2738 * loop.c: (loop_1_trns_proc) Ditto.
2739 (loop_2_trns_proc) Ditto.
2740 (loop_3_trns_proc) Ditto.
2742 * print.c: (print_space_trns_proc) Ditto.
2744 * sel-if.c: (select_if_proc) Ditto.
2746 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
2748 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
2749 destroying hash table.
2751 * glob.c: (read_active_file) Variable not referenced, removed.
2752 (cancel_input_pgm) Ditto.
2754 * levene.c: Add #include <stdlib.h> needed to call free().
2756 * aggregate.c: (parse_aggregate_functions) Make `function'
2759 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
2761 Start working to eliminate VFM dependence on static variables.
2763 * command.c: (cmd_parse) Use case_source_is_class().
2765 * data-list.c: Rewrite to eliminate use of static variables.
2767 * dfm.c: (cmd_begin_data) Use case_source_is_class().
2769 * file-handle.q: (fh_handle_name) Make parameter const.
2771 * file-type.c: Rewrite to eliminate use of static variables.
2773 * flip.c: Rewrite to eliminate use of static variables.
2775 * format.c: (get_format_var_width) New function.
2777 * get.c: Eliminate use of static variables.
2779 * inpt-pgm.c: Eliminate use of static variables.
2781 * matrix-data.c: Eliminate use of static variables.
2783 * set.q: (set_max_workspace) New variable.
2784 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
2786 * var.h: (struct case_list) Move here from vfmP.h.
2788 * vars-atr.c: (discard_variables) Handle new vfm_source type.
2790 * vfm.c: (vfm_source) Change type from struct case_stream to
2792 (vfm_sink) Change type from struct case_stream to struct
2794 (static var paging) Rename workspace_overflow, all references
2796 (procedure) Use new class structures.
2797 (process_active_file) Ditto.
2798 (process_active_file_write_case) Ditto.
2799 (prepare_for_writing) Use set_max_workspace. Use new class
2801 (close_active_file) Use new class structures. Free old sink.
2802 (global var disk_source_file) Removed.
2803 (global var disk_sink_file) Removed.
2804 (disk_stream_init) Removed.
2805 (disk_stream_read) Removed.
2806 (disk_stream_write) Removed.
2807 (disk_stream_mode) Removed.
2808 (disk_stream_destroy_source) Removed.
2809 (disk_stream_destroy_sink) Removed.
2810 (global var vfm_disk_stream) Removed.
2811 (disk_sink_create) New function.
2812 (disk_sink_write) New function.
2813 (disk_sink_destroy) New function.
2814 (disk_sink_make_source) New function.
2815 (disk_sink_class) New static var.
2816 (disk_source_read) New function.
2817 (disk_source_destroy) New function.
2818 (global var vfm_source_class) New var.
2819 (global var memory_source_cases) Removed.
2820 (global var memory_sink_cases) Removed.
2821 (global var memory_sink_max_cases) Removed.
2822 (struct memory_sink_info) New struct.
2823 (memory_stream_init) Removed.
2824 (memory_stream_read) Removed.
2825 (memory_stream_write) Removed.
2826 (memory_stream_mode) Removed.
2827 (memory_stream_destroy_source) Removed.
2828 (memory_stream_destroy_sink) Removed.
2829 (global var vfm_memory_stream) Removed.
2830 (page_to_disk) Renamed write_active_file_to_disk().
2831 (memory_sink_create) New function.
2832 (memory_sink_write) New function.
2833 (memory_sink_destroy) New function.
2834 (memory_sink_make_source) New function.
2835 (memory_sink_class) New static var.
2836 (memory_source_read) New function.
2837 (memory_source_destroy) New function.
2838 (memory_source_get_cases) New function.
2839 (memory_source_set_cases) New function.
2840 (global var vfm_source_class) New var.
2841 (procedure_write_case) Use new class structures.
2842 (create_case_source) New function.
2843 (case_source_is_complex) New function.
2844 (case_source_is_class) New function.
2845 (create_case_sink) New function.
2847 * vfm.h: (global variable reinit_sysmis) Not used, removed.
2848 (global variable reinit_blanks) Not used, removed.
2849 (global variable init_zero) Not used, removed.
2850 (global variable init_blanks) Not used, removed.
2851 (struct case_source) New struct.
2852 (struct case_source_class) New struct.
2853 (struct case_sink) New struct.
2854 (struct case_sink_class) New struct.
2855 (struct case_stream) Removed.
2857 * vfmP.h: (struct case_list) Moved to var.h.
2859 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
2861 * algorithm.c: (count_equal) New function.
2862 (count_if) New function.
2863 (unique) Add assertions.
2864 (partition) Add assertions.
2865 (is_partitioned) New function.
2866 (copy_if) Add assertions.
2867 (remove_equal) Add assertions.
2868 (lexicographical_compare) Rename lexicographical_compare_3way.
2869 (sort) Add assertions. Rephrase some code.
2870 (is_sorted) New function.
2872 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
2876 * sort.c: Completely rewrite.
2878 * sort.h: Expose interface via struct sort_cases_pgm, not via
2881 * aggregate.c: (sort) New static var.
2882 (cmd_aggregate) Use sort.
2883 (create_sysfile) Ditto.
2884 (aggregate_single_case) Ditto.
2885 (dump_aggregate_info) Ditto.
2886 (agr_00x_end_func) Ditto.
2887 (debug_print) Ditto.
2889 * var.h: (enum SRT_ASCEND) Removed.
2890 (enum SRT_DESCEND) Removed.
2891 (struct sort_cases_proc) Removed.
2892 (struct variable) Remove p.srt member.
2894 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
2896 Get rid of the old, crappy heap structure and replace it by a new,
2897 shiny, C++ STL-like heap structure.
2899 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
2901 * algorithm.c: (push_heap) New function.
2912 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
2914 Increase warning level.
2916 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
2918 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
2920 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
2922 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
2924 * dictionary.c: (dict_create_var) Fix root cause of bug worked
2925 around by previous change log entry.
2927 * compute.c: (lvalue_finalize) Remove workaround from previous
2930 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2932 * compute.c: Fixed a bug where the Format was not getting set for
2933 computed variables (thus causing a crash when SAVEing).
2935 * Added a test to stop this bug ever coming back
2937 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
2939 Got rid of approx.h. In general, replaced all references to
2940 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
2943 * Makefile.am: (pspp_SOURCES) Removed approx.h.
2945 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
2946 test for mag < EPSILON.
2948 * misc.h: Add definition of EPSILON.
2950 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
2952 * vfm.c: (procedure) Add check to prevent recursive call.
2954 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
2956 * Moved the declarations relating to values to their own header file
2959 * Added levene.c and levene.h
2961 * vars-atr.c: Changed the signature of compare_values to
2962 take const * arguments.
2964 * t-test.q: Changed the structure of struct t_test_proc
2965 variables now contain their own group statistics information.
2966 Eventually, t_test_proc might get renamed, because it'd be
2967 applicable to other commands too.
2969 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
2971 * data-out.c: Clean up. Changed interface of convert_*() to take
2972 either a `double' or a `const char *' instead of a `const union
2973 value *'. Update all implementations of those interfaces.
2974 (data_out) Use switch statements instead of a table.
2975 (convert_AHEX) Rewrite.
2977 * format.h: Update comment.
2979 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
2981 * q2c.c: (dump_header) Add an Emacs header line to output files
2982 that makes generated .c files read-only by default, to make it
2983 difficult to accidentally change generated files.
2985 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
2987 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
2988 not bogus a->v.c <=> b->v.c pointer compare.
2989 (compare_freq_alpha_a) Ditto.
2990 (compare_freq_numeric_d) Ditto.
2991 (compare_freq_alpha_d) Ditto.
2993 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
2995 Changed data_out() to store string data directly into a `union
2996 value''s s member, not indirectly into c.
2998 * crosstabs.q: (output_pivot_table) Use format_short() instead of
3000 (table_value_missing) Ditto.
3001 (float_M_suffix) Ditto.
3002 (format_short) New function.
3004 * data-in.h: (data_in_finite_line) Remove inline definition.
3006 * data-list.c: (destroy_dls_var_spec) New function.
3007 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
3008 (data_list_source_destroy_source) Avoid cast.
3009 (struct repeating_data_trns) New field `id_value'. Update
3011 (cmd_repeating_data) Initialize id_value. Use new
3012 repeating_data_trns_free() for freeing REPEATING DATA
3014 (rpd_parse_record) Rewrite support for record ID to be less bogus.
3015 (repeating_data_trns_free) New function.
3017 * data-out.c: (data_out) Change return type to `void' by replacing
3018 error returns by writing a message into the output buffer.
3019 (convert_A) Read from v->s instead of v->c.
3020 (convert_AHEX) Ditto.
3022 * expr-evl.c: Update comment.
3023 (expr_evaluate) Add assertion in OP_STRING case.
3025 * format.h: (macro MAX_FORMATTED_LEN) New macro.
3027 * list.q: (list_cases) Update for new data_out() semantics.
3029 * print.c: (print_trns_proc) Ditto.
3031 * tab.c: (tab_value) Ditto.
3032 (tab_float) Avoid stupid cast.
3034 * var.h: Update comments.
3035 (macro MAX_STRING) New macro.
3036 (macro MAX_ELEMS_PER_VALUE) New macro.
3038 * vars-atr.c: (compare_values) New function.
3040 * vfm.c: (dump_splits) Update for new data_out() semantics.
3042 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
3044 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
3046 (struct crosstab) Rename v[] to vars[]. All references updated.
3047 (hash_table_entry) Replace the hash algorithm and fix a bug at the
3048 same time, which caused the hash value to depend only on a single
3049 value, not all of the variables' values.
3051 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
3053 Clean up struct dictionary's value_cnt usage.
3055 * dictionary.c: Add a function comment to each function.
3056 (struct dictionary) Rename value_cnt to next_value_idx, which more
3057 accurately reflects its meaning. All references updated.
3058 (dict_rename_vars) Add assertion.
3059 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
3061 (dict_get_case_size) New function.
3063 * aggregate.c: (create_sysfile) Use dict_get_case_size().
3065 * get.c: (mtf_read_nonactive_records) Ditto.
3067 * sort.c: (allocate_cases) Ditto.
3068 (write_initial_runs) Ditto.
3072 * vfm.c: (prepare_for_writing) Ditto.
3076 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
3078 Make vfm.c slightly less grotesque.
3080 * vfm.c: (filter_var) Removed.
3081 (filter_index) Removed.
3082 (FILTERED macro) Removed.
3083 (exclude_this_case) New function.
3084 (process_active_file_write_case) Use exclude_this_case() instead
3085 of FILTERED and inline tests.
3086 (procedure_write_case) Ditto.
3087 (setup_filter) Removed.
3088 (open_active_file) Don't call setup_filter().
3089 (close_active_file) Call dict_get_filter() instead of checking
3092 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
3094 * var.h: (struct variable) Update comments.
3096 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
3098 New functions dict_create_var_assert(), dict_lookup_var_assert().
3099 Converted several dict_*_var()/assert pairs into a single
3100 dict_*_var_assert().
3102 * dictionary.c: (dict_create_var_assert) New function.
3103 (dict_lookup_var_assert) New function.
3105 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
3107 Got rid of "struct long_vec", envector(), devector(), etc. Added
3108 two members `init', `reinit' to struct variable as a substitute.
3110 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
3116 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
3119 * autorecode.c: (cmd_autorecode) destvars don't need init.
3121 * compute.c: (lvalue_finalize) Set reinit.
3123 * data-list.c: (fixed_parse_compatible) Don't need init usually.
3124 (dump_fmt_list) Ditto.
3127 * descript.q: (run_z_pass) Don't need init for z-scores.
3129 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
3131 (dict_clone_var) Copy `reinit' member, initialize `init' member.
3133 * glob.c: (init_glob) Remove vec_init() calls.
3135 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
3137 * loop.c: (internal_cmd_loop) Don't need to call envector().
3139 * numeric.c: (cmd_numeric) Ditto.
3141 (cmd_leave) Ditto. Set `init', `reinit' members.
3143 * recode.c: (cmd_recode) Don't need to call envector().
3145 * repeat.c: (internal_cmd_do_repeat) Ditto.
3147 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
3148 (force_create_variable) Removed prototype.
3149 (force_dup_variable) Ditto.
3151 * vector.c: (cmd_vector) Don't need to call envector().
3153 * vfm.c: (reinit_sysmis) Removed.
3154 (reinit_blanks) Removed.
3155 (init_zero) Removed.
3156 (init_blanks) Removed.
3157 (process_active_file_write_case) No need to deal with vectors.
3158 Call clear_temp_case().
3159 (vector_initialization) Rewrite to use `init', `reinit'.
3160 (close_active_file) No need to call vec_clear().
3161 (procedure_write_case) Call clear_temp_case().
3162 (clear_temp_case) New function.
3164 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
3166 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
3169 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
3171 Add auxiliary argument to procedure() interface. Associated small
3172 clean-ups of vfm interface.
3174 * Updated every caller of procedure() and process_active_file() to
3175 reflect modified interface. Simple, ordinary changes not listed
3178 * Updated every function that implements struct case_stream's
3179 `read' function to take a write_case_func and a write_case_data.
3180 Also updated every caller of write_case() to instead call them
3181 through these arguments. In some cases this meant that the extra
3182 args had to be threaded through a couple of extra levels. This
3183 wasn't difficult or interesting so the details won't be given.
3185 * data-list.c: (struct repeating_data_trns) Add members
3186 `write_case', `wc_data' as kluge.
3187 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
3189 (repeating_data_set_write_case) New function.
3191 * data-list.h: New file to declare repeating_data_trns_proc() and
3192 repeating_data_set_write_case().
3194 * inpt-pgm.c: (input_program_source_read) Call
3195 repeating_data_set_write_case() for all the REPEATING DATA
3196 transformations, so that they know where to send their cases.
3197 It's a big kluge. Also kluge in END CASE.
3198 (end_case_trns_proc) Never called anymore, but we still need it,
3201 * sort.c: (read_sort_output) Update to match struct case_stream
3204 * vfm.c: (struct write_case_data) New structure.
3205 (proc_func) Removed.
3206 (virt_proc_func) Removed.
3207 (begin_func) Removed.
3208 (virt_begin_func) Removed.
3210 (write_case) Removed.
3211 (procedure) Added an auxiliary parameter to each function pointer
3212 argument's prototype. Added an auxiliary data parameter.
3214 (process_active_file) Ditto.
3215 (process_active_file_write_case) Pass aux data along.
3216 (close_active_file) Ditto.
3217 (procedure_write_case) Ditto.
3218 (SPLIT_FILE_procfunc) Ditto.
3220 * vfm.h: (typedef write_case_data) New.
3221 (typedef write_case_func) New.
3222 (struct case_stream) Add parameters to `read' member prototype.
3224 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
3226 * t-test.q: Added calculations for independent samples. (But no Levene
3229 * Makefile.am: Moved q_sources_c into own variable
3231 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
3233 Miscellaneous cleanups.
3235 * Change unused to UNUSED in many source files to reflect modified
3236 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
3237 __CYGWIN32__, __unix__, and unix not to assume that they're
3238 defined to a nonzero value. Change use of __attribute__ to use
3239 NO_RETURN or PRINTF_FORMAT instead.
3241 * alloc.h: Move definitions for local_alloc(), local_free() here
3242 from ../pref.h.orig and simplify.
3244 * expr-evl.c: Instead of working differently based on PAGED_STACK,
3245 use a pool allocator unconditionally.
3246 (CHECK_STRING_SPACE) Removed.
3247 (ALLOC_STRING_SPACE) Removed.
3248 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
3251 * expr-opt.c: (dump_expression) Allocate string pool.
3253 * expr-prs.c: (expr_free) Free string pool.
3255 * pool.c: (pool_destroy) This pool must be removed from its
3256 parent's list of gizmos, not from its own. Use free_all_gizmos().
3257 (pool_clear) New function.
3258 (free_all_gizmos) New function.
3259 (pool_alloc) Use space in empty block after this one if any.
3260 (pool_release) Only empty out blocks, don't actually free() them.
3262 * print.c: Get rid of PAGED_STACK special case by always
3263 dynamically allocating line buffers.
3264 (struct print_trns) Always include the `line' member.
3265 (internal_cmd_print) Always initialize the `line' member.
3266 (alloc_line) Always allocate memory for `line'.
3267 (print_trns_proc) Always initialize buf from `line' member.
3268 (print_trns_free) Always free `line' memory.
3270 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
3273 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
3275 * flip.c: Fixed crash from FLIP when a numeric variable is
3276 specified on NEWNAMES and a large value is used, and a couple of
3277 other minor bugs besides.
3278 (struct varname) Make name a 9-character fixed-size array
3279 instead of a 1-character variable size array.
3280 (make_new_var) Allow digits in variable names.
3281 (flip_stream_write) Limit numeric values to 8 characters and
3282 format system missing and very large and small values more
3285 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3287 * command.c: Fixed test on command return status for the correct
3288 value, which had been causing a crash under certain invalid input.
3290 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
3292 * t-test.q: Added calculations for the one sample variant of the T-TEST
3294 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
3296 * tab.c: (render_strip) Fix bug that sometimes caused joined text
3297 in joined cells to be rendered outside box boundaries.
3299 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
3301 * random.c (rng_create): Fixed seeding so that it gets reseeded after
3302 SET seed=xx has been called.
3304 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
3306 * random.c (rng_get_double): Fix always-returning-zero bug in my
3307 preferred way, and at the same time make sure rounding doesn't
3310 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
3312 * html.c: (change_attributes) Dead code, removed.
3313 (escape_string) Eliminate code to call change_attributes() that
3314 never actually called it.
3315 (output_tab_table) Get rid of dependence on tab_hit
3316 and struct tab_joined_cell's hit member, which are abominations.
3318 * tab.c: (tab_output_text) Don't call
3319 d->class->text_set_font_by_name if it's a null pointer.
3320 (macro UNROLL_LOOP) Eliminate.
3321 (macro UNROLL_3_LOOPS) Eliminate.
3322 (tabi_render) Rewrite not to use the above macros.
3324 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
3326 Start working on a new output driver system, one that doesn't suck
3327 so much, by adding a "device-independent" output driver. The idea
3328 is to write out only a single output stream, then use separate
3329 processes to translate them into whatever formats we want. This
3330 is similar to how "groff" works with its various output drivers
3331 (grops, grotty, grodvi, ...).
3333 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
3335 * list.q: (write_all_headers) Stub out devind class.
3337 (determine_layout) Ditto.
3340 * output.c: (outp_init) Add devind class.
3342 * devind.c: New file.
3344 * devind.h: New file.
3346 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
3348 * frequencies.q: (hash_value_alpha) Fixed up the previous change
3349 to use the proper string length.
3351 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
3353 * Fixed bug where FREQ would crash on alpha values
3355 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
3357 * Removed bletcherous alloca() workarounds for AIX from top of
3358 many files. AIX can use the alternative alloca() implementation
3361 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
3363 * ascii.c: (ascii_option) Fix implementation of headers option.
3365 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
3367 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
3368 multiple blank lines into one.
3369 (struct ascii_driver_ext) Add squeeze_blank_lines option.
3370 (ascii_preopen_driver) Initialize squeeze_blank_lines.
3371 (static var option_tab) Add squeeze entry.
3372 (ascii_option) Set squeeze_blank_lines.
3373 (output_lines) Implement squeezing blank lines.
3375 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
3377 * Removed redundant code from output.h
3379 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
3381 Dictionary classes: each variable is "ordinary", "system", or
3384 * var.h: (enum dict_class) New enum.
3386 * vars-prs.c: (dict_class_from_id) New function.
3387 (dict_class_to_name) New function.
3389 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
3391 * var.h: (struct freq_tab_set) Removed (not used).
3393 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
3395 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
3397 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
3399 * stats.c: (hypercube) Rename pow4(). All references updated.
3401 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
3403 * rename-vars.c: (cmd_rename_variables) Rewritten.
3404 (compare_name) Removed.
3406 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
3408 var_set feature, and code taking advantage of it.
3410 * crosstabs.q: (static var var_dict) Removed.
3411 (static var variables) New variable.
3412 (static var variables_cnt) New variable.
3413 (cmd_crosstabs) Free variables instead of var_dict.
3414 (internal_cmd_crosstabs) Initialize and use variables,
3415 variables_cnt instead of var_dict.
3416 (free_var_dict) Removed.
3417 (crs_custom_tables) Use var_set instead of a copied dictionary.
3418 (crs_custom_variables) Set up variables, variables_cnt instead of
3420 [DEBUGGING] (debug_print) Ditto.
3422 * means.q: (mns_custom_tables) Use var_set instead of a copied
3425 * vars-prs.c: (parse_vs_variable) New function.
3426 (parse_dict_variable) Rewritten.
3427 (parse_variable) Rewritten.
3428 (parse_variables) Renamed parse_var_set_vars(), rewritten.
3429 (parse_variables) New function in terms of parse_var_set_vars().
3430 Now requires its first argument to be non-null. All references
3431 that passed a null pointer updated to pass default_dict instead.
3432 (macro id_dict) Removed.
3433 (parse_DATA_LIST_vars) Add assertions.
3434 (parse_mixed_vars) Ditto.
3435 (struct var_set) New structure.
3436 (var_set_get_cnt) New function.
3437 (var_set_get_var) New function.
3438 (var_set_lookup_var) New function.
3439 (var_set_destroy) New function.
3440 (dict_var_set_get_cnt) New function.
3441 (dict_var_set_get_var) New function.
3442 (dict_var_set_lookup_var) New function.
3443 (dict_var_set_destroy) New function.
3444 (var_set_create_from_dict) New function.
3445 (struct array_var_set) New structure.
3446 (array_var_set_get_cnt) New function.
3447 (array_var_set_get_var) New function.
3448 (array_var_set_lookup_var) New function.
3449 (array_var_set_destroy) New function.
3450 (var_set_create_from_array) New function.
3452 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
3453 instead of parse_variables(NULL, ...) in output code.
3455 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
3457 Change inp_init from a 2-bit vector to an ordinary array.
3458 Initialize it all in cmd_end_input_program() instead of in
3461 * inpt-pgm.c: (enum value_init_type) New enum.
3462 (global var inp_init) Change to `enum value_init_type *', make
3464 (inp_init_size) Removed.
3465 (inp_nval) Change to `size_t', make static.
3466 (cmd_input_program) Don't initialize inp_init or inp_init_size.
3467 (cmd_end_input_program) Initialize inp_init, inp_nval.
3468 (init_case) Rewrite.
3469 (clear_case) Rewrite.
3471 * inpt-pgm.h: Removed.
3473 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
3475 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
3476 Colin Plumb hash. It is simpler and should better resist
3478 (hsh_hash_string) Ditto.
3480 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
3482 * get.c: (export_write_case_func) Remove debug printing code.
3484 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
3486 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
3488 (save_write_case_func) Use &trns->h instead of cast.
3489 (cmd_export) Use &t->h instead of cast.
3491 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
3493 Moved vectors into the dictionary.
3495 * var.h: (struct vector) Moved here from vector.h. `index' member
3496 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
3499 * vector.h: Removed.
3501 * vector.c: (global var vec) Removed.
3502 (global var nvec) Removed.
3503 (cmd_vector) Rewritten.
3504 (find_vector) Removed.
3506 * dictionary.c: (dict_create_vector) New function.
3507 (dict_get_vector) New function, replaces reading global vec[]
3509 (dict_get_vector_cnt) New function, replaces reading global nvec
3511 (dict_lookup_vector) New function, replaces find_vector().
3512 (dict_clear_vectors) New function.
3514 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
3516 Start to move away from `struct variable' p `union' member to void
3519 * var.h: (struct variable) Add `aux' member.
3521 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
3523 Get rid of struct variable `foo' member.
3525 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
3527 (frq_custom_variables) Ditto.
3528 (frq_custom_grouped) Ditto.
3530 * get.c: (struct save_trns) Change `var' member from `int *' to
3531 `struct variable **'.
3532 (cmd_save_internal) Use aux instead of foo.
3533 (save_trns_proc) Use revised `var' member.
3534 (static var mtf_seq_no) Renamed mtf_seq_num.
3535 (static var mtf_seq_nums) New static var.
3536 (cmd_match_files) Initialize mtf_seq_nums.
3537 (mtf_free) Free mtf_seq_nums.
3538 (mtf_processing) Use mtf_seq_nums instead of foo.
3539 (mtf_merge_dictionary) No need to initialize mv->foo.
3540 (cmd_export) Use aux instead of foo. Use revised `var' member.
3541 (mns_custom_tables) Don't use foo to check for duplicates, that's
3542 what PV_NO_DUPLICATE is for.
3544 * var.h: (struct variable) Remove `foo' member.
3545 (struct frequencies_proc) New member.
3547 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
3549 Clean up COMPUTE and IF.
3551 * compute.c: More or less rewrite the darn thing.
3552 (struct compute_trns) Rename and reorder and add and delete
3554 (cmd_compute) Rewrite.
3555 (compute_num) Make conditional on test expression. Now used for
3556 both COMPUTE and IF.
3557 (compute_num_vec) Ditto.
3558 (compute_str) Ditto.
3559 (compute_str_vec) Ditto.
3562 (if_num_vec) Removed.
3564 (if_str_vec) Removed.
3565 (parse_target_expression) Renamed parse_rvalue_expression(),
3567 (new_trns) Renamed compute_trns_create(), rewritten.
3568 (delete_trns) Removed.
3569 (free_trns) Renamed compute_trns_free(), rewritten.
3570 (struct lvalue) New structure.
3571 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
3572 (lvalue_get_type) New function.
3573 (lvalue_is_vector) New function.
3574 (lvalue_finalize) New function.
3575 (lvalue_destroy) New function.
3577 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
3579 * command.def: Disallow MODIFY VARS in input mode, so that
3580 variables can't get dropped and confuse cmd_end_input_program()'s
3581 attempt to fill inp_init[].
3583 * modify-vars.c: (static var forward_positional_ordering) New
3585 (struct var_modification) Entirely changed.
3586 (rearrange_dict) Interface changed, rewritten.
3587 (cmd_modify_vars) Deal with modified struct var_modification, much
3589 (struct var_renaming) New structure.
3590 (compare_var_renaming_by_new_name) New function.
3591 (validate_var_modification) New function.
3593 * var.h: (struct modify_vars_proc) Removed.
3594 (struct variable) Removed member p.mfv.
3596 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
3598 Make EVALUATE a valid command whether we're debugging or not, so
3599 that `make check' can succeed regardless of whether debugging is
3602 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
3604 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
3606 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
3608 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
3609 statement by a simple if test.
3611 * dfm.c: (dfm_get_record) Add assertion.
3613 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
3615 For each file x.c, move #include "x.h" to the very top of the
3616 include list, to catch x.h failing to include the proper headers.
3618 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
3620 * algorithm.c: (find) New function.
3621 (remove_equal) New function.
3622 (set_difference) New function.
3623 (adjacent_find_equal) New function.
3624 [TEST_UNIQUE] Removed test case.
3625 (copy_if) Find end test.
3627 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
3629 * dictionary.c: (dict_get_case_weight) New convenience function.
3631 * aggregate.c: (accumulate_aggregate_info) Use
3632 dict_get_case_weight().
3634 * frequencies.q: (calc_general) Ditto.
3635 (calc_integer) Ditto.
3638 * t-test.q: (groups_calc) Ditto.
3641 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
3643 * glob.c: (global var default_dict) Change from `struct
3644 dictionary' to `struct dictionary *'. All references changed.
3645 (init_glob) Initialize default_dict with dict_create().
3647 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
3649 struct dictionary now made opaque. All related functions:
3651 * get.c: (rename_variables) Removed.
3652 (dict_delete_run) Removed.
3654 * temporary.c: (copy_variable) Removed.
3655 (new_dictionary) Removed.
3656 (save_dictionary) Removed.
3657 (restore_dictionary) Removed.
3658 (free_dictionary) Removed.
3660 * vars-atr.c: (clear_default_dict) Removed.
3661 (find_variable) Removed.
3662 (find_dict_variable) Removed.
3663 (create_variable) Removed.
3664 (delete_variable) Removed.
3665 (common_init_stuff) Removed.
3666 (init_variable) Removed. Updating of inp_init moved into
3667 cmd_end_input_program().
3668 (replace_variable) Removed.
3669 (rename_variable) Removed.
3670 (clear_variable) Removed.
3671 (dup_variable) Removed.
3673 * vars-prs.c: (is_varname) Removed.
3674 (is_dict_varname) Removed.
3675 (fill_all_vars) Removed.
3677 * vector.c: (find_vector) Removed.
3679 * weight.c: (stop_weighting) Removed.
3681 * dictionary.c: New file.
3682 (dict_create) New, replaces new_dictionary().
3683 (dict_clone) New, replaces save_dictionary() and
3684 restore_dictionary().
3685 (dict_clear) New, replaces clear_default_dict().
3686 (dict_destroy) New, replaces free_dictionary().
3687 (dict_get_var_cnt) New function, replaces references to
3689 (dict_get_var) New function, replaces references to dict->var[i].
3690 (dict_get_vars) New function, replaces fill_all_vars().
3691 (dict_create_var) New, replaces create_variable(). Interface
3692 drops `type' parameter, using a zero `width' to designate numeric.
3693 (dict_clone_var) New, replaces dup_variable().
3694 (dict_rename_var) New, replaces rename_variable().
3695 (dict_lookup_var) New, replaces find_variable(),
3696 find_dict_variable(), is_varname().
3697 (dict_contains_var) New function.
3698 (compare_variable_dblptrs) New function.
3699 (dict_delete_var) New function, replaces clear_variable().
3700 (dict_delete_vars) New function, replaces dict_delete_run().
3701 (dict_reorder_vars) New function.
3702 (dict_rename_vars) New function, replaces rename_variables().
3703 (dict_get_weight) New function, replaces reading dict->weight_var.
3704 (dict_set_weight) New function, replaces writing dict->weight_var
3705 or calling stop_weight(dict).
3706 (dict_get_filter) New function, replaces reading dict->filter_var.
3707 (dict_set_filter) New function, replaces writing dict->filter_var.
3708 (dict_get_case_limit) New function, replaces reading dict->N.
3709 (dict_set_case_limit) New function, replaces writing dict->N.
3710 (dict_get_value_cnt) New function, replaces reading dict->nval.
3711 (dict_compact_values) New function, replaces a loop that was
3712 replicated in several places.
3713 (dict_get_split_vars) New function, replaces reading dict->splits.
3714 (dict_get_split_cnt) New function, replaces reading
3716 (dict_set_split_vars) New function, replaces writing dict->splits.
3717 (dict_get_label) New function, replaces reading dict->label.
3718 (dict_set_label) New function, replaces writing dict->label.
3719 (dict_get_documents) New function, replaces reading
3721 (dict_set_documents) New function, replaces writing
3724 All references to above functions updated.
3726 * aggregate.c: (cmd_aggregate) Copy file label and documents from
3727 old dictionary to new by hand, because dict_create() can't do it
3728 itself. Use dict_set_documents(), dict_set_split_vars().
3730 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
3731 calling dict_destroy().
3733 * data-list.c: (dls_var_spec) Remove `type' member, replace by
3735 (fixed_parse_compatible) Some slightly nontrivial changes for
3737 (dump_fmt_list) Ditto.
3740 * file-type.c: (create_col_var) Ditto.
3742 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
3743 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
3744 (rename_variables) Use dict_rename_vars().
3745 (mtf_merge_dictionary) Use dict_get_documents(),
3746 dict_set_documents(), dict_compact_values().
3748 * pfm-read.c: (read_variables) Deal with changes to weighting.
3750 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
3751 is_varname() in output code.
3753 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
3754 other dictionary functions.
3756 * title.c: (add_document_line) Use dict_get_documents(),
3757 dict_set_documents().
3759 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
3760 reset default_handle by hand. dict_clear() will clear vectors so
3761 there's no need for that by hand.
3763 * vfm.c: (close_active_file) Move call to finish_compaction()
3764 earlier, so that we can do the compaction as a single step using
3765 dict_compact_values(). Use dict_clear_vectors().
3766 (finish_compaction) Use dict_delete_var(), dict_compact_values().
3768 Some functions don't have replacements:
3770 * vars-atr.c: (force_create_variable) Removed. All references
3771 updated to dict_create_var() followed by an assertion.
3772 (force_dup_variable) Removed. All references updated to
3773 dict_clone_var() followed by an assertion.
3775 * weight.c: (update_weighting) Removed. No longer necessary, so
3776 all references removed.
3778 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
3782 * aggregate.c: Eliminate separation of weighted and unweighted
3783 case. It made the code too obscure and I doubt it was actually
3784 faster. Instead, all code uses the "weighted" code, because
3785 that's a generalization of the "unweighted" code.
3788 (parse_aggregate_functions) No need to set FWEIGHT.
3789 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
3790 (dump_aggregate_info) Ditto.
3791 (initialize_aggregate_info) No need for special plain_function
3792 that gets rid of FWEIGHT option.
3794 * aggregate.c: Get rid of approximations.
3795 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
3797 (aggregate_single_case) Don't use approx_ne().
3799 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
3801 * ascii.c (ascii_line_width): Dead code, removed.
3803 * postscript.c (ps_line_width): Ditto.
3805 * q2c.c (xrealloc): Ditto.
3807 * count.c (internal_cmd_count): Ditto.
3809 * means.q (validate_dependent_endpoint): Ditto.
3811 * set.q: (cmd_gset) Ditto.
3813 * weight.c: [0] (weight_trns_proc) Ditto.
3815 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
3817 Make the code -Wmissing-prototypes clean.
3819 * Makefile.am (version.c): Add #include "version.h".
3821 * ascii.c: (ascii_open_global) Make static.
3822 (ascii_close_page) Ditto.
3823 (ascii_font_sizes) Ditto.
3824 (ascii_postopen_driver) Ditto.
3825 (ascii_close_driver) Ditto.
3826 (ascii_option) Ditto.
3827 (ascii_open_page) Ditto.
3828 (ascii_line_horz) Ditto.
3829 (ascii_line_vert) Ditto.
3830 (ascii_line_intersection) Ditto.
3832 (ascii_polyline_begin) Ditto.
3833 (ascii_polyline_point) Ditto.
3834 (ascii_polyline_end) Ditto.
3835 (ascii_text_set_font_by_name) Ditto.
3836 (ascii_text_set_font_by_position) Ditto.
3837 (ascii_text_set_font_by_family) Ditto.
3838 (ascii_text_get_font_name) Ditto.
3839 (ascii_text_get_font_family) Ditto.
3840 (ascii_text_set_size) Ditto.
3841 (ascii_text_get_size) Ditto.
3842 (ascii_text_metrics) Ditto.
3843 (ascii_text_draw) Ditto.
3844 (ascii_close_page) Ditto.
3846 * cmdline.h: New header for parse_command_line(). Used where
3849 * command.c: Move prototypes for cmd_*() functions to command.h.
3851 * command.h: Prototypes for cmd_*() functions moved here from
3854 * crosstabs.q: (gamma_int) Ditto.
3856 * file-handle.h: Add fh_init_files() prototype.
3858 * getline.c: (welcome) Ditto.
3860 * glob.h: New header for init_glob(). Used where appropriate.
3862 * hash.c: (comparison_helper) Ditto.
3864 * html.c: (html_open_global) Ditto.
3865 (html_close_global) Ditto.
3866 (html_preopen_driver) Ditto.
3867 (html_postopen_driver) Ditto.
3868 (html_close_driver) Ditto.
3869 (html_option) Ditto.
3870 (html_open_page) Ditto.
3871 (html_close_page) Ditto.
3872 (html_submit) Ditto.
3874 * inpt-pgm.c: (input_program_source_read) Ditto.
3876 * output.c: (find_defn_value) Ditto.
3877 (destroy_list) Ditto.
3879 * pfm-read.c: (read_int) Ditto.
3881 * postscript.c: (ps_open_global) Ditto.
3882 (ps_close_global) Ditto.
3883 (ps_font_sizes) Ditto.
3884 (ps_preopen_driver) Ditto.
3885 (ps_postopen_driver) Ditto.
3886 (ps_close_driver) Ditto.
3888 (ps_open_page) Ditto.
3889 (ps_close_page) Ditto.
3890 (ps_line_horz) Ditto.
3891 (ps_line_vert) Ditto.
3892 (ps_line_intersection) Ditto.
3894 (ps_polyline_begin) Ditto.
3895 (ps_polyline_point) Ditto.
3896 (ps_polyline_end) Ditto.
3897 (ps_text_set_font_by_name) Ditto.
3898 (ps_text_set_font_by_position) Ditto.
3899 (ps_text_set_font_family) Ditto.
3900 (ps_text_get_font_name) Ditto.
3901 (ps_text_get_font_family) Ditto.
3902 (ps_text_set_size) Ditto.
3903 (ps_text_get_size) Ditto.
3904 (ps_text_metrics) Ditto.
3905 (ps_text_draw) Ditto.
3907 * q2c.c: (finish_up) Ditto.
3916 (find_symbol) Ditto.
3919 (force_string) Ditto.
3921 (match_token) Ditto.
3924 (parse_setting) Ditto.
3925 (parse_specifier) Ditto.
3926 (parse_specifiers) Ditto.
3927 (parse_subcommand) Ditto.
3928 (dump_specifier_vars) Ditto.
3930 (make_identifier) Ditto.
3931 (dump_declarations) Ditto.
3932 (dump_specifier_init) Ditto.
3933 (dump_vars_init) Ditto.
3935 (dump_specifier_parse) Ditto.
3936 (dump_subcommand) Ditto.
3937 (dump_parser) Ditto.
3938 (dump_header) Ditto.
3940 (recognize_directive) Ditto.
3942 * recode.c: (string_to_long) Ditto.
3944 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
3946 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
3949 * sort.c: (sort_stream_read) Ditto.
3950 (sort_stream_mode) Ditto.
3952 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
3954 * algorithm.c (binary_search): Fix comparison.
3956 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
3958 * algorithm.c: (binary_search) Fix assertion.
3960 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
3962 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
3964 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
3966 * sort.c: (compare_case_lists) Rewrite.
3968 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
3970 * quicksort.c: Removed (not used).
3972 * quicksort.h: Removed (not used).
3974 * sort.c: Removed blp_quicksort() prototype.
3976 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
3978 * postscript.c: (int_2_compare) Rewrite.
3979 (compare_line) Rewrite.
3981 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
3983 * matrix-data.c (compare_factors) Use lexicographical_compare()
3985 (compare_doubles) New function.
3987 * algorithm.c: (lexicographical_compare) New algorithm.
3989 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
3991 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
3993 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
3995 * expr-prs.c: (cmp_func) Removed.
3996 (parse_function) Use binary_search() algorithm.
3997 (compare_functions) New function.
3998 (init_func_tab) Use sort() algorithm.
4000 * algorithm.c: (binary_search) New algorithm.
4002 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
4004 * descript.q: (display) Use sort() algorithm instead of qsort().
4005 (compare_func) Removed.
4006 (descriptives_compare_variables) New function.
4008 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
4010 Get rid of AVL trees. Hashes are more appropriate for everything
4013 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
4019 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
4021 Much code can be clarified by using C++ STL-like algorithms. Not
4022 all uses of these algorithms are listed below, only the ones where
4023 the change to an algorithm was the only change of interest.
4025 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
4027 * algorithm.c: New file.
4029 * algorithm.h: New file.
4031 * modify-vars.c: (static var forward) Removed.
4032 (static var positional) Removed.
4033 (compare_variables) Removed.
4034 (struct ordering) New.
4035 (cmd_modify_vars) Use sort() algorithm.
4036 (compare_variables_given_ordering) New function.
4037 (rearrange_dict) Use sort() algorithm.
4039 * sysfile-info.c: (cmd_display) Use sort() algorithm.
4040 (cmp_var_by_name) Removed.
4042 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
4044 Make file handles use a hash table.
4046 * file-handle.q: (files) Change to hash table, make static.
4047 (cmd_file_handle) Use hash table functions.
4048 (fh_get_handle_by_filename) Ditto.
4049 (fh_get_handle_by_name) Ditto.
4050 (hash_file_handle) New function.
4051 (cmp_file_handle) Rewrite.
4052 (fh_init_files) Use hash table functions.
4054 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
4056 Clean up FREQUENCIES.
4058 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
4060 * frequencies.q: Remove a lot of old #if'd out code at the end.
4061 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
4062 or calc_weight(). Initialize percentile_values.
4063 (calc) New function based on calc_weight() from frequencies.g.
4064 (precalc) Use hash functions.
4065 (static var comparison_func) Removed.
4066 (static var comparison_param) Removed.
4067 (comparison_helper) Removed.
4068 (get_freq_comparator) New function.
4069 (not_missing) New function.
4071 (postprocess_freq_tab) Use hash table functions, algorithms,
4072 get_freq_comparator(). Rewrite.
4073 (cleanup_freq_tab) Rephrase.
4074 (add_percentile) Clean up spacing.
4075 (hash_value_numeric) New function.
4076 (hash_value_alpha) New function.
4077 (compare_value_numeric_a) Rewrite.
4078 (compare_value_alpha_a) Rewrite.
4079 (compare_value_numeric_d) Rewrite.
4080 (compare_value_alpha_d) Rewrite.
4081 (compare_freq_numeric_a) Rewrite.
4082 (compare_freq_alpha_a) Rewrite.
4083 (compare_freq_numeric_d) Rewrite.
4084 (compare_freq_alpha_d) Rewrite.
4085 (calc_stats) Clean up mode, percentiles, max.
4086 (dump_statistics) Clean up spacing.
4088 * frequencies.g: Removed.
4090 * var.h: (struct freq_tab) Change `data' to hash table.
4092 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
4094 * file-handle.h: Remove declaration of global variable `files',
4095 which wasn't used anywhere.
4097 * postscript.c: (add_encoding) Remove superfluous cast.
4100 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
4103 * temporary.c: [0] (display_tree) Removed.
4105 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
4107 Implement a new random number generator based on the alleged RC4
4110 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
4113 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
4114 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
4116 (static var V[]) Removed.
4117 (static var Y) Removed.
4118 (static var X2) Removed.
4119 (setup_randomize) Removed.
4121 (rand_uniform) Removed.
4122 (rand_normal) Removed.
4123 (struct rng) New structure.
4124 (rng_create) New function.
4125 (rng_destroy) New function.
4126 (swap_byte) New static function.
4127 (rng_seed) New function.
4128 (rng_get_bytes) New function.
4129 (rng_get_int) New function.
4130 (rng_get_unsigned) New function.
4131 (rng_get_double) New function.
4132 (rng_get_double_normal) New function.
4133 (pspp_rng) New function.
4135 * random.h: Sync up to random.c.
4137 * sample.c: (struct sample_trns) Make `frac' unsigned and a
4138 fraction of UINT_MAX, not 65536.
4139 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
4142 * vfm.c: (open_active_file) No need to call setup_randomize() any
4145 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
4147 Change dictionary name indexes to use hash tables instead of AVL
4150 * crosstabs.q: (free_var_dict) Use hash tables.
4151 (crs_custom_tables) Ditto.
4152 (calc_general) Ditto.
4153 (compare_table_entry) Rewrite.
4154 (enum_var_values) Reorder parameters. All references updated.
4157 * get.c: (rename_variable) Use hash tables.
4158 (mtf_merge_dictionary) Ditto.
4160 * glob.c: (init_glob) Use hash tables.
4161 (cmp_variable) Removed.
4163 * means.q: (mns_custom_tables) Use hash tables.
4165 * modify-vars.c: (rearrange_dict) Use hash tables.
4167 * rename-vars.c: (cmd_rename_variables) Use hash tables.
4169 * sfm-read.c: (read_header) Use hash tables.
4170 (read_variables) Ditto.
4172 * temporary.c: (new_dictionary) Use hash tables.
4173 (save_dictionary) Ditto.
4174 (restore_dictionary) Ditto.
4176 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
4177 hash table `name_tab'.
4179 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
4180 [DEBUGGING] (dump_var_tree) Removed.
4181 (find_variable) Use hash tables.
4182 (find_dict_variable) Ditto.
4183 (common_init_stuff) Ditto.
4184 (rename_variable) Ditto.
4185 (clear_variable) Ditto. Also, remove debug code.
4186 (dup_variable) Use hash tables.
4188 * vars-prs.c: (fill_all_vars) Use hash tables.
4189 (is_dict_varname) Ditto.
4190 (parse_dict_variable) Ditto.
4192 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
4194 Change value labels to use hash tables instead of AVL trees, and
4195 change value labels into an ADT.
4197 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
4199 * value-labels.c: New file.
4201 * value-labels.h: New file.
4203 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
4204 Get rid of a stupid use of goto.
4206 * autorecode.c: (compare_alpha_value) Rewrite.
4207 (hash_alpha_value) Ditto.
4208 (compare_numeric_value) Rewrite.
4209 (hash_numeric_value) Ditto.
4211 * frequencies.q: (dump_full) Use value label ADT.
4213 * pfm-read.c: (read_value_label) Use value label ADT.
4215 * pfm-write.c: (write_value_labels) Use value label ADT.
4217 * sfm-read.c: (read_variables) Use value label ADT.
4218 (read_value_labels) Rewrite.
4220 * sfm-write.c: (write_value_labels) Rewrite.
4222 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
4223 (display_variables) Ditto.
4224 (describe_variable) Ditto.
4226 * t-test.q: (print_t_groups) Use value label ADT.
4228 * temporary.c: (copy_variable) Use value label ADT.
4229 (free_dictionary) Ditto.
4231 * val-labs.c: (verify_val_labs) Use value label ADT.
4233 (debug_print) Ditto.
4234 (val_lab_cmp) Removed.
4235 (inc_ref_count) Removed.
4236 (copy_value_labels) Removed.
4238 * var.h: (struct value_label) Removed.
4239 (struct variable) Change AVL tree `val_lab' into hash table
4242 * vars-atr.c: (init_variable) Use value label ADT.
4243 (clear_variable) Ditto.
4244 (free_value_label) Removed.
4245 (free_val_lab) Removed.
4246 (get_val_lab) Removed.
4247 (compare_variables) New function.
4248 (hash_variable) New function.
4250 * vfm.c: (dump_splits) Use value label ADT.
4252 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
4254 Add to the hash table interface.
4256 * hash.c: (hsh_hash_bytes) Add assertion.
4257 (hsh_hash_string) Ditto.
4261 (hsh_create) Ditto. Also make minimum `size'.
4262 (hsh_destroy) Rephrase.
4263 (sort_nulls_last) Removed.
4264 (not_null) New function.
4266 (comparison_helper) Ditto.
4267 (hsh_sort) Rewritten.
4268 (hsh_data_copy) New function.
4269 (hsh_sort_copy) Ditto.
4271 (hsh_replace) Ditto.
4272 (hsh_hash_double) Ditto.
4273 (hsh_delete) Fix stupid bug.
4275 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4276 * added a calculation of the mode to FREQUENCIES
4278 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4280 * moved (un)defs of DEBUGGING to config.h
4282 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
4284 * groff-font.c: (add_kern) Fix indentation.
4285 (add_kern) Use & instead of % to take power-of-2 modulus.
4286 (font_get_kern_adjust) Likewise.
4288 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
4290 * autorecode.c: (recode) Replace stupid use of memcpy() by
4292 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
4293 (hash_numeric_value) Ditto.
4294 (autorecode_proc_func) pool_strdup() was wrong here because the
4295 source string was not null-terminated. Use new pool_strndup()
4298 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
4299 use of hsh_iterator_init().
4301 * data-in.c: (parse_N) Initialize i->v->f.
4303 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
4306 * groff-font.c: Use power-of-2 hash table sizes, not prime.
4307 (groff_read_font) Don't call hsh_next_prime(). Don't call
4309 (static var hash) Remove `size_p', `max_used' members.
4310 (font_char_name_to_index) Don't call hsh_next_prime(). Use
4311 hsh_hash_string() instead of hashpjw(), & instead of %.
4312 (default_font) Don't call hsh_next_prime().
4314 * pool.c: (pool_strndup) New function.
4315 (pool_strdup) Reimplement in terms of pool_strndup.
4317 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
4319 (hash_ps_encoding) Use hsh_hash_string().
4320 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
4321 (hash_filename2font) Use hsh_hash_string().
4323 * som.c: Add #include <stdlib.h>.
4325 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
4326 (by destroying its pool).
4328 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
4330 Miscellaneous hash table code cleanup:
4332 * hash.h: (struct hsh_table) Moved into hash.c.
4333 (hsh_count) Ditto, and transformed into function.
4334 (hsh_compare_func) New typedef, used for defining otherwise-long
4335 function types here and in hash.c
4336 (hsh_hash_func) Ditto.
4337 (hsh_free_func) Ditto.
4339 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
4340 `table' to `entries'. Removed `mp'. All references updated.
4341 (hsh_clear) Don't shrink entries array; if the hash was this big
4342 once, it probably will be again.
4343 (hsh_rehash) Made static.
4344 (force_hsh_insert) Renamed hsh_force_insert.
4345 (force_hsh_find) Renamed hsh_force_find.
4347 Made hash table sizes powers of 2, because that's fine with any
4348 reasonable hash function and because taking a power-of-2 modulus
4349 is faster than any other:
4351 (hsh_prime_tab) Removed;
4352 (hsh_next_prime) Ditto.
4353 (next_power_of_2) New function.
4354 (hsh_create) Use next_power_of_2.
4355 (hsh_rehash) Use & instead of %.
4357 Cleaned up hsh_sort:
4359 (internal_comparison_fn) Removed.
4360 (sort_nulls_last) New function.
4361 (hsh_sort) Removed second parameter, switched to using the new
4362 quicksort() function from quicksort.h to avoid using nasty need
4363 for static variables with qsort(). All references updated.
4365 Changed the hash functions offered, because there are better hash
4366 functions than the ones we had, and cleaned up the names to boot:
4368 * hash.c: (hashpjw_d) Removed.
4370 (hsh_hash_bytes) New function.
4371 (hsh_hash_string) New function.
4372 (hsh_hash_int) New function.
4374 Improved the hash table iteration interface:
4376 * hash.h: (hsh_iterator_init) Removed.
4377 (struct hsh_iterator) Removed `init' member, change `next' to
4380 * hash.c: (hsh_foreach) Removed. All references updated to use
4381 hsh_first/hsh_next instead.
4382 (hsh_first) New function. Notably, unlike hsh_foreach() it does
4383 not treat a null pointer as an empty hash table.
4384 (hsh_next) New function.
4386 Made deletion possible, though slow:
4388 * hash.c: (locate_matching_entry) New function.
4389 (hsh_find) Use locate_matching_entry().
4390 (hsh_delete) New function also using locate_matching_entry().
4391 (hsh_force_delete) New function.
4393 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
4395 * quicksort.c: New file implementing a sort routine with a
4396 interface better than qsort() because it passes a user-provided
4397 parameter to the sort routine.
4399 * Makefile.am: Add quicksort.c, quicksort.h.
4401 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
4403 * All source files: Get rid of nasty special cases for Checker,
4404 which is pretty obsolete now.
4406 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
4408 * Fixed a bug apparent when using the FREQUENCIES command with the
4409 html driver. The html driver was incorrectly trying to display
4412 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
4414 * Makefile.am: Reorganized. Put locale dir in version.c instead
4415 of passing it to each compile command. Only put local gmp libs in
4416 LD_ADD if not installed on system. Remove `boast' target.
4418 * All source files: struct and union typedefs eliminated.
4419 `sizeof type' replaced by `sizeof object' where practical. Moved
4420 `unused' qualifiers from start to end of declarations for gcc
4421 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
4422 assertions on pointers strictly compliant. Removed _ prefixes on
4423 some function parameter names.
4425 * alloc.c: New source file, containing these external linkage
4426 functions removed from common.c: xmalloc, xcalloc, xrealloc,
4433 * ascii.c: Migrated from arenas to pools.
4434 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
4435 c_string to len_string. All references changed.
4436 (ascii_option) Signature changed to comply to new output.c
4438 (count_fancy_chars) Removed.
4439 (delineate) Removed support for rich text.
4440 (ascii_text_metrics) Ditto.
4442 (output_shorts) Change `box', `off', `on' from c_string to
4443 len_string. Change `remaining' from int to size_t.
4444 (ascii_close_page) Make page numbering less haphazard.
4446 * autorecode.c: Migrate from arenas to pools.
4448 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
4450 * bitvector.h: New file containing these macros from misc.h:
4451 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
4453 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
4454 word[3]. ncmd removed.
4455 (var empty_string) Removed.
4456 (var cmd_table) Declaration updated.
4457 (var cmdtab) Removed.
4458 (cmp_command) Removed.
4459 (split_words) Rewritten to use strtok_r().
4460 (init_cmd_parser) Renamed cmd_init(). Rewritten.
4461 (find_command) Removed.
4462 (FILE_TYPE_okay) Rewritten.
4463 (cmd_parse) Rewritten. Semantics of the return value of command
4464 handlers has changed: they must now return one of the new CMD_*
4465 enumerals, rather than a magic value. This meant that all
4466 commands had to be modified, and they were.
4467 (figure_out_command) New function.
4469 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
4470 #defines for INIT, INPU, etc.
4472 * command.h: New CMD_* enum series.
4473 (cur_proc) Make const char *, not char *.
4474 (cmd_init) Prototype.
4477 * common.c: Removed.
4479 * common.h: Removed.
4481 * correlations.q: New file.
4483 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
4485 (custom_tables) Renamed crs_custom_tables().
4486 (custom_variables) Renamed crs_custom_variables().
4487 (calc_integer) Add in some `const' qualifiers.
4488 (table_value_missing) Change from a_string to len_string.
4489 (float_M_suffix) Change from a_string to len_string.
4491 * data-in.c: Rewritten. All references to
4492 parse_string_as_format() changed to data_in().
4494 * data-in.h: New file.
4496 * data-list.c: Change DLS_* from #define's to enums. Move from
4497 rpd_msg() to tmsg().
4498 (RPD_ERR) New #define.
4499 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
4501 (read_from_data_list_fixed) Change from old
4502 parse_string_as_format() to new data_in().
4503 (read_from_data_list_free) Ditto.
4504 (read_from_data_list_list) Ditto.
4505 (cmd_repeating_data) Modify approach to checking for end of
4508 (rpd_parse_record) Change from old parse_string_as_format() to new
4509 data_in(). Change from old convert_format_to_string() to new
4511 (read_one_set_of_repetitions) Change dfm_push_cust() to
4512 dfm_push(), pop_cust() to dfm_pop().
4514 * data-out.c: Rewritten. All references to
4515 convert_format_to_string() changed to data_out().
4517 * descript.q: Migrate to new q2c.
4518 (cmd_descriptives) Removed.
4519 (internal_cmd_descriptives) Renamed cmd_descriptives ().
4520 (custom_variables) Renamed dsc_custom_variables().
4522 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
4524 (open_file_r) Initialize h->where.line_number. Migrate to new
4526 (open_file_w) Initialize h->where.line_number.
4527 (read_record) Change from ext->ln to h->where.line_number.
4528 Migrate to struct string.
4529 (dfm_put_record) Rephrased.
4530 (dfm_push_cust) Renamed dfm_push(), rewritten.
4531 (dfm_pop) New function.
4533 * error.c: All references updated.
4534 (glob var error_count) Renamed err_err_count.
4535 (glob var warning_count) Renamed err_warning_count.
4536 (glob var error_already_flagged) Renamed err_already_flagged.
4537 (glob var verbosity) Renamed err_verbosity.
4538 (glob var cust_fn) Removed.
4539 (glob var cust_ln) Removed.
4540 (static var file_loc) New.
4541 (static var nfile_loc) New.
4542 (static var mfile_loc) New.
4543 (tmsg) New function.
4544 (push_cust) Removed.
4547 (static var terminating) Removed.
4548 (failure) Renamed err_failure().
4549 (hcf) Renamed err_hcf().
4550 (err_push_file_locator) New function.
4551 (err_pop_file_locator) New function.
4552 (err_location) New function.
4553 (check_error_count) Renamed err_check_count().
4554 (vmsg) Renamed err_vmsg(). Interface changed.
4555 (verbose_msg) Removed.
4556 (err_cond_fail) New function.
4557 (error_break) Renamed err_break().
4559 * error.h: All references updated.
4560 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
4561 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
4563 (struct file_locator) New.
4565 (macro verbose_msg) Removed.
4566 (macro cond_fail) Removed.
4568 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
4570 * expr-prs.c: Reorganized. All references updated.
4571 (exprtypename) Renamed expr_type_name().
4572 (typename) Renamed type_name().
4573 (free_expression) Renamed expr_free().
4574 (parse_expression) Renamed expr_parse(). Uses new type_check()
4576 (init_functab) Renamed init_func_tab().
4577 (type_check) New function.
4578 (parse_or) Rewritten to use new allocate_nonterminal() and
4579 append_nonterminal_arg() functions.
4582 (parse_rel) Ditto. Also simplified logic.
4587 (SYSMIS_func) Ditto.
4588 (VALUE_func) Rephrased.
4589 (CONCAT_func) Fix memory leak by replacing free by free_node on
4591 (generic_str_func) Ditto.
4592 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
4594 (allocate_nonterminal) New function.
4595 (append_nonterminal_arg) New function.
4596 (static func_tab[]) Now at file level.
4598 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
4600 * expr.h: (enum series OP_*) Moved to exprP.h.
4601 (OP_* defines) Ditto.
4602 (struct op_desc) Ditto.
4603 (global ops[]) Ditto.
4604 (struct num_con_node) Ditto.
4605 (struct str_con_node) Ditto.
4606 (struct var_node) Ditto.
4607 (struct lag_node) Ditto.
4608 (struct casenum_node) Ditto.
4609 (struct nonterm_node) Ditto.
4610 (union any_node) Members renamed.
4611 (struct sys_node) Removed.
4612 (struct val_node) Removed.
4613 (operator typedef) Removed.
4614 (typedef exprtype) Removed.
4615 (enum series EX_*) Moved to exprP.h.
4616 (struct expression) Ditto. Also renamed a lot of the members.
4617 (PXP_* defines) Changed to enums.
4618 (free_node prototype) Moved to exprP.h.
4620 * file-handle.h: (struct file_handle) New member `where'.
4622 * file-handle.q: Migrated to new q2c format.
4623 (prepend_current_directory) Removed (dead code).
4624 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
4625 (fh_get_handle_by_filename) Removed dead code.
4626 Set new `where' member.
4628 * file-type.c: (file_type_source_read) References to
4629 parse_string_as_format() changed to data_in().
4630 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
4632 * filename.c: All references updated.
4633 (init_filename) Renamed fn_init().
4634 (expand_line) Removed.
4635 (macro EXPAND_LINE) Removed.
4636 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
4637 of custom functions.
4638 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
4639 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
4640 (normalize_filename) Renamed fn_normalize().
4641 (search_path) Renamed fn_search_path(), rewritten.
4642 (prepend_dir) Renamed fn_prepend_dir().
4643 (blp_getenv) Renamed fn_getenv().
4644 (blp_dirname) Renamed fn_dirname().
4645 (fn_basename) New function, not used.
4646 (absolute_filename_p) Renamed fn_absolute_p().
4647 (is_special_filename) Renamed fn_special_p().
4648 (file_exists) Renamed fn_exists_p().
4649 (readlink_malloc) Renamed fn_readlink().
4650 (getenv_default) Renamed fn_getenv_default().
4651 (open_file) Renamed fn_open().
4652 (close_file) Renamed fn_close().
4653 (open_file_ext) Renamed fn_open_ext().
4654 (close_file_ext) Renamed fn_close_ext().
4656 * font.h: Migrate from arenas to pools.
4658 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
4660 * frequencies.g: Migrate from arenas to pools.
4662 * frequencies.q: Migrate to new q2c version. Migrate from arenas
4665 * getline.c: All references updated.
4666 (global getl_buf) Changed from char * to struct string.
4667 (static getl_include_path) Ditto.
4668 (global getl_buf_len) Removed.
4669 (global getl_buf_size) Removed.
4670 (getl_include_path) Deal with new getl_buf, getl_include_path.
4671 (getl_uninitialize) New function.
4672 (getl_get_current_directory) Rewritten.
4673 (getl_clear_include_path) Rewritten.
4674 (getl_add_include_dir) Rewritten.
4675 (getl_add_file) Assertion fixed.
4676 (getl_add_virtual_file) Change initial value of `remaining_loops'
4678 (welcome) Rewritten.
4679 (handle_line_buffer) Make static. Change logic to make
4680 getl_add_virtual_file() change sensible. Use ds_*() strings.
4681 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
4682 (getl_close_file) Moved.
4683 (getl_location) New function.
4685 * getline.h: All references updated.
4686 (macro curln) Removed.
4687 (macro curfn) Removed.
4688 (macro am_interactive) Renamed getl_am_interactive.
4689 (macro am_reading_script) Renamed getl_reading_script.
4691 * glob.c: (global fmt_parse_ignore_error) Removed.
4692 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
4693 systems that support it (C99). Turn off SET ECHO by default. No
4694 necessary julcal initialization anymore.
4696 * groff-font.c: Migrate from arenas to pools.
4697 (groff_read_font) Use err_push_file_locator().
4698 (groff_read_DESC) Ditto.
4699 (font_msg) Use tmsg().
4701 * hash.c: (hsh_sort) Fix debug code.
4702 [GLOBAL_DEBUGGING] Include stdio.h.
4704 * hash.h: (macro force_hsh_insert) Rephrase.
4706 * heap.c: Rewritten.
4708 * heap.h: Rewritten.
4710 * html.c: (html_option) Change from outp_value to struct string.
4711 (postopen) Change from curfn to getl_location().
4712 (escape_string) Remove rich-text code. Signature changed.
4713 (output_tab_table) Switch from a_string to struct len_string.
4714 Remove rich text support.
4716 * lexer.c: All references updated. Largely rewritten. Major
4717 changes listed below. Removed tagged quote support. Adapted to
4718 struct string tokstr.
4719 (global tokstr) Changed to struct string.
4720 (global tokstr_size) Removed.
4721 (global tokstr_len) Removed.
4723 (global tokint) Removed.
4724 (global toklongstr) Removed.
4725 (C* defines) Removed.
4726 (static tbl[]) Removed.
4727 (static id[]) Removed.
4728 (static une[]) Removed.
4729 (discard_line) Renamed lex_discard_line().
4730 (get_entire_line) Renamed lex_entire_line().
4731 (get_rest_of_line) Renamed lex_rest_of_line().
4732 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
4733 (make_hexit) Removed.
4734 (syntax_error) Renamed lex_error(). Return value removed.
4735 (get_token_representation) Renamed lex_token_representation().
4736 (putback) Renamed lex_put_back().
4737 (putfwd) Renamed lex_put_forward().
4738 (convert_negative_to_dash) Renamed lex_negative_to_dash().
4739 (set_prog) Renamed lex_set_prog().
4740 (init_lex) Renamed lex_init().
4741 (reset_eof) Renamed lex_reset_eof().
4742 (lookahead) Renamed lex_look_ahead().
4743 (check_id) Rewritten.
4744 (yylex) Renamed lex_get(), rewritten.
4745 (lex_end_of_command) New function. Many commands were rephrased
4747 (lex_integer_p) New function. Replaces compare of tokint against
4749 (lex_integer) New function. Replaces tokint.
4750 (match_tok) Renamed lex_match().
4751 (match_id) Renamed lex_match_id().
4752 (match_int) Renamed lex_match_int().
4753 (force_match_id) Renamed lex_force_match_id(), added return value.
4754 (force_match) Renamed lex_force_match(), added return value.
4755 (force_string) Renamed lex_force_string(), added return value.
4756 (force_int) Renamed lex_force_int(), added return value.
4757 (lex_id_match_len) New function.
4758 (id_match) Renamed lex_id_match(), rewritten.
4759 (get_line) Renamed lex_get_line().
4760 (preprocess_line) Renamed lex_preprocess_line().
4761 (tokname) Renamed lex_token_name().
4762 (bin_value_func) Removed.
4763 (oct_value_func) Removed.
4764 (hex_value_func) Removed.
4765 (unexpected_eof) New function.
4766 (convert_numeric_string_to_char_string) New function.
4767 (parse_string) Rewritten, signature changed.
4768 (add_tokstr_char) Removed.
4769 (add_tokstr_unsigned) Removed.
4770 (add_tokstr_string) Removed.
4771 (parse_tagged_quote) Removed.
4772 (skip_comment) Renamed lex_skip_comment().
4774 * lexer.h: All references updated.
4775 (macro is_id1) Renamed CHAR_IS_ID1.
4776 (macro is_idn) Renamed CHAR_IS_IDN.
4777 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
4778 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
4779 (macro get_token) Removed.
4780 (macro id_match) Removed.
4781 (macro force_match_id) Removed.
4782 (macro force_match) Removed.
4783 (macro force_string) Removed.
4784 (macro force_int) Removed.
4785 (macro force_num) Removed.
4786 (macro force_id) Removed.
4788 * lexerP.h: Removed.
4790 * list.q: Migrated to new q2c format.
4791 (write_line) Deal with struct len_string.
4792 (write_varname) Ditto.
4793 (write_fallback_headers) Ditto.
4795 * magic.c: New file, incorporating the following global variables
4796 previously in other files: endian, second_lowest_value. And both
4797 of those are conditional on #define's.
4799 * magic.h: New file, incorporating the following global variable
4800 declarations: endian, second_lowest_value, and the following macro
4801 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
4803 * main.c: Added declarations of pgmname, finished, curdate,
4805 (main) Call new parse_script() function.
4806 (parse_script) New function.
4807 (execute_command) New function.
4808 (dump_token) Removed.
4809 (handle_error) New function.
4811 * matrix.c: New file.
4813 * matrix.h: New file.
4815 * matrix-data.c: Migrated from arenas to pools.
4816 (mget_token) Change from parse_string_as_format() to data_in().
4818 * means.q: Migrate to new q2c.
4819 (custom_tables) Renamed mns_custom_tables().
4820 (custom_crossbreak) Renamed mns_custom_crossbreak().
4821 (custom_variables) Renamed mns_custom_variables().
4823 * mis-val.c: (static var width) Changed from `int' to `size_t'.
4824 (parse_varnames) Prototype.
4825 (parse_numeric) Rephrasings.
4826 (parse_alpha) Adapt to new struct string tokstr.
4828 * misc.c: (intlog10) Rewritten.
4830 (ansi_rand) Renamed real_rand(), moved into random.c.
4831 (ansi_srand) Renamed real_srand(), moved into random.c.
4832 (setup_randomize) Moved to random.c.
4833 (rand_uniform) Ditto.
4834 (rand_normal) Ditto.
4835 (rand_simple) Ditto.
4836 (get_config_line) Removed.
4837 (reverse) Removed (dead code).
4839 * misc.h: (macro SET_BIT) Moved to bitvector.h.
4840 (macro CLEAR_BIT) Ditto.
4841 (macro TEST_BIT) Ditto.
4842 (macro SET_BIT_TO) Ditto.
4843 (macro BIT_INDEX) Ditto.
4845 * output.c: (outp_read_devices) Move to err_push_file_locator()
4846 from push_cust(). Use struct string.
4847 (expand_op_tokstr) Removed.
4848 (static var op_tokstr) Changed to struct string.
4849 (static var op_tokstr_size) Removed.
4850 (tokener) Rephrasings. Use struct string.
4851 (parse_options) Use struct string.
4852 (destroy_driver) Fix assertion.
4853 (outp_get_paper_size) Move to err_push_file_locator().
4854 [0] Removed dead code.
4855 (outp_string_width) Move to len_string.
4857 * output.h: Comment fixes.
4858 (TAG_* enum series) Removed.
4859 (struct outp_value) Removed.
4860 (enum OUTP_T_FANCY) Removed.
4861 (struct outp_text) `s' changed from a_string to len_string.
4862 (struct outp_class) `option' change arg 3 from outp_value to
4865 * pfm-read.c: (corrupt_msg) Rewritten.
4867 * pfm-write.c: (bufwrite) Fix assertion.
4869 * pool.c: New file, reference version.
4871 * pool.h: New file, reference version.
4873 * postscript.c: (ps_font_sizes) Fix assertion.
4874 (ps_option) Change arg 3 from outp_value to struct string.
4875 Adapt to struct string.
4876 (macro output_line) Removed.
4877 (macro add_string) Removed.
4878 (output_encodings) Adapted to struct string. Moved to
4879 err_push_file_locator().
4880 (find_encoding_file) Fix assertion.
4881 (read_ps_encodings) Move to err_push_file_locator().
4882 (postopen) Use getl_location() instead of curfn.
4883 (out_text_plain) Move to len_string.
4884 (text) Ditto. Remove rich text support.
4886 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
4887 (cmd_print_eject) Ditto.
4889 (internal_cmd_print) Now cleans up after itself. Uses
4890 fh_parse_file_handle() now.
4891 (cmd_print_space) Use PXP_NUMERIC to type-check.
4893 * q2c.c: Overhauled. Removed _("") i18n support. All references
4894 updated. All output functions updated to handle structures rather
4895 than local or static variables. Adapt to new PSPP lex_*()
4899 (macro MAX_N_SBC) Removed.
4900 (global bare) Removed.
4901 (enum STRING) Renamed T_STRING.
4902 (enum ID) Renamed T_ID.
4903 (get_buffer) Buffer size increased.
4904 (strlower) Renamed st_lower(), rephrased.
4905 (strupper) Renamed st_upper(), rephrased.
4906 (skip_ws) New function.
4907 (get_line) Don't special-case any types of lines (like those
4908 beginning with ! or $, for instance).
4909 (get_token) Renamed lex_get(). Rephrased.
4910 (static var `prefix') New.
4911 (parse) New function.
4912 (parse_setting) Minor rephrasing.
4913 (dump_specifier_vars) Ditto.
4914 (make_identifier) Put null terminator on identifier, duh.
4915 (dump_vars) Renamed dump_declarations(). Never indent. Never
4916 static. Output changed entirely.
4917 (dump_specifier_init) Rephrase.
4918 (dump_vars_init) No index variable needed. Other modifications.
4919 (dump_parser) Don't parse command name. Do dump functions instead
4920 of just code fragments.
4921 (dump_free) Dump function instead of code fragment.
4922 (recognize_directive) New function.
4923 (main) Use recognize_directive(). Don't rely on magic $ line
4924 beginning: instead, parse comments. Update list of headers.
4926 * random.c: New file, containing the following functions:
4927 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
4928 rand_normal, rand_simple.
4930 * random.h: New file.
4932 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
4933 function. `max_src_width', `max_dst_width' changed to size_t.
4934 (internal_cmd_recode) Removed.
4935 (parse_dest_spec) Merge similar cases.
4936 (parse_src_spec) Add assertion.
4938 * repeat.c: (recognize_keyword) New function.
4939 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
4940 REPEAT. Improve recognition of END REPEAT (use
4941 recognize_keyword()). Move from curfn to getl_location(). Use
4944 (perform_DO_REPEAT_substitutions) Adapt to struct string.
4946 * set.q: Adapt to new q2c.
4947 (cmd_set) Range-check some values better.
4948 (custom_blanks) Renamed stc_custom_blanks().
4949 (custom_length) Renamed stc_custom_length().
4950 (custom_results) Renamed stc_custom_results().
4951 (custom_seed) Renamed stc_custom_seed().
4952 (custom_width) Renamed stc_custom_width().
4953 (custom_format) Renamed stc_custom_format().
4954 (custom_journal) Renamed stc_custom_journal().
4955 (custom_color) Renamed stc_custom_color().
4956 (custom_listing) Renamed stc_custom_listing().
4957 (custom_disk) Renamed stc_custom_disk().
4958 (custom_log) Renamed stc_custom_log().
4959 (custom_rcolor) Renamed stc_custom_rcolor().
4960 (custom_viewlength) Renamed stc_custom_viewlength().
4961 (custom_workdev) Renamed stc_custom_workdev().
4963 * settings.h: Not necessary to include format.h any longer.
4965 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
4966 (corrupt_msg) Rewritten.
4968 * sort.c: Adapt to rewritten heap ADT.
4970 * str.c: (aa_strcpy) Removed.
4971 (ab_strcpy) Removed.
4972 (ac_strcpy) Removed.
4973 (ba_strcpy) Removed.
4974 (bb_strcpy) Removed.
4975 (ca_strcpy) Removed.
4976 (aa_strdup) Removed.
4977 (aa_strdupcpy) Removed.
4978 (ba_strdup) Removed.
4979 (sa_strdup) Removed.
4980 (memrev) Renamed mm_reverse().
4981 (memrmem) Renamed mm_find_reverse().
4982 (cmp_str) Renamed st_compare_pad().
4983 (strmaxcpy) Removed.
4984 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
4985 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
4987 (strpadcpy) Renamed st_pad_copy(), signature changed.
4988 (blpstrset) Removed.
4989 (ds_create) New function.
4990 (ds_init) New function.
4991 (ds_replace) New function.
4992 (ds_destroy) New function.
4993 (ds_clear) New function.
4994 (ds_extend) New function.
4995 (ds_shrink) New function.
4996 (ds_truncate) New function.
4997 (ds_length) New function.
4998 (ds_size) New function.
4999 (ds_value) New function.
5000 (ds_end) New function.
5001 (ds_concat) New function.
5002 (ds_concat_buffer) New function.
5003 (ds_printf) New function.
5004 (ds_putchar) New function.
5005 (ds_getline) New function.
5006 (ds_get_config_line) New function derived from the old
5007 misc.c:get_config_line().
5008 (ls_create) New function.
5009 (ls_create_buffer) New function.
5010 (ls_init) New function.
5011 (ls_shallow_copy) New function.
5012 (ls_destroy) New function.
5013 (ls_null) New function.
5014 (ls_null_p) New function.
5015 (ls_empty_p) New function.
5016 (ls_length) New function.
5017 (ls_value) New function.
5018 (ls_end) New function.
5020 * str.h: Reformatted.
5021 (struct a_string) Removed.
5022 (struct b_string) Removed.
5023 (struct c_string) Removed.
5024 (struct len_string) New.
5025 (struct string) New.
5026 (macro as_streq) Removed.
5027 (macro bs_streq) Removed.
5028 (macro cs_streq) Removed.
5029 (macro sa_streq) Removed.
5030 (macro sb_streq) Removed.
5031 [__GNUC__] (inline function ds_putchar) New function.
5032 [__GNUC__] (inline function ds_length) New function.
5033 [__GNUC__] (inline function ds_value) New function.
5034 [__GNUC__] (inline function ds_end) New function.
5036 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
5037 (display_vectors) Fix missing i18n.
5039 * t-test.q: Migrate to new q2c.
5041 * tab.c: Migrate from arenas to pools.
5042 (tab_create) Use struct len_string.
5043 (tab_realloc) Ditto.
5044 (text_format) Ditto.
5045 (tab_joint_text) Ditto.
5046 (tab_natural_width) Remove rich text support.
5047 (tab_natural_height) Ditto.
5048 (tab_output_text) Handle TAT_FIX.
5049 (tab_raw) Change arg from a_string to len_string.
5050 (tabi_driver) Fix assertion. Use struct len_string.
5051 (render_strip) Use struct len_string. Remove rich text support.
5052 Add `const' qualifiers.
5054 * tab.h: (enum TAB_RICH) Remove.
5055 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
5056 SOM_COL_* updated to read TAB_COL_*.
5057 (struct tab_table) Change arena to pool. Change a_string to
5060 * temporary.c: (restore_dictionary) Rewrite Checker code.
5062 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
5063 LOWEST, HIGHEST) Moved here from common.h.
5064 (typedef any_trns) Removed. All references changed to `struct
5067 * vars-atr.c: (force_create_variable) Fix assertion.
5068 (force_dup_variable) Fix assertion.
5070 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
5072 Using alphanumeric variables in functions under AGGREGATE
5073 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
5074 <BZN-mdksh@t-online.de> for reporting this bug.
5076 * aggregate.c: (parse_aggregate_functions) When setting the
5077 FSTRING bit, also allocate memory for the `string' member of
5079 (free_aggregate_functions) Free iter->string. Don't use the
5080 non-function bits when indexing the array of functions.
5081 [DEBUGGING] (debug_print) Don't use the non-function bits when
5082 indexing the array of functions.
5084 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
5086 Under certain circumstances, the final case would be omitted from
5087 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
5088 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5090 * aggregate.c (agr_00x_end_func): Increment number of cases in
5091 sink before writing case. For streams that keep track of how many
5092 cases there are based on this value, this means that the last case
5093 will be read in on the next stream read.
5095 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
5097 Undefined behavior was invoked by referencing a freed pointer.
5099 * vfm.c (memory_stream_write): Free pointer *after* checking for
5102 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
5104 A wrong record size was displayed when paging the active file to
5107 * vfm.c: (memory_stream_write) Fix off-by-one error.
5109 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
5111 Not having enough temporary space for sorting caused a core dump.
5114 * sort.c: (allocate_cases) Initialize i.
5116 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
5118 Syntax errors in function descriptions on AGGREGATE caused core
5121 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
5122 free_aggregate_functions(), since that function already frees
5125 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
5127 A null pointer was dereferenced, causing a core dump, when
5128 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
5129 but PSPP still doesn't calculate percentiles. Thanks to Regnor
5130 Jernsletten <rjernsle@eunet.no> for reporting this problem.
5132 * arena.c: (arena_malloc) If the arena hasn't been initialized
5133 already, initialize it.
5135 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
5137 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
5138 for compilation with Cygnus Windows B20. Not used by other
5141 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
5143 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
5144 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5146 * sort.c: (compare_case_lists) Reverse sense of comparison if
5147 sorting in descending order.
5148 (compare_record) Ditto.
5150 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
5152 SPLIT FILE with a string variable caused a core dump. Fixed.
5154 * vfm.c: If the variable is a string then make a temporary value
5155 struct pointing to it. The underlying problem is a lot bigger
5156 than this (see TODO) but this is a stopgap for the simple case at
5159 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
5161 Nested INCLUDEs didn't work. Fixed.
5163 * getline.c: (getl_include) Set first_line to NULL in allocated
5166 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
5168 The MATCH FILES procedure set the values of variables not present
5169 to 0. It should have been SYSMIS. This is now fixed.
5171 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
5173 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
5175 The REMARK command was too aggressive about skipping lines. It
5176 didn't like being the last command in a file.
5178 * command.c: (cmd_remark) Call get_entire_line() instead of
5181 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
5183 Comment parsing wasn't consistent with the rest of the code in its
5184 idea of where one command ends and another starts. This meant
5185 that sometimes commands would be mysteriously ignored. Thanks to
5186 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5188 * command.c: (parse_cmd) Hand off comment parsing to new function
5189 skip_comment() in lexer.c.
5190 * lexer.c: (skip_comment) New function.
5192 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
5194 The TABLE subcommand on MATCH FILES worked only erratically at
5195 best. This fixes it. Thanks to Dr. Dirk Melcher
5196 <BZN-mdksh@t-online.de> for reporting this bug.
5198 * get.c: (mtf_compare_BY_values) When comparing string values, a
5199 difference of 1 is still a difference :-)
5200 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
5201 advance TABLE files automatically when matched. Comment fixes.
5203 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
5205 VARIABLE LABELS rejected a slash before the first variable
5206 specification, contradicting the documentation. Thanks to Walter
5207 M. Gray <graywm@northernc.on.ca> for reporting this bug.
5209 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
5210 command specification.
5212 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
5214 Because of an incorrect optimization in memory allocation,
5215 CROSSTABS sometimes segfaulted when asked to output multiple
5216 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
5219 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
5220 are passed to output_pivot_table() for its use.
5221 (output_pivot_table) Instead of assuming the number of columns is
5222 constant, keep track with maxcols. In general mode, use maxcells
5223 to determine whether more matrix cells need to be allocated.
5225 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
5227 CROSSTABS didn't display value labels for column and row
5228 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
5231 * crosstabs.q: (table_value_missing) If the specified value has a
5232 value label for this variable, then show it instead of the raw
5234 (display_dimensions) Delegate display of value_labels to
5235 table_value_missing.
5237 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
5239 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
5240 <BZN-mdksh@t-online.de> for reporting this bug.
5242 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
5243 if the file isn't declared as binary.
5245 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
5247 MATCH FILES corrupted memory and dumped core on some syntax
5250 * get.c: (cmd_match_files) Set file->handle to NULL before
5252 (mtf_free_file) Don't free a null dictionary.
5254 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
5256 MATCH FILES should set numeric values not available to the
5257 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
5258 <BZN-mdksh@t-online.de> for reporting this bug.
5260 * get.c: (mtf_processing) Set unused records to system-missing,
5263 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
5265 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
5266 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
5268 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
5269 in newly created dictionary, and add each copied variable to the
5272 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
5276 * get.c: (trim_dictionary) Free variable list for KEEP after
5279 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
5281 Some systems didn't like the way open_file was coded. Thanks to
5282 Hankin <hankin@rogue.consultco.com> for pointing this out.
5284 * filename.c: (open_file) Don't try to store stdin, stdout,
5285 stderr as part of an array, because that doesn't always work.
5287 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
5289 The SAVE procedure didn't save long string variables properly.
5290 Fixed by this patch. Thanks to Hankin
5291 <hankin@rogue.consultco.com> for this patch.
5293 * sfm-write.c: (write_variable) Fix off-by-one error in writing
5294 out variable pad records.
5296 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
5298 Previously, if PRINT SPACE were given a negative argument, it
5299 would report an error, then spin in an (almost) infinite loop.
5300 This fixes that behavior.
5302 * print.c: (print_space_trns_proc) After reporting a negative
5303 argument, set number of lines to print to 1.
5305 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
5307 SPSS 8.0 outputs some new record types in its system files, and it
5308 allows longer value labels. Accept these system files.
5310 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
5311 11 emitted by SPSS 8.0.
5313 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
5315 The LIST procedure was too conservative in allocating space for
5316 buffers, which caused a bug that only showed up with very long
5317 output variables. Thanks to Hankin <hankin@dunno.com> for this
5320 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
5322 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
5324 Typo meant string format specifiers weren't checked properly. I
5325 think that Hankin <hankin@dunno.com> sent me this report, but I'm
5326 willing to be corrected on this point.
5328 * format.c: (check_string_specifier) Fix obvious typo.
5330 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
5332 Using $CASENUM in an expression didn't work. Here's a fix.
5333 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
5336 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
5338 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
5340 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
5342 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
5343 other behavior, *sigh*. This patch hopefully fixes that. This
5344 time I've actually tested it.
5346 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
5348 * data-list.c: (read_from_data_list_free,
5349 read_from_data_list_list) Call parse_string_as_format() directly
5350 without mucking around with the field width.
5352 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
5354 Occasionally, you may encounter a script that wants to be
5355 interpreted in interactive mode. Make -i emulate this behavior to
5356 allow such scripts to be executed with PSPP.
5358 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
5360 * cmdline.c: (pre_syntax_message[]) Update -i description.
5362 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
5363 when -i is given on the command line) don't treat unindented lines
5364 as starting a new command.
5366 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
5368 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
5369 mostly caused by local initialized aggregates. After egcs is
5370 fixed upstream these can be removed, but for now they're not a big
5373 * ascii.c: (ascii_postopen_driver) Checker chokes on local
5374 initialized arrays. Avoid this.
5376 * sfm-write.c: (sfm_write_dictionary) Don't use a local
5379 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
5381 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
5382 following changes avoid. Currently I compile sources with egcs
5383 1.1.1 and gcc 2.7.2.3 before sending them out.
5385 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
5387 * ascii.c: (option_tab[]) Initialize all struct members.
5389 * avl.h: (avl_traverser_init) New macro.
5391 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
5394 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
5397 * hash.c: Comment fix.
5399 * hash.h: (hsh_iterator_init) New macro.
5401 * html.c: (option_tab[]) Initialize all struct members.
5403 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
5406 * postscript.c: (option_tab[]) Initialize all struct members.
5407 (output_encodings, preclose, dump_lines) Use new
5408 hsh_iterator_init() macro.
5410 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
5413 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
5416 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
5418 * data-in.c: Examined each of the parsing functions to make sure
5419 that they wouldn't dump core if they were passed a string of the
5420 wrong length, since now the DATA LIST FREE/LIST routines don't
5421 check for field width before passing it to the data parser.
5422 (parse_RBHEX, parse_AHEX) Reject odd length input.
5423 (parse_string_as_format) Reject input that's too short or too
5426 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
5427 a field to its entire declared output width then pass it to the
5428 data-in parsing routines. This contradicted the documented
5429 behavior. This is fixed in these changes. Thanks to Mark H. Wood
5430 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
5431 free-format parsing that differed from SPSS.
5432 (cut_field) Commas and spaces are treated identically. Returns
5433 the proper column instead of a fixed 1 value.
5434 (parse_field) Removed.
5435 (read_from_data_list_free, read_from_data_list_list) Call
5436 parse_string_as_format directly instead of parse_field.
5438 * heap.c: (heap_delete) Stylistic fixes.
5440 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
5442 * loop.c: (loop_2_trns_proc) Formatting fix.
5444 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
5446 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
5448 * vfm.c: (macro FILTERED) New.
5449 (static var filter_var) New.
5450 (process_active_file_write_case) Use FILTERED.
5451 (setup_filter) Set filter_var.
5452 (close_active_file) Delete the filter if not
5453 FILTER_before_TEMPORARY.
5454 (procedure_write_case) Use FILTERED.
5456 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
5458 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
5460 * data-in.c: (parse_day_count) Message fix.
5461 (parse_month) Style fix.
5463 * data-list.c: (struct data_list_pgm) New member eof.
5464 (cmd_data_list) Init eof to 0.
5465 (do_reading) Implement the /END subcommand and read-past-eof
5468 * do-if.c: Include stdio.h when debugging.
5469 (cmd_else_if) Make sure the command is .-terminated.
5471 * glob.c: (init_glob) Capitalize the command prompt.
5473 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
5474 (end_file_trns_proc) Debugging message.
5476 * loop.c: (internal_cmd_loop) Make it work when there's no loop
5478 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
5480 * main.c: (dump_token) Make kwtab[] const.
5482 * set.q: Spelling, comment fixes.
5484 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
5487 * vars-prs.c: (fill_all_vars) Style fix.
5489 * vfm.c: (index_to_varname) Return const.
5491 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
5493 * Changes in many source files for partial -ansi -pedantic and
5494 no-debugging compliance: Remove trailing common in enum
5495 declarations; add `unused' attributes; insert some appropriate
5498 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
5500 * command.c: (shell) Make static.
5501 (run_command) Make static.
5503 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
5505 * dfm.c: (cmd_begin_data) I18n fix.
5507 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
5509 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
5511 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
5514 * file-handle.q: Don't prepend the source file directory name to
5515 the data file name. (Ongoing issue.)
5516 (prepend_current_directory) Comment out.
5517 (internal_cmd_file_handle) Don't call prepend_current_directory().
5518 (fh_get_handle_by_filename) Ditto.
5520 * filename.c: Append zero byte to readlink() return value.
5522 * getline.c: (getl_read_line) I18n fix.
5524 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
5526 * misc.h: Don't use gcc features if __STRICT_ANSI__.
5528 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
5531 * postscript.c: (output_encodings) Don't use local_strdup().
5534 * print.c: Don't use gcc features if __STRICT_ANSI__.
5536 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
5538 * recode.c: (parse_src_spec) Fully brace nested if's.
5540 * set.q: (global var set_testing_mode) New var.
5542 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
5544 * ascii.c: Add some more `unused' attributes that only come into
5545 play when NDEBUG is defined.
5546 (ascii_close_page) Set s_len when reallocating s.
5548 * crosstabs.q: (delete_missing) New function.
5549 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
5550 (make_summary_table) Create summary table reallocable.
5552 * postscript.c: Add more `unused' attributes as above.
5554 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
5555 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
5557 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
5560 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
5561 gratuitous space between parameter definition.
5563 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
5564 complaints about running off the end of functions with NDEBUG
5567 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
5569 * Several source files: Removed some PORTME notes when reflection
5570 revealed that ANSI forbids that sort of breakage. Also, added
5571 lots of `unused' qualifiers here and there.
5573 * aggregate.c: (accumulate_aggregate_info) Remove local var
5574 weighting that turned out not to be used.
5576 * avl.c: Update to version 1.1.0. Add unused specifier.
5577 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
5579 (avl_probe) Replace some instances of 1 with +1 where appropriate.
5580 (avl_find) Cast return value to void *.
5581 (avl_delete) q doesn't need to be initialized at the beginning of
5582 the function. Replace some instances of 1 with +1.
5583 (force_avl_delete) Renamed avl_force_delete, all references changed.
5584 (compare_ints) `param' marked unused.
5585 (print_int) `param' marked unused.
5586 (recurse_tree) Replace some instances of 1 with +1.
5588 * avl.h: Update to version 1.1.0. Only declares avl function
5589 types if not already declared.
5590 (AVL_MAX_HEIGHT) Only define if not already defined.
5591 (struct avl_node) New unused member char pad[2].
5592 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
5593 (force_avl_insert) Renamed avl_force_insert.
5594 (force_avl_delete) Renamed avl_force_delete.
5596 * crosstabs.q: (struct table_entry) Put `freq' into a union with
5598 (struct crosstab) Add new member `ofs'.
5599 (glob var int_tab) Removed.
5600 (custom_tables) In integer mode, assign v[i] properly through the
5602 (custom_variables) Now p.crs.max == max + 1.
5603 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
5604 (precalc) Implement integer mode.
5605 (calc_integer) Implement integer mode.
5606 (compare_table_entry) Remove unused local variable `comparing'.
5607 (make_summary_table) Implement integer mode.
5608 (macro ns_rows) Implemented as static variable now.
5609 (several variables) Made static, from global.
5610 (output_pivot_table) Use table_value_missing() for column heads.
5611 Remove several unused local variables. Implement integer mode
5612 table summing. Count up ns_rows.
5613 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
5614 (find_pivot_extent) Moved into find_pivot_extent_general; now just
5615 calls that function or find_pivot_extent_integer.
5616 (find_pivot_extent_integer) New function.
5617 (enum_var_values) Implemented for integer mode.
5618 (table_value_missing) New function.
5619 (display_dimensions) Call table_value_missing() for heads.
5620 (float_M_suffix) New function.
5621 (display_crosstabulation) Call table_value_missing() for row
5622 heads. Handle missing values in /MISSING=REPORT mode.
5623 (calc_fisher) Remove unused var N.
5624 (calc_r) Remove unused var fact.
5626 * data-list.c: (dump_fixed_table) Fix table dimensioning.
5627 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
5629 * data-out.c: (insert_commas) Remove unused var cp.
5630 (convert_CCx) Remove unused vars save_set_decimal,
5633 * descript.q: (dump_z_table) Fix table dimensioning.
5634 (pre_calc) Remove unused var j.
5635 (display) Remove unused vars title, s. Fix table dimensioning.
5637 * expr-evl.c: Comment fixes.
5639 * frequencies.q: (full_dim) New function.
5640 (dump_full) Fix table dimensioning.
5641 (condensed_dim) New function.
5642 (dump_condensed) Fix table dimensioning.
5644 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
5647 * html.c: (html_close_drive) Remove unused var i.
5648 (postopen) Remove unused vars title, curfn_len, cp.
5649 (preclose) Remove unused vars this, x.
5651 * lexer.c: Comment fixes.
5653 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
5655 * means.q: (custom_tables) Remove unused var m_dim.
5657 * mis-val.c: Format fix.
5659 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
5661 * output.c: (outp_get_paper_size) Remove unused var cp.
5663 * pfm-read.c: (read_float) Remove unused var save, unused label
5665 (read_variables) Remove unused vars cp, j.
5666 (read_value_label) Remove unused var j.
5668 * pfm-write.c: (bufwrite) Remove unused var i.
5670 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
5672 (output_encodings) Remove unused vars char_cp, n_output.
5673 (read_ps_encodings) Remove unused var ep.
5674 (postopen) Remove unused var title.
5675 (preclose) Remove unused var fp.
5676 (ps_open_page) Remove unused vars true, false, orientation,
5677 mirror_horz, mirror_vert, width, length.
5678 (ps_text_metrics) Remove unused var x.
5680 * q2c.c: (find_symbol) Remove unused var y.
5681 (parse_setting) Remove unused parameter sbc, all references
5683 (dump_parser) Remove unused var cp.
5684 (dump_free) Remove unused var i.
5686 * set.q: (static vars args, n) Removed.
5687 (internal_cmd_gset) Removed.
5689 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
5690 (read_machine_flt64_info) Removed unused var file_endian.
5691 (read_documents) Removed unused var i.
5692 (read_compressed_data) Removed unused parameter dict, all
5695 * sfm-write.c: (bufwrite) Removed unused var i.
5696 (sfm_write_case) Removed unused var i.
5698 * sort.c: (merge_once) Remove unused var t.
5699 (write_separate) #if 0 out as dead code.
5701 * split-file.c: (cmd_split_file) Remove unused var i.
5703 * sysfile-info.c: (sysfile_info_dim) New function.
5704 (cmd_sysfile_info) Fix table dimensioning.
5705 (variables_dim) New function.
5706 (display_variables) Fix table dimensioning.
5707 (describe_variable) Remove unused var prev_r.
5709 * t-test.q: (z_postcalc) Removed.
5710 (pairs_calc) Remove unused var bad_weight.
5711 (postcalc) Remove unused vars dfn, dfd.
5713 * tab.c: (tab_create) Set t->dim to NULL.
5714 (tab_dim) Make sure t->dim is NULL first.
5715 (tab_natural_width) Remove parameter `clamp'.
5716 (tab_value) Remove duplicate assertion for table.
5717 (tab_raw) New function.
5718 (nowrap_dim) New function.
5719 (wrap_dim) New function.
5720 (tab_output_text) Fix table dimensioning.
5722 * tab.h: (tab_raw) New macro.
5724 * val-labs.c: (get_label) Remove unused var type.
5725 (copy_value_labels) Remove unused var trav.
5727 * var.h: (struct crosstab_proc) Completely changed.
5729 * vars-prs.c: (parse_dict_variable) Remove unused var v.
5731 * vfm.c: (open_active_file) Remove unused vars i, lp.
5733 * weight.c: (weight_trns_proc) #if 0 out as dead code.
5735 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
5737 * Makefile.am: Add apply-dict.c, flip.c.
5739 * apply-dict.c: New file.
5741 * command.c: (struct command) Make cmd[] larger for CLEAR
5742 TRANSFORMATIONS command name.
5743 (parse_cmd) Make sure we're in a valid state before using it as an
5744 index. Discard variables and reset state on invalid transitions.
5745 (cmd_clear_transformations) New function.
5747 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
5748 Add unimplemented PRESERVE, RESTORE.
5750 * file-handle.h: Include stddef.h.
5754 * pfm-read.c: (parse_value) Pad value label values with spaces,
5757 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
5758 (sfm_close) Decrement reference count, make sure it's zero.
5759 (sfm_maybe_close) New function.
5760 (sfm_read_dictionary) Handle reference counts.
5762 * vars-atr.c: (clear_default_dict) New function.
5763 (discard_variables) Use clear_default_dict().
5765 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
5767 * Makefile.am: Add pfm-write.c.
5768 (LDADD) Add the libgmp2 libraries.
5770 * command.def: Define EXPORT.
5772 * get.c: (cmd_export) New function.
5773 (export_write_case_func) New function.
5775 * pfm-read.c: (static spss2ascii[]) Make it const.
5777 * pfm-write.c: New file.
5779 * sfm-write.c: Formatting, comment fixes.
5781 * var.h: Comment fix.
5783 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
5785 * Makefile.am: Add pfm.h, pfm-read.c.
5787 * command.def: IMPORT is now implemented.
5789 * format.c: (glob var translate_fmt[]) New var.
5791 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
5792 (cmd_import) New function.
5793 (import_source_read) New function.
5794 (glob var import_source) New var.
5796 * pfm-read.c: New file.
5800 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
5802 (dump_dictionary) Disabled printing a couple of items.
5804 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
5806 * crosstabs.q: (postcalc) Call make_summary_table().
5807 (make_summary_table) New function.
5808 (insert_summary) New function.
5809 (display_dimensions) Remove some unnecessary arguments, all
5811 (output_pivot_table) Fix lots of problems with the risk table
5813 (submit) Don't display an empty table.
5814 (display_risk) Fix order of arguments to calc_risk().
5816 * glob.c: Always include assert.h and stdlib.h.
5818 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
5821 * tab.c: (tab_create) Cosmetic changes.
5823 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
5825 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
5829 * crosstabs.q: (output_pivot_table) Headers drawing and submission
5830 code simplified, moved into new function submit().
5831 (submit) New function.
5832 (crosstabs_dim) New function.
5833 (display_directional) Substitute variable names for %s where
5835 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
5836 (calc_symmetric) Initialize parameters only if non-NULL.
5837 Calculate Somers' d.
5838 (calc_directional) Calculate Somers' d (or copy it, really).
5841 * output.c: (outp_string_width) New function.
5843 * postscript.c: (postopen) Calculate font widths based on the
5844 width of the zero '0' character, not the width of the space
5845 character. Set paper-width and paper-length based on points, not
5847 (ps_open_page) Fix page setup string for landscape mode.
5849 * som.h: (struct som_dimension) Removed.
5850 (struct som_table_class) height, width members take int * not
5853 * tab.c: Many functions now have added parameter validation.
5854 (tab_height, tab_width) These functions were removed and merged
5855 into a single function tab_resize(), and all references changed.
5856 (tab_dim) Rewritten since the interface changed; reduced from
5857 hundreds of lines to two. All callers were changed. Currently
5858 most of them just use tab_natural_dimensions as their callback and
5859 await detailed translation of functionality.
5860 (tab_natural_width) New function.
5861 (tab_natural_height) New function.
5862 (tab_natural_dimensions) New function. This is a callback
5863 function, not something that you'd want to call directly.
5864 (tab_nat_dim) Removed.
5865 (tabi_table) Allocates t->w and t->h.
5866 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
5867 dimensions callback.
5868 (evaluate_dimensions) Removed.
5869 (sum_columns) Removed.
5871 * tab.h: (enum TAL_1THIN) Removed.
5872 (enum series t_*) Removed.
5873 (struct tab_table) Members trh, trv changed to unsigned char *
5874 from int *. Member dim changed to a function pointer from a
5875 unsigned char *. Member max_stack_height removed. New members
5877 (macros tab_l, tab_r, tab_t, tab_b) New.
5879 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
5881 * ascii.c: (delineate) Assign last_space_nchars before skipping
5882 spaces, to fix right justification.
5884 * crosstabs.q: (static vars risk, direct) New vars.
5885 (static var pearson_r) Removed.
5886 (glob var chisq_fisher) Made static.
5887 (static vars row_tot[], col_tot[]) Don't include grand total
5889 (static var grand_total) Renamed W, all references changed.
5890 (output_pivot_table) Only make `table' if num_cells != 0. Make
5891 risk and directional tables. Deal with grand total no longer part
5892 of col_tot[]. Free rows and cols after we're done with them.
5893 (display_risk) New function.
5894 (display_directional) New function.
5895 (clac_r) Rewritten so that it stores all its results into its
5896 arguments, so it can be used for Spearman's correlation too.
5897 (calc_symmetric) Added a t[] argument, all references changed.
5898 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
5899 Pearson's r, Cohen's kappa.
5900 (calc_risk) New function.
5901 (calc_directional) New function.
5903 * som.c: (som_submit) Improved debugging code.
5905 * stats.c: (hypercube) New function.
5906 (cube) New function.
5908 (normal_sig) Went back to old implementation, which actually
5911 * stats.h: (macros square, cube, hypercube) Removed. The
5912 equivalent functions in stats.c are inlined here; all references
5913 to square changed to sqr.
5915 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
5917 * crosstabs.q: (N_SYMMETRIC) New define.
5918 (postcalc) Disable debug printing.
5919 (static vars chisq_fisher, pearson_r) New.
5920 (output_pivot_table) Add support for symmetric measures. Add
5921 chi-square output of exact sigs.
5922 (display_chisq) Rewritten.
5923 (display_symmetric) New function.
5924 (gamma_int) New function.
5926 (swap) New function.
5927 (calc_fisher) New function.
5928 (calc_chisq) Check boundary conditions better. Calculate Yates,
5929 Fisher, Mantel-Haenszel tests.
5930 (calc_r) New function.
5931 (calc_symmetric) New function.
5933 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
5935 (chisq_sig) Better boundary conditions. Renamed from
5938 * tab.h: (struct tab_table) New member cf.
5940 * tab.c: (tab_create) Set cf.
5941 (tab_width) New function.
5942 (tab_realloc) Handle cf.
5943 (tab_vline) Handle cf.
5944 (tab_hline) Handle cf.
5945 (tab_box) Handle cf.
5946 (tab_value) Handle cf.
5947 (tab_float) Handle cf.
5948 (tab_text) Handle cf.
5949 (tab_joint_text) Handle cf.
5950 (tab_offset) Handle cf.
5951 (tab_next_row) Handle cf.
5952 (evaluate_dimensions) Handle cf.
5953 (render_strip) Handle cf.
5955 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
5957 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
5958 output_pivot_table().
5959 (output_pivot_table) Moved lots of local variables outside and
5960 made them static. Add beginnings of chi-square statistic
5961 support. Now column and row totals aren't in the main matrix.
5962 Always zero out any leftover rows & columns after we're done with
5963 the table entries. Move all output stuff into
5964 display_dimensions(), display_crosstabs(), display_chisq().
5965 (display_dimensions) New function.
5966 (display_crosstabulation) New function.
5967 (display_chisq) New function.
5968 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
5970 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
5971 references, simplify logic.
5973 * postscript.c: Remove scale, translate-x, translate-y,
5974 mirror-horz, mirror-vert, rotate-180 options.
5975 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
5976 All references deleted.
5977 (macro YT) New macro.
5978 (array option_tab[]) Removed options.
5979 (ps_option) Removed options.
5980 (ps_open_page) Write page setup explicitly to output file, without
5981 using now-deleted BP function.
5982 (macro dump_line) Use YT().
5983 (macro dump_thick_line) Use YT().
5984 (draw_headers) Use YT().
5985 (switch_font) Reorder arguments to SF function.
5986 (write_text) Use YT().
5988 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
5991 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
5993 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
5994 null-debugging code.
5995 (tab_realloc) Remove null-debugging code. Initialize new regions
5997 (tab_vline) Support offsets.
5998 (tab_hline) Support offsets.
5999 (tab_box) Support offsets.
6001 (tab_nulls) Removed.
6004 (evaluate_dimensions) Remove null-debugging code. Understand
6005 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
6006 TAB_EMPTY not present.
6008 * tab.h: New cell attribute TAB_EMPTY.
6009 (macros tab_nr, tab_nc, tab_row, tab_col) New.
6011 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
6012 try to read them from system files.
6014 * vfm.c: (dump_splits) Don't call tab_null().
6016 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
6018 * crosstabs.q: (struct crosstab) Added `missing' member.
6019 (custom_tables) Init missing.
6020 (calc_general) Handle missing values.
6021 (calc_chisq) New function.
6022 (output_pivot_table) Start work on chi-square output. Update for
6023 new tab offset support functions. Shorten statistic names.
6025 * Several files: add in more `const's to placate gcc's warnings.
6027 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
6030 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
6031 tab_null, tab_nulls, tab_value, tab_float, tab_text,
6032 tab_joint_text) Add col_ofs and row_ofs support.
6033 (tab_offset) New function.
6034 (tab_next_row) New function.
6035 (tab_row) New function.
6036 (tab_col) New function.
6037 (tabi_table) Add col_ofs and row_ofs support.
6039 * vars-atr.c: (is_system_missing) New function.
6041 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
6043 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
6044 (static var no_cells) Removed.
6045 (static var num_cells) New.
6046 (static var expected) New.
6047 (static var cells[]) New.
6048 (internal_cmd_crosstabs) Deal with new variables.
6049 (postcalc) Removed most of the meat and put it in new function
6050 output_pivot_table().
6051 (output_pivot_table) Calculates and outputs an entire pivot table.
6053 * postscript.c: (postopen) Fix problems with free()ing addresses
6054 not obtained from malloc().
6056 * som.c: (som_submit) Add assertion.
6058 * sysfile-info.c: (describe_variable) Use new tab_nulls()
6061 * tab.c: (static var tab_names[]) New.
6062 (tab_realloc) -1 for nc or nr indicates no change.
6063 (tab_nulls) New function.
6064 (tab_dim) Use tab_names[].
6065 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
6066 (evaluate_dimensions) Don't terminate on uninited cells, just put
6067 an X in them and emit a notice. Use tab_names[].
6069 * tab.h: Move bits into tab.def.
6071 * tab.def: New. Don't try to declare tab_table_class because then
6072 som.h has to be included.
6074 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
6076 * command.def: New file, contains all the command definitions
6077 previously included bodily in command.c.
6079 * format.def: New file, contains all of the format definitions
6080 previously split across format.h, format.c, and sfm-write.c.
6082 * lexer.h: Renamed from tokens.h in order to match corresponding
6085 * lexerP.h: Moved some rarely used functions exported by lexer.c
6088 * Makefile.am: Commemorate renamed files.
6089 (EXTRA_DIST) Add command.def, format.def.
6091 * command.c: [0] (walk_cmdtable_func) Removed.
6093 * crosstabs.q: (postcalc) Made it work and print out matrices
6095 (enum_column_values) Renamed enum_var_values, generalized for any
6098 * format.h: (struct fmt_desc) New member `spss'.
6100 * q2c.c: (main) Generated code includes lexer.h instead of
6103 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
6104 instead of an independent translation table.
6106 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
6108 * Lots of source files: Added const to declarations.
6110 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
6112 * arena.c: (arena_clear) Set prev pointer to null when done.
6114 * ascii.c: (ascii_option) Rename index as indx.
6116 * avl.c: This is now a separate library called libavl.
6117 (xmalloc) Make static.
6118 (avl_probe) Step A7 can use the cache instead of an explicit
6120 (avl_delete) Don't maintain a q pointer because it's always
6121 available in the pointer stack. Comment fix.
6123 * avl.h: This is now a separate library called libavl.
6125 * command.c: (cmd_table[]) Remove spurious trailing "".
6127 * common.h: Only include random() fix if this system needs it.
6129 * crosstabs.q: Include alloca headers.
6130 (n_sorted_tab) New global var.
6131 (postcalc) Mostly rewritten.
6132 (find_pivot_extent) Rewritten.
6133 (enum_column_values) Rewritten.
6135 * data-out.c: (convert_F) Rename inner n as n_spaces.
6137 * error.c: (dump_message) Don't have an outer var i.
6139 * file-handle.q: (static var f) Removed. All references removed.
6140 (internal_cmd_file_handle) Uses a local variable instead of f.
6142 * get.c: (trim_dictionary) Change scope of i, i1, i2.
6143 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
6146 * getline.h: Declare getl_history as extern. Reported by
6147 palme@uni-wuppertal.de (Hubert Palme).
6149 * postscript.c: (postopen) Some large mods for constness.
6151 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
6154 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
6156 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
6157 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
6160 * avl.c, avl.h: New files. These form a clean-room
6161 reimplementation of avllib. Iterative algorithms are used in
6162 place of recursive ones, so there is no resemblance in the code.
6164 * Lots of headers: Don't include other headers by default.
6166 * Lots of source files: Explicitly include all needed headers.
6168 * arena.c: (arena_clear) New function.
6170 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
6171 (static var ar) Removed.
6172 (staitc vars ar_tc, ar_col) New.
6173 (cmd_crosstabs) Destroy the arenas.
6174 (internal_cmd_crosstabs) Create the arenas.
6175 (precalc) Don't need a free function for the hash.
6176 (calc_general) Make sure to zero out the trailer on the key data
6178 (print_table_entries) Updated.
6179 (postcalc) Worked on actually implementing.
6180 (find_pivot_extent) New function.
6181 (compare_value) New function.
6182 (enum_column_values) New function.
6184 * data-in.c: (parse_month) Make local array `static const'.
6186 * data-out.c: (convert_date) Make local array `static const'.
6187 (convert_WKDAY) Same.
6188 (convert_MONTH) Same.
6190 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
6191 been renamed to avl_walk().
6193 * hash.c: Rewritten more efficiently.
6195 * hash.h: Add attribute const to hsh_next_prime declaration.
6197 * lexer.c: (id_match) Make arguments const.
6199 * postscript.c: (ps_postopen_driver) Make default fonts the
6202 * q2c.c: (main) Generated code needs stdlib.h.
6204 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
6205 initialized to 0 now, not to NULL. All other references to
6206 avl_traverser were updated in the same way.
6208 * tokens.h: Macro version of id_match updated to use const
6211 * val-labs.c: (inc_ref_count) New function.
6212 (copy_value_labels) Simply through use of new avl_copy() function.
6214 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
6216 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
6217 (postcalc) Worked on this.
6219 * postscript.c: (OPO_DOUBLE_LINE) New enum.
6220 (struct ps_driver_ext) New line_width_thick member.
6221 (ps_preopen_drive) Init line_width_thick.
6222 (option_tab[]) Add line-* options.
6223 (ps_option) Parse line-* options.
6224 (postopen) Add line_width_thick support. Strip leading spaces on
6225 prologue output lines.
6226 (ps_open_page) Include line_width_thick in output.
6227 (macro dump_thick_line) New.
6228 (dump_fancy_line) Support thick lines as well as double lines.
6230 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
6232 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
6233 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
6235 * Many source files: Rename `options' to `pv_opts' as appropriate.
6237 * command.c: (static var cmd_table[]) Add CROSSTABS command.
6239 * common.c: (xcalloc) New function.
6241 * crosstabs.q: New file. Not finished yet, though.
6243 * data-list.c: Comment fix.
6245 * error.c: Remove some old Checker cruft.
6247 * frequencies.q: (dump_full) Cumulate valid percent instead of
6250 * getline.c: Comment fix.
6252 * hash.c: Comment fixes.
6254 * hash.h: (struct hsh_table) Make hash functions return unsigned
6255 instead of int to avoid problems with taking the modulo of
6256 negative return values. All references changed.
6258 * misc.c: (intlog10) Make its table static const instead of auto.
6260 * sfm-read.c: (read_header) Make `prefix' static const instead of
6263 * var.h: (union value) Add member `hash'.
6264 (struct variable) Rename prv_index as `foo'--all references
6266 (typedef pv_opts) Removed. All references changed.
6268 * vars-prs.c: (parse_variables) Message fixes.
6270 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
6272 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
6273 they are being inserted. Don't check for BY variables of
6274 different types. Discard variables if the active file isn't
6275 included in the merge.
6276 (mtf_processing) Essentially rewritten.
6277 (mtf_merge_dictionary) Check for master/slave variables of
6278 different types/widths.
6280 * vfm.c: (static var not_canceled) New var.
6281 (process_active_file) Don't call vfm_source->read() if
6282 there's no vfm-source. Initialize not_canceled.
6283 (process_active_file_write_case) Honor and update not_canceled.
6284 (prepare_for_writing) Rollback changes from yesterday, they were
6286 (close_active_file) Don't destroy vfm_source unless it exists.
6288 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
6290 * Lots of source files: Added { } around nested if/else constructs
6291 to avoid new gcc 2.8 warnings.
6293 * data-in.c: (parse_Z) Declare `int' type explicitly.
6296 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
6297 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
6298 prev members. Put TABLEs at the end of the chain and FILEs at the
6299 beginning. Don't allow the active file in STATE_INIT. Use proper
6300 `seen' value for the active file. Fill out the by members and
6301 make sure they're of consistent type. Do the actual merge
6303 (mtf_processing_finish) New function.
6304 (var_type_description) New function.
6305 (mtf_free_file) New function.
6306 (mtf_free) Rewritten.
6307 (mtf_delete_file_in_place) New function.
6308 (mtf_read_nonactive_records) New function.
6309 (mtf_compare_BY_values) New function.
6310 (static var mtf_seq_no) New var.
6311 (mtf_processing) New function.
6312 (mtf_merge_dictionary) Assign nval members for the system file
6313 dictionary. Assign fv values for its variables. Point each slave
6314 variable to the corresponding master variable.
6316 * hash.c: Include str.h.
6318 * mis-val.c: (copy_missing_values) src arg is const.
6320 * misc.c: (spacing) Make `max' var explicitly int.
6322 * sfm-read.c: (dump_dictionary) Message reformatting.
6323 (sfm_read_case) Add assertion.
6325 * sort.c: Esthetic fixes.
6327 * var.h: (struct match_files_proc) New struct.
6328 (struct variable) Add private data match_files_proc.
6330 * vars-atr.c: (delete_variable) Implement. Add argument for the
6331 dictionary that owning the variable.
6332 (dup_variable) Add assertion.
6334 * vfm.c: Comment fixes, hopefully the comments are correct now.
6335 (process_active_file) New function.
6336 (process_active_file_write_case) New function.
6337 (process_active_file_output_case) New function.
6338 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
6340 (write_case) Renamed procedure_write_case(). Now write_case is a
6341 pointer to a function. Style fixes.
6343 1998-03-05 Ben Pfaff <blp@gnu.org>
6345 * Makefile.am: (q2c) Link with libmisc.
6346 (version.c) Define default_config_path, include_path,
6349 * ascii.c: (ascii_postopen_driver) When the default newline string
6350 is requested, open file in text mode. Suggested by
6351 palme@uni-wuppertal.de (Hubert Palme).
6352 (static vars line_buf, line_p) Change from char * to unsigned char
6354 (ascii_close_page) char * to unsigned char *.
6356 * cmdline.c: (parse_command_line) Implement -r option by
6357 prepending ~/.pspp/rc to the list of files to process.
6359 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
6360 before pulling in a final line.
6361 (null_func, null_int_func) Removed (dead code).
6363 * descript.q: (display) Calculate width of variable name column
6364 properly. Calculate number of valid cases properly. Reported by
6365 palme@uni-wuppertal.de (Hubert Palme).
6367 * filename.c: (init_filename) Use default_config_path instead of
6368 now obsolete CONFIG_PATH.
6370 * getline.c: (getl_initialize) Use include_path instead of now
6371 obsolete INCLUDE_PATH.
6372 (getl_add_file) New argument `where'. All references changed.
6374 * groff.c: (find_font_file) Use groff_font_path instead of now
6375 obsolete GROFF_FONT_PATH.
6377 * postscript.c: (find_ps_file) Use groff_font_path instead of now
6378 obsolete GROFF_FONT_PATH. Copy through temporary variable to
6379 avoid problems with constness.
6381 * str.h: (macro cs_streq) New macro.
6383 * version.h: (glob var default_config_path, include_path,
6384 groff_font_path) New vars.
6386 1998-02-23 Ben Pfaff <blp@gnu.org>
6388 * Many source files: Change verbose_msg() priority levels and
6391 * aggregate.c: Include debug-print.h.
6393 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
6395 (static var pre_syntax_message) Document --safer/-s and
6398 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
6400 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
6401 because it's not used but it's still copied.
6402 (open_file_r) Remove gratuitous debug message.
6404 * filename.c: (safety_violation) New function.
6405 (open_file) Remove gratuitous debug messages. Don't allow pipe
6406 files if set_safer is set.
6408 * get.c: Turn off debugging.
6410 * getline.c: (getl_add_virtual_file) New function.
6411 (getl_read_line) Add verbose_msg() call for opening new syntax
6413 (getl_perform_delayed_reset) Add a return value describing whether
6414 any action was taken. Call reset_eof().
6416 * getline.h: Comment fix.
6418 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
6419 place of incorrect `continue'. Use strtok_r() instead of
6420 strtok(). Always check strtok_r() return value.
6421 (groff_read_DESC) Use strtok_r() instead of strtok().
6423 * lexer.c: (reset_eof) New function.
6425 * main.c: (parse) Get a token after performing a delayed reset
6426 action; allow empty syntax files.
6428 * postscript.c: (output_encodings) Use strtok_r() instead of
6431 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
6433 * set.q: Comment fixes.
6434 (glob var set_safer) New var.
6435 (internal_cmd_set) Support SAFER.
6437 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
6439 * temporary.c: (free_dictionary) Set d->splits to NULL after
6442 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
6443 variable deleted, not if it *isn't* deleted.
6445 1998-02-16 Ben Pfaff <blp@gnu.org>
6447 * command.c: (array cmd_table[]) Add MATCH FILES.
6449 * common.c: Comment fixes.
6451 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
6452 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
6453 Include alloca.h. Problem reported by palme@uni-wuppertal.de
6456 * expr-opt.c: Include str.h. Problem reported by
6457 palme@uni-wuppertal.de (Hubert Palme).
6459 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
6460 (static var mtf_by) Change from char ** to variable **.
6461 (static var mtf_master) New var.
6462 (mtf_merge_dictionary) New function.
6463 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
6464 var type. Reorder tests properly. Initialize file->dict. Detect
6465 TABLE= without BY=. Read file dictionaries and merge them. Give
6466 subcommand name with IN, LAST, FIRST error messages. Create IN,
6467 LAST, FIRST variables. Comment fixes.
6468 (mtf_free) Don't free default_dict. Free mtf_master.
6470 * getline.c: Define getl_mode. Change getl_buf_size to size_t
6472 (handle_line_buffer) Cast int to size_t in comparison to avoid
6475 * getline.h: Declare getl_mode extern.
6477 * groff-font.c: (groff_read_font) Type-fix calls to getline.
6478 (groff_read_DESC) Make line_size a size_t.
6479 (match_tok) Parenthesize name to avoid macro expansion.
6481 * mis-val.c: (copy_missing_values) New function.
6483 * postscript.c: (postopen) Make buf_size a size_t.
6485 * sfm-read.c: (dump_dictionary) Make global from static. Print
6486 variable info in parts for easier debugging with Checker.
6488 * temporary.c: (copy_variable) Use copy_value_labels().
6489 (new_dictionary) New arg: whether to copy file label, documents.
6491 * val-labs.c: (copy_value_labels) New function.
6493 * var.h: (enums MISSING_*) Add MISSING_COUNT.
6495 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
6497 (dup_variable) Set prv_index, get.fv, get.nv.
6499 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
6501 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
6503 * Many source files: For ANSI-compliance, add empty statement
6504 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
6505 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6507 * data-in.c: (parse_numeric) Some header files break on
6508 -DBL_MIN_10_EXP because they get a --; add () for safety.
6509 Reported by palme@uni-wuppertal.de (Hubert Palme).
6511 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
6512 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
6513 (dfm_close) Use close_file_ext.
6514 (open_inline_file) Set file.file to NULL, not file.
6515 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
6516 struct and use open_file_ext().
6517 (read_record) Use file.file.
6519 * file-handle.q: (prepend_current_directory) Pass through special
6522 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
6523 (normalize_filename) Pass through special filenames.
6524 (open_file, close_file) Accept pipe| and |pipe syntaxes as
6526 (dirname) Rename blp_dirname() because of name conflict on some
6527 OS. All references changed. Reported by palme@uni-wuppertal.de
6529 (is_special_filename) New function.
6531 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
6532 (trim_dictionary) Conditionalize some of the options on whether
6533 GTSV_OPT_MATCH_FILES is in *options.
6534 (rename_variables) Don't allow variables to be renamed as scratch
6536 (MTF_*) New enum series.
6537 (struct mtf_file) New struct.
6538 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
6540 (cmd_match_files, mtf_free) New functions.
6542 * lexer.c: (match_int) Needed parentheses around name to escape
6543 macro expansion. Reported by Micah Altman
6544 <maltman@www-vdc.fas.harvard.edu>.
6546 * print.c: Needed to include alloca.h. Reported by Micah Altman
6547 <maltman@www-vdc.fas.harvard.edu>.
6549 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
6550 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
6553 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
6554 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6556 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
6558 * html.c: (struct html_driver_ext) Move into htmlP.h.
6559 (html_preopen_driver) Initialize cp_x, cp_y.
6560 (html_submit) Implement as call to output_tab_table().
6561 (change_attributes) New function.
6562 (escape_string) New function.
6563 (output_tab_table) New function.
6565 * list.q: (write_all_headers) Add code for writing headers for the
6567 (clean_up) Write out the html close-table tag.
6568 (determine_layout) Ignore html driver.
6569 (list_cases) Write html data.
6571 * som.c: (som_submit) Move more of the code into output_table().
6573 * tab.c: (static var hit) Make a global var and rename tab_hit.
6574 (static var tab_table_class) Make a global var.
6576 * htmlP.h: New file.
6578 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
6580 * dump-sysfile.c: Removed.
6582 * html.c: (preclose) Change comment in emitted code.
6584 * matrix-data.c: Debugging off by default. Comment fixes.
6585 (static var container) New var.
6586 (cmd_matrix_data) Create and destroy container. Initialize
6587 is_per_factor[] to 0s. Move code into new function
6588 string_to_content_type(). Require split values to be present in
6589 the data when ROWTYPE_ is explicit. Call specific function, not
6590 general read_matrices().
6591 (string_to_content_type) New function.
6592 (context) Exclude all whitespace, not just spaces.
6593 (mget_token) A dot is a number. Add assertion.
6594 (static var data) Renamed nr_data.
6595 (static var factor_values) Renamed nr_factor_values.
6596 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
6597 only specific case. Close data_file before exit.
6598 (fill_matrix) New function.
6599 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
6600 printing. Style fixes. Message fixes. Move code into
6602 (read_matrices_without_rowtype) Rename
6603 matrix_data_read_without_rowtype(). Fix off-by-one error on
6604 loops. Allocate nr_data[] memory from arena.
6605 (read_matrices_with_rowtype) Removed.
6606 (read_splits) Renamed nr_read_splits(). Style fixes.
6607 (read_factors) Renamed nr_read_factors().
6608 (dump_cell_content) Comment fixes. Arguments changed. Change
6609 debug printing. All references changed.
6610 (output_data) Renamed nr_output_data().
6611 (static var wr_content) New var.
6612 (struct factor_data) New struct.
6613 (static var wr_data) New var.
6614 (static var wr_current) New var.
6615 (matrix_data_source_destroy_source) Removed.
6616 (read_matrices_with_rowtype) New function.
6617 (matrix_data_read_with_rowtype) New function.
6618 (wr_read_splits) New function.
6619 (compare_factors) New function.
6620 (wr_output_data) New function.
6621 (wr_read_rowtype) New function.
6622 (wr_read_factors) New function.
6623 (wr_read_indeps) New function.
6624 (glob var matrix_data_source) Make destroy_source member NULL as
6627 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
6629 * lexer.c: (syntax_error) Give better error message when at end of
6632 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
6633 N_SCALAR to output as plain N.
6634 (mdump_token) Change output format.
6635 (context) Fix message output interaction with spaces in input.
6636 (another_token) New function.
6637 (force_eol) Improved error message.
6638 (static var max_cell_index) New var.
6639 (read_matrices) Init `cells'. factor_values is now per-cell.
6640 Init max_cell_index.
6641 (read_data_lines) Replace `compare' local with new `compare' arg.
6642 Debugging messages changed. Only read factors if per_factor.
6643 Propagate error return from read_factors(), force_eol().
6644 Copy N_SCALAR values across the N vector.
6645 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
6646 check parentheses manually since we now have is_per_factor[].
6647 Call read_data_lines() with new args. Check for end of data after
6648 looping, using another_token().
6649 (read_factors) Arguments changed. Use max_cell_index to determine
6650 whether to read or compare factors. Message fixes.
6651 (dump_cell_content) New function.
6652 (output_data) Completely rewritten because content types were
6653 supported to be nested inside factor values, not vice versa.
6655 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
6657 * lexer.c: (syntax_error) Support formatted varargs messages.
6659 * matrix-data.c: Turn debugging on by default.
6660 (static content_type[]) New array.
6661 (static content_names[]) New array.
6662 (static rowtype_, varname_) New vars.
6663 (static is_per_factor[]) New array.
6664 (static split_values) Moved declaration.
6665 (static n_continuous, first_continuous) New var.
6666 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
6667 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
6668 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
6669 Check for continuous variables.
6670 [DEBUGGING] (debug_print) Remove content_names[].
6671 (mdump_token) New macro.
6672 (mget_token_dump) New function.
6673 (mdump_token) New function.
6674 (context) New function.
6675 (mget_token) Fix messages.
6676 (static var data, split_values, factor_values) New vars.
6677 (read_matrices) Manage split_values, factor_values.
6678 (read_data_lines) New function.
6679 (read_matrices_without_rowtype) Implemented.
6680 (read_splits) Message fixes. Uses `just_read'.
6681 (read_factors) New function.
6682 (output_data) New function.
6683 (matrix_data_source_destroy_source) Close the file handle.
6684 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
6687 * str.c: (strpadcmp) Removed.
6689 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
6691 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
6693 * Lots of source files: Add cast to unsigned character to calls to
6694 tolower() and toupper().
6696 * aggregate.c: Set default_dict.splits to NULL.
6698 * command.c: (static variable tab[]) Add MATRIX DATA.
6700 * data-in.c: Add debugging defines. Formatting fixes.
6702 * expr-opt.c: Formatting fixes.
6704 * lexer.c: (syntax_error) Message fixes.
6706 * matrix-data.c: New enum series.
6707 (static vars fmt, section, diag, explicit_rowtype, signle_split,
6708 split_values, n_factors, factors, cells, pop_n, contents,
6709 n_contents) New vars.
6710 (cmd_matrix_data) Finished implementation.
6711 (compare_variables_by_mxd_vartype) New function.
6712 [DEBUGGING] (debug_print) New function.
6713 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
6714 (read_matrices) New function.
6715 (read_matrices_without_rowtype) New function.
6716 (read_matrices_with_rowtype) New function.
6717 (read_splits) New function.
6718 (mget_token) New function.
6719 (force_eol) New function.
6720 [0] (test_tokenizer) New function.
6721 (matrix_data_source_destroy_source) New function.
6722 (glob var matrix_data_source) New var.
6724 * misc.h: Include ieeefp.h if present.
6726 * split-file.h: (cmd_split_file) Changes corresponding to struct
6729 * str.h: Fix memmem prototype.
6731 * temporary.c: (save_dictionary, restore_dictionary,
6732 free_dictionary) Changes corresponding to struct dictionary
6735 * var.h: (MXD_* enums) New enum series.
6736 (struct matrix_data_proc) New struct.
6737 (struct split) Removed.
6738 (struct dictionary) Changed `splits' member from `split *' to
6740 (macro force_create_variable) New macro. Replaced lots of
6741 create_variable()/assert() calls with calls to this macro.
6743 * vars-atr.c: (discard_variables) Changed assertion.
6744 [GLOBAL_DEBUGGING] (force_create_variable) New function
6745 called by the macro of the same name.
6746 (clear_variable) Changes to delete splits from the dictionary
6747 corresponding to struct dictionary changes.
6749 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
6750 corrupted variable `index' values in the dictionary passed in
6751 every time this function is called.
6753 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
6754 to struct dictionary changes.
6756 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
6758 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
6760 * command.c: New includes.
6761 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
6762 (cmd_erase) New function.
6763 [unix] (shell) New function.
6764 (run_command) New function.
6765 (cmd_host) New function.
6766 (cmd_new_file) New function.
6768 * expr-prs.c: (parse_primary) Message fix.
6770 * inpt-pgm.c: Formatting fix.
6771 (cmd_reread) Implement the FILE subcommand.
6773 * matrix-data.c: New file.
6775 * q2c.c: (dump_header) Change output commenting style.
6777 * weight.c: Comment fix.
6779 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
6781 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
6783 (buf_10x) Renamed buf_1xx, all references changed.
6784 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
6785 cases now implemented).
6786 (create_sysfile) New function.
6787 (agr_11x_func) New function.
6789 * data-in.c: (parse_numeric) Work properly if there's an
6790 explicitly coded decimal point in the data and decimal places are
6791 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
6792 <el@linux.lisse.na>.
6794 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
6795 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
6796 Eberhard W Lisse <el@linux.lisse.na>.
6798 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
6799 strerror.c. Bug reported by Alexandre Oliva
6800 <oliva@dcc.unicamp.br>.
6802 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
6803 (static var separate_case_tab) New var.
6804 (cmd_sort_cases) Cancel temporary transformations here. Free
6805 v_sort before return.
6806 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
6807 we're reading from a sort stream. Don't cancel temporary
6808 transformations. Offload internal sorting to do_internal_sort().
6809 (do_internal_sort) New function. Handles internal sorting even
6810 when SEPARATE is nonzero. Doesn't free v_sort.
6811 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
6813 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
6814 sink if SEPARATE is zero.
6815 (read_output_cases) Renamed read_sort_output(), all references
6816 changed. Now uses separate_case_tab when it exists.
6817 (write_separate) New function.
6819 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
6820 memory_sink_cases. Don't redundantly call
6821 vfm_source->destroy_source().
6822 (memory_stream_mode) After switching over, set memory_sink_cases
6825 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
6827 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
6829 (static var prev_case) New, moved out of aggregate_single_case()
6831 (static var buf64_10x, buf_10x) New.
6832 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
6833 the 000, 001, 100, and 101 cases. Free prev_case.
6834 (parse_aggregate_functions) Disallow scratch variables.
6835 (free_aggregate_functions) Only free agr_dict if non-null. Use
6836 iter->function to determine numeric/string type, not
6838 (aggregate_single_case) Don't manage prev_case. Initialize
6839 aggregate info after dumping it.
6840 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
6841 mean, stddev, weighted stddev definitions.
6842 (dump_aggregate_info) Implemented.
6843 (initialize_aggregate_info) Renamed from
6844 initialize_aggregate_functions(). Initializes dbl[2].
6845 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
6846 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
6848 * cases.c: (alloc_val) Removed.
6850 * get.c: (cmd_save_internal) Initialize new `dict' member.
6852 * sfm-write.c: (sfm_write_dictionary, write_header,
6853 write_variable, write_value_labels, write_documents) Reorganize,
6854 simplify for new parameter structure.
6855 (write_variable) Only one variable * argument now.
6857 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
6858 replaced by new `dict' member.
6860 * temporary.c: (new_dictionary) Initialize n_documents.
6862 * vars-atr.c: (dup_variable) Allocate `value's from dict into
6864 (init_variable, replace_variable) Eliminate usage of alloc_val().
6866 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
6868 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
6869 signal that AGGREGATE is to be used for forming final cases.
6870 (close_active_file) Call end_func before stopping lagging. Cancel
6871 temporary after finishing compaction.
6872 (write_case) Comment fixes. Cleaned up.
6873 (compact_case) Let AGGREGATE handle compaction when `temporary' is
6876 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
6878 * Makefile.am: (BUILT_SOURCES) Add means.c.
6879 (pspp_SOURCES) Add means.c.
6880 (EXTRA_DIST) Add means.q.
6882 * command.c: (array cmd_table[]) Add MEANS.
6884 * common.h: Esthetic fixes. Comment fixes. Test for
6885 MAX_SHORT_STRING greater than 8.
6886 (macros LOWEST, HIGHEST) New.
6888 * data-in.c, data-list.c, recode.c: Comment fixes.
6890 * means.q: New file, base version.
6892 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
6893 with LOWEST, DBL_MAX with HIGHEST.
6895 * q2c.c: (dump_vars) Add an enum to array types giving the number
6896 of values for the enum.
6898 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
6899 Replace second_lowest_value with second_lowest_flt64.
6901 * sfm-write.c: (write_variable, write_rec_7_34) Replace
6902 second_lowest_value with second_lowest_flt64.
6904 * t-test.q: Comment fix.
6906 * temporary.c: (restore_dictionary) Esthetic fix.
6908 * tokens.h: (force_match_id, force_match, force_string, force_int,
6909 force_num, force_id) Replace msg() with syntax_error().
6911 * var.h: (struct means_proc) New.
6912 (struct variable) Add mns member to `p' union.
6914 * vars-prs.c: (parse_variable, parse_dict_variable,
6915 parse_variables, parse_DATA_LIST_vars) Replace msg() with
6918 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
6920 * Makefile.am: (pspp_SOURCES) Add tab.h.
6922 * Most source files: Added a cast to unsigned char in usages of
6923 the ctype is*() functions. Replaced `end of command expected'
6924 calls to msg() with calls to syntax_error().
6926 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
6928 * lexer.c: (hex_val) Removed (was dead code).
6929 (idmatch) Parenthesize function name to avoid macro expansion.
6931 * postscript.c: Comment fixes.
6932 (ps_preopen_driver) Change default font size to 10pt.
6934 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
6936 (parse_format_spec) Change system-file format spec argument type
6937 to int32. Parse the format spec with bitwise operators.
6939 * sfmP.h: (struct sysfile_format) Removed.
6940 (struct sysfile_variable) Changed print, write members from
6941 sysfile_format to int32.
6943 * tokens.h: Esthetic fixes.
6944 [__GNUC__] (macro id_match) New macro to hopefully speed up
6945 identifier matching.
6946 (macros match_id, match_tok, match_int) Implemented in
6947 compiler-independent manner; no longer GNU C only.
6949 * vfm.h: Include time.h.
6951 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
6953 * data-list.c: (dump_fixed_table) Change tab_dim().
6955 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
6957 * error.c: Include command.h.
6959 * frequencies.g: Formatting fixes.
6961 * frequencies.q: Add tab_dim() calls. Make the total cell a
6964 * glob.c: Include command.h.
6966 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
6968 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
6969 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
6970 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
6971 the other elements (is this right?).
6972 (read_variables) Use lowest, highest members.
6973 (parse_format_spec) New arg `vv' for more stringent checking.
6974 (dump_dictionary) Byteswaps nonexplicit data.
6975 (sfm_read_case) Byteswap numeric data.
6977 * som.c: Initialize table_num to 1.
6978 (render_segments) Remember to increment y_index after each table
6981 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
6982 avl_count() on a NULL tree. No title for the second table.
6983 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
6984 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
6985 fix call to display_variables().
6986 (display_variables) Default to 4 columns, not 3. Set up headers.
6987 Column title is Variable, not Name. Fix index column.
6988 Add joint text. Add tab_dim(). Handle value labels properly.
6989 Handle DISPLAY LABELS properly. Draw boxes correctly.
6990 (describe_variable) Value labels don't need titles. Don't clear
6991 nonexistent index column.
6992 (compare_vectors_by_name) New function.
6993 (display_vectors) New function.
6995 * tab.c: (tab_height) Add assertion.
6996 (tab_null) Add debug code.
6997 (evaluate_dimensions) Add debug code.
6999 * var.h: (struct variable) get_proc data is sometimes used
7000 simultaneously with other per-procedure info, therefore it was
7001 removed from the union. All references changed.
7003 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
7005 * ascii.c: (ascii_close_page) Put title on second line of headers
7006 if there is no subtitle.
7008 * command.c: (glob var cur_proc) Move definition here, from
7010 (cmd_remark) Emit blank line before remarks.
7012 * command.h: (glob var cur_proc) Move declaration here, from
7015 * data-list.c: (dump_fixed_table) Fix messages.
7016 (dump_free_table) Call tab_nat_dim().
7018 * descript.q: (dump_z_table) Modify tab_dim() call.
7020 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
7022 (dump_statistics) Don't output header.
7024 * groff-font.c: Minor format fix.
7026 * html.c: Comment fix.
7028 * list.q: (write_varname) Indent after advancing page.
7030 * output.h: Minor reordering.
7032 * postscript.c: Comment fixes. Many places, '\n' was replaced by
7033 a reference to eol[].
7034 (struct ps_driver_ext) New member eol[].
7035 (ps_preopen_driver) Initialize eol[].
7036 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
7037 defaults. Handle headers. Fix test for minimum page length.
7038 (static var option_tab[]) Add `line-ends'.
7039 (ps_option) Handle line-ends to change eol[].
7040 (postopen) Scale prop_em_width and fixed_width properly. Set the
7041 prologue title to outp_title if applicable. Replace the prologue
7042 line ends with eol[]. Call draw_headers() if headers are enabled.
7043 (text_width) New function.
7044 (out_text_plain) New function.
7045 (draw_headers) New function.
7047 * print.c: (dump_table) Call tab_nat_dim().
7049 * som.c: (som_blank_line) Only advance a line if not at the top of
7051 (som_submit) Move several informational table calls here.
7052 Increment subtable_num if SOMF_NO_TITLE not set.
7053 (output_table) Advance a line if SOMF_NO_SPACING not set.
7054 (render_columns, render_segments, render_simple) Handle spacing
7055 between tables. Handle table titles. Remove debug output.
7057 * som.h: (SOMF_*) New enum series.
7058 (struct som_table_class) New member `flags'.
7060 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
7062 (display_variables) Calls tab_nat_dim().
7063 (describe_variable) Remove restriction on number of value labels.
7064 Make value labels separated by thin lines.
7066 * tab.c: (tab_create) Default `flags' to none.
7067 (tab_float) New arg `w'. All references changed.
7068 (tab_nat_dim) New function.
7069 (tab_output_text) No title or spacing.
7070 (tab_flags) New function.
7071 (tabi_flags) New function.
7072 (tabi_title) New function.
7073 (strip_height) Removed.
7074 (tabi_render) Skip title when necessary.
7075 (static var tab_tab_class) Add tabi_flags, tabi_title.
7076 (evaluate_dimensions) Disable display of column, row size.
7077 (sum_columns) Add title height to top header.
7078 (render_strip) Moved within file.
7080 * tab.h: (struct tab_table) New member `flags'.
7082 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
7084 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
7086 * Most source files: Add `const' attribute in all appropriate
7089 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
7090 column to the variables table for use by describe_variable().
7091 (cmd_display) Disable for the present.
7092 (display_documents) Don't wrap documents.
7093 (display_variables) Table has four columns now.
7094 (describe_variable) Table has four columns now. Don't use a
7095 subtable, use joined cells instead.
7097 * tab.c: (tab_create) Don't set `join'.
7098 (tab_realloc) ct array is not made up of a_string's.
7099 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
7100 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
7101 (text_format) New function.
7102 (tab_title) Rewritten, uses text_format().
7103 (tab_text) Rewritten, uses text_format().
7104 (tab_joint_text) New function.
7106 (static var hit) New variable.
7107 (render_strip) New args r1, r2. Implement joined cells that fit
7109 (tabi_render) Increment hit. Pass new args to render_strip().
7110 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
7111 cells. For t_naw and t_nah, ignore joined cells and null cells in
7114 * tab.h: (struct tab_join_rect) Removed.
7115 (struct tab_table) Removed `join'.
7116 (TAB_JOIN_MAIN) Removed.
7117 (struct tab_joined_cell) New struct.
7118 (TAT_NOWRAP) New enum.
7120 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
7122 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
7124 (ascii_postopen_driver) Fix initialization of *_spacing so that
7125 the TAL_0 bit doesn't count.
7127 * data-list.c: (dump_fixed_table) Use natural width for Format
7130 * glob.c: (rerange) Removed.
7131 (get_date) Formatting fixes. Internationalization fix.
7133 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
7136 * postscript.c: (ps_postopen_driver) Replace
7137 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
7139 * som.c: (som_submit) Don't eject page before every table.
7140 (output_table) Fix order of arguments on call to area().
7141 (render_columns) Fix calculation of max_len.
7143 * tab.c: (tabi_cumulate) Minor change to increase elegance.
7144 (render_strip) New function.
7145 (strip_height) New function.
7146 (tabi_render) Rewrite as calls to render_strip().
7148 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
7149 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
7150 with the TAB_* and OUTP_T_* constants.
7152 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
7154 * Makefile.am: Formatting fixes.
7156 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
7159 * data-list.c: (dump_fixed_table) Add tab_dim() call.
7161 * descript.q: (dump_z_table, display) Add tab_dim() calls.
7163 * dump-sysfile.c: (glob var length) Make type off_t.
7164 (usage) Fix arguments.
7167 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
7168 Now right-justification is the default so many references had to
7170 (struct outp_class) Removed line_width, all references changed.
7171 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
7172 (struct outp_driver) Add elements horiz_line_width,
7173 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
7176 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
7178 (postopen) Initialize all the informational members of
7181 * som.c: (som_blank_line) New function, renamed from blank_line(),
7182 all references changed.
7183 (som_submit) Disables drivers whose pages can't be opened.
7184 (render_columns, render_simple, render_segments) Add debug output.
7185 (render_columns) Fix loop range.
7186 (render_simple) Don't try to render the headers, they're taken
7187 care of automatically. Advance cp_y past the table when done.
7188 (render_segments) Fix loop ranges.
7190 * tab.c: Initialize new members of tab_table.
7191 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
7192 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
7193 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
7196 (tab_dim) New function.
7197 (tab_col_width) Removed.
7198 (tab_row_height) Removed.
7199 (tab_output_text) Call tab_dim().
7200 (tabi_driver) Call evaluate_dimensions(), sum_columns().
7201 (tabi_area) Implemented.
7202 (tabi_cumulate) Implemented.
7203 (tabi_render) Partially implemented, but broken.
7204 (var tab_table_class) Made static.
7205 (evaluate_dimensions) New function.
7206 (sum_columns) New function.
7208 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
7209 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
7210 t_scr, t_srr, t_sentinel. Removed: t_nat.
7211 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
7212 max_stack_height, w, h. Removed: ce, re.
7213 (macro blank_line) Removed.
7214 (glob var zero_length) Removed.
7216 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
7218 * Most source files: include some of the new include files broken
7221 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
7224 * aggregate.c: (glob var outfile) Make static.
7226 * command.c: (glob var pgm_state) Move here.
7228 * common.c: (glob vars endian, second_lowest_value, pgmname,
7229 finished, curdate, cur_proc, start_interactive, history_file) Move
7232 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
7234 * file-handle.q: (glob vars files, inline_file) Move here.
7236 * glob.c: Lost lots of glob vars, detailed in individual file
7238 (init_glob) set_printer, set_screen were obsolete, deleted.
7239 set_cprompt has fewer spaces because pspp has fewer letters than
7242 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
7243 (inp_nval) Made static.
7245 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
7246 tokstr_len, toklongstr, tokint) Move here.
7248 * misc.c: Lost several vars and functions.
7250 * set.q: (all the set_* variables) Move here.
7252 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
7253 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
7256 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
7258 * tab.h: (enum series t_*) New enums.
7259 (struct tab_table) Use arena struct tag. New members ce, re.
7261 * tokens.h: Comment fixes.
7263 * var.h: Move lots of enums and variables and functions and
7264 structures to other files. Use and declare a lot more union and
7265 struct tags. Comment fixes.
7267 * vector.c: (glob vars vec, nvec) Move here.
7269 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
7270 init_blanks, last_vfm_invocation) Move here.
7272 * cases.h: New file.
7273 (struct long_vec) Move here.
7274 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
7277 * command.h: New file.
7278 (STATE_* enums) Move here.
7279 (glob var pgm_state) Move here.
7281 * format.c: New file.
7282 (glob var formats) Move here.
7283 (parse_format_specifier_name, fmt_to_string,
7284 check_input_specifier, check_output_specifier,
7285 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
7288 * format.h: New file. Move functions now in format.c here.
7289 (FMT_* enums) Move here.
7290 (struct fmt_desc) Move here.
7291 (FCAT_* enums) Move here.
7292 (struct fmt_spec) Move here.
7293 (glob vars formats, fmt_parse_ignore_error) Move here.
7295 * inpt-pgm.h: New file.
7296 (INP_* enums) Move here, make #defines into enums.
7297 (glob vars inp_init, inp_init_size) Move here.
7300 (glob vars v_sort, nv_sort) Move here.
7301 (sort_cases, read_sort_output) Move here.
7303 * vector.h: New file.
7304 (struct vector) Move here, add struct tag.
7305 (glob vars vec, nvec) Move here.
7306 (find_vector) Move here.
7309 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
7310 reinit_blanks, init_zero, init_blanks) Move here.
7311 (struct case_stream) Move here.
7312 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
7313 vfm_disk_stream, sort_stream, data_list_source,
7314 input_program_source, file_type_source, get_source, n_lag) Move
7316 (procedure, write_case, lagged_case, compact_case, page_to_disk)
7319 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
7321 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
7322 (LDADD) Add libdcdflib.
7324 * ascii.c: Comment and formatting fixes. Almost every external
7325 function had an assert added, checking driver_open and page_open.
7326 (ascii_init_driver) Broken into ascii_preopen_driver,
7327 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
7328 (ascii_open_page) Sets page_open.
7329 (ascii_close_page) Clears page_open.
7331 * html.c: Comment and formatting fixes. Almost every external
7332 function had an assert added, checking driver_open and page_open.
7333 (html_init_driver) Broken into html_preopen_driver,
7334 html_postopen_driver, html_close_driver. Manages driver_open.
7335 (html_open_page) Sets page_open.
7336 (html_close_page) Clears page_open.
7337 (html_submit) Disabled.
7339 * lexer.c: (parse_string) Remove debugging printf.
7341 * list.q: (determine_layout) Open a page if one is not yet open.
7343 * output.c: Comment fixes.
7344 (add_class) Set the class member of the new list element.
7345 (parse_options) Don't handle device type.
7346 (colon_tokenize) New function.
7347 (configure_driver) New four-field format with a field for device
7348 type. Now initialize driver_open, page_open, next, and prev
7349 fields. Use new colon_tokenize() function. Don't do a memory
7350 copy to replace a driver, it doesn't work; instead delete the old
7351 driver and insert a new one.
7352 (destroy_driver) Don't call som_destroy_driver(). Close the page
7353 if it's open. Find the class in the list of classes and decrement
7354 that reference count. Remove the driver from the global driver
7356 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
7357 references changed. Rewritten. Don't return a driver that's not
7359 (outp_eject_page) All references to som_internal_eject_page()
7360 changed to use this. Sets cp_x to 0 as well as cp_y.
7362 * output.h: (OUTP_I_* enums) Removed.
7363 (struct som_submission_form) Removed.
7364 (struct outp_class) init_driver broken into preopen_driver,
7365 postopen_driver, and close_driver. submit changed to take a
7368 * postscript.c: Comment and formatting fixes. Almost every
7369 external function had an assert added, checking driver_open and
7371 (ps_init_driver) Broken into ps_preopen_driver,
7372 ps_postopen_driver, ps_close_driver. Manages driver_open.
7373 (ps_open_page) Sets page_open.
7374 (ps_close_page) Clears page_open.
7376 * som.c: New file, base implementation.
7378 * som.h: (struct som_table) Add struct tag.
7379 (enum SOM_COL_ACROSS) Removed.
7380 (SOM_ROWS, SOM_COLUMNS) New enums.
7381 (struct som_table_class) Add member `cumulate'. Remove `segment';
7382 change `render' arguments.
7383 (struct som_point, struct som_rect) Removed.
7384 (som_submit_table) Fixed typo, should have been som_submit.
7386 * sysfile-info: (describe_variable) Don't try to insert a
7387 subtable; just destroy it for now.
7389 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
7390 references to value labels.
7392 * tab.c: (tab_destroy) New function.
7393 (tab_columns) Change argument.
7394 [0] (tab_submit) Remove dead code.
7395 (tab_title) Allocate string from the table's arena.
7396 (tab_output_text) Only free the buffer if we allocated it.
7397 (tab_submit) New function.
7398 (static vars t, d) New static vars.
7399 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
7400 tabi_headers, tabi_cumulate, tabi_render) New functions.
7401 (glob var tab_table_class) New global var.
7403 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
7404 encapsulate the rectangle. All references changed.
7406 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
7408 * All header files updated to use struct tags in addition to
7409 typedefs for all structures. Don't use word `struct' in struct
7412 * Makefile.am: (pspp_SOURCES) Remove html.c.
7413 (INCLUDES) Replace the lib/* includes with a single lib/ include;
7414 all references updated.
7416 * command.c: (parse_cmd) Remove call to som_check_workspace.
7417 (output_line) Update to new som.
7419 * data-in.c: (parse_numeric) A single dot is not an error; it is
7420 the system-missing value.
7422 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
7425 * data-out.c: Added `const' as appropriate to many prototypes.
7426 (convert_E, convert_F, convert_CCx) Take double argument instead
7427 of value * argument.
7428 (convert_format_to_string) Call changed functions appropriately.
7429 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
7430 make a local copy of the value.
7432 * descript.q: Remove custom_variables() prototype now provided by
7434 (custom_variables) Don't increment sbc_variables, the caller does
7436 (dump_z_table, display) Update to new som.
7438 * error.c: (vmsg) Add const to prototype. Remove code to handle
7439 `too many errors' condition.
7440 (check_error_count) New function.
7441 (msg) Add const to prototype.
7443 * filename.c: (open_file) Rewrite for elegance.
7445 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
7446 (dump_full, dump_condensed, dump_statistics) Update for new som.
7448 * list.q: Don't include somP.h. Change all references to
7449 som_driver_ext to refer to the new members of som_driver. Change
7450 som_internal_eject_page() references to outp_eject_page().
7452 * main.c: (parse) Rewrite for elegance. Add call to
7453 check_error_count().
7455 * output.c: (add_class, outp_list_classes, outp_configure_driver)
7456 Rewrite or revise for new outp_driver_class_list structure.
7457 (outp_iterate_enabled_drivers) Fix comparison between disabled
7458 devices and current device type.
7459 (outp_eject_page) New function.
7461 * output.h: Comment fixes.
7462 (struct outp_driver) New members driver_open, page_open, cp_x,
7463 cp_y, font_height, prop_em_width, fixed_width. Deleted members
7465 (struct outp_driver_class_list) New struct.
7466 (outp_class_list) Changed to type outp_driver_class_list; all
7469 * print.c: (dump_table, print_trns_proc) Updated for new som.
7471 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
7472 prototypes for custom subcommands.
7473 (dump_subcommand) Always include the `else'.
7474 (dump_parser) Fix comments in output code.
7476 * set.q: Reordered functions.
7478 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
7480 * som.h: Rewritten from scratch.
7482 * str.h: Remove dead code.
7484 * tab.c, tab.h: New files, base implementation.
7486 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
7489 * t-test.q: New code from John Williams
7490 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
7491 Many many new static vars and defines.
7492 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
7493 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
7494 (struct value_list) New struct.
7495 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
7496 t_crt, t_sig, print_t_groups) New functions.
7497 (cmd_t_test) Implemented.
7499 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
7502 * vfm.c: (dump_splits) Update to new som.
7504 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
7506 * Makefile.am: (fiasco_SOURCES) Add html.c.
7508 * aggregate.c: Base source.
7510 * ascii.c: (postopen, preclose) Reformat.
7512 * data-out.c, expr-evl.c: Comment fixes.
7514 * filename.c: (open_file) When opening a file for writing, use
7515 line buffering instead of full buffering for better interactive
7516 performance. Suggested by Valerio Aimale
7517 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
7518 names `stdin', `stdout', `stderr'.
7520 * groff-font.c: Comment fixes.
7522 * html.c: New file; base version.
7524 * list.q: (write_all_headers, clean_up, determine_layout,
7525 list_cases) Ignore `special' devices for now. Needs to be fixed
7528 * output.c: (outp_init) Add html driver to list; reverse list
7531 * output.h: (struct outp_class_struct) New members `special',
7532 `submit'; comment fixes. All references changed.
7534 * postscript.c: (ps_init_driver) Make defaults for text_opt,
7535 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
7537 (postopen) Comment fix.
7538 (preclose) Comment fixes, formatting fixes. Change x->file.file
7539 references to more proper f->file.
7541 * som-high.c: (som_submit_table) Special classes use their own
7544 * som.h: Comment fixes.
7546 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
7549 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
7551 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
7553 * aggregate.c: Still working on this.
7555 * command.c: (cmd_table[]) Add AGGREGATE back in.
7556 (split_words) Make '-' a legal word separator as well as ' '.
7558 * main.c: Comment fixes.
7560 * q2c.c: (dump_parser) Don't require the procedure's full name to
7561 be present, in the generated source.
7563 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
7564 multiply specified and let it be default; let MISSING, CRITERIA,
7565 FORMAT be multiply specified.
7566 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
7567 (custom_groups) Fix defaults.
7568 (custom_pairs) Check whether this is a PAIRS subcommand before
7569 attempting to parse. Better garbage collection. Proper storage
7571 [DEBUGGING] (debug_print) New function.
7573 * temporary.c: Comment fixes.
7574 (copy_variable) Don't copy variable name and index.
7575 (save_dictionary) Copy variable name and index by hand.
7577 * vars-atr.c: Comment fixes.
7578 (create_variable) New dictionary argument. All references
7580 (common_init_stuff) New dictionary argument. All references
7582 (init_variable) New dictionary argument. All references changed.
7583 (dup_variable) New function.
7585 * vars-prs.c: (parse_variables) If there are any errors, we always
7586 return 0. Previously, it was possible for some types of errors to
7589 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
7591 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
7594 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
7596 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
7599 * q2c.c: Comment fixes.
7600 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
7602 * t-test.q: (cmd_list) Rename cmd_t_test.
7604 * temporary.c: (new_dictionary) Don't declare as static.
7606 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
7608 * aggregate.c: Changes, still not finished.
7610 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
7612 * q2c.c: Comment fixes. Now its output is internationalized.
7613 (get_token) Fix parsing of escapes within literal strings.
7614 (main) Fix bad #line directives in output.
7616 * t-test.q: Base implementation.
7618 * temporary.c: (new_dictionary) New function.
7619 (restore_dictionary) [__CHECKER__] Change fill character to *
7622 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
7624 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
7626 * aggregate.c: Changes, still not finished.
7628 * descript.q, list.q: Comment fixes.
7630 * q2c.c: Almost completely rewritten.
7632 * t-test.q: New file, not complete.
7634 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
7636 * aggregate.c: Changes, still not finished.
7638 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
7641 * temporary.c: (cancel_temporary) New function.
7643 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
7644 of doing it by hand.
7646 * vfm.c: (close_active_file) After restoring a TEMPORARY
7647 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
7649 (SPLIT_FILE_procfunc) Comment fix.
7651 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
7653 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
7655 * aggregate.c: New file, not finished yet.
7657 * command.c: (cmd_table) Add AGGREGATE.
7659 * common.h: (pgm_state) Move declaration to var.h.
7661 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
7663 (parse_string) Message fix.
7665 * recode.c: Comment fix.
7667 * sfm-read.c: (read_variables) Code esthetic fixes.
7668 (write_header) Default date is `Jan', not `JAN'.
7670 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
7672 * sort.c: (cmd_sort_cases) Farm the work out to new function
7673 parse_sort_variables().
7674 (parse_sort_variables) New function.
7675 (sort_cases) New function. Cancels temporary transformations,
7676 which sorting didn't do previously.
7677 (cmd_sort_cases) Better garbage collection on error. Uses
7679 (write_initial_runs, merge_once) Improved code esthetics.
7680 (sort_stream_read) Reduced to one call to read_output_cases().
7681 (read_output_cases) New function.
7683 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
7684 variable labels to 120 characters.
7686 * var.h: Comment fixes.
7687 (glob var pgm_state) From common.h.
7689 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
7691 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
7692 options. Set *names to NULL on error.
7694 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
7696 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
7698 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
7699 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
7701 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
7703 * vfm.c: (page_to_disk) Added missing local variables.
7705 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
7707 * get.c: Comment fix.
7709 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
7710 source is anything other than a disk stream, not just if it's in a
7711 memory stream. Call page_to_disk() before external sort.
7712 (allocate_cases) Message fix.
7714 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
7716 (page_to_disk) New function.
7718 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
7720 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
7722 * common.h: (macro strerror) Remove. From Alexandre Oliva
7723 <oliva@dcc.unicamp.br>.
7725 * get.c: (dict_delete_run) The number of variables to delete is
7726 not necessarily the number of variables that need to be shifted
7728 (trim_dictionary) Don't set *options to 0. Fix bug that caused
7729 too many variables to be deleted.
7731 * postscript.c: Comment fix.
7733 * q2c.c: Include strerror.c. From Alexandre Oliva
7734 <oliva@dcc.unicamp.br>.
7736 * set.q: #undef ON and OFF. From Alexandre Oliva
7737 <oliva@dcc.unicamp.br>.
7739 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
7740 early, otherwise errors cause a bad free().
7742 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
7743 Oliva <oliva@dcc.unicamp.br>.
7745 * temporary.c: (save_dictionary) Don't allocate memory if
7748 * vfm.c: (memory_stream_write) Message fix.
7750 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
7752 * command.c: (static var cmd_table[]) Define REPEATING DATA
7755 * common.h: Added support for broken systems that are missing
7756 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
7758 * Many source files: Replace syntax error messages via msg() with
7759 call to syntax_error().
7761 * data-list.c: (dump_fixed_table) Add support for dumping table
7762 for REPEATING DATA as well as DATA LIST FIXED.
7763 (cmd_repeating_data) Allows and requires `/' between subcommands.
7764 Does proper thing with allowing rpd.starts_end to stay 0. Allows
7765 CONTINUED specifications to be omitted. Forces CONTINUED to be
7766 specified if ID is. Calculates starts_end, cont_end from logical
7767 record length as reported by fhp. Calls dump_fixed_table() if
7768 requested. Fixed length of record copied by memcpy.
7769 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
7771 (realize_value) Returns sensible value for out-of-range variable
7773 (rpd_parse_record) New argument `ofs'. Fixed confusion between
7774 length of occurrences and length of line. Added warning for
7775 fields that exceed the line length. Fixed infinite loop.
7776 (read_one_set_of_repetitions) Numerous minor changes for more
7777 complete SPSS compliance. Message fixes.
7779 * dfm.c: (dfm_close) If the file being closed is the inline file,
7780 read all the remaining data before closing it.
7781 (dfm_get_record) Don't close the file on lossage, as either it
7782 has been closed already or it doesn't belong to us.
7784 * error.c: (puts_stdout) New function.
7785 (vmsg) Use puts_stdout instead of puts.
7787 * file-handle.q: (fh_record_width) New function.
7789 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
7792 (input_program_source_read) Made an old kluge an approved method.
7794 * lexer.c: (syntax_error) New function.
7796 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
7799 * output.c: (oupt_get_paper_size) Message fix.
7801 * q2c.c: Numerous fixes to formatting of generated code made to
7802 conform to GNU coding standards. Uses syntax_error() in generated
7803 code. Other miscellaneous generated message fixes. Added support
7804 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
7805 RAND_MAX, and/or strerror().
7807 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
7809 * data-in.c: Comment fixes.
7811 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
7812 (find_variable_input_spec) New function.
7813 (cmd_repeating_data) Initializes id_spec.
7814 (rpd_parse_record) Implemented.
7815 (read_one_set_of_repetitions) Returns -3 by default in order to
7816 kluge out some potential bugs.
7818 * data-out.c: Comment fixes.
7820 * file-type.c: (internal_cmd_record_type) Message fix.
7822 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
7823 for handling -3 return value.
7825 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
7827 * data-list.c: Comment fixes.
7828 (struct dls_var_spec) Reordered members.
7829 (read_from_data_list_fixed) Restructured.
7830 (struct repeating_data_trns) Reordered members. Renamed `starts'
7831 as `starts_beg', `ends' as `starts_end'.
7832 (cmd_repeating_data) Calculates length of repeated data if
7833 necessary and possible.
7834 (parse_num_or_var) Don't allow string variables.
7835 (realize_value) New function.
7836 (rpd_msg) New function.
7837 (rpd_parse_record) New function. Currently stubbed out.
7838 (read_one_set_of_repetitions) Implemented.
7840 * inpt-pgm.c: (input_program_source_read) Comment fix.
7842 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
7844 * command.c: (cmd_end_repeat_p) Removed.
7845 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
7846 (parse_cmd_name) Removed.
7848 * data-list.c: Comment fixes.
7849 (data_list_pgm) Removed `eof' member.
7850 (static var first) New var.
7851 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
7852 FILE TYPE file inside FILE TYPE structures.
7853 (append_var_spec) Appends to *first, not dls.spec.
7854 (parse_fixed) Message fixes.
7855 (struct rpd_num_or_var) New.
7856 (struct repeating_data_trns) New.
7857 (static var rpd) New.
7858 (cmd_repeating_data) New function.
7859 (parse_num_or_var) New function.
7860 (parse_repeating_data) New function.
7861 (read_one_set_of_repetitions) New function.
7863 * file-type.c: (cmd_file_type) Message fixes. Always
7864 default_handle to FILE TYPE file handle.
7865 (internal_cmd_record_type) Message fixes.
7867 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
7869 * repeat.c: Comment fix. Disable debugging.
7871 * temporary.c: (restore_dictionary) Sets splits to NULL and
7872 n_splits to 0 before destroying the variables because now doing
7873 this tries to remove split variables.
7875 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
7876 destroying the dictionary.
7877 (clear_variable) Removes a variable from splits after destroying
7880 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
7882 * cmdline.c: (set_compat) Removed.
7883 (pick_compat) Removed.
7884 (parse_command_line) Removed -c option.
7885 (pre_syntax_message) Removed -c option.
7886 (usage) Remove compatibility code.
7888 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
7889 (glob var compat) Removed.
7891 * compute.c: (type_check) Fixed messages about type mismatches.
7893 * data-list.c: (cmd_data_list) Removed compatibility code.
7894 (fixed_parse_compatible) Calls convert_negative_to_dash().
7895 Fixed bug where it only set the variable in fx.spec if it created
7896 the variable itself.
7897 (dump_fmt_list) Spelling fix.
7898 (cut_field) Removed compatibility code.
7900 * dfm.c: (cmd_begin_data) Don't require a command terminator on
7903 * expr-evl.c: (evaluate_expression) Implement LAG.
7905 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
7906 (parse_neg) Calls convert_negative_to_dash().
7907 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
7910 * expr.h: (struct expression_struct) Removed member max_lag.
7912 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
7913 (internal_cmd_record_type) Removed special handling to produce
7914 negative numbers from dash tokens.
7916 * getline.c: (static var DO_REPEAT_level) New var.
7917 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
7918 (handle_line_buffer) Copies the line into getl_buf; doesn't call
7919 copy_with_DO_REPEAT_substitutions().
7920 (getl_read_line) Maintains value of getl_mode. Calls
7921 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
7923 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
7925 * getline.h: (getl_mode) New glob var.
7927 * glob.c: Comment fixes.
7928 (init_glob) Restructured. Sets set_seed.
7929 (init_compat_dependent) Removed. All references removed.
7930 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
7931 (__htonl, __htons) Removed. (What were these for?)
7933 * lexer.c: (static var tbl) Dash set to class CNUM.
7934 (make_hexit) New function from data-out.c.
7935 (get_token_representation) Rewritten.
7936 (convert_negative_to_dash) New function.
7937 (lex_init_compat_dependent) Removed.
7938 (yylex) A dash is parsed as part of a number if it is followed by
7939 a digit. The ASCII representation of a number is copied to
7940 tokstr. String parsing farmed out to parse_string(). Comment
7942 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
7944 (preprocess_line) Line processing depends on interactive/batch
7945 mode, not on compatibility mode. Removed PC+ compatibility code.
7947 * loop.c: (loop_3_trns_proc) Comment fix.
7949 * main.c: Remove dead code.
7950 (main) Remove call to init_compat_dependent().
7952 * misc.c: (convert_fmt_ItoO) Make E format conversion more
7955 * print.c: (parse_string_argument) Calls
7956 convert_negative_to_dash().
7957 (fixed_parse_compatible) Calls convert_negative_to_dash().
7959 * repeat.c: (RPT_* defines) Removed.
7960 (struct rpt_numeric) Removed.
7961 (struct repeat_entry) New member type, changed `replacement' from
7963 (clean_up) Deallocation adapted to new repeat_entry.
7964 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
7965 usage. Creates vars for `type' of 1.
7966 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
7967 (store_numeric) Rewritten, new interface.
7968 (parse_numbers) Rewritten.
7969 (parse_strings) Rewritten.
7970 (find_DO_REPEAT_substitution) New function.
7971 (perform_DO_REPEAT_substitutions) New function.
7972 (copy_with_DO_REPEAT_substitutions) Removed.
7973 (debug_print) Rewritten.
7975 * set.q: Comment fix.
7976 (custom_results) Removed compatibility code.
7977 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
7980 * sysfile-info.c: (cmd_display) Removed compatibility code.
7982 * tokens.h: Comment fixes.
7983 (token types enum) Removed `toktype' typedef name for this int
7984 type. Removed SUBST. Restructured.
7986 * vars-atr.c: (discard_variables) Sets n_lag to 0.
7988 * vars-prs.c: Comment fix.
7990 * vfm.c: Comment fixes.
7991 (glob var n_lag) New var.
7992 (static vars lag_count, lag_head, lag_queue) New vars.
7993 (procedure) Removed argument nlag.
7994 (setup_lag) New function.
7995 (close_active_file) Discards lagging state.
7996 (lag_case) New function.
7997 (lagged_case) New function.
7998 (write_case) Lags a case if lagging.
8000 * weight.c: (cmd_weight) Removed compatibility code.
8002 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
8004 * getline.h: (struct getl_script) New members loop_index, macros.
8006 * getline.c: (getl_add_file) Sets first_line field to NULL.
8007 (getl_add_DO_REPEAT_file) New function.
8008 (handle_line_buffer) When the current line's length is negative,
8009 set the filename and line number. Increment line number after
8010 reading line. Pass the line to
8011 copy_with_DO_REPEAT_substitutions() for processing.
8012 (getl_close_file) Free DO REPEAT lines before freeing the
8013 filename, and just set the filename to NULL when doing this,
8014 because otherwise the filename gets freed twice.
8016 * glob.c: (glob var queuing) Removed. All references removed.
8018 * lexer.c: Comment fixes.
8019 (get_token_representation) New function.
8021 * repeat.c: Comment fixes.
8022 (struct repeat_entry) Replaced type and v union members with a
8024 (append_record) New function.
8025 (internal_cmd_do_repeat) Started reforming it for the new
8026 repeat_entry struct. Properly records filename changes in the
8027 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
8028 strncasecmp() result usage. Uses append_record() to simplify.
8029 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
8032 (copy_with_DO_REPEAT_substitutions) Started coding.
8034 [DEBUGGING] (debug_print_lines) New function.
8036 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
8038 * tokens.h: (macro is_id1, is_idn) New macros.
8040 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
8042 * cmdline.c: (static var pre_syntax_message) Changed `win'
8043 compatibility mode to `wnd'.
8045 * data-list.c: (fixed_parse_spss) Renamed
8046 fixed_parse_compatible().
8048 * glob.c: (init_glob) Excise unused code for
8049 program_invocation_short_name.
8051 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
8054 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
8056 * set.q: `win' compatibility renamed `wnd'.
8058 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
8060 * filename.c: [__WIN32__] Change the included Windows header files
8062 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
8063 second character is absolute.
8064 (dirname) Fix logic error. Don't printf() the results.
8065 (prepend_dir) Don't printf() the results.
8067 * getline.c: (handle_line_buffer) New function.
8068 (getl_read_line) Reads line with handle_line_buffer() when
8070 (getl_close_file) Discard line buffer data.
8072 * getline.h: Comment fixes.
8073 (struct getl_line_list) New struct.
8074 (getl_script_struct) Added line buffer members. These are hooks
8075 for use by DO REPEAT to allow it to insert virtual source code
8078 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
8079 Override Borland C++ stupidity that claims Windows has a console
8082 * repeat.c: This is in the process of being restructured from
8083 using a token-buffering approach to the DO REPEAT facility to
8084 using the more flexible approach of a line-buffering approach in
8085 conjunction with the getline module. Comment fixes.
8086 (struct tok_struct) Removed.
8087 (static vars queue_index, queue_head, queue) Removed.
8088 (static vars line_buf_head, line_buf_tail) New vars.
8089 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
8091 (pull_queue, destroy_queue) Removed.
8092 [DEBUGGING] (debug_print_tokens) Removed.
8094 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
8096 * file-handle.q: (prepend_current_directory) New function.
8097 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
8098 current directory before normalizing filename.
8100 * filename.c: (gnu_getcwd) New function.
8101 (absolute_filename_p) New function.
8102 (search_path) New argument, PREPEND. All references changed to
8103 pass NULL except those explicitly mentioned. Uses
8104 absolute_filename_p(). Prepends PREPEND before trying the
8106 (dirname, prepend_dir) New functions.
8108 * getline.c: (getl_get_current_directory) New function.
8109 (getl_include) Passes getl_get_current_directory() as PREPEND arg
8112 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
8114 * In several source files, the term `script' was replaced with
8115 `syntax file' inside error messages. Usage of the term `script'
8116 in the sense of a syntax file is now deprecated.
8118 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
8121 * dump-sysfile.c: (usage) Update message.
8123 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
8125 * getline.h: (glob var getl_include_path) Declare extern.
8127 * list.q: Define EXTERN as extern before #including somP.h.
8129 * var.h: Remove declaration of `disptype' variable.
8131 * vfm.c: (close_active_file) After switching the data sink to a
8132 data source, set vfm_sink to NULL, because it doesn't exist any
8135 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
8137 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
8138 _matherrl() to ignore all math errors.
8140 * sfm-read.c: (read_value_labels) When reading the labels from
8141 disk, read the little parts separately instead of as a struct;
8142 this avoids alignment problems.
8144 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
8145 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
8146 (write_header) Allocates and initializes elem_type.
8147 (sfm_write_case) Uses elem_type to determine how to handle each
8149 (sfm_close) Frees elem_type.
8151 * sfmP.h: Comment fix.
8152 [__BORLANDC__] Uses #pragma -a to adjust structure member
8155 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
8157 * Makefile.am: (fiasco_SOURCES) Remove display.c.
8159 * common.c: Fix typo.
8161 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
8162 sense of the condition.
8164 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
8165 line-continuation backslash.
8167 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
8169 * frequencies.q: (custom_grouped, add_percentile) Don't use a
8170 non-constant expression as an argument to sizeof.
8172 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
8173 undefine gettext macro because that's a conio function.
8175 * hash.h: (hsh_prime_tab declaration) Remove.
8177 * list.q: (write_fallback_headers) Move `leader' allocation out of
8178 main loop. Change to local_alloc() allocation.
8180 * output.h: Formatting fixes. Put __attribute__ in right place on
8181 function prototypes.
8183 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
8184 incorrect `SECOND_LOWEST_VALUE' references to proper
8185 `second_lowest_value'.
8187 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
8188 value. This way 2 out of 3 of the som files define the vars
8189 extern, the correct way, that actually works under BC++.
8190 (som_set_float) Don't use nonconstant initializers for a struct.
8192 * som-high.c: Add the standard alloca() header.
8193 (replicate_table) Add prototype.
8195 Merged DISPLAY routine.
8196 * sysfile-info.c: (AS_*) New enum series.
8197 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
8199 (cmd_display, display_macros, display_documents,
8200 display_variables) Stolen from defunct display.c.
8201 (describe_variable) New function.
8203 * temporary.c: [0] (display_tree) New debug function.
8204 (copy_variable) Performs shallow copy of value labels instead of
8205 deep copy; i.e., just copys the AVL tree and increments the
8208 * val-labs.c: Comment fixes.
8209 (do_value_labels) Optionally skip leading forward slash.
8210 (get_label) Creates only a single value label instead of many
8211 copies of one, and sets the reference count.
8213 * display.c: Removed.
8215 * dump-sysfile.c: New file, not yet complete.
8217 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
8219 For lots of source files I added more verbose_msg's. These aren't
8220 listed below as they have tested as being benign. In some cases
8221 these replaced debug_printf() calls.
8223 * output.c: (outp_read_devices) Message fix.
8225 * postscript.c: (output_encodings) Message fix. Reports errors on
8227 (postopen) Message fix.
8229 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
8231 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
8233 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
8236 * main.c: Remove <malloc.h> #include.
8238 * mis-val.c: (parse_numeric) Set .f member for each missing[]
8239 instead of trying to just set the missing[] itself, which is a
8242 * sfm-read.c: (read_variables) Same.
8244 * str.h: Add memmem() prototype.
8246 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
8248 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
8250 * Makefile.am: (q2c) Don't include any libraries in the link.
8252 * dfm.c: (force_line_buffer_extension) New macro.
8253 (count_tabs) New function.
8254 (tabs_To_spaces) New function.
8255 (read_record) Calls tabs_to_spaces() on the line being processed.
8257 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
8258 have to be compiled twice (once for CC, once for LOCAL_CC).
8260 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
8262 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
8263 (LDADD) Add @INTLLIBS@.
8264 (q2c) Add LIBS, @INTLLIBS@ to link step.
8266 * inpt-pgm.c: Turn off debugging.
8268 * postscript.c: (postopen) Format fix. local_free() blocks
8269 returned by local_alloc(); don't free() them.
8271 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
8273 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
8276 * data-list.c: (read_from_data_list_fixed) Pass proper value for
8277 LEN arg, not simply the full string length.
8279 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
8280 directories before generic temp file directories.
8282 * vfm.c: Disable debugging.
8284 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
8286 * get.c: Comment fix.
8287 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
8289 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
8291 * expr-prs.c: (debug_print_postfix) Conditionally included on
8292 GLOBAL_DEBUGGING. Removed out_header() reference.
8294 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
8296 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
8298 * ascii.c: Removed obsolete ascii_close_page() prototype.
8300 * command.c: (output_line) Comment fix.
8302 * data-in.c: Formatting fix.
8303 (parse_string_as_format) Now the `fc' argument is used only for
8304 the purpose of error messages; it is not an index into the string
8305 passed. All references changed.
8307 * data-list.c: Comment fix.
8308 (cut_field) Comment fix. Now returns the column number of the
8309 position of the field cut out on success.
8310 (parse_field) Added `column' argument. Puts the column numbers in
8312 (read_from_data_list_free, read_from_data_list_list) Record the
8313 column number returned by cut_field(), pass it to parse_field().
8315 * dfm.c: Comment fix.
8317 * do-ifP.h: Comment fix.
8319 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
8320 the SYSMIS function.
8322 * expr.h, exprP.h: Comment fix.
8324 * glob.c: (init_glob) Only calls setlocale() and family if
8327 * hash.h: Comment fix.
8329 * include.c: Comment fix.
8331 * output.c: Comment fix.
8333 * postscript.c: (ps_line_intersection) Simplified assertion.
8335 * repeat.c: Comment fix.
8337 * vars-atr.c: Comment fix.
8339 * vars-prs.c: Comment fix.
8341 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
8342 behavior with usage of postincrement.
8343 (memory_stream_read) Discards cases as it goes.
8345 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
8347 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
8350 * Most source files: Includes debug-print.h, related comment
8353 * cases.c: (alloc_val) Removed complex allocation code. Merely
8354 increments default_dict.nval and returns the former value.
8355 (envector, devector) Removed references to lv member of struct
8358 * common.h: (macro VME) Replaced complex definition with simple
8361 * data-list.c: (cmd_data_list) Sets vfm_source instead of
8362 read_active_file and cancel_input_pgm.
8363 (read_from_data_list, cancel_data_list) Removed.
8364 (data_list_source_read, data_list_source_destroy_source) New
8366 (glob var data_list_source) New var.
8368 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
8369 (cmd_begin_data) Improved criteria for an input program accessing
8370 the inline file. Still not perfect.
8372 * do-if.c: (do_if_trns_proc) Simplified debug output.
8374 * expr-prs.c: Comment fixes.
8375 [DEBUGGING] (debug_print_postfix) Simplified debug output.
8377 * file-handle.q: (fh_close_handle) Simplified debug output.
8379 * file-type.c: Comment fixes.
8380 (cmd_file_type) Sets vfm_source instead of read_active_file and
8382 (cmd_end_file_type) On failure, discards variables in place of
8383 just canceling the input program.
8384 (read_from_file_type) Renamed file_type_source_read.
8385 (cancel_file_type) Renamed file_type_source_destroy_source.
8386 (glob var file_type_source) New var.
8388 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
8389 (cmd_get) Initializes options to GTSV_NONE before passing to
8390 trim_dictionary(). Removed `lv' reference. Sets vfm_source
8391 instead of read_active_file and cancel_input_pgm.
8392 (cmd_save_internal) Initializes options before passing to
8393 trim_dictionary(). Local var `nval' removed.
8394 (dict_delete_run) Comment fixes.
8395 (trim_dictionary) Comment fixes. Disallows scratch variables if
8396 GTSV_OPT_SAVE set in options.
8397 (read_from_get) Renamed get_source_read.
8398 (cancel_get) Renamed get_source_destroy_source.
8399 (glob var get_source) New var.
8401 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
8402 read_active_file and cancel_input_pgm.
8403 (read_from_input_program) Renamed input_program_source_read.
8404 Simplified debug output.
8405 (cancel_input_program) Renamed
8406 input_program_source_destroy_source.
8407 (glob var input_program_source) New var.
8409 * loop.c: (loop_1_trns_proc) Simplified debug output.
8411 * main.c: (dump_token) Made eof output more explicit.
8413 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
8416 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
8417 code for always-memory or always-disk cases. malloc's case-list
8418 based on vfm_source_info.ncases. Explicit support for
8419 memory_stream via memory_source_cases.
8420 (do_external_sort) Sets vfm_source instead of read_active_file and
8422 (allocate_file_handles) The temporary directory permissions are
8423 set to 0700 instead of 0777.
8424 (allocate_cases) Formatting fixes. Simplified debug output.
8425 (output_record) Compacts the case if necessary before writing it
8427 (close_handle, open_handle_w) Simplified debug output.
8428 (write_initial_runs) Destroys vfm_sink, then sets it to
8429 sort_stream. Writes records to memory based on
8430 vfm_sink_info.case_size.
8431 (write_to_sort_cases) Renamed sort_stream_write().
8432 (merge) Simplified error handling. Simplified debug output.
8434 (read_from_external_sort) Renamed sort_stream_read().
8435 Reads records based on vfm_source_info.case_size.
8436 (sort_stream_write) Writes records to memory based on
8437 vfm_sink_info.case_size.
8438 (sort_stream_mode) New function.
8439 (glob var sort_stream) New variable.
8441 * temporary.c: (cmd_temporary) Simplified debug output.
8442 (copy_variable) Removed references to `lv'.
8444 * title.c: (get_title) Simplified debug output.
8446 * var.h: Comment fixes.
8447 (struct get_proc) Removed member `lv'.
8448 (struct variable) Removed member `lv'. Comment fixes.
8449 (glob vars read_active_file, write_active_file, cancel_input_pgm)
8451 (struct case_stream) New.
8453 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
8454 read_active_file references to use vfm_source.
8455 (init_variable, replace_variable) Removed references to `lv'.
8457 * vfm.c: Comment fixes.
8458 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
8460 (static var queue, qh, qt, n_lag) Removed. All references
8462 (glob var compaction_necessary, compaction_nval, compaction_case,
8463 paging) New variables.
8464 (record_case) Removed.
8465 (procedure) Comment fixes. Calls vfm_source->read() instead of
8468 (prepare_for_writing, arrange_compaction, make_temp_case,
8469 vector_initialization, setup_filter) New function.
8470 (open_active_file) Most of the code moved into the abovementioned
8471 new functions. Now sets temp_dict to &default_dict if there is no
8472 temporary dictionary, for convenience. New debug output.
8473 (close_active_file) Deals with changing the sink to the source.
8474 Calls finish_compaction(). Frees compaction_case. Mostly
8476 (glob vars disk_source_file, disk_sink_file) New vars.
8477 (destroy_active_file, read_from_memory) Removed.
8478 (disk_stream_init, disk_stream_read, disk_stream_write,
8479 disk_stream_mode, disk_stream_destroy_source,
8480 disk_stream_destroy_sink) New functions.
8481 (glob var vfm_disk_stream) New var.
8482 (glob vars memory_source_cases, memory_sink_cases,
8483 memory_sink_iter, memory_sink_max_cases) New vars.
8484 (memory_stream_init, memory_stream_read, memory_stream_write,
8485 memory_stream_mode, memory_stream_destroy_source,
8486 memory_stream_destroy_sink) New functions.
8487 (glob var vfm_memory_stream) New var.
8488 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
8489 named `more_cases'. Simplified debug output. Otherwise mostly
8491 (record_case) Moved into the stream drivers. Removed.
8492 (transform) Removed (was dead code).
8493 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
8494 common case that the splits don't change, we don't need to copy
8495 the case into prev_case again--pointless.
8496 (compact_case) New function.
8497 (finish_compaction) New function.
8499 * vfmP.h: Comment fixes.
8500 (DEV_* enum series) Removed.
8501 (struct storage) Renamed `stream_info'. Removed variant record.
8502 Removed `device' member.
8504 * debug-print.h: New file.
8506 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
8508 * autorecode.c: Turned off debugging.
8510 * data-list.c: (destroy_dls) Closes the associated file handle.
8512 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
8513 parse_variables() options.
8515 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
8517 * display.c: (display_variables) Really fixed null cell bug.
8519 * file-handle.q: (fh_close_handle) Changed debugging message.
8521 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
8522 parse_variables() options.
8524 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
8525 (cmd_list) Fails if no variables specified.
8526 (determine_layout) Writes blank lines manually.
8528 * loop.c: (loop_1_trns_proc) Made debugging code only print
8529 messages if debugging.
8531 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
8532 parse_variables() arguments.
8533 (main) Parses optional parenthesized options to varlist
8534 subcommands into sbc->message.
8536 * sfm-read.c: Format fix.
8538 * var.h: (FV_*) New enum series.
8539 (PV_*) New enum PV_NO_SCRATCH.
8541 * vars-prs.c: (find_var) Removed.
8542 (fill_all_vars) Takes FV_* enum instead of boolean third
8543 argument. Rewritten to deal with scratch as well as system
8545 (parse_variables) Error message on scratch variable if
8548 * vfm.c: (static var virt_begin_func) New var.
8549 (procedure) Sets up virt_begin_func.
8550 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
8551 after dump_splits(). For succeeding groups changes, calls
8552 virt_begin_func() instead of begin_func().
8554 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
8556 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
8559 * dfm.c: Added some debugging messages, disabled by default.
8560 (open_file_r) Fixed error message.
8561 (read_record) On eof on inline_file, instead of calling
8562 fh_close_handle(), simply jump to eof label like a normal file.
8565 * display.c: Thin lines between rows for certain kinds of
8566 listing. Fixed `null cell' bug.
8568 * error.c: (failure) Flush stdout, stderr before failing.
8570 * file-handle.q: (fh_close_handle) Added debugging message.
8572 * frequencies.q: (dump_full) Bottom line extends across entire
8573 table width. Changed title formatting.
8574 (dump_condensed) Changed title formatting.
8575 (dump_statistics) Fixed title formatting.
8577 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
8578 Sets default value of set_format.
8580 * list.q: (cmd_list) Calls blank_line() before determine_layout().
8581 Passes write_all_headers() to procedure() as pre-group func.
8582 (write_all_headers) New function.
8583 (determine_layout) Removed calls to write_header().
8584 Calls blank_line() before and after write_fallback_headers().
8586 * recode.c: (recode_trns_free) Only attempts to free head->map if
8589 * sfm-read.c: (read_variables) Allows `#' at beginning of system
8590 file variable names but gives a warning. Sets `left' based on
8591 first character being/not being `#'. On lossage frees dict->var.
8593 * som-high.c: (som_draw_title) Simplified title formatting.
8595 * vfm.c: (dump_splits) Fixed and changed splits formatting.
8597 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
8599 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
8600 beginning. Frees v_src, v_dest on successful exit. Frees
8601 h_trans[*], h_trans on lossage.
8602 (recode) Frees h_trans[*], h_trans.
8604 * dfm.c: (dfm_close) Formatting change.
8605 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
8606 longer allocates its own in inline_file.
8607 (open_file_r) Passes the local dfm_fhuser_ext to
8609 (open_file_w) Message fix.
8610 (read_record) Buffer reallocation strategy changed. Frees
8611 ext->line even in inline_file to prevent leaks.
8612 (dfm_put_record) Fixed bug where `ext' was cached before the file
8613 was opened and thus it would be NULL when the file really was
8615 (cmd_begin_data) Sets up inline_file basics itself, then calls
8616 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
8618 * list.q: (write_line) Formatting fix.
8619 (clean_up) Minor strategy change. Sets proportional font after
8621 (determine_layout) Sets fixed font before writing regular headers,
8622 or after writing fallback headers.
8624 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
8625 and KEEP vars after using them.
8627 * postscript.c: (ps_init_driver) Frees x->family.
8628 (postopen) When loading fonts, free the temporary font name buffer
8630 (ps_text_set_font_by_position) Free temporary font name buffer
8632 (text) Fixed code that calculated `lig' so that `lig' always gets
8633 initialized. Formatting fix.
8635 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
8637 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
8638 cells, not xmalloc(), so that the cells will get destroyed
8641 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
8644 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
8646 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
8649 * dfm.c: Comment fix.
8651 * list.q: Comment fixes. Include somP.h. Removed static vars
8652 table, n_columns, n_rows, part. New struct list_ext. New static
8654 (n_lines_remaining, n_chars_width, write_line) New functions.
8655 (cmd_list, list_cases) Rewritten.
8656 (begin_row, end_row, flush_table) Removed.
8657 (write_header, clean_up, write_varname, write_fallback_headers,
8658 determine_layout) New functions.
8660 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
8662 * output.h: Comment fix.
8664 * postscript.c: Comment fix.
8665 (struct ps_driver_ext) Removed prop_size, fixed_size members;
8666 added font_size. All references changed.
8667 (ps_init_driver) Initializes font_size. Simplified space checking
8669 (static var option_tab[]) Removed prop-size, fixed-size; added
8671 (ps_option) Handles font_size.
8673 * som-high.c: Moved prototypes into somP.h.
8674 (som_init_driver) New function.
8675 (som_submit_table) Moved some code into new function
8677 (build_target) Moved some code into new function
8678 som_internal_eject_page().
8679 (som_eject_page) Uses som_internal_eject_page().
8680 (som_internal_eject_page) New function.
8682 * som-low.c: Moved prototypes into somP.h.
8684 * som.h: Formatting fixes.
8686 * somP.h: (struct som_driver_ext) Removed em_width;
8687 added prop_em_width, fixed_width.
8689 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
8691 * Makefile.am: Added `localedir' definition. Added
8692 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
8694 * ascii.c: (macro draw_line) Fixed capitalization.
8696 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
8697 compute.c, count.c, data-in.c, data-list.c, data-out.c,
8698 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
8699 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
8700 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
8701 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
8702 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
8703 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
8704 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
8705 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
8706 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
8707 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
8708 for internationlization.
8710 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
8712 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
8714 * do-if.c, sort.c, val-labs.c: Comment fixes.
8716 * glob.c: (init_glob) Uncommented, updated i18n support.
8718 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
8719 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
8720 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
8721 the declarations of macros taking arguments a lot nicer.
8723 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
8725 * error.h: Removed CE, CW aliases for SE, SW.
8727 * q2c.c: Removed explicit streq() definition since it's duplicated
8730 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
8731 stats.h, str.h, tokens.h: Made the declarations of macros taking
8732 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
8735 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
8737 * cmdline.c: Comment fixes.
8738 (pick_compat) Changed return type to int. Now, instead of setting
8739 glob var `compat' to the emulation, returns the emulation. All
8741 (parse_command_line) Added terminating null to end of
8742 `long_options' array definition.
8743 (pre_syntax_message) Fixes.
8744 (usage) Shows the default emulation in the syntax message by
8745 calling pick_compat().
8747 * getline.c: (getl_add_include_dir) Separates paths with
8748 PATH_DELIMITER, not DIR_SEPARATOR.
8750 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
8751 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
8753 * output.c: (outp_configure_macro) Make earlier definitions for a
8754 particular key override later ones for the same key.
8756 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
8758 * ascii.c: Comment fixes.
8760 * output.c: (outp_get_paper_size)
8761 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
8763 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
8765 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
8766 <errno.h>. GNU libc 2 enforces this!
8768 * command.c: (parse_cmd) Fixed problem with `else' clause being
8769 paired with wrong `if'. Comment fix.
8771 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
8773 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
8774 blp_getline() to getline().
8776 * output.c: (outp_eval_dimension) Changed the fix from last time;
8777 there was no variable `a'.
8779 * q2c.c: (get_line) Fixed boundary condition overrun bug.
8781 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
8783 * output.c: (outp_evaluate_dimension) Fixed handling of negative
8784 numbers having fractional parts. Added case of a fraction without
8785 a whole-number part.
8787 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
8789 * ascii.c: (ascii_text_get_font_position) Removed.
8791 * expr.h, exprP.h: Disabled debugging.
8793 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
8796 * output.h: (struct outp_class_struct) Removed
8797 text_get_font_position method. All references deleted.
8799 * postscript.c: Big change here. Fontmaps were completely
8800 eliminated because of a change in philosophy. Comment fixes.
8801 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
8803 (struct ps_driver_ext) `position', `fontmap', `prop_name',
8804 `fixed_name' members removed. New members `prop_family',
8805 `fixed_family'. `family' member changed to type char *.
8806 (static var ps_fontmaps) Removed.
8808 (ps_init_driver) Removed obsolete references, updated.
8809 Initializes `translate_x', `translate_y', `scale'. Doesn't read
8810 fontmap, of course. Refers to font names through internal_name
8811 rather than subversive means. Frees proper items.
8812 (static var option_tab[]) Removed `fontmap-file' option; renamed
8813 `fixed-font', `prop-font'.
8814 (ps_option) Corresponds to option_tab[].
8815 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
8816 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
8817 hash_family) Removed.
8818 (postopen) Generates font names from family names. Gets
8819 PostScript font name properly. New prologue file comment `!!!'
8821 (ps_open_page) Adds translate_x, translate_y to BP prologue
8822 function; gives SF argument floating-point format.
8823 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
8824 font name. Doesn't change font family.
8825 (ps_text_set_font_by_position) Generates Groff font name from font
8826 family name instead of through table lookup.
8827 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
8828 all references changed. Reduced to simple string assignment.
8829 (ps_get_font_name) Removed.
8830 (ps_get_font_family) Reduced to string return.
8831 (text) Doesn't save `position' since it no longer exists. Ugly
8832 kluge to save font family--fix soon?
8833 (load_font) Removed PostScript name argument.
8835 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
8837 * postscript.c: Comment fix.
8838 (ps_open_page) Puts scale factor in PostScript output.
8840 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
8842 * Makefile.am: Distcleans q2c.
8844 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
8846 * ascii.c: (delineate) Sets text size even if width is zero.
8848 * command.c: Comment fix.
8849 (static var cmd_table[]) Re-enabled EVALUATE command.
8850 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
8851 of comments in script files. Now more liberal on criteria for
8852 performing a state transition--if *anything* happened correctly,
8853 not just if *everything* happened correctly.
8855 * data-out.c: (convert_F) Comment fix. Why in the fsck does
8856 Checker segfault on formatting large numbers and why in the fsck
8857 hadn't I noticed this before?
8859 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
8861 * list.q: (cmd_list) Commented out the actual output routine
8862 because of various problems. Probably will abandon the idea of
8863 using the general `crushed tables' for the LIST procedure.
8865 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
8866 clearing it. Allocates a new var_by_name dictionary before trying
8867 to add members to it.
8869 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
8870 `sib'. Changed type of `node' argument.
8871 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
8873 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
8874 [DEBUGGING] Only deletes the variable from var_by_name if that var
8877 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
8879 * Makefile.am: Added include files to SOURCES. Added
8880 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
8881 includes rules for q2c. Added `boast' target.
8883 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
8885 * Makefile.am: Maintainer-clean Makefile.in.
8887 * Makefile.am: Fixed redundant EXTRA_DIST line.
8889 * ascii.c: Comment fixes.
8890 (ascii_line_vert) Fixed overly aggressive range check.
8892 * display.c: Removed dead code.
8894 * list.q: Turn debugging on.
8895 (flush_table) New debug code.
8897 * sfm-read.c: (read_value_labels) malloc's the structure before
8898 trying to assign to its members.
8900 * sfm-write.c: Comment fix.
8902 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
8904 (output_table) No arguments anymore--gets them through `som'
8905 global. New debug code. In crushed tables, now sets `htv' as
8906 well as `hv' to avoid bad confusion later.
8907 (dump_crush_page) New debug code.
8909 * som-low.c: (som_dump_crush_page) New debug code.
8911 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
8913 All source files: Broke long lines into multiple lines.
8915 * ascii.c: (ascii_close_page) Uses host_system var in place of
8916 HOST_SYSTEM constant.
8918 * cmdline.c: (var syntax_message[]) Broke into
8919 pre_syntax_message[] and post_syntax_message[].
8920 (usage) Outputs both parts, separated by driver list.
8922 * error.h: Fixed broken formatting.
8924 * expr-opt.c: (str_search, str_rsearch) New functions.
8926 * misc.c: (blp_getdelim) Removed. All references changed to
8928 (str_search, str_rsearch) Removed.
8929 (memrmem) New function.
8931 * misc.h: (blp_getline) Removed. All reference changed to
8936 * filename.c: Includes "stat.h", not <sys/stat.h>.
8937 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
8939 * output.c: (outp_list_classes) Changed output formatting.
8941 * sfm-write.c: (write_header) Uses host_system var instead of
8942 HOST_SYSTEM constant.
8943 (write_rec_7_34) Extracts version numbers from the version string.
8946 * sort.c: Includes "stat.h", not <sys/stat.h>.
8948 * str.c: (strcasecmp) Removed.
8950 * title.c: (cmd_document) Uses host_system var instead of
8951 HOST_SYSTEM constant.
8953 * version.c: Generated on-the-fly by the Makefile instead of being
8956 * str.h: Comment fixes. Doesn't substitute for missing memmove or
8958 [!HAVE_STRNCASECMP] Declares strncasecmp().
8960 * version.h: Removed stray character. Comment fixes.
8961 (vars host_system, build_system) New vars.
8963 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
8965 * Most source files: Changed formatting of copyright notice; fixed
8966 FSF address; reformatted to better conform to GNU standards;
8967 comment fixes. Added markups to prevent GNU indent from messing
8968 up my beautiful formatting :-).
8970 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
8971 that GNU indent markups can be passed through without problems.
8973 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
8975 * get.c: Turned off debugging.
8977 * glob.c: (init_glob) Turned on save-file compression by default.
8979 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
8980 compression than was possible in save files.
8982 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
8984 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
8986 * frequencies.q: Removed Fiasco extensions. Updated calculation
8987 algorithms. Polished output format.
8988 (struct frq_info_struct) Removed members `max_degree', `min_n',
8989 all references removed.
8990 (macro frq_extensions) Removed.
8991 (static vars min_n, max_degree) Removed, all references removed.
8992 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
8993 calculate `min_n', `max_degree'.
8994 (postcalc) Passes new arg to dump_statistics().
8995 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
8997 (dump_condensed) Adds variable name title.
8998 (sum_freqs) Removed.
8999 (calc_stats) Updated calculation algorithm.
9000 (dump_statistics) Removed warning for too-few observations.
9001 Changed table formatting. Adds variable name title if passed new
9004 * output.h: Comment fix.
9006 * recode.c, sample.c, sort.c: Disabled debug code.
9008 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
9009 Improved debug code.
9011 * var.h: (enum series frq_*) Removed Fiasco extensions.
9013 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
9015 * command.c: Added PROCESS IF to command table.
9017 * Lots & lots of places, removed checks for NULLs preceding calls
9018 to free_expression(), which itself checks.
9020 * descript.q: Removed Fiasco extensions. Removed optimizations
9021 for non-weighted active files. Implemented some options.
9022 Finished polishing output format. Comment fixes. Merged
9024 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
9025 max_degree, min_n) Removed.
9026 (macro dsc_extensions) Removed.
9027 (struct dsc_info_struct) Removed `min_n' member, all references
9029 (internal_cmd_descriptives) Removed calculation of min_n,
9030 max_degree. Only deals with one `calc' routine instead of two
9032 (precalc) Eliminated redundancy. Updated for changes to
9033 descriptives_proc structure.
9034 (calc) Moved here from `descript.g'. Rewritten to calculate
9035 statistics via `moments about the mean' rather than by summing,
9036 summing squares, summing cubes, and so on.
9037 (postcalc) Rewritten for new-style statistical calculation.
9038 (display) Removed support for displaying variables across rows.
9039 No longer crushes the descriptives table. Removed ancient code.
9040 Added display of N, by variable and listwise.
9042 * descript.g: Removed; merged into `descript.q'.
9044 * expr-evl.c: (evaluate_expression) Now returns a double. For
9045 numeric results, it returns the result as well as storing it in
9046 the passed `value' structure if non-NULL. For string results it
9047 just returns 0.0 and it must be passed non-NULL. Many references
9048 to this function were optimized by use of this change, especially
9049 but not exclusively in `compute.c'.
9051 * frequencies.g: Comment fix.
9053 * glob.c: (glob var process_if_expr) New global var.
9055 * postscript.c: (static var option_tab[]) Corrected entry for
9057 (postopen) Sets x->size to x->prop_size.
9058 (ps_text_set_font_by_name) Sets font size as well as typeface for
9059 PROP and FIXED fonts.
9061 * sel-if.c: (cmd_process_if) New function.
9063 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
9064 (sfm_write_dictionary) Sets `n_cases' to 0.
9065 (sfm_write_case) Increments `n_cases'.
9066 (sfm_close) Attempts to seek the system file back to the header
9067 and write the number of cases in its proper slot.
9069 * som-frnt.c: (som_insert_table) Masks off expansion options since
9070 only SOPT_X_NORM seems to work sensibly.
9072 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
9073 with a `fixed' value of 2.
9075 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
9077 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
9078 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
9080 * var.h: (enum series dsc_*) Removed Fiasco extensions.
9081 (struct descriptives_proc) Removed `miss_noweight'; new members
9082 `X_bar', `M2', `M3', `M4', `min', `max'.
9084 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
9086 * vfm.c: (close_active_file) Cancels PROCESS IF.
9087 (write_case) Doesn't process cases unselected by PROCESS IF.
9089 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
9091 * glob.c: (glob var err) Removed.
9093 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
9094 doesn't have to take into account number of value labels since
9095 they're in a subtable anyway. Also, doesn't display more than 10
9096 value labels since we can't yet break pages in subtables.
9098 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
9100 * som-frnt.c: (som_change_table_size) Simple change for elegance
9101 that shouldn't change behavior.
9102 (som_set_value) Comment fix.
9104 * som-high.c: (som_submit_table) Message fix.
9106 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
9108 * command.c: Added SYSFILE INFO to command table.
9110 * file-handle.q: (fh_handle_filename) New function.
9112 * get.c: (save_trns_proc) Fixed a bug in padding of output data
9115 * main.c: (parse) New return value for command functions, -3.
9117 * misc.h: Comment fix.
9119 * output.h: Comment fixes.
9120 (macro COMPONENTS) Removed.
9122 * postscript.c: (write_text) Modified literal_chars[] so that `('
9123 and ')' are not written to the output in strings as literals.
9125 * sfm-read.c: (sfm_read_dictionary) New argument.
9126 (read_header) New argument. Sets the information structure's
9127 values from the header information.
9128 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
9129 bizarre Checker problem, I guess.
9130 (read_variables) Proper cleanup on lossage.
9132 * sfm.h: (struct sfm_read_info) New struct for use by
9133 sfm_read_dictionary().
9135 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
9136 currently used just for tables that can be dynamically resized and
9137 thus have to be allocated with arena_malloc() instead of
9138 arena_alloc(). All references changed.
9139 (som_change_table_size) New function.
9140 (som_insert_table) Bugfix: now inserts `cell', not `c'!
9142 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
9143 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
9146 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
9148 (draw_intersection) Now takes an argument specifying the table in
9149 question. All references changed.
9150 (draw_table_cell) New function.
9151 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
9152 (som_get_table_size) Many nice new explanatory comments.
9153 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
9155 * som.h: New enum series SOM_CREATE_* for use as create flags with
9158 * str.h: Moved a comment here from TODO.
9160 * sysfile-info.c: New file. Reference implementation.
9162 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
9164 * command.c: Added RENAME VARIABLES to table of commands.
9166 * data-in.c: (dls_error) Sets `cust_field'.
9167 (parse_N) Message fix.
9168 (parse_day_count) New function.
9169 (to_roman) Never outputs VX as a `short form' of V.
9170 (parse_month) Fixed parsing of Roman numerals.
9171 (parse_trailer) Message fix.
9172 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
9173 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
9174 the date is invalid.
9175 (parse_SDATE) Fixed swapped day, year.
9176 (parse_JDATE) Fixed bug for dates in 1582.
9177 (parse_DTIME) Allows days not between 1 and 31.
9178 (parse_numeric) Makes local copy of f.type for easier usage.
9181 * data-out.c: (convert_F) When outputting as scientific, properly
9182 sets f.type as fp->type.
9183 (insert_commas) Fixed operator precedence problem with setting of
9184 nitems. Changed strcpy to memcpy (no null terminator).
9185 (convert_date) Fixed FMT_JDATE: added 1900 to year.
9186 (convert_CCx) Essentially rewritten, but now it works.
9188 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
9190 (display_documents) Implemented.
9192 * error.c: (glob var cust_field) New var.
9193 (vmsg) Displays cust_field as part of message classes DE and DW.
9195 * formats.c: (debug_print) Fixed to compile under updated
9198 * get.c: (cmd_get, cmd_save_internal) Close file handle on
9201 * misc.c: (parse_format_specifier) Formatting fix.
9203 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
9204 `n_rename' for clarity.
9205 (cmd_modify_vars) Initializes `forward' and `positional' at
9206 appropriate times. Frees lists of vars to rename on failure.
9207 Comment fix. Frees memory on success.
9208 (rearrange_dict) Simplified `for' loop condition.
9210 * rename-vars.c: New file (reference implementation).
9212 * set.q: (internal_cmd_set) Fixed `emu' test condition.
9214 * sfm-read.c: (read_header) File label is created only if file
9215 label in file is not blank.
9216 (read_variables) Initializes `dict' local variable.
9217 (read_documents) Proper behavior on lossage.
9219 * sfm-write.c: (write_header) Doesn't blank out the file label
9220 (why was this here to begin with?!)
9222 * temporary.c: (save_dictionary) File label is copied only if
9223 non-NULL. Doesn't try to xstrdup() dictionary documents.
9224 Adapted so as to not irritate Checker.
9225 (free_dictionary) Only destroys var_by_name if non-NULL.
9227 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
9228 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
9229 lines to the document, indents the document. Also, it works now.
9230 (add_document_line) New function.
9232 * var.h: (struct dictionary) Reordering.
9234 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
9235 bits if it was allocated to begin with.
9237 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
9239 * command.c: Added MODIFY VARS to list of commands.
9241 * configure.in: Updated custom macros for autoconf 2.12. Removed
9242 mmap reference; fixed termcap library reference.
9244 * display.c: (display_variables) Fixed a few bugs although it's
9245 still not well written.
9247 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
9248 (induce_segfault) Calls chkr_disp_call_chain() instead of
9249 inducing an actual SIGSEGV.
9251 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
9252 str_search() and str_rsearch(). Fixed tests for matches on
9253 OP_INDEX and OP_RINDEX.
9255 * filename.c: (good_getcwd) Removed as the new libc for Checker
9256 doesn't contain this bug, apparently.
9258 * misc.c: (str_search, str_rsearch) Changed order of arguments for
9259 consistency with GNU memmem.
9260 (blp_getdelim) Changed `len' from `int' to `size_t'.
9262 * modify-vars.c: Reference implementation.
9264 * som-frnt.c: (zero_length) New global var.
9265 (som_create_table) Message fix.
9267 * som.h: Added gcc attributions to som_set_text(),
9268 som_output_text() prototypes. blank_line() refers to
9269 zero_length[] instead of a literal null string to suppress gcc
9272 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
9273 (allocate_cases) Decrements x_max so the last element of x[] can
9274 be used by the algorithm.
9276 * var.h: Changed minor details of `variable' declaration.
9277 (struct modify_vars_proc) New struct.
9278 (struct variable) Added field p.mfv.
9280 * vars-atr.c: Comment fix.
9282 * vars-prs.c: (fill_all_vars) More optimal implementation.
9284 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
9285 character, which it shouldn't have to do but printf() seems to
9286 read the null byte even though I supply a maximum length...
9288 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
9290 * command.c: Removed command alias X for QUIT.
9291 (parse_cmd) Fixed comment parsing.
9293 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
9295 (read_record) Fixed references to len, size.
9296 (dfm_get_record) Restructured.
9298 * file-handle.h: (struct file_handle) Field `lrecl' now of type
9301 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
9304 * modify-vars.c: New file. Not complete.
9306 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
9309 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
9310 problems caused by int/size_t differences.
9312 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
9315 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
9316 being compared were of equal length.
9318 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
9320 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
9322 * lexer.c: (get_dotted_rest_of_line) New function.
9324 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
9327 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
9328 type 6 records. Frees the dictionary properly.
9329 (read_header) Initializes the dictionary instead of letting
9330 read_variables() do it. Sets the dictionary file label from the
9332 (read_documents) New function.
9334 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
9335 write type 6 record if appropriate.
9336 (write_header) Writes file label from dictionary.
9337 (write_documents) New function.
9339 * temporary.c: (save_dictionary, restore_dictionary,
9340 free_dictionary) Properly handle new fields in dictionary struct.
9342 * title.c: (get_title) Returns after failure().
9343 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
9344 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
9346 * var.h: (struct dictionary) New fields `label', `n_documents',
9349 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
9351 * command.c: Added FILTER to list of commands.
9353 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
9356 * get.c: (cmd_save_internal) Removed weighting code since it's now
9357 handled by sfm-write.c. Properly commented out debug code.
9359 * glob.c: (glob var weighting) Removed.
9361 * sel-if.c: Comment fixes.
9362 (cmd_filter) New function.
9364 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
9365 (sfm_read_dictionary) Sets weighting variable direct in the
9366 created dictionary now. (Apparently we previously didn't support
9368 (read_header) Sets weight_index field in sfm_fhuser_ext from
9369 header read from disk.
9371 * sfm-write.c: (sfm_write_dictionary) Comment fix.
9372 (write_header) Now sets the weighting in the header from the
9373 passed primary dictionary instead of from the sfm_write_info.
9375 * sfm.h: (struct sfm_write_info) Removed field `weight'.
9377 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
9378 broke on boundary conditions.
9380 * var.h: (struct dictionary) New fields `weight_var',
9381 `weight_index', and `filter_var'.
9382 (glob var weighting) Removed. This is now part of struct
9383 dictionary. All references changed; the less mechanical changes
9384 are described above.
9386 * vars-atr.c: (find_dict_variable) New function.
9388 * vfm.c: (static var filter_index) New variable.
9389 (open_active_file) Initializes filter_index from default_dict.
9390 (write_case) Calls proc_func() only if the filter variable is
9391 nonzero; this implements FILTER behavior.
9393 * weight.c: (static var weight_varname) Removed.
9394 (cmd_weight) Modified default_dict instead of glob vars.
9395 (update_weighting) Changed the signature to modify a dictionary
9396 instead of glob vars. Now returns the weighting variable.
9397 (get_weighting_variable) Removed; its function is absorbed by
9399 (stop_weighting) Operates on a dictionary now.
9401 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
9403 * sort.c: Removed debugging info from messages.
9404 (do_external_sort) Cleans up after itself by deleting the
9405 temporary directory on failure. (On success it is deleted by the
9407 (allocate_cases) Removed debug code. Added clean up code.
9408 (output_record) Removed debug code.
9409 (merge) Added code to close all the input files that are currently
9410 open. This is a likely location for bugs, because I'm not sure
9411 about boundary conditions. Removed an unnecesary heap_delete().
9412 (merge_once) Removed input file "optimization" that in fact
9413 screwed up the rest of the code. Message and comment fixes.
9415 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
9417 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
9419 * heap.c: (heap_delete) New argument.
9421 * sort.c: Finished implementation of external sort.
9423 * vfm.c: (read_from_disk) Returns after a disk error.
9425 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
9427 * sort.c: (static var state) Removed.
9428 (static vars max_handles, tmp_basename, tmp_extname,
9429 huffman_queue) New variables.
9430 (do_external_sort) Moved most code to new functions.
9431 Creates huffman_queue.
9432 (allocate_file_handles, allocate_cases) New functions.
9433 (static vars run_no, run_length, file_index, case_count) New
9435 (output_record) Returns success. Now really writes to the output
9437 (begin_run, end_run) New functions.
9438 (write_initial_runs) Returns success. Initializes run_no to -1.
9439 Calls begin_run(), end_run() at appropriate times. Outputs debug
9441 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
9443 (merge) New function.
9445 * heap.c, heap.h: New files. Hopefully in near-final form.
9447 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
9449 * glob.c: Added write_active_file to global vars.
9451 * sort.c: Several new miscellaneous static variables.
9452 (cmd_sort_cases) Big comment fix.
9453 (perform_case_2) Renamed `do_external_sort' and completely
9455 (case_2_proc_func) Removed.
9456 (output_record, write_initial_runs, write_to_sort_cases,
9457 compare_record) New functions.
9459 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
9461 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
9463 * sort.c: (perform_case_2) Changed the method for allocation of
9464 lots of memory--now allocates one case at a time in hopes that
9465 more cases can be allocated with heavily fragmented memory.
9467 * var.h: (write_active_file) New global var.
9469 * vfm.c: (procedure, close_active_file, write_case,
9470 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
9471 arguments to procedure() to be NULL. All references to
9472 procedure() that made use of dummy functions were changed to NULL
9474 (open_active_file) If write_active_file is non-NULL, the output
9475 device becomes DEV_PGM (a new enum).
9476 (close_active_file) Sets write_active_file to NULL.
9477 (read_from_memory) Comment fix.
9478 (record_case) Calls write_active_file() when the output device is
9481 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
9485 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
9486 Fixed checking for duplicate varnames.
9487 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
9489 (autorecode_trns_free) Destroys hash tables for each recoding
9491 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
9493 * command.c: Added SORT CASES to cmd_table.
9494 (null_func, null_int_func) Prototyped.
9496 * descript.g: (calc_weight, calc_noweight) Computes own case
9499 * frequencies.q: (dump_statistics) Fixed problem with
9500 too-few-cases warning message.
9502 * get.c: (cmd_save_internal) Handles weighting properly.
9504 * hash.c: (hsh_dump) Output format changed.
9505 (force_hsh_insert) Actually works now, prototype changed.
9507 * list.q: (static var case_num) New variable.
9508 (cmd_list) Initializes case_num.
9509 (list_cases) Increments case_num.
9511 * var.h: Added definitions for SORT CASES. Comment fixes.
9513 * vfm.c: Some definitions moved to new file vfmP.h. Comment
9514 fixes. `active' renamed vfm_active, `rep' renamed
9515 vfm_replacement, all references changed.
9516 (procedure) The procfunc no longer receives a case number. All
9518 (write_case) Subtle reordering.
9519 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
9522 * weight.c: (get_weighting_variable) New function.
9524 * vfmP.h: New file with definitions from vfm.c.
9526 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
9528 * command.c: (FILE_TYPE_okay) Commented out some tests because
9529 they're clumsy and not yet needed.
9531 * var.h: Most *_trns structures moved to their respective source
9532 files. Some were moved into a new file, do-ifP.h. Comment fixes.
9533 (union any_trns) Changed to a typedef for trns_header.
9534 (struct input_program_pgm) Removed.
9536 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
9537 was allocated in the first place.
9539 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
9541 * autorecode.c: New file.
9543 * command.c: Added AUTORECODE to command table; re-enabled SET.
9545 * data-out.c: (convert_F) Handles infinities and NaNs properly.
9547 * error.c: (vmsg) Comment fixes.
9549 * hash.c: Comment fix.
9550 (hashpjw_d) New function.
9551 (hashpjw) Reimplemented as call to more general function
9553 (internal_comparison_fn) Initializes pointers properly.
9554 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
9555 (force_hsh_insert, force_hsh_find) New debugging wrapper
9558 * main.c: (main) Message fix.
9560 * output.c: (outp_read_devices) Message fix.
9562 * set.q: Comment fixes.
9563 (custom_results) Implemented Wnd/X form of subcommand.
9564 (set_routing) New function.
9565 (internal_cmd_set) Implemented ERRORS, MESSAGES.
9567 * settings.h: (SET_ROUTE_*) New enum series.
9568 (set_results) Renamed set_results_file, all references changed.
9569 (set_messages) Removed.
9570 (glob vars set_errors, set_messages, set_results) New vars.
9572 * title.c: (get_title) Remembers to xstrdup() the result of
9575 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
9577 (union any_trns) New element `arc'.
9579 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
9581 * command.c: (output_line) Removed references to set_screen.
9583 * error.c: (static var terminating) New var.
9584 (hcf) Sets terminating to 1.
9585 (vmsg) If terminating is nonzero, does not attempt to call hcf().
9586 This prevents an infinite loop if an error occurs within hcf().
9588 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
9589 statement circumlocution with `case 42000' trick.
9590 (evaluate_expression) New support for OP_STR_MIS.
9592 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
9593 statement circumlocution with `case 42000' trick.
9594 (dump_node) Handles OP_STR_MIS.
9596 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
9597 variables exceptions.
9598 (parse_function) Message fix.
9599 (ops[]) Added OP_STR_MIS.
9601 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
9603 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
9605 * glob.c: Removed set_scrnfile glob var.
9606 (init_glob) set_errorbreak set to 0 by default.
9608 * groff-font.c: Changed included files.
9609 (groff_read_font) Initializes font_arena local var correctly.
9610 (default_font) New function.
9612 * output.c: Comment fixes.
9613 (glob var disabled_devices) New variable.
9614 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
9616 [GLOBAL_DEBUGGING] (reentrancy) New function.
9617 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
9618 outp_iterate_enabled_drivers) Calls to reentrancy().
9619 (destroy_list) New function.
9620 (outp_done) Moved code to destroy_list().
9621 (parse_options) Parses `listing', `screen', `printer' options
9623 (configure_driver) Sets new `device' member of driver.
9624 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
9626 * output.h: Comment fixes. New enum series OUTP_DEV_*.
9627 (struct outp_driver_struct) New member `device'.
9629 * postscript.c: (find_encoding_file) Doesn't display its own error
9631 (default_encoding) New function.
9632 (switch_font) Calls default_encoding() if no encoding can be
9634 (text) Makes up a character metric if none exists for the desired
9636 (load_font) Properly copies a fallback filename. Calls
9637 default_font() for a font if none at all are known.
9639 * set.q: Comment fixes. Removed OUTPUT subcommand.
9640 (custom_listing) Calls outp_enable_device() to enable/disable
9642 (turn_screen_on) Removed.
9643 (internal_cmd_set) Calls outp_enable_device() to enable/disable
9644 screen, printer devices.
9646 * settings.h: Comment fixes.
9647 (glob vars set_output, set_printer, set_screen, set_scrnfile)
9650 * som-high.c: (som_submit_table, som_eject_page) Use
9651 outp_iterate_enabled_drivers() instead of iterating
9652 outp_driver_list directly.
9654 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
9656 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
9657 (parse_string_as_format) Handles new formats.
9658 (parse_numeric) Now handles DOT and PCT formats.
9660 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
9662 (convert_date) Handle EDATE and SDATE formats.
9663 (convert_CCx) Now if there's not room for the currency characters,
9664 converts it as F format if it's positive instead of giving up
9665 quickly. Also fixed save-and-restore bug with decimal point
9667 (convert_format_to_string) Handles new formats.
9669 * misc.c: (formats[]) Added new formats.
9670 (convert_fmt_ItoO) Supports new formats.
9672 * sfm-read.c: (parse_format_spec) Supports new formats. Better
9673 data checking. New argument, all references changed.
9675 * sfm-write.c: (write_format_spec) Supports new formats.
9677 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
9680 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
9682 * cmdline.c: Comment fixes.
9683 (parse_command_line) Changed return type to void.
9685 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
9687 (parse_numeric) Handles international numbers (comma as decimal
9688 point). Some reformatting.
9690 * data-list.c: (parse_free) Default output format is now
9691 set_format instead of hard-coded F8.2.
9692 (read_from_data_list_list) Emits error message on undefined data
9693 only if set_undefined is nonzero.
9695 * data-out.c: (convert_E) Changes decimal point from period to
9696 comma if appropriate. Restructured. Better comments.
9697 (convert_F) Changes decimal point from period to comma if
9699 (insert_commas) Major bug with handling of negative values fixed.
9700 Also, inserts periods instead of commas if appropriate.
9701 (convert_CCx) New function.
9702 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
9703 (num_to_string) Changed `.' to set_decimal.
9705 * dfm.c: Comment fixes.
9706 (dfm_close) Frees ext->line even in inline_file.
9707 (open_inline_file) New function.
9708 (open_file_r) When opening the inline file: now properly
9709 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
9711 (read_record) Calls fh_close_handle() instead of dfm_close() to
9712 close the inline file. Makes a copy of the line getl_buf to avoid
9714 (dfm_get_record) Restructured. Now checks the return value of
9716 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
9717 checking for use of inline file. No longer tries to close inline
9720 * error.c: (glob var error_already_flagged) New var.
9721 (vmsg) Message change. Now checks max number of errors/warnings,
9724 * file-handle.q: (fh_handle_name) Now allows closing of
9726 (fh_init_files) Reformatted.
9728 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
9730 * getline.c: (getl_include) Fixed bug that popped up when called
9731 when file queue was empty.
9732 (read_console) Resets error_count, warning_count,
9733 error_already_flagged to zero.
9735 * glob.c: Many changes to update list of variables.
9736 (init_compat_dependent) Now this function is called whenever
9737 `compat' changes. It now sets set_seed only if it hasn't
9738 previously been referenced. It now calls
9739 lex_init_compat_dependent().
9741 * include.c: (cmd_include_at) Frees temporary buffer instead of
9743 (cmd_include) Doesn't make copy of include file name.
9745 * lexer.c: Comment fixes.
9746 (init_lex) Moved some code into new function
9747 lex_init_compat_dependent().
9748 (lex_init_compat_dependent) New function.
9749 (hex_val) Simplified.
9750 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
9752 * main.c: Comment fixes.
9755 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
9756 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
9757 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
9758 (setup_randomize) Sets set_seed_used.
9760 * set.q: Comment fixes.
9761 (custom_results) Conditionalizes on `compat'.
9762 (custom_log) Calls custom_journal().
9763 (set_ccx) New function.
9764 (cmd_set) Calls init_compat_dependent() when `compat' changes.
9765 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
9766 when set_decimal changes. Range-checks values for MITERATE,
9767 MNEST. Message fixes.
9769 * settings.h: Comment fixes.
9770 (struct set_cust_currency) New struct.
9771 (set_cc[], set_grouping, set_seed_used) New global vars.
9773 * var.h: (FMT_CCA...FMT_CCE) New output formats.
9774 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
9776 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
9778 * glob.c: Revised variables to correspond to settings.h.
9779 (init_glob) Initializes variables from settings.h properly.
9781 * set.q: Began long-overdue major revision to correspond to new
9782 philosophy. Most code changed.
9784 * settings.h: Mostly changed; reorganized, reordered, large new
9787 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
9789 * get.c: (cmd_save_internal) No longer forces compression off.
9791 * sfm-read.c: (read_compressed_data) If eof is reached when
9792 reading a new instruction octet, only signal error if we're in the
9795 * sfm-write.c: (COMPRESSION_BIAS) New #define.
9796 (struct sfm_fhuser_ext) New member `end'.
9797 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
9798 (ensure_buf_space) New function.
9799 (sfm_write_case) Reimplemented in order to support compression.
9800 (sfm_close) Writes out the remaining contents of the compression
9803 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
9805 * command.c: Defined SAVE and XSAVE commands in command table.
9807 * common.h: second_lowest_value is of type flt64, not double.
9809 * file-handle.h: Comment fix.
9811 * get.c: Comment fixes.
9812 (static var `trns') New.
9813 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
9814 cmd_save_internal, cmd_save, cmd_xsave) New functions.
9815 (dict_delete_run) Clears the variables and frees them now.
9816 (trim_dictionary) Sets default for compression.
9817 On KEEP subcommand, frees deleted variables as well as clearing
9818 them. Finally got the sense of the test for deleting all
9820 [DEBUGGING] (dump_dict_variables) Message fix.
9822 * glob.c: (init_glob) set_compression set to 1 by default.
9824 * list.q: Properly #includes config.h.
9826 * misc.h: New macro REM_RND_UP.
9828 * settings.h: Comment fix.
9830 * sfm-read.c: (structs sysfile_header, sysfile_format,
9831 sysfile_variable; inline function bswap_int32) Moved to new file
9833 (corrupt_msg) [__CHECKER__] No longer induces segfault.
9834 (sfm_read_dictionary) Fixed bug caused by failing to initialize
9836 (read_machine_flt64_info) Fixed some problems caused by confusion
9837 between flt64 and double types.
9838 (read_header) Message fix.
9839 (read_variables) Fixed set of cases in which we byte-swap sv.print
9840 and sv.write. Fixed confusion of flt64 and double.
9842 * sfm.h: (struct sfm_write_info) New.
9844 * som-high.c: (som_draw_title) Properly frees `s'.
9846 * temporary.c: (save_dictionary) Comment fix.
9848 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
9849 (struct trns_header) Formatting fix.
9850 (struct save_trns) New.
9852 * vars-atr.c: (discard_variables) Comment fix.
9854 * sfm-write.c: New file, baseline release.
9856 * sfmP.h: New file, baseline release.
9858 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
9860 * cmdline.c: (parse_command_line) `--version' output updated.
9861 (glob var syntax_message[]) Added my e-mail address.
9863 * file-handle.q, lexer.c, vfm.c: Changed many instances of
9864 `illegal' to `invalid'.
9866 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
9867 uncompression buffer.
9868 (sfm_close) Frees decompression buffer.
9869 (sfm_read_dictionary) Initializes decompression buffer.
9870 (buffer_input, read_compressed_data) New functions.
9871 (sfm_read_case) Restructured; now calls read_compressed_data() to
9872 handle compressed system file data.
9874 * var.h: Comment fix.
9876 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
9878 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
9881 * get.c: New comments. New static var `get_file'.
9882 (cmd_get) Now fully implemented. Calls discard_variables();
9883 initializes fv and lv for all variables; new debug code; sets
9884 up the dictionary; sets up the input program.
9885 (read_from_get, cancel_get) New functions.
9887 * sfm-read.c: Comment fixes.
9888 (sfm_close) New static function.
9889 (sfm_read_dictionary) Properly sets up the class of the
9890 file_handle. No longer cares what size the data is in records of
9891 type 7. Also, on failure, properly cleans up the file_handle and
9893 (read_variables) No longer thinks it knows `nval' of the
9894 dictionary. Now sets p.get.fv, etc., instead of speculatively
9896 (read_value_labels) Fixed off-by-one error in indexing of
9898 (sfm_read_case) New function.
9899 (sfm_r_class) New static var.
9901 * var.h: (get_proc) New struct.
9902 (struct variable) New member p.get.
9904 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
9906 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
9907 the manual's meaning.
9908 (rename_variables) New function.
9909 (trim_variables) Doesn't try to parse MAP any more. Removed debug
9910 code. Now properly reorders the dictionary on the KEEP keyword.
9912 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
9915 * vars-atr.c: (clear_variable) New argument `dictionary *'.
9916 (rename_variable) New function.
9917 (free_val_lab) Reformatted.
9919 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
9921 * var.h: Reindented entire file. Comment fixes.
9922 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
9924 (glob var default_dict) New.
9925 (struct indirect_dictionary) Removed.
9927 * Many other source files were changed to add `default_dict.'
9928 before all references to the dictionary of the active file.
9930 * vars-atr.c: (make_indirect_dictionary) Removed.
9932 * glob.c: Reindented all variable declarations. Updated for
9933 changed var.h. Comment fixes.
9935 * temporary.c: (restore_dictionary, save_dictionary) Simplified
9936 because now we can mainly copy dictionary structs.
9938 * vars-prs.c: (is_dict_varname, parse_dict_variable,
9939 parse_variables) Takes dictionary instead of indirect_dictionary
9941 (parse_variables) Instead of calling make_indirect_dictionary,
9942 just sets DICT to &default_dict if DICT is NULL. Of course, lots
9943 of `*dict.' references had to be changed to `dict->'. Removed
9946 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
9948 * get.c: Added GTSV_OPT_* series of enums.
9949 (trim_dictionary, dict_delete_run) New functions.
9950 [DEBUGGING] (dump_dict_variables) New function.
9951 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
9952 [DEBUGGING] Calls dump_dict_variables() to display results.
9954 * glob.c: (cmp_variable) Now a public function declared in var.h.
9956 * sfm-read.c: Turned off debug code. Comment fixes.
9957 (read_machine_int32_info, read_machine_flt64_info) New functions
9958 to parse type 7 records.
9959 (sfm_read_dictionary) Properly byteswaps several fields now.
9960 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
9961 records. [DEBUGGING] Dumps dictionary.
9962 (read_variables) Sets `index' field of variables created properly.
9963 Constructs avl tree of variables in dictionary. [DEBUGGING] No
9964 longer dumps dictionary.
9965 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
9967 [DEBUGGING] (dump_dictionary) No longer stubbed out.
9969 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
9970 var before destroying any variables just to save a little time.
9972 * var.h: (struct variable) Reordered in order to make name[] the
9973 first member; this makes pointers to `variable' pointers to the
9974 variable name, simplifying avl trees, etc.
9975 (struct indirect_dictionary) New struct.
9977 * vars-atr.c: (find_variable) Rewritten for efficiency.
9978 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
9980 (is_varname) Rewritten for efficiency.
9981 (parse_variables) New argument, which is a `dictionary *'. All
9982 references changed. This function now reads variable names from
9983 the dictionary passed, or from the default dictionary if NULL.
9985 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
9987 * misc.h: Added new macro DIV_RND_UP to perform integer division,
9988 rounding up. Changed many references to ROUND_UP to use this
9991 * sfm-read.c: Includes avl.h.
9992 (corrupt_msg) Induces a segfault under Checker.
9993 (macro assertive_bufread) New. Many references to bufread() now
9995 (sfm_read_dictionary) Split up into several functions. Added code
9996 to read dictionary records following the the type 2 records. Not
9997 quite complete. New variable `var_by_index'.
9998 (read_header, read_variables) New functions extracted from
9999 sfm_read_dictionary().
10000 (read_value_labels) New function.
10001 (bufread) Checks ferror() if fread() doesn't return the expected
10002 value; if ferror() is zero it's just EOF.
10003 (dump_dictionary) Stubbed out.
10005 * BTW: The source code now exceeds 50000 lines!
10007 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
10009 * command.c: Added GET to cmd_table[].
10011 * list.q: Removed reference to alloca headers.
10012 (cmd_list) Gave prototype.
10014 * sfm-read.c: Added DEBUGGING comments.
10015 (sfm_read_dictionary) Checks bias correctly. Sets
10016 dict->var_by_name to NULL. Calculates long_string_count
10017 correctly. realloc's dict->var[] array to minimum size.
10018 [DEBUGGING] Calls dump_dictionary.
10019 [DEBUGGING] (dump_dictionary) New function.
10021 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
10022 (restore_dictionary) If the dictionary contains a non-NULL
10023 var_by_name, uses that instead of generating one.
10024 (free_dictionary) Destroys var_by_name.
10026 * var.h: (struct dictionary) Added field `var_by_name'.
10028 * get.c: New file, not complete.
10030 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
10032 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
10033 (parse_num_or_range) New function.
10034 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
10035 <n> THRU HIGH missing values.
10037 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
10038 __attribute__((const)).
10040 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
10042 * sfm-read.c: Finished reference implementation.
10044 * sfm.h: Includes var.h.
10046 * var.h: Comment fixes.
10047 (struct `variable') Reordered some fields.
10049 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
10050 constants added previously.
10052 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
10054 * common.h: Comment fixes. Added declaration of
10055 `second_lowest_value' as variable or macro. Made `compat_type',
10056 `pgm_state_type' into anonymous enums.
10058 * display.c: Comment fix.
10060 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
10062 [!defined SECOND_LOWEST_VALUE] Added definition for
10063 `second_lowest_value' global var.
10064 (compat, pgm_state global vars) Changed types to `int'.
10065 (init_glob) Initializes `second_lowest_value'.
10067 * sfm-read.c: Continued work, not complete.
10069 * var.h: Added new MISSING_* constants to handle LOWEST and
10072 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
10074 * sfm-read.c: New file, not complete.
10076 * cases.c: (vec_insert) Changed vector expansion algorithm.
10077 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
10078 mucking up the RECODE transformation in particular.
10079 (envector) Harmless change in notation.
10081 dfm is now fairly well tested again.
10082 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
10084 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
10086 * recode.c: Comment fix.
10088 * sfm.h: Interface should be fairly final now, or at least for a
10091 * vfm.c: [DEBUGGING] (index_to_varname) New function.
10092 (open_active_file) [DEBUGGING] Translates ccase indices into
10093 variable names now to make it easier to understand what's really
10096 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
10098 * data-in.c: Comment fix.
10100 * data-list.c: Includes dfm.h.
10101 (do_reading) Uses new function dfm_push_cust().
10103 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
10104 `return 1;' at end.
10106 * file-handle.h: Completely changed. Some parts split off into
10107 new file dfm.h. Implemented in file-handle.q.
10108 (enum FH_*) Removed.
10109 (struct fh_ext_class) New struct.
10110 (struct file_handle) Retained only these fields: name, norm_fn,
10111 fn, recform, lrecl, mode. New fields class, ext.
10112 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
10113 close_handle, handle_name) Added `fh_' prefix to name, all
10114 references changed.
10116 * dfm.h: New file, implemented in dfm.c.
10117 (get_record, put_record, fwd_record, bkwd_record, set_record,
10118 get_cur_col) Functions moved from file-handle.h, now prefixed with
10120 (dfm_push_cust) New function.
10122 * sfm.h: New file. Incomplete.
10124 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
10125 interface. Functions reordered, comments changed. Not well
10126 tested, probably full of bugs.
10127 (struct dfm_fhuser_ext) New struct.
10128 (dfm_close) New function.
10129 (open_file_r) Pickier about finding `BEGIN DATA.' line.
10130 (open_file_w) User messages changed.
10131 (get_record) Comment fixed.
10132 (read_record) Increments ext->ln even for inline_file. Calls
10133 dfm_close() for inline_file when `END DATA.' encountered.
10134 (dfm_get_record) Experimental restructuring.
10135 (dfm_push_cust) New function.
10136 (cmd_begin_data) Detects whether the inline file was fully read by
10137 checking whether it is still open; detects whether it was read at
10138 all by checking whether the line number is greater than zero.
10140 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
10141 interface. Functions reordered, comments changed. Not well
10142 tested, probably full of bugs.
10143 (init_file_handle) Removed initializers for obsolete fields, added
10145 (fh_close_handle) Much simpler, now mainly calls the class
10147 (fh_init_files) Renamed inline file internal filename.
10149 * file-type.c: Includes dfm.h.
10150 (read_from_file_type) Doesn't use dfm internal state anymore.
10152 * inpt-pgm.c, print.c: Include dfm.h.
10154 * recode.c: (internal_cmd_recode) Casts strlen() return value to
10155 int in comparison with other int.
10157 * som-high.c: (build_target) Fixed operator precedence problem in
10158 if statement (& versus ==).
10160 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
10162 * dfm.c: (read_record) Can now read fixed-length records; not
10164 (put_record) Can now write fixed-length records; not tested.
10166 * file-handle.h: FH_* defines changed to enums. New enum series
10168 (struct file_handle) New members recform, lrecl, mode.
10170 * file-handle.q: Parser changed.
10171 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
10172 /LRECL subcommands. These are compatible with Windows.
10173 (init_file_handle) Initializes recform, mode fields.
10175 * q2c.c: (get_line) When outputting `!' comment lines, now
10176 increments the output file line number so that `#line' directives
10178 (make_identifier) New function that converts an arbitrary string
10179 into a valid C identifier.
10180 (dump_vars) Calls make_identifier() in two places in order to
10181 suppress some errors for bad identifiers.
10182 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
10183 for NO. Allows numbers to be prefixed by underscores to make them
10184 acceptable C identifiers but still to be parsed as numbers by the
10187 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
10189 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
10191 * dfm.c: Comment fixes. (get_record) Gives error if file handle
10192 was opened for writing.
10193 (open_file_w) New function.
10194 (read_record) Uses strncasecmp if available. Improved error
10195 messages, comments.
10196 (put_record) New function.
10198 * file-handle.h: Moved function comments into dfm.c and
10199 file-handle.q. Comment fixes. Removed declarations of
10200 tilde_expand() and normalize_filename().
10201 (struct file_handle) Changed `open' from boolean to enumerated
10202 field to allow for three states--closed, open for reading, open
10203 for writing--all references changed.
10205 * file-handle.q: Includes filename.h.
10207 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
10208 references changed.
10209 (alloc_line) Makes allowance for line terminator characters in
10211 (print_trns_proc) Now handles OUTFILE, WRITE differences.
10212 (print_space_trns_proc) Handles OUTFILE differences.
10214 * recode.c, sample.c: Comment fixes.
10216 * var.h: (struct print_trns) Changed boolean field `eject' to
10217 bitmapped field `options'; all references changed. New enums
10218 PRT_* for use with this field.
10220 * exception.h, test-exception.c: Removed.
10222 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
10224 * ascii.c: (delineate) Turned off debug output.
10226 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
10229 * data-in.c: (parse_string_as_format) Sets the entire string value
10230 to spaces, not just the short string part of it. Is this correct
10233 * data-out.c: (convert_date) Fixed DATETIME format problems with
10234 decimal places, removed debug code.
10236 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
10237 middle of parsing BEGIN DATA that would cause the lexer to read
10238 from a wild pointer `prog'; now calls new function
10239 preprocess_line() in lexer.c.
10241 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
10243 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
10244 Now call induce_segfault() to induce the segfault.
10245 (induce_segfault) New function.
10247 * expr-opt.c: Comment fix.
10248 (parse_sysvar) New function.
10249 (parse_primary) Added system variable support--calls
10251 (global var ops) Added OP_CASENUM operator.
10253 * expr.h: Comment fixes.
10254 (OP_* enum) added OP_CASENUM operator.
10255 (struct casenum_node) New struct.
10256 (union any_union_union) New member `cas' of type `casenum_node'.
10258 * glob.c: (global var last_vfm_invocation) New var.
10259 (init_glob) Initializes last_vfm_invocation.
10261 * lexer.c: (lookahead) Fixed reversed condition on if statement.
10263 * getline.c: (get_line) Split into get_line() and preprocess_line().
10264 (preprocess_line) New function.
10266 * var.h: Declares last_vfm_invocation.
10268 * vfm.c: (procedure) Sets last_vfm_invocation.
10270 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
10272 * command.c: (parse_cmd) Fixed bad assertion related to
10275 * data-in.c: (parse_month) Implemented to parse months according
10276 to full interpretation of standard.
10277 (to_roman) New function.
10278 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
10279 (parse_weekday) Bug fix (forgot to skip all the day name).
10281 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
10282 up parsing of multirecord data items. Also fixed user message.
10284 * data-out.c: Comment fix.
10285 (year2, year4, convert_date, convert_time, convert_WKDAY,
10286 convert_MONTH) New functions to support time & date output.
10287 (convert_format_to_string) Calls new time & date output routines.
10289 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
10291 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
10294 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
10296 * misc.c: (global var formats) Fixed declarations of DATETIME,
10299 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
10300 the output_char buffer.
10302 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
10303 memory bug. Fixed user messages.
10305 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
10307 * Removed #pragma argsused from lots of places.
10309 * data-in.c: Implemented zoned decimal and time-date formats.
10310 Untested. This is a huge chunk of code--maybe 1000 lines and 50
10313 * data-out.c: Implemented zoned decimal format.
10315 * expr.h: Moved yrmoda() declaration here from exprP.h.
10317 * misc.c: (global var formats) Minor fixes--added
10318 FCAT_SHIFT_DECIMAL to formats N and Z.
10319 (convert_fmt_ItoO) Added support for format Z.
10321 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
10323 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
10325 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
10326 som_check_workspace() that is activated between commands.
10328 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
10331 * list.q: (begin_row) Changed title expansion style from
10332 SOPT_X_VERT to SOPT_X_SHSP.
10334 * som-frnt.c: Now includes `somP.h'.
10335 (som_push_workspace, som_pop_workspace) New functions that, taken
10336 together, form a solution to the recursive table building problem
10337 mentioned yesterday. Surrounded every table output routine
10338 throughout the program with calls to these functions.
10339 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
10340 (som_create_table) Checks that there's an active workspace.
10341 (som_destroy_all_tables, som_crush) Removed.
10343 * som-high.c: (global var som_preserve_tables) Removed, all
10344 references deleted.
10345 (som_submit_table) Checks that there's an active workspace.
10346 (dump_columnated_table) Doesn't columnate tables that would have
10347 just one row per column.
10348 (dump_crush_page, som_dump_crush_page) Removed debugging code.
10349 (som_dump_crush_page) Moved row number labels from left side of
10350 tables to right side.
10351 (som_get_table_size) Added support for SOPT_X_SHSP.
10353 * som.h: New cell expansion type SOPT_X_SHSP.
10355 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
10357 (global var curtab_arena) Moved from som-frnt.c.
10359 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
10361 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
10362 that causes bad location warnings to be suppressed.
10363 (delineate) Saves current font when calling draw_text(); fixed
10364 handling of NULLs when backing up. Also fixed line-wrapping bug.
10366 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
10367 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
10369 * common.c: Added code to cause assertion failure to dump core
10370 when run under Checker.
10372 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
10373 there are still bugs.
10375 * glob.c: (__eprintf) Removed.
10377 * list.q: Inserted som_preserve_tables kluge that prevents tables
10378 from being thrown away due to recursive table building through
10379 som_output_line being called from a transformation during the LIST
10380 procedure invocation. This is a general problem that must be
10381 solved in a better way since it applies to all procedures in
10383 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
10384 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
10386 * numeric.c: Fixed several errors in the form of msg() calls.
10388 * print.c: Updated for use of som.
10389 (dump_table) Reimplemented.
10390 (print_trns_proc) Calls som_eject_page() instead of eject_page().
10391 Calls som_output_text() instead of outs_line().
10393 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
10395 (som_output_text) Function moved from som-low.c. Interface
10398 * som-high.c: (som_preserve_tables) New global public variable
10400 (som_submit_table) Destroys the tables only if som_preserve_tables
10402 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
10403 one subrow per row. Now labels subrows if there's more than one
10405 (dump_crush_table) Added wishlist comment.
10406 (som_eject_page) New public function declared in som.h.
10408 * som-low.c: (som_dump_crush_page) Draws row labels if there's
10409 more than one subrow per row.
10410 (som_output_text) Moved to som-frnt.c.
10412 * som.h: (SOM_TOPT_PRESERVE) Removed.
10414 * title.c: (get_title) Changed interface.
10415 (cmd_title) Changed `title' to `outp_title'.
10416 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
10418 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
10420 * list.q: (flush_table) Conforms to new partial options in
10421 som_submission_form.
10423 * som-high.c: (paginate_horizontally) Changed form of subrow
10425 (build_target) Omits spacing before table if
10426 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
10427 (dump_crush_page) Changed interface. Only trims bottom rule if
10428 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
10429 (dump_crush_table) Handles partial tables.
10430 (output_row_label) New function.
10431 (som_dump_crush_page) Emits subrow number labels. Draws vertical
10432 rule on the right edge of narrow subrows.
10434 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
10435 constants to a series of SOM_TOPT_PARTIAL_* submission options.
10436 All references updated.
10438 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
10440 * misc.c: Comment fix.
10442 * som-high.c: (examine_table) Treats crushed tables separates for
10443 purpose of determining header size.
10444 (paginate_horizontally) Allots space for line numbers in crushed
10445 tables with lots of subrows per row. Calculates the `maximum page
10446 width', the width of the widest horizontal page.
10447 (build_target) Removed trim argument; all references changed.
10448 Stricter assertions. (dump_crush_page) New function.
10449 (dump_crush_table) Reimplemented.
10451 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
10452 (som_dump_crush_page) Reimplemented, interface changed.
10454 * somP.h: Many many new helper macros for use with crushed tables.
10455 (global var som) Removed `tv', `cum_y' members; all references
10456 removed. New members `mpw', `digit_space'.
10458 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
10460 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
10461 variable, changed to constant 1024.
10462 (arena_ca_strdup) Changed `sizeof(a_string)' to
10463 `sizeof(c_string)'.
10464 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
10465 `(c_string *)' to `(char *)'; this fixed some offset problems.
10467 * filename.c: (readlink_malloc) Changed initial allocation from
10469 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
10472 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
10473 &fm->owner in several places.
10475 * som-high.c: (output_table) Changed interface to rest of world.
10476 (examine_crush_table) Removed. Crushed tables are re-broken now,
10477 in preparation for rewrite.
10479 * som.h: Comment fix.
10481 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
10483 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
10484 itself in the cleanup stage.
10486 * descript.q: (display) At least temporarily, changed the table
10487 format to a crushed table.
10489 * list.q: (begin_row) At least temporarily, added horizontal lines
10492 * som-high.c: (examine_crush_table) Sets som.hh to the width of
10493 the horizontal "headers," that is, to the width of the far left
10494 and far right rules.
10495 (justify_pagination) Sets som.th to the width of the widest row
10496 in the crushed table. Fixed inner loop off-by-one error.
10498 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
10501 * somP.h: Comment fix.
10503 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
10505 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
10506 before closing it; also, opens the constructed filename `s'
10507 instead of f->filename.
10509 * postscript.c: Moved initialization of x->loaded, x->prop,
10510 x->fixed, x->current, also the add_encoding() calls, into
10512 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
10513 sets x->last_font to NULL; sets x->next_combo to zero.
10515 * som-high.c: (crushed_row_height) Moved definition farther up.
10516 (som_submit_table) Doesn't calculate line width, font size until
10517 after calling open_page(), to accomodate changes to PostScript
10519 (vert_headers) Removed; equivalent functionality moved to
10520 examine_table(), examine_crush_table().
10521 (justify_pagination) Replaced with different algorithm.
10522 (dump_crush_table) Bugfix that caused tables to fail to be clipped
10523 at the bottom of the page.
10525 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
10527 * command.c: Added cmd_list back into cmd_table.
10529 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
10530 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
10532 * list.q: (flush_table) Updated to new som_submission_form format.
10534 * som-frnt.c: Comment fix.
10536 * som-high.c: Changed `#endif' to `#undef EXTERN'.
10537 (output_table) Calls som_get_table_size() directly; handles
10539 (examine_crush_table) New function; calls vert_headers().
10540 (examine_table) Moved some code into new function, vert_headers().
10541 (justify_pagination) New function.
10542 (dump_plain_table) Removed `static' from `cy'.
10543 (dump_crush_table) New function.
10545 * som-low.c: (som_dump_crush_page) New function.
10547 * som.h: Comment fixes.
10548 (enum SOM_TOPT_CRUSH) New.
10549 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
10550 Temporarily set to zero to make do with LIST procedure.
10552 * somP.h: Re-ordering.
10554 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
10556 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
10558 * somP.h: New file for use by som-high.c, som-low.c.
10560 * q2c.c: Added definition for VME.
10561 (get_line) Now dumps `!' comment lines to the output file
10564 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
10565 set.q: Changed format of `!' comment lines.
10567 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
10569 * All source files: Added copyright notice.
10571 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
10572 longs in msg() calls.
10574 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
10576 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
10578 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
10580 * output.c: (outp_read_devices) Changed criteria for
10581 distinguishing different types of lines.
10583 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
10585 * cmdline.c: Changed syntax message.
10587 * filename.c: (good_getcwd) Bug fix (?).
10588 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
10590 (search_path) Appends DIR_SEPARATOR to directory name only if it
10591 does not already end with one.
10593 * glob.c: Checks STAT_PAGER envvar before PAGER.
10595 * output.c: Checks environment variables instead of just local
10598 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
10600 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
10601 when the pointer passed to the function was within the arena
10602 itself, so that it couldn't properly be set to NULL _after the
10605 * command.c: Re-enabled DISPLAY.
10607 * display.c: Rewritten to handle tables. Untested.
10609 * filename.c: (search_path) Fixed memory leak.
10611 * frequencies.q: (cmd_frequencies) Frees v_variables.
10612 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
10613 (cleanup_freq_tab) New function to garbage collect.
10614 (dump_full) Elegantized.
10616 * main.c: New comment.
10618 * output.h: New tag for tagged quotes: TAG_NEWLINE.
10620 * postscript.c: Comment fix.
10621 (release_fontmap, free_font_entry) New functions.
10622 (ps_init_driver) Sets free_font_entry() as the freefunc for
10623 hashtable `loaded'. Calls release_fontmap() when destroying a
10624 driver; also frees the output filename; also frees the
10625 ps_driver_ext block.
10626 (free_ps_encoding) Frees the filename as well as the encoding
10628 (output_encodings) Frees the line buffer and pops the msg-filename
10630 (read_fontmap) Frees the fontmap filename and the line buffer.
10631 (postopen, preclose) Misc. garbage collection fixes.
10632 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
10633 to NULL; this fixes some output problems.
10634 (text) Handles TAG_NEWLINE. Untested.
10636 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
10637 (som_set_string) Removed. All references changed to
10639 (som_set_text) Rewritten. New interface. More general.
10641 * som.h: Minor format changes.
10642 (struct som_value_cell) Removed; all references changed to
10644 (enums SOT_*) Changed.
10646 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
10648 * command.c: Re-enabled SPLIT FILE.
10650 * postscript.c: Comment fix.
10652 * som.h: Added `SOT_NONE'.
10654 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
10656 * vfm.c: (dump_splits) Reimplemented.
10658 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
10660 * Compiled the project under gcc 2.7.2, which gave some new
10661 warnings. This led to many additions of casts from unsigned to
10662 int sprinkled throughout the code.
10664 * arena.c: Many uses of `unsigned' changed to `size_t'.
10666 * command.c: Added END FILE, END REPEAT to command table.
10667 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
10668 (find_command, FILE_TYPE_okay) Not commented out anymore.
10669 (parse_cmd) Calls FILE_TYPE_okay again.
10670 (output_line) Added calls to som_output_text() to put the line
10671 in the output files.
10673 * common.c: (macro VME) Format changes.
10674 (xstrdup) Asserts that its argument is not NULL.
10676 * data-list.c: Implemented dump_fixed_table().
10678 * inpt-pgm.c: Formatting changes. Comment changes.
10679 (end_case_proc) Renamed end_case_trns_proc.
10680 (cmd_end_file, end_file_trns_proc) New functions.
10682 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
10684 * misc.h: (local_strdup) New macro corresponding to strdup() but
10685 allocating its data through local_alloc() if possible--that is, if
10688 * postscript.c: Comment changes.
10689 (quote_ps_name, quote_ps_string, output_encodings) New functions.
10690 (output_line, add_string) New macros supporting
10691 output_encodings().
10692 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
10693 substitution vars. Calls output_encodings() when a line
10694 consisting of `!encodings' is encountered.
10695 (preclose) Some code moved into quote_ps_string().
10696 (dump_line) Changed into macro supporting dump_fancy_line().
10697 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
10698 command when appropriate.
10699 (write_text) Fixed `literal_char' array (I think it's fixed, at
10701 (text) Fixed bug when width was zero. Now exits immediately on
10702 zero height_left. Now, when executing `goto restart;', checks
10703 that cp<end, so that we don't read beyond end-of-string. Also,
10704 outputs the correct code to the output file by outputting the code
10705 from the metric instead of the internal metric index.
10707 * repeat.c: (cmd_end_repeat) New function.
10709 * som.c: (var som) `headers' renamed `options' and semantics
10710 changed. All references changed.
10711 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
10712 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
10714 (som_text_table) Removed.
10715 (som_output_text) New function.
10717 * som.h: (struct som_submission_form) Removed `header', `reuse',
10718 replaced with bitmapped field `options'.
10719 (SOM_TOPT_*) New enum set for som_submission_form.options.
10720 (SOT_*) New enum set for som_output_text().
10722 * temporary.c: (copy_variable) When copying the var label, only
10723 calls xstrdup() if it's non-NULL.
10725 * var.h: (enum type `vartype') Removed; all references changed to
10728 * vars-atr.c: (init_variable) Changed local var `nbytes' from
10731 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
10733 * font.h: Comment changes.
10735 * groff-font.c: (groff_read_font) Initializes `name' field to
10736 NULL. Handles `encoding' field.
10738 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
10740 * postscript.c: (struct font_entry) Removed `position' field.
10741 (struct ps_font_combo) New struct.
10742 (struct ps_driver_ext) Removed field `next_position'. New fields
10743 `combos', `next_combo'. `last_font' field changed from
10744 `font_entry *' to `ps_font_combo *'.
10745 (ps_init_driver) Reformatted; handles new fields. When
10746 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
10748 (get_encoding, find_encoding_file) New functions.
10749 (add_encoding) Some code moved out into find_encoding_file().
10750 (postopen) Changed value for ${title}.
10751 (preclose) Sets `loaded' field to NULL after destroying the hash
10753 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
10755 (ps_text_set_font_by_position) Figures out the current family if
10757 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
10758 (switch_font) Implemented.
10759 (write_text) Calls switch_font() more often. Format changes.
10760 #undefs its macros after they're no longer useful.
10761 (text) Changed `continue' at one point to a jump to the top of the
10762 loop because we don't want `separate' reset to 0 at that point.
10763 (load_font) No longer sets `position' in the font_entry created.
10765 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
10767 * font.h: (struct font_desc) New member `encoding', which is not
10768 properly handled yet.
10770 * glob.c: (init_glob) Some new i18n code, which is probably
10773 * output.c: (outp_read_devices, outp_get_paper_size) Changed
10774 `size' local from `int' to `size_t'.
10776 * postscript.c: New driver configuration parameter `auto-encode'.
10777 New enums OPO_AUTO_ENCODE, ODA_COUNT.
10778 (struct font_entry) New member `position'.
10779 (struct ps_driver_ext) Reordered. New hash table member
10780 `encodings'; new members `next_position', `next_encoding',
10781 `last_font'. Members `current', `prop', `fixed' changed from type
10782 `font_desc *' to `font_entry *'; all references changed.
10783 (struct ps_encoding) New struct.
10784 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
10785 free_ps_encoding, add_encoding) New functions.
10786 (ps_init_driver) Added OPO_AUTO_ENCODE to default
10787 x->output_options. Initializes new members of ps_driver_ext.
10788 Changed default value for prologue_fn, encoding_fn. Calls
10789 read_ps_encodings after loading default fonts.
10790 (option_tab[], ps_option) Handle new configuration parameter.
10791 (switch_font) New function.
10792 (struct output_char) `font' member changed from `font_desc *' to
10793 `font_entry *'. New member `separate'.
10794 (read_fontmap) Changed `size' from `int' to `size_t'.
10795 (output_line, put_number) New macros for write_text().
10796 (write_text) Optimizes text output by consolidating multiple
10797 calls to PostScript `show' operator.
10798 (text) Keeps track of when text arguments can't be consolidated by
10799 write_text(), and marks those spots in the output stream.
10800 (load_font) Sets `position' of the allocated font_entry to -1, cuz
10801 the font hasn't been switched to by switch_font(), which is where
10802 the position is important--the PostScript is what cares about the
10805 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
10807 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
10808 call a NULL free_func.
10809 (hsh_rehash) Elegantized.
10810 (hsh_probe) Fix bug that manifested when the table was expanded
10811 and thus had to change location in memory. Good thing
10812 too--otherwise could have been much more subtle.
10813 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
10814 (hsh_foreach) New function for hash table iteration.
10816 * hash.h: (struct hsh_iterator) New.
10818 * lexer.c: (parse_tagged_quote) Font and family name strings in
10819 tags are now null-terminated.
10821 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
10823 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
10824 documented. (Never before tested?)
10826 * output.h: Comment changes.
10828 * postscript.c: New driver options `optimize-text-size',
10829 `optimize-line-size', `max-fonts-simult'. New enum set for
10830 specing cached line types. Comment fixes.
10831 (struct line_form) New struct.
10832 (struct ps_driver_struct) New members `text_opt', `line_opt',
10833 `max_fonts', `lines'.
10834 (ps_init_driver) Initializes new members of ps_driver_struct.
10835 (user option type enum set) New member `nonneg_int_arg'.
10836 (static var option_tab[]) Supports new options.
10837 (ps_option) Handles new options.
10838 (find_ps_file) Made static. No longer calls hsh_dump().
10839 (ps_get_var) Made static.
10840 (preclose) Dumps out proper DSC trailer.
10841 (ps_open_page) Elegantized.
10842 (ps_close_page) Calls dump_lines() if appropriate.
10843 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
10844 wrappers around line().
10845 (int_2_compare, compare_line, dump_line, dump_fancy_line,
10846 dump_lines, hash_line, free_line, line) New functions for support
10848 (write_text, text) Made static.
10849 (text) Added to font support, not finished.
10851 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
10853 * font.h: (struct font_desc) New members ascent, descent.
10855 * groff-font.c: (groff_read_font) Calculates font ascent and
10856 descent from the ascent and descent of the `d' and `p' characters,
10857 respectively, as per a suggestion on comp.fonts.
10859 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
10860 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
10862 (write_text) Handles text right-justification and centering (not
10863 full justification). Still very inefficient. (One output line
10865 (struct output_char) Added fields for font and font size.
10866 (text) Many bugfixes.
10868 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
10870 * cmdline.c: (usage) Calls outp_list_classes().
10872 * font.h: Comment fix.
10874 * groff-font.c: New exported global var `space_index'.
10875 (groff_init) New function to initialize `space_index'.
10876 (hash_kern) Casts result to unsigned.
10877 (font_name_to_index) Renamed font_char_name_to_index. All
10878 references changed. Also, now returns the value of `space_index'
10879 when passed an ASCII space character as an argument. Fixed
10881 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
10882 Handles passed NULL pointers properly.
10884 * lexer.c: (parse_tagged_quote) Comment fix. Better range
10887 * output.c: (outp_list_drivers) Removed. Removed all references.
10889 * output.h: Comment fixes.
10891 * postscript.c: (ps_open_global) Calls groff_init().
10892 (output_char) New structure.
10893 (write_text) New function.
10894 (text) No longer stubbed out! Now the output is correct--with a
10895 few exceptions, one of them being that the page has to be held
10896 upside down into a mirror.
10898 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
10900 * font.h: Comment fix.
10902 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
10903 All callers changed.
10904 (number_to_index) Renamed font_number_to_index, made extern. All
10906 (font_get_kern_adjust, font_get_char_metrics) New functions.
10908 * output.h: New constant OUTP_T_INTERNAL_DRAW.
10910 * postscript.c: Changed default line width back to 1/2 point.
10911 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
10912 in the center of the space allotted for them, not just a fixed
10913 offset from the edge of the space; this fixes some bugs.
10914 (ps_line_intersection) Now supports all command line styles.
10915 (ps_text_get_size) Bug fix in computation of em width.
10916 (text) New function, the meat behind ps_text_metrics and
10917 ps_text_draw. Not complete.
10918 (ps_text_metrics, ps_text_draw) Removed the stub taken from
10919 ascii.c; call text().
10921 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
10923 * arena.c: (arena_free) Assert that the argument is non-NULL.
10925 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
10926 only if old_kern is non-NULL.
10928 * postscript.c: (ps_init_driver) Changed default line width to 1
10930 (postopen) New prologue variables.
10931 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
10932 more of the common line styles properly, but not all.
10933 (ps_text_metrics) Fixed problem with this stubbed out version that
10934 kept it from taking font sizes into account.
10936 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
10938 * arena.c: (arena_malloc) Bug fix.
10939 (arena_dump) [GLOBAL_DEBUGGING] New function.
10941 * ascii.c: Comment fix.
10942 (count_fancy_chars, delineate) Now static functions.
10944 * filename.c: (interp_vars) Bug fixes.
10946 * font.h: Comment fixes.
10948 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
10949 beginning in case we have an error message to display before
10950 initializing the display.
10952 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
10954 (groff_read_font) Bug fixes.
10955 (name_to_index) Increments hash.used. Sets `name' field of hash
10957 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
10959 * hash.c: Return type changed.
10961 * postscript.c: Continued development. Now marks lines on the
10962 paper, but very buggy.
10964 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
10966 * Changed comments in many source files from `/* xxx /* yyy */' to
10967 `/* xxx */ /* yyy */' for cleanliness.
10969 * arena.c: (arena_sd_strdup) New function.
10971 * ascii.c: (struct ascii_driver_ext) New member `file'.
10972 (ascii_init_driver) Fills out member `file' for initing; uses
10973 close_file_ext for closing drivers.
10974 (ascii_option) Changed %.*s back to %s because the a_string's are
10975 always null-terminated.
10976 (postopen, preclose) New functions.
10977 (ascii_open_page) Uses new style of open_file_ext.
10978 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
10979 instead of this->output.
10980 (__assert_fail) Removed.
10982 * cmdline.c: Changed syntax_message[].
10984 * error.c: #include's <readline/history.h> only if the history
10985 library is available, not if just the readline library is
10988 * filename.c: (expand_line) Removed alloca() support.
10989 (interp_vars) No longer tilde-expands argument. Limit on output
10991 (tilde_expand) Now treats argument as path rather than filename.
10992 [!unix] Now is a no-op function.
10993 (search_path) Better verbose message formatting.
10994 (open_file, close_file) Comment fixes.
10995 (close_file) [!unix] Doesn't bother with pipes.
10996 (open_file_ext) Completely rewritten, interface revamped.
10997 (close_file_ext) New function.
10999 * font.h: Comment changes.
11001 * frequencies.q: Removed AIX alloca support since it doesn't use
11004 * hash.c: Comment changes & additions.
11005 (hsh_create) Initializes entire table instead of first M entries.
11006 (hsh_probe) Stupid bug fixed. Now it works.
11007 (hsh_dump) [GLOBAL_DEBUGGING] New function.
11009 * main.c: (parse) Detects EOF properly in token-eating loop.
11010 Should the STOP token have its value changed to 0?
11012 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
11013 (blp_getline) Now it's a macro.
11015 * output.h: (struct outp_driver) Removed members output, filename.
11017 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
11018 drivers in driver table.
11019 (outp_read_devices) Frees buf. Warns if there are no active
11021 (outp_configure_clear) Sets outp_configure_vec to NULL after
11022 deleting its elements.
11023 (configure_driver, destroy_driver) Removed references to output,
11024 filename members of outp_driver.
11025 (outp_evaluate_dimension, internal_get_paper_size,
11026 outp_get_paper_size) New functions.
11028 * postscript.c: Continued development. Now links but doesn't make
11029 any marks on the page. Lotsa bugs I suppose.
11031 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
11033 * str.h: Comment changes.
11035 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
11037 * Removed dependencies on non-nested comments in several files.
11038 Also removed references to (unix || __unix__) in #if's since
11039 prefh.orig makes those two equivalent.
11041 * ascii.c: (ascii_open_global) Creates ascii_arena.
11042 (ascii_close_global) Destroys ascii_arena.
11043 (ascii_init_driver) Doesn't create ascii_arena.
11044 (ascii_copy_driver) Removed.
11045 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
11046 (outp_class ascii_class) Removed ascii_copy_driver reference.
11048 * frequencies.q: Now can display all statistics except median.
11049 Still not finished.
11051 * output.c: Handles outp_class.ref_count so output class
11052 destructors are called properly.
11053 (add_class) Sets ref_count to 0.
11054 (configure_driver) Initializes class if ref_count++ is 0.
11055 (destroy_driver) Destructs class if --ref_count is 0. Frees the
11056 class output file name.
11058 * output.h: (struct outp_class) Removed copy_driver, inited.
11061 * postscript.c: Completely replaced but not finished.
11063 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
11065 * approx.h: #includes <float.h>.
11067 * arena.h, arena.c: Many functions changed to take an arena **
11068 instead of an arena *, for consistency. All callers changed.
11069 (arena_alloc) Now creates a new arena if passed *A that is NULL.
11070 (arena_destroy) Sets *A to NULL.
11072 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
11073 assertion that `width' be positive.
11075 * command.c: Removed #if's from cmd_table.
11076 (walk_cmdtable_func) [0] New function (debug code).
11077 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
11078 (parse_cmd) Doesn't return failure for unimplemented commands.
11080 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
11081 (SYSCODE) New constant macro.
11083 * descript.q: Checks for positive n_variables before performing
11086 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
11087 avl_find instead of &fp as arg 2.
11089 * frequencies.g, frequencies.q: Continued updating; now compiles &
11090 works again, but not complete.
11092 * main.c: Changes to user messages.
11094 * misc.c: (reverse) [0] New function.
11096 * settings.h: Comment removed. #includes "common.h".
11098 * som.c: (som_set_null) New function.
11099 (som_set_value, som_set_string, som_set_text) More detailing
11101 (som_set_float) Implemented function.
11102 (dump_columnated_table) Bug fix regarding page breaks.
11103 (draw_cell) Bug fix regarding text that spilled out of a cell.
11104 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
11106 (get_cell_size) Support SCON_EMPTY cells.
11107 (get_table_size) When calculating rules' widths and heights, mask
11108 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
11110 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
11112 (struct som_submission_form) New member `header'; all users
11115 * val-labs.c: (get_label) User messages changed.
11117 * var.h: Changed FREQUENCIES structures.
11119 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
11122 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
11124 * approx.h: Definition of EPSILON now depends on system's
11125 DBL_EPSILON. Removed GNU C specific code.
11126 (cmpapx) Renamed approx_compare.
11128 * frequencies.g, frequencies.q: Continued updating; still doesn't
11131 * groff-font.c: (name_to_index) Fix bug that kept it from
11134 * hash.c, hash.h: Completed work.
11136 * var.h: Changes to freq_tab, frequencies_proc.
11138 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
11141 * hash.c, hash.h: New files. Not completed.
11142 * Makefile.am: Added hash.c to source file list.
11143 * font.h: (struct font_desc) New member kern_size_p.
11144 * groff-font.c: Uses hash.h.
11145 (hashpjw) Moved to hash.c.
11146 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
11148 (static var hash) New member size_p.
11149 * var.h: Includes hash.h.
11150 (struct freq_tab) Changed AVL_TREE to hash_tab.
11152 * vars-prs.c: Comment, formatting fixes.
11154 * frequencies.g, frequencies.q: Continued updating. Not yet
11157 * formats.c: Bug fix.
11159 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
11161 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
11162 * descript.g: Comment fixes.
11163 * descript.q: Comment fixes. Moved some declarations into var.h.
11164 Made dsc_info a static table. Updated FIXMEs.
11165 (internal_cmd_descriptives) Beautified.
11167 * frequencies.q: Started updating into working order.
11168 * frequencies.g: New file analogous to descript.g.
11169 * var.h: Comment fixes. Added structures for FREQUENCIES.
11171 * som.c: Removed vestiges of crushing and partial table support.
11173 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
11175 * Many more changes to som.c especially, but these will not be
11176 documented as I have resolved to remove them. This patchlevel is
11177 being released solely so that I can fall back to it if I decide
11178 that removing the changes is not a good idea.
11180 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
11182 * som.c: (global var som) New member `cum_y'.
11183 (build_target) Properly handles titles for partial tables.
11184 (dump_partial_beg, dump_partial_mid, dump_partial_end)
11185 Merged into single new function dump_partial(). Fixed problem
11186 with titles on partial tables.
11187 (dump_table) Calls dump_partial() for all parts of partial tables.
11188 (dump_page) Criteria for drawing title changed.
11190 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
11192 * command.c: (cmd_table) Added LIST, WEIGHT.
11194 * command.c: (cmd_remark) No longer frees `s' since it's not
11195 dynamically allocated.
11197 * data-out.c: (convert_f) Now correctly handles the case where
11198 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
11199 number of decimals.
11200 (som_destroy_all_tables) Removed argument. All callers changed.
11201 (som_vline, som_hline) Argument validity checking corrected.
11202 (som_set_value) Implemented half-heartedly.
11203 (replicate_table) Copies tables piece-by-piece when using Checker.
11205 * som.h: New line style SLIN_1THIN, currently equivalent to
11206 SLIN_0. New enum set SOM_SUB_*.
11207 (struct som_submission_form) Removed `seq_no'. Added `type'.
11209 * list.q: Newly working file; uses partial tables.
11211 * som.c: (som_reduce_table) Renamed som_set_table_height().
11212 (som_crush) Removed argument `group'.
11213 (global var som) Removed `nt', `seq_no'. Added `type'.
11214 (som_submit_table) Arguments changed.
11215 (output_table) Removed partial table code.
11216 (build_target) New arg; partial table support added. All callers
11218 (dump_plain_table) Removed partial table code.
11219 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
11220 (dump_table) Supports partial tables.
11221 (dump_page) New argument to allow not drawing top and/or bottom
11222 headers. All callers changed. Supports partial tables.
11224 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
11226 * data-out.c: Changed `#include <approx.h>' to `#include
11228 (convert_F) Comment fix. Now won't print `-.000', etc.
11230 * descript.q: Now Z-scores work, although there appears to
11231 be a bug (which might actually be in data-out.c:convert_F()).
11232 (descriptives_trns_proc, descriptives_trns_free) New functions.
11233 (run_z_pass) Implemented.
11235 * var.h: Comment fixes.
11236 (dsc_z_score, descriptives_trns) New structs.
11237 (descriptives_trns) Added to any_trns as `dsc'.
11239 * error.c, error.h: New error class, IS (Installation Script
11240 error), used in those instances where the error is in the
11241 installation, but there is a script file or installation file that
11242 can be usefully referred to.
11244 * output.c: Change many IE classes to IS classes.
11246 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
11247 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
11248 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
11249 include the corresponding header?
11251 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
11252 Don't bail out if termcap can't be read.
11254 * som.c: (som_destroy_table) Removed.
11255 (som_reduce_table, som_destroy_all_tables) New functions.
11256 (som_crush) New function, not implemented.
11258 * som.h: New table option STAB_CRUSH. Comment fix. New struct
11259 som_submission_form. Function prototypes revised.
11261 Outputting huge tables (1000s of rows) a few rows at a time
11262 is supported, though untested. May even break everything.
11263 Actually, the code doesn't even compile right now.
11264 * som.c: (struct som) New fields htv, nt, seq_no.
11265 (som_submit_table) Multiple arguments changed to a single
11266 pointer to struct submission_form. Only increments subtable_num
11267 if seq_no is zero. Only destroys table if it's not going to
11269 (replicate_table) New function.
11270 (output_table) Comment fix.
11271 (examine_table) Changed inline code to code calling
11272 replicate_table(). Calculates htv. Supports partial tables.
11273 (draw_title) Removed comment.
11274 (build_target) Only allows for title on first part of partial
11276 (dump_plain_table) Only resets table chunk number on first part
11277 of partial tables; FIXME: doesn't work quite right. Supports
11279 (dump_page) Titles only on first part of partial tables.
11281 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
11283 * Thanks to an unreliable IDE hard drive, I have spent the last
11284 day reconstructing my Debian GNU/Linux installation and redoing
11285 the previous day's changes--somehow I managed to save every file
11286 except for output.c and output.h. So the following changes could
11287 really be considered independent of the output.c, output.h changes
11290 * output.h, output.c: Moved the outp_configure_vec global var,
11291 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
11292 outp_configure_vec is now static.
11294 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
11296 * The entire philosophy behind configuration of the output drivers
11297 changed. Now there is a termcap-type configuration where drivers
11298 to be read are determined beforehand, rather than parsing the
11299 entire output init file and storing it in memory & deciding what
11300 to actually use later. Faster & more memory-efficient at the same
11303 * output.c: Comment fix. Removed outp_init_drivers global var.
11304 Removed all references to synonyms. New structure outp_defn. New
11305 global vars outp_macros, outp_configure_vec.
11306 (search_name, delete_name, add_name, check_configure_vec,
11307 expand_name, find_defn_value) New static functions.
11308 (outp_configure_clear, outp_configure_add, outp_configure_macro,
11309 outp_read_devices) New extern functions.
11310 (outp_init) Much functionality moved into outp_read_devices.
11311 (outp_read_devices) Format of output init file changed; name of
11312 file is `devices' rather than `output' to avoid Makefile
11314 (outp_clear) Renamed outp_done.
11315 (outp_list_classes) Bug fix, cleaned up.
11316 (outp_list_drivers) Not implemented anymore.
11317 (outp_configure_driver) Now a static function; simplified; now
11318 interpolates macros; supports new structure.
11319 (outp_enable_driver, match_synonym) Removed; all references
11321 (find_driver) First argument removed.
11323 * output.h: Global var outp_init_drivers removed; new structure
11324 outp_names; new enum set OUTP_S_*; new global var
11325 outp_configure_vec; function prototypes for output.c exports
11328 * main.c: (main) Calls outp_read_devices() after parsing the
11331 * cmdline.c: (parse_command_line) New option -v --verbose;
11332 --version changed to -V. --device option changed syntax to just
11333 take a single device name. Accepts key=value declaration of
11334 output init file macros. Syntax message updated.
11336 * filename.c: (expand_line) New function.
11337 (interp_environ_vars) Renamed interp_vars; no longer uses
11339 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
11340 overridden by real environment vars.
11341 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
11342 * filename.h: interp_environ_vars() renamed interp_vars().
11344 * error.c, error.h: Added extern variable `verbosity', message
11347 * error.c: (vmsg) Support message class MM.
11348 (verbose_msg) New function.
11350 * descript.q: (generate_z_varname) Bug fix in generation of
11352 (dump_z_table) Bug fix in column headers.
11354 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
11355 page from 29 to 15. Don't set a default for ops[OPS_INIT,
11356 OPS_DONE]. Writes the uninit string when the driver is closed.
11357 (ascii_open_page) Write the init string before the first page.
11358 (output_shorts) Form of main loop changed from `while' to `for'.
11359 Bug fix with overstrikes: the character is printed *after* the
11360 backspace. Eliminated a lot of `& 0xff' modifiers.
11361 (advance_to_left_margin) New function.
11362 (return_carriage, output_lines) Handle left margin.
11364 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
11366 * ascii.c: New option `carriage-return-style'.
11368 * ascii.c: (count_fancy_chars) New function.
11369 (delineate, text_metrics) Use new function; bug fixes regarding
11371 (text_draw) Bug fix with rich text.
11372 (output_string, output_shorts) Reordered.
11373 (output_shorts) Now handles boxchars and some overstrike font
11375 (output_char, return_carriage) New functions.
11376 (output_lines) Now handles overstriking and font changes properly;
11377 some code moved to output_shorts.
11379 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
11382 * ascii.c: New member `debug' in ascii_driver_ext.
11383 (ascii_init_driver, delineate) Uses new member.
11385 Now you can set a vertical height on writing text.
11386 * ascii.c: (delineate) Keeps track of vertical position.
11387 (text_draw) No longer considers fully justified text an internal
11390 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
11392 Tables' titles are drawn; they can have variable height.
11393 * som.c: `som' struct has new member, title_height.
11394 (draw_title) New argument. Moved within file. All caller
11396 (build_target) New argument, amount of space needed for first row.
11397 Calculates height of title, takes that into account. All callers
11399 (dump_plain_table, dump_columnated_table) Took calculation of y1,
11401 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
11403 (dump_columnated_table) Organized for readability.
11404 (dump_page) Makes use of som.title_height.
11406 * som.c: Many comment bug fixes.
11408 * descript.q: (try_name, generate_z_name) Bug fix regarding
11409 generation of Z-score variable names.
11410 * var.h: Removed num from descriptives_proc; all referents removed.
11412 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
11414 * ascii.c: (ascii_line_horz, ascii_line_vert,
11415 ascii_line_intersection) Added debugging code.
11417 Added a descriptive line above each table to describe it.
11418 * command.c: (parse_cmd) Calls som_new_series.
11420 * som.c: New static vars table_num, subtable_num. New `som'
11422 (dump_page) New arguments.
11423 (som_submit_table) Handle new variables.
11425 * som.c, som.h: (som_submit_table) New arguments. All callers
11427 (som_new_series) New function.
11428 (build_target) Makes room for extra line.
11429 (draw_title) New function.
11430 (dump_page) Calls draw_title. Bug fix: doesn't always set
11433 Columnation of tables support.
11434 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
11436 * som.c: Deleted references to fr, lr, ri.
11437 (som_columnate) Bux fix: sets group member of table.
11438 (som_add_options) Function removed.
11439 (dump_table) Split into three functions; extensively reworked.
11441 * descript.q: (dump_z_table) Better output table formatting; added
11442 title support to correspond to som.h changes.
11443 (display) Title support.
11445 * output.h: Added OUTP_T_NONE.
11447 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
11449 * descript.q: Improved handling of Z scores; still not perfect.
11451 * output.h, ascii.c: Added hook for getting em width of current
11454 * som.c: Uses new em-width hook. Added debugging code to
11456 (som_columnate) New argument.
11457 (som_add_options) Removed.
11459 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
11461 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
11462 rules as a property of the table instead of as a property of the
11465 * ascii.c: Added `header' to table of options.
11467 * descript.q: Added even shorter statistic names; modified to work
11468 with new som interface.
11470 * misc.c (blp_getdelim): Bug fix.
11472 * version.c: includes 'conf.h'.
11474 ----------------------------------------------------------------------
11477 version-control: never
projects / pspp-builds.git / blob