1 Sun Jul 24 20:26:59 2005 Ben Pfaff <blp@gnu.org>
3 Get rid of dependency on libgmp by writing our own routine for
4 floating-point base conversion.
6 * pfm-write.c: (write_float) Rewrote.
8 (pow30_nonnegative) New function.
10 (trig_to_char) New function.
11 (format_trig_digits) New function.
12 (recurse_format_trig_int) New function.
13 (format_trig_int) New function.
14 (should_round_up) New function.
15 (try_round_up) New function.
16 (format_trig_double) New function.
18 Sun Jul 24 18:49:20 2005 Ben Pfaff <blp@gnu.org>
20 * data-in.c: (parse_numeric) Allow "1+23" even for F format, for
23 Sun Jul 24 18:47:37 2005 Ben Pfaff <blp@gnu.org>
25 * pfm-read.c: (read_version_data) Read and ignore author field.
27 Wed Jul 6 20:44:27 2005 Ben Pfaff <blp@gnu.org>
29 * get.c: (mtf_processing) Don't assume that
30 mtf_compare_BY_values() always returns -1, 0, or 1. Actually, it
31 returns a negative, zero, or positive result. Fixes MATCH FILES
32 bug on Mac OS X reported by "Marshall DeBerry" <mdb@radix.net>.
34 Mon Jul 4 18:01:15 2005 Ben Pfaff <blp@gnu.org>
36 * flip.c: [HAVE_SYS_TYPES_H] Really include <sys/types.h>. The
37 preprocessor test for sys/types.h was accidentally inverted. This
40 Sun Jul 3 22:47:39 2005 Ben Pfaff <blp@gnu.org>
42 * get.c: (cmd_match_files) Fix memory leak on `by' and on
45 * getline.c: [HAVE_LIBREADLINE] (read_console) Fix memory leak on
48 * vfm.c: (close_active_file) Remove unnecessary test.
50 Sun Jul 3 21:45:32 2005 Ben Pfaff <blp@gnu.org>
52 Fix NDEBUG compile errors.
54 * hash.h: Needed explicit #include <assert.h>.
56 * linked-list.c: (ll_next) First arg is UNUSED when NDEBUG is
59 Sun Jun 12 23:44:38 2005 Ben Pfaff <blp@gnu.org>
61 Implement embedding for PostScript driver. Fixes bug 12970.
63 * ascii.c: Fix compiler warnings.
67 * chart.h: Add `file' member.
69 * output.h: (struct outp_class) initialise_chart, finalise_chart
70 should take outp_driver *, not outp_class *. Update all
73 * plot-chart.c: (chart_create) Fix segfault when there are no
74 output drivers at all.
75 (chart_submit) Call d->class->finalise_chart.
77 * postscript.c: (ps_open_page) Set cp_y to 0.
78 (ps_submit) New function.
79 (ps_chart_initialise) Implement.
80 (ps_chart_finalise) Implement.
81 (static var postscript_class) Add ps_submit.
82 (static var epsf_class) Add ps_submit.
85 Sun Jun 12 14:54:40 2005 Ben Pfaff <blp@gnu.org>
87 Did some more work on bug 12859 and then realized that a *good*
88 solution would require some fundamental restructuring. For now,
89 I'm marking REPEATING DATA unimplemented, and then we can revisit
92 * command.def: Make REPEATING DATA unimplemented.
94 * data-list.c: (cmd_repeating_data) Assume inline file is 80
96 (realize_value) Revert previous changes; no longer needed.
99 * error.c: (err_hcf) Set nfile_loc, mfile_loc to 0 after freeing
100 file_loc, to avoid bad references later.
104 Tue Jun 7 00:14:09 2005 Ben Pfaff <blp@gnu.org>
106 Make some code tolerant of reentry. Should not be needed if other
107 code is correct but it is good to be generally tolerant.
109 * error.c: (err_hcf) Set file_loc to null after free().
111 * output.c: (outp_done) Similar changes.
113 * str.c: (ds_destroy) Ditto.
115 Tue Jun 7 00:10:20 2005 Ben Pfaff <blp@gnu.org>
117 Continue work on bug 12859, plus some code cleanup.
119 * data-list.c: (cmd_repeating_data) Replace `seen' bitmap by
120 boolean variables. Don't try to compute starts_end, cont_end for
121 inline file. Calculate length only after parsing variable
122 specifications. Add proper transformation to list.
123 (realize_value) If the rpd_num_or_var has no value, return new
124 DEFAULT_MEMBER argument (for use with inline file).
125 (repeating_data_trns_proc) Pass default values.
127 * dfm-read.c: (dfm_close_reader) Only skip data if *not* still
128 open, and only if we actually started reading data.
130 Sun Jun 5 18:39:36 2005 Ben Pfaff <blp@gnu.org>
134 * output.c: (outp_read_devices) Fix message.
136 Fri May 27 12:34:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
138 * sort-prs.[ch] (newfiles), aggregate.c, sort.[ch]: Separated the guts
139 of the sort algorithm from the parser for the SORT command.
141 * rank.q: Added the parser for the RANK command.
143 Thu May 26 12:29:21 2005 Ben Pfaff <blp@gnu.org>
147 * sort.c: (sort_parse_criteria) Only set *saw_direction if
148 saw_direction is non-null. Thanks to John Darrington for
151 Tue May 24 21:52:55 2005 Ben Pfaff <blp@gnu.org>
153 * get.c: (mtf_processing) Handle case of a lookup table as the
154 active file. Thanks to John Darrington for reporting this bug.
156 Wed May 25 10:27:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
158 * alloc.c alloc.h: (xcalloc) changed signature to imitate the
159 POSIX calloc function.
161 * crosstabs.q get.c vars-prs.c: Updated calls to xcalloc to
162 reflect new signature.
164 * sfm-read.c: Now much more robust in the face of badly formed
167 Mon May 23 11:57:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
169 *sfm-read.c: Fixed some bugs regarding long string continuation
170 records, which the previous fix uncovered.
172 Sat May 21 12:48:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
174 * sfm-read.c, sfmP.h: Allow reading of system files when the
175 case_size value in the header is -1. Also changed some Errors to
176 Warnings when reading system files.
178 Tue May 17 21:00:57 2005 Ben Pfaff <blp@gnu.org>
180 * data-list.c: (data_list_trns_free) Don't free the argument
181 because cancel_transformations() will do that itself.
182 (data_list_source_destroy) Destroy the argument to
183 data_list_trns_free(), because it no longer does so itself.
185 Tue May 17 18:29:35 2005 Ben Pfaff <blp@gnu.org>
187 * data-out.c: (format_and_round) Don't output leading `-' if value
190 Tue May 17 00:06:43 2005 Ben Pfaff <blp@gnu.org>
194 * som.c: (output_encodings) If some cell in the table won't fit
195 with the horizontal or vertical headers, cancel those headers.
197 * som.h: (struct som_table_class) Add fits_width, fits_length,
200 * tab.c: (tabi_fits_width) New function.
201 (tabi_fits_length) New function.
202 (tabi_set_headers) New function.
203 (global var tab_table_class) Add the new functions as appropriate
206 Mon May 16 22:34:06 2005 Ben Pfaff <blp@gnu.org>
208 Fix rest of bug 13054.
210 * format.def: Fix EDATE, SDATE, ADATE, JDATE, QYR, MOYR, WKYR,
211 DATETIME, TIME system/portable file values.
213 Mon May 16 22:31:15 2005 Ben Pfaff <blp@gnu.org>
215 * data-list.c: (parse_free) Use make_input_format().
217 * data-out.c: (num_to_string) Use make_output_format().
219 * dictionary.c: (dict_create_var) Ditto.
221 * format.c: (global var f8_2) New var.
222 (make_input_format) New function.
223 (make_output_format) New function.
225 * get.c: (cmd_match_files) Use make_output_format().
227 * list.q: (cmd_list) Ditto.
229 * matrix-data.c: Ditto.
231 * sfm-read.c: (parse_format_spec) Check output specifier
234 * tab.c: (tab_float) Use make_output_format().
236 Sun May 15 23:38:10 2005 Ben Pfaff <blp@gnu.org>
238 Fix more of bug 13054.
240 * format.def: FMT_A should allow 255-character output. FMT_AHEX
241 should allow 510-character input and output.
243 * data-out.c: (num_to_string) Get rid of NEW_STYLE option.
244 (convert_E) Handle non-finite values.
246 (format_and_round) New function.
247 (convert_infinite) New function used by try_F() and convert_E().
249 Sun May 15 23:36:55 2005 Ben Pfaff <blp@gnu.org>
251 Regularize string and buffer function names so that they make some
254 * str.c: (mm_reverse) Rename buf_reverse(). Update all
256 (mm_find_reverse) Rename buf_find_reverse(). Update all
258 (mm_case_compare) Rename buf_compare_case(). Update all
260 (st_compare_pad) Rename buf_compare_rpad(). Update all
262 (str_compare_rpad) New function.
263 (st_bare_pad_copy) Rename buf_copy_str_rpad(). Update all
265 (buf_copy_str_lpad) New function.
266 (st_bare_pad_len_copy) Rename buf_copy_rpad(). Update all
268 (st_pad_copy) Rename str_copy_rpad(). Update all references.
269 (st_trim_copy) Rename str_copy_trunc(). Update all references.
270 (st_uppercase) Renamed str_uppercase(). Update all references.
272 Sat May 14 08:22:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
274 * dfm-read.c: Fixed polarity of test in dfm-close-reader. Closes
277 Tue May 10 20:08:18 2005 Ben Pfaff <blp@gnu.org>
279 * data-in.c: (data_in) Add assertion to check input specifier.
281 * data-out.c: (data_out) Add assertion to check output specifier.
283 Tue May 10 19:56:35 2005 Ben Pfaff <blp@gnu.org>
285 Start to fix bug 13054.
287 * format.c: (check_input_specifier) Improve error message.
288 (check_input_specifier) Check F, COMMA, and DOLLAR formats for
289 valid decimal places.
290 (check_output_specifier) Ditto (but different criteria).
291 (convert_fmt_ItoO) Assert valid input and output specifiers.
292 Also, if input specifier has *any* decimal places, make the output
293 specifier 1 place wider.
295 Mon May 9 07:14:29 WST 2005 John Darrington <john@darrington.wattle.id.au>
297 * sysfile-info.c: Fixed bug [# 13024 ]
299 Sun May 8 13:52:12 2005 Ben Pfaff <blp@gnu.org>
301 "Fix" bug 13021 by disabling FILE TYPE. Eventually, we should
302 actually implement it.
304 * command.c: (FILE_TYPE_okay) Always return 1.
306 * command.def: Change FILE TYPE, END FILE TYPE into UNIMPL.
308 * file-type.c: Add prototypes to get rid of warnings.
310 Sun May 8 08:08:07 WST 2005 John Darrington <john@darrington.wattle.id.au>
312 * barchart.c box-whisker.c cartesian.c piechart.c plot-hist.c: Fixed
313 more ISO/IEC 9899:1990 conformance issues.
315 Wed May 4 23:54:02 2005 Ben Pfaff <blp@gnu.org>
317 Fix bug 12948. See also new test in
318 tests/bugs/match-file-scratch.sh.
320 * get.c: (mtf_merge_dictionary) Don't compact dictionary because
321 that deletes scratch variables that someone else might be using,
322 and because we can't reassign our sources' value indexes.
323 Instead, simply don't copy scratch variables into the master
326 * dictionary.c: (dict_compact_values) Delete variables from the
327 dictionary passed in, not from default_dict (!).
329 Tue May 3 22:25:17 2005 Ben Pfaff <blp@gnu.org>
331 Improve hash.c comments, error-checking.
333 * hash.c: (struct hsh_table) [NDEBUG] Add hash_ordered member.
334 (hsh_create) size == 0 should *not* return NULL! Set
336 (hsh_clear) Set hash_ordered.
337 (locate_matching_entry) Check hash_ordered.
338 (hsh_rehash) Rename rehash(). Add assertion. Set hash_ordered.
339 (hsh_data) Set hash_ordered. Add const-ness to return value and
343 Wed May 4 08:50:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
345 * casefile.c: Removed unnecessary #include <valgrind/valgrind.h>
347 Tue May 3 19:14:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
349 * copyleft.c: Updated copyright date.
351 * Makefile.am: Removed erroneous explicit "-lplot"
353 * examine.q oneway.q: Made these files conform to ISO/IEC 9899:1990
355 Tue May 3 16:20:31 WST 2005 John Darrington <john@darrington.wattle.id.au>
357 * command.c command.def: Added description string for unimplemented commands.
359 * oneway.q: Sorted the hash tables before shipping out the results. Closes
362 Mon May 2 23:45:01 2005 Ben Pfaff <blp@gnu.org>
366 * data-list.c: (parse_fixed) Use lex_end_of_command().
368 (cmd_repeating_data) Set cont_end.num in right situations.
369 (parse_repeating_data) Remove redundant test.
371 Mon May 2 23:37:19 2005 Ben Pfaff <blp@gnu.org>
373 Partial fix for bug 12859.
375 * data-list.c: (cmd_data_list) Add transformation properly in
376 vfm_source == NULL case.
378 Mon May 2 23:27:28 2005 Ben Pfaff <blp@gnu.org>
380 * lexer.c: (lex_error) Improve error messages.
382 Mon May 2 22:28:17 2005 Ben Pfaff <blp@gnu.org>
384 * get.c: (cmd_match_files) Check token type before trying to match
385 tokid. Fixes bug 12923.
387 Mon May 2 22:16:51 2005 Ben Pfaff <blp@gnu.org>
389 * flip.c: [HAVE_SYS_TYPES_H] Include <sys/types.h>. Fixes bug
392 Mon May 2 22:02:52 2005 Ben Pfaff <blp@gnu.org>
394 * expressions/generate.pl: (get_token) Make use of /g
395 backward-compatible with Perl 5.6.1.
397 Sun May 1 23:00:19 2005 Ben Pfaff <blp@gnu.org>
399 * var-display.c: (cmd_variable_alignment) Fix memory leak.
400 (cmd_variable_level) Ditto.
402 Sun May 1 22:49:04 2005 Ben Pfaff <blp@gnu.org>
404 Hash table had buggy deletion function. The fix required changing
405 other functions to do probing in the required order.
407 * hash.c: (locate_matching_entry) Rewrite and change interface.
408 (hsh_rehash) Rewrite to use locate_matching_entry().
411 (hsh_delete) Ditto. Also, fix stupid bugs.
413 Sun May 1 22:24:58 2005 Ben Pfaff <blp@gnu.org>
415 * dictionary.c: (dict_clone) Properly copy vectors.
417 Sun May 1 22:07:58 2005 Ben Pfaff <blp@gnu.org>
419 New implementation of long variable names. Each variable has a
420 "normal" name, which may be up to 64 bytes long and which is used
421 for all normal operations. Variables may have a "short" name,
422 which is limited to 8 bytes and used only for system and portable
423 file input and output.
425 Make tokid case-preserving. Update most uses of tokid to treat it
428 Update many commands to deal with long variable names.
430 * autorecode.c: (cmd_autorecode) Use strcasecmp() instead of strcmp().
432 * command.c: (cmd_parse) Ditto.
433 (match_strings) Use toupper() before comparing characters.
434 (conflicting_3char_prefixes) Use mm_case_compare() instead of
436 (cmd_match_words) Ditto.
438 * compute.c: (lvalue_parse) Use st_trim_copy() instead of
441 * count.c: (struct cnt_var_info) Change n[] to fit long var name.
442 Use st_trim_copy() instead of strcpy().
444 * data-in.c: (parse_enum) Use mm_case_compare() instead of
447 * data-list.c: (struct dls_var_spec) Change name[] to fit long var
449 (parse_free) Use st_trim_copy() instead of strcpy().
451 * descript.c: (struct dsc_var) Change z_name[] to fit long var
453 (try_name) Use strcasecmp() instead of strcmp().
454 (generate_z_varname) Use st_trim_copy() instead of strcpy().
455 (descriptives_compare_dsc_vars) Use strcasecmp() instead of
458 * dictionary.c: (struct dictionary) Removed `long_name_tab'
460 (compare_long_names) Removed.
461 (hash_long_name) Removed.
462 (dict_create) Don't initialize `long_name_tab' member.
463 (dict_clone) Copy short names into new dictionary.
464 (dict_clear) Don't clear `long_name_tab' member.
465 (dict_get_varname_block) Removed.
466 (dict_add_longvar_entry) Removed.
468 (dict_destroy) Don't destroy `long_name_tab' member.
469 (dict_create_var_from_short) Removed.
470 (dict_create_var_x) Removed.
471 (dict_create_var) Get rid of longname handling.
473 (dict_clone_var) Get rid of longname parameter and longname
475 (dict_lookup_var) Get rid of longname handling.
476 (dict_reorder_var) New function.
477 (dict_rename_var) Clear short name.
478 (dict_rename_vars) Get rid of longname handling. Clear short
480 (dict_create_vector) Support long vector names.
481 (dict_lookup_vector) Use strcasecmp() instead of strcmp().
482 (quasi_base27) Removed.
483 (make_short_name) Removed.
484 (compare_strings) New function.
485 (hash_string) New function.
486 (dict_assign_short_names) New function.
488 * file-handle.q: (get_handle_with_name) Use strcasecmp() instead
490 (get_handle_for_filename) Support long handle names.
492 * file-type.c: (struct col_spec) Make `name' fit long var names.
493 (cmd_file_type) Use strcasecmp() instead of strcmp().
495 * flip.c: (make_new_var) Rewrite.
496 (flip_sink_write) Use st_trim_copy() instead of strncpy().
498 * format.c: (parse_format_specifier_name) Use mm_case_compare()
501 * get.c: (cmd_save_internal) Rephrase.
502 (rename_variables) Drop test for identical variable name.
503 (struct mtf_proc) Change `first', `last' to fit long var name.
505 * hash.c: (hsh_hash_case_string) New function for case-insensitive
508 * lexer.c: (restore_token) Use st_trim_copy() instead of
510 (lex_get) Don't uppercase string when copying into tokid.
511 (lex_put_back_id) Use st_trim_copy() instead of
514 * list.q: (determine_layout) Consider length of variable names in
515 choosing vertical layout.
517 * matrix-data.c: (cmd_matrix_data) Use strcasecmp() instead of
519 (string_to_content_type) Ditto.
521 * modify-vars.c: (compare_variables_given_ordering) Ditto.
522 (struct var_renaming) Change `new_name' to fit long var name.
523 (compare_var_renaming_by_new_name) Use strcasecmp() instead of
526 * pfm-read.c: (read_variables) Disallow system variables in system
528 (write_variables) Call dict_assign_short_names() and use
529 short_name[] members.
531 * repeat.c: (internal_cmd_do_repeat) Use strcasecmp() instead of
534 * sfm-read.c: (sfm_open_reader) Rewrite code for long variable
535 map. Reorder variables into same order as long variable map.
536 (read_variables) Set short name.
538 * sfm-write.c: (sfm_open_writer) Call dict_assign_short_names().
539 (write_variable) Use st_bare_pad_copy().
540 (write_longvar_table) Rewrite.
542 * str.c: (mm_case_compare) New function.
544 * sysfile-info.c: (compare_vectors_by_name) Use strcasecmp()
547 * t-test.q: (tts_custom_groups) Remove redundant test.
548 (tts_custom_pairs) Ditto.
550 * var.h: (struct variable) Change `name' to fit long var names.
551 Remove `longname'. Add `short_name' member. Reorder some
553 (struct name_table_entry) Removed.
554 (struct vector) Change `name' to fit long vector names.
556 * vars-atr.c: (var_is_valid_name) Allow long var names.
557 (compare_var_names) Use strcasecmp() instead of strcmp().
558 (compare_var_ptr_names) Ditto.
559 (hash_var_name) Use hsh_hash_case_string().
560 (hash_var_ptr_name) Ditto.
561 (var_set_short_name) New function.
562 (var_clear_short_name) New function.
563 (var_set_short_name_suffix) New function.
565 * vars-prs.c: (parse_DATA_LIST_vars) Support long names.
566 Use strcasecmp() instead of strcmp().
567 (struct array_var_set) Removed `longname_tab'.
568 (array_var_set_lookup_var_idx) Drop longname_tab support.
569 (array_var_set_destroy) Don't destroy `longname_tab'.
570 (var_set_create_from_array) Don't create `longname_tab'.
572 * vector.c: (cmd_vector) Use strcasecmp() instead of strcmp().
575 * expressions/parse.c: (word_matches) Use mm_case_compare()
577 (compare_strings) New function.
578 (lookup_function) Use compare_strings() instead of strcmp().
580 Sun May 1 22:07:43 2005 Ben Pfaff <blp@gnu.org>
582 * algorithm.c: (move_element) New function.
584 Sun May 1 22:05:35 2005 Ben Pfaff <blp@gnu.org>
586 * aggregate.c: (parse_aggregate_functions) Always initialize
589 Sun May 1 22:03:47 2005 Ben Pfaff <blp@gnu.org>
591 * aggregate.c: (cmd_aggregate) Use dict_clone_var_assert().
593 * dictionary.c: (dict_clone) Ditto.
594 (dict_clone_var_assert) New function.
596 * get.c: (mtf_merge_dictionary) Use dict_clone_var_assert().
598 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
600 * error.c: Added a string for the compiler version to the
601 request_bug_report_and_abort function.
603 * groff_font.c, font.c: Removed manpage(1) style references from
604 comments, because RMS frowns upon them.
606 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
608 * expressions/parse.c: Improve previous fix for bug 12858 (LAG).
610 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
612 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
615 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
617 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
618 which should be LONG_NAME_LEN
620 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
622 * command.def echo.c: Added the ECHO command.
624 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
626 Finish fixing MATCH FILES (bug 11677).
628 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
629 keep_variables(), rename_variables().
630 (drop_variables) New function.
631 (keep_variables) New function.
632 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
633 (cmd_match_files) Deal with in_var. Use drop_variables(),
634 keep_variables(). When IN is specified, require BY. Set master
635 variables after master dictionary is complete. Add IN variables
636 after master dictionary is complete.
637 (mtf_free_file) Free `in_name'.
638 (mtf_delete_file_in_place) Set in_var value to 0.
639 (mtf_read_nonactive_records) Rephrase.
640 (mtf_processing) Support IN. Rephrase. Fix bugs.
641 (mtf_merge_dictionary) Don't set master variables; we do that
643 (get_master) Don't insist that there's a master variable.
645 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
647 Kluge to make some variable renaming sort of work.
650 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
652 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
654 Add functions for comparing sets of variables between cases.
657 * case.c: (case_compare) New function.
658 (case_compare_2dict) New function.
660 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
662 (cmd_aggregate) Nullify break_case. Don't call
663 initialize_aggregate_info().
664 (agr_destroy) Destroy break_case.
665 (aggregate_single_case) Rewrite. Use case_compare().
666 (dump_aggregate_info) Copy from break_case into output.
667 (initialize_aggregate_info) Copy break_case from input.
669 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
671 * vfm.c: (equal_splits) Use case_compare().
673 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
675 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
677 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
679 Start work on fixing MATCH FILES.
681 * get.c: (enum operation) Remove OP_MATCH.
682 (trim_dictionary) Change return value to bool. Don't support
684 (struct mtf_file) Remove `first', `last' members.
685 (struct mtf_proc) Add `first', `last' members. Change mtf_case
686 from `struct ccase *' to `struct ccase'. Remove `by' member.
687 (cmd_match_files) Essentially rewrite.
688 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
689 (mtf_read_nonactive_records) mtf_ parameter is not unused.
690 (mtf_processing) Ditto. Also rephrase some code.
691 (mtf_merge_dictionary) Rewrite for easy comprehension.
693 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
695 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
698 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
700 Thu Apr 14 2005 John Darrington
702 * var-display.c: New file.
704 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
705 display_width, measure and alignment parameters to variables.
707 * aggregate.c command.def compute.c count.c data-list.c descript.c
708 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
709 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
710 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
711 vars-prs.c vector.c :
712 - Replaced literal constants representing maximum variable name
713 length with macro definitions.
714 - Added support for long variable names.
715 - Changed lexer such that it no longer makes tokens upper
716 case, but relies upon case insensitive behaviour of commands.
718 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
720 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
721 fails, don't dereference the resulting null pointer (bug 12427).
722 Also, fix double free error.
724 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
726 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
727 (accumulate_aggregate_info) Set int1 to 1 for SUM.
728 (dump_aggregate_info) Only make SUM non-missing if there was at
731 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
733 * aggregate.c: (dump_aggregate_info) Properly test whether the
734 destination variable is numeric, when making the result
735 system-missing for columnwise missing values.
737 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
739 * misc.h: Remove GCC specializations.
741 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
743 Make sort stable (bug 12313).
745 * sort.c: Don't need to include some headers anymore.
746 (static var min_buffers) New variable.
747 (static var max_buffers) New variable.
748 (static var allow_internal_sort) New variable.
749 (cmd_sort_cases) Add test mode.
750 (sort_execute) Rephrase.
751 (do_internal_sort) Don't try internal sorting if
752 allow_internal_sort is set.
753 (struct external_sort) Renamed `initial_runs' to `runs' and
754 updated all references.
755 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
756 (macro MIN_BUFFER_SIZE_BYTES) Removed.
757 (macro MIN_BUFFER_SIZE_RECS) Removed.
758 (compare_initial_runs) Removed.
759 (struct record_run) Add member `idx'.
760 (write_initial_runs) Pass increasing values to process_case() as
762 (process_case) Add `idx' parameter and use it to initialize new
764 (allocate_cases) Limit allocated buffers to max_buffers.
765 (compare_record_run) Use new `idx' member for last resort
766 comparison, for stability.
767 (end_run) Call casefile_sleep() on irs->casefile, to prevent
768 running out of file descriptors.
769 (struct merge_state) Removed.
770 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
771 unless we have fewer runs left. Always merge consecutive runs,
772 for stability. Return the final run.
774 (choose_merge) New function.
775 (merge_once) Rewritten.
777 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
779 * cmdline.c: (static var testing_mode) Move into
780 parse_command_line().
782 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
784 * algorithm.c: (remove_range) New function.
785 (remove_element) New function.
787 * dictionary.c: (dict_delete_var) Use remove_element().
789 * flip.c: (cmd_flip) Ditto.
791 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
793 * file-handle.q: (struct file_handle) `open_mode' should not be
796 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
798 First phase of making SORT CASES stable (bug 12313).
800 * sort.c: (struct indexed_case) New structure.
801 (do_internal_sort) Rewrite to make internal sorting stable.
802 (compare_case_dblptrs) Removed.
803 (compare_indexed_cases) New function.
805 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
809 * casefile.c: (casereader_read_xfer_assert) New function.
811 * dictionary.c: (dict_compact_case) New function.
813 * flip.c: (struct flip_pgm) New member idx_to_fv.
814 (cmd_flip) Initialize idx_to_fv member.
815 (destroy_flip_pgm) Free idx_to_fv member.
816 (flip_sink_write) Use struct flip_pgm member instead of case_sink
818 (flip_sink_write) Ditto.
820 * vfm.c: (write_case) Use dict_compact_case() instead of
822 (compact_case) Removed.
823 (storage_source_create) Removed `dict' parameter. All references
826 * vfm.h: (struct case_source) Removed `value_cnt' member. All
828 (struct case_sink) Removed `dict', `idx_to_fv' members. All
831 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
833 More AGGREGATE fixes.
835 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
836 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
838 (initialize_aggregate_info) Fix initialization for MIN, MAX for
841 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
843 Start work on testing and debugging AGGREGATE.
845 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
846 of a bit-map. Require proper subcommand ordering. Make OUTFILE
847 subcommand mandatory.
848 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
849 functions' arguments are in the correct order and swap them if
851 (accumulate_aggregate_info) Make SUM include weights. Add various
853 (dump_aggregate_info) Add various string functions.
854 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
856 * sort.c: (sort_parse_criteria) Add parameter for returning
857 whether any directions were specified. All callers updated.
859 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
861 * t-test.q: Fixed erroneous logic in compare_group_binary.
863 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
865 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
866 keywords (bug 11628).
868 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
870 * vfm.c: (procedure_with_splits) Fix bug 11492: end_func() must be
871 called *before* close_active_file().
873 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
875 * file-handle.q: (struct file_handle) Change open_mode from
876 character pointer to 3-char array, for safety. Updated all
879 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
881 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
884 * pfm-read.c: (read_header) Improve error message for many cases
885 in which the input is not actually a portable file.
887 * file-handle.q: (fh_open) When we give an error message, actually
890 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
892 * format.c: (check_common_specifier) New function for checks
893 common to check_input_specifier() and check_output_specifier().
894 (check_input_specifier) Use check_common_specifier().
895 (check_output_specifier) Use check_common_specifier().
896 (check_string_specifier) Removed.
897 (check_specifier_type) New function.
898 (check_specifier_width) New function.
899 (get_format_var_width) Fix bug.
901 * formats.c: (internal_cmd_formats) Only accept numeric variables.
903 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
904 update all references. Make case-insensitive.
906 * pfm-read.c: Essentially rewrite the whole file. Now much
909 * print.c: (check_string_width) New function.
910 (fixed_parse_compatible) Use check_string_width(),
911 check_specifier_type().
912 (dump_fmt_list) Ditto.
914 * str.c: (st_trim_copy) New function.
915 (st_uppercase) New function.
917 * vars-atr.c: (var_is_valid_name) New function.
919 * expressions/parse.c: (type_coercion_core) Use
920 check_specifier_type().
922 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
924 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
926 * expressions/parse.c: (no_match) Ditto.
928 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
930 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
932 * expressions/helpers.c: (struct func_params) Removed.
933 (generalized_idf) Removed.
936 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
938 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
939 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
940 Implement SIG.F, which I had overlooked previously.
942 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
944 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
945 available only in testing mode.
947 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
949 * data-in.c: Use `bool' throughout, where relevant.
951 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
953 DATA LIST with free-field formats should not have implied decimal
954 places (bug 12035). Also clean up data-in.c a bit.
956 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
958 * data-in.c: (apply_implied_decimals) New function.
959 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
960 set. Also, get rid of gotos.
961 (parse_Z) Use apply_implied_decimals() if the field doesn't
962 contain a decimal point.
963 (parse_N) Use apply_implied_decimals().
969 (parse_enum) New function.
970 (macro CHAR_IS_ROMAN) Removed.
971 (macro ROMAN_VALUE) Removed.
972 (parse_month) Use parse_enum().
973 (parse_weekday) Use parse_enum().
974 (parse_DATETIME) Use long for weekday.
976 * data-list.c: (read_from_data_list_fixed) Use
979 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
981 When the lexer sees something like `-5' in the input, it has to
982 decide whether it's a negative numeric constant token or a '-'
983 token followed by a positive numeric constant token. It always
984 decides on the former, and then the parser can call
985 lex_negative_to_dash() if it wants the latter. However, this
986 doesn't work for the case of `-0', because negative zero is
987 (portably) indistinguishable from positive zero. So now we divide
988 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
989 distinction clear. This requires a little bit of extra effort,
990 because there were several references to T_NUM in the code base.
992 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
993 positive and negative numeric constants.
994 (lex_double_p) Renamed lex_is_number(). Changed return type to
995 bool. Updated all relevant references to T_NUM to instead use
997 (lex_double) Renamed lex_number(). All references updated.
998 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
999 bool. All references updated.
1000 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
1001 (lex_negative_to_dash) Ditto.
1004 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
1006 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
1008 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
1010 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
1012 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
1013 values as system-missing.
1015 * expressions/parse.c: (parse_vector_element) Fix order of
1016 arguments in call to expr_allocate_binary().
1018 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
1020 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
1023 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
1024 failure, as indicated by function comment.
1025 (parse_binary_operators) Always return NULL on type_coercion()
1026 failure. Should have been doing this anyway, but bug in
1027 type_coercion_core() filtered through.
1028 (parse_add) Fix typo in user message.
1029 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
1031 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
1033 * expressions/operations.def: Add VALUE function.
1035 * expressions/parse.c: (parse_function) Need an unary composite
1036 node for variables in A TO B, not a variable node. Use
1037 allocate_unary_variable().
1038 (parse_primary) Use allocate_unary_variable().
1039 (allocate_unary_variable) New function.
1041 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
1043 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
1044 but fixed the real problem that was preventing the build from a
1045 separate directory. I liked it my way better ;-)
1047 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
1049 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
1050 John Darrington <john@darrington.wattle.id.au> for reporting this
1053 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
1055 * expressions/Makefile.am expressions/evaluate.h.pl
1056 expressions/evaluate.inc.pl expressions/operations.h.pl
1057 expressions/optimize.inc.pl expressions/parse.inc.p:
1059 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
1062 Fixed everything so that it can be built from an arbitrary
1065 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1067 * Makefile.am : Fixed up CLEANFILES target.
1069 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
1071 * str.h: Changed `struct len_string' to `struct fixed_string', a
1072 more accurate name. Updated all references.
1074 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
1076 Redo calendar support. Should now be bug-for-bug compatible.
1078 * calendar.c: New file.
1080 * calendar.h: New file.
1082 * data-in.c: Use new calendar functions.
1083 (parse_sign) Change sense of return value.
1084 (calendar_error) New function.
1085 (ymd_to_ofs) New function.
1086 (ymd_to_date) New function.
1087 (parse_DATE) Use new function.
1088 (parse_ADATE) Ditto.
1089 (parse_EDATE) Ditto.
1090 (parse_SDATE) Ditto.
1091 (parse_JDATE) Ditto.
1096 (parse_DTIME) Ditto.
1097 (parse_DATETIME) Ditto.
1099 * data-out.c: (convert_date) Use new calendar functions.
1101 * error.c: (err_vmsg) Changed interface to be more sensible.
1102 Updated all callers.
1103 (dump_message) Don't double new-lines (why did we do this
1106 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
1108 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
1109 (macro FLT64_MAX) Moved here from pref.h.orig.
1111 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
1113 * set.q: Support SET EPOCH.
1114 (static var set_epoch) New var.
1115 (aux_stc_custom_epoch) New function.
1116 (stc_custom_epoch) New function.
1117 (get_epoch) New function.
1118 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
1120 * format.c: Make it possible just to check whether a specifier is
1121 valid without emitting an error message.
1122 (parse_format_specifier_name) Change interface, update all
1124 (check_input_specifier) Ditto.
1125 (check_output_specifier) Ditto.
1126 (parse_format_specifier) Ditto.
1128 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
1130 * command.def: Add DEBUG POOL.
1132 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
1134 (pool_clear) Properly account for size of pool gizmo.
1135 (pool_realloc) Ditto.
1136 (pool_clone) New function.
1138 * pool.h: Mark our allocation functions MALLOC_LIKE.
1140 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
1142 * Makefile.am: Move many definitions into new top-level
1143 Make.build. Add expressions to SUBDIRS. Add calendar.c,
1144 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
1147 * case.c: (case_resize) New function.
1148 (case_swap) New function.
1150 * casefile.c: Include mkfile.h.
1152 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
1154 * sfm-read.c: Fixed a buglet which caused a crash when trying
1155 to read a non-existent file.
1157 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
1161 * aggregate.c: (parse_aggregate_functions) Code cleanup.
1162 Important part: get rid of spurious copying of function->format to
1163 destvar->print and destvar->write.
1165 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
1167 Fix bug 11916, which was confusing a variable's `index' member
1168 with the variable's position in a var_set. Although these are
1169 usually the same, they are not for array `var_set's.
1171 Took advantage of this bug as an opportunity to clean up and
1172 rewrite parse_var_set_vars().
1174 * vars-prs.c: (parse_vs_variable_idx) New function.
1175 (parse_vs_variable) Reimplement in terms of
1176 parse_vs_variable_idx().
1177 (parse_var_idx_class) New function.
1178 (add_variable) New function.
1179 (add_variables) New function.
1180 (parse_var_set_vars) Rewritten.
1181 (struct var_set) Change `lookup_var' member that returns a
1182 variable into `lookup_var_idx' member that returns an int.
1183 Updated the var set implementations in obvious corresponding ways.
1184 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
1186 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
1188 Use our global variable compare & hash functions and give them
1189 better names. Add similar functions for dealing with double
1190 pointers to variables.
1192 * vars-atr.c: (compare_variables) Renamed compare_var_names().
1193 (hash_variable) Renamed hash_var_name().
1194 (compare_var_ptr_names) New function.
1195 (hash_var_ptr_name) New function.
1197 * t-test.q: (cmd_t_test) Use global compare_var_names(),
1199 (compare_var_name) Removed.
1200 (hash_var_name) Removed.
1202 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
1206 * dictionary.c: (compare_variable_dblptrs) Rename
1207 compare_var_ptrs() and fix it to properly dereference the double
1210 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
1212 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
1213 declare subcommands as mandatory. Closed bug #11843
1215 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
1217 * getline.c command.[ch] command.def: Added (very rudimentary)
1218 support for line completion when in interactive mode. Partially
1219 addresses bug #11693
1221 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
1223 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
1224 problems revealed by valgrind.
1227 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
1229 * set.q: Affixed a fix to the previous fix such that we'll be OK now
1230 whether or not PAGER is set.
1232 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
1234 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
1235 "invalid free" errors. Hopefully fixes bug #11722
1237 * compute.c expr-prs.c: Check that lvalues are populated before
1238 attempting to destroy them. Closes bug #11676
1240 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
1242 * aggregate.c: Initialised the complete agr_proc structure.
1246 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
1248 * print.c: (print_trns_free) Close the dfm writer if there is one,
1249 fixing a memory leak.
1251 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
1253 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
1257 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
1259 * linked-list.[ch] Added
1261 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
1262 set.q: Yet more memory leaks
1264 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
1266 * t-test.q examine.q : More memory leaks fixed.
1268 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
1270 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
1273 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1275 * ascii.c cartesian.c casefile.c chart.h devind.c
1276 examine.q frequencies.q
1277 html.c output.h piechart.c plot-chart.c plot-hist.c
1279 Integrated the chart rendering into the output stream
1280 (currently only works for html).
1282 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
1283 dummy-chart.c for compiling without charts.
1285 * mkfile.[ch] Created.
1287 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
1288 Added type element so we can tell if it's a chart or a table.
1290 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
1291 API of charts to be more like that of tables.
1293 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
1295 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
1296 main.c. Removed the handler for SIGQUIT.
1298 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
1300 * casefile.c: Added a signal handler to delete temp files on
1303 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
1305 * command.def Added a lot more unimplemented commands.
1307 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
1309 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
1311 * sort.c: (compare_initial_runs) Needed additional level of
1313 (merge_once) Fix plenty of stupid mistakes.
1315 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
1317 * casefile.c: (casefile_sleep) Need to flush_buffer() after
1318 calling casefile_to_disk() or we will lose the last block in the
1319 file if the casefile started out as disk-based.
1320 (casefile_get_reader) Initialize reader->destructive to 0.
1321 (cmd_debug_casefile) Add new test pattern.
1322 (test_casefile) Define new test pattern to make sure
1323 casefile_sleep() works properly.
1325 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
1327 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
1328 plot-hist.c plot-chart.c (Added) Reorganised these files in an
1329 attempt to seperate the creation and processing of charts from their
1332 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
1335 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
1337 * main.c Added a signal handler for SIGFPE
1339 * sort.c Somewhat more robust fix to the previous entry.
1341 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
1343 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
1344 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
1345 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
1348 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
1350 * case.h Fixed bug # 11307
1352 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
1354 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
1357 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
1359 * pfm-read.c: (read_variables) Remove direct manipulation of
1360 v->aux, which is no longer needed. Fixes bug 11483.
1362 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
1364 * data-list.c Fixed a bug in parsing delimiters.
1366 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
1369 * percentiles.c Properly handled calculation of Tukey hinges where
1370 the number of data is small.
1372 * oneway.q Used the generic value_to_string function for independent
1373 variable instead of trying to do it ourselves.
1375 * box-whisker.c Fixed a buglet which caused a crash if the number of
1379 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1381 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
1383 * percentiles.c Fixed some bugs when calculating percentiles when
1384 there's a small number of cases.
1386 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
1388 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
1390 * examine.q factor_stats.[ch] Added calculation of percentiles
1392 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1394 * t-test.q Fixed bug #11227 Made t-test work when the independent
1397 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1399 * factor_stats.c Fixed calculation of trimmed mean under various
1402 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
1404 * histogram.c chart.[ch] factor_stats.c frequencies.q
1406 Added code to calculate sensible histogram ranges and limits.
1408 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
1410 * chart.h Updated to reflect many API changes.
1412 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
1413 cartesian.c and into chart.c
1415 * factorstats.[ch] Added the histogram calculations
1417 * casefile.c Removed an unused variable.
1419 * frequencies.q examine.q histogram.c Reworked the API for
1422 * piechart.c Revised the API for piecharts.
1424 * var.h Moved the definitions of freq_tab and freq out of var.h
1425 and into frequencies.q where they belong.
1427 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
1429 * flip.c: (flip_file) Check for off_t separately from fseeko(),
1430 using AC_TYPE_OFF_T.
1432 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
1434 * flip.c: (flip_file) If fseeko() is not available, use long int
1435 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
1436 reporting the problem.
1438 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
1440 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
1441 conflict with stdio.
1443 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
1445 * var-labs.c (var_to_string) Now returns null if the variable is null
1447 * value-labels.c (value_to_string) Made it return null if either the
1448 value or the variable is null.
1450 * hash.c (hsh_clear) Fixed a buglet.
1452 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
1453 with the wrong model.
1455 * casefile.[ch] Added a function to return the casereader.case_idx
1458 * examine.q Implemented the extreme values results.
1460 John Darrington <john@darrington.wattle.id.au>
1462 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
1463 output.[ch] getline.c
1465 Plugged some memory leaks
1467 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
1469 Adopt GSL random number generators, paving the way for providing
1470 the complete suite of random number generators on expressions.
1472 * Makefile.am: Remove random.c, random.h.
1474 * random.c: Removed.
1476 * random.h: Removed.
1478 * algorithm.c: (algo_default_random) Use GSL functions.
1480 * casefile.c: (test_casefile) Use GSL RNG functions.
1482 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
1485 * sample.c: (cmd_sample) Use GSL RNG functions.
1486 (sample_trns_proc) Ditto.
1488 * set.q: (static var set_seed) Removed.
1489 (static var seed_flag) Removed.
1490 (static var rng) New variable.
1491 (aux_stc_custom_seed) No seed value anymore, don't print anything.
1492 (stc_custom_seed) Use new seed functions.
1493 (seed_is_set) Removed.
1494 (get_rng) New function that composes the entire external
1496 (set_rng) New function.
1497 (random_seed) New function.
1499 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
1501 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
1502 John Darrington <john@darrington.wattle.id.au> for reporting this
1505 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1507 * permissions.c command.def Added the PERMISSIONS command
1509 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
1511 * q2c.c: (dump_header) Don't try to emit #includes at very top of
1512 output file because that will precede #include <config.h>, which
1514 (main) Add needed headers to /* (header) */ code.
1516 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
1518 Instead of making system or portable file readers responsible for
1519 dropping and reordering variables, make them read full cases and
1520 let the caller take care of any changes.
1522 * get.c: New "case map" structure to handle this. Use for GET,
1523 IMPORT, MATCH FILES. Essentially rewrite the whole file.
1525 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
1526 changed appropriately.
1528 * sfm-read.c: (sfm_read_case) Ditto.
1530 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
1532 Decided that case_serialize() and case_unserialize() were too
1533 abstract. Also we need a couple more functions to avoid excessive
1534 copying for data in/out fast paths.
1536 * case.c: (case_serial_size) Removed.
1537 (case_serialize) Rename case_to_values() and make its argument
1538 explicitly an array of union values.
1539 (case_unserialize) Rename case_from_values() and make its argument
1540 explicitly an array of union values.
1541 (case_data_all) New function.
1542 (case_data_all_rw) New function.
1544 * casefile.c: (struct casefile) Change buffer from array of
1545 unsigned char to array of union value for better accuracy.
1546 Redefine buffer_used and buffer_size in terms of values, not
1547 bytes. Remove case_size because it is now redundant with
1548 value_cnt. Fix up all references to these members.
1550 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
1552 * barchart.c: (struct subcat) Make `label' member const to silence
1553 GCC warning with -Wwrite-strings.
1555 * cartesian.c: (struct dataset) Ditto.
1557 * case.c: Don't re-define NDEBUG if already defined.
1558 Add lots of comments.
1560 * str.c: Fix includes.
1562 * crosstabs.q: Fix includes.
1564 * examine.q: Fix includes. Fix GCC warning about unused
1567 * frequencies.q: (stat macro) Removed and replaced where used by
1570 * list.q: Fix includes.
1572 * oneway.q: Fix includes.
1574 * piechart.c: Fix includes. Only define M_PI if not already
1577 * sfm-read.c: (bswap) New function.
1578 (bswap_int32) Write in terms of bswap.
1579 (bswap_flt64) Ditto.
1581 * str.c: (ds_data) Add external definition here, needed because
1582 str.h has only an `extern inline' version.
1584 * value-labels.c: Fix includes.
1586 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
1588 Instead of providing a system or portable file writer with a raw
1589 case in the format needed for output, provide it with a regular
1590 case. The writer takes care of any needed translation.
1592 * aggregate.c: Adopt new scheme for AGGREGATE.
1593 (struct agr_proc) sfm_agr_case member removed.
1594 (write_case_to_sfm) Removed because the new interface is easier to
1597 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
1599 * pfm-write.c: Implement new scheme.
1601 * sfm-write.c: Ditto.
1603 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
1605 Instead of treating `struct file_handle' as a class to subclass
1606 into data files, system files, and portable files, instead use it
1607 as a helper that coordinates access. Now it is opaque, too.
1609 This means that most references to a struct file_handle are now
1610 changed into references to one of struct dfm_reader, struct
1611 dfm_writer, struct sfm_reader, struct sfm_writer, struct
1612 pfm_reader, or struct pfm_writer, according to what's being read
1615 Most related changes are only worth summarizing briefly.
1617 * dictionary.c: (dict_clear) Destroy aux data in deleted
1619 (dict_clear_aux) New function.
1620 (dict_create_var) Initialize aux, aux_dtor.
1621 (dict_delete_var) Destroy aux data in deleted variable.
1623 * file-handle.h: (struct fh_ext_class) Removed.
1624 (struct file_handle) Removed.
1625 (fh_init_files) Removed.
1627 * file-handle.q: Changed references to a handle's `private' member
1628 to direct references.
1629 (struct private_file_handle) Renamed file_handle.
1630 Add next, open_cnt, type, open_mode, aux members.
1631 (struct file_handle_list) Removed.
1632 (extern var inline_file) Removed.
1633 (static var file_handles) Changed from file_handle_list * to
1635 (create_file_handle) Initialize new members.
1636 (fh_close_handle) Removed.
1637 (mode_name) New function.
1638 (fh_open) New function.
1639 (fh_close) New function.
1640 (fh_parse_file_handle) Renamed fh_parse().
1642 * glob.c: (init_glob) Remove fh_init_files() call.
1644 * aggregate.c: use sfm_writer.
1645 (create_sysfile) Removed because the new interface is simpler.
1647 * apply-dict.c: Use sfm_reader.
1649 * data-list.c: Use dfm_reader.
1651 * file-type.c: Use dfm_reader.
1653 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
1655 * inpt-pgm.c: Use dfm_reader.
1657 * print.c: Use dfm_writer.
1659 * sysfile-info: Use sfm_reader.
1661 * dfm-read.c: Adopt new file handle infrastructure.
1663 * dfm-write.c: Ditto.
1665 * pfm-read.c: Ditto.
1667 * pfm-write.c: Ditto.
1669 * sfm-read.c: Ditto.
1671 * sfm-write.c: Ditto.
1673 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
1675 Break dictionary functions into separate header file.
1677 * dictionary.h: New file.
1679 * var.h: Moved dict_*() functions to dictionary.h.
1681 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
1683 Get rid of procedure-specific union in struct variable, using
1684 instead a void * pointer and a destructor function.
1686 Most related changes are only worth brief summaries.
1688 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
1689 old p.crs member in struct variable.
1691 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
1692 of old p.frq member in struct variable.
1694 * histogram.c: (draw_histogram) Takes new freq_tab arg because
1695 it's no longer possible to grab this from var->p.frq.
1697 * piechart.c: (draw_piechart) Ditto.
1699 * group.c: (group_proc_get) New function.
1701 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
1708 * main.c: (execute_command) Clear aux data in default_dict after
1709 each command. (It's debatable whether this should be done.)
1711 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
1712 member in struct variable.
1714 * means.q: Get rid of integer mode, which is not included in
1715 recent SPSS and was the only code that wanted per-variable private
1718 * var.h: (struct crosstab_proc) Removed.
1719 (struct frequencies_proc) Removed.
1720 (struct list_proc) Removed.
1721 (struct get_proc) Removed.
1722 (struct means_proc) Removed.
1723 (struct matrix_data_proc) Removed.
1724 (struct match_files_proc) Removed.
1725 (lots of enums) Removed.
1726 (struct variable) Removed members `p', `get'. Add member
1729 * vars-atr.c: (var_attach_aux) New function.
1730 (var_detach_aux) New function.
1731 (var_clear_aux) New function.
1732 (var_dtor_free) New function.
1733 (discard_variables) Use NULL instead of inline_file.
1735 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1737 * value-labs.c Fixed the implmentation of value_to_string, so
1738 that it properly handles alpha values.
1740 * oneway.q Changed instances where labels were being probed manually,
1741 to use the canonical {var,value}_to_string functions
1743 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1745 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
1746 plots. Changed the API of the cartesian plot to be a much lower level
1749 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
1751 * examine.q Added some of the parametric calculations
1753 * factor_stats.[ch] Created
1755 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1757 * examine.q Changed the definition of factors to be a composite, and
1758 dealt with the consequences.
1760 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
1762 * examine.q Fixed problem where examine wasn't dealing properly with
1765 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
1767 * oneway.q Fixed problem where oneway wasn't dealing properly with
1770 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
1772 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
1773 command which had settings didn't get the appropriate code
1776 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
1777 to convert variables/values to strings.
1779 * examine.q Added framework for the EXAMINE command.
1781 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
1783 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
1784 subcommand types. Changed frequencies.q to use it rather then the
1785 custom parser. Dealt with the consequences. Added a test for NTILES
1786 subcommand of frequencies.
1788 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
1790 * oneway.q Fixed up the behaviour when given missing values
1792 * levene.c oneway.q Fixed a buglet with the levene statistic and
1793 incorporated the levene test into the oneway command.
1795 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
1796 global scope, since they're only relevant to T-TEST
1798 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
1800 * group.c group.h group_proc.h levene.c oneway.q t-test.q
1802 Made the t-test more consistent
1803 with the way it handles groups. That is, it now uses a hash instead
1804 of an array of 2. Also, made the levene.c file independent of the
1805 implementation of the t-test. So now levene should be fine for both
1808 * Added an oneway.q file for one way anova
1810 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
1812 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
1815 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
1819 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
1820 (data_list_trns_free) Free dls->delims.
1822 * t-test.q: (tts_custom_pairs) Free vars.
1823 (ssbox_one_sample_init) Fix tab_vline() argument.
1824 (ssbox_independent_samples_init) Ditto.
1825 (trbox_paired_init) Ditto.
1826 (trbox_one_sample_init) Ditto.
1828 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
1830 Generalize casefiles to the extent that we can use them for
1831 sorting and other kinds of data transformations. Change cases to
1832 be copy-on-write to improve memory efficiency in common cases.
1833 Every access to a member of a `struct ccase' was changed to be a
1834 call to a case_*() function, especially case_data(), case_num(),
1835 case_str(), or case_data_rw(). Many instances of a local variable
1836 named "case_num" were changed to "case_idx" as a consequence.
1837 Many `struct ccase *' were changed to actual `struct ccase'
1838 because of copying semantics of cases. In several places there
1839 was a choice between updating debug code to work with the new ADTs
1840 or just deleting it because it was useless; I chose to delete it.
1842 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
1848 * aggregate.c: (struct agr_proc) Change type of `sort' to
1849 sort_criteria *. Add `break_vars', `break_var_cnt' members.
1850 Rename `vars' to `agr_vars', all references updated. Change
1851 `agr_case' to type `struct ccase'.
1852 (cmd_aggregate) Deal with new members. Use case_create(),
1853 sort_active_file_in_place(), sort_active_file_to_casefile().
1854 (agr_destroy) Deal with new members.
1855 (aggregate_single_case) Ditto.
1856 (dump_aggregate_info) Ditto.
1857 (initialize_aggregate_info) Ditto.
1858 (agr_to_active_file) Ditto.
1859 (presorted_agr_to_sysfile) Ditto.
1860 (sort_agr_to_sysfile) Removed.
1862 * alloc.c: (out_of_memory) Make non-static.
1864 * alloc.h: Prototype out_of_memory().
1866 * casefile.c: Switched from a linked list in-memory representation
1867 to a two-level array-style representation. The linked list was
1868 appropriate when we could stick a header onto cases, but that's no
1869 longer the case. Also, the two-level array will allow for random
1870 in-memory access in case that's ever wanted. Also added the
1871 concept of a `destructive casereader', one that destroys cases in
1872 the underlying casefile as they are read out.
1873 (macro CASES_PER_BLOCK) New macro.
1874 (struct casefile) New members `value_cnt', `case_list_size',
1875 `case_acct_size', `being_destroyed', `cases'. Removed `head',
1877 (struct casereader) Removed `cur'. Added `destructive', `c'.
1878 (global var casefiles) Made static.
1879 (static var case_bytes) New var.
1880 (casefile_create) Takes a value count, not a case size in bytes,
1881 to conform to the case interface. All callers updated. Deal with
1882 new and removed members.
1883 (casefile_destroy) Deal with new and removed members.
1884 (casefile_sleep) New function.
1885 (casefile_get_case_size) Removed.
1886 (casefile_get_value_cnt) New function.
1887 (casefile_append) Rewritten to deal with new and removed members.
1888 (casefile_append_xfer) New function.
1889 (write_case_to_disk) Use case_serialize().
1890 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
1891 Couldn't figure out why.
1892 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
1893 deal with new and removed members.
1895 (merge_sort) Removed.
1896 (casefile_sort) Removed.
1897 (casefile_get_reader) Deal with new and removed members.
1898 (casefile_get_destructive_reader) New function.
1899 (reader_open_file) Make code more readable. Create case for
1901 (casereader_get_casefile) New function.
1902 (casereader_read) Deal with new and removed members. Now returns
1903 a copy of the case, so that the caller is responsible for
1904 destroying the returned case.
1905 (casereader_read_xfer) New function.
1906 (casereader_destroy) Destroy reader's case.
1907 (test_casefile) Second arg is now a value count, all callers
1908 updated. Now tests destructive readers too.
1909 (get_random_case) Deal with new case ADT.
1910 (write_random_case) Ditto.
1911 (read_and_verify_random_case) Ditto.
1913 * crosstabs.q: Remove debug code.
1915 * descript.q: (calc_descriptives) Deal with new case, casefile
1918 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
1920 * do-if.c: Remove unneeded header inclusion.
1922 * expr-prs.c: Remove debug code.
1924 * exprP.h: Remove debug code.
1926 * flip.c: (flip_file) Use fseeko() if available.
1928 * formats.c: Remove debug code.
1930 * get.c: Remove debug code.
1931 (struct mtf_file) Change `input' from `union value *' to `struct
1932 ccase', all references updated.
1934 * levene.c: (levene) Deal with new case, casefile ADTs.
1936 * list.q: Remove debug code.
1938 * loop.c: Remove debug code.
1940 * matrix-data.c: Remove debug code.
1942 * means.q: Remove debug code.
1944 * mis-val.c: Remove debug code.
1946 * pfm-read.c: Remove debug code.
1947 (pfm_read_code) Change second arg from `union value *' to `struct
1948 ccase *', all references updated.
1950 * recode.c: (string_to_long) Make first arg const.
1951 (convert_to_double) Ditto.
1953 * repeat.c: Remove debug code.
1955 * sample.c: Remove debug code.
1957 * sfm-read.c: Remove debug code.
1958 (sfm_read_case) Change second arg from `union value *' to `struct
1961 * sort.c: Redone in terms of casefiles.
1962 (enum sort_direction) Moved here from sort.h.
1963 (struct sort_criterion) New structure.
1964 (struct sort_criteria) New structure.
1965 (cmd_sort_cases) Rewritten.
1966 (prepare_to_sort_active_file) New function.
1967 (sort_active_file_in_place) New function.
1968 (sort_active_file_to_casefile) New function.
1969 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
1970 changed, all callers updated.
1971 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
1972 rewritten & interface changed, all callers updated.
1973 (sort_cases) Renamed sort_execute(), rewritten & interface
1974 changed, all callers updated.
1975 (struct internal_sort) Removed.
1976 (do_internal_sort) Rewritten, interface changed.
1977 (destroy_internal_sort) Removed.
1978 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
1979 (struct initial_run) Removed; an initial run is now just a
1981 (compare_initial_runs) Rewritten.
1982 (struct external_sort) Changed almost completely.
1983 (do_external_sort) Rewritten, interface changed.
1984 (destroy_external_sort) Rewritten.
1985 [HAVE_MKDTEMP] (make_temp_dir) Removed.
1986 [!HAVE_MKDTEMP] (do_mkdir) Removed.
1987 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
1988 (init_external_sort) Removed.
1989 (simulate_error) Removed.
1990 (rmdir_temp_dir) Removed.
1991 (get_temp_file_name) Removed.
1992 (open_temp_file) Removed.
1993 (close_temp_file) Removed.
1994 (remove_temp_file) Removed.
1995 (write_temp_file) Removed.
1996 (read_temp_file) Removed.
1997 (struct record_run) Change `record' from `struct case_lit *' to
1999 (struct initial_run_state) Remove `idx_to_fv', `free_list',
2000 `file_idx', `output_file'. Add `run', casefile'. Change
2001 `last_output' from `struct case_list *' to `struct ccase'.
2002 (write_initial_runs) Change interface, rewrite.
2003 (sort_sink_write) Renamed process_case(), changed interfaced,
2005 (destroy_initial_run_state) Rewritten.
2006 (allocate_cases) Rewritten.
2007 (compare_record) Interface changed, rewritten.
2008 (start_run) Rewritten.
2009 (end_run) Rewritten.
2010 (output_record) Rewritten.
2011 (grab_case) Removed.
2012 (release_case) Removed.
2013 (struct merge_case) Change `cases' from double pointer to single
2015 (merge) Deal with new case and casefile ADTs.
2016 (struct run) Removed.
2017 (merge_once) Rewritten, interface changed.
2018 (fill_run_buffer) Removed.
2019 (sort_sink_make_source) Removed.
2020 (sort_sink_class) Removed.
2021 (struct sort_source_aux) Removed.
2022 (sort_source_read_helper) Removed.
2023 (sort_source_read) Removed.
2024 (read_sort_output) Removed.
2025 (read_internal_sort_output) Removed.
2026 (read_external_sort_output) Removed.
2027 (sort_source_destroy) Removed.
2028 (sort_source_class) Removed.
2030 * sort.h: (struct sort_cases_pgm) Removed.
2031 (enum sort_direction) Moved to sort.c.
2033 * t-test.q: (calculate) Deal with new case, casefile ADTs.
2035 * tab.c: Remove debug code.
2037 * var-labs.c: Remove debug code.
2039 * var.h: (struct ccase) Removed.
2040 (struct case_list) Removed.
2042 * vars-atr.c: (discard_variables) Use free_case_source().
2044 * vars-prs.c: (parse_vs_variable) Make arg const.
2045 (parse_dict_variable) Ditto.
2046 (parse_variables) Make struct dictionary * arg const.
2047 (parse_var_set_vars) Make struct var_set * arg const.
2048 (struct var_set) Add const to some of the function pointers' args.
2049 (var_set_get_cnt) Make arg const.
2050 (var_set_get_var) Make first arg const.
2051 (var_set_lookup_var) Make first arg const.
2052 (dict_var_set_get_cnt) Make arg const.
2053 (dict_var_set_get_var) Make first arg const.
2054 (dict_var_set_lookup_var) Make first arg const.
2055 (var_set_create_from_dict) Make arg const. Add cast to aux
2057 (struct array_var_set) Add const to var member.
2058 (array_var_set_get_cnt) Make arg const.
2059 (array_var_set_get_var) Make first arg const.
2060 (array_var_set_lookup_var) Make first arg const.
2061 (var_set_create_from_array) Make first arg const. Insert cast.
2063 * vfm.c: (struct write_case_data) Change trns_case, sink_case
2064 members from `struct ccase *' to `struct ccase'.
2065 (static var lag_queue) Change from double to single pointer.
2066 (procedure) Optimize trivial case.
2067 (internal_procedure) Deal with changed case, case_source ADTs.
2068 (create_trns_case) Changed interface, rewrote.
2069 (open_active_interface) Initialize modified lag queue.
2070 (write_case) Deal with changed case ADT.
2071 (lag_case) Deal with modified lag queue.
2072 (close_active_file) Destroy modified lag queue.
2073 Deal with changed case_source, case_sink ADTs.
2074 (destroy_storage_stream_info) Make null arg into no-op.
2075 (storage_sink_make_source) Set aux in created source.
2076 (storage_source_read) Deal with changed case, casefile ADTs.
2077 (storage_source_create) New function.
2078 (lagged_case) Rewrite.
2079 (free_case_source) New function.
2080 (free_case_sink) Rewrite.
2081 (struct split_aux_data) Changed prev_case from `struct ccase *' to
2083 (procedure_with_splits) Deal with changed prev_case.
2084 (procedure_with_splits_callback) Ditto.
2085 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
2087 (multipass_procedure_with_splits) Deal with changed prev_case.
2088 (multipass_split_callback) Ditto.
2091 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
2093 The workspace idea didn't work out.
2095 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
2097 * workspace.c: Removed.
2099 * workspace.h: Removed.
2101 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
2103 Fully implement arbitrary delimiters on DATA LIST, extending the
2104 half implementation that was already there.
2106 * data-list.c: (struct data_list_pgm) Remove `delim', add
2107 `delims', `delim_cnt'.
2108 (cmd_data_list) Initialize new members. Parse delimiters and
2109 clean up code a bit.
2110 (cut_field) Extract fields with arbitrary delimiters. Also, fix
2111 handling of leading commas.
2112 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
2114 (read_from_data_list_free) Adapt to new DFM interfaces.
2115 (read_from_data_list_list) Ditto.
2116 (repeating_data_trns_proc) Ditto.
2118 * dfm.c: Split up reader and writer into separate code, because
2119 they do different things. Use struct string instead of explicit
2120 allocation code, for clarity.
2121 (enum dfm_reader_flags) New enum.
2122 (struct dfm_fhuser_ext) Removed.
2123 (struct dfm_reader_ext) New.
2124 (get_reader) New function, used by just about all the reader
2126 (dfm_close) Removed.
2127 (close_reader) New function.
2128 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
2129 (dfm_open_for_writing) Ditto.
2130 (macro force_line_buffer_expansion) Removed.
2131 (count_tabs) Removed.
2132 (tabs_to_spaces) Removed.
2133 (read_record) Deal with new dfm_reader_ext. Use struct string
2134 functions. Don't convert tabs to spaces.
2135 (dfm_eof) New function.
2136 (dfm_get_record) Changed interface, rewrote.
2137 (dfm_expand_tabs) New function.
2138 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
2139 dfm_reader_ext, rewritten.
2140 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
2141 dfm_reader_ext, rewritten.
2142 (dfm_set_record) Removed in favor of dfm_forward_columns().
2143 (dfm_forward_columns) New function.
2144 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
2145 dfm_reader_ext, rewritten.
2146 (static var dfm_r_class) Use close_reader for the destructor.
2147 (struct dfm_writer_ext) New.
2148 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
2149 bounce buffer now instead of local allocation.
2150 (close_writer) New function.
2151 (static var dfm_writer_ext) Use close_writer for destructor.
2152 (cmd_begin_data) Adapt to new dfm_reader_ext.
2154 * file-handle.q: Add support for per-file tab width.
2155 (struct private_file_handle) Add tab_width member.
2156 (q2c specifications) Add tabwidth subcommand.
2157 (cmd_file_handle) Put parsed tab width into private_file_handle.
2158 (create_file_handle) Set default tab width.
2159 (handle_get_tab_width) New function.
2161 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
2163 * inpt-pgm.c: (reread_trns_proc) Ditto.
2165 * matrix-data.c: (context) Ditto.
2166 (another_token) Ditto.
2170 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
2172 * casefile.c: (casefile_destroy) Fix memory leak by freeing
2174 (casereader_destroy) Don't close file descriptor -1.
2176 * recode.c: (cmd_recode) Fix memory leak.
2178 * set.q: (q2c specifications) Fix typo in user message.
2180 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
2181 undefined behavior for overlapping arguments.
2183 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
2185 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
2186 don't call it when we're running under valgrind.
2187 (call_posix_fadvise) New function.
2188 (casefile_to_disk) Use call_posix_fadvise().
2189 (reader_open_file) Ditto.
2191 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
2193 Update our string ADTs, struct string and struct len_string. Get
2194 rid of pool support, which was largely unused. Rename lots of
2195 functions to have more obvious or consistent names.
2197 * ascii.c: Get rid of ascii_pool. It was only used for string
2199 (ascii_open_global) Don't create ascii_pool.
2200 (ascii_close_driver) Don't destroy ascii_pool.
2201 (ascii_postopen_driver) Don't use pool.
2202 (ascii_close_driver) Destroy strings manually.
2204 * str.c: (ds_create) Remove pool argument, all references updated.
2206 (ds_replace) Remove pool support, make more efficient when we
2207 don't need to reallocate.
2208 (ds_destroy) Remove pool support.
2209 (ds_rpad) New function.
2210 (ds_size) Renamed ds_capacity(), all references updated.
2211 (ds_value) Renamed ds_c_str(), all references updated.
2212 (ds_concat) Renamed ds_puts(), all references updated.
2213 (ds_concat_buffer) Renamed ds_concat(), all references updated.
2214 (ds_putchar) Renamed ds_putc(), all references updated.
2215 (ds_getline) Renamed ds_gets(), all references updated.
2216 (ls_create) Remove pool argument, all references updated.
2217 (ls_create_buffer) Ditto.
2218 (ls_destroy) Removed pool support.
2219 (ls_value) Renamed ls_c_str(), all references updated.
2221 * str.h: (ls_length) [__GNUC__] Add inline version.
2222 (ls_c_str) [__GNUC__] Add inline version.
2223 (ls_end) [__GNUC__] Add inline version.
2224 (struct string) Remove pool member. Rename `size' to `capacity',
2225 all references updated.
2227 * tab.c: (text_format) Instead of using pool argument to
2228 ls_create_buffer(), call pool_register() on allocated data.
2230 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
2232 We're abusing the current ASCII driver by telling it to allocate a
2233 9999-line, 9999-character page in the tests. This causes some
2234 systems to curl up and die because it allocates 20 MB of
2235 contiguous RAM. This change alleviates at least part of the
2236 problem. It is mostly a stop-gap until the new output system is
2239 * ascii.c: (struct line) New structure.
2240 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
2241 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
2242 (ascii_preopen_driver) Initialize new members, not old ones.
2243 (ascii_close_driver) Destroy new members, not old ones.
2244 (ascii_open_page) Allocate new members, not old ones.
2245 (expand_line) Allocate room in line.
2246 (draw_line) Use new members.
2247 (ascii_line_horz) Ditto.
2248 (ascii_line_vert) Ditto.
2249 (ascii_line_intersection) Ditto.
2251 (output_lines) Ditto.
2252 (ascii_close_page) Ditto.
2254 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
2256 * matrix.c: Dead code. Removed.
2258 * matrix.h: Dead code. Removed.
2260 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
2262 Contrary to what I'd always understood, there is an efficient
2263 algorithm for deletion from a hash table populated via linear
2264 probing. This change implements it.
2266 * hash.c: (hsh_rehash) Probe in increasing order.
2268 (locate_matching_entry) Ditto.
2269 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
2271 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
2273 * moments.c (calc_moments): Adjust calculation of kurtosis to
2274 avoid subtracting huge numbers from huge numbers, on Michael
2277 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
2279 Rework moments routines for improved numerical stability based on
2280 Michael Kiefte's advice. Any bugs or remaining numerical problems
2281 are still mine though.
2283 There is now a struct moments1 for use with one-pass moments. It
2284 uses a provisional means algorithm as an attempt to improve
2285 accuracy of higher moments. The older struct moments now only
2286 handles two-pass moments.
2288 * aggregate.c: Use moments1 instead moments.
2290 * descript.c: Revert previous change, which is no longer needed
2291 due to the moments revision.
2293 * moments.c: (calc_moments) New function for calculating variance,
2295 (moments_pass_one) Only accumulate weights bigger than zero.
2296 (moments_calculate) Allow calculating the mean on pass one, others
2297 require pass two. Implement in terms of calc_moments().
2298 (struct moments1) New structure.
2299 (init_moments1) New function.
2300 (moments1_clear) Ditto.
2301 (moments1_create) Ditto.
2302 (moments1_add) Ditto.
2303 (moments1_calculate) Ditto.
2304 (moments1_destroy) Ditto.
2305 (cmd_debug_moments) Deal with `struct moments' or `struct
2306 moments1' as requested by user.
2308 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
2310 * Makefile.am (pspp_SOURCES): Remove debug.c.
2312 * debug.c: Removed. It was empty anyway.
2314 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
2316 * descript.c (calc_descriptives): Fix assert failure when only
2317 MOMENT_MEAN is needed.
2319 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
2323 fixed problem with parsing in match_statistic() causing
2324 "DESCRIPTIVE STAT=MEAN." to barf.
2326 "MEAN" is now default if "SORT" given without specification.
2328 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
2329 generally less forgiving of syntax errors: better to have it do
2330 nothing and type it in again then to not know what it actually did
2333 z-score transformation now checks score for user-missing values
2334 and checks std_dev for SYSMIS.
2336 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
2338 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
2339 Changed dict_get_case_weight() to accept an additional int * flag
2340 to complain about system-missing, user-missing, zero, or negative
2341 weights and updated existing functions to pass int * to
2342 dict_get_case_weight().
2344 2004-04-05 jmd <jmd@gnu.org>
2346 * main.c: Fixed configuration problems with gsl
2348 * t-test.q: Fixed some problems encountered when compiling under Cygwin
2350 2004-04-03 blp <blp@gnu.org>
2352 * lexer.c, ChangeLog:
2353 Fix infinite loop on comment at end of file, add test.
2355 2004-04-03 jmd <jmd@gnu.org>
2357 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
2358 Fixed the calculation of percentiles and added --syntax and --algorithm options
2360 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
2362 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
2365 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
2367 * frequencies.q: Fixed the calculation of percentiles
2369 * Makefile.am: Added the --ansi flag and dealt with the
2370 consequences. Added some entries to PSPP_sources so that
2371 make distcheck would pass
2373 * cmdline.c: Added the --syntax and --algorithm options
2375 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
2377 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2379 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
2380 use the new multipass_split_... mechanism.
2382 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
2384 * frequencies.q: (calc_stats) Use moments data structure and
2385 calc_seskew(), calc_sekurt() functions.
2387 * set.q main.c settings.h Added support for --syntax and --algorithm
2390 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
2392 * vfm.c: Had to get last call to multipass_split_output() inside
2393 open_active_file()/close_active_file() pairing, so introduce new
2395 (internal_procedure) Move procedure() code here, except for calls
2396 to open_active_file() and close_active_file().
2397 (procedure) Wrap open_active_file() and close_active_file() around
2398 internal_procedure().
2399 (multipass_procedure_with_splits) Wrap open_active_file() and
2400 close_active_file() around internal_procedure().
2402 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
2404 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
2406 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
2408 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
2410 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
2412 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
2414 * algorithm.c: By default turn off some of the more expensive
2416 (expensive_assert) New macro which expands to assert if
2417 EXTRA_CHECKS is defined, to nothing otherwise.
2418 (unique) Use expensive_assert().
2419 (binary_search) Ditto.
2425 * command.c: (conflicting_3char_prefixes) Words that are the same
2426 don't cause conflicts when they are abbreviated to the first three
2429 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
2430 nonterm_node's n earlier.
2431 (generic_str_func) Ditto.
2433 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
2435 Add support for multipass procedures. Rewrite DESCRIPTIVES to
2436 test multipass support, take advantage of new moments
2437 calculation, and to not be such crappy code. Get rid of q2c
2438 processing for DESCRIPTIVES.
2440 * vfm.c: (struct multipass_split_aux_data) New structure.
2441 (multipass_procedure_with_splits) New function.
2442 (multipass_split_callback) New function.
2443 (multipass_split_output) New function.
2444 * descript.q: Removed.
2446 * descript.c: New file.
2448 * var.h: Removed descriptives enums.
2449 (struct descriptives_proc) Removed.
2450 (struct variable) Removed p.dsc.
2452 * Makefile.am: (q_sources_c) Remove descript.c.
2453 (q_sources_q) Removed descript.q.
2455 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
2457 New manager for keeping track of used workspace.
2459 * workspace.c: New file.
2461 * workspace.h: New file.
2463 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
2465 * sort.c: (do_internal_sort) Use workspace_malloc().
2466 (destroy_internal_sort) Use workspace_free().
2468 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
2470 New `struct casefile' for managing sets of cases.
2472 * casefile.c: New file.
2474 * casefile.h: New file.
2476 * command.def: Add DEBUG CASEFILE command.
2478 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
2480 * sort.c: (sort_cases) Move logic for sending storage file to disk
2481 into do_external_sort().
2482 (struct internal_sort) Use an array of ccase pointers instead of a
2484 (do_internal_sort) Rewrite to handle casefiles.
2485 (compare_case_list) Removed.
2486 (compare_cases) New function.
2487 (compare_case_dblptrs) New function.
2488 (read_internal_sort_output) Deal with new struct internal_sort.
2490 * vfm.c: (static var workspace_overflow) Removed.
2491 (struct storage_stream_info) Removed all the members. Added
2492 struct casefile * member.
2493 (storage_sink_open) Use casefile.
2494 (open_storage_file) Removed.
2495 (write_storage_file) Removed.
2496 (storage_to_disk) Removed.
2497 (destroy_storage_stream_info) Use casefile.
2498 (storage_sink_write) Use casefile.
2499 (storage_sink_make_source) Use casefile.
2500 (storage_source_count) Use casefile.
2501 (storage_source_read) Use casefile.
2502 (storage_source_on_disk) Removed.
2503 (storage_source_get_cases) Removed.
2504 (storage_source_set_cases) Removed.
2505 (storage_source_get_casefile) New function.
2507 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
2509 New `struct moments' for calculating moments.
2515 * moments.c: New file.
2517 * moments.h: New file.
2519 * command.def: Add DEBUG MOMENTS command.
2521 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
2524 * aggregate.c: Modify AGGREGATE to use the new moments
2525 calculation, even if not in such a great way.
2526 (struct agr_var) Add `moments' member.
2527 (parse_aggregate_functions) Set `moments' member to null.
2528 (agr_destroy) Destroy `moments' member.
2529 (accumulate_aggregate_info) Use `moments' for standard deviation.
2530 (dump_aggregate_info) Ditto.
2531 (initialize_aggregate_info) Create or clear `moments'.
2533 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
2534 cube(), pow4() that were in stats.h. All references updated.
2536 * crosstabs.q: stats.h had chi-square significance functions. Use
2538 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
2540 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
2541 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
2543 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
2545 * dictionary.c: (dict_compact_values) Compacted values need to
2548 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
2550 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
2551 `/' at start. Check return value of parse_variables() for error
2554 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
2556 Revamp expressions: make the code a little nicer, and fix bugs
2559 * expr-evl.c: (expr_evaluate) Make expression argument const.
2560 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2561 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
2562 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
2563 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
2564 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
2565 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
2566 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
2567 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
2568 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
2569 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
2570 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
2571 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
2572 Simplify OP_SYSMIS. Remove OP_STR_MIS.
2574 * expr-opt.c: (optimize_expression) Rewrite.
2579 (macro s0l) Removed.
2581 (macro s1l) Removed.
2583 (macro s2l) Removed.
2586 (eq_num_con) New function.
2587 (optimize_tree) New function.
2588 (macro rnc) Removed.
2589 (macro frnc) Removed.
2590 (str_search) Add const to string params.
2591 (str_rsearch) Ditto.
2592 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
2593 str[], str_len[] locals to substitute for most of removed macros.
2594 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2595 Removed support for missing values because we're never called with
2596 missing values. Use set_number() or set_number_errno() instead of
2597 rnc or frnc. Removed any stuff that caused trouble in testing.
2598 We can re-add it later if it really slows anything. Fix some
2600 (evaluate_tree_with_missing) Not yet supported. To be added later
2602 (repl_num_con) Removed.
2603 (collapse_node) New function.
2604 (force_repl_num_con) Removed.
2605 (set_number) New function.
2606 (set_number_errno) New function.
2607 (repl_str_con) Removed.
2608 (set_string) New function.
2609 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
2611 (dump_node) No special case for OP_AND, OP_OR.
2613 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
2614 (expr_get_type) New function.
2615 (type_check) Rewrite.
2616 (type_coercion) New function.
2617 (struct operator) New structure.
2618 (match_operator New function.
2619 (parse_binary_operators) New function.
2620 (parse_inverting_unary_operator) New function.
2621 (parse_or) Rewritten.
2622 (parse_and) Rewritten.
2623 (parse_not) Rewritten.
2624 (parse_rel) Rewritten.
2625 (parse_add) Rewritten.
2626 (parse_mul) Rewritten.
2627 (parse_neg) Rewritten.
2628 (parse_exp) Rewritten.
2629 (parse_sysvar) Add $TRUE, $FALSE system variables.
2630 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
2631 (parse_primary) Use allocate_var_node(), allocate_num_con(),
2633 (struct function) Remove desc, change `func' prototype.
2634 (unary_func) Remove special cases.
2635 (MISSING_func) Reduce to unary_func() that just returns a boolean.
2636 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
2637 (VALUE_func) Use allocate_var_node().
2638 (nary_num_func) Allow MIN and MAX for strings.
2639 Use allocate_var_node(). Properly clean up.
2641 (generic_str_func) Use local table instead of removed `desc'
2642 member. Mostly rewrite.
2643 (get_num_args) Revise error message.
2644 (parse_function) Return EXPR_ERROR, not 0 on error.
2646 (macro varies) Removed.
2647 (ops[]) Use expr.def.
2648 (free_node) Do nothing if node is null.
2649 (allocate_num_con) New function.
2650 (allocate_str_con) New function.
2651 (allocate_var_node) New function.
2652 (allocate_binary_nonterminal) New function.
2653 (append_nonterminal_arg) Removed.
2654 (static var func_tab[]) Revised.
2655 (expr_debug_print_postfix) Make parameter const.
2656 Use printf() instead of debug_printf().
2658 * expr.def: New file.
2660 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
2661 use named enum instead of unnamed, all references updated. Add
2662 EXPR_ANY, EXPR_NO_OPTIMIZE.
2664 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
2665 instead of defining OP_* directly.
2666 (macro IS_TERMINAL) New macro.
2667 (macro IS_NONTERMINAL) New macro.
2668 (enum OP_NO_FLAGS) New.
2670 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
2672 * error.c: (err_assert_fail) msg variable needs to be non-const.
2674 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
2676 * debug.c: (cmd_debug_evaluate) Rewrite.
2678 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
2680 Fix some CROSSTABS bit rot stupidity.
2682 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
2683 (internal_cmd_crosstabs) Initializes cells[] correctly.
2684 (float_M_suffix) Rename format_cell_entry(), change prototype,
2686 (display_crosstabulation) Fix cell formatting.
2688 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
2690 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
2691 to call lex_discard_line() to do that.
2693 * command.c: (run_command) Call lex_discard_line() after
2696 * lexer.c: (lex_entire_end) Change behavior.
2697 (lex_rest_of_line) Change behavior. Return const char *.
2698 (lex_discard_line) Don't clear getl_buf, don't emit message.
2700 * main.c: (handle_error) Emit message here.
2702 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
2703 instead of lex_entire_line().
2705 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
2707 * title.c: (get_title) Call lex_discard_line() after
2709 (cmd_file_label) Ditto.
2710 (cmd_document) Deal with const char * return value.
2712 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
2714 Removed REMARK command.
2716 * command.c: (extract_prefix) Removed.
2717 (output_line) Removed.
2718 (cmd_remark) Removed.
2720 * command.def: Remove REMARK.
2722 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
2724 Added abort() after lots of assert(0) invocations to avoid some
2725 compiler warnings. We really need a NOT_REACHED macro.
2727 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2729 * sort.c: Added missing call to temp_file_close. Changed error
2730 messages to warnings.
2732 * set.q: Improved setting of set_view{length,width} to be more tolerant
2735 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
2737 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
2738 used with incorrect syntax.
2740 * error.c, error.h et al: Overridden definition of assert for a
2743 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
2744 subcommand was given when it ought to have been.
2746 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
2748 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
2752 (tab_joint_text) Ditto.
2754 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
2756 * levene.c: Add #include.
2758 * set.q: (set_viewport) Add `int' argument to make its prototype
2759 correct for signal().
2761 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
2763 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
2766 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
2768 Changed DFM from open-at-first-access to explicit-open. Before,
2769 calling dfm_get_record() or dfm_put_record() would automatically
2770 open the file. Now, you have to call dfm_open_for_reading() or
2771 dfm_open_for_writing() explicitly. This makes it possible to
2772 check permissions, file existence, etc. earlier.
2774 Also made struct file_handle more opaque, and clean up in general.
2776 * data-list.c: (cmd_data_list) Open handle for reading.
2778 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
2780 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
2781 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
2782 (open_inline_file) Removed.
2783 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
2784 it. Deal with line_number in extension record instead of file
2786 (dfm_get_record) Rewrote.
2787 (dfm_put_record) Rewrote.
2788 (dfm_push) Assert file is open and one of ours. Deal with
2789 line_number in extension record instead of file handle.
2790 (dfm_pop) Assert file is open and one of ours. Deal with
2791 line_number in extension record instead of file handle.
2792 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
2795 * file-handle.h: (enum constants RH_RF_*) Removed.
2796 (enum constants FH_MD_*) Removed.
2797 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
2798 `recform', `lrecl', `mode' members. Public references to
2799 `recform' changed to use handle_get_mode(), references to `lrecl'
2800 changed to use handle_get_record_width(). Added `private' member.
2801 (enum file_handle_mode) New.
2803 * file-handle.q: (struct private_file_handle) New structure.
2804 (struct file_handle_list) New structure.
2805 (static var files) New.
2806 (static var file_handles) Removed.
2807 (init_file_handle) Removed.
2808 (create_file_handle) Removed.
2809 (get_handle_with_name) New function.
2810 (get_handle_for_filename) New function.
2811 (cmd_file_handle) Rewritten.
2812 (hash_file_handle) Removed.
2813 (cmp_file_handle) Removed.
2814 (fh_init_files) Rewritten.
2815 (fh_parse_file_handle) Rewritten. Allows identifiers as
2817 (fh_get_handle_by_name) Renamed handle_get_name(), all references
2819 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
2820 references updated. Rewritten.
2821 (fh_record_width) Renamed handle_get_record_width(), all
2822 references updated. Rewritten.
2823 (handle_get_mode) New function.
2825 * file-type.c: (cmd_file_type) Open handle for reading.
2827 * filename.c: [unix] (struct file_identity) New structure.
2828 [unix] (fn_get_identity) New function.
2829 [unix] (fn_free_identity) New function.
2830 [unix] (fn_compare_file_identities) New function.
2831 [!unix] (struct file_identity) New structure.
2832 [!unix] (fn_get_identity) New function.
2833 [!unix] (fn_free_identity) New function.
2834 [!unix] (fn_compare_file_identities) New function.
2836 * lexer.c: (static var put) Renamed put_token, all references
2838 (static var put_tokstr) New.
2839 (static var put_tokval) New.
2840 (lex_init) Initialize put_tokstr().
2841 (restore_token) New function.
2842 (save_token) New function.
2843 (lex_get) Use restore_token().
2844 (lex_put_back) Use save_token().
2845 (lex_put_back_id) New function.
2846 (lex_put_forward) Removed.
2847 (lex_preprocess_line) Set put_token instead of using
2849 (lex_negative_to_dash) Use save_token(), set put_token directly.
2850 (dump_token) Use stderr instead of stdout.
2852 * main.c: (main) Remove call to cmd_init().
2854 * matrix-data.c: (cmd_matrix_data) Open file for reading.
2856 * pfm-read.c: Use handle_get_filename() instead of trying to use
2857 h->fn directly, all over.
2859 * pfm-write.c: Ditto.
2861 * print.c: (internal_cmd_print) Open handle for writing.
2862 (dump_table) Use handle_get_filename().
2863 (print_trns_proc) Use handle_get_mode().
2864 (cmd_print_space) Use fh_parse_file_handle().
2865 Open handle for writing.
2866 [0] (debug_print) Removed.
2868 * sfm-read.c: Use handle_get_filename() instead of trying to use
2869 h->fn directly, all over.
2871 * sfm-write.c: Ditto.
2873 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
2877 * autorecode.c: (arc_free) Free arc->src_values.
2879 * error.c: (msg) Free buf.
2881 * val-labs.c: (do_value_labels) Always free vars.
2883 * vfm.c: (close_active_file) If sink has no make_source then call
2884 its destroy function.
2886 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
2888 Fixed cmd_parse() so that it always skips past a full command
2889 name. A few special commands for which this would be bad get
2890 special treatment. This lets us drop code for skipping past the
2891 end of a command name in most cmd_*() functions. It's not worth
2892 listing all the commands affected.
2894 * command.c: (struct command) Remove `cmd' member, replace by
2895 `name' member, all references updated. Remove `word', `next',
2896 `skip_entire_name' members.
2897 (macro DEFCMD) Deal with revised `struct command'.
2898 (macro UNIMPL) Ditto.
2899 (macro SPCCMD) New macro for commands whose last word shouldn't be
2901 (static array cmd_table[]) Make const, rename `commands', remove
2903 (macro COMMAND_CNT) New macro.
2904 (split_words) Removed.
2906 (FILE_TYPE_okay) Make parameter const.
2907 (cmd_parse) Improve error messages.
2908 (match_strings) New function.
2909 (next_word) New function.
2910 (enum command_match) New enum.
2911 (conflicting_3char_prefixes) New function.
2912 (conflicting_3char_prefix_command) New function.
2913 (cmd_match_words) New function.
2914 (count_matching_commands) New function.
2915 (get_command_name) New function.
2916 (free_words) New function.
2917 (unknown_command_error) New function.
2918 (figure_out_command) Renamed parse_command_name(), rewritten.
2920 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
2921 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
2922 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
2925 * command.h: (macro SPCCMD) New.
2927 * include.c: (cmd_include_at) Removed.
2928 (cmd_include) Allow identifier to be used as filename.
2930 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
2932 * t-test.q: (cmd_t_test) Command name is now parsed for us.
2935 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
2937 Start work on better test framework.
2939 * Makefile.am: (pspp_sources) Add debug.c.
2941 * debug.c: New file.
2943 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
2944 cmd_debug_evaluate().
2946 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
2948 * expr.h: (enum constant PXP_DUMP) Removed.
2950 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
2952 * set.q: Implemented the SHOW command, and synced it to the existing
2955 Added a handler for SIGWINCH so that viewlength and viewwidth follow
2956 changes as the window size is changed.
2958 Added fallback to set viewlength and viewwidth from LINES and COLUMS
2959 environment variables if other methods are not available.
2961 glob.c: Removed a lot of global variables from glob.c and encapsulated
2964 random.c: Tidied up the way the random seed is set.
2966 str.c: Added a ds_vprintf function.
2968 error.c: Extended dump_message so that messages are always broken at
2971 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
2973 * pfm-write.c: (bufwrite) Write out the correct element for string
2974 variables. From Andreas Streichardt <streichardt@globalpark.de>.
2976 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
2978 Get rid of static and global (!) vars in matrix-data.c.
2980 * matrix-data.c: (static var nr_data) Removed.
2981 (static var nr_factor_values) Removed.
2982 (static var max_cell_index) Removed.
2983 (static var split_values) Removed.
2984 (struct nr_aux_data) New structure.
2985 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
2986 place of static vars, pass to create_case_source() and procedure()
2988 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
2989 struct matrix_data_pgm *.
2990 (nr_read_splits) Ditto.
2991 (nr_read_factors) Ditto.
2992 (nr_output_data) Ditto.
2993 (static var wr_content) Removed.
2994 (global var wr_data) Removed.
2995 (global var wr_current) Removed.
2996 (struct wr_aux_data) New structure.
2997 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
2998 place of static vars, pass to create_case_source() and procedure()
3000 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
3001 instead of matrix_data_pgm *.
3002 (wr_read_splits) Ditto.
3003 (wr_output_data) Ditto.
3004 (wr_read_rowtype) Ditto.
3005 (wr_read_factors) Ditto.
3006 (wr_read_indeps) Ditto.
3008 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
3010 Get rid of static vars in autorecode.c.
3012 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
3013 `n_arc' to `spec_cnt'. All references updated.
3014 (static var v_src) Removed.
3015 (static var v_dest) Removed.
3016 (static var h_trns) Removed.
3017 (static var nv_src) Removed.
3018 (static var descend) Removed.
3019 (static var print) Removed.
3020 (enum direction) New enum.
3021 (struct autorecode_pgm) New structure.
3022 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
3023 Move n_dest local var into struct autorecode_pgm for ease of
3024 clean-up. Use arc_free().
3025 (arc_free) New function.
3026 (recode) Modify to take struct autorecode_pgm * parameter instead
3027 of using statics. Let the caller clean up.
3028 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
3029 instead of statics. Rearrange code a little.
3031 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
3033 Get rid of static, global vars in recode.c. Remove debug code.
3035 * recode.c: (static var head) Removed.
3036 (global var v) Removed.
3037 (global var nv) Removed.
3038 (cmd_recode) New local variables head, v, nv. Initialize and free
3039 v. Don't call debug_print().
3040 [DEBUGGING] (dump_dest) Removed.
3041 [DEBUGGING] (debug_print) Removed.
3043 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
3045 Get rid of static vars in expr-opt.c.
3047 * expr-opt.c: (static var e) Removed.
3048 (static var nop) Removed.
3049 (static var mop) Removed.
3050 (static var ndbl) Removed.
3051 (static var mdbl) Removed.
3052 (static var nstr) Removed.
3053 (static var mstr) Removed.
3054 (static var nvars) Removed.
3055 (static var mvars) Removed.
3056 (struct expr_dump_state) New structure.
3057 (dump_expression) Use new struct expr_dump_state instead of static
3058 vars and pass to functions we call.
3059 (dump_node) Use struct expr_dump_state * parameter.
3061 (emit_num_con) Ditto.
3062 (emit_str_con) Ditto.
3065 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
3067 Get rid of static var in COUNT.
3069 * count.c: (static var head) Move into cmd_count().
3070 (cmd_count) [DEBUGGING] Don't call debug_print.
3071 [DEBUGGING] (debug_print) Removed.
3073 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
3075 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
3077 * val-labs.c: (static var v) Removed.
3078 (static var nv) Removed.
3079 [DEBUGGING] (debug_print) Removed.
3080 (verify_val_labs) Add struct variable **, int parameters.
3081 (get_label) Ditto. Improve error messages, streamline.
3082 (erase_labels) New function for erasing value labels, taking over
3083 part of verify_val_labs()'s function.
3086 (cmd_value_labels) No need to call init() or done() anymore.
3087 (cmd_add_value_labels) Ditto.
3088 (do_value_labels) Add vars, var_cnt local variables. Clean up
3089 after them internally. Call erase_labels() if we should. Don't
3092 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
3094 Get rid of static vars in MATCH FILES.
3096 * get.c: (static var mtf_head) Removed.
3097 (static var mtf_tail) Removed.
3098 (static var mtf_by) Removed.
3099 (static var mtf_n_by) Removed.
3100 (static var mtf_master) Removed.
3101 (static var mtf_seq_num) Removed.
3102 (static var mtf_seq_nums) Removed.
3103 (static var mtf_sink) Removed.
3104 (static var mtf_case) Removed.
3105 (struct mtf_proc) New structure.
3106 (cmd_match_files) Use struct mtf_proc instead of static vars.
3107 (mtf_processing_finish) Ditto.
3109 (mtf_delete_file_in_place) Ditto.
3110 (mtf_read_nonactive_records) Ditto.
3111 (mtf_compare_BY_values) Ditto.
3112 (mtf_processing) Ditto.
3113 (mtf_merge_dictionary) Ditto.
3115 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
3117 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
3119 * dictionary.c: (dict_rename_var) Add assertion.
3120 (dict_contains_var) Check by index instead of name.
3122 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
3124 Get rid of compaction_necessary, compaction_nval, compaction_case.
3125 Redo VFM interface. Replace disk_sink and memory_sink by
3126 storage_sink, disk_source and memory_source by storage_source.
3128 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
3132 (struct write_case_data) Remove `begin_func', `end_func',
3133 `func_aux' members. Add `aux', `trns_case', `sink_case',
3134 `cases_written', `cases_analyzed' members.
3135 (global var compaction_necessary) Make static.
3136 (global var compaction_nval) Removed.
3137 (global var compaction_case) Removed.
3138 (static var case_count) Removed.
3139 (struct procedure_aux_data) Removed.
3140 (struct split_aux_data) Removed.
3141 (procedure) Remove begin_func, end_func parameters. Rewrite.
3142 (static var not_canceled) Removed.
3143 (process_active_file) Removed.
3144 (process_active_file_write_case) Removed.
3145 (process_active_file_output_case) Removed.
3146 (prepare_for_writing) Moved into open_active_file().
3147 (arrange_compaction) Ditto.
3149 (open_active_file) Rewrote.
3150 (write_case) New function.
3151 [DEBUGGING] (index_to_varname) Removed.
3152 (execute_transformations) New function.
3153 (exclude_this_case) Renamed filter_case(), changed interface.
3154 (clear_case) Added struct ccase * parameter to interface.
3155 (close_active_file) Added struct write_case_data * parameter,
3157 (disk_sink_create) Removed.
3158 (disk_sink_destroy) Removed.
3159 (disk_sink_make_source) Removed.
3160 (disk_sink_write) Removed.
3161 (disk_source_count) Removed.
3162 (disk_source_destroy) Removed.
3163 (disk_source_read) Removed.
3164 (global var disk_sink_class) Removed.
3165 (global var disk_source_class) Removed.
3166 (global var memory_sink_class) Removed.
3167 (global var memory_source_class) Removed.
3168 (memory_sink_create) Removed.
3169 (memory_sink_destroy) Removed.
3170 (memory_sink_make_source) Removed.
3171 (memory_sink_write) Removed.
3172 (memory_source_count) Removed.
3173 (memory_source_destroy) Removed.
3174 (memory_source_get_cases) Removed.
3175 (memory_source_read) Removed.
3176 (memory_source_set_cases) Removed.
3177 (struct disk_stream_info) Removed.
3178 (struct memory_sink_info) Removed.
3179 (struct memory_source_info) Removed.
3180 (write_active_file_to_disk) Removed.
3181 (destroy_storage_stream_info) New function.
3182 (global var null_sink_class) New var.
3183 (global var storage_sink_class) New var.
3184 (global var storage_source_class) New var.
3185 (open_storage_file) New function.
3186 (storage_sink_destroy) New function.
3187 (storage_sink_make_source) New function.
3188 (storage_sink_open) New function.
3189 (storage_sink_write) New function.
3190 (storage_source_count) New function.
3191 (storage_source_destroy) New function.
3192 (storage_source_get_cases) New function.
3193 (storage_source_on_disk) New function.
3194 (storage_source_read) New function.
3195 (storage_source_set_cases) New function.
3196 (storage_source_to_disk) New function.
3197 (storage_to_disk) New function.
3198 (struct storage_stream_info) New structure.
3199 (write_storage_file) New function.
3200 (procedure_write_case) Removed.
3201 (create_case_source) Add `struct dictionary *' parameter, all
3203 (create_case_sink) Ditto.
3204 (free_case_sink) New function.
3205 (struct split_aux_data) New structure.
3206 (procedure_with_splits) New function implementing what procedure()
3208 (SPLIT_FILE_proc_func) Removed.
3209 (procedure_with_splits_callback) New function.
3210 (equal_splits) New function.
3212 * aggregate.c: Pass around a struct instead of using statics.
3213 (static var outfile) Remove.
3214 (enum type) Give it tag `missing_treatment'.
3215 (static var missing) Remove.
3216 (static var sort) Remove.
3217 (static var agr_first) Remove.
3218 (static var agr_next) Remove.
3219 (static var case_count) Remove.
3220 (static var prev_case) Remove.
3221 (static var buf64_1xx) Remove.
3222 (static var buf_1xx) Remove.
3223 (struct agr_proc) New structure incorporating the above.
3224 (cmd_aggregate) Use new struct. Clean up error handling using
3225 agr_destroy(). Completely rewrite actual implementation of
3227 (create_sysfile) Add struct agr_proc * parameter, modify
3229 (parse_aggregate_functions) Ditto.
3230 (free_aggregate_functions) Ditto. Rename agr_destroy().
3231 (aggregate_single_case) Add struct agr_proc * parameter, modify
3233 (accumulate_aggregate_info) Ditto.
3234 (dump_aggregate_info) Ditto.
3235 (initialize_aggregate_info) Ditto.
3236 (agr_00x_trns_proc) Removed.
3237 (agr_00x_end_func) Removed.
3238 (agr_10x_trns_proc) Removed.
3239 (agr_10x_trns_free) Removed.
3240 (agr_10x_end_func) Removed.
3241 (agr_11x_read) Removed.
3242 (agr_11x_finish) Removed.
3243 [DEBUGGING] (debug_print) Removed.
3244 (write_case_to_sfm) Add struct agr_proc * parameter, modify
3246 (agr_to_active_file) New function.
3247 (presorted_agr_to_sysfile) New function.
3248 (sort_agr_to_sysfile) New function.
3250 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
3252 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
3254 * descript.q: (cmd_descriptives) Ditto.
3256 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
3257 to new procedure() interface.
3259 * command.c: (cmd_execute) Adapt to new procedure() interface.
3261 * dictionary.c: (dict_compact_values) Also delete scratch
3263 (dict_get_compacted_value_cnt) New function.
3264 (dict_get_compacted_idx_to_fv) New function.
3266 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
3267 (cmd_flip) Adapt to new procedure() interface.
3268 (flip_sink_write) Use sink->idx_to_fv.
3270 * frequencies.q: (internal_cmd_frequencies) Use
3271 procedure_with_splits().
3273 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
3274 (static var mtf_sink) New static var.
3275 (static var mtf_case) New static var.
3276 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
3277 we actually implement the matching.
3278 (mtf_delete_file_in_place) Use mtf_case.
3279 (mtf_processing) Use mtf_case and mtf_sink.
3280 (cmd_export) Adapt to new procedure() interface.
3282 * levene.c: (levene) Use procedure_with_splits().
3284 * list.q: (cmd_list) Use procedure_with_splits().
3286 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
3287 procedure() interface.
3288 (read_matrices_with_rowtype) Ditto.
3290 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
3291 TEMPORARY. Adapt to new procedure() interface.
3293 * rename-vars.c: Warn about and cancel TEMPORARY.
3295 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
3296 (sort_cases) Use dict_get_compacted_value_cnt() instead of
3297 compaction_nval. Adapt to new procedure() interface. Use
3298 storage_source_to_disk().
3299 (do_internal_sort) Don't try to dump the cases to memory.
3300 (compare_case_lists) Pass null idx_to_fv.
3301 (struct initial_run_state) Add `idx_to_fv' member. Remove
3303 (write_initial_runs) Don't initialize irs->case_size. Adapt to
3304 new procedure() interface. Reset irs->idx_to_fv after calling
3306 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
3307 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
3309 (destroy_initial_run_state) Don't dereference irs after freeing
3311 (allocate_cases) Don't calculate case_size locally.
3312 (compare_record) Add idx_to_fv parameter.
3313 (compare_record_run) Change parameter from struct sort_cases_pgm *
3314 to struct initial_run_state *. Pass irs->idx_to_fv to
3316 (compare_record_run) Third parameter now a struct
3317 initial_run_state *.
3318 (output_record) No need for out_case anymore. Pass irs, not
3319 struct sort_cases_pgm to pop_heap(). Use case_size from struct
3321 (merge) Use case_size from struct sort_cases_pgm.
3322 (merge_once) Use case_size from struct sort_cases_pgm.
3323 Pass null pointer to compare_record() as idx_to_fv.
3324 (global var sort_sink_class) Make static.
3326 * t-test.q: (cmd_t_test) Use procedure_with_splits().
3328 * temporary.c: Remove debugging crap.
3330 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
3332 * t-test.q, levene.c: Fixed up the handling of MISSING values
3335 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
3337 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
3340 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
3342 Change explicit variable name checks into use of
3343 dict_class_from_id().
3345 * dictionary.c: (dict_create_var) Change explicit variable name
3346 check into use of dict_class_from_id().
3348 * get.c: (trim_dictionary) Ditto.
3350 * sel-if.c: (cmd_filter) Ditto.
3352 * sysfile-info.c: (cmd_display) Ditto.
3354 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
3356 * vfm.c: (arrange_compaction) Ditto.
3358 * weight.c: (cmd_weight) Ditto.
3360 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
3362 * temporary.c: (cmd_temporary) When TEMPORARY was the first
3363 transformation following the input program, if any, for some
3364 reason we special-cased f_trns. That's just wrong. It should
3365 always be set to n_trns.
3367 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
3369 * format.c: (parse_format_specifier_name) Fix brown-bag bug
3370 introduced in last check-in.
3372 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
3374 * format.c: (global array translate_fmt[]) Removed.
3375 (translate_fmt) New function as replacement.
3376 (parse_format_specifier_name) Rewrite.
3378 * pfm-read.c: (convert_format) Use translate_fmt() instead of
3381 * sfm-read.c: (parse_format_spec) Ditto.
3383 * postscript.c: (text) Fix handling of fonts with missing
3386 * sort.c: (struct external_sort) Add temp_name member.
3387 (destroy_external_sort) Free temp_dir, temp_name members.
3388 (init_external_sort) Allocate temp_name.
3389 (get_temp_file_name) Change prototype.
3390 (open_temp_file) Deal with change to get_temp_file_name().
3391 (close_temp_file) Ditto.
3392 (remove_temp_file) Ditto.
3393 (write_temp_file) Ditto.
3394 (read_temp_file) Ditto.
3395 (sort_sink_destroy) Removed.
3396 (sort_sink_class) Change destroy member to null.
3398 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
3400 Eliminate temp_case.
3402 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
3403 anymore. Use agr_11x_finish().
3404 (aggregate_single_case) Make first param const.
3405 (accumulate_aggregate_info) Ditto.
3406 (agr_00x_end_func) Use compaction_case, not temp_case.
3407 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
3409 * data-list.c: (struct data_list_pgm) Add `case_size' member.
3410 (cmd_data_list) Initialize case_size.
3411 (read_from_data_list_fixed) Add struct ccase * param, use instead
3413 (read_from_data_list_free) Ditto.
3414 (read_from_data_list_list) Ditto.
3415 (read_one_case) Rename data_list_trns_proc(), all references
3416 updated. Add argument in calling above functions. Use c
3417 argument instead of temp_case.
3418 (destroy_dls) Rename data_list_trns_free(), all references
3421 * expr-evl.c: (expr_evaluate) Make second parameter const.
3423 * file-type.c: (struct file_type_pgm) Add `case_size' member.
3424 (cmd_end_file_type) Initialize `case_size'.
3425 (file_type_source_read) Add struct ccase * parameter. Use instead
3428 * flip.c: Rewritten.
3430 * get.c: (struct get_pgm) New structure to keep track of
3432 (cmd_get) Initialize case_size.
3434 (get_source) Deal with struct get_pgm.
3435 (get_source_read) Add struct ccase * parameter, use instead of
3437 (import_source_read) Ditto.
3439 * get.c: Use a null pointer instead of temp_case to represent the
3440 "current case" in a struct mtf_file's input member.
3441 (mtf_processing_finish) Pass null to mtf_processing(), not
3443 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
3444 (mtf_compare_BY_values) Add extra arg, use instead of null input
3446 (mtf_processing) Use c parameter instead of temp_case. Pass
3447 compaction_case to process_active_file_output_case().
3449 * glob.c: (global variable temp_case) Removed.
3451 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
3452 (cmd_input_program) Initialize case_size. Set
3453 vfm_source->value_cnt.
3454 (init_case) Add struct ccase * parameter, use instead of
3457 (input_program_source_read) Ditto.
3459 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
3460 (dump_cell_content) Ditto.
3461 (nr_output_data) Ditto.
3462 (read_matrices_without_rowtype) Ditto.
3463 (matrix_data_read_with_rowtype) Ditto.
3464 (wr_read_splits) Ditto.
3465 (wr_output_data) Ditto.
3467 * sort.h: (struct sort_cases_pgm) New member `case_size'.
3469 * sort.c: (sort_cases) Initialize scp->case_size.
3470 (struct external_sort) Remove `case_size' member.
3471 (write_initial_runs) Only call vfm_sink->class_destroy if
3473 (struct sort_source_aux) New structure.
3474 (sort_source_read_helper) New function.
3475 (sort_source_read) Use sort_source_read_helper().
3476 (read_sort_output) Change interface to be more reasonable.
3477 (read_internal_sort_output) Ditto.
3478 (read_external_sort_output) Ditto.
3480 * vars-prs.c: (dict_class_to_name) Pass return value through
3483 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
3484 (procedure) Initialize trns_case.
3485 (procedure) Pass trns_case to vfm_source->class->read().
3487 (process_active_file) Start using struct procedure_aux_data.
3488 (process_active_file_write_case) Pass trns_case to
3489 transformations, lag_case(), clear_case().
3490 (process_active_file_output_case) Add struct ccase * parameter.
3491 (create_trns_case) New function.
3492 (make_temp_case) Removed.
3493 (vector_initialization) Removed.
3494 (close_active_file) Only call make_source if non-null, otherwise
3495 set vfm_source to null pointer. Don't free temp_case.
3496 (disk_source_read) Add struct ccase * parameter, use instead of
3498 (memory_source_read) Ditto.
3499 (lag_case) Add const struct ccase * member.
3500 (procedure_write_case) Use trns_case instead of temp_case.
3501 (clear_case) Add struct ccase * member, use instead of temp_case.
3502 (exclude_this_case) Ditto.
3503 (create_case_source) Add struct dictionary * parameter, use to
3504 initialize source->value_cnt.
3506 * vfm.h: (struct case_source) Add `value_cnt' member.
3507 (struct case_source_class) Add struct ccase * parameter to `read'
3508 member function pointer.
3509 (struct case_sink_class) Make struct ccase * parameter const in
3510 `write' member function pointer.
3512 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
3514 Fix a lot of "possibly uninitialized variable" warnings. Some of
3515 them are even real bugs. A few of them make me wonder how the
3518 * aggregate.c: (parse_aggregate_functions) Initialize `function.
3520 * ascii.c: (output_lines) Add default case to switch.
3522 * crosstabs.q: Remove static variable `expected' and all
3524 (display_crosstabulation) Always calculate expected value.
3526 (output_pivot_table) Initialize `cmp'.
3527 (display_crosstabulation) New variable `last_row', which is
3530 * data-in.c: (parse_numeric) Always initialize sign. How did this
3533 * data-list.c: (repeating_data_trns_proc) Always initialize code.
3534 Always set info.ofs. (How did this work?!)
3536 * expr-opt.c: (optimize_tree) Always initialize `m'.
3537 (evaluate_tree) Always initialize `c'. (How did this work?)
3539 * frequencies.q: (frq_custom_variables) Always initialize min,
3541 (frq_custom_grouped) Always initialize `dl'.
3543 * groff-font.c: (groff_read_font) Always initialize char_set.
3545 * matrix-data.c: (nr_output_data) Initialize `split'.
3546 (wr_read_splits) Remove shadowing split_cnt declaration.
3547 (wr_output_data) Initialize `split'.
3549 * output.c: (tokener) Skip add character on syntax error.
3551 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
3553 * postscript.c: (read_ps_encodings) Use line.string instead of
3555 (write_text) Add default case to switch.
3556 (text) Always initialize multiple variables. Fix bug with
3559 * print.c: (fixed_parse_fortran) Initialize head.
3560 (alloc_line) Add default case to switch.
3562 * recode.c: (parse_dest_spec) Handle case where nothing matches.
3563 (recode_trns_proc) Move variable declaration inward. Add default
3566 * sfm-read.c: (read_header) Initialize skip_amt.
3568 * sysfile-info.c: (display_variables) Always initialize pc.
3570 * vars-prs.c: Initialized `included'.
3572 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
3574 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
3575 Just use signal() instead.
3577 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
3579 Get rid of vfm_sink_info and vfm_source_info.
3581 * aggregate.c: (agr_00x_end_func) Don't increment
3582 sfm_sink_info.ncases.
3584 * sort.c: (do_internal_sort) Get case count from
3585 vfm_source->class->count().
3586 (struct external_sort) Add `case_size' member.
3587 (do_external_sort) Initialize case_size.
3588 (struct initial_run_state) Add `case_size' member.
3589 (write_initial_runs) Initialize case_size.
3590 (sort_sink_write) Use case_size.
3591 (read_external_sort_output) Use case_size. Get case_cnt from
3594 * vfm.c: (struct write_case_data) Add underscores to existing arg
3595 names, all references updated. Renamed `aux' as `func_aux', all
3596 references updated. Added new `aux' member.
3597 (global var vfm_source_info) Removed.
3598 (global var vfm_sink_info) Removed.
3599 (struct procedure_aux_data) New.
3600 (struct split_aux_data) New.
3601 (procedure) Use `aux' fields for procedure_aux_data,
3603 (process_active_file_write_case) Pass case_count + 1 to
3604 transformation procedures, exclude_this_case().
3605 (process_active_file_output_case) Don't increment
3606 vfm_sink_info.ncases.
3607 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
3608 to send data to disk early.
3609 (make_temp_case) Don't use vfm_sink_info.case_size.
3610 (close_active_file) Don't initialize vfm_source_info.
3611 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
3612 (disk_sink_create) Initialize and/or update disk_stream_info.
3613 (disk_sink_write) Ditto.
3614 (disk_sink_destroy) Ditto.
3615 (disk_sink_make_source) Ditto.
3616 (disk_source_read) Ditto.
3617 (disk_source_destroy) Ditto.
3618 (global var disk_source_class) Add disk_source_count().
3619 (disk_source_count) New function.
3620 (struct memory_sink_info) Add `case_cnt', `case_size' members.
3621 (struct memory_source_info) Ditto.
3622 (memory_sink_create) Deal with case_cnt, case_size.
3623 (memory_sink_write) Ditto.
3624 (memory_sink_make_source) Ditto.
3625 (memory_source_read) Ditto.
3626 (memory_source_count) New function.
3627 (memory_source_class) Add memory_source_count().
3628 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
3629 proc_aux->cases_written, and pass it to transformation procedures
3630 and exclude_this_case ().
3631 (exclude_this_case) Add case_num parameter. Pass it to
3633 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
3636 * vfm.h: (struct case_source_class) Add `count' member.
3638 * vfmP.h: (struct stream_info) Removed.
3639 (global variable vfm_source_info) Removed.
3640 (global variable vfm_sink_info) Removed.
3642 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
3644 * var.h: (typedef trns_proc_func) New typedef.
3645 (trns_free_func) New typedef.
3646 (struct trns_header) Change `proc' to type trns_proc_func, `free'
3647 to type trns_free_func. This only changes the actual type of
3648 trns_proc_func, adding a `case_num' parameter. Updated all
3649 implementations to use the typedefs instead.
3651 * compute.c: (compute_num) Pass case_num to expr_evaluate().
3652 (compute_num_vec) Ditto.
3653 (compute_str) Ditto.
3654 (compute_str_vec) Ditto.
3656 * do-if.c: (do_if_trns_proc) Ditto.
3658 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
3661 * inpt-pgm.c: (input_program_source_read) Maintain case count,
3662 pass to transformation functions.
3663 (reread_trns_proc) Pass case_num arg to expr_evaluate().
3665 * loop.c: (loop_1_trns_proc) Ditto.
3666 (loop_2_trns_proc) Ditto.
3667 (loop_3_trns_proc) Ditto.
3669 * print.c: (print_space_trns_proc) Ditto.
3671 * sel-if.c: (select_if_proc) Ditto.
3673 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
3675 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
3676 destroying hash table.
3678 * glob.c: (read_active_file) Variable not referenced, removed.
3679 (cancel_input_pgm) Ditto.
3681 * levene.c: Add #include <stdlib.h> needed to call free().
3683 * aggregate.c: (parse_aggregate_functions) Make `function'
3686 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
3688 Start working to eliminate VFM dependence on static variables.
3690 * command.c: (cmd_parse) Use case_source_is_class().
3692 * data-list.c: Rewrite to eliminate use of static variables.
3694 * dfm.c: (cmd_begin_data) Use case_source_is_class().
3696 * file-handle.q: (fh_handle_name) Make parameter const.
3698 * file-type.c: Rewrite to eliminate use of static variables.
3700 * flip.c: Rewrite to eliminate use of static variables.
3702 * format.c: (get_format_var_width) New function.
3704 * get.c: Eliminate use of static variables.
3706 * inpt-pgm.c: Eliminate use of static variables.
3708 * matrix-data.c: Eliminate use of static variables.
3710 * set.q: (set_max_workspace) New variable.
3711 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
3713 * var.h: (struct case_list) Move here from vfmP.h.
3715 * vars-atr.c: (discard_variables) Handle new vfm_source type.
3717 * vfm.c: (vfm_source) Change type from struct case_stream to
3719 (vfm_sink) Change type from struct case_stream to struct
3721 (static var paging) Rename workspace_overflow, all references
3723 (procedure) Use new class structures.
3724 (process_active_file) Ditto.
3725 (process_active_file_write_case) Ditto.
3726 (prepare_for_writing) Use set_max_workspace. Use new class
3728 (close_active_file) Use new class structures. Free old sink.
3729 (global var disk_source_file) Removed.
3730 (global var disk_sink_file) Removed.
3731 (disk_stream_init) Removed.
3732 (disk_stream_read) Removed.
3733 (disk_stream_write) Removed.
3734 (disk_stream_mode) Removed.
3735 (disk_stream_destroy_source) Removed.
3736 (disk_stream_destroy_sink) Removed.
3737 (global var vfm_disk_stream) Removed.
3738 (disk_sink_create) New function.
3739 (disk_sink_write) New function.
3740 (disk_sink_destroy) New function.
3741 (disk_sink_make_source) New function.
3742 (disk_sink_class) New static var.
3743 (disk_source_read) New function.
3744 (disk_source_destroy) New function.
3745 (global var vfm_source_class) New var.
3746 (global var memory_source_cases) Removed.
3747 (global var memory_sink_cases) Removed.
3748 (global var memory_sink_max_cases) Removed.
3749 (struct memory_sink_info) New struct.
3750 (memory_stream_init) Removed.
3751 (memory_stream_read) Removed.
3752 (memory_stream_write) Removed.
3753 (memory_stream_mode) Removed.
3754 (memory_stream_destroy_source) Removed.
3755 (memory_stream_destroy_sink) Removed.
3756 (global var vfm_memory_stream) Removed.
3757 (page_to_disk) Renamed write_active_file_to_disk().
3758 (memory_sink_create) New function.
3759 (memory_sink_write) New function.
3760 (memory_sink_destroy) New function.
3761 (memory_sink_make_source) New function.
3762 (memory_sink_class) New static var.
3763 (memory_source_read) New function.
3764 (memory_source_destroy) New function.
3765 (memory_source_get_cases) New function.
3766 (memory_source_set_cases) New function.
3767 (global var vfm_source_class) New var.
3768 (procedure_write_case) Use new class structures.
3769 (create_case_source) New function.
3770 (case_source_is_complex) New function.
3771 (case_source_is_class) New function.
3772 (create_case_sink) New function.
3774 * vfm.h: (global variable reinit_sysmis) Not used, removed.
3775 (global variable reinit_blanks) Not used, removed.
3776 (global variable init_zero) Not used, removed.
3777 (global variable init_blanks) Not used, removed.
3778 (struct case_source) New struct.
3779 (struct case_source_class) New struct.
3780 (struct case_sink) New struct.
3781 (struct case_sink_class) New struct.
3782 (struct case_stream) Removed.
3784 * vfmP.h: (struct case_list) Moved to var.h.
3786 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
3788 * algorithm.c: (count_equal) New function.
3789 (count_if) New function.
3790 (unique) Add assertions.
3791 (partition) Add assertions.
3792 (is_partitioned) New function.
3793 (copy_if) Add assertions.
3794 (remove_equal) Add assertions.
3795 (lexicographical_compare) Rename lexicographical_compare_3way.
3796 (sort) Add assertions. Rephrase some code.
3797 (is_sorted) New function.
3799 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
3803 * sort.c: Completely rewrite.
3805 * sort.h: Expose interface via struct sort_cases_pgm, not via
3808 * aggregate.c: (sort) New static var.
3809 (cmd_aggregate) Use sort.
3810 (create_sysfile) Ditto.
3811 (aggregate_single_case) Ditto.
3812 (dump_aggregate_info) Ditto.
3813 (agr_00x_end_func) Ditto.
3814 (debug_print) Ditto.
3816 * var.h: (enum SRT_ASCEND) Removed.
3817 (enum SRT_DESCEND) Removed.
3818 (struct sort_cases_proc) Removed.
3819 (struct variable) Remove p.srt member.
3821 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
3823 Get rid of the old, crappy heap structure and replace it by a new,
3824 shiny, C++ STL-like heap structure.
3826 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
3828 * algorithm.c: (push_heap) New function.
3839 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
3841 Increase warning level.
3843 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
3845 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
3847 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
3849 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
3851 * dictionary.c: (dict_create_var) Fix root cause of bug worked
3852 around by previous change log entry.
3854 * compute.c: (lvalue_finalize) Remove workaround from previous
3857 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3859 * compute.c: Fixed a bug where the Format was not getting set for
3860 computed variables (thus causing a crash when SAVEing).
3862 * Added a test to stop this bug ever coming back
3864 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
3866 Got rid of approx.h. In general, replaced all references to
3867 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
3870 * Makefile.am: (pspp_SOURCES) Removed approx.h.
3872 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
3873 test for mag < EPSILON.
3875 * misc.h: Add definition of EPSILON.
3877 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
3879 * vfm.c: (procedure) Add check to prevent recursive call.
3881 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
3883 * Moved the declarations relating to values to their own header file
3886 * Added levene.c and levene.h
3888 * vars-atr.c: Changed the signature of compare_values to
3889 take const * arguments.
3891 * t-test.q: Changed the structure of struct t_test_proc
3892 variables now contain their own group statistics information.
3893 Eventually, t_test_proc might get renamed, because it'd be
3894 applicable to other commands too.
3896 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
3898 * data-out.c: Clean up. Changed interface of convert_*() to take
3899 either a `double' or a `const char *' instead of a `const union
3900 value *'. Update all implementations of those interfaces.
3901 (data_out) Use switch statements instead of a table.
3902 (convert_AHEX) Rewrite.
3904 * format.h: Update comment.
3906 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
3908 * q2c.c: (dump_header) Add an Emacs header line to output files
3909 that makes generated .c files read-only by default, to make it
3910 difficult to accidentally change generated files.
3912 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
3914 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
3915 not bogus a->v.c <=> b->v.c pointer compare.
3916 (compare_freq_alpha_a) Ditto.
3917 (compare_freq_numeric_d) Ditto.
3918 (compare_freq_alpha_d) Ditto.
3920 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
3922 Changed data_out() to store string data directly into a `union
3923 value''s s member, not indirectly into c.
3925 * crosstabs.q: (output_pivot_table) Use format_short() instead of
3927 (table_value_missing) Ditto.
3928 (float_M_suffix) Ditto.
3929 (format_short) New function.
3931 * data-in.h: (data_in_finite_line) Remove inline definition.
3933 * data-list.c: (destroy_dls_var_spec) New function.
3934 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
3935 (data_list_source_destroy_source) Avoid cast.
3936 (struct repeating_data_trns) New field `id_value'. Update
3938 (cmd_repeating_data) Initialize id_value. Use new
3939 repeating_data_trns_free() for freeing REPEATING DATA
3941 (rpd_parse_record) Rewrite support for record ID to be less bogus.
3942 (repeating_data_trns_free) New function.
3944 * data-out.c: (data_out) Change return type to `void' by replacing
3945 error returns by writing a message into the output buffer.
3946 (convert_A) Read from v->s instead of v->c.
3947 (convert_AHEX) Ditto.
3949 * expr-evl.c: Update comment.
3950 (expr_evaluate) Add assertion in OP_STRING case.
3952 * format.h: (macro MAX_FORMATTED_LEN) New macro.
3954 * list.q: (list_cases) Update for new data_out() semantics.
3956 * print.c: (print_trns_proc) Ditto.
3958 * tab.c: (tab_value) Ditto.
3959 (tab_float) Avoid stupid cast.
3961 * var.h: Update comments.
3962 (macro MAX_STRING) New macro.
3963 (macro MAX_ELEMS_PER_VALUE) New macro.
3965 * vars-atr.c: (compare_values) New function.
3967 * vfm.c: (dump_splits) Update for new data_out() semantics.
3969 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
3971 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
3973 (struct crosstab) Rename v[] to vars[]. All references updated.
3974 (hash_table_entry) Replace the hash algorithm and fix a bug at the
3975 same time, which caused the hash value to depend only on a single
3976 value, not all of the variables' values.
3978 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
3980 Clean up struct dictionary's value_cnt usage.
3982 * dictionary.c: Add a function comment to each function.
3983 (struct dictionary) Rename value_cnt to next_value_idx, which more
3984 accurately reflects its meaning. All references updated.
3985 (dict_rename_vars) Add assertion.
3986 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
3988 (dict_get_case_size) New function.
3990 * aggregate.c: (create_sysfile) Use dict_get_case_size().
3992 * get.c: (mtf_read_nonactive_records) Ditto.
3994 * sort.c: (allocate_cases) Ditto.
3995 (write_initial_runs) Ditto.
3999 * vfm.c: (prepare_for_writing) Ditto.
4003 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
4005 Make vfm.c slightly less grotesque.
4007 * vfm.c: (filter_var) Removed.
4008 (filter_index) Removed.
4009 (FILTERED macro) Removed.
4010 (exclude_this_case) New function.
4011 (process_active_file_write_case) Use exclude_this_case() instead
4012 of FILTERED and inline tests.
4013 (procedure_write_case) Ditto.
4014 (setup_filter) Removed.
4015 (open_active_file) Don't call setup_filter().
4016 (close_active_file) Call dict_get_filter() instead of checking
4019 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
4021 * var.h: (struct variable) Update comments.
4023 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
4025 New functions dict_create_var_assert(), dict_lookup_var_assert().
4026 Converted several dict_*_var()/assert pairs into a single
4027 dict_*_var_assert().
4029 * dictionary.c: (dict_create_var_assert) New function.
4030 (dict_lookup_var_assert) New function.
4032 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
4034 Got rid of "struct long_vec", envector(), devector(), etc. Added
4035 two members `init', `reinit' to struct variable as a substitute.
4037 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
4043 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
4046 * autorecode.c: (cmd_autorecode) destvars don't need init.
4048 * compute.c: (lvalue_finalize) Set reinit.
4050 * data-list.c: (fixed_parse_compatible) Don't need init usually.
4051 (dump_fmt_list) Ditto.
4054 * descript.q: (run_z_pass) Don't need init for z-scores.
4056 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
4058 (dict_clone_var) Copy `reinit' member, initialize `init' member.
4060 * glob.c: (init_glob) Remove vec_init() calls.
4062 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
4064 * loop.c: (internal_cmd_loop) Don't need to call envector().
4066 * numeric.c: (cmd_numeric) Ditto.
4068 (cmd_leave) Ditto. Set `init', `reinit' members.
4070 * recode.c: (cmd_recode) Don't need to call envector().
4072 * repeat.c: (internal_cmd_do_repeat) Ditto.
4074 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
4075 (force_create_variable) Removed prototype.
4076 (force_dup_variable) Ditto.
4078 * vector.c: (cmd_vector) Don't need to call envector().
4080 * vfm.c: (reinit_sysmis) Removed.
4081 (reinit_blanks) Removed.
4082 (init_zero) Removed.
4083 (init_blanks) Removed.
4084 (process_active_file_write_case) No need to deal with vectors.
4085 Call clear_temp_case().
4086 (vector_initialization) Rewrite to use `init', `reinit'.
4087 (close_active_file) No need to call vec_clear().
4088 (procedure_write_case) Call clear_temp_case().
4089 (clear_temp_case) New function.
4091 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
4093 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
4096 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
4098 Add auxiliary argument to procedure() interface. Associated small
4099 clean-ups of vfm interface.
4101 * Updated every caller of procedure() and process_active_file() to
4102 reflect modified interface. Simple, ordinary changes not listed
4105 * Updated every function that implements struct case_stream's
4106 `read' function to take a write_case_func and a write_case_data.
4107 Also updated every caller of write_case() to instead call them
4108 through these arguments. In some cases this meant that the extra
4109 args had to be threaded through a couple of extra levels. This
4110 wasn't difficult or interesting so the details won't be given.
4112 * data-list.c: (struct repeating_data_trns) Add members
4113 `write_case', `wc_data' as kluge.
4114 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
4116 (repeating_data_set_write_case) New function.
4118 * data-list.h: New file to declare repeating_data_trns_proc() and
4119 repeating_data_set_write_case().
4121 * inpt-pgm.c: (input_program_source_read) Call
4122 repeating_data_set_write_case() for all the REPEATING DATA
4123 transformations, so that they know where to send their cases.
4124 It's a big kluge. Also kluge in END CASE.
4125 (end_case_trns_proc) Never called anymore, but we still need it,
4128 * sort.c: (read_sort_output) Update to match struct case_stream
4131 * vfm.c: (struct write_case_data) New structure.
4132 (proc_func) Removed.
4133 (virt_proc_func) Removed.
4134 (begin_func) Removed.
4135 (virt_begin_func) Removed.
4137 (write_case) Removed.
4138 (procedure) Added an auxiliary parameter to each function pointer
4139 argument's prototype. Added an auxiliary data parameter.
4141 (process_active_file) Ditto.
4142 (process_active_file_write_case) Pass aux data along.
4143 (close_active_file) Ditto.
4144 (procedure_write_case) Ditto.
4145 (SPLIT_FILE_procfunc) Ditto.
4147 * vfm.h: (typedef write_case_data) New.
4148 (typedef write_case_func) New.
4149 (struct case_stream) Add parameters to `read' member prototype.
4151 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
4153 * t-test.q: Added calculations for independent samples. (But no Levene
4156 * Makefile.am: Moved q_sources_c into own variable
4158 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
4160 Miscellaneous cleanups.
4162 * Change unused to UNUSED in many source files to reflect modified
4163 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
4164 __CYGWIN32__, __unix__, and unix not to assume that they're
4165 defined to a nonzero value. Change use of __attribute__ to use
4166 NO_RETURN or PRINTF_FORMAT instead.
4168 * alloc.h: Move definitions for local_alloc(), local_free() here
4169 from ../pref.h.orig and simplify.
4171 * expr-evl.c: Instead of working differently based on PAGED_STACK,
4172 use a pool allocator unconditionally.
4173 (CHECK_STRING_SPACE) Removed.
4174 (ALLOC_STRING_SPACE) Removed.
4175 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
4178 * expr-opt.c: (dump_expression) Allocate string pool.
4180 * expr-prs.c: (expr_free) Free string pool.
4182 * pool.c: (pool_destroy) This pool must be removed from its
4183 parent's list of gizmos, not from its own. Use free_all_gizmos().
4184 (pool_clear) New function.
4185 (free_all_gizmos) New function.
4186 (pool_alloc) Use space in empty block after this one if any.
4187 (pool_release) Only empty out blocks, don't actually free() them.
4189 * print.c: Get rid of PAGED_STACK special case by always
4190 dynamically allocating line buffers.
4191 (struct print_trns) Always include the `line' member.
4192 (internal_cmd_print) Always initialize the `line' member.
4193 (alloc_line) Always allocate memory for `line'.
4194 (print_trns_proc) Always initialize buf from `line' member.
4195 (print_trns_free) Always free `line' memory.
4197 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
4200 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
4202 * flip.c: Fixed crash from FLIP when a numeric variable is
4203 specified on NEWNAMES and a large value is used, and a couple of
4204 other minor bugs besides.
4205 (struct varname) Make name a 9-character fixed-size array
4206 instead of a 1-character variable size array.
4207 (make_new_var) Allow digits in variable names.
4208 (flip_stream_write) Limit numeric values to 8 characters and
4209 format system missing and very large and small values more
4212 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
4214 * command.c: Fixed test on command return status for the correct
4215 value, which had been causing a crash under certain invalid input.
4217 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
4219 * t-test.q: Added calculations for the one sample variant of the T-TEST
4221 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
4223 * tab.c: (render_strip) Fix bug that sometimes caused joined text
4224 in joined cells to be rendered outside box boundaries.
4226 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
4228 * random.c (rng_create): Fixed seeding so that it gets reseeded after
4229 SET seed=xx has been called.
4231 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
4233 * random.c (rng_get_double): Fix always-returning-zero bug in my
4234 preferred way, and at the same time make sure rounding doesn't
4237 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
4239 * html.c: (change_attributes) Dead code, removed.
4240 (escape_string) Eliminate code to call change_attributes() that
4241 never actually called it.
4242 (output_tab_table) Get rid of dependence on tab_hit
4243 and struct tab_joined_cell's hit member, which are abominations.
4245 * tab.c: (tab_output_text) Don't call
4246 d->class->text_set_font_by_name if it's a null pointer.
4247 (macro UNROLL_LOOP) Eliminate.
4248 (macro UNROLL_3_LOOPS) Eliminate.
4249 (tabi_render) Rewrite not to use the above macros.
4251 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
4253 Start working on a new output driver system, one that doesn't suck
4254 so much, by adding a "device-independent" output driver. The idea
4255 is to write out only a single output stream, then use separate
4256 processes to translate them into whatever formats we want. This
4257 is similar to how "groff" works with its various output drivers
4258 (grops, grotty, grodvi, ...).
4260 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
4262 * list.q: (write_all_headers) Stub out devind class.
4264 (determine_layout) Ditto.
4267 * output.c: (outp_init) Add devind class.
4269 * devind.c: New file.
4271 * devind.h: New file.
4273 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
4275 * frequencies.q: (hash_value_alpha) Fixed up the previous change
4276 to use the proper string length.
4278 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4280 * Fixed bug where FREQ would crash on alpha values
4282 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
4284 * Removed bletcherous alloca() workarounds for AIX from top of
4285 many files. AIX can use the alternative alloca() implementation
4288 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
4290 * ascii.c: (ascii_option) Fix implementation of headers option.
4292 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
4294 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
4295 multiple blank lines into one.
4296 (struct ascii_driver_ext) Add squeeze_blank_lines option.
4297 (ascii_preopen_driver) Initialize squeeze_blank_lines.
4298 (static var option_tab) Add squeeze entry.
4299 (ascii_option) Set squeeze_blank_lines.
4300 (output_lines) Implement squeezing blank lines.
4302 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
4304 * Removed redundant code from output.h
4306 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
4308 Dictionary classes: each variable is "ordinary", "system", or
4311 * var.h: (enum dict_class) New enum.
4313 * vars-prs.c: (dict_class_from_id) New function.
4314 (dict_class_to_name) New function.
4316 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
4318 * var.h: (struct freq_tab_set) Removed (not used).
4320 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
4322 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
4324 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
4326 * stats.c: (hypercube) Rename pow4(). All references updated.
4328 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
4330 * rename-vars.c: (cmd_rename_variables) Rewritten.
4331 (compare_name) Removed.
4333 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
4335 var_set feature, and code taking advantage of it.
4337 * crosstabs.q: (static var var_dict) Removed.
4338 (static var variables) New variable.
4339 (static var variables_cnt) New variable.
4340 (cmd_crosstabs) Free variables instead of var_dict.
4341 (internal_cmd_crosstabs) Initialize and use variables,
4342 variables_cnt instead of var_dict.
4343 (free_var_dict) Removed.
4344 (crs_custom_tables) Use var_set instead of a copied dictionary.
4345 (crs_custom_variables) Set up variables, variables_cnt instead of
4347 [DEBUGGING] (debug_print) Ditto.
4349 * means.q: (mns_custom_tables) Use var_set instead of a copied
4352 * vars-prs.c: (parse_vs_variable) New function.
4353 (parse_dict_variable) Rewritten.
4354 (parse_variable) Rewritten.
4355 (parse_variables) Renamed parse_var_set_vars(), rewritten.
4356 (parse_variables) New function in terms of parse_var_set_vars().
4357 Now requires its first argument to be non-null. All references
4358 that passed a null pointer updated to pass default_dict instead.
4359 (macro id_dict) Removed.
4360 (parse_DATA_LIST_vars) Add assertions.
4361 (parse_mixed_vars) Ditto.
4362 (struct var_set) New structure.
4363 (var_set_get_cnt) New function.
4364 (var_set_get_var) New function.
4365 (var_set_lookup_var) New function.
4366 (var_set_destroy) New function.
4367 (dict_var_set_get_cnt) New function.
4368 (dict_var_set_get_var) New function.
4369 (dict_var_set_lookup_var) New function.
4370 (dict_var_set_destroy) New function.
4371 (var_set_create_from_dict) New function.
4372 (struct array_var_set) New structure.
4373 (array_var_set_get_cnt) New function.
4374 (array_var_set_get_var) New function.
4375 (array_var_set_lookup_var) New function.
4376 (array_var_set_destroy) New function.
4377 (var_set_create_from_array) New function.
4379 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
4380 instead of parse_variables(NULL, ...) in output code.
4382 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
4384 Change inp_init from a 2-bit vector to an ordinary array.
4385 Initialize it all in cmd_end_input_program() instead of in
4388 * inpt-pgm.c: (enum value_init_type) New enum.
4389 (global var inp_init) Change to `enum value_init_type *', make
4391 (inp_init_size) Removed.
4392 (inp_nval) Change to `size_t', make static.
4393 (cmd_input_program) Don't initialize inp_init or inp_init_size.
4394 (cmd_end_input_program) Initialize inp_init, inp_nval.
4395 (init_case) Rewrite.
4396 (clear_case) Rewrite.
4398 * inpt-pgm.h: Removed.
4400 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
4402 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
4403 Colin Plumb hash. It is simpler and should better resist
4405 (hsh_hash_string) Ditto.
4407 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
4409 * get.c: (export_write_case_func) Remove debug printing code.
4411 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
4413 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
4415 (save_write_case_func) Use &trns->h instead of cast.
4416 (cmd_export) Use &t->h instead of cast.
4418 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
4420 Moved vectors into the dictionary.
4422 * var.h: (struct vector) Moved here from vector.h. `index' member
4423 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
4426 * vector.h: Removed.
4428 * vector.c: (global var vec) Removed.
4429 (global var nvec) Removed.
4430 (cmd_vector) Rewritten.
4431 (find_vector) Removed.
4433 * dictionary.c: (dict_create_vector) New function.
4434 (dict_get_vector) New function, replaces reading global vec[]
4436 (dict_get_vector_cnt) New function, replaces reading global nvec
4438 (dict_lookup_vector) New function, replaces find_vector().
4439 (dict_clear_vectors) New function.
4441 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
4443 Start to move away from `struct variable' p `union' member to void
4446 * var.h: (struct variable) Add `aux' member.
4448 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
4450 Get rid of struct variable `foo' member.
4452 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
4454 (frq_custom_variables) Ditto.
4455 (frq_custom_grouped) Ditto.
4457 * get.c: (struct save_trns) Change `var' member from `int *' to
4458 `struct variable **'.
4459 (cmd_save_internal) Use aux instead of foo.
4460 (save_trns_proc) Use revised `var' member.
4461 (static var mtf_seq_no) Renamed mtf_seq_num.
4462 (static var mtf_seq_nums) New static var.
4463 (cmd_match_files) Initialize mtf_seq_nums.
4464 (mtf_free) Free mtf_seq_nums.
4465 (mtf_processing) Use mtf_seq_nums instead of foo.
4466 (mtf_merge_dictionary) No need to initialize mv->foo.
4467 (cmd_export) Use aux instead of foo. Use revised `var' member.
4468 (mns_custom_tables) Don't use foo to check for duplicates, that's
4469 what PV_NO_DUPLICATE is for.
4471 * var.h: (struct variable) Remove `foo' member.
4472 (struct frequencies_proc) New member.
4474 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
4476 Clean up COMPUTE and IF.
4478 * compute.c: More or less rewrite the darn thing.
4479 (struct compute_trns) Rename and reorder and add and delete
4481 (cmd_compute) Rewrite.
4482 (compute_num) Make conditional on test expression. Now used for
4483 both COMPUTE and IF.
4484 (compute_num_vec) Ditto.
4485 (compute_str) Ditto.
4486 (compute_str_vec) Ditto.
4489 (if_num_vec) Removed.
4491 (if_str_vec) Removed.
4492 (parse_target_expression) Renamed parse_rvalue_expression(),
4494 (new_trns) Renamed compute_trns_create(), rewritten.
4495 (delete_trns) Removed.
4496 (free_trns) Renamed compute_trns_free(), rewritten.
4497 (struct lvalue) New structure.
4498 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
4499 (lvalue_get_type) New function.
4500 (lvalue_is_vector) New function.
4501 (lvalue_finalize) New function.
4502 (lvalue_destroy) New function.
4504 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
4506 * command.def: Disallow MODIFY VARS in input mode, so that
4507 variables can't get dropped and confuse cmd_end_input_program()'s
4508 attempt to fill inp_init[].
4510 * modify-vars.c: (static var forward_positional_ordering) New
4512 (struct var_modification) Entirely changed.
4513 (rearrange_dict) Interface changed, rewritten.
4514 (cmd_modify_vars) Deal with modified struct var_modification, much
4516 (struct var_renaming) New structure.
4517 (compare_var_renaming_by_new_name) New function.
4518 (validate_var_modification) New function.
4520 * var.h: (struct modify_vars_proc) Removed.
4521 (struct variable) Removed member p.mfv.
4523 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
4525 Make EVALUATE a valid command whether we're debugging or not, so
4526 that `make check' can succeed regardless of whether debugging is
4529 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
4531 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
4533 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
4535 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
4536 statement by a simple if test.
4538 * dfm.c: (dfm_get_record) Add assertion.
4540 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
4542 For each file x.c, move #include "x.h" to the very top of the
4543 include list, to catch x.h failing to include the proper headers.
4545 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
4547 * algorithm.c: (find) New function.
4548 (remove_equal) New function.
4549 (set_difference) New function.
4550 (adjacent_find_equal) New function.
4551 [TEST_UNIQUE] Removed test case.
4552 (copy_if) Find end test.
4554 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
4556 * dictionary.c: (dict_get_case_weight) New convenience function.
4558 * aggregate.c: (accumulate_aggregate_info) Use
4559 dict_get_case_weight().
4561 * frequencies.q: (calc_general) Ditto.
4562 (calc_integer) Ditto.
4565 * t-test.q: (groups_calc) Ditto.
4568 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
4570 * glob.c: (global var default_dict) Change from `struct
4571 dictionary' to `struct dictionary *'. All references changed.
4572 (init_glob) Initialize default_dict with dict_create().
4574 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
4576 struct dictionary now made opaque. All related functions:
4578 * get.c: (rename_variables) Removed.
4579 (dict_delete_run) Removed.
4581 * temporary.c: (copy_variable) Removed.
4582 (new_dictionary) Removed.
4583 (save_dictionary) Removed.
4584 (restore_dictionary) Removed.
4585 (free_dictionary) Removed.
4587 * vars-atr.c: (clear_default_dict) Removed.
4588 (find_variable) Removed.
4589 (find_dict_variable) Removed.
4590 (create_variable) Removed.
4591 (delete_variable) Removed.
4592 (common_init_stuff) Removed.
4593 (init_variable) Removed. Updating of inp_init moved into
4594 cmd_end_input_program().
4595 (replace_variable) Removed.
4596 (rename_variable) Removed.
4597 (clear_variable) Removed.
4598 (dup_variable) Removed.
4600 * vars-prs.c: (is_varname) Removed.
4601 (is_dict_varname) Removed.
4602 (fill_all_vars) Removed.
4604 * vector.c: (find_vector) Removed.
4606 * weight.c: (stop_weighting) Removed.
4608 * dictionary.c: New file.
4609 (dict_create) New, replaces new_dictionary().
4610 (dict_clone) New, replaces save_dictionary() and
4611 restore_dictionary().
4612 (dict_clear) New, replaces clear_default_dict().
4613 (dict_destroy) New, replaces free_dictionary().
4614 (dict_get_var_cnt) New function, replaces references to
4616 (dict_get_var) New function, replaces references to dict->var[i].
4617 (dict_get_vars) New function, replaces fill_all_vars().
4618 (dict_create_var) New, replaces create_variable(). Interface
4619 drops `type' parameter, using a zero `width' to designate numeric.
4620 (dict_clone_var) New, replaces dup_variable().
4621 (dict_rename_var) New, replaces rename_variable().
4622 (dict_lookup_var) New, replaces find_variable(),
4623 find_dict_variable(), is_varname().
4624 (dict_contains_var) New function.
4625 (compare_variable_dblptrs) New function.
4626 (dict_delete_var) New function, replaces clear_variable().
4627 (dict_delete_vars) New function, replaces dict_delete_run().
4628 (dict_reorder_vars) New function.
4629 (dict_rename_vars) New function, replaces rename_variables().
4630 (dict_get_weight) New function, replaces reading dict->weight_var.
4631 (dict_set_weight) New function, replaces writing dict->weight_var
4632 or calling stop_weight(dict).
4633 (dict_get_filter) New function, replaces reading dict->filter_var.
4634 (dict_set_filter) New function, replaces writing dict->filter_var.
4635 (dict_get_case_limit) New function, replaces reading dict->N.
4636 (dict_set_case_limit) New function, replaces writing dict->N.
4637 (dict_get_value_cnt) New function, replaces reading dict->nval.
4638 (dict_compact_values) New function, replaces a loop that was
4639 replicated in several places.
4640 (dict_get_split_vars) New function, replaces reading dict->splits.
4641 (dict_get_split_cnt) New function, replaces reading
4643 (dict_set_split_vars) New function, replaces writing dict->splits.
4644 (dict_get_label) New function, replaces reading dict->label.
4645 (dict_set_label) New function, replaces writing dict->label.
4646 (dict_get_documents) New function, replaces reading
4648 (dict_set_documents) New function, replaces writing
4651 All references to above functions updated.
4653 * aggregate.c: (cmd_aggregate) Copy file label and documents from
4654 old dictionary to new by hand, because dict_create() can't do it
4655 itself. Use dict_set_documents(), dict_set_split_vars().
4657 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
4658 calling dict_destroy().
4660 * data-list.c: (dls_var_spec) Remove `type' member, replace by
4662 (fixed_parse_compatible) Some slightly nontrivial changes for
4664 (dump_fmt_list) Ditto.
4667 * file-type.c: (create_col_var) Ditto.
4669 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
4670 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
4671 (rename_variables) Use dict_rename_vars().
4672 (mtf_merge_dictionary) Use dict_get_documents(),
4673 dict_set_documents(), dict_compact_values().
4675 * pfm-read.c: (read_variables) Deal with changes to weighting.
4677 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
4678 is_varname() in output code.
4680 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
4681 other dictionary functions.
4683 * title.c: (add_document_line) Use dict_get_documents(),
4684 dict_set_documents().
4686 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
4687 reset default_handle by hand. dict_clear() will clear vectors so
4688 there's no need for that by hand.
4690 * vfm.c: (close_active_file) Move call to finish_compaction()
4691 earlier, so that we can do the compaction as a single step using
4692 dict_compact_values(). Use dict_clear_vectors().
4693 (finish_compaction) Use dict_delete_var(), dict_compact_values().
4695 Some functions don't have replacements:
4697 * vars-atr.c: (force_create_variable) Removed. All references
4698 updated to dict_create_var() followed by an assertion.
4699 (force_dup_variable) Removed. All references updated to
4700 dict_clone_var() followed by an assertion.
4702 * weight.c: (update_weighting) Removed. No longer necessary, so
4703 all references removed.
4705 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
4709 * aggregate.c: Eliminate separation of weighted and unweighted
4710 case. It made the code too obscure and I doubt it was actually
4711 faster. Instead, all code uses the "weighted" code, because
4712 that's a generalization of the "unweighted" code.
4715 (parse_aggregate_functions) No need to set FWEIGHT.
4716 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
4717 (dump_aggregate_info) Ditto.
4718 (initialize_aggregate_info) No need for special plain_function
4719 that gets rid of FWEIGHT option.
4721 * aggregate.c: Get rid of approximations.
4722 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
4724 (aggregate_single_case) Don't use approx_ne().
4726 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
4728 * ascii.c (ascii_line_width): Dead code, removed.
4730 * postscript.c (ps_line_width): Ditto.
4732 * q2c.c (xrealloc): Ditto.
4734 * count.c (internal_cmd_count): Ditto.
4736 * means.q (validate_dependent_endpoint): Ditto.
4738 * set.q: (cmd_gset) Ditto.
4740 * weight.c: [0] (weight_trns_proc) Ditto.
4742 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
4744 Make the code -Wmissing-prototypes clean.
4746 * Makefile.am (version.c): Add #include "version.h".
4748 * ascii.c: (ascii_open_global) Make static.
4749 (ascii_close_page) Ditto.
4750 (ascii_font_sizes) Ditto.
4751 (ascii_postopen_driver) Ditto.
4752 (ascii_close_driver) Ditto.
4753 (ascii_option) Ditto.
4754 (ascii_open_page) Ditto.
4755 (ascii_line_horz) Ditto.
4756 (ascii_line_vert) Ditto.
4757 (ascii_line_intersection) Ditto.
4759 (ascii_polyline_begin) Ditto.
4760 (ascii_polyline_point) Ditto.
4761 (ascii_polyline_end) Ditto.
4762 (ascii_text_set_font_by_name) Ditto.
4763 (ascii_text_set_font_by_position) Ditto.
4764 (ascii_text_set_font_by_family) Ditto.
4765 (ascii_text_get_font_name) Ditto.
4766 (ascii_text_get_font_family) Ditto.
4767 (ascii_text_set_size) Ditto.
4768 (ascii_text_get_size) Ditto.
4769 (ascii_text_metrics) Ditto.
4770 (ascii_text_draw) Ditto.
4771 (ascii_close_page) Ditto.
4773 * cmdline.h: New header for parse_command_line(). Used where
4776 * command.c: Move prototypes for cmd_*() functions to command.h.
4778 * command.h: Prototypes for cmd_*() functions moved here from
4781 * crosstabs.q: (gamma_int) Ditto.
4783 * file-handle.h: Add fh_init_files() prototype.
4785 * getline.c: (welcome) Ditto.
4787 * glob.h: New header for init_glob(). Used where appropriate.
4789 * hash.c: (comparison_helper) Ditto.
4791 * html.c: (html_open_global) Ditto.
4792 (html_close_global) Ditto.
4793 (html_preopen_driver) Ditto.
4794 (html_postopen_driver) Ditto.
4795 (html_close_driver) Ditto.
4796 (html_option) Ditto.
4797 (html_open_page) Ditto.
4798 (html_close_page) Ditto.
4799 (html_submit) Ditto.
4801 * inpt-pgm.c: (input_program_source_read) Ditto.
4803 * output.c: (find_defn_value) Ditto.
4804 (destroy_list) Ditto.
4806 * pfm-read.c: (read_int) Ditto.
4808 * postscript.c: (ps_open_global) Ditto.
4809 (ps_close_global) Ditto.
4810 (ps_font_sizes) Ditto.
4811 (ps_preopen_driver) Ditto.
4812 (ps_postopen_driver) Ditto.
4813 (ps_close_driver) Ditto.
4815 (ps_open_page) Ditto.
4816 (ps_close_page) Ditto.
4817 (ps_line_horz) Ditto.
4818 (ps_line_vert) Ditto.
4819 (ps_line_intersection) Ditto.
4821 (ps_polyline_begin) Ditto.
4822 (ps_polyline_point) Ditto.
4823 (ps_polyline_end) Ditto.
4824 (ps_text_set_font_by_name) Ditto.
4825 (ps_text_set_font_by_position) Ditto.
4826 (ps_text_set_font_family) Ditto.
4827 (ps_text_get_font_name) Ditto.
4828 (ps_text_get_font_family) Ditto.
4829 (ps_text_set_size) Ditto.
4830 (ps_text_get_size) Ditto.
4831 (ps_text_metrics) Ditto.
4832 (ps_text_draw) Ditto.
4834 * q2c.c: (finish_up) Ditto.
4843 (find_symbol) Ditto.
4846 (force_string) Ditto.
4848 (match_token) Ditto.
4851 (parse_setting) Ditto.
4852 (parse_specifier) Ditto.
4853 (parse_specifiers) Ditto.
4854 (parse_subcommand) Ditto.
4855 (dump_specifier_vars) Ditto.
4857 (make_identifier) Ditto.
4858 (dump_declarations) Ditto.
4859 (dump_specifier_init) Ditto.
4860 (dump_vars_init) Ditto.
4862 (dump_specifier_parse) Ditto.
4863 (dump_subcommand) Ditto.
4864 (dump_parser) Ditto.
4865 (dump_header) Ditto.
4867 (recognize_directive) Ditto.
4869 * recode.c: (string_to_long) Ditto.
4871 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
4873 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
4876 * sort.c: (sort_stream_read) Ditto.
4877 (sort_stream_mode) Ditto.
4879 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
4881 * algorithm.c (binary_search): Fix comparison.
4883 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
4885 * algorithm.c: (binary_search) Fix assertion.
4887 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
4889 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
4891 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
4893 * sort.c: (compare_case_lists) Rewrite.
4895 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
4897 * quicksort.c: Removed (not used).
4899 * quicksort.h: Removed (not used).
4901 * sort.c: Removed blp_quicksort() prototype.
4903 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
4905 * postscript.c: (int_2_compare) Rewrite.
4906 (compare_line) Rewrite.
4908 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
4910 * matrix-data.c (compare_factors) Use lexicographical_compare()
4912 (compare_doubles) New function.
4914 * algorithm.c: (lexicographical_compare) New algorithm.
4916 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
4918 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
4920 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
4922 * expr-prs.c: (cmp_func) Removed.
4923 (parse_function) Use binary_search() algorithm.
4924 (compare_functions) New function.
4925 (init_func_tab) Use sort() algorithm.
4927 * algorithm.c: (binary_search) New algorithm.
4929 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
4931 * descript.q: (display) Use sort() algorithm instead of qsort().
4932 (compare_func) Removed.
4933 (descriptives_compare_variables) New function.
4935 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
4937 Get rid of AVL trees. Hashes are more appropriate for everything
4940 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
4946 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
4948 Much code can be clarified by using C++ STL-like algorithms. Not
4949 all uses of these algorithms are listed below, only the ones where
4950 the change to an algorithm was the only change of interest.
4952 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
4954 * algorithm.c: New file.
4956 * algorithm.h: New file.
4958 * modify-vars.c: (static var forward) Removed.
4959 (static var positional) Removed.
4960 (compare_variables) Removed.
4961 (struct ordering) New.
4962 (cmd_modify_vars) Use sort() algorithm.
4963 (compare_variables_given_ordering) New function.
4964 (rearrange_dict) Use sort() algorithm.
4966 * sysfile-info.c: (cmd_display) Use sort() algorithm.
4967 (cmp_var_by_name) Removed.
4969 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
4971 Make file handles use a hash table.
4973 * file-handle.q: (files) Change to hash table, make static.
4974 (cmd_file_handle) Use hash table functions.
4975 (fh_get_handle_by_filename) Ditto.
4976 (fh_get_handle_by_name) Ditto.
4977 (hash_file_handle) New function.
4978 (cmp_file_handle) Rewrite.
4979 (fh_init_files) Use hash table functions.
4981 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
4983 Clean up FREQUENCIES.
4985 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
4987 * frequencies.q: Remove a lot of old #if'd out code at the end.
4988 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
4989 or calc_weight(). Initialize percentile_values.
4990 (calc) New function based on calc_weight() from frequencies.g.
4991 (precalc) Use hash functions.
4992 (static var comparison_func) Removed.
4993 (static var comparison_param) Removed.
4994 (comparison_helper) Removed.
4995 (get_freq_comparator) New function.
4996 (not_missing) New function.
4998 (postprocess_freq_tab) Use hash table functions, algorithms,
4999 get_freq_comparator(). Rewrite.
5000 (cleanup_freq_tab) Rephrase.
5001 (add_percentile) Clean up spacing.
5002 (hash_value_numeric) New function.
5003 (hash_value_alpha) New function.
5004 (compare_value_numeric_a) Rewrite.
5005 (compare_value_alpha_a) Rewrite.
5006 (compare_value_numeric_d) Rewrite.
5007 (compare_value_alpha_d) Rewrite.
5008 (compare_freq_numeric_a) Rewrite.
5009 (compare_freq_alpha_a) Rewrite.
5010 (compare_freq_numeric_d) Rewrite.
5011 (compare_freq_alpha_d) Rewrite.
5012 (calc_stats) Clean up mode, percentiles, max.
5013 (dump_statistics) Clean up spacing.
5015 * frequencies.g: Removed.
5017 * var.h: (struct freq_tab) Change `data' to hash table.
5019 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
5021 * file-handle.h: Remove declaration of global variable `files',
5022 which wasn't used anywhere.
5024 * postscript.c: (add_encoding) Remove superfluous cast.
5027 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
5030 * temporary.c: [0] (display_tree) Removed.
5032 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
5034 Implement a new random number generator based on the alleged RC4
5037 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
5040 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
5041 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
5043 (static var V[]) Removed.
5044 (static var Y) Removed.
5045 (static var X2) Removed.
5046 (setup_randomize) Removed.
5048 (rand_uniform) Removed.
5049 (rand_normal) Removed.
5050 (struct rng) New structure.
5051 (rng_create) New function.
5052 (rng_destroy) New function.
5053 (swap_byte) New static function.
5054 (rng_seed) New function.
5055 (rng_get_bytes) New function.
5056 (rng_get_int) New function.
5057 (rng_get_unsigned) New function.
5058 (rng_get_double) New function.
5059 (rng_get_double_normal) New function.
5060 (pspp_rng) New function.
5062 * random.h: Sync up to random.c.
5064 * sample.c: (struct sample_trns) Make `frac' unsigned and a
5065 fraction of UINT_MAX, not 65536.
5066 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
5069 * vfm.c: (open_active_file) No need to call setup_randomize() any
5072 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
5074 Change dictionary name indexes to use hash tables instead of AVL
5077 * crosstabs.q: (free_var_dict) Use hash tables.
5078 (crs_custom_tables) Ditto.
5079 (calc_general) Ditto.
5080 (compare_table_entry) Rewrite.
5081 (enum_var_values) Reorder parameters. All references updated.
5084 * get.c: (rename_variable) Use hash tables.
5085 (mtf_merge_dictionary) Ditto.
5087 * glob.c: (init_glob) Use hash tables.
5088 (cmp_variable) Removed.
5090 * means.q: (mns_custom_tables) Use hash tables.
5092 * modify-vars.c: (rearrange_dict) Use hash tables.
5094 * rename-vars.c: (cmd_rename_variables) Use hash tables.
5096 * sfm-read.c: (read_header) Use hash tables.
5097 (read_variables) Ditto.
5099 * temporary.c: (new_dictionary) Use hash tables.
5100 (save_dictionary) Ditto.
5101 (restore_dictionary) Ditto.
5103 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
5104 hash table `name_tab'.
5106 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
5107 [DEBUGGING] (dump_var_tree) Removed.
5108 (find_variable) Use hash tables.
5109 (find_dict_variable) Ditto.
5110 (common_init_stuff) Ditto.
5111 (rename_variable) Ditto.
5112 (clear_variable) Ditto. Also, remove debug code.
5113 (dup_variable) Use hash tables.
5115 * vars-prs.c: (fill_all_vars) Use hash tables.
5116 (is_dict_varname) Ditto.
5117 (parse_dict_variable) Ditto.
5119 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
5121 Change value labels to use hash tables instead of AVL trees, and
5122 change value labels into an ADT.
5124 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
5126 * value-labels.c: New file.
5128 * value-labels.h: New file.
5130 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
5131 Get rid of a stupid use of goto.
5133 * autorecode.c: (compare_alpha_value) Rewrite.
5134 (hash_alpha_value) Ditto.
5135 (compare_numeric_value) Rewrite.
5136 (hash_numeric_value) Ditto.
5138 * frequencies.q: (dump_full) Use value label ADT.
5140 * pfm-read.c: (read_value_label) Use value label ADT.
5142 * pfm-write.c: (write_value_labels) Use value label ADT.
5144 * sfm-read.c: (read_variables) Use value label ADT.
5145 (read_value_labels) Rewrite.
5147 * sfm-write.c: (write_value_labels) Rewrite.
5149 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
5150 (display_variables) Ditto.
5151 (describe_variable) Ditto.
5153 * t-test.q: (print_t_groups) Use value label ADT.
5155 * temporary.c: (copy_variable) Use value label ADT.
5156 (free_dictionary) Ditto.
5158 * val-labs.c: (verify_val_labs) Use value label ADT.
5160 (debug_print) Ditto.
5161 (val_lab_cmp) Removed.
5162 (inc_ref_count) Removed.
5163 (copy_value_labels) Removed.
5165 * var.h: (struct value_label) Removed.
5166 (struct variable) Change AVL tree `val_lab' into hash table
5169 * vars-atr.c: (init_variable) Use value label ADT.
5170 (clear_variable) Ditto.
5171 (free_value_label) Removed.
5172 (free_val_lab) Removed.
5173 (get_val_lab) Removed.
5174 (compare_variables) New function.
5175 (hash_variable) New function.
5177 * vfm.c: (dump_splits) Use value label ADT.
5179 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
5181 Add to the hash table interface.
5183 * hash.c: (hsh_hash_bytes) Add assertion.
5184 (hsh_hash_string) Ditto.
5188 (hsh_create) Ditto. Also make minimum `size'.
5189 (hsh_destroy) Rephrase.
5190 (sort_nulls_last) Removed.
5191 (not_null) New function.
5193 (comparison_helper) Ditto.
5194 (hsh_sort) Rewritten.
5195 (hsh_data_copy) New function.
5196 (hsh_sort_copy) Ditto.
5198 (hsh_replace) Ditto.
5199 (hsh_hash_double) Ditto.
5200 (hsh_delete) Fix stupid bug.
5202 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5203 * added a calculation of the mode to FREQUENCIES
5205 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
5207 * moved (un)defs of DEBUGGING to config.h
5209 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
5211 * groff-font.c: (add_kern) Fix indentation.
5212 (add_kern) Use & instead of % to take power-of-2 modulus.
5213 (font_get_kern_adjust) Likewise.
5215 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
5217 * autorecode.c: (recode) Replace stupid use of memcpy() by
5219 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
5220 (hash_numeric_value) Ditto.
5221 (autorecode_proc_func) pool_strdup() was wrong here because the
5222 source string was not null-terminated. Use new pool_strndup()
5225 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
5226 use of hsh_iterator_init().
5228 * data-in.c: (parse_N) Initialize i->v->f.
5230 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
5233 * groff-font.c: Use power-of-2 hash table sizes, not prime.
5234 (groff_read_font) Don't call hsh_next_prime(). Don't call
5236 (static var hash) Remove `size_p', `max_used' members.
5237 (font_char_name_to_index) Don't call hsh_next_prime(). Use
5238 hsh_hash_string() instead of hashpjw(), & instead of %.
5239 (default_font) Don't call hsh_next_prime().
5241 * pool.c: (pool_strndup) New function.
5242 (pool_strdup) Reimplement in terms of pool_strndup.
5244 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
5246 (hash_ps_encoding) Use hsh_hash_string().
5247 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
5248 (hash_filename2font) Use hsh_hash_string().
5250 * som.c: Add #include <stdlib.h>.
5252 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
5253 (by destroying its pool).
5255 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
5257 Miscellaneous hash table code cleanup:
5259 * hash.h: (struct hsh_table) Moved into hash.c.
5260 (hsh_count) Ditto, and transformed into function.
5261 (hsh_compare_func) New typedef, used for defining otherwise-long
5262 function types here and in hash.c
5263 (hsh_hash_func) Ditto.
5264 (hsh_free_func) Ditto.
5266 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
5267 `table' to `entries'. Removed `mp'. All references updated.
5268 (hsh_clear) Don't shrink entries array; if the hash was this big
5269 once, it probably will be again.
5270 (hsh_rehash) Made static.
5271 (force_hsh_insert) Renamed hsh_force_insert.
5272 (force_hsh_find) Renamed hsh_force_find.
5274 Made hash table sizes powers of 2, because that's fine with any
5275 reasonable hash function and because taking a power-of-2 modulus
5276 is faster than any other:
5278 (hsh_prime_tab) Removed;
5279 (hsh_next_prime) Ditto.
5280 (next_power_of_2) New function.
5281 (hsh_create) Use next_power_of_2.
5282 (hsh_rehash) Use & instead of %.
5284 Cleaned up hsh_sort:
5286 (internal_comparison_fn) Removed.
5287 (sort_nulls_last) New function.
5288 (hsh_sort) Removed second parameter, switched to using the new
5289 quicksort() function from quicksort.h to avoid using nasty need
5290 for static variables with qsort(). All references updated.
5292 Changed the hash functions offered, because there are better hash
5293 functions than the ones we had, and cleaned up the names to boot:
5295 * hash.c: (hashpjw_d) Removed.
5297 (hsh_hash_bytes) New function.
5298 (hsh_hash_string) New function.
5299 (hsh_hash_int) New function.
5301 Improved the hash table iteration interface:
5303 * hash.h: (hsh_iterator_init) Removed.
5304 (struct hsh_iterator) Removed `init' member, change `next' to
5307 * hash.c: (hsh_foreach) Removed. All references updated to use
5308 hsh_first/hsh_next instead.
5309 (hsh_first) New function. Notably, unlike hsh_foreach() it does
5310 not treat a null pointer as an empty hash table.
5311 (hsh_next) New function.
5313 Made deletion possible, though slow:
5315 * hash.c: (locate_matching_entry) New function.
5316 (hsh_find) Use locate_matching_entry().
5317 (hsh_delete) New function also using locate_matching_entry().
5318 (hsh_force_delete) New function.
5320 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
5322 * quicksort.c: New file implementing a sort routine with a
5323 interface better than qsort() because it passes a user-provided
5324 parameter to the sort routine.
5326 * Makefile.am: Add quicksort.c, quicksort.h.
5328 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
5330 * All source files: Get rid of nasty special cases for Checker,
5331 which is pretty obsolete now.
5333 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
5335 * Fixed a bug apparent when using the FREQUENCIES command with the
5336 html driver. The html driver was incorrectly trying to display
5339 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
5341 * Makefile.am: Reorganized. Put locale dir in version.c instead
5342 of passing it to each compile command. Only put local gmp libs in
5343 LD_ADD if not installed on system. Remove `boast' target.
5345 * All source files: struct and union typedefs eliminated.
5346 `sizeof type' replaced by `sizeof object' where practical. Moved
5347 `unused' qualifiers from start to end of declarations for gcc
5348 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
5349 assertions on pointers strictly compliant. Removed _ prefixes on
5350 some function parameter names.
5352 * alloc.c: New source file, containing these external linkage
5353 functions removed from common.c: xmalloc, xcalloc, xrealloc,
5360 * ascii.c: Migrated from arenas to pools.
5361 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
5362 c_string to len_string. All references changed.
5363 (ascii_option) Signature changed to comply to new output.c
5365 (count_fancy_chars) Removed.
5366 (delineate) Removed support for rich text.
5367 (ascii_text_metrics) Ditto.
5369 (output_shorts) Change `box', `off', `on' from c_string to
5370 len_string. Change `remaining' from int to size_t.
5371 (ascii_close_page) Make page numbering less haphazard.
5373 * autorecode.c: Migrate from arenas to pools.
5375 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
5377 * bitvector.h: New file containing these macros from misc.h:
5378 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
5380 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
5381 word[3]. ncmd removed.
5382 (var empty_string) Removed.
5383 (var cmd_table) Declaration updated.
5384 (var cmdtab) Removed.
5385 (cmp_command) Removed.
5386 (split_words) Rewritten to use strtok_r().
5387 (init_cmd_parser) Renamed cmd_init(). Rewritten.
5388 (find_command) Removed.
5389 (FILE_TYPE_okay) Rewritten.
5390 (cmd_parse) Rewritten. Semantics of the return value of command
5391 handlers has changed: they must now return one of the new CMD_*
5392 enumerals, rather than a magic value. This meant that all
5393 commands had to be modified, and they were.
5394 (figure_out_command) New function.
5396 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
5397 #defines for INIT, INPU, etc.
5399 * command.h: New CMD_* enum series.
5400 (cur_proc) Make const char *, not char *.
5401 (cmd_init) Prototype.
5404 * common.c: Removed.
5406 * common.h: Removed.
5408 * correlations.q: New file.
5410 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
5412 (custom_tables) Renamed crs_custom_tables().
5413 (custom_variables) Renamed crs_custom_variables().
5414 (calc_integer) Add in some `const' qualifiers.
5415 (table_value_missing) Change from a_string to len_string.
5416 (float_M_suffix) Change from a_string to len_string.
5418 * data-in.c: Rewritten. All references to
5419 parse_string_as_format() changed to data_in().
5421 * data-in.h: New file.
5423 * data-list.c: Change DLS_* from #define's to enums. Move from
5424 rpd_msg() to tmsg().
5425 (RPD_ERR) New #define.
5426 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
5428 (read_from_data_list_fixed) Change from old
5429 parse_string_as_format() to new data_in().
5430 (read_from_data_list_free) Ditto.
5431 (read_from_data_list_list) Ditto.
5432 (cmd_repeating_data) Modify approach to checking for end of
5435 (rpd_parse_record) Change from old parse_string_as_format() to new
5436 data_in(). Change from old convert_format_to_string() to new
5438 (read_one_set_of_repetitions) Change dfm_push_cust() to
5439 dfm_push(), pop_cust() to dfm_pop().
5441 * data-out.c: Rewritten. All references to
5442 convert_format_to_string() changed to data_out().
5444 * descript.q: Migrate to new q2c.
5445 (cmd_descriptives) Removed.
5446 (internal_cmd_descriptives) Renamed cmd_descriptives ().
5447 (custom_variables) Renamed dsc_custom_variables().
5449 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
5451 (open_file_r) Initialize h->where.line_number. Migrate to new
5453 (open_file_w) Initialize h->where.line_number.
5454 (read_record) Change from ext->ln to h->where.line_number.
5455 Migrate to struct string.
5456 (dfm_put_record) Rephrased.
5457 (dfm_push_cust) Renamed dfm_push(), rewritten.
5458 (dfm_pop) New function.
5460 * error.c: All references updated.
5461 (glob var error_count) Renamed err_err_count.
5462 (glob var warning_count) Renamed err_warning_count.
5463 (glob var error_already_flagged) Renamed err_already_flagged.
5464 (glob var verbosity) Renamed err_verbosity.
5465 (glob var cust_fn) Removed.
5466 (glob var cust_ln) Removed.
5467 (static var file_loc) New.
5468 (static var nfile_loc) New.
5469 (static var mfile_loc) New.
5470 (tmsg) New function.
5471 (push_cust) Removed.
5474 (static var terminating) Removed.
5475 (failure) Renamed err_failure().
5476 (hcf) Renamed err_hcf().
5477 (err_push_file_locator) New function.
5478 (err_pop_file_locator) New function.
5479 (err_location) New function.
5480 (check_error_count) Renamed err_check_count().
5481 (vmsg) Renamed err_vmsg(). Interface changed.
5482 (verbose_msg) Removed.
5483 (err_cond_fail) New function.
5484 (error_break) Renamed err_break().
5486 * error.h: All references updated.
5487 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
5488 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
5490 (struct file_locator) New.
5492 (macro verbose_msg) Removed.
5493 (macro cond_fail) Removed.
5495 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
5497 * expr-prs.c: Reorganized. All references updated.
5498 (exprtypename) Renamed expr_type_name().
5499 (typename) Renamed type_name().
5500 (free_expression) Renamed expr_free().
5501 (parse_expression) Renamed expr_parse(). Uses new type_check()
5503 (init_functab) Renamed init_func_tab().
5504 (type_check) New function.
5505 (parse_or) Rewritten to use new allocate_nonterminal() and
5506 append_nonterminal_arg() functions.
5509 (parse_rel) Ditto. Also simplified logic.
5514 (SYSMIS_func) Ditto.
5515 (VALUE_func) Rephrased.
5516 (CONCAT_func) Fix memory leak by replacing free by free_node on
5518 (generic_str_func) Ditto.
5519 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
5521 (allocate_nonterminal) New function.
5522 (append_nonterminal_arg) New function.
5523 (static func_tab[]) Now at file level.
5525 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
5527 * expr.h: (enum series OP_*) Moved to exprP.h.
5528 (OP_* defines) Ditto.
5529 (struct op_desc) Ditto.
5530 (global ops[]) Ditto.
5531 (struct num_con_node) Ditto.
5532 (struct str_con_node) Ditto.
5533 (struct var_node) Ditto.
5534 (struct lag_node) Ditto.
5535 (struct casenum_node) Ditto.
5536 (struct nonterm_node) Ditto.
5537 (union any_node) Members renamed.
5538 (struct sys_node) Removed.
5539 (struct val_node) Removed.
5540 (operator typedef) Removed.
5541 (typedef exprtype) Removed.
5542 (enum series EX_*) Moved to exprP.h.
5543 (struct expression) Ditto. Also renamed a lot of the members.
5544 (PXP_* defines) Changed to enums.
5545 (free_node prototype) Moved to exprP.h.
5547 * file-handle.h: (struct file_handle) New member `where'.
5549 * file-handle.q: Migrated to new q2c format.
5550 (prepend_current_directory) Removed (dead code).
5551 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
5552 (fh_get_handle_by_filename) Removed dead code.
5553 Set new `where' member.
5555 * file-type.c: (file_type_source_read) References to
5556 parse_string_as_format() changed to data_in().
5557 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
5559 * filename.c: All references updated.
5560 (init_filename) Renamed fn_init().
5561 (expand_line) Removed.
5562 (macro EXPAND_LINE) Removed.
5563 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
5564 of custom functions.
5565 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
5566 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
5567 (normalize_filename) Renamed fn_normalize().
5568 (search_path) Renamed fn_search_path(), rewritten.
5569 (prepend_dir) Renamed fn_prepend_dir().
5570 (blp_getenv) Renamed fn_getenv().
5571 (blp_dirname) Renamed fn_dirname().
5572 (fn_basename) New function, not used.
5573 (absolute_filename_p) Renamed fn_absolute_p().
5574 (is_special_filename) Renamed fn_special_p().
5575 (file_exists) Renamed fn_exists_p().
5576 (readlink_malloc) Renamed fn_readlink().
5577 (getenv_default) Renamed fn_getenv_default().
5578 (open_file) Renamed fn_open().
5579 (close_file) Renamed fn_close().
5580 (open_file_ext) Renamed fn_open_ext().
5581 (close_file_ext) Renamed fn_close_ext().
5583 * font.h: Migrate from arenas to pools.
5585 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
5587 * frequencies.g: Migrate from arenas to pools.
5589 * frequencies.q: Migrate to new q2c version. Migrate from arenas
5592 * getline.c: All references updated.
5593 (global getl_buf) Changed from char * to struct string.
5594 (static getl_include_path) Ditto.
5595 (global getl_buf_len) Removed.
5596 (global getl_buf_size) Removed.
5597 (getl_include_path) Deal with new getl_buf, getl_include_path.
5598 (getl_uninitialize) New function.
5599 (getl_get_current_directory) Rewritten.
5600 (getl_clear_include_path) Rewritten.
5601 (getl_add_include_dir) Rewritten.
5602 (getl_add_file) Assertion fixed.
5603 (getl_add_virtual_file) Change initial value of `remaining_loops'
5605 (welcome) Rewritten.
5606 (handle_line_buffer) Make static. Change logic to make
5607 getl_add_virtual_file() change sensible. Use ds_*() strings.
5608 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
5609 (getl_close_file) Moved.
5610 (getl_location) New function.
5612 * getline.h: All references updated.
5613 (macro curln) Removed.
5614 (macro curfn) Removed.
5615 (macro am_interactive) Renamed getl_am_interactive.
5616 (macro am_reading_script) Renamed getl_reading_script.
5618 * glob.c: (global fmt_parse_ignore_error) Removed.
5619 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
5620 systems that support it (C99). Turn off SET ECHO by default. No
5621 necessary julcal initialization anymore.
5623 * groff-font.c: Migrate from arenas to pools.
5624 (groff_read_font) Use err_push_file_locator().
5625 (groff_read_DESC) Ditto.
5626 (font_msg) Use tmsg().
5628 * hash.c: (hsh_sort) Fix debug code.
5629 [GLOBAL_DEBUGGING] Include stdio.h.
5631 * hash.h: (macro force_hsh_insert) Rephrase.
5633 * heap.c: Rewritten.
5635 * heap.h: Rewritten.
5637 * html.c: (html_option) Change from outp_value to struct string.
5638 (postopen) Change from curfn to getl_location().
5639 (escape_string) Remove rich-text code. Signature changed.
5640 (output_tab_table) Switch from a_string to struct len_string.
5641 Remove rich text support.
5643 * lexer.c: All references updated. Largely rewritten. Major
5644 changes listed below. Removed tagged quote support. Adapted to
5645 struct string tokstr.
5646 (global tokstr) Changed to struct string.
5647 (global tokstr_size) Removed.
5648 (global tokstr_len) Removed.
5650 (global tokint) Removed.
5651 (global toklongstr) Removed.
5652 (C* defines) Removed.
5653 (static tbl[]) Removed.
5654 (static id[]) Removed.
5655 (static une[]) Removed.
5656 (discard_line) Renamed lex_discard_line().
5657 (get_entire_line) Renamed lex_entire_line().
5658 (get_rest_of_line) Renamed lex_rest_of_line().
5659 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
5660 (make_hexit) Removed.
5661 (syntax_error) Renamed lex_error(). Return value removed.
5662 (get_token_representation) Renamed lex_token_representation().
5663 (putback) Renamed lex_put_back().
5664 (putfwd) Renamed lex_put_forward().
5665 (convert_negative_to_dash) Renamed lex_negative_to_dash().
5666 (set_prog) Renamed lex_set_prog().
5667 (init_lex) Renamed lex_init().
5668 (reset_eof) Renamed lex_reset_eof().
5669 (lookahead) Renamed lex_look_ahead().
5670 (check_id) Rewritten.
5671 (yylex) Renamed lex_get(), rewritten.
5672 (lex_end_of_command) New function. Many commands were rephrased
5674 (lex_integer_p) New function. Replaces compare of tokint against
5676 (lex_integer) New function. Replaces tokint.
5677 (match_tok) Renamed lex_match().
5678 (match_id) Renamed lex_match_id().
5679 (match_int) Renamed lex_match_int().
5680 (force_match_id) Renamed lex_force_match_id(), added return value.
5681 (force_match) Renamed lex_force_match(), added return value.
5682 (force_string) Renamed lex_force_string(), added return value.
5683 (force_int) Renamed lex_force_int(), added return value.
5684 (lex_id_match_len) New function.
5685 (id_match) Renamed lex_id_match(), rewritten.
5686 (get_line) Renamed lex_get_line().
5687 (preprocess_line) Renamed lex_preprocess_line().
5688 (tokname) Renamed lex_token_name().
5689 (bin_value_func) Removed.
5690 (oct_value_func) Removed.
5691 (hex_value_func) Removed.
5692 (unexpected_eof) New function.
5693 (convert_numeric_string_to_char_string) New function.
5694 (parse_string) Rewritten, signature changed.
5695 (add_tokstr_char) Removed.
5696 (add_tokstr_unsigned) Removed.
5697 (add_tokstr_string) Removed.
5698 (parse_tagged_quote) Removed.
5699 (skip_comment) Renamed lex_skip_comment().
5701 * lexer.h: All references updated.
5702 (macro is_id1) Renamed CHAR_IS_ID1.
5703 (macro is_idn) Renamed CHAR_IS_IDN.
5704 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
5705 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
5706 (macro get_token) Removed.
5707 (macro id_match) Removed.
5708 (macro force_match_id) Removed.
5709 (macro force_match) Removed.
5710 (macro force_string) Removed.
5711 (macro force_int) Removed.
5712 (macro force_num) Removed.
5713 (macro force_id) Removed.
5715 * lexerP.h: Removed.
5717 * list.q: Migrated to new q2c format.
5718 (write_line) Deal with struct len_string.
5719 (write_varname) Ditto.
5720 (write_fallback_headers) Ditto.
5722 * magic.c: New file, incorporating the following global variables
5723 previously in other files: endian, second_lowest_value. And both
5724 of those are conditional on #define's.
5726 * magic.h: New file, incorporating the following global variable
5727 declarations: endian, second_lowest_value, and the following macro
5728 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
5730 * main.c: Added declarations of pgmname, finished, curdate,
5732 (main) Call new parse_script() function.
5733 (parse_script) New function.
5734 (execute_command) New function.
5735 (dump_token) Removed.
5736 (handle_error) New function.
5738 * matrix.c: New file.
5740 * matrix.h: New file.
5742 * matrix-data.c: Migrated from arenas to pools.
5743 (mget_token) Change from parse_string_as_format() to data_in().
5745 * means.q: Migrate to new q2c.
5746 (custom_tables) Renamed mns_custom_tables().
5747 (custom_crossbreak) Renamed mns_custom_crossbreak().
5748 (custom_variables) Renamed mns_custom_variables().
5750 * mis-val.c: (static var width) Changed from `int' to `size_t'.
5751 (parse_varnames) Prototype.
5752 (parse_numeric) Rephrasings.
5753 (parse_alpha) Adapt to new struct string tokstr.
5755 * misc.c: (intlog10) Rewritten.
5757 (ansi_rand) Renamed real_rand(), moved into random.c.
5758 (ansi_srand) Renamed real_srand(), moved into random.c.
5759 (setup_randomize) Moved to random.c.
5760 (rand_uniform) Ditto.
5761 (rand_normal) Ditto.
5762 (rand_simple) Ditto.
5763 (get_config_line) Removed.
5764 (reverse) Removed (dead code).
5766 * misc.h: (macro SET_BIT) Moved to bitvector.h.
5767 (macro CLEAR_BIT) Ditto.
5768 (macro TEST_BIT) Ditto.
5769 (macro SET_BIT_TO) Ditto.
5770 (macro BIT_INDEX) Ditto.
5772 * output.c: (outp_read_devices) Move to err_push_file_locator()
5773 from push_cust(). Use struct string.
5774 (expand_op_tokstr) Removed.
5775 (static var op_tokstr) Changed to struct string.
5776 (static var op_tokstr_size) Removed.
5777 (tokener) Rephrasings. Use struct string.
5778 (parse_options) Use struct string.
5779 (destroy_driver) Fix assertion.
5780 (outp_get_paper_size) Move to err_push_file_locator().
5781 [0] Removed dead code.
5782 (outp_string_width) Move to len_string.
5784 * output.h: Comment fixes.
5785 (TAG_* enum series) Removed.
5786 (struct outp_value) Removed.
5787 (enum OUTP_T_FANCY) Removed.
5788 (struct outp_text) `s' changed from a_string to len_string.
5789 (struct outp_class) `option' change arg 3 from outp_value to
5792 * pfm-read.c: (corrupt_msg) Rewritten.
5794 * pfm-write.c: (bufwrite) Fix assertion.
5796 * pool.c: New file, reference version.
5798 * pool.h: New file, reference version.
5800 * postscript.c: (ps_font_sizes) Fix assertion.
5801 (ps_option) Change arg 3 from outp_value to struct string.
5802 Adapt to struct string.
5803 (macro output_line) Removed.
5804 (macro add_string) Removed.
5805 (output_encodings) Adapted to struct string. Moved to
5806 err_push_file_locator().
5807 (find_encoding_file) Fix assertion.
5808 (read_ps_encodings) Move to err_push_file_locator().
5809 (postopen) Use getl_location() instead of curfn.
5810 (out_text_plain) Move to len_string.
5811 (text) Ditto. Remove rich text support.
5813 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
5814 (cmd_print_eject) Ditto.
5816 (internal_cmd_print) Now cleans up after itself. Uses
5817 fh_parse_file_handle() now.
5818 (cmd_print_space) Use PXP_NUMERIC to type-check.
5820 * q2c.c: Overhauled. Removed _("") i18n support. All references
5821 updated. All output functions updated to handle structures rather
5822 than local or static variables. Adapt to new PSPP lex_*()
5826 (macro MAX_N_SBC) Removed.
5827 (global bare) Removed.
5828 (enum STRING) Renamed T_STRING.
5829 (enum ID) Renamed T_ID.
5830 (get_buffer) Buffer size increased.
5831 (strlower) Renamed st_lower(), rephrased.
5832 (strupper) Renamed st_upper(), rephrased.
5833 (skip_ws) New function.
5834 (get_line) Don't special-case any types of lines (like those
5835 beginning with ! or $, for instance).
5836 (get_token) Renamed lex_get(). Rephrased.
5837 (static var `prefix') New.
5838 (parse) New function.
5839 (parse_setting) Minor rephrasing.
5840 (dump_specifier_vars) Ditto.
5841 (make_identifier) Put null terminator on identifier, duh.
5842 (dump_vars) Renamed dump_declarations(). Never indent. Never
5843 static. Output changed entirely.
5844 (dump_specifier_init) Rephrase.
5845 (dump_vars_init) No index variable needed. Other modifications.
5846 (dump_parser) Don't parse command name. Do dump functions instead
5847 of just code fragments.
5848 (dump_free) Dump function instead of code fragment.
5849 (recognize_directive) New function.
5850 (main) Use recognize_directive(). Don't rely on magic $ line
5851 beginning: instead, parse comments. Update list of headers.
5853 * random.c: New file, containing the following functions:
5854 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
5855 rand_normal, rand_simple.
5857 * random.h: New file.
5859 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
5860 function. `max_src_width', `max_dst_width' changed to size_t.
5861 (internal_cmd_recode) Removed.
5862 (parse_dest_spec) Merge similar cases.
5863 (parse_src_spec) Add assertion.
5865 * repeat.c: (recognize_keyword) New function.
5866 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
5867 REPEAT. Improve recognition of END REPEAT (use
5868 recognize_keyword()). Move from curfn to getl_location(). Use
5871 (perform_DO_REPEAT_substitutions) Adapt to struct string.
5873 * set.q: Adapt to new q2c.
5874 (cmd_set) Range-check some values better.
5875 (custom_blanks) Renamed stc_custom_blanks().
5876 (custom_length) Renamed stc_custom_length().
5877 (custom_results) Renamed stc_custom_results().
5878 (custom_seed) Renamed stc_custom_seed().
5879 (custom_width) Renamed stc_custom_width().
5880 (custom_format) Renamed stc_custom_format().
5881 (custom_journal) Renamed stc_custom_journal().
5882 (custom_color) Renamed stc_custom_color().
5883 (custom_listing) Renamed stc_custom_listing().
5884 (custom_disk) Renamed stc_custom_disk().
5885 (custom_log) Renamed stc_custom_log().
5886 (custom_rcolor) Renamed stc_custom_rcolor().
5887 (custom_viewlength) Renamed stc_custom_viewlength().
5888 (custom_workdev) Renamed stc_custom_workdev().
5890 * settings.h: Not necessary to include format.h any longer.
5892 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
5893 (corrupt_msg) Rewritten.
5895 * sort.c: Adapt to rewritten heap ADT.
5897 * str.c: (aa_strcpy) Removed.
5898 (ab_strcpy) Removed.
5899 (ac_strcpy) Removed.
5900 (ba_strcpy) Removed.
5901 (bb_strcpy) Removed.
5902 (ca_strcpy) Removed.
5903 (aa_strdup) Removed.
5904 (aa_strdupcpy) Removed.
5905 (ba_strdup) Removed.
5906 (sa_strdup) Removed.
5907 (memrev) Renamed mm_reverse().
5908 (memrmem) Renamed mm_find_reverse().
5909 (cmp_str) Renamed st_compare_pad().
5910 (strmaxcpy) Removed.
5911 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
5912 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
5914 (strpadcpy) Renamed st_pad_copy(), signature changed.
5915 (blpstrset) Removed.
5916 (ds_create) New function.
5917 (ds_init) New function.
5918 (ds_replace) New function.
5919 (ds_destroy) New function.
5920 (ds_clear) New function.
5921 (ds_extend) New function.
5922 (ds_shrink) New function.
5923 (ds_truncate) New function.
5924 (ds_length) New function.
5925 (ds_size) New function.
5926 (ds_value) New function.
5927 (ds_end) New function.
5928 (ds_concat) New function.
5929 (ds_concat_buffer) New function.
5930 (ds_printf) New function.
5931 (ds_putchar) New function.
5932 (ds_getline) New function.
5933 (ds_get_config_line) New function derived from the old
5934 misc.c:get_config_line().
5935 (ls_create) New function.
5936 (ls_create_buffer) New function.
5937 (ls_init) New function.
5938 (ls_shallow_copy) New function.
5939 (ls_destroy) New function.
5940 (ls_null) New function.
5941 (ls_null_p) New function.
5942 (ls_empty_p) New function.
5943 (ls_length) New function.
5944 (ls_value) New function.
5945 (ls_end) New function.
5947 * str.h: Reformatted.
5948 (struct a_string) Removed.
5949 (struct b_string) Removed.
5950 (struct c_string) Removed.
5951 (struct len_string) New.
5952 (struct string) New.
5953 (macro as_streq) Removed.
5954 (macro bs_streq) Removed.
5955 (macro cs_streq) Removed.
5956 (macro sa_streq) Removed.
5957 (macro sb_streq) Removed.
5958 [__GNUC__] (inline function ds_putchar) New function.
5959 [__GNUC__] (inline function ds_length) New function.
5960 [__GNUC__] (inline function ds_value) New function.
5961 [__GNUC__] (inline function ds_end) New function.
5963 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
5964 (display_vectors) Fix missing i18n.
5966 * t-test.q: Migrate to new q2c.
5968 * tab.c: Migrate from arenas to pools.
5969 (tab_create) Use struct len_string.
5970 (tab_realloc) Ditto.
5971 (text_format) Ditto.
5972 (tab_joint_text) Ditto.
5973 (tab_natural_width) Remove rich text support.
5974 (tab_natural_height) Ditto.
5975 (tab_output_text) Handle TAT_FIX.
5976 (tab_raw) Change arg from a_string to len_string.
5977 (tabi_driver) Fix assertion. Use struct len_string.
5978 (render_strip) Use struct len_string. Remove rich text support.
5979 Add `const' qualifiers.
5981 * tab.h: (enum TAB_RICH) Remove.
5982 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
5983 SOM_COL_* updated to read TAB_COL_*.
5984 (struct tab_table) Change arena to pool. Change a_string to
5987 * temporary.c: (restore_dictionary) Rewrite Checker code.
5989 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
5990 LOWEST, HIGHEST) Moved here from common.h.
5991 (typedef any_trns) Removed. All references changed to `struct
5994 * vars-atr.c: (force_create_variable) Fix assertion.
5995 (force_dup_variable) Fix assertion.
5997 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
5999 Using alphanumeric variables in functions under AGGREGATE
6000 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
6001 <BZN-mdksh@t-online.de> for reporting this bug.
6003 * aggregate.c: (parse_aggregate_functions) When setting the
6004 FSTRING bit, also allocate memory for the `string' member of
6006 (free_aggregate_functions) Free iter->string. Don't use the
6007 non-function bits when indexing the array of functions.
6008 [DEBUGGING] (debug_print) Don't use the non-function bits when
6009 indexing the array of functions.
6011 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
6013 Under certain circumstances, the final case would be omitted from
6014 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
6015 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6017 * aggregate.c (agr_00x_end_func): Increment number of cases in
6018 sink before writing case. For streams that keep track of how many
6019 cases there are based on this value, this means that the last case
6020 will be read in on the next stream read.
6022 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
6024 Undefined behavior was invoked by referencing a freed pointer.
6026 * vfm.c (memory_stream_write): Free pointer *after* checking for
6029 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
6031 A wrong record size was displayed when paging the active file to
6034 * vfm.c: (memory_stream_write) Fix off-by-one error.
6036 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
6038 Not having enough temporary space for sorting caused a core dump.
6041 * sort.c: (allocate_cases) Initialize i.
6043 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
6045 Syntax errors in function descriptions on AGGREGATE caused core
6048 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
6049 free_aggregate_functions(), since that function already frees
6052 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
6054 A null pointer was dereferenced, causing a core dump, when
6055 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
6056 but PSPP still doesn't calculate percentiles. Thanks to Regnor
6057 Jernsletten <rjernsle@eunet.no> for reporting this problem.
6059 * arena.c: (arena_malloc) If the arena hasn't been initialized
6060 already, initialize it.
6062 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
6064 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
6065 for compilation with Cygnus Windows B20. Not used by other
6068 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
6070 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
6071 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6073 * sort.c: (compare_case_lists) Reverse sense of comparison if
6074 sorting in descending order.
6075 (compare_record) Ditto.
6077 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
6079 SPLIT FILE with a string variable caused a core dump. Fixed.
6081 * vfm.c: If the variable is a string then make a temporary value
6082 struct pointing to it. The underlying problem is a lot bigger
6083 than this (see TODO) but this is a stopgap for the simple case at
6086 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
6088 Nested INCLUDEs didn't work. Fixed.
6090 * getline.c: (getl_include) Set first_line to NULL in allocated
6093 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
6095 The MATCH FILES procedure set the values of variables not present
6096 to 0. It should have been SYSMIS. This is now fixed.
6098 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
6100 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
6102 The REMARK command was too aggressive about skipping lines. It
6103 didn't like being the last command in a file.
6105 * command.c: (cmd_remark) Call get_entire_line() instead of
6108 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
6110 Comment parsing wasn't consistent with the rest of the code in its
6111 idea of where one command ends and another starts. This meant
6112 that sometimes commands would be mysteriously ignored. Thanks to
6113 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
6115 * command.c: (parse_cmd) Hand off comment parsing to new function
6116 skip_comment() in lexer.c.
6117 * lexer.c: (skip_comment) New function.
6119 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
6121 The TABLE subcommand on MATCH FILES worked only erratically at
6122 best. This fixes it. Thanks to Dr. Dirk Melcher
6123 <BZN-mdksh@t-online.de> for reporting this bug.
6125 * get.c: (mtf_compare_BY_values) When comparing string values, a
6126 difference of 1 is still a difference :-)
6127 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
6128 advance TABLE files automatically when matched. Comment fixes.
6130 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
6132 VARIABLE LABELS rejected a slash before the first variable
6133 specification, contradicting the documentation. Thanks to Walter
6134 M. Gray <graywm@northernc.on.ca> for reporting this bug.
6136 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
6137 command specification.
6139 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
6141 Because of an incorrect optimization in memory allocation,
6142 CROSSTABS sometimes segfaulted when asked to output multiple
6143 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6146 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
6147 are passed to output_pivot_table() for its use.
6148 (output_pivot_table) Instead of assuming the number of columns is
6149 constant, keep track with maxcols. In general mode, use maxcells
6150 to determine whether more matrix cells need to be allocated.
6152 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
6154 CROSSTABS didn't display value labels for column and row
6155 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
6158 * crosstabs.q: (table_value_missing) If the specified value has a
6159 value label for this variable, then show it instead of the raw
6161 (display_dimensions) Delegate display of value_labels to
6162 table_value_missing.
6164 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
6166 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
6167 <BZN-mdksh@t-online.de> for reporting this bug.
6169 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
6170 if the file isn't declared as binary.
6172 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
6174 MATCH FILES corrupted memory and dumped core on some syntax
6177 * get.c: (cmd_match_files) Set file->handle to NULL before
6179 (mtf_free_file) Don't free a null dictionary.
6181 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
6183 MATCH FILES should set numeric values not available to the
6184 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
6185 <BZN-mdksh@t-online.de> for reporting this bug.
6187 * get.c: (mtf_processing) Set unused records to system-missing,
6190 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
6192 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
6193 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
6195 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
6196 in newly created dictionary, and add each copied variable to the
6199 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
6203 * get.c: (trim_dictionary) Free variable list for KEEP after
6206 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
6208 Some systems didn't like the way open_file was coded. Thanks to
6209 Hankin <hankin@rogue.consultco.com> for pointing this out.
6211 * filename.c: (open_file) Don't try to store stdin, stdout,
6212 stderr as part of an array, because that doesn't always work.
6214 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
6216 The SAVE procedure didn't save long string variables properly.
6217 Fixed by this patch. Thanks to Hankin
6218 <hankin@rogue.consultco.com> for this patch.
6220 * sfm-write.c: (write_variable) Fix off-by-one error in writing
6221 out variable pad records.
6223 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
6225 Previously, if PRINT SPACE were given a negative argument, it
6226 would report an error, then spin in an (almost) infinite loop.
6227 This fixes that behavior.
6229 * print.c: (print_space_trns_proc) After reporting a negative
6230 argument, set number of lines to print to 1.
6232 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
6234 SPSS 8.0 outputs some new record types in its system files, and it
6235 allows longer value labels. Accept these system files.
6237 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
6238 11 emitted by SPSS 8.0.
6240 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
6242 The LIST procedure was too conservative in allocating space for
6243 buffers, which caused a bug that only showed up with very long
6244 output variables. Thanks to Hankin <hankin@dunno.com> for this
6247 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
6249 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
6251 Typo meant string format specifiers weren't checked properly. I
6252 think that Hankin <hankin@dunno.com> sent me this report, but I'm
6253 willing to be corrected on this point.
6255 * format.c: (check_string_specifier) Fix obvious typo.
6257 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
6259 Using $CASENUM in an expression didn't work. Here's a fix.
6260 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
6263 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
6265 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
6267 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
6269 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
6270 other behavior, *sigh*. This patch hopefully fixes that. This
6271 time I've actually tested it.
6273 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
6275 * data-list.c: (read_from_data_list_free,
6276 read_from_data_list_list) Call parse_string_as_format() directly
6277 without mucking around with the field width.
6279 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
6281 Occasionally, you may encounter a script that wants to be
6282 interpreted in interactive mode. Make -i emulate this behavior to
6283 allow such scripts to be executed with PSPP.
6285 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
6287 * cmdline.c: (pre_syntax_message[]) Update -i description.
6289 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
6290 when -i is given on the command line) don't treat unindented lines
6291 as starting a new command.
6293 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
6295 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
6296 mostly caused by local initialized aggregates. After egcs is
6297 fixed upstream these can be removed, but for now they're not a big
6300 * ascii.c: (ascii_postopen_driver) Checker chokes on local
6301 initialized arrays. Avoid this.
6303 * sfm-write.c: (sfm_write_dictionary) Don't use a local
6306 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
6308 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
6309 following changes avoid. Currently I compile sources with egcs
6310 1.1.1 and gcc 2.7.2.3 before sending them out.
6312 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
6314 * ascii.c: (option_tab[]) Initialize all struct members.
6316 * avl.h: (avl_traverser_init) New macro.
6318 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
6321 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
6324 * hash.c: Comment fix.
6326 * hash.h: (hsh_iterator_init) New macro.
6328 * html.c: (option_tab[]) Initialize all struct members.
6330 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
6333 * postscript.c: (option_tab[]) Initialize all struct members.
6334 (output_encodings, preclose, dump_lines) Use new
6335 hsh_iterator_init() macro.
6337 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
6340 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
6343 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
6345 * data-in.c: Examined each of the parsing functions to make sure
6346 that they wouldn't dump core if they were passed a string of the
6347 wrong length, since now the DATA LIST FREE/LIST routines don't
6348 check for field width before passing it to the data parser.
6349 (parse_RBHEX, parse_AHEX) Reject odd length input.
6350 (parse_string_as_format) Reject input that's too short or too
6353 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
6354 a field to its entire declared output width then pass it to the
6355 data-in parsing routines. This contradicted the documented
6356 behavior. This is fixed in these changes. Thanks to Mark H. Wood
6357 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
6358 free-format parsing that differed from SPSS.
6359 (cut_field) Commas and spaces are treated identically. Returns
6360 the proper column instead of a fixed 1 value.
6361 (parse_field) Removed.
6362 (read_from_data_list_free, read_from_data_list_list) Call
6363 parse_string_as_format directly instead of parse_field.
6365 * heap.c: (heap_delete) Stylistic fixes.
6367 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
6369 * loop.c: (loop_2_trns_proc) Formatting fix.
6371 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
6373 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
6375 * vfm.c: (macro FILTERED) New.
6376 (static var filter_var) New.
6377 (process_active_file_write_case) Use FILTERED.
6378 (setup_filter) Set filter_var.
6379 (close_active_file) Delete the filter if not
6380 FILTER_before_TEMPORARY.
6381 (procedure_write_case) Use FILTERED.
6383 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
6385 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
6387 * data-in.c: (parse_day_count) Message fix.
6388 (parse_month) Style fix.
6390 * data-list.c: (struct data_list_pgm) New member eof.
6391 (cmd_data_list) Init eof to 0.
6392 (do_reading) Implement the /END subcommand and read-past-eof
6395 * do-if.c: Include stdio.h when debugging.
6396 (cmd_else_if) Make sure the command is .-terminated.
6398 * glob.c: (init_glob) Capitalize the command prompt.
6400 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
6401 (end_file_trns_proc) Debugging message.
6403 * loop.c: (internal_cmd_loop) Make it work when there's no loop
6405 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
6407 * main.c: (dump_token) Make kwtab[] const.
6409 * set.q: Spelling, comment fixes.
6411 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
6414 * vars-prs.c: (fill_all_vars) Style fix.
6416 * vfm.c: (index_to_varname) Return const.
6418 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
6420 * Changes in many source files for partial -ansi -pedantic and
6421 no-debugging compliance: Remove trailing common in enum
6422 declarations; add `unused' attributes; insert some appropriate
6425 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
6427 * command.c: (shell) Make static.
6428 (run_command) Make static.
6430 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
6432 * dfm.c: (cmd_begin_data) I18n fix.
6434 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
6436 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
6438 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
6441 * file-handle.q: Don't prepend the source file directory name to
6442 the data file name. (Ongoing issue.)
6443 (prepend_current_directory) Comment out.
6444 (internal_cmd_file_handle) Don't call prepend_current_directory().
6445 (fh_get_handle_by_filename) Ditto.
6447 * filename.c: Append zero byte to readlink() return value.
6449 * getline.c: (getl_read_line) I18n fix.
6451 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
6453 * misc.h: Don't use gcc features if __STRICT_ANSI__.
6455 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
6458 * postscript.c: (output_encodings) Don't use local_strdup().
6461 * print.c: Don't use gcc features if __STRICT_ANSI__.
6463 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
6465 * recode.c: (parse_src_spec) Fully brace nested if's.
6467 * set.q: (global var set_testing_mode) New var.
6469 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
6471 * ascii.c: Add some more `unused' attributes that only come into
6472 play when NDEBUG is defined.
6473 (ascii_close_page) Set s_len when reallocating s.
6475 * crosstabs.q: (delete_missing) New function.
6476 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
6477 (make_summary_table) Create summary table reallocable.
6479 * postscript.c: Add more `unused' attributes as above.
6481 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
6482 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
6484 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
6487 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
6488 gratuitous space between parameter definition.
6490 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
6491 complaints about running off the end of functions with NDEBUG
6494 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
6496 * Several source files: Removed some PORTME notes when reflection
6497 revealed that ANSI forbids that sort of breakage. Also, added
6498 lots of `unused' qualifiers here and there.
6500 * aggregate.c: (accumulate_aggregate_info) Remove local var
6501 weighting that turned out not to be used.
6503 * avl.c: Update to version 1.1.0. Add unused specifier.
6504 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
6506 (avl_probe) Replace some instances of 1 with +1 where appropriate.
6507 (avl_find) Cast return value to void *.
6508 (avl_delete) q doesn't need to be initialized at the beginning of
6509 the function. Replace some instances of 1 with +1.
6510 (force_avl_delete) Renamed avl_force_delete, all references changed.
6511 (compare_ints) `param' marked unused.
6512 (print_int) `param' marked unused.
6513 (recurse_tree) Replace some instances of 1 with +1.
6515 * avl.h: Update to version 1.1.0. Only declares avl function
6516 types if not already declared.
6517 (AVL_MAX_HEIGHT) Only define if not already defined.
6518 (struct avl_node) New unused member char pad[2].
6519 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
6520 (force_avl_insert) Renamed avl_force_insert.
6521 (force_avl_delete) Renamed avl_force_delete.
6523 * crosstabs.q: (struct table_entry) Put `freq' into a union with
6525 (struct crosstab) Add new member `ofs'.
6526 (glob var int_tab) Removed.
6527 (custom_tables) In integer mode, assign v[i] properly through the
6529 (custom_variables) Now p.crs.max == max + 1.
6530 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
6531 (precalc) Implement integer mode.
6532 (calc_integer) Implement integer mode.
6533 (compare_table_entry) Remove unused local variable `comparing'.
6534 (make_summary_table) Implement integer mode.
6535 (macro ns_rows) Implemented as static variable now.
6536 (several variables) Made static, from global.
6537 (output_pivot_table) Use table_value_missing() for column heads.
6538 Remove several unused local variables. Implement integer mode
6539 table summing. Count up ns_rows.
6540 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
6541 (find_pivot_extent) Moved into find_pivot_extent_general; now just
6542 calls that function or find_pivot_extent_integer.
6543 (find_pivot_extent_integer) New function.
6544 (enum_var_values) Implemented for integer mode.
6545 (table_value_missing) New function.
6546 (display_dimensions) Call table_value_missing() for heads.
6547 (float_M_suffix) New function.
6548 (display_crosstabulation) Call table_value_missing() for row
6549 heads. Handle missing values in /MISSING=REPORT mode.
6550 (calc_fisher) Remove unused var N.
6551 (calc_r) Remove unused var fact.
6553 * data-list.c: (dump_fixed_table) Fix table dimensioning.
6554 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
6556 * data-out.c: (insert_commas) Remove unused var cp.
6557 (convert_CCx) Remove unused vars save_set_decimal,
6560 * descript.q: (dump_z_table) Fix table dimensioning.
6561 (pre_calc) Remove unused var j.
6562 (display) Remove unused vars title, s. Fix table dimensioning.
6564 * expr-evl.c: Comment fixes.
6566 * frequencies.q: (full_dim) New function.
6567 (dump_full) Fix table dimensioning.
6568 (condensed_dim) New function.
6569 (dump_condensed) Fix table dimensioning.
6571 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
6574 * html.c: (html_close_drive) Remove unused var i.
6575 (postopen) Remove unused vars title, curfn_len, cp.
6576 (preclose) Remove unused vars this, x.
6578 * lexer.c: Comment fixes.
6580 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
6582 * means.q: (custom_tables) Remove unused var m_dim.
6584 * mis-val.c: Format fix.
6586 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
6588 * output.c: (outp_get_paper_size) Remove unused var cp.
6590 * pfm-read.c: (read_float) Remove unused var save, unused label
6592 (read_variables) Remove unused vars cp, j.
6593 (read_value_label) Remove unused var j.
6595 * pfm-write.c: (bufwrite) Remove unused var i.
6597 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
6599 (output_encodings) Remove unused vars char_cp, n_output.
6600 (read_ps_encodings) Remove unused var ep.
6601 (postopen) Remove unused var title.
6602 (preclose) Remove unused var fp.
6603 (ps_open_page) Remove unused vars true, false, orientation,
6604 mirror_horz, mirror_vert, width, length.
6605 (ps_text_metrics) Remove unused var x.
6607 * q2c.c: (find_symbol) Remove unused var y.
6608 (parse_setting) Remove unused parameter sbc, all references
6610 (dump_parser) Remove unused var cp.
6611 (dump_free) Remove unused var i.
6613 * set.q: (static vars args, n) Removed.
6614 (internal_cmd_gset) Removed.
6616 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
6617 (read_machine_flt64_info) Removed unused var file_endian.
6618 (read_documents) Removed unused var i.
6619 (read_compressed_data) Removed unused parameter dict, all
6622 * sfm-write.c: (bufwrite) Removed unused var i.
6623 (sfm_write_case) Removed unused var i.
6625 * sort.c: (merge_once) Remove unused var t.
6626 (write_separate) #if 0 out as dead code.
6628 * split-file.c: (cmd_split_file) Remove unused var i.
6630 * sysfile-info.c: (sysfile_info_dim) New function.
6631 (cmd_sysfile_info) Fix table dimensioning.
6632 (variables_dim) New function.
6633 (display_variables) Fix table dimensioning.
6634 (describe_variable) Remove unused var prev_r.
6636 * t-test.q: (z_postcalc) Removed.
6637 (pairs_calc) Remove unused var bad_weight.
6638 (postcalc) Remove unused vars dfn, dfd.
6640 * tab.c: (tab_create) Set t->dim to NULL.
6641 (tab_dim) Make sure t->dim is NULL first.
6642 (tab_natural_width) Remove parameter `clamp'.
6643 (tab_value) Remove duplicate assertion for table.
6644 (tab_raw) New function.
6645 (nowrap_dim) New function.
6646 (wrap_dim) New function.
6647 (tab_output_text) Fix table dimensioning.
6649 * tab.h: (tab_raw) New macro.
6651 * val-labs.c: (get_label) Remove unused var type.
6652 (copy_value_labels) Remove unused var trav.
6654 * var.h: (struct crosstab_proc) Completely changed.
6656 * vars-prs.c: (parse_dict_variable) Remove unused var v.
6658 * vfm.c: (open_active_file) Remove unused vars i, lp.
6660 * weight.c: (weight_trns_proc) #if 0 out as dead code.
6662 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
6664 * Makefile.am: Add apply-dict.c, flip.c.
6666 * apply-dict.c: New file.
6668 * command.c: (struct command) Make cmd[] larger for CLEAR
6669 TRANSFORMATIONS command name.
6670 (parse_cmd) Make sure we're in a valid state before using it as an
6671 index. Discard variables and reset state on invalid transitions.
6672 (cmd_clear_transformations) New function.
6674 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
6675 Add unimplemented PRESERVE, RESTORE.
6677 * file-handle.h: Include stddef.h.
6681 * pfm-read.c: (parse_value) Pad value label values with spaces,
6684 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
6685 (sfm_close) Decrement reference count, make sure it's zero.
6686 (sfm_maybe_close) New function.
6687 (sfm_read_dictionary) Handle reference counts.
6689 * vars-atr.c: (clear_default_dict) New function.
6690 (discard_variables) Use clear_default_dict().
6692 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
6694 * Makefile.am: Add pfm-write.c.
6695 (LDADD) Add the libgmp2 libraries.
6697 * command.def: Define EXPORT.
6699 * get.c: (cmd_export) New function.
6700 (export_write_case_func) New function.
6702 * pfm-read.c: (static spss2ascii[]) Make it const.
6704 * pfm-write.c: New file.
6706 * sfm-write.c: Formatting, comment fixes.
6708 * var.h: Comment fix.
6710 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
6712 * Makefile.am: Add pfm.h, pfm-read.c.
6714 * command.def: IMPORT is now implemented.
6716 * format.c: (glob var translate_fmt[]) New var.
6718 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
6719 (cmd_import) New function.
6720 (import_source_read) New function.
6721 (glob var import_source) New var.
6723 * pfm-read.c: New file.
6727 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
6729 (dump_dictionary) Disabled printing a couple of items.
6731 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
6733 * crosstabs.q: (postcalc) Call make_summary_table().
6734 (make_summary_table) New function.
6735 (insert_summary) New function.
6736 (display_dimensions) Remove some unnecessary arguments, all
6738 (output_pivot_table) Fix lots of problems with the risk table
6740 (submit) Don't display an empty table.
6741 (display_risk) Fix order of arguments to calc_risk().
6743 * glob.c: Always include assert.h and stdlib.h.
6745 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
6748 * tab.c: (tab_create) Cosmetic changes.
6750 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
6752 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
6756 * crosstabs.q: (output_pivot_table) Headers drawing and submission
6757 code simplified, moved into new function submit().
6758 (submit) New function.
6759 (crosstabs_dim) New function.
6760 (display_directional) Substitute variable names for %s where
6762 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
6763 (calc_symmetric) Initialize parameters only if non-NULL.
6764 Calculate Somers' d.
6765 (calc_directional) Calculate Somers' d (or copy it, really).
6768 * output.c: (outp_string_width) New function.
6770 * postscript.c: (postopen) Calculate font widths based on the
6771 width of the zero '0' character, not the width of the space
6772 character. Set paper-width and paper-length based on points, not
6774 (ps_open_page) Fix page setup string for landscape mode.
6776 * som.h: (struct som_dimension) Removed.
6777 (struct som_table_class) height, width members take int * not
6780 * tab.c: Many functions now have added parameter validation.
6781 (tab_height, tab_width) These functions were removed and merged
6782 into a single function tab_resize(), and all references changed.
6783 (tab_dim) Rewritten since the interface changed; reduced from
6784 hundreds of lines to two. All callers were changed. Currently
6785 most of them just use tab_natural_dimensions as their callback and
6786 await detailed translation of functionality.
6787 (tab_natural_width) New function.
6788 (tab_natural_height) New function.
6789 (tab_natural_dimensions) New function. This is a callback
6790 function, not something that you'd want to call directly.
6791 (tab_nat_dim) Removed.
6792 (tabi_table) Allocates t->w and t->h.
6793 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
6794 dimensions callback.
6795 (evaluate_dimensions) Removed.
6796 (sum_columns) Removed.
6798 * tab.h: (enum TAL_1THIN) Removed.
6799 (enum series t_*) Removed.
6800 (struct tab_table) Members trh, trv changed to unsigned char *
6801 from int *. Member dim changed to a function pointer from a
6802 unsigned char *. Member max_stack_height removed. New members
6804 (macros tab_l, tab_r, tab_t, tab_b) New.
6806 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
6808 * ascii.c: (delineate) Assign last_space_nchars before skipping
6809 spaces, to fix right justification.
6811 * crosstabs.q: (static vars risk, direct) New vars.
6812 (static var pearson_r) Removed.
6813 (glob var chisq_fisher) Made static.
6814 (static vars row_tot[], col_tot[]) Don't include grand total
6816 (static var grand_total) Renamed W, all references changed.
6817 (output_pivot_table) Only make `table' if num_cells != 0. Make
6818 risk and directional tables. Deal with grand total no longer part
6819 of col_tot[]. Free rows and cols after we're done with them.
6820 (display_risk) New function.
6821 (display_directional) New function.
6822 (clac_r) Rewritten so that it stores all its results into its
6823 arguments, so it can be used for Spearman's correlation too.
6824 (calc_symmetric) Added a t[] argument, all references changed.
6825 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
6826 Pearson's r, Cohen's kappa.
6827 (calc_risk) New function.
6828 (calc_directional) New function.
6830 * som.c: (som_submit) Improved debugging code.
6832 * stats.c: (hypercube) New function.
6833 (cube) New function.
6835 (normal_sig) Went back to old implementation, which actually
6838 * stats.h: (macros square, cube, hypercube) Removed. The
6839 equivalent functions in stats.c are inlined here; all references
6840 to square changed to sqr.
6842 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
6844 * crosstabs.q: (N_SYMMETRIC) New define.
6845 (postcalc) Disable debug printing.
6846 (static vars chisq_fisher, pearson_r) New.
6847 (output_pivot_table) Add support for symmetric measures. Add
6848 chi-square output of exact sigs.
6849 (display_chisq) Rewritten.
6850 (display_symmetric) New function.
6851 (gamma_int) New function.
6853 (swap) New function.
6854 (calc_fisher) New function.
6855 (calc_chisq) Check boundary conditions better. Calculate Yates,
6856 Fisher, Mantel-Haenszel tests.
6857 (calc_r) New function.
6858 (calc_symmetric) New function.
6860 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
6862 (chisq_sig) Better boundary conditions. Renamed from
6865 * tab.h: (struct tab_table) New member cf.
6867 * tab.c: (tab_create) Set cf.
6868 (tab_width) New function.
6869 (tab_realloc) Handle cf.
6870 (tab_vline) Handle cf.
6871 (tab_hline) Handle cf.
6872 (tab_box) Handle cf.
6873 (tab_value) Handle cf.
6874 (tab_float) Handle cf.
6875 (tab_text) Handle cf.
6876 (tab_joint_text) Handle cf.
6877 (tab_offset) Handle cf.
6878 (tab_next_row) Handle cf.
6879 (evaluate_dimensions) Handle cf.
6880 (render_strip) Handle cf.
6882 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
6884 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
6885 output_pivot_table().
6886 (output_pivot_table) Moved lots of local variables outside and
6887 made them static. Add beginnings of chi-square statistic
6888 support. Now column and row totals aren't in the main matrix.
6889 Always zero out any leftover rows & columns after we're done with
6890 the table entries. Move all output stuff into
6891 display_dimensions(), display_crosstabs(), display_chisq().
6892 (display_dimensions) New function.
6893 (display_crosstabulation) New function.
6894 (display_chisq) New function.
6895 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
6897 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
6898 references, simplify logic.
6900 * postscript.c: Remove scale, translate-x, translate-y,
6901 mirror-horz, mirror-vert, rotate-180 options.
6902 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
6903 All references deleted.
6904 (macro YT) New macro.
6905 (array option_tab[]) Removed options.
6906 (ps_option) Removed options.
6907 (ps_open_page) Write page setup explicitly to output file, without
6908 using now-deleted BP function.
6909 (macro dump_line) Use YT().
6910 (macro dump_thick_line) Use YT().
6911 (draw_headers) Use YT().
6912 (switch_font) Reorder arguments to SF function.
6913 (write_text) Use YT().
6915 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
6918 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
6920 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
6921 null-debugging code.
6922 (tab_realloc) Remove null-debugging code. Initialize new regions
6924 (tab_vline) Support offsets.
6925 (tab_hline) Support offsets.
6926 (tab_box) Support offsets.
6928 (tab_nulls) Removed.
6931 (evaluate_dimensions) Remove null-debugging code. Understand
6932 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
6933 TAB_EMPTY not present.
6935 * tab.h: New cell attribute TAB_EMPTY.
6936 (macros tab_nr, tab_nc, tab_row, tab_col) New.
6938 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
6939 try to read them from system files.
6941 * vfm.c: (dump_splits) Don't call tab_null().
6943 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
6945 * crosstabs.q: (struct crosstab) Added `missing' member.
6946 (custom_tables) Init missing.
6947 (calc_general) Handle missing values.
6948 (calc_chisq) New function.
6949 (output_pivot_table) Start work on chi-square output. Update for
6950 new tab offset support functions. Shorten statistic names.
6952 * Several files: add in more `const's to placate gcc's warnings.
6954 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
6957 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
6958 tab_null, tab_nulls, tab_value, tab_float, tab_text,
6959 tab_joint_text) Add col_ofs and row_ofs support.
6960 (tab_offset) New function.
6961 (tab_next_row) New function.
6962 (tab_row) New function.
6963 (tab_col) New function.
6964 (tabi_table) Add col_ofs and row_ofs support.
6966 * vars-atr.c: (is_system_missing) New function.
6968 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
6970 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
6971 (static var no_cells) Removed.
6972 (static var num_cells) New.
6973 (static var expected) New.
6974 (static var cells[]) New.
6975 (internal_cmd_crosstabs) Deal with new variables.
6976 (postcalc) Removed most of the meat and put it in new function
6977 output_pivot_table().
6978 (output_pivot_table) Calculates and outputs an entire pivot table.
6980 * postscript.c: (postopen) Fix problems with free()ing addresses
6981 not obtained from malloc().
6983 * som.c: (som_submit) Add assertion.
6985 * sysfile-info.c: (describe_variable) Use new tab_nulls()
6988 * tab.c: (static var tab_names[]) New.
6989 (tab_realloc) -1 for nc or nr indicates no change.
6990 (tab_nulls) New function.
6991 (tab_dim) Use tab_names[].
6992 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
6993 (evaluate_dimensions) Don't terminate on uninited cells, just put
6994 an X in them and emit a notice. Use tab_names[].
6996 * tab.h: Move bits into tab.def.
6998 * tab.def: New. Don't try to declare tab_table_class because then
6999 som.h has to be included.
7001 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
7003 * command.def: New file, contains all the command definitions
7004 previously included bodily in command.c.
7006 * format.def: New file, contains all of the format definitions
7007 previously split across format.h, format.c, and sfm-write.c.
7009 * lexer.h: Renamed from tokens.h in order to match corresponding
7012 * lexerP.h: Moved some rarely used functions exported by lexer.c
7015 * Makefile.am: Commemorate renamed files.
7016 (EXTRA_DIST) Add command.def, format.def.
7018 * command.c: [0] (walk_cmdtable_func) Removed.
7020 * crosstabs.q: (postcalc) Made it work and print out matrices
7022 (enum_column_values) Renamed enum_var_values, generalized for any
7025 * format.h: (struct fmt_desc) New member `spss'.
7027 * q2c.c: (main) Generated code includes lexer.h instead of
7030 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
7031 instead of an independent translation table.
7033 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
7035 * Lots of source files: Added const to declarations.
7037 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
7039 * arena.c: (arena_clear) Set prev pointer to null when done.
7041 * ascii.c: (ascii_option) Rename index as indx.
7043 * avl.c: This is now a separate library called libavl.
7044 (xmalloc) Make static.
7045 (avl_probe) Step A7 can use the cache instead of an explicit
7047 (avl_delete) Don't maintain a q pointer because it's always
7048 available in the pointer stack. Comment fix.
7050 * avl.h: This is now a separate library called libavl.
7052 * command.c: (cmd_table[]) Remove spurious trailing "".
7054 * common.h: Only include random() fix if this system needs it.
7056 * crosstabs.q: Include alloca headers.
7057 (n_sorted_tab) New global var.
7058 (postcalc) Mostly rewritten.
7059 (find_pivot_extent) Rewritten.
7060 (enum_column_values) Rewritten.
7062 * data-out.c: (convert_F) Rename inner n as n_spaces.
7064 * error.c: (dump_message) Don't have an outer var i.
7066 * file-handle.q: (static var f) Removed. All references removed.
7067 (internal_cmd_file_handle) Uses a local variable instead of f.
7069 * get.c: (trim_dictionary) Change scope of i, i1, i2.
7070 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
7073 * getline.h: Declare getl_history as extern. Reported by
7074 palme@uni-wuppertal.de (Hubert Palme).
7076 * postscript.c: (postopen) Some large mods for constness.
7078 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
7081 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
7083 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
7084 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
7087 * avl.c, avl.h: New files. These form a clean-room
7088 reimplementation of avllib. Iterative algorithms are used in
7089 place of recursive ones, so there is no resemblance in the code.
7091 * Lots of headers: Don't include other headers by default.
7093 * Lots of source files: Explicitly include all needed headers.
7095 * arena.c: (arena_clear) New function.
7097 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
7098 (static var ar) Removed.
7099 (staitc vars ar_tc, ar_col) New.
7100 (cmd_crosstabs) Destroy the arenas.
7101 (internal_cmd_crosstabs) Create the arenas.
7102 (precalc) Don't need a free function for the hash.
7103 (calc_general) Make sure to zero out the trailer on the key data
7105 (print_table_entries) Updated.
7106 (postcalc) Worked on actually implementing.
7107 (find_pivot_extent) New function.
7108 (compare_value) New function.
7109 (enum_column_values) New function.
7111 * data-in.c: (parse_month) Make local array `static const'.
7113 * data-out.c: (convert_date) Make local array `static const'.
7114 (convert_WKDAY) Same.
7115 (convert_MONTH) Same.
7117 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
7118 been renamed to avl_walk().
7120 * hash.c: Rewritten more efficiently.
7122 * hash.h: Add attribute const to hsh_next_prime declaration.
7124 * lexer.c: (id_match) Make arguments const.
7126 * postscript.c: (ps_postopen_driver) Make default fonts the
7129 * q2c.c: (main) Generated code needs stdlib.h.
7131 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
7132 initialized to 0 now, not to NULL. All other references to
7133 avl_traverser were updated in the same way.
7135 * tokens.h: Macro version of id_match updated to use const
7138 * val-labs.c: (inc_ref_count) New function.
7139 (copy_value_labels) Simply through use of new avl_copy() function.
7141 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
7143 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
7144 (postcalc) Worked on this.
7146 * postscript.c: (OPO_DOUBLE_LINE) New enum.
7147 (struct ps_driver_ext) New line_width_thick member.
7148 (ps_preopen_drive) Init line_width_thick.
7149 (option_tab[]) Add line-* options.
7150 (ps_option) Parse line-* options.
7151 (postopen) Add line_width_thick support. Strip leading spaces on
7152 prologue output lines.
7153 (ps_open_page) Include line_width_thick in output.
7154 (macro dump_thick_line) New.
7155 (dump_fancy_line) Support thick lines as well as double lines.
7157 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
7159 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
7160 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
7162 * Many source files: Rename `options' to `pv_opts' as appropriate.
7164 * command.c: (static var cmd_table[]) Add CROSSTABS command.
7166 * common.c: (xcalloc) New function.
7168 * crosstabs.q: New file. Not finished yet, though.
7170 * data-list.c: Comment fix.
7172 * error.c: Remove some old Checker cruft.
7174 * frequencies.q: (dump_full) Cumulate valid percent instead of
7177 * getline.c: Comment fix.
7179 * hash.c: Comment fixes.
7181 * hash.h: (struct hsh_table) Make hash functions return unsigned
7182 instead of int to avoid problems with taking the modulo of
7183 negative return values. All references changed.
7185 * misc.c: (intlog10) Make its table static const instead of auto.
7187 * sfm-read.c: (read_header) Make `prefix' static const instead of
7190 * var.h: (union value) Add member `hash'.
7191 (struct variable) Rename prv_index as `foo'--all references
7193 (typedef pv_opts) Removed. All references changed.
7195 * vars-prs.c: (parse_variables) Message fixes.
7197 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
7199 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
7200 they are being inserted. Don't check for BY variables of
7201 different types. Discard variables if the active file isn't
7202 included in the merge.
7203 (mtf_processing) Essentially rewritten.
7204 (mtf_merge_dictionary) Check for master/slave variables of
7205 different types/widths.
7207 * vfm.c: (static var not_canceled) New var.
7208 (process_active_file) Don't call vfm_source->read() if
7209 there's no vfm-source. Initialize not_canceled.
7210 (process_active_file_write_case) Honor and update not_canceled.
7211 (prepare_for_writing) Rollback changes from yesterday, they were
7213 (close_active_file) Don't destroy vfm_source unless it exists.
7215 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
7217 * Lots of source files: Added { } around nested if/else constructs
7218 to avoid new gcc 2.8 warnings.
7220 * data-in.c: (parse_Z) Declare `int' type explicitly.
7223 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
7224 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
7225 prev members. Put TABLEs at the end of the chain and FILEs at the
7226 beginning. Don't allow the active file in STATE_INIT. Use proper
7227 `seen' value for the active file. Fill out the by members and
7228 make sure they're of consistent type. Do the actual merge
7230 (mtf_processing_finish) New function.
7231 (var_type_description) New function.
7232 (mtf_free_file) New function.
7233 (mtf_free) Rewritten.
7234 (mtf_delete_file_in_place) New function.
7235 (mtf_read_nonactive_records) New function.
7236 (mtf_compare_BY_values) New function.
7237 (static var mtf_seq_no) New var.
7238 (mtf_processing) New function.
7239 (mtf_merge_dictionary) Assign nval members for the system file
7240 dictionary. Assign fv values for its variables. Point each slave
7241 variable to the corresponding master variable.
7243 * hash.c: Include str.h.
7245 * mis-val.c: (copy_missing_values) src arg is const.
7247 * misc.c: (spacing) Make `max' var explicitly int.
7249 * sfm-read.c: (dump_dictionary) Message reformatting.
7250 (sfm_read_case) Add assertion.
7252 * sort.c: Esthetic fixes.
7254 * var.h: (struct match_files_proc) New struct.
7255 (struct variable) Add private data match_files_proc.
7257 * vars-atr.c: (delete_variable) Implement. Add argument for the
7258 dictionary that owning the variable.
7259 (dup_variable) Add assertion.
7261 * vfm.c: Comment fixes, hopefully the comments are correct now.
7262 (process_active_file) New function.
7263 (process_active_file_write_case) New function.
7264 (process_active_file_output_case) New function.
7265 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
7267 (write_case) Renamed procedure_write_case(). Now write_case is a
7268 pointer to a function. Style fixes.
7270 1998-03-05 Ben Pfaff <blp@gnu.org>
7272 * Makefile.am: (q2c) Link with libmisc.
7273 (version.c) Define default_config_path, include_path,
7276 * ascii.c: (ascii_postopen_driver) When the default newline string
7277 is requested, open file in text mode. Suggested by
7278 palme@uni-wuppertal.de (Hubert Palme).
7279 (static vars line_buf, line_p) Change from char * to unsigned char
7281 (ascii_close_page) char * to unsigned char *.
7283 * cmdline.c: (parse_command_line) Implement -r option by
7284 prepending ~/.pspp/rc to the list of files to process.
7286 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
7287 before pulling in a final line.
7288 (null_func, null_int_func) Removed (dead code).
7290 * descript.q: (display) Calculate width of variable name column
7291 properly. Calculate number of valid cases properly. Reported by
7292 palme@uni-wuppertal.de (Hubert Palme).
7294 * filename.c: (init_filename) Use default_config_path instead of
7295 now obsolete CONFIG_PATH.
7297 * getline.c: (getl_initialize) Use include_path instead of now
7298 obsolete INCLUDE_PATH.
7299 (getl_add_file) New argument `where'. All references changed.
7301 * groff.c: (find_font_file) Use groff_font_path instead of now
7302 obsolete GROFF_FONT_PATH.
7304 * postscript.c: (find_ps_file) Use groff_font_path instead of now
7305 obsolete GROFF_FONT_PATH. Copy through temporary variable to
7306 avoid problems with constness.
7308 * str.h: (macro cs_streq) New macro.
7310 * version.h: (glob var default_config_path, include_path,
7311 groff_font_path) New vars.
7313 1998-02-23 Ben Pfaff <blp@gnu.org>
7315 * Many source files: Change verbose_msg() priority levels and
7318 * aggregate.c: Include debug-print.h.
7320 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
7322 (static var pre_syntax_message) Document --safer/-s and
7325 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
7327 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
7328 because it's not used but it's still copied.
7329 (open_file_r) Remove gratuitous debug message.
7331 * filename.c: (safety_violation) New function.
7332 (open_file) Remove gratuitous debug messages. Don't allow pipe
7333 files if set_safer is set.
7335 * get.c: Turn off debugging.
7337 * getline.c: (getl_add_virtual_file) New function.
7338 (getl_read_line) Add verbose_msg() call for opening new syntax
7340 (getl_perform_delayed_reset) Add a return value describing whether
7341 any action was taken. Call reset_eof().
7343 * getline.h: Comment fix.
7345 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
7346 place of incorrect `continue'. Use strtok_r() instead of
7347 strtok(). Always check strtok_r() return value.
7348 (groff_read_DESC) Use strtok_r() instead of strtok().
7350 * lexer.c: (reset_eof) New function.
7352 * main.c: (parse) Get a token after performing a delayed reset
7353 action; allow empty syntax files.
7355 * postscript.c: (output_encodings) Use strtok_r() instead of
7358 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
7360 * set.q: Comment fixes.
7361 (glob var set_safer) New var.
7362 (internal_cmd_set) Support SAFER.
7364 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
7366 * temporary.c: (free_dictionary) Set d->splits to NULL after
7369 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
7370 variable deleted, not if it *isn't* deleted.
7372 1998-02-16 Ben Pfaff <blp@gnu.org>
7374 * command.c: (array cmd_table[]) Add MATCH FILES.
7376 * common.c: Comment fixes.
7378 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
7379 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
7380 Include alloca.h. Problem reported by palme@uni-wuppertal.de
7383 * expr-opt.c: Include str.h. Problem reported by
7384 palme@uni-wuppertal.de (Hubert Palme).
7386 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
7387 (static var mtf_by) Change from char ** to variable **.
7388 (static var mtf_master) New var.
7389 (mtf_merge_dictionary) New function.
7390 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
7391 var type. Reorder tests properly. Initialize file->dict. Detect
7392 TABLE= without BY=. Read file dictionaries and merge them. Give
7393 subcommand name with IN, LAST, FIRST error messages. Create IN,
7394 LAST, FIRST variables. Comment fixes.
7395 (mtf_free) Don't free default_dict. Free mtf_master.
7397 * getline.c: Define getl_mode. Change getl_buf_size to size_t
7399 (handle_line_buffer) Cast int to size_t in comparison to avoid
7402 * getline.h: Declare getl_mode extern.
7404 * groff-font.c: (groff_read_font) Type-fix calls to getline.
7405 (groff_read_DESC) Make line_size a size_t.
7406 (match_tok) Parenthesize name to avoid macro expansion.
7408 * mis-val.c: (copy_missing_values) New function.
7410 * postscript.c: (postopen) Make buf_size a size_t.
7412 * sfm-read.c: (dump_dictionary) Make global from static. Print
7413 variable info in parts for easier debugging with Checker.
7415 * temporary.c: (copy_variable) Use copy_value_labels().
7416 (new_dictionary) New arg: whether to copy file label, documents.
7418 * val-labs.c: (copy_value_labels) New function.
7420 * var.h: (enums MISSING_*) Add MISSING_COUNT.
7422 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
7424 (dup_variable) Set prv_index, get.fv, get.nv.
7426 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
7428 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
7430 * Many source files: For ANSI-compliance, add empty statement
7431 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
7432 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7434 * data-in.c: (parse_numeric) Some header files break on
7435 -DBL_MIN_10_EXP because they get a --; add () for safety.
7436 Reported by palme@uni-wuppertal.de (Hubert Palme).
7438 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
7439 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
7440 (dfm_close) Use close_file_ext.
7441 (open_inline_file) Set file.file to NULL, not file.
7442 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
7443 struct and use open_file_ext().
7444 (read_record) Use file.file.
7446 * file-handle.q: (prepend_current_directory) Pass through special
7449 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
7450 (normalize_filename) Pass through special filenames.
7451 (open_file, close_file) Accept pipe| and |pipe syntaxes as
7453 (dirname) Rename blp_dirname() because of name conflict on some
7454 OS. All references changed. Reported by palme@uni-wuppertal.de
7456 (is_special_filename) New function.
7458 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
7459 (trim_dictionary) Conditionalize some of the options on whether
7460 GTSV_OPT_MATCH_FILES is in *options.
7461 (rename_variables) Don't allow variables to be renamed as scratch
7463 (MTF_*) New enum series.
7464 (struct mtf_file) New struct.
7465 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
7467 (cmd_match_files, mtf_free) New functions.
7469 * lexer.c: (match_int) Needed parentheses around name to escape
7470 macro expansion. Reported by Micah Altman
7471 <maltman@www-vdc.fas.harvard.edu>.
7473 * print.c: Needed to include alloca.h. Reported by Micah Altman
7474 <maltman@www-vdc.fas.harvard.edu>.
7476 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
7477 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
7480 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
7481 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
7483 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
7485 * html.c: (struct html_driver_ext) Move into htmlP.h.
7486 (html_preopen_driver) Initialize cp_x, cp_y.
7487 (html_submit) Implement as call to output_tab_table().
7488 (change_attributes) New function.
7489 (escape_string) New function.
7490 (output_tab_table) New function.
7492 * list.q: (write_all_headers) Add code for writing headers for the
7494 (clean_up) Write out the html close-table tag.
7495 (determine_layout) Ignore html driver.
7496 (list_cases) Write html data.
7498 * som.c: (som_submit) Move more of the code into output_table().
7500 * tab.c: (static var hit) Make a global var and rename tab_hit.
7501 (static var tab_table_class) Make a global var.
7503 * htmlP.h: New file.
7505 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
7507 * dump-sysfile.c: Removed.
7509 * html.c: (preclose) Change comment in emitted code.
7511 * matrix-data.c: Debugging off by default. Comment fixes.
7512 (static var container) New var.
7513 (cmd_matrix_data) Create and destroy container. Initialize
7514 is_per_factor[] to 0s. Move code into new function
7515 string_to_content_type(). Require split values to be present in
7516 the data when ROWTYPE_ is explicit. Call specific function, not
7517 general read_matrices().
7518 (string_to_content_type) New function.
7519 (context) Exclude all whitespace, not just spaces.
7520 (mget_token) A dot is a number. Add assertion.
7521 (static var data) Renamed nr_data.
7522 (static var factor_values) Renamed nr_factor_values.
7523 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
7524 only specific case. Close data_file before exit.
7525 (fill_matrix) New function.
7526 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
7527 printing. Style fixes. Message fixes. Move code into
7529 (read_matrices_without_rowtype) Rename
7530 matrix_data_read_without_rowtype(). Fix off-by-one error on
7531 loops. Allocate nr_data[] memory from arena.
7532 (read_matrices_with_rowtype) Removed.
7533 (read_splits) Renamed nr_read_splits(). Style fixes.
7534 (read_factors) Renamed nr_read_factors().
7535 (dump_cell_content) Comment fixes. Arguments changed. Change
7536 debug printing. All references changed.
7537 (output_data) Renamed nr_output_data().
7538 (static var wr_content) New var.
7539 (struct factor_data) New struct.
7540 (static var wr_data) New var.
7541 (static var wr_current) New var.
7542 (matrix_data_source_destroy_source) Removed.
7543 (read_matrices_with_rowtype) New function.
7544 (matrix_data_read_with_rowtype) New function.
7545 (wr_read_splits) New function.
7546 (compare_factors) New function.
7547 (wr_output_data) New function.
7548 (wr_read_rowtype) New function.
7549 (wr_read_factors) New function.
7550 (wr_read_indeps) New function.
7551 (glob var matrix_data_source) Make destroy_source member NULL as
7554 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
7556 * lexer.c: (syntax_error) Give better error message when at end of
7559 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
7560 N_SCALAR to output as plain N.
7561 (mdump_token) Change output format.
7562 (context) Fix message output interaction with spaces in input.
7563 (another_token) New function.
7564 (force_eol) Improved error message.
7565 (static var max_cell_index) New var.
7566 (read_matrices) Init `cells'. factor_values is now per-cell.
7567 Init max_cell_index.
7568 (read_data_lines) Replace `compare' local with new `compare' arg.
7569 Debugging messages changed. Only read factors if per_factor.
7570 Propagate error return from read_factors(), force_eol().
7571 Copy N_SCALAR values across the N vector.
7572 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
7573 check parentheses manually since we now have is_per_factor[].
7574 Call read_data_lines() with new args. Check for end of data after
7575 looping, using another_token().
7576 (read_factors) Arguments changed. Use max_cell_index to determine
7577 whether to read or compare factors. Message fixes.
7578 (dump_cell_content) New function.
7579 (output_data) Completely rewritten because content types were
7580 supported to be nested inside factor values, not vice versa.
7582 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
7584 * lexer.c: (syntax_error) Support formatted varargs messages.
7586 * matrix-data.c: Turn debugging on by default.
7587 (static content_type[]) New array.
7588 (static content_names[]) New array.
7589 (static rowtype_, varname_) New vars.
7590 (static is_per_factor[]) New array.
7591 (static split_values) Moved declaration.
7592 (static n_continuous, first_continuous) New var.
7593 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
7594 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
7595 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
7596 Check for continuous variables.
7597 [DEBUGGING] (debug_print) Remove content_names[].
7598 (mdump_token) New macro.
7599 (mget_token_dump) New function.
7600 (mdump_token) New function.
7601 (context) New function.
7602 (mget_token) Fix messages.
7603 (static var data, split_values, factor_values) New vars.
7604 (read_matrices) Manage split_values, factor_values.
7605 (read_data_lines) New function.
7606 (read_matrices_without_rowtype) Implemented.
7607 (read_splits) Message fixes. Uses `just_read'.
7608 (read_factors) New function.
7609 (output_data) New function.
7610 (matrix_data_source_destroy_source) Close the file handle.
7611 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
7614 * str.c: (strpadcmp) Removed.
7616 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
7618 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
7620 * Lots of source files: Add cast to unsigned character to calls to
7621 tolower() and toupper().
7623 * aggregate.c: Set default_dict.splits to NULL.
7625 * command.c: (static variable tab[]) Add MATRIX DATA.
7627 * data-in.c: Add debugging defines. Formatting fixes.
7629 * expr-opt.c: Formatting fixes.
7631 * lexer.c: (syntax_error) Message fixes.
7633 * matrix-data.c: New enum series.
7634 (static vars fmt, section, diag, explicit_rowtype, signle_split,
7635 split_values, n_factors, factors, cells, pop_n, contents,
7636 n_contents) New vars.
7637 (cmd_matrix_data) Finished implementation.
7638 (compare_variables_by_mxd_vartype) New function.
7639 [DEBUGGING] (debug_print) New function.
7640 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
7641 (read_matrices) New function.
7642 (read_matrices_without_rowtype) New function.
7643 (read_matrices_with_rowtype) New function.
7644 (read_splits) New function.
7645 (mget_token) New function.
7646 (force_eol) New function.
7647 [0] (test_tokenizer) New function.
7648 (matrix_data_source_destroy_source) New function.
7649 (glob var matrix_data_source) New var.
7651 * misc.h: Include ieeefp.h if present.
7653 * split-file.h: (cmd_split_file) Changes corresponding to struct
7656 * str.h: Fix memmem prototype.
7658 * temporary.c: (save_dictionary, restore_dictionary,
7659 free_dictionary) Changes corresponding to struct dictionary
7662 * var.h: (MXD_* enums) New enum series.
7663 (struct matrix_data_proc) New struct.
7664 (struct split) Removed.
7665 (struct dictionary) Changed `splits' member from `split *' to
7667 (macro force_create_variable) New macro. Replaced lots of
7668 create_variable()/assert() calls with calls to this macro.
7670 * vars-atr.c: (discard_variables) Changed assertion.
7671 [GLOBAL_DEBUGGING] (force_create_variable) New function
7672 called by the macro of the same name.
7673 (clear_variable) Changes to delete splits from the dictionary
7674 corresponding to struct dictionary changes.
7676 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
7677 corrupted variable `index' values in the dictionary passed in
7678 every time this function is called.
7680 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
7681 to struct dictionary changes.
7683 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
7685 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
7687 * command.c: New includes.
7688 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
7689 (cmd_erase) New function.
7690 [unix] (shell) New function.
7691 (run_command) New function.
7692 (cmd_host) New function.
7693 (cmd_new_file) New function.
7695 * expr-prs.c: (parse_primary) Message fix.
7697 * inpt-pgm.c: Formatting fix.
7698 (cmd_reread) Implement the FILE subcommand.
7700 * matrix-data.c: New file.
7702 * q2c.c: (dump_header) Change output commenting style.
7704 * weight.c: Comment fix.
7706 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
7708 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
7710 (buf_10x) Renamed buf_1xx, all references changed.
7711 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
7712 cases now implemented).
7713 (create_sysfile) New function.
7714 (agr_11x_func) New function.
7716 * data-in.c: (parse_numeric) Work properly if there's an
7717 explicitly coded decimal point in the data and decimal places are
7718 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
7719 <el@linux.lisse.na>.
7721 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
7722 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
7723 Eberhard W Lisse <el@linux.lisse.na>.
7725 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
7726 strerror.c. Bug reported by Alexandre Oliva
7727 <oliva@dcc.unicamp.br>.
7729 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
7730 (static var separate_case_tab) New var.
7731 (cmd_sort_cases) Cancel temporary transformations here. Free
7732 v_sort before return.
7733 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
7734 we're reading from a sort stream. Don't cancel temporary
7735 transformations. Offload internal sorting to do_internal_sort().
7736 (do_internal_sort) New function. Handles internal sorting even
7737 when SEPARATE is nonzero. Doesn't free v_sort.
7738 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
7740 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
7741 sink if SEPARATE is zero.
7742 (read_output_cases) Renamed read_sort_output(), all references
7743 changed. Now uses separate_case_tab when it exists.
7744 (write_separate) New function.
7746 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
7747 memory_sink_cases. Don't redundantly call
7748 vfm_source->destroy_source().
7749 (memory_stream_mode) After switching over, set memory_sink_cases
7752 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
7754 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
7756 (static var prev_case) New, moved out of aggregate_single_case()
7758 (static var buf64_10x, buf_10x) New.
7759 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
7760 the 000, 001, 100, and 101 cases. Free prev_case.
7761 (parse_aggregate_functions) Disallow scratch variables.
7762 (free_aggregate_functions) Only free agr_dict if non-null. Use
7763 iter->function to determine numeric/string type, not
7765 (aggregate_single_case) Don't manage prev_case. Initialize
7766 aggregate info after dumping it.
7767 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
7768 mean, stddev, weighted stddev definitions.
7769 (dump_aggregate_info) Implemented.
7770 (initialize_aggregate_info) Renamed from
7771 initialize_aggregate_functions(). Initializes dbl[2].
7772 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
7773 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
7775 * cases.c: (alloc_val) Removed.
7777 * get.c: (cmd_save_internal) Initialize new `dict' member.
7779 * sfm-write.c: (sfm_write_dictionary, write_header,
7780 write_variable, write_value_labels, write_documents) Reorganize,
7781 simplify for new parameter structure.
7782 (write_variable) Only one variable * argument now.
7784 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
7785 replaced by new `dict' member.
7787 * temporary.c: (new_dictionary) Initialize n_documents.
7789 * vars-atr.c: (dup_variable) Allocate `value's from dict into
7791 (init_variable, replace_variable) Eliminate usage of alloc_val().
7793 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
7795 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
7796 signal that AGGREGATE is to be used for forming final cases.
7797 (close_active_file) Call end_func before stopping lagging. Cancel
7798 temporary after finishing compaction.
7799 (write_case) Comment fixes. Cleaned up.
7800 (compact_case) Let AGGREGATE handle compaction when `temporary' is
7803 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
7805 * Makefile.am: (BUILT_SOURCES) Add means.c.
7806 (pspp_SOURCES) Add means.c.
7807 (EXTRA_DIST) Add means.q.
7809 * command.c: (array cmd_table[]) Add MEANS.
7811 * common.h: Esthetic fixes. Comment fixes. Test for
7812 MAX_SHORT_STRING greater than 8.
7813 (macros LOWEST, HIGHEST) New.
7815 * data-in.c, data-list.c, recode.c: Comment fixes.
7817 * means.q: New file, base version.
7819 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
7820 with LOWEST, DBL_MAX with HIGHEST.
7822 * q2c.c: (dump_vars) Add an enum to array types giving the number
7823 of values for the enum.
7825 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
7826 Replace second_lowest_value with second_lowest_flt64.
7828 * sfm-write.c: (write_variable, write_rec_7_34) Replace
7829 second_lowest_value with second_lowest_flt64.
7831 * t-test.q: Comment fix.
7833 * temporary.c: (restore_dictionary) Esthetic fix.
7835 * tokens.h: (force_match_id, force_match, force_string, force_int,
7836 force_num, force_id) Replace msg() with syntax_error().
7838 * var.h: (struct means_proc) New.
7839 (struct variable) Add mns member to `p' union.
7841 * vars-prs.c: (parse_variable, parse_dict_variable,
7842 parse_variables, parse_DATA_LIST_vars) Replace msg() with
7845 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
7847 * Makefile.am: (pspp_SOURCES) Add tab.h.
7849 * Most source files: Added a cast to unsigned char in usages of
7850 the ctype is*() functions. Replaced `end of command expected'
7851 calls to msg() with calls to syntax_error().
7853 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
7855 * lexer.c: (hex_val) Removed (was dead code).
7856 (idmatch) Parenthesize function name to avoid macro expansion.
7858 * postscript.c: Comment fixes.
7859 (ps_preopen_driver) Change default font size to 10pt.
7861 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
7863 (parse_format_spec) Change system-file format spec argument type
7864 to int32. Parse the format spec with bitwise operators.
7866 * sfmP.h: (struct sysfile_format) Removed.
7867 (struct sysfile_variable) Changed print, write members from
7868 sysfile_format to int32.
7870 * tokens.h: Esthetic fixes.
7871 [__GNUC__] (macro id_match) New macro to hopefully speed up
7872 identifier matching.
7873 (macros match_id, match_tok, match_int) Implemented in
7874 compiler-independent manner; no longer GNU C only.
7876 * vfm.h: Include time.h.
7878 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
7880 * data-list.c: (dump_fixed_table) Change tab_dim().
7882 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
7884 * error.c: Include command.h.
7886 * frequencies.g: Formatting fixes.
7888 * frequencies.q: Add tab_dim() calls. Make the total cell a
7891 * glob.c: Include command.h.
7893 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
7895 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
7896 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
7897 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
7898 the other elements (is this right?).
7899 (read_variables) Use lowest, highest members.
7900 (parse_format_spec) New arg `vv' for more stringent checking.
7901 (dump_dictionary) Byteswaps nonexplicit data.
7902 (sfm_read_case) Byteswap numeric data.
7904 * som.c: Initialize table_num to 1.
7905 (render_segments) Remember to increment y_index after each table
7908 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
7909 avl_count() on a NULL tree. No title for the second table.
7910 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
7911 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
7912 fix call to display_variables().
7913 (display_variables) Default to 4 columns, not 3. Set up headers.
7914 Column title is Variable, not Name. Fix index column.
7915 Add joint text. Add tab_dim(). Handle value labels properly.
7916 Handle DISPLAY LABELS properly. Draw boxes correctly.
7917 (describe_variable) Value labels don't need titles. Don't clear
7918 nonexistent index column.
7919 (compare_vectors_by_name) New function.
7920 (display_vectors) New function.
7922 * tab.c: (tab_height) Add assertion.
7923 (tab_null) Add debug code.
7924 (evaluate_dimensions) Add debug code.
7926 * var.h: (struct variable) get_proc data is sometimes used
7927 simultaneously with other per-procedure info, therefore it was
7928 removed from the union. All references changed.
7930 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
7932 * ascii.c: (ascii_close_page) Put title on second line of headers
7933 if there is no subtitle.
7935 * command.c: (glob var cur_proc) Move definition here, from
7937 (cmd_remark) Emit blank line before remarks.
7939 * command.h: (glob var cur_proc) Move declaration here, from
7942 * data-list.c: (dump_fixed_table) Fix messages.
7943 (dump_free_table) Call tab_nat_dim().
7945 * descript.q: (dump_z_table) Modify tab_dim() call.
7947 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
7949 (dump_statistics) Don't output header.
7951 * groff-font.c: Minor format fix.
7953 * html.c: Comment fix.
7955 * list.q: (write_varname) Indent after advancing page.
7957 * output.h: Minor reordering.
7959 * postscript.c: Comment fixes. Many places, '\n' was replaced by
7960 a reference to eol[].
7961 (struct ps_driver_ext) New member eol[].
7962 (ps_preopen_driver) Initialize eol[].
7963 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
7964 defaults. Handle headers. Fix test for minimum page length.
7965 (static var option_tab[]) Add `line-ends'.
7966 (ps_option) Handle line-ends to change eol[].
7967 (postopen) Scale prop_em_width and fixed_width properly. Set the
7968 prologue title to outp_title if applicable. Replace the prologue
7969 line ends with eol[]. Call draw_headers() if headers are enabled.
7970 (text_width) New function.
7971 (out_text_plain) New function.
7972 (draw_headers) New function.
7974 * print.c: (dump_table) Call tab_nat_dim().
7976 * som.c: (som_blank_line) Only advance a line if not at the top of
7978 (som_submit) Move several informational table calls here.
7979 Increment subtable_num if SOMF_NO_TITLE not set.
7980 (output_table) Advance a line if SOMF_NO_SPACING not set.
7981 (render_columns, render_segments, render_simple) Handle spacing
7982 between tables. Handle table titles. Remove debug output.
7984 * som.h: (SOMF_*) New enum series.
7985 (struct som_table_class) New member `flags'.
7987 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
7989 (display_variables) Calls tab_nat_dim().
7990 (describe_variable) Remove restriction on number of value labels.
7991 Make value labels separated by thin lines.
7993 * tab.c: (tab_create) Default `flags' to none.
7994 (tab_float) New arg `w'. All references changed.
7995 (tab_nat_dim) New function.
7996 (tab_output_text) No title or spacing.
7997 (tab_flags) New function.
7998 (tabi_flags) New function.
7999 (tabi_title) New function.
8000 (strip_height) Removed.
8001 (tabi_render) Skip title when necessary.
8002 (static var tab_tab_class) Add tabi_flags, tabi_title.
8003 (evaluate_dimensions) Disable display of column, row size.
8004 (sum_columns) Add title height to top header.
8005 (render_strip) Moved within file.
8007 * tab.h: (struct tab_table) New member `flags'.
8009 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
8011 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
8013 * Most source files: Add `const' attribute in all appropriate
8016 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
8017 column to the variables table for use by describe_variable().
8018 (cmd_display) Disable for the present.
8019 (display_documents) Don't wrap documents.
8020 (display_variables) Table has four columns now.
8021 (describe_variable) Table has four columns now. Don't use a
8022 subtable, use joined cells instead.
8024 * tab.c: (tab_create) Don't set `join'.
8025 (tab_realloc) ct array is not made up of a_string's.
8026 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
8027 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
8028 (text_format) New function.
8029 (tab_title) Rewritten, uses text_format().
8030 (tab_text) Rewritten, uses text_format().
8031 (tab_joint_text) New function.
8033 (static var hit) New variable.
8034 (render_strip) New args r1, r2. Implement joined cells that fit
8036 (tabi_render) Increment hit. Pass new args to render_strip().
8037 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
8038 cells. For t_naw and t_nah, ignore joined cells and null cells in
8041 * tab.h: (struct tab_join_rect) Removed.
8042 (struct tab_table) Removed `join'.
8043 (TAB_JOIN_MAIN) Removed.
8044 (struct tab_joined_cell) New struct.
8045 (TAT_NOWRAP) New enum.
8047 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
8049 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
8051 (ascii_postopen_driver) Fix initialization of *_spacing so that
8052 the TAL_0 bit doesn't count.
8054 * data-list.c: (dump_fixed_table) Use natural width for Format
8057 * glob.c: (rerange) Removed.
8058 (get_date) Formatting fixes. Internationalization fix.
8060 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
8063 * postscript.c: (ps_postopen_driver) Replace
8064 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
8066 * som.c: (som_submit) Don't eject page before every table.
8067 (output_table) Fix order of arguments on call to area().
8068 (render_columns) Fix calculation of max_len.
8070 * tab.c: (tabi_cumulate) Minor change to increase elegance.
8071 (render_strip) New function.
8072 (strip_height) New function.
8073 (tabi_render) Rewrite as calls to render_strip().
8075 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
8076 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
8077 with the TAB_* and OUTP_T_* constants.
8079 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
8081 * Makefile.am: Formatting fixes.
8083 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
8086 * data-list.c: (dump_fixed_table) Add tab_dim() call.
8088 * descript.q: (dump_z_table, display) Add tab_dim() calls.
8090 * dump-sysfile.c: (glob var length) Make type off_t.
8091 (usage) Fix arguments.
8094 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
8095 Now right-justification is the default so many references had to
8097 (struct outp_class) Removed line_width, all references changed.
8098 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
8099 (struct outp_driver) Add elements horiz_line_width,
8100 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
8103 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
8105 (postopen) Initialize all the informational members of
8108 * som.c: (som_blank_line) New function, renamed from blank_line(),
8109 all references changed.
8110 (som_submit) Disables drivers whose pages can't be opened.
8111 (render_columns, render_simple, render_segments) Add debug output.
8112 (render_columns) Fix loop range.
8113 (render_simple) Don't try to render the headers, they're taken
8114 care of automatically. Advance cp_y past the table when done.
8115 (render_segments) Fix loop ranges.
8117 * tab.c: Initialize new members of tab_table.
8118 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
8119 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
8120 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
8123 (tab_dim) New function.
8124 (tab_col_width) Removed.
8125 (tab_row_height) Removed.
8126 (tab_output_text) Call tab_dim().
8127 (tabi_driver) Call evaluate_dimensions(), sum_columns().
8128 (tabi_area) Implemented.
8129 (tabi_cumulate) Implemented.
8130 (tabi_render) Partially implemented, but broken.
8131 (var tab_table_class) Made static.
8132 (evaluate_dimensions) New function.
8133 (sum_columns) New function.
8135 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
8136 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
8137 t_scr, t_srr, t_sentinel. Removed: t_nat.
8138 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
8139 max_stack_height, w, h. Removed: ce, re.
8140 (macro blank_line) Removed.
8141 (glob var zero_length) Removed.
8143 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
8145 * Most source files: include some of the new include files broken
8148 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
8151 * aggregate.c: (glob var outfile) Make static.
8153 * command.c: (glob var pgm_state) Move here.
8155 * common.c: (glob vars endian, second_lowest_value, pgmname,
8156 finished, curdate, cur_proc, start_interactive, history_file) Move
8159 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
8161 * file-handle.q: (glob vars files, inline_file) Move here.
8163 * glob.c: Lost lots of glob vars, detailed in individual file
8165 (init_glob) set_printer, set_screen were obsolete, deleted.
8166 set_cprompt has fewer spaces because pspp has fewer letters than
8169 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
8170 (inp_nval) Made static.
8172 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
8173 tokstr_len, toklongstr, tokint) Move here.
8175 * misc.c: Lost several vars and functions.
8177 * set.q: (all the set_* variables) Move here.
8179 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
8180 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
8183 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
8185 * tab.h: (enum series t_*) New enums.
8186 (struct tab_table) Use arena struct tag. New members ce, re.
8188 * tokens.h: Comment fixes.
8190 * var.h: Move lots of enums and variables and functions and
8191 structures to other files. Use and declare a lot more union and
8192 struct tags. Comment fixes.
8194 * vector.c: (glob vars vec, nvec) Move here.
8196 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
8197 init_blanks, last_vfm_invocation) Move here.
8199 * cases.h: New file.
8200 (struct long_vec) Move here.
8201 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
8204 * command.h: New file.
8205 (STATE_* enums) Move here.
8206 (glob var pgm_state) Move here.
8208 * format.c: New file.
8209 (glob var formats) Move here.
8210 (parse_format_specifier_name, fmt_to_string,
8211 check_input_specifier, check_output_specifier,
8212 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
8215 * format.h: New file. Move functions now in format.c here.
8216 (FMT_* enums) Move here.
8217 (struct fmt_desc) Move here.
8218 (FCAT_* enums) Move here.
8219 (struct fmt_spec) Move here.
8220 (glob vars formats, fmt_parse_ignore_error) Move here.
8222 * inpt-pgm.h: New file.
8223 (INP_* enums) Move here, make #defines into enums.
8224 (glob vars inp_init, inp_init_size) Move here.
8227 (glob vars v_sort, nv_sort) Move here.
8228 (sort_cases, read_sort_output) Move here.
8230 * vector.h: New file.
8231 (struct vector) Move here, add struct tag.
8232 (glob vars vec, nvec) Move here.
8233 (find_vector) Move here.
8236 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
8237 reinit_blanks, init_zero, init_blanks) Move here.
8238 (struct case_stream) Move here.
8239 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
8240 vfm_disk_stream, sort_stream, data_list_source,
8241 input_program_source, file_type_source, get_source, n_lag) Move
8243 (procedure, write_case, lagged_case, compact_case, page_to_disk)
8246 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
8248 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
8249 (LDADD) Add libdcdflib.
8251 * ascii.c: Comment and formatting fixes. Almost every external
8252 function had an assert added, checking driver_open and page_open.
8253 (ascii_init_driver) Broken into ascii_preopen_driver,
8254 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
8255 (ascii_open_page) Sets page_open.
8256 (ascii_close_page) Clears page_open.
8258 * html.c: Comment and formatting fixes. Almost every external
8259 function had an assert added, checking driver_open and page_open.
8260 (html_init_driver) Broken into html_preopen_driver,
8261 html_postopen_driver, html_close_driver. Manages driver_open.
8262 (html_open_page) Sets page_open.
8263 (html_close_page) Clears page_open.
8264 (html_submit) Disabled.
8266 * lexer.c: (parse_string) Remove debugging printf.
8268 * list.q: (determine_layout) Open a page if one is not yet open.
8270 * output.c: Comment fixes.
8271 (add_class) Set the class member of the new list element.
8272 (parse_options) Don't handle device type.
8273 (colon_tokenize) New function.
8274 (configure_driver) New four-field format with a field for device
8275 type. Now initialize driver_open, page_open, next, and prev
8276 fields. Use new colon_tokenize() function. Don't do a memory
8277 copy to replace a driver, it doesn't work; instead delete the old
8278 driver and insert a new one.
8279 (destroy_driver) Don't call som_destroy_driver(). Close the page
8280 if it's open. Find the class in the list of classes and decrement
8281 that reference count. Remove the driver from the global driver
8283 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
8284 references changed. Rewritten. Don't return a driver that's not
8286 (outp_eject_page) All references to som_internal_eject_page()
8287 changed to use this. Sets cp_x to 0 as well as cp_y.
8289 * output.h: (OUTP_I_* enums) Removed.
8290 (struct som_submission_form) Removed.
8291 (struct outp_class) init_driver broken into preopen_driver,
8292 postopen_driver, and close_driver. submit changed to take a
8295 * postscript.c: Comment and formatting fixes. Almost every
8296 external function had an assert added, checking driver_open and
8298 (ps_init_driver) Broken into ps_preopen_driver,
8299 ps_postopen_driver, ps_close_driver. Manages driver_open.
8300 (ps_open_page) Sets page_open.
8301 (ps_close_page) Clears page_open.
8303 * som.c: New file, base implementation.
8305 * som.h: (struct som_table) Add struct tag.
8306 (enum SOM_COL_ACROSS) Removed.
8307 (SOM_ROWS, SOM_COLUMNS) New enums.
8308 (struct som_table_class) Add member `cumulate'. Remove `segment';
8309 change `render' arguments.
8310 (struct som_point, struct som_rect) Removed.
8311 (som_submit_table) Fixed typo, should have been som_submit.
8313 * sysfile-info: (describe_variable) Don't try to insert a
8314 subtable; just destroy it for now.
8316 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
8317 references to value labels.
8319 * tab.c: (tab_destroy) New function.
8320 (tab_columns) Change argument.
8321 [0] (tab_submit) Remove dead code.
8322 (tab_title) Allocate string from the table's arena.
8323 (tab_output_text) Only free the buffer if we allocated it.
8324 (tab_submit) New function.
8325 (static vars t, d) New static vars.
8326 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
8327 tabi_headers, tabi_cumulate, tabi_render) New functions.
8328 (glob var tab_table_class) New global var.
8330 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
8331 encapsulate the rectangle. All references changed.
8333 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
8335 * All header files updated to use struct tags in addition to
8336 typedefs for all structures. Don't use word `struct' in struct
8339 * Makefile.am: (pspp_SOURCES) Remove html.c.
8340 (INCLUDES) Replace the lib/* includes with a single lib/ include;
8341 all references updated.
8343 * command.c: (parse_cmd) Remove call to som_check_workspace.
8344 (output_line) Update to new som.
8346 * data-in.c: (parse_numeric) A single dot is not an error; it is
8347 the system-missing value.
8349 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
8352 * data-out.c: Added `const' as appropriate to many prototypes.
8353 (convert_E, convert_F, convert_CCx) Take double argument instead
8354 of value * argument.
8355 (convert_format_to_string) Call changed functions appropriately.
8356 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
8357 make a local copy of the value.
8359 * descript.q: Remove custom_variables() prototype now provided by
8361 (custom_variables) Don't increment sbc_variables, the caller does
8363 (dump_z_table, display) Update to new som.
8365 * error.c: (vmsg) Add const to prototype. Remove code to handle
8366 `too many errors' condition.
8367 (check_error_count) New function.
8368 (msg) Add const to prototype.
8370 * filename.c: (open_file) Rewrite for elegance.
8372 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
8373 (dump_full, dump_condensed, dump_statistics) Update for new som.
8375 * list.q: Don't include somP.h. Change all references to
8376 som_driver_ext to refer to the new members of som_driver. Change
8377 som_internal_eject_page() references to outp_eject_page().
8379 * main.c: (parse) Rewrite for elegance. Add call to
8380 check_error_count().
8382 * output.c: (add_class, outp_list_classes, outp_configure_driver)
8383 Rewrite or revise for new outp_driver_class_list structure.
8384 (outp_iterate_enabled_drivers) Fix comparison between disabled
8385 devices and current device type.
8386 (outp_eject_page) New function.
8388 * output.h: Comment fixes.
8389 (struct outp_driver) New members driver_open, page_open, cp_x,
8390 cp_y, font_height, prop_em_width, fixed_width. Deleted members
8392 (struct outp_driver_class_list) New struct.
8393 (outp_class_list) Changed to type outp_driver_class_list; all
8396 * print.c: (dump_table, print_trns_proc) Updated for new som.
8398 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
8399 prototypes for custom subcommands.
8400 (dump_subcommand) Always include the `else'.
8401 (dump_parser) Fix comments in output code.
8403 * set.q: Reordered functions.
8405 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
8407 * som.h: Rewritten from scratch.
8409 * str.h: Remove dead code.
8411 * tab.c, tab.h: New files, base implementation.
8413 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
8416 * t-test.q: New code from John Williams
8417 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
8418 Many many new static vars and defines.
8419 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
8420 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
8421 (struct value_list) New struct.
8422 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
8423 t_crt, t_sig, print_t_groups) New functions.
8424 (cmd_t_test) Implemented.
8426 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
8429 * vfm.c: (dump_splits) Update to new som.
8431 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
8433 * Makefile.am: (fiasco_SOURCES) Add html.c.
8435 * aggregate.c: Base source.
8437 * ascii.c: (postopen, preclose) Reformat.
8439 * data-out.c, expr-evl.c: Comment fixes.
8441 * filename.c: (open_file) When opening a file for writing, use
8442 line buffering instead of full buffering for better interactive
8443 performance. Suggested by Valerio Aimale
8444 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
8445 names `stdin', `stdout', `stderr'.
8447 * groff-font.c: Comment fixes.
8449 * html.c: New file; base version.
8451 * list.q: (write_all_headers, clean_up, determine_layout,
8452 list_cases) Ignore `special' devices for now. Needs to be fixed
8455 * output.c: (outp_init) Add html driver to list; reverse list
8458 * output.h: (struct outp_class_struct) New members `special',
8459 `submit'; comment fixes. All references changed.
8461 * postscript.c: (ps_init_driver) Make defaults for text_opt,
8462 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
8464 (postopen) Comment fix.
8465 (preclose) Comment fixes, formatting fixes. Change x->file.file
8466 references to more proper f->file.
8468 * som-high.c: (som_submit_table) Special classes use their own
8471 * som.h: Comment fixes.
8473 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
8476 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
8478 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
8480 * aggregate.c: Still working on this.
8482 * command.c: (cmd_table[]) Add AGGREGATE back in.
8483 (split_words) Make '-' a legal word separator as well as ' '.
8485 * main.c: Comment fixes.
8487 * q2c.c: (dump_parser) Don't require the procedure's full name to
8488 be present, in the generated source.
8490 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
8491 multiply specified and let it be default; let MISSING, CRITERIA,
8492 FORMAT be multiply specified.
8493 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
8494 (custom_groups) Fix defaults.
8495 (custom_pairs) Check whether this is a PAIRS subcommand before
8496 attempting to parse. Better garbage collection. Proper storage
8498 [DEBUGGING] (debug_print) New function.
8500 * temporary.c: Comment fixes.
8501 (copy_variable) Don't copy variable name and index.
8502 (save_dictionary) Copy variable name and index by hand.
8504 * vars-atr.c: Comment fixes.
8505 (create_variable) New dictionary argument. All references
8507 (common_init_stuff) New dictionary argument. All references
8509 (init_variable) New dictionary argument. All references changed.
8510 (dup_variable) New function.
8512 * vars-prs.c: (parse_variables) If there are any errors, we always
8513 return 0. Previously, it was possible for some types of errors to
8516 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
8518 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
8521 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
8523 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
8526 * q2c.c: Comment fixes.
8527 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
8529 * t-test.q: (cmd_list) Rename cmd_t_test.
8531 * temporary.c: (new_dictionary) Don't declare as static.
8533 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
8535 * aggregate.c: Changes, still not finished.
8537 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
8539 * q2c.c: Comment fixes. Now its output is internationalized.
8540 (get_token) Fix parsing of escapes within literal strings.
8541 (main) Fix bad #line directives in output.
8543 * t-test.q: Base implementation.
8545 * temporary.c: (new_dictionary) New function.
8546 (restore_dictionary) [__CHECKER__] Change fill character to *
8549 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
8551 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
8553 * aggregate.c: Changes, still not finished.
8555 * descript.q, list.q: Comment fixes.
8557 * q2c.c: Almost completely rewritten.
8559 * t-test.q: New file, not complete.
8561 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
8563 * aggregate.c: Changes, still not finished.
8565 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
8568 * temporary.c: (cancel_temporary) New function.
8570 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
8571 of doing it by hand.
8573 * vfm.c: (close_active_file) After restoring a TEMPORARY
8574 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
8576 (SPLIT_FILE_procfunc) Comment fix.
8578 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
8580 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
8582 * aggregate.c: New file, not finished yet.
8584 * command.c: (cmd_table) Add AGGREGATE.
8586 * common.h: (pgm_state) Move declaration to var.h.
8588 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
8590 (parse_string) Message fix.
8592 * recode.c: Comment fix.
8594 * sfm-read.c: (read_variables) Code esthetic fixes.
8595 (write_header) Default date is `Jan', not `JAN'.
8597 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
8599 * sort.c: (cmd_sort_cases) Farm the work out to new function
8600 parse_sort_variables().
8601 (parse_sort_variables) New function.
8602 (sort_cases) New function. Cancels temporary transformations,
8603 which sorting didn't do previously.
8604 (cmd_sort_cases) Better garbage collection on error. Uses
8606 (write_initial_runs, merge_once) Improved code esthetics.
8607 (sort_stream_read) Reduced to one call to read_output_cases().
8608 (read_output_cases) New function.
8610 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
8611 variable labels to 120 characters.
8613 * var.h: Comment fixes.
8614 (glob var pgm_state) From common.h.
8616 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
8618 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
8619 options. Set *names to NULL on error.
8621 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
8623 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
8625 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
8626 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
8628 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
8630 * vfm.c: (page_to_disk) Added missing local variables.
8632 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
8634 * get.c: Comment fix.
8636 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
8637 source is anything other than a disk stream, not just if it's in a
8638 memory stream. Call page_to_disk() before external sort.
8639 (allocate_cases) Message fix.
8641 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
8643 (page_to_disk) New function.
8645 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
8647 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
8649 * common.h: (macro strerror) Remove. From Alexandre Oliva
8650 <oliva@dcc.unicamp.br>.
8652 * get.c: (dict_delete_run) The number of variables to delete is
8653 not necessarily the number of variables that need to be shifted
8655 (trim_dictionary) Don't set *options to 0. Fix bug that caused
8656 too many variables to be deleted.
8658 * postscript.c: Comment fix.
8660 * q2c.c: Include strerror.c. From Alexandre Oliva
8661 <oliva@dcc.unicamp.br>.
8663 * set.q: #undef ON and OFF. From Alexandre Oliva
8664 <oliva@dcc.unicamp.br>.
8666 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
8667 early, otherwise errors cause a bad free().
8669 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
8670 Oliva <oliva@dcc.unicamp.br>.
8672 * temporary.c: (save_dictionary) Don't allocate memory if
8675 * vfm.c: (memory_stream_write) Message fix.
8677 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
8679 * command.c: (static var cmd_table[]) Define REPEATING DATA
8682 * common.h: Added support for broken systems that are missing
8683 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
8685 * Many source files: Replace syntax error messages via msg() with
8686 call to syntax_error().
8688 * data-list.c: (dump_fixed_table) Add support for dumping table
8689 for REPEATING DATA as well as DATA LIST FIXED.
8690 (cmd_repeating_data) Allows and requires `/' between subcommands.
8691 Does proper thing with allowing rpd.starts_end to stay 0. Allows
8692 CONTINUED specifications to be omitted. Forces CONTINUED to be
8693 specified if ID is. Calculates starts_end, cont_end from logical
8694 record length as reported by fhp. Calls dump_fixed_table() if
8695 requested. Fixed length of record copied by memcpy.
8696 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
8698 (realize_value) Returns sensible value for out-of-range variable
8700 (rpd_parse_record) New argument `ofs'. Fixed confusion between
8701 length of occurrences and length of line. Added warning for
8702 fields that exceed the line length. Fixed infinite loop.
8703 (read_one_set_of_repetitions) Numerous minor changes for more
8704 complete SPSS compliance. Message fixes.
8706 * dfm.c: (dfm_close) If the file being closed is the inline file,
8707 read all the remaining data before closing it.
8708 (dfm_get_record) Don't close the file on lossage, as either it
8709 has been closed already or it doesn't belong to us.
8711 * error.c: (puts_stdout) New function.
8712 (vmsg) Use puts_stdout instead of puts.
8714 * file-handle.q: (fh_record_width) New function.
8716 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
8719 (input_program_source_read) Made an old kluge an approved method.
8721 * lexer.c: (syntax_error) New function.
8723 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
8726 * output.c: (oupt_get_paper_size) Message fix.
8728 * q2c.c: Numerous fixes to formatting of generated code made to
8729 conform to GNU coding standards. Uses syntax_error() in generated
8730 code. Other miscellaneous generated message fixes. Added support
8731 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
8732 RAND_MAX, and/or strerror().
8734 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
8736 * data-in.c: Comment fixes.
8738 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
8739 (find_variable_input_spec) New function.
8740 (cmd_repeating_data) Initializes id_spec.
8741 (rpd_parse_record) Implemented.
8742 (read_one_set_of_repetitions) Returns -3 by default in order to
8743 kluge out some potential bugs.
8745 * data-out.c: Comment fixes.
8747 * file-type.c: (internal_cmd_record_type) Message fix.
8749 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
8750 for handling -3 return value.
8752 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
8754 * data-list.c: Comment fixes.
8755 (struct dls_var_spec) Reordered members.
8756 (read_from_data_list_fixed) Restructured.
8757 (struct repeating_data_trns) Reordered members. Renamed `starts'
8758 as `starts_beg', `ends' as `starts_end'.
8759 (cmd_repeating_data) Calculates length of repeated data if
8760 necessary and possible.
8761 (parse_num_or_var) Don't allow string variables.
8762 (realize_value) New function.
8763 (rpd_msg) New function.
8764 (rpd_parse_record) New function. Currently stubbed out.
8765 (read_one_set_of_repetitions) Implemented.
8767 * inpt-pgm.c: (input_program_source_read) Comment fix.
8769 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
8771 * command.c: (cmd_end_repeat_p) Removed.
8772 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
8773 (parse_cmd_name) Removed.
8775 * data-list.c: Comment fixes.
8776 (data_list_pgm) Removed `eof' member.
8777 (static var first) New var.
8778 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
8779 FILE TYPE file inside FILE TYPE structures.
8780 (append_var_spec) Appends to *first, not dls.spec.
8781 (parse_fixed) Message fixes.
8782 (struct rpd_num_or_var) New.
8783 (struct repeating_data_trns) New.
8784 (static var rpd) New.
8785 (cmd_repeating_data) New function.
8786 (parse_num_or_var) New function.
8787 (parse_repeating_data) New function.
8788 (read_one_set_of_repetitions) New function.
8790 * file-type.c: (cmd_file_type) Message fixes. Always
8791 default_handle to FILE TYPE file handle.
8792 (internal_cmd_record_type) Message fixes.
8794 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
8796 * repeat.c: Comment fix. Disable debugging.
8798 * temporary.c: (restore_dictionary) Sets splits to NULL and
8799 n_splits to 0 before destroying the variables because now doing
8800 this tries to remove split variables.
8802 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
8803 destroying the dictionary.
8804 (clear_variable) Removes a variable from splits after destroying
8807 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
8809 * cmdline.c: (set_compat) Removed.
8810 (pick_compat) Removed.
8811 (parse_command_line) Removed -c option.
8812 (pre_syntax_message) Removed -c option.
8813 (usage) Remove compatibility code.
8815 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
8816 (glob var compat) Removed.
8818 * compute.c: (type_check) Fixed messages about type mismatches.
8820 * data-list.c: (cmd_data_list) Removed compatibility code.
8821 (fixed_parse_compatible) Calls convert_negative_to_dash().
8822 Fixed bug where it only set the variable in fx.spec if it created
8823 the variable itself.
8824 (dump_fmt_list) Spelling fix.
8825 (cut_field) Removed compatibility code.
8827 * dfm.c: (cmd_begin_data) Don't require a command terminator on
8830 * expr-evl.c: (evaluate_expression) Implement LAG.
8832 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
8833 (parse_neg) Calls convert_negative_to_dash().
8834 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
8837 * expr.h: (struct expression_struct) Removed member max_lag.
8839 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
8840 (internal_cmd_record_type) Removed special handling to produce
8841 negative numbers from dash tokens.
8843 * getline.c: (static var DO_REPEAT_level) New var.
8844 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
8845 (handle_line_buffer) Copies the line into getl_buf; doesn't call
8846 copy_with_DO_REPEAT_substitutions().
8847 (getl_read_line) Maintains value of getl_mode. Calls
8848 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
8850 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
8852 * getline.h: (getl_mode) New glob var.
8854 * glob.c: Comment fixes.
8855 (init_glob) Restructured. Sets set_seed.
8856 (init_compat_dependent) Removed. All references removed.
8857 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
8858 (__htonl, __htons) Removed. (What were these for?)
8860 * lexer.c: (static var tbl) Dash set to class CNUM.
8861 (make_hexit) New function from data-out.c.
8862 (get_token_representation) Rewritten.
8863 (convert_negative_to_dash) New function.
8864 (lex_init_compat_dependent) Removed.
8865 (yylex) A dash is parsed as part of a number if it is followed by
8866 a digit. The ASCII representation of a number is copied to
8867 tokstr. String parsing farmed out to parse_string(). Comment
8869 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
8871 (preprocess_line) Line processing depends on interactive/batch
8872 mode, not on compatibility mode. Removed PC+ compatibility code.
8874 * loop.c: (loop_3_trns_proc) Comment fix.
8876 * main.c: Remove dead code.
8877 (main) Remove call to init_compat_dependent().
8879 * misc.c: (convert_fmt_ItoO) Make E format conversion more
8882 * print.c: (parse_string_argument) Calls
8883 convert_negative_to_dash().
8884 (fixed_parse_compatible) Calls convert_negative_to_dash().
8886 * repeat.c: (RPT_* defines) Removed.
8887 (struct rpt_numeric) Removed.
8888 (struct repeat_entry) New member type, changed `replacement' from
8890 (clean_up) Deallocation adapted to new repeat_entry.
8891 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
8892 usage. Creates vars for `type' of 1.
8893 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
8894 (store_numeric) Rewritten, new interface.
8895 (parse_numbers) Rewritten.
8896 (parse_strings) Rewritten.
8897 (find_DO_REPEAT_substitution) New function.
8898 (perform_DO_REPEAT_substitutions) New function.
8899 (copy_with_DO_REPEAT_substitutions) Removed.
8900 (debug_print) Rewritten.
8902 * set.q: Comment fix.
8903 (custom_results) Removed compatibility code.
8904 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
8907 * sysfile-info.c: (cmd_display) Removed compatibility code.
8909 * tokens.h: Comment fixes.
8910 (token types enum) Removed `toktype' typedef name for this int
8911 type. Removed SUBST. Restructured.
8913 * vars-atr.c: (discard_variables) Sets n_lag to 0.
8915 * vars-prs.c: Comment fix.
8917 * vfm.c: Comment fixes.
8918 (glob var n_lag) New var.
8919 (static vars lag_count, lag_head, lag_queue) New vars.
8920 (procedure) Removed argument nlag.
8921 (setup_lag) New function.
8922 (close_active_file) Discards lagging state.
8923 (lag_case) New function.
8924 (lagged_case) New function.
8925 (write_case) Lags a case if lagging.
8927 * weight.c: (cmd_weight) Removed compatibility code.
8929 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
8931 * getline.h: (struct getl_script) New members loop_index, macros.
8933 * getline.c: (getl_add_file) Sets first_line field to NULL.
8934 (getl_add_DO_REPEAT_file) New function.
8935 (handle_line_buffer) When the current line's length is negative,
8936 set the filename and line number. Increment line number after
8937 reading line. Pass the line to
8938 copy_with_DO_REPEAT_substitutions() for processing.
8939 (getl_close_file) Free DO REPEAT lines before freeing the
8940 filename, and just set the filename to NULL when doing this,
8941 because otherwise the filename gets freed twice.
8943 * glob.c: (glob var queuing) Removed. All references removed.
8945 * lexer.c: Comment fixes.
8946 (get_token_representation) New function.
8948 * repeat.c: Comment fixes.
8949 (struct repeat_entry) Replaced type and v union members with a
8951 (append_record) New function.
8952 (internal_cmd_do_repeat) Started reforming it for the new
8953 repeat_entry struct. Properly records filename changes in the
8954 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
8955 strncasecmp() result usage. Uses append_record() to simplify.
8956 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
8959 (copy_with_DO_REPEAT_substitutions) Started coding.
8961 [DEBUGGING] (debug_print_lines) New function.
8963 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
8965 * tokens.h: (macro is_id1, is_idn) New macros.
8967 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
8969 * cmdline.c: (static var pre_syntax_message) Changed `win'
8970 compatibility mode to `wnd'.
8972 * data-list.c: (fixed_parse_spss) Renamed
8973 fixed_parse_compatible().
8975 * glob.c: (init_glob) Excise unused code for
8976 program_invocation_short_name.
8978 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
8981 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
8983 * set.q: `win' compatibility renamed `wnd'.
8985 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
8987 * filename.c: [__WIN32__] Change the included Windows header files
8989 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
8990 second character is absolute.
8991 (dirname) Fix logic error. Don't printf() the results.
8992 (prepend_dir) Don't printf() the results.
8994 * getline.c: (handle_line_buffer) New function.
8995 (getl_read_line) Reads line with handle_line_buffer() when
8997 (getl_close_file) Discard line buffer data.
8999 * getline.h: Comment fixes.
9000 (struct getl_line_list) New struct.
9001 (getl_script_struct) Added line buffer members. These are hooks
9002 for use by DO REPEAT to allow it to insert virtual source code
9005 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
9006 Override Borland C++ stupidity that claims Windows has a console
9009 * repeat.c: This is in the process of being restructured from
9010 using a token-buffering approach to the DO REPEAT facility to
9011 using the more flexible approach of a line-buffering approach in
9012 conjunction with the getline module. Comment fixes.
9013 (struct tok_struct) Removed.
9014 (static vars queue_index, queue_head, queue) Removed.
9015 (static vars line_buf_head, line_buf_tail) New vars.
9016 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
9018 (pull_queue, destroy_queue) Removed.
9019 [DEBUGGING] (debug_print_tokens) Removed.
9021 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
9023 * file-handle.q: (prepend_current_directory) New function.
9024 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
9025 current directory before normalizing filename.
9027 * filename.c: (gnu_getcwd) New function.
9028 (absolute_filename_p) New function.
9029 (search_path) New argument, PREPEND. All references changed to
9030 pass NULL except those explicitly mentioned. Uses
9031 absolute_filename_p(). Prepends PREPEND before trying the
9033 (dirname, prepend_dir) New functions.
9035 * getline.c: (getl_get_current_directory) New function.
9036 (getl_include) Passes getl_get_current_directory() as PREPEND arg
9039 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
9041 * In several source files, the term `script' was replaced with
9042 `syntax file' inside error messages. Usage of the term `script'
9043 in the sense of a syntax file is now deprecated.
9045 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
9048 * dump-sysfile.c: (usage) Update message.
9050 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
9052 * getline.h: (glob var getl_include_path) Declare extern.
9054 * list.q: Define EXTERN as extern before #including somP.h.
9056 * var.h: Remove declaration of `disptype' variable.
9058 * vfm.c: (close_active_file) After switching the data sink to a
9059 data source, set vfm_sink to NULL, because it doesn't exist any
9062 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
9064 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
9065 _matherrl() to ignore all math errors.
9067 * sfm-read.c: (read_value_labels) When reading the labels from
9068 disk, read the little parts separately instead of as a struct;
9069 this avoids alignment problems.
9071 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
9072 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
9073 (write_header) Allocates and initializes elem_type.
9074 (sfm_write_case) Uses elem_type to determine how to handle each
9076 (sfm_close) Frees elem_type.
9078 * sfmP.h: Comment fix.
9079 [__BORLANDC__] Uses #pragma -a to adjust structure member
9082 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
9084 * Makefile.am: (fiasco_SOURCES) Remove display.c.
9086 * common.c: Fix typo.
9088 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
9089 sense of the condition.
9091 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
9092 line-continuation backslash.
9094 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
9096 * frequencies.q: (custom_grouped, add_percentile) Don't use a
9097 non-constant expression as an argument to sizeof.
9099 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
9100 undefine gettext macro because that's a conio function.
9102 * hash.h: (hsh_prime_tab declaration) Remove.
9104 * list.q: (write_fallback_headers) Move `leader' allocation out of
9105 main loop. Change to local_alloc() allocation.
9107 * output.h: Formatting fixes. Put __attribute__ in right place on
9108 function prototypes.
9110 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
9111 incorrect `SECOND_LOWEST_VALUE' references to proper
9112 `second_lowest_value'.
9114 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
9115 value. This way 2 out of 3 of the som files define the vars
9116 extern, the correct way, that actually works under BC++.
9117 (som_set_float) Don't use nonconstant initializers for a struct.
9119 * som-high.c: Add the standard alloca() header.
9120 (replicate_table) Add prototype.
9122 Merged DISPLAY routine.
9123 * sysfile-info.c: (AS_*) New enum series.
9124 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
9126 (cmd_display, display_macros, display_documents,
9127 display_variables) Stolen from defunct display.c.
9128 (describe_variable) New function.
9130 * temporary.c: [0] (display_tree) New debug function.
9131 (copy_variable) Performs shallow copy of value labels instead of
9132 deep copy; i.e., just copys the AVL tree and increments the
9135 * val-labs.c: Comment fixes.
9136 (do_value_labels) Optionally skip leading forward slash.
9137 (get_label) Creates only a single value label instead of many
9138 copies of one, and sets the reference count.
9140 * display.c: Removed.
9142 * dump-sysfile.c: New file, not yet complete.
9144 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
9146 For lots of source files I added more verbose_msg's. These aren't
9147 listed below as they have tested as being benign. In some cases
9148 these replaced debug_printf() calls.
9150 * output.c: (outp_read_devices) Message fix.
9152 * postscript.c: (output_encodings) Message fix. Reports errors on
9154 (postopen) Message fix.
9156 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
9158 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
9160 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
9163 * main.c: Remove <malloc.h> #include.
9165 * mis-val.c: (parse_numeric) Set .f member for each missing[]
9166 instead of trying to just set the missing[] itself, which is a
9169 * sfm-read.c: (read_variables) Same.
9171 * str.h: Add memmem() prototype.
9173 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
9175 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
9177 * Makefile.am: (q2c) Don't include any libraries in the link.
9179 * dfm.c: (force_line_buffer_extension) New macro.
9180 (count_tabs) New function.
9181 (tabs_To_spaces) New function.
9182 (read_record) Calls tabs_to_spaces() on the line being processed.
9184 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
9185 have to be compiled twice (once for CC, once for LOCAL_CC).
9187 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
9189 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
9190 (LDADD) Add @INTLLIBS@.
9191 (q2c) Add LIBS, @INTLLIBS@ to link step.
9193 * inpt-pgm.c: Turn off debugging.
9195 * postscript.c: (postopen) Format fix. local_free() blocks
9196 returned by local_alloc(); don't free() them.
9198 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
9200 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
9203 * data-list.c: (read_from_data_list_fixed) Pass proper value for
9204 LEN arg, not simply the full string length.
9206 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
9207 directories before generic temp file directories.
9209 * vfm.c: Disable debugging.
9211 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
9213 * get.c: Comment fix.
9214 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
9216 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
9218 * expr-prs.c: (debug_print_postfix) Conditionally included on
9219 GLOBAL_DEBUGGING. Removed out_header() reference.
9221 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
9223 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
9225 * ascii.c: Removed obsolete ascii_close_page() prototype.
9227 * command.c: (output_line) Comment fix.
9229 * data-in.c: Formatting fix.
9230 (parse_string_as_format) Now the `fc' argument is used only for
9231 the purpose of error messages; it is not an index into the string
9232 passed. All references changed.
9234 * data-list.c: Comment fix.
9235 (cut_field) Comment fix. Now returns the column number of the
9236 position of the field cut out on success.
9237 (parse_field) Added `column' argument. Puts the column numbers in
9239 (read_from_data_list_free, read_from_data_list_list) Record the
9240 column number returned by cut_field(), pass it to parse_field().
9242 * dfm.c: Comment fix.
9244 * do-ifP.h: Comment fix.
9246 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
9247 the SYSMIS function.
9249 * expr.h, exprP.h: Comment fix.
9251 * glob.c: (init_glob) Only calls setlocale() and family if
9254 * hash.h: Comment fix.
9256 * include.c: Comment fix.
9258 * output.c: Comment fix.
9260 * postscript.c: (ps_line_intersection) Simplified assertion.
9262 * repeat.c: Comment fix.
9264 * vars-atr.c: Comment fix.
9266 * vars-prs.c: Comment fix.
9268 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
9269 behavior with usage of postincrement.
9270 (memory_stream_read) Discards cases as it goes.
9272 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
9274 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
9277 * Most source files: Includes debug-print.h, related comment
9280 * cases.c: (alloc_val) Removed complex allocation code. Merely
9281 increments default_dict.nval and returns the former value.
9282 (envector, devector) Removed references to lv member of struct
9285 * common.h: (macro VME) Replaced complex definition with simple
9288 * data-list.c: (cmd_data_list) Sets vfm_source instead of
9289 read_active_file and cancel_input_pgm.
9290 (read_from_data_list, cancel_data_list) Removed.
9291 (data_list_source_read, data_list_source_destroy_source) New
9293 (glob var data_list_source) New var.
9295 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
9296 (cmd_begin_data) Improved criteria for an input program accessing
9297 the inline file. Still not perfect.
9299 * do-if.c: (do_if_trns_proc) Simplified debug output.
9301 * expr-prs.c: Comment fixes.
9302 [DEBUGGING] (debug_print_postfix) Simplified debug output.
9304 * file-handle.q: (fh_close_handle) Simplified debug output.
9306 * file-type.c: Comment fixes.
9307 (cmd_file_type) Sets vfm_source instead of read_active_file and
9309 (cmd_end_file_type) On failure, discards variables in place of
9310 just canceling the input program.
9311 (read_from_file_type) Renamed file_type_source_read.
9312 (cancel_file_type) Renamed file_type_source_destroy_source.
9313 (glob var file_type_source) New var.
9315 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
9316 (cmd_get) Initializes options to GTSV_NONE before passing to
9317 trim_dictionary(). Removed `lv' reference. Sets vfm_source
9318 instead of read_active_file and cancel_input_pgm.
9319 (cmd_save_internal) Initializes options before passing to
9320 trim_dictionary(). Local var `nval' removed.
9321 (dict_delete_run) Comment fixes.
9322 (trim_dictionary) Comment fixes. Disallows scratch variables if
9323 GTSV_OPT_SAVE set in options.
9324 (read_from_get) Renamed get_source_read.
9325 (cancel_get) Renamed get_source_destroy_source.
9326 (glob var get_source) New var.
9328 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
9329 read_active_file and cancel_input_pgm.
9330 (read_from_input_program) Renamed input_program_source_read.
9331 Simplified debug output.
9332 (cancel_input_program) Renamed
9333 input_program_source_destroy_source.
9334 (glob var input_program_source) New var.
9336 * loop.c: (loop_1_trns_proc) Simplified debug output.
9338 * main.c: (dump_token) Made eof output more explicit.
9340 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
9343 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
9344 code for always-memory or always-disk cases. malloc's case-list
9345 based on vfm_source_info.ncases. Explicit support for
9346 memory_stream via memory_source_cases.
9347 (do_external_sort) Sets vfm_source instead of read_active_file and
9349 (allocate_file_handles) The temporary directory permissions are
9350 set to 0700 instead of 0777.
9351 (allocate_cases) Formatting fixes. Simplified debug output.
9352 (output_record) Compacts the case if necessary before writing it
9354 (close_handle, open_handle_w) Simplified debug output.
9355 (write_initial_runs) Destroys vfm_sink, then sets it to
9356 sort_stream. Writes records to memory based on
9357 vfm_sink_info.case_size.
9358 (write_to_sort_cases) Renamed sort_stream_write().
9359 (merge) Simplified error handling. Simplified debug output.
9361 (read_from_external_sort) Renamed sort_stream_read().
9362 Reads records based on vfm_source_info.case_size.
9363 (sort_stream_write) Writes records to memory based on
9364 vfm_sink_info.case_size.
9365 (sort_stream_mode) New function.
9366 (glob var sort_stream) New variable.
9368 * temporary.c: (cmd_temporary) Simplified debug output.
9369 (copy_variable) Removed references to `lv'.
9371 * title.c: (get_title) Simplified debug output.
9373 * var.h: Comment fixes.
9374 (struct get_proc) Removed member `lv'.
9375 (struct variable) Removed member `lv'. Comment fixes.
9376 (glob vars read_active_file, write_active_file, cancel_input_pgm)
9378 (struct case_stream) New.
9380 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
9381 read_active_file references to use vfm_source.
9382 (init_variable, replace_variable) Removed references to `lv'.
9384 * vfm.c: Comment fixes.
9385 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
9387 (static var queue, qh, qt, n_lag) Removed. All references
9389 (glob var compaction_necessary, compaction_nval, compaction_case,
9390 paging) New variables.
9391 (record_case) Removed.
9392 (procedure) Comment fixes. Calls vfm_source->read() instead of
9395 (prepare_for_writing, arrange_compaction, make_temp_case,
9396 vector_initialization, setup_filter) New function.
9397 (open_active_file) Most of the code moved into the abovementioned
9398 new functions. Now sets temp_dict to &default_dict if there is no
9399 temporary dictionary, for convenience. New debug output.
9400 (close_active_file) Deals with changing the sink to the source.
9401 Calls finish_compaction(). Frees compaction_case. Mostly
9403 (glob vars disk_source_file, disk_sink_file) New vars.
9404 (destroy_active_file, read_from_memory) Removed.
9405 (disk_stream_init, disk_stream_read, disk_stream_write,
9406 disk_stream_mode, disk_stream_destroy_source,
9407 disk_stream_destroy_sink) New functions.
9408 (glob var vfm_disk_stream) New var.
9409 (glob vars memory_source_cases, memory_sink_cases,
9410 memory_sink_iter, memory_sink_max_cases) New vars.
9411 (memory_stream_init, memory_stream_read, memory_stream_write,
9412 memory_stream_mode, memory_stream_destroy_source,
9413 memory_stream_destroy_sink) New functions.
9414 (glob var vfm_memory_stream) New var.
9415 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
9416 named `more_cases'. Simplified debug output. Otherwise mostly
9418 (record_case) Moved into the stream drivers. Removed.
9419 (transform) Removed (was dead code).
9420 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
9421 common case that the splits don't change, we don't need to copy
9422 the case into prev_case again--pointless.
9423 (compact_case) New function.
9424 (finish_compaction) New function.
9426 * vfmP.h: Comment fixes.
9427 (DEV_* enum series) Removed.
9428 (struct storage) Renamed `stream_info'. Removed variant record.
9429 Removed `device' member.
9431 * debug-print.h: New file.
9433 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
9435 * autorecode.c: Turned off debugging.
9437 * data-list.c: (destroy_dls) Closes the associated file handle.
9439 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
9440 parse_variables() options.
9442 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
9444 * display.c: (display_variables) Really fixed null cell bug.
9446 * file-handle.q: (fh_close_handle) Changed debugging message.
9448 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
9449 parse_variables() options.
9451 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
9452 (cmd_list) Fails if no variables specified.
9453 (determine_layout) Writes blank lines manually.
9455 * loop.c: (loop_1_trns_proc) Made debugging code only print
9456 messages if debugging.
9458 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
9459 parse_variables() arguments.
9460 (main) Parses optional parenthesized options to varlist
9461 subcommands into sbc->message.
9463 * sfm-read.c: Format fix.
9465 * var.h: (FV_*) New enum series.
9466 (PV_*) New enum PV_NO_SCRATCH.
9468 * vars-prs.c: (find_var) Removed.
9469 (fill_all_vars) Takes FV_* enum instead of boolean third
9470 argument. Rewritten to deal with scratch as well as system
9472 (parse_variables) Error message on scratch variable if
9475 * vfm.c: (static var virt_begin_func) New var.
9476 (procedure) Sets up virt_begin_func.
9477 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
9478 after dump_splits(). For succeeding groups changes, calls
9479 virt_begin_func() instead of begin_func().
9481 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
9483 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
9486 * dfm.c: Added some debugging messages, disabled by default.
9487 (open_file_r) Fixed error message.
9488 (read_record) On eof on inline_file, instead of calling
9489 fh_close_handle(), simply jump to eof label like a normal file.
9492 * display.c: Thin lines between rows for certain kinds of
9493 listing. Fixed `null cell' bug.
9495 * error.c: (failure) Flush stdout, stderr before failing.
9497 * file-handle.q: (fh_close_handle) Added debugging message.
9499 * frequencies.q: (dump_full) Bottom line extends across entire
9500 table width. Changed title formatting.
9501 (dump_condensed) Changed title formatting.
9502 (dump_statistics) Fixed title formatting.
9504 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
9505 Sets default value of set_format.
9507 * list.q: (cmd_list) Calls blank_line() before determine_layout().
9508 Passes write_all_headers() to procedure() as pre-group func.
9509 (write_all_headers) New function.
9510 (determine_layout) Removed calls to write_header().
9511 Calls blank_line() before and after write_fallback_headers().
9513 * recode.c: (recode_trns_free) Only attempts to free head->map if
9516 * sfm-read.c: (read_variables) Allows `#' at beginning of system
9517 file variable names but gives a warning. Sets `left' based on
9518 first character being/not being `#'. On lossage frees dict->var.
9520 * som-high.c: (som_draw_title) Simplified title formatting.
9522 * vfm.c: (dump_splits) Fixed and changed splits formatting.
9524 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
9526 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
9527 beginning. Frees v_src, v_dest on successful exit. Frees
9528 h_trans[*], h_trans on lossage.
9529 (recode) Frees h_trans[*], h_trans.
9531 * dfm.c: (dfm_close) Formatting change.
9532 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
9533 longer allocates its own in inline_file.
9534 (open_file_r) Passes the local dfm_fhuser_ext to
9536 (open_file_w) Message fix.
9537 (read_record) Buffer reallocation strategy changed. Frees
9538 ext->line even in inline_file to prevent leaks.
9539 (dfm_put_record) Fixed bug where `ext' was cached before the file
9540 was opened and thus it would be NULL when the file really was
9542 (cmd_begin_data) Sets up inline_file basics itself, then calls
9543 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
9545 * list.q: (write_line) Formatting fix.
9546 (clean_up) Minor strategy change. Sets proportional font after
9548 (determine_layout) Sets fixed font before writing regular headers,
9549 or after writing fallback headers.
9551 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
9552 and KEEP vars after using them.
9554 * postscript.c: (ps_init_driver) Frees x->family.
9555 (postopen) When loading fonts, free the temporary font name buffer
9557 (ps_text_set_font_by_position) Free temporary font name buffer
9559 (text) Fixed code that calculated `lig' so that `lig' always gets
9560 initialized. Formatting fix.
9562 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
9564 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
9565 cells, not xmalloc(), so that the cells will get destroyed
9568 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
9571 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
9573 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
9576 * dfm.c: Comment fix.
9578 * list.q: Comment fixes. Include somP.h. Removed static vars
9579 table, n_columns, n_rows, part. New struct list_ext. New static
9581 (n_lines_remaining, n_chars_width, write_line) New functions.
9582 (cmd_list, list_cases) Rewritten.
9583 (begin_row, end_row, flush_table) Removed.
9584 (write_header, clean_up, write_varname, write_fallback_headers,
9585 determine_layout) New functions.
9587 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
9589 * output.h: Comment fix.
9591 * postscript.c: Comment fix.
9592 (struct ps_driver_ext) Removed prop_size, fixed_size members;
9593 added font_size. All references changed.
9594 (ps_init_driver) Initializes font_size. Simplified space checking
9596 (static var option_tab[]) Removed prop-size, fixed-size; added
9598 (ps_option) Handles font_size.
9600 * som-high.c: Moved prototypes into somP.h.
9601 (som_init_driver) New function.
9602 (som_submit_table) Moved some code into new function
9604 (build_target) Moved some code into new function
9605 som_internal_eject_page().
9606 (som_eject_page) Uses som_internal_eject_page().
9607 (som_internal_eject_page) New function.
9609 * som-low.c: Moved prototypes into somP.h.
9611 * som.h: Formatting fixes.
9613 * somP.h: (struct som_driver_ext) Removed em_width;
9614 added prop_em_width, fixed_width.
9616 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
9618 * Makefile.am: Added `localedir' definition. Added
9619 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
9621 * ascii.c: (macro draw_line) Fixed capitalization.
9623 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
9624 compute.c, count.c, data-in.c, data-list.c, data-out.c,
9625 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
9626 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
9627 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
9628 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
9629 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
9630 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
9631 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
9632 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
9633 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
9634 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
9635 for internationlization.
9637 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
9639 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
9641 * do-if.c, sort.c, val-labs.c: Comment fixes.
9643 * glob.c: (init_glob) Uncommented, updated i18n support.
9645 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
9646 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
9647 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
9648 the declarations of macros taking arguments a lot nicer.
9650 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
9652 * error.h: Removed CE, CW aliases for SE, SW.
9654 * q2c.c: Removed explicit streq() definition since it's duplicated
9657 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
9658 stats.h, str.h, tokens.h: Made the declarations of macros taking
9659 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
9662 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
9664 * cmdline.c: Comment fixes.
9665 (pick_compat) Changed return type to int. Now, instead of setting
9666 glob var `compat' to the emulation, returns the emulation. All
9668 (parse_command_line) Added terminating null to end of
9669 `long_options' array definition.
9670 (pre_syntax_message) Fixes.
9671 (usage) Shows the default emulation in the syntax message by
9672 calling pick_compat().
9674 * getline.c: (getl_add_include_dir) Separates paths with
9675 PATH_DELIMITER, not DIR_SEPARATOR.
9677 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
9678 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
9680 * output.c: (outp_configure_macro) Make earlier definitions for a
9681 particular key override later ones for the same key.
9683 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
9685 * ascii.c: Comment fixes.
9687 * output.c: (outp_get_paper_size)
9688 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
9690 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
9692 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
9693 <errno.h>. GNU libc 2 enforces this!
9695 * command.c: (parse_cmd) Fixed problem with `else' clause being
9696 paired with wrong `if'. Comment fix.
9698 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
9700 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
9701 blp_getline() to getline().
9703 * output.c: (outp_eval_dimension) Changed the fix from last time;
9704 there was no variable `a'.
9706 * q2c.c: (get_line) Fixed boundary condition overrun bug.
9708 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
9710 * output.c: (outp_evaluate_dimension) Fixed handling of negative
9711 numbers having fractional parts. Added case of a fraction without
9712 a whole-number part.
9714 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
9716 * ascii.c: (ascii_text_get_font_position) Removed.
9718 * expr.h, exprP.h: Disabled debugging.
9720 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
9723 * output.h: (struct outp_class_struct) Removed
9724 text_get_font_position method. All references deleted.
9726 * postscript.c: Big change here. Fontmaps were completely
9727 eliminated because of a change in philosophy. Comment fixes.
9728 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
9730 (struct ps_driver_ext) `position', `fontmap', `prop_name',
9731 `fixed_name' members removed. New members `prop_family',
9732 `fixed_family'. `family' member changed to type char *.
9733 (static var ps_fontmaps) Removed.
9735 (ps_init_driver) Removed obsolete references, updated.
9736 Initializes `translate_x', `translate_y', `scale'. Doesn't read
9737 fontmap, of course. Refers to font names through internal_name
9738 rather than subversive means. Frees proper items.
9739 (static var option_tab[]) Removed `fontmap-file' option; renamed
9740 `fixed-font', `prop-font'.
9741 (ps_option) Corresponds to option_tab[].
9742 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
9743 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
9744 hash_family) Removed.
9745 (postopen) Generates font names from family names. Gets
9746 PostScript font name properly. New prologue file comment `!!!'
9748 (ps_open_page) Adds translate_x, translate_y to BP prologue
9749 function; gives SF argument floating-point format.
9750 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
9751 font name. Doesn't change font family.
9752 (ps_text_set_font_by_position) Generates Groff font name from font
9753 family name instead of through table lookup.
9754 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
9755 all references changed. Reduced to simple string assignment.
9756 (ps_get_font_name) Removed.
9757 (ps_get_font_family) Reduced to string return.
9758 (text) Doesn't save `position' since it no longer exists. Ugly
9759 kluge to save font family--fix soon?
9760 (load_font) Removed PostScript name argument.
9762 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
9764 * postscript.c: Comment fix.
9765 (ps_open_page) Puts scale factor in PostScript output.
9767 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
9769 * Makefile.am: Distcleans q2c.
9771 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
9773 * ascii.c: (delineate) Sets text size even if width is zero.
9775 * command.c: Comment fix.
9776 (static var cmd_table[]) Re-enabled EVALUATE command.
9777 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
9778 of comments in script files. Now more liberal on criteria for
9779 performing a state transition--if *anything* happened correctly,
9780 not just if *everything* happened correctly.
9782 * data-out.c: (convert_F) Comment fix. Why in the fsck does
9783 Checker segfault on formatting large numbers and why in the fsck
9784 hadn't I noticed this before?
9786 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
9788 * list.q: (cmd_list) Commented out the actual output routine
9789 because of various problems. Probably will abandon the idea of
9790 using the general `crushed tables' for the LIST procedure.
9792 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
9793 clearing it. Allocates a new var_by_name dictionary before trying
9794 to add members to it.
9796 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
9797 `sib'. Changed type of `node' argument.
9798 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
9800 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
9801 [DEBUGGING] Only deletes the variable from var_by_name if that var
9804 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
9806 * Makefile.am: Added include files to SOURCES. Added
9807 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
9808 includes rules for q2c. Added `boast' target.
9810 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
9812 * Makefile.am: Maintainer-clean Makefile.in.
9814 * Makefile.am: Fixed redundant EXTRA_DIST line.
9816 * ascii.c: Comment fixes.
9817 (ascii_line_vert) Fixed overly aggressive range check.
9819 * display.c: Removed dead code.
9821 * list.q: Turn debugging on.
9822 (flush_table) New debug code.
9824 * sfm-read.c: (read_value_labels) malloc's the structure before
9825 trying to assign to its members.
9827 * sfm-write.c: Comment fix.
9829 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
9831 (output_table) No arguments anymore--gets them through `som'
9832 global. New debug code. In crushed tables, now sets `htv' as
9833 well as `hv' to avoid bad confusion later.
9834 (dump_crush_page) New debug code.
9836 * som-low.c: (som_dump_crush_page) New debug code.
9838 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
9840 All source files: Broke long lines into multiple lines.
9842 * ascii.c: (ascii_close_page) Uses host_system var in place of
9843 HOST_SYSTEM constant.
9845 * cmdline.c: (var syntax_message[]) Broke into
9846 pre_syntax_message[] and post_syntax_message[].
9847 (usage) Outputs both parts, separated by driver list.
9849 * error.h: Fixed broken formatting.
9851 * expr-opt.c: (str_search, str_rsearch) New functions.
9853 * misc.c: (blp_getdelim) Removed. All references changed to
9855 (str_search, str_rsearch) Removed.
9856 (memrmem) New function.
9858 * misc.h: (blp_getline) Removed. All reference changed to
9863 * filename.c: Includes "stat.h", not <sys/stat.h>.
9864 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
9866 * output.c: (outp_list_classes) Changed output formatting.
9868 * sfm-write.c: (write_header) Uses host_system var instead of
9869 HOST_SYSTEM constant.
9870 (write_rec_7_34) Extracts version numbers from the version string.
9873 * sort.c: Includes "stat.h", not <sys/stat.h>.
9875 * str.c: (strcasecmp) Removed.
9877 * title.c: (cmd_document) Uses host_system var instead of
9878 HOST_SYSTEM constant.
9880 * version.c: Generated on-the-fly by the Makefile instead of being
9883 * str.h: Comment fixes. Doesn't substitute for missing memmove or
9885 [!HAVE_STRNCASECMP] Declares strncasecmp().
9887 * version.h: Removed stray character. Comment fixes.
9888 (vars host_system, build_system) New vars.
9890 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
9892 * Most source files: Changed formatting of copyright notice; fixed
9893 FSF address; reformatted to better conform to GNU standards;
9894 comment fixes. Added markups to prevent GNU indent from messing
9895 up my beautiful formatting :-).
9897 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
9898 that GNU indent markups can be passed through without problems.
9900 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
9902 * get.c: Turned off debugging.
9904 * glob.c: (init_glob) Turned on save-file compression by default.
9906 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
9907 compression than was possible in save files.
9909 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
9911 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
9913 * frequencies.q: Removed Fiasco extensions. Updated calculation
9914 algorithms. Polished output format.
9915 (struct frq_info_struct) Removed members `max_degree', `min_n',
9916 all references removed.
9917 (macro frq_extensions) Removed.
9918 (static vars min_n, max_degree) Removed, all references removed.
9919 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
9920 calculate `min_n', `max_degree'.
9921 (postcalc) Passes new arg to dump_statistics().
9922 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
9924 (dump_condensed) Adds variable name title.
9925 (sum_freqs) Removed.
9926 (calc_stats) Updated calculation algorithm.
9927 (dump_statistics) Removed warning for too-few observations.
9928 Changed table formatting. Adds variable name title if passed new
9931 * output.h: Comment fix.
9933 * recode.c, sample.c, sort.c: Disabled debug code.
9935 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
9936 Improved debug code.
9938 * var.h: (enum series frq_*) Removed Fiasco extensions.
9940 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
9942 * command.c: Added PROCESS IF to command table.
9944 * Lots & lots of places, removed checks for NULLs preceding calls
9945 to free_expression(), which itself checks.
9947 * descript.q: Removed Fiasco extensions. Removed optimizations
9948 for non-weighted active files. Implemented some options.
9949 Finished polishing output format. Comment fixes. Merged
9951 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
9952 max_degree, min_n) Removed.
9953 (macro dsc_extensions) Removed.
9954 (struct dsc_info_struct) Removed `min_n' member, all references
9956 (internal_cmd_descriptives) Removed calculation of min_n,
9957 max_degree. Only deals with one `calc' routine instead of two
9959 (precalc) Eliminated redundancy. Updated for changes to
9960 descriptives_proc structure.
9961 (calc) Moved here from `descript.g'. Rewritten to calculate
9962 statistics via `moments about the mean' rather than by summing,
9963 summing squares, summing cubes, and so on.
9964 (postcalc) Rewritten for new-style statistical calculation.
9965 (display) Removed support for displaying variables across rows.
9966 No longer crushes the descriptives table. Removed ancient code.
9967 Added display of N, by variable and listwise.
9969 * descript.g: Removed; merged into `descript.q'.
9971 * expr-evl.c: (evaluate_expression) Now returns a double. For
9972 numeric results, it returns the result as well as storing it in
9973 the passed `value' structure if non-NULL. For string results it
9974 just returns 0.0 and it must be passed non-NULL. Many references
9975 to this function were optimized by use of this change, especially
9976 but not exclusively in `compute.c'.
9978 * frequencies.g: Comment fix.
9980 * glob.c: (glob var process_if_expr) New global var.
9982 * postscript.c: (static var option_tab[]) Corrected entry for
9984 (postopen) Sets x->size to x->prop_size.
9985 (ps_text_set_font_by_name) Sets font size as well as typeface for
9986 PROP and FIXED fonts.
9988 * sel-if.c: (cmd_process_if) New function.
9990 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
9991 (sfm_write_dictionary) Sets `n_cases' to 0.
9992 (sfm_write_case) Increments `n_cases'.
9993 (sfm_close) Attempts to seek the system file back to the header
9994 and write the number of cases in its proper slot.
9996 * som-frnt.c: (som_insert_table) Masks off expansion options since
9997 only SOPT_X_NORM seems to work sensibly.
9999 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
10000 with a `fixed' value of 2.
10002 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
10004 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
10005 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
10007 * var.h: (enum series dsc_*) Removed Fiasco extensions.
10008 (struct descriptives_proc) Removed `miss_noweight'; new members
10009 `X_bar', `M2', `M3', `M4', `min', `max'.
10011 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
10013 * vfm.c: (close_active_file) Cancels PROCESS IF.
10014 (write_case) Doesn't process cases unselected by PROCESS IF.
10016 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
10018 * glob.c: (glob var err) Removed.
10020 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
10021 doesn't have to take into account number of value labels since
10022 they're in a subtable anyway. Also, doesn't display more than 10
10023 value labels since we can't yet break pages in subtables.
10025 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
10027 * som-frnt.c: (som_change_table_size) Simple change for elegance
10028 that shouldn't change behavior.
10029 (som_set_value) Comment fix.
10031 * som-high.c: (som_submit_table) Message fix.
10033 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
10035 * command.c: Added SYSFILE INFO to command table.
10037 * file-handle.q: (fh_handle_filename) New function.
10039 * get.c: (save_trns_proc) Fixed a bug in padding of output data
10042 * main.c: (parse) New return value for command functions, -3.
10044 * misc.h: Comment fix.
10046 * output.h: Comment fixes.
10047 (macro COMPONENTS) Removed.
10049 * postscript.c: (write_text) Modified literal_chars[] so that `('
10050 and ')' are not written to the output in strings as literals.
10052 * sfm-read.c: (sfm_read_dictionary) New argument.
10053 (read_header) New argument. Sets the information structure's
10054 values from the header information.
10055 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
10056 bizarre Checker problem, I guess.
10057 (read_variables) Proper cleanup on lossage.
10059 * sfm.h: (struct sfm_read_info) New struct for use by
10060 sfm_read_dictionary().
10062 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
10063 currently used just for tables that can be dynamically resized and
10064 thus have to be allocated with arena_malloc() instead of
10065 arena_alloc(). All references changed.
10066 (som_change_table_size) New function.
10067 (som_insert_table) Bugfix: now inserts `cell', not `c'!
10069 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
10070 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
10073 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
10075 (draw_intersection) Now takes an argument specifying the table in
10076 question. All references changed.
10077 (draw_table_cell) New function.
10078 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
10079 (som_get_table_size) Many nice new explanatory comments.
10080 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
10082 * som.h: New enum series SOM_CREATE_* for use as create flags with
10083 som_create_table().
10085 * str.h: Moved a comment here from TODO.
10087 * sysfile-info.c: New file. Reference implementation.
10089 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
10091 * command.c: Added RENAME VARIABLES to table of commands.
10093 * data-in.c: (dls_error) Sets `cust_field'.
10094 (parse_N) Message fix.
10095 (parse_day_count) New function.
10096 (to_roman) Never outputs VX as a `short form' of V.
10097 (parse_month) Fixed parsing of Roman numerals.
10098 (parse_trailer) Message fix.
10099 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
10100 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
10101 the date is invalid.
10102 (parse_SDATE) Fixed swapped day, year.
10103 (parse_JDATE) Fixed bug for dates in 1582.
10104 (parse_DTIME) Allows days not between 1 and 31.
10105 (parse_numeric) Makes local copy of f.type for easier usage.
10108 * data-out.c: (convert_F) When outputting as scientific, properly
10109 sets f.type as fp->type.
10110 (insert_commas) Fixed operator precedence problem with setting of
10111 nitems. Changed strcpy to memcpy (no null terminator).
10112 (convert_date) Fixed FMT_JDATE: added 1900 to year.
10113 (convert_CCx) Essentially rewritten, but now it works.
10115 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
10116 feature of Fiasco).
10117 (display_documents) Implemented.
10119 * error.c: (glob var cust_field) New var.
10120 (vmsg) Displays cust_field as part of message classes DE and DW.
10122 * formats.c: (debug_print) Fixed to compile under updated
10125 * get.c: (cmd_get, cmd_save_internal) Close file handle on
10128 * misc.c: (parse_format_specifier) Formatting fix.
10130 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
10131 `n_rename' for clarity.
10132 (cmd_modify_vars) Initializes `forward' and `positional' at
10133 appropriate times. Frees lists of vars to rename on failure.
10134 Comment fix. Frees memory on success.
10135 (rearrange_dict) Simplified `for' loop condition.
10137 * rename-vars.c: New file (reference implementation).
10139 * set.q: (internal_cmd_set) Fixed `emu' test condition.
10141 * sfm-read.c: (read_header) File label is created only if file
10142 label in file is not blank.
10143 (read_variables) Initializes `dict' local variable.
10144 (read_documents) Proper behavior on lossage.
10146 * sfm-write.c: (write_header) Doesn't blank out the file label
10147 (why was this here to begin with?!)
10149 * temporary.c: (save_dictionary) File label is copied only if
10150 non-NULL. Doesn't try to xstrdup() dictionary documents.
10151 Adapted so as to not irritate Checker.
10152 (free_dictionary) Only destroys var_by_name if non-NULL.
10154 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
10155 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
10156 lines to the document, indents the document. Also, it works now.
10157 (add_document_line) New function.
10159 * var.h: (struct dictionary) Reordering.
10161 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
10162 bits if it was allocated to begin with.
10164 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
10166 * command.c: Added MODIFY VARS to list of commands.
10168 * configure.in: Updated custom macros for autoconf 2.12. Removed
10169 mmap reference; fixed termcap library reference.
10171 * display.c: (display_variables) Fixed a few bugs although it's
10172 still not well written.
10174 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
10175 (induce_segfault) Calls chkr_disp_call_chain() instead of
10176 inducing an actual SIGSEGV.
10178 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
10179 str_search() and str_rsearch(). Fixed tests for matches on
10180 OP_INDEX and OP_RINDEX.
10182 * filename.c: (good_getcwd) Removed as the new libc for Checker
10183 doesn't contain this bug, apparently.
10185 * misc.c: (str_search, str_rsearch) Changed order of arguments for
10186 consistency with GNU memmem.
10187 (blp_getdelim) Changed `len' from `int' to `size_t'.
10189 * modify-vars.c: Reference implementation.
10191 * som-frnt.c: (zero_length) New global var.
10192 (som_create_table) Message fix.
10194 * som.h: Added gcc attributions to som_set_text(),
10195 som_output_text() prototypes. blank_line() refers to
10196 zero_length[] instead of a literal null string to suppress gcc
10199 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
10200 (allocate_cases) Decrements x_max so the last element of x[] can
10201 be used by the algorithm.
10203 * var.h: Changed minor details of `variable' declaration.
10204 (struct modify_vars_proc) New struct.
10205 (struct variable) Added field p.mfv.
10207 * vars-atr.c: Comment fix.
10209 * vars-prs.c: (fill_all_vars) More optimal implementation.
10211 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
10212 character, which it shouldn't have to do but printf() seems to
10213 read the null byte even though I supply a maximum length...
10215 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
10217 * command.c: Removed command alias X for QUIT.
10218 (parse_cmd) Fixed comment parsing.
10220 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
10222 (read_record) Fixed references to len, size.
10223 (dfm_get_record) Restructured.
10225 * file-handle.h: (struct file_handle) Field `lrecl' now of type
10228 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
10231 * modify-vars.c: New file. Not complete.
10233 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
10236 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
10237 problems caused by int/size_t differences.
10239 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
10242 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
10243 being compared were of equal length.
10245 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
10247 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
10249 * lexer.c: (get_dotted_rest_of_line) New function.
10251 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
10254 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
10255 type 6 records. Frees the dictionary properly.
10256 (read_header) Initializes the dictionary instead of letting
10257 read_variables() do it. Sets the dictionary file label from the
10259 (read_documents) New function.
10261 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
10262 write type 6 record if appropriate.
10263 (write_header) Writes file label from dictionary.
10264 (write_documents) New function.
10266 * temporary.c: (save_dictionary, restore_dictionary,
10267 free_dictionary) Properly handle new fields in dictionary struct.
10269 * title.c: (get_title) Returns after failure().
10270 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
10271 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
10273 * var.h: (struct dictionary) New fields `label', `n_documents',
10276 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
10278 * command.c: Added FILTER to list of commands.
10280 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
10283 * get.c: (cmd_save_internal) Removed weighting code since it's now
10284 handled by sfm-write.c. Properly commented out debug code.
10286 * glob.c: (glob var weighting) Removed.
10288 * sel-if.c: Comment fixes.
10289 (cmd_filter) New function.
10291 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
10292 (sfm_read_dictionary) Sets weighting variable direct in the
10293 created dictionary now. (Apparently we previously didn't support
10295 (read_header) Sets weight_index field in sfm_fhuser_ext from
10296 header read from disk.
10298 * sfm-write.c: (sfm_write_dictionary) Comment fix.
10299 (write_header) Now sets the weighting in the header from the
10300 passed primary dictionary instead of from the sfm_write_info.
10302 * sfm.h: (struct sfm_write_info) Removed field `weight'.
10304 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
10305 broke on boundary conditions.
10307 * var.h: (struct dictionary) New fields `weight_var',
10308 `weight_index', and `filter_var'.
10309 (glob var weighting) Removed. This is now part of struct
10310 dictionary. All references changed; the less mechanical changes
10311 are described above.
10313 * vars-atr.c: (find_dict_variable) New function.
10315 * vfm.c: (static var filter_index) New variable.
10316 (open_active_file) Initializes filter_index from default_dict.
10317 (write_case) Calls proc_func() only if the filter variable is
10318 nonzero; this implements FILTER behavior.
10320 * weight.c: (static var weight_varname) Removed.
10321 (cmd_weight) Modified default_dict instead of glob vars.
10322 (update_weighting) Changed the signature to modify a dictionary
10323 instead of glob vars. Now returns the weighting variable.
10324 (get_weighting_variable) Removed; its function is absorbed by
10325 update_weighting().
10326 (stop_weighting) Operates on a dictionary now.
10328 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
10330 * sort.c: Removed debugging info from messages.
10331 (do_external_sort) Cleans up after itself by deleting the
10332 temporary directory on failure. (On success it is deleted by the
10334 (allocate_cases) Removed debug code. Added clean up code.
10335 (output_record) Removed debug code.
10336 (merge) Added code to close all the input files that are currently
10337 open. This is a likely location for bugs, because I'm not sure
10338 about boundary conditions. Removed an unnecesary heap_delete().
10339 (merge_once) Removed input file "optimization" that in fact
10340 screwed up the rest of the code. Message and comment fixes.
10342 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
10344 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
10346 * heap.c: (heap_delete) New argument.
10348 * sort.c: Finished implementation of external sort.
10350 * vfm.c: (read_from_disk) Returns after a disk error.
10352 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
10354 * sort.c: (static var state) Removed.
10355 (static vars max_handles, tmp_basename, tmp_extname,
10356 huffman_queue) New variables.
10357 (do_external_sort) Moved most code to new functions.
10358 Creates huffman_queue.
10359 (allocate_file_handles, allocate_cases) New functions.
10360 (static vars run_no, run_length, file_index, case_count) New
10362 (output_record) Returns success. Now really writes to the output
10364 (begin_run, end_run) New functions.
10365 (write_initial_runs) Returns success. Initializes run_no to -1.
10366 Calls begin_run(), end_run() at appropriate times. Outputs debug
10368 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
10370 (merge) New function.
10372 * heap.c, heap.h: New files. Hopefully in near-final form.
10374 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
10376 * glob.c: Added write_active_file to global vars.
10378 * sort.c: Several new miscellaneous static variables.
10379 (cmd_sort_cases) Big comment fix.
10380 (perform_case_2) Renamed `do_external_sort' and completely
10382 (case_2_proc_func) Removed.
10383 (output_record, write_initial_runs, write_to_sort_cases,
10384 compare_record) New functions.
10386 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
10388 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
10390 * sort.c: (perform_case_2) Changed the method for allocation of
10391 lots of memory--now allocates one case at a time in hopes that
10392 more cases can be allocated with heavily fragmented memory.
10394 * var.h: (write_active_file) New global var.
10396 * vfm.c: (procedure, close_active_file, write_case,
10397 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
10398 arguments to procedure() to be NULL. All references to
10399 procedure() that made use of dummy functions were changed to NULL
10401 (open_active_file) If write_active_file is non-NULL, the output
10402 device becomes DEV_PGM (a new enum).
10403 (close_active_file) Sets write_active_file to NULL.
10404 (read_from_memory) Comment fix.
10405 (record_case) Calls write_active_file() when the output device is
10408 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
10410 * sort.c: New file.
10412 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
10413 Fixed checking for duplicate varnames.
10414 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
10416 (autorecode_trns_free) Destroys hash tables for each recoding
10418 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
10420 * command.c: Added SORT CASES to cmd_table.
10421 (null_func, null_int_func) Prototyped.
10423 * descript.g: (calc_weight, calc_noweight) Computes own case
10426 * frequencies.q: (dump_statistics) Fixed problem with
10427 too-few-cases warning message.
10429 * get.c: (cmd_save_internal) Handles weighting properly.
10431 * hash.c: (hsh_dump) Output format changed.
10432 (force_hsh_insert) Actually works now, prototype changed.
10434 * list.q: (static var case_num) New variable.
10435 (cmd_list) Initializes case_num.
10436 (list_cases) Increments case_num.
10438 * var.h: Added definitions for SORT CASES. Comment fixes.
10440 * vfm.c: Some definitions moved to new file vfmP.h. Comment
10441 fixes. `active' renamed vfm_active, `rep' renamed
10442 vfm_replacement, all references changed.
10443 (procedure) The procfunc no longer receives a case number. All
10444 references changed.
10445 (write_case) Subtle reordering.
10446 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
10449 * weight.c: (get_weighting_variable) New function.
10451 * vfmP.h: New file with definitions from vfm.c.
10453 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
10455 * command.c: (FILE_TYPE_okay) Commented out some tests because
10456 they're clumsy and not yet needed.
10458 * var.h: Most *_trns structures moved to their respective source
10459 files. Some were moved into a new file, do-ifP.h. Comment fixes.
10460 (union any_trns) Changed to a typedef for trns_header.
10461 (struct input_program_pgm) Removed.
10463 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
10464 was allocated in the first place.
10466 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
10468 * autorecode.c: New file.
10470 * command.c: Added AUTORECODE to command table; re-enabled SET.
10472 * data-out.c: (convert_F) Handles infinities and NaNs properly.
10474 * error.c: (vmsg) Comment fixes.
10476 * hash.c: Comment fix.
10477 (hashpjw_d) New function.
10478 (hashpjw) Reimplemented as call to more general function
10480 (internal_comparison_fn) Initializes pointers properly.
10481 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
10482 (force_hsh_insert, force_hsh_find) New debugging wrapper
10485 * main.c: (main) Message fix.
10487 * output.c: (outp_read_devices) Message fix.
10489 * set.q: Comment fixes.
10490 (custom_results) Implemented Wnd/X form of subcommand.
10491 (set_routing) New function.
10492 (internal_cmd_set) Implemented ERRORS, MESSAGES.
10494 * settings.h: (SET_ROUTE_*) New enum series.
10495 (set_results) Renamed set_results_file, all references changed.
10496 (set_messages) Removed.
10497 (glob vars set_errors, set_messages, set_results) New vars.
10499 * title.c: (get_title) Remembers to xstrdup() the result of
10500 get_rest_of_line().
10502 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
10504 (union any_trns) New element `arc'.
10506 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
10508 * command.c: (output_line) Removed references to set_screen.
10510 * error.c: (static var terminating) New var.
10511 (hcf) Sets terminating to 1.
10512 (vmsg) If terminating is nonzero, does not attempt to call hcf().
10513 This prevents an infinite loop if an error occurs within hcf().
10515 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
10516 statement circumlocution with `case 42000' trick.
10517 (evaluate_expression) New support for OP_STR_MIS.
10519 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
10520 statement circumlocution with `case 42000' trick.
10521 (dump_node) Handles OP_STR_MIS.
10523 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
10524 variables exceptions.
10525 (parse_function) Message fix.
10526 (ops[]) Added OP_STR_MIS.
10528 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
10530 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
10532 * glob.c: Removed set_scrnfile glob var.
10533 (init_glob) set_errorbreak set to 0 by default.
10535 * groff-font.c: Changed included files.
10536 (groff_read_font) Initializes font_arena local var correctly.
10537 (default_font) New function.
10539 * output.c: Comment fixes.
10540 (glob var disabled_devices) New variable.
10541 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
10543 [GLOBAL_DEBUGGING] (reentrancy) New function.
10544 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
10545 outp_iterate_enabled_drivers) Calls to reentrancy().
10546 (destroy_list) New function.
10547 (outp_done) Moved code to destroy_list().
10548 (parse_options) Parses `listing', `screen', `printer' options
10550 (configure_driver) Sets new `device' member of driver.
10551 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
10553 * output.h: Comment fixes. New enum series OUTP_DEV_*.
10554 (struct outp_driver_struct) New member `device'.
10556 * postscript.c: (find_encoding_file) Doesn't display its own error
10558 (default_encoding) New function.
10559 (switch_font) Calls default_encoding() if no encoding can be
10561 (text) Makes up a character metric if none exists for the desired
10563 (load_font) Properly copies a fallback filename. Calls
10564 default_font() for a font if none at all are known.
10566 * set.q: Comment fixes. Removed OUTPUT subcommand.
10567 (custom_listing) Calls outp_enable_device() to enable/disable
10569 (turn_screen_on) Removed.
10570 (internal_cmd_set) Calls outp_enable_device() to enable/disable
10571 screen, printer devices.
10573 * settings.h: Comment fixes.
10574 (glob vars set_output, set_printer, set_screen, set_scrnfile)
10577 * som-high.c: (som_submit_table, som_eject_page) Use
10578 outp_iterate_enabled_drivers() instead of iterating
10579 outp_driver_list directly.
10581 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
10583 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
10584 (parse_string_as_format) Handles new formats.
10585 (parse_numeric) Now handles DOT and PCT formats.
10587 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
10589 (convert_date) Handle EDATE and SDATE formats.
10590 (convert_CCx) Now if there's not room for the currency characters,
10591 converts it as F format if it's positive instead of giving up
10592 quickly. Also fixed save-and-restore bug with decimal point
10594 (convert_format_to_string) Handles new formats.
10596 * misc.c: (formats[]) Added new formats.
10597 (convert_fmt_ItoO) Supports new formats.
10599 * sfm-read.c: (parse_format_spec) Supports new formats. Better
10600 data checking. New argument, all references changed.
10602 * sfm-write.c: (write_format_spec) Supports new formats.
10604 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
10607 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
10609 * cmdline.c: Comment fixes.
10610 (parse_command_line) Changed return type to void.
10612 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
10614 (parse_numeric) Handles international numbers (comma as decimal
10615 point). Some reformatting.
10617 * data-list.c: (parse_free) Default output format is now
10618 set_format instead of hard-coded F8.2.
10619 (read_from_data_list_list) Emits error message on undefined data
10620 only if set_undefined is nonzero.
10622 * data-out.c: (convert_E) Changes decimal point from period to
10623 comma if appropriate. Restructured. Better comments.
10624 (convert_F) Changes decimal point from period to comma if
10626 (insert_commas) Major bug with handling of negative values fixed.
10627 Also, inserts periods instead of commas if appropriate.
10628 (convert_CCx) New function.
10629 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
10630 (num_to_string) Changed `.' to set_decimal.
10632 * dfm.c: Comment fixes.
10633 (dfm_close) Frees ext->line even in inline_file.
10634 (open_inline_file) New function.
10635 (open_file_r) When opening the inline file: now properly
10636 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
10638 (read_record) Calls fh_close_handle() instead of dfm_close() to
10639 close the inline file. Makes a copy of the line getl_buf to avoid
10640 interlock problems.
10641 (dfm_get_record) Restructured. Now checks the return value of
10643 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
10644 checking for use of inline file. No longer tries to close inline
10647 * error.c: (glob var error_already_flagged) New var.
10648 (vmsg) Message change. Now checks max number of errors/warnings,
10651 * file-handle.q: (fh_handle_name) Now allows closing of
10653 (fh_init_files) Reformatted.
10655 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
10657 * getline.c: (getl_include) Fixed bug that popped up when called
10658 when file queue was empty.
10659 (read_console) Resets error_count, warning_count,
10660 error_already_flagged to zero.
10662 * glob.c: Many changes to update list of variables.
10663 (init_compat_dependent) Now this function is called whenever
10664 `compat' changes. It now sets set_seed only if it hasn't
10665 previously been referenced. It now calls
10666 lex_init_compat_dependent().
10668 * include.c: (cmd_include_at) Frees temporary buffer instead of
10670 (cmd_include) Doesn't make copy of include file name.
10672 * lexer.c: Comment fixes.
10673 (init_lex) Moved some code into new function
10674 lex_init_compat_dependent().
10675 (lex_init_compat_dependent) New function.
10676 (hex_val) Simplified.
10677 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
10679 * main.c: Comment fixes.
10680 (main) Reformatted.
10682 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
10683 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
10684 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
10685 (setup_randomize) Sets set_seed_used.
10687 * set.q: Comment fixes.
10688 (custom_results) Conditionalizes on `compat'.
10689 (custom_log) Calls custom_journal().
10690 (set_ccx) New function.
10691 (cmd_set) Calls init_compat_dependent() when `compat' changes.
10692 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
10693 when set_decimal changes. Range-checks values for MITERATE,
10694 MNEST. Message fixes.
10696 * settings.h: Comment fixes.
10697 (struct set_cust_currency) New struct.
10698 (set_cc[], set_grouping, set_seed_used) New global vars.
10700 * var.h: (FMT_CCA...FMT_CCE) New output formats.
10701 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
10703 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
10705 * glob.c: Revised variables to correspond to settings.h.
10706 (init_glob) Initializes variables from settings.h properly.
10708 * set.q: Began long-overdue major revision to correspond to new
10709 philosophy. Most code changed.
10711 * settings.h: Mostly changed; reorganized, reordered, large new
10714 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
10716 * get.c: (cmd_save_internal) No longer forces compression off.
10718 * sfm-read.c: (read_compressed_data) If eof is reached when
10719 reading a new instruction octet, only signal error if we're in the
10722 * sfm-write.c: (COMPRESSION_BIAS) New #define.
10723 (struct sfm_fhuser_ext) New member `end'.
10724 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
10725 (ensure_buf_space) New function.
10726 (sfm_write_case) Reimplemented in order to support compression.
10727 (sfm_close) Writes out the remaining contents of the compression
10730 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
10732 * command.c: Defined SAVE and XSAVE commands in command table.
10734 * common.h: second_lowest_value is of type flt64, not double.
10736 * file-handle.h: Comment fix.
10738 * get.c: Comment fixes.
10739 (static var `trns') New.
10740 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
10741 cmd_save_internal, cmd_save, cmd_xsave) New functions.
10742 (dict_delete_run) Clears the variables and frees them now.
10743 (trim_dictionary) Sets default for compression.
10744 On KEEP subcommand, frees deleted variables as well as clearing
10745 them. Finally got the sense of the test for deleting all
10747 [DEBUGGING] (dump_dict_variables) Message fix.
10749 * glob.c: (init_glob) set_compression set to 1 by default.
10751 * list.q: Properly #includes config.h.
10753 * misc.h: New macro REM_RND_UP.
10755 * settings.h: Comment fix.
10757 * sfm-read.c: (structs sysfile_header, sysfile_format,
10758 sysfile_variable; inline function bswap_int32) Moved to new file
10760 (corrupt_msg) [__CHECKER__] No longer induces segfault.
10761 (sfm_read_dictionary) Fixed bug caused by failing to initialize
10763 (read_machine_flt64_info) Fixed some problems caused by confusion
10764 between flt64 and double types.
10765 (read_header) Message fix.
10766 (read_variables) Fixed set of cases in which we byte-swap sv.print
10767 and sv.write. Fixed confusion of flt64 and double.
10769 * sfm.h: (struct sfm_write_info) New.
10771 * som-high.c: (som_draw_title) Properly frees `s'.
10773 * temporary.c: (save_dictionary) Comment fix.
10775 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
10776 (struct trns_header) Formatting fix.
10777 (struct save_trns) New.
10779 * vars-atr.c: (discard_variables) Comment fix.
10781 * sfm-write.c: New file, baseline release.
10783 * sfmP.h: New file, baseline release.
10785 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
10787 * cmdline.c: (parse_command_line) `--version' output updated.
10788 (glob var syntax_message[]) Added my e-mail address.
10790 * file-handle.q, lexer.c, vfm.c: Changed many instances of
10791 `illegal' to `invalid'.
10793 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
10794 uncompression buffer.
10795 (sfm_close) Frees decompression buffer.
10796 (sfm_read_dictionary) Initializes decompression buffer.
10797 (buffer_input, read_compressed_data) New functions.
10798 (sfm_read_case) Restructured; now calls read_compressed_data() to
10799 handle compressed system file data.
10801 * var.h: Comment fix.
10803 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
10805 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
10808 * get.c: New comments. New static var `get_file'.
10809 (cmd_get) Now fully implemented. Calls discard_variables();
10810 initializes fv and lv for all variables; new debug code; sets
10811 up the dictionary; sets up the input program.
10812 (read_from_get, cancel_get) New functions.
10814 * sfm-read.c: Comment fixes.
10815 (sfm_close) New static function.
10816 (sfm_read_dictionary) Properly sets up the class of the
10817 file_handle. No longer cares what size the data is in records of
10818 type 7. Also, on failure, properly cleans up the file_handle and
10819 free()s some stuff.
10820 (read_variables) No longer thinks it knows `nval' of the
10821 dictionary. Now sets p.get.fv, etc., instead of speculatively
10823 (read_value_labels) Fixed off-by-one error in indexing of
10825 (sfm_read_case) New function.
10826 (sfm_r_class) New static var.
10828 * var.h: (get_proc) New struct.
10829 (struct variable) New member p.get.
10831 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
10833 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
10834 the manual's meaning.
10835 (rename_variables) New function.
10836 (trim_variables) Doesn't try to parse MAP any more. Removed debug
10837 code. Now properly reorders the dictionary on the KEEP keyword.
10839 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
10840 garbage collection.
10842 * vars-atr.c: (clear_variable) New argument `dictionary *'.
10843 (rename_variable) New function.
10844 (free_val_lab) Reformatted.
10846 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
10848 * var.h: Reindented entire file. Comment fixes.
10849 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
10851 (glob var default_dict) New.
10852 (struct indirect_dictionary) Removed.
10854 * Many other source files were changed to add `default_dict.'
10855 before all references to the dictionary of the active file.
10857 * vars-atr.c: (make_indirect_dictionary) Removed.
10859 * glob.c: Reindented all variable declarations. Updated for
10860 changed var.h. Comment fixes.
10862 * temporary.c: (restore_dictionary, save_dictionary) Simplified
10863 because now we can mainly copy dictionary structs.
10865 * vars-prs.c: (is_dict_varname, parse_dict_variable,
10866 parse_variables) Takes dictionary instead of indirect_dictionary
10868 (parse_variables) Instead of calling make_indirect_dictionary,
10869 just sets DICT to &default_dict if DICT is NULL. Of course, lots
10870 of `*dict.' references had to be changed to `dict->'. Removed
10873 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
10875 * get.c: Added GTSV_OPT_* series of enums.
10876 (trim_dictionary, dict_delete_run) New functions.
10877 [DEBUGGING] (dump_dict_variables) New function.
10878 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
10879 [DEBUGGING] Calls dump_dict_variables() to display results.
10881 * glob.c: (cmp_variable) Now a public function declared in var.h.
10883 * sfm-read.c: Turned off debug code. Comment fixes.
10884 (read_machine_int32_info, read_machine_flt64_info) New functions
10885 to parse type 7 records.
10886 (sfm_read_dictionary) Properly byteswaps several fields now.
10887 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
10888 records. [DEBUGGING] Dumps dictionary.
10889 (read_variables) Sets `index' field of variables created properly.
10890 Constructs avl tree of variables in dictionary. [DEBUGGING] No
10891 longer dumps dictionary.
10892 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
10894 [DEBUGGING] (dump_dictionary) No longer stubbed out.
10896 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
10897 var before destroying any variables just to save a little time.
10899 * var.h: (struct variable) Reordered in order to make name[] the
10900 first member; this makes pointers to `variable' pointers to the
10901 variable name, simplifying avl trees, etc.
10902 (struct indirect_dictionary) New struct.
10904 * vars-atr.c: (find_variable) Rewritten for efficiency.
10905 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
10907 (is_varname) Rewritten for efficiency.
10908 (parse_variables) New argument, which is a `dictionary *'. All
10909 references changed. This function now reads variable names from
10910 the dictionary passed, or from the default dictionary if NULL.
10912 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
10914 * misc.h: Added new macro DIV_RND_UP to perform integer division,
10915 rounding up. Changed many references to ROUND_UP to use this
10918 * sfm-read.c: Includes avl.h.
10919 (corrupt_msg) Induces a segfault under Checker.
10920 (macro assertive_bufread) New. Many references to bufread() now
10922 (sfm_read_dictionary) Split up into several functions. Added code
10923 to read dictionary records following the the type 2 records. Not
10924 quite complete. New variable `var_by_index'.
10925 (read_header, read_variables) New functions extracted from
10926 sfm_read_dictionary().
10927 (read_value_labels) New function.
10928 (bufread) Checks ferror() if fread() doesn't return the expected
10929 value; if ferror() is zero it's just EOF.
10930 (dump_dictionary) Stubbed out.
10932 * BTW: The source code now exceeds 50000 lines!
10934 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
10936 * command.c: Added GET to cmd_table[].
10938 * list.q: Removed reference to alloca headers.
10939 (cmd_list) Gave prototype.
10941 * sfm-read.c: Added DEBUGGING comments.
10942 (sfm_read_dictionary) Checks bias correctly. Sets
10943 dict->var_by_name to NULL. Calculates long_string_count
10944 correctly. realloc's dict->var[] array to minimum size.
10945 [DEBUGGING] Calls dump_dictionary.
10946 [DEBUGGING] (dump_dictionary) New function.
10948 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
10949 (restore_dictionary) If the dictionary contains a non-NULL
10950 var_by_name, uses that instead of generating one.
10951 (free_dictionary) Destroys var_by_name.
10953 * var.h: (struct dictionary) Added field `var_by_name'.
10955 * get.c: New file, not complete.
10957 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
10959 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
10960 (parse_num_or_range) New function.
10961 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
10962 <n> THRU HIGH missing values.
10964 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
10965 __attribute__((const)).
10967 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
10969 * sfm-read.c: Finished reference implementation.
10971 * sfm.h: Includes var.h.
10973 * var.h: Comment fixes.
10974 (struct `variable') Reordered some fields.
10976 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
10977 constants added previously.
10979 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
10981 * common.h: Comment fixes. Added declaration of
10982 `second_lowest_value' as variable or macro. Made `compat_type',
10983 `pgm_state_type' into anonymous enums.
10985 * display.c: Comment fix.
10987 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
10989 [!defined SECOND_LOWEST_VALUE] Added definition for
10990 `second_lowest_value' global var.
10991 (compat, pgm_state global vars) Changed types to `int'.
10992 (init_glob) Initializes `second_lowest_value'.
10994 * sfm-read.c: Continued work, not complete.
10996 * var.h: Added new MISSING_* constants to handle LOWEST and
10999 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
11001 * sfm-read.c: New file, not complete.
11003 * cases.c: (vec_insert) Changed vector expansion algorithm.
11004 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
11005 mucking up the RECODE transformation in particular.
11006 (envector) Harmless change in notation.
11008 dfm is now fairly well tested again.
11009 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
11011 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
11013 * recode.c: Comment fix.
11015 * sfm.h: Interface should be fairly final now, or at least for a
11018 * vfm.c: [DEBUGGING] (index_to_varname) New function.
11019 (open_active_file) [DEBUGGING] Translates ccase indices into
11020 variable names now to make it easier to understand what's really
11023 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
11025 * data-in.c: Comment fix.
11027 * data-list.c: Includes dfm.h.
11028 (do_reading) Uses new function dfm_push_cust().
11030 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
11031 `return 1;' at end.
11033 * file-handle.h: Completely changed. Some parts split off into
11034 new file dfm.h. Implemented in file-handle.q.
11035 (enum FH_*) Removed.
11036 (struct fh_ext_class) New struct.
11037 (struct file_handle) Retained only these fields: name, norm_fn,
11038 fn, recform, lrecl, mode. New fields class, ext.
11039 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
11040 close_handle, handle_name) Added `fh_' prefix to name, all
11041 references changed.
11043 * dfm.h: New file, implemented in dfm.c.
11044 (get_record, put_record, fwd_record, bkwd_record, set_record,
11045 get_cur_col) Functions moved from file-handle.h, now prefixed with
11047 (dfm_push_cust) New function.
11049 * sfm.h: New file. Incomplete.
11051 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
11052 interface. Functions reordered, comments changed. Not well
11053 tested, probably full of bugs.
11054 (struct dfm_fhuser_ext) New struct.
11055 (dfm_close) New function.
11056 (open_file_r) Pickier about finding `BEGIN DATA.' line.
11057 (open_file_w) User messages changed.
11058 (get_record) Comment fixed.
11059 (read_record) Increments ext->ln even for inline_file. Calls
11060 dfm_close() for inline_file when `END DATA.' encountered.
11061 (dfm_get_record) Experimental restructuring.
11062 (dfm_push_cust) New function.
11063 (cmd_begin_data) Detects whether the inline file was fully read by
11064 checking whether it is still open; detects whether it was read at
11065 all by checking whether the line number is greater than zero.
11067 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
11068 interface. Functions reordered, comments changed. Not well
11069 tested, probably full of bugs.
11070 (init_file_handle) Removed initializers for obsolete fields, added
11072 (fh_close_handle) Much simpler, now mainly calls the class
11074 (fh_init_files) Renamed inline file internal filename.
11076 * file-type.c: Includes dfm.h.
11077 (read_from_file_type) Doesn't use dfm internal state anymore.
11079 * inpt-pgm.c, print.c: Include dfm.h.
11081 * recode.c: (internal_cmd_recode) Casts strlen() return value to
11082 int in comparison with other int.
11084 * som-high.c: (build_target) Fixed operator precedence problem in
11085 if statement (& versus ==).
11087 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
11089 * dfm.c: (read_record) Can now read fixed-length records; not
11091 (put_record) Can now write fixed-length records; not tested.
11093 * file-handle.h: FH_* defines changed to enums. New enum series
11095 (struct file_handle) New members recform, lrecl, mode.
11097 * file-handle.q: Parser changed.
11098 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
11099 /LRECL subcommands. These are compatible with Windows.
11100 (init_file_handle) Initializes recform, mode fields.
11102 * q2c.c: (get_line) When outputting `!' comment lines, now
11103 increments the output file line number so that `#line' directives
11105 (make_identifier) New function that converts an arbitrary string
11106 into a valid C identifier.
11107 (dump_vars) Calls make_identifier() in two places in order to
11108 suppress some errors for bad identifiers.
11109 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
11110 for NO. Allows numbers to be prefixed by underscores to make them
11111 acceptable C identifiers but still to be parsed as numbers by the
11114 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
11116 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
11118 * dfm.c: Comment fixes. (get_record) Gives error if file handle
11119 was opened for writing.
11120 (open_file_w) New function.
11121 (read_record) Uses strncasecmp if available. Improved error
11122 messages, comments.
11123 (put_record) New function.
11125 * file-handle.h: Moved function comments into dfm.c and
11126 file-handle.q. Comment fixes. Removed declarations of
11127 tilde_expand() and normalize_filename().
11128 (struct file_handle) Changed `open' from boolean to enumerated
11129 field to allow for three states--closed, open for reading, open
11130 for writing--all references changed.
11132 * file-handle.q: Includes filename.h.
11134 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
11135 references changed.
11136 (alloc_line) Makes allowance for line terminator characters in
11138 (print_trns_proc) Now handles OUTFILE, WRITE differences.
11139 (print_space_trns_proc) Handles OUTFILE differences.
11141 * recode.c, sample.c: Comment fixes.
11143 * var.h: (struct print_trns) Changed boolean field `eject' to
11144 bitmapped field `options'; all references changed. New enums
11145 PRT_* for use with this field.
11147 * exception.h, test-exception.c: Removed.
11149 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
11151 * ascii.c: (delineate) Turned off debug output.
11153 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
11156 * data-in.c: (parse_string_as_format) Sets the entire string value
11157 to spaces, not just the short string part of it. Is this correct
11160 * data-out.c: (convert_date) Fixed DATETIME format problems with
11161 decimal places, removed debug code.
11163 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
11164 middle of parsing BEGIN DATA that would cause the lexer to read
11165 from a wild pointer `prog'; now calls new function
11166 preprocess_line() in lexer.c.
11168 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
11170 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
11171 Now call induce_segfault() to induce the segfault.
11172 (induce_segfault) New function.
11174 * expr-opt.c: Comment fix.
11175 (parse_sysvar) New function.
11176 (parse_primary) Added system variable support--calls
11178 (global var ops) Added OP_CASENUM operator.
11180 * expr.h: Comment fixes.
11181 (OP_* enum) added OP_CASENUM operator.
11182 (struct casenum_node) New struct.
11183 (union any_union_union) New member `cas' of type `casenum_node'.
11185 * glob.c: (global var last_vfm_invocation) New var.
11186 (init_glob) Initializes last_vfm_invocation.
11188 * lexer.c: (lookahead) Fixed reversed condition on if statement.
11190 * getline.c: (get_line) Split into get_line() and preprocess_line().
11191 (preprocess_line) New function.
11193 * var.h: Declares last_vfm_invocation.
11195 * vfm.c: (procedure) Sets last_vfm_invocation.
11197 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
11199 * command.c: (parse_cmd) Fixed bad assertion related to
11202 * data-in.c: (parse_month) Implemented to parse months according
11203 to full interpretation of standard.
11204 (to_roman) New function.
11205 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
11206 (parse_weekday) Bug fix (forgot to skip all the day name).
11208 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
11209 up parsing of multirecord data items. Also fixed user message.
11211 * data-out.c: Comment fix.
11212 (year2, year4, convert_date, convert_time, convert_WKDAY,
11213 convert_MONTH) New functions to support time & date output.
11214 (convert_format_to_string) Calls new time & date output routines.
11216 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
11218 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
11221 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
11223 * misc.c: (global var formats) Fixed declarations of DATETIME,
11226 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
11227 the output_char buffer.
11229 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
11230 memory bug. Fixed user messages.
11232 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
11234 * Removed #pragma argsused from lots of places.
11236 * data-in.c: Implemented zoned decimal and time-date formats.
11237 Untested. This is a huge chunk of code--maybe 1000 lines and 50
11240 * data-out.c: Implemented zoned decimal format.
11242 * expr.h: Moved yrmoda() declaration here from exprP.h.
11244 * misc.c: (global var formats) Minor fixes--added
11245 FCAT_SHIFT_DECIMAL to formats N and Z.
11246 (convert_fmt_ItoO) Added support for format Z.
11248 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
11250 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
11252 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
11253 som_check_workspace() that is activated between commands.
11255 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
11258 * list.q: (begin_row) Changed title expansion style from
11259 SOPT_X_VERT to SOPT_X_SHSP.
11261 * som-frnt.c: Now includes `somP.h'.
11262 (som_push_workspace, som_pop_workspace) New functions that, taken
11263 together, form a solution to the recursive table building problem
11264 mentioned yesterday. Surrounded every table output routine
11265 throughout the program with calls to these functions.
11266 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
11267 (som_create_table) Checks that there's an active workspace.
11268 (som_destroy_all_tables, som_crush) Removed.
11270 * som-high.c: (global var som_preserve_tables) Removed, all
11271 references deleted.
11272 (som_submit_table) Checks that there's an active workspace.
11273 (dump_columnated_table) Doesn't columnate tables that would have
11274 just one row per column.
11275 (dump_crush_page, som_dump_crush_page) Removed debugging code.
11276 (som_dump_crush_page) Moved row number labels from left side of
11277 tables to right side.
11278 (som_get_table_size) Added support for SOPT_X_SHSP.
11280 * som.h: New cell expansion type SOPT_X_SHSP.
11282 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
11284 (global var curtab_arena) Moved from som-frnt.c.
11286 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
11288 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
11289 that causes bad location warnings to be suppressed.
11290 (delineate) Saves current font when calling draw_text(); fixed
11291 handling of NULLs when backing up. Also fixed line-wrapping bug.
11293 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
11294 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
11296 * common.c: Added code to cause assertion failure to dump core
11297 when run under Checker.
11299 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
11300 there are still bugs.
11302 * glob.c: (__eprintf) Removed.
11304 * list.q: Inserted som_preserve_tables kluge that prevents tables
11305 from being thrown away due to recursive table building through
11306 som_output_line being called from a transformation during the LIST
11307 procedure invocation. This is a general problem that must be
11308 solved in a better way since it applies to all procedures in
11310 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
11311 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
11313 * numeric.c: Fixed several errors in the form of msg() calls.
11315 * print.c: Updated for use of som.
11316 (dump_table) Reimplemented.
11317 (print_trns_proc) Calls som_eject_page() instead of eject_page().
11318 Calls som_output_text() instead of outs_line().
11320 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
11322 (som_output_text) Function moved from som-low.c. Interface
11325 * som-high.c: (som_preserve_tables) New global public variable
11327 (som_submit_table) Destroys the tables only if som_preserve_tables
11329 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
11330 one subrow per row. Now labels subrows if there's more than one
11332 (dump_crush_table) Added wishlist comment.
11333 (som_eject_page) New public function declared in som.h.
11335 * som-low.c: (som_dump_crush_page) Draws row labels if there's
11336 more than one subrow per row.
11337 (som_output_text) Moved to som-frnt.c.
11339 * som.h: (SOM_TOPT_PRESERVE) Removed.
11341 * title.c: (get_title) Changed interface.
11342 (cmd_title) Changed `title' to `outp_title'.
11343 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
11345 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
11347 * list.q: (flush_table) Conforms to new partial options in
11348 som_submission_form.
11350 * som-high.c: (paginate_horizontally) Changed form of subrow
11352 (build_target) Omits spacing before table if
11353 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
11354 (dump_crush_page) Changed interface. Only trims bottom rule if
11355 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
11356 (dump_crush_table) Handles partial tables.
11357 (output_row_label) New function.
11358 (som_dump_crush_page) Emits subrow number labels. Draws vertical
11359 rule on the right edge of narrow subrows.
11361 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
11362 constants to a series of SOM_TOPT_PARTIAL_* submission options.
11363 All references updated.
11365 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
11367 * misc.c: Comment fix.
11369 * som-high.c: (examine_table) Treats crushed tables separates for
11370 purpose of determining header size.
11371 (paginate_horizontally) Allots space for line numbers in crushed
11372 tables with lots of subrows per row. Calculates the `maximum page
11373 width', the width of the widest horizontal page.
11374 (build_target) Removed trim argument; all references changed.
11375 Stricter assertions. (dump_crush_page) New function.
11376 (dump_crush_table) Reimplemented.
11378 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
11379 (som_dump_crush_page) Reimplemented, interface changed.
11381 * somP.h: Many many new helper macros for use with crushed tables.
11382 (global var som) Removed `tv', `cum_y' members; all references
11383 removed. New members `mpw', `digit_space'.
11385 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
11387 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
11388 variable, changed to constant 1024.
11389 (arena_ca_strdup) Changed `sizeof(a_string)' to
11390 `sizeof(c_string)'.
11391 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
11392 `(c_string *)' to `(char *)'; this fixed some offset problems.
11394 * filename.c: (readlink_malloc) Changed initial allocation from
11396 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
11399 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
11400 &fm->owner in several places.
11402 * som-high.c: (output_table) Changed interface to rest of world.
11403 (examine_crush_table) Removed. Crushed tables are re-broken now,
11404 in preparation for rewrite.
11406 * som.h: Comment fix.
11408 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
11410 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
11411 itself in the cleanup stage.
11413 * descript.q: (display) At least temporarily, changed the table
11414 format to a crushed table.
11416 * list.q: (begin_row) At least temporarily, added horizontal lines
11419 * som-high.c: (examine_crush_table) Sets som.hh to the width of
11420 the horizontal "headers," that is, to the width of the far left
11421 and far right rules.
11422 (justify_pagination) Sets som.th to the width of the widest row
11423 in the crushed table. Fixed inner loop off-by-one error.
11425 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
11428 * somP.h: Comment fix.
11430 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
11432 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
11433 before closing it; also, opens the constructed filename `s'
11434 instead of f->filename.
11436 * postscript.c: Moved initialization of x->loaded, x->prop,
11437 x->fixed, x->current, also the add_encoding() calls, into
11439 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
11440 sets x->last_font to NULL; sets x->next_combo to zero.
11442 * som-high.c: (crushed_row_height) Moved definition farther up.
11443 (som_submit_table) Doesn't calculate line width, font size until
11444 after calling open_page(), to accomodate changes to PostScript
11446 (vert_headers) Removed; equivalent functionality moved to
11447 examine_table(), examine_crush_table().
11448 (justify_pagination) Replaced with different algorithm.
11449 (dump_crush_table) Bugfix that caused tables to fail to be clipped
11450 at the bottom of the page.
11452 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
11454 * command.c: Added cmd_list back into cmd_table.
11456 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
11457 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
11459 * list.q: (flush_table) Updated to new som_submission_form format.
11461 * som-frnt.c: Comment fix.
11463 * som-high.c: Changed `#endif' to `#undef EXTERN'.
11464 (output_table) Calls som_get_table_size() directly; handles
11466 (examine_crush_table) New function; calls vert_headers().
11467 (examine_table) Moved some code into new function, vert_headers().
11468 (justify_pagination) New function.
11469 (dump_plain_table) Removed `static' from `cy'.
11470 (dump_crush_table) New function.
11472 * som-low.c: (som_dump_crush_page) New function.
11474 * som.h: Comment fixes.
11475 (enum SOM_TOPT_CRUSH) New.
11476 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
11477 Temporarily set to zero to make do with LIST procedure.
11479 * somP.h: Re-ordering.
11481 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
11483 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
11485 * somP.h: New file for use by som-high.c, som-low.c.
11487 * q2c.c: Added definition for VME.
11488 (get_line) Now dumps `!' comment lines to the output file
11491 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
11492 set.q: Changed format of `!' comment lines.
11494 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
11496 * All source files: Added copyright notice.
11498 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
11499 longs in msg() calls.
11501 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
11503 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
11505 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
11507 * output.c: (outp_read_devices) Changed criteria for
11508 distinguishing different types of lines.
11510 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
11512 * cmdline.c: Changed syntax message.
11514 * filename.c: (good_getcwd) Bug fix (?).
11515 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
11517 (search_path) Appends DIR_SEPARATOR to directory name only if it
11518 does not already end with one.
11520 * glob.c: Checks STAT_PAGER envvar before PAGER.
11522 * output.c: Checks environment variables instead of just local
11525 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
11527 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
11528 when the pointer passed to the function was within the arena
11529 itself, so that it couldn't properly be set to NULL _after the
11532 * command.c: Re-enabled DISPLAY.
11534 * display.c: Rewritten to handle tables. Untested.
11536 * filename.c: (search_path) Fixed memory leak.
11538 * frequencies.q: (cmd_frequencies) Frees v_variables.
11539 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
11540 (cleanup_freq_tab) New function to garbage collect.
11541 (dump_full) Elegantized.
11543 * main.c: New comment.
11545 * output.h: New tag for tagged quotes: TAG_NEWLINE.
11547 * postscript.c: Comment fix.
11548 (release_fontmap, free_font_entry) New functions.
11549 (ps_init_driver) Sets free_font_entry() as the freefunc for
11550 hashtable `loaded'. Calls release_fontmap() when destroying a
11551 driver; also frees the output filename; also frees the
11552 ps_driver_ext block.
11553 (free_ps_encoding) Frees the filename as well as the encoding
11555 (output_encodings) Frees the line buffer and pops the msg-filename
11557 (read_fontmap) Frees the fontmap filename and the line buffer.
11558 (postopen, preclose) Misc. garbage collection fixes.
11559 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
11560 to NULL; this fixes some output problems.
11561 (text) Handles TAG_NEWLINE. Untested.
11563 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
11564 (som_set_string) Removed. All references changed to
11566 (som_set_text) Rewritten. New interface. More general.
11568 * som.h: Minor format changes.
11569 (struct som_value_cell) Removed; all references changed to
11571 (enums SOT_*) Changed.
11573 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
11575 * command.c: Re-enabled SPLIT FILE.
11577 * postscript.c: Comment fix.
11579 * som.h: Added `SOT_NONE'.
11581 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
11583 * vfm.c: (dump_splits) Reimplemented.
11585 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
11587 * Compiled the project under gcc 2.7.2, which gave some new
11588 warnings. This led to many additions of casts from unsigned to
11589 int sprinkled throughout the code.
11591 * arena.c: Many uses of `unsigned' changed to `size_t'.
11593 * command.c: Added END FILE, END REPEAT to command table.
11594 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
11595 (find_command, FILE_TYPE_okay) Not commented out anymore.
11596 (parse_cmd) Calls FILE_TYPE_okay again.
11597 (output_line) Added calls to som_output_text() to put the line
11598 in the output files.
11600 * common.c: (macro VME) Format changes.
11601 (xstrdup) Asserts that its argument is not NULL.
11603 * data-list.c: Implemented dump_fixed_table().
11605 * inpt-pgm.c: Formatting changes. Comment changes.
11606 (end_case_proc) Renamed end_case_trns_proc.
11607 (cmd_end_file, end_file_trns_proc) New functions.
11609 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
11611 * misc.h: (local_strdup) New macro corresponding to strdup() but
11612 allocating its data through local_alloc() if possible--that is, if
11615 * postscript.c: Comment changes.
11616 (quote_ps_name, quote_ps_string, output_encodings) New functions.
11617 (output_line, add_string) New macros supporting
11618 output_encodings().
11619 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
11620 substitution vars. Calls output_encodings() when a line
11621 consisting of `!encodings' is encountered.
11622 (preclose) Some code moved into quote_ps_string().
11623 (dump_line) Changed into macro supporting dump_fancy_line().
11624 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
11625 command when appropriate.
11626 (write_text) Fixed `literal_char' array (I think it's fixed, at
11628 (text) Fixed bug when width was zero. Now exits immediately on
11629 zero height_left. Now, when executing `goto restart;', checks
11630 that cp<end, so that we don't read beyond end-of-string. Also,
11631 outputs the correct code to the output file by outputting the code
11632 from the metric instead of the internal metric index.
11634 * repeat.c: (cmd_end_repeat) New function.
11636 * som.c: (var som) `headers' renamed `options' and semantics
11637 changed. All references changed.
11638 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
11639 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
11641 (som_text_table) Removed.
11642 (som_output_text) New function.
11644 * som.h: (struct som_submission_form) Removed `header', `reuse',
11645 replaced with bitmapped field `options'.
11646 (SOM_TOPT_*) New enum set for som_submission_form.options.
11647 (SOT_*) New enum set for som_output_text().
11649 * temporary.c: (copy_variable) When copying the var label, only
11650 calls xstrdup() if it's non-NULL.
11652 * var.h: (enum type `vartype') Removed; all references changed to
11655 * vars-atr.c: (init_variable) Changed local var `nbytes' from
11658 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
11660 * font.h: Comment changes.
11662 * groff-font.c: (groff_read_font) Initializes `name' field to
11663 NULL. Handles `encoding' field.
11665 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
11667 * postscript.c: (struct font_entry) Removed `position' field.
11668 (struct ps_font_combo) New struct.
11669 (struct ps_driver_ext) Removed field `next_position'. New fields
11670 `combos', `next_combo'. `last_font' field changed from
11671 `font_entry *' to `ps_font_combo *'.
11672 (ps_init_driver) Reformatted; handles new fields. When
11673 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
11675 (get_encoding, find_encoding_file) New functions.
11676 (add_encoding) Some code moved out into find_encoding_file().
11677 (postopen) Changed value for ${title}.
11678 (preclose) Sets `loaded' field to NULL after destroying the hash
11680 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
11682 (ps_text_set_font_by_position) Figures out the current family if
11684 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
11685 (switch_font) Implemented.
11686 (write_text) Calls switch_font() more often. Format changes.
11687 #undefs its macros after they're no longer useful.
11688 (text) Changed `continue' at one point to a jump to the top of the
11689 loop because we don't want `separate' reset to 0 at that point.
11690 (load_font) No longer sets `position' in the font_entry created.
11692 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
11694 * font.h: (struct font_desc) New member `encoding', which is not
11695 properly handled yet.
11697 * glob.c: (init_glob) Some new i18n code, which is probably
11700 * output.c: (outp_read_devices, outp_get_paper_size) Changed
11701 `size' local from `int' to `size_t'.
11703 * postscript.c: New driver configuration parameter `auto-encode'.
11704 New enums OPO_AUTO_ENCODE, ODA_COUNT.
11705 (struct font_entry) New member `position'.
11706 (struct ps_driver_ext) Reordered. New hash table member
11707 `encodings'; new members `next_position', `next_encoding',
11708 `last_font'. Members `current', `prop', `fixed' changed from type
11709 `font_desc *' to `font_entry *'; all references changed.
11710 (struct ps_encoding) New struct.
11711 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
11712 free_ps_encoding, add_encoding) New functions.
11713 (ps_init_driver) Added OPO_AUTO_ENCODE to default
11714 x->output_options. Initializes new members of ps_driver_ext.
11715 Changed default value for prologue_fn, encoding_fn. Calls
11716 read_ps_encodings after loading default fonts.
11717 (option_tab[], ps_option) Handle new configuration parameter.
11718 (switch_font) New function.
11719 (struct output_char) `font' member changed from `font_desc *' to
11720 `font_entry *'. New member `separate'.
11721 (read_fontmap) Changed `size' from `int' to `size_t'.
11722 (output_line, put_number) New macros for write_text().
11723 (write_text) Optimizes text output by consolidating multiple
11724 calls to PostScript `show' operator.
11725 (text) Keeps track of when text arguments can't be consolidated by
11726 write_text(), and marks those spots in the output stream.
11727 (load_font) Sets `position' of the allocated font_entry to -1, cuz
11728 the font hasn't been switched to by switch_font(), which is where
11729 the position is important--the PostScript is what cares about the
11732 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
11734 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
11735 call a NULL free_func.
11736 (hsh_rehash) Elegantized.
11737 (hsh_probe) Fix bug that manifested when the table was expanded
11738 and thus had to change location in memory. Good thing
11739 too--otherwise could have been much more subtle.
11740 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
11741 (hsh_foreach) New function for hash table iteration.
11743 * hash.h: (struct hsh_iterator) New.
11745 * lexer.c: (parse_tagged_quote) Font and family name strings in
11746 tags are now null-terminated.
11748 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
11750 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
11751 documented. (Never before tested?)
11753 * output.h: Comment changes.
11755 * postscript.c: New driver options `optimize-text-size',
11756 `optimize-line-size', `max-fonts-simult'. New enum set for
11757 specing cached line types. Comment fixes.
11758 (struct line_form) New struct.
11759 (struct ps_driver_struct) New members `text_opt', `line_opt',
11760 `max_fonts', `lines'.
11761 (ps_init_driver) Initializes new members of ps_driver_struct.
11762 (user option type enum set) New member `nonneg_int_arg'.
11763 (static var option_tab[]) Supports new options.
11764 (ps_option) Handles new options.
11765 (find_ps_file) Made static. No longer calls hsh_dump().
11766 (ps_get_var) Made static.
11767 (preclose) Dumps out proper DSC trailer.
11768 (ps_open_page) Elegantized.
11769 (ps_close_page) Calls dump_lines() if appropriate.
11770 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
11771 wrappers around line().
11772 (int_2_compare, compare_line, dump_line, dump_fancy_line,
11773 dump_lines, hash_line, free_line, line) New functions for support
11775 (write_text, text) Made static.
11776 (text) Added to font support, not finished.
11778 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
11780 * font.h: (struct font_desc) New members ascent, descent.
11782 * groff-font.c: (groff_read_font) Calculates font ascent and
11783 descent from the ascent and descent of the `d' and `p' characters,
11784 respectively, as per a suggestion on comp.fonts.
11786 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
11787 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
11789 (write_text) Handles text right-justification and centering (not
11790 full justification). Still very inefficient. (One output line
11792 (struct output_char) Added fields for font and font size.
11793 (text) Many bugfixes.
11795 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
11797 * cmdline.c: (usage) Calls outp_list_classes().
11799 * font.h: Comment fix.
11801 * groff-font.c: New exported global var `space_index'.
11802 (groff_init) New function to initialize `space_index'.
11803 (hash_kern) Casts result to unsigned.
11804 (font_name_to_index) Renamed font_char_name_to_index. All
11805 references changed. Also, now returns the value of `space_index'
11806 when passed an ASCII space character as an argument. Fixed
11808 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
11809 Handles passed NULL pointers properly.
11811 * lexer.c: (parse_tagged_quote) Comment fix. Better range
11814 * output.c: (outp_list_drivers) Removed. Removed all references.
11816 * output.h: Comment fixes.
11818 * postscript.c: (ps_open_global) Calls groff_init().
11819 (output_char) New structure.
11820 (write_text) New function.
11821 (text) No longer stubbed out! Now the output is correct--with a
11822 few exceptions, one of them being that the page has to be held
11823 upside down into a mirror.
11825 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
11827 * font.h: Comment fix.
11829 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
11830 All callers changed.
11831 (number_to_index) Renamed font_number_to_index, made extern. All
11833 (font_get_kern_adjust, font_get_char_metrics) New functions.
11835 * output.h: New constant OUTP_T_INTERNAL_DRAW.
11837 * postscript.c: Changed default line width back to 1/2 point.
11838 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
11839 in the center of the space allotted for them, not just a fixed
11840 offset from the edge of the space; this fixes some bugs.
11841 (ps_line_intersection) Now supports all command line styles.
11842 (ps_text_get_size) Bug fix in computation of em width.
11843 (text) New function, the meat behind ps_text_metrics and
11844 ps_text_draw. Not complete.
11845 (ps_text_metrics, ps_text_draw) Removed the stub taken from
11846 ascii.c; call text().
11848 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
11850 * arena.c: (arena_free) Assert that the argument is non-NULL.
11852 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
11853 only if old_kern is non-NULL.
11855 * postscript.c: (ps_init_driver) Changed default line width to 1
11857 (postopen) New prologue variables.
11858 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
11859 more of the common line styles properly, but not all.
11860 (ps_text_metrics) Fixed problem with this stubbed out version that
11861 kept it from taking font sizes into account.
11863 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
11865 * arena.c: (arena_malloc) Bug fix.
11866 (arena_dump) [GLOBAL_DEBUGGING] New function.
11868 * ascii.c: Comment fix.
11869 (count_fancy_chars, delineate) Now static functions.
11871 * filename.c: (interp_vars) Bug fixes.
11873 * font.h: Comment fixes.
11875 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
11876 beginning in case we have an error message to display before
11877 initializing the display.
11879 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
11881 (groff_read_font) Bug fixes.
11882 (name_to_index) Increments hash.used. Sets `name' field of hash
11884 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
11886 * hash.c: Return type changed.
11888 * postscript.c: Continued development. Now marks lines on the
11889 paper, but very buggy.
11891 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
11893 * Changed comments in many source files from `/* xxx /* yyy */' to
11894 `/* xxx */ /* yyy */' for cleanliness.
11896 * arena.c: (arena_sd_strdup) New function.
11898 * ascii.c: (struct ascii_driver_ext) New member `file'.
11899 (ascii_init_driver) Fills out member `file' for initing; uses
11900 close_file_ext for closing drivers.
11901 (ascii_option) Changed %.*s back to %s because the a_string's are
11902 always null-terminated.
11903 (postopen, preclose) New functions.
11904 (ascii_open_page) Uses new style of open_file_ext.
11905 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
11906 instead of this->output.
11907 (__assert_fail) Removed.
11909 * cmdline.c: Changed syntax_message[].
11911 * error.c: #include's <readline/history.h> only if the history
11912 library is available, not if just the readline library is
11915 * filename.c: (expand_line) Removed alloca() support.
11916 (interp_vars) No longer tilde-expands argument. Limit on output
11918 (tilde_expand) Now treats argument as path rather than filename.
11919 [!unix] Now is a no-op function.
11920 (search_path) Better verbose message formatting.
11921 (open_file, close_file) Comment fixes.
11922 (close_file) [!unix] Doesn't bother with pipes.
11923 (open_file_ext) Completely rewritten, interface revamped.
11924 (close_file_ext) New function.
11926 * font.h: Comment changes.
11928 * frequencies.q: Removed AIX alloca support since it doesn't use
11931 * hash.c: Comment changes & additions.
11932 (hsh_create) Initializes entire table instead of first M entries.
11933 (hsh_probe) Stupid bug fixed. Now it works.
11934 (hsh_dump) [GLOBAL_DEBUGGING] New function.
11936 * main.c: (parse) Detects EOF properly in token-eating loop.
11937 Should the STOP token have its value changed to 0?
11939 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
11940 (blp_getline) Now it's a macro.
11942 * output.h: (struct outp_driver) Removed members output, filename.
11944 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
11945 drivers in driver table.
11946 (outp_read_devices) Frees buf. Warns if there are no active
11948 (outp_configure_clear) Sets outp_configure_vec to NULL after
11949 deleting its elements.
11950 (configure_driver, destroy_driver) Removed references to output,
11951 filename members of outp_driver.
11952 (outp_evaluate_dimension, internal_get_paper_size,
11953 outp_get_paper_size) New functions.
11955 * postscript.c: Continued development. Now links but doesn't make
11956 any marks on the page. Lotsa bugs I suppose.
11958 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
11960 * str.h: Comment changes.
11962 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
11964 * Removed dependencies on non-nested comments in several files.
11965 Also removed references to (unix || __unix__) in #if's since
11966 prefh.orig makes those two equivalent.
11968 * ascii.c: (ascii_open_global) Creates ascii_arena.
11969 (ascii_close_global) Destroys ascii_arena.
11970 (ascii_init_driver) Doesn't create ascii_arena.
11971 (ascii_copy_driver) Removed.
11972 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
11973 (outp_class ascii_class) Removed ascii_copy_driver reference.
11975 * frequencies.q: Now can display all statistics except median.
11976 Still not finished.
11978 * output.c: Handles outp_class.ref_count so output class
11979 destructors are called properly.
11980 (add_class) Sets ref_count to 0.
11981 (configure_driver) Initializes class if ref_count++ is 0.
11982 (destroy_driver) Destructs class if --ref_count is 0. Frees the
11983 class output file name.
11985 * output.h: (struct outp_class) Removed copy_driver, inited.
11988 * postscript.c: Completely replaced but not finished.
11990 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
11992 * approx.h: #includes <float.h>.
11994 * arena.h, arena.c: Many functions changed to take an arena **
11995 instead of an arena *, for consistency. All callers changed.
11996 (arena_alloc) Now creates a new arena if passed *A that is NULL.
11997 (arena_destroy) Sets *A to NULL.
11999 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
12000 assertion that `width' be positive.
12002 * command.c: Removed #if's from cmd_table.
12003 (walk_cmdtable_func) [0] New function (debug code).
12004 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
12005 (parse_cmd) Doesn't return failure for unimplemented commands.
12007 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
12008 (SYSCODE) New constant macro.
12010 * descript.q: Checks for positive n_variables before performing
12013 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
12014 avl_find instead of &fp as arg 2.
12016 * frequencies.g, frequencies.q: Continued updating; now compiles &
12017 works again, but not complete.
12019 * main.c: Changes to user messages.
12021 * misc.c: (reverse) [0] New function.
12023 * settings.h: Comment removed. #includes "common.h".
12025 * som.c: (som_set_null) New function.
12026 (som_set_value, som_set_string, som_set_text) More detailing
12028 (som_set_float) Implemented function.
12029 (dump_columnated_table) Bug fix regarding page breaks.
12030 (draw_cell) Bug fix regarding text that spilled out of a cell.
12031 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
12033 (get_cell_size) Support SCON_EMPTY cells.
12034 (get_table_size) When calculating rules' widths and heights, mask
12035 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
12037 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
12039 (struct som_submission_form) New member `header'; all users
12042 * val-labs.c: (get_label) User messages changed.
12044 * var.h: Changed FREQUENCIES structures.
12046 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
12049 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
12051 * approx.h: Definition of EPSILON now depends on system's
12052 DBL_EPSILON. Removed GNU C specific code.
12053 (cmpapx) Renamed approx_compare.
12055 * frequencies.g, frequencies.q: Continued updating; still doesn't
12058 * groff-font.c: (name_to_index) Fix bug that kept it from
12061 * hash.c, hash.h: Completed work.
12063 * var.h: Changes to freq_tab, frequencies_proc.
12065 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
12068 * hash.c, hash.h: New files. Not completed.
12069 * Makefile.am: Added hash.c to source file list.
12070 * font.h: (struct font_desc) New member kern_size_p.
12071 * groff-font.c: Uses hash.h.
12072 (hashpjw) Moved to hash.c.
12073 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
12075 (static var hash) New member size_p.
12076 * var.h: Includes hash.h.
12077 (struct freq_tab) Changed AVL_TREE to hash_tab.
12079 * vars-prs.c: Comment, formatting fixes.
12081 * frequencies.g, frequencies.q: Continued updating. Not yet
12084 * formats.c: Bug fix.
12086 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
12088 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
12089 * descript.g: Comment fixes.
12090 * descript.q: Comment fixes. Moved some declarations into var.h.
12091 Made dsc_info a static table. Updated FIXMEs.
12092 (internal_cmd_descriptives) Beautified.
12094 * frequencies.q: Started updating into working order.
12095 * frequencies.g: New file analogous to descript.g.
12096 * var.h: Comment fixes. Added structures for FREQUENCIES.
12098 * som.c: Removed vestiges of crushing and partial table support.
12100 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
12102 * Many more changes to som.c especially, but these will not be
12103 documented as I have resolved to remove them. This patchlevel is
12104 being released solely so that I can fall back to it if I decide
12105 that removing the changes is not a good idea.
12107 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
12109 * som.c: (global var som) New member `cum_y'.
12110 (build_target) Properly handles titles for partial tables.
12111 (dump_partial_beg, dump_partial_mid, dump_partial_end)
12112 Merged into single new function dump_partial(). Fixed problem
12113 with titles on partial tables.
12114 (dump_table) Calls dump_partial() for all parts of partial tables.
12115 (dump_page) Criteria for drawing title changed.
12117 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
12119 * command.c: (cmd_table) Added LIST, WEIGHT.
12121 * command.c: (cmd_remark) No longer frees `s' since it's not
12122 dynamically allocated.
12124 * data-out.c: (convert_f) Now correctly handles the case where
12125 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
12126 number of decimals.
12127 (som_destroy_all_tables) Removed argument. All callers changed.
12128 (som_vline, som_hline) Argument validity checking corrected.
12129 (som_set_value) Implemented half-heartedly.
12130 (replicate_table) Copies tables piece-by-piece when using Checker.
12132 * som.h: New line style SLIN_1THIN, currently equivalent to
12133 SLIN_0. New enum set SOM_SUB_*.
12134 (struct som_submission_form) Removed `seq_no'. Added `type'.
12136 * list.q: Newly working file; uses partial tables.
12138 * som.c: (som_reduce_table) Renamed som_set_table_height().
12139 (som_crush) Removed argument `group'.
12140 (global var som) Removed `nt', `seq_no'. Added `type'.
12141 (som_submit_table) Arguments changed.
12142 (output_table) Removed partial table code.
12143 (build_target) New arg; partial table support added. All callers
12145 (dump_plain_table) Removed partial table code.
12146 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
12147 (dump_table) Supports partial tables.
12148 (dump_page) New argument to allow not drawing top and/or bottom
12149 headers. All callers changed. Supports partial tables.
12151 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
12153 * data-out.c: Changed `#include <approx.h>' to `#include
12155 (convert_F) Comment fix. Now won't print `-.000', etc.
12157 * descript.q: Now Z-scores work, although there appears to
12158 be a bug (which might actually be in data-out.c:convert_F()).
12159 (descriptives_trns_proc, descriptives_trns_free) New functions.
12160 (run_z_pass) Implemented.
12162 * var.h: Comment fixes.
12163 (dsc_z_score, descriptives_trns) New structs.
12164 (descriptives_trns) Added to any_trns as `dsc'.
12166 * error.c, error.h: New error class, IS (Installation Script
12167 error), used in those instances where the error is in the
12168 installation, but there is a script file or installation file that
12169 can be usefully referred to.
12171 * output.c: Change many IE classes to IS classes.
12173 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
12174 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
12175 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
12176 include the corresponding header?
12178 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
12179 Don't bail out if termcap can't be read.
12181 * som.c: (som_destroy_table) Removed.
12182 (som_reduce_table, som_destroy_all_tables) New functions.
12183 (som_crush) New function, not implemented.
12185 * som.h: New table option STAB_CRUSH. Comment fix. New struct
12186 som_submission_form. Function prototypes revised.
12188 Outputting huge tables (1000s of rows) a few rows at a time
12189 is supported, though untested. May even break everything.
12190 Actually, the code doesn't even compile right now.
12191 * som.c: (struct som) New fields htv, nt, seq_no.
12192 (som_submit_table) Multiple arguments changed to a single
12193 pointer to struct submission_form. Only increments subtable_num
12194 if seq_no is zero. Only destroys table if it's not going to
12196 (replicate_table) New function.
12197 (output_table) Comment fix.
12198 (examine_table) Changed inline code to code calling
12199 replicate_table(). Calculates htv. Supports partial tables.
12200 (draw_title) Removed comment.
12201 (build_target) Only allows for title on first part of partial
12203 (dump_plain_table) Only resets table chunk number on first part
12204 of partial tables; FIXME: doesn't work quite right. Supports
12206 (dump_page) Titles only on first part of partial tables.
12208 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
12210 * Thanks to an unreliable IDE hard drive, I have spent the last
12211 day reconstructing my Debian GNU/Linux installation and redoing
12212 the previous day's changes--somehow I managed to save every file
12213 except for output.c and output.h. So the following changes could
12214 really be considered independent of the output.c, output.h changes
12217 * output.h, output.c: Moved the outp_configure_vec global var,
12218 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
12219 outp_configure_vec is now static.
12221 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
12223 * The entire philosophy behind configuration of the output drivers
12224 changed. Now there is a termcap-type configuration where drivers
12225 to be read are determined beforehand, rather than parsing the
12226 entire output init file and storing it in memory & deciding what
12227 to actually use later. Faster & more memory-efficient at the same
12230 * output.c: Comment fix. Removed outp_init_drivers global var.
12231 Removed all references to synonyms. New structure outp_defn. New
12232 global vars outp_macros, outp_configure_vec.
12233 (search_name, delete_name, add_name, check_configure_vec,
12234 expand_name, find_defn_value) New static functions.
12235 (outp_configure_clear, outp_configure_add, outp_configure_macro,
12236 outp_read_devices) New extern functions.
12237 (outp_init) Much functionality moved into outp_read_devices.
12238 (outp_read_devices) Format of output init file changed; name of
12239 file is `devices' rather than `output' to avoid Makefile
12241 (outp_clear) Renamed outp_done.
12242 (outp_list_classes) Bug fix, cleaned up.
12243 (outp_list_drivers) Not implemented anymore.
12244 (outp_configure_driver) Now a static function; simplified; now
12245 interpolates macros; supports new structure.
12246 (outp_enable_driver, match_synonym) Removed; all references
12248 (find_driver) First argument removed.
12250 * output.h: Global var outp_init_drivers removed; new structure
12251 outp_names; new enum set OUTP_S_*; new global var
12252 outp_configure_vec; function prototypes for output.c exports
12255 * main.c: (main) Calls outp_read_devices() after parsing the
12258 * cmdline.c: (parse_command_line) New option -v --verbose;
12259 --version changed to -V. --device option changed syntax to just
12260 take a single device name. Accepts key=value declaration of
12261 output init file macros. Syntax message updated.
12263 * filename.c: (expand_line) New function.
12264 (interp_environ_vars) Renamed interp_vars; no longer uses
12266 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
12267 overridden by real environment vars.
12268 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
12269 * filename.h: interp_environ_vars() renamed interp_vars().
12271 * error.c, error.h: Added extern variable `verbosity', message
12274 * error.c: (vmsg) Support message class MM.
12275 (verbose_msg) New function.
12277 * descript.q: (generate_z_varname) Bug fix in generation of
12279 (dump_z_table) Bug fix in column headers.
12281 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
12282 page from 29 to 15. Don't set a default for ops[OPS_INIT,
12283 OPS_DONE]. Writes the uninit string when the driver is closed.
12284 (ascii_open_page) Write the init string before the first page.
12285 (output_shorts) Form of main loop changed from `while' to `for'.
12286 Bug fix with overstrikes: the character is printed *after* the
12287 backspace. Eliminated a lot of `& 0xff' modifiers.
12288 (advance_to_left_margin) New function.
12289 (return_carriage, output_lines) Handle left margin.
12291 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
12293 * ascii.c: New option `carriage-return-style'.
12295 * ascii.c: (count_fancy_chars) New function.
12296 (delineate, text_metrics) Use new function; bug fixes regarding
12298 (text_draw) Bug fix with rich text.
12299 (output_string, output_shorts) Reordered.
12300 (output_shorts) Now handles boxchars and some overstrike font
12302 (output_char, return_carriage) New functions.
12303 (output_lines) Now handles overstriking and font changes properly;
12304 some code moved to output_shorts.
12306 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
12309 * ascii.c: New member `debug' in ascii_driver_ext.
12310 (ascii_init_driver, delineate) Uses new member.
12312 Now you can set a vertical height on writing text.
12313 * ascii.c: (delineate) Keeps track of vertical position.
12314 (text_draw) No longer considers fully justified text an internal
12317 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
12319 Tables' titles are drawn; they can have variable height.
12320 * som.c: `som' struct has new member, title_height.
12321 (draw_title) New argument. Moved within file. All caller
12323 (build_target) New argument, amount of space needed for first row.
12324 Calculates height of title, takes that into account. All callers
12326 (dump_plain_table, dump_columnated_table) Took calculation of y1,
12328 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
12330 (dump_columnated_table) Organized for readability.
12331 (dump_page) Makes use of som.title_height.
12333 * som.c: Many comment bug fixes.
12335 * descript.q: (try_name, generate_z_name) Bug fix regarding
12336 generation of Z-score variable names.
12337 * var.h: Removed num from descriptives_proc; all referents removed.
12339 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
12341 * ascii.c: (ascii_line_horz, ascii_line_vert,
12342 ascii_line_intersection) Added debugging code.
12344 Added a descriptive line above each table to describe it.
12345 * command.c: (parse_cmd) Calls som_new_series.
12347 * som.c: New static vars table_num, subtable_num. New `som'
12349 (dump_page) New arguments.
12350 (som_submit_table) Handle new variables.
12352 * som.c, som.h: (som_submit_table) New arguments. All callers
12354 (som_new_series) New function.
12355 (build_target) Makes room for extra line.
12356 (draw_title) New function.
12357 (dump_page) Calls draw_title. Bug fix: doesn't always set
12360 Columnation of tables support.
12361 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
12363 * som.c: Deleted references to fr, lr, ri.
12364 (som_columnate) Bux fix: sets group member of table.
12365 (som_add_options) Function removed.
12366 (dump_table) Split into three functions; extensively reworked.
12368 * descript.q: (dump_z_table) Better output table formatting; added
12369 title support to correspond to som.h changes.
12370 (display) Title support.
12372 * output.h: Added OUTP_T_NONE.
12374 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
12376 * descript.q: Improved handling of Z scores; still not perfect.
12378 * output.h, ascii.c: Added hook for getting em width of current
12381 * som.c: Uses new em-width hook. Added debugging code to
12383 (som_columnate) New argument.
12384 (som_add_options) Removed.
12386 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
12388 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
12389 rules as a property of the table instead of as a property of the
12392 * ascii.c: Added `header' to table of options.
12394 * descript.q: Added even shorter statistic names; modified to work
12395 with new som interface.
12397 * misc.c (blp_getdelim): Bug fix.
12399 * version.c: includes 'conf.h'.
12401 ----------------------------------------------------------------------
12404 version-control: never
projects / pspp-builds.git / blob