1 Sun May 1 15:05:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
3 * error.c: Added a string for the compiler version to the
4 request_bug_report_and_abort function.
6 * groff_font.c, font.c: Removed manpage(1) style references from
7 comments, because RMS frowns upon them.
9 Thu Apr 28 18:52:06 2005 Ben Pfaff <blp@gnu.org>
11 * expressions/parse.c: Improve previous fix for PR 12858 (LAG).
13 Fri Apr 29 09:28:00 WST 2005 John Darrington <john@darrington.wattle.id.au>
15 * expressions/parse.c: Added handler for OP_LAG_Vn and OP_LAG_Vs.
18 Wed Apr 27 12:42:34 WST 2005 John Darrington <john@darrington.wattle.id.au>
20 * loop.c recode.c repeat.c: Fixed a couple of instances of SHORT_NAME_LEN
21 which should be LONG_NAME_LEN
23 Wed Apr 27 07:43:50 WST 2005 John Darrington <john@darrington.wattle.id.au>
25 * command.def echo.c: Added the ECHO command.
27 Mon Apr 25 22:55:59 2005 Ben Pfaff <blp@gnu.org>
29 Finish fixing MATCH FILES (PR 11677).
31 * get.c: (trim_dictionary) Rewrite in terms of drop_variables(),
32 keep_variables(), rename_variables().
33 (drop_variables) New function.
34 (keep_variables) New function.
35 (struct mtf_file) Rename `in' to `in_name'. Add `in_var'.
36 (cmd_match_files) Deal with in_var. Use drop_variables(),
37 keep_variables(). When IN is specified, require BY. Set master
38 variables after master dictionary is complete. Add IN variables
39 after master dictionary is complete.
40 (mtf_free_file) Free `in_name'.
41 (mtf_delete_file_in_place) Set in_var value to 0.
42 (mtf_read_nonactive_records) Rephrase.
43 (mtf_processing) Support IN. Rephrase. Fix bugs.
44 (mtf_merge_dictionary) Don't set master variables; we do that
46 (get_master) Don't insist that there's a master variable.
48 Mon Apr 25 22:55:22 2005 Ben Pfaff <blp@gnu.org>
50 Kluge to make some variable renaming sort of work.
53 * dictionary.c: (dict_rename_var) Call dict_add_longvar_entry().
55 Mon Apr 25 22:52:28 2005 Ben Pfaff <blp@gnu.org>
57 Add functions for comparing sets of variables between cases.
60 * case.c: (case_compare) New function.
61 (case_compare_2dict) New function.
63 * aggregate.c: (struct agr_proc) Remove `prev_break' member. Add
65 (cmd_aggregate) Nullify break_case. Don't call
66 initialize_aggregate_info().
67 (agr_destroy) Destroy break_case.
68 (aggregate_single_case) Rewrite. Use case_compare().
69 (dump_aggregate_info) Copy from break_case into output.
70 (initialize_aggregate_info) Copy break_case from input.
72 * get.c: (mtf_compare_BY_values) Use case_compare_2dict().
74 * vfm.c: (equal_splits) Use case_compare().
76 Sat Apr 23 17:01:04 WST 2005 John Darrington <john@darrington.wattle.id.au>
78 * dictionary.c vars-prs.c sfm-write.c: Fixed some memory leaks
80 Sun Apr 17 23:08:15 2005 Ben Pfaff <blp@gnu.org>
82 Start work on fixing MATCH FILES.
84 * get.c: (enum operation) Remove OP_MATCH.
85 (trim_dictionary) Change return value to bool. Don't support
87 (struct mtf_file) Remove `first', `last' members.
88 (struct mtf_proc) Add `first', `last' members. Change mtf_case
89 from `struct ccase *' to `struct ccase'. Remove `by' member.
90 (cmd_match_files) Essentially rewrite.
91 (mtf_free) Don't free `by' member. Destroy `mtf_case' member.
92 (mtf_read_nonactive_records) mtf_ parameter is not unused.
93 (mtf_processing) Ditto. Also rephrase some code.
94 (mtf_merge_dictionary) Rewrite for easy comprehension.
96 Sun Apr 17 23:06:00 2005 Ben Pfaff <blp@gnu.org>
98 * matrix-data.c: (wr_output_data) [DEBUGGING] Fix compilation
101 * q2c.c: (dump_token) [DEBUGGING] Fix compilation error.
103 Thu Apr 14 2005 John Darrington
105 * var-display.c: New file.
107 * format.h var.h sfm-read.c sfm-write.c dictionary.c : Added
108 display_width, measure and alignment parameters to variables.
110 * aggregate.c command.def compute.c count.c data-list.c descript.c
111 dictionary.c dictionary.h expr-prs.c file-type.c flip.c get.c
112 lexer.c lexer.h loop.c modify-vars.c pfm-read.c recode.c repeat.c
113 sfm-read.c sfm-write.c sfm-write.h sfmP.h val-labs.c val.h var.h
114 vars-prs.c vector.c :
115 - Replaced literal constants representing maximum variable name
116 length with macro definitions.
117 - Added support for long variable names.
118 - Changed lexer such that it no longer makes tokens upper
119 case, but relies upon case insensitive behaviour of commands.
121 Mon Apr 4 22:27:34 2005 Ben Pfaff <blp@gnu.org>
123 * aggregate.c: (parse_aggregate_functions) If dict_create_var()
124 fails, don't dereference the resulting null pointer (PR 12427).
125 Also, fix double free error.
127 Sat Mar 19 23:06:02 2005 Ben Pfaff <blp@gnu.org>
129 * aggregate.c: (parse_aggregate_functions) Fix N_NO_VARS format.
130 (accumulate_aggregate_info) Set int1 to 1 for SUM.
131 (dump_aggregate_info) Only make SUM non-missing if there was at
134 Sat Mar 19 14:48:19 2005 Ben Pfaff <blp@gnu.org>
136 * aggregate.c: (dump_aggregate_info) Properly test whether the
137 destination variable is numeric, when making the result
138 system-missing for columnwise missing values.
140 Mon Mar 14 21:52:34 2005 Ben Pfaff <blp@gnu.org>
142 * misc.h: Remove GCC specializations.
144 Mon Mar 14 21:07:23 2005 Ben Pfaff <blp@gnu.org>
146 Make sort stable (PR 12313).
148 * sort.c: Don't need to include some headers anymore.
149 (static var min_buffers) New variable.
150 (static var max_buffers) New variable.
151 (static var allow_internal_sort) New variable.
152 (cmd_sort_cases) Add test mode.
153 (sort_execute) Rephrase.
154 (do_internal_sort) Don't try internal sorting if
155 allow_internal_sort is set.
156 (struct external_sort) Renamed `initial_runs' to `runs' and
157 updated all references.
158 (macro MIN_BUFFER_TOTAL_SIZE_RECS) Removed.
159 (macro MIN_BUFFER_SIZE_BYTES) Removed.
160 (macro MIN_BUFFER_SIZE_RECS) Removed.
161 (compare_initial_runs) Removed.
162 (struct record_run) Add member `idx'.
163 (write_initial_runs) Pass increasing values to process_case() as
165 (process_case) Add `idx' parameter and use it to initialize new
167 (allocate_cases) Limit allocated buffers to max_buffers.
168 (compare_record_run) Use new `idx' member for last resort
169 comparison, for stability.
170 (end_run) Call casefile_sleep() on irs->casefile, to prevent
171 running out of file descriptors.
172 (struct merge_state) Removed.
173 (merge) Don't need to allocate cases. Always use MAX_MERGE_ORDER
174 unless we have fewer runs left. Always merge consecutive runs,
175 for stability. Return the final run.
177 (choose_merge) New function.
178 (merge_once) Rewritten.
180 Mon Mar 14 21:05:42 2005 Ben Pfaff <blp@gnu.org>
182 * cmdline.c: (static var testing_mode) Move into
183 parse_command_line().
185 Mon Mar 14 21:05:13 2005 Ben Pfaff <blp@gnu.org>
187 * algorithm.c: (remove_range) New function.
188 (remove_element) New function.
190 * dictionary.c: (dict_delete_var) Use remove_element().
192 * flip.c: (cmd_flip) Ditto.
195 Sun Mar 13 22:52:05 2005 Ben Pfaff <blp@gnu.org>
197 * file-handle.q: (struct file_handle) `open_mode' should not be
200 Sun Mar 13 22:40:54 2005 Ben Pfaff <blp@gnu.org>
202 First phase of making SORT CASES stable (PR 12313).
204 * sort.c: (struct indexed_case) New structure.
205 (do_internal_sort) Rewrite to make internal sorting stable.
206 (compare_case_dblptrs) Removed.
207 (compare_indexed_cases) New function.
209 Sun Mar 13 22:38:40 2005 Ben Pfaff <blp@gnu.org>
213 * casefile.c: (casereader_read_xfer_assert) New function.
215 * dictionary.c: (dict_compact_case) New function.
217 * flip.c: (struct flip_pgm) New member idx_to_fv.
218 (cmd_flip) Initialize idx_to_fv member.
219 (destroy_flip_pgm) Free idx_to_fv member.
220 (flip_sink_write) Use struct flip_pgm member instead of case_sink
222 (flip_sink_write) Ditto.
224 * vfm.c: (write_case) Use dict_compact_case() instead of
226 (compact_case) Removed.
227 (storage_source_create) Removed `dict' parameter. All references
230 * vfm.h: (struct case_source) Removed `value_cnt' member. All
232 (struct case_sink) Removed `dict', `idx_to_fv' members. All
235 Sun Mar 13 22:35:55 2005 Ben Pfaff <blp@gnu.org>
237 More AGGREGATE fixes.
239 * aggregate.c: (accumulate_aggregate_info) Implement NMISS and
240 NUMISS for strings. Fix FOUT, POUT, FGT, FLT, FIN, FOUT for
242 (initialize_aggregate_info) Fix initialization for MIN, MAX for
246 Sat Mar 12 23:26:21 2005 Ben Pfaff <blp@gnu.org>
248 Start work on testing and debugging AGGREGATE.
250 * aggregate.c: (cmd_aggregate) Use discrete bool variables instead
251 of a bit-map. Require proper subcommand ordering. Make OUTFILE
252 subcommand mandatory.
253 (parse_aggregate_functions) Check that PIN, POUT, FIN, FOUT
254 functions' arguments are in the correct order and swap them if
256 (accumulate_aggregate_info) Make SUM include weights. Add various
258 (dump_aggregate_info) Add various string functions.
259 (initialize_aggregate_info) Initialize int1 for MIN, MAX.
261 * sort.c: (sort_parse_criteria) Add parameter for returning
262 whether any directions were specified. All callers updated.
264 Sun Mar 13 14:54:27 WST 2005 John Darrington <john@darrington.wattle.id.au>
266 * t-test.q: Fixed erroneous logic in compare_group_binary.
268 Sat Mar 12 13:29:21 2005 Ben Pfaff <blp@gnu.org>
270 * split-file.c: (cmd_split_file) Ignore LAYERED and SEPARATE
273 Sat Mar 12 13:17:12 2005 Ben Pfaff <blp@gnu.org>
275 * vfm.c: (procedure_with_splits) Fix PR 11492: end_func() must be
276 called *before* close_active_file().
278 Sat Mar 12 12:20:57 2005 Ben Pfaff <blp@gnu.org>
280 * file-handle.q: (struct file_handle) Change open_mode from
281 character pointer to 3-char array, for safety. Updated all
284 Sat Mar 12 12:15:49 2005 Ben Pfaff <blp@gnu.org>
286 Thanks to Ben Kujala <bkujala@oregonchildcare.org> for reporting
289 * pfm-read.c: (read_header) Improve error message for many cases
290 in which the input is not actually a portable file.
292 * file-handle.q: (fh_open) When we give an error message, actually
295 Fri Mar 11 11:50:30 2005 Ben Pfaff <blp@gnu.org>
297 * format.c: (check_common_specifier) New function for checks
298 common to check_input_specifier() and check_output_specifier().
299 (check_input_specifier) Use check_common_specifier().
300 (check_output_specifier) Use check_common_specifier().
301 (check_string_specifier) Removed.
302 (check_specifier_type) New function.
303 (check_specifier_width) New function.
304 (get_format_var_width) Fix bug.
306 * formats.c: (internal_cmd_formats) Only accept numeric variables.
308 * lexer.c: (check_id) Rename lex_id_to_token(), make public,
309 update all references. Make case-insensitive.
311 * pfm-read.c: Essentially rewrite the whole file. Now much
314 * print.c: (check_string_width) New function.
315 (fixed_parse_compatible) Use check_string_width(),
316 check_specifier_type().
317 (dump_fmt_list) Ditto.
319 * str.c: (st_trim_copy) New function.
320 (st_uppercase) New function.
322 * vars-atr.c: (var_is_valid_name) New function.
324 * expressions/parse.c: (type_coercion_core) Use
325 check_specifier_type().
327 Fri Mar 11 11:31:24 2005 Ben Pfaff <blp@gnu.org>
329 * expressions/evaluate.c: (cmd_debug_evaluate) Fix memory leaks.
331 * expressions/parse.c: (no_match) Ditto.
333 Wed Mar 9 09:54:27 2005 Ben Pfaff <blp@gnu.org>
335 * Makefile.am: (pspp_LDADD) Add libgsl-extras.a.
337 * expressions/helpers.c: (struct func_params) Removed.
338 (generalized_idf) Removed.
341 (idf_fdist) Use gslextras_cdf_beta_Pinv() instead of idf_beta().
343 * expressions/operations.def: Implement IDF.BETA, CDF.BINOM,
344 CDF.GEOM, CDF.HYPER, CDF.NEGBIN, CDF.POISSON using gsl-extras.
345 Implement SIG.F, which I had overlooked previously.
347 Tue Mar 8 12:47:53 WST 2005 John Darrington <john@darrington.wattle.id.au>
349 * command.c command.def glob.[ch] cmdline.c: Made DEBUG cmds
350 available only in testing mode.
352 Sun Mar 6 23:25:40 2005 Ben Pfaff <blp@gnu.org>
354 * data-in.c: Use `bool' throughout, where relevant.
356 Sun Mar 6 19:52:22 2005 Ben Pfaff <blp@gnu.org>
358 DATA LIST with free-field formats should not have implied decimal
359 places (PR 12035). Also clean up data-in.c a bit.
361 * data-in.h: (enum) Add DI_IMPLIED_DECIMALS.
363 * data-in.c: (apply_implied_decimals) New function.
364 (parse_numeric) Don't adjust exponent if DI_IMPLIED_DECIMALS not
365 set. Also, get rid of gotos.
366 (parse_Z) Use apply_implied_decimals() if the field doesn't
367 contain a decimal point.
368 (parse_N) Use apply_implied_decimals().
374 (parse_enum) New function.
375 (macro CHAR_IS_ROMAN) Removed.
376 (macro ROMAN_VALUE) Removed.
377 (parse_month) Use parse_enum().
378 (parse_weekday) Use parse_enum().
379 (parse_DATETIME) Use long for weekday.
381 * data-list.c: (read_from_data_list_fixed) Use
384 Sun Mar 6 17:07:20 2005 Ben Pfaff <blp@gnu.org>
386 When the lexer sees something like `-5' in the input, it has to
387 decide whether it's a negative numeric constant token or a '-'
388 token followed by a positive numeric constant token. It always
389 decides on the former, and then the parser can call
390 lex_negative_to_dash() if it wants the latter. However, this
391 doesn't work for the case of `-0', because negative zero is
392 (portably) indistinguishable from positive zero. So now we divide
393 T_NUM into two tokens, T_POS_NUM and T_NEG_NUM, to make the
394 distinction clear. This requires a little bit of extra effort,
395 because there were several references to T_NUM in the code base.
397 * lexer.c: (lex_get) Use T_NEG_NUM and T_POS_NUM to distinguish
398 positive and negative numeric constants.
399 (lex_double_p) Renamed lex_is_number(). Changed return type to
400 bool. Updated all relevant references to T_NUM to instead use
402 (lex_double) Renamed lex_number(). All references updated.
403 (lex_integer_p) Renamed lex_is_integer(). Changed return type to
404 bool. All references updated.
405 (lex_token_representation) Understand T_NEG_NUM and T_POS_NUM.
406 (lex_negative_to_dash) Ditto.
409 * lexer.h: (enum) Add T_POS_NUM, T_NEG_NUM. Remove T_NUM.
411 Sun Mar 6 22:09:20 2005 Ben Pfaff <blp@gnu.org>
413 * expressions/operations.def: (NUMBER) Use DI_IMPLIED_DECIMALS.
415 Sun Mar 6 19:33:24 2005 Ben Pfaff <blp@gnu.org>
417 * expressions/operations.def: (VEC_ELEM_NUM) Treat user-missing
418 values as system-missing.
420 * expressions/parse.c: (parse_vector_element) Fix order of
421 arguments in call to expr_allocate_binary().
423 Sun Mar 6 17:51:05 2005 Ben Pfaff <blp@gnu.org>
425 * expressions/optimize.c: (optimize_tree) Fix optimization bug for
428 * expressions/parse.c: (type_coercion_core) Set *node to NULL on
429 failure, as indicated by function comment.
430 (parse_binary_operators) Always return NULL on type_coercion()
431 failure. Should have been doing this anyway, but bug in
432 type_coercion_core() filtered through.
433 (parse_add) Fix typo in user message.
434 (parse_primary) Understand T_NEG_NUM and T_POS_NUM.
436 Sun Mar 6 10:47:13 2005 Ben Pfaff <blp@gnu.org>
438 * expressions/operations.def: Add VALUE function.
440 * expressions/parse.c: (parse_function) Need an unary composite
441 node for variables in A TO B, not a variable node. Use
442 allocate_unary_variable().
443 (parse_primary) Use allocate_unary_variable().
444 (allocate_unary_variable) New function.
446 Thu Mar 3 23:53:32 2005 Ben Pfaff <blp@gnu.org>
448 * expressions/PSPP_expressions.pm: Renamed it back to generate.pl
449 but fixed the real problem that was preventing the build from a
450 separate directory. I liked it my way better ;-)
452 Thu Mar 3 23:17:51 2005 Ben Pfaff <blp@gnu.org>
454 * expressions/parse.c: (expr_parse) Fix parameter type. Thanks to
455 John Darrington <john@darrington.wattle.id.au> for reporting this
458 Thu Mar 3 22:10:25 WST 2005 John Darrington <john@darrington.wattle.id.au>
460 * expressions/Makefile.am expressions/evaluate.h.pl
461 expressions/evaluate.inc.pl expressions/operations.h.pl
462 expressions/optimize.inc.pl expressions/parse.inc.p:
464 Renamed generate.pl to PSPP_expressions.pm and adjusted *.pl
467 Fixed everything so that it can be built from an arbitrary
470 Thu Mar 3 22:08:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
472 * Makefile.am : Fixed up CLEANFILES target.
474 Mon Feb 28 23:49:56 2005 Ben Pfaff <blp@gnu.org>
476 * str.h: Changed `struct len_string' to `struct fixed_string', a
477 more accurate name. Updated all references.
479 Mon Feb 28 23:35:30 2005 Ben Pfaff <blp@gnu.org>
481 Redo calendar support. Should now be bug-for-bug compatible.
483 * calendar.c: New file.
485 * calendar.h: New file.
487 * data-in.c: Use new calendar functions.
488 (parse_sign) Change sense of return value.
489 (calendar_error) New function.
490 (ymd_to_ofs) New function.
491 (ymd_to_date) New function.
492 (parse_DATE) Use new function.
502 (parse_DATETIME) Ditto.
504 * data-out.c: (convert_date) Use new calendar functions.
506 * error.c: (err_vmsg) Changed interface to be more sensible.
508 (dump_message) Don't double new-lines (why did we do this
511 Mon Feb 28 23:30:25 2005 Ben Pfaff <blp@gnu.org>
513 * sfmP.h: (macro flt64) Moved here from pref.h.orig.
514 (macro FLT64_MAX) Moved here from pref.h.orig.
516 Mon Feb 28 23:28:01 2005 Ben Pfaff <blp@gnu.org>
518 * set.q: Support SET EPOCH.
519 (static var set_epoch) New var.
520 (aux_stc_custom_epoch) New function.
521 (stc_custom_epoch) New function.
522 (get_epoch) New function.
523 (stc_custom_pager) [USE_INTERNAL_PAGER] Fix bug.
525 * format.c: Make it possible just to check whether a specifier is
526 valid without emitting an error message.
527 (parse_format_specifier_name) Change interface, update all
529 (check_input_specifier) Ditto.
530 (check_output_specifier) Ditto.
531 (parse_format_specifier) Ditto.
533 Mon Feb 28 23:24:08 2005 Ben Pfaff <blp@gnu.org>
535 * command.def: Add DEBUG POOL.
537 * pool.c: (pool_destroy) Fix bug in deleting this pool from its
539 (pool_clear) Properly account for size of pool gizmo.
540 (pool_realloc) Ditto.
541 (pool_clone) New function.
543 * pool.h: Mark our allocation functions MALLOC_LIKE.
545 Mon Feb 28 23:21:26 2005 Ben Pfaff <blp@gnu.org>
547 * Makefile.am: Move many definitions into new top-level
548 Make.build. Add expressions to SUBDIRS. Add calendar.c,
549 calendar.h. Remove expr-evl.c, expr-opt.c expr-prs.c, expr.h,
552 * case.c: (case_resize) New function.
553 (case_swap) New function.
555 * casefile.c: Include mkfile.h.
557 Fri Feb 25 21:11:35 WST 2005 John Darrington <john@darrington.wattle.id.au>
559 * sfm-read.c: Fixed a buglet which caused a crash when trying
560 to read a non-existent file.
562 Sun Feb 13 16:11:13 2005 Ben Pfaff <blp@gnu.org>
566 * aggregate.c: (parse_aggregate_functions) Code cleanup.
567 Important part: get rid of spurious copying of function->format to
568 destvar->print and destvar->write.
570 Fri Feb 11 00:08:36 2005 Ben Pfaff <blp@gnu.org>
572 Fix PR 11916, which was confusing a variable's `index' member
573 with the variable's position in a var_set. Although these are
574 usually the same, they are not for array `var_set's.
576 Took advantage of this bug as an opportunity to clean up and
577 rewrite parse_var_set_vars().
579 * vars-prs.c: (parse_vs_variable_idx) New function.
580 (parse_vs_variable) Reimplement in terms of
581 parse_vs_variable_idx().
582 (parse_var_idx_class) New function.
583 (add_variable) New function.
584 (add_variables) New function.
585 (parse_var_set_vars) Rewritten.
586 (struct var_set) Change `lookup_var' member that returns a
587 variable into `lookup_var_idx' member that returns an int.
588 Updated the var set implementations in obvious corresponding ways.
589 Used compare_var_ptr_names(), hash_var_ptr_name() just added.
591 Fri Feb 11 00:06:03 2005 Ben Pfaff <blp@gnu.org>
593 Use our global variable compare & hash functions and give them
594 better names. Add similar functions for dealing with double
595 pointers to variables.
597 * vars-atr.c: (compare_variables) Renamed compare_var_names().
598 (hash_variable) Renamed hash_var_name().
599 (compare_var_ptr_names) New function.
600 (hash_var_ptr_name) New function.
602 * t-test.q: (cmd_t_test) Use global compare_var_names(),
604 (compare_var_name) Removed.
605 (hash_var_name) Removed.
607 Fri Feb 11 00:04:39 2005 Ben Pfaff <blp@gnu.org>
611 * dictionary.c: (compare_variable_dblptrs) Rename
612 compare_var_ptrs() and fix it to properly dereference the double
615 Mon Feb 7 09:58:15 WST 2005 John Darrington <john@darrington.wattle.id.au>
617 crosstabs.q examine.q oneway.q q2c.c: Added a q2c feature to
618 declare subcommands as mandatory. Closed bug #11843
620 Sat Feb 5 20:35:10 WST 2005 John Darrington <john@darrington.wattle.id.au>
622 * getline.c command.[ch] command.def: Added (very rudimentary)
623 support for line completion when in interactive mode. Partially
626 Mon Jan 31 09:52:51 WST 2005 John Darrington <john@darrington.wattle.id.au>
628 * examine.q factor_stats.c oneway.q output.c pfm-read.c: Fixed some
629 problems revealed by valgrind.
632 Wed Jan 26 11:44:11 WST 2005 John Darrington <john@darrington.wattle.id.au>
634 * set.q: Affixed a fix to the previous fix such that we'll be OK now
635 whether or not PAGER is set.
637 Wed Jan 26 09:25:54 WST 2005 John Darrington <john@darrington.wattle.id.au>
639 * set.q: Copied the string produced by getenv("PAGER") thus avoiding
640 "invalid free" errors. Hopefully fixes bug #11722
642 * compute.c expr-prs.c: Check that lvalues are populated before
643 attempting to destroy them. Closes bug #11676
645 Tue Jan 25 21:01:43 WST 2005 John Darrington <john@darrington.wattle.id.au>
647 * aggregate.c: Initialised the complete agr_proc structure.
651 Sun Jan 23 23:02:21 2005 Ben Pfaff <blp@gnu.org>
653 * print.c: (print_trns_free) Close the dfm writer if there is one,
654 fixing a memory leak.
656 Mon Jan 24 12:24:36 WST 2005 John Darrington <john@darrington.wattle.id.au>
658 * glob.c oneway.q q2c.c t-test.q vfm.c: Still *more* memory leaks
662 Fri Jan 21 19:54:14 WST 2005 John Darrington <john@darrington.wattle.id.au>
664 * linked-list.[ch] Added
666 * examine.q file-handle.[hq] font.h glob.c groff-font.c postscript.c
667 set.q: Yet more memory leaks
669 Tue Jan 18 23:12:40 WST 2005 John Darrington <john@darrington.wattle.id.au>
671 * t-test.q examine.q : More memory leaks fixed.
673 Tue Jan 18 19:26:59 WST 2005 John Darrington <john@darrington.wattle.id.au>
675 * examine.q factor_stats.[ch] get.c pfm-read.c: Plugged numerous
678 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
680 * ascii.c cartesian.c casefile.c chart.h devind.c
681 examine.q frequencies.q
682 html.c output.h piechart.c plot-chart.c plot-hist.c
684 Integrated the chart rendering into the output stream
685 (currently only works for html).
687 Removed gratuitous use of ifndef NO_CHARTS, and replaced with
688 dummy-chart.c for compiling without charts.
690 * mkfile.[ch] Created.
692 * som.[ch] tab.[ch]: Changed name of som_table to som_entity
693 Added type element so we can tell if it's a chart or a table.
695 * chart.h examine.q piechart.c plot-chart.c plot-hist.c: changed the
696 API of charts to be more like that of tables.
698 Thu Jan 13 21:00:02 WST 2005 John Darrington <john@darrington.wattle.id.au>
700 * casefile.c main.c: Moved the SIGINT handler from casefile.c to
701 main.c. Removed the handler for SIGQUIT.
703 Mon Jan 10 14:43:45 WST 2005 John Darrington <john@darrington.wattle.id.au>
705 * casefile.c: Added a signal handler to delete temp files on
708 * permissions.c Inhibited the PERMISSIONS command when SAFER is on.
710 * command.def Added a lot more unimplemented commands.
712 * copyleft.[ch] cmdline.c Moved legal information to copyleft.c
714 Sat Jan 8 23:58:34 2005 Ben Pfaff <blp@gnu.org>
716 * sort.c: (compare_initial_runs) Needed additional level of
718 (merge_once) Fix plenty of stupid mistakes.
720 Sat Jan 8 23:55:27 2005 Ben Pfaff <blp@gnu.org>
722 * casefile.c: (casefile_sleep) Need to flush_buffer() after
723 calling casefile_to_disk() or we will lose the last block in the
724 file if the casefile started out as disk-based.
725 (casefile_get_reader) Initialize reader->destructive to 0.
726 (cmd_debug_casefile) Add new test pattern.
727 (test_casefile) Define new test pattern to make sure
728 casefile_sleep() works properly.
730 Fri Jan 7 08:00:05 WST 2005 John Darrington <john@darrington.wattle.id.au>
732 * Makefile.am chart.[ch] histogram.[ch] piechart.c (Modified);
733 plot-hist.c plot-chart.c (Added) Reorganised these files in an
734 attempt to seperate the creation and processing of charts from their
737 * examine.q frequencies.q generated charts conditional upon the NO_CHARTS
740 Thu Jan 6 18:48:58 WST 2005 John Darrington <john@darrington.wattle.id.au>
742 * main.c Added a signal handler for SIGFPE
744 * sort.c Somewhat more robust fix to the previous entry.
746 Wed Jan 5 21:23:31 2005 Ben Pfaff <blp@gnu.org>
748 * sort.c: (merge) Fix assertion for proper Huffman merge pattern:
749 0 == 1 modulo 1. See Knuth 5.4.9 (vol. 3, 2nd ed.,
750 pp. 361). Thanks to John Darrington <john@cellform.com.au> for
753 Wed Jan 5 22:42:26 WST 2005 John Darrington <john@darrington.wattle.id.au>
755 * case.h Fixed bug # 11307
757 Wed Jan 5 08:30:48 WST 2005 John Darrington <john@darrington.wattle.id.au>
759 * val-labs.c Fixed bug which caused a crash if VALUE LABELS had
762 Mon Jan 3 17:44:37 2005 Ben Pfaff <blp@gnu.org>
764 * pfm-read.c: (read_variables) Remove direct manipulation of
765 v->aux, which is no longer needed. Fixes PR 11483.
767 Sat Jan 1 19:01:16 WST 2005 John Darrington <john@darrington.wattle.id.au>
769 * data-list.c Fixed a bug in parsing delimiters.
771 * group.c vars-atr.c Fixed buglet in hash/compare functions for alpha
774 * percentiles.c Properly handled calculation of Tukey hinges where
775 the number of data is small.
777 * oneway.q Used the generic value_to_string function for independent
778 variable instead of trying to do it ourselves.
780 * box-whisker.c Fixed a buglet which caused a crash if the number of
784 Fri Dec 31 16:47:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
786 * examine.q box-whisker.c chart.h Implemented boxplots in EXAMINE
788 * percentiles.c Fixed some bugs when calculating percentiles when
789 there's a small number of cases.
791 Wed Dec 29 08:18:08 WST 2004 John Darrington <john@darrington.wattle.id.au>
793 * percentiles.[ch] Added. Calculates percentiles and Tukey hinges
795 * examine.q factor_stats.[ch] Added calculation of percentiles
797 Fri Dec 24 15:09:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
799 * t-test.q Fixed bug #11227 Made t-test work when the independent
802 Sat Dec 11 11:43:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
804 * factor_stats.c Fixed calculation of trimmed mean under various
807 Sat Dec 4 17:14:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
809 * histogram.c chart.[ch] factor_stats.c frequencies.q
811 Added code to calculate sensible histogram ranges and limits.
813 Thu Dec 2 13:37:43 WST 2004 John Darrington <john@darrington.wattle.id.au>
815 * chart.h Updated to reflect many API changes.
817 * cartesian.c chart.c Moved the definitions of chart_write_{xy}scale from
818 cartesian.c and into chart.c
820 * factorstats.[ch] Added the histogram calculations
822 * casefile.c Removed an unused variable.
824 * frequencies.q examine.q histogram.c Reworked the API for
827 * piechart.c Revised the API for piecharts.
829 * var.h Moved the definitions of freq_tab and freq out of var.h
830 and into frequencies.q where they belong.
832 Tue Nov 30 21:10:20 2004 Ben Pfaff <blp@gnu.org>
834 * flip.c: (flip_file) Check for off_t separately from fseeko(),
837 Tue Nov 30 08:47:41 2004 Ben Pfaff <blp@gnu.org>
839 * flip.c: (flip_file) If fseeko() is not available, use long int
840 for off_t. Thanks to "Marshall DeBerry" <mdb@radix.net> for
841 reporting the problem.
843 Mon Nov 29 12:20:59 WST 2004 John Darrington <john@darrington.wattle.id.au>
845 * examine.q factor_stats.[ch] Changed stderr to se_mean to avoid
848 Sun Nov 21 10:32:41 WST 2004 John Darrington <john@darrington.wattle.id.au>
850 * var-labs.c (var_to_string) Now returns null if the variable is null
852 * value-labels.c (value_to_string) Made it return null if either the
853 value or the variable is null.
855 * hash.c (hsh_clear) Fixed a buglet.
857 * examine.q factor_stats.[ch] Largely rewrote, because I'd started
858 with the wrong model.
860 * casefile.[ch] Added a function to return the casereader.case_idx
863 * examine.q Implemented the extreme values results.
865 John Darrington <john@darrington.wattle.id.au>
867 * settings.h set.c glob.[ch] frequencies.q q2c.c error.c lexer.[ch]
868 output.[ch] getline.c
870 Plugged some memory leaks
872 Mon Nov 15 23:47:40 2004 Ben Pfaff <blp@gnu.org>
874 Adopt GSL random number generators, paving the way for providing
875 the complete suite of random number generators on expressions.
877 * Makefile.am: Remove random.c, random.h.
883 * algorithm.c: (algo_default_random) Use GSL functions.
885 * casefile.c: (test_casefile) Use GSL RNG functions.
887 * expr-evl.c: (expr_evaluate) Use GSL RNG functions for OP_NORMAL,
890 * sample.c: (cmd_sample) Use GSL RNG functions.
891 (sample_trns_proc) Ditto.
893 * set.q: (static var set_seed) Removed.
894 (static var seed_flag) Removed.
895 (static var rng) New variable.
896 (aux_stc_custom_seed) No seed value anymore, don't print anything.
897 (stc_custom_seed) Use new seed functions.
898 (seed_is_set) Removed.
899 (get_rng) New function that composes the entire external
901 (set_rng) New function.
902 (random_seed) New function.
904 Mon Nov 15 22:08:25 2004 Ben Pfaff <blp@gnu.org>
906 * expr-evl.c: (expr_evaluate) Fix XDATE.JDAY formula. Thanks to
907 John Darrington <john@darrington.wattle.id.au> for reporting this
910 Tue Nov 16 13:19:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
912 * permissions.c command.def Added the PERMISSIONS command
914 Mon Nov 15 01:33:32 2004 Ben Pfaff <blp@gnu.org>
916 * q2c.c: (dump_header) Don't try to emit #includes at very top of
917 output file because that will precede #include <config.h>, which
919 (main) Add needed headers to /* (header) */ code.
921 Mon Nov 15 01:21:36 2004 Ben Pfaff <blp@gnu.org>
923 Instead of making system or portable file readers responsible for
924 dropping and reordering variables, make them read full cases and
925 let the caller take care of any changes.
927 * get.c: New "case map" structure to handle this. Use for GET,
928 IMPORT, MATCH FILES. Essentially rewrite the whole file.
930 * pfm-read.c: (pfm_read_case) Read into provided case. Signature
931 changed appropriately.
933 * sfm-read.c: (sfm_read_case) Ditto.
935 Mon Nov 15 00:47:45 2004 Ben Pfaff <blp@gnu.org>
937 Decided that case_serialize() and case_unserialize() were too
938 abstract. Also we need a couple more functions to avoid excessive
939 copying for data in/out fast paths.
941 * case.c: (case_serial_size) Removed.
942 (case_serialize) Rename case_to_values() and make its argument
943 explicitly an array of union values.
944 (case_unserialize) Rename case_from_values() and make its argument
945 explicitly an array of union values.
946 (case_data_all) New function.
947 (case_data_all_rw) New function.
949 * casefile.c: (struct casefile) Change buffer from array of
950 unsigned char to array of union value for better accuracy.
951 Redefine buffer_used and buffer_size in terms of values, not
952 bytes. Remove case_size because it is now redundant with
953 value_cnt. Fix up all references to these members.
955 Mon Nov 15 00:45:46 2004 Ben Pfaff <blp@gnu.org>
957 * barchart.c: (struct subcat) Make `label' member const to silence
958 GCC warning with -Wwrite-strings.
960 * cartesian.c: (struct dataset) Ditto.
962 * case.c: Don't re-define NDEBUG if already defined.
963 Add lots of comments.
965 * str.c: Fix includes.
967 * crosstabs.q: Fix includes.
969 * examine.q: Fix includes. Fix GCC warning about unused
972 * frequencies.q: (stat macro) Removed and replaced where used by
975 * list.q: Fix includes.
977 * oneway.q: Fix includes.
979 * piechart.c: Fix includes. Only define M_PI if not already
982 * sfm-read.c: (bswap) New function.
983 (bswap_int32) Write in terms of bswap.
986 * str.c: (ds_data) Add external definition here, needed because
987 str.h has only an `extern inline' version.
989 * value-labels.c: Fix includes.
991 Mon Nov 15 00:40:55 2004 Ben Pfaff <blp@gnu.org>
993 Instead of providing a system or portable file writer with a raw
994 case in the format needed for output, provide it with a regular
995 case. The writer takes care of any needed translation.
997 * aggregate.c: Adopt new scheme for AGGREGATE.
998 (struct agr_proc) sfm_agr_case member removed.
999 (write_case_to_sfm) Removed because the new interface is easier to
1002 * get.c: Adopt new scheme for SAVE, XSAVE, EXPORT.
1004 * pfm-write.c: Implement new scheme.
1006 * sfm-write.c: Ditto.
1008 Mon Nov 15 00:32:24 2004 Ben Pfaff <blp@gnu.org>
1010 Instead of treating `struct file_handle' as a class to subclass
1011 into data files, system files, and portable files, instead use it
1012 as a helper that coordinates access. Now it is opaque, too.
1014 This means that most references to a struct file_handle are now
1015 changed into references to one of struct dfm_reader, struct
1016 dfm_writer, struct sfm_reader, struct sfm_writer, struct
1017 pfm_reader, or struct pfm_writer, according to what's being read
1020 Most related changes are only worth summarizing briefly.
1022 * dictionary.c: (dict_clear) Destroy aux data in deleted
1024 (dict_clear_aux) New function.
1025 (dict_create_var) Initialize aux, aux_dtor.
1026 (dict_delete_var) Destroy aux data in deleted variable.
1028 * file-handle.h: (struct fh_ext_class) Removed.
1029 (struct file_handle) Removed.
1030 (fh_init_files) Removed.
1032 * file-handle.q: Changed references to a handle's `private' member
1033 to direct references.
1034 (struct private_file_handle) Renamed file_handle.
1035 Add next, open_cnt, type, open_mode, aux members.
1036 (struct file_handle_list) Removed.
1037 (extern var inline_file) Removed.
1038 (static var file_handles) Changed from file_handle_list * to
1040 (create_file_handle) Initialize new members.
1041 (fh_close_handle) Removed.
1042 (mode_name) New function.
1043 (fh_open) New function.
1044 (fh_close) New function.
1045 (fh_parse_file_handle) Renamed fh_parse().
1047 * glob.c: (init_glob) Remove fh_init_files() call.
1049 * aggregate.c: use sfm_writer.
1050 (create_sysfile) Removed because the new interface is simpler.
1052 * apply-dict.c: Use sfm_reader.
1054 * data-list.c: Use dfm_reader.
1056 * file-type.c: Use dfm_reader.
1058 * get.c: Use sfm_reader, sfm_writer, pfm_reader, pfm_writer.
1060 * inpt-pgm.c: Use dfm_reader.
1062 * print.c: Use dfm_writer.
1064 * sysfile-info: Use sfm_reader.
1066 * dfm-read.c: Adopt new file handle infrastructure.
1068 * dfm-write.c: Ditto.
1070 * pfm-read.c: Ditto.
1072 * pfm-write.c: Ditto.
1074 * sfm-read.c: Ditto.
1076 * sfm-write.c: Ditto.
1078 Mon Nov 15 00:31:44 2004 Ben Pfaff <blp@gnu.org>
1080 Break dictionary functions into separate header file.
1082 * dictionary.h: New file.
1084 * var.h: Moved dict_*() functions to dictionary.h.
1086 Mon Nov 15 00:30:33 2004 Ben Pfaff <blp@gnu.org>
1088 Get rid of procedure-specific union in struct variable, using
1089 instead a void * pointer and a destructor function.
1091 Most related changes are only worth brief summaries.
1093 * crosstabs.q: Fix includes. Use new struct var_range in lieu of
1094 old p.crs member in struct variable.
1096 * frequencies.q: Fix includes. Use new struct var_freqs in lieu
1097 of old p.frq member in struct variable.
1099 * histogram.c: (draw_histogram) Takes new freq_tab arg because
1100 it's no longer possible to grab this from var->p.frq.
1102 * piechart.c: (draw_piechart) Ditto.
1104 * group.c: (group_proc_get) New function.
1106 * levene.c: Use group_proc_get() in lieu of old p.grp_data member
1113 * main.c: (execute_command) Clear aux data in default_dict after
1114 each command. (It's debatable whether this should be done.)
1116 * matrix-data.c: Use new struct mxd_var in lieu of old p.mxd
1117 member in struct variable.
1119 * means.q: Get rid of integer mode, which is not included in
1120 recent SPSS and was the only code that wanted per-variable private
1123 * var.h: (struct crosstab_proc) Removed.
1124 (struct frequencies_proc) Removed.
1125 (struct list_proc) Removed.
1126 (struct get_proc) Removed.
1127 (struct means_proc) Removed.
1128 (struct matrix_data_proc) Removed.
1129 (struct match_files_proc) Removed.
1130 (lots of enums) Removed.
1131 (struct variable) Removed members `p', `get'. Add member
1134 * vars-atr.c: (var_attach_aux) New function.
1135 (var_detach_aux) New function.
1136 (var_clear_aux) New function.
1137 (var_dtor_free) New function.
1138 (discard_variables) Use NULL instead of inline_file.
1140 Fri Nov 12 10:07:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
1142 * value-labs.c Fixed the implmentation of value_to_string, so
1143 that it properly handles alpha values.
1145 * oneway.q Changed instances where labels were being probed manually,
1146 to use the canonical {var,value}_to_string functions
1148 Thu Nov 11 21:01:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1150 * examine.q cartesian.c chart.[ch] Added normal and detrended normal
1151 plots. Changed the API of the cartesian plot to be a much lower level
1154 Sun Nov 7 17:25:04 WST 2004 John Darrington <john@darrington.wattle.id.au>
1156 * examine.q Added some of the parametric calculations
1158 * factor_stats.[ch] Created
1160 Sat Nov 6 21:24:31 WST 2004 John Darrington <john@darrington.wattle.id.au>
1162 * examine.q Changed the definition of factors to be a composite, and
1163 dealt with the consequences.
1165 Sat Nov 6 20:40:38 WST 2004 John Darrington <john@darrington.wattle.id.au>
1167 * examine.q Fixed problem where examine wasn't dealing properly with
1170 Sat Nov 6 14:49:47 WST 2004 John Darrington <john@darrington.wattle.id.au>
1172 * oneway.q Fixed problem where oneway wasn't dealing properly with
1175 Thu Nov 4 11:09:01 WST 2004 John Darrington <john@darrington.wattle.id.au>
1177 * q2c.c examine.q Fixed a bug (feature?) whereby arrays in the
1178 command which had settings didn't get the appropriate code
1181 * val.h value-labels.[ch] var-labs.c Added v*to_string functions
1182 to convert variables/values to strings.
1184 * examine.q Added framework for the EXAMINE command.
1186 Mon Nov 1 12:46:17 WST 2004 John Darrington <john@darrington.wattle.id.au>
1188 * q2c.c frequencies.q set.q t-test.q Fixed the q2c parsing of DBL
1189 subcommand types. Changed frequencies.q to use it rather then the
1190 custom parser. Dealt with the consequences. Added a test for NTILES
1191 subcommand of frequencies.
1193 Sat Oct 30 09:16:29 WST 2004 John Darrington <john@darrington.wattle.id.au>
1195 * oneway.q Fixed up the behaviour when given missing values
1197 * levene.c oneway.q Fixed a buglet with the levene statistic and
1198 incorporated the levene test into the oneway command.
1200 * group.h t-test.q Moved the CMP_EQ and CMP_LE symbols out of
1201 global scope, since they're only relevant to T-TEST
1203 Fri Oct 29 17:39:03 WST 2004 John Darrington <john@darrington.wattle.id.au>
1205 * group.c group.h group_proc.h levene.c oneway.q t-test.q
1207 Made the t-test more consistent
1208 with the way it handles groups. That is, it now uses a hash instead
1209 of an array of 2. Also, made the levene.c file independent of the
1210 implementation of the t-test. So now levene should be fine for both
1213 * Added an oneway.q file for one way anova
1215 Wed Jun 2 22:08:02 2004 Ben Pfaff <blp@gnu.org>
1217 * descript.c: (cmd_descriptives) Remove harmless but bogus test in
1220 Mon May 31 20:45:24 2004 Ben Pfaff <blp@gnu.org>
1224 * data-list.c: (cmd_data_list) Free dls->delims on lossage.
1225 (data_list_trns_free) Free dls->delims.
1227 * t-test.q: (tts_custom_pairs) Free vars.
1228 (ssbox_one_sample_init) Fix tab_vline() argument.
1229 (ssbox_independent_samples_init) Ditto.
1230 (trbox_paired_init) Ditto.
1231 (trbox_one_sample_init) Ditto.
1233 Mon May 31 17:19:27 2004 Ben Pfaff <blp@gnu.org>
1235 Generalize casefiles to the extent that we can use them for
1236 sorting and other kinds of data transformations. Change cases to
1237 be copy-on-write to improve memory efficiency in common cases.
1238 Every access to a member of a `struct ccase' was changed to be a
1239 call to a case_*() function, especially case_data(), case_num(),
1240 case_str(), or case_data_rw(). Many instances of a local variable
1241 named "case_num" were changed to "case_idx" as a consequence.
1242 Many `struct ccase *' were changed to actual `struct ccase'
1243 because of copying semantics of cases. In several places there
1244 was a choice between updating debug code to work with the new ADTs
1245 or just deleting it because it was useless; I chose to delete it.
1247 * Makefile.am: (pspp_SOURCES) Add case.c, case.h.
1253 * aggregate.c: (struct agr_proc) Change type of `sort' to
1254 sort_criteria *. Add `break_vars', `break_var_cnt' members.
1255 Rename `vars' to `agr_vars', all references updated. Change
1256 `agr_case' to type `struct ccase'.
1257 (cmd_aggregate) Deal with new members. Use case_create(),
1258 sort_active_file_in_place(), sort_active_file_to_casefile().
1259 (agr_destroy) Deal with new members.
1260 (aggregate_single_case) Ditto.
1261 (dump_aggregate_info) Ditto.
1262 (initialize_aggregate_info) Ditto.
1263 (agr_to_active_file) Ditto.
1264 (presorted_agr_to_sysfile) Ditto.
1265 (sort_agr_to_sysfile) Removed.
1267 * alloc.c: (out_of_memory) Make non-static.
1269 * alloc.h: Prototype out_of_memory().
1271 * casefile.c: Switched from a linked list in-memory representation
1272 to a two-level array-style representation. The linked list was
1273 appropriate when we could stick a header onto cases, but that's no
1274 longer the case. Also, the two-level array will allow for random
1275 in-memory access in case that's ever wanted. Also added the
1276 concept of a `destructive casereader', one that destroys cases in
1277 the underlying casefile as they are read out.
1278 (macro CASES_PER_BLOCK) New macro.
1279 (struct casefile) New members `value_cnt', `case_list_size',
1280 `case_acct_size', `being_destroyed', `cases'. Removed `head',
1282 (struct casereader) Removed `cur'. Added `destructive', `c'.
1283 (global var casefiles) Made static.
1284 (static var case_bytes) New var.
1285 (casefile_create) Takes a value count, not a case size in bytes,
1286 to conform to the case interface. All callers updated. Deal with
1287 new and removed members.
1288 (casefile_destroy) Deal with new and removed members.
1289 (casefile_sleep) New function.
1290 (casefile_get_case_size) Removed.
1291 (casefile_get_value_cnt) New function.
1292 (casefile_append) Rewritten to deal with new and removed members.
1293 (casefile_append_xfer) New function.
1294 (write_case_to_disk) Use case_serialize().
1295 (call_posix_fadvise) Removed because posix_fadvise64 segfaults.
1296 Couldn't figure out why.
1297 (casefile_to_disk) Don't call call_posix_fadvise. Rewritten to
1298 deal with new and removed members.
1300 (merge_sort) Removed.
1301 (casefile_sort) Removed.
1302 (casefile_get_reader) Deal with new and removed members.
1303 (casefile_get_destructive_reader) New function.
1304 (reader_open_file) Make code more readable. Create case for
1306 (casereader_get_casefile) New function.
1307 (casereader_read) Deal with new and removed members. Now returns
1308 a copy of the case, so that the caller is responsible for
1309 destroying the returned case.
1310 (casereader_read_xfer) New function.
1311 (casereader_destroy) Destroy reader's case.
1312 (test_casefile) Second arg is now a value count, all callers
1313 updated. Now tests destructive readers too.
1314 (get_random_case) Deal with new case ADT.
1315 (write_random_case) Ditto.
1316 (read_and_verify_random_case) Ditto.
1318 * crosstabs.q: Remove debug code.
1320 * descript.q: (calc_descriptives) Deal with new case, casefile
1323 * dfm.c: (cmd_begin_data) There's no storage_source_class anymore.
1325 * do-if.c: Remove unneeded header inclusion.
1327 * expr-prs.c: Remove debug code.
1329 * exprP.h: Remove debug code.
1331 * flip.c: (flip_file) Use fseeko() if available.
1333 * formats.c: Remove debug code.
1335 * get.c: Remove debug code.
1336 (struct mtf_file) Change `input' from `union value *' to `struct
1337 ccase', all references updated.
1339 * levene.c: (levene) Deal with new case, casefile ADTs.
1341 * list.q: Remove debug code.
1343 * loop.c: Remove debug code.
1345 * matrix-data.c: Remove debug code.
1347 * means.q: Remove debug code.
1349 * mis-val.c: Remove debug code.
1351 * pfm-read.c: Remove debug code.
1352 (pfm_read_code) Change second arg from `union value *' to `struct
1353 ccase *', all references updated.
1355 * recode.c: (string_to_long) Make first arg const.
1356 (convert_to_double) Ditto.
1358 * repeat.c: Remove debug code.
1360 * sample.c: Remove debug code.
1362 * sfm-read.c: Remove debug code.
1363 (sfm_read_case) Change second arg from `union value *' to `struct
1366 * sort.c: Redone in terms of casefiles.
1367 (enum sort_direction) Moved here from sort.h.
1368 (struct sort_criterion) New structure.
1369 (struct sort_criteria) New structure.
1370 (cmd_sort_cases) Rewritten.
1371 (prepare_to_sort_active_file) New function.
1372 (sort_active_file_in_place) New function.
1373 (sort_active_file_to_casefile) New function.
1374 (parse_sort) Renamed sort_parse_criteria(), rewritten & interface
1375 changed, all callers updated.
1376 (destroy_sort_cases_pgm) Renamed sort_destroy_criteria(),
1377 rewritten & interface changed, all callers updated.
1378 (sort_cases) Renamed sort_execute(), rewritten & interface
1379 changed, all callers updated.
1380 (struct internal_sort) Removed.
1381 (do_internal_sort) Rewritten, interface changed.
1382 (destroy_internal_sort) Removed.
1383 (compare_case_dblptrs) Use sort_criteria instead of sort_case_pgm.
1384 (struct initial_run) Removed; an initial run is now just a
1386 (compare_initial_runs) Rewritten.
1387 (struct external_sort) Changed almost completely.
1388 (do_external_sort) Rewritten, interface changed.
1389 (destroy_external_sort) Rewritten.
1390 [HAVE_MKDTEMP] (make_temp_dir) Removed.
1391 [!HAVE_MKDTEMP] (do_mkdir) Removed.
1392 [!HAVE_MKDTEMP] (make_temp_dir) Removed.
1393 (init_external_sort) Removed.
1394 (simulate_error) Removed.
1395 (rmdir_temp_dir) Removed.
1396 (get_temp_file_name) Removed.
1397 (open_temp_file) Removed.
1398 (close_temp_file) Removed.
1399 (remove_temp_file) Removed.
1400 (write_temp_file) Removed.
1401 (read_temp_file) Removed.
1402 (struct record_run) Change `record' from `struct case_lit *' to
1404 (struct initial_run_state) Remove `idx_to_fv', `free_list',
1405 `file_idx', `output_file'. Add `run', casefile'. Change
1406 `last_output' from `struct case_list *' to `struct ccase'.
1407 (write_initial_runs) Change interface, rewrite.
1408 (sort_sink_write) Renamed process_case(), changed interfaced,
1410 (destroy_initial_run_state) Rewritten.
1411 (allocate_cases) Rewritten.
1412 (compare_record) Interface changed, rewritten.
1413 (start_run) Rewritten.
1414 (end_run) Rewritten.
1415 (output_record) Rewritten.
1416 (grab_case) Removed.
1417 (release_case) Removed.
1418 (struct merge_case) Change `cases' from double pointer to single
1420 (merge) Deal with new case and casefile ADTs.
1421 (struct run) Removed.
1422 (merge_once) Rewritten, interface changed.
1423 (fill_run_buffer) Removed.
1424 (sort_sink_make_source) Removed.
1425 (sort_sink_class) Removed.
1426 (struct sort_source_aux) Removed.
1427 (sort_source_read_helper) Removed.
1428 (sort_source_read) Removed.
1429 (read_sort_output) Removed.
1430 (read_internal_sort_output) Removed.
1431 (read_external_sort_output) Removed.
1432 (sort_source_destroy) Removed.
1433 (sort_source_class) Removed.
1435 * sort.h: (struct sort_cases_pgm) Removed.
1436 (enum sort_direction) Moved to sort.c.
1438 * t-test.q: (calculate) Deal with new case, casefile ADTs.
1440 * tab.c: Remove debug code.
1442 * var-labs.c: Remove debug code.
1444 * var.h: (struct ccase) Removed.
1445 (struct case_list) Removed.
1447 * vars-atr.c: (discard_variables) Use free_case_source().
1449 * vars-prs.c: (parse_vs_variable) Make arg const.
1450 (parse_dict_variable) Ditto.
1451 (parse_variables) Make struct dictionary * arg const.
1452 (parse_var_set_vars) Make struct var_set * arg const.
1453 (struct var_set) Add const to some of the function pointers' args.
1454 (var_set_get_cnt) Make arg const.
1455 (var_set_get_var) Make first arg const.
1456 (var_set_lookup_var) Make first arg const.
1457 (dict_var_set_get_cnt) Make arg const.
1458 (dict_var_set_get_var) Make first arg const.
1459 (dict_var_set_lookup_var) Make first arg const.
1460 (var_set_create_from_dict) Make arg const. Add cast to aux
1462 (struct array_var_set) Add const to var member.
1463 (array_var_set_get_cnt) Make arg const.
1464 (array_var_set_get_var) Make first arg const.
1465 (array_var_set_lookup_var) Make first arg const.
1466 (var_set_create_from_array) Make first arg const. Insert cast.
1468 * vfm.c: (struct write_case_data) Change trns_case, sink_case
1469 members from `struct ccase *' to `struct ccase'.
1470 (static var lag_queue) Change from double to single pointer.
1471 (procedure) Optimize trivial case.
1472 (internal_procedure) Deal with changed case, case_source ADTs.
1473 (create_trns_case) Changed interface, rewrote.
1474 (open_active_interface) Initialize modified lag queue.
1475 (write_case) Deal with changed case ADT.
1476 (lag_case) Deal with modified lag queue.
1477 (close_active_file) Destroy modified lag queue.
1478 Deal with changed case_source, case_sink ADTs.
1479 (destroy_storage_stream_info) Make null arg into no-op.
1480 (storage_sink_make_source) Set aux in created source.
1481 (storage_source_read) Deal with changed case, casefile ADTs.
1482 (storage_source_create) New function.
1483 (lagged_case) Rewrite.
1484 (free_case_source) New function.
1485 (free_case_sink) Rewrite.
1486 (struct split_aux_data) Changed prev_case from `struct ccase *' to
1488 (procedure_with_splits) Deal with changed prev_case.
1489 (procedure_with_splits_callback) Ditto.
1490 (multipass_split_aux_data) Changed prev_case from `struct ccase *' to
1492 (multipass_procedure_with_splits) Deal with changed prev_case.
1493 (multipass_split_callback) Ditto.
1496 Mon May 31 17:19:06 2004 Ben Pfaff <blp@gnu.org>
1498 The workspace idea didn't work out.
1500 * Makefile.am: (pspp_SOURCES) Remove workspace.c, workspace.h.
1502 * workspace.c: Removed.
1504 * workspace.h: Removed.
1506 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
1508 Fully implement arbitrary delimiters on DATA LIST, extending the
1509 half implementation that was already there.
1511 * data-list.c: (struct data_list_pgm) Remove `delim', add
1512 `delims', `delim_cnt'.
1513 (cmd_data_list) Initialize new members. Parse delimiters and
1514 clean up code a bit.
1515 (cut_field) Extract fields with arbitrary delimiters. Also, fix
1516 handling of leading commas.
1517 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
1519 (read_from_data_list_free) Adapt to new DFM interfaces.
1520 (read_from_data_list_list) Ditto.
1521 (repeating_data_trns_proc) Ditto.
1523 * dfm.c: Split up reader and writer into separate code, because
1524 they do different things. Use struct string instead of explicit
1525 allocation code, for clarity.
1526 (enum dfm_reader_flags) New enum.
1527 (struct dfm_fhuser_ext) Removed.
1528 (struct dfm_reader_ext) New.
1529 (get_reader) New function, used by just about all the reader
1531 (dfm_close) Removed.
1532 (close_reader) New function.
1533 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
1534 (dfm_open_for_writing) Ditto.
1535 (macro force_line_buffer_expansion) Removed.
1536 (count_tabs) Removed.
1537 (tabs_to_spaces) Removed.
1538 (read_record) Deal with new dfm_reader_ext. Use struct string
1539 functions. Don't convert tabs to spaces.
1540 (dfm_eof) New function.
1541 (dfm_get_record) Changed interface, rewrote.
1542 (dfm_expand_tabs) New function.
1543 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
1544 dfm_reader_ext, rewritten.
1545 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
1546 dfm_reader_ext, rewritten.
1547 (dfm_set_record) Removed in favor of dfm_forward_columns().
1548 (dfm_forward_columns) New function.
1549 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
1550 dfm_reader_ext, rewritten.
1551 (static var dfm_r_class) Use close_reader for the destructor.
1552 (struct dfm_writer_ext) New.
1553 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
1554 bounce buffer now instead of local allocation.
1555 (close_writer) New function.
1556 (static var dfm_writer_ext) Use close_writer for destructor.
1557 (cmd_begin_data) Adapt to new dfm_reader_ext.
1559 * file-handle.q: Add support for per-file tab width.
1560 (struct private_file_handle) Add tab_width member.
1561 (q2c specifications) Add tabwidth subcommand.
1562 (cmd_file_handle) Put parsed tab width into private_file_handle.
1563 (create_file_handle) Set default tab width.
1564 (handle_get_tab_width) New function.
1566 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
1568 * inpt-pgm.c: (reread_trns_proc) Ditto.
1570 * matrix-data.c: (context) Ditto.
1571 (another_token) Ditto.
1575 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
1577 * casefile.c: (casefile_destroy) Fix memory leak by freeing
1579 (casereader_destroy) Don't close file descriptor -1.
1581 * recode.c: (cmd_recode) Fix memory leak.
1583 * set.q: (q2c specifications) Fix typo in user message.
1585 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
1586 undefined behavior for overlapping arguments.
1588 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
1590 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
1591 don't call it when we're running under valgrind.
1592 (call_posix_fadvise) New function.
1593 (casefile_to_disk) Use call_posix_fadvise().
1594 (reader_open_file) Ditto.
1596 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
1598 Update our string ADTs, struct string and struct len_string. Get
1599 rid of pool support, which was largely unused. Rename lots of
1600 functions to have more obvious or consistent names.
1602 * ascii.c: Get rid of ascii_pool. It was only used for string
1604 (ascii_open_global) Don't create ascii_pool.
1605 (ascii_close_driver) Don't destroy ascii_pool.
1606 (ascii_postopen_driver) Don't use pool.
1607 (ascii_close_driver) Destroy strings manually.
1609 * str.c: (ds_create) Remove pool argument, all references updated.
1611 (ds_replace) Remove pool support, make more efficient when we
1612 don't need to reallocate.
1613 (ds_destroy) Remove pool support.
1614 (ds_rpad) New function.
1615 (ds_size) Renamed ds_capacity(), all references updated.
1616 (ds_value) Renamed ds_c_str(), all references updated.
1617 (ds_concat) Renamed ds_puts(), all references updated.
1618 (ds_concat_buffer) Renamed ds_concat(), all references updated.
1619 (ds_putchar) Renamed ds_putc(), all references updated.
1620 (ds_getline) Renamed ds_gets(), all references updated.
1621 (ls_create) Remove pool argument, all references updated.
1622 (ls_create_buffer) Ditto.
1623 (ls_destroy) Removed pool support.
1624 (ls_value) Renamed ls_c_str(), all references updated.
1626 * str.h: (ls_length) [__GNUC__] Add inline version.
1627 (ls_c_str) [__GNUC__] Add inline version.
1628 (ls_end) [__GNUC__] Add inline version.
1629 (struct string) Remove pool member. Rename `size' to `capacity',
1630 all references updated.
1632 * tab.c: (text_format) Instead of using pool argument to
1633 ls_create_buffer(), call pool_register() on allocated data.
1635 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
1637 We're abusing the current ASCII driver by telling it to allocate a
1638 9999-line, 9999-character page in the tests. This causes some
1639 systems to curl up and die because it allocates 20 MB of
1640 contiguous RAM. This change alleviates at least part of the
1641 problem. It is mostly a stop-gap until the new output system is
1644 * ascii.c: (struct line) New structure.
1645 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
1646 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
1647 (ascii_preopen_driver) Initialize new members, not old ones.
1648 (ascii_close_driver) Destroy new members, not old ones.
1649 (ascii_open_page) Allocate new members, not old ones.
1650 (expand_line) Allocate room in line.
1651 (draw_line) Use new members.
1652 (ascii_line_horz) Ditto.
1653 (ascii_line_vert) Ditto.
1654 (ascii_line_intersection) Ditto.
1656 (output_lines) Ditto.
1657 (ascii_close_page) Ditto.
1659 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
1661 * matrix.c: Dead code. Removed.
1663 * matrix.h: Dead code. Removed.
1665 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
1667 Contrary to what I'd always understood, there is an efficient
1668 algorithm for deletion from a hash table populated via linear
1669 probing. This change implements it.
1671 * hash.c: (hsh_rehash) Probe in increasing order.
1673 (locate_matching_entry) Ditto.
1674 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
1676 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
1678 * moments.c (calc_moments): Adjust calculation of kurtosis to
1679 avoid subtracting huge numbers from huge numbers, on Michael
1682 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
1684 Rework moments routines for improved numerical stability based on
1685 Michael Kiefte's advice. Any bugs or remaining numerical problems
1686 are still mine though.
1688 There is now a struct moments1 for use with one-pass moments. It
1689 uses a provisional means algorithm as an attempt to improve
1690 accuracy of higher moments. The older struct moments now only
1691 handles two-pass moments.
1693 * aggregate.c: Use moments1 instead moments.
1695 * descript.c: Revert previous change, which is no longer needed
1696 due to the moments revision.
1698 * moments.c: (calc_moments) New function for calculating variance,
1700 (moments_pass_one) Only accumulate weights bigger than zero.
1701 (moments_calculate) Allow calculating the mean on pass one, others
1702 require pass two. Implement in terms of calc_moments().
1703 (struct moments1) New structure.
1704 (init_moments1) New function.
1705 (moments1_clear) Ditto.
1706 (moments1_create) Ditto.
1707 (moments1_add) Ditto.
1708 (moments1_calculate) Ditto.
1709 (moments1_destroy) Ditto.
1710 (cmd_debug_moments) Deal with `struct moments' or `struct
1711 moments1' as requested by user.
1713 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
1715 * Makefile.am (pspp_SOURCES): Remove debug.c.
1717 * debug.c: Removed. It was empty anyway.
1719 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
1721 * descript.c (calc_descriptives): Fix assert failure when only
1722 MOMENT_MEAN is needed.
1724 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
1728 fixed problem with parsing in match_statistic() causing
1729 "DESCRIPTIVE STAT=MEAN." to barf.
1731 "MEAN" is now default if "SORT" given without specification.
1733 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
1734 generally less forgiving of syntax errors: better to have it do
1735 nothing and type it in again then to not know what it actually did
1738 z-score transformation now checks score for user-missing values
1739 and checks std_dev for SYSMIS.
1741 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
1743 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
1744 Changed dict_get_case_weight() to accept an additional int * flag
1745 to complain about system-missing, user-missing, zero, or negative
1746 weights and updated existing functions to pass int * to
1747 dict_get_case_weight().
1749 2004-04-05 jmd <jmd@gnu.org>
1751 * main.c: Fixed configuration problems with gsl
1753 * t-test.q: Fixed some problems encountered when compiling under Cygwin
1755 2004-04-03 blp <blp@gnu.org>
1757 * lexer.c, ChangeLog:
1758 Fix infinite loop on comment at end of file, add test.
1760 2004-04-03 jmd <jmd@gnu.org>
1762 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
1763 Fixed the calculation of percentiles and added --syntax and --algorithm options
1765 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
1767 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
1770 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
1772 * frequencies.q: Fixed the calculation of percentiles
1774 * Makefile.am: Added the --ansi flag and dealt with the
1775 consequences. Added some entries to PSPP_sources so that
1776 make distcheck would pass
1778 * cmdline.c: Added the --syntax and --algorithm options
1780 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
1782 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
1784 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
1785 use the new multipass_split_... mechanism.
1787 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
1789 * frequencies.q: (calc_stats) Use moments data structure and
1790 calc_seskew(), calc_sekurt() functions.
1792 * set.q main.c settings.h Added support for --syntax and --algorithm
1795 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
1797 * vfm.c: Had to get last call to multipass_split_output() inside
1798 open_active_file()/close_active_file() pairing, so introduce new
1800 (internal_procedure) Move procedure() code here, except for calls
1801 to open_active_file() and close_active_file().
1802 (procedure) Wrap open_active_file() and close_active_file() around
1803 internal_procedure().
1804 (multipass_procedure_with_splits) Wrap open_active_file() and
1805 close_active_file() around internal_procedure().
1807 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
1809 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
1811 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
1813 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
1815 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
1817 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
1819 * algorithm.c: By default turn off some of the more expensive
1821 (expensive_assert) New macro which expands to assert if
1822 EXTRA_CHECKS is defined, to nothing otherwise.
1823 (unique) Use expensive_assert().
1824 (binary_search) Ditto.
1830 * command.c: (conflicting_3char_prefixes) Words that are the same
1831 don't cause conflicts when they are abbreviated to the first three
1834 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
1835 nonterm_node's n earlier.
1836 (generic_str_func) Ditto.
1838 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
1840 Add support for multipass procedures. Rewrite DESCRIPTIVES to
1841 test multipass support, take advantage of new moments
1842 calculation, and to not be such crappy code. Get rid of q2c
1843 processing for DESCRIPTIVES.
1845 * vfm.c: (struct multipass_split_aux_data) New structure.
1846 (multipass_procedure_with_splits) New function.
1847 (multipass_split_callback) New function.
1848 (multipass_split_output) New function.
1849 * descript.q: Removed.
1851 * descript.c: New file.
1853 * var.h: Removed descriptives enums.
1854 (struct descriptives_proc) Removed.
1855 (struct variable) Removed p.dsc.
1857 * Makefile.am: (q_sources_c) Remove descript.c.
1858 (q_sources_q) Removed descript.q.
1860 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
1862 New manager for keeping track of used workspace.
1864 * workspace.c: New file.
1866 * workspace.h: New file.
1868 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
1870 * sort.c: (do_internal_sort) Use workspace_malloc().
1871 (destroy_internal_sort) Use workspace_free().
1873 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
1875 New `struct casefile' for managing sets of cases.
1877 * casefile.c: New file.
1879 * casefile.h: New file.
1881 * command.def: Add DEBUG CASEFILE command.
1883 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
1885 * sort.c: (sort_cases) Move logic for sending storage file to disk
1886 into do_external_sort().
1887 (struct internal_sort) Use an array of ccase pointers instead of a
1889 (do_internal_sort) Rewrite to handle casefiles.
1890 (compare_case_list) Removed.
1891 (compare_cases) New function.
1892 (compare_case_dblptrs) New function.
1893 (read_internal_sort_output) Deal with new struct internal_sort.
1895 * vfm.c: (static var workspace_overflow) Removed.
1896 (struct storage_stream_info) Removed all the members. Added
1897 struct casefile * member.
1898 (storage_sink_open) Use casefile.
1899 (open_storage_file) Removed.
1900 (write_storage_file) Removed.
1901 (storage_to_disk) Removed.
1902 (destroy_storage_stream_info) Use casefile.
1903 (storage_sink_write) Use casefile.
1904 (storage_sink_make_source) Use casefile.
1905 (storage_source_count) Use casefile.
1906 (storage_source_read) Use casefile.
1907 (storage_source_on_disk) Removed.
1908 (storage_source_get_cases) Removed.
1909 (storage_source_set_cases) Removed.
1910 (storage_source_get_casefile) New function.
1912 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
1914 New `struct moments' for calculating moments.
1920 * moments.c: New file.
1922 * moments.h: New file.
1924 * command.def: Add DEBUG MOMENTS command.
1926 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
1929 * aggregate.c: Modify AGGREGATE to use the new moments
1930 calculation, even if not in such a great way.
1931 (struct agr_var) Add `moments' member.
1932 (parse_aggregate_functions) Set `moments' member to null.
1933 (agr_destroy) Destroy `moments' member.
1934 (accumulate_aggregate_info) Use `moments' for standard deviation.
1935 (dump_aggregate_info) Ditto.
1936 (initialize_aggregate_info) Create or clear `moments'.
1938 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
1939 cube(), pow4() that were in stats.h. All references updated.
1941 * crosstabs.q: stats.h had chi-square significance functions. Use
1943 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
1945 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
1946 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
1948 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
1950 * dictionary.c: (dict_compact_values) Compacted values need to
1953 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
1955 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
1956 `/' at start. Check return value of parse_variables() for error
1959 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
1961 Revamp expressions: make the code a little nicer, and fix bugs
1964 * expr-evl.c: (expr_evaluate) Make expression argument const.
1965 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
1966 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
1967 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
1968 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
1969 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
1970 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
1971 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
1972 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
1973 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
1974 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
1975 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
1976 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
1977 Simplify OP_SYSMIS. Remove OP_STR_MIS.
1979 * expr-opt.c: (optimize_expression) Rewrite.
1984 (macro s0l) Removed.
1986 (macro s1l) Removed.
1988 (macro s2l) Removed.
1991 (eq_num_con) New function.
1992 (optimize_tree) New function.
1993 (macro rnc) Removed.
1994 (macro frnc) Removed.
1995 (str_search) Add const to string params.
1996 (str_rsearch) Ditto.
1997 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
1998 str[], str_len[] locals to substitute for most of removed macros.
1999 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
2000 Removed support for missing values because we're never called with
2001 missing values. Use set_number() or set_number_errno() instead of
2002 rnc or frnc. Removed any stuff that caused trouble in testing.
2003 We can re-add it later if it really slows anything. Fix some
2005 (evaluate_tree_with_missing) Not yet supported. To be added later
2007 (repl_num_con) Removed.
2008 (collapse_node) New function.
2009 (force_repl_num_con) Removed.
2010 (set_number) New function.
2011 (set_number_errno) New function.
2012 (repl_str_con) Removed.
2013 (set_string) New function.
2014 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
2016 (dump_node) No special case for OP_AND, OP_OR.
2018 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
2019 (expr_get_type) New function.
2020 (type_check) Rewrite.
2021 (type_coercion) New function.
2022 (struct operator) New structure.
2023 (match_operator New function.
2024 (parse_binary_operators) New function.
2025 (parse_inverting_unary_operator) New function.
2026 (parse_or) Rewritten.
2027 (parse_and) Rewritten.
2028 (parse_not) Rewritten.
2029 (parse_rel) Rewritten.
2030 (parse_add) Rewritten.
2031 (parse_mul) Rewritten.
2032 (parse_neg) Rewritten.
2033 (parse_exp) Rewritten.
2034 (parse_sysvar) Add $TRUE, $FALSE system variables.
2035 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
2036 (parse_primary) Use allocate_var_node(), allocate_num_con(),
2038 (struct function) Remove desc, change `func' prototype.
2039 (unary_func) Remove special cases.
2040 (MISSING_func) Reduce to unary_func() that just returns a boolean.
2041 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
2042 (VALUE_func) Use allocate_var_node().
2043 (nary_num_func) Allow MIN and MAX for strings.
2044 Use allocate_var_node(). Properly clean up.
2046 (generic_str_func) Use local table instead of removed `desc'
2047 member. Mostly rewrite.
2048 (get_num_args) Revise error message.
2049 (parse_function) Return EXPR_ERROR, not 0 on error.
2051 (macro varies) Removed.
2052 (ops[]) Use expr.def.
2053 (free_node) Do nothing if node is null.
2054 (allocate_num_con) New function.
2055 (allocate_str_con) New function.
2056 (allocate_var_node) New function.
2057 (allocate_binary_nonterminal) New function.
2058 (append_nonterminal_arg) Removed.
2059 (static var func_tab[]) Revised.
2060 (expr_debug_print_postfix) Make parameter const.
2061 Use printf() instead of debug_printf().
2063 * expr.def: New file.
2065 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
2066 use named enum instead of unnamed, all references updated. Add
2067 EXPR_ANY, EXPR_NO_OPTIMIZE.
2069 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
2070 instead of defining OP_* directly.
2071 (macro IS_TERMINAL) New macro.
2072 (macro IS_NONTERMINAL) New macro.
2073 (enum OP_NO_FLAGS) New.
2075 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
2077 * error.c: (err_assert_fail) msg variable needs to be non-const.
2079 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
2081 * debug.c: (cmd_debug_evaluate) Rewrite.
2083 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
2085 Fix some CROSSTABS bit rot stupidity.
2087 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
2088 (internal_cmd_crosstabs) Initializes cells[] correctly.
2089 (float_M_suffix) Rename format_cell_entry(), change prototype,
2091 (display_crosstabulation) Fix cell formatting.
2093 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
2095 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
2096 to call lex_discard_line() to do that.
2098 * command.c: (run_command) Call lex_discard_line() after
2101 * lexer.c: (lex_entire_end) Change behavior.
2102 (lex_rest_of_line) Change behavior. Return const char *.
2103 (lex_discard_line) Don't clear getl_buf, don't emit message.
2105 * main.c: (handle_error) Emit message here.
2107 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
2108 instead of lex_entire_line().
2110 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
2112 * title.c: (get_title) Call lex_discard_line() after
2114 (cmd_file_label) Ditto.
2115 (cmd_document) Deal with const char * return value.
2117 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
2119 Removed REMARK command.
2121 * command.c: (extract_prefix) Removed.
2122 (output_line) Removed.
2123 (cmd_remark) Removed.
2125 * command.def: Remove REMARK.
2127 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
2129 Added abort() after lots of assert(0) invocations to avoid some
2130 compiler warnings. We really need a NOT_REACHED macro.
2132 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2134 * sort.c: Added missing call to temp_file_close. Changed error
2135 messages to warnings.
2137 * set.q: Improved setting of set_view{length,width} to be more tolerant
2140 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
2142 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
2143 used with incorrect syntax.
2145 * error.c, error.h et al: Overridden definition of assert for a
2148 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
2149 subcommand was given when it ought to have been.
2151 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
2153 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
2157 (tab_joint_text) Ditto.
2159 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
2161 * levene.c: Add #include.
2163 * set.q: (set_viewport) Add `int' argument to make its prototype
2164 correct for signal().
2166 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
2168 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
2171 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
2173 Changed DFM from open-at-first-access to explicit-open. Before,
2174 calling dfm_get_record() or dfm_put_record() would automatically
2175 open the file. Now, you have to call dfm_open_for_reading() or
2176 dfm_open_for_writing() explicitly. This makes it possible to
2177 check permissions, file existence, etc. earlier.
2179 Also made struct file_handle more opaque, and clean up in general.
2181 * data-list.c: (cmd_data_list) Open handle for reading.
2183 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
2185 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
2186 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
2187 (open_inline_file) Removed.
2188 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
2189 it. Deal with line_number in extension record instead of file
2191 (dfm_get_record) Rewrote.
2192 (dfm_put_record) Rewrote.
2193 (dfm_push) Assert file is open and one of ours. Deal with
2194 line_number in extension record instead of file handle.
2195 (dfm_pop) Assert file is open and one of ours. Deal with
2196 line_number in extension record instead of file handle.
2197 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
2200 * file-handle.h: (enum constants RH_RF_*) Removed.
2201 (enum constants FH_MD_*) Removed.
2202 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
2203 `recform', `lrecl', `mode' members. Public references to
2204 `recform' changed to use handle_get_mode(), references to `lrecl'
2205 changed to use handle_get_record_width(). Added `private' member.
2206 (enum file_handle_mode) New.
2208 * file-handle.q: (struct private_file_handle) New structure.
2209 (struct file_handle_list) New structure.
2210 (static var files) New.
2211 (static var file_handles) Removed.
2212 (init_file_handle) Removed.
2213 (create_file_handle) Removed.
2214 (get_handle_with_name) New function.
2215 (get_handle_for_filename) New function.
2216 (cmd_file_handle) Rewritten.
2217 (hash_file_handle) Removed.
2218 (cmp_file_handle) Removed.
2219 (fh_init_files) Rewritten.
2220 (fh_parse_file_handle) Rewritten. Allows identifiers as
2222 (fh_get_handle_by_name) Renamed handle_get_name(), all references
2224 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
2225 references updated. Rewritten.
2226 (fh_record_width) Renamed handle_get_record_width(), all
2227 references updated. Rewritten.
2228 (handle_get_mode) New function.
2230 * file-type.c: (cmd_file_type) Open handle for reading.
2232 * filename.c: [unix] (struct file_identity) New structure.
2233 [unix] (fn_get_identity) New function.
2234 [unix] (fn_free_identity) New function.
2235 [unix] (fn_compare_file_identities) New function.
2236 [!unix] (struct file_identity) New structure.
2237 [!unix] (fn_get_identity) New function.
2238 [!unix] (fn_free_identity) New function.
2239 [!unix] (fn_compare_file_identities) New function.
2241 * lexer.c: (static var put) Renamed put_token, all references
2243 (static var put_tokstr) New.
2244 (static var put_tokval) New.
2245 (lex_init) Initialize put_tokstr().
2246 (restore_token) New function.
2247 (save_token) New function.
2248 (lex_get) Use restore_token().
2249 (lex_put_back) Use save_token().
2250 (lex_put_back_id) New function.
2251 (lex_put_forward) Removed.
2252 (lex_preprocess_line) Set put_token instead of using
2254 (lex_negative_to_dash) Use save_token(), set put_token directly.
2255 (dump_token) Use stderr instead of stdout.
2257 * main.c: (main) Remove call to cmd_init().
2259 * matrix-data.c: (cmd_matrix_data) Open file for reading.
2261 * pfm-read.c: Use handle_get_filename() instead of trying to use
2262 h->fn directly, all over.
2264 * pfm-write.c: Ditto.
2266 * print.c: (internal_cmd_print) Open handle for writing.
2267 (dump_table) Use handle_get_filename().
2268 (print_trns_proc) Use handle_get_mode().
2269 (cmd_print_space) Use fh_parse_file_handle().
2270 Open handle for writing.
2271 [0] (debug_print) Removed.
2273 * sfm-read.c: Use handle_get_filename() instead of trying to use
2274 h->fn directly, all over.
2276 * sfm-write.c: Ditto.
2278 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
2282 * autorecode.c: (arc_free) Free arc->src_values.
2284 * error.c: (msg) Free buf.
2286 * val-labs.c: (do_value_labels) Always free vars.
2288 * vfm.c: (close_active_file) If sink has no make_source then call
2289 its destroy function.
2291 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
2293 Fixed cmd_parse() so that it always skips past a full command
2294 name. A few special commands for which this would be bad get
2295 special treatment. This lets us drop code for skipping past the
2296 end of a command name in most cmd_*() functions. It's not worth
2297 listing all the commands affected.
2299 * command.c: (struct command) Remove `cmd' member, replace by
2300 `name' member, all references updated. Remove `word', `next',
2301 `skip_entire_name' members.
2302 (macro DEFCMD) Deal with revised `struct command'.
2303 (macro UNIMPL) Ditto.
2304 (macro SPCCMD) New macro for commands whose last word shouldn't be
2306 (static array cmd_table[]) Make const, rename `commands', remove
2308 (macro COMMAND_CNT) New macro.
2309 (split_words) Removed.
2311 (FILE_TYPE_okay) Make parameter const.
2312 (cmd_parse) Improve error messages.
2313 (match_strings) New function.
2314 (next_word) New function.
2315 (enum command_match) New enum.
2316 (conflicting_3char_prefixes) New function.
2317 (conflicting_3char_prefix_command) New function.
2318 (cmd_match_words) New function.
2319 (count_matching_commands) New function.
2320 (get_command_name) New function.
2321 (free_words) New function.
2322 (unknown_command_error) New function.
2323 (figure_out_command) Renamed parse_command_name(), rewritten.
2325 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
2326 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
2327 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
2330 * command.h: (macro SPCCMD) New.
2332 * include.c: (cmd_include_at) Removed.
2333 (cmd_include) Allow identifier to be used as filename.
2335 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
2337 * t-test.q: (cmd_t_test) Command name is now parsed for us.
2340 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
2342 Start work on better test framework.
2344 * Makefile.am: (pspp_sources) Add debug.c.
2346 * debug.c: New file.
2348 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
2349 cmd_debug_evaluate().
2351 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
2353 * expr.h: (enum constant PXP_DUMP) Removed.
2355 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
2357 * set.q: Implemented the SHOW command, and synced it to the existing
2360 Added a handler for SIGWINCH so that viewlength and viewwidth follow
2361 changes as the window size is changed.
2363 Added fallback to set viewlength and viewwidth from LINES and COLUMS
2364 environment variables if other methods are not available.
2366 glob.c: Removed a lot of global variables from glob.c and encapsulated
2369 random.c: Tidied up the way the random seed is set.
2371 str.c: Added a ds_vprintf function.
2373 error.c: Extended dump_message so that messages are always broken at
2376 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
2378 * pfm-write.c: (bufwrite) Write out the correct element for string
2379 variables. From Andreas Streichardt <streichardt@globalpark.de>.
2381 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
2383 Get rid of static and global (!) vars in matrix-data.c.
2385 * matrix-data.c: (static var nr_data) Removed.
2386 (static var nr_factor_values) Removed.
2387 (static var max_cell_index) Removed.
2388 (static var split_values) Removed.
2389 (struct nr_aux_data) New structure.
2390 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
2391 place of static vars, pass to create_case_source() and procedure()
2393 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
2394 struct matrix_data_pgm *.
2395 (nr_read_splits) Ditto.
2396 (nr_read_factors) Ditto.
2397 (nr_output_data) Ditto.
2398 (static var wr_content) Removed.
2399 (global var wr_data) Removed.
2400 (global var wr_current) Removed.
2401 (struct wr_aux_data) New structure.
2402 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
2403 place of static vars, pass to create_case_source() and procedure()
2405 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
2406 instead of matrix_data_pgm *.
2407 (wr_read_splits) Ditto.
2408 (wr_output_data) Ditto.
2409 (wr_read_rowtype) Ditto.
2410 (wr_read_factors) Ditto.
2411 (wr_read_indeps) Ditto.
2413 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
2415 Get rid of static vars in autorecode.c.
2417 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
2418 `n_arc' to `spec_cnt'. All references updated.
2419 (static var v_src) Removed.
2420 (static var v_dest) Removed.
2421 (static var h_trns) Removed.
2422 (static var nv_src) Removed.
2423 (static var descend) Removed.
2424 (static var print) Removed.
2425 (enum direction) New enum.
2426 (struct autorecode_pgm) New structure.
2427 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
2428 Move n_dest local var into struct autorecode_pgm for ease of
2429 clean-up. Use arc_free().
2430 (arc_free) New function.
2431 (recode) Modify to take struct autorecode_pgm * parameter instead
2432 of using statics. Let the caller clean up.
2433 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
2434 instead of statics. Rearrange code a little.
2436 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
2438 Get rid of static, global vars in recode.c. Remove debug code.
2440 * recode.c: (static var head) Removed.
2441 (global var v) Removed.
2442 (global var nv) Removed.
2443 (cmd_recode) New local variables head, v, nv. Initialize and free
2444 v. Don't call debug_print().
2445 [DEBUGGING] (dump_dest) Removed.
2446 [DEBUGGING] (debug_print) Removed.
2448 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
2450 Get rid of static vars in expr-opt.c.
2452 * expr-opt.c: (static var e) Removed.
2453 (static var nop) Removed.
2454 (static var mop) Removed.
2455 (static var ndbl) Removed.
2456 (static var mdbl) Removed.
2457 (static var nstr) Removed.
2458 (static var mstr) Removed.
2459 (static var nvars) Removed.
2460 (static var mvars) Removed.
2461 (struct expr_dump_state) New structure.
2462 (dump_expression) Use new struct expr_dump_state instead of static
2463 vars and pass to functions we call.
2464 (dump_node) Use struct expr_dump_state * parameter.
2466 (emit_num_con) Ditto.
2467 (emit_str_con) Ditto.
2470 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
2472 Get rid of static var in COUNT.
2474 * count.c: (static var head) Move into cmd_count().
2475 (cmd_count) [DEBUGGING] Don't call debug_print.
2476 [DEBUGGING] (debug_print) Removed.
2478 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
2480 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
2482 * val-labs.c: (static var v) Removed.
2483 (static var nv) Removed.
2484 [DEBUGGING] (debug_print) Removed.
2485 (verify_val_labs) Add struct variable **, int parameters.
2486 (get_label) Ditto. Improve error messages, streamline.
2487 (erase_labels) New function for erasing value labels, taking over
2488 part of verify_val_labs()'s function.
2491 (cmd_value_labels) No need to call init() or done() anymore.
2492 (cmd_add_value_labels) Ditto.
2493 (do_value_labels) Add vars, var_cnt local variables. Clean up
2494 after them internally. Call erase_labels() if we should. Don't
2497 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
2499 Get rid of static vars in MATCH FILES.
2501 * get.c: (static var mtf_head) Removed.
2502 (static var mtf_tail) Removed.
2503 (static var mtf_by) Removed.
2504 (static var mtf_n_by) Removed.
2505 (static var mtf_master) Removed.
2506 (static var mtf_seq_num) Removed.
2507 (static var mtf_seq_nums) Removed.
2508 (static var mtf_sink) Removed.
2509 (static var mtf_case) Removed.
2510 (struct mtf_proc) New structure.
2511 (cmd_match_files) Use struct mtf_proc instead of static vars.
2512 (mtf_processing_finish) Ditto.
2514 (mtf_delete_file_in_place) Ditto.
2515 (mtf_read_nonactive_records) Ditto.
2516 (mtf_compare_BY_values) Ditto.
2517 (mtf_processing) Ditto.
2518 (mtf_merge_dictionary) Ditto.
2520 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
2522 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
2524 * dictionary.c: (dict_rename_var) Add assertion.
2525 (dict_contains_var) Check by index instead of name.
2527 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
2529 Get rid of compaction_necessary, compaction_nval, compaction_case.
2530 Redo VFM interface. Replace disk_sink and memory_sink by
2531 storage_sink, disk_source and memory_source by storage_source.
2533 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
2537 (struct write_case_data) Remove `begin_func', `end_func',
2538 `func_aux' members. Add `aux', `trns_case', `sink_case',
2539 `cases_written', `cases_analyzed' members.
2540 (global var compaction_necessary) Make static.
2541 (global var compaction_nval) Removed.
2542 (global var compaction_case) Removed.
2543 (static var case_count) Removed.
2544 (struct procedure_aux_data) Removed.
2545 (struct split_aux_data) Removed.
2546 (procedure) Remove begin_func, end_func parameters. Rewrite.
2547 (static var not_canceled) Removed.
2548 (process_active_file) Removed.
2549 (process_active_file_write_case) Removed.
2550 (process_active_file_output_case) Removed.
2551 (prepare_for_writing) Moved into open_active_file().
2552 (arrange_compaction) Ditto.
2554 (open_active_file) Rewrote.
2555 (write_case) New function.
2556 [DEBUGGING] (index_to_varname) Removed.
2557 (execute_transformations) New function.
2558 (exclude_this_case) Renamed filter_case(), changed interface.
2559 (clear_case) Added struct ccase * parameter to interface.
2560 (close_active_file) Added struct write_case_data * parameter,
2562 (disk_sink_create) Removed.
2563 (disk_sink_destroy) Removed.
2564 (disk_sink_make_source) Removed.
2565 (disk_sink_write) Removed.
2566 (disk_source_count) Removed.
2567 (disk_source_destroy) Removed.
2568 (disk_source_read) Removed.
2569 (global var disk_sink_class) Removed.
2570 (global var disk_source_class) Removed.
2571 (global var memory_sink_class) Removed.
2572 (global var memory_source_class) Removed.
2573 (memory_sink_create) Removed.
2574 (memory_sink_destroy) Removed.
2575 (memory_sink_make_source) Removed.
2576 (memory_sink_write) Removed.
2577 (memory_source_count) Removed.
2578 (memory_source_destroy) Removed.
2579 (memory_source_get_cases) Removed.
2580 (memory_source_read) Removed.
2581 (memory_source_set_cases) Removed.
2582 (struct disk_stream_info) Removed.
2583 (struct memory_sink_info) Removed.
2584 (struct memory_source_info) Removed.
2585 (write_active_file_to_disk) Removed.
2586 (destroy_storage_stream_info) New function.
2587 (global var null_sink_class) New var.
2588 (global var storage_sink_class) New var.
2589 (global var storage_source_class) New var.
2590 (open_storage_file) New function.
2591 (storage_sink_destroy) New function.
2592 (storage_sink_make_source) New function.
2593 (storage_sink_open) New function.
2594 (storage_sink_write) New function.
2595 (storage_source_count) New function.
2596 (storage_source_destroy) New function.
2597 (storage_source_get_cases) New function.
2598 (storage_source_on_disk) New function.
2599 (storage_source_read) New function.
2600 (storage_source_set_cases) New function.
2601 (storage_source_to_disk) New function.
2602 (storage_to_disk) New function.
2603 (struct storage_stream_info) New structure.
2604 (write_storage_file) New function.
2605 (procedure_write_case) Removed.
2606 (create_case_source) Add `struct dictionary *' parameter, all
2608 (create_case_sink) Ditto.
2609 (free_case_sink) New function.
2610 (struct split_aux_data) New structure.
2611 (procedure_with_splits) New function implementing what procedure()
2613 (SPLIT_FILE_proc_func) Removed.
2614 (procedure_with_splits_callback) New function.
2615 (equal_splits) New function.
2617 * aggregate.c: Pass around a struct instead of using statics.
2618 (static var outfile) Remove.
2619 (enum type) Give it tag `missing_treatment'.
2620 (static var missing) Remove.
2621 (static var sort) Remove.
2622 (static var agr_first) Remove.
2623 (static var agr_next) Remove.
2624 (static var case_count) Remove.
2625 (static var prev_case) Remove.
2626 (static var buf64_1xx) Remove.
2627 (static var buf_1xx) Remove.
2628 (struct agr_proc) New structure incorporating the above.
2629 (cmd_aggregate) Use new struct. Clean up error handling using
2630 agr_destroy(). Completely rewrite actual implementation of
2632 (create_sysfile) Add struct agr_proc * parameter, modify
2634 (parse_aggregate_functions) Ditto.
2635 (free_aggregate_functions) Ditto. Rename agr_destroy().
2636 (aggregate_single_case) Add struct agr_proc * parameter, modify
2638 (accumulate_aggregate_info) Ditto.
2639 (dump_aggregate_info) Ditto.
2640 (initialize_aggregate_info) Ditto.
2641 (agr_00x_trns_proc) Removed.
2642 (agr_00x_end_func) Removed.
2643 (agr_10x_trns_proc) Removed.
2644 (agr_10x_trns_free) Removed.
2645 (agr_10x_end_func) Removed.
2646 (agr_11x_read) Removed.
2647 (agr_11x_finish) Removed.
2648 [DEBUGGING] (debug_print) Removed.
2649 (write_case_to_sfm) Add struct agr_proc * parameter, modify
2651 (agr_to_active_file) New function.
2652 (presorted_agr_to_sysfile) New function.
2653 (sort_agr_to_sysfile) New function.
2655 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
2657 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
2659 * descript.q: (cmd_descriptives) Ditto.
2661 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
2662 to new procedure() interface.
2664 * command.c: (cmd_execute) Adapt to new procedure() interface.
2666 * dictionary.c: (dict_compact_values) Also delete scratch
2668 (dict_get_compacted_value_cnt) New function.
2669 (dict_get_compacted_idx_to_fv) New function.
2671 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
2672 (cmd_flip) Adapt to new procedure() interface.
2673 (flip_sink_write) Use sink->idx_to_fv.
2675 * frequencies.q: (internal_cmd_frequencies) Use
2676 procedure_with_splits().
2678 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
2679 (static var mtf_sink) New static var.
2680 (static var mtf_case) New static var.
2681 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
2682 we actually implement the matching.
2683 (mtf_delete_file_in_place) Use mtf_case.
2684 (mtf_processing) Use mtf_case and mtf_sink.
2685 (cmd_export) Adapt to new procedure() interface.
2687 * levene.c: (levene) Use procedure_with_splits().
2689 * list.q: (cmd_list) Use procedure_with_splits().
2691 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
2692 procedure() interface.
2693 (read_matrices_with_rowtype) Ditto.
2695 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
2696 TEMPORARY. Adapt to new procedure() interface.
2698 * rename-vars.c: Warn about and cancel TEMPORARY.
2700 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
2701 (sort_cases) Use dict_get_compacted_value_cnt() instead of
2702 compaction_nval. Adapt to new procedure() interface. Use
2703 storage_source_to_disk().
2704 (do_internal_sort) Don't try to dump the cases to memory.
2705 (compare_case_lists) Pass null idx_to_fv.
2706 (struct initial_run_state) Add `idx_to_fv' member. Remove
2708 (write_initial_runs) Don't initialize irs->case_size. Adapt to
2709 new procedure() interface. Reset irs->idx_to_fv after calling
2711 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
2712 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
2714 (destroy_initial_run_state) Don't dereference irs after freeing
2716 (allocate_cases) Don't calculate case_size locally.
2717 (compare_record) Add idx_to_fv parameter.
2718 (compare_record_run) Change parameter from struct sort_cases_pgm *
2719 to struct initial_run_state *. Pass irs->idx_to_fv to
2721 (compare_record_run) Third parameter now a struct
2722 initial_run_state *.
2723 (output_record) No need for out_case anymore. Pass irs, not
2724 struct sort_cases_pgm to pop_heap(). Use case_size from struct
2726 (merge) Use case_size from struct sort_cases_pgm.
2727 (merge_once) Use case_size from struct sort_cases_pgm.
2728 Pass null pointer to compare_record() as idx_to_fv.
2729 (global var sort_sink_class) Make static.
2731 * t-test.q: (cmd_t_test) Use procedure_with_splits().
2733 * temporary.c: Remove debugging crap.
2735 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
2737 * t-test.q, levene.c: Fixed up the handling of MISSING values
2740 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
2742 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
2745 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
2747 Change explicit variable name checks into use of
2748 dict_class_from_id().
2750 * dictionary.c: (dict_create_var) Change explicit variable name
2751 check into use of dict_class_from_id().
2753 * get.c: (trim_dictionary) Ditto.
2755 * sel-if.c: (cmd_filter) Ditto.
2757 * sysfile-info.c: (cmd_display) Ditto.
2759 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
2761 * vfm.c: (arrange_compaction) Ditto.
2763 * weight.c: (cmd_weight) Ditto.
2765 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
2767 * temporary.c: (cmd_temporary) When TEMPORARY was the first
2768 transformation following the input program, if any, for some
2769 reason we special-cased f_trns. That's just wrong. It should
2770 always be set to n_trns.
2772 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
2774 * format.c: (parse_format_specifier_name) Fix brown-bag bug
2775 introduced in last check-in.
2777 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
2779 * format.c: (global array translate_fmt[]) Removed.
2780 (translate_fmt) New function as replacement.
2781 (parse_format_specifier_name) Rewrite.
2783 * pfm-read.c: (convert_format) Use translate_fmt() instead of
2786 * sfm-read.c: (parse_format_spec) Ditto.
2788 * postscript.c: (text) Fix handling of fonts with missing
2791 * sort.c: (struct external_sort) Add temp_name member.
2792 (destroy_external_sort) Free temp_dir, temp_name members.
2793 (init_external_sort) Allocate temp_name.
2794 (get_temp_file_name) Change prototype.
2795 (open_temp_file) Deal with change to get_temp_file_name().
2796 (close_temp_file) Ditto.
2797 (remove_temp_file) Ditto.
2798 (write_temp_file) Ditto.
2799 (read_temp_file) Ditto.
2800 (sort_sink_destroy) Removed.
2801 (sort_sink_class) Change destroy member to null.
2803 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
2805 Eliminate temp_case.
2807 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
2808 anymore. Use agr_11x_finish().
2809 (aggregate_single_case) Make first param const.
2810 (accumulate_aggregate_info) Ditto.
2811 (agr_00x_end_func) Use compaction_case, not temp_case.
2812 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
2814 * data-list.c: (struct data_list_pgm) Add `case_size' member.
2815 (cmd_data_list) Initialize case_size.
2816 (read_from_data_list_fixed) Add struct ccase * param, use instead
2818 (read_from_data_list_free) Ditto.
2819 (read_from_data_list_list) Ditto.
2820 (read_one_case) Rename data_list_trns_proc(), all references
2821 updated. Add argument in calling above functions. Use c
2822 argument instead of temp_case.
2823 (destroy_dls) Rename data_list_trns_free(), all references
2826 * expr-evl.c: (expr_evaluate) Make second parameter const.
2828 * file-type.c: (struct file_type_pgm) Add `case_size' member.
2829 (cmd_end_file_type) Initialize `case_size'.
2830 (file_type_source_read) Add struct ccase * parameter. Use instead
2833 * flip.c: Rewritten.
2835 * get.c: (struct get_pgm) New structure to keep track of
2837 (cmd_get) Initialize case_size.
2839 (get_source) Deal with struct get_pgm.
2840 (get_source_read) Add struct ccase * parameter, use instead of
2842 (import_source_read) Ditto.
2844 * get.c: Use a null pointer instead of temp_case to represent the
2845 "current case" in a struct mtf_file's input member.
2846 (mtf_processing_finish) Pass null to mtf_processing(), not
2848 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
2849 (mtf_compare_BY_values) Add extra arg, use instead of null input
2851 (mtf_processing) Use c parameter instead of temp_case. Pass
2852 compaction_case to process_active_file_output_case().
2854 * glob.c: (global variable temp_case) Removed.
2856 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
2857 (cmd_input_program) Initialize case_size. Set
2858 vfm_source->value_cnt.
2859 (init_case) Add struct ccase * parameter, use instead of
2862 (input_program_source_read) Ditto.
2864 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
2865 (dump_cell_content) Ditto.
2866 (nr_output_data) Ditto.
2867 (read_matrices_without_rowtype) Ditto.
2868 (matrix_data_read_with_rowtype) Ditto.
2869 (wr_read_splits) Ditto.
2870 (wr_output_data) Ditto.
2872 * sort.h: (struct sort_cases_pgm) New member `case_size'.
2874 * sort.c: (sort_cases) Initialize scp->case_size.
2875 (struct external_sort) Remove `case_size' member.
2876 (write_initial_runs) Only call vfm_sink->class_destroy if
2878 (struct sort_source_aux) New structure.
2879 (sort_source_read_helper) New function.
2880 (sort_source_read) Use sort_source_read_helper().
2881 (read_sort_output) Change interface to be more reasonable.
2882 (read_internal_sort_output) Ditto.
2883 (read_external_sort_output) Ditto.
2885 * vars-prs.c: (dict_class_to_name) Pass return value through
2888 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
2889 (procedure) Initialize trns_case.
2890 (procedure) Pass trns_case to vfm_source->class->read().
2892 (process_active_file) Start using struct procedure_aux_data.
2893 (process_active_file_write_case) Pass trns_case to
2894 transformations, lag_case(), clear_case().
2895 (process_active_file_output_case) Add struct ccase * parameter.
2896 (create_trns_case) New function.
2897 (make_temp_case) Removed.
2898 (vector_initialization) Removed.
2899 (close_active_file) Only call make_source if non-null, otherwise
2900 set vfm_source to null pointer. Don't free temp_case.
2901 (disk_source_read) Add struct ccase * parameter, use instead of
2903 (memory_source_read) Ditto.
2904 (lag_case) Add const struct ccase * member.
2905 (procedure_write_case) Use trns_case instead of temp_case.
2906 (clear_case) Add struct ccase * member, use instead of temp_case.
2907 (exclude_this_case) Ditto.
2908 (create_case_source) Add struct dictionary * parameter, use to
2909 initialize source->value_cnt.
2911 * vfm.h: (struct case_source) Add `value_cnt' member.
2912 (struct case_source_class) Add struct ccase * parameter to `read'
2913 member function pointer.
2914 (struct case_sink_class) Make struct ccase * parameter const in
2915 `write' member function pointer.
2917 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
2919 Fix a lot of "possibly uninitialized variable" warnings. Some of
2920 them are even real bugs. A few of them make me wonder how the
2923 * aggregate.c: (parse_aggregate_functions) Initialize `function.
2925 * ascii.c: (output_lines) Add default case to switch.
2927 * crosstabs.q: Remove static variable `expected' and all
2929 (display_crosstabulation) Always calculate expected value.
2931 (output_pivot_table) Initialize `cmp'.
2932 (display_crosstabulation) New variable `last_row', which is
2935 * data-in.c: (parse_numeric) Always initialize sign. How did this
2938 * data-list.c: (repeating_data_trns_proc) Always initialize code.
2939 Always set info.ofs. (How did this work?!)
2941 * expr-opt.c: (optimize_tree) Always initialize `m'.
2942 (evaluate_tree) Always initialize `c'. (How did this work?)
2944 * frequencies.q: (frq_custom_variables) Always initialize min,
2946 (frq_custom_grouped) Always initialize `dl'.
2948 * groff-font.c: (groff_read_font) Always initialize char_set.
2950 * matrix-data.c: (nr_output_data) Initialize `split'.
2951 (wr_read_splits) Remove shadowing split_cnt declaration.
2952 (wr_output_data) Initialize `split'.
2954 * output.c: (tokener) Skip add character on syntax error.
2956 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
2958 * postscript.c: (read_ps_encodings) Use line.string instead of
2960 (write_text) Add default case to switch.
2961 (text) Always initialize multiple variables. Fix bug with
2964 * print.c: (fixed_parse_fortran) Initialize head.
2965 (alloc_line) Add default case to switch.
2967 * recode.c: (parse_dest_spec) Handle case where nothing matches.
2968 (recode_trns_proc) Move variable declaration inward. Add default
2971 * sfm-read.c: (read_header) Initialize skip_amt.
2973 * sysfile-info.c: (display_variables) Always initialize pc.
2975 * vars-prs.c: Initialized `included'.
2977 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
2979 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
2980 Just use signal() instead.
2982 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
2984 Get rid of vfm_sink_info and vfm_source_info.
2986 * aggregate.c: (agr_00x_end_func) Don't increment
2987 sfm_sink_info.ncases.
2989 * sort.c: (do_internal_sort) Get case count from
2990 vfm_source->class->count().
2991 (struct external_sort) Add `case_size' member.
2992 (do_external_sort) Initialize case_size.
2993 (struct initial_run_state) Add `case_size' member.
2994 (write_initial_runs) Initialize case_size.
2995 (sort_sink_write) Use case_size.
2996 (read_external_sort_output) Use case_size. Get case_cnt from
2999 * vfm.c: (struct write_case_data) Add underscores to existing arg
3000 names, all references updated. Renamed `aux' as `func_aux', all
3001 references updated. Added new `aux' member.
3002 (global var vfm_source_info) Removed.
3003 (global var vfm_sink_info) Removed.
3004 (struct procedure_aux_data) New.
3005 (struct split_aux_data) New.
3006 (procedure) Use `aux' fields for procedure_aux_data,
3008 (process_active_file_write_case) Pass case_count + 1 to
3009 transformation procedures, exclude_this_case().
3010 (process_active_file_output_case) Don't increment
3011 vfm_sink_info.ncases.
3012 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
3013 to send data to disk early.
3014 (make_temp_case) Don't use vfm_sink_info.case_size.
3015 (close_active_file) Don't initialize vfm_source_info.
3016 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
3017 (disk_sink_create) Initialize and/or update disk_stream_info.
3018 (disk_sink_write) Ditto.
3019 (disk_sink_destroy) Ditto.
3020 (disk_sink_make_source) Ditto.
3021 (disk_source_read) Ditto.
3022 (disk_source_destroy) Ditto.
3023 (global var disk_source_class) Add disk_source_count().
3024 (disk_source_count) New function.
3025 (struct memory_sink_info) Add `case_cnt', `case_size' members.
3026 (struct memory_source_info) Ditto.
3027 (memory_sink_create) Deal with case_cnt, case_size.
3028 (memory_sink_write) Ditto.
3029 (memory_sink_make_source) Ditto.
3030 (memory_source_read) Ditto.
3031 (memory_source_count) New function.
3032 (memory_source_class) Add memory_source_count().
3033 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
3034 proc_aux->cases_written, and pass it to transformation procedures
3035 and exclude_this_case ().
3036 (exclude_this_case) Add case_num parameter. Pass it to
3038 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
3041 * vfm.h: (struct case_source_class) Add `count' member.
3043 * vfmP.h: (struct stream_info) Removed.
3044 (global variable vfm_source_info) Removed.
3045 (global variable vfm_sink_info) Removed.
3047 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
3049 * var.h: (typedef trns_proc_func) New typedef.
3050 (trns_free_func) New typedef.
3051 (struct trns_header) Change `proc' to type trns_proc_func, `free'
3052 to type trns_free_func. This only changes the actual type of
3053 trns_proc_func, adding a `case_num' parameter. Updated all
3054 implementations to use the typedefs instead.
3056 * compute.c: (compute_num) Pass case_num to expr_evaluate().
3057 (compute_num_vec) Ditto.
3058 (compute_str) Ditto.
3059 (compute_str_vec) Ditto.
3061 * do-if.c: (do_if_trns_proc) Ditto.
3063 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
3066 * inpt-pgm.c: (input_program_source_read) Maintain case count,
3067 pass to transformation functions.
3068 (reread_trns_proc) Pass case_num arg to expr_evaluate().
3070 * loop.c: (loop_1_trns_proc) Ditto.
3071 (loop_2_trns_proc) Ditto.
3072 (loop_3_trns_proc) Ditto.
3074 * print.c: (print_space_trns_proc) Ditto.
3076 * sel-if.c: (select_if_proc) Ditto.
3078 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
3080 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
3081 destroying hash table.
3083 * glob.c: (read_active_file) Variable not referenced, removed.
3084 (cancel_input_pgm) Ditto.
3086 * levene.c: Add #include <stdlib.h> needed to call free().
3088 * aggregate.c: (parse_aggregate_functions) Make `function'
3091 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
3093 Start working to eliminate VFM dependence on static variables.
3095 * command.c: (cmd_parse) Use case_source_is_class().
3097 * data-list.c: Rewrite to eliminate use of static variables.
3099 * dfm.c: (cmd_begin_data) Use case_source_is_class().
3101 * file-handle.q: (fh_handle_name) Make parameter const.
3103 * file-type.c: Rewrite to eliminate use of static variables.
3105 * flip.c: Rewrite to eliminate use of static variables.
3107 * format.c: (get_format_var_width) New function.
3109 * get.c: Eliminate use of static variables.
3111 * inpt-pgm.c: Eliminate use of static variables.
3113 * matrix-data.c: Eliminate use of static variables.
3115 * set.q: (set_max_workspace) New variable.
3116 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
3118 * var.h: (struct case_list) Move here from vfmP.h.
3120 * vars-atr.c: (discard_variables) Handle new vfm_source type.
3122 * vfm.c: (vfm_source) Change type from struct case_stream to
3124 (vfm_sink) Change type from struct case_stream to struct
3126 (static var paging) Rename workspace_overflow, all references
3128 (procedure) Use new class structures.
3129 (process_active_file) Ditto.
3130 (process_active_file_write_case) Ditto.
3131 (prepare_for_writing) Use set_max_workspace. Use new class
3133 (close_active_file) Use new class structures. Free old sink.
3134 (global var disk_source_file) Removed.
3135 (global var disk_sink_file) Removed.
3136 (disk_stream_init) Removed.
3137 (disk_stream_read) Removed.
3138 (disk_stream_write) Removed.
3139 (disk_stream_mode) Removed.
3140 (disk_stream_destroy_source) Removed.
3141 (disk_stream_destroy_sink) Removed.
3142 (global var vfm_disk_stream) Removed.
3143 (disk_sink_create) New function.
3144 (disk_sink_write) New function.
3145 (disk_sink_destroy) New function.
3146 (disk_sink_make_source) New function.
3147 (disk_sink_class) New static var.
3148 (disk_source_read) New function.
3149 (disk_source_destroy) New function.
3150 (global var vfm_source_class) New var.
3151 (global var memory_source_cases) Removed.
3152 (global var memory_sink_cases) Removed.
3153 (global var memory_sink_max_cases) Removed.
3154 (struct memory_sink_info) New struct.
3155 (memory_stream_init) Removed.
3156 (memory_stream_read) Removed.
3157 (memory_stream_write) Removed.
3158 (memory_stream_mode) Removed.
3159 (memory_stream_destroy_source) Removed.
3160 (memory_stream_destroy_sink) Removed.
3161 (global var vfm_memory_stream) Removed.
3162 (page_to_disk) Renamed write_active_file_to_disk().
3163 (memory_sink_create) New function.
3164 (memory_sink_write) New function.
3165 (memory_sink_destroy) New function.
3166 (memory_sink_make_source) New function.
3167 (memory_sink_class) New static var.
3168 (memory_source_read) New function.
3169 (memory_source_destroy) New function.
3170 (memory_source_get_cases) New function.
3171 (memory_source_set_cases) New function.
3172 (global var vfm_source_class) New var.
3173 (procedure_write_case) Use new class structures.
3174 (create_case_source) New function.
3175 (case_source_is_complex) New function.
3176 (case_source_is_class) New function.
3177 (create_case_sink) New function.
3179 * vfm.h: (global variable reinit_sysmis) Not used, removed.
3180 (global variable reinit_blanks) Not used, removed.
3181 (global variable init_zero) Not used, removed.
3182 (global variable init_blanks) Not used, removed.
3183 (struct case_source) New struct.
3184 (struct case_source_class) New struct.
3185 (struct case_sink) New struct.
3186 (struct case_sink_class) New struct.
3187 (struct case_stream) Removed.
3189 * vfmP.h: (struct case_list) Moved to var.h.
3191 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
3193 * algorithm.c: (count_equal) New function.
3194 (count_if) New function.
3195 (unique) Add assertions.
3196 (partition) Add assertions.
3197 (is_partitioned) New function.
3198 (copy_if) Add assertions.
3199 (remove_equal) Add assertions.
3200 (lexicographical_compare) Rename lexicographical_compare_3way.
3201 (sort) Add assertions. Rephrase some code.
3202 (is_sorted) New function.
3204 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
3208 * sort.c: Completely rewrite.
3210 * sort.h: Expose interface via struct sort_cases_pgm, not via
3213 * aggregate.c: (sort) New static var.
3214 (cmd_aggregate) Use sort.
3215 (create_sysfile) Ditto.
3216 (aggregate_single_case) Ditto.
3217 (dump_aggregate_info) Ditto.
3218 (agr_00x_end_func) Ditto.
3219 (debug_print) Ditto.
3221 * var.h: (enum SRT_ASCEND) Removed.
3222 (enum SRT_DESCEND) Removed.
3223 (struct sort_cases_proc) Removed.
3224 (struct variable) Remove p.srt member.
3226 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
3228 Get rid of the old, crappy heap structure and replace it by a new,
3229 shiny, C++ STL-like heap structure.
3231 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
3233 * algorithm.c: (push_heap) New function.
3244 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
3246 Increase warning level.
3248 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
3250 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
3252 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
3254 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
3256 * dictionary.c: (dict_create_var) Fix root cause of bug worked
3257 around by previous change log entry.
3259 * compute.c: (lvalue_finalize) Remove workaround from previous
3262 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3264 * compute.c: Fixed a bug where the Format was not getting set for
3265 computed variables (thus causing a crash when SAVEing).
3267 * Added a test to stop this bug ever coming back
3269 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
3271 Got rid of approx.h. In general, replaced all references to
3272 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
3275 * Makefile.am: (pspp_SOURCES) Removed approx.h.
3277 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
3278 test for mag < EPSILON.
3280 * misc.h: Add definition of EPSILON.
3282 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
3284 * vfm.c: (procedure) Add check to prevent recursive call.
3286 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
3288 * Moved the declarations relating to values to their own header file
3291 * Added levene.c and levene.h
3293 * vars-atr.c: Changed the signature of compare_values to
3294 take const * arguments.
3296 * t-test.q: Changed the structure of struct t_test_proc
3297 variables now contain their own group statistics information.
3298 Eventually, t_test_proc might get renamed, because it'd be
3299 applicable to other commands too.
3301 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
3303 * data-out.c: Clean up. Changed interface of convert_*() to take
3304 either a `double' or a `const char *' instead of a `const union
3305 value *'. Update all implementations of those interfaces.
3306 (data_out) Use switch statements instead of a table.
3307 (convert_AHEX) Rewrite.
3309 * format.h: Update comment.
3311 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
3313 * q2c.c: (dump_header) Add an Emacs header line to output files
3314 that makes generated .c files read-only by default, to make it
3315 difficult to accidentally change generated files.
3317 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
3319 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
3320 not bogus a->v.c <=> b->v.c pointer compare.
3321 (compare_freq_alpha_a) Ditto.
3322 (compare_freq_numeric_d) Ditto.
3323 (compare_freq_alpha_d) Ditto.
3325 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
3327 Changed data_out() to store string data directly into a `union
3328 value''s s member, not indirectly into c.
3330 * crosstabs.q: (output_pivot_table) Use format_short() instead of
3332 (table_value_missing) Ditto.
3333 (float_M_suffix) Ditto.
3334 (format_short) New function.
3336 * data-in.h: (data_in_finite_line) Remove inline definition.
3338 * data-list.c: (destroy_dls_var_spec) New function.
3339 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
3340 (data_list_source_destroy_source) Avoid cast.
3341 (struct repeating_data_trns) New field `id_value'. Update
3343 (cmd_repeating_data) Initialize id_value. Use new
3344 repeating_data_trns_free() for freeing REPEATING DATA
3346 (rpd_parse_record) Rewrite support for record ID to be less bogus.
3347 (repeating_data_trns_free) New function.
3349 * data-out.c: (data_out) Change return type to `void' by replacing
3350 error returns by writing a message into the output buffer.
3351 (convert_A) Read from v->s instead of v->c.
3352 (convert_AHEX) Ditto.
3354 * expr-evl.c: Update comment.
3355 (expr_evaluate) Add assertion in OP_STRING case.
3357 * format.h: (macro MAX_FORMATTED_LEN) New macro.
3359 * list.q: (list_cases) Update for new data_out() semantics.
3361 * print.c: (print_trns_proc) Ditto.
3363 * tab.c: (tab_value) Ditto.
3364 (tab_float) Avoid stupid cast.
3366 * var.h: Update comments.
3367 (macro MAX_STRING) New macro.
3368 (macro MAX_ELEMS_PER_VALUE) New macro.
3370 * vars-atr.c: (compare_values) New function.
3372 * vfm.c: (dump_splits) Update for new data_out() semantics.
3374 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
3376 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
3378 (struct crosstab) Rename v[] to vars[]. All references updated.
3379 (hash_table_entry) Replace the hash algorithm and fix a bug at the
3380 same time, which caused the hash value to depend only on a single
3381 value, not all of the variables' values.
3383 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
3385 Clean up struct dictionary's value_cnt usage.
3387 * dictionary.c: Add a function comment to each function.
3388 (struct dictionary) Rename value_cnt to next_value_idx, which more
3389 accurately reflects its meaning. All references updated.
3390 (dict_rename_vars) Add assertion.
3391 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
3393 (dict_get_case_size) New function.
3395 * aggregate.c: (create_sysfile) Use dict_get_case_size().
3397 * get.c: (mtf_read_nonactive_records) Ditto.
3399 * sort.c: (allocate_cases) Ditto.
3400 (write_initial_runs) Ditto.
3404 * vfm.c: (prepare_for_writing) Ditto.
3408 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
3410 Make vfm.c slightly less grotesque.
3412 * vfm.c: (filter_var) Removed.
3413 (filter_index) Removed.
3414 (FILTERED macro) Removed.
3415 (exclude_this_case) New function.
3416 (process_active_file_write_case) Use exclude_this_case() instead
3417 of FILTERED and inline tests.
3418 (procedure_write_case) Ditto.
3419 (setup_filter) Removed.
3420 (open_active_file) Don't call setup_filter().
3421 (close_active_file) Call dict_get_filter() instead of checking
3424 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
3426 * var.h: (struct variable) Update comments.
3428 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
3430 New functions dict_create_var_assert(), dict_lookup_var_assert().
3431 Converted several dict_*_var()/assert pairs into a single
3432 dict_*_var_assert().
3434 * dictionary.c: (dict_create_var_assert) New function.
3435 (dict_lookup_var_assert) New function.
3437 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
3439 Got rid of "struct long_vec", envector(), devector(), etc. Added
3440 two members `init', `reinit' to struct variable as a substitute.
3442 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
3448 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
3451 * autorecode.c: (cmd_autorecode) destvars don't need init.
3453 * compute.c: (lvalue_finalize) Set reinit.
3455 * data-list.c: (fixed_parse_compatible) Don't need init usually.
3456 (dump_fmt_list) Ditto.
3459 * descript.q: (run_z_pass) Don't need init for z-scores.
3461 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
3463 (dict_clone_var) Copy `reinit' member, initialize `init' member.
3465 * glob.c: (init_glob) Remove vec_init() calls.
3467 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
3469 * loop.c: (internal_cmd_loop) Don't need to call envector().
3471 * numeric.c: (cmd_numeric) Ditto.
3473 (cmd_leave) Ditto. Set `init', `reinit' members.
3475 * recode.c: (cmd_recode) Don't need to call envector().
3477 * repeat.c: (internal_cmd_do_repeat) Ditto.
3479 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
3480 (force_create_variable) Removed prototype.
3481 (force_dup_variable) Ditto.
3483 * vector.c: (cmd_vector) Don't need to call envector().
3485 * vfm.c: (reinit_sysmis) Removed.
3486 (reinit_blanks) Removed.
3487 (init_zero) Removed.
3488 (init_blanks) Removed.
3489 (process_active_file_write_case) No need to deal with vectors.
3490 Call clear_temp_case().
3491 (vector_initialization) Rewrite to use `init', `reinit'.
3492 (close_active_file) No need to call vec_clear().
3493 (procedure_write_case) Call clear_temp_case().
3494 (clear_temp_case) New function.
3496 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
3498 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
3501 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
3503 Add auxiliary argument to procedure() interface. Associated small
3504 clean-ups of vfm interface.
3506 * Updated every caller of procedure() and process_active_file() to
3507 reflect modified interface. Simple, ordinary changes not listed
3510 * Updated every function that implements struct case_stream's
3511 `read' function to take a write_case_func and a write_case_data.
3512 Also updated every caller of write_case() to instead call them
3513 through these arguments. In some cases this meant that the extra
3514 args had to be threaded through a couple of extra levels. This
3515 wasn't difficult or interesting so the details won't be given.
3517 * data-list.c: (struct repeating_data_trns) Add members
3518 `write_case', `wc_data' as kluge.
3519 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
3521 (repeating_data_set_write_case) New function.
3523 * data-list.h: New file to declare repeating_data_trns_proc() and
3524 repeating_data_set_write_case().
3526 * inpt-pgm.c: (input_program_source_read) Call
3527 repeating_data_set_write_case() for all the REPEATING DATA
3528 transformations, so that they know where to send their cases.
3529 It's a big kluge. Also kluge in END CASE.
3530 (end_case_trns_proc) Never called anymore, but we still need it,
3533 * sort.c: (read_sort_output) Update to match struct case_stream
3536 * vfm.c: (struct write_case_data) New structure.
3537 (proc_func) Removed.
3538 (virt_proc_func) Removed.
3539 (begin_func) Removed.
3540 (virt_begin_func) Removed.
3542 (write_case) Removed.
3543 (procedure) Added an auxiliary parameter to each function pointer
3544 argument's prototype. Added an auxiliary data parameter.
3546 (process_active_file) Ditto.
3547 (process_active_file_write_case) Pass aux data along.
3548 (close_active_file) Ditto.
3549 (procedure_write_case) Ditto.
3550 (SPLIT_FILE_procfunc) Ditto.
3552 * vfm.h: (typedef write_case_data) New.
3553 (typedef write_case_func) New.
3554 (struct case_stream) Add parameters to `read' member prototype.
3556 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
3558 * t-test.q: Added calculations for independent samples. (But no Levene
3561 * Makefile.am: Moved q_sources_c into own variable
3563 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
3565 Miscellaneous cleanups.
3567 * Change unused to UNUSED in many source files to reflect modified
3568 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
3569 __CYGWIN32__, __unix__, and unix not to assume that they're
3570 defined to a nonzero value. Change use of __attribute__ to use
3571 NO_RETURN or PRINTF_FORMAT instead.
3573 * alloc.h: Move definitions for local_alloc(), local_free() here
3574 from ../pref.h.orig and simplify.
3576 * expr-evl.c: Instead of working differently based on PAGED_STACK,
3577 use a pool allocator unconditionally.
3578 (CHECK_STRING_SPACE) Removed.
3579 (ALLOC_STRING_SPACE) Removed.
3580 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
3583 * expr-opt.c: (dump_expression) Allocate string pool.
3585 * expr-prs.c: (expr_free) Free string pool.
3587 * pool.c: (pool_destroy) This pool must be removed from its
3588 parent's list of gizmos, not from its own. Use free_all_gizmos().
3589 (pool_clear) New function.
3590 (free_all_gizmos) New function.
3591 (pool_alloc) Use space in empty block after this one if any.
3592 (pool_release) Only empty out blocks, don't actually free() them.
3594 * print.c: Get rid of PAGED_STACK special case by always
3595 dynamically allocating line buffers.
3596 (struct print_trns) Always include the `line' member.
3597 (internal_cmd_print) Always initialize the `line' member.
3598 (alloc_line) Always allocate memory for `line'.
3599 (print_trns_proc) Always initialize buf from `line' member.
3600 (print_trns_free) Always free `line' memory.
3602 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
3605 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
3607 * flip.c: Fixed crash from FLIP when a numeric variable is
3608 specified on NEWNAMES and a large value is used, and a couple of
3609 other minor bugs besides.
3610 (struct varname) Make name a 9-character fixed-size array
3611 instead of a 1-character variable size array.
3612 (make_new_var) Allow digits in variable names.
3613 (flip_stream_write) Limit numeric values to 8 characters and
3614 format system missing and very large and small values more
3617 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
3619 * command.c: Fixed test on command return status for the correct
3620 value, which had been causing a crash under certain invalid input.
3622 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
3624 * t-test.q: Added calculations for the one sample variant of the T-TEST
3626 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
3628 * tab.c: (render_strip) Fix bug that sometimes caused joined text
3629 in joined cells to be rendered outside box boundaries.
3631 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
3633 * random.c (rng_create): Fixed seeding so that it gets reseeded after
3634 SET seed=xx has been called.
3636 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
3638 * random.c (rng_get_double): Fix always-returning-zero bug in my
3639 preferred way, and at the same time make sure rounding doesn't
3642 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
3644 * html.c: (change_attributes) Dead code, removed.
3645 (escape_string) Eliminate code to call change_attributes() that
3646 never actually called it.
3647 (output_tab_table) Get rid of dependence on tab_hit
3648 and struct tab_joined_cell's hit member, which are abominations.
3650 * tab.c: (tab_output_text) Don't call
3651 d->class->text_set_font_by_name if it's a null pointer.
3652 (macro UNROLL_LOOP) Eliminate.
3653 (macro UNROLL_3_LOOPS) Eliminate.
3654 (tabi_render) Rewrite not to use the above macros.
3656 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
3658 Start working on a new output driver system, one that doesn't suck
3659 so much, by adding a "device-independent" output driver. The idea
3660 is to write out only a single output stream, then use separate
3661 processes to translate them into whatever formats we want. This
3662 is similar to how "groff" works with its various output drivers
3663 (grops, grotty, grodvi, ...).
3665 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
3667 * list.q: (write_all_headers) Stub out devind class.
3669 (determine_layout) Ditto.
3672 * output.c: (outp_init) Add devind class.
3674 * devind.c: New file.
3676 * devind.h: New file.
3678 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
3680 * frequencies.q: (hash_value_alpha) Fixed up the previous change
3681 to use the proper string length.
3683 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
3685 * Fixed bug where FREQ would crash on alpha values
3687 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
3689 * Removed bletcherous alloca() workarounds for AIX from top of
3690 many files. AIX can use the alternative alloca() implementation
3693 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
3695 * ascii.c: (ascii_option) Fix implementation of headers option.
3697 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
3699 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
3700 multiple blank lines into one.
3701 (struct ascii_driver_ext) Add squeeze_blank_lines option.
3702 (ascii_preopen_driver) Initialize squeeze_blank_lines.
3703 (static var option_tab) Add squeeze entry.
3704 (ascii_option) Set squeeze_blank_lines.
3705 (output_lines) Implement squeezing blank lines.
3707 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
3709 * Removed redundant code from output.h
3711 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
3713 Dictionary classes: each variable is "ordinary", "system", or
3716 * var.h: (enum dict_class) New enum.
3718 * vars-prs.c: (dict_class_from_id) New function.
3719 (dict_class_to_name) New function.
3721 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
3723 * var.h: (struct freq_tab_set) Removed (not used).
3725 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
3727 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
3729 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
3731 * stats.c: (hypercube) Rename pow4(). All references updated.
3733 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
3735 * rename-vars.c: (cmd_rename_variables) Rewritten.
3736 (compare_name) Removed.
3738 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
3740 var_set feature, and code taking advantage of it.
3742 * crosstabs.q: (static var var_dict) Removed.
3743 (static var variables) New variable.
3744 (static var variables_cnt) New variable.
3745 (cmd_crosstabs) Free variables instead of var_dict.
3746 (internal_cmd_crosstabs) Initialize and use variables,
3747 variables_cnt instead of var_dict.
3748 (free_var_dict) Removed.
3749 (crs_custom_tables) Use var_set instead of a copied dictionary.
3750 (crs_custom_variables) Set up variables, variables_cnt instead of
3752 [DEBUGGING] (debug_print) Ditto.
3754 * means.q: (mns_custom_tables) Use var_set instead of a copied
3757 * vars-prs.c: (parse_vs_variable) New function.
3758 (parse_dict_variable) Rewritten.
3759 (parse_variable) Rewritten.
3760 (parse_variables) Renamed parse_var_set_vars(), rewritten.
3761 (parse_variables) New function in terms of parse_var_set_vars().
3762 Now requires its first argument to be non-null. All references
3763 that passed a null pointer updated to pass default_dict instead.
3764 (macro id_dict) Removed.
3765 (parse_DATA_LIST_vars) Add assertions.
3766 (parse_mixed_vars) Ditto.
3767 (struct var_set) New structure.
3768 (var_set_get_cnt) New function.
3769 (var_set_get_var) New function.
3770 (var_set_lookup_var) New function.
3771 (var_set_destroy) New function.
3772 (dict_var_set_get_cnt) New function.
3773 (dict_var_set_get_var) New function.
3774 (dict_var_set_lookup_var) New function.
3775 (dict_var_set_destroy) New function.
3776 (var_set_create_from_dict) New function.
3777 (struct array_var_set) New structure.
3778 (array_var_set_get_cnt) New function.
3779 (array_var_set_get_var) New function.
3780 (array_var_set_lookup_var) New function.
3781 (array_var_set_destroy) New function.
3782 (var_set_create_from_array) New function.
3784 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
3785 instead of parse_variables(NULL, ...) in output code.
3787 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
3789 Change inp_init from a 2-bit vector to an ordinary array.
3790 Initialize it all in cmd_end_input_program() instead of in
3793 * inpt-pgm.c: (enum value_init_type) New enum.
3794 (global var inp_init) Change to `enum value_init_type *', make
3796 (inp_init_size) Removed.
3797 (inp_nval) Change to `size_t', make static.
3798 (cmd_input_program) Don't initialize inp_init or inp_init_size.
3799 (cmd_end_input_program) Initialize inp_init, inp_nval.
3800 (init_case) Rewrite.
3801 (clear_case) Rewrite.
3803 * inpt-pgm.h: Removed.
3805 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
3807 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
3808 Colin Plumb hash. It is simpler and should better resist
3810 (hsh_hash_string) Ditto.
3812 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
3814 * get.c: (export_write_case_func) Remove debug printing code.
3816 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
3818 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
3820 (save_write_case_func) Use &trns->h instead of cast.
3821 (cmd_export) Use &t->h instead of cast.
3823 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
3825 Moved vectors into the dictionary.
3827 * var.h: (struct vector) Moved here from vector.h. `index' member
3828 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
3831 * vector.h: Removed.
3833 * vector.c: (global var vec) Removed.
3834 (global var nvec) Removed.
3835 (cmd_vector) Rewritten.
3836 (find_vector) Removed.
3838 * dictionary.c: (dict_create_vector) New function.
3839 (dict_get_vector) New function, replaces reading global vec[]
3841 (dict_get_vector_cnt) New function, replaces reading global nvec
3843 (dict_lookup_vector) New function, replaces find_vector().
3844 (dict_clear_vectors) New function.
3846 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
3848 Start to move away from `struct variable' p `union' member to void
3851 * var.h: (struct variable) Add `aux' member.
3853 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
3855 Get rid of struct variable `foo' member.
3857 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
3859 (frq_custom_variables) Ditto.
3860 (frq_custom_grouped) Ditto.
3862 * get.c: (struct save_trns) Change `var' member from `int *' to
3863 `struct variable **'.
3864 (cmd_save_internal) Use aux instead of foo.
3865 (save_trns_proc) Use revised `var' member.
3866 (static var mtf_seq_no) Renamed mtf_seq_num.
3867 (static var mtf_seq_nums) New static var.
3868 (cmd_match_files) Initialize mtf_seq_nums.
3869 (mtf_free) Free mtf_seq_nums.
3870 (mtf_processing) Use mtf_seq_nums instead of foo.
3871 (mtf_merge_dictionary) No need to initialize mv->foo.
3872 (cmd_export) Use aux instead of foo. Use revised `var' member.
3873 (mns_custom_tables) Don't use foo to check for duplicates, that's
3874 what PV_NO_DUPLICATE is for.
3876 * var.h: (struct variable) Remove `foo' member.
3877 (struct frequencies_proc) New member.
3879 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
3881 Clean up COMPUTE and IF.
3883 * compute.c: More or less rewrite the darn thing.
3884 (struct compute_trns) Rename and reorder and add and delete
3886 (cmd_compute) Rewrite.
3887 (compute_num) Make conditional on test expression. Now used for
3888 both COMPUTE and IF.
3889 (compute_num_vec) Ditto.
3890 (compute_str) Ditto.
3891 (compute_str_vec) Ditto.
3894 (if_num_vec) Removed.
3896 (if_str_vec) Removed.
3897 (parse_target_expression) Renamed parse_rvalue_expression(),
3899 (new_trns) Renamed compute_trns_create(), rewritten.
3900 (delete_trns) Removed.
3901 (free_trns) Renamed compute_trns_free(), rewritten.
3902 (struct lvalue) New structure.
3903 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
3904 (lvalue_get_type) New function.
3905 (lvalue_is_vector) New function.
3906 (lvalue_finalize) New function.
3907 (lvalue_destroy) New function.
3909 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
3911 * command.def: Disallow MODIFY VARS in input mode, so that
3912 variables can't get dropped and confuse cmd_end_input_program()'s
3913 attempt to fill inp_init[].
3915 * modify-vars.c: (static var forward_positional_ordering) New
3917 (struct var_modification) Entirely changed.
3918 (rearrange_dict) Interface changed, rewritten.
3919 (cmd_modify_vars) Deal with modified struct var_modification, much
3921 (struct var_renaming) New structure.
3922 (compare_var_renaming_by_new_name) New function.
3923 (validate_var_modification) New function.
3925 * var.h: (struct modify_vars_proc) Removed.
3926 (struct variable) Removed member p.mfv.
3928 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
3930 Make EVALUATE a valid command whether we're debugging or not, so
3931 that `make check' can succeed regardless of whether debugging is
3934 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
3936 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
3938 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
3940 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
3941 statement by a simple if test.
3943 * dfm.c: (dfm_get_record) Add assertion.
3945 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
3947 For each file x.c, move #include "x.h" to the very top of the
3948 include list, to catch x.h failing to include the proper headers.
3950 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
3952 * algorithm.c: (find) New function.
3953 (remove_equal) New function.
3954 (set_difference) New function.
3955 (adjacent_find_equal) New function.
3956 [TEST_UNIQUE] Removed test case.
3957 (copy_if) Find end test.
3959 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
3961 * dictionary.c: (dict_get_case_weight) New convenience function.
3963 * aggregate.c: (accumulate_aggregate_info) Use
3964 dict_get_case_weight().
3966 * frequencies.q: (calc_general) Ditto.
3967 (calc_integer) Ditto.
3970 * t-test.q: (groups_calc) Ditto.
3973 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
3975 * glob.c: (global var default_dict) Change from `struct
3976 dictionary' to `struct dictionary *'. All references changed.
3977 (init_glob) Initialize default_dict with dict_create().
3979 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
3981 struct dictionary now made opaque. All related functions:
3983 * get.c: (rename_variables) Removed.
3984 (dict_delete_run) Removed.
3986 * temporary.c: (copy_variable) Removed.
3987 (new_dictionary) Removed.
3988 (save_dictionary) Removed.
3989 (restore_dictionary) Removed.
3990 (free_dictionary) Removed.
3992 * vars-atr.c: (clear_default_dict) Removed.
3993 (find_variable) Removed.
3994 (find_dict_variable) Removed.
3995 (create_variable) Removed.
3996 (delete_variable) Removed.
3997 (common_init_stuff) Removed.
3998 (init_variable) Removed. Updating of inp_init moved into
3999 cmd_end_input_program().
4000 (replace_variable) Removed.
4001 (rename_variable) Removed.
4002 (clear_variable) Removed.
4003 (dup_variable) Removed.
4005 * vars-prs.c: (is_varname) Removed.
4006 (is_dict_varname) Removed.
4007 (fill_all_vars) Removed.
4009 * vector.c: (find_vector) Removed.
4011 * weight.c: (stop_weighting) Removed.
4013 * dictionary.c: New file.
4014 (dict_create) New, replaces new_dictionary().
4015 (dict_clone) New, replaces save_dictionary() and
4016 restore_dictionary().
4017 (dict_clear) New, replaces clear_default_dict().
4018 (dict_destroy) New, replaces free_dictionary().
4019 (dict_get_var_cnt) New function, replaces references to
4021 (dict_get_var) New function, replaces references to dict->var[i].
4022 (dict_get_vars) New function, replaces fill_all_vars().
4023 (dict_create_var) New, replaces create_variable(). Interface
4024 drops `type' parameter, using a zero `width' to designate numeric.
4025 (dict_clone_var) New, replaces dup_variable().
4026 (dict_rename_var) New, replaces rename_variable().
4027 (dict_lookup_var) New, replaces find_variable(),
4028 find_dict_variable(), is_varname().
4029 (dict_contains_var) New function.
4030 (compare_variable_dblptrs) New function.
4031 (dict_delete_var) New function, replaces clear_variable().
4032 (dict_delete_vars) New function, replaces dict_delete_run().
4033 (dict_reorder_vars) New function.
4034 (dict_rename_vars) New function, replaces rename_variables().
4035 (dict_get_weight) New function, replaces reading dict->weight_var.
4036 (dict_set_weight) New function, replaces writing dict->weight_var
4037 or calling stop_weight(dict).
4038 (dict_get_filter) New function, replaces reading dict->filter_var.
4039 (dict_set_filter) New function, replaces writing dict->filter_var.
4040 (dict_get_case_limit) New function, replaces reading dict->N.
4041 (dict_set_case_limit) New function, replaces writing dict->N.
4042 (dict_get_value_cnt) New function, replaces reading dict->nval.
4043 (dict_compact_values) New function, replaces a loop that was
4044 replicated in several places.
4045 (dict_get_split_vars) New function, replaces reading dict->splits.
4046 (dict_get_split_cnt) New function, replaces reading
4048 (dict_set_split_vars) New function, replaces writing dict->splits.
4049 (dict_get_label) New function, replaces reading dict->label.
4050 (dict_set_label) New function, replaces writing dict->label.
4051 (dict_get_documents) New function, replaces reading
4053 (dict_set_documents) New function, replaces writing
4056 All references to above functions updated.
4058 * aggregate.c: (cmd_aggregate) Copy file label and documents from
4059 old dictionary to new by hand, because dict_create() can't do it
4060 itself. Use dict_set_documents(), dict_set_split_vars().
4062 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
4063 calling dict_destroy().
4065 * data-list.c: (dls_var_spec) Remove `type' member, replace by
4067 (fixed_parse_compatible) Some slightly nontrivial changes for
4069 (dump_fmt_list) Ditto.
4072 * file-type.c: (create_col_var) Ditto.
4074 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
4075 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
4076 (rename_variables) Use dict_rename_vars().
4077 (mtf_merge_dictionary) Use dict_get_documents(),
4078 dict_set_documents(), dict_compact_values().
4080 * pfm-read.c: (read_variables) Deal with changes to weighting.
4082 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
4083 is_varname() in output code.
4085 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
4086 other dictionary functions.
4088 * title.c: (add_document_line) Use dict_get_documents(),
4089 dict_set_documents().
4091 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
4092 reset default_handle by hand. dict_clear() will clear vectors so
4093 there's no need for that by hand.
4095 * vfm.c: (close_active_file) Move call to finish_compaction()
4096 earlier, so that we can do the compaction as a single step using
4097 dict_compact_values(). Use dict_clear_vectors().
4098 (finish_compaction) Use dict_delete_var(), dict_compact_values().
4100 Some functions don't have replacements:
4102 * vars-atr.c: (force_create_variable) Removed. All references
4103 updated to dict_create_var() followed by an assertion.
4104 (force_dup_variable) Removed. All references updated to
4105 dict_clone_var() followed by an assertion.
4107 * weight.c: (update_weighting) Removed. No longer necessary, so
4108 all references removed.
4110 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
4114 * aggregate.c: Eliminate separation of weighted and unweighted
4115 case. It made the code too obscure and I doubt it was actually
4116 faster. Instead, all code uses the "weighted" code, because
4117 that's a generalization of the "unweighted" code.
4120 (parse_aggregate_functions) No need to set FWEIGHT.
4121 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
4122 (dump_aggregate_info) Ditto.
4123 (initialize_aggregate_info) No need for special plain_function
4124 that gets rid of FWEIGHT option.
4126 * aggregate.c: Get rid of approximations.
4127 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
4129 (aggregate_single_case) Don't use approx_ne().
4131 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
4133 * ascii.c (ascii_line_width): Dead code, removed.
4135 * postscript.c (ps_line_width): Ditto.
4137 * q2c.c (xrealloc): Ditto.
4139 * count.c (internal_cmd_count): Ditto.
4141 * means.q (validate_dependent_endpoint): Ditto.
4143 * set.q: (cmd_gset) Ditto.
4145 * weight.c: [0] (weight_trns_proc) Ditto.
4147 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
4149 Make the code -Wmissing-prototypes clean.
4151 * Makefile.am (version.c): Add #include "version.h".
4153 * ascii.c: (ascii_open_global) Make static.
4154 (ascii_close_page) Ditto.
4155 (ascii_font_sizes) Ditto.
4156 (ascii_postopen_driver) Ditto.
4157 (ascii_close_driver) Ditto.
4158 (ascii_option) Ditto.
4159 (ascii_open_page) Ditto.
4160 (ascii_line_horz) Ditto.
4161 (ascii_line_vert) Ditto.
4162 (ascii_line_intersection) Ditto.
4164 (ascii_polyline_begin) Ditto.
4165 (ascii_polyline_point) Ditto.
4166 (ascii_polyline_end) Ditto.
4167 (ascii_text_set_font_by_name) Ditto.
4168 (ascii_text_set_font_by_position) Ditto.
4169 (ascii_text_set_font_by_family) Ditto.
4170 (ascii_text_get_font_name) Ditto.
4171 (ascii_text_get_font_family) Ditto.
4172 (ascii_text_set_size) Ditto.
4173 (ascii_text_get_size) Ditto.
4174 (ascii_text_metrics) Ditto.
4175 (ascii_text_draw) Ditto.
4176 (ascii_close_page) Ditto.
4178 * cmdline.h: New header for parse_command_line(). Used where
4181 * command.c: Move prototypes for cmd_*() functions to command.h.
4183 * command.h: Prototypes for cmd_*() functions moved here from
4186 * crosstabs.q: (gamma_int) Ditto.
4188 * file-handle.h: Add fh_init_files() prototype.
4190 * getline.c: (welcome) Ditto.
4192 * glob.h: New header for init_glob(). Used where appropriate.
4194 * hash.c: (comparison_helper) Ditto.
4196 * html.c: (html_open_global) Ditto.
4197 (html_close_global) Ditto.
4198 (html_preopen_driver) Ditto.
4199 (html_postopen_driver) Ditto.
4200 (html_close_driver) Ditto.
4201 (html_option) Ditto.
4202 (html_open_page) Ditto.
4203 (html_close_page) Ditto.
4204 (html_submit) Ditto.
4206 * inpt-pgm.c: (input_program_source_read) Ditto.
4208 * output.c: (find_defn_value) Ditto.
4209 (destroy_list) Ditto.
4211 * pfm-read.c: (read_int) Ditto.
4213 * postscript.c: (ps_open_global) Ditto.
4214 (ps_close_global) Ditto.
4215 (ps_font_sizes) Ditto.
4216 (ps_preopen_driver) Ditto.
4217 (ps_postopen_driver) Ditto.
4218 (ps_close_driver) Ditto.
4220 (ps_open_page) Ditto.
4221 (ps_close_page) Ditto.
4222 (ps_line_horz) Ditto.
4223 (ps_line_vert) Ditto.
4224 (ps_line_intersection) Ditto.
4226 (ps_polyline_begin) Ditto.
4227 (ps_polyline_point) Ditto.
4228 (ps_polyline_end) Ditto.
4229 (ps_text_set_font_by_name) Ditto.
4230 (ps_text_set_font_by_position) Ditto.
4231 (ps_text_set_font_family) Ditto.
4232 (ps_text_get_font_name) Ditto.
4233 (ps_text_get_font_family) Ditto.
4234 (ps_text_set_size) Ditto.
4235 (ps_text_get_size) Ditto.
4236 (ps_text_metrics) Ditto.
4237 (ps_text_draw) Ditto.
4239 * q2c.c: (finish_up) Ditto.
4248 (find_symbol) Ditto.
4251 (force_string) Ditto.
4253 (match_token) Ditto.
4256 (parse_setting) Ditto.
4257 (parse_specifier) Ditto.
4258 (parse_specifiers) Ditto.
4259 (parse_subcommand) Ditto.
4260 (dump_specifier_vars) Ditto.
4262 (make_identifier) Ditto.
4263 (dump_declarations) Ditto.
4264 (dump_specifier_init) Ditto.
4265 (dump_vars_init) Ditto.
4267 (dump_specifier_parse) Ditto.
4268 (dump_subcommand) Ditto.
4269 (dump_parser) Ditto.
4270 (dump_header) Ditto.
4272 (recognize_directive) Ditto.
4274 * recode.c: (string_to_long) Ditto.
4276 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
4278 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
4281 * sort.c: (sort_stream_read) Ditto.
4282 (sort_stream_mode) Ditto.
4284 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
4286 * algorithm.c (binary_search): Fix comparison.
4288 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
4290 * algorithm.c: (binary_search) Fix assertion.
4292 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
4294 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
4296 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
4298 * sort.c: (compare_case_lists) Rewrite.
4300 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
4302 * quicksort.c: Removed (not used).
4304 * quicksort.h: Removed (not used).
4306 * sort.c: Removed blp_quicksort() prototype.
4308 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
4310 * postscript.c: (int_2_compare) Rewrite.
4311 (compare_line) Rewrite.
4313 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
4315 * matrix-data.c (compare_factors) Use lexicographical_compare()
4317 (compare_doubles) New function.
4319 * algorithm.c: (lexicographical_compare) New algorithm.
4321 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
4323 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
4325 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
4327 * expr-prs.c: (cmp_func) Removed.
4328 (parse_function) Use binary_search() algorithm.
4329 (compare_functions) New function.
4330 (init_func_tab) Use sort() algorithm.
4332 * algorithm.c: (binary_search) New algorithm.
4334 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
4336 * descript.q: (display) Use sort() algorithm instead of qsort().
4337 (compare_func) Removed.
4338 (descriptives_compare_variables) New function.
4340 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
4342 Get rid of AVL trees. Hashes are more appropriate for everything
4345 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
4351 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
4353 Much code can be clarified by using C++ STL-like algorithms. Not
4354 all uses of these algorithms are listed below, only the ones where
4355 the change to an algorithm was the only change of interest.
4357 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
4359 * algorithm.c: New file.
4361 * algorithm.h: New file.
4363 * modify-vars.c: (static var forward) Removed.
4364 (static var positional) Removed.
4365 (compare_variables) Removed.
4366 (struct ordering) New.
4367 (cmd_modify_vars) Use sort() algorithm.
4368 (compare_variables_given_ordering) New function.
4369 (rearrange_dict) Use sort() algorithm.
4371 * sysfile-info.c: (cmd_display) Use sort() algorithm.
4372 (cmp_var_by_name) Removed.
4374 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
4376 Make file handles use a hash table.
4378 * file-handle.q: (files) Change to hash table, make static.
4379 (cmd_file_handle) Use hash table functions.
4380 (fh_get_handle_by_filename) Ditto.
4381 (fh_get_handle_by_name) Ditto.
4382 (hash_file_handle) New function.
4383 (cmp_file_handle) Rewrite.
4384 (fh_init_files) Use hash table functions.
4386 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
4388 Clean up FREQUENCIES.
4390 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
4392 * frequencies.q: Remove a lot of old #if'd out code at the end.
4393 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
4394 or calc_weight(). Initialize percentile_values.
4395 (calc) New function based on calc_weight() from frequencies.g.
4396 (precalc) Use hash functions.
4397 (static var comparison_func) Removed.
4398 (static var comparison_param) Removed.
4399 (comparison_helper) Removed.
4400 (get_freq_comparator) New function.
4401 (not_missing) New function.
4403 (postprocess_freq_tab) Use hash table functions, algorithms,
4404 get_freq_comparator(). Rewrite.
4405 (cleanup_freq_tab) Rephrase.
4406 (add_percentile) Clean up spacing.
4407 (hash_value_numeric) New function.
4408 (hash_value_alpha) New function.
4409 (compare_value_numeric_a) Rewrite.
4410 (compare_value_alpha_a) Rewrite.
4411 (compare_value_numeric_d) Rewrite.
4412 (compare_value_alpha_d) Rewrite.
4413 (compare_freq_numeric_a) Rewrite.
4414 (compare_freq_alpha_a) Rewrite.
4415 (compare_freq_numeric_d) Rewrite.
4416 (compare_freq_alpha_d) Rewrite.
4417 (calc_stats) Clean up mode, percentiles, max.
4418 (dump_statistics) Clean up spacing.
4420 * frequencies.g: Removed.
4422 * var.h: (struct freq_tab) Change `data' to hash table.
4424 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
4426 * file-handle.h: Remove declaration of global variable `files',
4427 which wasn't used anywhere.
4429 * postscript.c: (add_encoding) Remove superfluous cast.
4432 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
4435 * temporary.c: [0] (display_tree) Removed.
4437 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
4439 Implement a new random number generator based on the alleged RC4
4442 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
4445 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
4446 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
4448 (static var V[]) Removed.
4449 (static var Y) Removed.
4450 (static var X2) Removed.
4451 (setup_randomize) Removed.
4453 (rand_uniform) Removed.
4454 (rand_normal) Removed.
4455 (struct rng) New structure.
4456 (rng_create) New function.
4457 (rng_destroy) New function.
4458 (swap_byte) New static function.
4459 (rng_seed) New function.
4460 (rng_get_bytes) New function.
4461 (rng_get_int) New function.
4462 (rng_get_unsigned) New function.
4463 (rng_get_double) New function.
4464 (rng_get_double_normal) New function.
4465 (pspp_rng) New function.
4467 * random.h: Sync up to random.c.
4469 * sample.c: (struct sample_trns) Make `frac' unsigned and a
4470 fraction of UINT_MAX, not 65536.
4471 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
4474 * vfm.c: (open_active_file) No need to call setup_randomize() any
4477 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
4479 Change dictionary name indexes to use hash tables instead of AVL
4482 * crosstabs.q: (free_var_dict) Use hash tables.
4483 (crs_custom_tables) Ditto.
4484 (calc_general) Ditto.
4485 (compare_table_entry) Rewrite.
4486 (enum_var_values) Reorder parameters. All references updated.
4489 * get.c: (rename_variable) Use hash tables.
4490 (mtf_merge_dictionary) Ditto.
4492 * glob.c: (init_glob) Use hash tables.
4493 (cmp_variable) Removed.
4495 * means.q: (mns_custom_tables) Use hash tables.
4497 * modify-vars.c: (rearrange_dict) Use hash tables.
4499 * rename-vars.c: (cmd_rename_variables) Use hash tables.
4501 * sfm-read.c: (read_header) Use hash tables.
4502 (read_variables) Ditto.
4504 * temporary.c: (new_dictionary) Use hash tables.
4505 (save_dictionary) Ditto.
4506 (restore_dictionary) Ditto.
4508 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
4509 hash table `name_tab'.
4511 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
4512 [DEBUGGING] (dump_var_tree) Removed.
4513 (find_variable) Use hash tables.
4514 (find_dict_variable) Ditto.
4515 (common_init_stuff) Ditto.
4516 (rename_variable) Ditto.
4517 (clear_variable) Ditto. Also, remove debug code.
4518 (dup_variable) Use hash tables.
4520 * vars-prs.c: (fill_all_vars) Use hash tables.
4521 (is_dict_varname) Ditto.
4522 (parse_dict_variable) Ditto.
4524 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
4526 Change value labels to use hash tables instead of AVL trees, and
4527 change value labels into an ADT.
4529 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
4531 * value-labels.c: New file.
4533 * value-labels.h: New file.
4535 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
4536 Get rid of a stupid use of goto.
4538 * autorecode.c: (compare_alpha_value) Rewrite.
4539 (hash_alpha_value) Ditto.
4540 (compare_numeric_value) Rewrite.
4541 (hash_numeric_value) Ditto.
4543 * frequencies.q: (dump_full) Use value label ADT.
4545 * pfm-read.c: (read_value_label) Use value label ADT.
4547 * pfm-write.c: (write_value_labels) Use value label ADT.
4549 * sfm-read.c: (read_variables) Use value label ADT.
4550 (read_value_labels) Rewrite.
4552 * sfm-write.c: (write_value_labels) Rewrite.
4554 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
4555 (display_variables) Ditto.
4556 (describe_variable) Ditto.
4558 * t-test.q: (print_t_groups) Use value label ADT.
4560 * temporary.c: (copy_variable) Use value label ADT.
4561 (free_dictionary) Ditto.
4563 * val-labs.c: (verify_val_labs) Use value label ADT.
4565 (debug_print) Ditto.
4566 (val_lab_cmp) Removed.
4567 (inc_ref_count) Removed.
4568 (copy_value_labels) Removed.
4570 * var.h: (struct value_label) Removed.
4571 (struct variable) Change AVL tree `val_lab' into hash table
4574 * vars-atr.c: (init_variable) Use value label ADT.
4575 (clear_variable) Ditto.
4576 (free_value_label) Removed.
4577 (free_val_lab) Removed.
4578 (get_val_lab) Removed.
4579 (compare_variables) New function.
4580 (hash_variable) New function.
4582 * vfm.c: (dump_splits) Use value label ADT.
4584 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
4586 Add to the hash table interface.
4588 * hash.c: (hsh_hash_bytes) Add assertion.
4589 (hsh_hash_string) Ditto.
4593 (hsh_create) Ditto. Also make minimum `size'.
4594 (hsh_destroy) Rephrase.
4595 (sort_nulls_last) Removed.
4596 (not_null) New function.
4598 (comparison_helper) Ditto.
4599 (hsh_sort) Rewritten.
4600 (hsh_data_copy) New function.
4601 (hsh_sort_copy) Ditto.
4603 (hsh_replace) Ditto.
4604 (hsh_hash_double) Ditto.
4605 (hsh_delete) Fix stupid bug.
4607 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4608 * added a calculation of the mode to FREQUENCIES
4610 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
4612 * moved (un)defs of DEBUGGING to config.h
4614 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
4616 * groff-font.c: (add_kern) Fix indentation.
4617 (add_kern) Use & instead of % to take power-of-2 modulus.
4618 (font_get_kern_adjust) Likewise.
4620 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
4622 * autorecode.c: (recode) Replace stupid use of memcpy() by
4624 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
4625 (hash_numeric_value) Ditto.
4626 (autorecode_proc_func) pool_strdup() was wrong here because the
4627 source string was not null-terminated. Use new pool_strndup()
4630 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
4631 use of hsh_iterator_init().
4633 * data-in.c: (parse_N) Initialize i->v->f.
4635 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
4638 * groff-font.c: Use power-of-2 hash table sizes, not prime.
4639 (groff_read_font) Don't call hsh_next_prime(). Don't call
4641 (static var hash) Remove `size_p', `max_used' members.
4642 (font_char_name_to_index) Don't call hsh_next_prime(). Use
4643 hsh_hash_string() instead of hashpjw(), & instead of %.
4644 (default_font) Don't call hsh_next_prime().
4646 * pool.c: (pool_strndup) New function.
4647 (pool_strdup) Reimplement in terms of pool_strndup.
4649 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
4651 (hash_ps_encoding) Use hsh_hash_string().
4652 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
4653 (hash_filename2font) Use hsh_hash_string().
4655 * som.c: Add #include <stdlib.h>.
4657 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
4658 (by destroying its pool).
4660 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
4662 Miscellaneous hash table code cleanup:
4664 * hash.h: (struct hsh_table) Moved into hash.c.
4665 (hsh_count) Ditto, and transformed into function.
4666 (hsh_compare_func) New typedef, used for defining otherwise-long
4667 function types here and in hash.c
4668 (hsh_hash_func) Ditto.
4669 (hsh_free_func) Ditto.
4671 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
4672 `table' to `entries'. Removed `mp'. All references updated.
4673 (hsh_clear) Don't shrink entries array; if the hash was this big
4674 once, it probably will be again.
4675 (hsh_rehash) Made static.
4676 (force_hsh_insert) Renamed hsh_force_insert.
4677 (force_hsh_find) Renamed hsh_force_find.
4679 Made hash table sizes powers of 2, because that's fine with any
4680 reasonable hash function and because taking a power-of-2 modulus
4681 is faster than any other:
4683 (hsh_prime_tab) Removed;
4684 (hsh_next_prime) Ditto.
4685 (next_power_of_2) New function.
4686 (hsh_create) Use next_power_of_2.
4687 (hsh_rehash) Use & instead of %.
4689 Cleaned up hsh_sort:
4691 (internal_comparison_fn) Removed.
4692 (sort_nulls_last) New function.
4693 (hsh_sort) Removed second parameter, switched to using the new
4694 quicksort() function from quicksort.h to avoid using nasty need
4695 for static variables with qsort(). All references updated.
4697 Changed the hash functions offered, because there are better hash
4698 functions than the ones we had, and cleaned up the names to boot:
4700 * hash.c: (hashpjw_d) Removed.
4702 (hsh_hash_bytes) New function.
4703 (hsh_hash_string) New function.
4704 (hsh_hash_int) New function.
4706 Improved the hash table iteration interface:
4708 * hash.h: (hsh_iterator_init) Removed.
4709 (struct hsh_iterator) Removed `init' member, change `next' to
4712 * hash.c: (hsh_foreach) Removed. All references updated to use
4713 hsh_first/hsh_next instead.
4714 (hsh_first) New function. Notably, unlike hsh_foreach() it does
4715 not treat a null pointer as an empty hash table.
4716 (hsh_next) New function.
4718 Made deletion possible, though slow:
4720 * hash.c: (locate_matching_entry) New function.
4721 (hsh_find) Use locate_matching_entry().
4722 (hsh_delete) New function also using locate_matching_entry().
4723 (hsh_force_delete) New function.
4725 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
4727 * quicksort.c: New file implementing a sort routine with a
4728 interface better than qsort() because it passes a user-provided
4729 parameter to the sort routine.
4731 * Makefile.am: Add quicksort.c, quicksort.h.
4733 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
4735 * All source files: Get rid of nasty special cases for Checker,
4736 which is pretty obsolete now.
4738 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
4740 * Fixed a bug apparent when using the FREQUENCIES command with the
4741 html driver. The html driver was incorrectly trying to display
4744 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
4746 * Makefile.am: Reorganized. Put locale dir in version.c instead
4747 of passing it to each compile command. Only put local gmp libs in
4748 LD_ADD if not installed on system. Remove `boast' target.
4750 * All source files: struct and union typedefs eliminated.
4751 `sizeof type' replaced by `sizeof object' where practical. Moved
4752 `unused' qualifiers from start to end of declarations for gcc
4753 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
4754 assertions on pointers strictly compliant. Removed _ prefixes on
4755 some function parameter names.
4757 * alloc.c: New source file, containing these external linkage
4758 functions removed from common.c: xmalloc, xcalloc, xrealloc,
4765 * ascii.c: Migrated from arenas to pools.
4766 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
4767 c_string to len_string. All references changed.
4768 (ascii_option) Signature changed to comply to new output.c
4770 (count_fancy_chars) Removed.
4771 (delineate) Removed support for rich text.
4772 (ascii_text_metrics) Ditto.
4774 (output_shorts) Change `box', `off', `on' from c_string to
4775 len_string. Change `remaining' from int to size_t.
4776 (ascii_close_page) Make page numbering less haphazard.
4778 * autorecode.c: Migrate from arenas to pools.
4780 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
4782 * bitvector.h: New file containing these macros from misc.h:
4783 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
4785 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
4786 word[3]. ncmd removed.
4787 (var empty_string) Removed.
4788 (var cmd_table) Declaration updated.
4789 (var cmdtab) Removed.
4790 (cmp_command) Removed.
4791 (split_words) Rewritten to use strtok_r().
4792 (init_cmd_parser) Renamed cmd_init(). Rewritten.
4793 (find_command) Removed.
4794 (FILE_TYPE_okay) Rewritten.
4795 (cmd_parse) Rewritten. Semantics of the return value of command
4796 handlers has changed: they must now return one of the new CMD_*
4797 enumerals, rather than a magic value. This meant that all
4798 commands had to be modified, and they were.
4799 (figure_out_command) New function.
4801 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
4802 #defines for INIT, INPU, etc.
4804 * command.h: New CMD_* enum series.
4805 (cur_proc) Make const char *, not char *.
4806 (cmd_init) Prototype.
4809 * common.c: Removed.
4811 * common.h: Removed.
4813 * correlations.q: New file.
4815 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
4817 (custom_tables) Renamed crs_custom_tables().
4818 (custom_variables) Renamed crs_custom_variables().
4819 (calc_integer) Add in some `const' qualifiers.
4820 (table_value_missing) Change from a_string to len_string.
4821 (float_M_suffix) Change from a_string to len_string.
4823 * data-in.c: Rewritten. All references to
4824 parse_string_as_format() changed to data_in().
4826 * data-in.h: New file.
4828 * data-list.c: Change DLS_* from #define's to enums. Move from
4829 rpd_msg() to tmsg().
4830 (RPD_ERR) New #define.
4831 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
4833 (read_from_data_list_fixed) Change from old
4834 parse_string_as_format() to new data_in().
4835 (read_from_data_list_free) Ditto.
4836 (read_from_data_list_list) Ditto.
4837 (cmd_repeating_data) Modify approach to checking for end of
4840 (rpd_parse_record) Change from old parse_string_as_format() to new
4841 data_in(). Change from old convert_format_to_string() to new
4843 (read_one_set_of_repetitions) Change dfm_push_cust() to
4844 dfm_push(), pop_cust() to dfm_pop().
4846 * data-out.c: Rewritten. All references to
4847 convert_format_to_string() changed to data_out().
4849 * descript.q: Migrate to new q2c.
4850 (cmd_descriptives) Removed.
4851 (internal_cmd_descriptives) Renamed cmd_descriptives ().
4852 (custom_variables) Renamed dsc_custom_variables().
4854 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
4856 (open_file_r) Initialize h->where.line_number. Migrate to new
4858 (open_file_w) Initialize h->where.line_number.
4859 (read_record) Change from ext->ln to h->where.line_number.
4860 Migrate to struct string.
4861 (dfm_put_record) Rephrased.
4862 (dfm_push_cust) Renamed dfm_push(), rewritten.
4863 (dfm_pop) New function.
4865 * error.c: All references updated.
4866 (glob var error_count) Renamed err_err_count.
4867 (glob var warning_count) Renamed err_warning_count.
4868 (glob var error_already_flagged) Renamed err_already_flagged.
4869 (glob var verbosity) Renamed err_verbosity.
4870 (glob var cust_fn) Removed.
4871 (glob var cust_ln) Removed.
4872 (static var file_loc) New.
4873 (static var nfile_loc) New.
4874 (static var mfile_loc) New.
4875 (tmsg) New function.
4876 (push_cust) Removed.
4879 (static var terminating) Removed.
4880 (failure) Renamed err_failure().
4881 (hcf) Renamed err_hcf().
4882 (err_push_file_locator) New function.
4883 (err_pop_file_locator) New function.
4884 (err_location) New function.
4885 (check_error_count) Renamed err_check_count().
4886 (vmsg) Renamed err_vmsg(). Interface changed.
4887 (verbose_msg) Removed.
4888 (err_cond_fail) New function.
4889 (error_break) Renamed err_break().
4891 * error.h: All references updated.
4892 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
4893 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
4895 (struct file_locator) New.
4897 (macro verbose_msg) Removed.
4898 (macro cond_fail) Removed.
4900 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
4902 * expr-prs.c: Reorganized. All references updated.
4903 (exprtypename) Renamed expr_type_name().
4904 (typename) Renamed type_name().
4905 (free_expression) Renamed expr_free().
4906 (parse_expression) Renamed expr_parse(). Uses new type_check()
4908 (init_functab) Renamed init_func_tab().
4909 (type_check) New function.
4910 (parse_or) Rewritten to use new allocate_nonterminal() and
4911 append_nonterminal_arg() functions.
4914 (parse_rel) Ditto. Also simplified logic.
4919 (SYSMIS_func) Ditto.
4920 (VALUE_func) Rephrased.
4921 (CONCAT_func) Fix memory leak by replacing free by free_node on
4923 (generic_str_func) Ditto.
4924 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
4926 (allocate_nonterminal) New function.
4927 (append_nonterminal_arg) New function.
4928 (static func_tab[]) Now at file level.
4930 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
4932 * expr.h: (enum series OP_*) Moved to exprP.h.
4933 (OP_* defines) Ditto.
4934 (struct op_desc) Ditto.
4935 (global ops[]) Ditto.
4936 (struct num_con_node) Ditto.
4937 (struct str_con_node) Ditto.
4938 (struct var_node) Ditto.
4939 (struct lag_node) Ditto.
4940 (struct casenum_node) Ditto.
4941 (struct nonterm_node) Ditto.
4942 (union any_node) Members renamed.
4943 (struct sys_node) Removed.
4944 (struct val_node) Removed.
4945 (operator typedef) Removed.
4946 (typedef exprtype) Removed.
4947 (enum series EX_*) Moved to exprP.h.
4948 (struct expression) Ditto. Also renamed a lot of the members.
4949 (PXP_* defines) Changed to enums.
4950 (free_node prototype) Moved to exprP.h.
4952 * file-handle.h: (struct file_handle) New member `where'.
4954 * file-handle.q: Migrated to new q2c format.
4955 (prepend_current_directory) Removed (dead code).
4956 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
4957 (fh_get_handle_by_filename) Removed dead code.
4958 Set new `where' member.
4960 * file-type.c: (file_type_source_read) References to
4961 parse_string_as_format() changed to data_in().
4962 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
4964 * filename.c: All references updated.
4965 (init_filename) Renamed fn_init().
4966 (expand_line) Removed.
4967 (macro EXPAND_LINE) Removed.
4968 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
4969 of custom functions.
4970 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
4971 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
4972 (normalize_filename) Renamed fn_normalize().
4973 (search_path) Renamed fn_search_path(), rewritten.
4974 (prepend_dir) Renamed fn_prepend_dir().
4975 (blp_getenv) Renamed fn_getenv().
4976 (blp_dirname) Renamed fn_dirname().
4977 (fn_basename) New function, not used.
4978 (absolute_filename_p) Renamed fn_absolute_p().
4979 (is_special_filename) Renamed fn_special_p().
4980 (file_exists) Renamed fn_exists_p().
4981 (readlink_malloc) Renamed fn_readlink().
4982 (getenv_default) Renamed fn_getenv_default().
4983 (open_file) Renamed fn_open().
4984 (close_file) Renamed fn_close().
4985 (open_file_ext) Renamed fn_open_ext().
4986 (close_file_ext) Renamed fn_close_ext().
4988 * font.h: Migrate from arenas to pools.
4990 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
4992 * frequencies.g: Migrate from arenas to pools.
4994 * frequencies.q: Migrate to new q2c version. Migrate from arenas
4997 * getline.c: All references updated.
4998 (global getl_buf) Changed from char * to struct string.
4999 (static getl_include_path) Ditto.
5000 (global getl_buf_len) Removed.
5001 (global getl_buf_size) Removed.
5002 (getl_include_path) Deal with new getl_buf, getl_include_path.
5003 (getl_uninitialize) New function.
5004 (getl_get_current_directory) Rewritten.
5005 (getl_clear_include_path) Rewritten.
5006 (getl_add_include_dir) Rewritten.
5007 (getl_add_file) Assertion fixed.
5008 (getl_add_virtual_file) Change initial value of `remaining_loops'
5010 (welcome) Rewritten.
5011 (handle_line_buffer) Make static. Change logic to make
5012 getl_add_virtual_file() change sensible. Use ds_*() strings.
5013 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
5014 (getl_close_file) Moved.
5015 (getl_location) New function.
5017 * getline.h: All references updated.
5018 (macro curln) Removed.
5019 (macro curfn) Removed.
5020 (macro am_interactive) Renamed getl_am_interactive.
5021 (macro am_reading_script) Renamed getl_reading_script.
5023 * glob.c: (global fmt_parse_ignore_error) Removed.
5024 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
5025 systems that support it (C99). Turn off SET ECHO by default. No
5026 necessary julcal initialization anymore.
5028 * groff-font.c: Migrate from arenas to pools.
5029 (groff_read_font) Use err_push_file_locator().
5030 (groff_read_DESC) Ditto.
5031 (font_msg) Use tmsg().
5033 * hash.c: (hsh_sort) Fix debug code.
5034 [GLOBAL_DEBUGGING] Include stdio.h.
5036 * hash.h: (macro force_hsh_insert) Rephrase.
5038 * heap.c: Rewritten.
5040 * heap.h: Rewritten.
5042 * html.c: (html_option) Change from outp_value to struct string.
5043 (postopen) Change from curfn to getl_location().
5044 (escape_string) Remove rich-text code. Signature changed.
5045 (output_tab_table) Switch from a_string to struct len_string.
5046 Remove rich text support.
5048 * lexer.c: All references updated. Largely rewritten. Major
5049 changes listed below. Removed tagged quote support. Adapted to
5050 struct string tokstr.
5051 (global tokstr) Changed to struct string.
5052 (global tokstr_size) Removed.
5053 (global tokstr_len) Removed.
5055 (global tokint) Removed.
5056 (global toklongstr) Removed.
5057 (C* defines) Removed.
5058 (static tbl[]) Removed.
5059 (static id[]) Removed.
5060 (static une[]) Removed.
5061 (discard_line) Renamed lex_discard_line().
5062 (get_entire_line) Renamed lex_entire_line().
5063 (get_rest_of_line) Renamed lex_rest_of_line().
5064 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
5065 (make_hexit) Removed.
5066 (syntax_error) Renamed lex_error(). Return value removed.
5067 (get_token_representation) Renamed lex_token_representation().
5068 (putback) Renamed lex_put_back().
5069 (putfwd) Renamed lex_put_forward().
5070 (convert_negative_to_dash) Renamed lex_negative_to_dash().
5071 (set_prog) Renamed lex_set_prog().
5072 (init_lex) Renamed lex_init().
5073 (reset_eof) Renamed lex_reset_eof().
5074 (lookahead) Renamed lex_look_ahead().
5075 (check_id) Rewritten.
5076 (yylex) Renamed lex_get(), rewritten.
5077 (lex_end_of_command) New function. Many commands were rephrased
5079 (lex_integer_p) New function. Replaces compare of tokint against
5081 (lex_integer) New function. Replaces tokint.
5082 (match_tok) Renamed lex_match().
5083 (match_id) Renamed lex_match_id().
5084 (match_int) Renamed lex_match_int().
5085 (force_match_id) Renamed lex_force_match_id(), added return value.
5086 (force_match) Renamed lex_force_match(), added return value.
5087 (force_string) Renamed lex_force_string(), added return value.
5088 (force_int) Renamed lex_force_int(), added return value.
5089 (lex_id_match_len) New function.
5090 (id_match) Renamed lex_id_match(), rewritten.
5091 (get_line) Renamed lex_get_line().
5092 (preprocess_line) Renamed lex_preprocess_line().
5093 (tokname) Renamed lex_token_name().
5094 (bin_value_func) Removed.
5095 (oct_value_func) Removed.
5096 (hex_value_func) Removed.
5097 (unexpected_eof) New function.
5098 (convert_numeric_string_to_char_string) New function.
5099 (parse_string) Rewritten, signature changed.
5100 (add_tokstr_char) Removed.
5101 (add_tokstr_unsigned) Removed.
5102 (add_tokstr_string) Removed.
5103 (parse_tagged_quote) Removed.
5104 (skip_comment) Renamed lex_skip_comment().
5106 * lexer.h: All references updated.
5107 (macro is_id1) Renamed CHAR_IS_ID1.
5108 (macro is_idn) Renamed CHAR_IS_IDN.
5109 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
5110 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
5111 (macro get_token) Removed.
5112 (macro id_match) Removed.
5113 (macro force_match_id) Removed.
5114 (macro force_match) Removed.
5115 (macro force_string) Removed.
5116 (macro force_int) Removed.
5117 (macro force_num) Removed.
5118 (macro force_id) Removed.
5120 * lexerP.h: Removed.
5122 * list.q: Migrated to new q2c format.
5123 (write_line) Deal with struct len_string.
5124 (write_varname) Ditto.
5125 (write_fallback_headers) Ditto.
5127 * magic.c: New file, incorporating the following global variables
5128 previously in other files: endian, second_lowest_value. And both
5129 of those are conditional on #define's.
5131 * magic.h: New file, incorporating the following global variable
5132 declarations: endian, second_lowest_value, and the following macro
5133 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
5135 * main.c: Added declarations of pgmname, finished, curdate,
5137 (main) Call new parse_script() function.
5138 (parse_script) New function.
5139 (execute_command) New function.
5140 (dump_token) Removed.
5141 (handle_error) New function.
5143 * matrix.c: New file.
5145 * matrix.h: New file.
5147 * matrix-data.c: Migrated from arenas to pools.
5148 (mget_token) Change from parse_string_as_format() to data_in().
5150 * means.q: Migrate to new q2c.
5151 (custom_tables) Renamed mns_custom_tables().
5152 (custom_crossbreak) Renamed mns_custom_crossbreak().
5153 (custom_variables) Renamed mns_custom_variables().
5155 * mis-val.c: (static var width) Changed from `int' to `size_t'.
5156 (parse_varnames) Prototype.
5157 (parse_numeric) Rephrasings.
5158 (parse_alpha) Adapt to new struct string tokstr.
5160 * misc.c: (intlog10) Rewritten.
5162 (ansi_rand) Renamed real_rand(), moved into random.c.
5163 (ansi_srand) Renamed real_srand(), moved into random.c.
5164 (setup_randomize) Moved to random.c.
5165 (rand_uniform) Ditto.
5166 (rand_normal) Ditto.
5167 (rand_simple) Ditto.
5168 (get_config_line) Removed.
5169 (reverse) Removed (dead code).
5171 * misc.h: (macro SET_BIT) Moved to bitvector.h.
5172 (macro CLEAR_BIT) Ditto.
5173 (macro TEST_BIT) Ditto.
5174 (macro SET_BIT_TO) Ditto.
5175 (macro BIT_INDEX) Ditto.
5177 * output.c: (outp_read_devices) Move to err_push_file_locator()
5178 from push_cust(). Use struct string.
5179 (expand_op_tokstr) Removed.
5180 (static var op_tokstr) Changed to struct string.
5181 (static var op_tokstr_size) Removed.
5182 (tokener) Rephrasings. Use struct string.
5183 (parse_options) Use struct string.
5184 (destroy_driver) Fix assertion.
5185 (outp_get_paper_size) Move to err_push_file_locator().
5186 [0] Removed dead code.
5187 (outp_string_width) Move to len_string.
5189 * output.h: Comment fixes.
5190 (TAG_* enum series) Removed.
5191 (struct outp_value) Removed.
5192 (enum OUTP_T_FANCY) Removed.
5193 (struct outp_text) `s' changed from a_string to len_string.
5194 (struct outp_class) `option' change arg 3 from outp_value to
5197 * pfm-read.c: (corrupt_msg) Rewritten.
5199 * pfm-write.c: (bufwrite) Fix assertion.
5201 * pool.c: New file, reference version.
5203 * pool.h: New file, reference version.
5205 * postscript.c: (ps_font_sizes) Fix assertion.
5206 (ps_option) Change arg 3 from outp_value to struct string.
5207 Adapt to struct string.
5208 (macro output_line) Removed.
5209 (macro add_string) Removed.
5210 (output_encodings) Adapted to struct string. Moved to
5211 err_push_file_locator().
5212 (find_encoding_file) Fix assertion.
5213 (read_ps_encodings) Move to err_push_file_locator().
5214 (postopen) Use getl_location() instead of curfn.
5215 (out_text_plain) Move to len_string.
5216 (text) Ditto. Remove rich text support.
5218 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
5219 (cmd_print_eject) Ditto.
5221 (internal_cmd_print) Now cleans up after itself. Uses
5222 fh_parse_file_handle() now.
5223 (cmd_print_space) Use PXP_NUMERIC to type-check.
5225 * q2c.c: Overhauled. Removed _("") i18n support. All references
5226 updated. All output functions updated to handle structures rather
5227 than local or static variables. Adapt to new PSPP lex_*()
5231 (macro MAX_N_SBC) Removed.
5232 (global bare) Removed.
5233 (enum STRING) Renamed T_STRING.
5234 (enum ID) Renamed T_ID.
5235 (get_buffer) Buffer size increased.
5236 (strlower) Renamed st_lower(), rephrased.
5237 (strupper) Renamed st_upper(), rephrased.
5238 (skip_ws) New function.
5239 (get_line) Don't special-case any types of lines (like those
5240 beginning with ! or $, for instance).
5241 (get_token) Renamed lex_get(). Rephrased.
5242 (static var `prefix') New.
5243 (parse) New function.
5244 (parse_setting) Minor rephrasing.
5245 (dump_specifier_vars) Ditto.
5246 (make_identifier) Put null terminator on identifier, duh.
5247 (dump_vars) Renamed dump_declarations(). Never indent. Never
5248 static. Output changed entirely.
5249 (dump_specifier_init) Rephrase.
5250 (dump_vars_init) No index variable needed. Other modifications.
5251 (dump_parser) Don't parse command name. Do dump functions instead
5252 of just code fragments.
5253 (dump_free) Dump function instead of code fragment.
5254 (recognize_directive) New function.
5255 (main) Use recognize_directive(). Don't rely on magic $ line
5256 beginning: instead, parse comments. Update list of headers.
5258 * random.c: New file, containing the following functions:
5259 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
5260 rand_normal, rand_simple.
5262 * random.h: New file.
5264 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
5265 function. `max_src_width', `max_dst_width' changed to size_t.
5266 (internal_cmd_recode) Removed.
5267 (parse_dest_spec) Merge similar cases.
5268 (parse_src_spec) Add assertion.
5270 * repeat.c: (recognize_keyword) New function.
5271 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
5272 REPEAT. Improve recognition of END REPEAT (use
5273 recognize_keyword()). Move from curfn to getl_location(). Use
5276 (perform_DO_REPEAT_substitutions) Adapt to struct string.
5278 * set.q: Adapt to new q2c.
5279 (cmd_set) Range-check some values better.
5280 (custom_blanks) Renamed stc_custom_blanks().
5281 (custom_length) Renamed stc_custom_length().
5282 (custom_results) Renamed stc_custom_results().
5283 (custom_seed) Renamed stc_custom_seed().
5284 (custom_width) Renamed stc_custom_width().
5285 (custom_format) Renamed stc_custom_format().
5286 (custom_journal) Renamed stc_custom_journal().
5287 (custom_color) Renamed stc_custom_color().
5288 (custom_listing) Renamed stc_custom_listing().
5289 (custom_disk) Renamed stc_custom_disk().
5290 (custom_log) Renamed stc_custom_log().
5291 (custom_rcolor) Renamed stc_custom_rcolor().
5292 (custom_viewlength) Renamed stc_custom_viewlength().
5293 (custom_workdev) Renamed stc_custom_workdev().
5295 * settings.h: Not necessary to include format.h any longer.
5297 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
5298 (corrupt_msg) Rewritten.
5300 * sort.c: Adapt to rewritten heap ADT.
5302 * str.c: (aa_strcpy) Removed.
5303 (ab_strcpy) Removed.
5304 (ac_strcpy) Removed.
5305 (ba_strcpy) Removed.
5306 (bb_strcpy) Removed.
5307 (ca_strcpy) Removed.
5308 (aa_strdup) Removed.
5309 (aa_strdupcpy) Removed.
5310 (ba_strdup) Removed.
5311 (sa_strdup) Removed.
5312 (memrev) Renamed mm_reverse().
5313 (memrmem) Renamed mm_find_reverse().
5314 (cmp_str) Renamed st_compare_pad().
5315 (strmaxcpy) Removed.
5316 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
5317 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
5319 (strpadcpy) Renamed st_pad_copy(), signature changed.
5320 (blpstrset) Removed.
5321 (ds_create) New function.
5322 (ds_init) New function.
5323 (ds_replace) New function.
5324 (ds_destroy) New function.
5325 (ds_clear) New function.
5326 (ds_extend) New function.
5327 (ds_shrink) New function.
5328 (ds_truncate) New function.
5329 (ds_length) New function.
5330 (ds_size) New function.
5331 (ds_value) New function.
5332 (ds_end) New function.
5333 (ds_concat) New function.
5334 (ds_concat_buffer) New function.
5335 (ds_printf) New function.
5336 (ds_putchar) New function.
5337 (ds_getline) New function.
5338 (ds_get_config_line) New function derived from the old
5339 misc.c:get_config_line().
5340 (ls_create) New function.
5341 (ls_create_buffer) New function.
5342 (ls_init) New function.
5343 (ls_shallow_copy) New function.
5344 (ls_destroy) New function.
5345 (ls_null) New function.
5346 (ls_null_p) New function.
5347 (ls_empty_p) New function.
5348 (ls_length) New function.
5349 (ls_value) New function.
5350 (ls_end) New function.
5352 * str.h: Reformatted.
5353 (struct a_string) Removed.
5354 (struct b_string) Removed.
5355 (struct c_string) Removed.
5356 (struct len_string) New.
5357 (struct string) New.
5358 (macro as_streq) Removed.
5359 (macro bs_streq) Removed.
5360 (macro cs_streq) Removed.
5361 (macro sa_streq) Removed.
5362 (macro sb_streq) Removed.
5363 [__GNUC__] (inline function ds_putchar) New function.
5364 [__GNUC__] (inline function ds_length) New function.
5365 [__GNUC__] (inline function ds_value) New function.
5366 [__GNUC__] (inline function ds_end) New function.
5368 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
5369 (display_vectors) Fix missing i18n.
5371 * t-test.q: Migrate to new q2c.
5373 * tab.c: Migrate from arenas to pools.
5374 (tab_create) Use struct len_string.
5375 (tab_realloc) Ditto.
5376 (text_format) Ditto.
5377 (tab_joint_text) Ditto.
5378 (tab_natural_width) Remove rich text support.
5379 (tab_natural_height) Ditto.
5380 (tab_output_text) Handle TAT_FIX.
5381 (tab_raw) Change arg from a_string to len_string.
5382 (tabi_driver) Fix assertion. Use struct len_string.
5383 (render_strip) Use struct len_string. Remove rich text support.
5384 Add `const' qualifiers.
5386 * tab.h: (enum TAB_RICH) Remove.
5387 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
5388 SOM_COL_* updated to read TAB_COL_*.
5389 (struct tab_table) Change arena to pool. Change a_string to
5392 * temporary.c: (restore_dictionary) Rewrite Checker code.
5394 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
5395 LOWEST, HIGHEST) Moved here from common.h.
5396 (typedef any_trns) Removed. All references changed to `struct
5399 * vars-atr.c: (force_create_variable) Fix assertion.
5400 (force_dup_variable) Fix assertion.
5402 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
5404 Using alphanumeric variables in functions under AGGREGATE
5405 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
5406 <BZN-mdksh@t-online.de> for reporting this bug.
5408 * aggregate.c: (parse_aggregate_functions) When setting the
5409 FSTRING bit, also allocate memory for the `string' member of
5411 (free_aggregate_functions) Free iter->string. Don't use the
5412 non-function bits when indexing the array of functions.
5413 [DEBUGGING] (debug_print) Don't use the non-function bits when
5414 indexing the array of functions.
5416 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
5418 Under certain circumstances, the final case would be omitted from
5419 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
5420 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5422 * aggregate.c (agr_00x_end_func): Increment number of cases in
5423 sink before writing case. For streams that keep track of how many
5424 cases there are based on this value, this means that the last case
5425 will be read in on the next stream read.
5427 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
5429 Undefined behavior was invoked by referencing a freed pointer.
5431 * vfm.c (memory_stream_write): Free pointer *after* checking for
5434 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
5436 A wrong record size was displayed when paging the active file to
5439 * vfm.c: (memory_stream_write) Fix off-by-one error.
5441 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
5443 Not having enough temporary space for sorting caused a core dump.
5446 * sort.c: (allocate_cases) Initialize i.
5448 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
5450 Syntax errors in function descriptions on AGGREGATE caused core
5453 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
5454 free_aggregate_functions(), since that function already frees
5457 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
5459 A null pointer was dereferenced, causing a core dump, when
5460 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
5461 but PSPP still doesn't calculate percentiles. Thanks to Regnor
5462 Jernsletten <rjernsle@eunet.no> for reporting this problem.
5464 * arena.c: (arena_malloc) If the arena hasn't been initialized
5465 already, initialize it.
5467 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
5469 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
5470 for compilation with Cygnus Windows B20. Not used by other
5473 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
5475 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
5476 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5478 * sort.c: (compare_case_lists) Reverse sense of comparison if
5479 sorting in descending order.
5480 (compare_record) Ditto.
5482 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
5484 SPLIT FILE with a string variable caused a core dump. Fixed.
5486 * vfm.c: If the variable is a string then make a temporary value
5487 struct pointing to it. The underlying problem is a lot bigger
5488 than this (see TODO) but this is a stopgap for the simple case at
5491 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
5493 Nested INCLUDEs didn't work. Fixed.
5495 * getline.c: (getl_include) Set first_line to NULL in allocated
5498 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
5500 The MATCH FILES procedure set the values of variables not present
5501 to 0. It should have been SYSMIS. This is now fixed.
5503 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
5505 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
5507 The REMARK command was too aggressive about skipping lines. It
5508 didn't like being the last command in a file.
5510 * command.c: (cmd_remark) Call get_entire_line() instead of
5513 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
5515 Comment parsing wasn't consistent with the rest of the code in its
5516 idea of where one command ends and another starts. This meant
5517 that sometimes commands would be mysteriously ignored. Thanks to
5518 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
5520 * command.c: (parse_cmd) Hand off comment parsing to new function
5521 skip_comment() in lexer.c.
5522 * lexer.c: (skip_comment) New function.
5524 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
5526 The TABLE subcommand on MATCH FILES worked only erratically at
5527 best. This fixes it. Thanks to Dr. Dirk Melcher
5528 <BZN-mdksh@t-online.de> for reporting this bug.
5530 * get.c: (mtf_compare_BY_values) When comparing string values, a
5531 difference of 1 is still a difference :-)
5532 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
5533 advance TABLE files automatically when matched. Comment fixes.
5535 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
5537 VARIABLE LABELS rejected a slash before the first variable
5538 specification, contradicting the documentation. Thanks to Walter
5539 M. Gray <graywm@northernc.on.ca> for reporting this bug.
5541 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
5542 command specification.
5544 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
5546 Because of an incorrect optimization in memory allocation,
5547 CROSSTABS sometimes segfaulted when asked to output multiple
5548 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
5551 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
5552 are passed to output_pivot_table() for its use.
5553 (output_pivot_table) Instead of assuming the number of columns is
5554 constant, keep track with maxcols. In general mode, use maxcells
5555 to determine whether more matrix cells need to be allocated.
5557 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
5559 CROSSTABS didn't display value labels for column and row
5560 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
5563 * crosstabs.q: (table_value_missing) If the specified value has a
5564 value label for this variable, then show it instead of the raw
5566 (display_dimensions) Delegate display of value_labels to
5567 table_value_missing.
5569 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
5571 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
5572 <BZN-mdksh@t-online.de> for reporting this bug.
5574 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
5575 if the file isn't declared as binary.
5577 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
5579 MATCH FILES corrupted memory and dumped core on some syntax
5582 * get.c: (cmd_match_files) Set file->handle to NULL before
5584 (mtf_free_file) Don't free a null dictionary.
5586 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
5588 MATCH FILES should set numeric values not available to the
5589 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
5590 <BZN-mdksh@t-online.de> for reporting this bug.
5592 * get.c: (mtf_processing) Set unused records to system-missing,
5595 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
5597 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
5598 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
5600 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
5601 in newly created dictionary, and add each copied variable to the
5604 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
5608 * get.c: (trim_dictionary) Free variable list for KEEP after
5611 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
5613 Some systems didn't like the way open_file was coded. Thanks to
5614 Hankin <hankin@rogue.consultco.com> for pointing this out.
5616 * filename.c: (open_file) Don't try to store stdin, stdout,
5617 stderr as part of an array, because that doesn't always work.
5619 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
5621 The SAVE procedure didn't save long string variables properly.
5622 Fixed by this patch. Thanks to Hankin
5623 <hankin@rogue.consultco.com> for this patch.
5625 * sfm-write.c: (write_variable) Fix off-by-one error in writing
5626 out variable pad records.
5628 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
5630 Previously, if PRINT SPACE were given a negative argument, it
5631 would report an error, then spin in an (almost) infinite loop.
5632 This fixes that behavior.
5634 * print.c: (print_space_trns_proc) After reporting a negative
5635 argument, set number of lines to print to 1.
5637 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
5639 SPSS 8.0 outputs some new record types in its system files, and it
5640 allows longer value labels. Accept these system files.
5642 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
5643 11 emitted by SPSS 8.0.
5645 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
5647 The LIST procedure was too conservative in allocating space for
5648 buffers, which caused a bug that only showed up with very long
5649 output variables. Thanks to Hankin <hankin@dunno.com> for this
5652 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
5654 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
5656 Typo meant string format specifiers weren't checked properly. I
5657 think that Hankin <hankin@dunno.com> sent me this report, but I'm
5658 willing to be corrected on this point.
5660 * format.c: (check_string_specifier) Fix obvious typo.
5662 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
5664 Using $CASENUM in an expression didn't work. Here's a fix.
5665 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
5668 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
5670 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
5672 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
5674 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
5675 other behavior, *sigh*. This patch hopefully fixes that. This
5676 time I've actually tested it.
5678 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
5680 * data-list.c: (read_from_data_list_free,
5681 read_from_data_list_list) Call parse_string_as_format() directly
5682 without mucking around with the field width.
5684 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
5686 Occasionally, you may encounter a script that wants to be
5687 interpreted in interactive mode. Make -i emulate this behavior to
5688 allow such scripts to be executed with PSPP.
5690 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
5692 * cmdline.c: (pre_syntax_message[]) Update -i description.
5694 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
5695 when -i is given on the command line) don't treat unindented lines
5696 as starting a new command.
5698 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
5700 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
5701 mostly caused by local initialized aggregates. After egcs is
5702 fixed upstream these can be removed, but for now they're not a big
5705 * ascii.c: (ascii_postopen_driver) Checker chokes on local
5706 initialized arrays. Avoid this.
5708 * sfm-write.c: (sfm_write_dictionary) Don't use a local
5711 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
5713 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
5714 following changes avoid. Currently I compile sources with egcs
5715 1.1.1 and gcc 2.7.2.3 before sending them out.
5717 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
5719 * ascii.c: (option_tab[]) Initialize all struct members.
5721 * avl.h: (avl_traverser_init) New macro.
5723 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
5726 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
5729 * hash.c: Comment fix.
5731 * hash.h: (hsh_iterator_init) New macro.
5733 * html.c: (option_tab[]) Initialize all struct members.
5735 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
5738 * postscript.c: (option_tab[]) Initialize all struct members.
5739 (output_encodings, preclose, dump_lines) Use new
5740 hsh_iterator_init() macro.
5742 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
5745 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
5748 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
5750 * data-in.c: Examined each of the parsing functions to make sure
5751 that they wouldn't dump core if they were passed a string of the
5752 wrong length, since now the DATA LIST FREE/LIST routines don't
5753 check for field width before passing it to the data parser.
5754 (parse_RBHEX, parse_AHEX) Reject odd length input.
5755 (parse_string_as_format) Reject input that's too short or too
5758 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
5759 a field to its entire declared output width then pass it to the
5760 data-in parsing routines. This contradicted the documented
5761 behavior. This is fixed in these changes. Thanks to Mark H. Wood
5762 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
5763 free-format parsing that differed from SPSS.
5764 (cut_field) Commas and spaces are treated identically. Returns
5765 the proper column instead of a fixed 1 value.
5766 (parse_field) Removed.
5767 (read_from_data_list_free, read_from_data_list_list) Call
5768 parse_string_as_format directly instead of parse_field.
5770 * heap.c: (heap_delete) Stylistic fixes.
5772 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
5774 * loop.c: (loop_2_trns_proc) Formatting fix.
5776 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
5778 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
5780 * vfm.c: (macro FILTERED) New.
5781 (static var filter_var) New.
5782 (process_active_file_write_case) Use FILTERED.
5783 (setup_filter) Set filter_var.
5784 (close_active_file) Delete the filter if not
5785 FILTER_before_TEMPORARY.
5786 (procedure_write_case) Use FILTERED.
5788 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
5790 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
5792 * data-in.c: (parse_day_count) Message fix.
5793 (parse_month) Style fix.
5795 * data-list.c: (struct data_list_pgm) New member eof.
5796 (cmd_data_list) Init eof to 0.
5797 (do_reading) Implement the /END subcommand and read-past-eof
5800 * do-if.c: Include stdio.h when debugging.
5801 (cmd_else_if) Make sure the command is .-terminated.
5803 * glob.c: (init_glob) Capitalize the command prompt.
5805 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
5806 (end_file_trns_proc) Debugging message.
5808 * loop.c: (internal_cmd_loop) Make it work when there's no loop
5810 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
5812 * main.c: (dump_token) Make kwtab[] const.
5814 * set.q: Spelling, comment fixes.
5816 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
5819 * vars-prs.c: (fill_all_vars) Style fix.
5821 * vfm.c: (index_to_varname) Return const.
5823 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
5825 * Changes in many source files for partial -ansi -pedantic and
5826 no-debugging compliance: Remove trailing common in enum
5827 declarations; add `unused' attributes; insert some appropriate
5830 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
5832 * command.c: (shell) Make static.
5833 (run_command) Make static.
5835 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
5837 * dfm.c: (cmd_begin_data) I18n fix.
5839 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
5841 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
5843 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
5846 * file-handle.q: Don't prepend the source file directory name to
5847 the data file name. (Ongoing issue.)
5848 (prepend_current_directory) Comment out.
5849 (internal_cmd_file_handle) Don't call prepend_current_directory().
5850 (fh_get_handle_by_filename) Ditto.
5852 * filename.c: Append zero byte to readlink() return value.
5854 * getline.c: (getl_read_line) I18n fix.
5856 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
5858 * misc.h: Don't use gcc features if __STRICT_ANSI__.
5860 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
5863 * postscript.c: (output_encodings) Don't use local_strdup().
5866 * print.c: Don't use gcc features if __STRICT_ANSI__.
5868 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
5870 * recode.c: (parse_src_spec) Fully brace nested if's.
5872 * set.q: (global var set_testing_mode) New var.
5874 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
5876 * ascii.c: Add some more `unused' attributes that only come into
5877 play when NDEBUG is defined.
5878 (ascii_close_page) Set s_len when reallocating s.
5880 * crosstabs.q: (delete_missing) New function.
5881 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
5882 (make_summary_table) Create summary table reallocable.
5884 * postscript.c: Add more `unused' attributes as above.
5886 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
5887 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
5889 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
5892 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
5893 gratuitous space between parameter definition.
5895 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
5896 complaints about running off the end of functions with NDEBUG
5899 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
5901 * Several source files: Removed some PORTME notes when reflection
5902 revealed that ANSI forbids that sort of breakage. Also, added
5903 lots of `unused' qualifiers here and there.
5905 * aggregate.c: (accumulate_aggregate_info) Remove local var
5906 weighting that turned out not to be used.
5908 * avl.c: Update to version 1.1.0. Add unused specifier.
5909 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
5911 (avl_probe) Replace some instances of 1 with +1 where appropriate.
5912 (avl_find) Cast return value to void *.
5913 (avl_delete) q doesn't need to be initialized at the beginning of
5914 the function. Replace some instances of 1 with +1.
5915 (force_avl_delete) Renamed avl_force_delete, all references changed.
5916 (compare_ints) `param' marked unused.
5917 (print_int) `param' marked unused.
5918 (recurse_tree) Replace some instances of 1 with +1.
5920 * avl.h: Update to version 1.1.0. Only declares avl function
5921 types if not already declared.
5922 (AVL_MAX_HEIGHT) Only define if not already defined.
5923 (struct avl_node) New unused member char pad[2].
5924 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
5925 (force_avl_insert) Renamed avl_force_insert.
5926 (force_avl_delete) Renamed avl_force_delete.
5928 * crosstabs.q: (struct table_entry) Put `freq' into a union with
5930 (struct crosstab) Add new member `ofs'.
5931 (glob var int_tab) Removed.
5932 (custom_tables) In integer mode, assign v[i] properly through the
5934 (custom_variables) Now p.crs.max == max + 1.
5935 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
5936 (precalc) Implement integer mode.
5937 (calc_integer) Implement integer mode.
5938 (compare_table_entry) Remove unused local variable `comparing'.
5939 (make_summary_table) Implement integer mode.
5940 (macro ns_rows) Implemented as static variable now.
5941 (several variables) Made static, from global.
5942 (output_pivot_table) Use table_value_missing() for column heads.
5943 Remove several unused local variables. Implement integer mode
5944 table summing. Count up ns_rows.
5945 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
5946 (find_pivot_extent) Moved into find_pivot_extent_general; now just
5947 calls that function or find_pivot_extent_integer.
5948 (find_pivot_extent_integer) New function.
5949 (enum_var_values) Implemented for integer mode.
5950 (table_value_missing) New function.
5951 (display_dimensions) Call table_value_missing() for heads.
5952 (float_M_suffix) New function.
5953 (display_crosstabulation) Call table_value_missing() for row
5954 heads. Handle missing values in /MISSING=REPORT mode.
5955 (calc_fisher) Remove unused var N.
5956 (calc_r) Remove unused var fact.
5958 * data-list.c: (dump_fixed_table) Fix table dimensioning.
5959 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
5961 * data-out.c: (insert_commas) Remove unused var cp.
5962 (convert_CCx) Remove unused vars save_set_decimal,
5965 * descript.q: (dump_z_table) Fix table dimensioning.
5966 (pre_calc) Remove unused var j.
5967 (display) Remove unused vars title, s. Fix table dimensioning.
5969 * expr-evl.c: Comment fixes.
5971 * frequencies.q: (full_dim) New function.
5972 (dump_full) Fix table dimensioning.
5973 (condensed_dim) New function.
5974 (dump_condensed) Fix table dimensioning.
5976 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
5979 * html.c: (html_close_drive) Remove unused var i.
5980 (postopen) Remove unused vars title, curfn_len, cp.
5981 (preclose) Remove unused vars this, x.
5983 * lexer.c: Comment fixes.
5985 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
5987 * means.q: (custom_tables) Remove unused var m_dim.
5989 * mis-val.c: Format fix.
5991 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
5993 * output.c: (outp_get_paper_size) Remove unused var cp.
5995 * pfm-read.c: (read_float) Remove unused var save, unused label
5997 (read_variables) Remove unused vars cp, j.
5998 (read_value_label) Remove unused var j.
6000 * pfm-write.c: (bufwrite) Remove unused var i.
6002 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
6004 (output_encodings) Remove unused vars char_cp, n_output.
6005 (read_ps_encodings) Remove unused var ep.
6006 (postopen) Remove unused var title.
6007 (preclose) Remove unused var fp.
6008 (ps_open_page) Remove unused vars true, false, orientation,
6009 mirror_horz, mirror_vert, width, length.
6010 (ps_text_metrics) Remove unused var x.
6012 * q2c.c: (find_symbol) Remove unused var y.
6013 (parse_setting) Remove unused parameter sbc, all references
6015 (dump_parser) Remove unused var cp.
6016 (dump_free) Remove unused var i.
6018 * set.q: (static vars args, n) Removed.
6019 (internal_cmd_gset) Removed.
6021 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
6022 (read_machine_flt64_info) Removed unused var file_endian.
6023 (read_documents) Removed unused var i.
6024 (read_compressed_data) Removed unused parameter dict, all
6027 * sfm-write.c: (bufwrite) Removed unused var i.
6028 (sfm_write_case) Removed unused var i.
6030 * sort.c: (merge_once) Remove unused var t.
6031 (write_separate) #if 0 out as dead code.
6033 * split-file.c: (cmd_split_file) Remove unused var i.
6035 * sysfile-info.c: (sysfile_info_dim) New function.
6036 (cmd_sysfile_info) Fix table dimensioning.
6037 (variables_dim) New function.
6038 (display_variables) Fix table dimensioning.
6039 (describe_variable) Remove unused var prev_r.
6041 * t-test.q: (z_postcalc) Removed.
6042 (pairs_calc) Remove unused var bad_weight.
6043 (postcalc) Remove unused vars dfn, dfd.
6045 * tab.c: (tab_create) Set t->dim to NULL.
6046 (tab_dim) Make sure t->dim is NULL first.
6047 (tab_natural_width) Remove parameter `clamp'.
6048 (tab_value) Remove duplicate assertion for table.
6049 (tab_raw) New function.
6050 (nowrap_dim) New function.
6051 (wrap_dim) New function.
6052 (tab_output_text) Fix table dimensioning.
6054 * tab.h: (tab_raw) New macro.
6056 * val-labs.c: (get_label) Remove unused var type.
6057 (copy_value_labels) Remove unused var trav.
6059 * var.h: (struct crosstab_proc) Completely changed.
6061 * vars-prs.c: (parse_dict_variable) Remove unused var v.
6063 * vfm.c: (open_active_file) Remove unused vars i, lp.
6065 * weight.c: (weight_trns_proc) #if 0 out as dead code.
6067 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
6069 * Makefile.am: Add apply-dict.c, flip.c.
6071 * apply-dict.c: New file.
6073 * command.c: (struct command) Make cmd[] larger for CLEAR
6074 TRANSFORMATIONS command name.
6075 (parse_cmd) Make sure we're in a valid state before using it as an
6076 index. Discard variables and reset state on invalid transitions.
6077 (cmd_clear_transformations) New function.
6079 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
6080 Add unimplemented PRESERVE, RESTORE.
6082 * file-handle.h: Include stddef.h.
6086 * pfm-read.c: (parse_value) Pad value label values with spaces,
6089 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
6090 (sfm_close) Decrement reference count, make sure it's zero.
6091 (sfm_maybe_close) New function.
6092 (sfm_read_dictionary) Handle reference counts.
6094 * vars-atr.c: (clear_default_dict) New function.
6095 (discard_variables) Use clear_default_dict().
6097 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
6099 * Makefile.am: Add pfm-write.c.
6100 (LDADD) Add the libgmp2 libraries.
6102 * command.def: Define EXPORT.
6104 * get.c: (cmd_export) New function.
6105 (export_write_case_func) New function.
6107 * pfm-read.c: (static spss2ascii[]) Make it const.
6109 * pfm-write.c: New file.
6111 * sfm-write.c: Formatting, comment fixes.
6113 * var.h: Comment fix.
6115 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
6117 * Makefile.am: Add pfm.h, pfm-read.c.
6119 * command.def: IMPORT is now implemented.
6121 * format.c: (glob var translate_fmt[]) New var.
6123 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
6124 (cmd_import) New function.
6125 (import_source_read) New function.
6126 (glob var import_source) New var.
6128 * pfm-read.c: New file.
6132 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
6134 (dump_dictionary) Disabled printing a couple of items.
6136 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
6138 * crosstabs.q: (postcalc) Call make_summary_table().
6139 (make_summary_table) New function.
6140 (insert_summary) New function.
6141 (display_dimensions) Remove some unnecessary arguments, all
6143 (output_pivot_table) Fix lots of problems with the risk table
6145 (submit) Don't display an empty table.
6146 (display_risk) Fix order of arguments to calc_risk().
6148 * glob.c: Always include assert.h and stdlib.h.
6150 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
6153 * tab.c: (tab_create) Cosmetic changes.
6155 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
6157 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
6161 * crosstabs.q: (output_pivot_table) Headers drawing and submission
6162 code simplified, moved into new function submit().
6163 (submit) New function.
6164 (crosstabs_dim) New function.
6165 (display_directional) Substitute variable names for %s where
6167 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
6168 (calc_symmetric) Initialize parameters only if non-NULL.
6169 Calculate Somers' d.
6170 (calc_directional) Calculate Somers' d (or copy it, really).
6173 * output.c: (outp_string_width) New function.
6175 * postscript.c: (postopen) Calculate font widths based on the
6176 width of the zero '0' character, not the width of the space
6177 character. Set paper-width and paper-length based on points, not
6179 (ps_open_page) Fix page setup string for landscape mode.
6181 * som.h: (struct som_dimension) Removed.
6182 (struct som_table_class) height, width members take int * not
6185 * tab.c: Many functions now have added parameter validation.
6186 (tab_height, tab_width) These functions were removed and merged
6187 into a single function tab_resize(), and all references changed.
6188 (tab_dim) Rewritten since the interface changed; reduced from
6189 hundreds of lines to two. All callers were changed. Currently
6190 most of them just use tab_natural_dimensions as their callback and
6191 await detailed translation of functionality.
6192 (tab_natural_width) New function.
6193 (tab_natural_height) New function.
6194 (tab_natural_dimensions) New function. This is a callback
6195 function, not something that you'd want to call directly.
6196 (tab_nat_dim) Removed.
6197 (tabi_table) Allocates t->w and t->h.
6198 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
6199 dimensions callback.
6200 (evaluate_dimensions) Removed.
6201 (sum_columns) Removed.
6203 * tab.h: (enum TAL_1THIN) Removed.
6204 (enum series t_*) Removed.
6205 (struct tab_table) Members trh, trv changed to unsigned char *
6206 from int *. Member dim changed to a function pointer from a
6207 unsigned char *. Member max_stack_height removed. New members
6209 (macros tab_l, tab_r, tab_t, tab_b) New.
6211 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
6213 * ascii.c: (delineate) Assign last_space_nchars before skipping
6214 spaces, to fix right justification.
6216 * crosstabs.q: (static vars risk, direct) New vars.
6217 (static var pearson_r) Removed.
6218 (glob var chisq_fisher) Made static.
6219 (static vars row_tot[], col_tot[]) Don't include grand total
6221 (static var grand_total) Renamed W, all references changed.
6222 (output_pivot_table) Only make `table' if num_cells != 0. Make
6223 risk and directional tables. Deal with grand total no longer part
6224 of col_tot[]. Free rows and cols after we're done with them.
6225 (display_risk) New function.
6226 (display_directional) New function.
6227 (clac_r) Rewritten so that it stores all its results into its
6228 arguments, so it can be used for Spearman's correlation too.
6229 (calc_symmetric) Added a t[] argument, all references changed.
6230 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
6231 Pearson's r, Cohen's kappa.
6232 (calc_risk) New function.
6233 (calc_directional) New function.
6235 * som.c: (som_submit) Improved debugging code.
6237 * stats.c: (hypercube) New function.
6238 (cube) New function.
6240 (normal_sig) Went back to old implementation, which actually
6243 * stats.h: (macros square, cube, hypercube) Removed. The
6244 equivalent functions in stats.c are inlined here; all references
6245 to square changed to sqr.
6247 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
6249 * crosstabs.q: (N_SYMMETRIC) New define.
6250 (postcalc) Disable debug printing.
6251 (static vars chisq_fisher, pearson_r) New.
6252 (output_pivot_table) Add support for symmetric measures. Add
6253 chi-square output of exact sigs.
6254 (display_chisq) Rewritten.
6255 (display_symmetric) New function.
6256 (gamma_int) New function.
6258 (swap) New function.
6259 (calc_fisher) New function.
6260 (calc_chisq) Check boundary conditions better. Calculate Yates,
6261 Fisher, Mantel-Haenszel tests.
6262 (calc_r) New function.
6263 (calc_symmetric) New function.
6265 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
6267 (chisq_sig) Better boundary conditions. Renamed from
6270 * tab.h: (struct tab_table) New member cf.
6272 * tab.c: (tab_create) Set cf.
6273 (tab_width) New function.
6274 (tab_realloc) Handle cf.
6275 (tab_vline) Handle cf.
6276 (tab_hline) Handle cf.
6277 (tab_box) Handle cf.
6278 (tab_value) Handle cf.
6279 (tab_float) Handle cf.
6280 (tab_text) Handle cf.
6281 (tab_joint_text) Handle cf.
6282 (tab_offset) Handle cf.
6283 (tab_next_row) Handle cf.
6284 (evaluate_dimensions) Handle cf.
6285 (render_strip) Handle cf.
6287 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
6289 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
6290 output_pivot_table().
6291 (output_pivot_table) Moved lots of local variables outside and
6292 made them static. Add beginnings of chi-square statistic
6293 support. Now column and row totals aren't in the main matrix.
6294 Always zero out any leftover rows & columns after we're done with
6295 the table entries. Move all output stuff into
6296 display_dimensions(), display_crosstabs(), display_chisq().
6297 (display_dimensions) New function.
6298 (display_crosstabulation) New function.
6299 (display_chisq) New function.
6300 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
6302 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
6303 references, simplify logic.
6305 * postscript.c: Remove scale, translate-x, translate-y,
6306 mirror-horz, mirror-vert, rotate-180 options.
6307 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
6308 All references deleted.
6309 (macro YT) New macro.
6310 (array option_tab[]) Removed options.
6311 (ps_option) Removed options.
6312 (ps_open_page) Write page setup explicitly to output file, without
6313 using now-deleted BP function.
6314 (macro dump_line) Use YT().
6315 (macro dump_thick_line) Use YT().
6316 (draw_headers) Use YT().
6317 (switch_font) Reorder arguments to SF function.
6318 (write_text) Use YT().
6320 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
6323 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
6325 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
6326 null-debugging code.
6327 (tab_realloc) Remove null-debugging code. Initialize new regions
6329 (tab_vline) Support offsets.
6330 (tab_hline) Support offsets.
6331 (tab_box) Support offsets.
6333 (tab_nulls) Removed.
6336 (evaluate_dimensions) Remove null-debugging code. Understand
6337 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
6338 TAB_EMPTY not present.
6340 * tab.h: New cell attribute TAB_EMPTY.
6341 (macros tab_nr, tab_nc, tab_row, tab_col) New.
6343 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
6344 try to read them from system files.
6346 * vfm.c: (dump_splits) Don't call tab_null().
6348 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
6350 * crosstabs.q: (struct crosstab) Added `missing' member.
6351 (custom_tables) Init missing.
6352 (calc_general) Handle missing values.
6353 (calc_chisq) New function.
6354 (output_pivot_table) Start work on chi-square output. Update for
6355 new tab offset support functions. Shorten statistic names.
6357 * Several files: add in more `const's to placate gcc's warnings.
6359 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
6362 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
6363 tab_null, tab_nulls, tab_value, tab_float, tab_text,
6364 tab_joint_text) Add col_ofs and row_ofs support.
6365 (tab_offset) New function.
6366 (tab_next_row) New function.
6367 (tab_row) New function.
6368 (tab_col) New function.
6369 (tabi_table) Add col_ofs and row_ofs support.
6371 * vars-atr.c: (is_system_missing) New function.
6373 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
6375 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
6376 (static var no_cells) Removed.
6377 (static var num_cells) New.
6378 (static var expected) New.
6379 (static var cells[]) New.
6380 (internal_cmd_crosstabs) Deal with new variables.
6381 (postcalc) Removed most of the meat and put it in new function
6382 output_pivot_table().
6383 (output_pivot_table) Calculates and outputs an entire pivot table.
6385 * postscript.c: (postopen) Fix problems with free()ing addresses
6386 not obtained from malloc().
6388 * som.c: (som_submit) Add assertion.
6390 * sysfile-info.c: (describe_variable) Use new tab_nulls()
6393 * tab.c: (static var tab_names[]) New.
6394 (tab_realloc) -1 for nc or nr indicates no change.
6395 (tab_nulls) New function.
6396 (tab_dim) Use tab_names[].
6397 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
6398 (evaluate_dimensions) Don't terminate on uninited cells, just put
6399 an X in them and emit a notice. Use tab_names[].
6401 * tab.h: Move bits into tab.def.
6403 * tab.def: New. Don't try to declare tab_table_class because then
6404 som.h has to be included.
6406 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
6408 * command.def: New file, contains all the command definitions
6409 previously included bodily in command.c.
6411 * format.def: New file, contains all of the format definitions
6412 previously split across format.h, format.c, and sfm-write.c.
6414 * lexer.h: Renamed from tokens.h in order to match corresponding
6417 * lexerP.h: Moved some rarely used functions exported by lexer.c
6420 * Makefile.am: Commemorate renamed files.
6421 (EXTRA_DIST) Add command.def, format.def.
6423 * command.c: [0] (walk_cmdtable_func) Removed.
6425 * crosstabs.q: (postcalc) Made it work and print out matrices
6427 (enum_column_values) Renamed enum_var_values, generalized for any
6430 * format.h: (struct fmt_desc) New member `spss'.
6432 * q2c.c: (main) Generated code includes lexer.h instead of
6435 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
6436 instead of an independent translation table.
6438 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
6440 * Lots of source files: Added const to declarations.
6442 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
6444 * arena.c: (arena_clear) Set prev pointer to null when done.
6446 * ascii.c: (ascii_option) Rename index as indx.
6448 * avl.c: This is now a separate library called libavl.
6449 (xmalloc) Make static.
6450 (avl_probe) Step A7 can use the cache instead of an explicit
6452 (avl_delete) Don't maintain a q pointer because it's always
6453 available in the pointer stack. Comment fix.
6455 * avl.h: This is now a separate library called libavl.
6457 * command.c: (cmd_table[]) Remove spurious trailing "".
6459 * common.h: Only include random() fix if this system needs it.
6461 * crosstabs.q: Include alloca headers.
6462 (n_sorted_tab) New global var.
6463 (postcalc) Mostly rewritten.
6464 (find_pivot_extent) Rewritten.
6465 (enum_column_values) Rewritten.
6467 * data-out.c: (convert_F) Rename inner n as n_spaces.
6469 * error.c: (dump_message) Don't have an outer var i.
6471 * file-handle.q: (static var f) Removed. All references removed.
6472 (internal_cmd_file_handle) Uses a local variable instead of f.
6474 * get.c: (trim_dictionary) Change scope of i, i1, i2.
6475 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
6478 * getline.h: Declare getl_history as extern. Reported by
6479 palme@uni-wuppertal.de (Hubert Palme).
6481 * postscript.c: (postopen) Some large mods for constness.
6483 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
6486 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
6488 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
6489 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
6492 * avl.c, avl.h: New files. These form a clean-room
6493 reimplementation of avllib. Iterative algorithms are used in
6494 place of recursive ones, so there is no resemblance in the code.
6496 * Lots of headers: Don't include other headers by default.
6498 * Lots of source files: Explicitly include all needed headers.
6500 * arena.c: (arena_clear) New function.
6502 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
6503 (static var ar) Removed.
6504 (staitc vars ar_tc, ar_col) New.
6505 (cmd_crosstabs) Destroy the arenas.
6506 (internal_cmd_crosstabs) Create the arenas.
6507 (precalc) Don't need a free function for the hash.
6508 (calc_general) Make sure to zero out the trailer on the key data
6510 (print_table_entries) Updated.
6511 (postcalc) Worked on actually implementing.
6512 (find_pivot_extent) New function.
6513 (compare_value) New function.
6514 (enum_column_values) New function.
6516 * data-in.c: (parse_month) Make local array `static const'.
6518 * data-out.c: (convert_date) Make local array `static const'.
6519 (convert_WKDAY) Same.
6520 (convert_MONTH) Same.
6522 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
6523 been renamed to avl_walk().
6525 * hash.c: Rewritten more efficiently.
6527 * hash.h: Add attribute const to hsh_next_prime declaration.
6529 * lexer.c: (id_match) Make arguments const.
6531 * postscript.c: (ps_postopen_driver) Make default fonts the
6534 * q2c.c: (main) Generated code needs stdlib.h.
6536 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
6537 initialized to 0 now, not to NULL. All other references to
6538 avl_traverser were updated in the same way.
6540 * tokens.h: Macro version of id_match updated to use const
6543 * val-labs.c: (inc_ref_count) New function.
6544 (copy_value_labels) Simply through use of new avl_copy() function.
6546 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
6548 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
6549 (postcalc) Worked on this.
6551 * postscript.c: (OPO_DOUBLE_LINE) New enum.
6552 (struct ps_driver_ext) New line_width_thick member.
6553 (ps_preopen_drive) Init line_width_thick.
6554 (option_tab[]) Add line-* options.
6555 (ps_option) Parse line-* options.
6556 (postopen) Add line_width_thick support. Strip leading spaces on
6557 prologue output lines.
6558 (ps_open_page) Include line_width_thick in output.
6559 (macro dump_thick_line) New.
6560 (dump_fancy_line) Support thick lines as well as double lines.
6562 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
6564 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
6565 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
6567 * Many source files: Rename `options' to `pv_opts' as appropriate.
6569 * command.c: (static var cmd_table[]) Add CROSSTABS command.
6571 * common.c: (xcalloc) New function.
6573 * crosstabs.q: New file. Not finished yet, though.
6575 * data-list.c: Comment fix.
6577 * error.c: Remove some old Checker cruft.
6579 * frequencies.q: (dump_full) Cumulate valid percent instead of
6582 * getline.c: Comment fix.
6584 * hash.c: Comment fixes.
6586 * hash.h: (struct hsh_table) Make hash functions return unsigned
6587 instead of int to avoid problems with taking the modulo of
6588 negative return values. All references changed.
6590 * misc.c: (intlog10) Make its table static const instead of auto.
6592 * sfm-read.c: (read_header) Make `prefix' static const instead of
6595 * var.h: (union value) Add member `hash'.
6596 (struct variable) Rename prv_index as `foo'--all references
6598 (typedef pv_opts) Removed. All references changed.
6600 * vars-prs.c: (parse_variables) Message fixes.
6602 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
6604 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
6605 they are being inserted. Don't check for BY variables of
6606 different types. Discard variables if the active file isn't
6607 included in the merge.
6608 (mtf_processing) Essentially rewritten.
6609 (mtf_merge_dictionary) Check for master/slave variables of
6610 different types/widths.
6612 * vfm.c: (static var not_canceled) New var.
6613 (process_active_file) Don't call vfm_source->read() if
6614 there's no vfm-source. Initialize not_canceled.
6615 (process_active_file_write_case) Honor and update not_canceled.
6616 (prepare_for_writing) Rollback changes from yesterday, they were
6618 (close_active_file) Don't destroy vfm_source unless it exists.
6620 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
6622 * Lots of source files: Added { } around nested if/else constructs
6623 to avoid new gcc 2.8 warnings.
6625 * data-in.c: (parse_Z) Declare `int' type explicitly.
6628 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
6629 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
6630 prev members. Put TABLEs at the end of the chain and FILEs at the
6631 beginning. Don't allow the active file in STATE_INIT. Use proper
6632 `seen' value for the active file. Fill out the by members and
6633 make sure they're of consistent type. Do the actual merge
6635 (mtf_processing_finish) New function.
6636 (var_type_description) New function.
6637 (mtf_free_file) New function.
6638 (mtf_free) Rewritten.
6639 (mtf_delete_file_in_place) New function.
6640 (mtf_read_nonactive_records) New function.
6641 (mtf_compare_BY_values) New function.
6642 (static var mtf_seq_no) New var.
6643 (mtf_processing) New function.
6644 (mtf_merge_dictionary) Assign nval members for the system file
6645 dictionary. Assign fv values for its variables. Point each slave
6646 variable to the corresponding master variable.
6648 * hash.c: Include str.h.
6650 * mis-val.c: (copy_missing_values) src arg is const.
6652 * misc.c: (spacing) Make `max' var explicitly int.
6654 * sfm-read.c: (dump_dictionary) Message reformatting.
6655 (sfm_read_case) Add assertion.
6657 * sort.c: Esthetic fixes.
6659 * var.h: (struct match_files_proc) New struct.
6660 (struct variable) Add private data match_files_proc.
6662 * vars-atr.c: (delete_variable) Implement. Add argument for the
6663 dictionary that owning the variable.
6664 (dup_variable) Add assertion.
6666 * vfm.c: Comment fixes, hopefully the comments are correct now.
6667 (process_active_file) New function.
6668 (process_active_file_write_case) New function.
6669 (process_active_file_output_case) New function.
6670 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
6672 (write_case) Renamed procedure_write_case(). Now write_case is a
6673 pointer to a function. Style fixes.
6675 1998-03-05 Ben Pfaff <blp@gnu.org>
6677 * Makefile.am: (q2c) Link with libmisc.
6678 (version.c) Define default_config_path, include_path,
6681 * ascii.c: (ascii_postopen_driver) When the default newline string
6682 is requested, open file in text mode. Suggested by
6683 palme@uni-wuppertal.de (Hubert Palme).
6684 (static vars line_buf, line_p) Change from char * to unsigned char
6686 (ascii_close_page) char * to unsigned char *.
6688 * cmdline.c: (parse_command_line) Implement -r option by
6689 prepending ~/.pspp/rc to the list of files to process.
6691 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
6692 before pulling in a final line.
6693 (null_func, null_int_func) Removed (dead code).
6695 * descript.q: (display) Calculate width of variable name column
6696 properly. Calculate number of valid cases properly. Reported by
6697 palme@uni-wuppertal.de (Hubert Palme).
6699 * filename.c: (init_filename) Use default_config_path instead of
6700 now obsolete CONFIG_PATH.
6702 * getline.c: (getl_initialize) Use include_path instead of now
6703 obsolete INCLUDE_PATH.
6704 (getl_add_file) New argument `where'. All references changed.
6706 * groff.c: (find_font_file) Use groff_font_path instead of now
6707 obsolete GROFF_FONT_PATH.
6709 * postscript.c: (find_ps_file) Use groff_font_path instead of now
6710 obsolete GROFF_FONT_PATH. Copy through temporary variable to
6711 avoid problems with constness.
6713 * str.h: (macro cs_streq) New macro.
6715 * version.h: (glob var default_config_path, include_path,
6716 groff_font_path) New vars.
6718 1998-02-23 Ben Pfaff <blp@gnu.org>
6720 * Many source files: Change verbose_msg() priority levels and
6723 * aggregate.c: Include debug-print.h.
6725 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
6727 (static var pre_syntax_message) Document --safer/-s and
6730 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
6732 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
6733 because it's not used but it's still copied.
6734 (open_file_r) Remove gratuitous debug message.
6736 * filename.c: (safety_violation) New function.
6737 (open_file) Remove gratuitous debug messages. Don't allow pipe
6738 files if set_safer is set.
6740 * get.c: Turn off debugging.
6742 * getline.c: (getl_add_virtual_file) New function.
6743 (getl_read_line) Add verbose_msg() call for opening new syntax
6745 (getl_perform_delayed_reset) Add a return value describing whether
6746 any action was taken. Call reset_eof().
6748 * getline.h: Comment fix.
6750 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
6751 place of incorrect `continue'. Use strtok_r() instead of
6752 strtok(). Always check strtok_r() return value.
6753 (groff_read_DESC) Use strtok_r() instead of strtok().
6755 * lexer.c: (reset_eof) New function.
6757 * main.c: (parse) Get a token after performing a delayed reset
6758 action; allow empty syntax files.
6760 * postscript.c: (output_encodings) Use strtok_r() instead of
6763 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
6765 * set.q: Comment fixes.
6766 (glob var set_safer) New var.
6767 (internal_cmd_set) Support SAFER.
6769 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
6771 * temporary.c: (free_dictionary) Set d->splits to NULL after
6774 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
6775 variable deleted, not if it *isn't* deleted.
6777 1998-02-16 Ben Pfaff <blp@gnu.org>
6779 * command.c: (array cmd_table[]) Add MATCH FILES.
6781 * common.c: Comment fixes.
6783 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
6784 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
6785 Include alloca.h. Problem reported by palme@uni-wuppertal.de
6788 * expr-opt.c: Include str.h. Problem reported by
6789 palme@uni-wuppertal.de (Hubert Palme).
6791 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
6792 (static var mtf_by) Change from char ** to variable **.
6793 (static var mtf_master) New var.
6794 (mtf_merge_dictionary) New function.
6795 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
6796 var type. Reorder tests properly. Initialize file->dict. Detect
6797 TABLE= without BY=. Read file dictionaries and merge them. Give
6798 subcommand name with IN, LAST, FIRST error messages. Create IN,
6799 LAST, FIRST variables. Comment fixes.
6800 (mtf_free) Don't free default_dict. Free mtf_master.
6802 * getline.c: Define getl_mode. Change getl_buf_size to size_t
6804 (handle_line_buffer) Cast int to size_t in comparison to avoid
6807 * getline.h: Declare getl_mode extern.
6809 * groff-font.c: (groff_read_font) Type-fix calls to getline.
6810 (groff_read_DESC) Make line_size a size_t.
6811 (match_tok) Parenthesize name to avoid macro expansion.
6813 * mis-val.c: (copy_missing_values) New function.
6815 * postscript.c: (postopen) Make buf_size a size_t.
6817 * sfm-read.c: (dump_dictionary) Make global from static. Print
6818 variable info in parts for easier debugging with Checker.
6820 * temporary.c: (copy_variable) Use copy_value_labels().
6821 (new_dictionary) New arg: whether to copy file label, documents.
6823 * val-labs.c: (copy_value_labels) New function.
6825 * var.h: (enums MISSING_*) Add MISSING_COUNT.
6827 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
6829 (dup_variable) Set prv_index, get.fv, get.nv.
6831 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
6833 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
6835 * Many source files: For ANSI-compliance, add empty statement
6836 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
6837 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6839 * data-in.c: (parse_numeric) Some header files break on
6840 -DBL_MIN_10_EXP because they get a --; add () for safety.
6841 Reported by palme@uni-wuppertal.de (Hubert Palme).
6843 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
6844 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
6845 (dfm_close) Use close_file_ext.
6846 (open_inline_file) Set file.file to NULL, not file.
6847 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
6848 struct and use open_file_ext().
6849 (read_record) Use file.file.
6851 * file-handle.q: (prepend_current_directory) Pass through special
6854 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
6855 (normalize_filename) Pass through special filenames.
6856 (open_file, close_file) Accept pipe| and |pipe syntaxes as
6858 (dirname) Rename blp_dirname() because of name conflict on some
6859 OS. All references changed. Reported by palme@uni-wuppertal.de
6861 (is_special_filename) New function.
6863 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
6864 (trim_dictionary) Conditionalize some of the options on whether
6865 GTSV_OPT_MATCH_FILES is in *options.
6866 (rename_variables) Don't allow variables to be renamed as scratch
6868 (MTF_*) New enum series.
6869 (struct mtf_file) New struct.
6870 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
6872 (cmd_match_files, mtf_free) New functions.
6874 * lexer.c: (match_int) Needed parentheses around name to escape
6875 macro expansion. Reported by Micah Altman
6876 <maltman@www-vdc.fas.harvard.edu>.
6878 * print.c: Needed to include alloca.h. Reported by Micah Altman
6879 <maltman@www-vdc.fas.harvard.edu>.
6881 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
6882 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
6885 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
6886 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
6888 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
6890 * html.c: (struct html_driver_ext) Move into htmlP.h.
6891 (html_preopen_driver) Initialize cp_x, cp_y.
6892 (html_submit) Implement as call to output_tab_table().
6893 (change_attributes) New function.
6894 (escape_string) New function.
6895 (output_tab_table) New function.
6897 * list.q: (write_all_headers) Add code for writing headers for the
6899 (clean_up) Write out the html close-table tag.
6900 (determine_layout) Ignore html driver.
6901 (list_cases) Write html data.
6903 * som.c: (som_submit) Move more of the code into output_table().
6905 * tab.c: (static var hit) Make a global var and rename tab_hit.
6906 (static var tab_table_class) Make a global var.
6908 * htmlP.h: New file.
6910 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
6912 * dump-sysfile.c: Removed.
6914 * html.c: (preclose) Change comment in emitted code.
6916 * matrix-data.c: Debugging off by default. Comment fixes.
6917 (static var container) New var.
6918 (cmd_matrix_data) Create and destroy container. Initialize
6919 is_per_factor[] to 0s. Move code into new function
6920 string_to_content_type(). Require split values to be present in
6921 the data when ROWTYPE_ is explicit. Call specific function, not
6922 general read_matrices().
6923 (string_to_content_type) New function.
6924 (context) Exclude all whitespace, not just spaces.
6925 (mget_token) A dot is a number. Add assertion.
6926 (static var data) Renamed nr_data.
6927 (static var factor_values) Renamed nr_factor_values.
6928 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
6929 only specific case. Close data_file before exit.
6930 (fill_matrix) New function.
6931 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
6932 printing. Style fixes. Message fixes. Move code into
6934 (read_matrices_without_rowtype) Rename
6935 matrix_data_read_without_rowtype(). Fix off-by-one error on
6936 loops. Allocate nr_data[] memory from arena.
6937 (read_matrices_with_rowtype) Removed.
6938 (read_splits) Renamed nr_read_splits(). Style fixes.
6939 (read_factors) Renamed nr_read_factors().
6940 (dump_cell_content) Comment fixes. Arguments changed. Change
6941 debug printing. All references changed.
6942 (output_data) Renamed nr_output_data().
6943 (static var wr_content) New var.
6944 (struct factor_data) New struct.
6945 (static var wr_data) New var.
6946 (static var wr_current) New var.
6947 (matrix_data_source_destroy_source) Removed.
6948 (read_matrices_with_rowtype) New function.
6949 (matrix_data_read_with_rowtype) New function.
6950 (wr_read_splits) New function.
6951 (compare_factors) New function.
6952 (wr_output_data) New function.
6953 (wr_read_rowtype) New function.
6954 (wr_read_factors) New function.
6955 (wr_read_indeps) New function.
6956 (glob var matrix_data_source) Make destroy_source member NULL as
6959 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
6961 * lexer.c: (syntax_error) Give better error message when at end of
6964 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
6965 N_SCALAR to output as plain N.
6966 (mdump_token) Change output format.
6967 (context) Fix message output interaction with spaces in input.
6968 (another_token) New function.
6969 (force_eol) Improved error message.
6970 (static var max_cell_index) New var.
6971 (read_matrices) Init `cells'. factor_values is now per-cell.
6972 Init max_cell_index.
6973 (read_data_lines) Replace `compare' local with new `compare' arg.
6974 Debugging messages changed. Only read factors if per_factor.
6975 Propagate error return from read_factors(), force_eol().
6976 Copy N_SCALAR values across the N vector.
6977 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
6978 check parentheses manually since we now have is_per_factor[].
6979 Call read_data_lines() with new args. Check for end of data after
6980 looping, using another_token().
6981 (read_factors) Arguments changed. Use max_cell_index to determine
6982 whether to read or compare factors. Message fixes.
6983 (dump_cell_content) New function.
6984 (output_data) Completely rewritten because content types were
6985 supported to be nested inside factor values, not vice versa.
6987 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
6989 * lexer.c: (syntax_error) Support formatted varargs messages.
6991 * matrix-data.c: Turn debugging on by default.
6992 (static content_type[]) New array.
6993 (static content_names[]) New array.
6994 (static rowtype_, varname_) New vars.
6995 (static is_per_factor[]) New array.
6996 (static split_values) Moved declaration.
6997 (static n_continuous, first_continuous) New var.
6998 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
6999 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
7000 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
7001 Check for continuous variables.
7002 [DEBUGGING] (debug_print) Remove content_names[].
7003 (mdump_token) New macro.
7004 (mget_token_dump) New function.
7005 (mdump_token) New function.
7006 (context) New function.
7007 (mget_token) Fix messages.
7008 (static var data, split_values, factor_values) New vars.
7009 (read_matrices) Manage split_values, factor_values.
7010 (read_data_lines) New function.
7011 (read_matrices_without_rowtype) Implemented.
7012 (read_splits) Message fixes. Uses `just_read'.
7013 (read_factors) New function.
7014 (output_data) New function.
7015 (matrix_data_source_destroy_source) Close the file handle.
7016 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
7019 * str.c: (strpadcmp) Removed.
7021 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
7023 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
7025 * Lots of source files: Add cast to unsigned character to calls to
7026 tolower() and toupper().
7028 * aggregate.c: Set default_dict.splits to NULL.
7030 * command.c: (static variable tab[]) Add MATRIX DATA.
7032 * data-in.c: Add debugging defines. Formatting fixes.
7034 * expr-opt.c: Formatting fixes.
7036 * lexer.c: (syntax_error) Message fixes.
7038 * matrix-data.c: New enum series.
7039 (static vars fmt, section, diag, explicit_rowtype, signle_split,
7040 split_values, n_factors, factors, cells, pop_n, contents,
7041 n_contents) New vars.
7042 (cmd_matrix_data) Finished implementation.
7043 (compare_variables_by_mxd_vartype) New function.
7044 [DEBUGGING] (debug_print) New function.
7045 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
7046 (read_matrices) New function.
7047 (read_matrices_without_rowtype) New function.
7048 (read_matrices_with_rowtype) New function.
7049 (read_splits) New function.
7050 (mget_token) New function.
7051 (force_eol) New function.
7052 [0] (test_tokenizer) New function.
7053 (matrix_data_source_destroy_source) New function.
7054 (glob var matrix_data_source) New var.
7056 * misc.h: Include ieeefp.h if present.
7058 * split-file.h: (cmd_split_file) Changes corresponding to struct
7061 * str.h: Fix memmem prototype.
7063 * temporary.c: (save_dictionary, restore_dictionary,
7064 free_dictionary) Changes corresponding to struct dictionary
7067 * var.h: (MXD_* enums) New enum series.
7068 (struct matrix_data_proc) New struct.
7069 (struct split) Removed.
7070 (struct dictionary) Changed `splits' member from `split *' to
7072 (macro force_create_variable) New macro. Replaced lots of
7073 create_variable()/assert() calls with calls to this macro.
7075 * vars-atr.c: (discard_variables) Changed assertion.
7076 [GLOBAL_DEBUGGING] (force_create_variable) New function
7077 called by the macro of the same name.
7078 (clear_variable) Changes to delete splits from the dictionary
7079 corresponding to struct dictionary changes.
7081 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
7082 corrupted variable `index' values in the dictionary passed in
7083 every time this function is called.
7085 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
7086 to struct dictionary changes.
7088 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
7090 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
7092 * command.c: New includes.
7093 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
7094 (cmd_erase) New function.
7095 [unix] (shell) New function.
7096 (run_command) New function.
7097 (cmd_host) New function.
7098 (cmd_new_file) New function.
7100 * expr-prs.c: (parse_primary) Message fix.
7102 * inpt-pgm.c: Formatting fix.
7103 (cmd_reread) Implement the FILE subcommand.
7105 * matrix-data.c: New file.
7107 * q2c.c: (dump_header) Change output commenting style.
7109 * weight.c: Comment fix.
7111 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
7113 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
7115 (buf_10x) Renamed buf_1xx, all references changed.
7116 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
7117 cases now implemented).
7118 (create_sysfile) New function.
7119 (agr_11x_func) New function.
7121 * data-in.c: (parse_numeric) Work properly if there's an
7122 explicitly coded decimal point in the data and decimal places are
7123 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
7124 <el@linux.lisse.na>.
7126 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
7127 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
7128 Eberhard W Lisse <el@linux.lisse.na>.
7130 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
7131 strerror.c. Bug reported by Alexandre Oliva
7132 <oliva@dcc.unicamp.br>.
7134 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
7135 (static var separate_case_tab) New var.
7136 (cmd_sort_cases) Cancel temporary transformations here. Free
7137 v_sort before return.
7138 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
7139 we're reading from a sort stream. Don't cancel temporary
7140 transformations. Offload internal sorting to do_internal_sort().
7141 (do_internal_sort) New function. Handles internal sorting even
7142 when SEPARATE is nonzero. Doesn't free v_sort.
7143 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
7145 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
7146 sink if SEPARATE is zero.
7147 (read_output_cases) Renamed read_sort_output(), all references
7148 changed. Now uses separate_case_tab when it exists.
7149 (write_separate) New function.
7151 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
7152 memory_sink_cases. Don't redundantly call
7153 vfm_source->destroy_source().
7154 (memory_stream_mode) After switching over, set memory_sink_cases
7157 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
7159 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
7161 (static var prev_case) New, moved out of aggregate_single_case()
7163 (static var buf64_10x, buf_10x) New.
7164 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
7165 the 000, 001, 100, and 101 cases. Free prev_case.
7166 (parse_aggregate_functions) Disallow scratch variables.
7167 (free_aggregate_functions) Only free agr_dict if non-null. Use
7168 iter->function to determine numeric/string type, not
7170 (aggregate_single_case) Don't manage prev_case. Initialize
7171 aggregate info after dumping it.
7172 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
7173 mean, stddev, weighted stddev definitions.
7174 (dump_aggregate_info) Implemented.
7175 (initialize_aggregate_info) Renamed from
7176 initialize_aggregate_functions(). Initializes dbl[2].
7177 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
7178 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
7180 * cases.c: (alloc_val) Removed.
7182 * get.c: (cmd_save_internal) Initialize new `dict' member.
7184 * sfm-write.c: (sfm_write_dictionary, write_header,
7185 write_variable, write_value_labels, write_documents) Reorganize,
7186 simplify for new parameter structure.
7187 (write_variable) Only one variable * argument now.
7189 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
7190 replaced by new `dict' member.
7192 * temporary.c: (new_dictionary) Initialize n_documents.
7194 * vars-atr.c: (dup_variable) Allocate `value's from dict into
7196 (init_variable, replace_variable) Eliminate usage of alloc_val().
7198 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
7200 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
7201 signal that AGGREGATE is to be used for forming final cases.
7202 (close_active_file) Call end_func before stopping lagging. Cancel
7203 temporary after finishing compaction.
7204 (write_case) Comment fixes. Cleaned up.
7205 (compact_case) Let AGGREGATE handle compaction when `temporary' is
7208 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
7210 * Makefile.am: (BUILT_SOURCES) Add means.c.
7211 (pspp_SOURCES) Add means.c.
7212 (EXTRA_DIST) Add means.q.
7214 * command.c: (array cmd_table[]) Add MEANS.
7216 * common.h: Esthetic fixes. Comment fixes. Test for
7217 MAX_SHORT_STRING greater than 8.
7218 (macros LOWEST, HIGHEST) New.
7220 * data-in.c, data-list.c, recode.c: Comment fixes.
7222 * means.q: New file, base version.
7224 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
7225 with LOWEST, DBL_MAX with HIGHEST.
7227 * q2c.c: (dump_vars) Add an enum to array types giving the number
7228 of values for the enum.
7230 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
7231 Replace second_lowest_value with second_lowest_flt64.
7233 * sfm-write.c: (write_variable, write_rec_7_34) Replace
7234 second_lowest_value with second_lowest_flt64.
7236 * t-test.q: Comment fix.
7238 * temporary.c: (restore_dictionary) Esthetic fix.
7240 * tokens.h: (force_match_id, force_match, force_string, force_int,
7241 force_num, force_id) Replace msg() with syntax_error().
7243 * var.h: (struct means_proc) New.
7244 (struct variable) Add mns member to `p' union.
7246 * vars-prs.c: (parse_variable, parse_dict_variable,
7247 parse_variables, parse_DATA_LIST_vars) Replace msg() with
7250 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
7252 * Makefile.am: (pspp_SOURCES) Add tab.h.
7254 * Most source files: Added a cast to unsigned char in usages of
7255 the ctype is*() functions. Replaced `end of command expected'
7256 calls to msg() with calls to syntax_error().
7258 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
7260 * lexer.c: (hex_val) Removed (was dead code).
7261 (idmatch) Parenthesize function name to avoid macro expansion.
7263 * postscript.c: Comment fixes.
7264 (ps_preopen_driver) Change default font size to 10pt.
7266 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
7268 (parse_format_spec) Change system-file format spec argument type
7269 to int32. Parse the format spec with bitwise operators.
7271 * sfmP.h: (struct sysfile_format) Removed.
7272 (struct sysfile_variable) Changed print, write members from
7273 sysfile_format to int32.
7275 * tokens.h: Esthetic fixes.
7276 [__GNUC__] (macro id_match) New macro to hopefully speed up
7277 identifier matching.
7278 (macros match_id, match_tok, match_int) Implemented in
7279 compiler-independent manner; no longer GNU C only.
7281 * vfm.h: Include time.h.
7283 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
7285 * data-list.c: (dump_fixed_table) Change tab_dim().
7287 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
7289 * error.c: Include command.h.
7291 * frequencies.g: Formatting fixes.
7293 * frequencies.q: Add tab_dim() calls. Make the total cell a
7296 * glob.c: Include command.h.
7298 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
7300 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
7301 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
7302 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
7303 the other elements (is this right?).
7304 (read_variables) Use lowest, highest members.
7305 (parse_format_spec) New arg `vv' for more stringent checking.
7306 (dump_dictionary) Byteswaps nonexplicit data.
7307 (sfm_read_case) Byteswap numeric data.
7309 * som.c: Initialize table_num to 1.
7310 (render_segments) Remember to increment y_index after each table
7313 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
7314 avl_count() on a NULL tree. No title for the second table.
7315 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
7316 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
7317 fix call to display_variables().
7318 (display_variables) Default to 4 columns, not 3. Set up headers.
7319 Column title is Variable, not Name. Fix index column.
7320 Add joint text. Add tab_dim(). Handle value labels properly.
7321 Handle DISPLAY LABELS properly. Draw boxes correctly.
7322 (describe_variable) Value labels don't need titles. Don't clear
7323 nonexistent index column.
7324 (compare_vectors_by_name) New function.
7325 (display_vectors) New function.
7327 * tab.c: (tab_height) Add assertion.
7328 (tab_null) Add debug code.
7329 (evaluate_dimensions) Add debug code.
7331 * var.h: (struct variable) get_proc data is sometimes used
7332 simultaneously with other per-procedure info, therefore it was
7333 removed from the union. All references changed.
7335 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
7337 * ascii.c: (ascii_close_page) Put title on second line of headers
7338 if there is no subtitle.
7340 * command.c: (glob var cur_proc) Move definition here, from
7342 (cmd_remark) Emit blank line before remarks.
7344 * command.h: (glob var cur_proc) Move declaration here, from
7347 * data-list.c: (dump_fixed_table) Fix messages.
7348 (dump_free_table) Call tab_nat_dim().
7350 * descript.q: (dump_z_table) Modify tab_dim() call.
7352 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
7354 (dump_statistics) Don't output header.
7356 * groff-font.c: Minor format fix.
7358 * html.c: Comment fix.
7360 * list.q: (write_varname) Indent after advancing page.
7362 * output.h: Minor reordering.
7364 * postscript.c: Comment fixes. Many places, '\n' was replaced by
7365 a reference to eol[].
7366 (struct ps_driver_ext) New member eol[].
7367 (ps_preopen_driver) Initialize eol[].
7368 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
7369 defaults. Handle headers. Fix test for minimum page length.
7370 (static var option_tab[]) Add `line-ends'.
7371 (ps_option) Handle line-ends to change eol[].
7372 (postopen) Scale prop_em_width and fixed_width properly. Set the
7373 prologue title to outp_title if applicable. Replace the prologue
7374 line ends with eol[]. Call draw_headers() if headers are enabled.
7375 (text_width) New function.
7376 (out_text_plain) New function.
7377 (draw_headers) New function.
7379 * print.c: (dump_table) Call tab_nat_dim().
7381 * som.c: (som_blank_line) Only advance a line if not at the top of
7383 (som_submit) Move several informational table calls here.
7384 Increment subtable_num if SOMF_NO_TITLE not set.
7385 (output_table) Advance a line if SOMF_NO_SPACING not set.
7386 (render_columns, render_segments, render_simple) Handle spacing
7387 between tables. Handle table titles. Remove debug output.
7389 * som.h: (SOMF_*) New enum series.
7390 (struct som_table_class) New member `flags'.
7392 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
7394 (display_variables) Calls tab_nat_dim().
7395 (describe_variable) Remove restriction on number of value labels.
7396 Make value labels separated by thin lines.
7398 * tab.c: (tab_create) Default `flags' to none.
7399 (tab_float) New arg `w'. All references changed.
7400 (tab_nat_dim) New function.
7401 (tab_output_text) No title or spacing.
7402 (tab_flags) New function.
7403 (tabi_flags) New function.
7404 (tabi_title) New function.
7405 (strip_height) Removed.
7406 (tabi_render) Skip title when necessary.
7407 (static var tab_tab_class) Add tabi_flags, tabi_title.
7408 (evaluate_dimensions) Disable display of column, row size.
7409 (sum_columns) Add title height to top header.
7410 (render_strip) Moved within file.
7412 * tab.h: (struct tab_table) New member `flags'.
7414 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
7416 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
7418 * Most source files: Add `const' attribute in all appropriate
7421 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
7422 column to the variables table for use by describe_variable().
7423 (cmd_display) Disable for the present.
7424 (display_documents) Don't wrap documents.
7425 (display_variables) Table has four columns now.
7426 (describe_variable) Table has four columns now. Don't use a
7427 subtable, use joined cells instead.
7429 * tab.c: (tab_create) Don't set `join'.
7430 (tab_realloc) ct array is not made up of a_string's.
7431 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
7432 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
7433 (text_format) New function.
7434 (tab_title) Rewritten, uses text_format().
7435 (tab_text) Rewritten, uses text_format().
7436 (tab_joint_text) New function.
7438 (static var hit) New variable.
7439 (render_strip) New args r1, r2. Implement joined cells that fit
7441 (tabi_render) Increment hit. Pass new args to render_strip().
7442 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
7443 cells. For t_naw and t_nah, ignore joined cells and null cells in
7446 * tab.h: (struct tab_join_rect) Removed.
7447 (struct tab_table) Removed `join'.
7448 (TAB_JOIN_MAIN) Removed.
7449 (struct tab_joined_cell) New struct.
7450 (TAT_NOWRAP) New enum.
7452 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
7454 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
7456 (ascii_postopen_driver) Fix initialization of *_spacing so that
7457 the TAL_0 bit doesn't count.
7459 * data-list.c: (dump_fixed_table) Use natural width for Format
7462 * glob.c: (rerange) Removed.
7463 (get_date) Formatting fixes. Internationalization fix.
7465 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
7468 * postscript.c: (ps_postopen_driver) Replace
7469 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
7471 * som.c: (som_submit) Don't eject page before every table.
7472 (output_table) Fix order of arguments on call to area().
7473 (render_columns) Fix calculation of max_len.
7475 * tab.c: (tabi_cumulate) Minor change to increase elegance.
7476 (render_strip) New function.
7477 (strip_height) New function.
7478 (tabi_render) Rewrite as calls to render_strip().
7480 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
7481 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
7482 with the TAB_* and OUTP_T_* constants.
7484 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
7486 * Makefile.am: Formatting fixes.
7488 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
7491 * data-list.c: (dump_fixed_table) Add tab_dim() call.
7493 * descript.q: (dump_z_table, display) Add tab_dim() calls.
7495 * dump-sysfile.c: (glob var length) Make type off_t.
7496 (usage) Fix arguments.
7499 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
7500 Now right-justification is the default so many references had to
7502 (struct outp_class) Removed line_width, all references changed.
7503 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
7504 (struct outp_driver) Add elements horiz_line_width,
7505 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
7508 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
7510 (postopen) Initialize all the informational members of
7513 * som.c: (som_blank_line) New function, renamed from blank_line(),
7514 all references changed.
7515 (som_submit) Disables drivers whose pages can't be opened.
7516 (render_columns, render_simple, render_segments) Add debug output.
7517 (render_columns) Fix loop range.
7518 (render_simple) Don't try to render the headers, they're taken
7519 care of automatically. Advance cp_y past the table when done.
7520 (render_segments) Fix loop ranges.
7522 * tab.c: Initialize new members of tab_table.
7523 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
7524 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
7525 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
7528 (tab_dim) New function.
7529 (tab_col_width) Removed.
7530 (tab_row_height) Removed.
7531 (tab_output_text) Call tab_dim().
7532 (tabi_driver) Call evaluate_dimensions(), sum_columns().
7533 (tabi_area) Implemented.
7534 (tabi_cumulate) Implemented.
7535 (tabi_render) Partially implemented, but broken.
7536 (var tab_table_class) Made static.
7537 (evaluate_dimensions) New function.
7538 (sum_columns) New function.
7540 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
7541 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
7542 t_scr, t_srr, t_sentinel. Removed: t_nat.
7543 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
7544 max_stack_height, w, h. Removed: ce, re.
7545 (macro blank_line) Removed.
7546 (glob var zero_length) Removed.
7548 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
7550 * Most source files: include some of the new include files broken
7553 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
7556 * aggregate.c: (glob var outfile) Make static.
7558 * command.c: (glob var pgm_state) Move here.
7560 * common.c: (glob vars endian, second_lowest_value, pgmname,
7561 finished, curdate, cur_proc, start_interactive, history_file) Move
7564 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
7566 * file-handle.q: (glob vars files, inline_file) Move here.
7568 * glob.c: Lost lots of glob vars, detailed in individual file
7570 (init_glob) set_printer, set_screen were obsolete, deleted.
7571 set_cprompt has fewer spaces because pspp has fewer letters than
7574 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
7575 (inp_nval) Made static.
7577 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
7578 tokstr_len, toklongstr, tokint) Move here.
7580 * misc.c: Lost several vars and functions.
7582 * set.q: (all the set_* variables) Move here.
7584 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
7585 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
7588 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
7590 * tab.h: (enum series t_*) New enums.
7591 (struct tab_table) Use arena struct tag. New members ce, re.
7593 * tokens.h: Comment fixes.
7595 * var.h: Move lots of enums and variables and functions and
7596 structures to other files. Use and declare a lot more union and
7597 struct tags. Comment fixes.
7599 * vector.c: (glob vars vec, nvec) Move here.
7601 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
7602 init_blanks, last_vfm_invocation) Move here.
7604 * cases.h: New file.
7605 (struct long_vec) Move here.
7606 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
7609 * command.h: New file.
7610 (STATE_* enums) Move here.
7611 (glob var pgm_state) Move here.
7613 * format.c: New file.
7614 (glob var formats) Move here.
7615 (parse_format_specifier_name, fmt_to_string,
7616 check_input_specifier, check_output_specifier,
7617 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
7620 * format.h: New file. Move functions now in format.c here.
7621 (FMT_* enums) Move here.
7622 (struct fmt_desc) Move here.
7623 (FCAT_* enums) Move here.
7624 (struct fmt_spec) Move here.
7625 (glob vars formats, fmt_parse_ignore_error) Move here.
7627 * inpt-pgm.h: New file.
7628 (INP_* enums) Move here, make #defines into enums.
7629 (glob vars inp_init, inp_init_size) Move here.
7632 (glob vars v_sort, nv_sort) Move here.
7633 (sort_cases, read_sort_output) Move here.
7635 * vector.h: New file.
7636 (struct vector) Move here, add struct tag.
7637 (glob vars vec, nvec) Move here.
7638 (find_vector) Move here.
7641 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
7642 reinit_blanks, init_zero, init_blanks) Move here.
7643 (struct case_stream) Move here.
7644 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
7645 vfm_disk_stream, sort_stream, data_list_source,
7646 input_program_source, file_type_source, get_source, n_lag) Move
7648 (procedure, write_case, lagged_case, compact_case, page_to_disk)
7651 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
7653 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
7654 (LDADD) Add libdcdflib.
7656 * ascii.c: Comment and formatting fixes. Almost every external
7657 function had an assert added, checking driver_open and page_open.
7658 (ascii_init_driver) Broken into ascii_preopen_driver,
7659 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
7660 (ascii_open_page) Sets page_open.
7661 (ascii_close_page) Clears page_open.
7663 * html.c: Comment and formatting fixes. Almost every external
7664 function had an assert added, checking driver_open and page_open.
7665 (html_init_driver) Broken into html_preopen_driver,
7666 html_postopen_driver, html_close_driver. Manages driver_open.
7667 (html_open_page) Sets page_open.
7668 (html_close_page) Clears page_open.
7669 (html_submit) Disabled.
7671 * lexer.c: (parse_string) Remove debugging printf.
7673 * list.q: (determine_layout) Open a page if one is not yet open.
7675 * output.c: Comment fixes.
7676 (add_class) Set the class member of the new list element.
7677 (parse_options) Don't handle device type.
7678 (colon_tokenize) New function.
7679 (configure_driver) New four-field format with a field for device
7680 type. Now initialize driver_open, page_open, next, and prev
7681 fields. Use new colon_tokenize() function. Don't do a memory
7682 copy to replace a driver, it doesn't work; instead delete the old
7683 driver and insert a new one.
7684 (destroy_driver) Don't call som_destroy_driver(). Close the page
7685 if it's open. Find the class in the list of classes and decrement
7686 that reference count. Remove the driver from the global driver
7688 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
7689 references changed. Rewritten. Don't return a driver that's not
7691 (outp_eject_page) All references to som_internal_eject_page()
7692 changed to use this. Sets cp_x to 0 as well as cp_y.
7694 * output.h: (OUTP_I_* enums) Removed.
7695 (struct som_submission_form) Removed.
7696 (struct outp_class) init_driver broken into preopen_driver,
7697 postopen_driver, and close_driver. submit changed to take a
7700 * postscript.c: Comment and formatting fixes. Almost every
7701 external function had an assert added, checking driver_open and
7703 (ps_init_driver) Broken into ps_preopen_driver,
7704 ps_postopen_driver, ps_close_driver. Manages driver_open.
7705 (ps_open_page) Sets page_open.
7706 (ps_close_page) Clears page_open.
7708 * som.c: New file, base implementation.
7710 * som.h: (struct som_table) Add struct tag.
7711 (enum SOM_COL_ACROSS) Removed.
7712 (SOM_ROWS, SOM_COLUMNS) New enums.
7713 (struct som_table_class) Add member `cumulate'. Remove `segment';
7714 change `render' arguments.
7715 (struct som_point, struct som_rect) Removed.
7716 (som_submit_table) Fixed typo, should have been som_submit.
7718 * sysfile-info: (describe_variable) Don't try to insert a
7719 subtable; just destroy it for now.
7721 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
7722 references to value labels.
7724 * tab.c: (tab_destroy) New function.
7725 (tab_columns) Change argument.
7726 [0] (tab_submit) Remove dead code.
7727 (tab_title) Allocate string from the table's arena.
7728 (tab_output_text) Only free the buffer if we allocated it.
7729 (tab_submit) New function.
7730 (static vars t, d) New static vars.
7731 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
7732 tabi_headers, tabi_cumulate, tabi_render) New functions.
7733 (glob var tab_table_class) New global var.
7735 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
7736 encapsulate the rectangle. All references changed.
7738 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
7740 * All header files updated to use struct tags in addition to
7741 typedefs for all structures. Don't use word `struct' in struct
7744 * Makefile.am: (pspp_SOURCES) Remove html.c.
7745 (INCLUDES) Replace the lib/* includes with a single lib/ include;
7746 all references updated.
7748 * command.c: (parse_cmd) Remove call to som_check_workspace.
7749 (output_line) Update to new som.
7751 * data-in.c: (parse_numeric) A single dot is not an error; it is
7752 the system-missing value.
7754 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
7757 * data-out.c: Added `const' as appropriate to many prototypes.
7758 (convert_E, convert_F, convert_CCx) Take double argument instead
7759 of value * argument.
7760 (convert_format_to_string) Call changed functions appropriately.
7761 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
7762 make a local copy of the value.
7764 * descript.q: Remove custom_variables() prototype now provided by
7766 (custom_variables) Don't increment sbc_variables, the caller does
7768 (dump_z_table, display) Update to new som.
7770 * error.c: (vmsg) Add const to prototype. Remove code to handle
7771 `too many errors' condition.
7772 (check_error_count) New function.
7773 (msg) Add const to prototype.
7775 * filename.c: (open_file) Rewrite for elegance.
7777 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
7778 (dump_full, dump_condensed, dump_statistics) Update for new som.
7780 * list.q: Don't include somP.h. Change all references to
7781 som_driver_ext to refer to the new members of som_driver. Change
7782 som_internal_eject_page() references to outp_eject_page().
7784 * main.c: (parse) Rewrite for elegance. Add call to
7785 check_error_count().
7787 * output.c: (add_class, outp_list_classes, outp_configure_driver)
7788 Rewrite or revise for new outp_driver_class_list structure.
7789 (outp_iterate_enabled_drivers) Fix comparison between disabled
7790 devices and current device type.
7791 (outp_eject_page) New function.
7793 * output.h: Comment fixes.
7794 (struct outp_driver) New members driver_open, page_open, cp_x,
7795 cp_y, font_height, prop_em_width, fixed_width. Deleted members
7797 (struct outp_driver_class_list) New struct.
7798 (outp_class_list) Changed to type outp_driver_class_list; all
7801 * print.c: (dump_table, print_trns_proc) Updated for new som.
7803 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
7804 prototypes for custom subcommands.
7805 (dump_subcommand) Always include the `else'.
7806 (dump_parser) Fix comments in output code.
7808 * set.q: Reordered functions.
7810 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
7812 * som.h: Rewritten from scratch.
7814 * str.h: Remove dead code.
7816 * tab.c, tab.h: New files, base implementation.
7818 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
7821 * t-test.q: New code from John Williams
7822 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
7823 Many many new static vars and defines.
7824 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
7825 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
7826 (struct value_list) New struct.
7827 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
7828 t_crt, t_sig, print_t_groups) New functions.
7829 (cmd_t_test) Implemented.
7831 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
7834 * vfm.c: (dump_splits) Update to new som.
7836 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
7838 * Makefile.am: (fiasco_SOURCES) Add html.c.
7840 * aggregate.c: Base source.
7842 * ascii.c: (postopen, preclose) Reformat.
7844 * data-out.c, expr-evl.c: Comment fixes.
7846 * filename.c: (open_file) When opening a file for writing, use
7847 line buffering instead of full buffering for better interactive
7848 performance. Suggested by Valerio Aimale
7849 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
7850 names `stdin', `stdout', `stderr'.
7852 * groff-font.c: Comment fixes.
7854 * html.c: New file; base version.
7856 * list.q: (write_all_headers, clean_up, determine_layout,
7857 list_cases) Ignore `special' devices for now. Needs to be fixed
7860 * output.c: (outp_init) Add html driver to list; reverse list
7863 * output.h: (struct outp_class_struct) New members `special',
7864 `submit'; comment fixes. All references changed.
7866 * postscript.c: (ps_init_driver) Make defaults for text_opt,
7867 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
7869 (postopen) Comment fix.
7870 (preclose) Comment fixes, formatting fixes. Change x->file.file
7871 references to more proper f->file.
7873 * som-high.c: (som_submit_table) Special classes use their own
7876 * som.h: Comment fixes.
7878 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
7881 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
7883 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
7885 * aggregate.c: Still working on this.
7887 * command.c: (cmd_table[]) Add AGGREGATE back in.
7888 (split_words) Make '-' a legal word separator as well as ' '.
7890 * main.c: Comment fixes.
7892 * q2c.c: (dump_parser) Don't require the procedure's full name to
7893 be present, in the generated source.
7895 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
7896 multiply specified and let it be default; let MISSING, CRITERIA,
7897 FORMAT be multiply specified.
7898 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
7899 (custom_groups) Fix defaults.
7900 (custom_pairs) Check whether this is a PAIRS subcommand before
7901 attempting to parse. Better garbage collection. Proper storage
7903 [DEBUGGING] (debug_print) New function.
7905 * temporary.c: Comment fixes.
7906 (copy_variable) Don't copy variable name and index.
7907 (save_dictionary) Copy variable name and index by hand.
7909 * vars-atr.c: Comment fixes.
7910 (create_variable) New dictionary argument. All references
7912 (common_init_stuff) New dictionary argument. All references
7914 (init_variable) New dictionary argument. All references changed.
7915 (dup_variable) New function.
7917 * vars-prs.c: (parse_variables) If there are any errors, we always
7918 return 0. Previously, it was possible for some types of errors to
7921 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
7923 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
7926 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
7928 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
7931 * q2c.c: Comment fixes.
7932 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
7934 * t-test.q: (cmd_list) Rename cmd_t_test.
7936 * temporary.c: (new_dictionary) Don't declare as static.
7938 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
7940 * aggregate.c: Changes, still not finished.
7942 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
7944 * q2c.c: Comment fixes. Now its output is internationalized.
7945 (get_token) Fix parsing of escapes within literal strings.
7946 (main) Fix bad #line directives in output.
7948 * t-test.q: Base implementation.
7950 * temporary.c: (new_dictionary) New function.
7951 (restore_dictionary) [__CHECKER__] Change fill character to *
7954 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
7956 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
7958 * aggregate.c: Changes, still not finished.
7960 * descript.q, list.q: Comment fixes.
7962 * q2c.c: Almost completely rewritten.
7964 * t-test.q: New file, not complete.
7966 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
7968 * aggregate.c: Changes, still not finished.
7970 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
7973 * temporary.c: (cancel_temporary) New function.
7975 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
7976 of doing it by hand.
7978 * vfm.c: (close_active_file) After restoring a TEMPORARY
7979 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
7981 (SPLIT_FILE_procfunc) Comment fix.
7983 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
7985 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
7987 * aggregate.c: New file, not finished yet.
7989 * command.c: (cmd_table) Add AGGREGATE.
7991 * common.h: (pgm_state) Move declaration to var.h.
7993 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
7995 (parse_string) Message fix.
7997 * recode.c: Comment fix.
7999 * sfm-read.c: (read_variables) Code esthetic fixes.
8000 (write_header) Default date is `Jan', not `JAN'.
8002 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
8004 * sort.c: (cmd_sort_cases) Farm the work out to new function
8005 parse_sort_variables().
8006 (parse_sort_variables) New function.
8007 (sort_cases) New function. Cancels temporary transformations,
8008 which sorting didn't do previously.
8009 (cmd_sort_cases) Better garbage collection on error. Uses
8011 (write_initial_runs, merge_once) Improved code esthetics.
8012 (sort_stream_read) Reduced to one call to read_output_cases().
8013 (read_output_cases) New function.
8015 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
8016 variable labels to 120 characters.
8018 * var.h: Comment fixes.
8019 (glob var pgm_state) From common.h.
8021 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
8023 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
8024 options. Set *names to NULL on error.
8026 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
8028 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
8030 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
8031 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
8033 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
8035 * vfm.c: (page_to_disk) Added missing local variables.
8037 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
8039 * get.c: Comment fix.
8041 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
8042 source is anything other than a disk stream, not just if it's in a
8043 memory stream. Call page_to_disk() before external sort.
8044 (allocate_cases) Message fix.
8046 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
8048 (page_to_disk) New function.
8050 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
8052 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
8054 * common.h: (macro strerror) Remove. From Alexandre Oliva
8055 <oliva@dcc.unicamp.br>.
8057 * get.c: (dict_delete_run) The number of variables to delete is
8058 not necessarily the number of variables that need to be shifted
8060 (trim_dictionary) Don't set *options to 0. Fix bug that caused
8061 too many variables to be deleted.
8063 * postscript.c: Comment fix.
8065 * q2c.c: Include strerror.c. From Alexandre Oliva
8066 <oliva@dcc.unicamp.br>.
8068 * set.q: #undef ON and OFF. From Alexandre Oliva
8069 <oliva@dcc.unicamp.br>.
8071 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
8072 early, otherwise errors cause a bad free().
8074 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
8075 Oliva <oliva@dcc.unicamp.br>.
8077 * temporary.c: (save_dictionary) Don't allocate memory if
8080 * vfm.c: (memory_stream_write) Message fix.
8082 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
8084 * command.c: (static var cmd_table[]) Define REPEATING DATA
8087 * common.h: Added support for broken systems that are missing
8088 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
8090 * Many source files: Replace syntax error messages via msg() with
8091 call to syntax_error().
8093 * data-list.c: (dump_fixed_table) Add support for dumping table
8094 for REPEATING DATA as well as DATA LIST FIXED.
8095 (cmd_repeating_data) Allows and requires `/' between subcommands.
8096 Does proper thing with allowing rpd.starts_end to stay 0. Allows
8097 CONTINUED specifications to be omitted. Forces CONTINUED to be
8098 specified if ID is. Calculates starts_end, cont_end from logical
8099 record length as reported by fhp. Calls dump_fixed_table() if
8100 requested. Fixed length of record copied by memcpy.
8101 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
8103 (realize_value) Returns sensible value for out-of-range variable
8105 (rpd_parse_record) New argument `ofs'. Fixed confusion between
8106 length of occurrences and length of line. Added warning for
8107 fields that exceed the line length. Fixed infinite loop.
8108 (read_one_set_of_repetitions) Numerous minor changes for more
8109 complete SPSS compliance. Message fixes.
8111 * dfm.c: (dfm_close) If the file being closed is the inline file,
8112 read all the remaining data before closing it.
8113 (dfm_get_record) Don't close the file on lossage, as either it
8114 has been closed already or it doesn't belong to us.
8116 * error.c: (puts_stdout) New function.
8117 (vmsg) Use puts_stdout instead of puts.
8119 * file-handle.q: (fh_record_width) New function.
8121 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
8124 (input_program_source_read) Made an old kluge an approved method.
8126 * lexer.c: (syntax_error) New function.
8128 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
8131 * output.c: (oupt_get_paper_size) Message fix.
8133 * q2c.c: Numerous fixes to formatting of generated code made to
8134 conform to GNU coding standards. Uses syntax_error() in generated
8135 code. Other miscellaneous generated message fixes. Added support
8136 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
8137 RAND_MAX, and/or strerror().
8139 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
8141 * data-in.c: Comment fixes.
8143 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
8144 (find_variable_input_spec) New function.
8145 (cmd_repeating_data) Initializes id_spec.
8146 (rpd_parse_record) Implemented.
8147 (read_one_set_of_repetitions) Returns -3 by default in order to
8148 kluge out some potential bugs.
8150 * data-out.c: Comment fixes.
8152 * file-type.c: (internal_cmd_record_type) Message fix.
8154 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
8155 for handling -3 return value.
8157 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
8159 * data-list.c: Comment fixes.
8160 (struct dls_var_spec) Reordered members.
8161 (read_from_data_list_fixed) Restructured.
8162 (struct repeating_data_trns) Reordered members. Renamed `starts'
8163 as `starts_beg', `ends' as `starts_end'.
8164 (cmd_repeating_data) Calculates length of repeated data if
8165 necessary and possible.
8166 (parse_num_or_var) Don't allow string variables.
8167 (realize_value) New function.
8168 (rpd_msg) New function.
8169 (rpd_parse_record) New function. Currently stubbed out.
8170 (read_one_set_of_repetitions) Implemented.
8172 * inpt-pgm.c: (input_program_source_read) Comment fix.
8174 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
8176 * command.c: (cmd_end_repeat_p) Removed.
8177 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
8178 (parse_cmd_name) Removed.
8180 * data-list.c: Comment fixes.
8181 (data_list_pgm) Removed `eof' member.
8182 (static var first) New var.
8183 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
8184 FILE TYPE file inside FILE TYPE structures.
8185 (append_var_spec) Appends to *first, not dls.spec.
8186 (parse_fixed) Message fixes.
8187 (struct rpd_num_or_var) New.
8188 (struct repeating_data_trns) New.
8189 (static var rpd) New.
8190 (cmd_repeating_data) New function.
8191 (parse_num_or_var) New function.
8192 (parse_repeating_data) New function.
8193 (read_one_set_of_repetitions) New function.
8195 * file-type.c: (cmd_file_type) Message fixes. Always
8196 default_handle to FILE TYPE file handle.
8197 (internal_cmd_record_type) Message fixes.
8199 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
8201 * repeat.c: Comment fix. Disable debugging.
8203 * temporary.c: (restore_dictionary) Sets splits to NULL and
8204 n_splits to 0 before destroying the variables because now doing
8205 this tries to remove split variables.
8207 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
8208 destroying the dictionary.
8209 (clear_variable) Removes a variable from splits after destroying
8212 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
8214 * cmdline.c: (set_compat) Removed.
8215 (pick_compat) Removed.
8216 (parse_command_line) Removed -c option.
8217 (pre_syntax_message) Removed -c option.
8218 (usage) Remove compatibility code.
8220 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
8221 (glob var compat) Removed.
8223 * compute.c: (type_check) Fixed messages about type mismatches.
8225 * data-list.c: (cmd_data_list) Removed compatibility code.
8226 (fixed_parse_compatible) Calls convert_negative_to_dash().
8227 Fixed bug where it only set the variable in fx.spec if it created
8228 the variable itself.
8229 (dump_fmt_list) Spelling fix.
8230 (cut_field) Removed compatibility code.
8232 * dfm.c: (cmd_begin_data) Don't require a command terminator on
8235 * expr-evl.c: (evaluate_expression) Implement LAG.
8237 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
8238 (parse_neg) Calls convert_negative_to_dash().
8239 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
8242 * expr.h: (struct expression_struct) Removed member max_lag.
8244 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
8245 (internal_cmd_record_type) Removed special handling to produce
8246 negative numbers from dash tokens.
8248 * getline.c: (static var DO_REPEAT_level) New var.
8249 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
8250 (handle_line_buffer) Copies the line into getl_buf; doesn't call
8251 copy_with_DO_REPEAT_substitutions().
8252 (getl_read_line) Maintains value of getl_mode. Calls
8253 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
8255 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
8257 * getline.h: (getl_mode) New glob var.
8259 * glob.c: Comment fixes.
8260 (init_glob) Restructured. Sets set_seed.
8261 (init_compat_dependent) Removed. All references removed.
8262 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
8263 (__htonl, __htons) Removed. (What were these for?)
8265 * lexer.c: (static var tbl) Dash set to class CNUM.
8266 (make_hexit) New function from data-out.c.
8267 (get_token_representation) Rewritten.
8268 (convert_negative_to_dash) New function.
8269 (lex_init_compat_dependent) Removed.
8270 (yylex) A dash is parsed as part of a number if it is followed by
8271 a digit. The ASCII representation of a number is copied to
8272 tokstr. String parsing farmed out to parse_string(). Comment
8274 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
8276 (preprocess_line) Line processing depends on interactive/batch
8277 mode, not on compatibility mode. Removed PC+ compatibility code.
8279 * loop.c: (loop_3_trns_proc) Comment fix.
8281 * main.c: Remove dead code.
8282 (main) Remove call to init_compat_dependent().
8284 * misc.c: (convert_fmt_ItoO) Make E format conversion more
8287 * print.c: (parse_string_argument) Calls
8288 convert_negative_to_dash().
8289 (fixed_parse_compatible) Calls convert_negative_to_dash().
8291 * repeat.c: (RPT_* defines) Removed.
8292 (struct rpt_numeric) Removed.
8293 (struct repeat_entry) New member type, changed `replacement' from
8295 (clean_up) Deallocation adapted to new repeat_entry.
8296 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
8297 usage. Creates vars for `type' of 1.
8298 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
8299 (store_numeric) Rewritten, new interface.
8300 (parse_numbers) Rewritten.
8301 (parse_strings) Rewritten.
8302 (find_DO_REPEAT_substitution) New function.
8303 (perform_DO_REPEAT_substitutions) New function.
8304 (copy_with_DO_REPEAT_substitutions) Removed.
8305 (debug_print) Rewritten.
8307 * set.q: Comment fix.
8308 (custom_results) Removed compatibility code.
8309 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
8312 * sysfile-info.c: (cmd_display) Removed compatibility code.
8314 * tokens.h: Comment fixes.
8315 (token types enum) Removed `toktype' typedef name for this int
8316 type. Removed SUBST. Restructured.
8318 * vars-atr.c: (discard_variables) Sets n_lag to 0.
8320 * vars-prs.c: Comment fix.
8322 * vfm.c: Comment fixes.
8323 (glob var n_lag) New var.
8324 (static vars lag_count, lag_head, lag_queue) New vars.
8325 (procedure) Removed argument nlag.
8326 (setup_lag) New function.
8327 (close_active_file) Discards lagging state.
8328 (lag_case) New function.
8329 (lagged_case) New function.
8330 (write_case) Lags a case if lagging.
8332 * weight.c: (cmd_weight) Removed compatibility code.
8334 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
8336 * getline.h: (struct getl_script) New members loop_index, macros.
8338 * getline.c: (getl_add_file) Sets first_line field to NULL.
8339 (getl_add_DO_REPEAT_file) New function.
8340 (handle_line_buffer) When the current line's length is negative,
8341 set the filename and line number. Increment line number after
8342 reading line. Pass the line to
8343 copy_with_DO_REPEAT_substitutions() for processing.
8344 (getl_close_file) Free DO REPEAT lines before freeing the
8345 filename, and just set the filename to NULL when doing this,
8346 because otherwise the filename gets freed twice.
8348 * glob.c: (glob var queuing) Removed. All references removed.
8350 * lexer.c: Comment fixes.
8351 (get_token_representation) New function.
8353 * repeat.c: Comment fixes.
8354 (struct repeat_entry) Replaced type and v union members with a
8356 (append_record) New function.
8357 (internal_cmd_do_repeat) Started reforming it for the new
8358 repeat_entry struct. Properly records filename changes in the
8359 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
8360 strncasecmp() result usage. Uses append_record() to simplify.
8361 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
8364 (copy_with_DO_REPEAT_substitutions) Started coding.
8366 [DEBUGGING] (debug_print_lines) New function.
8368 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
8370 * tokens.h: (macro is_id1, is_idn) New macros.
8372 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
8374 * cmdline.c: (static var pre_syntax_message) Changed `win'
8375 compatibility mode to `wnd'.
8377 * data-list.c: (fixed_parse_spss) Renamed
8378 fixed_parse_compatible().
8380 * glob.c: (init_glob) Excise unused code for
8381 program_invocation_short_name.
8383 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
8386 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
8388 * set.q: `win' compatibility renamed `wnd'.
8390 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
8392 * filename.c: [__WIN32__] Change the included Windows header files
8394 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
8395 second character is absolute.
8396 (dirname) Fix logic error. Don't printf() the results.
8397 (prepend_dir) Don't printf() the results.
8399 * getline.c: (handle_line_buffer) New function.
8400 (getl_read_line) Reads line with handle_line_buffer() when
8402 (getl_close_file) Discard line buffer data.
8404 * getline.h: Comment fixes.
8405 (struct getl_line_list) New struct.
8406 (getl_script_struct) Added line buffer members. These are hooks
8407 for use by DO REPEAT to allow it to insert virtual source code
8410 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
8411 Override Borland C++ stupidity that claims Windows has a console
8414 * repeat.c: This is in the process of being restructured from
8415 using a token-buffering approach to the DO REPEAT facility to
8416 using the more flexible approach of a line-buffering approach in
8417 conjunction with the getline module. Comment fixes.
8418 (struct tok_struct) Removed.
8419 (static vars queue_index, queue_head, queue) Removed.
8420 (static vars line_buf_head, line_buf_tail) New vars.
8421 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
8423 (pull_queue, destroy_queue) Removed.
8424 [DEBUGGING] (debug_print_tokens) Removed.
8426 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
8428 * file-handle.q: (prepend_current_directory) New function.
8429 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
8430 current directory before normalizing filename.
8432 * filename.c: (gnu_getcwd) New function.
8433 (absolute_filename_p) New function.
8434 (search_path) New argument, PREPEND. All references changed to
8435 pass NULL except those explicitly mentioned. Uses
8436 absolute_filename_p(). Prepends PREPEND before trying the
8438 (dirname, prepend_dir) New functions.
8440 * getline.c: (getl_get_current_directory) New function.
8441 (getl_include) Passes getl_get_current_directory() as PREPEND arg
8444 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
8446 * In several source files, the term `script' was replaced with
8447 `syntax file' inside error messages. Usage of the term `script'
8448 in the sense of a syntax file is now deprecated.
8450 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
8453 * dump-sysfile.c: (usage) Update message.
8455 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
8457 * getline.h: (glob var getl_include_path) Declare extern.
8459 * list.q: Define EXTERN as extern before #including somP.h.
8461 * var.h: Remove declaration of `disptype' variable.
8463 * vfm.c: (close_active_file) After switching the data sink to a
8464 data source, set vfm_sink to NULL, because it doesn't exist any
8467 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
8469 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
8470 _matherrl() to ignore all math errors.
8472 * sfm-read.c: (read_value_labels) When reading the labels from
8473 disk, read the little parts separately instead of as a struct;
8474 this avoids alignment problems.
8476 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
8477 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
8478 (write_header) Allocates and initializes elem_type.
8479 (sfm_write_case) Uses elem_type to determine how to handle each
8481 (sfm_close) Frees elem_type.
8483 * sfmP.h: Comment fix.
8484 [__BORLANDC__] Uses #pragma -a to adjust structure member
8487 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
8489 * Makefile.am: (fiasco_SOURCES) Remove display.c.
8491 * common.c: Fix typo.
8493 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
8494 sense of the condition.
8496 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
8497 line-continuation backslash.
8499 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
8501 * frequencies.q: (custom_grouped, add_percentile) Don't use a
8502 non-constant expression as an argument to sizeof.
8504 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
8505 undefine gettext macro because that's a conio function.
8507 * hash.h: (hsh_prime_tab declaration) Remove.
8509 * list.q: (write_fallback_headers) Move `leader' allocation out of
8510 main loop. Change to local_alloc() allocation.
8512 * output.h: Formatting fixes. Put __attribute__ in right place on
8513 function prototypes.
8515 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
8516 incorrect `SECOND_LOWEST_VALUE' references to proper
8517 `second_lowest_value'.
8519 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
8520 value. This way 2 out of 3 of the som files define the vars
8521 extern, the correct way, that actually works under BC++.
8522 (som_set_float) Don't use nonconstant initializers for a struct.
8524 * som-high.c: Add the standard alloca() header.
8525 (replicate_table) Add prototype.
8527 Merged DISPLAY routine.
8528 * sysfile-info.c: (AS_*) New enum series.
8529 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
8531 (cmd_display, display_macros, display_documents,
8532 display_variables) Stolen from defunct display.c.
8533 (describe_variable) New function.
8535 * temporary.c: [0] (display_tree) New debug function.
8536 (copy_variable) Performs shallow copy of value labels instead of
8537 deep copy; i.e., just copys the AVL tree and increments the
8540 * val-labs.c: Comment fixes.
8541 (do_value_labels) Optionally skip leading forward slash.
8542 (get_label) Creates only a single value label instead of many
8543 copies of one, and sets the reference count.
8545 * display.c: Removed.
8547 * dump-sysfile.c: New file, not yet complete.
8549 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
8551 For lots of source files I added more verbose_msg's. These aren't
8552 listed below as they have tested as being benign. In some cases
8553 these replaced debug_printf() calls.
8555 * output.c: (outp_read_devices) Message fix.
8557 * postscript.c: (output_encodings) Message fix. Reports errors on
8559 (postopen) Message fix.
8561 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
8563 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
8565 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
8568 * main.c: Remove <malloc.h> #include.
8570 * mis-val.c: (parse_numeric) Set .f member for each missing[]
8571 instead of trying to just set the missing[] itself, which is a
8574 * sfm-read.c: (read_variables) Same.
8576 * str.h: Add memmem() prototype.
8578 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
8580 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
8582 * Makefile.am: (q2c) Don't include any libraries in the link.
8584 * dfm.c: (force_line_buffer_extension) New macro.
8585 (count_tabs) New function.
8586 (tabs_To_spaces) New function.
8587 (read_record) Calls tabs_to_spaces() on the line being processed.
8589 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
8590 have to be compiled twice (once for CC, once for LOCAL_CC).
8592 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
8594 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
8595 (LDADD) Add @INTLLIBS@.
8596 (q2c) Add LIBS, @INTLLIBS@ to link step.
8598 * inpt-pgm.c: Turn off debugging.
8600 * postscript.c: (postopen) Format fix. local_free() blocks
8601 returned by local_alloc(); don't free() them.
8603 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
8605 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
8608 * data-list.c: (read_from_data_list_fixed) Pass proper value for
8609 LEN arg, not simply the full string length.
8611 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
8612 directories before generic temp file directories.
8614 * vfm.c: Disable debugging.
8616 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
8618 * get.c: Comment fix.
8619 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
8621 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
8623 * expr-prs.c: (debug_print_postfix) Conditionally included on
8624 GLOBAL_DEBUGGING. Removed out_header() reference.
8626 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
8628 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
8630 * ascii.c: Removed obsolete ascii_close_page() prototype.
8632 * command.c: (output_line) Comment fix.
8634 * data-in.c: Formatting fix.
8635 (parse_string_as_format) Now the `fc' argument is used only for
8636 the purpose of error messages; it is not an index into the string
8637 passed. All references changed.
8639 * data-list.c: Comment fix.
8640 (cut_field) Comment fix. Now returns the column number of the
8641 position of the field cut out on success.
8642 (parse_field) Added `column' argument. Puts the column numbers in
8644 (read_from_data_list_free, read_from_data_list_list) Record the
8645 column number returned by cut_field(), pass it to parse_field().
8647 * dfm.c: Comment fix.
8649 * do-ifP.h: Comment fix.
8651 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
8652 the SYSMIS function.
8654 * expr.h, exprP.h: Comment fix.
8656 * glob.c: (init_glob) Only calls setlocale() and family if
8659 * hash.h: Comment fix.
8661 * include.c: Comment fix.
8663 * output.c: Comment fix.
8665 * postscript.c: (ps_line_intersection) Simplified assertion.
8667 * repeat.c: Comment fix.
8669 * vars-atr.c: Comment fix.
8671 * vars-prs.c: Comment fix.
8673 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
8674 behavior with usage of postincrement.
8675 (memory_stream_read) Discards cases as it goes.
8677 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
8679 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
8682 * Most source files: Includes debug-print.h, related comment
8685 * cases.c: (alloc_val) Removed complex allocation code. Merely
8686 increments default_dict.nval and returns the former value.
8687 (envector, devector) Removed references to lv member of struct
8690 * common.h: (macro VME) Replaced complex definition with simple
8693 * data-list.c: (cmd_data_list) Sets vfm_source instead of
8694 read_active_file and cancel_input_pgm.
8695 (read_from_data_list, cancel_data_list) Removed.
8696 (data_list_source_read, data_list_source_destroy_source) New
8698 (glob var data_list_source) New var.
8700 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
8701 (cmd_begin_data) Improved criteria for an input program accessing
8702 the inline file. Still not perfect.
8704 * do-if.c: (do_if_trns_proc) Simplified debug output.
8706 * expr-prs.c: Comment fixes.
8707 [DEBUGGING] (debug_print_postfix) Simplified debug output.
8709 * file-handle.q: (fh_close_handle) Simplified debug output.
8711 * file-type.c: Comment fixes.
8712 (cmd_file_type) Sets vfm_source instead of read_active_file and
8714 (cmd_end_file_type) On failure, discards variables in place of
8715 just canceling the input program.
8716 (read_from_file_type) Renamed file_type_source_read.
8717 (cancel_file_type) Renamed file_type_source_destroy_source.
8718 (glob var file_type_source) New var.
8720 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
8721 (cmd_get) Initializes options to GTSV_NONE before passing to
8722 trim_dictionary(). Removed `lv' reference. Sets vfm_source
8723 instead of read_active_file and cancel_input_pgm.
8724 (cmd_save_internal) Initializes options before passing to
8725 trim_dictionary(). Local var `nval' removed.
8726 (dict_delete_run) Comment fixes.
8727 (trim_dictionary) Comment fixes. Disallows scratch variables if
8728 GTSV_OPT_SAVE set in options.
8729 (read_from_get) Renamed get_source_read.
8730 (cancel_get) Renamed get_source_destroy_source.
8731 (glob var get_source) New var.
8733 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
8734 read_active_file and cancel_input_pgm.
8735 (read_from_input_program) Renamed input_program_source_read.
8736 Simplified debug output.
8737 (cancel_input_program) Renamed
8738 input_program_source_destroy_source.
8739 (glob var input_program_source) New var.
8741 * loop.c: (loop_1_trns_proc) Simplified debug output.
8743 * main.c: (dump_token) Made eof output more explicit.
8745 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
8748 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
8749 code for always-memory or always-disk cases. malloc's case-list
8750 based on vfm_source_info.ncases. Explicit support for
8751 memory_stream via memory_source_cases.
8752 (do_external_sort) Sets vfm_source instead of read_active_file and
8754 (allocate_file_handles) The temporary directory permissions are
8755 set to 0700 instead of 0777.
8756 (allocate_cases) Formatting fixes. Simplified debug output.
8757 (output_record) Compacts the case if necessary before writing it
8759 (close_handle, open_handle_w) Simplified debug output.
8760 (write_initial_runs) Destroys vfm_sink, then sets it to
8761 sort_stream. Writes records to memory based on
8762 vfm_sink_info.case_size.
8763 (write_to_sort_cases) Renamed sort_stream_write().
8764 (merge) Simplified error handling. Simplified debug output.
8766 (read_from_external_sort) Renamed sort_stream_read().
8767 Reads records based on vfm_source_info.case_size.
8768 (sort_stream_write) Writes records to memory based on
8769 vfm_sink_info.case_size.
8770 (sort_stream_mode) New function.
8771 (glob var sort_stream) New variable.
8773 * temporary.c: (cmd_temporary) Simplified debug output.
8774 (copy_variable) Removed references to `lv'.
8776 * title.c: (get_title) Simplified debug output.
8778 * var.h: Comment fixes.
8779 (struct get_proc) Removed member `lv'.
8780 (struct variable) Removed member `lv'. Comment fixes.
8781 (glob vars read_active_file, write_active_file, cancel_input_pgm)
8783 (struct case_stream) New.
8785 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
8786 read_active_file references to use vfm_source.
8787 (init_variable, replace_variable) Removed references to `lv'.
8789 * vfm.c: Comment fixes.
8790 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
8792 (static var queue, qh, qt, n_lag) Removed. All references
8794 (glob var compaction_necessary, compaction_nval, compaction_case,
8795 paging) New variables.
8796 (record_case) Removed.
8797 (procedure) Comment fixes. Calls vfm_source->read() instead of
8800 (prepare_for_writing, arrange_compaction, make_temp_case,
8801 vector_initialization, setup_filter) New function.
8802 (open_active_file) Most of the code moved into the abovementioned
8803 new functions. Now sets temp_dict to &default_dict if there is no
8804 temporary dictionary, for convenience. New debug output.
8805 (close_active_file) Deals with changing the sink to the source.
8806 Calls finish_compaction(). Frees compaction_case. Mostly
8808 (glob vars disk_source_file, disk_sink_file) New vars.
8809 (destroy_active_file, read_from_memory) Removed.
8810 (disk_stream_init, disk_stream_read, disk_stream_write,
8811 disk_stream_mode, disk_stream_destroy_source,
8812 disk_stream_destroy_sink) New functions.
8813 (glob var vfm_disk_stream) New var.
8814 (glob vars memory_source_cases, memory_sink_cases,
8815 memory_sink_iter, memory_sink_max_cases) New vars.
8816 (memory_stream_init, memory_stream_read, memory_stream_write,
8817 memory_stream_mode, memory_stream_destroy_source,
8818 memory_stream_destroy_sink) New functions.
8819 (glob var vfm_memory_stream) New var.
8820 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
8821 named `more_cases'. Simplified debug output. Otherwise mostly
8823 (record_case) Moved into the stream drivers. Removed.
8824 (transform) Removed (was dead code).
8825 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
8826 common case that the splits don't change, we don't need to copy
8827 the case into prev_case again--pointless.
8828 (compact_case) New function.
8829 (finish_compaction) New function.
8831 * vfmP.h: Comment fixes.
8832 (DEV_* enum series) Removed.
8833 (struct storage) Renamed `stream_info'. Removed variant record.
8834 Removed `device' member.
8836 * debug-print.h: New file.
8838 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
8840 * autorecode.c: Turned off debugging.
8842 * data-list.c: (destroy_dls) Closes the associated file handle.
8844 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
8845 parse_variables() options.
8847 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
8849 * display.c: (display_variables) Really fixed null cell bug.
8851 * file-handle.q: (fh_close_handle) Changed debugging message.
8853 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
8854 parse_variables() options.
8856 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
8857 (cmd_list) Fails if no variables specified.
8858 (determine_layout) Writes blank lines manually.
8860 * loop.c: (loop_1_trns_proc) Made debugging code only print
8861 messages if debugging.
8863 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
8864 parse_variables() arguments.
8865 (main) Parses optional parenthesized options to varlist
8866 subcommands into sbc->message.
8868 * sfm-read.c: Format fix.
8870 * var.h: (FV_*) New enum series.
8871 (PV_*) New enum PV_NO_SCRATCH.
8873 * vars-prs.c: (find_var) Removed.
8874 (fill_all_vars) Takes FV_* enum instead of boolean third
8875 argument. Rewritten to deal with scratch as well as system
8877 (parse_variables) Error message on scratch variable if
8880 * vfm.c: (static var virt_begin_func) New var.
8881 (procedure) Sets up virt_begin_func.
8882 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
8883 after dump_splits(). For succeeding groups changes, calls
8884 virt_begin_func() instead of begin_func().
8886 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
8888 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
8891 * dfm.c: Added some debugging messages, disabled by default.
8892 (open_file_r) Fixed error message.
8893 (read_record) On eof on inline_file, instead of calling
8894 fh_close_handle(), simply jump to eof label like a normal file.
8897 * display.c: Thin lines between rows for certain kinds of
8898 listing. Fixed `null cell' bug.
8900 * error.c: (failure) Flush stdout, stderr before failing.
8902 * file-handle.q: (fh_close_handle) Added debugging message.
8904 * frequencies.q: (dump_full) Bottom line extends across entire
8905 table width. Changed title formatting.
8906 (dump_condensed) Changed title formatting.
8907 (dump_statistics) Fixed title formatting.
8909 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
8910 Sets default value of set_format.
8912 * list.q: (cmd_list) Calls blank_line() before determine_layout().
8913 Passes write_all_headers() to procedure() as pre-group func.
8914 (write_all_headers) New function.
8915 (determine_layout) Removed calls to write_header().
8916 Calls blank_line() before and after write_fallback_headers().
8918 * recode.c: (recode_trns_free) Only attempts to free head->map if
8921 * sfm-read.c: (read_variables) Allows `#' at beginning of system
8922 file variable names but gives a warning. Sets `left' based on
8923 first character being/not being `#'. On lossage frees dict->var.
8925 * som-high.c: (som_draw_title) Simplified title formatting.
8927 * vfm.c: (dump_splits) Fixed and changed splits formatting.
8929 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
8931 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
8932 beginning. Frees v_src, v_dest on successful exit. Frees
8933 h_trans[*], h_trans on lossage.
8934 (recode) Frees h_trans[*], h_trans.
8936 * dfm.c: (dfm_close) Formatting change.
8937 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
8938 longer allocates its own in inline_file.
8939 (open_file_r) Passes the local dfm_fhuser_ext to
8941 (open_file_w) Message fix.
8942 (read_record) Buffer reallocation strategy changed. Frees
8943 ext->line even in inline_file to prevent leaks.
8944 (dfm_put_record) Fixed bug where `ext' was cached before the file
8945 was opened and thus it would be NULL when the file really was
8947 (cmd_begin_data) Sets up inline_file basics itself, then calls
8948 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
8950 * list.q: (write_line) Formatting fix.
8951 (clean_up) Minor strategy change. Sets proportional font after
8953 (determine_layout) Sets fixed font before writing regular headers,
8954 or after writing fallback headers.
8956 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
8957 and KEEP vars after using them.
8959 * postscript.c: (ps_init_driver) Frees x->family.
8960 (postopen) When loading fonts, free the temporary font name buffer
8962 (ps_text_set_font_by_position) Free temporary font name buffer
8964 (text) Fixed code that calculated `lig' so that `lig' always gets
8965 initialized. Formatting fix.
8967 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
8969 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
8970 cells, not xmalloc(), so that the cells will get destroyed
8973 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
8976 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
8978 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
8981 * dfm.c: Comment fix.
8983 * list.q: Comment fixes. Include somP.h. Removed static vars
8984 table, n_columns, n_rows, part. New struct list_ext. New static
8986 (n_lines_remaining, n_chars_width, write_line) New functions.
8987 (cmd_list, list_cases) Rewritten.
8988 (begin_row, end_row, flush_table) Removed.
8989 (write_header, clean_up, write_varname, write_fallback_headers,
8990 determine_layout) New functions.
8992 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
8994 * output.h: Comment fix.
8996 * postscript.c: Comment fix.
8997 (struct ps_driver_ext) Removed prop_size, fixed_size members;
8998 added font_size. All references changed.
8999 (ps_init_driver) Initializes font_size. Simplified space checking
9001 (static var option_tab[]) Removed prop-size, fixed-size; added
9003 (ps_option) Handles font_size.
9005 * som-high.c: Moved prototypes into somP.h.
9006 (som_init_driver) New function.
9007 (som_submit_table) Moved some code into new function
9009 (build_target) Moved some code into new function
9010 som_internal_eject_page().
9011 (som_eject_page) Uses som_internal_eject_page().
9012 (som_internal_eject_page) New function.
9014 * som-low.c: Moved prototypes into somP.h.
9016 * som.h: Formatting fixes.
9018 * somP.h: (struct som_driver_ext) Removed em_width;
9019 added prop_em_width, fixed_width.
9021 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
9023 * Makefile.am: Added `localedir' definition. Added
9024 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
9026 * ascii.c: (macro draw_line) Fixed capitalization.
9028 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
9029 compute.c, count.c, data-in.c, data-list.c, data-out.c,
9030 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
9031 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
9032 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
9033 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
9034 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
9035 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
9036 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
9037 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
9038 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
9039 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
9040 for internationlization.
9042 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
9044 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
9046 * do-if.c, sort.c, val-labs.c: Comment fixes.
9048 * glob.c: (init_glob) Uncommented, updated i18n support.
9050 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
9051 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
9052 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
9053 the declarations of macros taking arguments a lot nicer.
9055 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
9057 * error.h: Removed CE, CW aliases for SE, SW.
9059 * q2c.c: Removed explicit streq() definition since it's duplicated
9062 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
9063 stats.h, str.h, tokens.h: Made the declarations of macros taking
9064 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
9067 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
9069 * cmdline.c: Comment fixes.
9070 (pick_compat) Changed return type to int. Now, instead of setting
9071 glob var `compat' to the emulation, returns the emulation. All
9073 (parse_command_line) Added terminating null to end of
9074 `long_options' array definition.
9075 (pre_syntax_message) Fixes.
9076 (usage) Shows the default emulation in the syntax message by
9077 calling pick_compat().
9079 * getline.c: (getl_add_include_dir) Separates paths with
9080 PATH_DELIMITER, not DIR_SEPARATOR.
9082 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
9083 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
9085 * output.c: (outp_configure_macro) Make earlier definitions for a
9086 particular key override later ones for the same key.
9088 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
9090 * ascii.c: Comment fixes.
9092 * output.c: (outp_get_paper_size)
9093 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
9095 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
9097 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
9098 <errno.h>. GNU libc 2 enforces this!
9100 * command.c: (parse_cmd) Fixed problem with `else' clause being
9101 paired with wrong `if'. Comment fix.
9103 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
9105 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
9106 blp_getline() to getline().
9108 * output.c: (outp_eval_dimension) Changed the fix from last time;
9109 there was no variable `a'.
9111 * q2c.c: (get_line) Fixed boundary condition overrun bug.
9113 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
9115 * output.c: (outp_evaluate_dimension) Fixed handling of negative
9116 numbers having fractional parts. Added case of a fraction without
9117 a whole-number part.
9119 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
9121 * ascii.c: (ascii_text_get_font_position) Removed.
9123 * expr.h, exprP.h: Disabled debugging.
9125 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
9128 * output.h: (struct outp_class_struct) Removed
9129 text_get_font_position method. All references deleted.
9131 * postscript.c: Big change here. Fontmaps were completely
9132 eliminated because of a change in philosophy. Comment fixes.
9133 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
9135 (struct ps_driver_ext) `position', `fontmap', `prop_name',
9136 `fixed_name' members removed. New members `prop_family',
9137 `fixed_family'. `family' member changed to type char *.
9138 (static var ps_fontmaps) Removed.
9140 (ps_init_driver) Removed obsolete references, updated.
9141 Initializes `translate_x', `translate_y', `scale'. Doesn't read
9142 fontmap, of course. Refers to font names through internal_name
9143 rather than subversive means. Frees proper items.
9144 (static var option_tab[]) Removed `fontmap-file' option; renamed
9145 `fixed-font', `prop-font'.
9146 (ps_option) Corresponds to option_tab[].
9147 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
9148 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
9149 hash_family) Removed.
9150 (postopen) Generates font names from family names. Gets
9151 PostScript font name properly. New prologue file comment `!!!'
9153 (ps_open_page) Adds translate_x, translate_y to BP prologue
9154 function; gives SF argument floating-point format.
9155 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
9156 font name. Doesn't change font family.
9157 (ps_text_set_font_by_position) Generates Groff font name from font
9158 family name instead of through table lookup.
9159 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
9160 all references changed. Reduced to simple string assignment.
9161 (ps_get_font_name) Removed.
9162 (ps_get_font_family) Reduced to string return.
9163 (text) Doesn't save `position' since it no longer exists. Ugly
9164 kluge to save font family--fix soon?
9165 (load_font) Removed PostScript name argument.
9167 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
9169 * postscript.c: Comment fix.
9170 (ps_open_page) Puts scale factor in PostScript output.
9172 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
9174 * Makefile.am: Distcleans q2c.
9176 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
9178 * ascii.c: (delineate) Sets text size even if width is zero.
9180 * command.c: Comment fix.
9181 (static var cmd_table[]) Re-enabled EVALUATE command.
9182 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
9183 of comments in script files. Now more liberal on criteria for
9184 performing a state transition--if *anything* happened correctly,
9185 not just if *everything* happened correctly.
9187 * data-out.c: (convert_F) Comment fix. Why in the fsck does
9188 Checker segfault on formatting large numbers and why in the fsck
9189 hadn't I noticed this before?
9191 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
9193 * list.q: (cmd_list) Commented out the actual output routine
9194 because of various problems. Probably will abandon the idea of
9195 using the general `crushed tables' for the LIST procedure.
9197 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
9198 clearing it. Allocates a new var_by_name dictionary before trying
9199 to add members to it.
9201 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
9202 `sib'. Changed type of `node' argument.
9203 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
9205 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
9206 [DEBUGGING] Only deletes the variable from var_by_name if that var
9209 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
9211 * Makefile.am: Added include files to SOURCES. Added
9212 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
9213 includes rules for q2c. Added `boast' target.
9215 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
9217 * Makefile.am: Maintainer-clean Makefile.in.
9219 * Makefile.am: Fixed redundant EXTRA_DIST line.
9221 * ascii.c: Comment fixes.
9222 (ascii_line_vert) Fixed overly aggressive range check.
9224 * display.c: Removed dead code.
9226 * list.q: Turn debugging on.
9227 (flush_table) New debug code.
9229 * sfm-read.c: (read_value_labels) malloc's the structure before
9230 trying to assign to its members.
9232 * sfm-write.c: Comment fix.
9234 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
9236 (output_table) No arguments anymore--gets them through `som'
9237 global. New debug code. In crushed tables, now sets `htv' as
9238 well as `hv' to avoid bad confusion later.
9239 (dump_crush_page) New debug code.
9241 * som-low.c: (som_dump_crush_page) New debug code.
9243 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
9245 All source files: Broke long lines into multiple lines.
9247 * ascii.c: (ascii_close_page) Uses host_system var in place of
9248 HOST_SYSTEM constant.
9250 * cmdline.c: (var syntax_message[]) Broke into
9251 pre_syntax_message[] and post_syntax_message[].
9252 (usage) Outputs both parts, separated by driver list.
9254 * error.h: Fixed broken formatting.
9256 * expr-opt.c: (str_search, str_rsearch) New functions.
9258 * misc.c: (blp_getdelim) Removed. All references changed to
9260 (str_search, str_rsearch) Removed.
9261 (memrmem) New function.
9263 * misc.h: (blp_getline) Removed. All reference changed to
9268 * filename.c: Includes "stat.h", not <sys/stat.h>.
9269 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
9271 * output.c: (outp_list_classes) Changed output formatting.
9273 * sfm-write.c: (write_header) Uses host_system var instead of
9274 HOST_SYSTEM constant.
9275 (write_rec_7_34) Extracts version numbers from the version string.
9278 * sort.c: Includes "stat.h", not <sys/stat.h>.
9280 * str.c: (strcasecmp) Removed.
9282 * title.c: (cmd_document) Uses host_system var instead of
9283 HOST_SYSTEM constant.
9285 * version.c: Generated on-the-fly by the Makefile instead of being
9288 * str.h: Comment fixes. Doesn't substitute for missing memmove or
9290 [!HAVE_STRNCASECMP] Declares strncasecmp().
9292 * version.h: Removed stray character. Comment fixes.
9293 (vars host_system, build_system) New vars.
9295 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
9297 * Most source files: Changed formatting of copyright notice; fixed
9298 FSF address; reformatted to better conform to GNU standards;
9299 comment fixes. Added markups to prevent GNU indent from messing
9300 up my beautiful formatting :-).
9302 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
9303 that GNU indent markups can be passed through without problems.
9305 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
9307 * get.c: Turned off debugging.
9309 * glob.c: (init_glob) Turned on save-file compression by default.
9311 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
9312 compression than was possible in save files.
9314 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
9316 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
9318 * frequencies.q: Removed Fiasco extensions. Updated calculation
9319 algorithms. Polished output format.
9320 (struct frq_info_struct) Removed members `max_degree', `min_n',
9321 all references removed.
9322 (macro frq_extensions) Removed.
9323 (static vars min_n, max_degree) Removed, all references removed.
9324 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
9325 calculate `min_n', `max_degree'.
9326 (postcalc) Passes new arg to dump_statistics().
9327 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
9329 (dump_condensed) Adds variable name title.
9330 (sum_freqs) Removed.
9331 (calc_stats) Updated calculation algorithm.
9332 (dump_statistics) Removed warning for too-few observations.
9333 Changed table formatting. Adds variable name title if passed new
9336 * output.h: Comment fix.
9338 * recode.c, sample.c, sort.c: Disabled debug code.
9340 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
9341 Improved debug code.
9343 * var.h: (enum series frq_*) Removed Fiasco extensions.
9345 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
9347 * command.c: Added PROCESS IF to command table.
9349 * Lots & lots of places, removed checks for NULLs preceding calls
9350 to free_expression(), which itself checks.
9352 * descript.q: Removed Fiasco extensions. Removed optimizations
9353 for non-weighted active files. Implemented some options.
9354 Finished polishing output format. Comment fixes. Merged
9356 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
9357 max_degree, min_n) Removed.
9358 (macro dsc_extensions) Removed.
9359 (struct dsc_info_struct) Removed `min_n' member, all references
9361 (internal_cmd_descriptives) Removed calculation of min_n,
9362 max_degree. Only deals with one `calc' routine instead of two
9364 (precalc) Eliminated redundancy. Updated for changes to
9365 descriptives_proc structure.
9366 (calc) Moved here from `descript.g'. Rewritten to calculate
9367 statistics via `moments about the mean' rather than by summing,
9368 summing squares, summing cubes, and so on.
9369 (postcalc) Rewritten for new-style statistical calculation.
9370 (display) Removed support for displaying variables across rows.
9371 No longer crushes the descriptives table. Removed ancient code.
9372 Added display of N, by variable and listwise.
9374 * descript.g: Removed; merged into `descript.q'.
9376 * expr-evl.c: (evaluate_expression) Now returns a double. For
9377 numeric results, it returns the result as well as storing it in
9378 the passed `value' structure if non-NULL. For string results it
9379 just returns 0.0 and it must be passed non-NULL. Many references
9380 to this function were optimized by use of this change, especially
9381 but not exclusively in `compute.c'.
9383 * frequencies.g: Comment fix.
9385 * glob.c: (glob var process_if_expr) New global var.
9387 * postscript.c: (static var option_tab[]) Corrected entry for
9389 (postopen) Sets x->size to x->prop_size.
9390 (ps_text_set_font_by_name) Sets font size as well as typeface for
9391 PROP and FIXED fonts.
9393 * sel-if.c: (cmd_process_if) New function.
9395 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
9396 (sfm_write_dictionary) Sets `n_cases' to 0.
9397 (sfm_write_case) Increments `n_cases'.
9398 (sfm_close) Attempts to seek the system file back to the header
9399 and write the number of cases in its proper slot.
9401 * som-frnt.c: (som_insert_table) Masks off expansion options since
9402 only SOPT_X_NORM seems to work sensibly.
9404 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
9405 with a `fixed' value of 2.
9407 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
9409 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
9410 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
9412 * var.h: (enum series dsc_*) Removed Fiasco extensions.
9413 (struct descriptives_proc) Removed `miss_noweight'; new members
9414 `X_bar', `M2', `M3', `M4', `min', `max'.
9416 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
9418 * vfm.c: (close_active_file) Cancels PROCESS IF.
9419 (write_case) Doesn't process cases unselected by PROCESS IF.
9421 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
9423 * glob.c: (glob var err) Removed.
9425 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
9426 doesn't have to take into account number of value labels since
9427 they're in a subtable anyway. Also, doesn't display more than 10
9428 value labels since we can't yet break pages in subtables.
9430 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
9432 * som-frnt.c: (som_change_table_size) Simple change for elegance
9433 that shouldn't change behavior.
9434 (som_set_value) Comment fix.
9436 * som-high.c: (som_submit_table) Message fix.
9438 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
9440 * command.c: Added SYSFILE INFO to command table.
9442 * file-handle.q: (fh_handle_filename) New function.
9444 * get.c: (save_trns_proc) Fixed a bug in padding of output data
9447 * main.c: (parse) New return value for command functions, -3.
9449 * misc.h: Comment fix.
9451 * output.h: Comment fixes.
9452 (macro COMPONENTS) Removed.
9454 * postscript.c: (write_text) Modified literal_chars[] so that `('
9455 and ')' are not written to the output in strings as literals.
9457 * sfm-read.c: (sfm_read_dictionary) New argument.
9458 (read_header) New argument. Sets the information structure's
9459 values from the header information.
9460 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
9461 bizarre Checker problem, I guess.
9462 (read_variables) Proper cleanup on lossage.
9464 * sfm.h: (struct sfm_read_info) New struct for use by
9465 sfm_read_dictionary().
9467 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
9468 currently used just for tables that can be dynamically resized and
9469 thus have to be allocated with arena_malloc() instead of
9470 arena_alloc(). All references changed.
9471 (som_change_table_size) New function.
9472 (som_insert_table) Bugfix: now inserts `cell', not `c'!
9474 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
9475 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
9478 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
9480 (draw_intersection) Now takes an argument specifying the table in
9481 question. All references changed.
9482 (draw_table_cell) New function.
9483 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
9484 (som_get_table_size) Many nice new explanatory comments.
9485 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
9487 * som.h: New enum series SOM_CREATE_* for use as create flags with
9490 * str.h: Moved a comment here from TODO.
9492 * sysfile-info.c: New file. Reference implementation.
9494 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
9496 * command.c: Added RENAME VARIABLES to table of commands.
9498 * data-in.c: (dls_error) Sets `cust_field'.
9499 (parse_N) Message fix.
9500 (parse_day_count) New function.
9501 (to_roman) Never outputs VX as a `short form' of V.
9502 (parse_month) Fixed parsing of Roman numerals.
9503 (parse_trailer) Message fix.
9504 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
9505 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
9506 the date is invalid.
9507 (parse_SDATE) Fixed swapped day, year.
9508 (parse_JDATE) Fixed bug for dates in 1582.
9509 (parse_DTIME) Allows days not between 1 and 31.
9510 (parse_numeric) Makes local copy of f.type for easier usage.
9513 * data-out.c: (convert_F) When outputting as scientific, properly
9514 sets f.type as fp->type.
9515 (insert_commas) Fixed operator precedence problem with setting of
9516 nitems. Changed strcpy to memcpy (no null terminator).
9517 (convert_date) Fixed FMT_JDATE: added 1900 to year.
9518 (convert_CCx) Essentially rewritten, but now it works.
9520 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
9522 (display_documents) Implemented.
9524 * error.c: (glob var cust_field) New var.
9525 (vmsg) Displays cust_field as part of message classes DE and DW.
9527 * formats.c: (debug_print) Fixed to compile under updated
9530 * get.c: (cmd_get, cmd_save_internal) Close file handle on
9533 * misc.c: (parse_format_specifier) Formatting fix.
9535 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
9536 `n_rename' for clarity.
9537 (cmd_modify_vars) Initializes `forward' and `positional' at
9538 appropriate times. Frees lists of vars to rename on failure.
9539 Comment fix. Frees memory on success.
9540 (rearrange_dict) Simplified `for' loop condition.
9542 * rename-vars.c: New file (reference implementation).
9544 * set.q: (internal_cmd_set) Fixed `emu' test condition.
9546 * sfm-read.c: (read_header) File label is created only if file
9547 label in file is not blank.
9548 (read_variables) Initializes `dict' local variable.
9549 (read_documents) Proper behavior on lossage.
9551 * sfm-write.c: (write_header) Doesn't blank out the file label
9552 (why was this here to begin with?!)
9554 * temporary.c: (save_dictionary) File label is copied only if
9555 non-NULL. Doesn't try to xstrdup() dictionary documents.
9556 Adapted so as to not irritate Checker.
9557 (free_dictionary) Only destroys var_by_name if non-NULL.
9559 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
9560 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
9561 lines to the document, indents the document. Also, it works now.
9562 (add_document_line) New function.
9564 * var.h: (struct dictionary) Reordering.
9566 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
9567 bits if it was allocated to begin with.
9569 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
9571 * command.c: Added MODIFY VARS to list of commands.
9573 * configure.in: Updated custom macros for autoconf 2.12. Removed
9574 mmap reference; fixed termcap library reference.
9576 * display.c: (display_variables) Fixed a few bugs although it's
9577 still not well written.
9579 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
9580 (induce_segfault) Calls chkr_disp_call_chain() instead of
9581 inducing an actual SIGSEGV.
9583 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
9584 str_search() and str_rsearch(). Fixed tests for matches on
9585 OP_INDEX and OP_RINDEX.
9587 * filename.c: (good_getcwd) Removed as the new libc for Checker
9588 doesn't contain this bug, apparently.
9590 * misc.c: (str_search, str_rsearch) Changed order of arguments for
9591 consistency with GNU memmem.
9592 (blp_getdelim) Changed `len' from `int' to `size_t'.
9594 * modify-vars.c: Reference implementation.
9596 * som-frnt.c: (zero_length) New global var.
9597 (som_create_table) Message fix.
9599 * som.h: Added gcc attributions to som_set_text(),
9600 som_output_text() prototypes. blank_line() refers to
9601 zero_length[] instead of a literal null string to suppress gcc
9604 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
9605 (allocate_cases) Decrements x_max so the last element of x[] can
9606 be used by the algorithm.
9608 * var.h: Changed minor details of `variable' declaration.
9609 (struct modify_vars_proc) New struct.
9610 (struct variable) Added field p.mfv.
9612 * vars-atr.c: Comment fix.
9614 * vars-prs.c: (fill_all_vars) More optimal implementation.
9616 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
9617 character, which it shouldn't have to do but printf() seems to
9618 read the null byte even though I supply a maximum length...
9620 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
9622 * command.c: Removed command alias X for QUIT.
9623 (parse_cmd) Fixed comment parsing.
9625 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
9627 (read_record) Fixed references to len, size.
9628 (dfm_get_record) Restructured.
9630 * file-handle.h: (struct file_handle) Field `lrecl' now of type
9633 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
9636 * modify-vars.c: New file. Not complete.
9638 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
9641 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
9642 problems caused by int/size_t differences.
9644 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
9647 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
9648 being compared were of equal length.
9650 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
9652 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
9654 * lexer.c: (get_dotted_rest_of_line) New function.
9656 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
9659 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
9660 type 6 records. Frees the dictionary properly.
9661 (read_header) Initializes the dictionary instead of letting
9662 read_variables() do it. Sets the dictionary file label from the
9664 (read_documents) New function.
9666 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
9667 write type 6 record if appropriate.
9668 (write_header) Writes file label from dictionary.
9669 (write_documents) New function.
9671 * temporary.c: (save_dictionary, restore_dictionary,
9672 free_dictionary) Properly handle new fields in dictionary struct.
9674 * title.c: (get_title) Returns after failure().
9675 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
9676 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
9678 * var.h: (struct dictionary) New fields `label', `n_documents',
9681 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
9683 * command.c: Added FILTER to list of commands.
9685 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
9688 * get.c: (cmd_save_internal) Removed weighting code since it's now
9689 handled by sfm-write.c. Properly commented out debug code.
9691 * glob.c: (glob var weighting) Removed.
9693 * sel-if.c: Comment fixes.
9694 (cmd_filter) New function.
9696 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
9697 (sfm_read_dictionary) Sets weighting variable direct in the
9698 created dictionary now. (Apparently we previously didn't support
9700 (read_header) Sets weight_index field in sfm_fhuser_ext from
9701 header read from disk.
9703 * sfm-write.c: (sfm_write_dictionary) Comment fix.
9704 (write_header) Now sets the weighting in the header from the
9705 passed primary dictionary instead of from the sfm_write_info.
9707 * sfm.h: (struct sfm_write_info) Removed field `weight'.
9709 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
9710 broke on boundary conditions.
9712 * var.h: (struct dictionary) New fields `weight_var',
9713 `weight_index', and `filter_var'.
9714 (glob var weighting) Removed. This is now part of struct
9715 dictionary. All references changed; the less mechanical changes
9716 are described above.
9718 * vars-atr.c: (find_dict_variable) New function.
9720 * vfm.c: (static var filter_index) New variable.
9721 (open_active_file) Initializes filter_index from default_dict.
9722 (write_case) Calls proc_func() only if the filter variable is
9723 nonzero; this implements FILTER behavior.
9725 * weight.c: (static var weight_varname) Removed.
9726 (cmd_weight) Modified default_dict instead of glob vars.
9727 (update_weighting) Changed the signature to modify a dictionary
9728 instead of glob vars. Now returns the weighting variable.
9729 (get_weighting_variable) Removed; its function is absorbed by
9731 (stop_weighting) Operates on a dictionary now.
9733 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
9735 * sort.c: Removed debugging info from messages.
9736 (do_external_sort) Cleans up after itself by deleting the
9737 temporary directory on failure. (On success it is deleted by the
9739 (allocate_cases) Removed debug code. Added clean up code.
9740 (output_record) Removed debug code.
9741 (merge) Added code to close all the input files that are currently
9742 open. This is a likely location for bugs, because I'm not sure
9743 about boundary conditions. Removed an unnecesary heap_delete().
9744 (merge_once) Removed input file "optimization" that in fact
9745 screwed up the rest of the code. Message and comment fixes.
9747 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
9749 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
9751 * heap.c: (heap_delete) New argument.
9753 * sort.c: Finished implementation of external sort.
9755 * vfm.c: (read_from_disk) Returns after a disk error.
9757 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
9759 * sort.c: (static var state) Removed.
9760 (static vars max_handles, tmp_basename, tmp_extname,
9761 huffman_queue) New variables.
9762 (do_external_sort) Moved most code to new functions.
9763 Creates huffman_queue.
9764 (allocate_file_handles, allocate_cases) New functions.
9765 (static vars run_no, run_length, file_index, case_count) New
9767 (output_record) Returns success. Now really writes to the output
9769 (begin_run, end_run) New functions.
9770 (write_initial_runs) Returns success. Initializes run_no to -1.
9771 Calls begin_run(), end_run() at appropriate times. Outputs debug
9773 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
9775 (merge) New function.
9777 * heap.c, heap.h: New files. Hopefully in near-final form.
9779 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
9781 * glob.c: Added write_active_file to global vars.
9783 * sort.c: Several new miscellaneous static variables.
9784 (cmd_sort_cases) Big comment fix.
9785 (perform_case_2) Renamed `do_external_sort' and completely
9787 (case_2_proc_func) Removed.
9788 (output_record, write_initial_runs, write_to_sort_cases,
9789 compare_record) New functions.
9791 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
9793 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
9795 * sort.c: (perform_case_2) Changed the method for allocation of
9796 lots of memory--now allocates one case at a time in hopes that
9797 more cases can be allocated with heavily fragmented memory.
9799 * var.h: (write_active_file) New global var.
9801 * vfm.c: (procedure, close_active_file, write_case,
9802 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
9803 arguments to procedure() to be NULL. All references to
9804 procedure() that made use of dummy functions were changed to NULL
9806 (open_active_file) If write_active_file is non-NULL, the output
9807 device becomes DEV_PGM (a new enum).
9808 (close_active_file) Sets write_active_file to NULL.
9809 (read_from_memory) Comment fix.
9810 (record_case) Calls write_active_file() when the output device is
9813 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
9817 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
9818 Fixed checking for duplicate varnames.
9819 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
9821 (autorecode_trns_free) Destroys hash tables for each recoding
9823 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
9825 * command.c: Added SORT CASES to cmd_table.
9826 (null_func, null_int_func) Prototyped.
9828 * descript.g: (calc_weight, calc_noweight) Computes own case
9831 * frequencies.q: (dump_statistics) Fixed problem with
9832 too-few-cases warning message.
9834 * get.c: (cmd_save_internal) Handles weighting properly.
9836 * hash.c: (hsh_dump) Output format changed.
9837 (force_hsh_insert) Actually works now, prototype changed.
9839 * list.q: (static var case_num) New variable.
9840 (cmd_list) Initializes case_num.
9841 (list_cases) Increments case_num.
9843 * var.h: Added definitions for SORT CASES. Comment fixes.
9845 * vfm.c: Some definitions moved to new file vfmP.h. Comment
9846 fixes. `active' renamed vfm_active, `rep' renamed
9847 vfm_replacement, all references changed.
9848 (procedure) The procfunc no longer receives a case number. All
9850 (write_case) Subtle reordering.
9851 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
9854 * weight.c: (get_weighting_variable) New function.
9856 * vfmP.h: New file with definitions from vfm.c.
9858 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
9860 * command.c: (FILE_TYPE_okay) Commented out some tests because
9861 they're clumsy and not yet needed.
9863 * var.h: Most *_trns structures moved to their respective source
9864 files. Some were moved into a new file, do-ifP.h. Comment fixes.
9865 (union any_trns) Changed to a typedef for trns_header.
9866 (struct input_program_pgm) Removed.
9868 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
9869 was allocated in the first place.
9871 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
9873 * autorecode.c: New file.
9875 * command.c: Added AUTORECODE to command table; re-enabled SET.
9877 * data-out.c: (convert_F) Handles infinities and NaNs properly.
9879 * error.c: (vmsg) Comment fixes.
9881 * hash.c: Comment fix.
9882 (hashpjw_d) New function.
9883 (hashpjw) Reimplemented as call to more general function
9885 (internal_comparison_fn) Initializes pointers properly.
9886 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
9887 (force_hsh_insert, force_hsh_find) New debugging wrapper
9890 * main.c: (main) Message fix.
9892 * output.c: (outp_read_devices) Message fix.
9894 * set.q: Comment fixes.
9895 (custom_results) Implemented Wnd/X form of subcommand.
9896 (set_routing) New function.
9897 (internal_cmd_set) Implemented ERRORS, MESSAGES.
9899 * settings.h: (SET_ROUTE_*) New enum series.
9900 (set_results) Renamed set_results_file, all references changed.
9901 (set_messages) Removed.
9902 (glob vars set_errors, set_messages, set_results) New vars.
9904 * title.c: (get_title) Remembers to xstrdup() the result of
9907 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
9909 (union any_trns) New element `arc'.
9911 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
9913 * command.c: (output_line) Removed references to set_screen.
9915 * error.c: (static var terminating) New var.
9916 (hcf) Sets terminating to 1.
9917 (vmsg) If terminating is nonzero, does not attempt to call hcf().
9918 This prevents an infinite loop if an error occurs within hcf().
9920 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
9921 statement circumlocution with `case 42000' trick.
9922 (evaluate_expression) New support for OP_STR_MIS.
9924 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
9925 statement circumlocution with `case 42000' trick.
9926 (dump_node) Handles OP_STR_MIS.
9928 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
9929 variables exceptions.
9930 (parse_function) Message fix.
9931 (ops[]) Added OP_STR_MIS.
9933 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
9935 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
9937 * glob.c: Removed set_scrnfile glob var.
9938 (init_glob) set_errorbreak set to 0 by default.
9940 * groff-font.c: Changed included files.
9941 (groff_read_font) Initializes font_arena local var correctly.
9942 (default_font) New function.
9944 * output.c: Comment fixes.
9945 (glob var disabled_devices) New variable.
9946 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
9948 [GLOBAL_DEBUGGING] (reentrancy) New function.
9949 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
9950 outp_iterate_enabled_drivers) Calls to reentrancy().
9951 (destroy_list) New function.
9952 (outp_done) Moved code to destroy_list().
9953 (parse_options) Parses `listing', `screen', `printer' options
9955 (configure_driver) Sets new `device' member of driver.
9956 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
9958 * output.h: Comment fixes. New enum series OUTP_DEV_*.
9959 (struct outp_driver_struct) New member `device'.
9961 * postscript.c: (find_encoding_file) Doesn't display its own error
9963 (default_encoding) New function.
9964 (switch_font) Calls default_encoding() if no encoding can be
9966 (text) Makes up a character metric if none exists for the desired
9968 (load_font) Properly copies a fallback filename. Calls
9969 default_font() for a font if none at all are known.
9971 * set.q: Comment fixes. Removed OUTPUT subcommand.
9972 (custom_listing) Calls outp_enable_device() to enable/disable
9974 (turn_screen_on) Removed.
9975 (internal_cmd_set) Calls outp_enable_device() to enable/disable
9976 screen, printer devices.
9978 * settings.h: Comment fixes.
9979 (glob vars set_output, set_printer, set_screen, set_scrnfile)
9982 * som-high.c: (som_submit_table, som_eject_page) Use
9983 outp_iterate_enabled_drivers() instead of iterating
9984 outp_driver_list directly.
9986 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
9988 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
9989 (parse_string_as_format) Handles new formats.
9990 (parse_numeric) Now handles DOT and PCT formats.
9992 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
9994 (convert_date) Handle EDATE and SDATE formats.
9995 (convert_CCx) Now if there's not room for the currency characters,
9996 converts it as F format if it's positive instead of giving up
9997 quickly. Also fixed save-and-restore bug with decimal point
9999 (convert_format_to_string) Handles new formats.
10001 * misc.c: (formats[]) Added new formats.
10002 (convert_fmt_ItoO) Supports new formats.
10004 * sfm-read.c: (parse_format_spec) Supports new formats. Better
10005 data checking. New argument, all references changed.
10007 * sfm-write.c: (write_format_spec) Supports new formats.
10009 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
10012 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
10014 * cmdline.c: Comment fixes.
10015 (parse_command_line) Changed return type to void.
10017 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
10019 (parse_numeric) Handles international numbers (comma as decimal
10020 point). Some reformatting.
10022 * data-list.c: (parse_free) Default output format is now
10023 set_format instead of hard-coded F8.2.
10024 (read_from_data_list_list) Emits error message on undefined data
10025 only if set_undefined is nonzero.
10027 * data-out.c: (convert_E) Changes decimal point from period to
10028 comma if appropriate. Restructured. Better comments.
10029 (convert_F) Changes decimal point from period to comma if
10031 (insert_commas) Major bug with handling of negative values fixed.
10032 Also, inserts periods instead of commas if appropriate.
10033 (convert_CCx) New function.
10034 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
10035 (num_to_string) Changed `.' to set_decimal.
10037 * dfm.c: Comment fixes.
10038 (dfm_close) Frees ext->line even in inline_file.
10039 (open_inline_file) New function.
10040 (open_file_r) When opening the inline file: now properly
10041 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
10043 (read_record) Calls fh_close_handle() instead of dfm_close() to
10044 close the inline file. Makes a copy of the line getl_buf to avoid
10045 interlock problems.
10046 (dfm_get_record) Restructured. Now checks the return value of
10048 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
10049 checking for use of inline file. No longer tries to close inline
10052 * error.c: (glob var error_already_flagged) New var.
10053 (vmsg) Message change. Now checks max number of errors/warnings,
10056 * file-handle.q: (fh_handle_name) Now allows closing of
10058 (fh_init_files) Reformatted.
10060 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
10062 * getline.c: (getl_include) Fixed bug that popped up when called
10063 when file queue was empty.
10064 (read_console) Resets error_count, warning_count,
10065 error_already_flagged to zero.
10067 * glob.c: Many changes to update list of variables.
10068 (init_compat_dependent) Now this function is called whenever
10069 `compat' changes. It now sets set_seed only if it hasn't
10070 previously been referenced. It now calls
10071 lex_init_compat_dependent().
10073 * include.c: (cmd_include_at) Frees temporary buffer instead of
10075 (cmd_include) Doesn't make copy of include file name.
10077 * lexer.c: Comment fixes.
10078 (init_lex) Moved some code into new function
10079 lex_init_compat_dependent().
10080 (lex_init_compat_dependent) New function.
10081 (hex_val) Simplified.
10082 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
10084 * main.c: Comment fixes.
10085 (main) Reformatted.
10087 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
10088 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
10089 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
10090 (setup_randomize) Sets set_seed_used.
10092 * set.q: Comment fixes.
10093 (custom_results) Conditionalizes on `compat'.
10094 (custom_log) Calls custom_journal().
10095 (set_ccx) New function.
10096 (cmd_set) Calls init_compat_dependent() when `compat' changes.
10097 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
10098 when set_decimal changes. Range-checks values for MITERATE,
10099 MNEST. Message fixes.
10101 * settings.h: Comment fixes.
10102 (struct set_cust_currency) New struct.
10103 (set_cc[], set_grouping, set_seed_used) New global vars.
10105 * var.h: (FMT_CCA...FMT_CCE) New output formats.
10106 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
10108 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
10110 * glob.c: Revised variables to correspond to settings.h.
10111 (init_glob) Initializes variables from settings.h properly.
10113 * set.q: Began long-overdue major revision to correspond to new
10114 philosophy. Most code changed.
10116 * settings.h: Mostly changed; reorganized, reordered, large new
10119 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
10121 * get.c: (cmd_save_internal) No longer forces compression off.
10123 * sfm-read.c: (read_compressed_data) If eof is reached when
10124 reading a new instruction octet, only signal error if we're in the
10127 * sfm-write.c: (COMPRESSION_BIAS) New #define.
10128 (struct sfm_fhuser_ext) New member `end'.
10129 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
10130 (ensure_buf_space) New function.
10131 (sfm_write_case) Reimplemented in order to support compression.
10132 (sfm_close) Writes out the remaining contents of the compression
10135 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
10137 * command.c: Defined SAVE and XSAVE commands in command table.
10139 * common.h: second_lowest_value is of type flt64, not double.
10141 * file-handle.h: Comment fix.
10143 * get.c: Comment fixes.
10144 (static var `trns') New.
10145 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
10146 cmd_save_internal, cmd_save, cmd_xsave) New functions.
10147 (dict_delete_run) Clears the variables and frees them now.
10148 (trim_dictionary) Sets default for compression.
10149 On KEEP subcommand, frees deleted variables as well as clearing
10150 them. Finally got the sense of the test for deleting all
10152 [DEBUGGING] (dump_dict_variables) Message fix.
10154 * glob.c: (init_glob) set_compression set to 1 by default.
10156 * list.q: Properly #includes config.h.
10158 * misc.h: New macro REM_RND_UP.
10160 * settings.h: Comment fix.
10162 * sfm-read.c: (structs sysfile_header, sysfile_format,
10163 sysfile_variable; inline function bswap_int32) Moved to new file
10165 (corrupt_msg) [__CHECKER__] No longer induces segfault.
10166 (sfm_read_dictionary) Fixed bug caused by failing to initialize
10168 (read_machine_flt64_info) Fixed some problems caused by confusion
10169 between flt64 and double types.
10170 (read_header) Message fix.
10171 (read_variables) Fixed set of cases in which we byte-swap sv.print
10172 and sv.write. Fixed confusion of flt64 and double.
10174 * sfm.h: (struct sfm_write_info) New.
10176 * som-high.c: (som_draw_title) Properly frees `s'.
10178 * temporary.c: (save_dictionary) Comment fix.
10180 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
10181 (struct trns_header) Formatting fix.
10182 (struct save_trns) New.
10184 * vars-atr.c: (discard_variables) Comment fix.
10186 * sfm-write.c: New file, baseline release.
10188 * sfmP.h: New file, baseline release.
10190 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
10192 * cmdline.c: (parse_command_line) `--version' output updated.
10193 (glob var syntax_message[]) Added my e-mail address.
10195 * file-handle.q, lexer.c, vfm.c: Changed many instances of
10196 `illegal' to `invalid'.
10198 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
10199 uncompression buffer.
10200 (sfm_close) Frees decompression buffer.
10201 (sfm_read_dictionary) Initializes decompression buffer.
10202 (buffer_input, read_compressed_data) New functions.
10203 (sfm_read_case) Restructured; now calls read_compressed_data() to
10204 handle compressed system file data.
10206 * var.h: Comment fix.
10208 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
10210 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
10213 * get.c: New comments. New static var `get_file'.
10214 (cmd_get) Now fully implemented. Calls discard_variables();
10215 initializes fv and lv for all variables; new debug code; sets
10216 up the dictionary; sets up the input program.
10217 (read_from_get, cancel_get) New functions.
10219 * sfm-read.c: Comment fixes.
10220 (sfm_close) New static function.
10221 (sfm_read_dictionary) Properly sets up the class of the
10222 file_handle. No longer cares what size the data is in records of
10223 type 7. Also, on failure, properly cleans up the file_handle and
10224 free()s some stuff.
10225 (read_variables) No longer thinks it knows `nval' of the
10226 dictionary. Now sets p.get.fv, etc., instead of speculatively
10228 (read_value_labels) Fixed off-by-one error in indexing of
10230 (sfm_read_case) New function.
10231 (sfm_r_class) New static var.
10233 * var.h: (get_proc) New struct.
10234 (struct variable) New member p.get.
10236 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
10238 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
10239 the manual's meaning.
10240 (rename_variables) New function.
10241 (trim_variables) Doesn't try to parse MAP any more. Removed debug
10242 code. Now properly reorders the dictionary on the KEEP keyword.
10244 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
10245 garbage collection.
10247 * vars-atr.c: (clear_variable) New argument `dictionary *'.
10248 (rename_variable) New function.
10249 (free_val_lab) Reformatted.
10251 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
10253 * var.h: Reindented entire file. Comment fixes.
10254 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
10256 (glob var default_dict) New.
10257 (struct indirect_dictionary) Removed.
10259 * Many other source files were changed to add `default_dict.'
10260 before all references to the dictionary of the active file.
10262 * vars-atr.c: (make_indirect_dictionary) Removed.
10264 * glob.c: Reindented all variable declarations. Updated for
10265 changed var.h. Comment fixes.
10267 * temporary.c: (restore_dictionary, save_dictionary) Simplified
10268 because now we can mainly copy dictionary structs.
10270 * vars-prs.c: (is_dict_varname, parse_dict_variable,
10271 parse_variables) Takes dictionary instead of indirect_dictionary
10273 (parse_variables) Instead of calling make_indirect_dictionary,
10274 just sets DICT to &default_dict if DICT is NULL. Of course, lots
10275 of `*dict.' references had to be changed to `dict->'. Removed
10278 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
10280 * get.c: Added GTSV_OPT_* series of enums.
10281 (trim_dictionary, dict_delete_run) New functions.
10282 [DEBUGGING] (dump_dict_variables) New function.
10283 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
10284 [DEBUGGING] Calls dump_dict_variables() to display results.
10286 * glob.c: (cmp_variable) Now a public function declared in var.h.
10288 * sfm-read.c: Turned off debug code. Comment fixes.
10289 (read_machine_int32_info, read_machine_flt64_info) New functions
10290 to parse type 7 records.
10291 (sfm_read_dictionary) Properly byteswaps several fields now.
10292 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
10293 records. [DEBUGGING] Dumps dictionary.
10294 (read_variables) Sets `index' field of variables created properly.
10295 Constructs avl tree of variables in dictionary. [DEBUGGING] No
10296 longer dumps dictionary.
10297 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
10299 [DEBUGGING] (dump_dictionary) No longer stubbed out.
10301 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
10302 var before destroying any variables just to save a little time.
10304 * var.h: (struct variable) Reordered in order to make name[] the
10305 first member; this makes pointers to `variable' pointers to the
10306 variable name, simplifying avl trees, etc.
10307 (struct indirect_dictionary) New struct.
10309 * vars-atr.c: (find_variable) Rewritten for efficiency.
10310 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
10312 (is_varname) Rewritten for efficiency.
10313 (parse_variables) New argument, which is a `dictionary *'. All
10314 references changed. This function now reads variable names from
10315 the dictionary passed, or from the default dictionary if NULL.
10317 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
10319 * misc.h: Added new macro DIV_RND_UP to perform integer division,
10320 rounding up. Changed many references to ROUND_UP to use this
10323 * sfm-read.c: Includes avl.h.
10324 (corrupt_msg) Induces a segfault under Checker.
10325 (macro assertive_bufread) New. Many references to bufread() now
10327 (sfm_read_dictionary) Split up into several functions. Added code
10328 to read dictionary records following the the type 2 records. Not
10329 quite complete. New variable `var_by_index'.
10330 (read_header, read_variables) New functions extracted from
10331 sfm_read_dictionary().
10332 (read_value_labels) New function.
10333 (bufread) Checks ferror() if fread() doesn't return the expected
10334 value; if ferror() is zero it's just EOF.
10335 (dump_dictionary) Stubbed out.
10337 * BTW: The source code now exceeds 50000 lines!
10339 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
10341 * command.c: Added GET to cmd_table[].
10343 * list.q: Removed reference to alloca headers.
10344 (cmd_list) Gave prototype.
10346 * sfm-read.c: Added DEBUGGING comments.
10347 (sfm_read_dictionary) Checks bias correctly. Sets
10348 dict->var_by_name to NULL. Calculates long_string_count
10349 correctly. realloc's dict->var[] array to minimum size.
10350 [DEBUGGING] Calls dump_dictionary.
10351 [DEBUGGING] (dump_dictionary) New function.
10353 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
10354 (restore_dictionary) If the dictionary contains a non-NULL
10355 var_by_name, uses that instead of generating one.
10356 (free_dictionary) Destroys var_by_name.
10358 * var.h: (struct dictionary) Added field `var_by_name'.
10360 * get.c: New file, not complete.
10362 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
10364 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
10365 (parse_num_or_range) New function.
10366 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
10367 <n> THRU HIGH missing values.
10369 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
10370 __attribute__((const)).
10372 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
10374 * sfm-read.c: Finished reference implementation.
10376 * sfm.h: Includes var.h.
10378 * var.h: Comment fixes.
10379 (struct `variable') Reordered some fields.
10381 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
10382 constants added previously.
10384 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
10386 * common.h: Comment fixes. Added declaration of
10387 `second_lowest_value' as variable or macro. Made `compat_type',
10388 `pgm_state_type' into anonymous enums.
10390 * display.c: Comment fix.
10392 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
10394 [!defined SECOND_LOWEST_VALUE] Added definition for
10395 `second_lowest_value' global var.
10396 (compat, pgm_state global vars) Changed types to `int'.
10397 (init_glob) Initializes `second_lowest_value'.
10399 * sfm-read.c: Continued work, not complete.
10401 * var.h: Added new MISSING_* constants to handle LOWEST and
10404 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
10406 * sfm-read.c: New file, not complete.
10408 * cases.c: (vec_insert) Changed vector expansion algorithm.
10409 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
10410 mucking up the RECODE transformation in particular.
10411 (envector) Harmless change in notation.
10413 dfm is now fairly well tested again.
10414 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
10416 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
10418 * recode.c: Comment fix.
10420 * sfm.h: Interface should be fairly final now, or at least for a
10423 * vfm.c: [DEBUGGING] (index_to_varname) New function.
10424 (open_active_file) [DEBUGGING] Translates ccase indices into
10425 variable names now to make it easier to understand what's really
10428 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
10430 * data-in.c: Comment fix.
10432 * data-list.c: Includes dfm.h.
10433 (do_reading) Uses new function dfm_push_cust().
10435 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
10436 `return 1;' at end.
10438 * file-handle.h: Completely changed. Some parts split off into
10439 new file dfm.h. Implemented in file-handle.q.
10440 (enum FH_*) Removed.
10441 (struct fh_ext_class) New struct.
10442 (struct file_handle) Retained only these fields: name, norm_fn,
10443 fn, recform, lrecl, mode. New fields class, ext.
10444 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
10445 close_handle, handle_name) Added `fh_' prefix to name, all
10446 references changed.
10448 * dfm.h: New file, implemented in dfm.c.
10449 (get_record, put_record, fwd_record, bkwd_record, set_record,
10450 get_cur_col) Functions moved from file-handle.h, now prefixed with
10452 (dfm_push_cust) New function.
10454 * sfm.h: New file. Incomplete.
10456 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
10457 interface. Functions reordered, comments changed. Not well
10458 tested, probably full of bugs.
10459 (struct dfm_fhuser_ext) New struct.
10460 (dfm_close) New function.
10461 (open_file_r) Pickier about finding `BEGIN DATA.' line.
10462 (open_file_w) User messages changed.
10463 (get_record) Comment fixed.
10464 (read_record) Increments ext->ln even for inline_file. Calls
10465 dfm_close() for inline_file when `END DATA.' encountered.
10466 (dfm_get_record) Experimental restructuring.
10467 (dfm_push_cust) New function.
10468 (cmd_begin_data) Detects whether the inline file was fully read by
10469 checking whether it is still open; detects whether it was read at
10470 all by checking whether the line number is greater than zero.
10472 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
10473 interface. Functions reordered, comments changed. Not well
10474 tested, probably full of bugs.
10475 (init_file_handle) Removed initializers for obsolete fields, added
10477 (fh_close_handle) Much simpler, now mainly calls the class
10479 (fh_init_files) Renamed inline file internal filename.
10481 * file-type.c: Includes dfm.h.
10482 (read_from_file_type) Doesn't use dfm internal state anymore.
10484 * inpt-pgm.c, print.c: Include dfm.h.
10486 * recode.c: (internal_cmd_recode) Casts strlen() return value to
10487 int in comparison with other int.
10489 * som-high.c: (build_target) Fixed operator precedence problem in
10490 if statement (& versus ==).
10492 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
10494 * dfm.c: (read_record) Can now read fixed-length records; not
10496 (put_record) Can now write fixed-length records; not tested.
10498 * file-handle.h: FH_* defines changed to enums. New enum series
10500 (struct file_handle) New members recform, lrecl, mode.
10502 * file-handle.q: Parser changed.
10503 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
10504 /LRECL subcommands. These are compatible with Windows.
10505 (init_file_handle) Initializes recform, mode fields.
10507 * q2c.c: (get_line) When outputting `!' comment lines, now
10508 increments the output file line number so that `#line' directives
10510 (make_identifier) New function that converts an arbitrary string
10511 into a valid C identifier.
10512 (dump_vars) Calls make_identifier() in two places in order to
10513 suppress some errors for bad identifiers.
10514 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
10515 for NO. Allows numbers to be prefixed by underscores to make them
10516 acceptable C identifiers but still to be parsed as numbers by the
10519 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
10521 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
10523 * dfm.c: Comment fixes. (get_record) Gives error if file handle
10524 was opened for writing.
10525 (open_file_w) New function.
10526 (read_record) Uses strncasecmp if available. Improved error
10527 messages, comments.
10528 (put_record) New function.
10530 * file-handle.h: Moved function comments into dfm.c and
10531 file-handle.q. Comment fixes. Removed declarations of
10532 tilde_expand() and normalize_filename().
10533 (struct file_handle) Changed `open' from boolean to enumerated
10534 field to allow for three states--closed, open for reading, open
10535 for writing--all references changed.
10537 * file-handle.q: Includes filename.h.
10539 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
10540 references changed.
10541 (alloc_line) Makes allowance for line terminator characters in
10543 (print_trns_proc) Now handles OUTFILE, WRITE differences.
10544 (print_space_trns_proc) Handles OUTFILE differences.
10546 * recode.c, sample.c: Comment fixes.
10548 * var.h: (struct print_trns) Changed boolean field `eject' to
10549 bitmapped field `options'; all references changed. New enums
10550 PRT_* for use with this field.
10552 * exception.h, test-exception.c: Removed.
10554 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
10556 * ascii.c: (delineate) Turned off debug output.
10558 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
10561 * data-in.c: (parse_string_as_format) Sets the entire string value
10562 to spaces, not just the short string part of it. Is this correct
10565 * data-out.c: (convert_date) Fixed DATETIME format problems with
10566 decimal places, removed debug code.
10568 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
10569 middle of parsing BEGIN DATA that would cause the lexer to read
10570 from a wild pointer `prog'; now calls new function
10571 preprocess_line() in lexer.c.
10573 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
10575 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
10576 Now call induce_segfault() to induce the segfault.
10577 (induce_segfault) New function.
10579 * expr-opt.c: Comment fix.
10580 (parse_sysvar) New function.
10581 (parse_primary) Added system variable support--calls
10583 (global var ops) Added OP_CASENUM operator.
10585 * expr.h: Comment fixes.
10586 (OP_* enum) added OP_CASENUM operator.
10587 (struct casenum_node) New struct.
10588 (union any_union_union) New member `cas' of type `casenum_node'.
10590 * glob.c: (global var last_vfm_invocation) New var.
10591 (init_glob) Initializes last_vfm_invocation.
10593 * lexer.c: (lookahead) Fixed reversed condition on if statement.
10595 * getline.c: (get_line) Split into get_line() and preprocess_line().
10596 (preprocess_line) New function.
10598 * var.h: Declares last_vfm_invocation.
10600 * vfm.c: (procedure) Sets last_vfm_invocation.
10602 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
10604 * command.c: (parse_cmd) Fixed bad assertion related to
10607 * data-in.c: (parse_month) Implemented to parse months according
10608 to full interpretation of standard.
10609 (to_roman) New function.
10610 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
10611 (parse_weekday) Bug fix (forgot to skip all the day name).
10613 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
10614 up parsing of multirecord data items. Also fixed user message.
10616 * data-out.c: Comment fix.
10617 (year2, year4, convert_date, convert_time, convert_WKDAY,
10618 convert_MONTH) New functions to support time & date output.
10619 (convert_format_to_string) Calls new time & date output routines.
10621 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
10623 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
10626 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
10628 * misc.c: (global var formats) Fixed declarations of DATETIME,
10631 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
10632 the output_char buffer.
10634 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
10635 memory bug. Fixed user messages.
10637 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
10639 * Removed #pragma argsused from lots of places.
10641 * data-in.c: Implemented zoned decimal and time-date formats.
10642 Untested. This is a huge chunk of code--maybe 1000 lines and 50
10645 * data-out.c: Implemented zoned decimal format.
10647 * expr.h: Moved yrmoda() declaration here from exprP.h.
10649 * misc.c: (global var formats) Minor fixes--added
10650 FCAT_SHIFT_DECIMAL to formats N and Z.
10651 (convert_fmt_ItoO) Added support for format Z.
10653 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
10655 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
10657 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
10658 som_check_workspace() that is activated between commands.
10660 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
10663 * list.q: (begin_row) Changed title expansion style from
10664 SOPT_X_VERT to SOPT_X_SHSP.
10666 * som-frnt.c: Now includes `somP.h'.
10667 (som_push_workspace, som_pop_workspace) New functions that, taken
10668 together, form a solution to the recursive table building problem
10669 mentioned yesterday. Surrounded every table output routine
10670 throughout the program with calls to these functions.
10671 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
10672 (som_create_table) Checks that there's an active workspace.
10673 (som_destroy_all_tables, som_crush) Removed.
10675 * som-high.c: (global var som_preserve_tables) Removed, all
10676 references deleted.
10677 (som_submit_table) Checks that there's an active workspace.
10678 (dump_columnated_table) Doesn't columnate tables that would have
10679 just one row per column.
10680 (dump_crush_page, som_dump_crush_page) Removed debugging code.
10681 (som_dump_crush_page) Moved row number labels from left side of
10682 tables to right side.
10683 (som_get_table_size) Added support for SOPT_X_SHSP.
10685 * som.h: New cell expansion type SOPT_X_SHSP.
10687 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
10689 (global var curtab_arena) Moved from som-frnt.c.
10691 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
10693 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
10694 that causes bad location warnings to be suppressed.
10695 (delineate) Saves current font when calling draw_text(); fixed
10696 handling of NULLs when backing up. Also fixed line-wrapping bug.
10698 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
10699 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
10701 * common.c: Added code to cause assertion failure to dump core
10702 when run under Checker.
10704 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
10705 there are still bugs.
10707 * glob.c: (__eprintf) Removed.
10709 * list.q: Inserted som_preserve_tables kluge that prevents tables
10710 from being thrown away due to recursive table building through
10711 som_output_line being called from a transformation during the LIST
10712 procedure invocation. This is a general problem that must be
10713 solved in a better way since it applies to all procedures in
10715 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
10716 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
10718 * numeric.c: Fixed several errors in the form of msg() calls.
10720 * print.c: Updated for use of som.
10721 (dump_table) Reimplemented.
10722 (print_trns_proc) Calls som_eject_page() instead of eject_page().
10723 Calls som_output_text() instead of outs_line().
10725 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
10727 (som_output_text) Function moved from som-low.c. Interface
10730 * som-high.c: (som_preserve_tables) New global public variable
10732 (som_submit_table) Destroys the tables only if som_preserve_tables
10734 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
10735 one subrow per row. Now labels subrows if there's more than one
10737 (dump_crush_table) Added wishlist comment.
10738 (som_eject_page) New public function declared in som.h.
10740 * som-low.c: (som_dump_crush_page) Draws row labels if there's
10741 more than one subrow per row.
10742 (som_output_text) Moved to som-frnt.c.
10744 * som.h: (SOM_TOPT_PRESERVE) Removed.
10746 * title.c: (get_title) Changed interface.
10747 (cmd_title) Changed `title' to `outp_title'.
10748 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
10750 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
10752 * list.q: (flush_table) Conforms to new partial options in
10753 som_submission_form.
10755 * som-high.c: (paginate_horizontally) Changed form of subrow
10757 (build_target) Omits spacing before table if
10758 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
10759 (dump_crush_page) Changed interface. Only trims bottom rule if
10760 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
10761 (dump_crush_table) Handles partial tables.
10762 (output_row_label) New function.
10763 (som_dump_crush_page) Emits subrow number labels. Draws vertical
10764 rule on the right edge of narrow subrows.
10766 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
10767 constants to a series of SOM_TOPT_PARTIAL_* submission options.
10768 All references updated.
10770 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
10772 * misc.c: Comment fix.
10774 * som-high.c: (examine_table) Treats crushed tables separates for
10775 purpose of determining header size.
10776 (paginate_horizontally) Allots space for line numbers in crushed
10777 tables with lots of subrows per row. Calculates the `maximum page
10778 width', the width of the widest horizontal page.
10779 (build_target) Removed trim argument; all references changed.
10780 Stricter assertions. (dump_crush_page) New function.
10781 (dump_crush_table) Reimplemented.
10783 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
10784 (som_dump_crush_page) Reimplemented, interface changed.
10786 * somP.h: Many many new helper macros for use with crushed tables.
10787 (global var som) Removed `tv', `cum_y' members; all references
10788 removed. New members `mpw', `digit_space'.
10790 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
10792 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
10793 variable, changed to constant 1024.
10794 (arena_ca_strdup) Changed `sizeof(a_string)' to
10795 `sizeof(c_string)'.
10796 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
10797 `(c_string *)' to `(char *)'; this fixed some offset problems.
10799 * filename.c: (readlink_malloc) Changed initial allocation from
10801 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
10804 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
10805 &fm->owner in several places.
10807 * som-high.c: (output_table) Changed interface to rest of world.
10808 (examine_crush_table) Removed. Crushed tables are re-broken now,
10809 in preparation for rewrite.
10811 * som.h: Comment fix.
10813 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
10815 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
10816 itself in the cleanup stage.
10818 * descript.q: (display) At least temporarily, changed the table
10819 format to a crushed table.
10821 * list.q: (begin_row) At least temporarily, added horizontal lines
10824 * som-high.c: (examine_crush_table) Sets som.hh to the width of
10825 the horizontal "headers," that is, to the width of the far left
10826 and far right rules.
10827 (justify_pagination) Sets som.th to the width of the widest row
10828 in the crushed table. Fixed inner loop off-by-one error.
10830 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
10833 * somP.h: Comment fix.
10835 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
10837 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
10838 before closing it; also, opens the constructed filename `s'
10839 instead of f->filename.
10841 * postscript.c: Moved initialization of x->loaded, x->prop,
10842 x->fixed, x->current, also the add_encoding() calls, into
10844 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
10845 sets x->last_font to NULL; sets x->next_combo to zero.
10847 * som-high.c: (crushed_row_height) Moved definition farther up.
10848 (som_submit_table) Doesn't calculate line width, font size until
10849 after calling open_page(), to accomodate changes to PostScript
10851 (vert_headers) Removed; equivalent functionality moved to
10852 examine_table(), examine_crush_table().
10853 (justify_pagination) Replaced with different algorithm.
10854 (dump_crush_table) Bugfix that caused tables to fail to be clipped
10855 at the bottom of the page.
10857 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
10859 * command.c: Added cmd_list back into cmd_table.
10861 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
10862 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
10864 * list.q: (flush_table) Updated to new som_submission_form format.
10866 * som-frnt.c: Comment fix.
10868 * som-high.c: Changed `#endif' to `#undef EXTERN'.
10869 (output_table) Calls som_get_table_size() directly; handles
10871 (examine_crush_table) New function; calls vert_headers().
10872 (examine_table) Moved some code into new function, vert_headers().
10873 (justify_pagination) New function.
10874 (dump_plain_table) Removed `static' from `cy'.
10875 (dump_crush_table) New function.
10877 * som-low.c: (som_dump_crush_page) New function.
10879 * som.h: Comment fixes.
10880 (enum SOM_TOPT_CRUSH) New.
10881 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
10882 Temporarily set to zero to make do with LIST procedure.
10884 * somP.h: Re-ordering.
10886 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
10888 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
10890 * somP.h: New file for use by som-high.c, som-low.c.
10892 * q2c.c: Added definition for VME.
10893 (get_line) Now dumps `!' comment lines to the output file
10896 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
10897 set.q: Changed format of `!' comment lines.
10899 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
10901 * All source files: Added copyright notice.
10903 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
10904 longs in msg() calls.
10906 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
10908 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
10910 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
10912 * output.c: (outp_read_devices) Changed criteria for
10913 distinguishing different types of lines.
10915 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
10917 * cmdline.c: Changed syntax message.
10919 * filename.c: (good_getcwd) Bug fix (?).
10920 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
10922 (search_path) Appends DIR_SEPARATOR to directory name only if it
10923 does not already end with one.
10925 * glob.c: Checks STAT_PAGER envvar before PAGER.
10927 * output.c: Checks environment variables instead of just local
10930 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
10932 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
10933 when the pointer passed to the function was within the arena
10934 itself, so that it couldn't properly be set to NULL _after the
10937 * command.c: Re-enabled DISPLAY.
10939 * display.c: Rewritten to handle tables. Untested.
10941 * filename.c: (search_path) Fixed memory leak.
10943 * frequencies.q: (cmd_frequencies) Frees v_variables.
10944 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
10945 (cleanup_freq_tab) New function to garbage collect.
10946 (dump_full) Elegantized.
10948 * main.c: New comment.
10950 * output.h: New tag for tagged quotes: TAG_NEWLINE.
10952 * postscript.c: Comment fix.
10953 (release_fontmap, free_font_entry) New functions.
10954 (ps_init_driver) Sets free_font_entry() as the freefunc for
10955 hashtable `loaded'. Calls release_fontmap() when destroying a
10956 driver; also frees the output filename; also frees the
10957 ps_driver_ext block.
10958 (free_ps_encoding) Frees the filename as well as the encoding
10960 (output_encodings) Frees the line buffer and pops the msg-filename
10962 (read_fontmap) Frees the fontmap filename and the line buffer.
10963 (postopen, preclose) Misc. garbage collection fixes.
10964 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
10965 to NULL; this fixes some output problems.
10966 (text) Handles TAG_NEWLINE. Untested.
10968 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
10969 (som_set_string) Removed. All references changed to
10971 (som_set_text) Rewritten. New interface. More general.
10973 * som.h: Minor format changes.
10974 (struct som_value_cell) Removed; all references changed to
10976 (enums SOT_*) Changed.
10978 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
10980 * command.c: Re-enabled SPLIT FILE.
10982 * postscript.c: Comment fix.
10984 * som.h: Added `SOT_NONE'.
10986 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
10988 * vfm.c: (dump_splits) Reimplemented.
10990 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
10992 * Compiled the project under gcc 2.7.2, which gave some new
10993 warnings. This led to many additions of casts from unsigned to
10994 int sprinkled throughout the code.
10996 * arena.c: Many uses of `unsigned' changed to `size_t'.
10998 * command.c: Added END FILE, END REPEAT to command table.
10999 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
11000 (find_command, FILE_TYPE_okay) Not commented out anymore.
11001 (parse_cmd) Calls FILE_TYPE_okay again.
11002 (output_line) Added calls to som_output_text() to put the line
11003 in the output files.
11005 * common.c: (macro VME) Format changes.
11006 (xstrdup) Asserts that its argument is not NULL.
11008 * data-list.c: Implemented dump_fixed_table().
11010 * inpt-pgm.c: Formatting changes. Comment changes.
11011 (end_case_proc) Renamed end_case_trns_proc.
11012 (cmd_end_file, end_file_trns_proc) New functions.
11014 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
11016 * misc.h: (local_strdup) New macro corresponding to strdup() but
11017 allocating its data through local_alloc() if possible--that is, if
11020 * postscript.c: Comment changes.
11021 (quote_ps_name, quote_ps_string, output_encodings) New functions.
11022 (output_line, add_string) New macros supporting
11023 output_encodings().
11024 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
11025 substitution vars. Calls output_encodings() when a line
11026 consisting of `!encodings' is encountered.
11027 (preclose) Some code moved into quote_ps_string().
11028 (dump_line) Changed into macro supporting dump_fancy_line().
11029 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
11030 command when appropriate.
11031 (write_text) Fixed `literal_char' array (I think it's fixed, at
11033 (text) Fixed bug when width was zero. Now exits immediately on
11034 zero height_left. Now, when executing `goto restart;', checks
11035 that cp<end, so that we don't read beyond end-of-string. Also,
11036 outputs the correct code to the output file by outputting the code
11037 from the metric instead of the internal metric index.
11039 * repeat.c: (cmd_end_repeat) New function.
11041 * som.c: (var som) `headers' renamed `options' and semantics
11042 changed. All references changed.
11043 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
11044 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
11046 (som_text_table) Removed.
11047 (som_output_text) New function.
11049 * som.h: (struct som_submission_form) Removed `header', `reuse',
11050 replaced with bitmapped field `options'.
11051 (SOM_TOPT_*) New enum set for som_submission_form.options.
11052 (SOT_*) New enum set for som_output_text().
11054 * temporary.c: (copy_variable) When copying the var label, only
11055 calls xstrdup() if it's non-NULL.
11057 * var.h: (enum type `vartype') Removed; all references changed to
11060 * vars-atr.c: (init_variable) Changed local var `nbytes' from
11063 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
11065 * font.h: Comment changes.
11067 * groff-font.c: (groff_read_font) Initializes `name' field to
11068 NULL. Handles `encoding' field.
11070 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
11072 * postscript.c: (struct font_entry) Removed `position' field.
11073 (struct ps_font_combo) New struct.
11074 (struct ps_driver_ext) Removed field `next_position'. New fields
11075 `combos', `next_combo'. `last_font' field changed from
11076 `font_entry *' to `ps_font_combo *'.
11077 (ps_init_driver) Reformatted; handles new fields. When
11078 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
11080 (get_encoding, find_encoding_file) New functions.
11081 (add_encoding) Some code moved out into find_encoding_file().
11082 (postopen) Changed value for ${title}.
11083 (preclose) Sets `loaded' field to NULL after destroying the hash
11085 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
11087 (ps_text_set_font_by_position) Figures out the current family if
11089 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
11090 (switch_font) Implemented.
11091 (write_text) Calls switch_font() more often. Format changes.
11092 #undefs its macros after they're no longer useful.
11093 (text) Changed `continue' at one point to a jump to the top of the
11094 loop because we don't want `separate' reset to 0 at that point.
11095 (load_font) No longer sets `position' in the font_entry created.
11097 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
11099 * font.h: (struct font_desc) New member `encoding', which is not
11100 properly handled yet.
11102 * glob.c: (init_glob) Some new i18n code, which is probably
11105 * output.c: (outp_read_devices, outp_get_paper_size) Changed
11106 `size' local from `int' to `size_t'.
11108 * postscript.c: New driver configuration parameter `auto-encode'.
11109 New enums OPO_AUTO_ENCODE, ODA_COUNT.
11110 (struct font_entry) New member `position'.
11111 (struct ps_driver_ext) Reordered. New hash table member
11112 `encodings'; new members `next_position', `next_encoding',
11113 `last_font'. Members `current', `prop', `fixed' changed from type
11114 `font_desc *' to `font_entry *'; all references changed.
11115 (struct ps_encoding) New struct.
11116 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
11117 free_ps_encoding, add_encoding) New functions.
11118 (ps_init_driver) Added OPO_AUTO_ENCODE to default
11119 x->output_options. Initializes new members of ps_driver_ext.
11120 Changed default value for prologue_fn, encoding_fn. Calls
11121 read_ps_encodings after loading default fonts.
11122 (option_tab[], ps_option) Handle new configuration parameter.
11123 (switch_font) New function.
11124 (struct output_char) `font' member changed from `font_desc *' to
11125 `font_entry *'. New member `separate'.
11126 (read_fontmap) Changed `size' from `int' to `size_t'.
11127 (output_line, put_number) New macros for write_text().
11128 (write_text) Optimizes text output by consolidating multiple
11129 calls to PostScript `show' operator.
11130 (text) Keeps track of when text arguments can't be consolidated by
11131 write_text(), and marks those spots in the output stream.
11132 (load_font) Sets `position' of the allocated font_entry to -1, cuz
11133 the font hasn't been switched to by switch_font(), which is where
11134 the position is important--the PostScript is what cares about the
11137 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
11139 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
11140 call a NULL free_func.
11141 (hsh_rehash) Elegantized.
11142 (hsh_probe) Fix bug that manifested when the table was expanded
11143 and thus had to change location in memory. Good thing
11144 too--otherwise could have been much more subtle.
11145 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
11146 (hsh_foreach) New function for hash table iteration.
11148 * hash.h: (struct hsh_iterator) New.
11150 * lexer.c: (parse_tagged_quote) Font and family name strings in
11151 tags are now null-terminated.
11153 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
11155 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
11156 documented. (Never before tested?)
11158 * output.h: Comment changes.
11160 * postscript.c: New driver options `optimize-text-size',
11161 `optimize-line-size', `max-fonts-simult'. New enum set for
11162 specing cached line types. Comment fixes.
11163 (struct line_form) New struct.
11164 (struct ps_driver_struct) New members `text_opt', `line_opt',
11165 `max_fonts', `lines'.
11166 (ps_init_driver) Initializes new members of ps_driver_struct.
11167 (user option type enum set) New member `nonneg_int_arg'.
11168 (static var option_tab[]) Supports new options.
11169 (ps_option) Handles new options.
11170 (find_ps_file) Made static. No longer calls hsh_dump().
11171 (ps_get_var) Made static.
11172 (preclose) Dumps out proper DSC trailer.
11173 (ps_open_page) Elegantized.
11174 (ps_close_page) Calls dump_lines() if appropriate.
11175 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
11176 wrappers around line().
11177 (int_2_compare, compare_line, dump_line, dump_fancy_line,
11178 dump_lines, hash_line, free_line, line) New functions for support
11180 (write_text, text) Made static.
11181 (text) Added to font support, not finished.
11183 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
11185 * font.h: (struct font_desc) New members ascent, descent.
11187 * groff-font.c: (groff_read_font) Calculates font ascent and
11188 descent from the ascent and descent of the `d' and `p' characters,
11189 respectively, as per a suggestion on comp.fonts.
11191 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
11192 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
11194 (write_text) Handles text right-justification and centering (not
11195 full justification). Still very inefficient. (One output line
11197 (struct output_char) Added fields for font and font size.
11198 (text) Many bugfixes.
11200 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
11202 * cmdline.c: (usage) Calls outp_list_classes().
11204 * font.h: Comment fix.
11206 * groff-font.c: New exported global var `space_index'.
11207 (groff_init) New function to initialize `space_index'.
11208 (hash_kern) Casts result to unsigned.
11209 (font_name_to_index) Renamed font_char_name_to_index. All
11210 references changed. Also, now returns the value of `space_index'
11211 when passed an ASCII space character as an argument. Fixed
11213 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
11214 Handles passed NULL pointers properly.
11216 * lexer.c: (parse_tagged_quote) Comment fix. Better range
11219 * output.c: (outp_list_drivers) Removed. Removed all references.
11221 * output.h: Comment fixes.
11223 * postscript.c: (ps_open_global) Calls groff_init().
11224 (output_char) New structure.
11225 (write_text) New function.
11226 (text) No longer stubbed out! Now the output is correct--with a
11227 few exceptions, one of them being that the page has to be held
11228 upside down into a mirror.
11230 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
11232 * font.h: Comment fix.
11234 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
11235 All callers changed.
11236 (number_to_index) Renamed font_number_to_index, made extern. All
11238 (font_get_kern_adjust, font_get_char_metrics) New functions.
11240 * output.h: New constant OUTP_T_INTERNAL_DRAW.
11242 * postscript.c: Changed default line width back to 1/2 point.
11243 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
11244 in the center of the space allotted for them, not just a fixed
11245 offset from the edge of the space; this fixes some bugs.
11246 (ps_line_intersection) Now supports all command line styles.
11247 (ps_text_get_size) Bug fix in computation of em width.
11248 (text) New function, the meat behind ps_text_metrics and
11249 ps_text_draw. Not complete.
11250 (ps_text_metrics, ps_text_draw) Removed the stub taken from
11251 ascii.c; call text().
11253 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
11255 * arena.c: (arena_free) Assert that the argument is non-NULL.
11257 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
11258 only if old_kern is non-NULL.
11260 * postscript.c: (ps_init_driver) Changed default line width to 1
11262 (postopen) New prologue variables.
11263 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
11264 more of the common line styles properly, but not all.
11265 (ps_text_metrics) Fixed problem with this stubbed out version that
11266 kept it from taking font sizes into account.
11268 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
11270 * arena.c: (arena_malloc) Bug fix.
11271 (arena_dump) [GLOBAL_DEBUGGING] New function.
11273 * ascii.c: Comment fix.
11274 (count_fancy_chars, delineate) Now static functions.
11276 * filename.c: (interp_vars) Bug fixes.
11278 * font.h: Comment fixes.
11280 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
11281 beginning in case we have an error message to display before
11282 initializing the display.
11284 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
11286 (groff_read_font) Bug fixes.
11287 (name_to_index) Increments hash.used. Sets `name' field of hash
11289 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
11291 * hash.c: Return type changed.
11293 * postscript.c: Continued development. Now marks lines on the
11294 paper, but very buggy.
11296 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
11298 * Changed comments in many source files from `/* xxx /* yyy */' to
11299 `/* xxx */ /* yyy */' for cleanliness.
11301 * arena.c: (arena_sd_strdup) New function.
11303 * ascii.c: (struct ascii_driver_ext) New member `file'.
11304 (ascii_init_driver) Fills out member `file' for initing; uses
11305 close_file_ext for closing drivers.
11306 (ascii_option) Changed %.*s back to %s because the a_string's are
11307 always null-terminated.
11308 (postopen, preclose) New functions.
11309 (ascii_open_page) Uses new style of open_file_ext.
11310 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
11311 instead of this->output.
11312 (__assert_fail) Removed.
11314 * cmdline.c: Changed syntax_message[].
11316 * error.c: #include's <readline/history.h> only if the history
11317 library is available, not if just the readline library is
11320 * filename.c: (expand_line) Removed alloca() support.
11321 (interp_vars) No longer tilde-expands argument. Limit on output
11323 (tilde_expand) Now treats argument as path rather than filename.
11324 [!unix] Now is a no-op function.
11325 (search_path) Better verbose message formatting.
11326 (open_file, close_file) Comment fixes.
11327 (close_file) [!unix] Doesn't bother with pipes.
11328 (open_file_ext) Completely rewritten, interface revamped.
11329 (close_file_ext) New function.
11331 * font.h: Comment changes.
11333 * frequencies.q: Removed AIX alloca support since it doesn't use
11336 * hash.c: Comment changes & additions.
11337 (hsh_create) Initializes entire table instead of first M entries.
11338 (hsh_probe) Stupid bug fixed. Now it works.
11339 (hsh_dump) [GLOBAL_DEBUGGING] New function.
11341 * main.c: (parse) Detects EOF properly in token-eating loop.
11342 Should the STOP token have its value changed to 0?
11344 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
11345 (blp_getline) Now it's a macro.
11347 * output.h: (struct outp_driver) Removed members output, filename.
11349 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
11350 drivers in driver table.
11351 (outp_read_devices) Frees buf. Warns if there are no active
11353 (outp_configure_clear) Sets outp_configure_vec to NULL after
11354 deleting its elements.
11355 (configure_driver, destroy_driver) Removed references to output,
11356 filename members of outp_driver.
11357 (outp_evaluate_dimension, internal_get_paper_size,
11358 outp_get_paper_size) New functions.
11360 * postscript.c: Continued development. Now links but doesn't make
11361 any marks on the page. Lotsa bugs I suppose.
11363 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
11365 * str.h: Comment changes.
11367 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
11369 * Removed dependencies on non-nested comments in several files.
11370 Also removed references to (unix || __unix__) in #if's since
11371 prefh.orig makes those two equivalent.
11373 * ascii.c: (ascii_open_global) Creates ascii_arena.
11374 (ascii_close_global) Destroys ascii_arena.
11375 (ascii_init_driver) Doesn't create ascii_arena.
11376 (ascii_copy_driver) Removed.
11377 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
11378 (outp_class ascii_class) Removed ascii_copy_driver reference.
11380 * frequencies.q: Now can display all statistics except median.
11381 Still not finished.
11383 * output.c: Handles outp_class.ref_count so output class
11384 destructors are called properly.
11385 (add_class) Sets ref_count to 0.
11386 (configure_driver) Initializes class if ref_count++ is 0.
11387 (destroy_driver) Destructs class if --ref_count is 0. Frees the
11388 class output file name.
11390 * output.h: (struct outp_class) Removed copy_driver, inited.
11393 * postscript.c: Completely replaced but not finished.
11395 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
11397 * approx.h: #includes <float.h>.
11399 * arena.h, arena.c: Many functions changed to take an arena **
11400 instead of an arena *, for consistency. All callers changed.
11401 (arena_alloc) Now creates a new arena if passed *A that is NULL.
11402 (arena_destroy) Sets *A to NULL.
11404 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
11405 assertion that `width' be positive.
11407 * command.c: Removed #if's from cmd_table.
11408 (walk_cmdtable_func) [0] New function (debug code).
11409 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
11410 (parse_cmd) Doesn't return failure for unimplemented commands.
11412 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
11413 (SYSCODE) New constant macro.
11415 * descript.q: Checks for positive n_variables before performing
11418 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
11419 avl_find instead of &fp as arg 2.
11421 * frequencies.g, frequencies.q: Continued updating; now compiles &
11422 works again, but not complete.
11424 * main.c: Changes to user messages.
11426 * misc.c: (reverse) [0] New function.
11428 * settings.h: Comment removed. #includes "common.h".
11430 * som.c: (som_set_null) New function.
11431 (som_set_value, som_set_string, som_set_text) More detailing
11433 (som_set_float) Implemented function.
11434 (dump_columnated_table) Bug fix regarding page breaks.
11435 (draw_cell) Bug fix regarding text that spilled out of a cell.
11436 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
11438 (get_cell_size) Support SCON_EMPTY cells.
11439 (get_table_size) When calculating rules' widths and heights, mask
11440 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
11442 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
11444 (struct som_submission_form) New member `header'; all users
11447 * val-labs.c: (get_label) User messages changed.
11449 * var.h: Changed FREQUENCIES structures.
11451 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
11454 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
11456 * approx.h: Definition of EPSILON now depends on system's
11457 DBL_EPSILON. Removed GNU C specific code.
11458 (cmpapx) Renamed approx_compare.
11460 * frequencies.g, frequencies.q: Continued updating; still doesn't
11463 * groff-font.c: (name_to_index) Fix bug that kept it from
11466 * hash.c, hash.h: Completed work.
11468 * var.h: Changes to freq_tab, frequencies_proc.
11470 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
11473 * hash.c, hash.h: New files. Not completed.
11474 * Makefile.am: Added hash.c to source file list.
11475 * font.h: (struct font_desc) New member kern_size_p.
11476 * groff-font.c: Uses hash.h.
11477 (hashpjw) Moved to hash.c.
11478 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
11480 (static var hash) New member size_p.
11481 * var.h: Includes hash.h.
11482 (struct freq_tab) Changed AVL_TREE to hash_tab.
11484 * vars-prs.c: Comment, formatting fixes.
11486 * frequencies.g, frequencies.q: Continued updating. Not yet
11489 * formats.c: Bug fix.
11491 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
11493 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
11494 * descript.g: Comment fixes.
11495 * descript.q: Comment fixes. Moved some declarations into var.h.
11496 Made dsc_info a static table. Updated FIXMEs.
11497 (internal_cmd_descriptives) Beautified.
11499 * frequencies.q: Started updating into working order.
11500 * frequencies.g: New file analogous to descript.g.
11501 * var.h: Comment fixes. Added structures for FREQUENCIES.
11503 * som.c: Removed vestiges of crushing and partial table support.
11505 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
11507 * Many more changes to som.c especially, but these will not be
11508 documented as I have resolved to remove them. This patchlevel is
11509 being released solely so that I can fall back to it if I decide
11510 that removing the changes is not a good idea.
11512 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
11514 * som.c: (global var som) New member `cum_y'.
11515 (build_target) Properly handles titles for partial tables.
11516 (dump_partial_beg, dump_partial_mid, dump_partial_end)
11517 Merged into single new function dump_partial(). Fixed problem
11518 with titles on partial tables.
11519 (dump_table) Calls dump_partial() for all parts of partial tables.
11520 (dump_page) Criteria for drawing title changed.
11522 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
11524 * command.c: (cmd_table) Added LIST, WEIGHT.
11526 * command.c: (cmd_remark) No longer frees `s' since it's not
11527 dynamically allocated.
11529 * data-out.c: (convert_f) Now correctly handles the case where
11530 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
11531 number of decimals.
11532 (som_destroy_all_tables) Removed argument. All callers changed.
11533 (som_vline, som_hline) Argument validity checking corrected.
11534 (som_set_value) Implemented half-heartedly.
11535 (replicate_table) Copies tables piece-by-piece when using Checker.
11537 * som.h: New line style SLIN_1THIN, currently equivalent to
11538 SLIN_0. New enum set SOM_SUB_*.
11539 (struct som_submission_form) Removed `seq_no'. Added `type'.
11541 * list.q: Newly working file; uses partial tables.
11543 * som.c: (som_reduce_table) Renamed som_set_table_height().
11544 (som_crush) Removed argument `group'.
11545 (global var som) Removed `nt', `seq_no'. Added `type'.
11546 (som_submit_table) Arguments changed.
11547 (output_table) Removed partial table code.
11548 (build_target) New arg; partial table support added. All callers
11550 (dump_plain_table) Removed partial table code.
11551 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
11552 (dump_table) Supports partial tables.
11553 (dump_page) New argument to allow not drawing top and/or bottom
11554 headers. All callers changed. Supports partial tables.
11556 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
11558 * data-out.c: Changed `#include <approx.h>' to `#include
11560 (convert_F) Comment fix. Now won't print `-.000', etc.
11562 * descript.q: Now Z-scores work, although there appears to
11563 be a bug (which might actually be in data-out.c:convert_F()).
11564 (descriptives_trns_proc, descriptives_trns_free) New functions.
11565 (run_z_pass) Implemented.
11567 * var.h: Comment fixes.
11568 (dsc_z_score, descriptives_trns) New structs.
11569 (descriptives_trns) Added to any_trns as `dsc'.
11571 * error.c, error.h: New error class, IS (Installation Script
11572 error), used in those instances where the error is in the
11573 installation, but there is a script file or installation file that
11574 can be usefully referred to.
11576 * output.c: Change many IE classes to IS classes.
11578 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
11579 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
11580 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
11581 include the corresponding header?
11583 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
11584 Don't bail out if termcap can't be read.
11586 * som.c: (som_destroy_table) Removed.
11587 (som_reduce_table, som_destroy_all_tables) New functions.
11588 (som_crush) New function, not implemented.
11590 * som.h: New table option STAB_CRUSH. Comment fix. New struct
11591 som_submission_form. Function prototypes revised.
11593 Outputting huge tables (1000s of rows) a few rows at a time
11594 is supported, though untested. May even break everything.
11595 Actually, the code doesn't even compile right now.
11596 * som.c: (struct som) New fields htv, nt, seq_no.
11597 (som_submit_table) Multiple arguments changed to a single
11598 pointer to struct submission_form. Only increments subtable_num
11599 if seq_no is zero. Only destroys table if it's not going to
11601 (replicate_table) New function.
11602 (output_table) Comment fix.
11603 (examine_table) Changed inline code to code calling
11604 replicate_table(). Calculates htv. Supports partial tables.
11605 (draw_title) Removed comment.
11606 (build_target) Only allows for title on first part of partial
11608 (dump_plain_table) Only resets table chunk number on first part
11609 of partial tables; FIXME: doesn't work quite right. Supports
11611 (dump_page) Titles only on first part of partial tables.
11613 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
11615 * Thanks to an unreliable IDE hard drive, I have spent the last
11616 day reconstructing my Debian GNU/Linux installation and redoing
11617 the previous day's changes--somehow I managed to save every file
11618 except for output.c and output.h. So the following changes could
11619 really be considered independent of the output.c, output.h changes
11622 * output.h, output.c: Moved the outp_configure_vec global var,
11623 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
11624 outp_configure_vec is now static.
11626 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
11628 * The entire philosophy behind configuration of the output drivers
11629 changed. Now there is a termcap-type configuration where drivers
11630 to be read are determined beforehand, rather than parsing the
11631 entire output init file and storing it in memory & deciding what
11632 to actually use later. Faster & more memory-efficient at the same
11635 * output.c: Comment fix. Removed outp_init_drivers global var.
11636 Removed all references to synonyms. New structure outp_defn. New
11637 global vars outp_macros, outp_configure_vec.
11638 (search_name, delete_name, add_name, check_configure_vec,
11639 expand_name, find_defn_value) New static functions.
11640 (outp_configure_clear, outp_configure_add, outp_configure_macro,
11641 outp_read_devices) New extern functions.
11642 (outp_init) Much functionality moved into outp_read_devices.
11643 (outp_read_devices) Format of output init file changed; name of
11644 file is `devices' rather than `output' to avoid Makefile
11646 (outp_clear) Renamed outp_done.
11647 (outp_list_classes) Bug fix, cleaned up.
11648 (outp_list_drivers) Not implemented anymore.
11649 (outp_configure_driver) Now a static function; simplified; now
11650 interpolates macros; supports new structure.
11651 (outp_enable_driver, match_synonym) Removed; all references
11653 (find_driver) First argument removed.
11655 * output.h: Global var outp_init_drivers removed; new structure
11656 outp_names; new enum set OUTP_S_*; new global var
11657 outp_configure_vec; function prototypes for output.c exports
11660 * main.c: (main) Calls outp_read_devices() after parsing the
11663 * cmdline.c: (parse_command_line) New option -v --verbose;
11664 --version changed to -V. --device option changed syntax to just
11665 take a single device name. Accepts key=value declaration of
11666 output init file macros. Syntax message updated.
11668 * filename.c: (expand_line) New function.
11669 (interp_environ_vars) Renamed interp_vars; no longer uses
11671 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
11672 overridden by real environment vars.
11673 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
11674 * filename.h: interp_environ_vars() renamed interp_vars().
11676 * error.c, error.h: Added extern variable `verbosity', message
11679 * error.c: (vmsg) Support message class MM.
11680 (verbose_msg) New function.
11682 * descript.q: (generate_z_varname) Bug fix in generation of
11684 (dump_z_table) Bug fix in column headers.
11686 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
11687 page from 29 to 15. Don't set a default for ops[OPS_INIT,
11688 OPS_DONE]. Writes the uninit string when the driver is closed.
11689 (ascii_open_page) Write the init string before the first page.
11690 (output_shorts) Form of main loop changed from `while' to `for'.
11691 Bug fix with overstrikes: the character is printed *after* the
11692 backspace. Eliminated a lot of `& 0xff' modifiers.
11693 (advance_to_left_margin) New function.
11694 (return_carriage, output_lines) Handle left margin.
11696 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
11698 * ascii.c: New option `carriage-return-style'.
11700 * ascii.c: (count_fancy_chars) New function.
11701 (delineate, text_metrics) Use new function; bug fixes regarding
11703 (text_draw) Bug fix with rich text.
11704 (output_string, output_shorts) Reordered.
11705 (output_shorts) Now handles boxchars and some overstrike font
11707 (output_char, return_carriage) New functions.
11708 (output_lines) Now handles overstriking and font changes properly;
11709 some code moved to output_shorts.
11711 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
11714 * ascii.c: New member `debug' in ascii_driver_ext.
11715 (ascii_init_driver, delineate) Uses new member.
11717 Now you can set a vertical height on writing text.
11718 * ascii.c: (delineate) Keeps track of vertical position.
11719 (text_draw) No longer considers fully justified text an internal
11722 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
11724 Tables' titles are drawn; they can have variable height.
11725 * som.c: `som' struct has new member, title_height.
11726 (draw_title) New argument. Moved within file. All caller
11728 (build_target) New argument, amount of space needed for first row.
11729 Calculates height of title, takes that into account. All callers
11731 (dump_plain_table, dump_columnated_table) Took calculation of y1,
11733 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
11735 (dump_columnated_table) Organized for readability.
11736 (dump_page) Makes use of som.title_height.
11738 * som.c: Many comment bug fixes.
11740 * descript.q: (try_name, generate_z_name) Bug fix regarding
11741 generation of Z-score variable names.
11742 * var.h: Removed num from descriptives_proc; all referents removed.
11744 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
11746 * ascii.c: (ascii_line_horz, ascii_line_vert,
11747 ascii_line_intersection) Added debugging code.
11749 Added a descriptive line above each table to describe it.
11750 * command.c: (parse_cmd) Calls som_new_series.
11752 * som.c: New static vars table_num, subtable_num. New `som'
11754 (dump_page) New arguments.
11755 (som_submit_table) Handle new variables.
11757 * som.c, som.h: (som_submit_table) New arguments. All callers
11759 (som_new_series) New function.
11760 (build_target) Makes room for extra line.
11761 (draw_title) New function.
11762 (dump_page) Calls draw_title. Bug fix: doesn't always set
11765 Columnation of tables support.
11766 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
11768 * som.c: Deleted references to fr, lr, ri.
11769 (som_columnate) Bux fix: sets group member of table.
11770 (som_add_options) Function removed.
11771 (dump_table) Split into three functions; extensively reworked.
11773 * descript.q: (dump_z_table) Better output table formatting; added
11774 title support to correspond to som.h changes.
11775 (display) Title support.
11777 * output.h: Added OUTP_T_NONE.
11779 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
11781 * descript.q: Improved handling of Z scores; still not perfect.
11783 * output.h, ascii.c: Added hook for getting em width of current
11786 * som.c: Uses new em-width hook. Added debugging code to
11788 (som_columnate) New argument.
11789 (som_add_options) Removed.
11791 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
11793 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
11794 rules as a property of the table instead of as a property of the
11797 * ascii.c: Added `header' to table of options.
11799 * descript.q: Added even shorter statistic names; modified to work
11800 with new som interface.
11802 * misc.c (blp_getdelim): Bug fix.
11804 * version.c: includes 'conf.h'.
11806 ----------------------------------------------------------------------
11809 version-control: never
projects / pspp-builds.git / blob