pspp
13 years agoCategoricals: Sort the reverse value map. 20100825040502/pspp 20100826040503/pspp 20100827040503/pspp 20100828040502/pspp
John Darrington [Tue, 24 Aug 2010 14:17:17 +0000 (16:17 +0200)]
Categoricals: Sort the reverse value map.

The /CONTRAST subcommand of the ONEWAY command
requires that the categorical values are sorted
in ascending order.

13 years agoOneway: Fixed most compiler warnings
John Darrington [Mon, 23 Aug 2010 15:26:10 +0000 (17:26 +0200)]
Oneway: Fixed most compiler warnings

13 years agoOneway: Fix problems with MISSING=ANALYSIS
John Darrington [Mon, 23 Aug 2010 15:00:57 +0000 (17:00 +0200)]
Oneway: Fix problems with MISSING=ANALYSIS

13 years agoCategoricals: Use moments instead of keeping cc count ourselves
John Darrington [Mon, 23 Aug 2010 14:45:27 +0000 (16:45 +0200)]
Categoricals: Use moments instead of keeping cc count ourselves

13 years agooneway.c: Use the categoricals struct to calculate number of groups
John Darrington [Sun, 15 Aug 2010 15:50:14 +0000 (17:50 +0200)]
oneway.c: Use the categoricals struct to calculate number of groups

13 years agooneway: use new structures in the show_contrast_tests function
John Darrington [Sun, 15 Aug 2010 15:14:10 +0000 (17:14 +0200)]
oneway: use new structures in the show_contrast_tests function

13 years agooneway: Fix descriptives for multiple variables
John Darrington [Sun, 15 Aug 2010 11:10:37 +0000 (13:10 +0200)]
oneway: Fix descriptives for multiple variables

13 years agoAdd optional callback functions to categoricals.
John Darrington [Sat, 14 Aug 2010 17:49:51 +0000 (19:49 +0200)]
Add optional callback functions to categoricals.

Added callback functions to categoricals to enable
per category calculations to be done at the request
of the caller.  This change also modifies oneway.c (show_descriptives)
to use this new feature.  However at present it doesn't
work properly when multiple dependent variables are
specified.

13 years agoConstness
John Darrington [Sat, 14 Aug 2010 15:09:59 +0000 (17:09 +0200)]
Constness

13 years agoOneway: Remove group_stats from the show_homogeniety function
John Darrington [Sat, 14 Aug 2010 12:03:01 +0000 (14:03 +0200)]
Oneway: Remove group_stats from the show_homogeniety function

13 years agoOneway: Remove group_values struct from show_contrast_coeffs
John Darrington [Sat, 14 Aug 2010 11:46:39 +0000 (13:46 +0200)]
Oneway:  Remove group_values struct from show_contrast_coeffs

13 years agoCovariance matrix interface change.
John Darrington [Sat, 14 Aug 2010 09:16:21 +0000 (11:16 +0200)]
Covariance matrix interface change.

covariance_2pass_create now takes a pointer to a
struct categoricals which must be created by the caller,
instead of creating this object for itself.  This will
(hopefully) make the implementation of interactions and other
features easier.

13 years agoOneway: Remove dict member from struct and add wv member
John Darrington [Sat, 14 Aug 2010 08:06:23 +0000 (10:06 +0200)]
Oneway: Remove dict member from struct and add wv member

13 years agoOneway: Use covariance matrix and sweep operator
John Darrington [Fri, 13 Aug 2010 16:21:16 +0000 (18:21 +0200)]
Oneway: Use covariance matrix and sweep operator

Calculate the anova table using the routines from
src/math/covariance.c and lib/linreg/sweep.c instead
of the add hoc method.  This change doesn't remove
all traces of the old method, since the data is still
needed for some subcommands.  This will be the subject
of future changes.

13 years agoOneway: Additional test case.
John Darrington [Thu, 12 Aug 2010 19:12:30 +0000 (21:12 +0200)]
Oneway: Additional test case.

Add an explicit test for a oneway command run
on several different dependent variables.

13 years agoOneway: Use lex_get_num instead of lex_parse_value.
John Darrington [Thu, 12 Aug 2010 16:13:26 +0000 (18:13 +0200)]
Oneway:  Use lex_get_num instead of lex_parse_value.

Contrast coefficients can only be numeric, so parse_value
is an unnecessary generalisation.

13 years agoConstness
John Darrington [Sun, 8 Aug 2010 11:20:46 +0000 (13:20 +0200)]
Constness

13 years agoConstness
John Darrington [Sun, 8 Aug 2010 08:10:09 +0000 (10:10 +0200)]
Constness

13 years agoONEWAY: seperate the command specification from the variables used in its calculation
John Darrington [Sun, 8 Aug 2010 08:02:32 +0000 (10:02 +0200)]
ONEWAY: seperate the command specification from the variables used in its calculation

13 years agoCategoricals.c Create entries for all groups.
John Darrington [Sun, 8 Aug 2010 07:33:19 +0000 (09:33 +0200)]
Categoricals.c Create entries for all groups.

Although for the purposes of creating a covariance matrix, only
n - 1 entries are needed,  for other purposes (such as descriptive
statistics, contrasts, planned comparisons etc) all n entries are required.
(where n is the number of distinct values).  This change updates
categories.c so that all n categories are generated.  Covariance matrix
routines are free to ignore the ones not of interest.

13 years agoSyntax Window: Dynamically set paste sensitivity
John Darrington [Tue, 24 Aug 2010 12:46:37 +0000 (14:46 +0200)]
Syntax Window: Dynamically set paste sensitivity

Set the sensitivity of the paste action according to
whether there is anything to be pasted in the clipboard.

13 years agoImplemented Edit->Paste in the syntax viewer
John Darrington [Mon, 23 Aug 2010 20:36:32 +0000 (22:36 +0200)]
Implemented Edit->Paste in the syntax viewer

13 years agoformat: Optimize fmt_from_io(). 20100824040503/pspp
Ben Pfaff [Mon, 16 Aug 2010 05:03:19 +0000 (22:03 -0700)]
format: Optimize fmt_from_io().

A "switch" statement should be much faster than a linear search.

13 years agoformat: Fix type code for Z format in system and portable files.
Ben Pfaff [Mon, 16 Aug 2010 05:02:38 +0000 (22:02 -0700)]
format: Fix type code for Z format in system and portable files.

Z format is code 15, not 16 (which is N format).

13 years agoSyntax Window: Edit->* item sensitivity follows selection
John Darrington [Mon, 23 Aug 2010 17:30:10 +0000 (19:30 +0200)]
Syntax Window: Edit->* item sensitivity follows selection

Disable the Edit Cut/Copy/Delete menuitems by default
and enable them only when a selection is active.

13 years agoImplemented Cut, Copy and Delete in the syntax editor
John Darrington [Mon, 23 Aug 2010 16:57:31 +0000 (18:57 +0200)]
Implemented Cut, Copy and Delete in the syntax editor

13 years agoSET MXWARNS = 0 to be interpreted as unlimited. 20100822040502/pspp 20100823040503/pspp
John Darrington [Sun, 22 Aug 2010 10:36:37 +0000 (12:36 +0200)]
SET MXWARNS = 0 to be interpreted as unlimited.

This change introduces a special meaning to the
value of zero for the MXWARNS settings.  When
a zero value is set.  A single warning will be
emitted informing the user that the setting is
in effect.  Thereafter no warning will be emitted.
All warning situations will be ignored.

13 years agoMove MX* processing to libpspp/message.c
John Darrington [Sun, 22 Aug 2010 09:05:16 +0000 (11:05 +0200)]
Move MX* processing to libpspp/message.c

This change moves the guts of src/ui/terminal/msg-ui.c
into libpspp/message.c  The affected code handles the
processing of the MXWARNS and MXERRS settings.  As this
code was under src/ui/terminal these settings were being
ignored in the GUI

13 years agoUpdate tests to reflect string changes.
John Darrington [Sun, 22 Aug 2010 08:46:58 +0000 (10:46 +0200)]
Update tests to reflect string changes.

Commits 608b1765241e7c6f9bd5e86a8f81cf15edeb413b and
c1a56a1dd2afad462cf76d91c40aa064cc7dce04 changed some
output strings, but didn't update the tests to match.
This change makes that update.

13 years agosyntax-editor.ui cleanup 20100821040503/pspp
John Darrington [Sat, 21 Aug 2010 10:53:51 +0000 (12:53 +0200)]
syntax-editor.ui cleanup

13 years agoAllow undo/redo of pasted text as a single item
John Darrington [Sun, 8 Aug 2010 15:46:02 +0000 (17:46 +0200)]
Allow undo/redo of pasted text as a single item

13 years agoText input dialog: Use widget-io
John Darrington [Sat, 21 Aug 2010 09:48:05 +0000 (11:48 +0200)]
Text input dialog: Use widget-io

Use the widget_scanf function instead of manually
juxtaposing widgets.  This makes life a lot easier
for translators.

13 years agoCanonicalise 2-tailed vs. 2-sided
John Darrington [Sat, 21 Aug 2010 08:37:02 +0000 (10:37 +0200)]
Canonicalise 2-tailed vs. 2-sided

13 years agoConsolidate printed strings
John Darrington [Sat, 21 Aug 2010 08:35:32 +0000 (10:35 +0200)]
Consolidate printed strings

13 years agoCorrect grammar in printed string
John Darrington [Sat, 21 Aug 2010 08:16:58 +0000 (10:16 +0200)]
Correct grammar in printed string

13 years agofile-handle-def.c: replace hash with hmap
John Darrington [Fri, 20 Aug 2010 16:49:01 +0000 (18:49 +0200)]
file-handle-def.c: replace hash with hmap

13 years agoFix translation of column headers in text import dialog. 20100820040508/pspp
John Darrington [Thu, 19 Aug 2010 15:09:02 +0000 (17:09 +0200)]
Fix translation of column headers in text import dialog.

The "Text" and "Line" column headers in the text import dialog were not being
translated.  Thanks to Mindaugas embar@super.lt for reporting this.

13 years agoFix translation of column header.
John Darrington [Thu, 19 Aug 2010 14:54:45 +0000 (16:54 +0200)]
Fix translation of column header.

The "var" column header in the data view was not getting
translated, due to lack of a call to gettext.  Thanks to
Mindaugas embar@super.lt for reporting this.

13 years agocorrelations: Fix memory leak 20100814040504/pspp 20100815040507/pspp 20100816040502/pspp 20100817040502/pspp 20100818040505/pspp 20100819040502/pspp
John Darrington [Wed, 11 Aug 2010 19:31:20 +0000 (21:31 +0200)]
correlations: Fix memory leak

13 years agotests: Ignore testsuite.at since it is now a generated file. 20100810040503/pspp 20100811040504/pspp 20100812040503/pspp 20100813040503/pspp
Ben Pfaff [Mon, 9 Aug 2010 05:36:21 +0000 (22:36 -0700)]
tests: Ignore testsuite.at since it is now a generated file.

13 years agoCOUNT: Convert tests to use Autotest.
Ben Pfaff [Mon, 9 Aug 2010 05:34:11 +0000 (22:34 -0700)]
COUNT: Convert tests to use Autotest.

13 years agoBEGIN DATA: Convert tests to use Autotest.
Ben Pfaff [Mon, 9 Aug 2010 05:34:48 +0000 (22:34 -0700)]
BEGIN DATA: Convert tests to use Autotest.

13 years agoADD FILES: Convert testsuite to use Autotest.
Ben Pfaff [Mon, 9 Aug 2010 05:16:05 +0000 (22:16 -0700)]
ADD FILES: Convert testsuite to use Autotest.

13 years agotests: Rewrite attributes tests to use Autotest.
Ben Pfaff [Mon, 9 Aug 2010 05:35:37 +0000 (22:35 -0700)]
tests: Rewrite attributes tests to use Autotest.

13 years agoSET: Add test to avoid regression on bug #30682.
Ben Pfaff [Sun, 8 Aug 2010 23:32:08 +0000 (16:32 -0700)]
SET: Add test to avoid regression on bug #30682.

13 years agoImplement SAVE TRANSLATE to comma- and tab-delimited text formats.
Ben Pfaff [Sun, 8 Aug 2010 20:50:49 +0000 (13:50 -0700)]
Implement SAVE TRANSLATE to comma- and tab-delimited text formats.

13 years agoSAVE: Fix UNSELECTED=RETAIN with a filter variable.
Ben Pfaff [Sat, 7 Aug 2010 20:47:33 +0000 (13:47 -0700)]
SAVE: Fix UNSELECTED=RETAIN with a filter variable.

Apparently this had never been tested.  It assert-failed consistently
because the filter variable being saved was from the dictionary before
reading the data, but the dictionary after reading the data was
different due to the temporary transformation used to drop the
filtered data.

13 years agoDATA LIST: Don't report an error for an empty final field in LIST format.
Ben Pfaff [Fri, 6 Aug 2010 23:32:04 +0000 (16:32 -0700)]
DATA LIST: Don't report an error for an empty final field in LIST format.

Also add test to prevent inadvertent regressions.

13 years agoDATA LIST: Fix output column reporting for FREE and LIST formats.
Ben Pfaff [Sun, 8 Aug 2010 02:34:24 +0000 (19:34 -0700)]
DATA LIST: Fix output column reporting for FREE and LIST formats.

Also, add tests to prevent inadvertent regressions.

13 years agoDATA LIST: Convert tests to use Autotest.
Ben Pfaff [Sun, 8 Aug 2010 01:42:07 +0000 (18:42 -0700)]
DATA LIST: Convert tests to use Autotest.

13 years agosys-file-writer: Consistently use "goto error" to exit.
Ben Pfaff [Tue, 3 Aug 2010 05:41:19 +0000 (22:41 -0700)]
sys-file-writer: Consistently use "goto error" to exit.

13 years agosys-file-writer: Make write_error(), close_writer() static.
Ben Pfaff [Tue, 3 Aug 2010 05:40:57 +0000 (22:40 -0700)]
sys-file-writer: Make write_error(), close_writer() static.

These functions were never meant to be public (and they were not declared
in a header file).

13 years agosys-file-writer: Fix comment.
Ben Pfaff [Tue, 3 Aug 2010 05:11:57 +0000 (22:11 -0700)]
sys-file-writer: Fix comment.

13 years agoReplace S_I[RWX]{USR,GRP,OTH} macros by their values.
Ben Pfaff [Tue, 3 Aug 2010 05:11:13 +0000 (22:11 -0700)]
Replace S_I[RWX]{USR,GRP,OTH} macros by their values.

POSIX 2008 guarantees that these macros have their traditional Unix values,
so it should no be longer necessary to use the macros for portability's
sake.  Personally, I find the values easier to read, especially when
several of them are OR'd together.

13 years agoi18n: Make a few strings more generic for translators.
Ben Pfaff [Mon, 2 Aug 2010 04:19:50 +0000 (21:19 -0700)]
i18n: Make a few strings more generic for translators.

This should reduce the amount of work required by translators, by reducing
the number of unique strings to be translated.

13 years agoAggregate-dialog: Preselect summary function and variable name. 20100809040503/pspp
John Darrington [Sun, 8 Aug 2010 18:10:04 +0000 (20:10 +0200)]
Aggregate-dialog: Preselect summary function and variable name.

Apparently the most common use of aggregate is to count cases.
Therefore we set the default summary function and variable
name controls, so that the user has fewer keystrokes/mouse
clicks in order to achieve this.

13 years agoSET FORMAT: Flag an error if an invalid format is given.
John Darrington [Sun, 8 Aug 2010 13:48:41 +0000 (15:48 +0200)]
SET FORMAT: Flag an error if an invalid format is given.

Fixes bug #30682

13 years agoAggregate: Fixed bug when attempting to create duplicate variable 20100808040502/pspp
John Darrington [Sun, 8 Aug 2010 09:39:16 +0000 (11:39 +0200)]
Aggregate: Fixed bug when attempting to create duplicate variable

This change fixes a segfault which occured if AGGREGATE MODE=ADDVARIABLES
attempted to create a variable which already exists in the dictionary.
Added a test to check for this bug.

13 years agoAggregate dialog: Initialize HPane widget width on opening.
John Darrington [Sat, 7 Aug 2010 15:18:53 +0000 (17:18 +0200)]
Aggregate dialog: Initialize HPane widget width on opening.

Set the HPane position to 50% of maximum, when the widget is
realized.  Thanks to Fredrik Clementz for suggesting this.

13 years agoONEWAY: Add explicit tests for the homogeneity and descriptives subcommands 20100807040502/pspp
John Darrington [Fri, 6 Aug 2010 18:19:16 +0000 (20:19 +0200)]
ONEWAY: Add explicit tests for the homogeneity and descriptives subcommands

13 years agoMigrate the tests for the ONEWAY command to autotest style
John Darrington [Fri, 6 Aug 2010 17:06:40 +0000 (19:06 +0200)]
Migrate the tests for the ONEWAY command to autotest style

13 years agoAvoid duplicating the list of autotest files.
John Darrington [Fri, 6 Aug 2010 14:01:43 +0000 (16:01 +0200)]
Avoid duplicating the list of autotest files.

Reviewed by Ben Pfaff

13 years agoReplace oneway.q with a manually crafted oneway.c file 20100806040502/pspp
John Darrington [Thu, 5 Aug 2010 15:07:42 +0000 (17:07 +0200)]
Replace oneway.q with a manually crafted oneway.c file

13 years agoDocumentation: Add explanation of ONEWAY/MISSING
John Darrington [Thu, 5 Aug 2010 15:06:01 +0000 (17:06 +0200)]
Documentation: Add explanation of ONEWAY/MISSING

13 years agoAvoid compiler warning 20100801040501/pspp 20100802040501/pspp 20100803040504/pspp 20100804040501/pspp 20100805040502/pspp
John Darrington [Sun, 1 Aug 2010 08:24:28 +0000 (10:24 +0200)]
Avoid compiler warning

13 years agoFACTOR: prevent crash if the dataset is empty. 20100731040501/pspp
John Darrington [Sat, 31 Jul 2010 09:55:18 +0000 (11:55 +0200)]
FACTOR: prevent crash if the dataset is empty.

The FACTOR command crashed if there were no cases
which had non-missing values for all variables.
This change emits a warning in this case and does
no analysis.

13 years agoDeallocate memory from pool using the correct function
John Darrington [Fri, 30 Jul 2010 21:41:01 +0000 (23:41 +0200)]
Deallocate memory from pool using the correct function

Memory allocated using pool_alloc was being deallocated using
the standard free function instead of pool_free.  This change
fixes that.  Thanks to Andras Muranyi for reporting this problem.

13 years agoFlush the journal after every write.
John Darrington [Fri, 30 Jul 2010 17:49:03 +0000 (19:49 +0200)]
Flush the journal after every write.

Unexpected bugs in the parser, engine or in procedures can cause crashes
in the GUI.  If the journal is not flushed *before* running the syntax, then
no record of that syntax exists, and the bug can be hard to reproduce.
This change ensures that the syntax is written to the journal before it is
processed.

13 years agoRemoved the gnulib modules which are being flagged as obsolete
John Darrington [Fri, 30 Jul 2010 17:40:36 +0000 (19:40 +0200)]
Removed the gnulib modules which are being flagged as obsolete

13 years agoAGGREGATE: Add .h file to Makefile (fixing "make distcheck"). 20100730040501/pspp
Ben Pfaff [Fri, 30 Jul 2010 05:34:24 +0000 (22:34 -0700)]
AGGREGATE: Add .h file to Makefile (fixing "make distcheck").

13 years agoFLIP: Convert tests to use Autotest.
Ben Pfaff [Fri, 30 Jul 2010 05:15:15 +0000 (22:15 -0700)]
FLIP: Convert tests to use Autotest.

13 years agomake-file: Remove superfluous fflush().
Ben Pfaff [Fri, 30 Jul 2010 05:09:08 +0000 (22:09 -0700)]
make-file: Remove superfluous fflush().

Probably introduced during debugging and accidentally left in.

13 years agotemp-file: New functions for creating temporary files honoring $TMPDIR.
Ben Pfaff [Fri, 30 Jul 2010 05:08:33 +0000 (22:08 -0700)]
temp-file: New functions for creating temporary files honoring $TMPDIR.

The tmpfile() function is useful, but it doesn't necessarily honor
the $TMPDIR environment variable.  Some of our users find that a problem,
so this commit replaces tmpfile() usage by a new pair of functions
create_temp_file() and close_temp_file() that do honor $TMPDIR.

Bug #30530.

13 years agotemp-file: Rename "ext-array" (for "external array").
Ben Pfaff [Fri, 30 Jul 2010 04:16:06 +0000 (21:16 -0700)]
temp-file: Rename "ext-array" (for "external array").

I want to introduce a new source module for general creation of temporary
files and this module's name conflicts.

13 years agoAGGREGATE: Fixed a bug with MEDIAN vs. MODE=ADDVARIABLES
John Darrington [Thu, 29 Jul 2010 16:15:59 +0000 (18:15 +0200)]
AGGREGATE: Fixed a bug with MEDIAN vs. MODE=ADDVARIABLES

13 years agoAdded dialog box for the aggregate command
John Darrington [Thu, 29 Jul 2010 14:35:56 +0000 (16:35 +0200)]
Added dialog box for the aggregate command

13 years agoAGGREGATE: New file aggregate.h containing the summary function specifications 20100729040501/pspp
John Darrington [Wed, 28 Jul 2010 14:32:00 +0000 (16:32 +0200)]
AGGREGATE: New file aggregate.h containing the summary function specifications

Added a header file containing the declaration and type of the agr_func_tab
table, and expanded that type to contain a description of the function and
an explicit declaration of whether a source variable is permitted/needed.
This change is primarily for the benefit of the forthcoming dialog box for
the aggregate command.  However it also (in my opinion) makes the existing
implementation a little easier to understand.

13 years agoRemove URL from translatable string 20100727040509/pspp 20100728040502/pspp
John Darrington [Mon, 26 Jul 2010 13:16:03 +0000 (15:16 +0200)]
Remove URL from translatable string

13 years agoAGGREGATE: Add MODE=ADDVARIABLES subcommand.
John Darrington [Mon, 26 Jul 2010 12:34:58 +0000 (14:34 +0200)]
AGGREGATE: Add MODE=ADDVARIABLES subcommand.

Instead of replacing the current dataset with the aggregated
data, this subcommand appends newvariables to the data with the
aggregated values.

13 years agoFix upper bound for subscript in ordered_cols. 20100726040509/pspp
Jason H Stover [Sun, 25 Jul 2010 16:34:46 +0000 (12:34 -0400)]
Fix upper bound for subscript in ordered_cols.

13 years agoFix memory leak in crosstabs 20100725040501/pspp
John Darrington [Sat, 24 Jul 2010 16:21:15 +0000 (18:21 +0200)]
Fix memory leak in crosstabs

13 years agoFix memory leak in MRSETS
John Darrington [Sat, 24 Jul 2010 15:54:55 +0000 (17:54 +0200)]
Fix memory leak in MRSETS

13 years agoAvoid unused function warning
John Darrington [Sat, 24 Jul 2010 14:37:00 +0000 (16:37 +0200)]
Avoid unused function warning

13 years agoReplaced relibility.q with relibility.c 20100724040501/pspp
John Darrington [Tue, 20 Jul 2010 07:26:47 +0000 (09:26 +0200)]
Replaced relibility.q with relibility.c

Replaced the reliability autogenerated parser
with a handcrafted one.

13 years agoAdd argument specifying column containing dependent variable. 20100722040501/pspp 20100723040501/pspp
Jason H Stover [Tue, 20 Jul 2010 22:32:35 +0000 (18:32 -0400)]
Add argument specifying column containing dependent variable.

13 years agoDelete file "means.q" 20100720040501/pspp
John Darrington [Mon, 19 Jul 2010 18:47:05 +0000 (20:47 +0200)]
Delete file "means.q"

This file contained only the skeleton of the parser.

13 years agoRemove unnecessary include directives of hash.h
John Darrington [Mon, 19 Jul 2010 16:47:38 +0000 (18:47 +0200)]
Remove unnecessary include directives of hash.h

13 years agoFix memory leak in data_in
John Darrington [Sun, 18 Jul 2010 17:19:53 +0000 (19:19 +0200)]
Fix memory leak in data_in

13 years agoReliability dialog: Add checkbox for summary subcommand 20100717040502/pspp 20100718040501/pspp
John Darrington [Fri, 16 Jul 2010 20:53:18 +0000 (22:53 +0200)]
Reliability dialog: Add checkbox for summary subcommand

13 years agoadd missing source file to glade support library
John Darrington [Fri, 16 Jul 2010 20:44:10 +0000 (22:44 +0200)]
add missing source file to glade support library

13 years agoFix memory leak
John Darrington [Fri, 16 Jul 2010 14:18:07 +0000 (16:18 +0200)]
Fix memory leak

13 years agoRemove const qualifiers from encoding converter components.
John Darrington [Fri, 16 Jul 2010 13:42:40 +0000 (15:42 +0200)]
Remove const qualifiers from encoding converter components.

These elements have to be freed.  Therefore const is not
appropriate.

13 years agoDo not rely on user to specify all variables in VARIABLE subcommand. Fixes bug 30389. 20100716040502/pspp
Jason H Stover [Thu, 15 Jul 2010 17:11:33 +0000 (13:11 -0400)]
Do not rely on user to specify all variables in VARIABLE subcommand. Fixes bug 30389.

13 years agoReplace unknown XML entities with their numerical counterpart. 20100711040509/pspp 20100712040501/pspp 20100713040501/pspp 20100714040501/pspp 20100715040507/pspp
John Darrington [Thu, 8 Jul 2010 13:24:11 +0000 (15:24 +0200)]
Replace unknown XML entities with their numerical counterpart.

Texinfo seems to produce XML entities (such as ©) which
are not valid (although they are valid for HTML).  We work
around such problems by post-processing with sed. Here, we
replace these unknown entities with their numeric counterparts.
Such is the advice given at
http://www.dwheeler.com/essays/quotes-in-html.html

13 years agoFix various memory leaks
John Darrington [Sun, 4 Jul 2010 15:17:32 +0000 (17:17 +0200)]
Fix various memory leaks

13 years agoFix memory leak in tab_destroy
John Darrington [Sun, 4 Jul 2010 12:50:16 +0000 (14:50 +0200)]
Fix memory leak in tab_destroy

13 years agoFix memory leak in examine
John Darrington [Sun, 4 Jul 2010 12:49:54 +0000 (14:49 +0200)]
Fix memory leak in examine

13 years agoFix uninitialized variable
John Darrington [Sun, 4 Jul 2010 12:17:32 +0000 (14:17 +0200)]
Fix uninitialized variable

13 years agoFix invalid reference
John Darrington [Sun, 4 Jul 2010 11:16:54 +0000 (13:16 +0200)]
Fix invalid reference

13 years agocairo: Fix handling of font sizes. 20100702040502/pspp 20100703040502/pspp
Ben Pfaff [Tue, 29 Jun 2010 23:59:42 +0000 (16:59 -0700)]
cairo: Fix handling of font sizes.

Until now this code used pango_font_description_set_absolute_size() to set
the font size.  This sets the font size in device units, e.g. pixels on a
display.  But font sizes are actual specified by the user in points, so
we should instead use pango_font_description_get_size().  This commit
makes that change.

That change is simple, but it necessitates a larger change.
Until now the cairo driver has just assumed that the size of a font is
the size that we assigned it.  But this is no longer the case, since
points and pixels are now different.  So now we measure the actual width
and height of characters and use those as the font size.  At the same
time, the code no longer ignores font sizes included as part of font
description strings, and allows different fonts to have different sizes.

With plenty of help from John Darrington.