Select Cases Dialog: Convert to PsppireDialogAction
[pspp] / src / ui / gui / psppire-data-window.c
index ad967b3256c7578860236c8eed1e79cf9d2bbf1f..6cf3a8f617d421a4fe4a48ab7296a892596f5360 100644 (file)
@@ -1,5 +1,5 @@
 /* PSPPIRE - a graphical user interface for PSPP.
-   Copyright (C) 2008, 2009, 2010, 2011, 2012  Free Software Foundation
+   Copyright (C) 2008, 2009, 2010, 2011, 2012, 2013, 2014  Free Software Foundation
 
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 #include "language/lexer/lexer.h"
 #include "libpspp/message.h"
 #include "libpspp/str.h"
-#include "ui/gui/aggregate-dialog.h"
-#include "ui/gui/autorecode-dialog.h"
-#include "ui/gui/binomial-dialog.h"
 #include "ui/gui/builder-wrapper.h"
-#include "ui/gui/chi-square-dialog.h"
-#include "ui/gui/comments-dialog.h"
-#include "ui/gui/compute-dialog.h"
-#include "ui/gui/count-dialog.h"
-#include "ui/gui/crosstabs-dialog.h"
 #include "ui/gui/entry-dialog.h"
 #include "ui/gui/executor.h"
-#include "ui/gui/frequencies-dialog.h"
 #include "ui/gui/help-menu.h"
 #include "ui/gui/helper.h"
 #include "ui/gui/helper.h"
-#include "ui/gui/k-related-dialog.h"
-#include "ui/gui/npar-two-sample-related.h"
-#include "ui/gui/oneway-anova-dialog.h"
+#include "ui/gui/psppire-import-assistant.h"
 #include "ui/gui/psppire-data-window.h"
 #include "ui/gui/psppire-dialog-action.h"
+#include "ui/gui/psppire-encoding-selector.h"
 #include "ui/gui/psppire-syntax-window.h"
 #include "ui/gui/psppire-window.h"
 #include "ui/gui/psppire.h"
-#include "ui/gui/runs-dialog.h"
-#include "ui/gui/ks-one-sample-dialog.h"
 #include "ui/gui/recode-dialog.h"
-#include "ui/gui/select-cases-dialog.h"
-#include "ui/gui/split-file-dialog.h"
-#include "ui/gui/t-test-one-sample.h"
-#include "ui/gui/t-test-paired-samples.h"
-#include "ui/gui/text-data-import-dialog.h"
-#include "ui/gui/transpose-dialog.h"
-#include "ui/gui/univariate-dialog.h"
-#include "ui/gui/weight-cases-dialog.h"
 #include "ui/syntax-gen.h"
 
 #include "gl/c-strcase.h"
@@ -170,15 +150,18 @@ transformation_change_callback (bool transformations_pending,
 {
   PsppireDataWindow  *de = PSPPIRE_DATA_WINDOW (data);
 
-  GtkUIManager *uim = GTK_UI_MANAGER (get_object_assert (de->builder, "uimanager1", GTK_TYPE_UI_MANAGER));
-
-  GtkWidget *menuitem =
-    gtk_ui_manager_get_widget (uim,"/ui/menubar/transform/transform_run-pending");
-
   GtkWidget *status_label  =
     get_widget_assert (de->builder, "case-counter-area");
 
-  gtk_widget_set_sensitive (menuitem, transformations_pending);
+  { /* Set the sensitivity of the "Transformations Pending" menuitem */
+    GtkUIManager *uim = 
+      GTK_UI_MANAGER (get_object_assert (de->builder, "uimanager1", GTK_TYPE_UI_MANAGER));
+
+    GtkWidget *menuitem =
+      gtk_ui_manager_get_widget (uim,"/ui/menubar/transform/transform_run-pending");
+    
+    gtk_widget_set_sensitive (menuitem, transformations_pending);
+  }
 
 
   if ( transformations_pending)
@@ -317,18 +300,25 @@ dump_rm (GtkRecentManager *rm)
 }
 #endif
 
+static gboolean
+has_suffix (const gchar *name, const gchar *suffix)
+{
+  size_t name_len = strlen (name);
+  size_t suffix_len = strlen (suffix);
+  return (name_len > suffix_len
+          && !c_strcasecmp (&name[name_len - suffix_len], suffix));
+}
+
 static gboolean
 name_has_por_suffix (const gchar *name)
 {
-  size_t length = strlen (name);
-  return length > 4 && !c_strcasecmp (&name[length - 4], ".por");
+  return has_suffix (name, ".por");
 }
 
 static gboolean
 name_has_sav_suffix (const gchar *name)
 {
-  size_t length = strlen (name);
-  return length > 4 && !c_strcasecmp (&name[length - 4], ".sav");
+  return has_suffix (name, ".sav") || has_suffix (name, ".zsav");
 }
 
 /* Returns true if NAME has a suffix which might denote a PSPP file */
@@ -339,38 +329,68 @@ name_has_suffix (const gchar *name)
 }
 
 static gboolean
-load_file (PsppireWindow *de, const gchar *file_name)
+load_file (PsppireWindow *de, const gchar *file_name, const char *encoding,
+           gpointer syn)
 {
-  struct string filename;
-  gchar *utf8_file_name;
-  const char *mime_type;
-  gchar *syntax;
+  const char *mime_type = NULL;
+  gchar *syntax = NULL;
   bool ok;
 
-  ds_init_empty (&filename);
-
-  utf8_file_name = g_filename_to_utf8 (file_name, -1, NULL, NULL, NULL);
+  if (syn == NULL)
+    {
+      gchar *utf8_file_name;
+      struct string filename;
+      
+      utf8_file_name = g_filename_to_utf8 (file_name, -1, NULL, NULL, NULL);
 
-  syntax_gen_string (&filename, ss_cstr (utf8_file_name));
+      if (NULL == utf8_file_name)
+       return FALSE;
 
-  g_free (utf8_file_name);
+      ds_init_empty (&filename);    
+      syntax_gen_string (&filename, ss_cstr (utf8_file_name));
+      
+      g_free (utf8_file_name);
 
-  syntax = g_strdup_printf ("GET FILE=%s.", ds_cstr (&filename));
-  ds_destroy (&filename);
+      if (encoding && encoding[0])
+        syntax = g_strdup_printf ("GET FILE=%s ENCODING='%s'.",
+                                  ds_cstr (&filename), encoding);
+      else
+        syntax = g_strdup_printf ("GET FILE=%s.", ds_cstr (&filename));
+      ds_destroy (&filename);
+    }
+  else
+    {
+      syntax = syn;
+    }
 
   ok = execute_syntax (PSPPIRE_DATA_WINDOW (de),
-                       lex_reader_for_string (syntax));
+                       lex_reader_for_string (syntax, "UTF-8"));
   g_free (syntax);
 
-  mime_type = (name_has_por_suffix (file_name)
-               ? "application/x-spss-por"
-               : "application/x-spss-sav");
-
-  add_most_recent (file_name, mime_type);
+  if (ok && syn == NULL)
+    {
+      if (name_has_por_suffix (file_name))
+       mime_type = "application/x-spss-por";
+      else if (name_has_sav_suffix (file_name))
+       mime_type = "application/x-spss-sav";
+      
+      add_most_recent (file_name, mime_type, encoding);
+    }
 
   return ok;
 }
 
+static const char *
+psppire_data_window_format_to_string (enum PsppireDataWindowFormat format)
+{
+  if (format == PSPPIRE_DATA_WINDOW_SAV)
+    return ".sav";
+  else if (format == PSPPIRE_DATA_WINDOW_ZSAV)
+    return ".zsav";
+  else
+    return ".por";
+}
+
 /* Save DE to file */
 static void
 save_file (PsppireWindow *w)
@@ -387,12 +407,7 @@ save_file (PsppireWindow *w)
   fnx = g_string_new (file_name);
 
   if ( ! name_has_suffix (fnx->str))
-    {
-      if ( de->save_as_portable)
-       g_string_append (fnx, ".por");
-      else
-       g_string_append (fnx, ".sav");
-    }
+    g_string_append (fnx, psppire_data_window_format_to_string (de->format));
 
   ds_init_empty (&filename);
 
@@ -403,9 +418,13 @@ save_file (PsppireWindow *w)
   syntax_gen_string (&filename, ss_cstr (utf8_file_name));
   g_free (utf8_file_name);
 
-  syntax = g_strdup_printf ("%s OUTFILE=%s.",
-                            de->save_as_portable ? "EXPORT" : "SAVE",
-                            ds_cstr (&filename));
+  if (de->format == PSPPIRE_DATA_WINDOW_SAV)
+    syntax = g_strdup_printf ("SAVE OUTFILE=%s.", ds_cstr (&filename));
+  else if (de->format == PSPPIRE_DATA_WINDOW_ZSAV)
+    syntax = g_strdup_printf ("SAVE /ZCOMPRESSED /OUTFILE=%s.",
+                              ds_cstr (&filename));
+  else
+    syntax = g_strdup_printf ("EXPORT OUTFILE=%s.", ds_cstr (&filename));
 
   ds_destroy (&filename);
 
@@ -429,10 +448,12 @@ sysfile_info (PsppireDataWindow *de)
       struct string filename;
       gchar *file_name =
        gtk_file_chooser_get_filename (GTK_FILE_CHOOSER (dialog));
-
       gchar *utf8_file_name = g_filename_to_utf8 (file_name, -1, NULL, NULL,
                                                   NULL);
 
+      const gchar *encoding = psppire_encoding_selector_get_encoding (
+        gtk_file_chooser_get_extra_widget (GTK_FILE_CHOOSER (dialog)));
+
       gchar *syntax;
 
       ds_init_empty (&filename);
@@ -441,7 +462,11 @@ sysfile_info (PsppireDataWindow *de)
 
       g_free (utf8_file_name);
 
-      syntax = g_strdup_printf ("SYSFILE INFO %s.", ds_cstr (&filename));
+      if (encoding)
+        syntax = g_strdup_printf ("SYSFILE INFO %s ENCODING='%s'.",
+                                  ds_cstr (&filename), encoding);
+      else
+        syntax = g_strdup_printf ("SYSFILE INFO %s.", ds_cstr (&filename));
       g_free (execute_syntax_string (de, syntax));
     }
 
@@ -453,23 +478,31 @@ sysfile_info (PsppireDataWindow *de)
 static void
 data_pick_filename (PsppireWindow *window)
 {
+  GtkListStore *list_store;
+  GtkWidget *combo_box;
+
   PsppireDataWindow *de = PSPPIRE_DATA_WINDOW (window);
-  GtkFileFilter *filter = gtk_file_filter_new ();
-  GtkWidget *button_sys;
+  GtkFileFilter *filter;
   GtkWidget *dialog =
     gtk_file_chooser_dialog_new (_("Save"),
                                 GTK_WINDOW (de),
                                 GTK_FILE_CHOOSER_ACTION_SAVE,
-                                GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
-                                GTK_STOCK_SAVE, GTK_RESPONSE_ACCEPT,
+                                _("Cancel"), GTK_RESPONSE_CANCEL,
+                                _("Save"), GTK_RESPONSE_ACCEPT,
                                 NULL);
 
   g_object_set (dialog, "local-only", FALSE, NULL);
 
+  filter = gtk_file_filter_new ();
   gtk_file_filter_set_name (filter, _("System Files (*.sav)"));
   gtk_file_filter_add_mime_type (filter, "application/x-spss-sav");
   gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
 
+  filter = gtk_file_filter_new ();
+  gtk_file_filter_set_name (filter, _("Compressed System Files (*.zsav)"));
+  gtk_file_filter_add_pattern (filter, "*.zsav");
+  gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
+
   filter = gtk_file_filter_new ();
   gtk_file_filter_set_name (filter, _("Portable Files (*.por) "));
   gtk_file_filter_add_mime_type (filter, "application/x-spss-por");
@@ -479,24 +512,49 @@ data_pick_filename (PsppireWindow *window)
   gtk_file_filter_set_name (filter, _("All Files"));
   gtk_file_filter_add_pattern (filter, "*");
   gtk_file_chooser_add_filter (GTK_FILE_CHOOSER (dialog), filter);
+  gtk_file_chooser_set_filter (GTK_FILE_CHOOSER (dialog), filter);
 
   {
-    GtkWidget *button_por;
-    GtkWidget *vbox = gtk_vbox_new (TRUE, 5);
-    button_sys =
-      gtk_radio_button_new_with_label (NULL, _("System File"));
-
-    button_por =
-      gtk_radio_button_new_with_label
-      (gtk_radio_button_get_group (GTK_RADIO_BUTTON(button_sys)),
-       _("Portable File"));
-
-    psppire_box_pack_start_defaults (GTK_BOX (vbox), button_sys);
-    psppire_box_pack_start_defaults (GTK_BOX (vbox), button_por);
-
-    gtk_widget_show_all (vbox);
-
-    gtk_file_chooser_set_extra_widget (GTK_FILE_CHOOSER(dialog), vbox);
+    GtkCellRenderer *cell;
+    GtkWidget *label;
+    GtkTreeIter iter;
+    GtkWidget *hbox;
+
+    list_store = gtk_list_store_new (2, G_TYPE_INT, G_TYPE_STRING);
+    combo_box = gtk_combo_box_new_with_model (GTK_TREE_MODEL (list_store));
+
+    gtk_list_store_append (list_store, &iter);
+    gtk_list_store_set (list_store, &iter,
+                        0, PSPPIRE_DATA_WINDOW_SAV,
+                        1, _("System File"),
+                        -1);
+    gtk_combo_box_set_active_iter (GTK_COMBO_BOX (combo_box), &iter);
+
+    gtk_list_store_append (list_store, &iter);
+    gtk_list_store_set (list_store, &iter,
+                        0, PSPPIRE_DATA_WINDOW_ZSAV,
+                        1, _("Compressed System File"),
+                        -1);
+
+    gtk_list_store_append (list_store, &iter);
+    gtk_list_store_set (list_store, &iter,
+                        0, PSPPIRE_DATA_WINDOW_POR,
+                        1, _("Portable File"),
+                        -1);
+
+    label = gtk_label_new (_("Format:"));
+
+    cell = gtk_cell_renderer_text_new ();
+    gtk_cell_layout_pack_start (GTK_CELL_LAYOUT (combo_box), cell, FALSE);
+    gtk_cell_layout_add_attribute (GTK_CELL_LAYOUT (combo_box), cell,
+                                   "text", 1);
+
+    hbox = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
+    gtk_box_pack_start (GTK_BOX (hbox), label, FALSE, FALSE, 0);
+    gtk_box_pack_start (GTK_BOX (hbox), combo_box, FALSE, FALSE, 0);
+    gtk_widget_show_all (hbox);
+
+    gtk_file_chooser_set_extra_widget (GTK_FILE_CHOOSER (dialog), hbox);
   }
 
   gtk_file_chooser_set_do_overwrite_confirmation (GTK_FILE_CHOOSER (dialog),
@@ -512,16 +570,18 @@ data_pick_filename (PsppireWindow *window)
           gtk_file_chooser_get_filename (GTK_FILE_CHOOSER (dialog))
           );
 
-       de->save_as_portable =
-         ! gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (button_sys));
+        GtkTreeIter iter;
+        int format;
+
+        gtk_combo_box_get_active_iter (GTK_COMBO_BOX (combo_box), &iter);
+        gtk_tree_model_get (GTK_TREE_MODEL (list_store), &iter,
+                            0, &format,
+                            -1);
+       de->format = format;
 
        if ( ! name_has_suffix (filename->str))
-         {
-           if ( de->save_as_portable)
-             g_string_append (filename, ".por");
-           else
-             g_string_append (filename, ".sav");
-         }
+          g_string_append (filename,
+                           psppire_data_window_format_to_string (format));
 
        psppire_window_set_filename (PSPPIRE_WINDOW (de), filename->str);
 
@@ -555,8 +615,8 @@ confirm_delete_dataset (PsppireDataWindow *de,
     old_dataset, new_dataset, existing_dataset);
 
   gtk_dialog_add_buttons (GTK_DIALOG (dialog),
-                          GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
-                          GTK_STOCK_DELETE, GTK_RESPONSE_OK,
+                          _("Cancel"), GTK_RESPONSE_CANCEL,
+                          _("Delete"), GTK_RESPONSE_OK,
                           NULL);
 
   g_object_set (dialog, "icon-name", "pspp", NULL);
@@ -635,29 +695,18 @@ static void
 fonts_activate (PsppireDataWindow  *de)
 {
   GtkWidget *toplevel = gtk_widget_get_toplevel (GTK_WIDGET (de));
-  PangoFontDescription *current_font;
-  gchar *font_name;
-  GtkWidget *dialog =
-    gtk_font_selection_dialog_new (_("Font Selection"));
-
-
-  current_font = GTK_WIDGET(de->data_editor)->style->font_desc;
-  font_name = pango_font_description_to_string (current_font);
+  GtkWidget *dialog =  gtk_font_chooser_dialog_new (NULL, GTK_WINDOW (toplevel));
+  GtkStyle *style = gtk_widget_get_style (GTK_WIDGET(de->data_editor));
+  PangoFontDescription *current_font = style->font_desc;
 
-  gtk_font_selection_dialog_set_font_name (GTK_FONT_SELECTION_DIALOG (dialog), font_name);
-
-  g_free (font_name);
+  gtk_font_chooser_set_font_desc (GTK_FONT_CHOOSER (dialog), current_font);
 
   gtk_window_set_transient_for (GTK_WINDOW (dialog),
                                GTK_WINDOW (toplevel));
 
   if ( GTK_RESPONSE_OK == gtk_dialog_run (GTK_DIALOG (dialog)) )
     {
-      const gchar *font = gtk_font_selection_dialog_get_font_name
-       (GTK_FONT_SELECTION_DIALOG (dialog));
-
-      PangoFontDescription* font_desc =
-       pango_font_description_from_string (font);
+      PangoFontDescription* font_desc = gtk_font_chooser_get_font_desc (GTK_FONT_CHOOSER (dialog));
 
       psppire_data_editor_set_font (de->data_editor, font_desc);
     }
@@ -704,7 +753,7 @@ on_recent_data_select (GtkMenuShell *menushell,
 
   g_free (uri);
 
-  open_data_window (window, file);
+  open_data_window (window, file, NULL, NULL);
 
   g_free (file);
 }
@@ -767,7 +816,7 @@ on_recent_files_select (GtkMenuShell *menushell,   gpointer user_data)
 
   free (encoding);
 
-  if ( psppire_window_load (PSPPIRE_WINDOW (se), file) ) 
+  if ( psppire_window_load (PSPPIRE_WINDOW (se), file, encoding, NULL) ) 
     gtk_widget_show (se);
   else
     gtk_widget_destroy (se);
@@ -782,18 +831,19 @@ set_unsaved (gpointer w)
 }
 
 static void
-on_switch_page (PsppireDataEditor *de, GtkNotebookPage *p,
+on_switch_page (PsppireDataEditor *de, gpointer p,
                gint pagenum, PsppireDataWindow *dw)
 {
-  GtkWidget *page_menu_item;
-  gboolean is_ds;
-  const char *path;
+  /* Set the appropriate ui_manager according to the selected page.
+     This is necessary, because the menus for the variable view and
+     the data view are different (slightly). */
 
-  is_ds = pagenum == PSPPIRE_DATA_EDITOR_DATA_VIEW;
-  path = (is_ds
+  gboolean is_ds = pagenum == PSPPIRE_DATA_EDITOR_DATA_VIEW;
+  const char *path = (is_ds
           ? "/ui/menubar/view/view_data"
           : "/ui/menubar/view/view_variables");
-  page_menu_item = gtk_ui_manager_get_widget (dw->ui_manager, path);
+
+  GtkWidget *page_menu_item = gtk_ui_manager_get_widget (dw->ui_manager, path);
   gtk_check_menu_item_set_active (GTK_CHECK_MENU_ITEM (page_menu_item), TRUE);
 }
 
@@ -829,12 +879,24 @@ connect_action (PsppireDataWindow *dw, const char *action_name,
                                    GCallback handler)
 {
   GtkAction *action = get_action_assert (dw->builder, action_name);
+
   g_signal_connect_swapped (action, "activate", handler, dw);
 
   return action;
 }
 
+/* Only a data file with at least one variable can be saved. */
+static void
+enable_save (PsppireDataWindow *dw)
+{
+  gboolean enable = psppire_dict_get_var_cnt (dw->dict) > 0;
+
+  gtk_action_set_sensitive (get_action_assert (dw->builder, "file_save"),
+                            enable);
+  gtk_action_set_sensitive (get_action_assert (dw->builder, "file_save_as"),
+                            enable);
+}
+
 /* Initializes as much of a PsppireDataWindow as we can and must before the
    dataset has been set.
 
@@ -845,17 +907,55 @@ connect_action (PsppireDataWindow *dw, const char *action_name,
 static void
 psppire_data_window_init (PsppireDataWindow *de)
 {
+  GtkWidget *w ;
   de->builder = builder_new ("data-editor.ui");
 
   de->ui_manager = GTK_UI_MANAGER (get_object_assert (de->builder, "uimanager1", GTK_TYPE_UI_MANAGER));
 
-  PSPPIRE_WINDOW (de)->menu =
-    GTK_MENU_SHELL (gtk_ui_manager_get_widget (de->ui_manager, "/ui/menubar/windows/windows_minimise_all")->parent);
+  w = gtk_ui_manager_get_widget (de->ui_manager, "/ui/menubar/windows/windows_minimise_all");
+
+  PSPPIRE_WINDOW (de)->menu = GTK_MENU_SHELL (gtk_widget_get_parent (w));
 
   de->uim = NULL;
   de->merge_id = 0;
 }
 
+static void
+file_import (PsppireDataWindow *dw)
+{
+  GtkWidget *w = psppire_import_assistant_new (GTK_WINDOW (dw));
+  PsppireImportAssistant *asst = PSPPIRE_IMPORT_ASSISTANT (w);
+  gtk_widget_show_all (w);
+  
+  asst->main_loop = g_main_loop_new (NULL, TRUE);
+  g_main_loop_run (asst->main_loop);
+  g_main_loop_unref (asst->main_loop);
+
+  if (!asst->file_name)
+    goto end;
+  
+  switch (asst->response)
+    {
+    case GTK_RESPONSE_APPLY:
+      {
+       g_debug ("HERE");
+       gchar *fn = g_path_get_basename (asst->file_name);
+       open_data_window (PSPPIRE_WINDOW (dw), fn, NULL, psppire_import_assistant_generate_syntax (asst));
+       g_free (fn);
+      }
+      break;
+    case PSPPIRE_RESPONSE_PASTE:
+      g_debug ("THERE");
+      free (paste_syntax_to_window (psppire_import_assistant_generate_syntax (asst)));
+      break;
+    default:
+      break;
+    }
+    
+ end:  
+  gtk_widget_destroy (GTK_WIDGET (asst));
+}
+
 static void
 psppire_data_window_finish_init (PsppireDataWindow *de,
                                  struct dataset *ds)
@@ -870,7 +970,7 @@ psppire_data_window_finish_init (PsppireDataWindow *de,
   GtkWidget *hb ;
   GtkWidget *sb ;
 
-  GtkWidget *box = gtk_vbox_new (FALSE, 0);
+  GtkWidget *box = gtk_box_new (GTK_ORIENTATION_VERTICAL, 0);
 
   de->dataset = ds;
   de->dict = psppire_dict_new_from_dict (dataset_dict (ds));
@@ -878,7 +978,7 @@ psppire_data_window_finish_init (PsppireDataWindow *de,
   psppire_data_store_set_reader (de->data_store, NULL);
 
   menubar = get_widget_assert (de->builder, "menubar");
-  hb = get_widget_assert (de->builder, "handlebox1");
+  hb = get_widget_assert (de->builder, "toolbar");
   sb = get_widget_assert (de->builder, "status-bar");
 
   de->uim = NULL;
@@ -921,48 +1021,28 @@ psppire_data_window_finish_init (PsppireDataWindow *de,
                    G_CALLBACK (on_split_change),
                    de);
 
+  g_signal_connect_swapped (de->dict, "backend-changed",
+                            G_CALLBACK (enable_save), de);
+  g_signal_connect_swapped (de->dict, "variable-inserted",
+                            G_CALLBACK (enable_save), de);
+  g_signal_connect_swapped (de->dict, "variable-deleted",
+                            G_CALLBACK (enable_save), de);
+  enable_save (de);
 
   connect_action (de, "file_new_data", G_CALLBACK (create_data_window));
-
-  connect_action (de, "file_import-text", G_CALLBACK (text_data_import_assistant));
+  connect_action (de, "file_import", G_CALLBACK (file_import));
 
   connect_action (de, "file_save", G_CALLBACK (psppire_window_save));
   connect_action (de, "file_open", G_CALLBACK (psppire_window_open));
-
   connect_action (de, "file_save_as", G_CALLBACK (psppire_window_save_as));
-
   connect_action (de, "rename_dataset", G_CALLBACK (on_rename_dataset));
-
   connect_action (de, "file_information_working-file", G_CALLBACK (display_dict));
-
   connect_action (de, "file_information_external-file", G_CALLBACK (sysfile_info));
 
   g_signal_connect_swapped (get_action_assert (de->builder, "view_value-labels"), "toggled", G_CALLBACK (toggle_value_labels), de);
 
-  connect_action (de, "data_transpose", G_CALLBACK (transpose_dialog));
-  connect_action (de, "data_select-cases", G_CALLBACK (select_cases_dialog));
-  connect_action (de, "data_aggregate", G_CALLBACK (aggregate_dialog));
-  connect_action (de, "transform_compute", G_CALLBACK (compute_dialog));
-  connect_action (de, "transform_autorecode", G_CALLBACK (autorecode_dialog));
-  connect_action (de, "data_split-file", G_CALLBACK (split_file_dialog));
-  connect_action (de, "data_weight-cases", G_CALLBACK (weight_cases_dialog));
-  connect_action (de, "oneway-anova", G_CALLBACK (oneway_anova_dialog));
-  connect_action (de, "paired-t-test", G_CALLBACK (t_test_paired_samples_dialog));
-  connect_action (de, "one-sample-t-test", G_CALLBACK (t_test_one_sample_dialog));
-  connect_action (de, "utilities_comments", G_CALLBACK (comments_dialog));
-  connect_action (de, "transform_count", G_CALLBACK (count_dialog));
   connect_action (de, "transform_recode-same", G_CALLBACK (recode_same_dialog));
   connect_action (de, "transform_recode-different", G_CALLBACK (recode_different_dialog));
-  connect_action (de, "analyze_frequencies", G_CALLBACK (frequencies_dialog));
-  connect_action (de, "crosstabs", G_CALLBACK (crosstabs_dialog));
-  connect_action (de, "univariate", G_CALLBACK (univariate_dialog));
-  connect_action (de, "chi-square", G_CALLBACK (chisquare_dialog));
-  connect_action (de, "binomial", G_CALLBACK (binomial_dialog));
-  connect_action (de, "runs", G_CALLBACK (runs_dialog));
-  connect_action (de, "ks-one-sample", G_CALLBACK (ks_one_sample_dialog));
-  connect_action (de, "k-related-samples", G_CALLBACK (k_related_dialog));
-  connect_action (de, "two-related-samples", G_CALLBACK (two_related_dialog));
 
   {
     GtkWidget *recent_data =
@@ -1038,8 +1118,8 @@ psppire_data_window_finish_init (PsppireDataWindow *de,
 
   g_signal_connect_swapped (get_action_assert (de->builder, "windows_split"), "toggled", G_CALLBACK (toggle_split_window), de);
 
-  merge_help_menu (de->ui_manager);
-
+  gtk_menu_shell_append (GTK_MENU_SHELL (menubar),  create_help_menu (GTK_WINDOW (de)));
+  
   g_signal_connect (de->data_editor, "notify::ui-manager",
                     G_CALLBACK (on_ui_manager_changed), de);
   on_ui_manager_changed (de->data_editor, NULL, de);
@@ -1070,6 +1150,15 @@ psppire_data_window_dispose (GObject *object)
 
   if (dw->dict)
     {
+      g_signal_handlers_disconnect_by_func (dw->dict,
+                                            G_CALLBACK (enable_save), dw);
+      g_signal_handlers_disconnect_by_func (dw->dict,
+                                            G_CALLBACK (on_weight_change), dw);
+      g_signal_handlers_disconnect_by_func (dw->dict,
+                                            G_CALLBACK (on_filter_change), dw);
+      g_signal_handlers_disconnect_by_func (dw->dict,
+                                            G_CALLBACK (on_split_change), dw);
+
       g_object_unref (dw->dict);
       dw->dict = NULL;
     }
@@ -1214,7 +1303,7 @@ psppire_data_window_new (struct dataset *ds)
   GtkWidget *dw;
 
   if (the_session == NULL)
-    the_session = session_create ();
+    the_session = session_create (NULL);
 
   if (ds == NULL)
     {
@@ -1304,7 +1393,8 @@ create_data_window (void)
 }
 
 void
-open_data_window (PsppireWindow *victim, const char *file_name)
+open_data_window (PsppireWindow *victim, const char *file_name,
+                  const char *encoding, gpointer hint)
 {
   GtkWidget *window;
 
@@ -1317,7 +1407,7 @@ open_data_window (PsppireWindow *victim, const char *file_name)
   else
     window = psppire_data_window_new (NULL);
 
-  psppire_window_load (PSPPIRE_WINDOW (window), file_name);
+  psppire_window_load (PSPPIRE_WINDOW (window), file_name, encoding, hint);
   gtk_widget_show_all (window);
 }