fix memory leaks; bug 21056

diff --git a/src/language/stats/ChangeLog b/src/language/stats/ChangeLog
index 4f63f1676e7006dbb1fc9dc0d0ed5f8f52357d1e..21e27f188a7d5df57788fe72c3d73e66f8c0ee3e 100644 (file)
--- a/src/language/stats/ChangeLog
+++ b/src/language/stats/ChangeLog
@@ -1,3 +1,8 @@
+2007-09-21  Jason Stover  <jhs@wonko.gcsu.edu>
+
+       * regression.q (run_regression): Partial fix of memory leak, bug
+       21056.
+
 2007-09-19  Ben Pfaff  <blp@gnu.org>
 
        Fix bug #21108.

diff --git a/src/language/stats/regression.q b/src/language/stats/regression.q
index 0b7250cee58b17361f34a58089ed2b2ad972542a..d923a35b00770ed3e09c04f9cc5cffcf8834c98b 100644 (file)
--- a/src/language/stats/regression.q
+++ b/src/language/stats/regression.q
@@ -1199,8 +1199,6 @@ run_regression (struct casereader *input, struct cmd_regression *cmd,
              lopts.get_indep_mean_std[i] = 1;
            }
          models[k] = pspp_linreg_cache_alloc (X->m->size1, X->m->size2);
-         models[k]->indep_means = gsl_vector_alloc (X->m->size2);
-         models[k]->indep_std = gsl_vector_alloc (X->m->size2);
          models[k]->depvar = dep_var;
          /*
             For large data sets, use QR decomposition.

diff --git a/src/math/linreg/ChangeLog b/src/math/linreg/ChangeLog
index a45216fd1e1f63241331094428572b6f577a3875..08ab14401f39406541a4b157d060fbe8a73787b2 100644 (file)
--- a/src/math/linreg/ChangeLog
+++ b/src/math/linreg/ChangeLog
@@ -1,3 +1,8 @@
+2007-09-21  Jason Stover  <jhs@wonko.gcsu.edu>
+
+       * linreg.c (pspp_linreg_cache_free): Partial fix of memory leak,
+       bug 21056.
+
 2007-08-11  Jason Stover  <jhs@math.gcsu.edu>
 
        * linreg.h (enum): Dropped ambiguous PSPP_LINREG_SVD in favor of

diff --git a/src/math/linreg/linreg.c b/src/math/linreg/linreg.c
index 3b5b50dd5c2d0f8a756fa5005c510f7625a760a9..4fc3b20a74d55bb5d284e5269764edf861312eed 100644 (file)
--- a/src/math/linreg/linreg.c
+++ b/src/math/linreg/linreg.c
@@ -189,6 +189,7 @@ pspp_linreg_cache_free (void *m)
        {
          pspp_coeff_free (c->coeff[i]);
        }
+      free (c->coeff);
       free (c);
     }
   return true;