1 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
3 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
5 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
7 * dictionary.c: (dict_create_var) Fix root cause of bug worked
8 around by previous change log entry.
10 * compute.c: (lvalue_finalize) Remove workaround from previous
13 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
15 * compute.c: Fixed a bug where the Format was not getting set for
16 computed variables (thus causing a crash when SAVEing).
18 * Added a test to stop this bug ever coming back
20 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
22 Got rid of approx.h. In general, replaced all references to
23 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
26 * Makefile.am: (pspp_SOURCES) Removed approx.h.
28 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
29 test for mag < EPSILON.
31 * misc.h: Add definition of EPSILON.
33 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
35 * vfm.c: (procedure) Add check to prevent recursive call.
37 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
39 * Moved the declarations relating to values to their own header file
42 * Added levene.c and levene.h
44 * vars-atr.c: Changed the signature of compare_values to
45 take const * arguments.
47 * t-test.q: Changed the structure of struct t_test_proc
48 variables now contain their own group statistics information.
49 Eventually, t_test_proc might get renamed, because it'd be
50 applicable to other commands too.
52 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
54 * data-out.c: Clean up. Changed interface of convert_*() to take
55 either a `double' or a `const char *' instead of a `const union
56 value *'. Update all implementations of those interfaces.
57 (data_out) Use switch statements instead of a table.
58 (convert_AHEX) Rewrite.
60 * format.h: Update comment.
62 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
64 * q2c.c: (dump_header) Add an Emacs header line to output files
65 that makes generated .c files read-only by default, to make it
66 difficult to accidentally change generated files.
68 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
70 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
71 not bogus a->v.c <=> b->v.c pointer compare.
72 (compare_freq_alpha_a) Ditto.
73 (compare_freq_numeric_d) Ditto.
74 (compare_freq_alpha_d) Ditto.
76 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
78 Changed data_out() to store string data directly into a `union
79 value''s s member, not indirectly into c.
81 * crosstabs.q: (output_pivot_table) Use format_short() instead of
83 (table_value_missing) Ditto.
84 (float_M_suffix) Ditto.
85 (format_short) New function.
87 * data-in.h: (data_in_finite_line) Remove inline definition.
89 * data-list.c: (destroy_dls_var_spec) New function.
90 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
91 (data_list_source_destroy_source) Avoid cast.
92 (struct repeating_data_trns) New field `id_value'. Update
94 (cmd_repeating_data) Initialize id_value. Use new
95 repeating_data_trns_free() for freeing REPEATING DATA
97 (rpd_parse_record) Rewrite support for record ID to be less bogus.
98 (repeating_data_trns_free) New function.
100 * data-out.c: (data_out) Change return type to `void' by replacing
101 error returns by writing a message into the output buffer.
102 (convert_A) Read from v->s instead of v->c.
103 (convert_AHEX) Ditto.
105 * expr-evl.c: Update comment.
106 (expr_evaluate) Add assertion in OP_STRING case.
108 * format.h: (macro MAX_FORMATTED_LEN) New macro.
110 * list.q: (list_cases) Update for new data_out() semantics.
112 * print.c: (print_trns_proc) Ditto.
114 * tab.c: (tab_value) Ditto.
115 (tab_float) Avoid stupid cast.
117 * var.h: Update comments.
118 (macro MAX_STRING) New macro.
119 (macro MAX_ELEMS_PER_VALUE) New macro.
121 * vars-atr.c: (compare_values) New function.
123 * vfm.c: (dump_splits) Update for new data_out() semantics.
125 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
127 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
129 (struct crosstab) Rename v[] to vars[]. All references updated.
130 (hash_table_entry) Replace the hash algorithm and fix a bug at the
131 same time, which caused the hash value to depend only on a single
132 value, not all of the variables' values.
134 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
136 Clean up struct dictionary's value_cnt usage.
138 * dictionary.c: Add a function comment to each function.
139 (struct dictionary) Rename value_cnt to next_value_idx, which more
140 accurately reflects its meaning. All references updated.
141 (dict_rename_vars) Add assertion.
142 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
144 (dict_get_case_size) New function.
146 * aggregate.c: (create_sysfile) Use dict_get_case_size().
148 * get.c: (mtf_read_nonactive_records) Ditto.
150 * sort.c: (allocate_cases) Ditto.
151 (write_initial_runs) Ditto.
155 * vfm.c: (prepare_for_writing) Ditto.
159 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
161 Make vfm.c slightly less grotesque.
163 * vfm.c: (filter_var) Removed.
164 (filter_index) Removed.
165 (FILTERED macro) Removed.
166 (exclude_this_case) New function.
167 (process_active_file_write_case) Use exclude_this_case() instead
168 of FILTERED and inline tests.
169 (procedure_write_case) Ditto.
170 (setup_filter) Removed.
171 (open_active_file) Don't call setup_filter().
172 (close_active_file) Call dict_get_filter() instead of checking
175 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
177 * var.h: (struct variable) Update comments.
179 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
181 New functions dict_create_var_assert(), dict_lookup_var_assert().
182 Converted several dict_*_var()/assert pairs into a single
185 * dictionary.c: (dict_create_var_assert) New function.
186 (dict_lookup_var_assert) New function.
188 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
190 Got rid of "struct long_vec", envector(), devector(), etc. Added
191 two members `init', `reinit' to struct variable as a substitute.
193 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
199 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
202 * autorecode.c: (cmd_autorecode) destvars don't need init.
204 * compute.c: (lvalue_finalize) Set reinit.
206 * data-list.c: (fixed_parse_compatible) Don't need init usually.
207 (dump_fmt_list) Ditto.
210 * descript.q: (run_z_pass) Don't need init for z-scores.
212 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
214 (dict_clone_var) Copy `reinit' member, initialize `init' member.
216 * glob.c: (init_glob) Remove vec_init() calls.
218 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
220 * loop.c: (internal_cmd_loop) Don't need to call envector().
222 * numeric.c: (cmd_numeric) Ditto.
224 (cmd_leave) Ditto. Set `init', `reinit' members.
226 * recode.c: (cmd_recode) Don't need to call envector().
228 * repeat.c: (internal_cmd_do_repeat) Ditto.
230 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
231 (force_create_variable) Removed prototype.
232 (force_dup_variable) Ditto.
234 * vector.c: (cmd_vector) Don't need to call envector().
236 * vfm.c: (reinit_sysmis) Removed.
237 (reinit_blanks) Removed.
239 (init_blanks) Removed.
240 (process_active_file_write_case) No need to deal with vectors.
241 Call clear_temp_case().
242 (vector_initialization) Rewrite to use `init', `reinit'.
243 (close_active_file) No need to call vec_clear().
244 (procedure_write_case) Call clear_temp_case().
245 (clear_temp_case) New function.
247 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
249 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
252 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
254 Add auxiliary argument to procedure() interface. Associated small
255 clean-ups of vfm interface.
257 * Updated every caller of procedure() and process_active_file() to
258 reflect modified interface. Simple, ordinary changes not listed
261 * Updated every function that implements struct case_stream's
262 `read' function to take a write_case_func and a write_case_data.
263 Also updated every caller of write_case() to instead call them
264 through these arguments. In some cases this meant that the extra
265 args had to be threaded through a couple of extra levels. This
266 wasn't difficult or interesting so the details won't be given.
268 * data-list.c: (struct repeating_data_trns) Add members
269 `write_case', `wc_data' as kluge.
270 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
272 (repeating_data_set_write_case) New function.
274 * data-list.h: New file to declare repeating_data_trns_proc() and
275 repeating_data_set_write_case().
277 * inpt-pgm.c: (input_program_source_read) Call
278 repeating_data_set_write_case() for all the REPEATING DATA
279 transformations, so that they know where to send their cases.
280 It's a big kluge. Also kluge in END CASE.
281 (end_case_trns_proc) Never called anymore, but we still need it,
284 * sort.c: (read_sort_output) Update to match struct case_stream
287 * vfm.c: (struct write_case_data) New structure.
289 (virt_proc_func) Removed.
290 (begin_func) Removed.
291 (virt_begin_func) Removed.
293 (write_case) Removed.
294 (procedure) Added an auxiliary parameter to each function pointer
295 argument's prototype. Added an auxiliary data parameter.
297 (process_active_file) Ditto.
298 (process_active_file_write_case) Pass aux data along.
299 (close_active_file) Ditto.
300 (procedure_write_case) Ditto.
301 (SPLIT_FILE_procfunc) Ditto.
303 * vfm.h: (typedef write_case_data) New.
304 (typedef write_case_func) New.
305 (struct case_stream) Add parameters to `read' member prototype.
307 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
309 * t-test.q: Added calculations for independent samples. (But no Levene
312 * Makefile.am: Moved q_sources_c into own variable
314 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
316 Miscellaneous cleanups.
318 * Change unused to UNUSED in many source files to reflect modified
319 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
320 __CYGWIN32__, __unix__, and unix not to assume that they're
321 defined to a nonzero value. Change use of __attribute__ to use
322 NO_RETURN or PRINTF_FORMAT instead.
324 * alloc.h: Move definitions for local_alloc(), local_free() here
325 from ../pref.h.orig and simplify.
327 * expr-evl.c: Instead of working differently based on PAGED_STACK,
328 use a pool allocator unconditionally.
329 (CHECK_STRING_SPACE) Removed.
330 (ALLOC_STRING_SPACE) Removed.
331 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
334 * expr-opt.c: (dump_expression) Allocate string pool.
336 * expr-prs.c: (expr_free) Free string pool.
338 * pool.c: (pool_destroy) This pool must be removed from its
339 parent's list of gizmos, not from its own. Use free_all_gizmos().
340 (pool_clear) New function.
341 (free_all_gizmos) New function.
342 (pool_alloc) Use space in empty block after this one if any.
343 (pool_release) Only empty out blocks, don't actually free() them.
345 * print.c: Get rid of PAGED_STACK special case by always
346 dynamically allocating line buffers.
347 (struct print_trns) Always include the `line' member.
348 (internal_cmd_print) Always initialize the `line' member.
349 (alloc_line) Always allocate memory for `line'.
350 (print_trns_proc) Always initialize buf from `line' member.
351 (print_trns_free) Always free `line' memory.
353 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
356 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
358 * flip.c: Fixed crash from FLIP when a numeric variable is
359 specified on NEWNAMES and a large value is used, and a couple of
360 other minor bugs besides.
361 (struct varname) Make name a 9-character fixed-size array
362 instead of a 1-character variable size array.
363 (make_new_var) Allow digits in variable names.
364 (flip_stream_write) Limit numeric values to 8 characters and
365 format system missing and very large and small values more
368 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
370 * command.c: Fixed test on command return status for the correct
371 value, which had been causing a crash under certain invalid input.
373 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
375 * t-test.q: Added calculations for the one sample variant of the T-TEST
377 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
379 * tab.c: (render_strip) Fix bug that sometimes caused joined text
380 in joined cells to be rendered outside box boundaries.
382 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
384 * random.c (rng_create): Fixed seeding so that it gets reseeded after
385 SET seed=xx has been called.
387 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
389 * random.c (rng_get_double): Fix always-returning-zero bug in my
390 preferred way, and at the same time make sure rounding doesn't
393 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
395 * html.c: (change_attributes) Dead code, removed.
396 (escape_string) Eliminate code to call change_attributes() that
397 never actually called it.
398 (output_tab_table) Get rid of dependence on tab_hit
399 and struct tab_joined_cell's hit member, which are abominations.
401 * tab.c: (tab_output_text) Don't call
402 d->class->text_set_font_by_name if it's a null pointer.
403 (macro UNROLL_LOOP) Eliminate.
404 (macro UNROLL_3_LOOPS) Eliminate.
405 (tabi_render) Rewrite not to use the above macros.
407 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
409 Start working on a new output driver system, one that doesn't suck
410 so much, by adding a "device-independent" output driver. The idea
411 is to write out only a single output stream, then use separate
412 processes to translate them into whatever formats we want. This
413 is similar to how "groff" works with its various output drivers
414 (grops, grotty, grodvi, ...).
416 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
418 * list.q: (write_all_headers) Stub out devind class.
420 (determine_layout) Ditto.
423 * output.c: (outp_init) Add devind class.
425 * devind.c: New file.
427 * devind.h: New file.
429 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
431 * frequencies.q: (hash_value_alpha) Fixed up the previous change
432 to use the proper string length.
434 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
436 * Fixed bug where FREQ would crash on alpha values
438 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
440 * Removed bletcherous alloca() workarounds for AIX from top of
441 many files. AIX can use the alternative alloca() implementation
444 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
446 * ascii.c: (ascii_option) Fix implementation of headers option.
448 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
450 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
451 multiple blank lines into one.
452 (struct ascii_driver_ext) Add squeeze_blank_lines option.
453 (ascii_preopen_driver) Initialize squeeze_blank_lines.
454 (static var option_tab) Add squeeze entry.
455 (ascii_option) Set squeeze_blank_lines.
456 (output_lines) Implement squeezing blank lines.
458 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
460 * Removed redundant code from output.h
462 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
464 Dictionary classes: each variable is "ordinary", "system", or
467 * var.h: (enum dict_class) New enum.
469 * vars-prs.c: (dict_class_from_id) New function.
470 (dict_class_to_name) New function.
472 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
474 * var.h: (struct freq_tab_set) Removed (not used).
476 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
478 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
480 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
482 * stats.c: (hypercube) Rename pow4(). All references updated.
484 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
486 * rename-vars.c: (cmd_rename_variables) Rewritten.
487 (compare_name) Removed.
489 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
491 var_set feature, and code taking advantage of it.
493 * crosstabs.q: (static var var_dict) Removed.
494 (static var variables) New variable.
495 (static var variables_cnt) New variable.
496 (cmd_crosstabs) Free variables instead of var_dict.
497 (internal_cmd_crosstabs) Initialize and use variables,
498 variables_cnt instead of var_dict.
499 (free_var_dict) Removed.
500 (crs_custom_tables) Use var_set instead of a copied dictionary.
501 (crs_custom_variables) Set up variables, variables_cnt instead of
503 [DEBUGGING] (debug_print) Ditto.
505 * means.q: (mns_custom_tables) Use var_set instead of a copied
508 * vars-prs.c: (parse_vs_variable) New function.
509 (parse_dict_variable) Rewritten.
510 (parse_variable) Rewritten.
511 (parse_variables) Renamed parse_var_set_vars(), rewritten.
512 (parse_variables) New function in terms of parse_var_set_vars().
513 Now requires its first argument to be non-null. All references
514 that passed a null pointer updated to pass default_dict instead.
515 (macro id_dict) Removed.
516 (parse_DATA_LIST_vars) Add assertions.
517 (parse_mixed_vars) Ditto.
518 (struct var_set) New structure.
519 (var_set_get_cnt) New function.
520 (var_set_get_var) New function.
521 (var_set_lookup_var) New function.
522 (var_set_destroy) New function.
523 (dict_var_set_get_cnt) New function.
524 (dict_var_set_get_var) New function.
525 (dict_var_set_lookup_var) New function.
526 (dict_var_set_destroy) New function.
527 (var_set_create_from_dict) New function.
528 (struct array_var_set) New structure.
529 (array_var_set_get_cnt) New function.
530 (array_var_set_get_var) New function.
531 (array_var_set_lookup_var) New function.
532 (array_var_set_destroy) New function.
533 (var_set_create_from_array) New function.
535 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
536 instead of parse_variables(NULL, ...) in output code.
538 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
540 Change inp_init from a 2-bit vector to an ordinary array.
541 Initialize it all in cmd_end_input_program() instead of in
544 * inpt-pgm.c: (enum value_init_type) New enum.
545 (global var inp_init) Change to `enum value_init_type *', make
547 (inp_init_size) Removed.
548 (inp_nval) Change to `size_t', make static.
549 (cmd_input_program) Don't initialize inp_init or inp_init_size.
550 (cmd_end_input_program) Initialize inp_init, inp_nval.
552 (clear_case) Rewrite.
554 * inpt-pgm.h: Removed.
556 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
558 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
559 Colin Plumb hash. It is simpler and should better resist
561 (hsh_hash_string) Ditto.
563 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
565 * get.c: (export_write_case_func) Remove debug printing code.
567 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
569 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
571 (save_write_case_func) Use &trns->h instead of cast.
572 (cmd_export) Use &t->h instead of cast.
574 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
576 Moved vectors into the dictionary.
578 * var.h: (struct vector) Moved here from vector.h. `index' member
579 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
584 * vector.c: (global var vec) Removed.
585 (global var nvec) Removed.
586 (cmd_vector) Rewritten.
587 (find_vector) Removed.
589 * dictionary.c: (dict_create_vector) New function.
590 (dict_get_vector) New function, replaces reading global vec[]
592 (dict_get_vector_cnt) New function, replaces reading global nvec
594 (dict_lookup_vector) New function, replaces find_vector().
595 (dict_clear_vectors) New function.
597 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
599 Start to move away from `struct variable' p `union' member to void
602 * var.h: (struct variable) Add `aux' member.
604 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
606 Get rid of struct variable `foo' member.
608 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
610 (frq_custom_variables) Ditto.
611 (frq_custom_grouped) Ditto.
613 * get.c: (struct save_trns) Change `var' member from `int *' to
614 `struct variable **'.
615 (cmd_save_internal) Use aux instead of foo.
616 (save_trns_proc) Use revised `var' member.
617 (static var mtf_seq_no) Renamed mtf_seq_num.
618 (static var mtf_seq_nums) New static var.
619 (cmd_match_files) Initialize mtf_seq_nums.
620 (mtf_free) Free mtf_seq_nums.
621 (mtf_processing) Use mtf_seq_nums instead of foo.
622 (mtf_merge_dictionary) No need to initialize mv->foo.
623 (cmd_export) Use aux instead of foo. Use revised `var' member.
624 (mns_custom_tables) Don't use foo to check for duplicates, that's
625 what PV_NO_DUPLICATE is for.
627 * var.h: (struct variable) Remove `foo' member.
628 (struct frequencies_proc) New member.
630 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
632 Clean up COMPUTE and IF.
634 * compute.c: More or less rewrite the darn thing.
635 (struct compute_trns) Rename and reorder and add and delete
637 (cmd_compute) Rewrite.
638 (compute_num) Make conditional on test expression. Now used for
640 (compute_num_vec) Ditto.
642 (compute_str_vec) Ditto.
645 (if_num_vec) Removed.
647 (if_str_vec) Removed.
648 (parse_target_expression) Renamed parse_rvalue_expression(),
650 (new_trns) Renamed compute_trns_create(), rewritten.
651 (delete_trns) Removed.
652 (free_trns) Renamed compute_trns_free(), rewritten.
653 (struct lvalue) New structure.
654 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
655 (lvalue_get_type) New function.
656 (lvalue_is_vector) New function.
657 (lvalue_finalize) New function.
658 (lvalue_destroy) New function.
660 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
662 * command.def: Disallow MODIFY VARS in input mode, so that
663 variables can't get dropped and confuse cmd_end_input_program()'s
664 attempt to fill inp_init[].
666 * modify-vars.c: (static var forward_positional_ordering) New
668 (struct var_modification) Entirely changed.
669 (rearrange_dict) Interface changed, rewritten.
670 (cmd_modify_vars) Deal with modified struct var_modification, much
672 (struct var_renaming) New structure.
673 (compare_var_renaming_by_new_name) New function.
674 (validate_var_modification) New function.
676 * var.h: (struct modify_vars_proc) Removed.
677 (struct variable) Removed member p.mfv.
679 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
681 Make EVALUATE a valid command whether we're debugging or not, so
682 that `make check' can succeed regardless of whether debugging is
685 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
687 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
689 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
691 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
692 statement by a simple if test.
694 * dfm.c: (dfm_get_record) Add assertion.
696 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
698 For each file x.c, move #include "x.h" to the very top of the
699 include list, to catch x.h failing to include the proper headers.
701 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
703 * algorithm.c: (find) New function.
704 (remove_equal) New function.
705 (set_difference) New function.
706 (adjacent_find_equal) New function.
707 [TEST_UNIQUE] Removed test case.
708 (copy_if) Find end test.
710 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
712 * dictionary.c: (dict_get_case_weight) New convenience function.
714 * aggregate.c: (accumulate_aggregate_info) Use
715 dict_get_case_weight().
717 * frequencies.q: (calc_general) Ditto.
718 (calc_integer) Ditto.
721 * t-test.q: (groups_calc) Ditto.
724 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
726 * glob.c: (global var default_dict) Change from `struct
727 dictionary' to `struct dictionary *'. All references changed.
728 (init_glob) Initialize default_dict with dict_create().
730 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
732 struct dictionary now made opaque. All related functions:
734 * get.c: (rename_variables) Removed.
735 (dict_delete_run) Removed.
737 * temporary.c: (copy_variable) Removed.
738 (new_dictionary) Removed.
739 (save_dictionary) Removed.
740 (restore_dictionary) Removed.
741 (free_dictionary) Removed.
743 * vars-atr.c: (clear_default_dict) Removed.
744 (find_variable) Removed.
745 (find_dict_variable) Removed.
746 (create_variable) Removed.
747 (delete_variable) Removed.
748 (common_init_stuff) Removed.
749 (init_variable) Removed. Updating of inp_init moved into
750 cmd_end_input_program().
751 (replace_variable) Removed.
752 (rename_variable) Removed.
753 (clear_variable) Removed.
754 (dup_variable) Removed.
756 * vars-prs.c: (is_varname) Removed.
757 (is_dict_varname) Removed.
758 (fill_all_vars) Removed.
760 * vector.c: (find_vector) Removed.
762 * weight.c: (stop_weighting) Removed.
764 * dictionary.c: New file.
765 (dict_create) New, replaces new_dictionary().
766 (dict_clone) New, replaces save_dictionary() and
767 restore_dictionary().
768 (dict_clear) New, replaces clear_default_dict().
769 (dict_destroy) New, replaces free_dictionary().
770 (dict_get_var_cnt) New function, replaces references to
772 (dict_get_var) New function, replaces references to dict->var[i].
773 (dict_get_vars) New function, replaces fill_all_vars().
774 (dict_create_var) New, replaces create_variable(). Interface
775 drops `type' parameter, using a zero `width' to designate numeric.
776 (dict_clone_var) New, replaces dup_variable().
777 (dict_rename_var) New, replaces rename_variable().
778 (dict_lookup_var) New, replaces find_variable(),
779 find_dict_variable(), is_varname().
780 (dict_contains_var) New function.
781 (compare_variable_dblptrs) New function.
782 (dict_delete_var) New function, replaces clear_variable().
783 (dict_delete_vars) New function, replaces dict_delete_run().
784 (dict_reorder_vars) New function.
785 (dict_rename_vars) New function, replaces rename_variables().
786 (dict_get_weight) New function, replaces reading dict->weight_var.
787 (dict_set_weight) New function, replaces writing dict->weight_var
788 or calling stop_weight(dict).
789 (dict_get_filter) New function, replaces reading dict->filter_var.
790 (dict_set_filter) New function, replaces writing dict->filter_var.
791 (dict_get_case_limit) New function, replaces reading dict->N.
792 (dict_set_case_limit) New function, replaces writing dict->N.
793 (dict_get_value_cnt) New function, replaces reading dict->nval.
794 (dict_compact_values) New function, replaces a loop that was
795 replicated in several places.
796 (dict_get_split_vars) New function, replaces reading dict->splits.
797 (dict_get_split_cnt) New function, replaces reading
799 (dict_set_split_vars) New function, replaces writing dict->splits.
800 (dict_get_label) New function, replaces reading dict->label.
801 (dict_set_label) New function, replaces writing dict->label.
802 (dict_get_documents) New function, replaces reading
804 (dict_set_documents) New function, replaces writing
807 All references to above functions updated.
809 * aggregate.c: (cmd_aggregate) Copy file label and documents from
810 old dictionary to new by hand, because dict_create() can't do it
811 itself. Use dict_set_documents(), dict_set_split_vars().
813 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
814 calling dict_destroy().
816 * data-list.c: (dls_var_spec) Remove `type' member, replace by
818 (fixed_parse_compatible) Some slightly nontrivial changes for
820 (dump_fmt_list) Ditto.
823 * file-type.c: (create_col_var) Ditto.
825 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
826 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
827 (rename_variables) Use dict_rename_vars().
828 (mtf_merge_dictionary) Use dict_get_documents(),
829 dict_set_documents(), dict_compact_values().
831 * pfm-read.c: (read_variables) Deal with changes to weighting.
833 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
834 is_varname() in output code.
836 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
837 other dictionary functions.
839 * title.c: (add_document_line) Use dict_get_documents(),
840 dict_set_documents().
842 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
843 reset default_handle by hand. dict_clear() will clear vectors so
844 there's no need for that by hand.
846 * vfm.c: (close_active_file) Move call to finish_compaction()
847 earlier, so that we can do the compaction as a single step using
848 dict_compact_values(). Use dict_clear_vectors().
849 (finish_compaction) Use dict_delete_var(), dict_compact_values().
851 Some functions don't have replacements:
853 * vars-atr.c: (force_create_variable) Removed. All references
854 updated to dict_create_var() followed by an assertion.
855 (force_dup_variable) Removed. All references updated to
856 dict_clone_var() followed by an assertion.
858 * weight.c: (update_weighting) Removed. No longer necessary, so
859 all references removed.
861 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
865 * aggregate.c: Eliminate separation of weighted and unweighted
866 case. It made the code too obscure and I doubt it was actually
867 faster. Instead, all code uses the "weighted" code, because
868 that's a generalization of the "unweighted" code.
871 (parse_aggregate_functions) No need to set FWEIGHT.
872 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
873 (dump_aggregate_info) Ditto.
874 (initialize_aggregate_info) No need for special plain_function
875 that gets rid of FWEIGHT option.
877 * aggregate.c: Get rid of approximations.
878 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
880 (aggregate_single_case) Don't use approx_ne().
882 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
884 * ascii.c (ascii_line_width): Dead code, removed.
886 * postscript.c (ps_line_width): Ditto.
888 * q2c.c (xrealloc): Ditto.
890 * count.c (internal_cmd_count): Ditto.
892 * means.q (validate_dependent_endpoint): Ditto.
894 * set.q: (cmd_gset) Ditto.
896 * weight.c: [0] (weight_trns_proc) Ditto.
898 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
900 Make the code -Wmissing-prototypes clean.
902 * Makefile.am (version.c): Add #include "version.h".
904 * ascii.c: (ascii_open_global) Make static.
905 (ascii_close_page) Ditto.
906 (ascii_font_sizes) Ditto.
907 (ascii_postopen_driver) Ditto.
908 (ascii_close_driver) Ditto.
909 (ascii_option) Ditto.
910 (ascii_open_page) Ditto.
911 (ascii_line_horz) Ditto.
912 (ascii_line_vert) Ditto.
913 (ascii_line_intersection) Ditto.
915 (ascii_polyline_begin) Ditto.
916 (ascii_polyline_point) Ditto.
917 (ascii_polyline_end) Ditto.
918 (ascii_text_set_font_by_name) Ditto.
919 (ascii_text_set_font_by_position) Ditto.
920 (ascii_text_set_font_by_family) Ditto.
921 (ascii_text_get_font_name) Ditto.
922 (ascii_text_get_font_family) Ditto.
923 (ascii_text_set_size) Ditto.
924 (ascii_text_get_size) Ditto.
925 (ascii_text_metrics) Ditto.
926 (ascii_text_draw) Ditto.
927 (ascii_close_page) Ditto.
929 * cmdline.h: New header for parse_command_line(). Used where
932 * command.c: Move prototypes for cmd_*() functions to command.h.
934 * command.h: Prototypes for cmd_*() functions moved here from
937 * crosstabs.q: (gamma_int) Ditto.
939 * file-handle.h: Add fh_init_files() prototype.
941 * getline.c: (welcome) Ditto.
943 * glob.h: New header for init_glob(). Used where appropriate.
945 * hash.c: (comparison_helper) Ditto.
947 * html.c: (html_open_global) Ditto.
948 (html_close_global) Ditto.
949 (html_preopen_driver) Ditto.
950 (html_postopen_driver) Ditto.
951 (html_close_driver) Ditto.
953 (html_open_page) Ditto.
954 (html_close_page) Ditto.
957 * inpt-pgm.c: (input_program_source_read) Ditto.
959 * output.c: (find_defn_value) Ditto.
960 (destroy_list) Ditto.
962 * pfm-read.c: (read_int) Ditto.
964 * postscript.c: (ps_open_global) Ditto.
965 (ps_close_global) Ditto.
966 (ps_font_sizes) Ditto.
967 (ps_preopen_driver) Ditto.
968 (ps_postopen_driver) Ditto.
969 (ps_close_driver) Ditto.
971 (ps_open_page) Ditto.
972 (ps_close_page) Ditto.
973 (ps_line_horz) Ditto.
974 (ps_line_vert) Ditto.
975 (ps_line_intersection) Ditto.
977 (ps_polyline_begin) Ditto.
978 (ps_polyline_point) Ditto.
979 (ps_polyline_end) Ditto.
980 (ps_text_set_font_by_name) Ditto.
981 (ps_text_set_font_by_position) Ditto.
982 (ps_text_set_font_family) Ditto.
983 (ps_text_get_font_name) Ditto.
984 (ps_text_get_font_family) Ditto.
985 (ps_text_set_size) Ditto.
986 (ps_text_get_size) Ditto.
987 (ps_text_metrics) Ditto.
988 (ps_text_draw) Ditto.
990 * q2c.c: (finish_up) Ditto.
1002 (force_string) Ditto.
1004 (match_token) Ditto.
1007 (parse_setting) Ditto.
1008 (parse_specifier) Ditto.
1009 (parse_specifiers) Ditto.
1010 (parse_subcommand) Ditto.
1011 (dump_specifier_vars) Ditto.
1013 (make_identifier) Ditto.
1014 (dump_declarations) Ditto.
1015 (dump_specifier_init) Ditto.
1016 (dump_vars_init) Ditto.
1018 (dump_specifier_parse) Ditto.
1019 (dump_subcommand) Ditto.
1020 (dump_parser) Ditto.
1021 (dump_header) Ditto.
1023 (recognize_directive) Ditto.
1025 * recode.c: (string_to_long) Ditto.
1027 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
1029 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
1032 * sort.c: (sort_stream_read) Ditto.
1033 (sort_stream_mode) Ditto.
1035 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
1037 * algorithm.c (binary_search): Fix comparison.
1039 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
1041 * algorithm.c: (binary_search) Fix assertion.
1043 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
1045 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
1047 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
1049 * sort.c: (compare_case_lists) Rewrite.
1051 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
1053 * quicksort.c: Removed (not used).
1055 * quicksort.h: Removed (not used).
1057 * sort.c: Removed blp_quicksort() prototype.
1059 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
1061 * postscript.c: (int_2_compare) Rewrite.
1062 (compare_line) Rewrite.
1064 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
1066 * matrix-data.c (compare_factors) Use lexicographical_compare()
1068 (compare_doubles) New function.
1070 * algorithm.c: (lexicographical_compare) New algorithm.
1072 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
1074 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
1076 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
1078 * expr-prs.c: (cmp_func) Removed.
1079 (parse_function) Use binary_search() algorithm.
1080 (compare_functions) New function.
1081 (init_func_tab) Use sort() algorithm.
1083 * algorithm.c: (binary_search) New algorithm.
1085 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
1087 * descript.q: (display) Use sort() algorithm instead of qsort().
1088 (compare_func) Removed.
1089 (descriptives_compare_variables) New function.
1091 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
1093 Get rid of AVL trees. Hashes are more appropriate for everything
1096 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
1102 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
1104 Much code can be clarified by using C++ STL-like algorithms. Not
1105 all uses of these algorithms are listed below, only the ones where
1106 the change to an algorithm was the only change of interest.
1108 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
1110 * algorithm.c: New file.
1112 * algorithm.h: New file.
1114 * modify-vars.c: (static var forward) Removed.
1115 (static var positional) Removed.
1116 (compare_variables) Removed.
1117 (struct ordering) New.
1118 (cmd_modify_vars) Use sort() algorithm.
1119 (compare_variables_given_ordering) New function.
1120 (rearrange_dict) Use sort() algorithm.
1122 * sysfile-info.c: (cmd_display) Use sort() algorithm.
1123 (cmp_var_by_name) Removed.
1125 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
1127 Make file handles use a hash table.
1129 * file-handle.q: (files) Change to hash table, make static.
1130 (cmd_file_handle) Use hash table functions.
1131 (fh_get_handle_by_filename) Ditto.
1132 (fh_get_handle_by_name) Ditto.
1133 (hash_file_handle) New function.
1134 (cmp_file_handle) Rewrite.
1135 (fh_init_files) Use hash table functions.
1137 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
1139 Clean up FREQUENCIES.
1141 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
1143 * frequencies.q: Remove a lot of old #if'd out code at the end.
1144 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
1145 or calc_weight(). Initialize percentile_values.
1146 (calc) New function based on calc_weight() from frequencies.g.
1147 (precalc) Use hash functions.
1148 (static var comparison_func) Removed.
1149 (static var comparison_param) Removed.
1150 (comparison_helper) Removed.
1151 (get_freq_comparator) New function.
1152 (not_missing) New function.
1154 (postprocess_freq_tab) Use hash table functions, algorithms,
1155 get_freq_comparator(). Rewrite.
1156 (cleanup_freq_tab) Rephrase.
1157 (add_percentile) Clean up spacing.
1158 (hash_value_numeric) New function.
1159 (hash_value_alpha) New function.
1160 (compare_value_numeric_a) Rewrite.
1161 (compare_value_alpha_a) Rewrite.
1162 (compare_value_numeric_d) Rewrite.
1163 (compare_value_alpha_d) Rewrite.
1164 (compare_freq_numeric_a) Rewrite.
1165 (compare_freq_alpha_a) Rewrite.
1166 (compare_freq_numeric_d) Rewrite.
1167 (compare_freq_alpha_d) Rewrite.
1168 (calc_stats) Clean up mode, percentiles, max.
1169 (dump_statistics) Clean up spacing.
1171 * frequencies.g: Removed.
1173 * var.h: (struct freq_tab) Change `data' to hash table.
1175 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
1177 * file-handle.h: Remove declaration of global variable `files',
1178 which wasn't used anywhere.
1180 * postscript.c: (add_encoding) Remove superfluous cast.
1183 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
1186 * temporary.c: [0] (display_tree) Removed.
1188 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
1190 Implement a new random number generator based on the alleged RC4
1193 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
1196 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
1197 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
1199 (static var V[]) Removed.
1200 (static var Y) Removed.
1201 (static var X2) Removed.
1202 (setup_randomize) Removed.
1204 (rand_uniform) Removed.
1205 (rand_normal) Removed.
1206 (struct rng) New structure.
1207 (rng_create) New function.
1208 (rng_destroy) New function.
1209 (swap_byte) New static function.
1210 (rng_seed) New function.
1211 (rng_get_bytes) New function.
1212 (rng_get_int) New function.
1213 (rng_get_unsigned) New function.
1214 (rng_get_double) New function.
1215 (rng_get_double_normal) New function.
1216 (pspp_rng) New function.
1218 * random.h: Sync up to random.c.
1220 * sample.c: (struct sample_trns) Make `frac' unsigned and a
1221 fraction of UINT_MAX, not 65536.
1222 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
1225 * vfm.c: (open_active_file) No need to call setup_randomize() any
1228 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
1230 Change dictionary name indexes to use hash tables instead of AVL
1233 * crosstabs.q: (free_var_dict) Use hash tables.
1234 (crs_custom_tables) Ditto.
1235 (calc_general) Ditto.
1236 (compare_table_entry) Rewrite.
1237 (enum_var_values) Reorder parameters. All references updated.
1240 * get.c: (rename_variable) Use hash tables.
1241 (mtf_merge_dictionary) Ditto.
1243 * glob.c: (init_glob) Use hash tables.
1244 (cmp_variable) Removed.
1246 * means.q: (mns_custom_tables) Use hash tables.
1248 * modify-vars.c: (rearrange_dict) Use hash tables.
1250 * rename-vars.c: (cmd_rename_variables) Use hash tables.
1252 * sfm-read.c: (read_header) Use hash tables.
1253 (read_variables) Ditto.
1255 * temporary.c: (new_dictionary) Use hash tables.
1256 (save_dictionary) Ditto.
1257 (restore_dictionary) Ditto.
1259 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
1260 hash table `name_tab'.
1262 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
1263 [DEBUGGING] (dump_var_tree) Removed.
1264 (find_variable) Use hash tables.
1265 (find_dict_variable) Ditto.
1266 (common_init_stuff) Ditto.
1267 (rename_variable) Ditto.
1268 (clear_variable) Ditto. Also, remove debug code.
1269 (dup_variable) Use hash tables.
1271 * vars-prs.c: (fill_all_vars) Use hash tables.
1272 (is_dict_varname) Ditto.
1273 (parse_dict_variable) Ditto.
1275 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
1277 Change value labels to use hash tables instead of AVL trees, and
1278 change value labels into an ADT.
1280 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
1282 * value-labels.c: New file.
1284 * value-labels.h: New file.
1286 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
1287 Get rid of a stupid use of goto.
1289 * autorecode.c: (compare_alpha_value) Rewrite.
1290 (hash_alpha_value) Ditto.
1291 (compare_numeric_value) Rewrite.
1292 (hash_numeric_value) Ditto.
1294 * frequencies.q: (dump_full) Use value label ADT.
1296 * pfm-read.c: (read_value_label) Use value label ADT.
1298 * pfm-write.c: (write_value_labels) Use value label ADT.
1300 * sfm-read.c: (read_variables) Use value label ADT.
1301 (read_value_labels) Rewrite.
1303 * sfm-write.c: (write_value_labels) Rewrite.
1305 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
1306 (display_variables) Ditto.
1307 (describe_variable) Ditto.
1309 * t-test.q: (print_t_groups) Use value label ADT.
1311 * temporary.c: (copy_variable) Use value label ADT.
1312 (free_dictionary) Ditto.
1314 * val-labs.c: (verify_val_labs) Use value label ADT.
1316 (debug_print) Ditto.
1317 (val_lab_cmp) Removed.
1318 (inc_ref_count) Removed.
1319 (copy_value_labels) Removed.
1321 * var.h: (struct value_label) Removed.
1322 (struct variable) Change AVL tree `val_lab' into hash table
1325 * vars-atr.c: (init_variable) Use value label ADT.
1326 (clear_variable) Ditto.
1327 (free_value_label) Removed.
1328 (free_val_lab) Removed.
1329 (get_val_lab) Removed.
1330 (compare_variables) New function.
1331 (hash_variable) New function.
1333 * vfm.c: (dump_splits) Use value label ADT.
1335 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
1337 Add to the hash table interface.
1339 * hash.c: (hsh_hash_bytes) Add assertion.
1340 (hsh_hash_string) Ditto.
1344 (hsh_create) Ditto. Also make minimum `size'.
1345 (hsh_destroy) Rephrase.
1346 (sort_nulls_last) Removed.
1347 (not_null) New function.
1349 (comparison_helper) Ditto.
1350 (hsh_sort) Rewritten.
1351 (hsh_data_copy) New function.
1352 (hsh_sort_copy) Ditto.
1354 (hsh_replace) Ditto.
1355 (hsh_hash_double) Ditto.
1356 (hsh_delete) Fix stupid bug.
1358 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
1359 * added a calculation of the mode to FREQUENCIES
1361 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
1363 * moved (un)defs of DEBUGGING to config.h
1365 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
1367 * groff-font.c: (add_kern) Fix indentation.
1368 (add_kern) Use & instead of % to take power-of-2 modulus.
1369 (font_get_kern_adjust) Likewise.
1371 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
1373 * autorecode.c: (recode) Replace stupid use of memcpy() by
1375 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
1376 (hash_numeric_value) Ditto.
1377 (autorecode_proc_func) pool_strdup() was wrong here because the
1378 source string was not null-terminated. Use new pool_strndup()
1381 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
1382 use of hsh_iterator_init().
1384 * data-in.c: (parse_N) Initialize i->v->f.
1386 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
1389 * groff-font.c: Use power-of-2 hash table sizes, not prime.
1390 (groff_read_font) Don't call hsh_next_prime(). Don't call
1392 (static var hash) Remove `size_p', `max_used' members.
1393 (font_char_name_to_index) Don't call hsh_next_prime(). Use
1394 hsh_hash_string() instead of hashpjw(), & instead of %.
1395 (default_font) Don't call hsh_next_prime().
1397 * pool.c: (pool_strndup) New function.
1398 (pool_strdup) Reimplement in terms of pool_strndup.
1400 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
1402 (hash_ps_encoding) Use hsh_hash_string().
1403 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
1404 (hash_filename2font) Use hsh_hash_string().
1406 * som.c: Add #include <stdlib.h>.
1408 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
1409 (by destroying its pool).
1411 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
1413 Miscellaneous hash table code cleanup:
1415 * hash.h: (struct hsh_table) Moved into hash.c.
1416 (hsh_count) Ditto, and transformed into function.
1417 (hsh_compare_func) New typedef, used for defining otherwise-long
1418 function types here and in hash.c
1419 (hsh_hash_func) Ditto.
1420 (hsh_free_func) Ditto.
1422 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
1423 `table' to `entries'. Removed `mp'. All references updated.
1424 (hsh_clear) Don't shrink entries array; if the hash was this big
1425 once, it probably will be again.
1426 (hsh_rehash) Made static.
1427 (force_hsh_insert) Renamed hsh_force_insert.
1428 (force_hsh_find) Renamed hsh_force_find.
1430 Made hash table sizes powers of 2, because that's fine with any
1431 reasonable hash function and because taking a power-of-2 modulus
1432 is faster than any other:
1434 (hsh_prime_tab) Removed;
1435 (hsh_next_prime) Ditto.
1436 (next_power_of_2) New function.
1437 (hsh_create) Use next_power_of_2.
1438 (hsh_rehash) Use & instead of %.
1440 Cleaned up hsh_sort:
1442 (internal_comparison_fn) Removed.
1443 (sort_nulls_last) New function.
1444 (hsh_sort) Removed second parameter, switched to using the new
1445 quicksort() function from quicksort.h to avoid using nasty need
1446 for static variables with qsort(). All references updated.
1448 Changed the hash functions offered, because there are better hash
1449 functions than the ones we had, and cleaned up the names to boot:
1451 * hash.c: (hashpjw_d) Removed.
1453 (hsh_hash_bytes) New function.
1454 (hsh_hash_string) New function.
1455 (hsh_hash_int) New function.
1457 Improved the hash table iteration interface:
1459 * hash.h: (hsh_iterator_init) Removed.
1460 (struct hsh_iterator) Removed `init' member, change `next' to
1463 * hash.c: (hsh_foreach) Removed. All references updated to use
1464 hsh_first/hsh_next instead.
1465 (hsh_first) New function. Notably, unlike hsh_foreach() it does
1466 not treat a null pointer as an empty hash table.
1467 (hsh_next) New function.
1469 Made deletion possible, though slow:
1471 * hash.c: (locate_matching_entry) New function.
1472 (hsh_find) Use locate_matching_entry().
1473 (hsh_delete) New function also using locate_matching_entry().
1474 (hsh_force_delete) New function.
1476 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
1478 * quicksort.c: New file implementing a sort routine with a
1479 interface better than qsort() because it passes a user-provided
1480 parameter to the sort routine.
1482 * Makefile.am: Add quicksort.c, quicksort.h.
1484 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
1486 * All source files: Get rid of nasty special cases for Checker,
1487 which is pretty obsolete now.
1489 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
1491 * Fixed a bug apparent when using the FREQUENCIES command with the
1492 html driver. The html driver was incorrectly trying to display
1495 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
1497 * Makefile.am: Reorganized. Put locale dir in version.c instead
1498 of passing it to each compile command. Only put local gmp libs in
1499 LD_ADD if not installed on system. Remove `boast' target.
1501 * All source files: struct and union typedefs eliminated.
1502 `sizeof type' replaced by `sizeof object' where practical. Moved
1503 `unused' qualifiers from start to end of declarations for gcc
1504 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
1505 assertions on pointers strictly compliant. Removed _ prefixes on
1506 some function parameter names.
1508 * alloc.c: New source file, containing these external linkage
1509 functions removed from common.c: xmalloc, xcalloc, xrealloc,
1516 * ascii.c: Migrated from arenas to pools.
1517 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
1518 c_string to len_string. All references changed.
1519 (ascii_option) Signature changed to comply to new output.c
1521 (count_fancy_chars) Removed.
1522 (delineate) Removed support for rich text.
1523 (ascii_text_metrics) Ditto.
1525 (output_shorts) Change `box', `off', `on' from c_string to
1526 len_string. Change `remaining' from int to size_t.
1527 (ascii_close_page) Make page numbering less haphazard.
1529 * autorecode.c: Migrate from arenas to pools.
1531 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
1533 * bitvector.h: New file containing these macros from misc.h:
1534 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
1536 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
1537 word[3]. ncmd removed.
1538 (var empty_string) Removed.
1539 (var cmd_table) Declaration updated.
1540 (var cmdtab) Removed.
1541 (cmp_command) Removed.
1542 (split_words) Rewritten to use strtok_r().
1543 (init_cmd_parser) Renamed cmd_init(). Rewritten.
1544 (find_command) Removed.
1545 (FILE_TYPE_okay) Rewritten.
1546 (cmd_parse) Rewritten. Semantics of the return value of command
1547 handlers has changed: they must now return one of the new CMD_*
1548 enumerals, rather than a magic value. This meant that all
1549 commands had to be modified, and they were.
1550 (figure_out_command) New function.
1552 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
1553 #defines for INIT, INPU, etc.
1555 * command.h: New CMD_* enum series.
1556 (cur_proc) Make const char *, not char *.
1557 (cmd_init) Prototype.
1560 * common.c: Removed.
1562 * common.h: Removed.
1564 * correlations.q: New file.
1566 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
1568 (custom_tables) Renamed crs_custom_tables().
1569 (custom_variables) Renamed crs_custom_variables().
1570 (calc_integer) Add in some `const' qualifiers.
1571 (table_value_missing) Change from a_string to len_string.
1572 (float_M_suffix) Change from a_string to len_string.
1574 * data-in.c: Rewritten. All references to
1575 parse_string_as_format() changed to data_in().
1577 * data-in.h: New file.
1579 * data-list.c: Change DLS_* from #define's to enums. Move from
1580 rpd_msg() to tmsg().
1581 (RPD_ERR) New #define.
1582 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
1584 (read_from_data_list_fixed) Change from old
1585 parse_string_as_format() to new data_in().
1586 (read_from_data_list_free) Ditto.
1587 (read_from_data_list_list) Ditto.
1588 (cmd_repeating_data) Modify approach to checking for end of
1591 (rpd_parse_record) Change from old parse_string_as_format() to new
1592 data_in(). Change from old convert_format_to_string() to new
1594 (read_one_set_of_repetitions) Change dfm_push_cust() to
1595 dfm_push(), pop_cust() to dfm_pop().
1597 * data-out.c: Rewritten. All references to
1598 convert_format_to_string() changed to data_out().
1600 * descript.q: Migrate to new q2c.
1601 (cmd_descriptives) Removed.
1602 (internal_cmd_descriptives) Renamed cmd_descriptives ().
1603 (custom_variables) Renamed dsc_custom_variables().
1605 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
1607 (open_file_r) Initialize h->where.line_number. Migrate to new
1609 (open_file_w) Initialize h->where.line_number.
1610 (read_record) Change from ext->ln to h->where.line_number.
1611 Migrate to struct string.
1612 (dfm_put_record) Rephrased.
1613 (dfm_push_cust) Renamed dfm_push(), rewritten.
1614 (dfm_pop) New function.
1616 * error.c: All references updated.
1617 (glob var error_count) Renamed err_err_count.
1618 (glob var warning_count) Renamed err_warning_count.
1619 (glob var error_already_flagged) Renamed err_already_flagged.
1620 (glob var verbosity) Renamed err_verbosity.
1621 (glob var cust_fn) Removed.
1622 (glob var cust_ln) Removed.
1623 (static var file_loc) New.
1624 (static var nfile_loc) New.
1625 (static var mfile_loc) New.
1626 (tmsg) New function.
1627 (push_cust) Removed.
1630 (static var terminating) Removed.
1631 (failure) Renamed err_failure().
1632 (hcf) Renamed err_hcf().
1633 (err_push_file_locator) New function.
1634 (err_pop_file_locator) New function.
1635 (err_location) New function.
1636 (check_error_count) Renamed err_check_count().
1637 (vmsg) Renamed err_vmsg(). Interface changed.
1638 (verbose_msg) Removed.
1639 (err_cond_fail) New function.
1640 (error_break) Renamed err_break().
1642 * error.h: All references updated.
1643 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
1644 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
1646 (struct file_locator) New.
1648 (macro verbose_msg) Removed.
1649 (macro cond_fail) Removed.
1651 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
1653 * expr-prs.c: Reorganized. All references updated.
1654 (exprtypename) Renamed expr_type_name().
1655 (typename) Renamed type_name().
1656 (free_expression) Renamed expr_free().
1657 (parse_expression) Renamed expr_parse(). Uses new type_check()
1659 (init_functab) Renamed init_func_tab().
1660 (type_check) New function.
1661 (parse_or) Rewritten to use new allocate_nonterminal() and
1662 append_nonterminal_arg() functions.
1665 (parse_rel) Ditto. Also simplified logic.
1670 (SYSMIS_func) Ditto.
1671 (VALUE_func) Rephrased.
1672 (CONCAT_func) Fix memory leak by replacing free by free_node on
1674 (generic_str_func) Ditto.
1675 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
1677 (allocate_nonterminal) New function.
1678 (append_nonterminal_arg) New function.
1679 (static func_tab[]) Now at file level.
1681 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
1683 * expr.h: (enum series OP_*) Moved to exprP.h.
1684 (OP_* defines) Ditto.
1685 (struct op_desc) Ditto.
1686 (global ops[]) Ditto.
1687 (struct num_con_node) Ditto.
1688 (struct str_con_node) Ditto.
1689 (struct var_node) Ditto.
1690 (struct lag_node) Ditto.
1691 (struct casenum_node) Ditto.
1692 (struct nonterm_node) Ditto.
1693 (union any_node) Members renamed.
1694 (struct sys_node) Removed.
1695 (struct val_node) Removed.
1696 (operator typedef) Removed.
1697 (typedef exprtype) Removed.
1698 (enum series EX_*) Moved to exprP.h.
1699 (struct expression) Ditto. Also renamed a lot of the members.
1700 (PXP_* defines) Changed to enums.
1701 (free_node prototype) Moved to exprP.h.
1703 * file-handle.h: (struct file_handle) New member `where'.
1705 * file-handle.q: Migrated to new q2c format.
1706 (prepend_current_directory) Removed (dead code).
1707 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
1708 (fh_get_handle_by_filename) Removed dead code.
1709 Set new `where' member.
1711 * file-type.c: (file_type_source_read) References to
1712 parse_string_as_format() changed to data_in().
1713 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
1715 * filename.c: All references updated.
1716 (init_filename) Renamed fn_init().
1717 (expand_line) Removed.
1718 (macro EXPAND_LINE) Removed.
1719 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
1720 of custom functions.
1721 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
1722 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
1723 (normalize_filename) Renamed fn_normalize().
1724 (search_path) Renamed fn_search_path(), rewritten.
1725 (prepend_dir) Renamed fn_prepend_dir().
1726 (blp_getenv) Renamed fn_getenv().
1727 (blp_dirname) Renamed fn_dirname().
1728 (fn_basename) New function, not used.
1729 (absolute_filename_p) Renamed fn_absolute_p().
1730 (is_special_filename) Renamed fn_special_p().
1731 (file_exists) Renamed fn_exists_p().
1732 (readlink_malloc) Renamed fn_readlink().
1733 (getenv_default) Renamed fn_getenv_default().
1734 (open_file) Renamed fn_open().
1735 (close_file) Renamed fn_close().
1736 (open_file_ext) Renamed fn_open_ext().
1737 (close_file_ext) Renamed fn_close_ext().
1739 * font.h: Migrate from arenas to pools.
1741 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
1743 * frequencies.g: Migrate from arenas to pools.
1745 * frequencies.q: Migrate to new q2c version. Migrate from arenas
1748 * getline.c: All references updated.
1749 (global getl_buf) Changed from char * to struct string.
1750 (static getl_include_path) Ditto.
1751 (global getl_buf_len) Removed.
1752 (global getl_buf_size) Removed.
1753 (getl_include_path) Deal with new getl_buf, getl_include_path.
1754 (getl_uninitialize) New function.
1755 (getl_get_current_directory) Rewritten.
1756 (getl_clear_include_path) Rewritten.
1757 (getl_add_include_dir) Rewritten.
1758 (getl_add_file) Assertion fixed.
1759 (getl_add_virtual_file) Change initial value of `remaining_loops'
1761 (welcome) Rewritten.
1762 (handle_line_buffer) Make static. Change logic to make
1763 getl_add_virtual_file() change sensible. Use ds_*() strings.
1764 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
1765 (getl_close_file) Moved.
1766 (getl_location) New function.
1768 * getline.h: All references updated.
1769 (macro curln) Removed.
1770 (macro curfn) Removed.
1771 (macro am_interactive) Renamed getl_am_interactive.
1772 (macro am_reading_script) Renamed getl_reading_script.
1774 * glob.c: (global fmt_parse_ignore_error) Removed.
1775 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
1776 systems that support it (C99). Turn off SET ECHO by default. No
1777 necessary julcal initialization anymore.
1779 * groff-font.c: Migrate from arenas to pools.
1780 (groff_read_font) Use err_push_file_locator().
1781 (groff_read_DESC) Ditto.
1782 (font_msg) Use tmsg().
1784 * hash.c: (hsh_sort) Fix debug code.
1785 [GLOBAL_DEBUGGING] Include stdio.h.
1787 * hash.h: (macro force_hsh_insert) Rephrase.
1789 * heap.c: Rewritten.
1791 * heap.h: Rewritten.
1793 * html.c: (html_option) Change from outp_value to struct string.
1794 (postopen) Change from curfn to getl_location().
1795 (escape_string) Remove rich-text code. Signature changed.
1796 (output_tab_table) Switch from a_string to struct len_string.
1797 Remove rich text support.
1799 * lexer.c: All references updated. Largely rewritten. Major
1800 changes listed below. Removed tagged quote support. Adapted to
1801 struct string tokstr.
1802 (global tokstr) Changed to struct string.
1803 (global tokstr_size) Removed.
1804 (global tokstr_len) Removed.
1806 (global tokint) Removed.
1807 (global toklongstr) Removed.
1808 (C* defines) Removed.
1809 (static tbl[]) Removed.
1810 (static id[]) Removed.
1811 (static une[]) Removed.
1812 (discard_line) Renamed lex_discard_line().
1813 (get_entire_line) Renamed lex_entire_line().
1814 (get_rest_of_line) Renamed lex_rest_of_line().
1815 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
1816 (make_hexit) Removed.
1817 (syntax_error) Renamed lex_error(). Return value removed.
1818 (get_token_representation) Renamed lex_token_representation().
1819 (putback) Renamed lex_put_back().
1820 (putfwd) Renamed lex_put_forward().
1821 (convert_negative_to_dash) Renamed lex_negative_to_dash().
1822 (set_prog) Renamed lex_set_prog().
1823 (init_lex) Renamed lex_init().
1824 (reset_eof) Renamed lex_reset_eof().
1825 (lookahead) Renamed lex_look_ahead().
1826 (check_id) Rewritten.
1827 (yylex) Renamed lex_get(), rewritten.
1828 (lex_end_of_command) New function. Many commands were rephrased
1830 (lex_integer_p) New function. Replaces compare of tokint against
1832 (lex_integer) New function. Replaces tokint.
1833 (match_tok) Renamed lex_match().
1834 (match_id) Renamed lex_match_id().
1835 (match_int) Renamed lex_match_int().
1836 (force_match_id) Renamed lex_force_match_id(), added return value.
1837 (force_match) Renamed lex_force_match(), added return value.
1838 (force_string) Renamed lex_force_string(), added return value.
1839 (force_int) Renamed lex_force_int(), added return value.
1840 (lex_id_match_len) New function.
1841 (id_match) Renamed lex_id_match(), rewritten.
1842 (get_line) Renamed lex_get_line().
1843 (preprocess_line) Renamed lex_preprocess_line().
1844 (tokname) Renamed lex_token_name().
1845 (bin_value_func) Removed.
1846 (oct_value_func) Removed.
1847 (hex_value_func) Removed.
1848 (unexpected_eof) New function.
1849 (convert_numeric_string_to_char_string) New function.
1850 (parse_string) Rewritten, signature changed.
1851 (add_tokstr_char) Removed.
1852 (add_tokstr_unsigned) Removed.
1853 (add_tokstr_string) Removed.
1854 (parse_tagged_quote) Removed.
1855 (skip_comment) Renamed lex_skip_comment().
1857 * lexer.h: All references updated.
1858 (macro is_id1) Renamed CHAR_IS_ID1.
1859 (macro is_idn) Renamed CHAR_IS_IDN.
1860 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
1861 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
1862 (macro get_token) Removed.
1863 (macro id_match) Removed.
1864 (macro force_match_id) Removed.
1865 (macro force_match) Removed.
1866 (macro force_string) Removed.
1867 (macro force_int) Removed.
1868 (macro force_num) Removed.
1869 (macro force_id) Removed.
1871 * lexerP.h: Removed.
1873 * list.q: Migrated to new q2c format.
1874 (write_line) Deal with struct len_string.
1875 (write_varname) Ditto.
1876 (write_fallback_headers) Ditto.
1878 * magic.c: New file, incorporating the following global variables
1879 previously in other files: endian, second_lowest_value. And both
1880 of those are conditional on #define's.
1882 * magic.h: New file, incorporating the following global variable
1883 declarations: endian, second_lowest_value, and the following macro
1884 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
1886 * main.c: Added declarations of pgmname, finished, curdate,
1888 (main) Call new parse_script() function.
1889 (parse_script) New function.
1890 (execute_command) New function.
1891 (dump_token) Removed.
1892 (handle_error) New function.
1894 * matrix.c: New file.
1896 * matrix.h: New file.
1898 * matrix-data.c: Migrated from arenas to pools.
1899 (mget_token) Change from parse_string_as_format() to data_in().
1901 * means.q: Migrate to new q2c.
1902 (custom_tables) Renamed mns_custom_tables().
1903 (custom_crossbreak) Renamed mns_custom_crossbreak().
1904 (custom_variables) Renamed mns_custom_variables().
1906 * mis-val.c: (static var width) Changed from `int' to `size_t'.
1907 (parse_varnames) Prototype.
1908 (parse_numeric) Rephrasings.
1909 (parse_alpha) Adapt to new struct string tokstr.
1911 * misc.c: (intlog10) Rewritten.
1913 (ansi_rand) Renamed real_rand(), moved into random.c.
1914 (ansi_srand) Renamed real_srand(), moved into random.c.
1915 (setup_randomize) Moved to random.c.
1916 (rand_uniform) Ditto.
1917 (rand_normal) Ditto.
1918 (rand_simple) Ditto.
1919 (get_config_line) Removed.
1920 (reverse) Removed (dead code).
1922 * misc.h: (macro SET_BIT) Moved to bitvector.h.
1923 (macro CLEAR_BIT) Ditto.
1924 (macro TEST_BIT) Ditto.
1925 (macro SET_BIT_TO) Ditto.
1926 (macro BIT_INDEX) Ditto.
1928 * output.c: (outp_read_devices) Move to err_push_file_locator()
1929 from push_cust(). Use struct string.
1930 (expand_op_tokstr) Removed.
1931 (static var op_tokstr) Changed to struct string.
1932 (static var op_tokstr_size) Removed.
1933 (tokener) Rephrasings. Use struct string.
1934 (parse_options) Use struct string.
1935 (destroy_driver) Fix assertion.
1936 (outp_get_paper_size) Move to err_push_file_locator().
1937 [0] Removed dead code.
1938 (outp_string_width) Move to len_string.
1940 * output.h: Comment fixes.
1941 (TAG_* enum series) Removed.
1942 (struct outp_value) Removed.
1943 (enum OUTP_T_FANCY) Removed.
1944 (struct outp_text) `s' changed from a_string to len_string.
1945 (struct outp_class) `option' change arg 3 from outp_value to
1948 * pfm-read.c: (corrupt_msg) Rewritten.
1950 * pfm-write.c: (bufwrite) Fix assertion.
1952 * pool.c: New file, reference version.
1954 * pool.h: New file, reference version.
1956 * postscript.c: (ps_font_sizes) Fix assertion.
1957 (ps_option) Change arg 3 from outp_value to struct string.
1958 Adapt to struct string.
1959 (macro output_line) Removed.
1960 (macro add_string) Removed.
1961 (output_encodings) Adapted to struct string. Moved to
1962 err_push_file_locator().
1963 (find_encoding_file) Fix assertion.
1964 (read_ps_encodings) Move to err_push_file_locator().
1965 (postopen) Use getl_location() instead of curfn.
1966 (out_text_plain) Move to len_string.
1967 (text) Ditto. Remove rich text support.
1969 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
1970 (cmd_print_eject) Ditto.
1972 (internal_cmd_print) Now cleans up after itself. Uses
1973 fh_parse_file_handle() now.
1974 (cmd_print_space) Use PXP_NUMERIC to type-check.
1976 * q2c.c: Overhauled. Removed _("") i18n support. All references
1977 updated. All output functions updated to handle structures rather
1978 than local or static variables. Adapt to new PSPP lex_*()
1982 (macro MAX_N_SBC) Removed.
1983 (global bare) Removed.
1984 (enum STRING) Renamed T_STRING.
1985 (enum ID) Renamed T_ID.
1986 (get_buffer) Buffer size increased.
1987 (strlower) Renamed st_lower(), rephrased.
1988 (strupper) Renamed st_upper(), rephrased.
1989 (skip_ws) New function.
1990 (get_line) Don't special-case any types of lines (like those
1991 beginning with ! or $, for instance).
1992 (get_token) Renamed lex_get(). Rephrased.
1993 (static var `prefix') New.
1994 (parse) New function.
1995 (parse_setting) Minor rephrasing.
1996 (dump_specifier_vars) Ditto.
1997 (make_identifier) Put null terminator on identifier, duh.
1998 (dump_vars) Renamed dump_declarations(). Never indent. Never
1999 static. Output changed entirely.
2000 (dump_specifier_init) Rephrase.
2001 (dump_vars_init) No index variable needed. Other modifications.
2002 (dump_parser) Don't parse command name. Do dump functions instead
2003 of just code fragments.
2004 (dump_free) Dump function instead of code fragment.
2005 (recognize_directive) New function.
2006 (main) Use recognize_directive(). Don't rely on magic $ line
2007 beginning: instead, parse comments. Update list of headers.
2009 * random.c: New file, containing the following functions:
2010 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
2011 rand_normal, rand_simple.
2013 * random.h: New file.
2015 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
2016 function. `max_src_width', `max_dst_width' changed to size_t.
2017 (internal_cmd_recode) Removed.
2018 (parse_dest_spec) Merge similar cases.
2019 (parse_src_spec) Add assertion.
2021 * repeat.c: (recognize_keyword) New function.
2022 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
2023 REPEAT. Improve recognition of END REPEAT (use
2024 recognize_keyword()). Move from curfn to getl_location(). Use
2027 (perform_DO_REPEAT_substitutions) Adapt to struct string.
2029 * set.q: Adapt to new q2c.
2030 (cmd_set) Range-check some values better.
2031 (custom_blanks) Renamed stc_custom_blanks().
2032 (custom_length) Renamed stc_custom_length().
2033 (custom_results) Renamed stc_custom_results().
2034 (custom_seed) Renamed stc_custom_seed().
2035 (custom_width) Renamed stc_custom_width().
2036 (custom_format) Renamed stc_custom_format().
2037 (custom_journal) Renamed stc_custom_journal().
2038 (custom_color) Renamed stc_custom_color().
2039 (custom_listing) Renamed stc_custom_listing().
2040 (custom_disk) Renamed stc_custom_disk().
2041 (custom_log) Renamed stc_custom_log().
2042 (custom_rcolor) Renamed stc_custom_rcolor().
2043 (custom_viewlength) Renamed stc_custom_viewlength().
2044 (custom_workdev) Renamed stc_custom_workdev().
2046 * settings.h: Not necessary to include format.h any longer.
2048 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
2049 (corrupt_msg) Rewritten.
2051 * sort.c: Adapt to rewritten heap ADT.
2053 * str.c: (aa_strcpy) Removed.
2054 (ab_strcpy) Removed.
2055 (ac_strcpy) Removed.
2056 (ba_strcpy) Removed.
2057 (bb_strcpy) Removed.
2058 (ca_strcpy) Removed.
2059 (aa_strdup) Removed.
2060 (aa_strdupcpy) Removed.
2061 (ba_strdup) Removed.
2062 (sa_strdup) Removed.
2063 (memrev) Renamed mm_reverse().
2064 (memrmem) Renamed mm_find_reverse().
2065 (cmp_str) Renamed st_compare_pad().
2066 (strmaxcpy) Removed.
2067 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
2068 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
2070 (strpadcpy) Renamed st_pad_copy(), signature changed.
2071 (blpstrset) Removed.
2072 (ds_create) New function.
2073 (ds_init) New function.
2074 (ds_replace) New function.
2075 (ds_destroy) New function.
2076 (ds_clear) New function.
2077 (ds_extend) New function.
2078 (ds_shrink) New function.
2079 (ds_truncate) New function.
2080 (ds_length) New function.
2081 (ds_size) New function.
2082 (ds_value) New function.
2083 (ds_end) New function.
2084 (ds_concat) New function.
2085 (ds_concat_buffer) New function.
2086 (ds_printf) New function.
2087 (ds_putchar) New function.
2088 (ds_getline) New function.
2089 (ds_get_config_line) New function derived from the old
2090 misc.c:get_config_line().
2091 (ls_create) New function.
2092 (ls_create_buffer) New function.
2093 (ls_init) New function.
2094 (ls_shallow_copy) New function.
2095 (ls_destroy) New function.
2096 (ls_null) New function.
2097 (ls_null_p) New function.
2098 (ls_empty_p) New function.
2099 (ls_length) New function.
2100 (ls_value) New function.
2101 (ls_end) New function.
2103 * str.h: Reformatted.
2104 (struct a_string) Removed.
2105 (struct b_string) Removed.
2106 (struct c_string) Removed.
2107 (struct len_string) New.
2108 (struct string) New.
2109 (macro as_streq) Removed.
2110 (macro bs_streq) Removed.
2111 (macro cs_streq) Removed.
2112 (macro sa_streq) Removed.
2113 (macro sb_streq) Removed.
2114 [__GNUC__] (inline function ds_putchar) New function.
2115 [__GNUC__] (inline function ds_length) New function.
2116 [__GNUC__] (inline function ds_value) New function.
2117 [__GNUC__] (inline function ds_end) New function.
2119 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
2120 (display_vectors) Fix missing i18n.
2122 * t-test.q: Migrate to new q2c.
2124 * tab.c: Migrate from arenas to pools.
2125 (tab_create) Use struct len_string.
2126 (tab_realloc) Ditto.
2127 (text_format) Ditto.
2128 (tab_joint_text) Ditto.
2129 (tab_natural_width) Remove rich text support.
2130 (tab_natural_height) Ditto.
2131 (tab_output_text) Handle TAT_FIX.
2132 (tab_raw) Change arg from a_string to len_string.
2133 (tabi_driver) Fix assertion. Use struct len_string.
2134 (render_strip) Use struct len_string. Remove rich text support.
2135 Add `const' qualifiers.
2137 * tab.h: (enum TAB_RICH) Remove.
2138 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
2139 SOM_COL_* updated to read TAB_COL_*.
2140 (struct tab_table) Change arena to pool. Change a_string to
2143 * temporary.c: (restore_dictionary) Rewrite Checker code.
2145 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
2146 LOWEST, HIGHEST) Moved here from common.h.
2147 (typedef any_trns) Removed. All references changed to `struct
2150 * vars-atr.c: (force_create_variable) Fix assertion.
2151 (force_dup_variable) Fix assertion.
2153 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
2155 Using alphanumeric variables in functions under AGGREGATE
2156 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
2157 <BZN-mdksh@t-online.de> for reporting this bug.
2159 * aggregate.c: (parse_aggregate_functions) When setting the
2160 FSTRING bit, also allocate memory for the `string' member of
2162 (free_aggregate_functions) Free iter->string. Don't use the
2163 non-function bits when indexing the array of functions.
2164 [DEBUGGING] (debug_print) Don't use the non-function bits when
2165 indexing the array of functions.
2167 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
2169 Under certain circumstances, the final case would be omitted from
2170 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
2171 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
2173 * aggregate.c (agr_00x_end_func): Increment number of cases in
2174 sink before writing case. For streams that keep track of how many
2175 cases there are based on this value, this means that the last case
2176 will be read in on the next stream read.
2178 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
2180 Undefined behavior was invoked by referencing a freed pointer.
2182 * vfm.c (memory_stream_write): Free pointer *after* checking for
2185 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
2187 A wrong record size was displayed when paging the active file to
2190 * vfm.c: (memory_stream_write) Fix off-by-one error.
2192 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
2194 Not having enough temporary space for sorting caused a core dump.
2197 * sort.c: (allocate_cases) Initialize i.
2199 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
2201 Syntax errors in function descriptions on AGGREGATE caused core
2204 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
2205 free_aggregate_functions(), since that function already frees
2208 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
2210 A null pointer was dereferenced, causing a core dump, when
2211 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
2212 but PSPP still doesn't calculate percentiles. Thanks to Regnor
2213 Jernsletten <rjernsle@eunet.no> for reporting this problem.
2215 * arena.c: (arena_malloc) If the arena hasn't been initialized
2216 already, initialize it.
2218 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
2220 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
2221 for compilation with Cygnus Windows B20. Not used by other
2224 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
2226 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
2227 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
2229 * sort.c: (compare_case_lists) Reverse sense of comparison if
2230 sorting in descending order.
2231 (compare_record) Ditto.
2233 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
2235 SPLIT FILE with a string variable caused a core dump. Fixed.
2237 * vfm.c: If the variable is a string then make a temporary value
2238 struct pointing to it. The underlying problem is a lot bigger
2239 than this (see TODO) but this is a stopgap for the simple case at
2242 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
2244 Nested INCLUDEs didn't work. Fixed.
2246 * getline.c: (getl_include) Set first_line to NULL in allocated
2249 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
2251 The MATCH FILES procedure set the values of variables not present
2252 to 0. It should have been SYSMIS. This is now fixed.
2254 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
2256 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
2258 The REMARK command was too aggressive about skipping lines. It
2259 didn't like being the last command in a file.
2261 * command.c: (cmd_remark) Call get_entire_line() instead of
2264 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
2266 Comment parsing wasn't consistent with the rest of the code in its
2267 idea of where one command ends and another starts. This meant
2268 that sometimes commands would be mysteriously ignored. Thanks to
2269 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
2271 * command.c: (parse_cmd) Hand off comment parsing to new function
2272 skip_comment() in lexer.c.
2273 * lexer.c: (skip_comment) New function.
2275 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
2277 The TABLE subcommand on MATCH FILES worked only erratically at
2278 best. This fixes it. Thanks to Dr. Dirk Melcher
2279 <BZN-mdksh@t-online.de> for reporting this bug.
2281 * get.c: (mtf_compare_BY_values) When comparing string values, a
2282 difference of 1 is still a difference :-)
2283 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
2284 advance TABLE files automatically when matched. Comment fixes.
2286 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
2288 VARIABLE LABELS rejected a slash before the first variable
2289 specification, contradicting the documentation. Thanks to Walter
2290 M. Gray <graywm@northernc.on.ca> for reporting this bug.
2292 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
2293 command specification.
2295 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
2297 Because of an incorrect optimization in memory allocation,
2298 CROSSTABS sometimes segfaulted when asked to output multiple
2299 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
2302 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
2303 are passed to output_pivot_table() for its use.
2304 (output_pivot_table) Instead of assuming the number of columns is
2305 constant, keep track with maxcols. In general mode, use maxcells
2306 to determine whether more matrix cells need to be allocated.
2308 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
2310 CROSSTABS didn't display value labels for column and row
2311 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
2314 * crosstabs.q: (table_value_missing) If the specified value has a
2315 value label for this variable, then show it instead of the raw
2317 (display_dimensions) Delegate display of value_labels to
2318 table_value_missing.
2320 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
2322 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
2323 <BZN-mdksh@t-online.de> for reporting this bug.
2325 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
2326 if the file isn't declared as binary.
2328 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
2330 MATCH FILES corrupted memory and dumped core on some syntax
2333 * get.c: (cmd_match_files) Set file->handle to NULL before
2335 (mtf_free_file) Don't free a null dictionary.
2337 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
2339 MATCH FILES should set numeric values not available to the
2340 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
2341 <BZN-mdksh@t-online.de> for reporting this bug.
2343 * get.c: (mtf_processing) Set unused records to system-missing,
2346 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
2348 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
2349 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
2351 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
2352 in newly created dictionary, and add each copied variable to the
2355 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
2359 * get.c: (trim_dictionary) Free variable list for KEEP after
2362 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
2364 Some systems didn't like the way open_file was coded. Thanks to
2365 Hankin <hankin@rogue.consultco.com> for pointing this out.
2367 * filename.c: (open_file) Don't try to store stdin, stdout,
2368 stderr as part of an array, because that doesn't always work.
2370 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
2372 The SAVE procedure didn't save long string variables properly.
2373 Fixed by this patch. Thanks to Hankin
2374 <hankin@rogue.consultco.com> for this patch.
2376 * sfm-write.c: (write_variable) Fix off-by-one error in writing
2377 out variable pad records.
2379 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
2381 Previously, if PRINT SPACE were given a negative argument, it
2382 would report an error, then spin in an (almost) infinite loop.
2383 This fixes that behavior.
2385 * print.c: (print_space_trns_proc) After reporting a negative
2386 argument, set number of lines to print to 1.
2388 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
2390 SPSS 8.0 outputs some new record types in its system files, and it
2391 allows longer value labels. Accept these system files.
2393 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
2394 11 emitted by SPSS 8.0.
2396 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
2398 The LIST procedure was too conservative in allocating space for
2399 buffers, which caused a bug that only showed up with very long
2400 output variables. Thanks to Hankin <hankin@dunno.com> for this
2403 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
2405 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
2407 Typo meant string format specifiers weren't checked properly. I
2408 think that Hankin <hankin@dunno.com> sent me this report, but I'm
2409 willing to be corrected on this point.
2411 * format.c: (check_string_specifier) Fix obvious typo.
2413 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
2415 Using $CASENUM in an expression didn't work. Here's a fix.
2416 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
2419 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
2421 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
2423 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
2425 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
2426 other behavior, *sigh*. This patch hopefully fixes that. This
2427 time I've actually tested it.
2429 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
2431 * data-list.c: (read_from_data_list_free,
2432 read_from_data_list_list) Call parse_string_as_format() directly
2433 without mucking around with the field width.
2435 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
2437 Occasionally, you may encounter a script that wants to be
2438 interpreted in interactive mode. Make -i emulate this behavior to
2439 allow such scripts to be executed with PSPP.
2441 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
2443 * cmdline.c: (pre_syntax_message[]) Update -i description.
2445 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
2446 when -i is given on the command line) don't treat unindented lines
2447 as starting a new command.
2449 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
2451 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
2452 mostly caused by local initialized aggregates. After egcs is
2453 fixed upstream these can be removed, but for now they're not a big
2456 * ascii.c: (ascii_postopen_driver) Checker chokes on local
2457 initialized arrays. Avoid this.
2459 * sfm-write.c: (sfm_write_dictionary) Don't use a local
2462 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
2464 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
2465 following changes avoid. Currently I compile sources with egcs
2466 1.1.1 and gcc 2.7.2.3 before sending them out.
2468 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
2470 * ascii.c: (option_tab[]) Initialize all struct members.
2472 * avl.h: (avl_traverser_init) New macro.
2474 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
2477 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
2480 * hash.c: Comment fix.
2482 * hash.h: (hsh_iterator_init) New macro.
2484 * html.c: (option_tab[]) Initialize all struct members.
2486 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
2489 * postscript.c: (option_tab[]) Initialize all struct members.
2490 (output_encodings, preclose, dump_lines) Use new
2491 hsh_iterator_init() macro.
2493 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
2496 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
2499 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
2501 * data-in.c: Examined each of the parsing functions to make sure
2502 that they wouldn't dump core if they were passed a string of the
2503 wrong length, since now the DATA LIST FREE/LIST routines don't
2504 check for field width before passing it to the data parser.
2505 (parse_RBHEX, parse_AHEX) Reject odd length input.
2506 (parse_string_as_format) Reject input that's too short or too
2509 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
2510 a field to its entire declared output width then pass it to the
2511 data-in parsing routines. This contradicted the documented
2512 behavior. This is fixed in these changes. Thanks to Mark H. Wood
2513 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
2514 free-format parsing that differed from SPSS.
2515 (cut_field) Commas and spaces are treated identically. Returns
2516 the proper column instead of a fixed 1 value.
2517 (parse_field) Removed.
2518 (read_from_data_list_free, read_from_data_list_list) Call
2519 parse_string_as_format directly instead of parse_field.
2521 * heap.c: (heap_delete) Stylistic fixes.
2523 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
2525 * loop.c: (loop_2_trns_proc) Formatting fix.
2527 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
2529 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
2531 * vfm.c: (macro FILTERED) New.
2532 (static var filter_var) New.
2533 (process_active_file_write_case) Use FILTERED.
2534 (setup_filter) Set filter_var.
2535 (close_active_file) Delete the filter if not
2536 FILTER_before_TEMPORARY.
2537 (procedure_write_case) Use FILTERED.
2539 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
2541 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
2543 * data-in.c: (parse_day_count) Message fix.
2544 (parse_month) Style fix.
2546 * data-list.c: (struct data_list_pgm) New member eof.
2547 (cmd_data_list) Init eof to 0.
2548 (do_reading) Implement the /END subcommand and read-past-eof
2551 * do-if.c: Include stdio.h when debugging.
2552 (cmd_else_if) Make sure the command is .-terminated.
2554 * glob.c: (init_glob) Capitalize the command prompt.
2556 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
2557 (end_file_trns_proc) Debugging message.
2559 * loop.c: (internal_cmd_loop) Make it work when there's no loop
2561 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
2563 * main.c: (dump_token) Make kwtab[] const.
2565 * set.q: Spelling, comment fixes.
2567 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
2570 * vars-prs.c: (fill_all_vars) Style fix.
2572 * vfm.c: (index_to_varname) Return const.
2574 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
2576 * Changes in many source files for partial -ansi -pedantic and
2577 no-debugging compliance: Remove trailing common in enum
2578 declarations; add `unused' attributes; insert some appropriate
2581 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
2583 * command.c: (shell) Make static.
2584 (run_command) Make static.
2586 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
2588 * dfm.c: (cmd_begin_data) I18n fix.
2590 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
2592 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
2594 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
2597 * file-handle.q: Don't prepend the source file directory name to
2598 the data file name. (Ongoing issue.)
2599 (prepend_current_directory) Comment out.
2600 (internal_cmd_file_handle) Don't call prepend_current_directory().
2601 (fh_get_handle_by_filename) Ditto.
2603 * filename.c: Append zero byte to readlink() return value.
2605 * getline.c: (getl_read_line) I18n fix.
2607 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
2609 * misc.h: Don't use gcc features if __STRICT_ANSI__.
2611 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
2614 * postscript.c: (output_encodings) Don't use local_strdup().
2617 * print.c: Don't use gcc features if __STRICT_ANSI__.
2619 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
2621 * recode.c: (parse_src_spec) Fully brace nested if's.
2623 * set.q: (global var set_testing_mode) New var.
2625 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
2627 * ascii.c: Add some more `unused' attributes that only come into
2628 play when NDEBUG is defined.
2629 (ascii_close_page) Set s_len when reallocating s.
2631 * crosstabs.q: (delete_missing) New function.
2632 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
2633 (make_summary_table) Create summary table reallocable.
2635 * postscript.c: Add more `unused' attributes as above.
2637 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
2638 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
2640 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
2643 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
2644 gratuitous space between parameter definition.
2646 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
2647 complaints about running off the end of functions with NDEBUG
2650 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
2652 * Several source files: Removed some PORTME notes when reflection
2653 revealed that ANSI forbids that sort of breakage. Also, added
2654 lots of `unused' qualifiers here and there.
2656 * aggregate.c: (accumulate_aggregate_info) Remove local var
2657 weighting that turned out not to be used.
2659 * avl.c: Update to version 1.1.0. Add unused specifier.
2660 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
2662 (avl_probe) Replace some instances of 1 with +1 where appropriate.
2663 (avl_find) Cast return value to void *.
2664 (avl_delete) q doesn't need to be initialized at the beginning of
2665 the function. Replace some instances of 1 with +1.
2666 (force_avl_delete) Renamed avl_force_delete, all references changed.
2667 (compare_ints) `param' marked unused.
2668 (print_int) `param' marked unused.
2669 (recurse_tree) Replace some instances of 1 with +1.
2671 * avl.h: Update to version 1.1.0. Only declares avl function
2672 types if not already declared.
2673 (AVL_MAX_HEIGHT) Only define if not already defined.
2674 (struct avl_node) New unused member char pad[2].
2675 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
2676 (force_avl_insert) Renamed avl_force_insert.
2677 (force_avl_delete) Renamed avl_force_delete.
2679 * crosstabs.q: (struct table_entry) Put `freq' into a union with
2681 (struct crosstab) Add new member `ofs'.
2682 (glob var int_tab) Removed.
2683 (custom_tables) In integer mode, assign v[i] properly through the
2685 (custom_variables) Now p.crs.max == max + 1.
2686 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
2687 (precalc) Implement integer mode.
2688 (calc_integer) Implement integer mode.
2689 (compare_table_entry) Remove unused local variable `comparing'.
2690 (make_summary_table) Implement integer mode.
2691 (macro ns_rows) Implemented as static variable now.
2692 (several variables) Made static, from global.
2693 (output_pivot_table) Use table_value_missing() for column heads.
2694 Remove several unused local variables. Implement integer mode
2695 table summing. Count up ns_rows.
2696 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
2697 (find_pivot_extent) Moved into find_pivot_extent_general; now just
2698 calls that function or find_pivot_extent_integer.
2699 (find_pivot_extent_integer) New function.
2700 (enum_var_values) Implemented for integer mode.
2701 (table_value_missing) New function.
2702 (display_dimensions) Call table_value_missing() for heads.
2703 (float_M_suffix) New function.
2704 (display_crosstabulation) Call table_value_missing() for row
2705 heads. Handle missing values in /MISSING=REPORT mode.
2706 (calc_fisher) Remove unused var N.
2707 (calc_r) Remove unused var fact.
2709 * data-list.c: (dump_fixed_table) Fix table dimensioning.
2710 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
2712 * data-out.c: (insert_commas) Remove unused var cp.
2713 (convert_CCx) Remove unused vars save_set_decimal,
2716 * descript.q: (dump_z_table) Fix table dimensioning.
2717 (pre_calc) Remove unused var j.
2718 (display) Remove unused vars title, s. Fix table dimensioning.
2720 * expr-evl.c: Comment fixes.
2722 * frequencies.q: (full_dim) New function.
2723 (dump_full) Fix table dimensioning.
2724 (condensed_dim) New function.
2725 (dump_condensed) Fix table dimensioning.
2727 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
2730 * html.c: (html_close_drive) Remove unused var i.
2731 (postopen) Remove unused vars title, curfn_len, cp.
2732 (preclose) Remove unused vars this, x.
2734 * lexer.c: Comment fixes.
2736 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
2738 * means.q: (custom_tables) Remove unused var m_dim.
2740 * mis-val.c: Format fix.
2742 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
2744 * output.c: (outp_get_paper_size) Remove unused var cp.
2746 * pfm-read.c: (read_float) Remove unused var save, unused label
2748 (read_variables) Remove unused vars cp, j.
2749 (read_value_label) Remove unused var j.
2751 * pfm-write.c: (bufwrite) Remove unused var i.
2753 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
2755 (output_encodings) Remove unused vars char_cp, n_output.
2756 (read_ps_encodings) Remove unused var ep.
2757 (postopen) Remove unused var title.
2758 (preclose) Remove unused var fp.
2759 (ps_open_page) Remove unused vars true, false, orientation,
2760 mirror_horz, mirror_vert, width, length.
2761 (ps_text_metrics) Remove unused var x.
2763 * q2c.c: (find_symbol) Remove unused var y.
2764 (parse_setting) Remove unused parameter sbc, all references
2766 (dump_parser) Remove unused var cp.
2767 (dump_free) Remove unused var i.
2769 * set.q: (static vars args, n) Removed.
2770 (internal_cmd_gset) Removed.
2772 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
2773 (read_machine_flt64_info) Removed unused var file_endian.
2774 (read_documents) Removed unused var i.
2775 (read_compressed_data) Removed unused parameter dict, all
2778 * sfm-write.c: (bufwrite) Removed unused var i.
2779 (sfm_write_case) Removed unused var i.
2781 * sort.c: (merge_once) Remove unused var t.
2782 (write_separate) #if 0 out as dead code.
2784 * split-file.c: (cmd_split_file) Remove unused var i.
2786 * sysfile-info.c: (sysfile_info_dim) New function.
2787 (cmd_sysfile_info) Fix table dimensioning.
2788 (variables_dim) New function.
2789 (display_variables) Fix table dimensioning.
2790 (describe_variable) Remove unused var prev_r.
2792 * t-test.q: (z_postcalc) Removed.
2793 (pairs_calc) Remove unused var bad_weight.
2794 (postcalc) Remove unused vars dfn, dfd.
2796 * tab.c: (tab_create) Set t->dim to NULL.
2797 (tab_dim) Make sure t->dim is NULL first.
2798 (tab_natural_width) Remove parameter `clamp'.
2799 (tab_value) Remove duplicate assertion for table.
2800 (tab_raw) New function.
2801 (nowrap_dim) New function.
2802 (wrap_dim) New function.
2803 (tab_output_text) Fix table dimensioning.
2805 * tab.h: (tab_raw) New macro.
2807 * val-labs.c: (get_label) Remove unused var type.
2808 (copy_value_labels) Remove unused var trav.
2810 * var.h: (struct crosstab_proc) Completely changed.
2812 * vars-prs.c: (parse_dict_variable) Remove unused var v.
2814 * vfm.c: (open_active_file) Remove unused vars i, lp.
2816 * weight.c: (weight_trns_proc) #if 0 out as dead code.
2818 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
2820 * Makefile.am: Add apply-dict.c, flip.c.
2822 * apply-dict.c: New file.
2824 * command.c: (struct command) Make cmd[] larger for CLEAR
2825 TRANSFORMATIONS command name.
2826 (parse_cmd) Make sure we're in a valid state before using it as an
2827 index. Discard variables and reset state on invalid transitions.
2828 (cmd_clear_transformations) New function.
2830 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
2831 Add unimplemented PRESERVE, RESTORE.
2833 * file-handle.h: Include stddef.h.
2837 * pfm-read.c: (parse_value) Pad value label values with spaces,
2840 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
2841 (sfm_close) Decrement reference count, make sure it's zero.
2842 (sfm_maybe_close) New function.
2843 (sfm_read_dictionary) Handle reference counts.
2845 * vars-atr.c: (clear_default_dict) New function.
2846 (discard_variables) Use clear_default_dict().
2848 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
2850 * Makefile.am: Add pfm-write.c.
2851 (LDADD) Add the libgmp2 libraries.
2853 * command.def: Define EXPORT.
2855 * get.c: (cmd_export) New function.
2856 (export_write_case_func) New function.
2858 * pfm-read.c: (static spss2ascii[]) Make it const.
2860 * pfm-write.c: New file.
2862 * sfm-write.c: Formatting, comment fixes.
2864 * var.h: Comment fix.
2866 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
2868 * Makefile.am: Add pfm.h, pfm-read.c.
2870 * command.def: IMPORT is now implemented.
2872 * format.c: (glob var translate_fmt[]) New var.
2874 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
2875 (cmd_import) New function.
2876 (import_source_read) New function.
2877 (glob var import_source) New var.
2879 * pfm-read.c: New file.
2883 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
2885 (dump_dictionary) Disabled printing a couple of items.
2887 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
2889 * crosstabs.q: (postcalc) Call make_summary_table().
2890 (make_summary_table) New function.
2891 (insert_summary) New function.
2892 (display_dimensions) Remove some unnecessary arguments, all
2894 (output_pivot_table) Fix lots of problems with the risk table
2896 (submit) Don't display an empty table.
2897 (display_risk) Fix order of arguments to calc_risk().
2899 * glob.c: Always include assert.h and stdlib.h.
2901 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
2904 * tab.c: (tab_create) Cosmetic changes.
2906 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
2908 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
2912 * crosstabs.q: (output_pivot_table) Headers drawing and submission
2913 code simplified, moved into new function submit().
2914 (submit) New function.
2915 (crosstabs_dim) New function.
2916 (display_directional) Substitute variable names for %s where
2918 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
2919 (calc_symmetric) Initialize parameters only if non-NULL.
2920 Calculate Somers' d.
2921 (calc_directional) Calculate Somers' d (or copy it, really).
2924 * output.c: (outp_string_width) New function.
2926 * postscript.c: (postopen) Calculate font widths based on the
2927 width of the zero '0' character, not the width of the space
2928 character. Set paper-width and paper-length based on points, not
2930 (ps_open_page) Fix page setup string for landscape mode.
2932 * som.h: (struct som_dimension) Removed.
2933 (struct som_table_class) height, width members take int * not
2936 * tab.c: Many functions now have added parameter validation.
2937 (tab_height, tab_width) These functions were removed and merged
2938 into a single function tab_resize(), and all references changed.
2939 (tab_dim) Rewritten since the interface changed; reduced from
2940 hundreds of lines to two. All callers were changed. Currently
2941 most of them just use tab_natural_dimensions as their callback and
2942 await detailed translation of functionality.
2943 (tab_natural_width) New function.
2944 (tab_natural_height) New function.
2945 (tab_natural_dimensions) New function. This is a callback
2946 function, not something that you'd want to call directly.
2947 (tab_nat_dim) Removed.
2948 (tabi_table) Allocates t->w and t->h.
2949 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
2950 dimensions callback.
2951 (evaluate_dimensions) Removed.
2952 (sum_columns) Removed.
2954 * tab.h: (enum TAL_1THIN) Removed.
2955 (enum series t_*) Removed.
2956 (struct tab_table) Members trh, trv changed to unsigned char *
2957 from int *. Member dim changed to a function pointer from a
2958 unsigned char *. Member max_stack_height removed. New members
2960 (macros tab_l, tab_r, tab_t, tab_b) New.
2962 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
2964 * ascii.c: (delineate) Assign last_space_nchars before skipping
2965 spaces, to fix right justification.
2967 * crosstabs.q: (static vars risk, direct) New vars.
2968 (static var pearson_r) Removed.
2969 (glob var chisq_fisher) Made static.
2970 (static vars row_tot[], col_tot[]) Don't include grand total
2972 (static var grand_total) Renamed W, all references changed.
2973 (output_pivot_table) Only make `table' if num_cells != 0. Make
2974 risk and directional tables. Deal with grand total no longer part
2975 of col_tot[]. Free rows and cols after we're done with them.
2976 (display_risk) New function.
2977 (display_directional) New function.
2978 (clac_r) Rewritten so that it stores all its results into its
2979 arguments, so it can be used for Spearman's correlation too.
2980 (calc_symmetric) Added a t[] argument, all references changed.
2981 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
2982 Pearson's r, Cohen's kappa.
2983 (calc_risk) New function.
2984 (calc_directional) New function.
2986 * som.c: (som_submit) Improved debugging code.
2988 * stats.c: (hypercube) New function.
2989 (cube) New function.
2991 (normal_sig) Went back to old implementation, which actually
2994 * stats.h: (macros square, cube, hypercube) Removed. The
2995 equivalent functions in stats.c are inlined here; all references
2996 to square changed to sqr.
2998 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
3000 * crosstabs.q: (N_SYMMETRIC) New define.
3001 (postcalc) Disable debug printing.
3002 (static vars chisq_fisher, pearson_r) New.
3003 (output_pivot_table) Add support for symmetric measures. Add
3004 chi-square output of exact sigs.
3005 (display_chisq) Rewritten.
3006 (display_symmetric) New function.
3007 (gamma_int) New function.
3009 (swap) New function.
3010 (calc_fisher) New function.
3011 (calc_chisq) Check boundary conditions better. Calculate Yates,
3012 Fisher, Mantel-Haenszel tests.
3013 (calc_r) New function.
3014 (calc_symmetric) New function.
3016 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
3018 (chisq_sig) Better boundary conditions. Renamed from
3021 * tab.h: (struct tab_table) New member cf.
3023 * tab.c: (tab_create) Set cf.
3024 (tab_width) New function.
3025 (tab_realloc) Handle cf.
3026 (tab_vline) Handle cf.
3027 (tab_hline) Handle cf.
3028 (tab_box) Handle cf.
3029 (tab_value) Handle cf.
3030 (tab_float) Handle cf.
3031 (tab_text) Handle cf.
3032 (tab_joint_text) Handle cf.
3033 (tab_offset) Handle cf.
3034 (tab_next_row) Handle cf.
3035 (evaluate_dimensions) Handle cf.
3036 (render_strip) Handle cf.
3038 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
3040 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
3041 output_pivot_table().
3042 (output_pivot_table) Moved lots of local variables outside and
3043 made them static. Add beginnings of chi-square statistic
3044 support. Now column and row totals aren't in the main matrix.
3045 Always zero out any leftover rows & columns after we're done with
3046 the table entries. Move all output stuff into
3047 display_dimensions(), display_crosstabs(), display_chisq().
3048 (display_dimensions) New function.
3049 (display_crosstabulation) New function.
3050 (display_chisq) New function.
3051 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
3053 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
3054 references, simplify logic.
3056 * postscript.c: Remove scale, translate-x, translate-y,
3057 mirror-horz, mirror-vert, rotate-180 options.
3058 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
3059 All references deleted.
3060 (macro YT) New macro.
3061 (array option_tab[]) Removed options.
3062 (ps_option) Removed options.
3063 (ps_open_page) Write page setup explicitly to output file, without
3064 using now-deleted BP function.
3065 (macro dump_line) Use YT().
3066 (macro dump_thick_line) Use YT().
3067 (draw_headers) Use YT().
3068 (switch_font) Reorder arguments to SF function.
3069 (write_text) Use YT().
3071 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
3074 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
3076 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
3077 null-debugging code.
3078 (tab_realloc) Remove null-debugging code. Initialize new regions
3080 (tab_vline) Support offsets.
3081 (tab_hline) Support offsets.
3082 (tab_box) Support offsets.
3084 (tab_nulls) Removed.
3087 (evaluate_dimensions) Remove null-debugging code. Understand
3088 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
3089 TAB_EMPTY not present.
3091 * tab.h: New cell attribute TAB_EMPTY.
3092 (macros tab_nr, tab_nc, tab_row, tab_col) New.
3094 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
3095 try to read them from system files.
3097 * vfm.c: (dump_splits) Don't call tab_null().
3099 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
3101 * crosstabs.q: (struct crosstab) Added `missing' member.
3102 (custom_tables) Init missing.
3103 (calc_general) Handle missing values.
3104 (calc_chisq) New function.
3105 (output_pivot_table) Start work on chi-square output. Update for
3106 new tab offset support functions. Shorten statistic names.
3108 * Several files: add in more `const's to placate gcc's warnings.
3110 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
3113 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
3114 tab_null, tab_nulls, tab_value, tab_float, tab_text,
3115 tab_joint_text) Add col_ofs and row_ofs support.
3116 (tab_offset) New function.
3117 (tab_next_row) New function.
3118 (tab_row) New function.
3119 (tab_col) New function.
3120 (tabi_table) Add col_ofs and row_ofs support.
3122 * vars-atr.c: (is_system_missing) New function.
3124 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
3126 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
3127 (static var no_cells) Removed.
3128 (static var num_cells) New.
3129 (static var expected) New.
3130 (static var cells[]) New.
3131 (internal_cmd_crosstabs) Deal with new variables.
3132 (postcalc) Removed most of the meat and put it in new function
3133 output_pivot_table().
3134 (output_pivot_table) Calculates and outputs an entire pivot table.
3136 * postscript.c: (postopen) Fix problems with free()ing addresses
3137 not obtained from malloc().
3139 * som.c: (som_submit) Add assertion.
3141 * sysfile-info.c: (describe_variable) Use new tab_nulls()
3144 * tab.c: (static var tab_names[]) New.
3145 (tab_realloc) -1 for nc or nr indicates no change.
3146 (tab_nulls) New function.
3147 (tab_dim) Use tab_names[].
3148 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
3149 (evaluate_dimensions) Don't terminate on uninited cells, just put
3150 an X in them and emit a notice. Use tab_names[].
3152 * tab.h: Move bits into tab.def.
3154 * tab.def: New. Don't try to declare tab_table_class because then
3155 som.h has to be included.
3157 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
3159 * command.def: New file, contains all the command definitions
3160 previously included bodily in command.c.
3162 * format.def: New file, contains all of the format definitions
3163 previously split across format.h, format.c, and sfm-write.c.
3165 * lexer.h: Renamed from tokens.h in order to match corresponding
3168 * lexerP.h: Moved some rarely used functions exported by lexer.c
3171 * Makefile.am: Commemorate renamed files.
3172 (EXTRA_DIST) Add command.def, format.def.
3174 * command.c: [0] (walk_cmdtable_func) Removed.
3176 * crosstabs.q: (postcalc) Made it work and print out matrices
3178 (enum_column_values) Renamed enum_var_values, generalized for any
3181 * format.h: (struct fmt_desc) New member `spss'.
3183 * q2c.c: (main) Generated code includes lexer.h instead of
3186 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
3187 instead of an independent translation table.
3189 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
3191 * Lots of source files: Added const to declarations.
3193 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
3195 * arena.c: (arena_clear) Set prev pointer to null when done.
3197 * ascii.c: (ascii_option) Rename index as indx.
3199 * avl.c: This is now a separate library called libavl.
3200 (xmalloc) Make static.
3201 (avl_probe) Step A7 can use the cache instead of an explicit
3203 (avl_delete) Don't maintain a q pointer because it's always
3204 available in the pointer stack. Comment fix.
3206 * avl.h: This is now a separate library called libavl.
3208 * command.c: (cmd_table[]) Remove spurious trailing "".
3210 * common.h: Only include random() fix if this system needs it.
3212 * crosstabs.q: Include alloca headers.
3213 (n_sorted_tab) New global var.
3214 (postcalc) Mostly rewritten.
3215 (find_pivot_extent) Rewritten.
3216 (enum_column_values) Rewritten.
3218 * data-out.c: (convert_F) Rename inner n as n_spaces.
3220 * error.c: (dump_message) Don't have an outer var i.
3222 * file-handle.q: (static var f) Removed. All references removed.
3223 (internal_cmd_file_handle) Uses a local variable instead of f.
3225 * get.c: (trim_dictionary) Change scope of i, i1, i2.
3226 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
3229 * getline.h: Declare getl_history as extern. Reported by
3230 palme@uni-wuppertal.de (Hubert Palme).
3232 * postscript.c: (postopen) Some large mods for constness.
3234 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
3237 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
3239 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
3240 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
3243 * avl.c, avl.h: New files. These form a clean-room
3244 reimplementation of avllib. Iterative algorithms are used in
3245 place of recursive ones, so there is no resemblance in the code.
3247 * Lots of headers: Don't include other headers by default.
3249 * Lots of source files: Explicitly include all needed headers.
3251 * arena.c: (arena_clear) New function.
3253 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
3254 (static var ar) Removed.
3255 (staitc vars ar_tc, ar_col) New.
3256 (cmd_crosstabs) Destroy the arenas.
3257 (internal_cmd_crosstabs) Create the arenas.
3258 (precalc) Don't need a free function for the hash.
3259 (calc_general) Make sure to zero out the trailer on the key data
3261 (print_table_entries) Updated.
3262 (postcalc) Worked on actually implementing.
3263 (find_pivot_extent) New function.
3264 (compare_value) New function.
3265 (enum_column_values) New function.
3267 * data-in.c: (parse_month) Make local array `static const'.
3269 * data-out.c: (convert_date) Make local array `static const'.
3270 (convert_WKDAY) Same.
3271 (convert_MONTH) Same.
3273 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
3274 been renamed to avl_walk().
3276 * hash.c: Rewritten more efficiently.
3278 * hash.h: Add attribute const to hsh_next_prime declaration.
3280 * lexer.c: (id_match) Make arguments const.
3282 * postscript.c: (ps_postopen_driver) Make default fonts the
3285 * q2c.c: (main) Generated code needs stdlib.h.
3287 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
3288 initialized to 0 now, not to NULL. All other references to
3289 avl_traverser were updated in the same way.
3291 * tokens.h: Macro version of id_match updated to use const
3294 * val-labs.c: (inc_ref_count) New function.
3295 (copy_value_labels) Simply through use of new avl_copy() function.
3297 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
3299 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
3300 (postcalc) Worked on this.
3302 * postscript.c: (OPO_DOUBLE_LINE) New enum.
3303 (struct ps_driver_ext) New line_width_thick member.
3304 (ps_preopen_drive) Init line_width_thick.
3305 (option_tab[]) Add line-* options.
3306 (ps_option) Parse line-* options.
3307 (postopen) Add line_width_thick support. Strip leading spaces on
3308 prologue output lines.
3309 (ps_open_page) Include line_width_thick in output.
3310 (macro dump_thick_line) New.
3311 (dump_fancy_line) Support thick lines as well as double lines.
3313 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
3315 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
3316 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
3318 * Many source files: Rename `options' to `pv_opts' as appropriate.
3320 * command.c: (static var cmd_table[]) Add CROSSTABS command.
3322 * common.c: (xcalloc) New function.
3324 * crosstabs.q: New file. Not finished yet, though.
3326 * data-list.c: Comment fix.
3328 * error.c: Remove some old Checker cruft.
3330 * frequencies.q: (dump_full) Cumulate valid percent instead of
3333 * getline.c: Comment fix.
3335 * hash.c: Comment fixes.
3337 * hash.h: (struct hsh_table) Make hash functions return unsigned
3338 instead of int to avoid problems with taking the modulo of
3339 negative return values. All references changed.
3341 * misc.c: (intlog10) Make its table static const instead of auto.
3343 * sfm-read.c: (read_header) Make `prefix' static const instead of
3346 * var.h: (union value) Add member `hash'.
3347 (struct variable) Rename prv_index as `foo'--all references
3349 (typedef pv_opts) Removed. All references changed.
3351 * vars-prs.c: (parse_variables) Message fixes.
3353 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
3355 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
3356 they are being inserted. Don't check for BY variables of
3357 different types. Discard variables if the active file isn't
3358 included in the merge.
3359 (mtf_processing) Essentially rewritten.
3360 (mtf_merge_dictionary) Check for master/slave variables of
3361 different types/widths.
3363 * vfm.c: (static var not_canceled) New var.
3364 (process_active_file) Don't call vfm_source->read() if
3365 there's no vfm-source. Initialize not_canceled.
3366 (process_active_file_write_case) Honor and update not_canceled.
3367 (prepare_for_writing) Rollback changes from yesterday, they were
3369 (close_active_file) Don't destroy vfm_source unless it exists.
3371 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
3373 * Lots of source files: Added { } around nested if/else constructs
3374 to avoid new gcc 2.8 warnings.
3376 * data-in.c: (parse_Z) Declare `int' type explicitly.
3379 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
3380 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
3381 prev members. Put TABLEs at the end of the chain and FILEs at the
3382 beginning. Don't allow the active file in STATE_INIT. Use proper
3383 `seen' value for the active file. Fill out the by members and
3384 make sure they're of consistent type. Do the actual merge
3386 (mtf_processing_finish) New function.
3387 (var_type_description) New function.
3388 (mtf_free_file) New function.
3389 (mtf_free) Rewritten.
3390 (mtf_delete_file_in_place) New function.
3391 (mtf_read_nonactive_records) New function.
3392 (mtf_compare_BY_values) New function.
3393 (static var mtf_seq_no) New var.
3394 (mtf_processing) New function.
3395 (mtf_merge_dictionary) Assign nval members for the system file
3396 dictionary. Assign fv values for its variables. Point each slave
3397 variable to the corresponding master variable.
3399 * hash.c: Include str.h.
3401 * mis-val.c: (copy_missing_values) src arg is const.
3403 * misc.c: (spacing) Make `max' var explicitly int.
3405 * sfm-read.c: (dump_dictionary) Message reformatting.
3406 (sfm_read_case) Add assertion.
3408 * sort.c: Esthetic fixes.
3410 * var.h: (struct match_files_proc) New struct.
3411 (struct variable) Add private data match_files_proc.
3413 * vars-atr.c: (delete_variable) Implement. Add argument for the
3414 dictionary that owning the variable.
3415 (dup_variable) Add assertion.
3417 * vfm.c: Comment fixes, hopefully the comments are correct now.
3418 (process_active_file) New function.
3419 (process_active_file_write_case) New function.
3420 (process_active_file_output_case) New function.
3421 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
3423 (write_case) Renamed procedure_write_case(). Now write_case is a
3424 pointer to a function. Style fixes.
3426 1998-03-05 Ben Pfaff <blp@gnu.org>
3428 * Makefile.am: (q2c) Link with libmisc.
3429 (version.c) Define default_config_path, include_path,
3432 * ascii.c: (ascii_postopen_driver) When the default newline string
3433 is requested, open file in text mode. Suggested by
3434 palme@uni-wuppertal.de (Hubert Palme).
3435 (static vars line_buf, line_p) Change from char * to unsigned char
3437 (ascii_close_page) char * to unsigned char *.
3439 * cmdline.c: (parse_command_line) Implement -r option by
3440 prepending ~/.pspp/rc to the list of files to process.
3442 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
3443 before pulling in a final line.
3444 (null_func, null_int_func) Removed (dead code).
3446 * descript.q: (display) Calculate width of variable name column
3447 properly. Calculate number of valid cases properly. Reported by
3448 palme@uni-wuppertal.de (Hubert Palme).
3450 * filename.c: (init_filename) Use default_config_path instead of
3451 now obsolete CONFIG_PATH.
3453 * getline.c: (getl_initialize) Use include_path instead of now
3454 obsolete INCLUDE_PATH.
3455 (getl_add_file) New argument `where'. All references changed.
3457 * groff.c: (find_font_file) Use groff_font_path instead of now
3458 obsolete GROFF_FONT_PATH.
3460 * postscript.c: (find_ps_file) Use groff_font_path instead of now
3461 obsolete GROFF_FONT_PATH. Copy through temporary variable to
3462 avoid problems with constness.
3464 * str.h: (macro cs_streq) New macro.
3466 * version.h: (glob var default_config_path, include_path,
3467 groff_font_path) New vars.
3469 1998-02-23 Ben Pfaff <blp@gnu.org>
3471 * Many source files: Change verbose_msg() priority levels and
3474 * aggregate.c: Include debug-print.h.
3476 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
3478 (static var pre_syntax_message) Document --safer/-s and
3481 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
3483 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
3484 because it's not used but it's still copied.
3485 (open_file_r) Remove gratuitous debug message.
3487 * filename.c: (safety_violation) New function.
3488 (open_file) Remove gratuitous debug messages. Don't allow pipe
3489 files if set_safer is set.
3491 * get.c: Turn off debugging.
3493 * getline.c: (getl_add_virtual_file) New function.
3494 (getl_read_line) Add verbose_msg() call for opening new syntax
3496 (getl_perform_delayed_reset) Add a return value describing whether
3497 any action was taken. Call reset_eof().
3499 * getline.h: Comment fix.
3501 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
3502 place of incorrect `continue'. Use strtok_r() instead of
3503 strtok(). Always check strtok_r() return value.
3504 (groff_read_DESC) Use strtok_r() instead of strtok().
3506 * lexer.c: (reset_eof) New function.
3508 * main.c: (parse) Get a token after performing a delayed reset
3509 action; allow empty syntax files.
3511 * postscript.c: (output_encodings) Use strtok_r() instead of
3514 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
3516 * set.q: Comment fixes.
3517 (glob var set_safer) New var.
3518 (internal_cmd_set) Support SAFER.
3520 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
3522 * temporary.c: (free_dictionary) Set d->splits to NULL after
3525 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
3526 variable deleted, not if it *isn't* deleted.
3528 1998-02-16 Ben Pfaff <blp@gnu.org>
3530 * command.c: (array cmd_table[]) Add MATCH FILES.
3532 * common.c: Comment fixes.
3534 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
3535 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
3536 Include alloca.h. Problem reported by palme@uni-wuppertal.de
3539 * expr-opt.c: Include str.h. Problem reported by
3540 palme@uni-wuppertal.de (Hubert Palme).
3542 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
3543 (static var mtf_by) Change from char ** to variable **.
3544 (static var mtf_master) New var.
3545 (mtf_merge_dictionary) New function.
3546 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
3547 var type. Reorder tests properly. Initialize file->dict. Detect
3548 TABLE= without BY=. Read file dictionaries and merge them. Give
3549 subcommand name with IN, LAST, FIRST error messages. Create IN,
3550 LAST, FIRST variables. Comment fixes.
3551 (mtf_free) Don't free default_dict. Free mtf_master.
3553 * getline.c: Define getl_mode. Change getl_buf_size to size_t
3555 (handle_line_buffer) Cast int to size_t in comparison to avoid
3558 * getline.h: Declare getl_mode extern.
3560 * groff-font.c: (groff_read_font) Type-fix calls to getline.
3561 (groff_read_DESC) Make line_size a size_t.
3562 (match_tok) Parenthesize name to avoid macro expansion.
3564 * mis-val.c: (copy_missing_values) New function.
3566 * postscript.c: (postopen) Make buf_size a size_t.
3568 * sfm-read.c: (dump_dictionary) Make global from static. Print
3569 variable info in parts for easier debugging with Checker.
3571 * temporary.c: (copy_variable) Use copy_value_labels().
3572 (new_dictionary) New arg: whether to copy file label, documents.
3574 * val-labs.c: (copy_value_labels) New function.
3576 * var.h: (enums MISSING_*) Add MISSING_COUNT.
3578 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
3580 (dup_variable) Set prv_index, get.fv, get.nv.
3582 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
3584 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
3586 * Many source files: For ANSI-compliance, add empty statement
3587 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
3588 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
3590 * data-in.c: (parse_numeric) Some header files break on
3591 -DBL_MIN_10_EXP because they get a --; add () for safety.
3592 Reported by palme@uni-wuppertal.de (Hubert Palme).
3594 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
3595 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
3596 (dfm_close) Use close_file_ext.
3597 (open_inline_file) Set file.file to NULL, not file.
3598 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
3599 struct and use open_file_ext().
3600 (read_record) Use file.file.
3602 * file-handle.q: (prepend_current_directory) Pass through special
3605 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
3606 (normalize_filename) Pass through special filenames.
3607 (open_file, close_file) Accept pipe| and |pipe syntaxes as
3609 (dirname) Rename blp_dirname() because of name conflict on some
3610 OS. All references changed. Reported by palme@uni-wuppertal.de
3612 (is_special_filename) New function.
3614 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
3615 (trim_dictionary) Conditionalize some of the options on whether
3616 GTSV_OPT_MATCH_FILES is in *options.
3617 (rename_variables) Don't allow variables to be renamed as scratch
3619 (MTF_*) New enum series.
3620 (struct mtf_file) New struct.
3621 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
3623 (cmd_match_files, mtf_free) New functions.
3625 * lexer.c: (match_int) Needed parentheses around name to escape
3626 macro expansion. Reported by Micah Altman
3627 <maltman@www-vdc.fas.harvard.edu>.
3629 * print.c: Needed to include alloca.h. Reported by Micah Altman
3630 <maltman@www-vdc.fas.harvard.edu>.
3632 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
3633 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
3636 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
3637 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
3639 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
3641 * html.c: (struct html_driver_ext) Move into htmlP.h.
3642 (html_preopen_driver) Initialize cp_x, cp_y.
3643 (html_submit) Implement as call to output_tab_table().
3644 (change_attributes) New function.
3645 (escape_string) New function.
3646 (output_tab_table) New function.
3648 * list.q: (write_all_headers) Add code for writing headers for the
3650 (clean_up) Write out the html close-table tag.
3651 (determine_layout) Ignore html driver.
3652 (list_cases) Write html data.
3654 * som.c: (som_submit) Move more of the code into output_table().
3656 * tab.c: (static var hit) Make a global var and rename tab_hit.
3657 (static var tab_table_class) Make a global var.
3659 * htmlP.h: New file.
3661 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
3663 * dump-sysfile.c: Removed.
3665 * html.c: (preclose) Change comment in emitted code.
3667 * matrix-data.c: Debugging off by default. Comment fixes.
3668 (static var container) New var.
3669 (cmd_matrix_data) Create and destroy container. Initialize
3670 is_per_factor[] to 0s. Move code into new function
3671 string_to_content_type(). Require split values to be present in
3672 the data when ROWTYPE_ is explicit. Call specific function, not
3673 general read_matrices().
3674 (string_to_content_type) New function.
3675 (context) Exclude all whitespace, not just spaces.
3676 (mget_token) A dot is a number. Add assertion.
3677 (static var data) Renamed nr_data.
3678 (static var factor_values) Renamed nr_factor_values.
3679 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
3680 only specific case. Close data_file before exit.
3681 (fill_matrix) New function.
3682 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
3683 printing. Style fixes. Message fixes. Move code into
3685 (read_matrices_without_rowtype) Rename
3686 matrix_data_read_without_rowtype(). Fix off-by-one error on
3687 loops. Allocate nr_data[] memory from arena.
3688 (read_matrices_with_rowtype) Removed.
3689 (read_splits) Renamed nr_read_splits(). Style fixes.
3690 (read_factors) Renamed nr_read_factors().
3691 (dump_cell_content) Comment fixes. Arguments changed. Change
3692 debug printing. All references changed.
3693 (output_data) Renamed nr_output_data().
3694 (static var wr_content) New var.
3695 (struct factor_data) New struct.
3696 (static var wr_data) New var.
3697 (static var wr_current) New var.
3698 (matrix_data_source_destroy_source) Removed.
3699 (read_matrices_with_rowtype) New function.
3700 (matrix_data_read_with_rowtype) New function.
3701 (wr_read_splits) New function.
3702 (compare_factors) New function.
3703 (wr_output_data) New function.
3704 (wr_read_rowtype) New function.
3705 (wr_read_factors) New function.
3706 (wr_read_indeps) New function.
3707 (glob var matrix_data_source) Make destroy_source member NULL as
3710 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
3712 * lexer.c: (syntax_error) Give better error message when at end of
3715 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
3716 N_SCALAR to output as plain N.
3717 (mdump_token) Change output format.
3718 (context) Fix message output interaction with spaces in input.
3719 (another_token) New function.
3720 (force_eol) Improved error message.
3721 (static var max_cell_index) New var.
3722 (read_matrices) Init `cells'. factor_values is now per-cell.
3723 Init max_cell_index.
3724 (read_data_lines) Replace `compare' local with new `compare' arg.
3725 Debugging messages changed. Only read factors if per_factor.
3726 Propagate error return from read_factors(), force_eol().
3727 Copy N_SCALAR values across the N vector.
3728 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
3729 check parentheses manually since we now have is_per_factor[].
3730 Call read_data_lines() with new args. Check for end of data after
3731 looping, using another_token().
3732 (read_factors) Arguments changed. Use max_cell_index to determine
3733 whether to read or compare factors. Message fixes.
3734 (dump_cell_content) New function.
3735 (output_data) Completely rewritten because content types were
3736 supported to be nested inside factor values, not vice versa.
3738 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
3740 * lexer.c: (syntax_error) Support formatted varargs messages.
3742 * matrix-data.c: Turn debugging on by default.
3743 (static content_type[]) New array.
3744 (static content_names[]) New array.
3745 (static rowtype_, varname_) New vars.
3746 (static is_per_factor[]) New array.
3747 (static split_values) Moved declaration.
3748 (static n_continuous, first_continuous) New var.
3749 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
3750 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
3751 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
3752 Check for continuous variables.
3753 [DEBUGGING] (debug_print) Remove content_names[].
3754 (mdump_token) New macro.
3755 (mget_token_dump) New function.
3756 (mdump_token) New function.
3757 (context) New function.
3758 (mget_token) Fix messages.
3759 (static var data, split_values, factor_values) New vars.
3760 (read_matrices) Manage split_values, factor_values.
3761 (read_data_lines) New function.
3762 (read_matrices_without_rowtype) Implemented.
3763 (read_splits) Message fixes. Uses `just_read'.
3764 (read_factors) New function.
3765 (output_data) New function.
3766 (matrix_data_source_destroy_source) Close the file handle.
3767 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
3770 * str.c: (strpadcmp) Removed.
3772 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
3774 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
3776 * Lots of source files: Add cast to unsigned character to calls to
3777 tolower() and toupper().
3779 * aggregate.c: Set default_dict.splits to NULL.
3781 * command.c: (static variable tab[]) Add MATRIX DATA.
3783 * data-in.c: Add debugging defines. Formatting fixes.
3785 * expr-opt.c: Formatting fixes.
3787 * lexer.c: (syntax_error) Message fixes.
3789 * matrix-data.c: New enum series.
3790 (static vars fmt, section, diag, explicit_rowtype, signle_split,
3791 split_values, n_factors, factors, cells, pop_n, contents,
3792 n_contents) New vars.
3793 (cmd_matrix_data) Finished implementation.
3794 (compare_variables_by_mxd_vartype) New function.
3795 [DEBUGGING] (debug_print) New function.
3796 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
3797 (read_matrices) New function.
3798 (read_matrices_without_rowtype) New function.
3799 (read_matrices_with_rowtype) New function.
3800 (read_splits) New function.
3801 (mget_token) New function.
3802 (force_eol) New function.
3803 [0] (test_tokenizer) New function.
3804 (matrix_data_source_destroy_source) New function.
3805 (glob var matrix_data_source) New var.
3807 * misc.h: Include ieeefp.h if present.
3809 * split-file.h: (cmd_split_file) Changes corresponding to struct
3812 * str.h: Fix memmem prototype.
3814 * temporary.c: (save_dictionary, restore_dictionary,
3815 free_dictionary) Changes corresponding to struct dictionary
3818 * var.h: (MXD_* enums) New enum series.
3819 (struct matrix_data_proc) New struct.
3820 (struct split) Removed.
3821 (struct dictionary) Changed `splits' member from `split *' to
3823 (macro force_create_variable) New macro. Replaced lots of
3824 create_variable()/assert() calls with calls to this macro.
3826 * vars-atr.c: (discard_variables) Changed assertion.
3827 [GLOBAL_DEBUGGING] (force_create_variable) New function
3828 called by the macro of the same name.
3829 (clear_variable) Changes to delete splits from the dictionary
3830 corresponding to struct dictionary changes.
3832 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
3833 corrupted variable `index' values in the dictionary passed in
3834 every time this function is called.
3836 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
3837 to struct dictionary changes.
3839 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
3841 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
3843 * command.c: New includes.
3844 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
3845 (cmd_erase) New function.
3846 [unix] (shell) New function.
3847 (run_command) New function.
3848 (cmd_host) New function.
3849 (cmd_new_file) New function.
3851 * expr-prs.c: (parse_primary) Message fix.
3853 * inpt-pgm.c: Formatting fix.
3854 (cmd_reread) Implement the FILE subcommand.
3856 * matrix-data.c: New file.
3858 * q2c.c: (dump_header) Change output commenting style.
3860 * weight.c: Comment fix.
3862 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
3864 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
3866 (buf_10x) Renamed buf_1xx, all references changed.
3867 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
3868 cases now implemented).
3869 (create_sysfile) New function.
3870 (agr_11x_func) New function.
3872 * data-in.c: (parse_numeric) Work properly if there's an
3873 explicitly coded decimal point in the data and decimal places are
3874 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
3875 <el@linux.lisse.na>.
3877 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
3878 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
3879 Eberhard W Lisse <el@linux.lisse.na>.
3881 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
3882 strerror.c. Bug reported by Alexandre Oliva
3883 <oliva@dcc.unicamp.br>.
3885 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
3886 (static var separate_case_tab) New var.
3887 (cmd_sort_cases) Cancel temporary transformations here. Free
3888 v_sort before return.
3889 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
3890 we're reading from a sort stream. Don't cancel temporary
3891 transformations. Offload internal sorting to do_internal_sort().
3892 (do_internal_sort) New function. Handles internal sorting even
3893 when SEPARATE is nonzero. Doesn't free v_sort.
3894 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
3896 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
3897 sink if SEPARATE is zero.
3898 (read_output_cases) Renamed read_sort_output(), all references
3899 changed. Now uses separate_case_tab when it exists.
3900 (write_separate) New function.
3902 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
3903 memory_sink_cases. Don't redundantly call
3904 vfm_source->destroy_source().
3905 (memory_stream_mode) After switching over, set memory_sink_cases
3908 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
3910 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
3912 (static var prev_case) New, moved out of aggregate_single_case()
3914 (static var buf64_10x, buf_10x) New.
3915 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
3916 the 000, 001, 100, and 101 cases. Free prev_case.
3917 (parse_aggregate_functions) Disallow scratch variables.
3918 (free_aggregate_functions) Only free agr_dict if non-null. Use
3919 iter->function to determine numeric/string type, not
3921 (aggregate_single_case) Don't manage prev_case. Initialize
3922 aggregate info after dumping it.
3923 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
3924 mean, stddev, weighted stddev definitions.
3925 (dump_aggregate_info) Implemented.
3926 (initialize_aggregate_info) Renamed from
3927 initialize_aggregate_functions(). Initializes dbl[2].
3928 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
3929 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
3931 * cases.c: (alloc_val) Removed.
3933 * get.c: (cmd_save_internal) Initialize new `dict' member.
3935 * sfm-write.c: (sfm_write_dictionary, write_header,
3936 write_variable, write_value_labels, write_documents) Reorganize,
3937 simplify for new parameter structure.
3938 (write_variable) Only one variable * argument now.
3940 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
3941 replaced by new `dict' member.
3943 * temporary.c: (new_dictionary) Initialize n_documents.
3945 * vars-atr.c: (dup_variable) Allocate `value's from dict into
3947 (init_variable, replace_variable) Eliminate usage of alloc_val().
3949 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
3951 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
3952 signal that AGGREGATE is to be used for forming final cases.
3953 (close_active_file) Call end_func before stopping lagging. Cancel
3954 temporary after finishing compaction.
3955 (write_case) Comment fixes. Cleaned up.
3956 (compact_case) Let AGGREGATE handle compaction when `temporary' is
3959 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
3961 * Makefile.am: (BUILT_SOURCES) Add means.c.
3962 (pspp_SOURCES) Add means.c.
3963 (EXTRA_DIST) Add means.q.
3965 * command.c: (array cmd_table[]) Add MEANS.
3967 * common.h: Esthetic fixes. Comment fixes. Test for
3968 MAX_SHORT_STRING greater than 8.
3969 (macros LOWEST, HIGHEST) New.
3971 * data-in.c, data-list.c, recode.c: Comment fixes.
3973 * means.q: New file, base version.
3975 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
3976 with LOWEST, DBL_MAX with HIGHEST.
3978 * q2c.c: (dump_vars) Add an enum to array types giving the number
3979 of values for the enum.
3981 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
3982 Replace second_lowest_value with second_lowest_flt64.
3984 * sfm-write.c: (write_variable, write_rec_7_34) Replace
3985 second_lowest_value with second_lowest_flt64.
3987 * t-test.q: Comment fix.
3989 * temporary.c: (restore_dictionary) Esthetic fix.
3991 * tokens.h: (force_match_id, force_match, force_string, force_int,
3992 force_num, force_id) Replace msg() with syntax_error().
3994 * var.h: (struct means_proc) New.
3995 (struct variable) Add mns member to `p' union.
3997 * vars-prs.c: (parse_variable, parse_dict_variable,
3998 parse_variables, parse_DATA_LIST_vars) Replace msg() with
4001 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
4003 * Makefile.am: (pspp_SOURCES) Add tab.h.
4005 * Most source files: Added a cast to unsigned char in usages of
4006 the ctype is*() functions. Replaced `end of command expected'
4007 calls to msg() with calls to syntax_error().
4009 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
4011 * lexer.c: (hex_val) Removed (was dead code).
4012 (idmatch) Parenthesize function name to avoid macro expansion.
4014 * postscript.c: Comment fixes.
4015 (ps_preopen_driver) Change default font size to 10pt.
4017 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
4019 (parse_format_spec) Change system-file format spec argument type
4020 to int32. Parse the format spec with bitwise operators.
4022 * sfmP.h: (struct sysfile_format) Removed.
4023 (struct sysfile_variable) Changed print, write members from
4024 sysfile_format to int32.
4026 * tokens.h: Esthetic fixes.
4027 [__GNUC__] (macro id_match) New macro to hopefully speed up
4028 identifier matching.
4029 (macros match_id, match_tok, match_int) Implemented in
4030 compiler-independent manner; no longer GNU C only.
4032 * vfm.h: Include time.h.
4034 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
4036 * data-list.c: (dump_fixed_table) Change tab_dim().
4038 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
4040 * error.c: Include command.h.
4042 * frequencies.g: Formatting fixes.
4044 * frequencies.q: Add tab_dim() calls. Make the total cell a
4047 * glob.c: Include command.h.
4049 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
4051 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
4052 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
4053 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
4054 the other elements (is this right?).
4055 (read_variables) Use lowest, highest members.
4056 (parse_format_spec) New arg `vv' for more stringent checking.
4057 (dump_dictionary) Byteswaps nonexplicit data.
4058 (sfm_read_case) Byteswap numeric data.
4060 * som.c: Initialize table_num to 1.
4061 (render_segments) Remember to increment y_index after each table
4064 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
4065 avl_count() on a NULL tree. No title for the second table.
4066 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
4067 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
4068 fix call to display_variables().
4069 (display_variables) Default to 4 columns, not 3. Set up headers.
4070 Column title is Variable, not Name. Fix index column.
4071 Add joint text. Add tab_dim(). Handle value labels properly.
4072 Handle DISPLAY LABELS properly. Draw boxes correctly.
4073 (describe_variable) Value labels don't need titles. Don't clear
4074 nonexistent index column.
4075 (compare_vectors_by_name) New function.
4076 (display_vectors) New function.
4078 * tab.c: (tab_height) Add assertion.
4079 (tab_null) Add debug code.
4080 (evaluate_dimensions) Add debug code.
4082 * var.h: (struct variable) get_proc data is sometimes used
4083 simultaneously with other per-procedure info, therefore it was
4084 removed from the union. All references changed.
4086 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
4088 * ascii.c: (ascii_close_page) Put title on second line of headers
4089 if there is no subtitle.
4091 * command.c: (glob var cur_proc) Move definition here, from
4093 (cmd_remark) Emit blank line before remarks.
4095 * command.h: (glob var cur_proc) Move declaration here, from
4098 * data-list.c: (dump_fixed_table) Fix messages.
4099 (dump_free_table) Call tab_nat_dim().
4101 * descript.q: (dump_z_table) Modify tab_dim() call.
4103 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
4105 (dump_statistics) Don't output header.
4107 * groff-font.c: Minor format fix.
4109 * html.c: Comment fix.
4111 * list.q: (write_varname) Indent after advancing page.
4113 * output.h: Minor reordering.
4115 * postscript.c: Comment fixes. Many places, '\n' was replaced by
4116 a reference to eol[].
4117 (struct ps_driver_ext) New member eol[].
4118 (ps_preopen_driver) Initialize eol[].
4119 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
4120 defaults. Handle headers. Fix test for minimum page length.
4121 (static var option_tab[]) Add `line-ends'.
4122 (ps_option) Handle line-ends to change eol[].
4123 (postopen) Scale prop_em_width and fixed_width properly. Set the
4124 prologue title to outp_title if applicable. Replace the prologue
4125 line ends with eol[]. Call draw_headers() if headers are enabled.
4126 (text_width) New function.
4127 (out_text_plain) New function.
4128 (draw_headers) New function.
4130 * print.c: (dump_table) Call tab_nat_dim().
4132 * som.c: (som_blank_line) Only advance a line if not at the top of
4134 (som_submit) Move several informational table calls here.
4135 Increment subtable_num if SOMF_NO_TITLE not set.
4136 (output_table) Advance a line if SOMF_NO_SPACING not set.
4137 (render_columns, render_segments, render_simple) Handle spacing
4138 between tables. Handle table titles. Remove debug output.
4140 * som.h: (SOMF_*) New enum series.
4141 (struct som_table_class) New member `flags'.
4143 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
4145 (display_variables) Calls tab_nat_dim().
4146 (describe_variable) Remove restriction on number of value labels.
4147 Make value labels separated by thin lines.
4149 * tab.c: (tab_create) Default `flags' to none.
4150 (tab_float) New arg `w'. All references changed.
4151 (tab_nat_dim) New function.
4152 (tab_output_text) No title or spacing.
4153 (tab_flags) New function.
4154 (tabi_flags) New function.
4155 (tabi_title) New function.
4156 (strip_height) Removed.
4157 (tabi_render) Skip title when necessary.
4158 (static var tab_tab_class) Add tabi_flags, tabi_title.
4159 (evaluate_dimensions) Disable display of column, row size.
4160 (sum_columns) Add title height to top header.
4161 (render_strip) Moved within file.
4163 * tab.h: (struct tab_table) New member `flags'.
4165 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
4167 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
4169 * Most source files: Add `const' attribute in all appropriate
4172 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
4173 column to the variables table for use by describe_variable().
4174 (cmd_display) Disable for the present.
4175 (display_documents) Don't wrap documents.
4176 (display_variables) Table has four columns now.
4177 (describe_variable) Table has four columns now. Don't use a
4178 subtable, use joined cells instead.
4180 * tab.c: (tab_create) Don't set `join'.
4181 (tab_realloc) ct array is not made up of a_string's.
4182 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
4183 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
4184 (text_format) New function.
4185 (tab_title) Rewritten, uses text_format().
4186 (tab_text) Rewritten, uses text_format().
4187 (tab_joint_text) New function.
4189 (static var hit) New variable.
4190 (render_strip) New args r1, r2. Implement joined cells that fit
4192 (tabi_render) Increment hit. Pass new args to render_strip().
4193 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
4194 cells. For t_naw and t_nah, ignore joined cells and null cells in
4197 * tab.h: (struct tab_join_rect) Removed.
4198 (struct tab_table) Removed `join'.
4199 (TAB_JOIN_MAIN) Removed.
4200 (struct tab_joined_cell) New struct.
4201 (TAT_NOWRAP) New enum.
4203 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
4205 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
4207 (ascii_postopen_driver) Fix initialization of *_spacing so that
4208 the TAL_0 bit doesn't count.
4210 * data-list.c: (dump_fixed_table) Use natural width for Format
4213 * glob.c: (rerange) Removed.
4214 (get_date) Formatting fixes. Internationalization fix.
4216 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
4219 * postscript.c: (ps_postopen_driver) Replace
4220 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
4222 * som.c: (som_submit) Don't eject page before every table.
4223 (output_table) Fix order of arguments on call to area().
4224 (render_columns) Fix calculation of max_len.
4226 * tab.c: (tabi_cumulate) Minor change to increase elegance.
4227 (render_strip) New function.
4228 (strip_height) New function.
4229 (tabi_render) Rewrite as calls to render_strip().
4231 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
4232 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
4233 with the TAB_* and OUTP_T_* constants.
4235 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
4237 * Makefile.am: Formatting fixes.
4239 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
4242 * data-list.c: (dump_fixed_table) Add tab_dim() call.
4244 * descript.q: (dump_z_table, display) Add tab_dim() calls.
4246 * dump-sysfile.c: (glob var length) Make type off_t.
4247 (usage) Fix arguments.
4250 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
4251 Now right-justification is the default so many references had to
4253 (struct outp_class) Removed line_width, all references changed.
4254 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
4255 (struct outp_driver) Add elements horiz_line_width,
4256 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
4259 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
4261 (postopen) Initialize all the informational members of
4264 * som.c: (som_blank_line) New function, renamed from blank_line(),
4265 all references changed.
4266 (som_submit) Disables drivers whose pages can't be opened.
4267 (render_columns, render_simple, render_segments) Add debug output.
4268 (render_columns) Fix loop range.
4269 (render_simple) Don't try to render the headers, they're taken
4270 care of automatically. Advance cp_y past the table when done.
4271 (render_segments) Fix loop ranges.
4273 * tab.c: Initialize new members of tab_table.
4274 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
4275 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
4276 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
4279 (tab_dim) New function.
4280 (tab_col_width) Removed.
4281 (tab_row_height) Removed.
4282 (tab_output_text) Call tab_dim().
4283 (tabi_driver) Call evaluate_dimensions(), sum_columns().
4284 (tabi_area) Implemented.
4285 (tabi_cumulate) Implemented.
4286 (tabi_render) Partially implemented, but broken.
4287 (var tab_table_class) Made static.
4288 (evaluate_dimensions) New function.
4289 (sum_columns) New function.
4291 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
4292 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
4293 t_scr, t_srr, t_sentinel. Removed: t_nat.
4294 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
4295 max_stack_height, w, h. Removed: ce, re.
4296 (macro blank_line) Removed.
4297 (glob var zero_length) Removed.
4299 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
4301 * Most source files: include some of the new include files broken
4304 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
4307 * aggregate.c: (glob var outfile) Make static.
4309 * command.c: (glob var pgm_state) Move here.
4311 * common.c: (glob vars endian, second_lowest_value, pgmname,
4312 finished, curdate, cur_proc, start_interactive, history_file) Move
4315 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
4317 * file-handle.q: (glob vars files, inline_file) Move here.
4319 * glob.c: Lost lots of glob vars, detailed in individual file
4321 (init_glob) set_printer, set_screen were obsolete, deleted.
4322 set_cprompt has fewer spaces because pspp has fewer letters than
4325 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
4326 (inp_nval) Made static.
4328 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
4329 tokstr_len, toklongstr, tokint) Move here.
4331 * misc.c: Lost several vars and functions.
4333 * set.q: (all the set_* variables) Move here.
4335 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
4336 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
4339 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
4341 * tab.h: (enum series t_*) New enums.
4342 (struct tab_table) Use arena struct tag. New members ce, re.
4344 * tokens.h: Comment fixes.
4346 * var.h: Move lots of enums and variables and functions and
4347 structures to other files. Use and declare a lot more union and
4348 struct tags. Comment fixes.
4350 * vector.c: (glob vars vec, nvec) Move here.
4352 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
4353 init_blanks, last_vfm_invocation) Move here.
4355 * cases.h: New file.
4356 (struct long_vec) Move here.
4357 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
4360 * command.h: New file.
4361 (STATE_* enums) Move here.
4362 (glob var pgm_state) Move here.
4364 * format.c: New file.
4365 (glob var formats) Move here.
4366 (parse_format_specifier_name, fmt_to_string,
4367 check_input_specifier, check_output_specifier,
4368 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
4371 * format.h: New file. Move functions now in format.c here.
4372 (FMT_* enums) Move here.
4373 (struct fmt_desc) Move here.
4374 (FCAT_* enums) Move here.
4375 (struct fmt_spec) Move here.
4376 (glob vars formats, fmt_parse_ignore_error) Move here.
4378 * inpt-pgm.h: New file.
4379 (INP_* enums) Move here, make #defines into enums.
4380 (glob vars inp_init, inp_init_size) Move here.
4383 (glob vars v_sort, nv_sort) Move here.
4384 (sort_cases, read_sort_output) Move here.
4386 * vector.h: New file.
4387 (struct vector) Move here, add struct tag.
4388 (glob vars vec, nvec) Move here.
4389 (find_vector) Move here.
4392 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
4393 reinit_blanks, init_zero, init_blanks) Move here.
4394 (struct case_stream) Move here.
4395 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
4396 vfm_disk_stream, sort_stream, data_list_source,
4397 input_program_source, file_type_source, get_source, n_lag) Move
4399 (procedure, write_case, lagged_case, compact_case, page_to_disk)
4402 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
4404 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
4405 (LDADD) Add libdcdflib.
4407 * ascii.c: Comment and formatting fixes. Almost every external
4408 function had an assert added, checking driver_open and page_open.
4409 (ascii_init_driver) Broken into ascii_preopen_driver,
4410 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
4411 (ascii_open_page) Sets page_open.
4412 (ascii_close_page) Clears page_open.
4414 * html.c: Comment and formatting fixes. Almost every external
4415 function had an assert added, checking driver_open and page_open.
4416 (html_init_driver) Broken into html_preopen_driver,
4417 html_postopen_driver, html_close_driver. Manages driver_open.
4418 (html_open_page) Sets page_open.
4419 (html_close_page) Clears page_open.
4420 (html_submit) Disabled.
4422 * lexer.c: (parse_string) Remove debugging printf.
4424 * list.q: (determine_layout) Open a page if one is not yet open.
4426 * output.c: Comment fixes.
4427 (add_class) Set the class member of the new list element.
4428 (parse_options) Don't handle device type.
4429 (colon_tokenize) New function.
4430 (configure_driver) New four-field format with a field for device
4431 type. Now initialize driver_open, page_open, next, and prev
4432 fields. Use new colon_tokenize() function. Don't do a memory
4433 copy to replace a driver, it doesn't work; instead delete the old
4434 driver and insert a new one.
4435 (destroy_driver) Don't call som_destroy_driver(). Close the page
4436 if it's open. Find the class in the list of classes and decrement
4437 that reference count. Remove the driver from the global driver
4439 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
4440 references changed. Rewritten. Don't return a driver that's not
4442 (outp_eject_page) All references to som_internal_eject_page()
4443 changed to use this. Sets cp_x to 0 as well as cp_y.
4445 * output.h: (OUTP_I_* enums) Removed.
4446 (struct som_submission_form) Removed.
4447 (struct outp_class) init_driver broken into preopen_driver,
4448 postopen_driver, and close_driver. submit changed to take a
4451 * postscript.c: Comment and formatting fixes. Almost every
4452 external function had an assert added, checking driver_open and
4454 (ps_init_driver) Broken into ps_preopen_driver,
4455 ps_postopen_driver, ps_close_driver. Manages driver_open.
4456 (ps_open_page) Sets page_open.
4457 (ps_close_page) Clears page_open.
4459 * som.c: New file, base implementation.
4461 * som.h: (struct som_table) Add struct tag.
4462 (enum SOM_COL_ACROSS) Removed.
4463 (SOM_ROWS, SOM_COLUMNS) New enums.
4464 (struct som_table_class) Add member `cumulate'. Remove `segment';
4465 change `render' arguments.
4466 (struct som_point, struct som_rect) Removed.
4467 (som_submit_table) Fixed typo, should have been som_submit.
4469 * sysfile-info: (describe_variable) Don't try to insert a
4470 subtable; just destroy it for now.
4472 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
4473 references to value labels.
4475 * tab.c: (tab_destroy) New function.
4476 (tab_columns) Change argument.
4477 [0] (tab_submit) Remove dead code.
4478 (tab_title) Allocate string from the table's arena.
4479 (tab_output_text) Only free the buffer if we allocated it.
4480 (tab_submit) New function.
4481 (static vars t, d) New static vars.
4482 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
4483 tabi_headers, tabi_cumulate, tabi_render) New functions.
4484 (glob var tab_table_class) New global var.
4486 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
4487 encapsulate the rectangle. All references changed.
4489 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
4491 * All header files updated to use struct tags in addition to
4492 typedefs for all structures. Don't use word `struct' in struct
4495 * Makefile.am: (pspp_SOURCES) Remove html.c.
4496 (INCLUDES) Replace the lib/* includes with a single lib/ include;
4497 all references updated.
4499 * command.c: (parse_cmd) Remove call to som_check_workspace.
4500 (output_line) Update to new som.
4502 * data-in.c: (parse_numeric) A single dot is not an error; it is
4503 the system-missing value.
4505 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
4508 * data-out.c: Added `const' as appropriate to many prototypes.
4509 (convert_E, convert_F, convert_CCx) Take double argument instead
4510 of value * argument.
4511 (convert_format_to_string) Call changed functions appropriately.
4512 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
4513 make a local copy of the value.
4515 * descript.q: Remove custom_variables() prototype now provided by
4517 (custom_variables) Don't increment sbc_variables, the caller does
4519 (dump_z_table, display) Update to new som.
4521 * error.c: (vmsg) Add const to prototype. Remove code to handle
4522 `too many errors' condition.
4523 (check_error_count) New function.
4524 (msg) Add const to prototype.
4526 * filename.c: (open_file) Rewrite for elegance.
4528 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
4529 (dump_full, dump_condensed, dump_statistics) Update for new som.
4531 * list.q: Don't include somP.h. Change all references to
4532 som_driver_ext to refer to the new members of som_driver. Change
4533 som_internal_eject_page() references to outp_eject_page().
4535 * main.c: (parse) Rewrite for elegance. Add call to
4536 check_error_count().
4538 * output.c: (add_class, outp_list_classes, outp_configure_driver)
4539 Rewrite or revise for new outp_driver_class_list structure.
4540 (outp_iterate_enabled_drivers) Fix comparison between disabled
4541 devices and current device type.
4542 (outp_eject_page) New function.
4544 * output.h: Comment fixes.
4545 (struct outp_driver) New members driver_open, page_open, cp_x,
4546 cp_y, font_height, prop_em_width, fixed_width. Deleted members
4548 (struct outp_driver_class_list) New struct.
4549 (outp_class_list) Changed to type outp_driver_class_list; all
4552 * print.c: (dump_table, print_trns_proc) Updated for new som.
4554 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
4555 prototypes for custom subcommands.
4556 (dump_subcommand) Always include the `else'.
4557 (dump_parser) Fix comments in output code.
4559 * set.q: Reordered functions.
4561 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
4563 * som.h: Rewritten from scratch.
4565 * str.h: Remove dead code.
4567 * tab.c, tab.h: New files, base implementation.
4569 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
4572 * t-test.q: New code from John Williams
4573 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
4574 Many many new static vars and defines.
4575 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
4576 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
4577 (struct value_list) New struct.
4578 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
4579 t_crt, t_sig, print_t_groups) New functions.
4580 (cmd_t_test) Implemented.
4582 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
4585 * vfm.c: (dump_splits) Update to new som.
4587 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
4589 * Makefile.am: (fiasco_SOURCES) Add html.c.
4591 * aggregate.c: Base source.
4593 * ascii.c: (postopen, preclose) Reformat.
4595 * data-out.c, expr-evl.c: Comment fixes.
4597 * filename.c: (open_file) When opening a file for writing, use
4598 line buffering instead of full buffering for better interactive
4599 performance. Suggested by Valerio Aimale
4600 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
4601 names `stdin', `stdout', `stderr'.
4603 * groff-font.c: Comment fixes.
4605 * html.c: New file; base version.
4607 * list.q: (write_all_headers, clean_up, determine_layout,
4608 list_cases) Ignore `special' devices for now. Needs to be fixed
4611 * output.c: (outp_init) Add html driver to list; reverse list
4614 * output.h: (struct outp_class_struct) New members `special',
4615 `submit'; comment fixes. All references changed.
4617 * postscript.c: (ps_init_driver) Make defaults for text_opt,
4618 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
4620 (postopen) Comment fix.
4621 (preclose) Comment fixes, formatting fixes. Change x->file.file
4622 references to more proper f->file.
4624 * som-high.c: (som_submit_table) Special classes use their own
4627 * som.h: Comment fixes.
4629 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
4632 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
4634 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
4636 * aggregate.c: Still working on this.
4638 * command.c: (cmd_table[]) Add AGGREGATE back in.
4639 (split_words) Make '-' a legal word separator as well as ' '.
4641 * main.c: Comment fixes.
4643 * q2c.c: (dump_parser) Don't require the procedure's full name to
4644 be present, in the generated source.
4646 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
4647 multiply specified and let it be default; let MISSING, CRITERIA,
4648 FORMAT be multiply specified.
4649 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
4650 (custom_groups) Fix defaults.
4651 (custom_pairs) Check whether this is a PAIRS subcommand before
4652 attempting to parse. Better garbage collection. Proper storage
4654 [DEBUGGING] (debug_print) New function.
4656 * temporary.c: Comment fixes.
4657 (copy_variable) Don't copy variable name and index.
4658 (save_dictionary) Copy variable name and index by hand.
4660 * vars-atr.c: Comment fixes.
4661 (create_variable) New dictionary argument. All references
4663 (common_init_stuff) New dictionary argument. All references
4665 (init_variable) New dictionary argument. All references changed.
4666 (dup_variable) New function.
4668 * vars-prs.c: (parse_variables) If there are any errors, we always
4669 return 0. Previously, it was possible for some types of errors to
4672 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
4674 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
4677 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
4679 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
4682 * q2c.c: Comment fixes.
4683 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
4685 * t-test.q: (cmd_list) Rename cmd_t_test.
4687 * temporary.c: (new_dictionary) Don't declare as static.
4689 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
4691 * aggregate.c: Changes, still not finished.
4693 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
4695 * q2c.c: Comment fixes. Now its output is internationalized.
4696 (get_token) Fix parsing of escapes within literal strings.
4697 (main) Fix bad #line directives in output.
4699 * t-test.q: Base implementation.
4701 * temporary.c: (new_dictionary) New function.
4702 (restore_dictionary) [__CHECKER__] Change fill character to *
4705 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
4707 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
4709 * aggregate.c: Changes, still not finished.
4711 * descript.q, list.q: Comment fixes.
4713 * q2c.c: Almost completely rewritten.
4715 * t-test.q: New file, not complete.
4717 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
4719 * aggregate.c: Changes, still not finished.
4721 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
4724 * temporary.c: (cancel_temporary) New function.
4726 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
4727 of doing it by hand.
4729 * vfm.c: (close_active_file) After restoring a TEMPORARY
4730 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
4732 (SPLIT_FILE_procfunc) Comment fix.
4734 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
4736 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
4738 * aggregate.c: New file, not finished yet.
4740 * command.c: (cmd_table) Add AGGREGATE.
4742 * common.h: (pgm_state) Move declaration to var.h.
4744 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
4746 (parse_string) Message fix.
4748 * recode.c: Comment fix.
4750 * sfm-read.c: (read_variables) Code esthetic fixes.
4751 (write_header) Default date is `Jan', not `JAN'.
4753 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
4755 * sort.c: (cmd_sort_cases) Farm the work out to new function
4756 parse_sort_variables().
4757 (parse_sort_variables) New function.
4758 (sort_cases) New function. Cancels temporary transformations,
4759 which sorting didn't do previously.
4760 (cmd_sort_cases) Better garbage collection on error. Uses
4762 (write_initial_runs, merge_once) Improved code esthetics.
4763 (sort_stream_read) Reduced to one call to read_output_cases().
4764 (read_output_cases) New function.
4766 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
4767 variable labels to 120 characters.
4769 * var.h: Comment fixes.
4770 (glob var pgm_state) From common.h.
4772 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
4774 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
4775 options. Set *names to NULL on error.
4777 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
4779 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
4781 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
4782 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
4784 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
4786 * vfm.c: (page_to_disk) Added missing local variables.
4788 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
4790 * get.c: Comment fix.
4792 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
4793 source is anything other than a disk stream, not just if it's in a
4794 memory stream. Call page_to_disk() before external sort.
4795 (allocate_cases) Message fix.
4797 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
4799 (page_to_disk) New function.
4801 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
4803 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
4805 * common.h: (macro strerror) Remove. From Alexandre Oliva
4806 <oliva@dcc.unicamp.br>.
4808 * get.c: (dict_delete_run) The number of variables to delete is
4809 not necessarily the number of variables that need to be shifted
4811 (trim_dictionary) Don't set *options to 0. Fix bug that caused
4812 too many variables to be deleted.
4814 * postscript.c: Comment fix.
4816 * q2c.c: Include strerror.c. From Alexandre Oliva
4817 <oliva@dcc.unicamp.br>.
4819 * set.q: #undef ON and OFF. From Alexandre Oliva
4820 <oliva@dcc.unicamp.br>.
4822 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
4823 early, otherwise errors cause a bad free().
4825 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
4826 Oliva <oliva@dcc.unicamp.br>.
4828 * temporary.c: (save_dictionary) Don't allocate memory if
4831 * vfm.c: (memory_stream_write) Message fix.
4833 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
4835 * command.c: (static var cmd_table[]) Define REPEATING DATA
4838 * common.h: Added support for broken systems that are missing
4839 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
4841 * Many source files: Replace syntax error messages via msg() with
4842 call to syntax_error().
4844 * data-list.c: (dump_fixed_table) Add support for dumping table
4845 for REPEATING DATA as well as DATA LIST FIXED.
4846 (cmd_repeating_data) Allows and requires `/' between subcommands.
4847 Does proper thing with allowing rpd.starts_end to stay 0. Allows
4848 CONTINUED specifications to be omitted. Forces CONTINUED to be
4849 specified if ID is. Calculates starts_end, cont_end from logical
4850 record length as reported by fhp. Calls dump_fixed_table() if
4851 requested. Fixed length of record copied by memcpy.
4852 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
4854 (realize_value) Returns sensible value for out-of-range variable
4856 (rpd_parse_record) New argument `ofs'. Fixed confusion between
4857 length of occurrences and length of line. Added warning for
4858 fields that exceed the line length. Fixed infinite loop.
4859 (read_one_set_of_repetitions) Numerous minor changes for more
4860 complete SPSS compliance. Message fixes.
4862 * dfm.c: (dfm_close) If the file being closed is the inline file,
4863 read all the remaining data before closing it.
4864 (dfm_get_record) Don't close the file on lossage, as either it
4865 has been closed already or it doesn't belong to us.
4867 * error.c: (puts_stdout) New function.
4868 (vmsg) Use puts_stdout instead of puts.
4870 * file-handle.q: (fh_record_width) New function.
4872 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
4875 (input_program_source_read) Made an old kluge an approved method.
4877 * lexer.c: (syntax_error) New function.
4879 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
4882 * output.c: (oupt_get_paper_size) Message fix.
4884 * q2c.c: Numerous fixes to formatting of generated code made to
4885 conform to GNU coding standards. Uses syntax_error() in generated
4886 code. Other miscellaneous generated message fixes. Added support
4887 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
4888 RAND_MAX, and/or strerror().
4890 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
4892 * data-in.c: Comment fixes.
4894 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
4895 (find_variable_input_spec) New function.
4896 (cmd_repeating_data) Initializes id_spec.
4897 (rpd_parse_record) Implemented.
4898 (read_one_set_of_repetitions) Returns -3 by default in order to
4899 kluge out some potential bugs.
4901 * data-out.c: Comment fixes.
4903 * file-type.c: (internal_cmd_record_type) Message fix.
4905 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
4906 for handling -3 return value.
4908 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
4910 * data-list.c: Comment fixes.
4911 (struct dls_var_spec) Reordered members.
4912 (read_from_data_list_fixed) Restructured.
4913 (struct repeating_data_trns) Reordered members. Renamed `starts'
4914 as `starts_beg', `ends' as `starts_end'.
4915 (cmd_repeating_data) Calculates length of repeated data if
4916 necessary and possible.
4917 (parse_num_or_var) Don't allow string variables.
4918 (realize_value) New function.
4919 (rpd_msg) New function.
4920 (rpd_parse_record) New function. Currently stubbed out.
4921 (read_one_set_of_repetitions) Implemented.
4923 * inpt-pgm.c: (input_program_source_read) Comment fix.
4925 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
4927 * command.c: (cmd_end_repeat_p) Removed.
4928 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
4929 (parse_cmd_name) Removed.
4931 * data-list.c: Comment fixes.
4932 (data_list_pgm) Removed `eof' member.
4933 (static var first) New var.
4934 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
4935 FILE TYPE file inside FILE TYPE structures.
4936 (append_var_spec) Appends to *first, not dls.spec.
4937 (parse_fixed) Message fixes.
4938 (struct rpd_num_or_var) New.
4939 (struct repeating_data_trns) New.
4940 (static var rpd) New.
4941 (cmd_repeating_data) New function.
4942 (parse_num_or_var) New function.
4943 (parse_repeating_data) New function.
4944 (read_one_set_of_repetitions) New function.
4946 * file-type.c: (cmd_file_type) Message fixes. Always
4947 default_handle to FILE TYPE file handle.
4948 (internal_cmd_record_type) Message fixes.
4950 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
4952 * repeat.c: Comment fix. Disable debugging.
4954 * temporary.c: (restore_dictionary) Sets splits to NULL and
4955 n_splits to 0 before destroying the variables because now doing
4956 this tries to remove split variables.
4958 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
4959 destroying the dictionary.
4960 (clear_variable) Removes a variable from splits after destroying
4963 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
4965 * cmdline.c: (set_compat) Removed.
4966 (pick_compat) Removed.
4967 (parse_command_line) Removed -c option.
4968 (pre_syntax_message) Removed -c option.
4969 (usage) Remove compatibility code.
4971 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
4972 (glob var compat) Removed.
4974 * compute.c: (type_check) Fixed messages about type mismatches.
4976 * data-list.c: (cmd_data_list) Removed compatibility code.
4977 (fixed_parse_compatible) Calls convert_negative_to_dash().
4978 Fixed bug where it only set the variable in fx.spec if it created
4979 the variable itself.
4980 (dump_fmt_list) Spelling fix.
4981 (cut_field) Removed compatibility code.
4983 * dfm.c: (cmd_begin_data) Don't require a command terminator on
4986 * expr-evl.c: (evaluate_expression) Implement LAG.
4988 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
4989 (parse_neg) Calls convert_negative_to_dash().
4990 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
4993 * expr.h: (struct expression_struct) Removed member max_lag.
4995 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
4996 (internal_cmd_record_type) Removed special handling to produce
4997 negative numbers from dash tokens.
4999 * getline.c: (static var DO_REPEAT_level) New var.
5000 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
5001 (handle_line_buffer) Copies the line into getl_buf; doesn't call
5002 copy_with_DO_REPEAT_substitutions().
5003 (getl_read_line) Maintains value of getl_mode. Calls
5004 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
5006 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
5008 * getline.h: (getl_mode) New glob var.
5010 * glob.c: Comment fixes.
5011 (init_glob) Restructured. Sets set_seed.
5012 (init_compat_dependent) Removed. All references removed.
5013 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
5014 (__htonl, __htons) Removed. (What were these for?)
5016 * lexer.c: (static var tbl) Dash set to class CNUM.
5017 (make_hexit) New function from data-out.c.
5018 (get_token_representation) Rewritten.
5019 (convert_negative_to_dash) New function.
5020 (lex_init_compat_dependent) Removed.
5021 (yylex) A dash is parsed as part of a number if it is followed by
5022 a digit. The ASCII representation of a number is copied to
5023 tokstr. String parsing farmed out to parse_string(). Comment
5025 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
5027 (preprocess_line) Line processing depends on interactive/batch
5028 mode, not on compatibility mode. Removed PC+ compatibility code.
5030 * loop.c: (loop_3_trns_proc) Comment fix.
5032 * main.c: Remove dead code.
5033 (main) Remove call to init_compat_dependent().
5035 * misc.c: (convert_fmt_ItoO) Make E format conversion more
5038 * print.c: (parse_string_argument) Calls
5039 convert_negative_to_dash().
5040 (fixed_parse_compatible) Calls convert_negative_to_dash().
5042 * repeat.c: (RPT_* defines) Removed.
5043 (struct rpt_numeric) Removed.
5044 (struct repeat_entry) New member type, changed `replacement' from
5046 (clean_up) Deallocation adapted to new repeat_entry.
5047 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
5048 usage. Creates vars for `type' of 1.
5049 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
5050 (store_numeric) Rewritten, new interface.
5051 (parse_numbers) Rewritten.
5052 (parse_strings) Rewritten.
5053 (find_DO_REPEAT_substitution) New function.
5054 (perform_DO_REPEAT_substitutions) New function.
5055 (copy_with_DO_REPEAT_substitutions) Removed.
5056 (debug_print) Rewritten.
5058 * set.q: Comment fix.
5059 (custom_results) Removed compatibility code.
5060 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
5063 * sysfile-info.c: (cmd_display) Removed compatibility code.
5065 * tokens.h: Comment fixes.
5066 (token types enum) Removed `toktype' typedef name for this int
5067 type. Removed SUBST. Restructured.
5069 * vars-atr.c: (discard_variables) Sets n_lag to 0.
5071 * vars-prs.c: Comment fix.
5073 * vfm.c: Comment fixes.
5074 (glob var n_lag) New var.
5075 (static vars lag_count, lag_head, lag_queue) New vars.
5076 (procedure) Removed argument nlag.
5077 (setup_lag) New function.
5078 (close_active_file) Discards lagging state.
5079 (lag_case) New function.
5080 (lagged_case) New function.
5081 (write_case) Lags a case if lagging.
5083 * weight.c: (cmd_weight) Removed compatibility code.
5085 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
5087 * getline.h: (struct getl_script) New members loop_index, macros.
5089 * getline.c: (getl_add_file) Sets first_line field to NULL.
5090 (getl_add_DO_REPEAT_file) New function.
5091 (handle_line_buffer) When the current line's length is negative,
5092 set the filename and line number. Increment line number after
5093 reading line. Pass the line to
5094 copy_with_DO_REPEAT_substitutions() for processing.
5095 (getl_close_file) Free DO REPEAT lines before freeing the
5096 filename, and just set the filename to NULL when doing this,
5097 because otherwise the filename gets freed twice.
5099 * glob.c: (glob var queuing) Removed. All references removed.
5101 * lexer.c: Comment fixes.
5102 (get_token_representation) New function.
5104 * repeat.c: Comment fixes.
5105 (struct repeat_entry) Replaced type and v union members with a
5107 (append_record) New function.
5108 (internal_cmd_do_repeat) Started reforming it for the new
5109 repeat_entry struct. Properly records filename changes in the
5110 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
5111 strncasecmp() result usage. Uses append_record() to simplify.
5112 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
5115 (copy_with_DO_REPEAT_substitutions) Started coding.
5117 [DEBUGGING] (debug_print_lines) New function.
5119 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
5121 * tokens.h: (macro is_id1, is_idn) New macros.
5123 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
5125 * cmdline.c: (static var pre_syntax_message) Changed `win'
5126 compatibility mode to `wnd'.
5128 * data-list.c: (fixed_parse_spss) Renamed
5129 fixed_parse_compatible().
5131 * glob.c: (init_glob) Excise unused code for
5132 program_invocation_short_name.
5134 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
5137 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
5139 * set.q: `win' compatibility renamed `wnd'.
5141 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
5143 * filename.c: [__WIN32__] Change the included Windows header files
5145 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
5146 second character is absolute.
5147 (dirname) Fix logic error. Don't printf() the results.
5148 (prepend_dir) Don't printf() the results.
5150 * getline.c: (handle_line_buffer) New function.
5151 (getl_read_line) Reads line with handle_line_buffer() when
5153 (getl_close_file) Discard line buffer data.
5155 * getline.h: Comment fixes.
5156 (struct getl_line_list) New struct.
5157 (getl_script_struct) Added line buffer members. These are hooks
5158 for use by DO REPEAT to allow it to insert virtual source code
5161 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
5162 Override Borland C++ stupidity that claims Windows has a console
5165 * repeat.c: This is in the process of being restructured from
5166 using a token-buffering approach to the DO REPEAT facility to
5167 using the more flexible approach of a line-buffering approach in
5168 conjunction with the getline module. Comment fixes.
5169 (struct tok_struct) Removed.
5170 (static vars queue_index, queue_head, queue) Removed.
5171 (static vars line_buf_head, line_buf_tail) New vars.
5172 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
5174 (pull_queue, destroy_queue) Removed.
5175 [DEBUGGING] (debug_print_tokens) Removed.
5177 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
5179 * file-handle.q: (prepend_current_directory) New function.
5180 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
5181 current directory before normalizing filename.
5183 * filename.c: (gnu_getcwd) New function.
5184 (absolute_filename_p) New function.
5185 (search_path) New argument, PREPEND. All references changed to
5186 pass NULL except those explicitly mentioned. Uses
5187 absolute_filename_p(). Prepends PREPEND before trying the
5189 (dirname, prepend_dir) New functions.
5191 * getline.c: (getl_get_current_directory) New function.
5192 (getl_include) Passes getl_get_current_directory() as PREPEND arg
5195 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
5197 * In several source files, the term `script' was replaced with
5198 `syntax file' inside error messages. Usage of the term `script'
5199 in the sense of a syntax file is now deprecated.
5201 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
5204 * dump-sysfile.c: (usage) Update message.
5206 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
5208 * getline.h: (glob var getl_include_path) Declare extern.
5210 * list.q: Define EXTERN as extern before #including somP.h.
5212 * var.h: Remove declaration of `disptype' variable.
5214 * vfm.c: (close_active_file) After switching the data sink to a
5215 data source, set vfm_sink to NULL, because it doesn't exist any
5218 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
5220 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
5221 _matherrl() to ignore all math errors.
5223 * sfm-read.c: (read_value_labels) When reading the labels from
5224 disk, read the little parts separately instead of as a struct;
5225 this avoids alignment problems.
5227 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
5228 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
5229 (write_header) Allocates and initializes elem_type.
5230 (sfm_write_case) Uses elem_type to determine how to handle each
5232 (sfm_close) Frees elem_type.
5234 * sfmP.h: Comment fix.
5235 [__BORLANDC__] Uses #pragma -a to adjust structure member
5238 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
5240 * Makefile.am: (fiasco_SOURCES) Remove display.c.
5242 * common.c: Fix typo.
5244 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
5245 sense of the condition.
5247 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
5248 line-continuation backslash.
5250 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
5252 * frequencies.q: (custom_grouped, add_percentile) Don't use a
5253 non-constant expression as an argument to sizeof.
5255 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
5256 undefine gettext macro because that's a conio function.
5258 * hash.h: (hsh_prime_tab declaration) Remove.
5260 * list.q: (write_fallback_headers) Move `leader' allocation out of
5261 main loop. Change to local_alloc() allocation.
5263 * output.h: Formatting fixes. Put __attribute__ in right place on
5264 function prototypes.
5266 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
5267 incorrect `SECOND_LOWEST_VALUE' references to proper
5268 `second_lowest_value'.
5270 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
5271 value. This way 2 out of 3 of the som files define the vars
5272 extern, the correct way, that actually works under BC++.
5273 (som_set_float) Don't use nonconstant initializers for a struct.
5275 * som-high.c: Add the standard alloca() header.
5276 (replicate_table) Add prototype.
5278 Merged DISPLAY routine.
5279 * sysfile-info.c: (AS_*) New enum series.
5280 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
5282 (cmd_display, display_macros, display_documents,
5283 display_variables) Stolen from defunct display.c.
5284 (describe_variable) New function.
5286 * temporary.c: [0] (display_tree) New debug function.
5287 (copy_variable) Performs shallow copy of value labels instead of
5288 deep copy; i.e., just copys the AVL tree and increments the
5291 * val-labs.c: Comment fixes.
5292 (do_value_labels) Optionally skip leading forward slash.
5293 (get_label) Creates only a single value label instead of many
5294 copies of one, and sets the reference count.
5296 * display.c: Removed.
5298 * dump-sysfile.c: New file, not yet complete.
5300 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
5302 For lots of source files I added more verbose_msg's. These aren't
5303 listed below as they have tested as being benign. In some cases
5304 these replaced debug_printf() calls.
5306 * output.c: (outp_read_devices) Message fix.
5308 * postscript.c: (output_encodings) Message fix. Reports errors on
5310 (postopen) Message fix.
5312 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
5314 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
5316 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
5319 * main.c: Remove <malloc.h> #include.
5321 * mis-val.c: (parse_numeric) Set .f member for each missing[]
5322 instead of trying to just set the missing[] itself, which is a
5325 * sfm-read.c: (read_variables) Same.
5327 * str.h: Add memmem() prototype.
5329 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
5331 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
5333 * Makefile.am: (q2c) Don't include any libraries in the link.
5335 * dfm.c: (force_line_buffer_extension) New macro.
5336 (count_tabs) New function.
5337 (tabs_To_spaces) New function.
5338 (read_record) Calls tabs_to_spaces() on the line being processed.
5340 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
5341 have to be compiled twice (once for CC, once for LOCAL_CC).
5343 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
5345 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
5346 (LDADD) Add @INTLLIBS@.
5347 (q2c) Add LIBS, @INTLLIBS@ to link step.
5349 * inpt-pgm.c: Turn off debugging.
5351 * postscript.c: (postopen) Format fix. local_free() blocks
5352 returned by local_alloc(); don't free() them.
5354 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
5356 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
5359 * data-list.c: (read_from_data_list_fixed) Pass proper value for
5360 LEN arg, not simply the full string length.
5362 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
5363 directories before generic temp file directories.
5365 * vfm.c: Disable debugging.
5367 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
5369 * get.c: Comment fix.
5370 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
5372 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
5374 * expr-prs.c: (debug_print_postfix) Conditionally included on
5375 GLOBAL_DEBUGGING. Removed out_header() reference.
5377 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
5379 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
5381 * ascii.c: Removed obsolete ascii_close_page() prototype.
5383 * command.c: (output_line) Comment fix.
5385 * data-in.c: Formatting fix.
5386 (parse_string_as_format) Now the `fc' argument is used only for
5387 the purpose of error messages; it is not an index into the string
5388 passed. All references changed.
5390 * data-list.c: Comment fix.
5391 (cut_field) Comment fix. Now returns the column number of the
5392 position of the field cut out on success.
5393 (parse_field) Added `column' argument. Puts the column numbers in
5395 (read_from_data_list_free, read_from_data_list_list) Record the
5396 column number returned by cut_field(), pass it to parse_field().
5398 * dfm.c: Comment fix.
5400 * do-ifP.h: Comment fix.
5402 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
5403 the SYSMIS function.
5405 * expr.h, exprP.h: Comment fix.
5407 * glob.c: (init_glob) Only calls setlocale() and family if
5410 * hash.h: Comment fix.
5412 * include.c: Comment fix.
5414 * output.c: Comment fix.
5416 * postscript.c: (ps_line_intersection) Simplified assertion.
5418 * repeat.c: Comment fix.
5420 * vars-atr.c: Comment fix.
5422 * vars-prs.c: Comment fix.
5424 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
5425 behavior with usage of postincrement.
5426 (memory_stream_read) Discards cases as it goes.
5428 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
5430 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
5433 * Most source files: Includes debug-print.h, related comment
5436 * cases.c: (alloc_val) Removed complex allocation code. Merely
5437 increments default_dict.nval and returns the former value.
5438 (envector, devector) Removed references to lv member of struct
5441 * common.h: (macro VME) Replaced complex definition with simple
5444 * data-list.c: (cmd_data_list) Sets vfm_source instead of
5445 read_active_file and cancel_input_pgm.
5446 (read_from_data_list, cancel_data_list) Removed.
5447 (data_list_source_read, data_list_source_destroy_source) New
5449 (glob var data_list_source) New var.
5451 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
5452 (cmd_begin_data) Improved criteria for an input program accessing
5453 the inline file. Still not perfect.
5455 * do-if.c: (do_if_trns_proc) Simplified debug output.
5457 * expr-prs.c: Comment fixes.
5458 [DEBUGGING] (debug_print_postfix) Simplified debug output.
5460 * file-handle.q: (fh_close_handle) Simplified debug output.
5462 * file-type.c: Comment fixes.
5463 (cmd_file_type) Sets vfm_source instead of read_active_file and
5465 (cmd_end_file_type) On failure, discards variables in place of
5466 just canceling the input program.
5467 (read_from_file_type) Renamed file_type_source_read.
5468 (cancel_file_type) Renamed file_type_source_destroy_source.
5469 (glob var file_type_source) New var.
5471 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
5472 (cmd_get) Initializes options to GTSV_NONE before passing to
5473 trim_dictionary(). Removed `lv' reference. Sets vfm_source
5474 instead of read_active_file and cancel_input_pgm.
5475 (cmd_save_internal) Initializes options before passing to
5476 trim_dictionary(). Local var `nval' removed.
5477 (dict_delete_run) Comment fixes.
5478 (trim_dictionary) Comment fixes. Disallows scratch variables if
5479 GTSV_OPT_SAVE set in options.
5480 (read_from_get) Renamed get_source_read.
5481 (cancel_get) Renamed get_source_destroy_source.
5482 (glob var get_source) New var.
5484 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
5485 read_active_file and cancel_input_pgm.
5486 (read_from_input_program) Renamed input_program_source_read.
5487 Simplified debug output.
5488 (cancel_input_program) Renamed
5489 input_program_source_destroy_source.
5490 (glob var input_program_source) New var.
5492 * loop.c: (loop_1_trns_proc) Simplified debug output.
5494 * main.c: (dump_token) Made eof output more explicit.
5496 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
5499 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
5500 code for always-memory or always-disk cases. malloc's case-list
5501 based on vfm_source_info.ncases. Explicit support for
5502 memory_stream via memory_source_cases.
5503 (do_external_sort) Sets vfm_source instead of read_active_file and
5505 (allocate_file_handles) The temporary directory permissions are
5506 set to 0700 instead of 0777.
5507 (allocate_cases) Formatting fixes. Simplified debug output.
5508 (output_record) Compacts the case if necessary before writing it
5510 (close_handle, open_handle_w) Simplified debug output.
5511 (write_initial_runs) Destroys vfm_sink, then sets it to
5512 sort_stream. Writes records to memory based on
5513 vfm_sink_info.case_size.
5514 (write_to_sort_cases) Renamed sort_stream_write().
5515 (merge) Simplified error handling. Simplified debug output.
5517 (read_from_external_sort) Renamed sort_stream_read().
5518 Reads records based on vfm_source_info.case_size.
5519 (sort_stream_write) Writes records to memory based on
5520 vfm_sink_info.case_size.
5521 (sort_stream_mode) New function.
5522 (glob var sort_stream) New variable.
5524 * temporary.c: (cmd_temporary) Simplified debug output.
5525 (copy_variable) Removed references to `lv'.
5527 * title.c: (get_title) Simplified debug output.
5529 * var.h: Comment fixes.
5530 (struct get_proc) Removed member `lv'.
5531 (struct variable) Removed member `lv'. Comment fixes.
5532 (glob vars read_active_file, write_active_file, cancel_input_pgm)
5534 (struct case_stream) New.
5536 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
5537 read_active_file references to use vfm_source.
5538 (init_variable, replace_variable) Removed references to `lv'.
5540 * vfm.c: Comment fixes.
5541 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
5543 (static var queue, qh, qt, n_lag) Removed. All references
5545 (glob var compaction_necessary, compaction_nval, compaction_case,
5546 paging) New variables.
5547 (record_case) Removed.
5548 (procedure) Comment fixes. Calls vfm_source->read() instead of
5551 (prepare_for_writing, arrange_compaction, make_temp_case,
5552 vector_initialization, setup_filter) New function.
5553 (open_active_file) Most of the code moved into the abovementioned
5554 new functions. Now sets temp_dict to &default_dict if there is no
5555 temporary dictionary, for convenience. New debug output.
5556 (close_active_file) Deals with changing the sink to the source.
5557 Calls finish_compaction(). Frees compaction_case. Mostly
5559 (glob vars disk_source_file, disk_sink_file) New vars.
5560 (destroy_active_file, read_from_memory) Removed.
5561 (disk_stream_init, disk_stream_read, disk_stream_write,
5562 disk_stream_mode, disk_stream_destroy_source,
5563 disk_stream_destroy_sink) New functions.
5564 (glob var vfm_disk_stream) New var.
5565 (glob vars memory_source_cases, memory_sink_cases,
5566 memory_sink_iter, memory_sink_max_cases) New vars.
5567 (memory_stream_init, memory_stream_read, memory_stream_write,
5568 memory_stream_mode, memory_stream_destroy_source,
5569 memory_stream_destroy_sink) New functions.
5570 (glob var vfm_memory_stream) New var.
5571 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
5572 named `more_cases'. Simplified debug output. Otherwise mostly
5574 (record_case) Moved into the stream drivers. Removed.
5575 (transform) Removed (was dead code).
5576 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
5577 common case that the splits don't change, we don't need to copy
5578 the case into prev_case again--pointless.
5579 (compact_case) New function.
5580 (finish_compaction) New function.
5582 * vfmP.h: Comment fixes.
5583 (DEV_* enum series) Removed.
5584 (struct storage) Renamed `stream_info'. Removed variant record.
5585 Removed `device' member.
5587 * debug-print.h: New file.
5589 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
5591 * autorecode.c: Turned off debugging.
5593 * data-list.c: (destroy_dls) Closes the associated file handle.
5595 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
5596 parse_variables() options.
5598 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
5600 * display.c: (display_variables) Really fixed null cell bug.
5602 * file-handle.q: (fh_close_handle) Changed debugging message.
5604 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
5605 parse_variables() options.
5607 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
5608 (cmd_list) Fails if no variables specified.
5609 (determine_layout) Writes blank lines manually.
5611 * loop.c: (loop_1_trns_proc) Made debugging code only print
5612 messages if debugging.
5614 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
5615 parse_variables() arguments.
5616 (main) Parses optional parenthesized options to varlist
5617 subcommands into sbc->message.
5619 * sfm-read.c: Format fix.
5621 * var.h: (FV_*) New enum series.
5622 (PV_*) New enum PV_NO_SCRATCH.
5624 * vars-prs.c: (find_var) Removed.
5625 (fill_all_vars) Takes FV_* enum instead of boolean third
5626 argument. Rewritten to deal with scratch as well as system
5628 (parse_variables) Error message on scratch variable if
5631 * vfm.c: (static var virt_begin_func) New var.
5632 (procedure) Sets up virt_begin_func.
5633 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
5634 after dump_splits(). For succeeding groups changes, calls
5635 virt_begin_func() instead of begin_func().
5637 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
5639 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
5642 * dfm.c: Added some debugging messages, disabled by default.
5643 (open_file_r) Fixed error message.
5644 (read_record) On eof on inline_file, instead of calling
5645 fh_close_handle(), simply jump to eof label like a normal file.
5648 * display.c: Thin lines between rows for certain kinds of
5649 listing. Fixed `null cell' bug.
5651 * error.c: (failure) Flush stdout, stderr before failing.
5653 * file-handle.q: (fh_close_handle) Added debugging message.
5655 * frequencies.q: (dump_full) Bottom line extends across entire
5656 table width. Changed title formatting.
5657 (dump_condensed) Changed title formatting.
5658 (dump_statistics) Fixed title formatting.
5660 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
5661 Sets default value of set_format.
5663 * list.q: (cmd_list) Calls blank_line() before determine_layout().
5664 Passes write_all_headers() to procedure() as pre-group func.
5665 (write_all_headers) New function.
5666 (determine_layout) Removed calls to write_header().
5667 Calls blank_line() before and after write_fallback_headers().
5669 * recode.c: (recode_trns_free) Only attempts to free head->map if
5672 * sfm-read.c: (read_variables) Allows `#' at beginning of system
5673 file variable names but gives a warning. Sets `left' based on
5674 first character being/not being `#'. On lossage frees dict->var.
5676 * som-high.c: (som_draw_title) Simplified title formatting.
5678 * vfm.c: (dump_splits) Fixed and changed splits formatting.
5680 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
5682 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
5683 beginning. Frees v_src, v_dest on successful exit. Frees
5684 h_trans[*], h_trans on lossage.
5685 (recode) Frees h_trans[*], h_trans.
5687 * dfm.c: (dfm_close) Formatting change.
5688 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
5689 longer allocates its own in inline_file.
5690 (open_file_r) Passes the local dfm_fhuser_ext to
5692 (open_file_w) Message fix.
5693 (read_record) Buffer reallocation strategy changed. Frees
5694 ext->line even in inline_file to prevent leaks.
5695 (dfm_put_record) Fixed bug where `ext' was cached before the file
5696 was opened and thus it would be NULL when the file really was
5698 (cmd_begin_data) Sets up inline_file basics itself, then calls
5699 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
5701 * list.q: (write_line) Formatting fix.
5702 (clean_up) Minor strategy change. Sets proportional font after
5704 (determine_layout) Sets fixed font before writing regular headers,
5705 or after writing fallback headers.
5707 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
5708 and KEEP vars after using them.
5710 * postscript.c: (ps_init_driver) Frees x->family.
5711 (postopen) When loading fonts, free the temporary font name buffer
5713 (ps_text_set_font_by_position) Free temporary font name buffer
5715 (text) Fixed code that calculated `lig' so that `lig' always gets
5716 initialized. Formatting fix.
5718 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
5720 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
5721 cells, not xmalloc(), so that the cells will get destroyed
5724 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
5727 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
5729 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
5732 * dfm.c: Comment fix.
5734 * list.q: Comment fixes. Include somP.h. Removed static vars
5735 table, n_columns, n_rows, part. New struct list_ext. New static
5737 (n_lines_remaining, n_chars_width, write_line) New functions.
5738 (cmd_list, list_cases) Rewritten.
5739 (begin_row, end_row, flush_table) Removed.
5740 (write_header, clean_up, write_varname, write_fallback_headers,
5741 determine_layout) New functions.
5743 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
5745 * output.h: Comment fix.
5747 * postscript.c: Comment fix.
5748 (struct ps_driver_ext) Removed prop_size, fixed_size members;
5749 added font_size. All references changed.
5750 (ps_init_driver) Initializes font_size. Simplified space checking
5752 (static var option_tab[]) Removed prop-size, fixed-size; added
5754 (ps_option) Handles font_size.
5756 * som-high.c: Moved prototypes into somP.h.
5757 (som_init_driver) New function.
5758 (som_submit_table) Moved some code into new function
5760 (build_target) Moved some code into new function
5761 som_internal_eject_page().
5762 (som_eject_page) Uses som_internal_eject_page().
5763 (som_internal_eject_page) New function.
5765 * som-low.c: Moved prototypes into somP.h.
5767 * som.h: Formatting fixes.
5769 * somP.h: (struct som_driver_ext) Removed em_width;
5770 added prop_em_width, fixed_width.
5772 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
5774 * Makefile.am: Added `localedir' definition. Added
5775 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
5777 * ascii.c: (macro draw_line) Fixed capitalization.
5779 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
5780 compute.c, count.c, data-in.c, data-list.c, data-out.c,
5781 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
5782 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
5783 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
5784 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
5785 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
5786 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
5787 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
5788 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
5789 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
5790 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
5791 for internationlization.
5793 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
5795 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
5797 * do-if.c, sort.c, val-labs.c: Comment fixes.
5799 * glob.c: (init_glob) Uncommented, updated i18n support.
5801 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
5802 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
5803 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
5804 the declarations of macros taking arguments a lot nicer.
5806 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
5808 * error.h: Removed CE, CW aliases for SE, SW.
5810 * q2c.c: Removed explicit streq() definition since it's duplicated
5813 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
5814 stats.h, str.h, tokens.h: Made the declarations of macros taking
5815 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
5818 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
5820 * cmdline.c: Comment fixes.
5821 (pick_compat) Changed return type to int. Now, instead of setting
5822 glob var `compat' to the emulation, returns the emulation. All
5824 (parse_command_line) Added terminating null to end of
5825 `long_options' array definition.
5826 (pre_syntax_message) Fixes.
5827 (usage) Shows the default emulation in the syntax message by
5828 calling pick_compat().
5830 * getline.c: (getl_add_include_dir) Separates paths with
5831 PATH_DELIMITER, not DIR_SEPARATOR.
5833 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
5834 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
5836 * output.c: (outp_configure_macro) Make earlier definitions for a
5837 particular key override later ones for the same key.
5839 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
5841 * ascii.c: Comment fixes.
5843 * output.c: (outp_get_paper_size)
5844 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
5846 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
5848 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
5849 <errno.h>. GNU libc 2 enforces this!
5851 * command.c: (parse_cmd) Fixed problem with `else' clause being
5852 paired with wrong `if'. Comment fix.
5854 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
5856 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
5857 blp_getline() to getline().
5859 * output.c: (outp_eval_dimension) Changed the fix from last time;
5860 there was no variable `a'.
5862 * q2c.c: (get_line) Fixed boundary condition overrun bug.
5864 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
5866 * output.c: (outp_evaluate_dimension) Fixed handling of negative
5867 numbers having fractional parts. Added case of a fraction without
5868 a whole-number part.
5870 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
5872 * ascii.c: (ascii_text_get_font_position) Removed.
5874 * expr.h, exprP.h: Disabled debugging.
5876 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
5879 * output.h: (struct outp_class_struct) Removed
5880 text_get_font_position method. All references deleted.
5882 * postscript.c: Big change here. Fontmaps were completely
5883 eliminated because of a change in philosophy. Comment fixes.
5884 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
5886 (struct ps_driver_ext) `position', `fontmap', `prop_name',
5887 `fixed_name' members removed. New members `prop_family',
5888 `fixed_family'. `family' member changed to type char *.
5889 (static var ps_fontmaps) Removed.
5891 (ps_init_driver) Removed obsolete references, updated.
5892 Initializes `translate_x', `translate_y', `scale'. Doesn't read
5893 fontmap, of course. Refers to font names through internal_name
5894 rather than subversive means. Frees proper items.
5895 (static var option_tab[]) Removed `fontmap-file' option; renamed
5896 `fixed-font', `prop-font'.
5897 (ps_option) Corresponds to option_tab[].
5898 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
5899 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
5900 hash_family) Removed.
5901 (postopen) Generates font names from family names. Gets
5902 PostScript font name properly. New prologue file comment `!!!'
5904 (ps_open_page) Adds translate_x, translate_y to BP prologue
5905 function; gives SF argument floating-point format.
5906 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
5907 font name. Doesn't change font family.
5908 (ps_text_set_font_by_position) Generates Groff font name from font
5909 family name instead of through table lookup.
5910 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
5911 all references changed. Reduced to simple string assignment.
5912 (ps_get_font_name) Removed.
5913 (ps_get_font_family) Reduced to string return.
5914 (text) Doesn't save `position' since it no longer exists. Ugly
5915 kluge to save font family--fix soon?
5916 (load_font) Removed PostScript name argument.
5918 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
5920 * postscript.c: Comment fix.
5921 (ps_open_page) Puts scale factor in PostScript output.
5923 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
5925 * Makefile.am: Distcleans q2c.
5927 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
5929 * ascii.c: (delineate) Sets text size even if width is zero.
5931 * command.c: Comment fix.
5932 (static var cmd_table[]) Re-enabled EVALUATE command.
5933 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
5934 of comments in script files. Now more liberal on criteria for
5935 performing a state transition--if *anything* happened correctly,
5936 not just if *everything* happened correctly.
5938 * data-out.c: (convert_F) Comment fix. Why in the fsck does
5939 Checker segfault on formatting large numbers and why in the fsck
5940 hadn't I noticed this before?
5942 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
5944 * list.q: (cmd_list) Commented out the actual output routine
5945 because of various problems. Probably will abandon the idea of
5946 using the general `crushed tables' for the LIST procedure.
5948 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
5949 clearing it. Allocates a new var_by_name dictionary before trying
5950 to add members to it.
5952 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
5953 `sib'. Changed type of `node' argument.
5954 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
5956 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
5957 [DEBUGGING] Only deletes the variable from var_by_name if that var
5960 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
5962 * Makefile.am: Added include files to SOURCES. Added
5963 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
5964 includes rules for q2c. Added `boast' target.
5966 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
5968 * Makefile.am: Maintainer-clean Makefile.in.
5970 * Makefile.am: Fixed redundant EXTRA_DIST line.
5972 * ascii.c: Comment fixes.
5973 (ascii_line_vert) Fixed overly aggressive range check.
5975 * display.c: Removed dead code.
5977 * list.q: Turn debugging on.
5978 (flush_table) New debug code.
5980 * sfm-read.c: (read_value_labels) malloc's the structure before
5981 trying to assign to its members.
5983 * sfm-write.c: Comment fix.
5985 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
5987 (output_table) No arguments anymore--gets them through `som'
5988 global. New debug code. In crushed tables, now sets `htv' as
5989 well as `hv' to avoid bad confusion later.
5990 (dump_crush_page) New debug code.
5992 * som-low.c: (som_dump_crush_page) New debug code.
5994 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
5996 All source files: Broke long lines into multiple lines.
5998 * ascii.c: (ascii_close_page) Uses host_system var in place of
5999 HOST_SYSTEM constant.
6001 * cmdline.c: (var syntax_message[]) Broke into
6002 pre_syntax_message[] and post_syntax_message[].
6003 (usage) Outputs both parts, separated by driver list.
6005 * error.h: Fixed broken formatting.
6007 * expr-opt.c: (str_search, str_rsearch) New functions.
6009 * misc.c: (blp_getdelim) Removed. All references changed to
6011 (str_search, str_rsearch) Removed.
6012 (memrmem) New function.
6014 * misc.h: (blp_getline) Removed. All reference changed to
6019 * filename.c: Includes "stat.h", not <sys/stat.h>.
6020 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
6022 * output.c: (outp_list_classes) Changed output formatting.
6024 * sfm-write.c: (write_header) Uses host_system var instead of
6025 HOST_SYSTEM constant.
6026 (write_rec_7_34) Extracts version numbers from the version string.
6029 * sort.c: Includes "stat.h", not <sys/stat.h>.
6031 * str.c: (strcasecmp) Removed.
6033 * title.c: (cmd_document) Uses host_system var instead of
6034 HOST_SYSTEM constant.
6036 * version.c: Generated on-the-fly by the Makefile instead of being
6039 * str.h: Comment fixes. Doesn't substitute for missing memmove or
6041 [!HAVE_STRNCASECMP] Declares strncasecmp().
6043 * version.h: Removed stray character. Comment fixes.
6044 (vars host_system, build_system) New vars.
6046 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
6048 * Most source files: Changed formatting of copyright notice; fixed
6049 FSF address; reformatted to better conform to GNU standards;
6050 comment fixes. Added markups to prevent GNU indent from messing
6051 up my beautiful formatting :-).
6053 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
6054 that GNU indent markups can be passed through without problems.
6056 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
6058 * get.c: Turned off debugging.
6060 * glob.c: (init_glob) Turned on save-file compression by default.
6062 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
6063 compression than was possible in save files.
6065 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
6067 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
6069 * frequencies.q: Removed Fiasco extensions. Updated calculation
6070 algorithms. Polished output format.
6071 (struct frq_info_struct) Removed members `max_degree', `min_n',
6072 all references removed.
6073 (macro frq_extensions) Removed.
6074 (static vars min_n, max_degree) Removed, all references removed.
6075 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
6076 calculate `min_n', `max_degree'.
6077 (postcalc) Passes new arg to dump_statistics().
6078 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
6080 (dump_condensed) Adds variable name title.
6081 (sum_freqs) Removed.
6082 (calc_stats) Updated calculation algorithm.
6083 (dump_statistics) Removed warning for too-few observations.
6084 Changed table formatting. Adds variable name title if passed new
6087 * output.h: Comment fix.
6089 * recode.c, sample.c, sort.c: Disabled debug code.
6091 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
6092 Improved debug code.
6094 * var.h: (enum series frq_*) Removed Fiasco extensions.
6096 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
6098 * command.c: Added PROCESS IF to command table.
6100 * Lots & lots of places, removed checks for NULLs preceding calls
6101 to free_expression(), which itself checks.
6103 * descript.q: Removed Fiasco extensions. Removed optimizations
6104 for non-weighted active files. Implemented some options.
6105 Finished polishing output format. Comment fixes. Merged
6107 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
6108 max_degree, min_n) Removed.
6109 (macro dsc_extensions) Removed.
6110 (struct dsc_info_struct) Removed `min_n' member, all references
6112 (internal_cmd_descriptives) Removed calculation of min_n,
6113 max_degree. Only deals with one `calc' routine instead of two
6115 (precalc) Eliminated redundancy. Updated for changes to
6116 descriptives_proc structure.
6117 (calc) Moved here from `descript.g'. Rewritten to calculate
6118 statistics via `moments about the mean' rather than by summing,
6119 summing squares, summing cubes, and so on.
6120 (postcalc) Rewritten for new-style statistical calculation.
6121 (display) Removed support for displaying variables across rows.
6122 No longer crushes the descriptives table. Removed ancient code.
6123 Added display of N, by variable and listwise.
6125 * descript.g: Removed; merged into `descript.q'.
6127 * expr-evl.c: (evaluate_expression) Now returns a double. For
6128 numeric results, it returns the result as well as storing it in
6129 the passed `value' structure if non-NULL. For string results it
6130 just returns 0.0 and it must be passed non-NULL. Many references
6131 to this function were optimized by use of this change, especially
6132 but not exclusively in `compute.c'.
6134 * frequencies.g: Comment fix.
6136 * glob.c: (glob var process_if_expr) New global var.
6138 * postscript.c: (static var option_tab[]) Corrected entry for
6140 (postopen) Sets x->size to x->prop_size.
6141 (ps_text_set_font_by_name) Sets font size as well as typeface for
6142 PROP and FIXED fonts.
6144 * sel-if.c: (cmd_process_if) New function.
6146 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
6147 (sfm_write_dictionary) Sets `n_cases' to 0.
6148 (sfm_write_case) Increments `n_cases'.
6149 (sfm_close) Attempts to seek the system file back to the header
6150 and write the number of cases in its proper slot.
6152 * som-frnt.c: (som_insert_table) Masks off expansion options since
6153 only SOPT_X_NORM seems to work sensibly.
6155 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
6156 with a `fixed' value of 2.
6158 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
6160 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
6161 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
6163 * var.h: (enum series dsc_*) Removed Fiasco extensions.
6164 (struct descriptives_proc) Removed `miss_noweight'; new members
6165 `X_bar', `M2', `M3', `M4', `min', `max'.
6167 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
6169 * vfm.c: (close_active_file) Cancels PROCESS IF.
6170 (write_case) Doesn't process cases unselected by PROCESS IF.
6172 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
6174 * glob.c: (glob var err) Removed.
6176 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
6177 doesn't have to take into account number of value labels since
6178 they're in a subtable anyway. Also, doesn't display more than 10
6179 value labels since we can't yet break pages in subtables.
6181 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
6183 * som-frnt.c: (som_change_table_size) Simple change for elegance
6184 that shouldn't change behavior.
6185 (som_set_value) Comment fix.
6187 * som-high.c: (som_submit_table) Message fix.
6189 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
6191 * command.c: Added SYSFILE INFO to command table.
6193 * file-handle.q: (fh_handle_filename) New function.
6195 * get.c: (save_trns_proc) Fixed a bug in padding of output data
6198 * main.c: (parse) New return value for command functions, -3.
6200 * misc.h: Comment fix.
6202 * output.h: Comment fixes.
6203 (macro COMPONENTS) Removed.
6205 * postscript.c: (write_text) Modified literal_chars[] so that `('
6206 and ')' are not written to the output in strings as literals.
6208 * sfm-read.c: (sfm_read_dictionary) New argument.
6209 (read_header) New argument. Sets the information structure's
6210 values from the header information.
6211 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
6212 bizarre Checker problem, I guess.
6213 (read_variables) Proper cleanup on lossage.
6215 * sfm.h: (struct sfm_read_info) New struct for use by
6216 sfm_read_dictionary().
6218 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
6219 currently used just for tables that can be dynamically resized and
6220 thus have to be allocated with arena_malloc() instead of
6221 arena_alloc(). All references changed.
6222 (som_change_table_size) New function.
6223 (som_insert_table) Bugfix: now inserts `cell', not `c'!
6225 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
6226 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
6229 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
6231 (draw_intersection) Now takes an argument specifying the table in
6232 question. All references changed.
6233 (draw_table_cell) New function.
6234 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
6235 (som_get_table_size) Many nice new explanatory comments.
6236 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
6238 * som.h: New enum series SOM_CREATE_* for use as create flags with
6241 * str.h: Moved a comment here from TODO.
6243 * sysfile-info.c: New file. Reference implementation.
6245 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
6247 * command.c: Added RENAME VARIABLES to table of commands.
6249 * data-in.c: (dls_error) Sets `cust_field'.
6250 (parse_N) Message fix.
6251 (parse_day_count) New function.
6252 (to_roman) Never outputs VX as a `short form' of V.
6253 (parse_month) Fixed parsing of Roman numerals.
6254 (parse_trailer) Message fix.
6255 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
6256 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
6257 the date is invalid.
6258 (parse_SDATE) Fixed swapped day, year.
6259 (parse_JDATE) Fixed bug for dates in 1582.
6260 (parse_DTIME) Allows days not between 1 and 31.
6261 (parse_numeric) Makes local copy of f.type for easier usage.
6264 * data-out.c: (convert_F) When outputting as scientific, properly
6265 sets f.type as fp->type.
6266 (insert_commas) Fixed operator precedence problem with setting of
6267 nitems. Changed strcpy to memcpy (no null terminator).
6268 (convert_date) Fixed FMT_JDATE: added 1900 to year.
6269 (convert_CCx) Essentially rewritten, but now it works.
6271 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
6273 (display_documents) Implemented.
6275 * error.c: (glob var cust_field) New var.
6276 (vmsg) Displays cust_field as part of message classes DE and DW.
6278 * formats.c: (debug_print) Fixed to compile under updated
6281 * get.c: (cmd_get, cmd_save_internal) Close file handle on
6284 * misc.c: (parse_format_specifier) Formatting fix.
6286 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
6287 `n_rename' for clarity.
6288 (cmd_modify_vars) Initializes `forward' and `positional' at
6289 appropriate times. Frees lists of vars to rename on failure.
6290 Comment fix. Frees memory on success.
6291 (rearrange_dict) Simplified `for' loop condition.
6293 * rename-vars.c: New file (reference implementation).
6295 * set.q: (internal_cmd_set) Fixed `emu' test condition.
6297 * sfm-read.c: (read_header) File label is created only if file
6298 label in file is not blank.
6299 (read_variables) Initializes `dict' local variable.
6300 (read_documents) Proper behavior on lossage.
6302 * sfm-write.c: (write_header) Doesn't blank out the file label
6303 (why was this here to begin with?!)
6305 * temporary.c: (save_dictionary) File label is copied only if
6306 non-NULL. Doesn't try to xstrdup() dictionary documents.
6307 Adapted so as to not irritate Checker.
6308 (free_dictionary) Only destroys var_by_name if non-NULL.
6310 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
6311 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
6312 lines to the document, indents the document. Also, it works now.
6313 (add_document_line) New function.
6315 * var.h: (struct dictionary) Reordering.
6317 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
6318 bits if it was allocated to begin with.
6320 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
6322 * command.c: Added MODIFY VARS to list of commands.
6324 * configure.in: Updated custom macros for autoconf 2.12. Removed
6325 mmap reference; fixed termcap library reference.
6327 * display.c: (display_variables) Fixed a few bugs although it's
6328 still not well written.
6330 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
6331 (induce_segfault) Calls chkr_disp_call_chain() instead of
6332 inducing an actual SIGSEGV.
6334 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
6335 str_search() and str_rsearch(). Fixed tests for matches on
6336 OP_INDEX and OP_RINDEX.
6338 * filename.c: (good_getcwd) Removed as the new libc for Checker
6339 doesn't contain this bug, apparently.
6341 * misc.c: (str_search, str_rsearch) Changed order of arguments for
6342 consistency with GNU memmem.
6343 (blp_getdelim) Changed `len' from `int' to `size_t'.
6345 * modify-vars.c: Reference implementation.
6347 * som-frnt.c: (zero_length) New global var.
6348 (som_create_table) Message fix.
6350 * som.h: Added gcc attributions to som_set_text(),
6351 som_output_text() prototypes. blank_line() refers to
6352 zero_length[] instead of a literal null string to suppress gcc
6355 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
6356 (allocate_cases) Decrements x_max so the last element of x[] can
6357 be used by the algorithm.
6359 * var.h: Changed minor details of `variable' declaration.
6360 (struct modify_vars_proc) New struct.
6361 (struct variable) Added field p.mfv.
6363 * vars-atr.c: Comment fix.
6365 * vars-prs.c: (fill_all_vars) More optimal implementation.
6367 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
6368 character, which it shouldn't have to do but printf() seems to
6369 read the null byte even though I supply a maximum length...
6371 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
6373 * command.c: Removed command alias X for QUIT.
6374 (parse_cmd) Fixed comment parsing.
6376 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
6378 (read_record) Fixed references to len, size.
6379 (dfm_get_record) Restructured.
6381 * file-handle.h: (struct file_handle) Field `lrecl' now of type
6384 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
6387 * modify-vars.c: New file. Not complete.
6389 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
6392 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
6393 problems caused by int/size_t differences.
6395 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
6398 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
6399 being compared were of equal length.
6401 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
6403 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
6405 * lexer.c: (get_dotted_rest_of_line) New function.
6407 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
6410 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
6411 type 6 records. Frees the dictionary properly.
6412 (read_header) Initializes the dictionary instead of letting
6413 read_variables() do it. Sets the dictionary file label from the
6415 (read_documents) New function.
6417 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
6418 write type 6 record if appropriate.
6419 (write_header) Writes file label from dictionary.
6420 (write_documents) New function.
6422 * temporary.c: (save_dictionary, restore_dictionary,
6423 free_dictionary) Properly handle new fields in dictionary struct.
6425 * title.c: (get_title) Returns after failure().
6426 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
6427 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
6429 * var.h: (struct dictionary) New fields `label', `n_documents',
6432 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
6434 * command.c: Added FILTER to list of commands.
6436 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
6439 * get.c: (cmd_save_internal) Removed weighting code since it's now
6440 handled by sfm-write.c. Properly commented out debug code.
6442 * glob.c: (glob var weighting) Removed.
6444 * sel-if.c: Comment fixes.
6445 (cmd_filter) New function.
6447 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
6448 (sfm_read_dictionary) Sets weighting variable direct in the
6449 created dictionary now. (Apparently we previously didn't support
6451 (read_header) Sets weight_index field in sfm_fhuser_ext from
6452 header read from disk.
6454 * sfm-write.c: (sfm_write_dictionary) Comment fix.
6455 (write_header) Now sets the weighting in the header from the
6456 passed primary dictionary instead of from the sfm_write_info.
6458 * sfm.h: (struct sfm_write_info) Removed field `weight'.
6460 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
6461 broke on boundary conditions.
6463 * var.h: (struct dictionary) New fields `weight_var',
6464 `weight_index', and `filter_var'.
6465 (glob var weighting) Removed. This is now part of struct
6466 dictionary. All references changed; the less mechanical changes
6467 are described above.
6469 * vars-atr.c: (find_dict_variable) New function.
6471 * vfm.c: (static var filter_index) New variable.
6472 (open_active_file) Initializes filter_index from default_dict.
6473 (write_case) Calls proc_func() only if the filter variable is
6474 nonzero; this implements FILTER behavior.
6476 * weight.c: (static var weight_varname) Removed.
6477 (cmd_weight) Modified default_dict instead of glob vars.
6478 (update_weighting) Changed the signature to modify a dictionary
6479 instead of glob vars. Now returns the weighting variable.
6480 (get_weighting_variable) Removed; its function is absorbed by
6482 (stop_weighting) Operates on a dictionary now.
6484 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
6486 * sort.c: Removed debugging info from messages.
6487 (do_external_sort) Cleans up after itself by deleting the
6488 temporary directory on failure. (On success it is deleted by the
6490 (allocate_cases) Removed debug code. Added clean up code.
6491 (output_record) Removed debug code.
6492 (merge) Added code to close all the input files that are currently
6493 open. This is a likely location for bugs, because I'm not sure
6494 about boundary conditions. Removed an unnecesary heap_delete().
6495 (merge_once) Removed input file "optimization" that in fact
6496 screwed up the rest of the code. Message and comment fixes.
6498 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
6500 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
6502 * heap.c: (heap_delete) New argument.
6504 * sort.c: Finished implementation of external sort.
6506 * vfm.c: (read_from_disk) Returns after a disk error.
6508 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
6510 * sort.c: (static var state) Removed.
6511 (static vars max_handles, tmp_basename, tmp_extname,
6512 huffman_queue) New variables.
6513 (do_external_sort) Moved most code to new functions.
6514 Creates huffman_queue.
6515 (allocate_file_handles, allocate_cases) New functions.
6516 (static vars run_no, run_length, file_index, case_count) New
6518 (output_record) Returns success. Now really writes to the output
6520 (begin_run, end_run) New functions.
6521 (write_initial_runs) Returns success. Initializes run_no to -1.
6522 Calls begin_run(), end_run() at appropriate times. Outputs debug
6524 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
6526 (merge) New function.
6528 * heap.c, heap.h: New files. Hopefully in near-final form.
6530 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
6532 * glob.c: Added write_active_file to global vars.
6534 * sort.c: Several new miscellaneous static variables.
6535 (cmd_sort_cases) Big comment fix.
6536 (perform_case_2) Renamed `do_external_sort' and completely
6538 (case_2_proc_func) Removed.
6539 (output_record, write_initial_runs, write_to_sort_cases,
6540 compare_record) New functions.
6542 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
6544 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
6546 * sort.c: (perform_case_2) Changed the method for allocation of
6547 lots of memory--now allocates one case at a time in hopes that
6548 more cases can be allocated with heavily fragmented memory.
6550 * var.h: (write_active_file) New global var.
6552 * vfm.c: (procedure, close_active_file, write_case,
6553 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
6554 arguments to procedure() to be NULL. All references to
6555 procedure() that made use of dummy functions were changed to NULL
6557 (open_active_file) If write_active_file is non-NULL, the output
6558 device becomes DEV_PGM (a new enum).
6559 (close_active_file) Sets write_active_file to NULL.
6560 (read_from_memory) Comment fix.
6561 (record_case) Calls write_active_file() when the output device is
6564 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
6568 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
6569 Fixed checking for duplicate varnames.
6570 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
6572 (autorecode_trns_free) Destroys hash tables for each recoding
6574 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
6576 * command.c: Added SORT CASES to cmd_table.
6577 (null_func, null_int_func) Prototyped.
6579 * descript.g: (calc_weight, calc_noweight) Computes own case
6582 * frequencies.q: (dump_statistics) Fixed problem with
6583 too-few-cases warning message.
6585 * get.c: (cmd_save_internal) Handles weighting properly.
6587 * hash.c: (hsh_dump) Output format changed.
6588 (force_hsh_insert) Actually works now, prototype changed.
6590 * list.q: (static var case_num) New variable.
6591 (cmd_list) Initializes case_num.
6592 (list_cases) Increments case_num.
6594 * var.h: Added definitions for SORT CASES. Comment fixes.
6596 * vfm.c: Some definitions moved to new file vfmP.h. Comment
6597 fixes. `active' renamed vfm_active, `rep' renamed
6598 vfm_replacement, all references changed.
6599 (procedure) The procfunc no longer receives a case number. All
6601 (write_case) Subtle reordering.
6602 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
6605 * weight.c: (get_weighting_variable) New function.
6607 * vfmP.h: New file with definitions from vfm.c.
6609 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
6611 * command.c: (FILE_TYPE_okay) Commented out some tests because
6612 they're clumsy and not yet needed.
6614 * var.h: Most *_trns structures moved to their respective source
6615 files. Some were moved into a new file, do-ifP.h. Comment fixes.
6616 (union any_trns) Changed to a typedef for trns_header.
6617 (struct input_program_pgm) Removed.
6619 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
6620 was allocated in the first place.
6622 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
6624 * autorecode.c: New file.
6626 * command.c: Added AUTORECODE to command table; re-enabled SET.
6628 * data-out.c: (convert_F) Handles infinities and NaNs properly.
6630 * error.c: (vmsg) Comment fixes.
6632 * hash.c: Comment fix.
6633 (hashpjw_d) New function.
6634 (hashpjw) Reimplemented as call to more general function
6636 (internal_comparison_fn) Initializes pointers properly.
6637 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
6638 (force_hsh_insert, force_hsh_find) New debugging wrapper
6641 * main.c: (main) Message fix.
6643 * output.c: (outp_read_devices) Message fix.
6645 * set.q: Comment fixes.
6646 (custom_results) Implemented Wnd/X form of subcommand.
6647 (set_routing) New function.
6648 (internal_cmd_set) Implemented ERRORS, MESSAGES.
6650 * settings.h: (SET_ROUTE_*) New enum series.
6651 (set_results) Renamed set_results_file, all references changed.
6652 (set_messages) Removed.
6653 (glob vars set_errors, set_messages, set_results) New vars.
6655 * title.c: (get_title) Remembers to xstrdup() the result of
6658 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
6660 (union any_trns) New element `arc'.
6662 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
6664 * command.c: (output_line) Removed references to set_screen.
6666 * error.c: (static var terminating) New var.
6667 (hcf) Sets terminating to 1.
6668 (vmsg) If terminating is nonzero, does not attempt to call hcf().
6669 This prevents an infinite loop if an error occurs within hcf().
6671 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
6672 statement circumlocution with `case 42000' trick.
6673 (evaluate_expression) New support for OP_STR_MIS.
6675 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
6676 statement circumlocution with `case 42000' trick.
6677 (dump_node) Handles OP_STR_MIS.
6679 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
6680 variables exceptions.
6681 (parse_function) Message fix.
6682 (ops[]) Added OP_STR_MIS.
6684 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
6686 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
6688 * glob.c: Removed set_scrnfile glob var.
6689 (init_glob) set_errorbreak set to 0 by default.
6691 * groff-font.c: Changed included files.
6692 (groff_read_font) Initializes font_arena local var correctly.
6693 (default_font) New function.
6695 * output.c: Comment fixes.
6696 (glob var disabled_devices) New variable.
6697 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
6699 [GLOBAL_DEBUGGING] (reentrancy) New function.
6700 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
6701 outp_iterate_enabled_drivers) Calls to reentrancy().
6702 (destroy_list) New function.
6703 (outp_done) Moved code to destroy_list().
6704 (parse_options) Parses `listing', `screen', `printer' options
6706 (configure_driver) Sets new `device' member of driver.
6707 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
6709 * output.h: Comment fixes. New enum series OUTP_DEV_*.
6710 (struct outp_driver_struct) New member `device'.
6712 * postscript.c: (find_encoding_file) Doesn't display its own error
6714 (default_encoding) New function.
6715 (switch_font) Calls default_encoding() if no encoding can be
6717 (text) Makes up a character metric if none exists for the desired
6719 (load_font) Properly copies a fallback filename. Calls
6720 default_font() for a font if none at all are known.
6722 * set.q: Comment fixes. Removed OUTPUT subcommand.
6723 (custom_listing) Calls outp_enable_device() to enable/disable
6725 (turn_screen_on) Removed.
6726 (internal_cmd_set) Calls outp_enable_device() to enable/disable
6727 screen, printer devices.
6729 * settings.h: Comment fixes.
6730 (glob vars set_output, set_printer, set_screen, set_scrnfile)
6733 * som-high.c: (som_submit_table, som_eject_page) Use
6734 outp_iterate_enabled_drivers() instead of iterating
6735 outp_driver_list directly.
6737 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
6739 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
6740 (parse_string_as_format) Handles new formats.
6741 (parse_numeric) Now handles DOT and PCT formats.
6743 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
6745 (convert_date) Handle EDATE and SDATE formats.
6746 (convert_CCx) Now if there's not room for the currency characters,
6747 converts it as F format if it's positive instead of giving up
6748 quickly. Also fixed save-and-restore bug with decimal point
6750 (convert_format_to_string) Handles new formats.
6752 * misc.c: (formats[]) Added new formats.
6753 (convert_fmt_ItoO) Supports new formats.
6755 * sfm-read.c: (parse_format_spec) Supports new formats. Better
6756 data checking. New argument, all references changed.
6758 * sfm-write.c: (write_format_spec) Supports new formats.
6760 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
6763 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
6765 * cmdline.c: Comment fixes.
6766 (parse_command_line) Changed return type to void.
6768 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
6770 (parse_numeric) Handles international numbers (comma as decimal
6771 point). Some reformatting.
6773 * data-list.c: (parse_free) Default output format is now
6774 set_format instead of hard-coded F8.2.
6775 (read_from_data_list_list) Emits error message on undefined data
6776 only if set_undefined is nonzero.
6778 * data-out.c: (convert_E) Changes decimal point from period to
6779 comma if appropriate. Restructured. Better comments.
6780 (convert_F) Changes decimal point from period to comma if
6782 (insert_commas) Major bug with handling of negative values fixed.
6783 Also, inserts periods instead of commas if appropriate.
6784 (convert_CCx) New function.
6785 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
6786 (num_to_string) Changed `.' to set_decimal.
6788 * dfm.c: Comment fixes.
6789 (dfm_close) Frees ext->line even in inline_file.
6790 (open_inline_file) New function.
6791 (open_file_r) When opening the inline file: now properly
6792 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
6794 (read_record) Calls fh_close_handle() instead of dfm_close() to
6795 close the inline file. Makes a copy of the line getl_buf to avoid
6797 (dfm_get_record) Restructured. Now checks the return value of
6799 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
6800 checking for use of inline file. No longer tries to close inline
6803 * error.c: (glob var error_already_flagged) New var.
6804 (vmsg) Message change. Now checks max number of errors/warnings,
6807 * file-handle.q: (fh_handle_name) Now allows closing of
6809 (fh_init_files) Reformatted.
6811 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
6813 * getline.c: (getl_include) Fixed bug that popped up when called
6814 when file queue was empty.
6815 (read_console) Resets error_count, warning_count,
6816 error_already_flagged to zero.
6818 * glob.c: Many changes to update list of variables.
6819 (init_compat_dependent) Now this function is called whenever
6820 `compat' changes. It now sets set_seed only if it hasn't
6821 previously been referenced. It now calls
6822 lex_init_compat_dependent().
6824 * include.c: (cmd_include_at) Frees temporary buffer instead of
6826 (cmd_include) Doesn't make copy of include file name.
6828 * lexer.c: Comment fixes.
6829 (init_lex) Moved some code into new function
6830 lex_init_compat_dependent().
6831 (lex_init_compat_dependent) New function.
6832 (hex_val) Simplified.
6833 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
6835 * main.c: Comment fixes.
6838 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
6839 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
6840 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
6841 (setup_randomize) Sets set_seed_used.
6843 * set.q: Comment fixes.
6844 (custom_results) Conditionalizes on `compat'.
6845 (custom_log) Calls custom_journal().
6846 (set_ccx) New function.
6847 (cmd_set) Calls init_compat_dependent() when `compat' changes.
6848 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
6849 when set_decimal changes. Range-checks values for MITERATE,
6850 MNEST. Message fixes.
6852 * settings.h: Comment fixes.
6853 (struct set_cust_currency) New struct.
6854 (set_cc[], set_grouping, set_seed_used) New global vars.
6856 * var.h: (FMT_CCA...FMT_CCE) New output formats.
6857 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
6859 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
6861 * glob.c: Revised variables to correspond to settings.h.
6862 (init_glob) Initializes variables from settings.h properly.
6864 * set.q: Began long-overdue major revision to correspond to new
6865 philosophy. Most code changed.
6867 * settings.h: Mostly changed; reorganized, reordered, large new
6870 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
6872 * get.c: (cmd_save_internal) No longer forces compression off.
6874 * sfm-read.c: (read_compressed_data) If eof is reached when
6875 reading a new instruction octet, only signal error if we're in the
6878 * sfm-write.c: (COMPRESSION_BIAS) New #define.
6879 (struct sfm_fhuser_ext) New member `end'.
6880 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
6881 (ensure_buf_space) New function.
6882 (sfm_write_case) Reimplemented in order to support compression.
6883 (sfm_close) Writes out the remaining contents of the compression
6886 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
6888 * command.c: Defined SAVE and XSAVE commands in command table.
6890 * common.h: second_lowest_value is of type flt64, not double.
6892 * file-handle.h: Comment fix.
6894 * get.c: Comment fixes.
6895 (static var `trns') New.
6896 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
6897 cmd_save_internal, cmd_save, cmd_xsave) New functions.
6898 (dict_delete_run) Clears the variables and frees them now.
6899 (trim_dictionary) Sets default for compression.
6900 On KEEP subcommand, frees deleted variables as well as clearing
6901 them. Finally got the sense of the test for deleting all
6903 [DEBUGGING] (dump_dict_variables) Message fix.
6905 * glob.c: (init_glob) set_compression set to 1 by default.
6907 * list.q: Properly #includes config.h.
6909 * misc.h: New macro REM_RND_UP.
6911 * settings.h: Comment fix.
6913 * sfm-read.c: (structs sysfile_header, sysfile_format,
6914 sysfile_variable; inline function bswap_int32) Moved to new file
6916 (corrupt_msg) [__CHECKER__] No longer induces segfault.
6917 (sfm_read_dictionary) Fixed bug caused by failing to initialize
6919 (read_machine_flt64_info) Fixed some problems caused by confusion
6920 between flt64 and double types.
6921 (read_header) Message fix.
6922 (read_variables) Fixed set of cases in which we byte-swap sv.print
6923 and sv.write. Fixed confusion of flt64 and double.
6925 * sfm.h: (struct sfm_write_info) New.
6927 * som-high.c: (som_draw_title) Properly frees `s'.
6929 * temporary.c: (save_dictionary) Comment fix.
6931 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
6932 (struct trns_header) Formatting fix.
6933 (struct save_trns) New.
6935 * vars-atr.c: (discard_variables) Comment fix.
6937 * sfm-write.c: New file, baseline release.
6939 * sfmP.h: New file, baseline release.
6941 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
6943 * cmdline.c: (parse_command_line) `--version' output updated.
6944 (glob var syntax_message[]) Added my e-mail address.
6946 * file-handle.q, lexer.c, vfm.c: Changed many instances of
6947 `illegal' to `invalid'.
6949 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
6950 uncompression buffer.
6951 (sfm_close) Frees decompression buffer.
6952 (sfm_read_dictionary) Initializes decompression buffer.
6953 (buffer_input, read_compressed_data) New functions.
6954 (sfm_read_case) Restructured; now calls read_compressed_data() to
6955 handle compressed system file data.
6957 * var.h: Comment fix.
6959 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
6961 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
6964 * get.c: New comments. New static var `get_file'.
6965 (cmd_get) Now fully implemented. Calls discard_variables();
6966 initializes fv and lv for all variables; new debug code; sets
6967 up the dictionary; sets up the input program.
6968 (read_from_get, cancel_get) New functions.
6970 * sfm-read.c: Comment fixes.
6971 (sfm_close) New static function.
6972 (sfm_read_dictionary) Properly sets up the class of the
6973 file_handle. No longer cares what size the data is in records of
6974 type 7. Also, on failure, properly cleans up the file_handle and
6976 (read_variables) No longer thinks it knows `nval' of the
6977 dictionary. Now sets p.get.fv, etc., instead of speculatively
6979 (read_value_labels) Fixed off-by-one error in indexing of
6981 (sfm_read_case) New function.
6982 (sfm_r_class) New static var.
6984 * var.h: (get_proc) New struct.
6985 (struct variable) New member p.get.
6987 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
6989 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
6990 the manual's meaning.
6991 (rename_variables) New function.
6992 (trim_variables) Doesn't try to parse MAP any more. Removed debug
6993 code. Now properly reorders the dictionary on the KEEP keyword.
6995 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
6998 * vars-atr.c: (clear_variable) New argument `dictionary *'.
6999 (rename_variable) New function.
7000 (free_val_lab) Reformatted.
7002 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
7004 * var.h: Reindented entire file. Comment fixes.
7005 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
7007 (glob var default_dict) New.
7008 (struct indirect_dictionary) Removed.
7010 * Many other source files were changed to add `default_dict.'
7011 before all references to the dictionary of the active file.
7013 * vars-atr.c: (make_indirect_dictionary) Removed.
7015 * glob.c: Reindented all variable declarations. Updated for
7016 changed var.h. Comment fixes.
7018 * temporary.c: (restore_dictionary, save_dictionary) Simplified
7019 because now we can mainly copy dictionary structs.
7021 * vars-prs.c: (is_dict_varname, parse_dict_variable,
7022 parse_variables) Takes dictionary instead of indirect_dictionary
7024 (parse_variables) Instead of calling make_indirect_dictionary,
7025 just sets DICT to &default_dict if DICT is NULL. Of course, lots
7026 of `*dict.' references had to be changed to `dict->'. Removed
7029 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
7031 * get.c: Added GTSV_OPT_* series of enums.
7032 (trim_dictionary, dict_delete_run) New functions.
7033 [DEBUGGING] (dump_dict_variables) New function.
7034 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
7035 [DEBUGGING] Calls dump_dict_variables() to display results.
7037 * glob.c: (cmp_variable) Now a public function declared in var.h.
7039 * sfm-read.c: Turned off debug code. Comment fixes.
7040 (read_machine_int32_info, read_machine_flt64_info) New functions
7041 to parse type 7 records.
7042 (sfm_read_dictionary) Properly byteswaps several fields now.
7043 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
7044 records. [DEBUGGING] Dumps dictionary.
7045 (read_variables) Sets `index' field of variables created properly.
7046 Constructs avl tree of variables in dictionary. [DEBUGGING] No
7047 longer dumps dictionary.
7048 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
7050 [DEBUGGING] (dump_dictionary) No longer stubbed out.
7052 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
7053 var before destroying any variables just to save a little time.
7055 * var.h: (struct variable) Reordered in order to make name[] the
7056 first member; this makes pointers to `variable' pointers to the
7057 variable name, simplifying avl trees, etc.
7058 (struct indirect_dictionary) New struct.
7060 * vars-atr.c: (find_variable) Rewritten for efficiency.
7061 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
7063 (is_varname) Rewritten for efficiency.
7064 (parse_variables) New argument, which is a `dictionary *'. All
7065 references changed. This function now reads variable names from
7066 the dictionary passed, or from the default dictionary if NULL.
7068 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
7070 * misc.h: Added new macro DIV_RND_UP to perform integer division,
7071 rounding up. Changed many references to ROUND_UP to use this
7074 * sfm-read.c: Includes avl.h.
7075 (corrupt_msg) Induces a segfault under Checker.
7076 (macro assertive_bufread) New. Many references to bufread() now
7078 (sfm_read_dictionary) Split up into several functions. Added code
7079 to read dictionary records following the the type 2 records. Not
7080 quite complete. New variable `var_by_index'.
7081 (read_header, read_variables) New functions extracted from
7082 sfm_read_dictionary().
7083 (read_value_labels) New function.
7084 (bufread) Checks ferror() if fread() doesn't return the expected
7085 value; if ferror() is zero it's just EOF.
7086 (dump_dictionary) Stubbed out.
7088 * BTW: The source code now exceeds 50000 lines!
7090 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
7092 * command.c: Added GET to cmd_table[].
7094 * list.q: Removed reference to alloca headers.
7095 (cmd_list) Gave prototype.
7097 * sfm-read.c: Added DEBUGGING comments.
7098 (sfm_read_dictionary) Checks bias correctly. Sets
7099 dict->var_by_name to NULL. Calculates long_string_count
7100 correctly. realloc's dict->var[] array to minimum size.
7101 [DEBUGGING] Calls dump_dictionary.
7102 [DEBUGGING] (dump_dictionary) New function.
7104 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
7105 (restore_dictionary) If the dictionary contains a non-NULL
7106 var_by_name, uses that instead of generating one.
7107 (free_dictionary) Destroys var_by_name.
7109 * var.h: (struct dictionary) Added field `var_by_name'.
7111 * get.c: New file, not complete.
7113 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
7115 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
7116 (parse_num_or_range) New function.
7117 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
7118 <n> THRU HIGH missing values.
7120 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
7121 __attribute__((const)).
7123 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
7125 * sfm-read.c: Finished reference implementation.
7127 * sfm.h: Includes var.h.
7129 * var.h: Comment fixes.
7130 (struct `variable') Reordered some fields.
7132 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
7133 constants added previously.
7135 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
7137 * common.h: Comment fixes. Added declaration of
7138 `second_lowest_value' as variable or macro. Made `compat_type',
7139 `pgm_state_type' into anonymous enums.
7141 * display.c: Comment fix.
7143 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
7145 [!defined SECOND_LOWEST_VALUE] Added definition for
7146 `second_lowest_value' global var.
7147 (compat, pgm_state global vars) Changed types to `int'.
7148 (init_glob) Initializes `second_lowest_value'.
7150 * sfm-read.c: Continued work, not complete.
7152 * var.h: Added new MISSING_* constants to handle LOWEST and
7155 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
7157 * sfm-read.c: New file, not complete.
7159 * cases.c: (vec_insert) Changed vector expansion algorithm.
7160 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
7161 mucking up the RECODE transformation in particular.
7162 (envector) Harmless change in notation.
7164 dfm is now fairly well tested again.
7165 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
7167 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
7169 * recode.c: Comment fix.
7171 * sfm.h: Interface should be fairly final now, or at least for a
7174 * vfm.c: [DEBUGGING] (index_to_varname) New function.
7175 (open_active_file) [DEBUGGING] Translates ccase indices into
7176 variable names now to make it easier to understand what's really
7179 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
7181 * data-in.c: Comment fix.
7183 * data-list.c: Includes dfm.h.
7184 (do_reading) Uses new function dfm_push_cust().
7186 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
7189 * file-handle.h: Completely changed. Some parts split off into
7190 new file dfm.h. Implemented in file-handle.q.
7191 (enum FH_*) Removed.
7192 (struct fh_ext_class) New struct.
7193 (struct file_handle) Retained only these fields: name, norm_fn,
7194 fn, recform, lrecl, mode. New fields class, ext.
7195 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
7196 close_handle, handle_name) Added `fh_' prefix to name, all
7199 * dfm.h: New file, implemented in dfm.c.
7200 (get_record, put_record, fwd_record, bkwd_record, set_record,
7201 get_cur_col) Functions moved from file-handle.h, now prefixed with
7203 (dfm_push_cust) New function.
7205 * sfm.h: New file. Incomplete.
7207 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
7208 interface. Functions reordered, comments changed. Not well
7209 tested, probably full of bugs.
7210 (struct dfm_fhuser_ext) New struct.
7211 (dfm_close) New function.
7212 (open_file_r) Pickier about finding `BEGIN DATA.' line.
7213 (open_file_w) User messages changed.
7214 (get_record) Comment fixed.
7215 (read_record) Increments ext->ln even for inline_file. Calls
7216 dfm_close() for inline_file when `END DATA.' encountered.
7217 (dfm_get_record) Experimental restructuring.
7218 (dfm_push_cust) New function.
7219 (cmd_begin_data) Detects whether the inline file was fully read by
7220 checking whether it is still open; detects whether it was read at
7221 all by checking whether the line number is greater than zero.
7223 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
7224 interface. Functions reordered, comments changed. Not well
7225 tested, probably full of bugs.
7226 (init_file_handle) Removed initializers for obsolete fields, added
7228 (fh_close_handle) Much simpler, now mainly calls the class
7230 (fh_init_files) Renamed inline file internal filename.
7232 * file-type.c: Includes dfm.h.
7233 (read_from_file_type) Doesn't use dfm internal state anymore.
7235 * inpt-pgm.c, print.c: Include dfm.h.
7237 * recode.c: (internal_cmd_recode) Casts strlen() return value to
7238 int in comparison with other int.
7240 * som-high.c: (build_target) Fixed operator precedence problem in
7241 if statement (& versus ==).
7243 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
7245 * dfm.c: (read_record) Can now read fixed-length records; not
7247 (put_record) Can now write fixed-length records; not tested.
7249 * file-handle.h: FH_* defines changed to enums. New enum series
7251 (struct file_handle) New members recform, lrecl, mode.
7253 * file-handle.q: Parser changed.
7254 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
7255 /LRECL subcommands. These are compatible with Windows.
7256 (init_file_handle) Initializes recform, mode fields.
7258 * q2c.c: (get_line) When outputting `!' comment lines, now
7259 increments the output file line number so that `#line' directives
7261 (make_identifier) New function that converts an arbitrary string
7262 into a valid C identifier.
7263 (dump_vars) Calls make_identifier() in two places in order to
7264 suppress some errors for bad identifiers.
7265 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
7266 for NO. Allows numbers to be prefixed by underscores to make them
7267 acceptable C identifiers but still to be parsed as numbers by the
7270 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
7272 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
7274 * dfm.c: Comment fixes. (get_record) Gives error if file handle
7275 was opened for writing.
7276 (open_file_w) New function.
7277 (read_record) Uses strncasecmp if available. Improved error
7279 (put_record) New function.
7281 * file-handle.h: Moved function comments into dfm.c and
7282 file-handle.q. Comment fixes. Removed declarations of
7283 tilde_expand() and normalize_filename().
7284 (struct file_handle) Changed `open' from boolean to enumerated
7285 field to allow for three states--closed, open for reading, open
7286 for writing--all references changed.
7288 * file-handle.q: Includes filename.h.
7290 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
7292 (alloc_line) Makes allowance for line terminator characters in
7294 (print_trns_proc) Now handles OUTFILE, WRITE differences.
7295 (print_space_trns_proc) Handles OUTFILE differences.
7297 * recode.c, sample.c: Comment fixes.
7299 * var.h: (struct print_trns) Changed boolean field `eject' to
7300 bitmapped field `options'; all references changed. New enums
7301 PRT_* for use with this field.
7303 * exception.h, test-exception.c: Removed.
7305 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
7307 * ascii.c: (delineate) Turned off debug output.
7309 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
7312 * data-in.c: (parse_string_as_format) Sets the entire string value
7313 to spaces, not just the short string part of it. Is this correct
7316 * data-out.c: (convert_date) Fixed DATETIME format problems with
7317 decimal places, removed debug code.
7319 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
7320 middle of parsing BEGIN DATA that would cause the lexer to read
7321 from a wild pointer `prog'; now calls new function
7322 preprocess_line() in lexer.c.
7324 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
7326 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
7327 Now call induce_segfault() to induce the segfault.
7328 (induce_segfault) New function.
7330 * expr-opt.c: Comment fix.
7331 (parse_sysvar) New function.
7332 (parse_primary) Added system variable support--calls
7334 (global var ops) Added OP_CASENUM operator.
7336 * expr.h: Comment fixes.
7337 (OP_* enum) added OP_CASENUM operator.
7338 (struct casenum_node) New struct.
7339 (union any_union_union) New member `cas' of type `casenum_node'.
7341 * glob.c: (global var last_vfm_invocation) New var.
7342 (init_glob) Initializes last_vfm_invocation.
7344 * lexer.c: (lookahead) Fixed reversed condition on if statement.
7346 * getline.c: (get_line) Split into get_line() and preprocess_line().
7347 (preprocess_line) New function.
7349 * var.h: Declares last_vfm_invocation.
7351 * vfm.c: (procedure) Sets last_vfm_invocation.
7353 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
7355 * command.c: (parse_cmd) Fixed bad assertion related to
7358 * data-in.c: (parse_month) Implemented to parse months according
7359 to full interpretation of standard.
7360 (to_roman) New function.
7361 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
7362 (parse_weekday) Bug fix (forgot to skip all the day name).
7364 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
7365 up parsing of multirecord data items. Also fixed user message.
7367 * data-out.c: Comment fix.
7368 (year2, year4, convert_date, convert_time, convert_WKDAY,
7369 convert_MONTH) New functions to support time & date output.
7370 (convert_format_to_string) Calls new time & date output routines.
7372 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
7374 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
7377 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
7379 * misc.c: (global var formats) Fixed declarations of DATETIME,
7382 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
7383 the output_char buffer.
7385 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
7386 memory bug. Fixed user messages.
7388 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
7390 * Removed #pragma argsused from lots of places.
7392 * data-in.c: Implemented zoned decimal and time-date formats.
7393 Untested. This is a huge chunk of code--maybe 1000 lines and 50
7396 * data-out.c: Implemented zoned decimal format.
7398 * expr.h: Moved yrmoda() declaration here from exprP.h.
7400 * misc.c: (global var formats) Minor fixes--added
7401 FCAT_SHIFT_DECIMAL to formats N and Z.
7402 (convert_fmt_ItoO) Added support for format Z.
7404 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
7406 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
7408 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
7409 som_check_workspace() that is activated between commands.
7411 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
7414 * list.q: (begin_row) Changed title expansion style from
7415 SOPT_X_VERT to SOPT_X_SHSP.
7417 * som-frnt.c: Now includes `somP.h'.
7418 (som_push_workspace, som_pop_workspace) New functions that, taken
7419 together, form a solution to the recursive table building problem
7420 mentioned yesterday. Surrounded every table output routine
7421 throughout the program with calls to these functions.
7422 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
7423 (som_create_table) Checks that there's an active workspace.
7424 (som_destroy_all_tables, som_crush) Removed.
7426 * som-high.c: (global var som_preserve_tables) Removed, all
7428 (som_submit_table) Checks that there's an active workspace.
7429 (dump_columnated_table) Doesn't columnate tables that would have
7430 just one row per column.
7431 (dump_crush_page, som_dump_crush_page) Removed debugging code.
7432 (som_dump_crush_page) Moved row number labels from left side of
7433 tables to right side.
7434 (som_get_table_size) Added support for SOPT_X_SHSP.
7436 * som.h: New cell expansion type SOPT_X_SHSP.
7438 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
7440 (global var curtab_arena) Moved from som-frnt.c.
7442 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
7444 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
7445 that causes bad location warnings to be suppressed.
7446 (delineate) Saves current font when calling draw_text(); fixed
7447 handling of NULLs when backing up. Also fixed line-wrapping bug.
7449 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
7450 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
7452 * common.c: Added code to cause assertion failure to dump core
7453 when run under Checker.
7455 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
7456 there are still bugs.
7458 * glob.c: (__eprintf) Removed.
7460 * list.q: Inserted som_preserve_tables kluge that prevents tables
7461 from being thrown away due to recursive table building through
7462 som_output_line being called from a transformation during the LIST
7463 procedure invocation. This is a general problem that must be
7464 solved in a better way since it applies to all procedures in
7466 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
7467 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
7469 * numeric.c: Fixed several errors in the form of msg() calls.
7471 * print.c: Updated for use of som.
7472 (dump_table) Reimplemented.
7473 (print_trns_proc) Calls som_eject_page() instead of eject_page().
7474 Calls som_output_text() instead of outs_line().
7476 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
7478 (som_output_text) Function moved from som-low.c. Interface
7481 * som-high.c: (som_preserve_tables) New global public variable
7483 (som_submit_table) Destroys the tables only if som_preserve_tables
7485 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
7486 one subrow per row. Now labels subrows if there's more than one
7488 (dump_crush_table) Added wishlist comment.
7489 (som_eject_page) New public function declared in som.h.
7491 * som-low.c: (som_dump_crush_page) Draws row labels if there's
7492 more than one subrow per row.
7493 (som_output_text) Moved to som-frnt.c.
7495 * som.h: (SOM_TOPT_PRESERVE) Removed.
7497 * title.c: (get_title) Changed interface.
7498 (cmd_title) Changed `title' to `outp_title'.
7499 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
7501 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
7503 * list.q: (flush_table) Conforms to new partial options in
7504 som_submission_form.
7506 * som-high.c: (paginate_horizontally) Changed form of subrow
7508 (build_target) Omits spacing before table if
7509 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
7510 (dump_crush_page) Changed interface. Only trims bottom rule if
7511 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
7512 (dump_crush_table) Handles partial tables.
7513 (output_row_label) New function.
7514 (som_dump_crush_page) Emits subrow number labels. Draws vertical
7515 rule on the right edge of narrow subrows.
7517 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
7518 constants to a series of SOM_TOPT_PARTIAL_* submission options.
7519 All references updated.
7521 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
7523 * misc.c: Comment fix.
7525 * som-high.c: (examine_table) Treats crushed tables separates for
7526 purpose of determining header size.
7527 (paginate_horizontally) Allots space for line numbers in crushed
7528 tables with lots of subrows per row. Calculates the `maximum page
7529 width', the width of the widest horizontal page.
7530 (build_target) Removed trim argument; all references changed.
7531 Stricter assertions. (dump_crush_page) New function.
7532 (dump_crush_table) Reimplemented.
7534 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
7535 (som_dump_crush_page) Reimplemented, interface changed.
7537 * somP.h: Many many new helper macros for use with crushed tables.
7538 (global var som) Removed `tv', `cum_y' members; all references
7539 removed. New members `mpw', `digit_space'.
7541 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
7543 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
7544 variable, changed to constant 1024.
7545 (arena_ca_strdup) Changed `sizeof(a_string)' to
7547 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
7548 `(c_string *)' to `(char *)'; this fixed some offset problems.
7550 * filename.c: (readlink_malloc) Changed initial allocation from
7552 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
7555 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
7556 &fm->owner in several places.
7558 * som-high.c: (output_table) Changed interface to rest of world.
7559 (examine_crush_table) Removed. Crushed tables are re-broken now,
7560 in preparation for rewrite.
7562 * som.h: Comment fix.
7564 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
7566 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
7567 itself in the cleanup stage.
7569 * descript.q: (display) At least temporarily, changed the table
7570 format to a crushed table.
7572 * list.q: (begin_row) At least temporarily, added horizontal lines
7575 * som-high.c: (examine_crush_table) Sets som.hh to the width of
7576 the horizontal "headers," that is, to the width of the far left
7577 and far right rules.
7578 (justify_pagination) Sets som.th to the width of the widest row
7579 in the crushed table. Fixed inner loop off-by-one error.
7581 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
7584 * somP.h: Comment fix.
7586 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
7588 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
7589 before closing it; also, opens the constructed filename `s'
7590 instead of f->filename.
7592 * postscript.c: Moved initialization of x->loaded, x->prop,
7593 x->fixed, x->current, also the add_encoding() calls, into
7595 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
7596 sets x->last_font to NULL; sets x->next_combo to zero.
7598 * som-high.c: (crushed_row_height) Moved definition farther up.
7599 (som_submit_table) Doesn't calculate line width, font size until
7600 after calling open_page(), to accomodate changes to PostScript
7602 (vert_headers) Removed; equivalent functionality moved to
7603 examine_table(), examine_crush_table().
7604 (justify_pagination) Replaced with different algorithm.
7605 (dump_crush_table) Bugfix that caused tables to fail to be clipped
7606 at the bottom of the page.
7608 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
7610 * command.c: Added cmd_list back into cmd_table.
7612 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
7613 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
7615 * list.q: (flush_table) Updated to new som_submission_form format.
7617 * som-frnt.c: Comment fix.
7619 * som-high.c: Changed `#endif' to `#undef EXTERN'.
7620 (output_table) Calls som_get_table_size() directly; handles
7622 (examine_crush_table) New function; calls vert_headers().
7623 (examine_table) Moved some code into new function, vert_headers().
7624 (justify_pagination) New function.
7625 (dump_plain_table) Removed `static' from `cy'.
7626 (dump_crush_table) New function.
7628 * som-low.c: (som_dump_crush_page) New function.
7630 * som.h: Comment fixes.
7631 (enum SOM_TOPT_CRUSH) New.
7632 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
7633 Temporarily set to zero to make do with LIST procedure.
7635 * somP.h: Re-ordering.
7637 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
7639 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
7641 * somP.h: New file for use by som-high.c, som-low.c.
7643 * q2c.c: Added definition for VME.
7644 (get_line) Now dumps `!' comment lines to the output file
7647 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
7648 set.q: Changed format of `!' comment lines.
7650 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
7652 * All source files: Added copyright notice.
7654 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
7655 longs in msg() calls.
7657 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
7659 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
7661 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
7663 * output.c: (outp_read_devices) Changed criteria for
7664 distinguishing different types of lines.
7666 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
7668 * cmdline.c: Changed syntax message.
7670 * filename.c: (good_getcwd) Bug fix (?).
7671 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
7673 (search_path) Appends DIR_SEPARATOR to directory name only if it
7674 does not already end with one.
7676 * glob.c: Checks STAT_PAGER envvar before PAGER.
7678 * output.c: Checks environment variables instead of just local
7681 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
7683 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
7684 when the pointer passed to the function was within the arena
7685 itself, so that it couldn't properly be set to NULL _after the
7688 * command.c: Re-enabled DISPLAY.
7690 * display.c: Rewritten to handle tables. Untested.
7692 * filename.c: (search_path) Fixed memory leak.
7694 * frequencies.q: (cmd_frequencies) Frees v_variables.
7695 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
7696 (cleanup_freq_tab) New function to garbage collect.
7697 (dump_full) Elegantized.
7699 * main.c: New comment.
7701 * output.h: New tag for tagged quotes: TAG_NEWLINE.
7703 * postscript.c: Comment fix.
7704 (release_fontmap, free_font_entry) New functions.
7705 (ps_init_driver) Sets free_font_entry() as the freefunc for
7706 hashtable `loaded'. Calls release_fontmap() when destroying a
7707 driver; also frees the output filename; also frees the
7708 ps_driver_ext block.
7709 (free_ps_encoding) Frees the filename as well as the encoding
7711 (output_encodings) Frees the line buffer and pops the msg-filename
7713 (read_fontmap) Frees the fontmap filename and the line buffer.
7714 (postopen, preclose) Misc. garbage collection fixes.
7715 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
7716 to NULL; this fixes some output problems.
7717 (text) Handles TAG_NEWLINE. Untested.
7719 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
7720 (som_set_string) Removed. All references changed to
7722 (som_set_text) Rewritten. New interface. More general.
7724 * som.h: Minor format changes.
7725 (struct som_value_cell) Removed; all references changed to
7727 (enums SOT_*) Changed.
7729 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
7731 * command.c: Re-enabled SPLIT FILE.
7733 * postscript.c: Comment fix.
7735 * som.h: Added `SOT_NONE'.
7737 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
7739 * vfm.c: (dump_splits) Reimplemented.
7741 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
7743 * Compiled the project under gcc 2.7.2, which gave some new
7744 warnings. This led to many additions of casts from unsigned to
7745 int sprinkled throughout the code.
7747 * arena.c: Many uses of `unsigned' changed to `size_t'.
7749 * command.c: Added END FILE, END REPEAT to command table.
7750 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
7751 (find_command, FILE_TYPE_okay) Not commented out anymore.
7752 (parse_cmd) Calls FILE_TYPE_okay again.
7753 (output_line) Added calls to som_output_text() to put the line
7754 in the output files.
7756 * common.c: (macro VME) Format changes.
7757 (xstrdup) Asserts that its argument is not NULL.
7759 * data-list.c: Implemented dump_fixed_table().
7761 * inpt-pgm.c: Formatting changes. Comment changes.
7762 (end_case_proc) Renamed end_case_trns_proc.
7763 (cmd_end_file, end_file_trns_proc) New functions.
7765 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
7767 * misc.h: (local_strdup) New macro corresponding to strdup() but
7768 allocating its data through local_alloc() if possible--that is, if
7771 * postscript.c: Comment changes.
7772 (quote_ps_name, quote_ps_string, output_encodings) New functions.
7773 (output_line, add_string) New macros supporting
7775 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
7776 substitution vars. Calls output_encodings() when a line
7777 consisting of `!encodings' is encountered.
7778 (preclose) Some code moved into quote_ps_string().
7779 (dump_line) Changed into macro supporting dump_fancy_line().
7780 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
7781 command when appropriate.
7782 (write_text) Fixed `literal_char' array (I think it's fixed, at
7784 (text) Fixed bug when width was zero. Now exits immediately on
7785 zero height_left. Now, when executing `goto restart;', checks
7786 that cp<end, so that we don't read beyond end-of-string. Also,
7787 outputs the correct code to the output file by outputting the code
7788 from the metric instead of the internal metric index.
7790 * repeat.c: (cmd_end_repeat) New function.
7792 * som.c: (var som) `headers' renamed `options' and semantics
7793 changed. All references changed.
7794 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
7795 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
7797 (som_text_table) Removed.
7798 (som_output_text) New function.
7800 * som.h: (struct som_submission_form) Removed `header', `reuse',
7801 replaced with bitmapped field `options'.
7802 (SOM_TOPT_*) New enum set for som_submission_form.options.
7803 (SOT_*) New enum set for som_output_text().
7805 * temporary.c: (copy_variable) When copying the var label, only
7806 calls xstrdup() if it's non-NULL.
7808 * var.h: (enum type `vartype') Removed; all references changed to
7811 * vars-atr.c: (init_variable) Changed local var `nbytes' from
7814 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
7816 * font.h: Comment changes.
7818 * groff-font.c: (groff_read_font) Initializes `name' field to
7819 NULL. Handles `encoding' field.
7821 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
7823 * postscript.c: (struct font_entry) Removed `position' field.
7824 (struct ps_font_combo) New struct.
7825 (struct ps_driver_ext) Removed field `next_position'. New fields
7826 `combos', `next_combo'. `last_font' field changed from
7827 `font_entry *' to `ps_font_combo *'.
7828 (ps_init_driver) Reformatted; handles new fields. When
7829 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
7831 (get_encoding, find_encoding_file) New functions.
7832 (add_encoding) Some code moved out into find_encoding_file().
7833 (postopen) Changed value for ${title}.
7834 (preclose) Sets `loaded' field to NULL after destroying the hash
7836 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
7838 (ps_text_set_font_by_position) Figures out the current family if
7840 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
7841 (switch_font) Implemented.
7842 (write_text) Calls switch_font() more often. Format changes.
7843 #undefs its macros after they're no longer useful.
7844 (text) Changed `continue' at one point to a jump to the top of the
7845 loop because we don't want `separate' reset to 0 at that point.
7846 (load_font) No longer sets `position' in the font_entry created.
7848 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
7850 * font.h: (struct font_desc) New member `encoding', which is not
7851 properly handled yet.
7853 * glob.c: (init_glob) Some new i18n code, which is probably
7856 * output.c: (outp_read_devices, outp_get_paper_size) Changed
7857 `size' local from `int' to `size_t'.
7859 * postscript.c: New driver configuration parameter `auto-encode'.
7860 New enums OPO_AUTO_ENCODE, ODA_COUNT.
7861 (struct font_entry) New member `position'.
7862 (struct ps_driver_ext) Reordered. New hash table member
7863 `encodings'; new members `next_position', `next_encoding',
7864 `last_font'. Members `current', `prop', `fixed' changed from type
7865 `font_desc *' to `font_entry *'; all references changed.
7866 (struct ps_encoding) New struct.
7867 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
7868 free_ps_encoding, add_encoding) New functions.
7869 (ps_init_driver) Added OPO_AUTO_ENCODE to default
7870 x->output_options. Initializes new members of ps_driver_ext.
7871 Changed default value for prologue_fn, encoding_fn. Calls
7872 read_ps_encodings after loading default fonts.
7873 (option_tab[], ps_option) Handle new configuration parameter.
7874 (switch_font) New function.
7875 (struct output_char) `font' member changed from `font_desc *' to
7876 `font_entry *'. New member `separate'.
7877 (read_fontmap) Changed `size' from `int' to `size_t'.
7878 (output_line, put_number) New macros for write_text().
7879 (write_text) Optimizes text output by consolidating multiple
7880 calls to PostScript `show' operator.
7881 (text) Keeps track of when text arguments can't be consolidated by
7882 write_text(), and marks those spots in the output stream.
7883 (load_font) Sets `position' of the allocated font_entry to -1, cuz
7884 the font hasn't been switched to by switch_font(), which is where
7885 the position is important--the PostScript is what cares about the
7888 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
7890 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
7891 call a NULL free_func.
7892 (hsh_rehash) Elegantized.
7893 (hsh_probe) Fix bug that manifested when the table was expanded
7894 and thus had to change location in memory. Good thing
7895 too--otherwise could have been much more subtle.
7896 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
7897 (hsh_foreach) New function for hash table iteration.
7899 * hash.h: (struct hsh_iterator) New.
7901 * lexer.c: (parse_tagged_quote) Font and family name strings in
7902 tags are now null-terminated.
7904 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
7906 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
7907 documented. (Never before tested?)
7909 * output.h: Comment changes.
7911 * postscript.c: New driver options `optimize-text-size',
7912 `optimize-line-size', `max-fonts-simult'. New enum set for
7913 specing cached line types. Comment fixes.
7914 (struct line_form) New struct.
7915 (struct ps_driver_struct) New members `text_opt', `line_opt',
7916 `max_fonts', `lines'.
7917 (ps_init_driver) Initializes new members of ps_driver_struct.
7918 (user option type enum set) New member `nonneg_int_arg'.
7919 (static var option_tab[]) Supports new options.
7920 (ps_option) Handles new options.
7921 (find_ps_file) Made static. No longer calls hsh_dump().
7922 (ps_get_var) Made static.
7923 (preclose) Dumps out proper DSC trailer.
7924 (ps_open_page) Elegantized.
7925 (ps_close_page) Calls dump_lines() if appropriate.
7926 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
7927 wrappers around line().
7928 (int_2_compare, compare_line, dump_line, dump_fancy_line,
7929 dump_lines, hash_line, free_line, line) New functions for support
7931 (write_text, text) Made static.
7932 (text) Added to font support, not finished.
7934 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
7936 * font.h: (struct font_desc) New members ascent, descent.
7938 * groff-font.c: (groff_read_font) Calculates font ascent and
7939 descent from the ascent and descent of the `d' and `p' characters,
7940 respectively, as per a suggestion on comp.fonts.
7942 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
7943 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
7945 (write_text) Handles text right-justification and centering (not
7946 full justification). Still very inefficient. (One output line
7948 (struct output_char) Added fields for font and font size.
7949 (text) Many bugfixes.
7951 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
7953 * cmdline.c: (usage) Calls outp_list_classes().
7955 * font.h: Comment fix.
7957 * groff-font.c: New exported global var `space_index'.
7958 (groff_init) New function to initialize `space_index'.
7959 (hash_kern) Casts result to unsigned.
7960 (font_name_to_index) Renamed font_char_name_to_index. All
7961 references changed. Also, now returns the value of `space_index'
7962 when passed an ASCII space character as an argument. Fixed
7964 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
7965 Handles passed NULL pointers properly.
7967 * lexer.c: (parse_tagged_quote) Comment fix. Better range
7970 * output.c: (outp_list_drivers) Removed. Removed all references.
7972 * output.h: Comment fixes.
7974 * postscript.c: (ps_open_global) Calls groff_init().
7975 (output_char) New structure.
7976 (write_text) New function.
7977 (text) No longer stubbed out! Now the output is correct--with a
7978 few exceptions, one of them being that the page has to be held
7979 upside down into a mirror.
7981 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
7983 * font.h: Comment fix.
7985 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
7986 All callers changed.
7987 (number_to_index) Renamed font_number_to_index, made extern. All
7989 (font_get_kern_adjust, font_get_char_metrics) New functions.
7991 * output.h: New constant OUTP_T_INTERNAL_DRAW.
7993 * postscript.c: Changed default line width back to 1/2 point.
7994 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
7995 in the center of the space allotted for them, not just a fixed
7996 offset from the edge of the space; this fixes some bugs.
7997 (ps_line_intersection) Now supports all command line styles.
7998 (ps_text_get_size) Bug fix in computation of em width.
7999 (text) New function, the meat behind ps_text_metrics and
8000 ps_text_draw. Not complete.
8001 (ps_text_metrics, ps_text_draw) Removed the stub taken from
8002 ascii.c; call text().
8004 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
8006 * arena.c: (arena_free) Assert that the argument is non-NULL.
8008 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
8009 only if old_kern is non-NULL.
8011 * postscript.c: (ps_init_driver) Changed default line width to 1
8013 (postopen) New prologue variables.
8014 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
8015 more of the common line styles properly, but not all.
8016 (ps_text_metrics) Fixed problem with this stubbed out version that
8017 kept it from taking font sizes into account.
8019 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
8021 * arena.c: (arena_malloc) Bug fix.
8022 (arena_dump) [GLOBAL_DEBUGGING] New function.
8024 * ascii.c: Comment fix.
8025 (count_fancy_chars, delineate) Now static functions.
8027 * filename.c: (interp_vars) Bug fixes.
8029 * font.h: Comment fixes.
8031 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
8032 beginning in case we have an error message to display before
8033 initializing the display.
8035 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
8037 (groff_read_font) Bug fixes.
8038 (name_to_index) Increments hash.used. Sets `name' field of hash
8040 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
8042 * hash.c: Return type changed.
8044 * postscript.c: Continued development. Now marks lines on the
8045 paper, but very buggy.
8047 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
8049 * Changed comments in many source files from `/* xxx /* yyy */' to
8050 `/* xxx */ /* yyy */' for cleanliness.
8052 * arena.c: (arena_sd_strdup) New function.
8054 * ascii.c: (struct ascii_driver_ext) New member `file'.
8055 (ascii_init_driver) Fills out member `file' for initing; uses
8056 close_file_ext for closing drivers.
8057 (ascii_option) Changed %.*s back to %s because the a_string's are
8058 always null-terminated.
8059 (postopen, preclose) New functions.
8060 (ascii_open_page) Uses new style of open_file_ext.
8061 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
8062 instead of this->output.
8063 (__assert_fail) Removed.
8065 * cmdline.c: Changed syntax_message[].
8067 * error.c: #include's <readline/history.h> only if the history
8068 library is available, not if just the readline library is
8071 * filename.c: (expand_line) Removed alloca() support.
8072 (interp_vars) No longer tilde-expands argument. Limit on output
8074 (tilde_expand) Now treats argument as path rather than filename.
8075 [!unix] Now is a no-op function.
8076 (search_path) Better verbose message formatting.
8077 (open_file, close_file) Comment fixes.
8078 (close_file) [!unix] Doesn't bother with pipes.
8079 (open_file_ext) Completely rewritten, interface revamped.
8080 (close_file_ext) New function.
8082 * font.h: Comment changes.
8084 * frequencies.q: Removed AIX alloca support since it doesn't use
8087 * hash.c: Comment changes & additions.
8088 (hsh_create) Initializes entire table instead of first M entries.
8089 (hsh_probe) Stupid bug fixed. Now it works.
8090 (hsh_dump) [GLOBAL_DEBUGGING] New function.
8092 * main.c: (parse) Detects EOF properly in token-eating loop.
8093 Should the STOP token have its value changed to 0?
8095 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
8096 (blp_getline) Now it's a macro.
8098 * output.h: (struct outp_driver) Removed members output, filename.
8100 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
8101 drivers in driver table.
8102 (outp_read_devices) Frees buf. Warns if there are no active
8104 (outp_configure_clear) Sets outp_configure_vec to NULL after
8105 deleting its elements.
8106 (configure_driver, destroy_driver) Removed references to output,
8107 filename members of outp_driver.
8108 (outp_evaluate_dimension, internal_get_paper_size,
8109 outp_get_paper_size) New functions.
8111 * postscript.c: Continued development. Now links but doesn't make
8112 any marks on the page. Lotsa bugs I suppose.
8114 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
8116 * str.h: Comment changes.
8118 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
8120 * Removed dependencies on non-nested comments in several files.
8121 Also removed references to (unix || __unix__) in #if's since
8122 prefh.orig makes those two equivalent.
8124 * ascii.c: (ascii_open_global) Creates ascii_arena.
8125 (ascii_close_global) Destroys ascii_arena.
8126 (ascii_init_driver) Doesn't create ascii_arena.
8127 (ascii_copy_driver) Removed.
8128 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
8129 (outp_class ascii_class) Removed ascii_copy_driver reference.
8131 * frequencies.q: Now can display all statistics except median.
8134 * output.c: Handles outp_class.ref_count so output class
8135 destructors are called properly.
8136 (add_class) Sets ref_count to 0.
8137 (configure_driver) Initializes class if ref_count++ is 0.
8138 (destroy_driver) Destructs class if --ref_count is 0. Frees the
8139 class output file name.
8141 * output.h: (struct outp_class) Removed copy_driver, inited.
8144 * postscript.c: Completely replaced but not finished.
8146 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
8148 * approx.h: #includes <float.h>.
8150 * arena.h, arena.c: Many functions changed to take an arena **
8151 instead of an arena *, for consistency. All callers changed.
8152 (arena_alloc) Now creates a new arena if passed *A that is NULL.
8153 (arena_destroy) Sets *A to NULL.
8155 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
8156 assertion that `width' be positive.
8158 * command.c: Removed #if's from cmd_table.
8159 (walk_cmdtable_func) [0] New function (debug code).
8160 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
8161 (parse_cmd) Doesn't return failure for unimplemented commands.
8163 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
8164 (SYSCODE) New constant macro.
8166 * descript.q: Checks for positive n_variables before performing
8169 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
8170 avl_find instead of &fp as arg 2.
8172 * frequencies.g, frequencies.q: Continued updating; now compiles &
8173 works again, but not complete.
8175 * main.c: Changes to user messages.
8177 * misc.c: (reverse) [0] New function.
8179 * settings.h: Comment removed. #includes "common.h".
8181 * som.c: (som_set_null) New function.
8182 (som_set_value, som_set_string, som_set_text) More detailing
8184 (som_set_float) Implemented function.
8185 (dump_columnated_table) Bug fix regarding page breaks.
8186 (draw_cell) Bug fix regarding text that spilled out of a cell.
8187 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
8189 (get_cell_size) Support SCON_EMPTY cells.
8190 (get_table_size) When calculating rules' widths and heights, mask
8191 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
8193 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
8195 (struct som_submission_form) New member `header'; all users
8198 * val-labs.c: (get_label) User messages changed.
8200 * var.h: Changed FREQUENCIES structures.
8202 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
8205 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
8207 * approx.h: Definition of EPSILON now depends on system's
8208 DBL_EPSILON. Removed GNU C specific code.
8209 (cmpapx) Renamed approx_compare.
8211 * frequencies.g, frequencies.q: Continued updating; still doesn't
8214 * groff-font.c: (name_to_index) Fix bug that kept it from
8217 * hash.c, hash.h: Completed work.
8219 * var.h: Changes to freq_tab, frequencies_proc.
8221 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
8224 * hash.c, hash.h: New files. Not completed.
8225 * Makefile.am: Added hash.c to source file list.
8226 * font.h: (struct font_desc) New member kern_size_p.
8227 * groff-font.c: Uses hash.h.
8228 (hashpjw) Moved to hash.c.
8229 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
8231 (static var hash) New member size_p.
8232 * var.h: Includes hash.h.
8233 (struct freq_tab) Changed AVL_TREE to hash_tab.
8235 * vars-prs.c: Comment, formatting fixes.
8237 * frequencies.g, frequencies.q: Continued updating. Not yet
8240 * formats.c: Bug fix.
8242 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
8244 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
8245 * descript.g: Comment fixes.
8246 * descript.q: Comment fixes. Moved some declarations into var.h.
8247 Made dsc_info a static table. Updated FIXMEs.
8248 (internal_cmd_descriptives) Beautified.
8250 * frequencies.q: Started updating into working order.
8251 * frequencies.g: New file analogous to descript.g.
8252 * var.h: Comment fixes. Added structures for FREQUENCIES.
8254 * som.c: Removed vestiges of crushing and partial table support.
8256 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
8258 * Many more changes to som.c especially, but these will not be
8259 documented as I have resolved to remove them. This patchlevel is
8260 being released solely so that I can fall back to it if I decide
8261 that removing the changes is not a good idea.
8263 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
8265 * som.c: (global var som) New member `cum_y'.
8266 (build_target) Properly handles titles for partial tables.
8267 (dump_partial_beg, dump_partial_mid, dump_partial_end)
8268 Merged into single new function dump_partial(). Fixed problem
8269 with titles on partial tables.
8270 (dump_table) Calls dump_partial() for all parts of partial tables.
8271 (dump_page) Criteria for drawing title changed.
8273 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
8275 * command.c: (cmd_table) Added LIST, WEIGHT.
8277 * command.c: (cmd_remark) No longer frees `s' since it's not
8278 dynamically allocated.
8280 * data-out.c: (convert_f) Now correctly handles the case where
8281 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
8283 (som_destroy_all_tables) Removed argument. All callers changed.
8284 (som_vline, som_hline) Argument validity checking corrected.
8285 (som_set_value) Implemented half-heartedly.
8286 (replicate_table) Copies tables piece-by-piece when using Checker.
8288 * som.h: New line style SLIN_1THIN, currently equivalent to
8289 SLIN_0. New enum set SOM_SUB_*.
8290 (struct som_submission_form) Removed `seq_no'. Added `type'.
8292 * list.q: Newly working file; uses partial tables.
8294 * som.c: (som_reduce_table) Renamed som_set_table_height().
8295 (som_crush) Removed argument `group'.
8296 (global var som) Removed `nt', `seq_no'. Added `type'.
8297 (som_submit_table) Arguments changed.
8298 (output_table) Removed partial table code.
8299 (build_target) New arg; partial table support added. All callers
8301 (dump_plain_table) Removed partial table code.
8302 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
8303 (dump_table) Supports partial tables.
8304 (dump_page) New argument to allow not drawing top and/or bottom
8305 headers. All callers changed. Supports partial tables.
8307 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
8309 * data-out.c: Changed `#include <approx.h>' to `#include
8311 (convert_F) Comment fix. Now won't print `-.000', etc.
8313 * descript.q: Now Z-scores work, although there appears to
8314 be a bug (which might actually be in data-out.c:convert_F()).
8315 (descriptives_trns_proc, descriptives_trns_free) New functions.
8316 (run_z_pass) Implemented.
8318 * var.h: Comment fixes.
8319 (dsc_z_score, descriptives_trns) New structs.
8320 (descriptives_trns) Added to any_trns as `dsc'.
8322 * error.c, error.h: New error class, IS (Installation Script
8323 error), used in those instances where the error is in the
8324 installation, but there is a script file or installation file that
8325 can be usefully referred to.
8327 * output.c: Change many IE classes to IS classes.
8329 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
8330 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
8331 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
8332 include the corresponding header?
8334 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
8335 Don't bail out if termcap can't be read.
8337 * som.c: (som_destroy_table) Removed.
8338 (som_reduce_table, som_destroy_all_tables) New functions.
8339 (som_crush) New function, not implemented.
8341 * som.h: New table option STAB_CRUSH. Comment fix. New struct
8342 som_submission_form. Function prototypes revised.
8344 Outputting huge tables (1000s of rows) a few rows at a time
8345 is supported, though untested. May even break everything.
8346 Actually, the code doesn't even compile right now.
8347 * som.c: (struct som) New fields htv, nt, seq_no.
8348 (som_submit_table) Multiple arguments changed to a single
8349 pointer to struct submission_form. Only increments subtable_num
8350 if seq_no is zero. Only destroys table if it's not going to
8352 (replicate_table) New function.
8353 (output_table) Comment fix.
8354 (examine_table) Changed inline code to code calling
8355 replicate_table(). Calculates htv. Supports partial tables.
8356 (draw_title) Removed comment.
8357 (build_target) Only allows for title on first part of partial
8359 (dump_plain_table) Only resets table chunk number on first part
8360 of partial tables; FIXME: doesn't work quite right. Supports
8362 (dump_page) Titles only on first part of partial tables.
8364 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
8366 * Thanks to an unreliable IDE hard drive, I have spent the last
8367 day reconstructing my Debian GNU/Linux installation and redoing
8368 the previous day's changes--somehow I managed to save every file
8369 except for output.c and output.h. So the following changes could
8370 really be considered independent of the output.c, output.h changes
8373 * output.h, output.c: Moved the outp_configure_vec global var,
8374 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
8375 outp_configure_vec is now static.
8377 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
8379 * The entire philosophy behind configuration of the output drivers
8380 changed. Now there is a termcap-type configuration where drivers
8381 to be read are determined beforehand, rather than parsing the
8382 entire output init file and storing it in memory & deciding what
8383 to actually use later. Faster & more memory-efficient at the same
8386 * output.c: Comment fix. Removed outp_init_drivers global var.
8387 Removed all references to synonyms. New structure outp_defn. New
8388 global vars outp_macros, outp_configure_vec.
8389 (search_name, delete_name, add_name, check_configure_vec,
8390 expand_name, find_defn_value) New static functions.
8391 (outp_configure_clear, outp_configure_add, outp_configure_macro,
8392 outp_read_devices) New extern functions.
8393 (outp_init) Much functionality moved into outp_read_devices.
8394 (outp_read_devices) Format of output init file changed; name of
8395 file is `devices' rather than `output' to avoid Makefile
8397 (outp_clear) Renamed outp_done.
8398 (outp_list_classes) Bug fix, cleaned up.
8399 (outp_list_drivers) Not implemented anymore.
8400 (outp_configure_driver) Now a static function; simplified; now
8401 interpolates macros; supports new structure.
8402 (outp_enable_driver, match_synonym) Removed; all references
8404 (find_driver) First argument removed.
8406 * output.h: Global var outp_init_drivers removed; new structure
8407 outp_names; new enum set OUTP_S_*; new global var
8408 outp_configure_vec; function prototypes for output.c exports
8411 * main.c: (main) Calls outp_read_devices() after parsing the
8414 * cmdline.c: (parse_command_line) New option -v --verbose;
8415 --version changed to -V. --device option changed syntax to just
8416 take a single device name. Accepts key=value declaration of
8417 output init file macros. Syntax message updated.
8419 * filename.c: (expand_line) New function.
8420 (interp_environ_vars) Renamed interp_vars; no longer uses
8422 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
8423 overridden by real environment vars.
8424 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
8425 * filename.h: interp_environ_vars() renamed interp_vars().
8427 * error.c, error.h: Added extern variable `verbosity', message
8430 * error.c: (vmsg) Support message class MM.
8431 (verbose_msg) New function.
8433 * descript.q: (generate_z_varname) Bug fix in generation of
8435 (dump_z_table) Bug fix in column headers.
8437 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
8438 page from 29 to 15. Don't set a default for ops[OPS_INIT,
8439 OPS_DONE]. Writes the uninit string when the driver is closed.
8440 (ascii_open_page) Write the init string before the first page.
8441 (output_shorts) Form of main loop changed from `while' to `for'.
8442 Bug fix with overstrikes: the character is printed *after* the
8443 backspace. Eliminated a lot of `& 0xff' modifiers.
8444 (advance_to_left_margin) New function.
8445 (return_carriage, output_lines) Handle left margin.
8447 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
8449 * ascii.c: New option `carriage-return-style'.
8451 * ascii.c: (count_fancy_chars) New function.
8452 (delineate, text_metrics) Use new function; bug fixes regarding
8454 (text_draw) Bug fix with rich text.
8455 (output_string, output_shorts) Reordered.
8456 (output_shorts) Now handles boxchars and some overstrike font
8458 (output_char, return_carriage) New functions.
8459 (output_lines) Now handles overstriking and font changes properly;
8460 some code moved to output_shorts.
8462 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
8465 * ascii.c: New member `debug' in ascii_driver_ext.
8466 (ascii_init_driver, delineate) Uses new member.
8468 Now you can set a vertical height on writing text.
8469 * ascii.c: (delineate) Keeps track of vertical position.
8470 (text_draw) No longer considers fully justified text an internal
8473 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
8475 Tables' titles are drawn; they can have variable height.
8476 * som.c: `som' struct has new member, title_height.
8477 (draw_title) New argument. Moved within file. All caller
8479 (build_target) New argument, amount of space needed for first row.
8480 Calculates height of title, takes that into account. All callers
8482 (dump_plain_table, dump_columnated_table) Took calculation of y1,
8484 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
8486 (dump_columnated_table) Organized for readability.
8487 (dump_page) Makes use of som.title_height.
8489 * som.c: Many comment bug fixes.
8491 * descript.q: (try_name, generate_z_name) Bug fix regarding
8492 generation of Z-score variable names.
8493 * var.h: Removed num from descriptives_proc; all referents removed.
8495 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
8497 * ascii.c: (ascii_line_horz, ascii_line_vert,
8498 ascii_line_intersection) Added debugging code.
8500 Added a descriptive line above each table to describe it.
8501 * command.c: (parse_cmd) Calls som_new_series.
8503 * som.c: New static vars table_num, subtable_num. New `som'
8505 (dump_page) New arguments.
8506 (som_submit_table) Handle new variables.
8508 * som.c, som.h: (som_submit_table) New arguments. All callers
8510 (som_new_series) New function.
8511 (build_target) Makes room for extra line.
8512 (draw_title) New function.
8513 (dump_page) Calls draw_title. Bug fix: doesn't always set
8516 Columnation of tables support.
8517 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
8519 * som.c: Deleted references to fr, lr, ri.
8520 (som_columnate) Bux fix: sets group member of table.
8521 (som_add_options) Function removed.
8522 (dump_table) Split into three functions; extensively reworked.
8524 * descript.q: (dump_z_table) Better output table formatting; added
8525 title support to correspond to som.h changes.
8526 (display) Title support.
8528 * output.h: Added OUTP_T_NONE.
8530 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
8532 * descript.q: Improved handling of Z scores; still not perfect.
8534 * output.h, ascii.c: Added hook for getting em width of current
8537 * som.c: Uses new em-width hook. Added debugging code to
8539 (som_columnate) New argument.
8540 (som_add_options) Removed.
8542 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
8544 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
8545 rules as a property of the table instead of as a property of the
8548 * ascii.c: Added `header' to table of options.
8550 * descript.q: Added even shorter statistic names; modified to work
8551 with new som interface.
8553 * misc.c (blp_getdelim): Bug fix.
8555 * version.c: includes 'conf.h'.
8557 ----------------------------------------------------------------------
8560 version-control: never
projects / pspp-builds.git / blob