1 Sun May 30 18:35:19 2004 Ben Pfaff <blp@gnu.org>
3 Fully implement arbitrary delimiters on DATA LIST, extending the
4 half implementation that was already there.
6 * data-list.c: (struct data_list_pgm) Remove `delim', add
8 (cmd_data_list) Initialize new members. Parse delimiters and
10 (cut_field) Extract fields with arbitrary delimiters. Also, fix
11 handling of leading commas.
12 (read_from_data_list_fixed) Expand tabs. Adapt to new DFM
14 (read_from_data_list_free) Adapt to new DFM interfaces.
15 (read_from_data_list_list) Ditto.
16 (repeating_data_trns_proc) Ditto.
18 * dfm.c: Split up reader and writer into separate code, because
19 they do different things. Use struct string instead of explicit
20 allocation code, for clarity.
21 (enum dfm_reader_flags) New enum.
22 (struct dfm_fhuser_ext) Removed.
23 (struct dfm_reader_ext) New.
24 (get_reader) New function, used by just about all the reader
27 (close_reader) New function.
28 (dfm_open_for_reading) Rewrite initialization of dfm_fhuser_ext.
29 (dfm_open_for_writing) Ditto.
30 (macro force_line_buffer_expansion) Removed.
32 (tabs_to_spaces) Removed.
33 (read_record) Deal with new dfm_reader_ext. Use struct string
34 functions. Don't convert tabs to spaces.
35 (dfm_eof) New function.
36 (dfm_get_record) Changed interface, rewrote.
37 (dfm_expand_tabs) New function.
38 (dfm_fwd_record) Renamed dfm_forward_record(), updated to new
39 dfm_reader_ext, rewritten.
40 (dfm_bkwd_record) Renamed dfm_reread_record(), updated to new
41 dfm_reader_ext, rewritten.
42 (dfm_set_record) Removed in favor of dfm_forward_columns().
43 (dfm_forward_columns) New function.
44 (dfm_get_cur_col) Renamed dfm_column_start, updated to new
45 dfm_reader_ext, rewritten.
46 (static var dfm_r_class) Use close_reader for the destructor.
47 (struct dfm_writer_ext) New.
48 (dfm_put_record) Updated to new dfm_writer_ext, rewritten. Uses
49 bounce buffer now instead of local allocation.
50 (close_writer) New function.
51 (static var dfm_writer_ext) Use close_writer for destructor.
52 (cmd_begin_data) Adapt to new dfm_reader_ext.
54 * file-handle.q: Add support for per-file tab width.
55 (struct private_file_handle) Add tab_width member.
56 (q2c specifications) Add tabwidth subcommand.
57 (cmd_file_handle) Put parsed tab width into private_file_handle.
58 (create_file_handle) Set default tab width.
59 (handle_get_tab_width) New function.
61 * file-type.c: (file_type_source_read) Adapt to new DFM interface.
63 * inpt-pgm.c: (reread_trns_proc) Ditto.
65 * matrix-data.c: (context) Ditto.
66 (another_token) Ditto.
70 Sun May 30 18:33:59 2004 Ben Pfaff <blp@gnu.org>
72 * casefile.c: (casefile_destroy) Fix memory leak by freeing
74 (casereader_destroy) Don't close file descriptor -1.
76 * recode.c: (cmd_recode) Fix memory leak.
78 * set.q: (q2c specifications) Fix typo in user message.
80 * str.c: (st_bare_pad_len_copy) Change memcpy to memmove to avoid
81 undefined behavior for overlapping arguments.
83 Sun May 30 18:31:48 2004 Ben Pfaff <blp@gnu.org>
85 * casefile.c: valgrind doesn't implement posix_fadvise() yet, so
86 don't call it when we're running under valgrind.
87 (call_posix_fadvise) New function.
88 (casefile_to_disk) Use call_posix_fadvise().
89 (reader_open_file) Ditto.
91 Sun May 30 18:20:12 2004 Ben Pfaff <blp@gnu.org>
93 Update our string ADTs, struct string and struct len_string. Get
94 rid of pool support, which was largely unused. Rename lots of
95 functions to have more obvious or consistent names.
97 * ascii.c: Get rid of ascii_pool. It was only used for string
99 (ascii_open_global) Don't create ascii_pool.
100 (ascii_close_driver) Don't destroy ascii_pool.
101 (ascii_postopen_driver) Don't use pool.
102 (ascii_close_driver) Destroy strings manually.
104 * str.c: (ds_create) Remove pool argument, all references updated.
106 (ds_replace) Remove pool support, make more efficient when we
107 don't need to reallocate.
108 (ds_destroy) Remove pool support.
109 (ds_rpad) New function.
110 (ds_size) Renamed ds_capacity(), all references updated.
111 (ds_value) Renamed ds_c_str(), all references updated.
112 (ds_concat) Renamed ds_puts(), all references updated.
113 (ds_concat_buffer) Renamed ds_concat(), all references updated.
114 (ds_putchar) Renamed ds_putc(), all references updated.
115 (ds_getline) Renamed ds_gets(), all references updated.
116 (ls_create) Remove pool argument, all references updated.
117 (ls_create_buffer) Ditto.
118 (ls_destroy) Removed pool support.
119 (ls_value) Renamed ls_c_str(), all references updated.
121 * str.h: (ls_length) [__GNUC__] Add inline version.
122 (ls_c_str) [__GNUC__] Add inline version.
123 (ls_end) [__GNUC__] Add inline version.
124 (struct string) Remove pool member. Rename `size' to `capacity',
125 all references updated.
127 * tab.c: (text_format) Instead of using pool argument to
128 ls_create_buffer(), call pool_register() on allocated data.
130 Mon Apr 26 22:40:07 2004 Ben Pfaff <blp@gnu.org>
132 We're abusing the current ASCII driver by telling it to allocate a
133 9999-line, 9999-character page in the tests. This causes some
134 systems to curl up and die because it allocates 20 MB of
135 contiguous RAM. This change alleviates at least part of the
136 problem. It is mostly a stop-gap until the new output system is
139 * ascii.c: (struct line) New structure.
140 (struct ascii_driver_ext) Remove `page', `page_size', `line_len',
141 `line_len_size', `n_output' members. Add `lines', `lines_cap'.
142 (ascii_preopen_driver) Initialize new members, not old ones.
143 (ascii_close_driver) Destroy new members, not old ones.
144 (ascii_open_page) Allocate new members, not old ones.
145 (expand_line) Allocate room in line.
146 (draw_line) Use new members.
147 (ascii_line_horz) Ditto.
148 (ascii_line_vert) Ditto.
149 (ascii_line_intersection) Ditto.
151 (output_lines) Ditto.
152 (ascii_close_page) Ditto.
154 Sun Apr 25 23:40:15 2004 Ben Pfaff <blp@gnu.org>
156 * matrix.c: Dead code. Removed.
158 * matrix.h: Dead code. Removed.
160 Fri Apr 16 23:59:51 2004 Ben Pfaff <blp@gnu.org>
162 Contrary to what I'd always understood, there is an efficient
163 algorithm for deletion from a hash table populated via linear
164 probing. This change implements it.
166 * hash.c: (hsh_rehash) Probe in increasing order.
168 (locate_matching_entry) Ditto.
169 (hsh_delete) Use Knuth's Algorithm 6.4R for deletion.
171 Tue Apr 13 19:24:15 2004 Ben Pfaff <blp@gnu.org>
173 * moments.c (calc_moments): Adjust calculation of kurtosis to
174 avoid subtracting huge numbers from huge numbers, on Michael
177 Sun Apr 11 14:22:12 2004 Ben Pfaff <blp@gnu.org>
179 Rework moments routines for improved numerical stability based on
180 Michael Kiefte's advice. Any bugs or remaining numerical problems
181 are still mine though.
183 There is now a struct moments1 for use with one-pass moments. It
184 uses a provisional means algorithm as an attempt to improve
185 accuracy of higher moments. The older struct moments now only
186 handles two-pass moments.
188 * aggregate.c: Use moments1 instead moments.
190 * descript.c: Revert previous change, which is no longer needed
191 due to the moments revision.
193 * moments.c: (calc_moments) New function for calculating variance,
195 (moments_pass_one) Only accumulate weights bigger than zero.
196 (moments_calculate) Allow calculating the mean on pass one, others
197 require pass two. Implement in terms of calc_moments().
198 (struct moments1) New structure.
199 (init_moments1) New function.
200 (moments1_clear) Ditto.
201 (moments1_create) Ditto.
202 (moments1_add) Ditto.
203 (moments1_calculate) Ditto.
204 (moments1_destroy) Ditto.
205 (cmd_debug_moments) Deal with `struct moments' or `struct
206 moments1' as requested by user.
208 Sun Apr 11 14:21:55 2004 Ben Pfaff <blp@gnu.org>
210 * Makefile.am (pspp_SOURCES): Remove debug.c.
212 * debug.c: Removed. It was empty anyway.
214 Fri Apr 9 20:04:49 2004 Ben Pfaff <blp@gnu.org>
216 * descript.c (calc_descriptives): Fix assert failure when only
217 MOMENT_MEAN is needed.
219 2004-04-09 Michael Kiefte <mkiefte@dal.ca>
223 fixed problem with parsing in match_statistic() causing
224 "DESCRIPTIVE STAT=MEAN." to barf.
226 "MEAN" is now default if "SORT" given without specification.
228 Fixed infinite loop with "DESCRIPT GIBBERISH=ALL." Parsing is
229 generally less forgiving of syntax errors: better to have it do
230 nothing and type it in again then to not know what it actually did
233 z-score transformation now checks score for user-missing values
234 and checks std_dev for SYSMIS.
236 2004-04-06 Michael Kiefte <mkiefte@dal.ca>
238 * aggregate.c, crosstabs.q, descript.c, dictionary.c, frequencies.q, levene.c, t-test.q, var.h:
239 Changed dict_get_case_weight() to accept an additional int * flag
240 to complain about system-missing, user-missing, zero, or negative
241 weights and updated existing functions to pass int * to
242 dict_get_case_weight().
244 2004-04-05 jmd <jmd@gnu.org>
246 * main.c: Fixed configuration problems with gsl
248 * t-test.q: Fixed some problems encountered when compiling under Cygwin
250 2004-04-03 blp <blp@gnu.org>
252 * lexer.c, ChangeLog:
253 Fix infinite loop on comment at end of file, add test.
255 2004-04-03 jmd <jmd@gnu.org>
257 * settings.h, var.h, ChangeLog, Makefile.am, cmdline.c, command.c, command.h, error.h, filename.c, frequencies.q, lexer.h, main.c, q2c.c, set.q:
258 Fixed the calculation of percentiles and added --syntax and --algorithm options
260 Sat Apr 3 11:43:37 2004 Ben Pfaff <blp@gnu.org>
262 * lexer.c: (lex_skip_comment) Handle end-of-file correctly (I
265 Sat Apr 3 15:00:18 WST 2004 John Darrington <john@darrington.wattle.id.au>
267 * frequencies.q: Fixed the calculation of percentiles
269 * Makefile.am: Added the --ansi flag and dealt with the
270 consequences. Added some entries to PSPP_sources so that
271 make distcheck would pass
273 * cmdline.c: Added the --syntax and --algorithm options
275 * q2c.c: Added an implicit /ALGORITHM subcommand to everything.
277 Fri Apr 2 11:25:22 WAST 2004 John Darrington <john@darrington.wattle.id.au>
279 * t-test.q, levene.c, levene.h Converted t-test (incl levene) to
280 use the new multipass_split_... mechanism.
282 Wed Mar 31 22:36:22 2004 Ben Pfaff <blp@gnu.org>
284 * frequencies.q: (calc_stats) Use moments data structure and
285 calc_seskew(), calc_sekurt() functions.
287 * set.q main.c settings.h Added support for --syntax and --algorithm
290 Tue Mar 30 22:04:19 2004 Ben Pfaff <blp@gnu.org>
292 * vfm.c: Had to get last call to multipass_split_output() inside
293 open_active_file()/close_active_file() pairing, so introduce new
295 (internal_procedure) Move procedure() code here, except for calls
296 to open_active_file() and close_active_file().
297 (procedure) Wrap open_active_file() and close_active_file() around
298 internal_procedure().
299 (multipass_procedure_with_splits) Wrap open_active_file() and
300 close_active_file() around internal_procedure().
302 Tue Mar 30 22:01:57 2004 Ben Pfaff <blp@gnu.org>
304 * descript.c: (cmd_descriptives) Free `vars' to avoid memory leak.
306 Mon Mar 29 16:26:40 2004 Ben Pfaff <blp@gnu.org>
308 * debug.c: Removed. Moved cmd_debug_evaluate() into expr-evl.c.
310 * expr-evl.c: (cmd_debug_evaluate) Moved here from debug.c.
312 Mon Mar 29 16:03:08 2004 Ben Pfaff <blp@gnu.org>
314 * algorithm.c: By default turn off some of the more expensive
316 (expensive_assert) New macro which expands to assert if
317 EXTRA_CHECKS is defined, to nothing otherwise.
318 (unique) Use expensive_assert().
319 (binary_search) Ditto.
325 * command.c: (conflicting_3char_prefixes) Words that are the same
326 don't cause conflicts when they are abbreviated to the first three
329 * expr-evl.c: (CONCAT_func) Fix memory leak by incrementing struct
330 nonterm_node's n earlier.
331 (generic_str_func) Ditto.
333 Mon Mar 29 15:32:17 2004 Ben Pfaff <blp@gnu.org>
335 Add support for multipass procedures. Rewrite DESCRIPTIVES to
336 test multipass support, take advantage of new moments
337 calculation, and to not be such crappy code. Get rid of q2c
338 processing for DESCRIPTIVES.
340 * vfm.c: (struct multipass_split_aux_data) New structure.
341 (multipass_procedure_with_splits) New function.
342 (multipass_split_callback) New function.
343 (multipass_split_output) New function.
344 * descript.q: Removed.
346 * descript.c: New file.
348 * var.h: Removed descriptives enums.
349 (struct descriptives_proc) Removed.
350 (struct variable) Removed p.dsc.
352 * Makefile.am: (q_sources_c) Remove descript.c.
353 (q_sources_q) Removed descript.q.
355 Mon Mar 29 15:31:55 2004 Ben Pfaff <blp@gnu.org>
357 New manager for keeping track of used workspace.
359 * workspace.c: New file.
361 * workspace.h: New file.
363 * Makefile.am: (pspp_SOURCES) Add workspace.c, workspace.h.
365 * sort.c: (do_internal_sort) Use workspace_malloc().
366 (destroy_internal_sort) Use workspace_free().
368 Mon Mar 29 15:31:08 2004 Ben Pfaff <blp@gnu.org>
370 New `struct casefile' for managing sets of cases.
372 * casefile.c: New file.
374 * casefile.h: New file.
376 * command.def: Add DEBUG CASEFILE command.
378 * Makefile.am: (pspp_SOURCES) Add casefile.c, casefile.h.
380 * sort.c: (sort_cases) Move logic for sending storage file to disk
381 into do_external_sort().
382 (struct internal_sort) Use an array of ccase pointers instead of a
384 (do_internal_sort) Rewrite to handle casefiles.
385 (compare_case_list) Removed.
386 (compare_cases) New function.
387 (compare_case_dblptrs) New function.
388 (read_internal_sort_output) Deal with new struct internal_sort.
390 * vfm.c: (static var workspace_overflow) Removed.
391 (struct storage_stream_info) Removed all the members. Added
392 struct casefile * member.
393 (storage_sink_open) Use casefile.
394 (open_storage_file) Removed.
395 (write_storage_file) Removed.
396 (storage_to_disk) Removed.
397 (destroy_storage_stream_info) Use casefile.
398 (storage_sink_write) Use casefile.
399 (storage_sink_make_source) Use casefile.
400 (storage_source_count) Use casefile.
401 (storage_source_read) Use casefile.
402 (storage_source_on_disk) Removed.
403 (storage_source_get_cases) Removed.
404 (storage_source_set_cases) Removed.
405 (storage_source_get_casefile) New function.
407 Mon Mar 29 15:30:09 2004 Ben Pfaff <blp@gnu.org>
409 New `struct moments' for calculating moments.
415 * moments.c: New file.
417 * moments.h: New file.
419 * command.def: Add DEBUG MOMENTS command.
421 * Makefile.am: (pspp_SOURCES) Add moments.c, moments.h. Remove
424 * aggregate.c: Modify AGGREGATE to use the new moments
425 calculation, even if not in such a great way.
426 (struct agr_var) Add `moments' member.
427 (parse_aggregate_functions) Set `moments' member to null.
428 (agr_destroy) Destroy `moments' member.
429 (accumulate_aggregate_info) Use `moments' for standard deviation.
430 (dump_aggregate_info) Ditto.
431 (initialize_aggregate_info) Create or clear `moments'.
433 * misc.h: Add pow2(), pow3(), pow4() functions in place of sqr(),
434 cube(), pow4() that were in stats.h. All references updated.
436 * crosstabs.q: stats.h had chi-square significance functions. Use
438 (display_chisq) Use gsl_cdf_chisq_Q() instead of chisq_sig().
440 * expr-evl.c: (expr_evaluate) Use moments_of_values() for
441 OP_CFVAR, OP_MEAN, OP_SD, OP_VARIANCE.
443 Fri Mar 26 14:21:23 2004 Ben Pfaff <blp@gnu.org>
445 * dictionary.c: (dict_compact_values) Compacted values need to
448 Fri Mar 26 00:54:57 2004 Ben Pfaff <blp@gnu.org>
450 * var-labs.c: (cmd_variable_labels) For compatibility, don't allow
451 `/' at start. Check return value of parse_variables() for error
454 Fri Mar 26 00:19:27 2004 Ben Pfaff <blp@gnu.org>
456 Revamp expressions: make the code a little nicer, and fix bugs
459 * expr-evl.c: (expr_evaluate) Make expression argument const.
460 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
461 OP_POW is missing for arg 2 <= 0. OP_LOG is natural log, not
462 base-10 log. Fix OP_ANY, OP_ANY_STRING, OP_RANGE, OP_RANGE_STRING
463 off-by-ones. Add OP_MAX_STRING, OP_MIN_STRING. Fix OP_TIME_HMS,
464 OP_DATE_WKYR boundary conditions. Add OP_CTIME_DAYS,
465 OP_CTIME_HOURS, OP_CTIME_MINUTES, OP_CTIME_DAYS, OP_CTIME_SECONDS.
466 Support OP_INDEX_2, OP_INDEX_3, OP_RINDEX_2, OP_RINDEX_3 instead
467 of OP_INDEX, OP_INDEX_OPT, OP_RINDEX, OP_RINDEX_OPT. Merge
468 OP_LPAD_OPT into OP_LPAD, OP_RPAD_OPT into OP_RPAD, OP_LTRIM_OPT
469 into OP_LTRIM, OP_RTRIM_OPT into OP_RTRIM, OP_NUMBER_OPT into
470 OP_NUMBER. Fix OP_RTRIM fragility. Support OP_SUBSTR_2,
471 OP_SUBSTR_3 instead of OP_SUBSTR, OP_SUBSTR_OPT. Remove OP_INV.
472 Simplify OP_SYSMIS. Remove OP_STR_MIS.
474 * expr-opt.c: (optimize_expression) Rewrite.
486 (eq_num_con) New function.
487 (optimize_tree) New function.
489 (macro frnc) Removed.
490 (str_search) Add const to string params.
492 (evaluate_tree_no_missing) Renamed from evaluate_tree. Add num[],
493 str[], str_len[] locals to substitute for most of removed macros.
494 Support OP_ADD, OP_SUB, OP_MUL, OP_DIV instead of OP_PLUS, OP_MUL.
495 Removed support for missing values because we're never called with
496 missing values. Use set_number() or set_number_errno() instead of
497 rnc or frnc. Removed any stuff that caused trouble in testing.
498 We can re-add it later if it really slows anything. Fix some
500 (evaluate_tree_with_missing) Not yet supported. To be added later
502 (repl_num_con) Removed.
503 (collapse_node) New function.
504 (force_repl_num_con) Removed.
505 (set_number) New function.
506 (set_number_errno) New function.
507 (repl_str_con) Removed.
508 (set_string) New function.
509 (yrmoda) Tighten boundary conditions. Adopt 2030 cut-off for
511 (dump_node) No special case for OP_AND, OP_OR.
513 * expr-prs.c: (expr_prs) Honor EXPR_NO_OPTIMIZE bit. Rewrite.
514 (expr_get_type) New function.
515 (type_check) Rewrite.
516 (type_coercion) New function.
517 (struct operator) New structure.
518 (match_operator New function.
519 (parse_binary_operators) New function.
520 (parse_inverting_unary_operator) New function.
521 (parse_or) Rewritten.
522 (parse_and) Rewritten.
523 (parse_not) Rewritten.
524 (parse_rel) Rewritten.
525 (parse_add) Rewritten.
526 (parse_mul) Rewritten.
527 (parse_neg) Rewritten.
528 (parse_exp) Rewritten.
529 (parse_sysvar) Add $TRUE, $FALSE system variables.
530 Get $LENGTH, $WIDTH from get_viewlength(), get_viewwidth().
531 (parse_primary) Use allocate_var_node(), allocate_num_con(),
533 (struct function) Remove desc, change `func' prototype.
534 (unary_func) Remove special cases.
535 (MISSING_func) Reduce to unary_func() that just returns a boolean.
536 (SYSMIS_func) Handle SYSMIS((x)) like SYSMIS(x).
537 (VALUE_func) Use allocate_var_node().
538 (nary_num_func) Allow MIN and MAX for strings.
539 Use allocate_var_node(). Properly clean up.
541 (generic_str_func) Use local table instead of removed `desc'
542 member. Mostly rewrite.
543 (get_num_args) Revise error message.
544 (parse_function) Return EXPR_ERROR, not 0 on error.
546 (macro varies) Removed.
547 (ops[]) Use expr.def.
548 (free_node) Do nothing if node is null.
549 (allocate_num_con) New function.
550 (allocate_str_con) New function.
551 (allocate_var_node) New function.
552 (allocate_binary_nonterminal) New function.
553 (append_nonterminal_arg) Removed.
554 (static var func_tab[]) Revised.
555 (expr_debug_print_postfix) Make parameter const.
556 Use printf() instead of debug_printf().
558 * expr.def: New file.
560 * expr.h: Change PXP_* to EXPR_*, all references updated. Also
561 use named enum instead of unnamed, all references updated. Add
562 EXPR_ANY, EXPR_NO_OPTIMIZE.
564 * exprP.h: Remove EX_*. Add DEFINE_OPERATOR. Use expr.def
565 instead of defining OP_* directly.
566 (macro IS_TERMINAL) New macro.
567 (macro IS_NONTERMINAL) New macro.
568 (enum OP_NO_FLAGS) New.
570 Fri Mar 26 00:18:01 2004 Ben Pfaff <blp@gnu.org>
572 * error.c: (err_assert_fail) msg variable needs to be non-const.
574 Fri Mar 26 00:17:24 2004 Ben Pfaff <blp@gnu.org>
576 * debug.c: (cmd_debug_evaluate) Rewrite.
578 Fri Mar 26 00:15:13 2004 Ben Pfaff <blp@gnu.org>
580 Fix some CROSSTABS bit rot stupidity.
582 * crosstabs.q: Reorder the CELLS subcommands for compatibility.
583 (internal_cmd_crosstabs) Initializes cells[] correctly.
584 (float_M_suffix) Rename format_cell_entry(), change prototype,
586 (display_crosstabulation) Fix cell formatting.
588 Fri Mar 26 00:14:09 2004 Ben Pfaff <blp@gnu.org>
590 Make lex_rest_of_line(), lex_entire_end() not discard lines. Have
591 to call lex_discard_line() to do that.
593 * command.c: (run_command) Call lex_discard_line() after
596 * lexer.c: (lex_entire_end) Change behavior.
597 (lex_rest_of_line) Change behavior. Return const char *.
598 (lex_discard_line) Don't clear getl_buf, don't emit message.
600 * main.c: (handle_error) Emit message here.
602 * repeat.c: (internal_cmd_do_repeat) Use lex_discard_line()
603 instead of lex_entire_line().
605 * str.c: (mm_find_reverse) Make length params size_t. Rewrite.
607 * title.c: (get_title) Call lex_discard_line() after
609 (cmd_file_label) Ditto.
610 (cmd_document) Deal with const char * return value.
612 Fri Mar 26 00:10:16 2004 Ben Pfaff <blp@gnu.org>
614 Removed REMARK command.
616 * command.c: (extract_prefix) Removed.
617 (output_line) Removed.
618 (cmd_remark) Removed.
620 * command.def: Remove REMARK.
622 Fri Mar 26 00:08:38 2004 Ben Pfaff <blp@gnu.org>
624 Added abort() after lots of assert(0) invocations to avoid some
625 compiler warnings. We really need a NOT_REACHED macro.
627 Tue Mar 23 08:00:42 WAST 2004 John Darrington <john@darrington.wattle.id.au>
629 * sort.c: Added missing call to temp_file_close. Changed error
630 messages to warnings.
632 * set.q: Improved setting of set_view{length,width} to be more tolerant
635 Sun Mar 21 10:11:14 WST 2004 John Darrington <john@darrington.wattle.id.au>
637 * val-labs.c: Fixed a bug where PSPP would crash, if VALUE LABELS was
638 used with incorrect syntax.
640 * error.c, error.h et al: Overridden definition of assert for a
643 * test-q.c: Fixed a buglet where it would crash if no /VARIABLES
644 subcommand was given when it ought to have been.
646 Sat Mar 20 22:19:08 2004 Ben Pfaff <blp@gnu.org>
648 * tab.c: (tab_vline) Fix assertions to respect row_ofs and
652 (tab_joint_text) Ditto.
654 Sat Mar 20 17:57:23 2004 Ben Pfaff <blp@gnu.org>
656 * levene.c: Add #include.
658 * set.q: (set_viewport) Add `int' argument to make its prototype
659 correct for signal().
661 Sat Mar 20 15:35:17 2004 Ben Pfaff <blp@gnu.org>
663 * expr-evl.c: (expr_evaluate) Assert that `c' is nonzero before
666 Sat Mar 20 15:18:16 2004 Ben Pfaff <blp@gnu.org>
668 Changed DFM from open-at-first-access to explicit-open. Before,
669 calling dfm_get_record() or dfm_put_record() would automatically
670 open the file. Now, you have to call dfm_open_for_reading() or
671 dfm_open_for_writing() explicitly. This makes it possible to
672 check permissions, file existence, etc. earlier.
674 Also made struct file_handle more opaque, and clean up in general.
676 * data-list.c: (cmd_data_list) Open handle for reading.
678 * dfm.c: (struct dfm_fhuser_ext) Add `where', `saw_begin_data'
680 (open_file_r) Renamed dfm_open_for_reading(), rewrote.
681 (open_file_w) Renamed dfm_open_for_writing(), rewrote.
682 (open_inline_file) Removed.
683 (read_record) For inline_file, if we haven't seen BEGIN DATA, read
684 it. Deal with line_number in extension record instead of file
686 (dfm_get_record) Rewrote.
687 (dfm_put_record) Rewrote.
688 (dfm_push) Assert file is open and one of ours. Deal with
689 line_number in extension record instead of file handle.
690 (dfm_pop) Assert file is open and one of ours. Deal with
691 line_number in extension record instead of file handle.
692 (cmd_begin_data) Use dfm_open_for_reading(). Mark that we saw
695 * file-handle.h: (enum constants RH_RF_*) Removed.
696 (enum constants FH_MD_*) Removed.
697 (struct file_handle) Removed `name', `norm_fn', `fn', `where',
698 `recform', `lrecl', `mode' members. Public references to
699 `recform' changed to use handle_get_mode(), references to `lrecl'
700 changed to use handle_get_record_width(). Added `private' member.
701 (enum file_handle_mode) New.
703 * file-handle.q: (struct private_file_handle) New structure.
704 (struct file_handle_list) New structure.
705 (static var files) New.
706 (static var file_handles) Removed.
707 (init_file_handle) Removed.
708 (create_file_handle) Removed.
709 (get_handle_with_name) New function.
710 (get_handle_for_filename) New function.
711 (cmd_file_handle) Rewritten.
712 (hash_file_handle) Removed.
713 (cmp_file_handle) Removed.
714 (fh_init_files) Rewritten.
715 (fh_parse_file_handle) Rewritten. Allows identifiers as
717 (fh_get_handle_by_name) Renamed handle_get_name(), all references
719 (fh_get_handle_by_filename) Renamed handle_get_filename(), all
720 references updated. Rewritten.
721 (fh_record_width) Renamed handle_get_record_width(), all
722 references updated. Rewritten.
723 (handle_get_mode) New function.
725 * file-type.c: (cmd_file_type) Open handle for reading.
727 * filename.c: [unix] (struct file_identity) New structure.
728 [unix] (fn_get_identity) New function.
729 [unix] (fn_free_identity) New function.
730 [unix] (fn_compare_file_identities) New function.
731 [!unix] (struct file_identity) New structure.
732 [!unix] (fn_get_identity) New function.
733 [!unix] (fn_free_identity) New function.
734 [!unix] (fn_compare_file_identities) New function.
736 * lexer.c: (static var put) Renamed put_token, all references
738 (static var put_tokstr) New.
739 (static var put_tokval) New.
740 (lex_init) Initialize put_tokstr().
741 (restore_token) New function.
742 (save_token) New function.
743 (lex_get) Use restore_token().
744 (lex_put_back) Use save_token().
745 (lex_put_back_id) New function.
746 (lex_put_forward) Removed.
747 (lex_preprocess_line) Set put_token instead of using
749 (lex_negative_to_dash) Use save_token(), set put_token directly.
750 (dump_token) Use stderr instead of stdout.
752 * main.c: (main) Remove call to cmd_init().
754 * matrix-data.c: (cmd_matrix_data) Open file for reading.
756 * pfm-read.c: Use handle_get_filename() instead of trying to use
757 h->fn directly, all over.
759 * pfm-write.c: Ditto.
761 * print.c: (internal_cmd_print) Open handle for writing.
762 (dump_table) Use handle_get_filename().
763 (print_trns_proc) Use handle_get_mode().
764 (cmd_print_space) Use fh_parse_file_handle().
765 Open handle for writing.
766 [0] (debug_print) Removed.
768 * sfm-read.c: Use handle_get_filename() instead of trying to use
769 h->fn directly, all over.
771 * sfm-write.c: Ditto.
773 Sat Mar 20 14:35:48 2004 Ben Pfaff <blp@gnu.org>
777 * autorecode.c: (arc_free) Free arc->src_values.
779 * error.c: (msg) Free buf.
781 * val-labs.c: (do_value_labels) Always free vars.
783 * vfm.c: (close_active_file) If sink has no make_source then call
784 its destroy function.
786 Sat Mar 20 14:00:24 2004 Ben Pfaff <blp@gnu.org>
788 Fixed cmd_parse() so that it always skips past a full command
789 name. A few special commands for which this would be bad get
790 special treatment. This lets us drop code for skipping past the
791 end of a command name in most cmd_*() functions. It's not worth
792 listing all the commands affected.
794 * command.c: (struct command) Remove `cmd' member, replace by
795 `name' member, all references updated. Remove `word', `next',
796 `skip_entire_name' members.
797 (macro DEFCMD) Deal with revised `struct command'.
798 (macro UNIMPL) Ditto.
799 (macro SPCCMD) New macro for commands whose last word shouldn't be
801 (static array cmd_table[]) Make const, rename `commands', remove
803 (macro COMMAND_CNT) New macro.
804 (split_words) Removed.
806 (FILE_TYPE_okay) Make parameter const.
807 (cmd_parse) Improve error messages.
808 (match_strings) New function.
809 (next_word) New function.
810 (enum command_match) New enum.
811 (conflicting_3char_prefixes) New function.
812 (conflicting_3char_prefix_command) New function.
813 (cmd_match_words) New function.
814 (count_matching_commands) New function.
815 (get_command_name) New function.
816 (free_words) New function.
817 (unknown_command_error) New function.
818 (figure_out_command) Renamed parse_command_name(), rewritten.
820 * command.def: Removed @ command. Marked BEGIN DATA, DOCUMENT,
821 FILE LABEL, REMARK, SUBTITLE, TITLE as special. Renamed EVALUATE
822 to DEBUG EVALUATE. Added N alias for N OF CASES, SORT alias for
825 * command.h: (macro SPCCMD) New.
827 * include.c: (cmd_include_at) Removed.
828 (cmd_include) Allow identifier to be used as filename.
830 * inpt-pgm.c: (cmd_reread) Use fh_parse_file_handle().
832 * t-test.q: (cmd_t_test) Command name is now parsed for us.
835 Sat Mar 20 13:56:00 2004 Ben Pfaff <blp@gnu.org>
837 Start work on better test framework.
839 * Makefile.am: (pspp_sources) Add debug.c.
843 * compute.c: (cmd_evaluate) Moved to debug.c, renamed
844 cmd_debug_evaluate().
846 * expr-prs.c: (expr_parse) Remove PXP_DUMP support.
848 * expr.h: (enum constant PXP_DUMP) Removed.
850 Sat Mar 20 00:05:42 WST 2004 John Darrington <john@darrington.wattle.id.au>
852 * set.q: Implemented the SHOW command, and synced it to the existing
855 Added a handler for SIGWINCH so that viewlength and viewwidth follow
856 changes as the window size is changed.
858 Added fallback to set viewlength and viewwidth from LINES and COLUMS
859 environment variables if other methods are not available.
861 glob.c: Removed a lot of global variables from glob.c and encapsulated
864 random.c: Tidied up the way the random seed is set.
866 str.c: Added a ds_vprintf function.
868 error.c: Extended dump_message so that messages are always broken at
871 Thu Mar 18 11:07:14 2004 Ben Pfaff <blp@gnu.org>
873 * pfm-write.c: (bufwrite) Write out the correct element for string
874 variables. From Andreas Streichardt <streichardt@globalpark.de>.
876 Mon Mar 15 20:48:03 2004 Ben Pfaff <blp@gnu.org>
878 Get rid of static and global (!) vars in matrix-data.c.
880 * matrix-data.c: (static var nr_data) Removed.
881 (static var nr_factor_values) Removed.
882 (static var max_cell_index) Removed.
883 (static var split_values) Removed.
884 (struct nr_aux_data) New structure.
885 (read_matrices_without_rowtype) Use a local struct nr_aux_data in
886 place of static vars, pass to create_case_source() and procedure()
888 (nr_read_data_lines) Use struct nr_aux_data * parameter instead of
889 struct matrix_data_pgm *.
890 (nr_read_splits) Ditto.
891 (nr_read_factors) Ditto.
892 (nr_output_data) Ditto.
893 (static var wr_content) Removed.
894 (global var wr_data) Removed.
895 (global var wr_current) Removed.
896 (struct wr_aux_data) New structure.
897 (read_matrices_with_rowtype) Use a local struct wr_aux_data in
898 place of static vars, pass to create_case_source() and procedure()
900 (matrix_data_read_with_rowtype) Use struct wr_aux_data * parameter
901 instead of matrix_data_pgm *.
902 (wr_read_splits) Ditto.
903 (wr_output_data) Ditto.
904 (wr_read_rowtype) Ditto.
905 (wr_read_factors) Ditto.
906 (wr_read_indeps) Ditto.
908 Mon Mar 15 20:07:29 2004 Ben Pfaff <blp@gnu.org>
910 Get rid of static vars in autorecode.c.
912 * autorecode.c: (struct autorecode_trns) Rename `arc' to `specs',
913 `n_arc' to `spec_cnt'. All references updated.
914 (static var v_src) Removed.
915 (static var v_dest) Removed.
916 (static var h_trns) Removed.
917 (static var nv_src) Removed.
918 (static var descend) Removed.
919 (static var print) Removed.
920 (enum direction) New enum.
921 (struct autorecode_pgm) New structure.
922 (cmd_autorecode) Use struct autorecode_pgm instead of static vars.
923 Move n_dest local var into struct autorecode_pgm for ease of
924 clean-up. Use arc_free().
925 (arc_free) New function.
926 (recode) Modify to take struct autorecode_pgm * parameter instead
927 of using statics. Let the caller clean up.
928 (autorecode_proc_func) Use struct autorecode_pgm * auxiliary data
929 instead of statics. Rearrange code a little.
931 Mon Mar 15 00:25:02 2004 Ben Pfaff <blp@gnu.org>
933 Get rid of static, global vars in recode.c. Remove debug code.
935 * recode.c: (static var head) Removed.
936 (global var v) Removed.
937 (global var nv) Removed.
938 (cmd_recode) New local variables head, v, nv. Initialize and free
939 v. Don't call debug_print().
940 [DEBUGGING] (dump_dest) Removed.
941 [DEBUGGING] (debug_print) Removed.
943 Mon Mar 15 00:14:49 2004 Ben Pfaff <blp@gnu.org>
945 Get rid of static vars in expr-opt.c.
947 * expr-opt.c: (static var e) Removed.
948 (static var nop) Removed.
949 (static var mop) Removed.
950 (static var ndbl) Removed.
951 (static var mdbl) Removed.
952 (static var nstr) Removed.
953 (static var mstr) Removed.
954 (static var nvars) Removed.
955 (static var mvars) Removed.
956 (struct expr_dump_state) New structure.
957 (dump_expression) Use new struct expr_dump_state instead of static
958 vars and pass to functions we call.
959 (dump_node) Use struct expr_dump_state * parameter.
961 (emit_num_con) Ditto.
962 (emit_str_con) Ditto.
965 Mon Mar 15 00:03:51 2004 Ben Pfaff <blp@gnu.org>
967 Get rid of static var in COUNT.
969 * count.c: (static var head) Move into cmd_count().
970 (cmd_count) [DEBUGGING] Don't call debug_print.
971 [DEBUGGING] (debug_print) Removed.
973 Sun Mar 14 23:56:09 2004 Ben Pfaff <blp@gnu.org>
975 Get rid of static vars in VALUE LABELS, ADD VALUE LABELS.
977 * val-labs.c: (static var v) Removed.
978 (static var nv) Removed.
979 [DEBUGGING] (debug_print) Removed.
980 (verify_val_labs) Add struct variable **, int parameters.
981 (get_label) Ditto. Improve error messages, streamline.
982 (erase_labels) New function for erasing value labels, taking over
983 part of verify_val_labs()'s function.
986 (cmd_value_labels) No need to call init() or done() anymore.
987 (cmd_add_value_labels) Ditto.
988 (do_value_labels) Add vars, var_cnt local variables. Clean up
989 after them internally. Call erase_labels() if we should. Don't
992 Sun Mar 14 23:33:53 2004 Ben Pfaff <blp@gnu.org>
994 Get rid of static vars in MATCH FILES.
996 * get.c: (static var mtf_head) Removed.
997 (static var mtf_tail) Removed.
998 (static var mtf_by) Removed.
999 (static var mtf_n_by) Removed.
1000 (static var mtf_master) Removed.
1001 (static var mtf_seq_num) Removed.
1002 (static var mtf_seq_nums) Removed.
1003 (static var mtf_sink) Removed.
1004 (static var mtf_case) Removed.
1005 (struct mtf_proc) New structure.
1006 (cmd_match_files) Use struct mtf_proc instead of static vars.
1007 (mtf_processing_finish) Ditto.
1009 (mtf_delete_file_in_place) Ditto.
1010 (mtf_read_nonactive_records) Ditto.
1011 (mtf_compare_BY_values) Ditto.
1012 (mtf_processing) Ditto.
1013 (mtf_merge_dictionary) Ditto.
1015 Sun Mar 14 22:48:12 2004 Ben Pfaff <blp@gnu.org>
1017 * command.def: Add CASESTOVARS, VARSTOCASES unimplemented commands.
1019 * dictionary.c: (dict_rename_var) Add assertion.
1020 (dict_contains_var) Check by index instead of name.
1022 Sun Mar 14 22:01:02 2004 Ben Pfaff <blp@gnu.org>
1024 Get rid of compaction_necessary, compaction_nval, compaction_case.
1025 Redo VFM interface. Replace disk_sink and memory_sink by
1026 storage_sink, disk_source and memory_source by storage_source.
1028 * vfm.h: (struct case_sink) Add `dict', `idx_to_fv', `value_cnt'
1032 (struct write_case_data) Remove `begin_func', `end_func',
1033 `func_aux' members. Add `aux', `trns_case', `sink_case',
1034 `cases_written', `cases_analyzed' members.
1035 (global var compaction_necessary) Make static.
1036 (global var compaction_nval) Removed.
1037 (global var compaction_case) Removed.
1038 (static var case_count) Removed.
1039 (struct procedure_aux_data) Removed.
1040 (struct split_aux_data) Removed.
1041 (procedure) Remove begin_func, end_func parameters. Rewrite.
1042 (static var not_canceled) Removed.
1043 (process_active_file) Removed.
1044 (process_active_file_write_case) Removed.
1045 (process_active_file_output_case) Removed.
1046 (prepare_for_writing) Moved into open_active_file().
1047 (arrange_compaction) Ditto.
1049 (open_active_file) Rewrote.
1050 (write_case) New function.
1051 [DEBUGGING] (index_to_varname) Removed.
1052 (execute_transformations) New function.
1053 (exclude_this_case) Renamed filter_case(), changed interface.
1054 (clear_case) Added struct ccase * parameter to interface.
1055 (close_active_file) Added struct write_case_data * parameter,
1057 (disk_sink_create) Removed.
1058 (disk_sink_destroy) Removed.
1059 (disk_sink_make_source) Removed.
1060 (disk_sink_write) Removed.
1061 (disk_source_count) Removed.
1062 (disk_source_destroy) Removed.
1063 (disk_source_read) Removed.
1064 (global var disk_sink_class) Removed.
1065 (global var disk_source_class) Removed.
1066 (global var memory_sink_class) Removed.
1067 (global var memory_source_class) Removed.
1068 (memory_sink_create) Removed.
1069 (memory_sink_destroy) Removed.
1070 (memory_sink_make_source) Removed.
1071 (memory_sink_write) Removed.
1072 (memory_source_count) Removed.
1073 (memory_source_destroy) Removed.
1074 (memory_source_get_cases) Removed.
1075 (memory_source_read) Removed.
1076 (memory_source_set_cases) Removed.
1077 (struct disk_stream_info) Removed.
1078 (struct memory_sink_info) Removed.
1079 (struct memory_source_info) Removed.
1080 (write_active_file_to_disk) Removed.
1081 (destroy_storage_stream_info) New function.
1082 (global var null_sink_class) New var.
1083 (global var storage_sink_class) New var.
1084 (global var storage_source_class) New var.
1085 (open_storage_file) New function.
1086 (storage_sink_destroy) New function.
1087 (storage_sink_make_source) New function.
1088 (storage_sink_open) New function.
1089 (storage_sink_write) New function.
1090 (storage_source_count) New function.
1091 (storage_source_destroy) New function.
1092 (storage_source_get_cases) New function.
1093 (storage_source_on_disk) New function.
1094 (storage_source_read) New function.
1095 (storage_source_set_cases) New function.
1096 (storage_source_to_disk) New function.
1097 (storage_to_disk) New function.
1098 (struct storage_stream_info) New structure.
1099 (write_storage_file) New function.
1100 (procedure_write_case) Removed.
1101 (create_case_source) Add `struct dictionary *' parameter, all
1103 (create_case_sink) Ditto.
1104 (free_case_sink) New function.
1105 (struct split_aux_data) New structure.
1106 (procedure_with_splits) New function implementing what procedure()
1108 (SPLIT_FILE_proc_func) Removed.
1109 (procedure_with_splits_callback) New function.
1110 (equal_splits) New function.
1112 * aggregate.c: Pass around a struct instead of using statics.
1113 (static var outfile) Remove.
1114 (enum type) Give it tag `missing_treatment'.
1115 (static var missing) Remove.
1116 (static var sort) Remove.
1117 (static var agr_first) Remove.
1118 (static var agr_next) Remove.
1119 (static var case_count) Remove.
1120 (static var prev_case) Remove.
1121 (static var buf64_1xx) Remove.
1122 (static var buf_1xx) Remove.
1123 (struct agr_proc) New structure incorporating the above.
1124 (cmd_aggregate) Use new struct. Clean up error handling using
1125 agr_destroy(). Completely rewrite actual implementation of
1127 (create_sysfile) Add struct agr_proc * parameter, modify
1129 (parse_aggregate_functions) Ditto.
1130 (free_aggregate_functions) Ditto. Rename agr_destroy().
1131 (aggregate_single_case) Add struct agr_proc * parameter, modify
1133 (accumulate_aggregate_info) Ditto.
1134 (dump_aggregate_info) Ditto.
1135 (initialize_aggregate_info) Ditto.
1136 (agr_00x_trns_proc) Removed.
1137 (agr_00x_end_func) Removed.
1138 (agr_10x_trns_proc) Removed.
1139 (agr_10x_trns_free) Removed.
1140 (agr_10x_end_func) Removed.
1141 (agr_11x_read) Removed.
1142 (agr_11x_finish) Removed.
1143 [DEBUGGING] (debug_print) Removed.
1144 (write_case_to_sfm) Add struct agr_proc * parameter, modify
1146 (agr_to_active_file) New function.
1147 (presorted_agr_to_sysfile) New function.
1148 (sort_agr_to_sysfile) New function.
1150 * autorecode.c: (cmd_autorecode) Use procedure_with_splits().
1152 * crosstabs.q: (internal_cmd_crosstabs) Ditto.
1154 * descript.q: (cmd_descriptives) Ditto.
1156 * dfm.c: (cmd_begin_data) Check for storage_source_class. Adapt
1157 to new procedure() interface.
1159 * command.c: (cmd_execute) Adapt to new procedure() interface.
1161 * dictionary.c: (dict_compact_values) Also delete scratch
1163 (dict_get_compacted_value_cnt) New function.
1164 (dict_get_compacted_idx_to_fv) New function.
1166 * flip.c: (cmd_flip) Warn about and cancel TEMPORARY.
1167 (cmd_flip) Adapt to new procedure() interface.
1168 (flip_sink_write) Use sink->idx_to_fv.
1170 * frequencies.q: (internal_cmd_frequencies) Use
1171 procedure_with_splits().
1173 * get.c: (cmd_save_internal) Adapt to new procedure() interface.
1174 (static var mtf_sink) New static var.
1175 (static var mtf_case) New static var.
1176 (cmd_match_files) Warn about and cancel TEMPORARY. Redo the way
1177 we actually implement the matching.
1178 (mtf_delete_file_in_place) Use mtf_case.
1179 (mtf_processing) Use mtf_case and mtf_sink.
1180 (cmd_export) Adapt to new procedure() interface.
1182 * levene.c: (levene) Use procedure_with_splits().
1184 * list.q: (cmd_list) Use procedure_with_splits().
1186 * matrix-data.c: (read_matrices_without_rowtype) Adapt to new
1187 procedure() interface.
1188 (read_matrices_with_rowtype) Ditto.
1190 * modify-vars.c; (cmd_modify_vars) Warn about and cancel
1191 TEMPORARY. Adapt to new procedure() interface.
1193 * rename-vars.c: Warn about and cancel TEMPORARY.
1195 * sort.c: (cmd_sort_cases) Warn about TEMPORARY.
1196 (sort_cases) Use dict_get_compacted_value_cnt() instead of
1197 compaction_nval. Adapt to new procedure() interface. Use
1198 storage_source_to_disk().
1199 (do_internal_sort) Don't try to dump the cases to memory.
1200 (compare_case_lists) Pass null idx_to_fv.
1201 (struct initial_run_state) Add `idx_to_fv' member. Remove
1203 (write_initial_runs) Don't initialize irs->case_size. Adapt to
1204 new procedure() interface. Reset irs->idx_to_fv after calling
1206 (sort_sink_write) Set irs->idx_to_fv. Use case_size from struct
1207 sort_cases_pgm. Pass irs, not struct sort_cases_pgm to
1209 (destroy_initial_run_state) Don't dereference irs after freeing
1211 (allocate_cases) Don't calculate case_size locally.
1212 (compare_record) Add idx_to_fv parameter.
1213 (compare_record_run) Change parameter from struct sort_cases_pgm *
1214 to struct initial_run_state *. Pass irs->idx_to_fv to
1216 (compare_record_run) Third parameter now a struct
1217 initial_run_state *.
1218 (output_record) No need for out_case anymore. Pass irs, not
1219 struct sort_cases_pgm to pop_heap(). Use case_size from struct
1221 (merge) Use case_size from struct sort_cases_pgm.
1222 (merge_once) Use case_size from struct sort_cases_pgm.
1223 Pass null pointer to compare_record() as idx_to_fv.
1224 (global var sort_sink_class) Make static.
1226 * t-test.q: (cmd_t_test) Use procedure_with_splits().
1228 * temporary.c: Remove debugging crap.
1230 Sat Mar 13 14:19:52 WST 2004 John Darrington <john@darrington.wattle.id.au>
1232 * t-test.q, levene.c: Fixed up the handling of MISSING values
1235 Fri Mar 12 16:23:35 WST 2004 John Darrington <john@darrington.wattle.id.au>
1237 * t-test.q, levene.c: Added support for T-TEST /GROUP where only
1240 Wed Mar 10 23:25:13 2004 Ben Pfaff <blp@gnu.org>
1242 Change explicit variable name checks into use of
1243 dict_class_from_id().
1245 * dictionary.c: (dict_create_var) Change explicit variable name
1246 check into use of dict_class_from_id().
1248 * get.c: (trim_dictionary) Ditto.
1250 * sel-if.c: (cmd_filter) Ditto.
1252 * sysfile-info.c: (cmd_display) Ditto.
1254 * vars-prs.c: (parse_DATA_LIST_vars) Ditto.
1256 * vfm.c: (arrange_compaction) Ditto.
1258 * weight.c: (cmd_weight) Ditto.
1260 Wed Mar 10 21:16:34 2004 Ben Pfaff <blp@gnu.org>
1262 * temporary.c: (cmd_temporary) When TEMPORARY was the first
1263 transformation following the input program, if any, for some
1264 reason we special-cased f_trns. That's just wrong. It should
1265 always be set to n_trns.
1267 Tue Mar 9 23:44:40 2004 Ben Pfaff <blp@gnu.org>
1269 * format.c: (parse_format_specifier_name) Fix brown-bag bug
1270 introduced in last check-in.
1272 Tue Mar 9 23:10:41 2004 Ben Pfaff <blp@gnu.org>
1274 * format.c: (global array translate_fmt[]) Removed.
1275 (translate_fmt) New function as replacement.
1276 (parse_format_specifier_name) Rewrite.
1278 * pfm-read.c: (convert_format) Use translate_fmt() instead of
1281 * sfm-read.c: (parse_format_spec) Ditto.
1283 * postscript.c: (text) Fix handling of fonts with missing
1286 * sort.c: (struct external_sort) Add temp_name member.
1287 (destroy_external_sort) Free temp_dir, temp_name members.
1288 (init_external_sort) Allocate temp_name.
1289 (get_temp_file_name) Change prototype.
1290 (open_temp_file) Deal with change to get_temp_file_name().
1291 (close_temp_file) Ditto.
1292 (remove_temp_file) Ditto.
1293 (write_temp_file) Ditto.
1294 (read_temp_file) Ditto.
1295 (sort_sink_destroy) Removed.
1296 (sort_sink_class) Change destroy member to null.
1298 Tue Mar 9 22:36:34 2004 Ben Pfaff <blp@gnu.org>
1300 Eliminate temp_case.
1302 * aggregate.c: (cmd_aggregate) No need to save/restore temp_case
1303 anymore. Use agr_11x_finish().
1304 (aggregate_single_case) Make first param const.
1305 (accumulate_aggregate_info) Ditto.
1306 (agr_00x_end_func) Use compaction_case, not temp_case.
1307 (agr_11x_func) Break into agr_11x_read(), agr_11x_finish().
1309 * data-list.c: (struct data_list_pgm) Add `case_size' member.
1310 (cmd_data_list) Initialize case_size.
1311 (read_from_data_list_fixed) Add struct ccase * param, use instead
1313 (read_from_data_list_free) Ditto.
1314 (read_from_data_list_list) Ditto.
1315 (read_one_case) Rename data_list_trns_proc(), all references
1316 updated. Add argument in calling above functions. Use c
1317 argument instead of temp_case.
1318 (destroy_dls) Rename data_list_trns_free(), all references
1321 * expr-evl.c: (expr_evaluate) Make second parameter const.
1323 * file-type.c: (struct file_type_pgm) Add `case_size' member.
1324 (cmd_end_file_type) Initialize `case_size'.
1325 (file_type_source_read) Add struct ccase * parameter. Use instead
1328 * flip.c: Rewritten.
1330 * get.c: (struct get_pgm) New structure to keep track of
1332 (cmd_get) Initialize case_size.
1334 (get_source) Deal with struct get_pgm.
1335 (get_source_read) Add struct ccase * parameter, use instead of
1337 (import_source_read) Ditto.
1339 * get.c: Use a null pointer instead of temp_case to represent the
1340 "current case" in a struct mtf_file's input member.
1341 (mtf_processing_finish) Pass null to mtf_processing(), not
1343 (mtf_read_nonactive_records) Don't set iter->input to temp_case.
1344 (mtf_compare_BY_values) Add extra arg, use instead of null input
1346 (mtf_processing) Use c parameter instead of temp_case. Pass
1347 compaction_case to process_active_file_output_case().
1349 * glob.c: (global variable temp_case) Removed.
1351 * inpt-pgm.c: (struct input_program_pgm) Add `case_size' member.
1352 (cmd_input_program) Initialize case_size. Set
1353 vfm_source->value_cnt.
1354 (init_case) Add struct ccase * parameter, use instead of
1357 (input_program_source_read) Ditto.
1359 * matrix-data.c: (matrix_data_read_without_rowtype) Ditto.
1360 (dump_cell_content) Ditto.
1361 (nr_output_data) Ditto.
1362 (read_matrices_without_rowtype) Ditto.
1363 (matrix_data_read_with_rowtype) Ditto.
1364 (wr_read_splits) Ditto.
1365 (wr_output_data) Ditto.
1367 * sort.h: (struct sort_cases_pgm) New member `case_size'.
1369 * sort.c: (sort_cases) Initialize scp->case_size.
1370 (struct external_sort) Remove `case_size' member.
1371 (write_initial_runs) Only call vfm_sink->class_destroy if
1373 (struct sort_source_aux) New structure.
1374 (sort_source_read_helper) New function.
1375 (sort_source_read) Use sort_source_read_helper().
1376 (read_sort_output) Change interface to be more reasonable.
1377 (read_internal_sort_output) Ditto.
1378 (read_external_sort_output) Ditto.
1380 * vars-prs.c: (dict_class_to_name) Pass return value through
1383 * vfm.c: (struct procedure_aux_data) Add `trns_case' member.
1384 (procedure) Initialize trns_case.
1385 (procedure) Pass trns_case to vfm_source->class->read().
1387 (process_active_file) Start using struct procedure_aux_data.
1388 (process_active_file_write_case) Pass trns_case to
1389 transformations, lag_case(), clear_case().
1390 (process_active_file_output_case) Add struct ccase * parameter.
1391 (create_trns_case) New function.
1392 (make_temp_case) Removed.
1393 (vector_initialization) Removed.
1394 (close_active_file) Only call make_source if non-null, otherwise
1395 set vfm_source to null pointer. Don't free temp_case.
1396 (disk_source_read) Add struct ccase * parameter, use instead of
1398 (memory_source_read) Ditto.
1399 (lag_case) Add const struct ccase * member.
1400 (procedure_write_case) Use trns_case instead of temp_case.
1401 (clear_case) Add struct ccase * member, use instead of temp_case.
1402 (exclude_this_case) Ditto.
1403 (create_case_source) Add struct dictionary * parameter, use to
1404 initialize source->value_cnt.
1406 * vfm.h: (struct case_source) Add `value_cnt' member.
1407 (struct case_source_class) Add struct ccase * parameter to `read'
1408 member function pointer.
1409 (struct case_sink_class) Make struct ccase * parameter const in
1410 `write' member function pointer.
1412 Wed Mar 3 20:44:37 2004 Ben Pfaff <blp@gnu.org>
1414 Fix a lot of "possibly uninitialized variable" warnings. Some of
1415 them are even real bugs. A few of them make me wonder how the
1418 * aggregate.c: (parse_aggregate_functions) Initialize `function.
1420 * ascii.c: (output_lines) Add default case to switch.
1422 * crosstabs.q: Remove static variable `expected' and all
1424 (display_crosstabulation) Always calculate expected value.
1426 (output_pivot_table) Initialize `cmp'.
1427 (display_crosstabulation) New variable `last_row', which is
1430 * data-in.c: (parse_numeric) Always initialize sign. How did this
1433 * data-list.c: (repeating_data_trns_proc) Always initialize code.
1434 Always set info.ofs. (How did this work?!)
1436 * expr-opt.c: (optimize_tree) Always initialize `m'.
1437 (evaluate_tree) Always initialize `c'. (How did this work?)
1439 * frequencies.q: (frq_custom_variables) Always initialize min,
1441 (frq_custom_grouped) Always initialize `dl'.
1443 * groff-font.c: (groff_read_font) Always initialize char_set.
1445 * matrix-data.c: (nr_output_data) Initialize `split'.
1446 (wr_read_splits) Remove shadowing split_cnt declaration.
1447 (wr_output_data) Initialize `split'.
1449 * output.c: (tokener) Skip add character on syntax error.
1451 * pool.c: (pool_strndup) Always set `copy'. (How did this work?!)
1453 * postscript.c: (read_ps_encodings) Use line.string instead of
1455 (write_text) Add default case to switch.
1456 (text) Always initialize multiple variables. Fix bug with
1459 * print.c: (fixed_parse_fortran) Initialize head.
1460 (alloc_line) Add default case to switch.
1462 * recode.c: (parse_dest_spec) Handle case where nothing matches.
1463 (recode_trns_proc) Move variable declaration inward. Add default
1466 * sfm-read.c: (read_header) Initialize skip_amt.
1468 * sysfile-info.c: (display_variables) Always initialize pc.
1470 * vars-prs.c: Initialized `included'.
1472 Wed Mar 3 09:30:09 2004 Ben Pfaff <blp@gnu.org>
1474 * main.c: (main) sigaction()'s sa_flags member was uninitialized.
1475 Just use signal() instead.
1477 Wed Mar 3 09:26:30 2004 Ben Pfaff <blp@gnu.org>
1479 Get rid of vfm_sink_info and vfm_source_info.
1481 * aggregate.c: (agr_00x_end_func) Don't increment
1482 sfm_sink_info.ncases.
1484 * sort.c: (do_internal_sort) Get case count from
1485 vfm_source->class->count().
1486 (struct external_sort) Add `case_size' member.
1487 (do_external_sort) Initialize case_size.
1488 (struct initial_run_state) Add `case_size' member.
1489 (write_initial_runs) Initialize case_size.
1490 (sort_sink_write) Use case_size.
1491 (read_external_sort_output) Use case_size. Get case_cnt from
1494 * vfm.c: (struct write_case_data) Add underscores to existing arg
1495 names, all references updated. Renamed `aux' as `func_aux', all
1496 references updated. Added new `aux' member.
1497 (global var vfm_source_info) Removed.
1498 (global var vfm_sink_info) Removed.
1499 (struct procedure_aux_data) New.
1500 (struct split_aux_data) New.
1501 (procedure) Use `aux' fields for procedure_aux_data,
1503 (process_active_file_write_case) Pass case_count + 1 to
1504 transformation procedures, exclude_this_case().
1505 (process_active_file_output_case) Don't increment
1506 vfm_sink_info.ncases.
1507 (prepare_for_writing) Don't initialize vfm_sink_info. Don't try
1508 to send data to disk early.
1509 (make_temp_case) Don't use vfm_sink_info.case_size.
1510 (close_active_file) Don't initialize vfm_source_info.
1511 (struct disk_stream_info) New, to allow for case_cnt and case_size fields.
1512 (disk_sink_create) Initialize and/or update disk_stream_info.
1513 (disk_sink_write) Ditto.
1514 (disk_sink_destroy) Ditto.
1515 (disk_sink_make_source) Ditto.
1516 (disk_source_read) Ditto.
1517 (disk_source_destroy) Ditto.
1518 (global var disk_source_class) Add disk_source_count().
1519 (disk_source_count) New function.
1520 (struct memory_sink_info) Add `case_cnt', `case_size' members.
1521 (struct memory_source_info) Ditto.
1522 (memory_sink_create) Deal with case_cnt, case_size.
1523 (memory_sink_write) Ditto.
1524 (memory_sink_make_source) Ditto.
1525 (memory_source_read) Ditto.
1526 (memory_source_count) New function.
1527 (memory_source_class) Add memory_source_count().
1528 (procedure_write_case) Don't use vfm_sink_info.ncases. Do use
1529 proc_aux->cases_written, and pass it to transformation procedures
1530 and exclude_this_case ().
1531 (exclude_this_case) Add case_num parameter. Pass it to
1533 (SPLIT_FILE_procfunc) Use split_aux->prev_case instead of static
1536 * vfm.h: (struct case_source_class) Add `count' member.
1538 * vfmP.h: (struct stream_info) Removed.
1539 (global variable vfm_source_info) Removed.
1540 (global variable vfm_sink_info) Removed.
1542 Tue Mar 2 23:38:17 2004 Ben Pfaff <blp@gnu.org>
1544 * var.h: (typedef trns_proc_func) New typedef.
1545 (trns_free_func) New typedef.
1546 (struct trns_header) Change `proc' to type trns_proc_func, `free'
1547 to type trns_free_func. This only changes the actual type of
1548 trns_proc_func, adding a `case_num' parameter. Updated all
1549 implementations to use the typedefs instead.
1551 * compute.c: (compute_num) Pass case_num to expr_evaluate().
1552 (compute_num_vec) Ditto.
1553 (compute_str) Ditto.
1554 (compute_str_vec) Ditto.
1556 * do-if.c: (do_if_trns_proc) Ditto.
1558 * expr-evl.c: (expr_evaluate) Add new case_num parameter, use for
1561 * inpt-pgm.c: (input_program_source_read) Maintain case count,
1562 pass to transformation functions.
1563 (reread_trns_proc) Pass case_num arg to expr_evaluate().
1565 * loop.c: (loop_1_trns_proc) Ditto.
1566 (loop_2_trns_proc) Ditto.
1567 (loop_3_trns_proc) Ditto.
1569 * print.c: (print_space_trns_proc) Ditto.
1571 * sel-if.c: (select_if_proc) Ditto.
1573 Tue Mar 2 11:36:52 2004 Ben Pfaff <blp@gnu.org>
1575 * frequencies.q: (cleanup_freq_tab) Avoid memory leak by
1576 destroying hash table.
1578 * glob.c: (read_active_file) Variable not referenced, removed.
1579 (cancel_input_pgm) Ditto.
1581 * levene.c: Add #include <stdlib.h> needed to call free().
1583 * aggregate.c: (parse_aggregate_functions) Make `function'
1586 Tue Mar 2 11:30:56 2004 Ben Pfaff <blp@gnu.org>
1588 Start working to eliminate VFM dependence on static variables.
1590 * command.c: (cmd_parse) Use case_source_is_class().
1592 * data-list.c: Rewrite to eliminate use of static variables.
1594 * dfm.c: (cmd_begin_data) Use case_source_is_class().
1596 * file-handle.q: (fh_handle_name) Make parameter const.
1598 * file-type.c: Rewrite to eliminate use of static variables.
1600 * flip.c: Rewrite to eliminate use of static variables.
1602 * format.c: (get_format_var_width) New function.
1604 * get.c: Eliminate use of static variables.
1606 * inpt-pgm.c: Eliminate use of static variables.
1608 * matrix-data.c: Eliminate use of static variables.
1610 * set.q: (set_max_workspace) New variable.
1611 (cmd_set) Use SET WORKSPACE to modify set_max_workspace.
1613 * var.h: (struct case_list) Move here from vfmP.h.
1615 * vars-atr.c: (discard_variables) Handle new vfm_source type.
1617 * vfm.c: (vfm_source) Change type from struct case_stream to
1619 (vfm_sink) Change type from struct case_stream to struct
1621 (static var paging) Rename workspace_overflow, all references
1623 (procedure) Use new class structures.
1624 (process_active_file) Ditto.
1625 (process_active_file_write_case) Ditto.
1626 (prepare_for_writing) Use set_max_workspace. Use new class
1628 (close_active_file) Use new class structures. Free old sink.
1629 (global var disk_source_file) Removed.
1630 (global var disk_sink_file) Removed.
1631 (disk_stream_init) Removed.
1632 (disk_stream_read) Removed.
1633 (disk_stream_write) Removed.
1634 (disk_stream_mode) Removed.
1635 (disk_stream_destroy_source) Removed.
1636 (disk_stream_destroy_sink) Removed.
1637 (global var vfm_disk_stream) Removed.
1638 (disk_sink_create) New function.
1639 (disk_sink_write) New function.
1640 (disk_sink_destroy) New function.
1641 (disk_sink_make_source) New function.
1642 (disk_sink_class) New static var.
1643 (disk_source_read) New function.
1644 (disk_source_destroy) New function.
1645 (global var vfm_source_class) New var.
1646 (global var memory_source_cases) Removed.
1647 (global var memory_sink_cases) Removed.
1648 (global var memory_sink_max_cases) Removed.
1649 (struct memory_sink_info) New struct.
1650 (memory_stream_init) Removed.
1651 (memory_stream_read) Removed.
1652 (memory_stream_write) Removed.
1653 (memory_stream_mode) Removed.
1654 (memory_stream_destroy_source) Removed.
1655 (memory_stream_destroy_sink) Removed.
1656 (global var vfm_memory_stream) Removed.
1657 (page_to_disk) Renamed write_active_file_to_disk().
1658 (memory_sink_create) New function.
1659 (memory_sink_write) New function.
1660 (memory_sink_destroy) New function.
1661 (memory_sink_make_source) New function.
1662 (memory_sink_class) New static var.
1663 (memory_source_read) New function.
1664 (memory_source_destroy) New function.
1665 (memory_source_get_cases) New function.
1666 (memory_source_set_cases) New function.
1667 (global var vfm_source_class) New var.
1668 (procedure_write_case) Use new class structures.
1669 (create_case_source) New function.
1670 (case_source_is_complex) New function.
1671 (case_source_is_class) New function.
1672 (create_case_sink) New function.
1674 * vfm.h: (global variable reinit_sysmis) Not used, removed.
1675 (global variable reinit_blanks) Not used, removed.
1676 (global variable init_zero) Not used, removed.
1677 (global variable init_blanks) Not used, removed.
1678 (struct case_source) New struct.
1679 (struct case_source_class) New struct.
1680 (struct case_sink) New struct.
1681 (struct case_sink_class) New struct.
1682 (struct case_stream) Removed.
1684 * vfmP.h: (struct case_list) Moved to var.h.
1686 Tue Mar 2 11:28:30 2004 Ben Pfaff <blp@gnu.org>
1688 * algorithm.c: (count_equal) New function.
1689 (count_if) New function.
1690 (unique) Add assertions.
1691 (partition) Add assertions.
1692 (is_partitioned) New function.
1693 (copy_if) Add assertions.
1694 (remove_equal) Add assertions.
1695 (lexicographical_compare) Rename lexicographical_compare_3way.
1696 (sort) Add assertions. Rephrase some code.
1697 (is_sorted) New function.
1699 Sun Feb 29 23:24:57 2004 Ben Pfaff <blp@gnu.org>
1703 * sort.c: Completely rewrite.
1705 * sort.h: Expose interface via struct sort_cases_pgm, not via
1708 * aggregate.c: (sort) New static var.
1709 (cmd_aggregate) Use sort.
1710 (create_sysfile) Ditto.
1711 (aggregate_single_case) Ditto.
1712 (dump_aggregate_info) Ditto.
1713 (agr_00x_end_func) Ditto.
1714 (debug_print) Ditto.
1716 * var.h: (enum SRT_ASCEND) Removed.
1717 (enum SRT_DESCEND) Removed.
1718 (struct sort_cases_proc) Removed.
1719 (struct variable) Remove p.srt member.
1721 Sun Feb 29 23:22:45 2004 Ben Pfaff <blp@gnu.org>
1723 Get rid of the old, crappy heap structure and replace it by a new,
1724 shiny, C++ STL-like heap structure.
1726 * Makefile.am: (pspp_SOURCES) Remove heap.c, heap.h.
1728 * algorithm.c: (push_heap) New function.
1739 Sun Feb 29 23:21:53 2004 Ben Pfaff <blp@gnu.org>
1741 Increase warning level.
1743 * Makefile.am: (AM_CFLAGS) Remove -Wnouninitialized.
1745 Sat Feb 21 17:38:58 WST 2004 John Darrington <john@darrington.wattle.id.au>
1747 * main.c: Added a signal handler for SIGSEGV requesting a bug report.
1749 Fri Feb 20 23:22:14 2004 Ben Pfaff <blp@gnu.org>
1751 * dictionary.c: (dict_create_var) Fix root cause of bug worked
1752 around by previous change log entry.
1754 * compute.c: (lvalue_finalize) Remove workaround from previous
1757 Fri Feb 20 14:37:41 WAST 2004 John Darrington <john@darrington.wattle.id.au>
1759 * compute.c: Fixed a bug where the Format was not getting set for
1760 computed variables (thus causing a crash when SAVEing).
1762 * Added a test to stop this bug ever coming back
1764 Wed Feb 18 22:21:35 2004 Ben Pfaff <blp@gnu.org>
1766 Got rid of approx.h. In general, replaced all references to
1767 approx_eq() by ==, approx_lt() by <, etc. Other types of changes
1770 * Makefile.am: (pspp_SOURCES) Removed approx.h.
1772 * data-out.c: (try_F) Replaced test for approx_eq(number, 0.0) by
1773 test for mag < EPSILON.
1775 * misc.h: Add definition of EPSILON.
1777 Wed Feb 18 21:32:44 2004 Ben Pfaff <blp@gnu.org>
1779 * vfm.c: (procedure) Add check to prevent recursive call.
1781 Wed Feb 18 21:48:54 WST 2004 John Darrington <john@darrington.wattle.id.au>
1783 * Moved the declarations relating to values to their own header file
1786 * Added levene.c and levene.h
1788 * vars-atr.c: Changed the signature of compare_values to
1789 take const * arguments.
1791 * t-test.q: Changed the structure of struct t_test_proc
1792 variables now contain their own group statistics information.
1793 Eventually, t_test_proc might get renamed, because it'd be
1794 applicable to other commands too.
1796 Mon Feb 16 23:15:51 2004 Ben Pfaff <blp@gnu.org>
1798 * data-out.c: Clean up. Changed interface of convert_*() to take
1799 either a `double' or a `const char *' instead of a `const union
1800 value *'. Update all implementations of those interfaces.
1801 (data_out) Use switch statements instead of a table.
1802 (convert_AHEX) Rewrite.
1804 * format.h: Update comment.
1806 Mon Feb 16 22:14:36 2004 Ben Pfaff <blp@gnu.org>
1808 * q2c.c: (dump_header) Add an Emacs header line to output files
1809 that makes generated .c files read-only by default, to make it
1810 difficult to accidentally change generated files.
1812 Mon Feb 16 22:12:07 2004 Ben Pfaff <blp@gnu.org>
1814 * frequencies.q: (compare_freq_numeric_a) Compare by frequency,
1815 not bogus a->v.c <=> b->v.c pointer compare.
1816 (compare_freq_alpha_a) Ditto.
1817 (compare_freq_numeric_d) Ditto.
1818 (compare_freq_alpha_d) Ditto.
1820 Mon Feb 16 22:00:53 2004 Ben Pfaff <blp@gnu.org>
1822 Changed data_out() to store string data directly into a `union
1823 value''s s member, not indirectly into c.
1825 * crosstabs.q: (output_pivot_table) Use format_short() instead of
1827 (table_value_missing) Ditto.
1828 (float_M_suffix) Ditto.
1829 (format_short) New function.
1831 * data-in.h: (data_in_finite_line) Remove inline definition.
1833 * data-list.c: (destroy_dls_var_spec) New function.
1834 (destroy_dls) Rewrite in terms of destroy_dls_var_spec().
1835 (data_list_source_destroy_source) Avoid cast.
1836 (struct repeating_data_trns) New field `id_value'. Update
1838 (cmd_repeating_data) Initialize id_value. Use new
1839 repeating_data_trns_free() for freeing REPEATING DATA
1841 (rpd_parse_record) Rewrite support for record ID to be less bogus.
1842 (repeating_data_trns_free) New function.
1844 * data-out.c: (data_out) Change return type to `void' by replacing
1845 error returns by writing a message into the output buffer.
1846 (convert_A) Read from v->s instead of v->c.
1847 (convert_AHEX) Ditto.
1849 * expr-evl.c: Update comment.
1850 (expr_evaluate) Add assertion in OP_STRING case.
1852 * format.h: (macro MAX_FORMATTED_LEN) New macro.
1854 * list.q: (list_cases) Update for new data_out() semantics.
1856 * print.c: (print_trns_proc) Ditto.
1858 * tab.c: (tab_value) Ditto.
1859 (tab_float) Avoid stupid cast.
1861 * var.h: Update comments.
1862 (macro MAX_STRING) New macro.
1863 (macro MAX_ELEMS_PER_VALUE) New macro.
1865 * vars-atr.c: (compare_values) New function.
1867 * vfm.c: (dump_splits) Update for new data_out() semantics.
1869 Mon Feb 16 21:45:47 2004 Ben Pfaff <blp@gnu.org>
1871 * crosstabs.q: (struct table_entry) Rename v[] to values[]. All
1873 (struct crosstab) Rename v[] to vars[]. All references updated.
1874 (hash_table_entry) Replace the hash algorithm and fix a bug at the
1875 same time, which caused the hash value to depend only on a single
1876 value, not all of the variables' values.
1878 Mon Feb 16 12:49:53 2004 Ben Pfaff <blp@gnu.org>
1880 Clean up struct dictionary's value_cnt usage.
1882 * dictionary.c: Add a function comment to each function.
1883 (struct dictionary) Rename value_cnt to next_value_idx, which more
1884 accurately reflects its meaning. All references updated.
1885 (dict_rename_vars) Add assertion.
1886 (dict_get_value_cnt) Rename dict_get_next_value_idx(). All
1888 (dict_get_case_size) New function.
1890 * aggregate.c: (create_sysfile) Use dict_get_case_size().
1892 * get.c: (mtf_read_nonactive_records) Ditto.
1894 * sort.c: (allocate_cases) Ditto.
1895 (write_initial_runs) Ditto.
1899 * vfm.c: (prepare_for_writing) Ditto.
1903 Mon Feb 16 00:17:55 2004 Ben Pfaff <blp@gnu.org>
1905 Make vfm.c slightly less grotesque.
1907 * vfm.c: (filter_var) Removed.
1908 (filter_index) Removed.
1909 (FILTERED macro) Removed.
1910 (exclude_this_case) New function.
1911 (process_active_file_write_case) Use exclude_this_case() instead
1912 of FILTERED and inline tests.
1913 (procedure_write_case) Ditto.
1914 (setup_filter) Removed.
1915 (open_active_file) Don't call setup_filter().
1916 (close_active_file) Call dict_get_filter() instead of checking
1919 Mon Feb 16 00:01:53 2004 Ben Pfaff <blp@gnu.org>
1921 * var.h: (struct variable) Update comments.
1923 Sun Feb 15 23:14:59 2004 Ben Pfaff <blp@gnu.org>
1925 New functions dict_create_var_assert(), dict_lookup_var_assert().
1926 Converted several dict_*_var()/assert pairs into a single
1927 dict_*_var_assert().
1929 * dictionary.c: (dict_create_var_assert) New function.
1930 (dict_lookup_var_assert) New function.
1932 Sun Feb 15 23:06:08 2004 Ben Pfaff <blp@gnu.org>
1934 Got rid of "struct long_vec", envector(), devector(), etc. Added
1935 two members `init', `reinit' to struct variable as a substitute.
1937 * Makefile.am: (pspp_SOURCES) Removed cases.c, cases.h.
1943 * aggregate.c: (parse_aggregate_functions) destvar doesn't need
1946 * autorecode.c: (cmd_autorecode) destvars don't need init.
1948 * compute.c: (lvalue_finalize) Set reinit.
1950 * data-list.c: (fixed_parse_compatible) Don't need init usually.
1951 (dump_fmt_list) Ditto.
1954 * descript.q: (run_z_pass) Don't need init for z-scores.
1956 * dictionary.c: (dict_create_var) Initialize `init', `reinit'
1958 (dict_clone_var) Copy `reinit' member, initialize `init' member.
1960 * glob.c: (init_glob) Remove vec_init() calls.
1962 * inpt-pgm.c: (cmd_end_input_program) Use `reinit', not `left'.
1964 * loop.c: (internal_cmd_loop) Don't need to call envector().
1966 * numeric.c: (cmd_numeric) Ditto.
1968 (cmd_leave) Ditto. Set `init', `reinit' members.
1970 * recode.c: (cmd_recode) Don't need to call envector().
1972 * repeat.c: (internal_cmd_do_repeat) Ditto.
1974 * var.h: (struct variable) Remove `left'. Add `init', `reinit'.
1975 (force_create_variable) Removed prototype.
1976 (force_dup_variable) Ditto.
1978 * vector.c: (cmd_vector) Don't need to call envector().
1980 * vfm.c: (reinit_sysmis) Removed.
1981 (reinit_blanks) Removed.
1982 (init_zero) Removed.
1983 (init_blanks) Removed.
1984 (process_active_file_write_case) No need to deal with vectors.
1985 Call clear_temp_case().
1986 (vector_initialization) Rewrite to use `init', `reinit'.
1987 (close_active_file) No need to call vec_clear().
1988 (procedure_write_case) Call clear_temp_case().
1989 (clear_temp_case) New function.
1991 Sun Feb 15 20:50:36 2004 Ben Pfaff <blp@gnu.org>
1993 * pfm-write.c: (bufwrite) Get rid of nasty cast that also invoked
1996 Thu Feb 12 23:35:15 2004 Ben Pfaff <blp@gnu.org>
1998 Add auxiliary argument to procedure() interface. Associated small
1999 clean-ups of vfm interface.
2001 * Updated every caller of procedure() and process_active_file() to
2002 reflect modified interface. Simple, ordinary changes not listed
2005 * Updated every function that implements struct case_stream's
2006 `read' function to take a write_case_func and a write_case_data.
2007 Also updated every caller of write_case() to instead call them
2008 through these arguments. In some cases this meant that the extra
2009 args had to be threaded through a couple of extra levels. This
2010 wasn't difficult or interesting so the details won't be given.
2012 * data-list.c: (struct repeating_data_trns) Add members
2013 `write_case', `wc_data' as kluge.
2014 (read_one_set_of_repetitions) Rename repeating_data_trns_proc and
2016 (repeating_data_set_write_case) New function.
2018 * data-list.h: New file to declare repeating_data_trns_proc() and
2019 repeating_data_set_write_case().
2021 * inpt-pgm.c: (input_program_source_read) Call
2022 repeating_data_set_write_case() for all the REPEATING DATA
2023 transformations, so that they know where to send their cases.
2024 It's a big kluge. Also kluge in END CASE.
2025 (end_case_trns_proc) Never called anymore, but we still need it,
2028 * sort.c: (read_sort_output) Update to match struct case_stream
2031 * vfm.c: (struct write_case_data) New structure.
2032 (proc_func) Removed.
2033 (virt_proc_func) Removed.
2034 (begin_func) Removed.
2035 (virt_begin_func) Removed.
2037 (write_case) Removed.
2038 (procedure) Added an auxiliary parameter to each function pointer
2039 argument's prototype. Added an auxiliary data parameter.
2041 (process_active_file) Ditto.
2042 (process_active_file_write_case) Pass aux data along.
2043 (close_active_file) Ditto.
2044 (procedure_write_case) Ditto.
2045 (SPLIT_FILE_procfunc) Ditto.
2047 * vfm.h: (typedef write_case_data) New.
2048 (typedef write_case_func) New.
2049 (struct case_stream) Add parameters to `read' member prototype.
2051 Thu Feb 12 19:24:53 WST 2004 John Darrington <john@darrington.wattle.id.au>
2053 * t-test.q: Added calculations for independent samples. (But no Levene
2056 * Makefile.am: Moved q_sources_c into own variable
2058 Wed Feb 11 23:56:51 2004 Ben Pfaff <blp@gnu.org>
2060 Miscellaneous cleanups.
2062 * Change unused to UNUSED in many source files to reflect modified
2063 pref.h. Change use of __WIN32__, __MSDOS, __DJGPP__,
2064 __CYGWIN32__, __unix__, and unix not to assume that they're
2065 defined to a nonzero value. Change use of __attribute__ to use
2066 NO_RETURN or PRINTF_FORMAT instead.
2068 * alloc.h: Move definitions for local_alloc(), local_free() here
2069 from ../pref.h.orig and simplify.
2071 * expr-evl.c: Instead of working differently based on PAGED_STACK,
2072 use a pool allocator unconditionally.
2073 (CHECK_STRING_SPACE) Removed.
2074 (ALLOC_STRING_SPACE) Removed.
2075 (expr_evaluate) Use e->pool instead of CHECK_STRING_SPACE and
2078 * expr-opt.c: (dump_expression) Allocate string pool.
2080 * expr-prs.c: (expr_free) Free string pool.
2082 * pool.c: (pool_destroy) This pool must be removed from its
2083 parent's list of gizmos, not from its own. Use free_all_gizmos().
2084 (pool_clear) New function.
2085 (free_all_gizmos) New function.
2086 (pool_alloc) Use space in empty block after this one if any.
2087 (pool_release) Only empty out blocks, don't actually free() them.
2089 * print.c: Get rid of PAGED_STACK special case by always
2090 dynamically allocating line buffers.
2091 (struct print_trns) Always include the `line' member.
2092 (internal_cmd_print) Always initialize the `line' member.
2093 (alloc_line) Always allocate memory for `line'.
2094 (print_trns_proc) Always initialize buf from `line' member.
2095 (print_trns_free) Always free `line' memory.
2097 * sort.c: (allocate_file_handles) Special-case MS-DOS for mkdir()
2100 Wed Feb 11 20:33:18 2004 Ben Pfaff <blp@gnu.org>
2102 * flip.c: Fixed crash from FLIP when a numeric variable is
2103 specified on NEWNAMES and a large value is used, and a couple of
2104 other minor bugs besides.
2105 (struct varname) Make name a 9-character fixed-size array
2106 instead of a 1-character variable size array.
2107 (make_new_var) Allow digits in variable names.
2108 (flip_stream_write) Limit numeric values to 8 characters and
2109 format system missing and very large and small values more
2112 Thu Feb 5 13:19:06 WAST 2004 John Darrington <john@darrington.wattle.id.au>
2114 * command.c: Fixed test on command return status for the correct
2115 value, which had been causing a crash under certain invalid input.
2117 Wed Feb 4 15:34:11 WST 2004 John Darrington <john@darrington.wattle.id.au>
2119 * t-test.q: Added calculations for the one sample variant of the T-TEST
2121 Tue Feb 3 20:09:54 2004 Ben Pfaff <blp@gnu.org>
2123 * tab.c: (render_strip) Fix bug that sometimes caused joined text
2124 in joined cells to be rendered outside box boundaries.
2126 Tue Feb 3 18:56:45 WST 2004 John Darrington <john@darrington.wattle.id.au>
2128 * random.c (rng_create): Fixed seeding so that it gets reseeded after
2129 SET seed=xx has been called.
2131 Mon Jan 19 14:08:09 2004 Ben Pfaff <blp@gnu.org>
2133 * random.c (rng_get_double): Fix always-returning-zero bug in my
2134 preferred way, and at the same time make sure rounding doesn't
2137 Thu Jan 1 23:16:41 2004 Ben Pfaff <blp@gnu.org>
2139 * html.c: (change_attributes) Dead code, removed.
2140 (escape_string) Eliminate code to call change_attributes() that
2141 never actually called it.
2142 (output_tab_table) Get rid of dependence on tab_hit
2143 and struct tab_joined_cell's hit member, which are abominations.
2145 * tab.c: (tab_output_text) Don't call
2146 d->class->text_set_font_by_name if it's a null pointer.
2147 (macro UNROLL_LOOP) Eliminate.
2148 (macro UNROLL_3_LOOPS) Eliminate.
2149 (tabi_render) Rewrite not to use the above macros.
2151 Thu Jan 1 23:09:07 2004 Ben Pfaff <blp@gnu.org>
2153 Start working on a new output driver system, one that doesn't suck
2154 so much, by adding a "device-independent" output driver. The idea
2155 is to write out only a single output stream, then use separate
2156 processes to translate them into whatever formats we want. This
2157 is similar to how "groff" works with its various output drivers
2158 (grops, grotty, grodvi, ...).
2160 * Makefile.am: (pspp_SOURCES) Add devind.c, devind.h.
2162 * list.q: (write_all_headers) Stub out devind class.
2164 (determine_layout) Ditto.
2167 * output.c: (outp_init) Add devind class.
2169 * devind.c: New file.
2171 * devind.h: New file.
2173 Thu Jan 1 23:08:14 2004 Ben Pfaff <blp@gnu.org>
2175 * frequencies.q: (hash_value_alpha) Fixed up the previous change
2176 to use the proper string length.
2178 Wed Dec 31 16:27:33 WAST 2003 John Darrington <john@darrington.wattle.id.au>
2180 * Fixed bug where FREQ would crash on alpha values
2182 Tue Dec 30 22:42:57 2003 Ben Pfaff <blp@gnu.org>
2184 * Removed bletcherous alloca() workarounds for AIX from top of
2185 many files. AIX can use the alternative alloca() implementation
2188 Tue Dec 30 22:35:16 2003 Ben Pfaff <blp@gnu.org>
2190 * ascii.c: (ascii_option) Fix implementation of headers option.
2192 Tue Dec 30 22:32:53 2003 Ben Pfaff <blp@gnu.org>
2194 * ascii.c: Add a "squeeze" option to the ASCII driver to squeeze
2195 multiple blank lines into one.
2196 (struct ascii_driver_ext) Add squeeze_blank_lines option.
2197 (ascii_preopen_driver) Initialize squeeze_blank_lines.
2198 (static var option_tab) Add squeeze entry.
2199 (ascii_option) Set squeeze_blank_lines.
2200 (output_lines) Implement squeezing blank lines.
2202 Wed Dec 31 07:19:46 WST 2003 John Darrington <john@darrington.wattle.id.au>
2204 * Removed redundant code from output.h
2206 Sat Dec 27 22:17:52 2003 Ben Pfaff <blp@gnu.org>
2208 Dictionary classes: each variable is "ordinary", "system", or
2211 * var.h: (enum dict_class) New enum.
2213 * vars-prs.c: (dict_class_from_id) New function.
2214 (dict_class_to_name) New function.
2216 Sat Dec 27 22:16:06 2003 Ben Pfaff <blp@gnu.org>
2218 * var.h: (struct freq_tab_set) Removed (not used).
2220 Sat Dec 27 22:15:21 2003 Ben Pfaff <blp@gnu.org>
2222 * value-labels.c: (val_labs_destroy) vls needs to be freed too.
2224 Sat Dec 27 22:10:49 2003 Ben Pfaff <blp@gnu.org>
2226 * stats.c: (hypercube) Rename pow4(). All references updated.
2228 Sat Dec 27 22:05:49 2003 Ben Pfaff <blp@gnu.org>
2230 * rename-vars.c: (cmd_rename_variables) Rewritten.
2231 (compare_name) Removed.
2233 Sat Dec 27 22:03:51 2003 Ben Pfaff <blp@gnu.org>
2235 var_set feature, and code taking advantage of it.
2237 * crosstabs.q: (static var var_dict) Removed.
2238 (static var variables) New variable.
2239 (static var variables_cnt) New variable.
2240 (cmd_crosstabs) Free variables instead of var_dict.
2241 (internal_cmd_crosstabs) Initialize and use variables,
2242 variables_cnt instead of var_dict.
2243 (free_var_dict) Removed.
2244 (crs_custom_tables) Use var_set instead of a copied dictionary.
2245 (crs_custom_variables) Set up variables, variables_cnt instead of
2247 [DEBUGGING] (debug_print) Ditto.
2249 * means.q: (mns_custom_tables) Use var_set instead of a copied
2252 * vars-prs.c: (parse_vs_variable) New function.
2253 (parse_dict_variable) Rewritten.
2254 (parse_variable) Rewritten.
2255 (parse_variables) Renamed parse_var_set_vars(), rewritten.
2256 (parse_variables) New function in terms of parse_var_set_vars().
2257 Now requires its first argument to be non-null. All references
2258 that passed a null pointer updated to pass default_dict instead.
2259 (macro id_dict) Removed.
2260 (parse_DATA_LIST_vars) Add assertions.
2261 (parse_mixed_vars) Ditto.
2262 (struct var_set) New structure.
2263 (var_set_get_cnt) New function.
2264 (var_set_get_var) New function.
2265 (var_set_lookup_var) New function.
2266 (var_set_destroy) New function.
2267 (dict_var_set_get_cnt) New function.
2268 (dict_var_set_get_var) New function.
2269 (dict_var_set_lookup_var) New function.
2270 (dict_var_set_destroy) New function.
2271 (var_set_create_from_dict) New function.
2272 (struct array_var_set) New structure.
2273 (array_var_set_get_cnt) New function.
2274 (array_var_set_get_var) New function.
2275 (array_var_set_lookup_var) New function.
2276 (array_var_set_destroy) New function.
2277 (var_set_create_from_array) New function.
2279 * q2c.c: (dump_parser) Use parse_variables(default_dict, ...)
2280 instead of parse_variables(NULL, ...) in output code.
2282 Sat Dec 27 21:38:53 2003 Ben Pfaff <blp@gnu.org>
2284 Change inp_init from a 2-bit vector to an ordinary array.
2285 Initialize it all in cmd_end_input_program() instead of in
2288 * inpt-pgm.c: (enum value_init_type) New enum.
2289 (global var inp_init) Change to `enum value_init_type *', make
2291 (inp_init_size) Removed.
2292 (inp_nval) Change to `size_t', make static.
2293 (cmd_input_program) Don't initialize inp_init or inp_init_size.
2294 (cmd_end_input_program) Initialize inp_init, inp_nval.
2295 (init_case) Rewrite.
2296 (clear_case) Rewrite.
2298 * inpt-pgm.h: Removed.
2300 Sat Dec 27 21:36:38 2003 Ben Pfaff <blp@gnu.org>
2302 * hash.c: (hsh_hash_bytes) Use Fowler-Noll-Vo hash instead of
2303 Colin Plumb hash. It is simpler and should better resist
2305 (hsh_hash_string) Ditto.
2307 Sat Dec 27 21:34:57 2003 Ben Pfaff <blp@gnu.org>
2309 * get.c: (export_write_case_func) Remove debug printing code.
2311 Sat Dec 27 21:11:09 2003 Ben Pfaff <blp@gnu.org>
2313 * get.c: (cmd_save_internal) Rename parameter. Use &t->h instead
2315 (save_write_case_func) Use &trns->h instead of cast.
2316 (cmd_export) Use &t->h instead of cast.
2318 Sat Dec 27 20:57:42 2003 Ben Pfaff <blp@gnu.org>
2320 Moved vectors into the dictionary.
2322 * var.h: (struct vector) Moved here from vector.h. `index' member
2323 renamed `idx', `v' renamed `var', `nv' renamed `cnt'. All
2326 * vector.h: Removed.
2328 * vector.c: (global var vec) Removed.
2329 (global var nvec) Removed.
2330 (cmd_vector) Rewritten.
2331 (find_vector) Removed.
2333 * dictionary.c: (dict_create_vector) New function.
2334 (dict_get_vector) New function, replaces reading global vec[]
2336 (dict_get_vector_cnt) New function, replaces reading global nvec
2338 (dict_lookup_vector) New function, replaces find_vector().
2339 (dict_clear_vectors) New function.
2341 Sat Dec 27 20:54:01 2003 Ben Pfaff <blp@gnu.org>
2343 Start to move away from `struct variable' p `union' member to void
2346 * var.h: (struct variable) Add `aux' member.
2348 Sat Dec 27 20:36:25 2003 Ben Pfaff <blp@gnu.org>
2350 Get rid of struct variable `foo' member.
2352 * frequencies.q: (internal_cmd_frequencies) Use p.frq.used instead
2354 (frq_custom_variables) Ditto.
2355 (frq_custom_grouped) Ditto.
2357 * get.c: (struct save_trns) Change `var' member from `int *' to
2358 `struct variable **'.
2359 (cmd_save_internal) Use aux instead of foo.
2360 (save_trns_proc) Use revised `var' member.
2361 (static var mtf_seq_no) Renamed mtf_seq_num.
2362 (static var mtf_seq_nums) New static var.
2363 (cmd_match_files) Initialize mtf_seq_nums.
2364 (mtf_free) Free mtf_seq_nums.
2365 (mtf_processing) Use mtf_seq_nums instead of foo.
2366 (mtf_merge_dictionary) No need to initialize mv->foo.
2367 (cmd_export) Use aux instead of foo. Use revised `var' member.
2368 (mns_custom_tables) Don't use foo to check for duplicates, that's
2369 what PV_NO_DUPLICATE is for.
2371 * var.h: (struct variable) Remove `foo' member.
2372 (struct frequencies_proc) New member.
2374 Sat Dec 27 19:46:13 2003 Ben Pfaff <blp@gnu.org>
2376 Clean up COMPUTE and IF.
2378 * compute.c: More or less rewrite the darn thing.
2379 (struct compute_trns) Rename and reorder and add and delete
2381 (cmd_compute) Rewrite.
2382 (compute_num) Make conditional on test expression. Now used for
2383 both COMPUTE and IF.
2384 (compute_num_vec) Ditto.
2385 (compute_str) Ditto.
2386 (compute_str_vec) Ditto.
2389 (if_num_vec) Removed.
2391 (if_str_vec) Removed.
2392 (parse_target_expression) Renamed parse_rvalue_expression(),
2394 (new_trns) Renamed compute_trns_create(), rewritten.
2395 (delete_trns) Removed.
2396 (free_trns) Renamed compute_trns_free(), rewritten.
2397 (struct lvalue) New structure.
2398 (parse_var_or_vec) Renamed lvalue_parse(), rewritten.
2399 (lvalue_get_type) New function.
2400 (lvalue_is_vector) New function.
2401 (lvalue_finalize) New function.
2402 (lvalue_destroy) New function.
2404 Sat Dec 27 19:44:14 2003 Ben Pfaff <blp@gnu.org>
2406 * command.def: Disallow MODIFY VARS in input mode, so that
2407 variables can't get dropped and confuse cmd_end_input_program()'s
2408 attempt to fill inp_init[].
2410 * modify-vars.c: (static var forward_positional_ordering) New
2412 (struct var_modification) Entirely changed.
2413 (rearrange_dict) Interface changed, rewritten.
2414 (cmd_modify_vars) Deal with modified struct var_modification, much
2416 (struct var_renaming) New structure.
2417 (compare_var_renaming_by_new_name) New function.
2418 (validate_var_modification) New function.
2420 * var.h: (struct modify_vars_proc) Removed.
2421 (struct variable) Removed member p.mfv.
2423 Sat Dec 27 19:40:26 2003 Ben Pfaff <blp@gnu.org>
2425 Make EVALUATE a valid command whether we're debugging or not, so
2426 that `make check' can succeed regardless of whether debugging is
2429 * command.def: [GLOBAL_DEBUGGING] Drop the #if.
2431 * compute.c: [GLOBAL_DEBUGGING] (cmd_evaluate) Drop the #if.
2433 Sat Dec 27 19:34:40 2003 Ben Pfaff <blp@gnu.org>
2435 * apply-dict.c: (cmd_apply_dictionary) Replace a ghastly switch
2436 statement by a simple if test.
2438 * dfm.c: (dfm_get_record) Add assertion.
2440 Sat Dec 27 17:51:26 2003 Ben Pfaff <blp@gnu.org>
2442 For each file x.c, move #include "x.h" to the very top of the
2443 include list, to catch x.h failing to include the proper headers.
2445 Sat Dec 27 17:50:19 2003 Ben Pfaff <blp@gnu.org>
2447 * algorithm.c: (find) New function.
2448 (remove_equal) New function.
2449 (set_difference) New function.
2450 (adjacent_find_equal) New function.
2451 [TEST_UNIQUE] Removed test case.
2452 (copy_if) Find end test.
2454 Sat Dec 27 17:42:45 2003 Ben Pfaff <blp@gnu.org>
2456 * dictionary.c: (dict_get_case_weight) New convenience function.
2458 * aggregate.c: (accumulate_aggregate_info) Use
2459 dict_get_case_weight().
2461 * frequencies.q: (calc_general) Ditto.
2462 (calc_integer) Ditto.
2465 * t-test.q: (groups_calc) Ditto.
2468 Sat Dec 27 17:29:45 2003 Ben Pfaff <blp@gnu.org>
2470 * glob.c: (global var default_dict) Change from `struct
2471 dictionary' to `struct dictionary *'. All references changed.
2472 (init_glob) Initialize default_dict with dict_create().
2474 Sat Dec 27 17:06:06 2003 Ben Pfaff <blp@gnu.org>
2476 struct dictionary now made opaque. All related functions:
2478 * get.c: (rename_variables) Removed.
2479 (dict_delete_run) Removed.
2481 * temporary.c: (copy_variable) Removed.
2482 (new_dictionary) Removed.
2483 (save_dictionary) Removed.
2484 (restore_dictionary) Removed.
2485 (free_dictionary) Removed.
2487 * vars-atr.c: (clear_default_dict) Removed.
2488 (find_variable) Removed.
2489 (find_dict_variable) Removed.
2490 (create_variable) Removed.
2491 (delete_variable) Removed.
2492 (common_init_stuff) Removed.
2493 (init_variable) Removed. Updating of inp_init moved into
2494 cmd_end_input_program().
2495 (replace_variable) Removed.
2496 (rename_variable) Removed.
2497 (clear_variable) Removed.
2498 (dup_variable) Removed.
2500 * vars-prs.c: (is_varname) Removed.
2501 (is_dict_varname) Removed.
2502 (fill_all_vars) Removed.
2504 * vector.c: (find_vector) Removed.
2506 * weight.c: (stop_weighting) Removed.
2508 * dictionary.c: New file.
2509 (dict_create) New, replaces new_dictionary().
2510 (dict_clone) New, replaces save_dictionary() and
2511 restore_dictionary().
2512 (dict_clear) New, replaces clear_default_dict().
2513 (dict_destroy) New, replaces free_dictionary().
2514 (dict_get_var_cnt) New function, replaces references to
2516 (dict_get_var) New function, replaces references to dict->var[i].
2517 (dict_get_vars) New function, replaces fill_all_vars().
2518 (dict_create_var) New, replaces create_variable(). Interface
2519 drops `type' parameter, using a zero `width' to designate numeric.
2520 (dict_clone_var) New, replaces dup_variable().
2521 (dict_rename_var) New, replaces rename_variable().
2522 (dict_lookup_var) New, replaces find_variable(),
2523 find_dict_variable(), is_varname().
2524 (dict_contains_var) New function.
2525 (compare_variable_dblptrs) New function.
2526 (dict_delete_var) New function, replaces clear_variable().
2527 (dict_delete_vars) New function, replaces dict_delete_run().
2528 (dict_reorder_vars) New function.
2529 (dict_rename_vars) New function, replaces rename_variables().
2530 (dict_get_weight) New function, replaces reading dict->weight_var.
2531 (dict_set_weight) New function, replaces writing dict->weight_var
2532 or calling stop_weight(dict).
2533 (dict_get_filter) New function, replaces reading dict->filter_var.
2534 (dict_set_filter) New function, replaces writing dict->filter_var.
2535 (dict_get_case_limit) New function, replaces reading dict->N.
2536 (dict_set_case_limit) New function, replaces writing dict->N.
2537 (dict_get_value_cnt) New function, replaces reading dict->nval.
2538 (dict_compact_values) New function, replaces a loop that was
2539 replicated in several places.
2540 (dict_get_split_vars) New function, replaces reading dict->splits.
2541 (dict_get_split_cnt) New function, replaces reading
2543 (dict_set_split_vars) New function, replaces writing dict->splits.
2544 (dict_get_label) New function, replaces reading dict->label.
2545 (dict_set_label) New function, replaces writing dict->label.
2546 (dict_get_documents) New function, replaces reading
2548 (dict_set_documents) New function, replaces writing
2551 All references to above functions updated.
2553 * aggregate.c: (cmd_aggregate) Copy file label and documents from
2554 old dictionary to new by hand, because dict_create() can't do it
2555 itself. Use dict_set_documents(), dict_set_split_vars().
2557 * temporary.c: (cancel_temporary) Also set temp_dict to NULL after
2558 calling dict_destroy().
2560 * data-list.c: (dls_var_spec) Remove `type' member, replace by
2562 (fixed_parse_compatible) Some slightly nontrivial changes for
2564 (dump_fmt_list) Ditto.
2567 * file-type.c: (create_col_var) Ditto.
2569 * get.c: (cmd_get) Use dict_compact_values() instead of a loop.
2570 (trim_dictionary) Use dict_delete_vars(), dict_reorder_vars().
2571 (rename_variables) Use dict_rename_vars().
2572 (mtf_merge_dictionary) Use dict_get_documents(),
2573 dict_set_documents(), dict_compact_values().
2575 * pfm-read.c: (read_variables) Deal with changes to weighting.
2577 * q2c.c: (dump_parser) Use dict_lookup_var() instead of
2578 is_varname() in output code.
2580 * sfm-read.c: (read_header) Use dict_create(), dict_set_label(),
2581 other dictionary functions.
2583 * title.c: (add_document_line) Use dict_get_documents(),
2584 dict_set_documents().
2586 * vars-atr.c: (discard_variables) Use dict_clear(default_dict),
2587 reset default_handle by hand. dict_clear() will clear vectors so
2588 there's no need for that by hand.
2590 * vfm.c: (close_active_file) Move call to finish_compaction()
2591 earlier, so that we can do the compaction as a single step using
2592 dict_compact_values(). Use dict_clear_vectors().
2593 (finish_compaction) Use dict_delete_var(), dict_compact_values().
2595 Some functions don't have replacements:
2597 * vars-atr.c: (force_create_variable) Removed. All references
2598 updated to dict_create_var() followed by an assertion.
2599 (force_dup_variable) Removed. All references updated to
2600 dict_clone_var() followed by an assertion.
2602 * weight.c: (update_weighting) Removed. No longer necessary, so
2603 all references removed.
2605 Sat Dec 27 16:43:01 2003 Ben Pfaff <blp@gnu.org>
2609 * aggregate.c: Eliminate separation of weighted and unweighted
2610 case. It made the code too obscure and I doubt it was actually
2611 faster. Instead, all code uses the "weighted" code, because
2612 that's a generalization of the "unweighted" code.
2615 (parse_aggregate_functions) No need to set FWEIGHT.
2616 (accumulate_aggregate_info) Get rid of FWEIGHT cases.
2617 (dump_aggregate_info) Ditto.
2618 (initialize_aggregate_info) No need for special plain_function
2619 that gets rid of FWEIGHT option.
2621 * aggregate.c: Get rid of approximations.
2622 (accumulate_aggregate_info) Don't use approx_gt(), approx_lt(),
2624 (aggregate_single_case) Don't use approx_ne().
2626 Sat Dec 27 16:19:36 2003 Ben Pfaff <blp@gnu.org>
2628 * ascii.c (ascii_line_width): Dead code, removed.
2630 * postscript.c (ps_line_width): Ditto.
2632 * q2c.c (xrealloc): Ditto.
2634 * count.c (internal_cmd_count): Ditto.
2636 * means.q (validate_dependent_endpoint): Ditto.
2638 * set.q: (cmd_gset) Ditto.
2640 * weight.c: [0] (weight_trns_proc) Ditto.
2642 Sat Dec 27 16:18:16 2003 Ben Pfaff <blp@gnu.org>
2644 Make the code -Wmissing-prototypes clean.
2646 * Makefile.am (version.c): Add #include "version.h".
2648 * ascii.c: (ascii_open_global) Make static.
2649 (ascii_close_page) Ditto.
2650 (ascii_font_sizes) Ditto.
2651 (ascii_postopen_driver) Ditto.
2652 (ascii_close_driver) Ditto.
2653 (ascii_option) Ditto.
2654 (ascii_open_page) Ditto.
2655 (ascii_line_horz) Ditto.
2656 (ascii_line_vert) Ditto.
2657 (ascii_line_intersection) Ditto.
2659 (ascii_polyline_begin) Ditto.
2660 (ascii_polyline_point) Ditto.
2661 (ascii_polyline_end) Ditto.
2662 (ascii_text_set_font_by_name) Ditto.
2663 (ascii_text_set_font_by_position) Ditto.
2664 (ascii_text_set_font_by_family) Ditto.
2665 (ascii_text_get_font_name) Ditto.
2666 (ascii_text_get_font_family) Ditto.
2667 (ascii_text_set_size) Ditto.
2668 (ascii_text_get_size) Ditto.
2669 (ascii_text_metrics) Ditto.
2670 (ascii_text_draw) Ditto.
2671 (ascii_close_page) Ditto.
2673 * cmdline.h: New header for parse_command_line(). Used where
2676 * command.c: Move prototypes for cmd_*() functions to command.h.
2678 * command.h: Prototypes for cmd_*() functions moved here from
2681 * crosstabs.q: (gamma_int) Ditto.
2683 * file-handle.h: Add fh_init_files() prototype.
2685 * getline.c: (welcome) Ditto.
2687 * glob.h: New header for init_glob(). Used where appropriate.
2689 * hash.c: (comparison_helper) Ditto.
2691 * html.c: (html_open_global) Ditto.
2692 (html_close_global) Ditto.
2693 (html_preopen_driver) Ditto.
2694 (html_postopen_driver) Ditto.
2695 (html_close_driver) Ditto.
2696 (html_option) Ditto.
2697 (html_open_page) Ditto.
2698 (html_close_page) Ditto.
2699 (html_submit) Ditto.
2701 * inpt-pgm.c: (input_program_source_read) Ditto.
2703 * output.c: (find_defn_value) Ditto.
2704 (destroy_list) Ditto.
2706 * pfm-read.c: (read_int) Ditto.
2708 * postscript.c: (ps_open_global) Ditto.
2709 (ps_close_global) Ditto.
2710 (ps_font_sizes) Ditto.
2711 (ps_preopen_driver) Ditto.
2712 (ps_postopen_driver) Ditto.
2713 (ps_close_driver) Ditto.
2715 (ps_open_page) Ditto.
2716 (ps_close_page) Ditto.
2717 (ps_line_horz) Ditto.
2718 (ps_line_vert) Ditto.
2719 (ps_line_intersection) Ditto.
2721 (ps_polyline_begin) Ditto.
2722 (ps_polyline_point) Ditto.
2723 (ps_polyline_end) Ditto.
2724 (ps_text_set_font_by_name) Ditto.
2725 (ps_text_set_font_by_position) Ditto.
2726 (ps_text_set_font_family) Ditto.
2727 (ps_text_get_font_name) Ditto.
2728 (ps_text_get_font_family) Ditto.
2729 (ps_text_set_size) Ditto.
2730 (ps_text_get_size) Ditto.
2731 (ps_text_metrics) Ditto.
2732 (ps_text_draw) Ditto.
2734 * q2c.c: (finish_up) Ditto.
2743 (find_symbol) Ditto.
2746 (force_string) Ditto.
2748 (match_token) Ditto.
2751 (parse_setting) Ditto.
2752 (parse_specifier) Ditto.
2753 (parse_specifiers) Ditto.
2754 (parse_subcommand) Ditto.
2755 (dump_specifier_vars) Ditto.
2757 (make_identifier) Ditto.
2758 (dump_declarations) Ditto.
2759 (dump_specifier_init) Ditto.
2760 (dump_vars_init) Ditto.
2762 (dump_specifier_parse) Ditto.
2763 (dump_subcommand) Ditto.
2764 (dump_parser) Ditto.
2765 (dump_header) Ditto.
2767 (recognize_directive) Ditto.
2769 * recode.c: (string_to_long) Ditto.
2771 * repeat.c: (find_DO_REPEAT_substitution) Ditto.
2773 * repeat.h: New header for perform_DO_REPEAT_substitutions, used
2776 * sort.c: (sort_stream_read) Ditto.
2777 (sort_stream_mode) Ditto.
2779 Fri Dec 19 23:35:04 2003 Ben Pfaff <blp@gnu.org>
2781 * algorithm.c (binary_search): Fix comparison.
2783 Fri Dec 19 23:27:45 2003 Ben Pfaff <blp@gnu.org>
2785 * algorithm.c: (binary_search) Fix assertion.
2787 Fri Dec 19 21:31:48 2003 Ben Pfaff <blp@gnu.org>
2789 * sysfile-info.c: (compare_vectors_by_name) Rewrite.
2791 Fri Dec 19 21:30:24 2003 Ben Pfaff <blp@gnu.org>
2793 * sort.c: (compare_case_lists) Rewrite.
2795 Fri Dec 19 16:44:22 2003 Ben Pfaff <blp@gnu.org>
2797 * quicksort.c: Removed (not used).
2799 * quicksort.h: Removed (not used).
2801 * sort.c: Removed blp_quicksort() prototype.
2803 Fri Dec 19 16:42:13 2003 Ben Pfaff <blp@gnu.org>
2805 * postscript.c: (int_2_compare) Rewrite.
2806 (compare_line) Rewrite.
2808 Fri Dec 19 16:38:35 2003 Ben Pfaff <blp@gnu.org>
2810 * matrix-data.c (compare_factors) Use lexicographical_compare()
2812 (compare_doubles) New function.
2814 * algorithm.c: (lexicographical_compare) New algorithm.
2816 Fri Dec 19 16:23:45 2003 Ben Pfaff <blp@gnu.org>
2818 * matrix-data.c (compare_variables_by_mxd_vartype): Rewrite.
2820 Fri Dec 19 15:54:45 2003 Ben Pfaff <blp@gnu.org>
2822 * expr-prs.c: (cmp_func) Removed.
2823 (parse_function) Use binary_search() algorithm.
2824 (compare_functions) New function.
2825 (init_func_tab) Use sort() algorithm.
2827 * algorithm.c: (binary_search) New algorithm.
2829 Fri Dec 19 15:50:45 2003 Ben Pfaff <blp@gnu.org>
2831 * descript.q: (display) Use sort() algorithm instead of qsort().
2832 (compare_func) Removed.
2833 (descriptives_compare_variables) New function.
2835 Fri Dec 19 15:08:38 2003 Ben Pfaff <blp@gnu.org>
2837 Get rid of AVL trees. Hashes are more appropriate for everything
2840 * Makefile.am: (pspp_SOURCES) Remove avl.c, avl.h.
2846 Fri Dec 19 14:33:31 2003 Ben Pfaff <blp@gnu.org>
2848 Much code can be clarified by using C++ STL-like algorithms. Not
2849 all uses of these algorithms are listed below, only the ones where
2850 the change to an algorithm was the only change of interest.
2852 * Makefile.am: (pspp_SOURCES) Add algorithm.c, algorithm.h.
2854 * algorithm.c: New file.
2856 * algorithm.h: New file.
2858 * modify-vars.c: (static var forward) Removed.
2859 (static var positional) Removed.
2860 (compare_variables) Removed.
2861 (struct ordering) New.
2862 (cmd_modify_vars) Use sort() algorithm.
2863 (compare_variables_given_ordering) New function.
2864 (rearrange_dict) Use sort() algorithm.
2866 * sysfile-info.c: (cmd_display) Use sort() algorithm.
2867 (cmp_var_by_name) Removed.
2869 Fri Dec 19 14:26:17 2003 Ben Pfaff <blp@gnu.org>
2871 Make file handles use a hash table.
2873 * file-handle.q: (files) Change to hash table, make static.
2874 (cmd_file_handle) Use hash table functions.
2875 (fh_get_handle_by_filename) Ditto.
2876 (fh_get_handle_by_name) Ditto.
2877 (hash_file_handle) New function.
2878 (cmp_file_handle) Rewrite.
2879 (fh_init_files) Use hash table functions.
2881 Fri Dec 19 14:24:38 2003 Ben Pfaff <blp@gnu.org>
2883 Clean up FREQUENCIES.
2885 * Makefile.am: (pspp_SOURCES) Remove frequencies.g.
2887 * frequencies.q: Remove a lot of old #if'd out code at the end.
2888 (internal_cmd_frequencies) Use calc() instead of calc_no_weight()
2889 or calc_weight(). Initialize percentile_values.
2890 (calc) New function based on calc_weight() from frequencies.g.
2891 (precalc) Use hash functions.
2892 (static var comparison_func) Removed.
2893 (static var comparison_param) Removed.
2894 (comparison_helper) Removed.
2895 (get_freq_comparator) New function.
2896 (not_missing) New function.
2898 (postprocess_freq_tab) Use hash table functions, algorithms,
2899 get_freq_comparator(). Rewrite.
2900 (cleanup_freq_tab) Rephrase.
2901 (add_percentile) Clean up spacing.
2902 (hash_value_numeric) New function.
2903 (hash_value_alpha) New function.
2904 (compare_value_numeric_a) Rewrite.
2905 (compare_value_alpha_a) Rewrite.
2906 (compare_value_numeric_d) Rewrite.
2907 (compare_value_alpha_d) Rewrite.
2908 (compare_freq_numeric_a) Rewrite.
2909 (compare_freq_alpha_a) Rewrite.
2910 (compare_freq_numeric_d) Rewrite.
2911 (compare_freq_alpha_d) Rewrite.
2912 (calc_stats) Clean up mode, percentiles, max.
2913 (dump_statistics) Clean up spacing.
2915 * frequencies.g: Removed.
2917 * var.h: (struct freq_tab) Change `data' to hash table.
2919 Fri Dec 19 14:15:46 2003 Ben Pfaff <blp@gnu.org>
2921 * file-handle.h: Remove declaration of global variable `files',
2922 which wasn't used anywhere.
2924 * postscript.c: (add_encoding) Remove superfluous cast.
2927 * sfm-read.c: [linux] (bswap_int32) Drop ntohl() non-portable
2930 * temporary.c: [0] (display_tree) Removed.
2932 Fri Dec 19 14:13:04 2003 Ben Pfaff <blp@gnu.org>
2934 Implement a new random number generator based on the alleged RC4
2937 * expr-evl.c: (expr_evaluate) Use rng_get_double_normal() instead
2940 * random.c: [!HAVE_GOOD_RANDOM] (real_rand) Removed.
2941 [!HAVE_GOOD_RANDOM] (real_srand) Removed.
2943 (static var V[]) Removed.
2944 (static var Y) Removed.
2945 (static var X2) Removed.
2946 (setup_randomize) Removed.
2948 (rand_uniform) Removed.
2949 (rand_normal) Removed.
2950 (struct rng) New structure.
2951 (rng_create) New function.
2952 (rng_destroy) New function.
2953 (swap_byte) New static function.
2954 (rng_seed) New function.
2955 (rng_get_bytes) New function.
2956 (rng_get_int) New function.
2957 (rng_get_unsigned) New function.
2958 (rng_get_double) New function.
2959 (rng_get_double_normal) New function.
2960 (pspp_rng) New function.
2962 * random.h: Sync up to random.c.
2964 * sample.c: (struct sample_trns) Make `frac' unsigned and a
2965 fraction of UINT_MAX, not 65536.
2966 (cmd_sample) Use rng_get_unsigned(), rng_get_double(), UINT_MAX
2969 * vfm.c: (open_active_file) No need to call setup_randomize() any
2972 Fri Dec 19 12:05:56 2003 Ben Pfaff <blp@gnu.org>
2974 Change dictionary name indexes to use hash tables instead of AVL
2977 * crosstabs.q: (free_var_dict) Use hash tables.
2978 (crs_custom_tables) Ditto.
2979 (calc_general) Ditto.
2980 (compare_table_entry) Rewrite.
2981 (enum_var_values) Reorder parameters. All references updated.
2984 * get.c: (rename_variable) Use hash tables.
2985 (mtf_merge_dictionary) Ditto.
2987 * glob.c: (init_glob) Use hash tables.
2988 (cmp_variable) Removed.
2990 * means.q: (mns_custom_tables) Use hash tables.
2992 * modify-vars.c: (rearrange_dict) Use hash tables.
2994 * rename-vars.c: (cmd_rename_variables) Use hash tables.
2996 * sfm-read.c: (read_header) Use hash tables.
2997 (read_variables) Ditto.
2999 * temporary.c: (new_dictionary) Use hash tables.
3000 (save_dictionary) Ditto.
3001 (restore_dictionary) Ditto.
3003 * var.h: (struct dictionary) Change AVL tree `var_by_name' into
3004 hash table `name_tab'.
3006 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed.
3007 [DEBUGGING] (dump_var_tree) Removed.
3008 (find_variable) Use hash tables.
3009 (find_dict_variable) Ditto.
3010 (common_init_stuff) Ditto.
3011 (rename_variable) Ditto.
3012 (clear_variable) Ditto. Also, remove debug code.
3013 (dup_variable) Use hash tables.
3015 * vars-prs.c: (fill_all_vars) Use hash tables.
3016 (is_dict_varname) Ditto.
3017 (parse_dict_variable) Ditto.
3019 Fri Dec 19 11:46:23 2003 Ben Pfaff <blp@gnu.org>
3021 Change value labels to use hash tables instead of AVL trees, and
3022 change value labels into an ADT.
3024 * Makefile.am: (pspp_SOURCES) Add value-labels.c, value-labels.h.
3026 * value-labels.c: New file.
3028 * value-labels.h: New file.
3030 * apply-dict.c: (cmd_apply_dictionary) Use value label ADT.
3031 Get rid of a stupid use of goto.
3033 * autorecode.c: (compare_alpha_value) Rewrite.
3034 (hash_alpha_value) Ditto.
3035 (compare_numeric_value) Rewrite.
3036 (hash_numeric_value) Ditto.
3038 * frequencies.q: (dump_full) Use value label ADT.
3040 * pfm-read.c: (read_value_label) Use value label ADT.
3042 * pfm-write.c: (write_value_labels) Use value label ADT.
3044 * sfm-read.c: (read_variables) Use value label ADT.
3045 (read_value_labels) Rewrite.
3047 * sfm-write.c: (write_value_labels) Rewrite.
3049 * sysfile-info.c: (cmd_sysfile_info) Use value label ADT.
3050 (display_variables) Ditto.
3051 (describe_variable) Ditto.
3053 * t-test.q: (print_t_groups) Use value label ADT.
3055 * temporary.c: (copy_variable) Use value label ADT.
3056 (free_dictionary) Ditto.
3058 * val-labs.c: (verify_val_labs) Use value label ADT.
3060 (debug_print) Ditto.
3061 (val_lab_cmp) Removed.
3062 (inc_ref_count) Removed.
3063 (copy_value_labels) Removed.
3065 * var.h: (struct value_label) Removed.
3066 (struct variable) Change AVL tree `val_lab' into hash table
3069 * vars-atr.c: (init_variable) Use value label ADT.
3070 (clear_variable) Ditto.
3071 (free_value_label) Removed.
3072 (free_val_lab) Removed.
3073 (get_val_lab) Removed.
3074 (compare_variables) New function.
3075 (hash_variable) New function.
3077 * vfm.c: (dump_splits) Use value label ADT.
3079 Fri Dec 19 11:18:11 2003 Ben Pfaff <blp@gnu.org>
3081 Add to the hash table interface.
3083 * hash.c: (hsh_hash_bytes) Add assertion.
3084 (hsh_hash_string) Ditto.
3088 (hsh_create) Ditto. Also make minimum `size'.
3089 (hsh_destroy) Rephrase.
3090 (sort_nulls_last) Removed.
3091 (not_null) New function.
3093 (comparison_helper) Ditto.
3094 (hsh_sort) Rewritten.
3095 (hsh_data_copy) New function.
3096 (hsh_sort_copy) Ditto.
3098 (hsh_replace) Ditto.
3099 (hsh_hash_double) Ditto.
3100 (hsh_delete) Fix stupid bug.
3102 Thu Dec 18 12:27:03 WAST 2003 John Darrington <john@darrington.wattle.id.au>
3103 * added a calculation of the mode to FREQUENCIES
3105 Wed Dec 17 12:53:01 WAST 2003 John Darrington <john@darrington.wattle.id.au>
3107 * moved (un)defs of DEBUGGING to config.h
3109 Mon Dec 15 21:35:59 2003 Ben Pfaff <blp@gnu.org>
3111 * groff-font.c: (add_kern) Fix indentation.
3112 (add_kern) Use & instead of % to take power-of-2 modulus.
3113 (font_get_kern_adjust) Likewise.
3115 Fri Dec 12 23:54:37 2003 Ben Pfaff <blp@gnu.org>
3117 * autorecode.c: (recode) Replace stupid use of memcpy() by
3119 (hash_alpha_value) Use hsh_hash_bytes(). Get rid of nasty casts.
3120 (hash_numeric_value) Ditto.
3121 (autorecode_proc_func) pool_strdup() was wrong here because the
3122 source string was not null-terminated. Use new pool_strndup()
3125 * crosstabs.q: (enum_var_values) Remove superfluous and bizarre
3126 use of hsh_iterator_init().
3128 * data-in.c: (parse_N) Initialize i->v->f.
3130 * flip.c: (cmd_flip) Use memmove(), not memcpy(), to copy
3133 * groff-font.c: Use power-of-2 hash table sizes, not prime.
3134 (groff_read_font) Don't call hsh_next_prime(). Don't call
3136 (static var hash) Remove `size_p', `max_used' members.
3137 (font_char_name_to_index) Don't call hsh_next_prime(). Use
3138 hsh_hash_string() instead of hashpjw(), & instead of %.
3139 (default_font) Don't call hsh_next_prime().
3141 * pool.c: (pool_strndup) New function.
3142 (pool_strdup) Reimplement in terms of pool_strndup.
3144 * postscript.c: (hash_font_entry) Use hsh_hash_string(). Get rid
3146 (hash_ps_encoding) Use hsh_hash_string().
3147 (hash_ps_combo) Use hsh_hash_string(), hsh_hash_int().
3148 (hash_filename2font) Use hsh_hash_string().
3150 * som.c: Add #include <stdlib.h>.
3152 * tab.c: (tab_destroy) Don't set t->container after freeing `t'
3153 (by destroying its pool).
3155 Fri Dec 12 23:18:59 2003 Ben Pfaff <blp@gnu.org>
3157 Miscellaneous hash table code cleanup:
3159 * hash.h: (struct hsh_table) Moved into hash.c.
3160 (hsh_count) Ditto, and transformed into function.
3161 (hsh_compare_func) New typedef, used for defining otherwise-long
3162 function types here and in hash.c
3163 (hsh_hash_func) Ditto.
3164 (hsh_free_func) Ditto.
3166 * hash.c: (struct hsh_table) Renamed `n' to `used', `m' to `size',
3167 `table' to `entries'. Removed `mp'. All references updated.
3168 (hsh_clear) Don't shrink entries array; if the hash was this big
3169 once, it probably will be again.
3170 (hsh_rehash) Made static.
3171 (force_hsh_insert) Renamed hsh_force_insert.
3172 (force_hsh_find) Renamed hsh_force_find.
3174 Made hash table sizes powers of 2, because that's fine with any
3175 reasonable hash function and because taking a power-of-2 modulus
3176 is faster than any other:
3178 (hsh_prime_tab) Removed;
3179 (hsh_next_prime) Ditto.
3180 (next_power_of_2) New function.
3181 (hsh_create) Use next_power_of_2.
3182 (hsh_rehash) Use & instead of %.
3184 Cleaned up hsh_sort:
3186 (internal_comparison_fn) Removed.
3187 (sort_nulls_last) New function.
3188 (hsh_sort) Removed second parameter, switched to using the new
3189 quicksort() function from quicksort.h to avoid using nasty need
3190 for static variables with qsort(). All references updated.
3192 Changed the hash functions offered, because there are better hash
3193 functions than the ones we had, and cleaned up the names to boot:
3195 * hash.c: (hashpjw_d) Removed.
3197 (hsh_hash_bytes) New function.
3198 (hsh_hash_string) New function.
3199 (hsh_hash_int) New function.
3201 Improved the hash table iteration interface:
3203 * hash.h: (hsh_iterator_init) Removed.
3204 (struct hsh_iterator) Removed `init' member, change `next' to
3207 * hash.c: (hsh_foreach) Removed. All references updated to use
3208 hsh_first/hsh_next instead.
3209 (hsh_first) New function. Notably, unlike hsh_foreach() it does
3210 not treat a null pointer as an empty hash table.
3211 (hsh_next) New function.
3213 Made deletion possible, though slow:
3215 * hash.c: (locate_matching_entry) New function.
3216 (hsh_find) Use locate_matching_entry().
3217 (hsh_delete) New function also using locate_matching_entry().
3218 (hsh_force_delete) New function.
3220 Fri Dec 12 23:16:10 2003 Ben Pfaff <blp@gnu.org>
3222 * quicksort.c: New file implementing a sort routine with a
3223 interface better than qsort() because it passes a user-provided
3224 parameter to the sort routine.
3226 * Makefile.am: Add quicksort.c, quicksort.h.
3228 Fri Dec 12 13:31:58 2003 Ben Pfaff <blp@gnu.org>
3230 * All source files: Get rid of nasty special cases for Checker,
3231 which is pretty obsolete now.
3233 Thu Dec 11 21:38:24 WST 2003 John Darrington <john@darrington.wattle.id.au>
3235 * Fixed a bug apparent when using the FREQUENCIES command with the
3236 html driver. The html driver was incorrectly trying to display
3239 Sun Jan 2 21:40:13 2000 Ben Pfaff <blp@gnu.org>
3241 * Makefile.am: Reorganized. Put locale dir in version.c instead
3242 of passing it to each compile command. Only put local gmp libs in
3243 LD_ADD if not installed on system. Remove `boast' target.
3245 * All source files: struct and union typedefs eliminated.
3246 `sizeof type' replaced by `sizeof object' where practical. Moved
3247 `unused' qualifiers from start to end of declarations for gcc
3248 2.7.2 compatibility. Change `while (1)' to `for (;;)'. Made
3249 assertions on pointers strictly compliant. Removed _ prefixes on
3250 some function parameter names.
3252 * alloc.c: New source file, containing these external linkage
3253 functions removed from common.c: xmalloc, xcalloc, xrealloc,
3260 * ascii.c: Migrated from arenas to pools.
3261 (struct ascii_driver_ext) ops[], box[], fonts[] changed from
3262 c_string to len_string. All references changed.
3263 (ascii_option) Signature changed to comply to new output.c
3265 (count_fancy_chars) Removed.
3266 (delineate) Removed support for rich text.
3267 (ascii_text_metrics) Ditto.
3269 (output_shorts) Change `box', `off', `on' from c_string to
3270 len_string. Change `remaining' from int to size_t.
3271 (ascii_close_page) Make page numbering less haphazard.
3273 * autorecode.c: Migrate from arenas to pools.
3275 * avl.c: Migrate from arenas to pools. Synch from libavl 1.4.0.
3277 * bitvector.h: New file containing these macros from misc.h:
3278 SET_BIT, CLEAR_BIT, SET_BIT_TO, TEST_BIT, BIT_INDEX.
3280 * command.c: (struct command) cmd1, cmd2, cmd3 members changed to
3281 word[3]. ncmd removed.
3282 (var empty_string) Removed.
3283 (var cmd_table) Declaration updated.
3284 (var cmdtab) Removed.
3285 (cmp_command) Removed.
3286 (split_words) Rewritten to use strtok_r().
3287 (init_cmd_parser) Renamed cmd_init(). Rewritten.
3288 (find_command) Removed.
3289 (FILE_TYPE_okay) Rewritten.
3290 (cmd_parse) Rewritten. Semantics of the return value of command
3291 handlers has changed: they must now return one of the new CMD_*
3292 enumerals, rather than a magic value. This meant that all
3293 commands had to be modified, and they were.
3294 (figure_out_command) New function.
3296 * command.def: Add CORRELATIONS, PEARSON CORRELATIONS. Add
3297 #defines for INIT, INPU, etc.
3299 * command.h: New CMD_* enum series.
3300 (cur_proc) Make const char *, not char *.
3301 (cmd_init) Prototype.
3304 * common.c: Removed.
3306 * common.h: Removed.
3308 * correlations.q: New file.
3310 * crosstabs.q: Migrate from arenas to pools. Migrate to new-style
3312 (custom_tables) Renamed crs_custom_tables().
3313 (custom_variables) Renamed crs_custom_variables().
3314 (calc_integer) Add in some `const' qualifiers.
3315 (table_value_missing) Change from a_string to len_string.
3316 (float_M_suffix) Change from a_string to len_string.
3318 * data-in.c: Rewritten. All references to
3319 parse_string_as_format() changed to data_in().
3321 * data-in.h: New file.
3323 * data-list.c: Change DLS_* from #define's to enums. Move from
3324 rpd_msg() to tmsg().
3325 (RPD_ERR) New #define.
3326 (do_reading) Change dfm_push_cust() to dfm_push(), pop_cust() to
3328 (read_from_data_list_fixed) Change from old
3329 parse_string_as_format() to new data_in().
3330 (read_from_data_list_free) Ditto.
3331 (read_from_data_list_list) Ditto.
3332 (cmd_repeating_data) Modify approach to checking for end of
3335 (rpd_parse_record) Change from old parse_string_as_format() to new
3336 data_in(). Change from old convert_format_to_string() to new
3338 (read_one_set_of_repetitions) Change dfm_push_cust() to
3339 dfm_push(), pop_cust() to dfm_pop().
3341 * data-out.c: Rewritten. All references to
3342 convert_format_to_string() changed to data_out().
3344 * descript.q: Migrate to new q2c.
3345 (cmd_descriptives) Removed.
3346 (internal_cmd_descriptives) Renamed cmd_descriptives ().
3347 (custom_variables) Renamed dsc_custom_variables().
3349 * dfm.c: (struct dfm_fhuser_ext) `ln' removed. All references
3351 (open_file_r) Initialize h->where.line_number. Migrate to new
3353 (open_file_w) Initialize h->where.line_number.
3354 (read_record) Change from ext->ln to h->where.line_number.
3355 Migrate to struct string.
3356 (dfm_put_record) Rephrased.
3357 (dfm_push_cust) Renamed dfm_push(), rewritten.
3358 (dfm_pop) New function.
3360 * error.c: All references updated.
3361 (glob var error_count) Renamed err_err_count.
3362 (glob var warning_count) Renamed err_warning_count.
3363 (glob var error_already_flagged) Renamed err_already_flagged.
3364 (glob var verbosity) Renamed err_verbosity.
3365 (glob var cust_fn) Removed.
3366 (glob var cust_ln) Removed.
3367 (static var file_loc) New.
3368 (static var nfile_loc) New.
3369 (static var mfile_loc) New.
3370 (tmsg) New function.
3371 (push_cust) Removed.
3374 (static var terminating) Removed.
3375 (failure) Renamed err_failure().
3376 (hcf) Renamed err_hcf().
3377 (err_push_file_locator) New function.
3378 (err_pop_file_locator) New function.
3379 (err_location) New function.
3380 (check_error_count) Renamed err_check_count().
3381 (vmsg) Renamed err_vmsg(). Interface changed.
3382 (verbose_msg) Removed.
3383 (err_cond_fail) New function.
3384 (error_break) Renamed err_break().
3386 * error.h: All references updated.
3387 (enum MSG_CLASS_COUNT) Renamed ERR_CLASS_COUNT.
3388 (enum ERR_CLASS_MASK, ERR_VERBOSITY_SHIFT, ERR_VERBOSITY_MASK)
3390 (struct file_locator) New.
3392 (macro verbose_msg) Removed.
3393 (macro cond_fail) Removed.
3395 * expr-opt.c: (evaluate_tree) sizeof(char) == 1.
3397 * expr-prs.c: Reorganized. All references updated.
3398 (exprtypename) Renamed expr_type_name().
3399 (typename) Renamed type_name().
3400 (free_expression) Renamed expr_free().
3401 (parse_expression) Renamed expr_parse(). Uses new type_check()
3403 (init_functab) Renamed init_func_tab().
3404 (type_check) New function.
3405 (parse_or) Rewritten to use new allocate_nonterminal() and
3406 append_nonterminal_arg() functions.
3409 (parse_rel) Ditto. Also simplified logic.
3414 (SYSMIS_func) Ditto.
3415 (VALUE_func) Rephrased.
3416 (CONCAT_func) Fix memory leak by replacing free by free_node on
3418 (generic_str_func) Ditto.
3419 (parse_function) Ditto. Also rephrasings. Uses bsearch() to find
3421 (allocate_nonterminal) New function.
3422 (append_nonterminal_arg) New function.
3423 (static func_tab[]) Now at file level.
3425 (init_func_tab) Moved. Now just uses qsort() to sort func_tab[].
3427 * expr.h: (enum series OP_*) Moved to exprP.h.
3428 (OP_* defines) Ditto.
3429 (struct op_desc) Ditto.
3430 (global ops[]) Ditto.
3431 (struct num_con_node) Ditto.
3432 (struct str_con_node) Ditto.
3433 (struct var_node) Ditto.
3434 (struct lag_node) Ditto.
3435 (struct casenum_node) Ditto.
3436 (struct nonterm_node) Ditto.
3437 (union any_node) Members renamed.
3438 (struct sys_node) Removed.
3439 (struct val_node) Removed.
3440 (operator typedef) Removed.
3441 (typedef exprtype) Removed.
3442 (enum series EX_*) Moved to exprP.h.
3443 (struct expression) Ditto. Also renamed a lot of the members.
3444 (PXP_* defines) Changed to enums.
3445 (free_node prototype) Moved to exprP.h.
3447 * file-handle.h: (struct file_handle) New member `where'.
3449 * file-handle.q: Migrated to new q2c format.
3450 (prepend_current_directory) Removed (dead code).
3451 (cmd_file_handle) Incorporated all of internal_cmd_file_handle().
3452 (fh_get_handle_by_filename) Removed dead code.
3453 Set new `where' member.
3455 * file-type.c: (file_type_source_read) References to
3456 parse_string_as_format() changed to data_in().
3457 dfm_push_cust()/pop_cust() changed to dfm_push()/dfm_pop().
3459 * filename.c: All references updated.
3460 (init_filename) Renamed fn_init().
3461 (expand_line) Removed.
3462 (macro EXPAND_LINE) Removed.
3463 (interp_vars) Renamed fn_interp_vars(). Now uses st_*() instead
3464 of custom functions.
3465 (gnu_getcwd) Renamed fn_get_cwd(), rewritten.
3466 (tilde_expand) Renamed fn_tilde_expand(), uses ds_*().
3467 (normalize_filename) Renamed fn_normalize().
3468 (search_path) Renamed fn_search_path(), rewritten.
3469 (prepend_dir) Renamed fn_prepend_dir().
3470 (blp_getenv) Renamed fn_getenv().
3471 (blp_dirname) Renamed fn_dirname().
3472 (fn_basename) New function, not used.
3473 (absolute_filename_p) Renamed fn_absolute_p().
3474 (is_special_filename) Renamed fn_special_p().
3475 (file_exists) Renamed fn_exists_p().
3476 (readlink_malloc) Renamed fn_readlink().
3477 (getenv_default) Renamed fn_getenv_default().
3478 (open_file) Renamed fn_open().
3479 (close_file) Renamed fn_close().
3480 (open_file_ext) Renamed fn_open_ext().
3481 (close_file_ext) Renamed fn_close_ext().
3483 * font.h: Migrate from arenas to pools.
3485 * format.c: (parse_format_specifier_name) Deal with ds_* strings.
3487 * frequencies.g: Migrate from arenas to pools.
3489 * frequencies.q: Migrate to new q2c version. Migrate from arenas
3492 * getline.c: All references updated.
3493 (global getl_buf) Changed from char * to struct string.
3494 (static getl_include_path) Ditto.
3495 (global getl_buf_len) Removed.
3496 (global getl_buf_size) Removed.
3497 (getl_include_path) Deal with new getl_buf, getl_include_path.
3498 (getl_uninitialize) New function.
3499 (getl_get_current_directory) Rewritten.
3500 (getl_clear_include_path) Rewritten.
3501 (getl_add_include_dir) Rewritten.
3502 (getl_add_file) Assertion fixed.
3503 (getl_add_virtual_file) Change initial value of `remaining_loops'
3505 (welcome) Rewritten.
3506 (handle_line_buffer) Make static. Change logic to make
3507 getl_add_virtual_file() change sensible. Use ds_*() strings.
3508 (getl_read_line) Use ds_*() strings. Implement SET ECHO.
3509 (getl_close_file) Moved.
3510 (getl_location) New function.
3512 * getline.h: All references updated.
3513 (macro curln) Removed.
3514 (macro curfn) Removed.
3515 (macro am_interactive) Renamed getl_am_interactive.
3516 (macro am_reading_script) Renamed getl_reading_script.
3518 * glob.c: (global fmt_parse_ignore_error) Removed.
3519 (init_glob) Use locale_dir not LOCALEDIR. Use feholdexcept() on
3520 systems that support it (C99). Turn off SET ECHO by default. No
3521 necessary julcal initialization anymore.
3523 * groff-font.c: Migrate from arenas to pools.
3524 (groff_read_font) Use err_push_file_locator().
3525 (groff_read_DESC) Ditto.
3526 (font_msg) Use tmsg().
3528 * hash.c: (hsh_sort) Fix debug code.
3529 [GLOBAL_DEBUGGING] Include stdio.h.
3531 * hash.h: (macro force_hsh_insert) Rephrase.
3533 * heap.c: Rewritten.
3535 * heap.h: Rewritten.
3537 * html.c: (html_option) Change from outp_value to struct string.
3538 (postopen) Change from curfn to getl_location().
3539 (escape_string) Remove rich-text code. Signature changed.
3540 (output_tab_table) Switch from a_string to struct len_string.
3541 Remove rich text support.
3543 * lexer.c: All references updated. Largely rewritten. Major
3544 changes listed below. Removed tagged quote support. Adapted to
3545 struct string tokstr.
3546 (global tokstr) Changed to struct string.
3547 (global tokstr_size) Removed.
3548 (global tokstr_len) Removed.
3550 (global tokint) Removed.
3551 (global toklongstr) Removed.
3552 (C* defines) Removed.
3553 (static tbl[]) Removed.
3554 (static id[]) Removed.
3555 (static une[]) Removed.
3556 (discard_line) Renamed lex_discard_line().
3557 (get_entire_line) Renamed lex_entire_line().
3558 (get_rest_of_line) Renamed lex_rest_of_line().
3559 (get_dotted_rest_of_line) Merged into lex_rest_of_line().
3560 (make_hexit) Removed.
3561 (syntax_error) Renamed lex_error(). Return value removed.
3562 (get_token_representation) Renamed lex_token_representation().
3563 (putback) Renamed lex_put_back().
3564 (putfwd) Renamed lex_put_forward().
3565 (convert_negative_to_dash) Renamed lex_negative_to_dash().
3566 (set_prog) Renamed lex_set_prog().
3567 (init_lex) Renamed lex_init().
3568 (reset_eof) Renamed lex_reset_eof().
3569 (lookahead) Renamed lex_look_ahead().
3570 (check_id) Rewritten.
3571 (yylex) Renamed lex_get(), rewritten.
3572 (lex_end_of_command) New function. Many commands were rephrased
3574 (lex_integer_p) New function. Replaces compare of tokint against
3576 (lex_integer) New function. Replaces tokint.
3577 (match_tok) Renamed lex_match().
3578 (match_id) Renamed lex_match_id().
3579 (match_int) Renamed lex_match_int().
3580 (force_match_id) Renamed lex_force_match_id(), added return value.
3581 (force_match) Renamed lex_force_match(), added return value.
3582 (force_string) Renamed lex_force_string(), added return value.
3583 (force_int) Renamed lex_force_int(), added return value.
3584 (lex_id_match_len) New function.
3585 (id_match) Renamed lex_id_match(), rewritten.
3586 (get_line) Renamed lex_get_line().
3587 (preprocess_line) Renamed lex_preprocess_line().
3588 (tokname) Renamed lex_token_name().
3589 (bin_value_func) Removed.
3590 (oct_value_func) Removed.
3591 (hex_value_func) Removed.
3592 (unexpected_eof) New function.
3593 (convert_numeric_string_to_char_string) New function.
3594 (parse_string) Rewritten, signature changed.
3595 (add_tokstr_char) Removed.
3596 (add_tokstr_unsigned) Removed.
3597 (add_tokstr_string) Removed.
3598 (parse_tagged_quote) Removed.
3599 (skip_comment) Renamed lex_skip_comment().
3601 * lexer.h: All references updated.
3602 (macro is_id1) Renamed CHAR_IS_ID1.
3603 (macro is_idn) Renamed CHAR_IS_IDN.
3604 (token names ID, NUM, STRING, STOP, ... WITH, EXP) Renamed with
3605 prefix T_: T_ID, T_NUM, T_STRING, T_STOP, ... T_WITH, T_EXP.
3606 (macro get_token) Removed.
3607 (macro id_match) Removed.
3608 (macro force_match_id) Removed.
3609 (macro force_match) Removed.
3610 (macro force_string) Removed.
3611 (macro force_int) Removed.
3612 (macro force_num) Removed.
3613 (macro force_id) Removed.
3615 * lexerP.h: Removed.
3617 * list.q: Migrated to new q2c format.
3618 (write_line) Deal with struct len_string.
3619 (write_varname) Ditto.
3620 (write_fallback_headers) Ditto.
3622 * magic.c: New file, incorporating the following global variables
3623 previously in other files: endian, second_lowest_value. And both
3624 of those are conditional on #define's.
3626 * magic.h: New file, incorporating the following global variable
3627 declarations: endian, second_lowest_value, and the following macro
3628 declarations: NOT_DOUBLE, NOT_LONG, NOT_INT.
3630 * main.c: Added declarations of pgmname, finished, curdate,
3632 (main) Call new parse_script() function.
3633 (parse_script) New function.
3634 (execute_command) New function.
3635 (dump_token) Removed.
3636 (handle_error) New function.
3638 * matrix.c: New file.
3640 * matrix.h: New file.
3642 * matrix-data.c: Migrated from arenas to pools.
3643 (mget_token) Change from parse_string_as_format() to data_in().
3645 * means.q: Migrate to new q2c.
3646 (custom_tables) Renamed mns_custom_tables().
3647 (custom_crossbreak) Renamed mns_custom_crossbreak().
3648 (custom_variables) Renamed mns_custom_variables().
3650 * mis-val.c: (static var width) Changed from `int' to `size_t'.
3651 (parse_varnames) Prototype.
3652 (parse_numeric) Rephrasings.
3653 (parse_alpha) Adapt to new struct string tokstr.
3655 * misc.c: (intlog10) Rewritten.
3657 (ansi_rand) Renamed real_rand(), moved into random.c.
3658 (ansi_srand) Renamed real_srand(), moved into random.c.
3659 (setup_randomize) Moved to random.c.
3660 (rand_uniform) Ditto.
3661 (rand_normal) Ditto.
3662 (rand_simple) Ditto.
3663 (get_config_line) Removed.
3664 (reverse) Removed (dead code).
3666 * misc.h: (macro SET_BIT) Moved to bitvector.h.
3667 (macro CLEAR_BIT) Ditto.
3668 (macro TEST_BIT) Ditto.
3669 (macro SET_BIT_TO) Ditto.
3670 (macro BIT_INDEX) Ditto.
3672 * output.c: (outp_read_devices) Move to err_push_file_locator()
3673 from push_cust(). Use struct string.
3674 (expand_op_tokstr) Removed.
3675 (static var op_tokstr) Changed to struct string.
3676 (static var op_tokstr_size) Removed.
3677 (tokener) Rephrasings. Use struct string.
3678 (parse_options) Use struct string.
3679 (destroy_driver) Fix assertion.
3680 (outp_get_paper_size) Move to err_push_file_locator().
3681 [0] Removed dead code.
3682 (outp_string_width) Move to len_string.
3684 * output.h: Comment fixes.
3685 (TAG_* enum series) Removed.
3686 (struct outp_value) Removed.
3687 (enum OUTP_T_FANCY) Removed.
3688 (struct outp_text) `s' changed from a_string to len_string.
3689 (struct outp_class) `option' change arg 3 from outp_value to
3692 * pfm-read.c: (corrupt_msg) Rewritten.
3694 * pfm-write.c: (bufwrite) Fix assertion.
3696 * pool.c: New file, reference version.
3698 * pool.h: New file, reference version.
3700 * postscript.c: (ps_font_sizes) Fix assertion.
3701 (ps_option) Change arg 3 from outp_value to struct string.
3702 Adapt to struct string.
3703 (macro output_line) Removed.
3704 (macro add_string) Removed.
3705 (output_encodings) Adapted to struct string. Moved to
3706 err_push_file_locator().
3707 (find_encoding_file) Fix assertion.
3708 (read_ps_encodings) Move to err_push_file_locator().
3709 (postopen) Use getl_location() instead of curfn.
3710 (out_text_plain) Move to len_string.
3711 (text) Ditto. Remove rich text support.
3713 * print.c: (cmd_print) Remove now-unneeded resource cleanup code.
3714 (cmd_print_eject) Ditto.
3716 (internal_cmd_print) Now cleans up after itself. Uses
3717 fh_parse_file_handle() now.
3718 (cmd_print_space) Use PXP_NUMERIC to type-check.
3720 * q2c.c: Overhauled. Removed _("") i18n support. All references
3721 updated. All output functions updated to handle structures rather
3722 than local or static variables. Adapt to new PSPP lex_*()
3726 (macro MAX_N_SBC) Removed.
3727 (global bare) Removed.
3728 (enum STRING) Renamed T_STRING.
3729 (enum ID) Renamed T_ID.
3730 (get_buffer) Buffer size increased.
3731 (strlower) Renamed st_lower(), rephrased.
3732 (strupper) Renamed st_upper(), rephrased.
3733 (skip_ws) New function.
3734 (get_line) Don't special-case any types of lines (like those
3735 beginning with ! or $, for instance).
3736 (get_token) Renamed lex_get(). Rephrased.
3737 (static var `prefix') New.
3738 (parse) New function.
3739 (parse_setting) Minor rephrasing.
3740 (dump_specifier_vars) Ditto.
3741 (make_identifier) Put null terminator on identifier, duh.
3742 (dump_vars) Renamed dump_declarations(). Never indent. Never
3743 static. Output changed entirely.
3744 (dump_specifier_init) Rephrase.
3745 (dump_vars_init) No index variable needed. Other modifications.
3746 (dump_parser) Don't parse command name. Do dump functions instead
3747 of just code fragments.
3748 (dump_free) Dump function instead of code fragment.
3749 (recognize_directive) New function.
3750 (main) Use recognize_directive(). Don't rely on magic $ line
3751 beginning: instead, parse comments. Update list of headers.
3753 * random.c: New file, containing the following functions:
3754 real_rand(), real_srand(), setup_randomize, shuffle, rand_uniform,
3755 rand_normal, rand_simple.
3757 * random.h: New file.
3759 * recode.c: (cmd_recode) Merge internal_cmd_recode() into this
3760 function. `max_src_width', `max_dst_width' changed to size_t.
3761 (internal_cmd_recode) Removed.
3762 (parse_dest_spec) Merge similar cases.
3763 (parse_src_spec) Add assertion.
3765 * repeat.c: (recognize_keyword) New function.
3766 (internal_cmd_do_repeat) Parse and handle PRINT keyword on END
3767 REPEAT. Improve recognition of END REPEAT (use
3768 recognize_keyword()). Move from curfn to getl_location(). Use
3771 (perform_DO_REPEAT_substitutions) Adapt to struct string.
3773 * set.q: Adapt to new q2c.
3774 (cmd_set) Range-check some values better.
3775 (custom_blanks) Renamed stc_custom_blanks().
3776 (custom_length) Renamed stc_custom_length().
3777 (custom_results) Renamed stc_custom_results().
3778 (custom_seed) Renamed stc_custom_seed().
3779 (custom_width) Renamed stc_custom_width().
3780 (custom_format) Renamed stc_custom_format().
3781 (custom_journal) Renamed stc_custom_journal().
3782 (custom_color) Renamed stc_custom_color().
3783 (custom_listing) Renamed stc_custom_listing().
3784 (custom_disk) Renamed stc_custom_disk().
3785 (custom_log) Renamed stc_custom_log().
3786 (custom_rcolor) Renamed stc_custom_rcolor().
3787 (custom_viewlength) Renamed stc_custom_viewlength().
3788 (custom_workdev) Renamed stc_custom_workdev().
3790 * settings.h: Not necessary to include format.h any longer.
3792 * sfm-read.h: (macro bswap_int32) Moved here from sfmP.h.
3793 (corrupt_msg) Rewritten.
3795 * sort.c: Adapt to rewritten heap ADT.
3797 * str.c: (aa_strcpy) Removed.
3798 (ab_strcpy) Removed.
3799 (ac_strcpy) Removed.
3800 (ba_strcpy) Removed.
3801 (bb_strcpy) Removed.
3802 (ca_strcpy) Removed.
3803 (aa_strdup) Removed.
3804 (aa_strdupcpy) Removed.
3805 (ba_strdup) Removed.
3806 (sa_strdup) Removed.
3807 (memrev) Renamed mm_reverse().
3808 (memrmem) Renamed mm_find_reverse().
3809 (cmp_str) Renamed st_compare_pad().
3810 (strmaxcpy) Removed.
3811 (strbarepadcpy) Renamed st_bare_pad_copy(), signature changed.
3812 (strbarepadlencpy) Renamed st_bare_pad_len_copy(), signature
3814 (strpadcpy) Renamed st_pad_copy(), signature changed.
3815 (blpstrset) Removed.
3816 (ds_create) New function.
3817 (ds_init) New function.
3818 (ds_replace) New function.
3819 (ds_destroy) New function.
3820 (ds_clear) New function.
3821 (ds_extend) New function.
3822 (ds_shrink) New function.
3823 (ds_truncate) New function.
3824 (ds_length) New function.
3825 (ds_size) New function.
3826 (ds_value) New function.
3827 (ds_end) New function.
3828 (ds_concat) New function.
3829 (ds_concat_buffer) New function.
3830 (ds_printf) New function.
3831 (ds_putchar) New function.
3832 (ds_getline) New function.
3833 (ds_get_config_line) New function derived from the old
3834 misc.c:get_config_line().
3835 (ls_create) New function.
3836 (ls_create_buffer) New function.
3837 (ls_init) New function.
3838 (ls_shallow_copy) New function.
3839 (ls_destroy) New function.
3840 (ls_null) New function.
3841 (ls_null_p) New function.
3842 (ls_empty_p) New function.
3843 (ls_length) New function.
3844 (ls_value) New function.
3845 (ls_end) New function.
3847 * str.h: Reformatted.
3848 (struct a_string) Removed.
3849 (struct b_string) Removed.
3850 (struct c_string) Removed.
3851 (struct len_string) New.
3852 (struct string) New.
3853 (macro as_streq) Removed.
3854 (macro bs_streq) Removed.
3855 (macro cs_streq) Removed.
3856 (macro sa_streq) Removed.
3857 (macro sb_streq) Removed.
3858 [__GNUC__] (inline function ds_putchar) New function.
3859 [__GNUC__] (inline function ds_length) New function.
3860 [__GNUC__] (inline function ds_value) New function.
3861 [__GNUC__] (inline function ds_end) New function.
3863 * sysfile-info.c: (cmd_sysfile_info) Rephrased.
3864 (display_vectors) Fix missing i18n.
3866 * t-test.q: Migrate to new q2c.
3868 * tab.c: Migrate from arenas to pools.
3869 (tab_create) Use struct len_string.
3870 (tab_realloc) Ditto.
3871 (text_format) Ditto.
3872 (tab_joint_text) Ditto.
3873 (tab_natural_width) Remove rich text support.
3874 (tab_natural_height) Ditto.
3875 (tab_output_text) Handle TAT_FIX.
3876 (tab_raw) Change arg from a_string to len_string.
3877 (tabi_driver) Fix assertion. Use struct len_string.
3878 (render_strip) Use struct len_string. Remove rich text support.
3879 Add `const' qualifiers.
3881 * tab.h: (enum TAB_RICH) Remove.
3882 (enums TAB_COL_NONE, TAB_COL_DONE) New. Where appropriate,
3883 SOM_COL_* updated to read TAB_COL_*.
3884 (struct tab_table) Change arena to pool. Change a_string to
3887 * temporary.c: (restore_dictionary) Rewrite Checker code.
3889 * var.h: (macros MAX_SHORT_STRING, MIN_LONG_STRING, SYSMIS,
3890 LOWEST, HIGHEST) Moved here from common.h.
3891 (typedef any_trns) Removed. All references changed to `struct
3894 * vars-atr.c: (force_create_variable) Fix assertion.
3895 (force_dup_variable) Fix assertion.
3897 Thu Jun 3 18:40:42 1999 Ben Pfaff <blp@gnu.org>
3899 Using alphanumeric variables in functions under AGGREGATE
3900 segfaulted. Fixed. Thanks to Dr. Dirk Melcher
3901 <BZN-mdksh@t-online.de> for reporting this bug.
3903 * aggregate.c: (parse_aggregate_functions) When setting the
3904 FSTRING bit, also allocate memory for the `string' member of
3906 (free_aggregate_functions) Free iter->string. Don't use the
3907 non-function bits when indexing the array of functions.
3908 [DEBUGGING] (debug_print) Don't use the non-function bits when
3909 indexing the array of functions.
3911 Sun May 30 00:00:54 1999 Ben Pfaff <blp@gnu.org>
3913 Under certain circumstances, the final case would be omitted from
3914 the results of an AGGREGATE operation. Fixed. Thanks to Dr. Dirk
3915 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
3917 * aggregate.c (agr_00x_end_func): Increment number of cases in
3918 sink before writing case. For streams that keep track of how many
3919 cases there are based on this value, this means that the last case
3920 will be read in on the next stream read.
3922 Sat May 29 22:03:31 1999 Ben Pfaff <blp@gnu.org>
3924 Undefined behavior was invoked by referencing a freed pointer.
3926 * vfm.c (memory_stream_write): Free pointer *after* checking for
3929 Sat May 29 22:02:22 1999 Ben Pfaff <blp@gnu.org>
3931 A wrong record size was displayed when paging the active file to
3934 * vfm.c: (memory_stream_write) Fix off-by-one error.
3936 Sat May 29 21:50:26 1999 Ben Pfaff <blp@gnu.org>
3938 Not having enough temporary space for sorting caused a core dump.
3941 * sort.c: (allocate_cases) Initialize i.
3943 Sat May 29 21:40:54 1999 Ben Pfaff <blp@gnu.org>
3945 Syntax errors in function descriptions on AGGREGATE caused core
3948 * aggregate.c (cmd_aggregate): Don't free agr_dict after calling
3949 free_aggregate_functions(), since that function already frees
3952 Sat May 29 21:06:10 1999 Ben Pfaff <blp@gnu.org>
3954 A null pointer was dereferenced, causing a core dump, when
3955 PERCENTILES was specified on FREQUENCIES. This fixes the problem,
3956 but PSPP still doesn't calculate percentiles. Thanks to Regnor
3957 Jernsletten <rjernsle@eunet.no> for reporting this problem.
3959 * arena.c: (arena_malloc) If the arena hasn't been initialized
3960 already, initialize it.
3962 Sat May 29 20:47:29 1999 Ben Pfaff <blp@gnu.org>
3964 * Makefile.cygwin: New file supplied by Hankin <hankin@dunno.com>
3965 for compilation with Cygnus Windows B20. Not used by other
3968 Sat May 29 20:36:04 1999 Ben Pfaff <blp@gnu.org>
3970 SORT always sorted in ascending order. Fixed. Thanks to Dr. Dirk
3971 Melcher <BZN-mdksh@t-online.de> for reporting this bug.
3973 * sort.c: (compare_case_lists) Reverse sense of comparison if
3974 sorting in descending order.
3975 (compare_record) Ditto.
3977 Tue Mar 9 13:18:54 1999 Ben Pfaff <blp@gnu.org>
3979 SPLIT FILE with a string variable caused a core dump. Fixed.
3981 * vfm.c: If the variable is a string then make a temporary value
3982 struct pointing to it. The underlying problem is a lot bigger
3983 than this (see TODO) but this is a stopgap for the simple case at
3986 Tue Mar 9 13:15:53 1999 Ben Pfaff <blp@gnu.org>
3988 Nested INCLUDEs didn't work. Fixed.
3990 * getline.c: (getl_include) Set first_line to NULL in allocated
3993 Tue Mar 9 13:13:46 1999 Ben Pfaff <blp@gnu.org>
3995 The MATCH FILES procedure set the values of variables not present
3996 to 0. It should have been SYSMIS. This is now fixed.
3998 * get.c: (mtf_delete_file_in_place) Replace 0.0 by SYSMIS.
4000 Tue Mar 9 12:52:23 1999 Ben Pfaff <blp@gnu.org>
4002 The REMARK command was too aggressive about skipping lines. It
4003 didn't like being the last command in a file.
4005 * command.c: (cmd_remark) Call get_entire_line() instead of
4008 Tue Mar 9 12:48:05 1999 Ben Pfaff <blp@gnu.org>
4010 Comment parsing wasn't consistent with the rest of the code in its
4011 idea of where one command ends and another starts. This meant
4012 that sometimes commands would be mysteriously ignored. Thanks to
4013 Dr. Dirk Melcher <BZN-mdksh@t-online.de> for reporting this bug.
4015 * command.c: (parse_cmd) Hand off comment parsing to new function
4016 skip_comment() in lexer.c.
4017 * lexer.c: (skip_comment) New function.
4019 Wed Jan 20 20:22:07 1999 Ben Pfaff <blp@gnu.org>
4021 The TABLE subcommand on MATCH FILES worked only erratically at
4022 best. This fixes it. Thanks to Dr. Dirk Melcher
4023 <BZN-mdksh@t-online.de> for reporting this bug.
4025 * get.c: (mtf_compare_BY_values) When comparing string values, a
4026 difference of 1 is still a difference :-)
4027 (mtf_processing) Inverted TABLE reading logic fixed. Also don't
4028 advance TABLE files automatically when matched. Comment fixes.
4030 Tue Jan 19 22:32:31 1999 Ben Pfaff <blp@gnu.org>
4032 VARIABLE LABELS rejected a slash before the first variable
4033 specification, contradicting the documentation. Thanks to Walter
4034 M. Gray <graywm@northernc.on.ca> for reporting this bug.
4036 * var-labs.c: (cmd_variable_labels) Ignore a leading slash in
4037 command specification.
4039 Tue Jan 19 22:29:54 1999 Ben Pfaff <blp@gnu.org>
4041 Because of an incorrect optimization in memory allocation,
4042 CROSSTABS sometimes segfaulted when asked to output multiple
4043 tables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
4046 * crosstabs.q: (postcalc) New variables maxcols, maxcells, which
4047 are passed to output_pivot_table() for its use.
4048 (output_pivot_table) Instead of assuming the number of columns is
4049 constant, keep track with maxcols. In general mode, use maxcells
4050 to determine whether more matrix cells need to be allocated.
4052 Tue Jan 19 22:27:46 1999 Ben Pfaff <blp@gnu.org>
4054 CROSSTABS didn't display value labels for column and row
4055 variables. Thanks to Walter M. Gray <graywm@northernc.on.ca> for
4058 * crosstabs.q: (table_value_missing) If the specified value has a
4059 value label for this variable, then show it instead of the raw
4061 (display_dimensions) Delegate display of value_labels to
4062 table_value_missing.
4064 Mon Jan 18 20:04:06 1999 Ben Pfaff <blp@gnu.org>
4066 WRITE didn't write line ends. Fixed. Thanks to Dr. Dirk Melcher
4067 <BZN-mdksh@t-online.de> for reporting this bug.
4069 * print.c: (print_trns_proc) Write (CR/)LF if PRINT is used _or_
4070 if the file isn't declared as binary.
4072 Mon Jan 18 19:56:45 1999 Ben Pfaff <blp@gnu.org>
4074 MATCH FILES corrupted memory and dumped core on some syntax
4077 * get.c: (cmd_match_files) Set file->handle to NULL before
4079 (mtf_free_file) Don't free a null dictionary.
4081 Mon Jan 18 19:27:57 1999 Ben Pfaff <blp@gnu.org>
4083 MATCH FILES should set numeric values not available to the
4084 system-missing value, not to 0. Thanks to Dr. Dirk Melcher
4085 <BZN-mdksh@t-online.de> for reporting this bug.
4087 * get.c: (mtf_processing) Set unused records to system-missing,
4090 Mon Jan 18 15:06:46 1999 Ben Pfaff <blp@gnu.org>
4092 KEEP didn't work properly on the SAVE procedure. Fixed. Thanks
4093 to Ralf Geschke <ralf@kuerbis.org> for reporting this bug.
4095 * temporary.c: (save_dictionary) Initialize var_by_name AVL tree
4096 in newly created dictionary, and add each copied variable to the
4099 Mon Jan 18 15:04:48 1999 Ben Pfaff <blp@gnu.org>
4103 * get.c: (trim_dictionary) Free variable list for KEEP after
4106 Mon Jan 18 12:57:36 1999 Ben Pfaff <blp@gnu.org>
4108 Some systems didn't like the way open_file was coded. Thanks to
4109 Hankin <hankin@rogue.consultco.com> for pointing this out.
4111 * filename.c: (open_file) Don't try to store stdin, stdout,
4112 stderr as part of an array, because that doesn't always work.
4114 Mon Jan 18 12:53:27 1999 Ben Pfaff <blp@gnu.org>
4116 The SAVE procedure didn't save long string variables properly.
4117 Fixed by this patch. Thanks to Hankin
4118 <hankin@rogue.consultco.com> for this patch.
4120 * sfm-write.c: (write_variable) Fix off-by-one error in writing
4121 out variable pad records.
4123 Tue Jan 5 14:29:27 1999 Ben Pfaff <blp@gnu.org>
4125 Previously, if PRINT SPACE were given a negative argument, it
4126 would report an error, then spin in an (almost) infinite loop.
4127 This fixes that behavior.
4129 * print.c: (print_space_trns_proc) After reporting a negative
4130 argument, set number of lines to print to 1.
4132 Tue Jan 5 13:59:55 1999 Ben Pfaff <blp@gnu.org>
4134 SPSS 8.0 outputs some new record types in its system files, and it
4135 allows longer value labels. Accept these system files.
4137 * sfm-read.c: (sfm_read_dictionary) Ignore record type 7 subtype
4138 11 emitted by SPSS 8.0.
4140 Tue Jan 5 13:55:50 1999 Ben Pfaff <blp@gnu.org>
4142 The LIST procedure was too conservative in allocating space for
4143 buffers, which caused a bug that only showed up with very long
4144 output variables. Thanks to Hankin <hankin@dunno.com> for this
4147 * list.q: (determine_layout) Allocate 1022 bytes instead of 256.
4149 Tue Jan 5 13:34:34 1999 Ben Pfaff <blp@gnu.org>
4151 Typo meant string format specifiers weren't checked properly. I
4152 think that Hankin <hankin@dunno.com> sent me this report, but I'm
4153 willing to be corrected on this point.
4155 * format.c: (check_string_specifier) Fix obvious typo.
4157 Tue Jan 5 12:50:42 1999 Ben Pfaff <blp@gnu.org>
4159 Using $CASENUM in an expression didn't work. Here's a fix.
4160 Thanks to Dirk Melcher <BZN-mdksh@t-online.de> for reporting this
4163 * expr-evl.c: (evaluate_expression) Add OP_CASENUM case.
4165 * expr-opt.c: (dump_node) OP_CASENUM is acceptable.
4167 Tue Jan 5 12:47:48 1999 Ben Pfaff <blp@gnu.org>
4169 The changes in 0.2.1 to fix DATA LIST FREE parsing broke some
4170 other behavior, *sigh*. This patch hopefully fixes that. This
4171 time I've actually tested it.
4173 Thanks to Hankin <hankin@dunno.com> for reporting this bug.
4175 * data-list.c: (read_from_data_list_free,
4176 read_from_data_list_list) Call parse_string_as_format() directly
4177 without mucking around with the field width.
4179 Tue Jan 5 12:31:19 1999 Ben Pfaff <blp@gnu.org>
4181 Occasionally, you may encounter a script that wants to be
4182 interpreted in interactive mode. Make -i emulate this behavior to
4183 allow such scripts to be executed with PSPP.
4185 Thanks to Hankin <hankin@dunno.com> for reporting this behavior.
4187 * cmdline.c: (pre_syntax_message[]) Update -i description.
4189 * lexer.c: (preprocess_line) When getl_interactive is 2 (i.e.,
4190 when -i is given on the command line) don't treat unindented lines
4191 as starting a new command.
4193 Tue Jan 5 12:30:10 1999 Ben Pfaff <blp@gnu.org>
4195 In conjunction with egcs 1.1.1, Checker emits some bogus warnings,
4196 mostly caused by local initialized aggregates. After egcs is
4197 fixed upstream these can be removed, but for now they're not a big
4200 * ascii.c: (ascii_postopen_driver) Checker chokes on local
4201 initialized arrays. Avoid this.
4203 * sfm-write.c: (sfm_write_dictionary) Don't use a local
4206 Tue Jan 5 12:07:24 1999 Ben Pfaff <blp@gnu.org>
4208 egcs 1.1.1 has some new warnings relative to gcc 2.8.1, which the
4209 following changes avoid. Currently I compile sources with egcs
4210 1.1.1 and gcc 2.7.2.3 before sending them out.
4212 * apply-dict.c: (apply_dict) Use new avl_traverser_init() macro.
4214 * ascii.c: (option_tab[]) Initialize all struct members.
4216 * avl.h: (avl_traverser_init) New macro.
4218 * command.c: (DEFCMD, UNIMPL macros, cmd_table[]) Initialize all
4221 * crosstabs.q: (enum_var_values) Use new hsh_iterator_init()
4224 * hash.c: Comment fix.
4226 * hash.h: (hsh_iterator_init) New macro.
4228 * html.c: (option_tab[]) Initialize all struct members.
4230 * pfm-write.c: (write_value_labels) Use new avl_traverser_init()
4233 * postscript.c: (option_tab[]) Initialize all struct members.
4234 (output_encodings, preclose, dump_lines) Use new
4235 hsh_iterator_init() macro.
4237 * sfm-write.c: (write_value_labels) Use new avl_traverser_init()
4240 * sysfile-info.c: (describe_variable) Use new avl_traverser_init()
4243 Thu Nov 19 12:32:45 1998 Ben Pfaff <blp@gnu.org>
4245 * data-in.c: Examined each of the parsing functions to make sure
4246 that they wouldn't dump core if they were passed a string of the
4247 wrong length, since now the DATA LIST FREE/LIST routines don't
4248 check for field width before passing it to the data parser.
4249 (parse_RBHEX, parse_AHEX) Reject odd length input.
4250 (parse_string_as_format) Reject input that's too short or too
4253 * data-list.c: Before, the DATA LIST FREE/LIST routines would pad
4254 a field to its entire declared output width then pass it to the
4255 data-in parsing routines. This contradicted the documented
4256 behavior. This is fixed in these changes. Thanks to Mark H. Wood
4257 <mwood@IUPUI.Edu>. In addition, this fixes a few more details of
4258 free-format parsing that differed from SPSS.
4259 (cut_field) Commas and spaces are treated identically. Returns
4260 the proper column instead of a fixed 1 value.
4261 (parse_field) Removed.
4262 (read_from_data_list_free, read_from_data_list_list) Call
4263 parse_string_as_format directly instead of parse_field.
4265 * heap.c: (heap_delete) Stylistic fixes.
4267 Sun Aug 9 11:12:13 1998 Ben Pfaff <blp@gnu.org>
4269 * loop.c: (loop_2_trns_proc) Formatting fix.
4271 * sel-if.c: (cmd_filter) Set FILTER_before_TEMPORARY.
4273 * var.h: (glob var FILTER_before_TEMPORARY) New global var.
4275 * vfm.c: (macro FILTERED) New.
4276 (static var filter_var) New.
4277 (process_active_file_write_case) Use FILTERED.
4278 (setup_filter) Set filter_var.
4279 (close_active_file) Delete the filter if not
4280 FILTER_before_TEMPORARY.
4281 (procedure_write_case) Use FILTERED.
4283 Sat Aug 8 00:20:14 1998 Ben Pfaff <blp@gnu.org>
4285 * crosstabs.q: Changed /PIVOT={ON,OFF} to /FORMAT={PIVOT,NOPIVOT}.
4287 * data-in.c: (parse_day_count) Message fix.
4288 (parse_month) Style fix.
4290 * data-list.c: (struct data_list_pgm) New member eof.
4291 (cmd_data_list) Init eof to 0.
4292 (do_reading) Implement the /END subcommand and read-past-eof
4295 * do-if.c: Include stdio.h when debugging.
4296 (cmd_else_if) Make sure the command is .-terminated.
4298 * glob.c: (init_glob) Capitalize the command prompt.
4300 * inpt-pgm.c: (end_case_trns_proc) Debugging message.
4301 (end_file_trns_proc) Debugging message.
4303 * loop.c: (internal_cmd_loop) Make it work when there's no loop
4305 (loop_2_trns_proc) Enable MXLOOPS (why was this disabled?)
4307 * main.c: (dump_token) Make kwtab[] const.
4309 * set.q: Spelling, comment fixes.
4311 * sysfile-info.c: (cmd_display) DISPLAY VECTORS not DISPLAY
4314 * vars-prs.c: (fill_all_vars) Style fix.
4316 * vfm.c: (index_to_varname) Return const.
4318 Tue Aug 4 23:49:23 1998 Ben Pfaff <blp@gnu.org>
4320 * Changes in many source files for partial -ansi -pedantic and
4321 no-debugging compliance: Remove trailing common in enum
4322 declarations; add `unused' attributes; insert some appropriate
4325 * cmdline.c: (parse_command_line) Add new --testing-mode flag.
4327 * command.c: (shell) Make static.
4328 (run_command) Make static.
4330 * data-list.c: (dump_fixed_table) Remove use of local_strdup().
4332 * dfm.c: (cmd_begin_data) I18n fix.
4334 * error.c: (verbose_msg) Define if __STRICT_ANSI__.
4336 * error.h: (macro verbose_msg) Define if __STRICT_ANSI__.
4338 * expr-opt.c: (evaluate_tree) Don't initialize local arrays if
4341 * file-handle.q: Don't prepend the source file directory name to
4342 the data file name. (Ongoing issue.)
4343 (prepend_current_directory) Comment out.
4344 (internal_cmd_file_handle) Don't call prepend_current_directory().
4345 (fh_get_handle_by_filename) Ditto.
4347 * filename.c: Append zero byte to readlink() return value.
4349 * getline.c: (getl_read_line) I18n fix.
4351 * lexer.h: Don't use gcc features if __STRICT_ANSI__.
4353 * misc.h: Don't use gcc features if __STRICT_ANSI__.
4355 * pfm-write.c: (bufwrite) Don't try to increment a void * pointer
4358 * postscript.c: (output_encodings) Don't use local_strdup().
4361 * print.c: Don't use gcc features if __STRICT_ANSI__.
4363 * q2c.c: (dump_vars) Don't put a , at the end of the last enum.
4365 * recode.c: (parse_src_spec) Fully brace nested if's.
4367 * set.q: (global var set_testing_mode) New var.
4369 Wed Jul 29 22:01:44 1998 Ben Pfaff <blp@gnu.org>
4371 * ascii.c: Add some more `unused' attributes that only come into
4372 play when NDEBUG is defined.
4373 (ascii_close_page) Set s_len when reallocating s.
4375 * crosstabs.q: (delete_missing) New function.
4376 (output_pivot_table) Call delete_missing() if /MISSING=REPORT.
4377 (make_summary_table) Create summary table reallocable.
4379 * postscript.c: Add more `unused' attributes as above.
4381 * tab.c: (tab_create) [GLOBAL_DEBUGGING] Set reallocable member.
4382 (tab_realloc) [GLOBAL_DEBUGGING] Assert that table is reallocable.
4384 * tab.h: (struct tab_table) [GLOBAL_DEBUGGING] New `reallocable'
4387 * var.h: (macro force_dup_variable) [!GLOBAL_DEBUGGING] Remove
4388 gratuitous space between parameter definition.
4390 * vars-atr.c: Changed some assert(0)'s to abort()'s to prevent
4391 complaints about running off the end of functions with NDEBUG
4394 Sun Jul 5 00:17:25 1998 Ben Pfaff <blp@gnu.org>
4396 * Several source files: Removed some PORTME notes when reflection
4397 revealed that ANSI forbids that sort of breakage. Also, added
4398 lots of `unused' qualifiers here and there.
4400 * aggregate.c: (accumulate_aggregate_info) Remove local var
4401 weighting that turned out not to be used.
4403 * avl.c: Update to version 1.1.0. Add unused specifier.
4404 (avl_destroy) Initialize ab to 0. Comment fixes. Cast return
4406 (avl_probe) Replace some instances of 1 with +1 where appropriate.
4407 (avl_find) Cast return value to void *.
4408 (avl_delete) q doesn't need to be initialized at the beginning of
4409 the function. Replace some instances of 1 with +1.
4410 (force_avl_delete) Renamed avl_force_delete, all references changed.
4411 (compare_ints) `param' marked unused.
4412 (print_int) `param' marked unused.
4413 (recurse_tree) Replace some instances of 1 with +1.
4415 * avl.h: Update to version 1.1.0. Only declares avl function
4416 types if not already declared.
4417 (AVL_MAX_HEIGHT) Only define if not already defined.
4418 (struct avl_node) New unused member char pad[2].
4419 [GLOBAL_DEBUGGING] Change conditionalization to NDEBUG instead.
4420 (force_avl_insert) Renamed avl_force_insert.
4421 (force_avl_delete) Renamed avl_force_delete.
4423 * crosstabs.q: (struct table_entry) Put `freq' into a union with
4425 (struct crosstab) Add new member `ofs'.
4426 (glob var int_tab) Removed.
4427 (custom_tables) In integer mode, assign v[i] properly through the
4429 (custom_variables) Now p.crs.max == max + 1.
4430 [DEBUGGING] (debug_print) p.crs.min and p.crs.max are now ints.
4431 (precalc) Implement integer mode.
4432 (calc_integer) Implement integer mode.
4433 (compare_table_entry) Remove unused local variable `comparing'.
4434 (make_summary_table) Implement integer mode.
4435 (macro ns_rows) Implemented as static variable now.
4436 (several variables) Made static, from global.
4437 (output_pivot_table) Use table_value_missing() for column heads.
4438 Remove several unused local variables. Implement integer mode
4439 table summing. Count up ns_rows.
4440 (crosstabs_dim) Make columns wider when /MISSING=REPORT requested.
4441 (find_pivot_extent) Moved into find_pivot_extent_general; now just
4442 calls that function or find_pivot_extent_integer.
4443 (find_pivot_extent_integer) New function.
4444 (enum_var_values) Implemented for integer mode.
4445 (table_value_missing) New function.
4446 (display_dimensions) Call table_value_missing() for heads.
4447 (float_M_suffix) New function.
4448 (display_crosstabulation) Call table_value_missing() for row
4449 heads. Handle missing values in /MISSING=REPORT mode.
4450 (calc_fisher) Remove unused var N.
4451 (calc_r) Remove unused var fact.
4453 * data-list.c: (dump_fixed_table) Fix table dimensioning.
4454 (read_one_set_of_repetitions) Remove unused vars var_spec, column.
4456 * data-out.c: (insert_commas) Remove unused var cp.
4457 (convert_CCx) Remove unused vars save_set_decimal,
4460 * descript.q: (dump_z_table) Fix table dimensioning.
4461 (pre_calc) Remove unused var j.
4462 (display) Remove unused vars title, s. Fix table dimensioning.
4464 * expr-evl.c: Comment fixes.
4466 * frequencies.q: (full_dim) New function.
4467 (dump_full) Fix table dimensioning.
4468 (condensed_dim) New function.
4469 (dump_condensed) Fix table dimensioning.
4471 * get.c: (cmd_match_files) Remove unused var n_val. Remove unused
4474 * html.c: (html_close_drive) Remove unused var i.
4475 (postopen) Remove unused vars title, curfn_len, cp.
4476 (preclose) Remove unused vars this, x.
4478 * lexer.c: Comment fixes.
4480 * matrix-data.c: (cmd_matrix_data) Remove unused var index.
4482 * means.q: (custom_tables) Remove unused var m_dim.
4484 * mis-val.c: Format fix.
4486 * modify-vars.c: (cmd_modify_vars) Remove unused var new_dict.
4488 * output.c: (outp_get_paper_size) Remove unused var cp.
4490 * pfm-read.c: (read_float) Remove unused var save, unused label
4492 (read_variables) Remove unused vars cp, j.
4493 (read_value_label) Remove unused var j.
4495 * pfm-write.c: (bufwrite) Remove unused var i.
4497 * postscript.c: (ps_postopen_drive) Remove unused vars dev_info,
4499 (output_encodings) Remove unused vars char_cp, n_output.
4500 (read_ps_encodings) Remove unused var ep.
4501 (postopen) Remove unused var title.
4502 (preclose) Remove unused var fp.
4503 (ps_open_page) Remove unused vars true, false, orientation,
4504 mirror_horz, mirror_vert, width, length.
4505 (ps_text_metrics) Remove unused var x.
4507 * q2c.c: (find_symbol) Remove unused var y.
4508 (parse_setting) Remove unused parameter sbc, all references
4510 (dump_parser) Remove unused var cp.
4511 (dump_free) Remove unused var i.
4513 * set.q: (static vars args, n) Removed.
4514 (internal_cmd_gset) Removed.
4516 * sfm-read.c: (sfm_read_dictionary) Removed unused var i.
4517 (read_machine_flt64_info) Removed unused var file_endian.
4518 (read_documents) Removed unused var i.
4519 (read_compressed_data) Removed unused parameter dict, all
4522 * sfm-write.c: (bufwrite) Removed unused var i.
4523 (sfm_write_case) Removed unused var i.
4525 * sort.c: (merge_once) Remove unused var t.
4526 (write_separate) #if 0 out as dead code.
4528 * split-file.c: (cmd_split_file) Remove unused var i.
4530 * sysfile-info.c: (sysfile_info_dim) New function.
4531 (cmd_sysfile_info) Fix table dimensioning.
4532 (variables_dim) New function.
4533 (display_variables) Fix table dimensioning.
4534 (describe_variable) Remove unused var prev_r.
4536 * t-test.q: (z_postcalc) Removed.
4537 (pairs_calc) Remove unused var bad_weight.
4538 (postcalc) Remove unused vars dfn, dfd.
4540 * tab.c: (tab_create) Set t->dim to NULL.
4541 (tab_dim) Make sure t->dim is NULL first.
4542 (tab_natural_width) Remove parameter `clamp'.
4543 (tab_value) Remove duplicate assertion for table.
4544 (tab_raw) New function.
4545 (nowrap_dim) New function.
4546 (wrap_dim) New function.
4547 (tab_output_text) Fix table dimensioning.
4549 * tab.h: (tab_raw) New macro.
4551 * val-labs.c: (get_label) Remove unused var type.
4552 (copy_value_labels) Remove unused var trav.
4554 * var.h: (struct crosstab_proc) Completely changed.
4556 * vars-prs.c: (parse_dict_variable) Remove unused var v.
4558 * vfm.c: (open_active_file) Remove unused vars i, lp.
4560 * weight.c: (weight_trns_proc) #if 0 out as dead code.
4562 Tue Jun 2 23:37:21 1998 Ben Pfaff <blp@gnu.org>
4564 * Makefile.am: Add apply-dict.c, flip.c.
4566 * apply-dict.c: New file.
4568 * command.c: (struct command) Make cmd[] larger for CLEAR
4569 TRANSFORMATIONS command name.
4570 (parse_cmd) Make sure we're in a valid state before using it as an
4571 index. Discard variables and reset state on invalid transitions.
4572 (cmd_clear_transformations) New function.
4574 * command.def: Add APPLY DICTIONARY, CLEAR TRANSFORMATIONS, FLIP.
4575 Add unimplemented PRESERVE, RESTORE.
4577 * file-handle.h: Include stddef.h.
4581 * pfm-read.c: (parse_value) Pad value label values with spaces,
4584 * sfm-read.c: (struct sfm_fhuser_ext) Add reference count.
4585 (sfm_close) Decrement reference count, make sure it's zero.
4586 (sfm_maybe_close) New function.
4587 (sfm_read_dictionary) Handle reference counts.
4589 * vars-atr.c: (clear_default_dict) New function.
4590 (discard_variables) Use clear_default_dict().
4592 Sun May 31 00:58:05 1998 Ben Pfaff <blp@gnu.org>
4594 * Makefile.am: Add pfm-write.c.
4595 (LDADD) Add the libgmp2 libraries.
4597 * command.def: Define EXPORT.
4599 * get.c: (cmd_export) New function.
4600 (export_write_case_func) New function.
4602 * pfm-read.c: (static spss2ascii[]) Make it const.
4604 * pfm-write.c: New file.
4606 * sfm-write.c: Formatting, comment fixes.
4608 * var.h: Comment fix.
4610 Fri May 29 21:44:12 1998 Ben Pfaff <blp@gnu.org>
4612 * Makefile.am: Add pfm.h, pfm-read.c.
4614 * command.def: IMPORT is now implemented.
4616 * format.c: (glob var translate_fmt[]) New var.
4618 * get.c: (enum GTSV_NONE) Renamed GTSV_OPT_NONE.
4619 (cmd_import) New function.
4620 (import_source_read) New function.
4621 (glob var import_source) New var.
4623 * pfm-read.c: New file.
4627 * sfm-read.c: (parse_format_spec) Local variable translate_fmt[]
4629 (dump_dictionary) Disabled printing a couple of items.
4631 Mon May 25 12:42:37 1998 Ben Pfaff <blp@gnu.org>
4633 * crosstabs.q: (postcalc) Call make_summary_table().
4634 (make_summary_table) New function.
4635 (insert_summary) New function.
4636 (display_dimensions) Remove some unnecessary arguments, all
4638 (output_pivot_table) Fix lots of problems with the risk table
4640 (submit) Don't display an empty table.
4641 (display_risk) Fix order of arguments to calc_risk().
4643 * glob.c: Always include assert.h and stdlib.h.
4645 * output.h: (enum OUTP_T_JUST_FULL) Removed, all references
4648 * tab.c: (tab_create) Cosmetic changes.
4650 * tab.h: (enum TAB_JUSTIFY) Removed, all references removed.
4652 Sun May 24 22:39:23 1998 Ben Pfaff <blp@gnu.org>
4656 * crosstabs.q: (output_pivot_table) Headers drawing and submission
4657 code simplified, moved into new function submit().
4658 (submit) New function.
4659 (crosstabs_dim) New function.
4660 (display_directional) Substitute variable names for %s where
4662 (somers_d_v[], somers_d_ase[], somers_d_t[]) New static vars.
4663 (calc_symmetric) Initialize parameters only if non-NULL.
4664 Calculate Somers' d.
4665 (calc_directional) Calculate Somers' d (or copy it, really).
4668 * output.c: (outp_string_width) New function.
4670 * postscript.c: (postopen) Calculate font widths based on the
4671 width of the zero '0' character, not the width of the space
4672 character. Set paper-width and paper-length based on points, not
4674 (ps_open_page) Fix page setup string for landscape mode.
4676 * som.h: (struct som_dimension) Removed.
4677 (struct som_table_class) height, width members take int * not
4680 * tab.c: Many functions now have added parameter validation.
4681 (tab_height, tab_width) These functions were removed and merged
4682 into a single function tab_resize(), and all references changed.
4683 (tab_dim) Rewritten since the interface changed; reduced from
4684 hundreds of lines to two. All callers were changed. Currently
4685 most of them just use tab_natural_dimensions as their callback and
4686 await detailed translation of functionality.
4687 (tab_natural_width) New function.
4688 (tab_natural_height) New function.
4689 (tab_natural_dimensions) New function. This is a callback
4690 function, not something that you'd want to call directly.
4691 (tab_nat_dim) Removed.
4692 (tabi_table) Allocates t->w and t->h.
4693 (tabi_driver) Inlined sum_columns()'s functionality. Calls the
4694 dimensions callback.
4695 (evaluate_dimensions) Removed.
4696 (sum_columns) Removed.
4698 * tab.h: (enum TAL_1THIN) Removed.
4699 (enum series t_*) Removed.
4700 (struct tab_table) Members trh, trv changed to unsigned char *
4701 from int *. Member dim changed to a function pointer from a
4702 unsigned char *. Member max_stack_height removed. New members
4704 (macros tab_l, tab_r, tab_t, tab_b) New.
4706 Sat May 23 23:22:13 1998 Ben Pfaff <blp@gnu.org>
4708 * ascii.c: (delineate) Assign last_space_nchars before skipping
4709 spaces, to fix right justification.
4711 * crosstabs.q: (static vars risk, direct) New vars.
4712 (static var pearson_r) Removed.
4713 (glob var chisq_fisher) Made static.
4714 (static vars row_tot[], col_tot[]) Don't include grand total
4716 (static var grand_total) Renamed W, all references changed.
4717 (output_pivot_table) Only make `table' if num_cells != 0. Make
4718 risk and directional tables. Deal with grand total no longer part
4719 of col_tot[]. Free rows and cols after we're done with them.
4720 (display_risk) New function.
4721 (display_directional) New function.
4722 (clac_r) Rewritten so that it stores all its results into its
4723 arguments, so it can be used for Spearman's correlation too.
4724 (calc_symmetric) Added a t[] argument, all references changed.
4725 Calculates ASEs for tau-b, tau-c, gamma. Calculates Spearman's r,
4726 Pearson's r, Cohen's kappa.
4727 (calc_risk) New function.
4728 (calc_directional) New function.
4730 * som.c: (som_submit) Improved debugging code.
4732 * stats.c: (hypercube) New function.
4733 (cube) New function.
4735 (normal_sig) Went back to old implementation, which actually
4738 * stats.h: (macros square, cube, hypercube) Removed. The
4739 equivalent functions in stats.c are inlined here; all references
4740 to square changed to sqr.
4742 Fri May 22 00:03:41 1998 Ben Pfaff <blp@gnu.org>
4744 * crosstabs.q: (N_SYMMETRIC) New define.
4745 (postcalc) Disable debug printing.
4746 (static vars chisq_fisher, pearson_r) New.
4747 (output_pivot_table) Add support for symmetric measures. Add
4748 chi-square output of exact sigs.
4749 (display_chisq) Rewritten.
4750 (display_symmetric) New function.
4751 (gamma_int) New function.
4753 (swap) New function.
4754 (calc_fisher) New function.
4755 (calc_chisq) Check boundary conditions better. Calculate Yates,
4756 Fisher, Mantel-Haenszel tests.
4757 (calc_r) New function.
4758 (calc_symmetric) New function.
4760 * stats.c: (normal_sig) Rewritten with new algorithm. Renamed
4762 (chisq_sig) Better boundary conditions. Renamed from
4765 * tab.h: (struct tab_table) New member cf.
4767 * tab.c: (tab_create) Set cf.
4768 (tab_width) New function.
4769 (tab_realloc) Handle cf.
4770 (tab_vline) Handle cf.
4771 (tab_hline) Handle cf.
4772 (tab_box) Handle cf.
4773 (tab_value) Handle cf.
4774 (tab_float) Handle cf.
4775 (tab_text) Handle cf.
4776 (tab_joint_text) Handle cf.
4777 (tab_offset) Handle cf.
4778 (tab_next_row) Handle cf.
4779 (evaluate_dimensions) Handle cf.
4780 (render_strip) Handle cf.
4782 Wed May 20 00:03:59 1998 Ben Pfaff <blp@gnu.org>
4784 * crosstabs.q: (postcalc) New vars row_tot, col_tot, pass them to
4785 output_pivot_table().
4786 (output_pivot_table) Moved lots of local variables outside and
4787 made them static. Add beginnings of chi-square statistic
4788 support. Now column and row totals aren't in the main matrix.
4789 Always zero out any leftover rows & columns after we're done with
4790 the table entries. Move all output stuff into
4791 display_dimensions(), display_crosstabs(), display_chisq().
4792 (display_dimensions) New function.
4793 (display_crosstabulation) New function.
4794 (display_chisq) New function.
4795 (calc_chisq) Implemented Pearson and likelihood-ratio chisquares.
4797 * frequencies.q: (dump_full, dump_condensed) Remove tab_null()
4798 references, simplify logic.
4800 * postscript.c: Remove scale, translate-x, translate-y,
4801 mirror-horz, mirror-vert, rotate-180 options.
4802 (struct ps_driver_ext) Remove scale, translate_x, translate_y.
4803 All references deleted.
4804 (macro YT) New macro.
4805 (array option_tab[]) Removed options.
4806 (ps_option) Removed options.
4807 (ps_open_page) Write page setup explicitly to output file, without
4808 using now-deleted BP function.
4809 (macro dump_line) Use YT().
4810 (macro dump_thick_line) Use YT().
4811 (draw_headers) Use YT().
4812 (switch_font) Reorder arguments to SF function.
4813 (write_text) Use YT().
4815 * sfm-read.c: (sfm_read_case) Don't attempt to read variables that
4818 * sysfile-info.c: (describe_variables) Don't use tab_nulls().
4820 * tab.c: (tab_create) Initialize t->ct to zeros. Remove
4821 null-debugging code.
4822 (tab_realloc) Remove null-debugging code. Initialize new regions
4824 (tab_vline) Support offsets.
4825 (tab_hline) Support offsets.
4826 (tab_box) Support offsets.
4828 (tab_nulls) Removed.
4831 (evaluate_dimensions) Remove null-debugging code. Understand
4832 TAB_EMPTY attribute. Assert that text.s.s is always non-NULL if
4833 TAB_EMPTY not present.
4835 * tab.h: New cell attribute TAB_EMPTY.
4836 (macros tab_nr, tab_nc, tab_row, tab_col) New.
4838 * vars-atr.c: (init_variable) Set get.fv to -1 so that GET doesn't
4839 try to read them from system files.
4841 * vfm.c: (dump_splits) Don't call tab_null().
4843 Sat May 16 19:36:55 1998 Ben Pfaff <blp@gnu.org>
4845 * crosstabs.q: (struct crosstab) Added `missing' member.
4846 (custom_tables) Init missing.
4847 (calc_general) Handle missing values.
4848 (calc_chisq) New function.
4849 (output_pivot_table) Start work on chi-square output. Update for
4850 new tab offset support functions. Shorten statistic names.
4852 * Several files: add in more `const's to placate gcc's warnings.
4854 * tab.h: (struct tab_table) Add col_ofs, row_ofs members. Comment
4857 * tab.c: (tab_height, tab_realloc, tab_vline, tab_hline, tab_box,
4858 tab_null, tab_nulls, tab_value, tab_float, tab_text,
4859 tab_joint_text) Add col_ofs and row_ofs support.
4860 (tab_offset) New function.
4861 (tab_next_row) New function.
4862 (tab_row) New function.
4863 (tab_col) New function.
4864 (tabi_table) Add col_ofs and row_ofs support.
4866 * vars-atr.c: (is_system_missing) New function.
4868 Tue May 12 16:14:30 1998 Ben Pfaff <blp@gnu.org>
4870 * crosstabs.q: Expanded subcommand names RESID --> RESIDUAL, etc.
4871 (static var no_cells) Removed.
4872 (static var num_cells) New.
4873 (static var expected) New.
4874 (static var cells[]) New.
4875 (internal_cmd_crosstabs) Deal with new variables.
4876 (postcalc) Removed most of the meat and put it in new function
4877 output_pivot_table().
4878 (output_pivot_table) Calculates and outputs an entire pivot table.
4880 * postscript.c: (postopen) Fix problems with free()ing addresses
4881 not obtained from malloc().
4883 * som.c: (som_submit) Add assertion.
4885 * sysfile-info.c: (describe_variable) Use new tab_nulls()
4888 * tab.c: (static var tab_names[]) New.
4889 (tab_realloc) -1 for nc or nr indicates no change.
4890 (tab_nulls) New function.
4891 (tab_dim) Use tab_names[].
4892 (tabi_cumulate) Don't include bottom or right headers. Furrfu.
4893 (evaluate_dimensions) Don't terminate on uninited cells, just put
4894 an X in them and emit a notice. Use tab_names[].
4896 * tab.h: Move bits into tab.def.
4898 * tab.def: New. Don't try to declare tab_table_class because then
4899 som.h has to be included.
4901 Thu May 7 22:55:04 1998 Ben Pfaff <blp@gnu.org>
4903 * command.def: New file, contains all the command definitions
4904 previously included bodily in command.c.
4906 * format.def: New file, contains all of the format definitions
4907 previously split across format.h, format.c, and sfm-write.c.
4909 * lexer.h: Renamed from tokens.h in order to match corresponding
4912 * lexerP.h: Moved some rarely used functions exported by lexer.c
4915 * Makefile.am: Commemorate renamed files.
4916 (EXTRA_DIST) Add command.def, format.def.
4918 * command.c: [0] (walk_cmdtable_func) Removed.
4920 * crosstabs.q: (postcalc) Made it work and print out matrices
4922 (enum_column_values) Renamed enum_var_values, generalized for any
4925 * format.h: (struct fmt_desc) New member `spss'.
4927 * q2c.c: (main) Generated code includes lexer.h instead of
4930 * sfm-write.c: (write_format_spec) Use new spss member of fmt_spec
4931 instead of an independent translation table.
4933 Tue May 5 13:19:03 1998 Ben Pfaff <blp@gnu.org>
4935 * Lots of source files: Added const to declarations.
4937 * aggregate.c: (parse_aggregate_function) Rename inner i to j.
4939 * arena.c: (arena_clear) Set prev pointer to null when done.
4941 * ascii.c: (ascii_option) Rename index as indx.
4943 * avl.c: This is now a separate library called libavl.
4944 (xmalloc) Make static.
4945 (avl_probe) Step A7 can use the cache instead of an explicit
4947 (avl_delete) Don't maintain a q pointer because it's always
4948 available in the pointer stack. Comment fix.
4950 * avl.h: This is now a separate library called libavl.
4952 * command.c: (cmd_table[]) Remove spurious trailing "".
4954 * common.h: Only include random() fix if this system needs it.
4956 * crosstabs.q: Include alloca headers.
4957 (n_sorted_tab) New global var.
4958 (postcalc) Mostly rewritten.
4959 (find_pivot_extent) Rewritten.
4960 (enum_column_values) Rewritten.
4962 * data-out.c: (convert_F) Rename inner n as n_spaces.
4964 * error.c: (dump_message) Don't have an outer var i.
4966 * file-handle.q: (static var f) Removed. All references removed.
4967 (internal_cmd_file_handle) Uses a local variable instead of f.
4969 * get.c: (trim_dictionary) Change scope of i, i1, i2.
4970 (cmd_match_files) Don't strcpy tokstr into sbc (why was this ever
4973 * getline.h: Declare getl_history as extern. Reported by
4974 palme@uni-wuppertal.de (Hubert Palme).
4976 * postscript.c: (postopen) Some large mods for constness.
4978 * recode.c: Remove spurious copyrights since PSPP is owned by FSF
4981 Fri Apr 24 12:52:47 1998 Ben Pfaff <blp@gnu.org>
4983 * Makefile.am: Rename BUILT_SOURCES to q_sources, all references
4984 changed. Add avl.c, avl.h to pspp_SOURCES. Remove avllib from
4987 * avl.c, avl.h: New files. These form a clean-room
4988 reimplementation of avllib. Iterative algorithms are used in
4989 place of recursive ones, so there is no resemblance in the code.
4991 * Lots of headers: Don't include other headers by default.
4993 * Lots of source files: Explicitly include all needed headers.
4995 * arena.c: (arena_clear) New function.
4997 * crosstabs.q: (ROW_VAR, COL_VAR) New enums.
4998 (static var ar) Removed.
4999 (staitc vars ar_tc, ar_col) New.
5000 (cmd_crosstabs) Destroy the arenas.
5001 (internal_cmd_crosstabs) Create the arenas.
5002 (precalc) Don't need a free function for the hash.
5003 (calc_general) Make sure to zero out the trailer on the key data
5005 (print_table_entries) Updated.
5006 (postcalc) Worked on actually implementing.
5007 (find_pivot_extent) New function.
5008 (compare_value) New function.
5009 (enum_column_values) New function.
5011 * data-in.c: (parse_month) Make local array `static const'.
5013 * data-out.c: (convert_date) Make local array `static const'.
5014 (convert_WKDAY) Same.
5015 (convert_MONTH) Same.
5017 * frequencies.q: (postprocess_freq_tab) avl_walk_inorder() has
5018 been renamed to avl_walk().
5020 * hash.c: Rewritten more efficiently.
5022 * hash.h: Add attribute const to hsh_next_prime declaration.
5024 * lexer.c: (id_match) Make arguments const.
5026 * postscript.c: (ps_postopen_driver) Make default fonts the
5029 * q2c.c: (main) Generated code needs stdlib.h.
5031 * sfm-write.c: (write_value_labels) An avl_traverser needs to be
5032 initialized to 0 now, not to NULL. All other references to
5033 avl_traverser were updated in the same way.
5035 * tokens.h: Macro version of id_match updated to use const
5038 * val-labs.c: (inc_ref_count) New function.
5039 (copy_value_labels) Simply through use of new avl_copy() function.
5041 Wed Apr 15 13:01:58 1998 Ben Pfaff <blp@gnu.org>
5043 * crosstabs.q: Probably doesn't compile. New PIVOT subcommand.
5044 (postcalc) Worked on this.
5046 * postscript.c: (OPO_DOUBLE_LINE) New enum.
5047 (struct ps_driver_ext) New line_width_thick member.
5048 (ps_preopen_drive) Init line_width_thick.
5049 (option_tab[]) Add line-* options.
5050 (ps_option) Parse line-* options.
5051 (postopen) Add line_width_thick support. Strip leading spaces on
5052 prologue output lines.
5053 (ps_open_page) Include line_width_thick in output.
5054 (macro dump_thick_line) New.
5055 (dump_fancy_line) Support thick lines as well as double lines.
5057 Tue Apr 14 00:50:08 1998 Ben Pfaff <blp@gnu.org>
5059 * Makefile.am: Add crosstabs.c to BUILT_SOURCES. Add crosstabs.q
5060 to pspp_SOURCES. Add crosstabs.q to EXTRA_DIST.
5062 * Many source files: Rename `options' to `pv_opts' as appropriate.
5064 * command.c: (static var cmd_table[]) Add CROSSTABS command.
5066 * common.c: (xcalloc) New function.
5068 * crosstabs.q: New file. Not finished yet, though.
5070 * data-list.c: Comment fix.
5072 * error.c: Remove some old Checker cruft.
5074 * frequencies.q: (dump_full) Cumulate valid percent instead of
5077 * getline.c: Comment fix.
5079 * hash.c: Comment fixes.
5081 * hash.h: (struct hsh_table) Make hash functions return unsigned
5082 instead of int to avoid problems with taking the modulo of
5083 negative return values. All references changed.
5085 * misc.c: (intlog10) Make its table static const instead of auto.
5087 * sfm-read.c: (read_header) Make `prefix' static const instead of
5090 * var.h: (union value) Add member `hash'.
5091 (struct variable) Rename prv_index as `foo'--all references
5093 (typedef pv_opts) Removed. All references changed.
5095 * vars-prs.c: (parse_variables) Message fixes.
5097 Mon Mar 9 15:35:08 1998 Ben Pfaff <blp@gnu.org>
5099 * get.c: (cmd_match_files) Don't reverse the order of FILEs as
5100 they are being inserted. Don't check for BY variables of
5101 different types. Discard variables if the active file isn't
5102 included in the merge.
5103 (mtf_processing) Essentially rewritten.
5104 (mtf_merge_dictionary) Check for master/slave variables of
5105 different types/widths.
5107 * vfm.c: (static var not_canceled) New var.
5108 (process_active_file) Don't call vfm_source->read() if
5109 there's no vfm-source. Initialize not_canceled.
5110 (process_active_file_write_case) Honor and update not_canceled.
5111 (prepare_for_writing) Rollback changes from yesterday, they were
5113 (close_active_file) Don't destroy vfm_source unless it exists.
5115 Mon Mar 9 00:56:16 1998 Ben Pfaff <blp@gnu.org>
5117 * Lots of source files: Added { } around nested if/else constructs
5118 to avoid new gcc 2.8 warnings.
5120 * data-in.c: (parse_Z) Declare `int' type explicitly.
5123 * get.c: (struct mtf_file) Add prev, next_min, by, input members.
5124 (cmd_match_files) Initialize mtf_by_values. Manage by, input,
5125 prev members. Put TABLEs at the end of the chain and FILEs at the
5126 beginning. Don't allow the active file in STATE_INIT. Use proper
5127 `seen' value for the active file. Fill out the by members and
5128 make sure they're of consistent type. Do the actual merge
5130 (mtf_processing_finish) New function.
5131 (var_type_description) New function.
5132 (mtf_free_file) New function.
5133 (mtf_free) Rewritten.
5134 (mtf_delete_file_in_place) New function.
5135 (mtf_read_nonactive_records) New function.
5136 (mtf_compare_BY_values) New function.
5137 (static var mtf_seq_no) New var.
5138 (mtf_processing) New function.
5139 (mtf_merge_dictionary) Assign nval members for the system file
5140 dictionary. Assign fv values for its variables. Point each slave
5141 variable to the corresponding master variable.
5143 * hash.c: Include str.h.
5145 * mis-val.c: (copy_missing_values) src arg is const.
5147 * misc.c: (spacing) Make `max' var explicitly int.
5149 * sfm-read.c: (dump_dictionary) Message reformatting.
5150 (sfm_read_case) Add assertion.
5152 * sort.c: Esthetic fixes.
5154 * var.h: (struct match_files_proc) New struct.
5155 (struct variable) Add private data match_files_proc.
5157 * vars-atr.c: (delete_variable) Implement. Add argument for the
5158 dictionary that owning the variable.
5159 (dup_variable) Add assertion.
5161 * vfm.c: Comment fixes, hopefully the comments are correct now.
5162 (process_active_file) New function.
5163 (process_active_file_write_case) New function.
5164 (process_active_file_output_case) New function.
5165 (prepare_for_writing) Use temp_dict->nval for vfm_info, not
5167 (write_case) Renamed procedure_write_case(). Now write_case is a
5168 pointer to a function. Style fixes.
5170 1998-03-05 Ben Pfaff <blp@gnu.org>
5172 * Makefile.am: (q2c) Link with libmisc.
5173 (version.c) Define default_config_path, include_path,
5176 * ascii.c: (ascii_postopen_driver) When the default newline string
5177 is requested, open file in text mode. Suggested by
5178 palme@uni-wuppertal.de (Hubert Palme).
5179 (static vars line_buf, line_p) Change from char * to unsigned char
5181 (ascii_close_page) char * to unsigned char *.
5183 * cmdline.c: (parse_command_line) Implement -r option by
5184 prepending ~/.pspp/rc to the list of files to process.
5186 * command.c: (cmd_remark) Reset getl_prompt to the standard prompt
5187 before pulling in a final line.
5188 (null_func, null_int_func) Removed (dead code).
5190 * descript.q: (display) Calculate width of variable name column
5191 properly. Calculate number of valid cases properly. Reported by
5192 palme@uni-wuppertal.de (Hubert Palme).
5194 * filename.c: (init_filename) Use default_config_path instead of
5195 now obsolete CONFIG_PATH.
5197 * getline.c: (getl_initialize) Use include_path instead of now
5198 obsolete INCLUDE_PATH.
5199 (getl_add_file) New argument `where'. All references changed.
5201 * groff.c: (find_font_file) Use groff_font_path instead of now
5202 obsolete GROFF_FONT_PATH.
5204 * postscript.c: (find_ps_file) Use groff_font_path instead of now
5205 obsolete GROFF_FONT_PATH. Copy through temporary variable to
5206 avoid problems with constness.
5208 * str.h: (macro cs_streq) New macro.
5210 * version.h: (glob var default_config_path, include_path,
5211 groff_font_path) New vars.
5213 1998-02-23 Ben Pfaff <blp@gnu.org>
5215 * Many source files: Change verbose_msg() priority levels and
5218 * aggregate.c: Include debug-print.h.
5220 * cmdline.c: (parse_command_line) Add --safer/-s and --command/-c
5222 (static var pre_syntax_message) Document --safer/-s and
5225 * command.c: (cmd_erase, cmd_host) Disable if set_safer is set.
5227 * dfm.c: (open_inline_file) [__CHECKER__] Zero out ext->file,
5228 because it's not used but it's still copied.
5229 (open_file_r) Remove gratuitous debug message.
5231 * filename.c: (safety_violation) New function.
5232 (open_file) Remove gratuitous debug messages. Don't allow pipe
5233 files if set_safer is set.
5235 * get.c: Turn off debugging.
5237 * getline.c: (getl_add_virtual_file) New function.
5238 (getl_read_line) Add verbose_msg() call for opening new syntax
5240 (getl_perform_delayed_reset) Add a return value describing whether
5241 any action was taken. Call reset_eof().
5243 * getline.h: Comment fix.
5245 * groff-font.c: (groff_read_font) Use `goto next_iteration' in
5246 place of incorrect `continue'. Use strtok_r() instead of
5247 strtok(). Always check strtok_r() return value.
5248 (groff_read_DESC) Use strtok_r() instead of strtok().
5250 * lexer.c: (reset_eof) New function.
5252 * main.c: (parse) Get a token after performing a delayed reset
5253 action; allow empty syntax files.
5255 * postscript.c: (output_encodings) Use strtok_r() instead of
5258 * q2c.c: (dump_parser) Use strtok_r() instead of strtok().
5260 * set.q: Comment fixes.
5261 (glob var set_safer) New var.
5262 (internal_cmd_set) Support SAFER.
5264 * str.h: [!HAVE_STRTOK_R] Declare strtok_r() prototype.
5266 * temporary.c: (free_dictionary) Set d->splits to NULL after
5269 * vars-atr.c: (clear_variable) Decrement dict->n_splits if
5270 variable deleted, not if it *isn't* deleted.
5272 1998-02-16 Ben Pfaff <blp@gnu.org>
5274 * command.c: (array cmd_table[]) Add MATCH FILES.
5276 * common.c: Comment fixes.
5278 * data-list.c, dfm.c, error.c, filename.c, list.q, matrix-data.c,
5279 modify-vars.c, postscript.c, sfm-read.c, sfm-write.c, tab.c:
5280 Include alloca.h. Problem reported by palme@uni-wuppertal.de
5283 * expr-opt.c: Include str.h. Problem reported by
5284 palme@uni-wuppertal.de (Hubert Palme).
5286 * get.c: (cmd_get) [DEBUGGING] Update v->p.get to v->get.
5287 (static var mtf_by) Change from char ** to variable **.
5288 (static var mtf_master) New var.
5289 (mtf_merge_dictionary) New function.
5290 (cmd_match_files) Init mtf_master. Parse mtf_by according to new
5291 var type. Reorder tests properly. Initialize file->dict. Detect
5292 TABLE= without BY=. Read file dictionaries and merge them. Give
5293 subcommand name with IN, LAST, FIRST error messages. Create IN,
5294 LAST, FIRST variables. Comment fixes.
5295 (mtf_free) Don't free default_dict. Free mtf_master.
5297 * getline.c: Define getl_mode. Change getl_buf_size to size_t
5299 (handle_line_buffer) Cast int to size_t in comparison to avoid
5302 * getline.h: Declare getl_mode extern.
5304 * groff-font.c: (groff_read_font) Type-fix calls to getline.
5305 (groff_read_DESC) Make line_size a size_t.
5306 (match_tok) Parenthesize name to avoid macro expansion.
5308 * mis-val.c: (copy_missing_values) New function.
5310 * postscript.c: (postopen) Make buf_size a size_t.
5312 * sfm-read.c: (dump_dictionary) Make global from static. Print
5313 variable info in parts for easier debugging with Checker.
5315 * temporary.c: (copy_variable) Use copy_value_labels().
5316 (new_dictionary) New arg: whether to copy file label, documents.
5318 * val-labs.c: (copy_value_labels) New function.
5320 * var.h: (enums MISSING_*) Add MISSING_COUNT.
5322 * vars-atr.c: [GLOBAL_DEBUGGING] (force_dup_variable) New
5324 (dup_variable) Set prv_index, get.fv, get.nv.
5326 Fri Feb 13 15:38:36 1998 Ben Pfaff <blp@gnu.org>
5328 * Makefile.am: (pspp_SOURCE) Add htmlP.h.
5330 * Many source files: For ANSI-compliance, add empty statement
5331 after label. Reported by palme@uni-wuppertal.de (Hubert Palme)
5332 and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
5334 * data-in.c: (parse_numeric) Some header files break on
5335 -DBL_MIN_10_EXP because they get a --; add () for safety.
5336 Reported by palme@uni-wuppertal.de (Hubert Palme).
5338 * dfm.c: Idea by Dr Eberhard W Lisse <el@linux.lisse.na>.
5339 (struct dfm_fhuser_ext) Change `file' from FILE * to file_ext.
5340 (dfm_close) Use close_file_ext.
5341 (open_inline_file) Set file.file to NULL, not file.
5342 (open_file_r, open_file_w) Initialize file.file; fill in file_ext
5343 struct and use open_file_ext().
5344 (read_record) Use file.file.
5346 * file-handle.q: (prepend_current_directory) Pass through special
5349 * filename.c: Only include unistd.h if HAVE_UNISTD_H.
5350 (normalize_filename) Pass through special filenames.
5351 (open_file, close_file) Accept pipe| and |pipe syntaxes as
5353 (dirname) Rename blp_dirname() because of name conflict on some
5354 OS. All references changed. Reported by palme@uni-wuppertal.de
5356 (is_special_filename) New function.
5358 * get.c: (GTSV_OPT*) Add GTSV_OPT_MATCH_FILES.
5359 (trim_dictionary) Conditionalize some of the options on whether
5360 GTSV_OPT_MATCH_FILES is in *options.
5361 (rename_variables) Don't allow variables to be renamed as scratch
5363 (MTF_*) New enum series.
5364 (struct mtf_file) New struct.
5365 (static vars mtf_head, mtf_tail, mtf_by, mtf_n_by, mtf_free) New
5367 (cmd_match_files, mtf_free) New functions.
5369 * lexer.c: (match_int) Needed parentheses around name to escape
5370 macro expansion. Reported by Micah Altman
5371 <maltman@www-vdc.fas.harvard.edu>.
5373 * print.c: Needed to include alloca.h. Reported by Micah Altman
5374 <maltman@www-vdc.fas.harvard.edu>.
5376 * recode.c: (convert_to_double) Parenthesize -DBL_MIN_10_EXP to
5377 -(DBL_MIN_10_EXP). Reported by palme@uni-wuppertal.de (Hubert
5380 * str.h: Include stdarg.h. Reported by palme@uni-wuppertal.de
5381 (Hubert Palme) and Micah Altman <maltman@www-vdc.fas.harvard.edu>.
5383 Thu Feb 5 00:18:21 1998 Ben Pfaff <blp@gnu.org>
5385 * html.c: (struct html_driver_ext) Move into htmlP.h.
5386 (html_preopen_driver) Initialize cp_x, cp_y.
5387 (html_submit) Implement as call to output_tab_table().
5388 (change_attributes) New function.
5389 (escape_string) New function.
5390 (output_tab_table) New function.
5392 * list.q: (write_all_headers) Add code for writing headers for the
5394 (clean_up) Write out the html close-table tag.
5395 (determine_layout) Ignore html driver.
5396 (list_cases) Write html data.
5398 * som.c: (som_submit) Move more of the code into output_table().
5400 * tab.c: (static var hit) Make a global var and rename tab_hit.
5401 (static var tab_table_class) Make a global var.
5403 * htmlP.h: New file.
5405 Tue Feb 3 16:12:18 1998 Ben Pfaff <blp@gnu.org>
5407 * dump-sysfile.c: Removed.
5409 * html.c: (preclose) Change comment in emitted code.
5411 * matrix-data.c: Debugging off by default. Comment fixes.
5412 (static var container) New var.
5413 (cmd_matrix_data) Create and destroy container. Initialize
5414 is_per_factor[] to 0s. Move code into new function
5415 string_to_content_type(). Require split values to be present in
5416 the data when ROWTYPE_ is explicit. Call specific function, not
5417 general read_matrices().
5418 (string_to_content_type) New function.
5419 (context) Exclude all whitespace, not just spaces.
5420 (mget_token) A dot is a number. Add assertion.
5421 (static var data) Renamed nr_data.
5422 (static var factor_values) Renamed nr_factor_values.
5423 (read_matrices) Renamed read_matrices_without_rowtype(). Handle
5424 only specific case. Close data_file before exit.
5425 (fill_matrix) New function.
5426 (read_data_lines) Renamed nr_read_data_lines(). Remove debug
5427 printing. Style fixes. Message fixes. Move code into
5429 (read_matrices_without_rowtype) Rename
5430 matrix_data_read_without_rowtype(). Fix off-by-one error on
5431 loops. Allocate nr_data[] memory from arena.
5432 (read_matrices_with_rowtype) Removed.
5433 (read_splits) Renamed nr_read_splits(). Style fixes.
5434 (read_factors) Renamed nr_read_factors().
5435 (dump_cell_content) Comment fixes. Arguments changed. Change
5436 debug printing. All references changed.
5437 (output_data) Renamed nr_output_data().
5438 (static var wr_content) New var.
5439 (struct factor_data) New struct.
5440 (static var wr_data) New var.
5441 (static var wr_current) New var.
5442 (matrix_data_source_destroy_source) Removed.
5443 (read_matrices_with_rowtype) New function.
5444 (matrix_data_read_with_rowtype) New function.
5445 (wr_read_splits) New function.
5446 (compare_factors) New function.
5447 (wr_output_data) New function.
5448 (wr_read_rowtype) New function.
5449 (wr_read_factors) New function.
5450 (wr_read_indeps) New function.
5451 (glob var matrix_data_source) Make destroy_source member NULL as
5454 Fri Jan 23 00:09:08 1998 Ben Pfaff <blp@gnu.org>
5456 * lexer.c: (syntax_error) Give better error message when at end of
5459 * matrix-data.c: (var content_names[]) Fix PROX spelling. Change
5460 N_SCALAR to output as plain N.
5461 (mdump_token) Change output format.
5462 (context) Fix message output interaction with spaces in input.
5463 (another_token) New function.
5464 (force_eol) Improved error message.
5465 (static var max_cell_index) New var.
5466 (read_matrices) Init `cells'. factor_values is now per-cell.
5467 Init max_cell_index.
5468 (read_data_lines) Replace `compare' local with new `compare' arg.
5469 Debugging messages changed. Only read factors if per_factor.
5470 Propagate error return from read_factors(), force_eol().
5471 Copy N_SCALAR values across the N vector.
5472 (read_matrices_without_rowtype) Don't init `cells'. Don't need to
5473 check parentheses manually since we now have is_per_factor[].
5474 Call read_data_lines() with new args. Check for end of data after
5475 looping, using another_token().
5476 (read_factors) Arguments changed. Use max_cell_index to determine
5477 whether to read or compare factors. Message fixes.
5478 (dump_cell_content) New function.
5479 (output_data) Completely rewritten because content types were
5480 supported to be nested inside factor values, not vice versa.
5482 Thu Jan 22 00:26:38 1998 Ben Pfaff <blp@gnu.org>
5484 * lexer.c: (syntax_error) Support formatted varargs messages.
5486 * matrix-data.c: Turn debugging on by default.
5487 (static content_type[]) New array.
5488 (static content_names[]) New array.
5489 (static rowtype_, varname_) New vars.
5490 (static is_per_factor[]) New array.
5491 (static split_values) Moved declaration.
5492 (static n_continuous, first_continuous) New var.
5493 (cmd_matrix_data) Don't init split_values. Assign ROWTYPE_ to
5494 rowtype_. Simplify SPLIT code. Init is_per_factor[]. Assign
5495 VARNAME_ to varname_. Initialize first_continuous, n_continuous.
5496 Check for continuous variables.
5497 [DEBUGGING] (debug_print) Remove content_names[].
5498 (mdump_token) New macro.
5499 (mget_token_dump) New function.
5500 (mdump_token) New function.
5501 (context) New function.
5502 (mget_token) Fix messages.
5503 (static var data, split_values, factor_values) New vars.
5504 (read_matrices) Manage split_values, factor_values.
5505 (read_data_lines) New function.
5506 (read_matrices_without_rowtype) Implemented.
5507 (read_splits) Message fixes. Uses `just_read'.
5508 (read_factors) New function.
5509 (output_data) New function.
5510 (matrix_data_source_destroy_source) Close the file handle.
5511 (glob var matrix_source) Change name from "DATA LIST" to "MATRIX
5514 * str.c: (strpadcmp) Removed.
5516 * vfm.c: (dump_splits) Initialize i; fix test for end of splits.
5518 Sun Jan 18 00:30:59 1998 Ben Pfaff <blp@gnu.org>
5520 * Lots of source files: Add cast to unsigned character to calls to
5521 tolower() and toupper().
5523 * aggregate.c: Set default_dict.splits to NULL.
5525 * command.c: (static variable tab[]) Add MATRIX DATA.
5527 * data-in.c: Add debugging defines. Formatting fixes.
5529 * expr-opt.c: Formatting fixes.
5531 * lexer.c: (syntax_error) Message fixes.
5533 * matrix-data.c: New enum series.
5534 (static vars fmt, section, diag, explicit_rowtype, signle_split,
5535 split_values, n_factors, factors, cells, pop_n, contents,
5536 n_contents) New vars.
5537 (cmd_matrix_data) Finished implementation.
5538 (compare_variables_by_mxd_vartype) New function.
5539 [DEBUGGING] (debug_print) New function.
5540 (static vars mtoken, mtokstr, mtoklen, mtokval) New vars.
5541 (read_matrices) New function.
5542 (read_matrices_without_rowtype) New function.
5543 (read_matrices_with_rowtype) New function.
5544 (read_splits) New function.
5545 (mget_token) New function.
5546 (force_eol) New function.
5547 [0] (test_tokenizer) New function.
5548 (matrix_data_source_destroy_source) New function.
5549 (glob var matrix_data_source) New var.
5551 * misc.h: Include ieeefp.h if present.
5553 * split-file.h: (cmd_split_file) Changes corresponding to struct
5556 * str.h: Fix memmem prototype.
5558 * temporary.c: (save_dictionary, restore_dictionary,
5559 free_dictionary) Changes corresponding to struct dictionary
5562 * var.h: (MXD_* enums) New enum series.
5563 (struct matrix_data_proc) New struct.
5564 (struct split) Removed.
5565 (struct dictionary) Changed `splits' member from `split *' to
5567 (macro force_create_variable) New macro. Replaced lots of
5568 create_variable()/assert() calls with calls to this macro.
5570 * vars-atr.c: (discard_variables) Changed assertion.
5571 [GLOBAL_DEBUGGING] (force_create_variable) New function
5572 called by the macro of the same name.
5573 (clear_variable) Changes to delete splits from the dictionary
5574 corresponding to struct dictionary changes.
5576 * vars-prs.c: (parse_variables) [GLOBAL_DEBUGGING] Check for
5577 corrupted variable `index' values in the dictionary passed in
5578 every time this function is called.
5580 * vfm.c: (dump_splits, SPLIT_FILE_procfunc) Changes corresponding
5581 to struct dictionary changes.
5583 Tue Jan 13 23:45:02 1998 Ben Pfaff <blp@gnu.org>
5585 * Makefile.am: (pspp_SOURCES) Add matrix-data.c.
5587 * command.c: New includes.
5588 (static array cmd_table[]) Add ERASE, HOST, NEW FILE.
5589 (cmd_erase) New function.
5590 [unix] (shell) New function.
5591 (run_command) New function.
5592 (cmd_host) New function.
5593 (cmd_new_file) New function.
5595 * expr-prs.c: (parse_primary) Message fix.
5597 * inpt-pgm.c: Formatting fix.
5598 (cmd_reread) Implement the FILE subcommand.
5600 * matrix-data.c: New file.
5602 * q2c.c: (dump_header) Change output commenting style.
5604 * weight.c: Comment fix.
5606 Tue Jan 13 00:53:39 1998 Ben Pfaff <blp@gnu.org>
5608 * aggregate.c: (buf64_10x) Renamed buf64_1xx, all references
5610 (buf_10x) Renamed buf_1xx, all references changed.
5611 (cmd_aggregate) Implemented cases 010, 011, 110, and 111 (all
5612 cases now implemented).
5613 (create_sysfile) New function.
5614 (agr_11x_func) New function.
5616 * data-in.c: (parse_numeric) Work properly if there's an
5617 explicitly coded decimal point in the data and decimal places are
5618 specified on DATA LIST. Bug reported by Dr Eberhard W Lisse
5619 <el@linux.lisse.na>.
5621 * get.c: (cmd_get, cmd_save_internal) Allow extraneous slash
5622 before file specification on GET, SAVE, XSAVE. Bug reported by Dr
5623 Eberhard W Lisse <el@linux.lisse.na>.
5625 * q2c.c: [!HAVE_STRERROR] Include misc/strerror.c, not
5626 strerror.c. Bug reported by Alexandre Oliva
5627 <oliva@dcc.unicamp.br>.
5629 * sort.c: Include sort.h. Comment fixes. A few esthetic fixes.
5630 (static var separate_case_tab) New var.
5631 (cmd_sort_cases) Cancel temporary transformations here. Free
5632 v_sort before return.
5633 (sort_cases) Run an EXECUTE procedure if SEPARATE is nonzero and
5634 we're reading from a sort stream. Don't cancel temporary
5635 transformations. Offload internal sorting to do_internal_sort().
5636 (do_internal_sort) New function. Handles internal sorting even
5637 when SEPARATE is nonzero. Doesn't free v_sort.
5638 (do_external_sort) Take new arg SEPARATE. Only destroy `x' if
5640 (write_initial_runs) Take new arg SEPARATE. Only destroy the old
5641 sink if SEPARATE is zero.
5642 (read_output_cases) Renamed read_sort_output(), all references
5643 changed. Now uses separate_case_tab when it exists.
5644 (write_separate) New function.
5646 * vfm.c: (page_to_disk) Destroy memory_source_cases, not
5647 memory_sink_cases. Don't redundantly call
5648 vfm_source->destroy_source().
5649 (memory_stream_mode) After switching over, set memory_sink_cases
5652 Sat Jan 10 23:35:51 1998 Ben Pfaff <blp@gnu.org>
5654 * aggregate.c: (struct agr_var) Expand dbl[] array from 2 to 3
5656 (static var prev_case) New, moved out of aggregate_single_case()
5658 (static var buf64_10x, buf_10x) New.
5659 (cmd_aggregate) Initialize prev_case. Comment fixes. Implement
5660 the 000, 001, 100, and 101 cases. Free prev_case.
5661 (parse_aggregate_functions) Disallow scratch variables.
5662 (free_aggregate_functions) Only free agr_dict if non-null. Use
5663 iter->function to determine numeric/string type, not
5665 (aggregate_single_case) Don't manage prev_case. Initialize
5666 aggregate info after dumping it.
5667 (accumulate_aggregate_info) Fix sum, weighted sum, mean, weighted
5668 mean, stddev, weighted stddev definitions.
5669 (dump_aggregate_info) Implemented.
5670 (initialize_aggregate_info) Renamed from
5671 initialize_aggregate_functions(). Initializes dbl[2].
5672 (agr_00x_trns_proc, agr_00x_end_func, write_case_to_sfm,
5673 agr_10x_trns_proc, agr_10x_trns_free, agr_10x_end_func) New.
5675 * cases.c: (alloc_val) Removed.
5677 * get.c: (cmd_save_internal) Initialize new `dict' member.
5679 * sfm-write.c: (sfm_write_dictionary, write_header,
5680 write_variable, write_value_labels, write_documents) Reorganize,
5681 simplify for new parameter structure.
5682 (write_variable) Only one variable * argument now.
5684 * sfm.h: (struct sfm_write_info) Removed `pri', `sec', and
5685 replaced by new `dict' member.
5687 * temporary.c: (new_dictionary) Initialize n_documents.
5689 * vars-atr.c: (dup_variable) Allocate `value's from dict into
5691 (init_variable, replace_variable) Eliminate usage of alloc_val().
5693 * vars-prs.c: (parse_DATA_LIST_vars) Accept PV_NO_SCRATCH option.
5695 * vfm.c: (arrange_compaction) Allow `temporary' value of 2 to
5696 signal that AGGREGATE is to be used for forming final cases.
5697 (close_active_file) Call end_func before stopping lagging. Cancel
5698 temporary after finishing compaction.
5699 (write_case) Comment fixes. Cleaned up.
5700 (compact_case) Let AGGREGATE handle compaction when `temporary' is
5703 Sat Jan 10 02:10:47 1998 Ben Pfaff <blp@gnu.org>
5705 * Makefile.am: (BUILT_SOURCES) Add means.c.
5706 (pspp_SOURCES) Add means.c.
5707 (EXTRA_DIST) Add means.q.
5709 * command.c: (array cmd_table[]) Add MEANS.
5711 * common.h: Esthetic fixes. Comment fixes. Test for
5712 MAX_SHORT_STRING greater than 8.
5713 (macros LOWEST, HIGHEST) New.
5715 * data-in.c, data-list.c, recode.c: Comment fixes.
5717 * means.q: New file, base version.
5719 * mis-val.c: (parse_num_or_range, parse_numeric) Replace -DBL_MAX
5720 with LOWEST, DBL_MAX with HIGHEST.
5722 * q2c.c: (dump_vars) Add an enum to array types giving the number
5723 of values for the enum.
5725 * sfm-read.c: (sfm_read_dictionary, read_machine_flt64_info)
5726 Replace second_lowest_value with second_lowest_flt64.
5728 * sfm-write.c: (write_variable, write_rec_7_34) Replace
5729 second_lowest_value with second_lowest_flt64.
5731 * t-test.q: Comment fix.
5733 * temporary.c: (restore_dictionary) Esthetic fix.
5735 * tokens.h: (force_match_id, force_match, force_string, force_int,
5736 force_num, force_id) Replace msg() with syntax_error().
5738 * var.h: (struct means_proc) New.
5739 (struct variable) Add mns member to `p' union.
5741 * vars-prs.c: (parse_variable, parse_dict_variable,
5742 parse_variables, parse_DATA_LIST_vars) Replace msg() with
5745 Thu Jan 8 22:28:41 1998 Ben Pfaff <blp@gnu.org>
5747 * Makefile.am: (pspp_SOURCES) Add tab.h.
5749 * Most source files: Added a cast to unsigned char in usages of
5750 the ctype is*() functions. Replaced `end of command expected'
5751 calls to msg() with calls to syntax_error().
5753 * frequencies.q: (dump_condensed) Fix tab_dim() column reference.
5755 * lexer.c: (hex_val) Removed (was dead code).
5756 (idmatch) Parenthesize function name to avoid macro expansion.
5758 * postscript.c: Comment fixes.
5759 (ps_preopen_driver) Change default font size to 10pt.
5761 * sfm-read.c: (read_variables) Byteswap sv.print, sv.write as
5763 (parse_format_spec) Change system-file format spec argument type
5764 to int32. Parse the format spec with bitwise operators.
5766 * sfmP.h: (struct sysfile_format) Removed.
5767 (struct sysfile_variable) Changed print, write members from
5768 sysfile_format to int32.
5770 * tokens.h: Esthetic fixes.
5771 [__GNUC__] (macro id_match) New macro to hopefully speed up
5772 identifier matching.
5773 (macros match_id, match_tok, match_int) Implemented in
5774 compiler-independent manner; no longer GNU C only.
5776 * vfm.h: Include time.h.
5778 Mon Jan 5 11:06:15 1998 Ben Pfaff <blp@gnu.org>
5780 * data-list.c: (dump_fixed_table) Change tab_dim().
5782 * dump-sysfile.c: (open_sysfile) Fix mmap() call.
5784 * error.c: Include command.h.
5786 * frequencies.g: Formatting fixes.
5788 * frequencies.q: Add tab_dim() calls. Make the total cell a
5791 * glob.c: Include command.h.
5793 * sfm-read.c: (struct sfm_fhuser_ext) New members sysmis, highest,
5795 (sfm_read_dictionary) Initialize sysmis, highest, lowest.
5796 (sfm_read_machine_flt64_info) Update sysmis, highest, lowest.
5797 (read_variables) Byteswap sv.type; byteswap sv.print, sv.write as
5798 the other elements (is this right?).
5799 (read_variables) Use lowest, highest members.
5800 (parse_format_spec) New arg `vv' for more stringent checking.
5801 (dump_dictionary) Byteswaps nonexplicit data.
5802 (sfm_read_case) Byteswap numeric data.
5804 * som.c: Initialize table_num to 1.
5805 (render_segments) Remember to increment y_index after each table
5808 * sysfile-info.c: (cmd_sysfile_info) Change tab_dim(). Don't call
5809 avl_count() on a NULL tree. No title for the second table.
5810 (cmd_display) Handle DISPLAY VECTORS by calling display_vectors().
5811 Handle AS_SCRATCH as AS_NAMES. Warn if no variables. Re-enable;
5812 fix call to display_variables().
5813 (display_variables) Default to 4 columns, not 3. Set up headers.
5814 Column title is Variable, not Name. Fix index column.
5815 Add joint text. Add tab_dim(). Handle value labels properly.
5816 Handle DISPLAY LABELS properly. Draw boxes correctly.
5817 (describe_variable) Value labels don't need titles. Don't clear
5818 nonexistent index column.
5819 (compare_vectors_by_name) New function.
5820 (display_vectors) New function.
5822 * tab.c: (tab_height) Add assertion.
5823 (tab_null) Add debug code.
5824 (evaluate_dimensions) Add debug code.
5826 * var.h: (struct variable) get_proc data is sometimes used
5827 simultaneously with other per-procedure info, therefore it was
5828 removed from the union. All references changed.
5830 Sun Jan 4 18:13:33 1998 Ben Pfaff <blp@gnu.org>
5832 * ascii.c: (ascii_close_page) Put title on second line of headers
5833 if there is no subtitle.
5835 * command.c: (glob var cur_proc) Move definition here, from
5837 (cmd_remark) Emit blank line before remarks.
5839 * command.h: (glob var cur_proc) Move declaration here, from
5842 * data-list.c: (dump_fixed_table) Fix messages.
5843 (dump_free_table) Call tab_nat_dim().
5845 * descript.q: (dump_z_table) Modify tab_dim() call.
5847 * frequencies.q: (dump_condensed, dump_statistics) Add tab_dim()
5849 (dump_statistics) Don't output header.
5851 * groff-font.c: Minor format fix.
5853 * html.c: Comment fix.
5855 * list.q: (write_varname) Indent after advancing page.
5857 * output.h: Minor reordering.
5859 * postscript.c: Comment fixes. Many places, '\n' was replaced by
5860 a reference to eol[].
5861 (struct ps_driver_ext) New member eol[].
5862 (ps_preopen_driver) Initialize eol[].
5863 (ps_postopen_driver) Fix sense of text for text_opt, line_opt
5864 defaults. Handle headers. Fix test for minimum page length.
5865 (static var option_tab[]) Add `line-ends'.
5866 (ps_option) Handle line-ends to change eol[].
5867 (postopen) Scale prop_em_width and fixed_width properly. Set the
5868 prologue title to outp_title if applicable. Replace the prologue
5869 line ends with eol[]. Call draw_headers() if headers are enabled.
5870 (text_width) New function.
5871 (out_text_plain) New function.
5872 (draw_headers) New function.
5874 * print.c: (dump_table) Call tab_nat_dim().
5876 * som.c: (som_blank_line) Only advance a line if not at the top of
5878 (som_submit) Move several informational table calls here.
5879 Increment subtable_num if SOMF_NO_TITLE not set.
5880 (output_table) Advance a line if SOMF_NO_SPACING not set.
5881 (render_columns, render_segments, render_simple) Handle spacing
5882 between tables. Handle table titles. Remove debug output.
5884 * som.h: (SOMF_*) New enum series.
5885 (struct som_table_class) New member `flags'.
5887 * sysfile-info.c: (cmd_sysfile_info) Calls tab_nat_dim(). No
5889 (display_variables) Calls tab_nat_dim().
5890 (describe_variable) Remove restriction on number of value labels.
5891 Make value labels separated by thin lines.
5893 * tab.c: (tab_create) Default `flags' to none.
5894 (tab_float) New arg `w'. All references changed.
5895 (tab_nat_dim) New function.
5896 (tab_output_text) No title or spacing.
5897 (tab_flags) New function.
5898 (tabi_flags) New function.
5899 (tabi_title) New function.
5900 (strip_height) Removed.
5901 (tabi_render) Skip title when necessary.
5902 (static var tab_tab_class) Add tabi_flags, tabi_title.
5903 (evaluate_dimensions) Disable display of column, row size.
5904 (sum_columns) Add title height to top header.
5905 (render_strip) Moved within file.
5907 * tab.h: (struct tab_table) New member `flags'.
5909 * vfm.c: (dump_splits) Calls tab_nat_dim(). No title.
5911 Sat Jan 3 16:55:44 1998 Ben Pfaff <blp@gnu.org>
5913 * Most source files: Add `const' attribute in all appropriate
5916 * sysfile-info.c: (cmd_sysfile_info) Add tab_dim() call, add a
5917 column to the variables table for use by describe_variable().
5918 (cmd_display) Disable for the present.
5919 (display_documents) Don't wrap documents.
5920 (display_variables) Table has four columns now.
5921 (describe_variable) Table has four columns now. Don't use a
5922 subtable, use joined cells instead.
5924 * tab.c: (tab_create) Don't set `join'.
5925 (tab_realloc) ct array is not made up of a_string's.
5926 Reallocate trh, hrh, h arrays, initialize trh array. Initialize
5927 cell contents on GLOBAL_DEBUGGING, not DEBUGGING.
5928 (text_format) New function.
5929 (tab_title) Rewritten, uses text_format().
5930 (tab_text) Rewritten, uses text_format().
5931 (tab_joint_text) New function.
5933 (static var hit) New variable.
5934 (render_strip) New args r1, r2. Implement joined cells that fit
5936 (tabi_render) Increment hit. Pass new args to render_strip().
5937 (evaluate_dimensions) [GLOBAL_DEBUGGING] Check for uninitialized
5938 cells. For t_naw and t_nah, ignore joined cells and null cells in
5941 * tab.h: (struct tab_join_rect) Removed.
5942 (struct tab_table) Removed `join'.
5943 (TAB_JOIN_MAIN) Removed.
5944 (struct tab_joined_cell) New struct.
5945 (TAT_NOWRAP) New enum.
5947 Fri Jan 2 01:39:58 1998 Ben Pfaff <blp@gnu.org>
5949 * ascii.c: (ascii_postopen) Replace ASCII_* macros with their
5951 (ascii_postopen_driver) Fix initialization of *_spacing so that
5952 the TAL_0 bit doesn't count.
5954 * data-list.c: (dump_fixed_table) Use natural width for Format
5957 * glob.c: (rerange) Removed.
5958 (get_date) Formatting fixes. Internationalization fix.
5960 * html.c: (html_postopen_driver) Replace HTML_DEFAULT_OUTPUT_FILE
5963 * postscript.c: (ps_postopen_driver) Replace
5964 PS_DEFAULT_OUTPUT_FILE with "pspp.ps".
5966 * som.c: (som_submit) Don't eject page before every table.
5967 (output_table) Fix order of arguments on call to area().
5968 (render_columns) Fix calculation of max_len.
5970 * tab.c: (tabi_cumulate) Minor change to increase elegance.
5971 (render_strip) New function.
5972 (strip_height) New function.
5973 (tabi_render) Rewrite as calls to render_strip().
5975 * tab.h: (TAT_* enums) Removed TAT_RICH, all references removed.
5976 Renumbered TAT_PRINTF, TAT_TITLE, TAT_FIX to correspond better
5977 with the TAB_* and OUTP_T_* constants.
5979 Thu Jan 1 11:53:52 1998 Ben Pfaff <blp@gnu.org>
5981 * Makefile.am: Formatting fixes.
5983 * ascii.c: (ascii_postopen_driver) Initialize *_line_spacing[],
5986 * data-list.c: (dump_fixed_table) Add tab_dim() call.
5988 * descript.q: (dump_z_table, display) Add tab_dim() calls.
5990 * dump-sysfile.c: (glob var length) Make type off_t.
5991 (usage) Fix arguments.
5994 * output.h: (OUTP_T_*) Change constants' value to match tab.h.
5995 Now right-justification is the default so many references had to
5997 (struct outp_class) Removed line_width, all references changed.
5998 (OUTP_DEV_*) Add OUTP_DEV_DISABLED.
5999 (struct outp_driver) Add elements horiz_line_width,
6000 vert_line_width, horiz_line_spacing, vert_line_spacing. Remove
6003 * postscript.c: (outp_encodings) Formatting fixes. Fix garbage
6005 (postopen) Initialize all the informational members of
6008 * som.c: (som_blank_line) New function, renamed from blank_line(),
6009 all references changed.
6010 (som_submit) Disables drivers whose pages can't be opened.
6011 (render_columns, render_simple, render_segments) Add debug output.
6012 (render_columns) Fix loop range.
6013 (render_simple) Don't try to render the headers, they're taken
6014 care of automatically. Advance cp_y past the table when done.
6015 (render_segments) Fix loop ranges.
6017 * tab.c: Initialize new members of tab_table.
6018 (tab_vline) Handle trv[]; don't set style for spacing-only lines.
6019 (tab_hline) Handle trh[]; don't set style for spacing-only lines.
6020 (tab_box) Handle trh[], trv[]; don't set style for spacing-only
6023 (tab_dim) New function.
6024 (tab_col_width) Removed.
6025 (tab_row_height) Removed.
6026 (tab_output_text) Call tab_dim().
6027 (tabi_driver) Call evaluate_dimensions(), sum_columns().
6028 (tabi_area) Implemented.
6029 (tabi_cumulate) Implemented.
6030 (tabi_render) Partially implemented, but broken.
6031 (var tab_table_class) Made static.
6032 (evaluate_dimensions) New function.
6033 (sum_columns) New function.
6035 * tab.h: (enum t_*) Now start at t_end. New: t_ptw, t_nr, t_nc,
6036 t_nah, t_naw, t_neg, t_xch, t_dup, t_lbl, t_jnz, t_sac, t_sar,
6037 t_scr, t_srr, t_sentinel. Removed: t_nat.
6038 (struct tab_table) New: wl, wr, ht, hb, trh, hrh, trv, wrv, dim,
6039 max_stack_height, w, h. Removed: ce, re.
6040 (macro blank_line) Removed.
6041 (glob var zero_length) Removed.
6043 Fri Dec 26 15:44:31 1997 Ben Pfaff <blp@gnu.org>
6045 * Most source files: include some of the new include files broken
6048 * Makefile.am: (pspp_SOURCES) Add all the new source files to the
6051 * aggregate.c: (glob var outfile) Make static.
6053 * command.c: (glob var pgm_state) Move here.
6055 * common.c: (glob vars endian, second_lowest_value, pgmname,
6056 finished, curdate, cur_proc, start_interactive, history_file) Move
6059 * descript.q: (structs dsc_z_score, descriptives_trns) Move here.
6061 * file-handle.q: (glob vars files, inline_file) Move here.
6063 * glob.c: Lost lots of glob vars, detailed in individual file
6065 (init_glob) set_printer, set_screen were obsolete, deleted.
6066 set_cprompt has fewer spaces because pspp has fewer letters than
6069 * inpt-pgm.c: (glob vars inp_init, inp_init_size) Move here.
6070 (inp_nval) Made static.
6072 * lexer.c: (glob vars token, tokval, tokstr, tokstr_size,
6073 tokstr_len, toklongstr, tokint) Move here.
6075 * misc.c: Lost several vars and functions.
6077 * set.q: (all the set_* variables) Move here.
6079 * str.c: (strmaxcpy, strbarepadcpy, strbarepadlencpy, strpadcpy,
6080 blpstrset, strpadcmp, memrev, memrmem, cmp_str) Move here from
6083 * tab.c: (set_expr, tab_col_width, tab_row_height) New functions.
6085 * tab.h: (enum series t_*) New enums.
6086 (struct tab_table) Use arena struct tag. New members ce, re.
6088 * tokens.h: Comment fixes.
6090 * var.h: Move lots of enums and variables and functions and
6091 structures to other files. Use and declare a lot more union and
6092 struct tags. Comment fixes.
6094 * vector.c: (glob vars vec, nvec) Move here.
6096 * vfm.c: (glob vars reinit_sysmis, reinit_blanks, init_zero,
6097 init_blanks, last_vfm_invocation) Move here.
6099 * cases.h: New file.
6100 (struct long_vec) Move here.
6101 (vec_init, vec_clear, vec_insert, vec_delete, devector, envector)
6104 * command.h: New file.
6105 (STATE_* enums) Move here.
6106 (glob var pgm_state) Move here.
6108 * format.c: New file.
6109 (glob var formats) Move here.
6110 (parse_format_specifier_name, fmt_to_string,
6111 check_input_specifier, check_output_specifier,
6112 check_string_specifier, convert_fmt_ItoO, parse_format_specifier)
6115 * format.h: New file. Move functions now in format.c here.
6116 (FMT_* enums) Move here.
6117 (struct fmt_desc) Move here.
6118 (FCAT_* enums) Move here.
6119 (struct fmt_spec) Move here.
6120 (glob vars formats, fmt_parse_ignore_error) Move here.
6122 * inpt-pgm.h: New file.
6123 (INP_* enums) Move here, make #defines into enums.
6124 (glob vars inp_init, inp_init_size) Move here.
6127 (glob vars v_sort, nv_sort) Move here.
6128 (sort_cases, read_sort_output) Move here.
6130 * vector.h: New file.
6131 (struct vector) Move here, add struct tag.
6132 (glob vars vec, nvec) Move here.
6133 (find_vector) Move here.
6136 (glob vars last_vfm_invocation, temp_case, reinit_sysmis,
6137 reinit_blanks, init_zero, init_blanks) Move here.
6138 (struct case_stream) Move here.
6139 (glob vars vfm_source, vfm_sink, vfm_memory_stream,
6140 vfm_disk_stream, sort_stream, data_list_source,
6141 input_program_source, file_type_source, get_source, n_lag) Move
6143 (procedure, write_case, lagged_case, compact_case, page_to_disk)
6146 Wed Dec 24 22:40:42 1997 Ben Pfaff <blp@gnu.org>
6148 * Makefile.am: (pspp_SOURCES) Added html.c, som.c, som.h.
6149 (LDADD) Add libdcdflib.
6151 * ascii.c: Comment and formatting fixes. Almost every external
6152 function had an assert added, checking driver_open and page_open.
6153 (ascii_init_driver) Broken into ascii_preopen_driver,
6154 ascii_postopen_driver, ascii_close_driver. Manages driver_open.
6155 (ascii_open_page) Sets page_open.
6156 (ascii_close_page) Clears page_open.
6158 * html.c: Comment and formatting fixes. Almost every external
6159 function had an assert added, checking driver_open and page_open.
6160 (html_init_driver) Broken into html_preopen_driver,
6161 html_postopen_driver, html_close_driver. Manages driver_open.
6162 (html_open_page) Sets page_open.
6163 (html_close_page) Clears page_open.
6164 (html_submit) Disabled.
6166 * lexer.c: (parse_string) Remove debugging printf.
6168 * list.q: (determine_layout) Open a page if one is not yet open.
6170 * output.c: Comment fixes.
6171 (add_class) Set the class member of the new list element.
6172 (parse_options) Don't handle device type.
6173 (colon_tokenize) New function.
6174 (configure_driver) New four-field format with a field for device
6175 type. Now initialize driver_open, page_open, next, and prev
6176 fields. Use new colon_tokenize() function. Don't do a memory
6177 copy to replace a driver, it doesn't work; instead delete the old
6178 driver and insert a new one.
6179 (destroy_driver) Don't call som_destroy_driver(). Close the page
6180 if it's open. Find the class in the list of classes and decrement
6181 that reference count. Remove the driver from the global driver
6183 (outp_iterate_enabled_drivers) Renamed outp_drivers(). All
6184 references changed. Rewritten. Don't return a driver that's not
6186 (outp_eject_page) All references to som_internal_eject_page()
6187 changed to use this. Sets cp_x to 0 as well as cp_y.
6189 * output.h: (OUTP_I_* enums) Removed.
6190 (struct som_submission_form) Removed.
6191 (struct outp_class) init_driver broken into preopen_driver,
6192 postopen_driver, and close_driver. submit changed to take a
6195 * postscript.c: Comment and formatting fixes. Almost every
6196 external function had an assert added, checking driver_open and
6198 (ps_init_driver) Broken into ps_preopen_driver,
6199 ps_postopen_driver, ps_close_driver. Manages driver_open.
6200 (ps_open_page) Sets page_open.
6201 (ps_close_page) Clears page_open.
6203 * som.c: New file, base implementation.
6205 * som.h: (struct som_table) Add struct tag.
6206 (enum SOM_COL_ACROSS) Removed.
6207 (SOM_ROWS, SOM_COLUMNS) New enums.
6208 (struct som_table_class) Add member `cumulate'. Remove `segment';
6209 change `render' arguments.
6210 (struct som_point, struct som_rect) Removed.
6211 (som_submit_table) Fixed typo, should have been som_submit.
6213 * sysfile-info: (describe_variable) Don't try to insert a
6214 subtable; just destroy it for now.
6216 * t-test.q: Include dcdflib/cdflib.h instead of cdflib.h. Fix
6217 references to value labels.
6219 * tab.c: (tab_destroy) New function.
6220 (tab_columns) Change argument.
6221 [0] (tab_submit) Remove dead code.
6222 (tab_title) Allocate string from the table's arena.
6223 (tab_output_text) Only free the buffer if we allocated it.
6224 (tab_submit) New function.
6225 (static vars t, d) New static vars.
6226 (tabi_table, tabi_driver, tabi_count, tabi_area, tabi_columns,
6227 tabi_headers, tabi_cumulate, tabi_render) New functions.
6228 (glob var tab_table_class) New global var.
6230 * tab.h: (struct tab_join_rect) Don't use a som_rect; directly
6231 encapsulate the rectangle. All references changed.
6233 Sun Dec 21 16:18:58 1997 Ben Pfaff <blp@gnu.org>
6235 * All header files updated to use struct tags in addition to
6236 typedefs for all structures. Don't use word `struct' in struct
6239 * Makefile.am: (pspp_SOURCES) Remove html.c.
6240 (INCLUDES) Replace the lib/* includes with a single lib/ include;
6241 all references updated.
6243 * command.c: (parse_cmd) Remove call to som_check_workspace.
6244 (output_line) Update to new som.
6246 * data-in.c: (parse_numeric) A single dot is not an error; it is
6247 the system-missing value.
6249 * data-list.c: (dump_fixed_table, dump_free_table) Update to new
6252 * data-out.c: Added `const' as appropriate to many prototypes.
6253 (convert_E, convert_F, convert_CCx) Take double argument instead
6254 of value * argument.
6255 (convert_format_to_string) Call changed functions appropriately.
6256 Instead of modifying the caller's value for FCAT_SHIFT_DECIMAL,
6257 make a local copy of the value.
6259 * descript.q: Remove custom_variables() prototype now provided by
6261 (custom_variables) Don't increment sbc_variables, the caller does
6263 (dump_z_table, display) Update to new som.
6265 * error.c: (vmsg) Add const to prototype. Remove code to handle
6266 `too many errors' condition.
6267 (check_error_count) New function.
6268 (msg) Add const to prototype.
6270 * filename.c: (open_file) Rewrite for elegance.
6272 * frequencies.q: Remove custom_*() prototypes now provided by q2c.
6273 (dump_full, dump_condensed, dump_statistics) Update for new som.
6275 * list.q: Don't include somP.h. Change all references to
6276 som_driver_ext to refer to the new members of som_driver. Change
6277 som_internal_eject_page() references to outp_eject_page().
6279 * main.c: (parse) Rewrite for elegance. Add call to
6280 check_error_count().
6282 * output.c: (add_class, outp_list_classes, outp_configure_driver)
6283 Rewrite or revise for new outp_driver_class_list structure.
6284 (outp_iterate_enabled_drivers) Fix comparison between disabled
6285 devices and current device type.
6286 (outp_eject_page) New function.
6288 * output.h: Comment fixes.
6289 (struct outp_driver) New members driver_open, page_open, cp_x,
6290 cp_y, font_height, prop_em_width, fixed_width. Deleted members
6292 (struct outp_driver_class_list) New struct.
6293 (outp_class_list) Changed to type outp_driver_class_list; all
6296 * print.c: (dump_table, print_trns_proc) Updated for new som.
6298 * q2c.c: (dump_vars) Simplify array subcommand code. Declare
6299 prototypes for custom subcommands.
6300 (dump_subcommand) Always include the `else'.
6301 (dump_parser) Fix comments in output code.
6303 * set.q: Reordered functions.
6305 * som-frnt.c, som-high.c, som-low.c, somP.h: Removed.
6307 * som.h: Rewritten from scratch.
6309 * str.h: Remove dead code.
6311 * tab.c, tab.h: New files, base implementation.
6313 * sysfile-info.c: (cmd_sysfile_info, describe_variable) Update to
6316 * t-test.q: New code from John Williams
6317 <johnr.williams@stonebow.otago.ac.nz>. Include math.h, cdflib.h.
6318 Many many new static vars and defines.
6319 (precalc, postcalc, g_postcalc, z_postcalc, t_pairs, t_groups,
6320 groups_calc, pairs_calc, z_dev_calc, z_calc) New functions.
6321 (struct value_list) New struct.
6322 (variance, covariance, pooled_variance, oneway, pearson_r, f_sig,
6323 t_crt, t_sig, print_t_groups) New functions.
6324 (cmd_t_test) Implemented.
6326 * temporary.c: (cancel_temporary) Only free the temp_dict if it's
6329 * vfm.c: (dump_splits) Update to new som.
6331 Thu Dec 4 23:02:22 1997 Ben Pfaff <blp@gnu.org>
6333 * Makefile.am: (fiasco_SOURCES) Add html.c.
6335 * aggregate.c: Base source.
6337 * ascii.c: (postopen, preclose) Reformat.
6339 * data-out.c, expr-evl.c: Comment fixes.
6341 * filename.c: (open_file) When opening a file for writing, use
6342 line buffering instead of full buffering for better interactive
6343 performance. Suggested by Valerio Aimale
6344 <valerio@svpop.com.dist.unige.it>. Also, recognize special file
6345 names `stdin', `stdout', `stderr'.
6347 * groff-font.c: Comment fixes.
6349 * html.c: New file; base version.
6351 * list.q: (write_all_headers, clean_up, determine_layout,
6352 list_cases) Ignore `special' devices for now. Needs to be fixed
6355 * output.c: (outp_init) Add html driver to list; reverse list
6358 * output.h: (struct outp_class_struct) New members `special',
6359 `submit'; comment fixes. All references changed.
6361 * postscript.c: (ps_init_driver) Make defaults for text_opt,
6362 line_opt depend on whether the OUTP_DEV_SCREEN bit is set on the
6364 (postopen) Comment fix.
6365 (preclose) Comment fixes, formatting fixes. Change x->file.file
6366 references to more proper f->file.
6368 * som-high.c: (som_submit_table) Special classes use their own
6371 * som.h: Comment fixes.
6373 * temporary.c: (new_dictionary) Don't try to xstrdup() a NULL
6376 Tue Dec 2 14:36:07 1997 Ben Pfaff <blp@gnu.org>
6378 * Makefile.am: (fiasco_SOURCES) Add aggregate.c back in.
6380 * aggregate.c: Still working on this.
6382 * command.c: (cmd_table[]) Add AGGREGATE back in.
6383 (split_words) Make '-' a legal word separator as well as ' '.
6385 * main.c: Comment fixes.
6387 * q2c.c: (dump_parser) Don't require the procedure's full name to
6388 be present, in the generated source.
6390 * t-test.q: Change name to `t-test' from `t test'. Let PAIRS be
6391 multiply specified and let it be default; let MISSING, CRITERIA,
6392 FORMAT be multiply specified.
6393 (cmd_t_test) Parse command name. [DEBUGGING] Call debug_print().
6394 (custom_groups) Fix defaults.
6395 (custom_pairs) Check whether this is a PAIRS subcommand before
6396 attempting to parse. Better garbage collection. Proper storage
6398 [DEBUGGING] (debug_print) New function.
6400 * temporary.c: Comment fixes.
6401 (copy_variable) Don't copy variable name and index.
6402 (save_dictionary) Copy variable name and index by hand.
6404 * vars-atr.c: Comment fixes.
6405 (create_variable) New dictionary argument. All references
6407 (common_init_stuff) New dictionary argument. All references
6409 (init_variable) New dictionary argument. All references changed.
6410 (dup_variable) New function.
6412 * vars-prs.c: (parse_variables) If there are any errors, we always
6413 return 0. Previously, it was possible for some types of errors to
6416 Sat Nov 22 01:20:59 1997 Ben Pfaff <blp@gnu.org>
6418 * Makefile.am: (fiasco_SOURCES) For 0.1.5 release, remove
6421 * command.c: (cmd_table[]) Comment out AGGREGATE; add T TEST.
6423 * list.q, t-test.q: Remove ALL option from VARLIST declaration in
6426 * q2c.c: Comment fixes.
6427 (SBC_* enums) Remove SBC_VARLIST_ALL; all references removed.
6429 * t-test.q: (cmd_list) Rename cmd_t_test.
6431 * temporary.c: (new_dictionary) Don't declare as static.
6433 Fri Nov 21 00:03:06 1997 Ben Pfaff <blp@gnu.org>
6435 * aggregate.c: Changes, still not finished.
6437 * file-handle.q, frequencies.q, list.q, set.q: Comment fixes.
6439 * q2c.c: Comment fixes. Now its output is internationalized.
6440 (get_token) Fix parsing of escapes within literal strings.
6441 (main) Fix bad #line directives in output.
6443 * t-test.q: Base implementation.
6445 * temporary.c: (new_dictionary) New function.
6446 (restore_dictionary) [__CHECKER__] Change fill character to *
6449 Sun Nov 16 01:29:57 1997 Ben Pfaff <blp@gnu.org>
6451 * Makefile.am: (BUILT_SOURCES, fiasco_SOURCES) Add t-test.c
6453 * aggregate.c: Changes, still not finished.
6455 * descript.q, list.q: Comment fixes.
6457 * q2c.c: Almost completely rewritten.
6459 * t-test.q: New file, not complete.
6461 Fri Nov 14 00:14:48 1997 Ben Pfaff <blp@gnu.org>
6463 * aggregate.c: Changes, still not finished.
6465 * sort.c: (sort_cases) Call cancel_temporary() instead of doing it
6468 * temporary.c: (cancel_temporary) New function.
6470 * vars-atr.c: (discard_variables) Call cancel_temporary() instead
6471 of doing it by hand.
6473 * vfm.c: (close_active_file) After restoring a TEMPORARY
6474 dictionary, set temp_dict to NULL. Cancel TEMPORARY through
6476 (SPLIT_FILE_procfunc) Comment fix.
6478 Tue Oct 28 16:08:45 1997 Ben Pfaff <blp@gnu.org>
6480 * Makefile.am: (fiasco_SOURCES) Add aggregate.c.
6482 * aggregate.c: New file, not finished yet.
6484 * command.c: (cmd_table) Add AGGREGATE.
6486 * common.h: (pgm_state) Move declaration to var.h.
6488 * lexer.c: (bin_value_func, oct_value_func, hex_value_func) i18n
6490 (parse_string) Message fix.
6492 * recode.c: Comment fix.
6494 * sfm-read.c: (read_variables) Code esthetic fixes.
6495 (write_header) Default date is `Jan', not `JAN'.
6497 * sfmP.h: (bswap_int32) [!__linux__] Fix off-by-one errors.
6499 * sort.c: (cmd_sort_cases) Farm the work out to new function
6500 parse_sort_variables().
6501 (parse_sort_variables) New function.
6502 (sort_cases) New function. Cancels temporary transformations,
6503 which sorting didn't do previously.
6504 (cmd_sort_cases) Better garbage collection on error. Uses
6506 (write_initial_runs, merge_once) Improved code esthetics.
6507 (sort_stream_read) Reduced to one call to read_output_cases().
6508 (read_output_cases) New function.
6510 * var-labs.c: (cmd_variable_labels) Re-enabled truncation of
6511 variable labels to 120 characters.
6513 * var.h: Comment fixes.
6514 (glob var pgm_state) From common.h.
6516 * vars-atr.c: (discard_variables) Set pgm_state to STATE_INIT.
6518 * vars-prs.c: (parse_DATA_LIST_vars) Support PV_SINGLE in
6519 options. Set *names to NULL on error.
6521 * vfm.c: (memory_stream_init) Assert compaction_nval != 0.
6523 Thu Oct 9 09:59:49 1997 Ben Pfaff <blp@gnu.org>
6525 * sfm-write.c, vfm.c: [HAVE_UNISTD] #include <unistd.h>, needed by
6526 SunOS4. From Alexandre Oliva <oliva@dcc.unicamp.br>.
6528 Wed Oct 8 18:55:24 1997 Ben Pfaff <blp@gnu.org>
6530 * vfm.c: (page_to_disk) Added missing local variables.
6532 Tue Oct 7 20:23:17 1997 Ben Pfaff <blp@gnu.org>
6534 * get.c: Comment fix.
6536 * sort.c: (cmd_sort_cases) Attempt to perform internal sort if the
6537 source is anything other than a disk stream, not just if it's in a
6538 memory stream. Call page_to_disk() before external sort.
6539 (allocate_cases) Message fix.
6541 * vfm.c: (prepare_for_writing) Warn user when paging workspace to
6543 (page_to_disk) New function.
6545 Sun Oct 5 15:56:14 1997 Ben Pfaff <blp@gnu.org>
6547 * Makefile.am: (INCLUDES) Include .. instead of $(top_srcdir).
6549 * common.h: (macro strerror) Remove. From Alexandre Oliva
6550 <oliva@dcc.unicamp.br>.
6552 * get.c: (dict_delete_run) The number of variables to delete is
6553 not necessarily the number of variables that need to be shifted
6555 (trim_dictionary) Don't set *options to 0. Fix bug that caused
6556 too many variables to be deleted.
6558 * postscript.c: Comment fix.
6560 * q2c.c: Include strerror.c. From Alexandre Oliva
6561 <oliva@dcc.unicamp.br>.
6563 * set.q: #undef ON and OFF. From Alexandre Oliva
6564 <oliva@dcc.unicamp.br>.
6566 * sfm-read.c: (sfm_read_dictionary) Don't set the file class too
6567 early, otherwise errors cause a bad free().
6569 * str.h: (macro nvsprintf) s/FORMATS/FORMAT/ typo. From Alexandre
6570 Oliva <oliva@dcc.unicamp.br>.
6572 * temporary.c: (save_dictionary) Don't allocate memory if
6575 * vfm.c: (memory_stream_write) Message fix.
6577 Sat Oct 4 16:20:43 1997 Ben Pfaff <blp@gnu.org>
6579 * command.c: (static var cmd_table[]) Define REPEATING DATA
6582 * common.h: Added support for broken systems that are missing
6583 EXIT_SUCCESS, EXIT_FAILURE, RAND_MAX, and/or strerror().
6585 * Many source files: Replace syntax error messages via msg() with
6586 call to syntax_error().
6588 * data-list.c: (dump_fixed_table) Add support for dumping table
6589 for REPEATING DATA as well as DATA LIST FIXED.
6590 (cmd_repeating_data) Allows and requires `/' between subcommands.
6591 Does proper thing with allowing rpd.starts_end to stay 0. Allows
6592 CONTINUED specifications to be omitted. Forces CONTINUED to be
6593 specified if ID is. Calculates starts_end, cont_end from logical
6594 record length as reported by fhp. Calls dump_fixed_table() if
6595 requested. Fixed length of record copied by memcpy.
6596 (parse_num_or_var) Sets `num' to 0, not NOT_INT, for variables.
6598 (realize_value) Returns sensible value for out-of-range variable
6600 (rpd_parse_record) New argument `ofs'. Fixed confusion between
6601 length of occurrences and length of line. Added warning for
6602 fields that exceed the line length. Fixed infinite loop.
6603 (read_one_set_of_repetitions) Numerous minor changes for more
6604 complete SPSS compliance. Message fixes.
6606 * dfm.c: (dfm_close) If the file being closed is the inline file,
6607 read all the remaining data before closing it.
6608 (dfm_get_record) Don't close the file on lossage, as either it
6609 has been closed already or it doesn't belong to us.
6611 * error.c: (puts_stdout) New function.
6612 (vmsg) Use puts_stdout instead of puts.
6614 * file-handle.q: (fh_record_width) New function.
6616 * inpt-pgm.c: (init_case) Fixed buffer overrun when inp_nval % 4
6619 (input_program_source_read) Made an old kluge an approved method.
6621 * lexer.c: (syntax_error) New function.
6623 * misc.c: [BROKEN_RAND] (ansi_rand, ansi_srand; static var next)
6626 * output.c: (oupt_get_paper_size) Message fix.
6628 * q2c.c: Numerous fixes to formatting of generated code made to
6629 conform to GNU coding standards. Uses syntax_error() in generated
6630 code. Other miscellaneous generated message fixes. Added support
6631 for broken systems that are missing EXIT_SUCCESS, EXIT_FAILURE,
6632 RAND_MAX, and/or strerror().
6634 Sat Oct 4 02:09:56 1997 Ben Pfaff <blp@gnu.org>
6636 * data-in.c: Comment fixes.
6638 * data-list.c: (struct repeating_data_trns) New member `id_spec'.
6639 (find_variable_input_spec) New function.
6640 (cmd_repeating_data) Initializes id_spec.
6641 (rpd_parse_record) Implemented.
6642 (read_one_set_of_repetitions) Returns -3 by default in order to
6643 kluge out some potential bugs.
6645 * data-out.c: Comment fixes.
6647 * file-type.c: (internal_cmd_record_type) Message fix.
6649 * inpt-pgm.c: (input_program_source_read) Special temporary kluge
6650 for handling -3 return value.
6652 Sat Sep 20 23:58:15 1997 Ben Pfaff <blp@gnu.org>
6654 * data-list.c: Comment fixes.
6655 (struct dls_var_spec) Reordered members.
6656 (read_from_data_list_fixed) Restructured.
6657 (struct repeating_data_trns) Reordered members. Renamed `starts'
6658 as `starts_beg', `ends' as `starts_end'.
6659 (cmd_repeating_data) Calculates length of repeated data if
6660 necessary and possible.
6661 (parse_num_or_var) Don't allow string variables.
6662 (realize_value) New function.
6663 (rpd_msg) New function.
6664 (rpd_parse_record) New function. Currently stubbed out.
6665 (read_one_set_of_repetitions) Implemented.
6667 * inpt-pgm.c: (input_program_source_read) Comment fix.
6669 Thu Sep 18 21:34:57 1997 Ben Pfaff <blp@gnu.org>
6671 * command.c: (cmd_end_repeat_p) Removed.
6672 (init_cmd_parser) Doesn't set cmd_end_repeat_p.
6673 (parse_cmd_name) Removed.
6675 * data-list.c: Comment fixes.
6676 (data_list_pgm) Removed `eof' member.
6677 (static var first) New var.
6678 (cmd_data_list) Sets `first'. Ensures that DATA LIST uses the
6679 FILE TYPE file inside FILE TYPE structures.
6680 (append_var_spec) Appends to *first, not dls.spec.
6681 (parse_fixed) Message fixes.
6682 (struct rpd_num_or_var) New.
6683 (struct repeating_data_trns) New.
6684 (static var rpd) New.
6685 (cmd_repeating_data) New function.
6686 (parse_num_or_var) New function.
6687 (parse_repeating_data) New function.
6688 (read_one_set_of_repetitions) New function.
6690 * file-type.c: (cmd_file_type) Message fixes. Always
6691 default_handle to FILE TYPE file handle.
6692 (internal_cmd_record_type) Message fixes.
6694 Wed Aug 20 14:22:03 1997 Ben Pfaff <blp@gnu.org>
6696 * repeat.c: Comment fix. Disable debugging.
6698 * temporary.c: (restore_dictionary) Sets splits to NULL and
6699 n_splits to 0 before destroying the variables because now doing
6700 this tries to remove split variables.
6702 * vars-atr.c: (discard_variables) Asserts that n_splits is 0 after
6703 destroying the dictionary.
6704 (clear_variable) Removes a variable from splits after destroying
6707 Mon Aug 18 18:06:55 1997 Ben Pfaff <blp@gnu.org>
6709 * cmdline.c: (set_compat) Removed.
6710 (pick_compat) Removed.
6711 (parse_command_line) Removed -c option.
6712 (pre_syntax_message) Removed -c option.
6713 (usage) Remove compatibility code.
6715 * common.h: (macros VER_PC, VER_WND, VER_X) Removed.
6716 (glob var compat) Removed.
6718 * compute.c: (type_check) Fixed messages about type mismatches.
6720 * data-list.c: (cmd_data_list) Removed compatibility code.
6721 (fixed_parse_compatible) Calls convert_negative_to_dash().
6722 Fixed bug where it only set the variable in fx.spec if it created
6723 the variable itself.
6724 (dump_fmt_list) Spelling fix.
6725 (cut_field) Removed compatibility code.
6727 * dfm.c: (cmd_begin_data) Don't require a command terminator on
6730 * expr-evl.c: (evaluate_expression) Implement LAG.
6732 * expr-prs.c: (parse_add) Calls convert_negative_to_dash().
6733 (parse_neg) Calls convert_negative_to_dash().
6734 (LAG_func) Increases n_lag to the lag requested. Fixed assignment
6737 * expr.h: (struct expression_struct) Removed member max_lag.
6739 * file-type.c: (parse_col_spec) Calls convert_negative_to_dash().
6740 (internal_cmd_record_type) Removed special handling to produce
6741 negative numbers from dash tokens.
6743 * getline.c: (static var DO_REPEAT_level) New var.
6744 (getl_add_DO_REPEAT_file) Increments DO_REPEAT_level.
6745 (handle_line_buffer) Copies the line into getl_buf; doesn't call
6746 copy_with_DO_REPEAT_substitutions().
6747 (getl_read_line) Maintains value of getl_mode. Calls
6748 perform_DO_REPEAT_substitutions() whenever DO_REPEAT_level is
6750 (getl_close_file) Decrements DO_REPEAT_level when appropriate.
6752 * getline.h: (getl_mode) New glob var.
6754 * glob.c: Comment fixes.
6755 (init_glob) Restructured. Sets set_seed.
6756 (init_compat_dependent) Removed. All references removed.
6757 (get_date) Format changed from MM/DD/YY to DD MMM YYYY.
6758 (__htonl, __htons) Removed. (What were these for?)
6760 * lexer.c: (static var tbl) Dash set to class CNUM.
6761 (make_hexit) New function from data-out.c.
6762 (get_token_representation) Rewritten.
6763 (convert_negative_to_dash) New function.
6764 (lex_init_compat_dependent) Removed.
6765 (yylex) A dash is parsed as part of a number if it is followed by
6766 a digit. The ASCII representation of a number is copied to
6767 tokstr. String parsing farmed out to parse_string(). Comment
6769 (bin_value_func, oct_value_func, hex_value_func, parse_string) New
6771 (preprocess_line) Line processing depends on interactive/batch
6772 mode, not on compatibility mode. Removed PC+ compatibility code.
6774 * loop.c: (loop_3_trns_proc) Comment fix.
6776 * main.c: Remove dead code.
6777 (main) Remove call to init_compat_dependent().
6779 * misc.c: (convert_fmt_ItoO) Make E format conversion more
6782 * print.c: (parse_string_argument) Calls
6783 convert_negative_to_dash().
6784 (fixed_parse_compatible) Calls convert_negative_to_dash().
6786 * repeat.c: (RPT_* defines) Removed.
6787 (struct rpt_numeric) Removed.
6788 (struct repeat_entry) New member type, changed `replacement' from
6790 (clean_up) Deallocation adapted to new repeat_entry.
6791 (internal_cmd_do_repeat) `type' defaults to 0. Remove lookahead()
6792 usage. Creates vars for `type' of 1.
6793 (parse_ids) Sets type of 1. Adapted to new repeat_entry.
6794 (store_numeric) Rewritten, new interface.
6795 (parse_numbers) Rewritten.
6796 (parse_strings) Rewritten.
6797 (find_DO_REPEAT_substitution) New function.
6798 (perform_DO_REPEAT_substitutions) New function.
6799 (copy_with_DO_REPEAT_substitutions) Removed.
6800 (debug_print) Rewritten.
6802 * set.q: Comment fix.
6803 (custom_results) Removed compatibility code.
6804 (internal_cmd_set) Removed SET EMULATION subcommand. Removed
6807 * sysfile-info.c: (cmd_display) Removed compatibility code.
6809 * tokens.h: Comment fixes.
6810 (token types enum) Removed `toktype' typedef name for this int
6811 type. Removed SUBST. Restructured.
6813 * vars-atr.c: (discard_variables) Sets n_lag to 0.
6815 * vars-prs.c: Comment fix.
6817 * vfm.c: Comment fixes.
6818 (glob var n_lag) New var.
6819 (static vars lag_count, lag_head, lag_queue) New vars.
6820 (procedure) Removed argument nlag.
6821 (setup_lag) New function.
6822 (close_active_file) Discards lagging state.
6823 (lag_case) New function.
6824 (lagged_case) New function.
6825 (write_case) Lags a case if lagging.
6827 * weight.c: (cmd_weight) Removed compatibility code.
6829 Sun Aug 17 22:34:40 1997 Ben Pfaff <blp@gnu.org>
6831 * getline.h: (struct getl_script) New members loop_index, macros.
6833 * getline.c: (getl_add_file) Sets first_line field to NULL.
6834 (getl_add_DO_REPEAT_file) New function.
6835 (handle_line_buffer) When the current line's length is negative,
6836 set the filename and line number. Increment line number after
6837 reading line. Pass the line to
6838 copy_with_DO_REPEAT_substitutions() for processing.
6839 (getl_close_file) Free DO REPEAT lines before freeing the
6840 filename, and just set the filename to NULL when doing this,
6841 because otherwise the filename gets freed twice.
6843 * glob.c: (glob var queuing) Removed. All references removed.
6845 * lexer.c: Comment fixes.
6846 (get_token_representation) New function.
6848 * repeat.c: Comment fixes.
6849 (struct repeat_entry) Replaced type and v union members with a
6851 (append_record) New function.
6852 (internal_cmd_do_repeat) Started reforming it for the new
6853 repeat_entry struct. Properly records filename changes in the
6854 getl_line_buf. Fixed improper use of = for ==. Fixed sense of
6855 strncasecmp() result usage. Uses append_record() to simplify.
6856 Properly discards END REPEAT line. Calls getl_add_DO_REPEAT_file
6859 (copy_with_DO_REPEAT_substitutions) Started coding.
6861 [DEBUGGING] (debug_print_lines) New function.
6863 * set.q: (custom_results, internal_cmd_set) s/VER_PCP40/VER_PC/;
6865 * tokens.h: (macro is_id1, is_idn) New macros.
6867 Sat Aug 16 10:57:41 1997 Ben Pfaff <blp@gnu.org>
6869 * cmdline.c: (static var pre_syntax_message) Changed `win'
6870 compatibility mode to `wnd'.
6872 * data-list.c: (fixed_parse_spss) Renamed
6873 fixed_parse_compatible().
6875 * glob.c: (init_glob) Excise unused code for
6876 program_invocation_short_name.
6878 * lexer.c: (preprocess_line) Leading indentors are ignored in Wnd
6881 * print.c: (fixed_parse_spss) Renamed fixed_parse_compatible().
6883 * set.q: `win' compatibility renamed `wnd'.
6885 Thu Aug 14 22:11:12 1997 Ben Pfaff <blp@gnu.org>
6887 * filename.c: [__WIN32__] Change the included Windows header files
6889 (absolute_filename_p) [__MSDOS__] A filename with a colon as the
6890 second character is absolute.
6891 (dirname) Fix logic error. Don't printf() the results.
6892 (prepend_dir) Don't printf() the results.
6894 * getline.c: (handle_line_buffer) New function.
6895 (getl_read_line) Reads line with handle_line_buffer() when
6897 (getl_close_file) Discard line buffer data.
6899 * getline.h: Comment fixes.
6900 (struct getl_line_list) New struct.
6901 (getl_script_struct) Added line buffer members. These are hooks
6902 for use by DO REPEAT to allow it to insert virtual source code
6905 * glob.c: (init_glob) [__DJGPP__ || (__WIN32__ && __BORLANDC__)]
6906 Override Borland C++ stupidity that claims Windows has a console
6909 * repeat.c: This is in the process of being restructured from
6910 using a token-buffering approach to the DO REPEAT facility to
6911 using the more flexible approach of a line-buffering approach in
6912 conjunction with the getline module. Comment fixes.
6913 (struct tok_struct) Removed.
6914 (static vars queue_index, queue_head, queue) Removed.
6915 (static vars line_buf_head, line_buf_tail) New vars.
6916 (internal_cmd_do_repeat) Instead of queuing tokens, queue lines.
6918 (pull_queue, destroy_queue) Removed.
6919 [DEBUGGING] (debug_print_tokens) Removed.
6921 Tue Aug 5 13:57:58 1997 Ben Pfaff <blp@gnu.org>
6923 * file-handle.q: (prepend_current_directory) New function.
6924 (internal_cmd_file_handle, fh_get_handle_by_filename) Prepends
6925 current directory before normalizing filename.
6927 * filename.c: (gnu_getcwd) New function.
6928 (absolute_filename_p) New function.
6929 (search_path) New argument, PREPEND. All references changed to
6930 pass NULL except those explicitly mentioned. Uses
6931 absolute_filename_p(). Prepends PREPEND before trying the
6933 (dirname, prepend_dir) New functions.
6935 * getline.c: (getl_get_current_directory) New function.
6936 (getl_include) Passes getl_get_current_directory() as PREPEND arg
6939 Sun Aug 3 11:42:36 1997 Ben Pfaff <blp@gnu.org>
6941 * In several source files, the term `script' was replaced with
6942 `syntax file' inside error messages. Usage of the term `script'
6943 in the sense of a syntax file is now deprecated.
6945 * cmdline.c: (static vars pre_syntax_message, post_syntax_message)
6948 * dump-sysfile.c: (usage) Update message.
6950 * getline.c: (getl_read_line) Ignore lines beginning with `#!'.
6952 * getline.h: (glob var getl_include_path) Declare extern.
6954 * list.q: Define EXTERN as extern before #including somP.h.
6956 * var.h: Remove declaration of `disptype' variable.
6958 * vfm.c: (close_active_file) After switching the data sink to a
6959 data source, set vfm_sink to NULL, because it doesn't exist any
6962 Thu Jul 17 21:41:44 1997 Ben Pfaff <blp@gnu.org>
6964 * glob.c: [__BORLANDC__] Include math.h. Define _matherr() and
6965 _matherrl() to ignore all math errors.
6967 * sfm-read.c: (read_value_labels) When reading the labels from
6968 disk, read the little parts separately instead of as a struct;
6969 this avoids alignment problems.
6971 * sfm-write.c: (struct sfm_fhuser_ext) New member `elem_type'.
6972 (sfm_write_dictionary) Sets elem_type and frees it on lossage.
6973 (write_header) Allocates and initializes elem_type.
6974 (sfm_write_case) Uses elem_type to determine how to handle each
6976 (sfm_close) Frees elem_type.
6978 * sfmP.h: Comment fix.
6979 [__BORLANDC__] Uses #pragma -a to adjust structure member
6982 Thu Jul 17 01:55:12 1997 Ben Pfaff <blp@gnu.org>
6984 * Makefile.am: (fiasco_SOURCES) Remove display.c.
6986 * common.c: Fix typo.
6988 * dfm.c: (read_record) Remove strncasecmp() emulation and fix the
6989 sense of the condition.
6991 * expr-evl.c: (macro ALLOC_STRING_SPACE) [!PAGED_STACK] Add
6992 line-continuation backslash.
6994 * filename.c: [__WIN32__] Include <windef.h> before <winbase.h>.
6996 * frequencies.q: (custom_grouped, add_percentile) Don't use a
6997 non-constant expression as an argument to sizeof.
6999 * glob.c: [__WIN32__ && __BORLANDC__] When including <conio.h>,
7000 undefine gettext macro because that's a conio function.
7002 * hash.h: (hsh_prime_tab declaration) Remove.
7004 * list.q: (write_fallback_headers) Move `leader' allocation out of
7005 main loop. Change to local_alloc() allocation.
7007 * output.h: Formatting fixes. Put __attribute__ in right place on
7008 function prototypes.
7010 * sfm-read.c: (read_machine_flt64_info, read_variables) Change
7011 incorrect `SECOND_LOWEST_VALUE' references to proper
7012 `second_lowest_value'.
7014 * som-frnt.c: (EXTERN macro) Define as `extern' instead of null
7015 value. This way 2 out of 3 of the som files define the vars
7016 extern, the correct way, that actually works under BC++.
7017 (som_set_float) Don't use nonconstant initializers for a struct.
7019 * som-high.c: Add the standard alloca() header.
7020 (replicate_table) Add prototype.
7022 Merged DISPLAY routine.
7023 * sysfile-info.c: (AS_*) New enum series.
7024 (cmd_sysfile_info) Gutted. Calls describe_variable() to do the
7026 (cmd_display, display_macros, display_documents,
7027 display_variables) Stolen from defunct display.c.
7028 (describe_variable) New function.
7030 * temporary.c: [0] (display_tree) New debug function.
7031 (copy_variable) Performs shallow copy of value labels instead of
7032 deep copy; i.e., just copys the AVL tree and increments the
7035 * val-labs.c: Comment fixes.
7036 (do_value_labels) Optionally skip leading forward slash.
7037 (get_label) Creates only a single value label instead of many
7038 copies of one, and sets the reference count.
7040 * display.c: Removed.
7042 * dump-sysfile.c: New file, not yet complete.
7044 Fri Jul 11 23:02:18 1997 Ben Pfaff <blp@gnu.org>
7046 For lots of source files I added more verbose_msg's. These aren't
7047 listed below as they have tested as being benign. In some cases
7048 these replaced debug_printf() calls.
7050 * output.c: (outp_read_devices) Message fix.
7052 * postscript.c: (output_encodings) Message fix. Reports errors on
7054 (postopen) Message fix.
7056 Fri Jul 11 14:09:40 1997 Ben Pfaff <blp@gnu.org>
7058 * dfm.c: (dfm_close) Don't call fclose() for a NULL FILE.
7060 * filename.c: (close_file_ext) Set f->file to NULL *after* closing
7063 * main.c: Remove <malloc.h> #include.
7065 * mis-val.c: (parse_numeric) Set .f member for each missing[]
7066 instead of trying to just set the missing[] itself, which is a
7069 * sfm-read.c: (read_variables) Same.
7071 * str.h: Add memmem() prototype.
7073 * val-labs.c, var-labs.c: Replace <malloc.h> with <stdlib.h>.
7075 Thu Jul 10 22:13:53 1997 Ben Pfaff <blp@gnu.org>
7077 * Makefile.am: (q2c) Don't include any libraries in the link.
7079 * dfm.c: (force_line_buffer_extension) New macro.
7080 (count_tabs) New function.
7081 (tabs_To_spaces) New function.
7082 (read_record) Calls tabs_to_spaces() on the line being processed.
7084 * q2c.c: Disabled i18n for this proglet so that libintl.a doesn't
7085 have to be compiled twice (once for CC, once for LOCAL_CC).
7087 Sun Jul 6 19:14:33 1997 Ben Pfaff <blp@gnu.org>
7089 * Makefile.am: (INCLUDES) Add intl directory; fix directories.
7090 (LDADD) Add @INTLLIBS@.
7091 (q2c) Add LIBS, @INTLLIBS@ to link step.
7093 * inpt-pgm.c: Turn off debugging.
7095 * postscript.c: (postopen) Format fix. local_free() blocks
7096 returned by local_alloc(); don't free() them.
7098 Sat Jul 5 23:44:51 1997 Ben Pfaff <blp@gnu.org>
7100 * data-in.c: (parse_string_as_format) Comment fix. Fix check for
7103 * data-list.c: (read_from_data_list_fixed) Pass proper value for
7104 LEN arg, not simply the full string length.
7106 * sort.c: (allocate_file_handles) Check SPSS compatible temp file
7107 directories before generic temp file directories.
7109 * vfm.c: Disable debugging.
7111 Fri Jul 4 13:26:41 1997 Ben Pfaff <blp@gnu.org>
7113 * get.c: Comment fix.
7114 (cmd_save_internal) Always passes GTSV_OPT_SAVE option.
7116 Wed Jun 25 22:52:28 1997 Ben Pfaff <blp@gnu.org>
7118 * expr-prs.c: (debug_print_postfix) Conditionally included on
7119 GLOBAL_DEBUGGING. Removed out_header() reference.
7121 * exprP.h: Removed #undef GLOBAL_DEBUGGING.
7123 Sun Jun 22 22:00:28 1997 Ben Pfaff <blp@gnu.org>
7125 * ascii.c: Removed obsolete ascii_close_page() prototype.
7127 * command.c: (output_line) Comment fix.
7129 * data-in.c: Formatting fix.
7130 (parse_string_as_format) Now the `fc' argument is used only for
7131 the purpose of error messages; it is not an index into the string
7132 passed. All references changed.
7134 * data-list.c: Comment fix.
7135 (cut_field) Comment fix. Now returns the column number of the
7136 position of the field cut out on success.
7137 (parse_field) Added `column' argument. Puts the column numbers in
7139 (read_from_data_list_free, read_from_data_list_list) Record the
7140 column number returned by cut_field(), pass it to parse_field().
7142 * dfm.c: Comment fix.
7144 * do-ifP.h: Comment fix.
7146 * expr-prs.c: (SYSMIS_func) Implemented string-type arguments for
7147 the SYSMIS function.
7149 * expr.h, exprP.h: Comment fix.
7151 * glob.c: (init_glob) Only calls setlocale() and family if
7154 * hash.h: Comment fix.
7156 * include.c: Comment fix.
7158 * output.c: Comment fix.
7160 * postscript.c: (ps_line_intersection) Simplified assertion.
7162 * repeat.c: Comment fix.
7164 * vars-atr.c: Comment fix.
7166 * vars-prs.c: Comment fix.
7168 * vfm.c: (vector_initialization) [DEBUGGING] Fixed undefined
7169 behavior with usage of postincrement.
7170 (memory_stream_read) Discards cases as it goes.
7172 Sun Jun 15 16:45:17 1997 Ben Pfaff <blp@gnu.org>
7174 * Makefile.am: Cleans q2c, not just distcleans it. Distcleans
7177 * Most source files: Includes debug-print.h, related comment
7180 * cases.c: (alloc_val) Removed complex allocation code. Merely
7181 increments default_dict.nval and returns the former value.
7182 (envector, devector) Removed references to lv member of struct
7185 * common.h: (macro VME) Replaced complex definition with simple
7188 * data-list.c: (cmd_data_list) Sets vfm_source instead of
7189 read_active_file and cancel_input_pgm.
7190 (read_from_data_list, cancel_data_list) Removed.
7191 (data_list_source_read, data_list_source_destroy_source) New
7193 (glob var data_list_source) New var.
7195 * dfm.c: (open_file_r, open_file_w) Simplified debug output.
7196 (cmd_begin_data) Improved criteria for an input program accessing
7197 the inline file. Still not perfect.
7199 * do-if.c: (do_if_trns_proc) Simplified debug output.
7201 * expr-prs.c: Comment fixes.
7202 [DEBUGGING] (debug_print_postfix) Simplified debug output.
7204 * file-handle.q: (fh_close_handle) Simplified debug output.
7206 * file-type.c: Comment fixes.
7207 (cmd_file_type) Sets vfm_source instead of read_active_file and
7209 (cmd_end_file_type) On failure, discards variables in place of
7210 just canceling the input program.
7211 (read_from_file_type) Renamed file_type_source_read.
7212 (cancel_file_type) Renamed file_type_source_destroy_source.
7213 (glob var file_type_source) New var.
7215 * get.c: (GTSV_* enum series) New enums GTSV_OPT_SAVE, GTSV_NONE.
7216 (cmd_get) Initializes options to GTSV_NONE before passing to
7217 trim_dictionary(). Removed `lv' reference. Sets vfm_source
7218 instead of read_active_file and cancel_input_pgm.
7219 (cmd_save_internal) Initializes options before passing to
7220 trim_dictionary(). Local var `nval' removed.
7221 (dict_delete_run) Comment fixes.
7222 (trim_dictionary) Comment fixes. Disallows scratch variables if
7223 GTSV_OPT_SAVE set in options.
7224 (read_from_get) Renamed get_source_read.
7225 (cancel_get) Renamed get_source_destroy_source.
7226 (glob var get_source) New var.
7228 * inpt-pgm.c: (cmd_input_program) Sets vfm_source instead of
7229 read_active_file and cancel_input_pgm.
7230 (read_from_input_program) Renamed input_program_source_read.
7231 Simplified debug output.
7232 (cancel_input_program) Renamed
7233 input_program_source_destroy_source.
7234 (glob var input_program_source) New var.
7236 * loop.c: (loop_1_trns_proc) Simplified debug output.
7238 * main.c: (dump_token) Made eof output more explicit.
7240 * sfm-read.c: (read_variables, dump_dictionary) Removed `lv'
7243 * sort.c: (cmd_sort_cases) Disallows scratch variables. Removed
7244 code for always-memory or always-disk cases. malloc's case-list
7245 based on vfm_source_info.ncases. Explicit support for
7246 memory_stream via memory_source_cases.
7247 (do_external_sort) Sets vfm_source instead of read_active_file and
7249 (allocate_file_handles) The temporary directory permissions are
7250 set to 0700 instead of 0777.
7251 (allocate_cases) Formatting fixes. Simplified debug output.
7252 (output_record) Compacts the case if necessary before writing it
7254 (close_handle, open_handle_w) Simplified debug output.
7255 (write_initial_runs) Destroys vfm_sink, then sets it to
7256 sort_stream. Writes records to memory based on
7257 vfm_sink_info.case_size.
7258 (write_to_sort_cases) Renamed sort_stream_write().
7259 (merge) Simplified error handling. Simplified debug output.
7261 (read_from_external_sort) Renamed sort_stream_read().
7262 Reads records based on vfm_source_info.case_size.
7263 (sort_stream_write) Writes records to memory based on
7264 vfm_sink_info.case_size.
7265 (sort_stream_mode) New function.
7266 (glob var sort_stream) New variable.
7268 * temporary.c: (cmd_temporary) Simplified debug output.
7269 (copy_variable) Removed references to `lv'.
7271 * title.c: (get_title) Simplified debug output.
7273 * var.h: Comment fixes.
7274 (struct get_proc) Removed member `lv'.
7275 (struct variable) Removed member `lv'. Comment fixes.
7276 (glob vars read_active_file, write_active_file, cancel_input_pgm)
7278 (struct case_stream) New.
7280 * vars-atr.c: (discard_variables) Changed cancel_input_pgm,
7281 read_active_file references to use vfm_source.
7282 (init_variable, replace_variable) Removed references to `lv'.
7284 * vfm.c: Comment fixes.
7285 (glob var vfm_source, vfm_sink, vfm_source_info, vfm_sink_info)
7287 (static var queue, qh, qt, n_lag) Removed. All references
7289 (glob var compaction_necessary, compaction_nval, compaction_case,
7290 paging) New variables.
7291 (record_case) Removed.
7292 (procedure) Comment fixes. Calls vfm_source->read() instead of
7295 (prepare_for_writing, arrange_compaction, make_temp_case,
7296 vector_initialization, setup_filter) New function.
7297 (open_active_file) Most of the code moved into the abovementioned
7298 new functions. Now sets temp_dict to &default_dict if there is no
7299 temporary dictionary, for convenience. New debug output.
7300 (close_active_file) Deals with changing the sink to the source.
7301 Calls finish_compaction(). Frees compaction_case. Mostly
7303 (glob vars disk_source_file, disk_sink_file) New vars.
7304 (destroy_active_file, read_from_memory) Removed.
7305 (disk_stream_init, disk_stream_read, disk_stream_write,
7306 disk_stream_mode, disk_stream_destroy_source,
7307 disk_stream_destroy_sink) New functions.
7308 (glob var vfm_disk_stream) New var.
7309 (glob vars memory_source_cases, memory_sink_cases,
7310 memory_sink_iter, memory_sink_max_cases) New vars.
7311 (memory_stream_init, memory_stream_read, memory_stream_write,
7312 memory_stream_mode, memory_stream_destroy_source,
7313 memory_stream_destroy_sink) New functions.
7314 (glob var vfm_memory_stream) New var.
7315 (write_case) Local var `i' renamed `cur_trns'; local var `retval'
7316 named `more_cases'. Simplified debug output. Otherwise mostly
7318 (record_case) Moved into the stream drivers. Removed.
7319 (transform) Removed (was dead code).
7320 (SPLIT_FILE_procfunc) s/vfm_replacement/vfm_sink_info/. In the
7321 common case that the splits don't change, we don't need to copy
7322 the case into prev_case again--pointless.
7323 (compact_case) New function.
7324 (finish_compaction) New function.
7326 * vfmP.h: Comment fixes.
7327 (DEV_* enum series) Removed.
7328 (struct storage) Renamed `stream_info'. Removed variant record.
7329 Removed `device' member.
7331 * debug-print.h: New file.
7333 Sun Jun 8 01:12:38 1997 Ben Pfaff <blp@gnu.org>
7335 * autorecode.c: Turned off debugging.
7337 * data-list.c: (destroy_dls) Closes the associated file handle.
7339 * descript.q: (custom_variables) Added PV_NO_SCRATCH to
7340 parse_variables() options.
7342 * dfm.c: (open_file_r) Removed gratuituous argument to msg() call.
7344 * display.c: (display_variables) Really fixed null cell bug.
7346 * file-handle.q: (fh_close_handle) Changed debugging message.
7348 * frequencies.q: (custom_variables) Added PV_NO_SCRATCH to
7349 parse_variables() options.
7351 * list.q: Added PV_NO_SCRATCH in q2c varlist options.
7352 (cmd_list) Fails if no variables specified.
7353 (determine_layout) Writes blank lines manually.
7355 * loop.c: (loop_1_trns_proc) Made debugging code only print
7356 messages if debugging.
7358 * q2c.c: (dump_subcommand) Appends sbc->message to SBC_VARLIST
7359 parse_variables() arguments.
7360 (main) Parses optional parenthesized options to varlist
7361 subcommands into sbc->message.
7363 * sfm-read.c: Format fix.
7365 * var.h: (FV_*) New enum series.
7366 (PV_*) New enum PV_NO_SCRATCH.
7368 * vars-prs.c: (find_var) Removed.
7369 (fill_all_vars) Takes FV_* enum instead of boolean third
7370 argument. Rewritten to deal with scratch as well as system
7372 (parse_variables) Error message on scratch variable if
7375 * vfm.c: (static var virt_begin_func) New var.
7376 (procedure) Sets up virt_begin_func.
7377 (SPLIT_FILE_procfunc) For the first case, calls virt_begin_func()
7378 after dump_splits(). For succeeding groups changes, calls
7379 virt_begin_func() instead of begin_func().
7381 Fri Jun 6 22:42:23 1997 Ben Pfaff <blp@gnu.org>
7383 * count.c, data-out.c, file-handle.q, list.q, loop.c: Turned off
7386 * dfm.c: Added some debugging messages, disabled by default.
7387 (open_file_r) Fixed error message.
7388 (read_record) On eof on inline_file, instead of calling
7389 fh_close_handle(), simply jump to eof label like a normal file.
7392 * display.c: Thin lines between rows for certain kinds of
7393 listing. Fixed `null cell' bug.
7395 * error.c: (failure) Flush stdout, stderr before failing.
7397 * file-handle.q: (fh_close_handle) Added debugging message.
7399 * frequencies.q: (dump_full) Bottom line extends across entire
7400 table width. Changed title formatting.
7401 (dump_condensed) Changed title formatting.
7402 (dump_statistics) Fixed title formatting.
7404 * glob.c: (init_glob) Moved initialization of cur_proc out of #if.
7405 Sets default value of set_format.
7407 * list.q: (cmd_list) Calls blank_line() before determine_layout().
7408 Passes write_all_headers() to procedure() as pre-group func.
7409 (write_all_headers) New function.
7410 (determine_layout) Removed calls to write_header().
7411 Calls blank_line() before and after write_fallback_headers().
7413 * recode.c: (recode_trns_free) Only attempts to free head->map if
7416 * sfm-read.c: (read_variables) Allows `#' at beginning of system
7417 file variable names but gives a warning. Sets `left' based on
7418 first character being/not being `#'. On lossage frees dict->var.
7420 * som-high.c: (som_draw_title) Simplified title formatting.
7422 * vfm.c: (dump_splits) Fixed and changed splits formatting.
7424 Thu Jun 5 22:51:15 1997 Ben Pfaff <blp@gnu.org>
7426 * autorecode.c: (cmd_autorecode) Sets h_trans to NULL at
7427 beginning. Frees v_src, v_dest on successful exit. Frees
7428 h_trans[*], h_trans on lossage.
7429 (recode) Frees h_trans[*], h_trans.
7431 * dfm.c: (dfm_close) Formatting change.
7432 (open_inline_file) Now passed a dfm_fhuser_ext to initialize; no
7433 longer allocates its own in inline_file.
7434 (open_file_r) Passes the local dfm_fhuser_ext to
7436 (open_file_w) Message fix.
7437 (read_record) Buffer reallocation strategy changed. Frees
7438 ext->line even in inline_file to prevent leaks.
7439 (dfm_put_record) Fixed bug where `ext' was cached before the file
7440 was opened and thus it would be NULL when the file really was
7442 (cmd_begin_data) Sets up inline_file basics itself, then calls
7443 open_inline_file() for the dfm_fhuser_ext. Formatting fix.
7445 * list.q: (write_line) Formatting fix.
7446 (clean_up) Minor strategy change. Sets proportional font after
7448 (determine_layout) Sets fixed font before writing regular headers,
7449 or after writing fallback headers.
7451 * modify-vars.c: (cmd_modify_vars) Frees variable lists for DROP
7452 and KEEP vars after using them.
7454 * postscript.c: (ps_init_driver) Frees x->family.
7455 (postopen) When loading fonts, free the temporary font name buffer
7457 (ps_text_set_font_by_position) Free temporary font name buffer
7459 (text) Fixed code that calculated `lig' so that `lig' always gets
7460 initialized. Formatting fix.
7462 * som-low.c: (get_cell_size, som_get_table_size) `prop_height' ->
7464 [GLOBAL_DEBUGGIGN] (check_table) Use arena_alloc() to allocate
7465 cells, not xmalloc(), so that the cells will get destroyed
7468 * sysfile-info.c: (cmd_sysfile_info) Frees the dictionary after
7471 Tue Jun 3 23:33:22 1997 Ben Pfaff <blp@gnu.org>
7473 * ascii.c: (ascii_text_draw) Always sets metrics for strings that
7476 * dfm.c: Comment fix.
7478 * list.q: Comment fixes. Include somP.h. Removed static vars
7479 table, n_columns, n_rows, part. New struct list_ext. New static
7481 (n_lines_remaining, n_chars_width, write_line) New functions.
7482 (cmd_list, list_cases) Rewritten.
7483 (begin_row, end_row, flush_table) Removed.
7484 (write_header, clean_up, write_varname, write_fallback_headers,
7485 determine_layout) New functions.
7487 * output.c: (outp_iterate_enabled_drivers) Minor reformat.
7489 * output.h: Comment fix.
7491 * postscript.c: Comment fix.
7492 (struct ps_driver_ext) Removed prop_size, fixed_size members;
7493 added font_size. All references changed.
7494 (ps_init_driver) Initializes font_size. Simplified space checking
7496 (static var option_tab[]) Removed prop-size, fixed-size; added
7498 (ps_option) Handles font_size.
7500 * som-high.c: Moved prototypes into somP.h.
7501 (som_init_driver) New function.
7502 (som_submit_table) Moved some code into new function
7504 (build_target) Moved some code into new function
7505 som_internal_eject_page().
7506 (som_eject_page) Uses som_internal_eject_page().
7507 (som_internal_eject_page) New function.
7509 * som-low.c: Moved prototypes into somP.h.
7511 * som.h: Formatting fixes.
7513 * somP.h: (struct som_driver_ext) Removed em_width;
7514 added prop_em_width, fixed_width.
7516 Mon Jun 2 14:25:25 1997 Ben Pfaff <blp@gnu.org>
7518 * Makefile.am: Added `localedir' definition. Added
7519 -DLOCALEDIR="..." to DEFS. Added -I. to INCLUDES.
7521 * ascii.c: (macro draw_line) Fixed capitalization.
7523 * ascii.c, autorecode.c, cases.c, cmdline.c, command.c, common.c,
7524 compute.c, count.c, data-in.c, data-list.c, data-out.c,
7525 descript.q, dfm.c, display.c, do-if.c, error.c, expr-evl.c,
7526 expr-opt.c, expr-prs.c, file-handle.q, file-type.c, filename.c,
7527 formats.c, frequencies.q, get.c, getline.c, glob.c, groff-font.c,
7528 hash.c, heap.c, include.c, inpt-pgm.c, lexer.c, list.q, loop.c,
7529 main.c, mis-val.c, misc.c, modify-vars.c, numeric.c, output.c,
7530 postscript.c, print.c, q2c.c, recode.c, rename-vars.c, repeat.c,
7531 sample.c, sel-if.c, sfm-read.c, sfm-write.c, sfmP.h, som-frnt.c,
7532 som-high.c, som-low.c, sort.c, split-file.c, sysfile-info.c,
7533 temporary.c, title.c, tokens.h, val-labs.c, var-labs.c,
7534 vars-atr.c, vars-prs.c, vector.c, vfm.c, weight.c: Marked strings
7535 for internationlization.
7537 * glob.c: [HAVE_LOCALE_H] Includes locale.h.
7539 Sun Jun 1 23:31:18 1997 Ben Pfaff <blp@gnu.org>
7541 * do-if.c, sort.c, val-labs.c: Comment fixes.
7543 * glob.c: (init_glob) Uncommented, updated i18n support.
7545 * arena.c, ascii.c, data-in.c, descript.q, error.c, expr-evl.c,
7546 expr-opt.c, expr-prs.c, filename.c, frequencies.q, groff-font.c,
7547 output.c, postscript.c, sfm-read.c, som-high.c, vars-prs.c: Made
7548 the declarations of macros taking arguments a lot nicer.
7550 Sun Jun 1 17:22:04 1997 Ben Pfaff <blp@gnu.org>
7552 * error.h: Removed CE, CW aliases for SE, SW.
7554 * q2c.c: Removed explicit streq() definition since it's duplicated
7557 * approx.h, error.h, font.h, hash.h, misc.h, output.h, somP.h,
7558 stats.h, str.h, tokens.h: Made the declarations of macros taking
7559 arguments a lot nicer-looking of <pinard@iro.umontreal.ca>.
7562 Sun Jun 1 12:02:06 1997 Ben Pfaff <blp@gnu.org>
7564 * cmdline.c: Comment fixes.
7565 (pick_compat) Changed return type to int. Now, instead of setting
7566 glob var `compat' to the emulation, returns the emulation. All
7568 (parse_command_line) Added terminating null to end of
7569 `long_options' array definition.
7570 (pre_syntax_message) Fixes.
7571 (usage) Shows the default emulation in the syntax message by
7572 calling pick_compat().
7574 * getline.c: (getl_add_include_dir) Separates paths with
7575 PATH_DELIMITER, not DIR_SEPARATOR.
7577 * glob.c: (init_glob) Fixed references to DEFAULT_VER_PCP40,
7578 DEFAULT_VER_WIN61, DEFAULT_VER_X40.
7580 * output.c: (outp_configure_macro) Make earlier definitions for a
7581 particular key override later ones for the same key.
7583 Fri May 30 19:40:49 1997 Ben Pfaff <blp@gnu.org>
7585 * ascii.c: Comment fixes.
7587 * output.c: (outp_get_paper_size)
7588 s/STAT_OUTPUT_INIT_FILE/STAT_OUTPUT_PAPERSIZE_FILE/.
7590 Sun May 25 22:34:07 1997 Ben Pfaff <blp@gnu.org>
7592 * ascii.c, postscript.c, sfm-read.c, sfm-write.c, sort.c: Include
7593 <errno.h>. GNU libc 2 enforces this!
7595 * command.c: (parse_cmd) Fixed problem with `else' clause being
7596 paired with wrong `if'. Comment fix.
7598 Fri May 9 16:53:52 1997 Ben Pfaff <blp@gnu.org>
7600 * getline.c: [!HAVE_LIBREADLINE] (read_console) Changed
7601 blp_getline() to getline().
7603 * output.c: (outp_eval_dimension) Changed the fix from last time;
7604 there was no variable `a'.
7606 * q2c.c: (get_line) Fixed boundary condition overrun bug.
7608 Mon May 5 21:58:22 1997 Ben Pfaff <blp@gnu.org>
7610 * output.c: (outp_evaluate_dimension) Fixed handling of negative
7611 numbers having fractional parts. Added case of a fraction without
7612 a whole-number part.
7614 Fri May 2 22:08:05 1997 Ben Pfaff <blp@gnu.org>
7616 * ascii.c: (ascii_text_get_font_position) Removed.
7618 * expr.h, exprP.h: Disabled debugging.
7620 * groff-font.c, postscript.c: Changed `groff' to `Groff' in
7623 * output.h: (struct outp_class_struct) Removed
7624 text_get_font_position method. All references deleted.
7626 * postscript.c: Big change here. Fontmaps were completely
7627 eliminated because of a change in philosophy. Comment fixes.
7628 (struct ps_fontmap, ps2dit_map, font_family, dit2family_map)
7630 (struct ps_driver_ext) `position', `fontmap', `prop_name',
7631 `fixed_name' members removed. New members `prop_family',
7632 `fixed_family'. `family' member changed to type char *.
7633 (static var ps_fontmaps) Removed.
7635 (ps_init_driver) Removed obsolete references, updated.
7636 Initializes `translate_x', `translate_y', `scale'. Doesn't read
7637 fontmap, of course. Refers to font names through internal_name
7638 rather than subversive means. Frees proper items.
7639 (static var option_tab[]) Removed `fontmap-file' option; renamed
7640 `fixed-font', `prop-font'.
7641 (ps_option) Corresponds to option_tab[].
7642 (read_fontmap, release_fontmap, ps_to_dit, compare_ps2dit,
7643 hash_ps2dit, compare_dit2family, hash_dit2family, compare_family,
7644 hash_family) Removed.
7645 (postopen) Generates font names from family names. Gets
7646 PostScript font name properly. New prologue file comment `!!!'
7648 (ps_open_page) Adds translate_x, translate_y to BP prologue
7649 function; gives SF argument floating-point format.
7650 (ps_text_set_font_by_name) Doesn't try to map PostScript->Groff
7651 font name. Doesn't change font family.
7652 (ps_text_set_font_by_position) Generates Groff font name from font
7653 family name instead of through table lookup.
7654 (ps_text_set_font_by_family) Renamed `ps_text_set_font_family',
7655 all references changed. Reduced to simple string assignment.
7656 (ps_get_font_name) Removed.
7657 (ps_get_font_family) Reduced to string return.
7658 (text) Doesn't save `position' since it no longer exists. Ugly
7659 kluge to save font family--fix soon?
7660 (load_font) Removed PostScript name argument.
7662 Thu May 1 14:58:59 1997 Ben Pfaff <blp@gnu.org>
7664 * postscript.c: Comment fix.
7665 (ps_open_page) Puts scale factor in PostScript output.
7667 Sat Apr 26 11:49:32 1997 Ben Pfaff <blp@gnu.org>
7669 * Makefile.am: Distcleans q2c.
7671 Wed Apr 23 21:33:48 1997 Ben Pfaff <blp@gnu.org>
7673 * ascii.c: (delineate) Sets text size even if width is zero.
7675 * command.c: Comment fix.
7676 (static var cmd_table[]) Re-enabled EVALUATE command.
7677 (parse_cmd) Lotsa comment fixes. Fixed infinite loop in parsing
7678 of comments in script files. Now more liberal on criteria for
7679 performing a state transition--if *anything* happened correctly,
7680 not just if *everything* happened correctly.
7682 * data-out.c: (convert_F) Comment fix. Why in the fsck does
7683 Checker segfault on formatting large numbers and why in the fsck
7684 hadn't I noticed this before?
7686 * expr.h, exprP.h: No longer turn off GLOBAL_DEBUGGING.
7688 * list.q: (cmd_list) Commented out the actual output routine
7689 because of various problems. Probably will abandon the idea of
7690 using the general `crushed tables' for the LIST procedure.
7692 * temporary.c: (restore_dictionary) Sets var_by_name to NULL after
7693 clearing it. Allocates a new var_by_name dictionary before trying
7694 to add members to it.
7696 * vars-atr.c: [DEBUGGING] (dump_one_var_node) Removed argument
7697 `sib'. Changed type of `node' argument.
7698 [DEBUGGING] (dump_var_tree) Replaced avlwalk() with
7700 (clear_variable) Only dumps the var tree if var_by_name non-NULL.
7701 [DEBUGGING] Only deletes the variable from var_by_name if that var
7704 Fri Apr 18 16:48:41 1997 Ben Pfaff <blp@gnu.org>
7706 * Makefile.am: Added include files to SOURCES. Added
7707 frequencies.q to EXTRA_DIST. Removed include/ from INCLUDES. Now
7708 includes rules for q2c. Added `boast' target.
7710 Fri Apr 18 15:42:22 1997 Ben Pfaff <blp@gnu.org>
7712 * Makefile.am: Maintainer-clean Makefile.in.
7714 * Makefile.am: Fixed redundant EXTRA_DIST line.
7716 * ascii.c: Comment fixes.
7717 (ascii_line_vert) Fixed overly aggressive range check.
7719 * display.c: Removed dead code.
7721 * list.q: Turn debugging on.
7722 (flush_table) New debug code.
7724 * sfm-read.c: (read_value_labels) malloc's the structure before
7725 trying to assign to its members.
7727 * sfm-write.c: Comment fix.
7729 * som-high.c: (som_submit_table) Sets som.t and som.d on each call
7731 (output_table) No arguments anymore--gets them through `som'
7732 global. New debug code. In crushed tables, now sets `htv' as
7733 well as `hv' to avoid bad confusion later.
7734 (dump_crush_page) New debug code.
7736 * som-low.c: (som_dump_crush_page) New debug code.
7738 Thu Mar 27 01:11:29 1997 Ben Pfaff <blp@gnu.org>
7740 All source files: Broke long lines into multiple lines.
7742 * ascii.c: (ascii_close_page) Uses host_system var in place of
7743 HOST_SYSTEM constant.
7745 * cmdline.c: (var syntax_message[]) Broke into
7746 pre_syntax_message[] and post_syntax_message[].
7747 (usage) Outputs both parts, separated by driver list.
7749 * error.h: Fixed broken formatting.
7751 * expr-opt.c: (str_search, str_rsearch) New functions.
7753 * misc.c: (blp_getdelim) Removed. All references changed to
7755 (str_search, str_rsearch) Removed.
7756 (memrmem) New function.
7758 * misc.h: (blp_getline) Removed. All reference changed to
7763 * filename.c: Includes "stat.h", not <sys/stat.h>.
7764 (blp_getenv) Uses host_system var instead of HOST_SYSTEM constant.
7766 * output.c: (outp_list_classes) Changed output formatting.
7768 * sfm-write.c: (write_header) Uses host_system var instead of
7769 HOST_SYSTEM constant.
7770 (write_rec_7_34) Extracts version numbers from the version string.
7773 * sort.c: Includes "stat.h", not <sys/stat.h>.
7775 * str.c: (strcasecmp) Removed.
7777 * title.c: (cmd_document) Uses host_system var instead of
7778 HOST_SYSTEM constant.
7780 * version.c: Generated on-the-fly by the Makefile instead of being
7783 * str.h: Comment fixes. Doesn't substitute for missing memmove or
7785 [!HAVE_STRNCASECMP] Declares strncasecmp().
7787 * version.h: Removed stray character. Comment fixes.
7788 (vars host_system, build_system) New vars.
7790 Mon Mar 24 21:47:31 1997 Ben Pfaff <blp@gnu.org>
7792 * Most source files: Changed formatting of copyright notice; fixed
7793 FSF address; reformatted to better conform to GNU standards;
7794 comment fixes. Added markups to prevent GNU indent from messing
7795 up my beautiful formatting :-).
7797 * q2c.c: (get_line) Ignores lines that begin with `/* *INDENT' so
7798 that GNU indent markups can be passed through without problems.
7800 Wed Feb 19 21:30:31 1997 Ben Pfaff <blp@gnu.org>
7802 * get.c: Turned off debugging.
7804 * glob.c: (init_glob) Turned on save-file compression by default.
7806 * sfm-write.c: (sfm_write_case) Fixed bug which resulted in less
7807 compression than was possible in save files.
7809 Sun Feb 16 20:57:20 1997 Ben Pfaff <blp@gnu.org>
7811 * data-out.c: (convert_F) Comment fixes. Debug message fixes.
7813 * frequencies.q: Removed Fiasco extensions. Updated calculation
7814 algorithms. Polished output format.
7815 (struct frq_info_struct) Removed members `max_degree', `min_n',
7816 all references removed.
7817 (macro frq_extensions) Removed.
7818 (static vars min_n, max_degree) Removed, all references removed.
7819 (internal_cmd_frequencies) Doesn't handle extensions. Doesn't
7820 calculate `min_n', `max_degree'.
7821 (postcalc) Passes new arg to dump_statistics().
7822 (dump_full) Honor NOLABEL option. Buggy? Adds variable name
7824 (dump_condensed) Adds variable name title.
7825 (sum_freqs) Removed.
7826 (calc_stats) Updated calculation algorithm.
7827 (dump_statistics) Removed warning for too-few observations.
7828 Changed table formatting. Adds variable name title if passed new
7831 * output.h: Comment fix.
7833 * recode.c, sample.c, sort.c: Disabled debug code.
7835 * som-frnt.c: (som_set_value, som_set_float, som_set_text)
7836 Improved debug code.
7838 * var.h: (enum series frq_*) Removed Fiasco extensions.
7840 Sat Feb 15 21:26:53 1997 Ben Pfaff <blp@gnu.org>
7842 * command.c: Added PROCESS IF to command table.
7844 * Lots & lots of places, removed checks for NULLs preceding calls
7845 to free_expression(), which itself checks.
7847 * descript.q: Removed Fiasco extensions. Removed optimizations
7848 for non-weighted active files. Implemented some options.
7849 Finished polishing output format. Comment fixes. Merged
7851 (static vars n_glob_miss_list, n_glob_valid, n_glob_missing,
7852 max_degree, min_n) Removed.
7853 (macro dsc_extensions) Removed.
7854 (struct dsc_info_struct) Removed `min_n' member, all references
7856 (internal_cmd_descriptives) Removed calculation of min_n,
7857 max_degree. Only deals with one `calc' routine instead of two
7859 (precalc) Eliminated redundancy. Updated for changes to
7860 descriptives_proc structure.
7861 (calc) Moved here from `descript.g'. Rewritten to calculate
7862 statistics via `moments about the mean' rather than by summing,
7863 summing squares, summing cubes, and so on.
7864 (postcalc) Rewritten for new-style statistical calculation.
7865 (display) Removed support for displaying variables across rows.
7866 No longer crushes the descriptives table. Removed ancient code.
7867 Added display of N, by variable and listwise.
7869 * descript.g: Removed; merged into `descript.q'.
7871 * expr-evl.c: (evaluate_expression) Now returns a double. For
7872 numeric results, it returns the result as well as storing it in
7873 the passed `value' structure if non-NULL. For string results it
7874 just returns 0.0 and it must be passed non-NULL. Many references
7875 to this function were optimized by use of this change, especially
7876 but not exclusively in `compute.c'.
7878 * frequencies.g: Comment fix.
7880 * glob.c: (glob var process_if_expr) New global var.
7882 * postscript.c: (static var option_tab[]) Corrected entry for
7884 (postopen) Sets x->size to x->prop_size.
7885 (ps_text_set_font_by_name) Sets font size as well as typeface for
7886 PROP and FIXED fonts.
7888 * sel-if.c: (cmd_process_if) New function.
7890 * sfm-write.c: (struct sfm_fhuser_ext) New member `n_cases'.
7891 (sfm_write_dictionary) Sets `n_cases' to 0.
7892 (sfm_write_case) Increments `n_cases'.
7893 (sfm_close) Attempts to seek the system file back to the header
7894 and write the number of cases in its proper slot.
7896 * som-frnt.c: (som_insert_table) Masks off expansion options since
7897 only SOPT_X_NORM seems to work sensibly.
7899 * som-low.c: (get_cell_size) Fixed bug when a table cell was sized
7900 with a `fixed' value of 2.
7902 * sort.c: (cmd_sort_cases) Cancels PROCESS IF.
7904 * sysfile-info.c: (cmd_sysfile_info) Doesn't display more than 10
7905 value labels; uses SOPT_NONE instead of SOPT_X_BOTH.
7907 * var.h: (enum series dsc_*) Removed Fiasco extensions.
7908 (struct descriptives_proc) Removed `miss_noweight'; new members
7909 `X_bar', `M2', `M3', `M4', `min', `max'.
7911 * vars-atr.c: (discard_variables) Cancels PROCESS IF.
7913 * vfm.c: (close_active_file) Cancels PROCESS IF.
7914 (write_case) Doesn't process cases unselected by PROCESS IF.
7916 Fri Feb 14 23:32:58 1997 Ben Pfaff <blp@gnu.org>
7918 * glob.c: (glob var err) Removed.
7920 * sysfile-info.c: (cmd_sysfile_info) When adjusting table size,
7921 doesn't have to take into account number of value labels since
7922 they're in a subtable anyway. Also, doesn't display more than 10
7923 value labels since we can't yet break pages in subtables.
7925 Tue Feb 4 15:15:50 1997 Ben Pfaff <blp@gnu.org>
7927 * som-frnt.c: (som_change_table_size) Simple change for elegance
7928 that shouldn't change behavior.
7929 (som_set_value) Comment fix.
7931 * som-high.c: (som_submit_table) Message fix.
7933 Wed Jan 22 21:54:00 1997 Ben Pfaff <blp@gnu.org>
7935 * command.c: Added SYSFILE INFO to command table.
7937 * file-handle.q: (fh_handle_filename) New function.
7939 * get.c: (save_trns_proc) Fixed a bug in padding of output data
7942 * main.c: (parse) New return value for command functions, -3.
7944 * misc.h: Comment fix.
7946 * output.h: Comment fixes.
7947 (macro COMPONENTS) Removed.
7949 * postscript.c: (write_text) Modified literal_chars[] so that `('
7950 and ')' are not written to the output in strings as literals.
7952 * sfm-read.c: (sfm_read_dictionary) New argument.
7953 (read_header) New argument. Sets the information structure's
7954 values from the header information.
7955 (read_variables) [__CHECKER__] Redefines isalnum()--some sort of
7956 bizarre Checker problem, I guess.
7957 (read_variables) Proper cleanup on lossage.
7959 * sfm.h: (struct sfm_read_info) New struct for use by
7960 sfm_read_dictionary().
7962 * som-frnt.c: (som_create_table) New argument CREATE_FLAGS,
7963 currently used just for tables that can be dynamically resized and
7964 thus have to be allocated with arena_malloc() instead of
7965 arena_alloc(). All references changed.
7966 (som_change_table_size) New function.
7967 (som_insert_table) Bugfix: now inserts `cell', not `c'!
7969 * som-high.c: [GLOBAL_DEBUGGING] (check_table) Moved to som-low.c.
7970 (som_submit_table) [GLOBAL_DEBUGGING] Doesn't call check_table()
7973 * som-low.c: (draw_cell) Calls draw_table_cell() for SCON_TABLE
7975 (draw_intersection) Now takes an argument specifying the table in
7976 question. All references changed.
7977 (draw_table_cell) New function.
7978 (som_get_table_size) [GLOBAL_DEBUGGING] Calls check_table().
7979 (som_get_table_size) Many nice new explanatory comments.
7980 [GLOBAL_DEBUGGING] (check_table) Moved here from som-high.c.
7982 * som.h: New enum series SOM_CREATE_* for use as create flags with
7985 * str.h: Moved a comment here from TODO.
7987 * sysfile-info.c: New file. Reference implementation.
7989 Sun Jan 19 14:22:11 1997 Ben Pfaff <blp@gnu.org>
7991 * command.c: Added RENAME VARIABLES to table of commands.
7993 * data-in.c: (dls_error) Sets `cust_field'.
7994 (parse_N) Message fix.
7995 (parse_day_count) New function.
7996 (to_roman) Never outputs VX as a `short form' of V.
7997 (parse_month) Fixed parsing of Roman numerals.
7998 (parse_trailer) Message fix.
7999 (parse_DATE, parse_ADATE, parse_EDATE, parse_SDATE, parse_JDATE,
8000 parse_QYR, parse_MOYR, parse_WKYR, parse_DTIME) Issue a message if
8001 the date is invalid.
8002 (parse_SDATE) Fixed swapped day, year.
8003 (parse_JDATE) Fixed bug for dates in 1582.
8004 (parse_DTIME) Allows days not between 1 and 31.
8005 (parse_numeric) Makes local copy of f.type for easier usage.
8008 * data-out.c: (convert_F) When outputting as scientific, properly
8009 sets f.type as fp->type.
8010 (insert_commas) Fixed operator precedence problem with setting of
8011 nitems. Changed strcpy to memcpy (no null terminator).
8012 (convert_date) Fixed FMT_JDATE: added 1900 to year.
8013 (convert_CCx) Essentially rewritten, but now it works.
8015 * display.c: (cmd_display) Added DISPLAY FILE LABEL (undocumented
8017 (display_documents) Implemented.
8019 * error.c: (glob var cust_field) New var.
8020 (vmsg) Displays cust_field as part of message classes DE and DW.
8022 * formats.c: (debug_print) Fixed to compile under updated
8025 * get.c: (cmd_get, cmd_save_internal) Close file handle on
8028 * misc.c: (parse_format_specifier) Formatting fix.
8030 * modify-vars.c: (struct var_modification) Renamed `n_reorder' as
8031 `n_rename' for clarity.
8032 (cmd_modify_vars) Initializes `forward' and `positional' at
8033 appropriate times. Frees lists of vars to rename on failure.
8034 Comment fix. Frees memory on success.
8035 (rearrange_dict) Simplified `for' loop condition.
8037 * rename-vars.c: New file (reference implementation).
8039 * set.q: (internal_cmd_set) Fixed `emu' test condition.
8041 * sfm-read.c: (read_header) File label is created only if file
8042 label in file is not blank.
8043 (read_variables) Initializes `dict' local variable.
8044 (read_documents) Proper behavior on lossage.
8046 * sfm-write.c: (write_header) Doesn't blank out the file label
8047 (why was this here to begin with?!)
8049 * temporary.c: (save_dictionary) File label is copied only if
8050 non-NULL. Doesn't try to xstrdup() dictionary documents.
8051 Adapted so as to not irritate Checker.
8052 (free_dictionary) Only destroys var_by_name if non-NULL.
8054 * title.c: (cmd_file_label) Doesn't skip FILE, LABEL tokens.
8055 (cmd_document) Doesn't skip DOCUMENT token. Adds some header
8056 lines to the document, indents the document. Also, it works now.
8057 (add_document_line) New function.
8059 * var.h: (struct dictionary) Reordering.
8061 * vars-prs.c: (parse_variables) On lossage, only local_free()'s
8062 bits if it was allocated to begin with.
8064 Thu Jan 16 13:08:57 1997 Ben Pfaff <blp@gnu.org>
8066 * command.c: Added MODIFY VARS to list of commands.
8068 * configure.in: Updated custom macros for autoconf 2.12. Removed
8069 mmap reference; fixed termcap library reference.
8071 * display.c: (display_variables) Fixed a few bugs although it's
8072 still not well written.
8074 * error.c: [!__CHECKER__] (chkr_disp_call_chain) New function.
8075 (induce_segfault) Calls chkr_disp_call_chain() instead of
8076 inducing an actual SIGSEGV.
8078 * expr-opt.c: (evaluate_tree) Swapped order of arguments to
8079 str_search() and str_rsearch(). Fixed tests for matches on
8080 OP_INDEX and OP_RINDEX.
8082 * filename.c: (good_getcwd) Removed as the new libc for Checker
8083 doesn't contain this bug, apparently.
8085 * misc.c: (str_search, str_rsearch) Changed order of arguments for
8086 consistency with GNU memmem.
8087 (blp_getdelim) Changed `len' from `int' to `size_t'.
8089 * modify-vars.c: Reference implementation.
8091 * som-frnt.c: (zero_length) New global var.
8092 (som_create_table) Message fix.
8094 * som.h: Added gcc attributions to som_set_text(),
8095 som_output_text() prototypes. blank_line() refers to
8096 zero_length[] instead of a literal null string to suppress gcc
8099 * sort.c: (do_external_sort) Fixed fencepost error on lossage.
8100 (allocate_cases) Decrements x_max so the last element of x[] can
8101 be used by the algorithm.
8103 * var.h: Changed minor details of `variable' declaration.
8104 (struct modify_vars_proc) New struct.
8105 (struct variable) Added field p.mfv.
8107 * vars-atr.c: Comment fix.
8109 * vars-prs.c: (fill_all_vars) More optimal implementation.
8111 * vfm.c: (dump_splits) Sets the last byte of temp_buf to a null
8112 character, which it shouldn't have to do but printf() seems to
8113 read the null byte even though I supply a maximum length...
8115 Fri Jan 10 20:22:08 1997 Ben Pfaff <blp@gnu.org>
8117 * command.c: Removed command alias X for QUIT.
8118 (parse_cmd) Fixed comment parsing.
8120 * dfm.c: (struct dfm_fhuser_ext) Fields `len', `size' are now of
8122 (read_record) Fixed references to len, size.
8123 (dfm_get_record) Restructured.
8125 * file-handle.h: (struct file_handle) Field `lrecl' now of type
8128 * file-handle.q: (internal_cmd_file_handle) Checks for nonpositive
8131 * modify-vars.c: New file. Not complete.
8133 * set.q: (set_ccx) Fixed operator precedence problem regarding ^
8136 * sfm-read.c: (bswap_flt64, read_header, write_variable) Fixed
8137 problems caused by int/size_t differences.
8139 * sort.c: (output_record, merge_once) Cast `size_t's to `int's in
8142 * str.c: (strcasecmp) Fixed bug that cropped up when the strings
8143 being compared were of equal length.
8145 Thu Jan 2 19:08:23 1997 Ben Pfaff <blp@gnu.org>
8147 * command.c: Added DOCUMENT, DROP DOCUMENTS, FILE LABEL.
8149 * lexer.c: (get_dotted_rest_of_line) New function.
8151 * sel-if.c: (cmd_filter) Cannot choose string or scratch variables
8154 * sfm-read.c: (sfm_read_dictionary) Calls read_documents() to read
8155 type 6 records. Frees the dictionary properly.
8156 (read_header) Initializes the dictionary instead of letting
8157 read_variables() do it. Sets the dictionary file label from the
8159 (read_documents) New function.
8161 * sfm-write.c: (sfm_write_dictionary) Calls write_documents() to
8162 write type 6 record if appropriate.
8163 (write_header) Writes file label from dictionary.
8164 (write_documents) New function.
8166 * temporary.c: (save_dictionary, restore_dictionary,
8167 free_dictionary) Properly handle new fields in dictionary struct.
8169 * title.c: (get_title) Returns after failure().
8170 (cmd_file_label, cmd_document, cmd_drop_documents) New functions
8171 for new commands FILE LABEL, DOCUMENT, DROP DOCUMENTS. Untested.
8173 * var.h: (struct dictionary) New fields `label', `n_documents',
8176 Wed Jan 1 22:08:10 1997 Ben Pfaff <blp@gnu.org>
8178 * command.c: Added FILTER to list of commands.
8180 * frequencies.g: [WEIGHTING] Removed test for weighting!=-1 since
8183 * get.c: (cmd_save_internal) Removed weighting code since it's now
8184 handled by sfm-write.c. Properly commented out debug code.
8186 * glob.c: (glob var weighting) Removed.
8188 * sel-if.c: Comment fixes.
8189 (cmd_filter) New function.
8191 * sfm-read.c: (struct sfm_fhuser_ext) New field `weight_index'.
8192 (sfm_read_dictionary) Sets weighting variable direct in the
8193 created dictionary now. (Apparently we previously didn't support
8195 (read_header) Sets weight_index field in sfm_fhuser_ext from
8196 header read from disk.
8198 * sfm-write.c: (sfm_write_dictionary) Comment fix.
8199 (write_header) Now sets the weighting in the header from the
8200 passed primary dictionary instead of from the sfm_write_info.
8202 * sfm.h: (struct sfm_write_info) Removed field `weight'.
8204 * som-high.c: (dump_crush_table) Fixed a couple of assertions that
8205 broke on boundary conditions.
8207 * var.h: (struct dictionary) New fields `weight_var',
8208 `weight_index', and `filter_var'.
8209 (glob var weighting) Removed. This is now part of struct
8210 dictionary. All references changed; the less mechanical changes
8211 are described above.
8213 * vars-atr.c: (find_dict_variable) New function.
8215 * vfm.c: (static var filter_index) New variable.
8216 (open_active_file) Initializes filter_index from default_dict.
8217 (write_case) Calls proc_func() only if the filter variable is
8218 nonzero; this implements FILTER behavior.
8220 * weight.c: (static var weight_varname) Removed.
8221 (cmd_weight) Modified default_dict instead of glob vars.
8222 (update_weighting) Changed the signature to modify a dictionary
8223 instead of glob vars. Now returns the weighting variable.
8224 (get_weighting_variable) Removed; its function is absorbed by
8226 (stop_weighting) Operates on a dictionary now.
8228 Wed Jan 1 17:00:59 1997 Ben Pfaff <blp@gnu.org>
8230 * sort.c: Removed debugging info from messages.
8231 (do_external_sort) Cleans up after itself by deleting the
8232 temporary directory on failure. (On success it is deleted by the
8234 (allocate_cases) Removed debug code. Added clean up code.
8235 (output_record) Removed debug code.
8236 (merge) Added code to close all the input files that are currently
8237 open. This is a likely location for bugs, because I'm not sure
8238 about boundary conditions. Removed an unnecesary heap_delete().
8239 (merge_once) Removed input file "optimization" that in fact
8240 screwed up the rest of the code. Message and comment fixes.
8242 Sun Dec 29 21:36:48 1996 Ben Pfaff <blp@gnu.org>
8244 * error.c: [__CHECKER__] (induce_segfault) Flushes output streams.
8246 * heap.c: (heap_delete) New argument.
8248 * sort.c: Finished implementation of external sort.
8250 * vfm.c: (read_from_disk) Returns after a disk error.
8252 Sun Dec 22 23:10:39 1996 Ben Pfaff <blp@gnu.org>
8254 * sort.c: (static var state) Removed.
8255 (static vars max_handles, tmp_basename, tmp_extname,
8256 huffman_queue) New variables.
8257 (do_external_sort) Moved most code to new functions.
8258 Creates huffman_queue.
8259 (allocate_file_handles, allocate_cases) New functions.
8260 (static vars run_no, run_length, file_index, case_count) New
8262 (output_record) Returns success. Now really writes to the output
8264 (begin_run, end_run) New functions.
8265 (write_initial_runs) Returns success. Initializes run_no to -1.
8266 Calls begin_run(), end_run() at appropriate times. Outputs debug
8268 (write_to_sort_cases) Calls begin_run(), end_run() at appropriate
8270 (merge) New function.
8272 * heap.c, heap.h: New files. Hopefully in near-final form.
8274 Sat Dec 21 21:51:04 1996 Ben Pfaff <blp@gnu.org>
8276 * glob.c: Added write_active_file to global vars.
8278 * sort.c: Several new miscellaneous static variables.
8279 (cmd_sort_cases) Big comment fix.
8280 (perform_case_2) Renamed `do_external_sort' and completely
8282 (case_2_proc_func) Removed.
8283 (output_record, write_initial_runs, write_to_sort_cases,
8284 compare_record) New functions.
8286 * vfm.c: [DEBUGGING] (index_to_varname) Excised bit rot.
8288 Tue Dec 17 18:57:59 1996 Ben Pfaff <blp@gnu.org>
8290 * sort.c: (perform_case_2) Changed the method for allocation of
8291 lots of memory--now allocates one case at a time in hopes that
8292 more cases can be allocated with heavily fragmented memory.
8294 * var.h: (write_active_file) New global var.
8296 * vfm.c: (procedure, close_active_file, write_case,
8297 SPLIT_FILE_procfunc) Now allow beginfunc, procfunc, and endfunc
8298 arguments to procedure() to be NULL. All references to
8299 procedure() that made use of dummy functions were changed to NULL
8301 (open_active_file) If write_active_file is non-NULL, the output
8302 device becomes DEV_PGM (a new enum).
8303 (close_active_file) Sets write_active_file to NULL.
8304 (read_from_memory) Comment fix.
8305 (record_case) Calls write_active_file() when the output device is
8308 Sun Dec 15 15:32:16 1996 Ben Pfaff <blp@gnu.org>
8312 * autorecode.c: (cmd_autorecode) Fixed parsing of options.
8313 Fixed checking for duplicate varnames.
8314 (recode) xmalloc()'s the transformation instead of arena_alloc()'ing
8316 (autorecode_trns_free) Destroys hash tables for each recoding
8318 (autorecode_proc_func) Compares NULL to *vpp instead of vpp.
8320 * command.c: Added SORT CASES to cmd_table.
8321 (null_func, null_int_func) Prototyped.
8323 * descript.g: (calc_weight, calc_noweight) Computes own case
8326 * frequencies.q: (dump_statistics) Fixed problem with
8327 too-few-cases warning message.
8329 * get.c: (cmd_save_internal) Handles weighting properly.
8331 * hash.c: (hsh_dump) Output format changed.
8332 (force_hsh_insert) Actually works now, prototype changed.
8334 * list.q: (static var case_num) New variable.
8335 (cmd_list) Initializes case_num.
8336 (list_cases) Increments case_num.
8338 * var.h: Added definitions for SORT CASES. Comment fixes.
8340 * vfm.c: Some definitions moved to new file vfmP.h. Comment
8341 fixes. `active' renamed vfm_active, `rep' renamed
8342 vfm_replacement, all references changed.
8343 (procedure) The procfunc no longer receives a case number. All
8345 (write_case) Subtle reordering.
8346 (SPLIT_FILE_procfunc) Counts cases differently. Slightly less
8349 * weight.c: (get_weighting_variable) New function.
8351 * vfmP.h: New file with definitions from vfm.c.
8353 Sat Dec 14 10:35:30 1996 Ben Pfaff <blp@gnu.org>
8355 * command.c: (FILE_TYPE_okay) Commented out some tests because
8356 they're clumsy and not yet needed.
8358 * var.h: Most *_trns structures moved to their respective source
8359 files. Some were moved into a new file, do-ifP.h. Comment fixes.
8360 (union any_trns) Changed to a typedef for trns_header.
8361 (struct input_program_pgm) Removed.
8363 * vars-prs.c: (parse_variables) Only local_free()'s bits if it
8364 was allocated in the first place.
8366 Fri Dec 13 21:30:53 1996 Ben Pfaff <blp@gnu.org>
8368 * autorecode.c: New file.
8370 * command.c: Added AUTORECODE to command table; re-enabled SET.
8372 * data-out.c: (convert_F) Handles infinities and NaNs properly.
8374 * error.c: (vmsg) Comment fixes.
8376 * hash.c: Comment fix.
8377 (hashpjw_d) New function.
8378 (hashpjw) Reimplemented as call to more general function
8380 (internal_comparison_fn) Initializes pointers properly.
8381 (hsh_sort) [GLOBAL_DEBUGGING] New debugging code.
8382 (force_hsh_insert, force_hsh_find) New debugging wrapper
8385 * main.c: (main) Message fix.
8387 * output.c: (outp_read_devices) Message fix.
8389 * set.q: Comment fixes.
8390 (custom_results) Implemented Wnd/X form of subcommand.
8391 (set_routing) New function.
8392 (internal_cmd_set) Implemented ERRORS, MESSAGES.
8394 * settings.h: (SET_ROUTE_*) New enum series.
8395 (set_results) Renamed set_results_file, all references changed.
8396 (set_messages) Removed.
8397 (glob vars set_errors, set_messages, set_results) New vars.
8399 * title.c: (get_title) Remembers to xstrdup() the result of
8402 * var.h: (arc_item, arc_spec, autorecode_trns) New structures for
8404 (union any_trns) New element `arc'.
8406 Fri Dec 6 23:53:47 1996 Ben Pfaff <blp@gnu.org>
8408 * command.c: (output_line) Removed references to set_screen.
8410 * error.c: (static var terminating) New var.
8411 (hcf) Sets terminating to 1.
8412 (vmsg) If terminating is nonzero, does not attempt to call hcf().
8413 This prevents an infinite loop if an error occurs within hcf().
8415 * expr-evl.c: (evaluate_expression) [__CHECKER__] Replaced case
8416 statement circumlocution with `case 42000' trick.
8417 (evaluate_expression) New support for OP_STR_MIS.
8419 * expr-opt.c: (evaluate_expression) [__CHECKER__] Replaced case
8420 statement circumlocution with `case 42000' trick.
8421 (dump_node) Handles OP_STR_MIS.
8423 * expr-prs.c: (MISSING_func, SYSMIS_func) Rewrote to handle string
8424 variables exceptions.
8425 (parse_function) Message fix.
8426 (ops[]) Added OP_STR_MIS.
8428 * expr.h: Added OP_STR_MIS to OP_* enum. Comment fixes.
8430 * exprP.h: [__CHECKER__] Removed case statement circumlocution.
8432 * glob.c: Removed set_scrnfile glob var.
8433 (init_glob) set_errorbreak set to 0 by default.
8435 * groff-font.c: Changed included files.
8436 (groff_read_font) Initializes font_arena local var correctly.
8437 (default_font) New function.
8439 * output.c: Comment fixes.
8440 (glob var disabled_devices) New variable.
8441 [GLOBAL_DEBUGGING] (static var iterating_driver_list) New
8443 [GLOBAL_DEBUGGING] (reentrancy) New function.
8444 [GLOBAL_DEBUGGING] (outp_read_devices, outp_done, find_driver,
8445 outp_iterate_enabled_drivers) Calls to reentrancy().
8446 (destroy_list) New function.
8447 (outp_done) Moved code to destroy_list().
8448 (parse_options) Parses `listing', `screen', `printer' options
8450 (configure_driver) Sets new `device' member of driver.
8451 (outp_iterate_enabled_drivers, outp_enable_device) New functions.
8453 * output.h: Comment fixes. New enum series OUTP_DEV_*.
8454 (struct outp_driver_struct) New member `device'.
8456 * postscript.c: (find_encoding_file) Doesn't display its own error
8458 (default_encoding) New function.
8459 (switch_font) Calls default_encoding() if no encoding can be
8461 (text) Makes up a character metric if none exists for the desired
8463 (load_font) Properly copies a fallback filename. Calls
8464 default_font() for a font if none at all are known.
8466 * set.q: Comment fixes. Removed OUTPUT subcommand.
8467 (custom_listing) Calls outp_enable_device() to enable/disable
8469 (turn_screen_on) Removed.
8470 (internal_cmd_set) Calls outp_enable_device() to enable/disable
8471 screen, printer devices.
8473 * settings.h: Comment fixes.
8474 (glob vars set_output, set_printer, set_screen, set_scrnfile)
8477 * som-high.c: (som_submit_table, som_eject_page) Use
8478 outp_iterate_enabled_drivers() instead of iterating
8479 outp_driver_list directly.
8481 Wed Dec 4 21:34:17 1996 Ben Pfaff <blp@gnu.org>
8483 * data-in.c: (parse_EDATE, parse_SDATE) New functions.
8484 (parse_string_as_format) Handles new formats.
8485 (parse_numeric) Now handles DOT and PCT formats.
8487 * data-out.c: (convert_E, convert_F, insert_commas) Handle DOT
8489 (convert_date) Handle EDATE and SDATE formats.
8490 (convert_CCx) Now if there's not room for the currency characters,
8491 converts it as F format if it's positive instead of giving up
8492 quickly. Also fixed save-and-restore bug with decimal point
8494 (convert_format_to_string) Handles new formats.
8496 * misc.c: (formats[]) Added new formats.
8497 (convert_fmt_ItoO) Supports new formats.
8499 * sfm-read.c: (parse_format_spec) Supports new formats. Better
8500 data checking. New argument, all references changed.
8502 * sfm-write.c: (write_format_spec) Supports new formats.
8504 * var.h: New formats FMT_DOT, FMT_PCT, FMT_EDATE, FMT_SDATE.
8507 Sun Dec 1 17:19:00 1996 Ben Pfaff <blp@gnu.org>
8509 * cmdline.c: Comment fixes.
8510 (parse_command_line) Changed return type to void.
8512 * data-in.c: (parse_string_as_format) Added FMT_CCA...FMT_CCE to
8514 (parse_numeric) Handles international numbers (comma as decimal
8515 point). Some reformatting.
8517 * data-list.c: (parse_free) Default output format is now
8518 set_format instead of hard-coded F8.2.
8519 (read_from_data_list_list) Emits error message on undefined data
8520 only if set_undefined is nonzero.
8522 * data-out.c: (convert_E) Changes decimal point from period to
8523 comma if appropriate. Restructured. Better comments.
8524 (convert_F) Changes decimal point from period to comma if
8526 (insert_commas) Major bug with handling of negative values fixed.
8527 Also, inserts periods instead of commas if appropriate.
8528 (convert_CCx) New function.
8529 (convert_format_to_string) Added FMT_CCA...FMT_CCE to switch.
8530 (num_to_string) Changed `.' to set_decimal.
8532 * dfm.c: Comment fixes.
8533 (dfm_close) Frees ext->line even in inline_file.
8534 (open_inline_file) New function.
8535 (open_file_r) When opening the inline file: now properly
8536 recognizes `BEGIN DATA.' line, and calls open_inline_file() to
8538 (read_record) Calls fh_close_handle() instead of dfm_close() to
8539 close the inline file. Makes a copy of the line getl_buf to avoid
8541 (dfm_get_record) Restructured. Now checks the return value of
8543 (cmd_begin_data) Moved open code into open_inline_file(). Relaxed
8544 checking for use of inline file. No longer tries to close inline
8547 * error.c: (glob var error_already_flagged) New var.
8548 (vmsg) Message change. Now checks max number of errors/warnings,
8551 * file-handle.q: (fh_handle_name) Now allows closing of
8553 (fh_init_files) Reformatted.
8555 * get.c: (trim_dictionary) Checks SCOMP option instead of COMP.
8557 * getline.c: (getl_include) Fixed bug that popped up when called
8558 when file queue was empty.
8559 (read_console) Resets error_count, warning_count,
8560 error_already_flagged to zero.
8562 * glob.c: Many changes to update list of variables.
8563 (init_compat_dependent) Now this function is called whenever
8564 `compat' changes. It now sets set_seed only if it hasn't
8565 previously been referenced. It now calls
8566 lex_init_compat_dependent().
8568 * include.c: (cmd_include_at) Frees temporary buffer instead of
8570 (cmd_include) Doesn't make copy of include file name.
8572 * lexer.c: Comment fixes.
8573 (init_lex) Moved some code into new function
8574 lex_init_compat_dependent().
8575 (lex_init_compat_dependent) New function.
8576 (hex_val) Simplified.
8577 (preprocess_line) Uses set_endcmd instead of hardcoding `.'.
8579 * main.c: Comment fixes.
8582 * misc.c: (formats[]) Added FMT_CCA...FMT_CCE.
8583 (check_input_specifier) Disallows FMT_CCA...FMT_CCE.
8584 (convert_fmt_ItoO) Detects FMT_CCA...FMT_CCE.
8585 (setup_randomize) Sets set_seed_used.
8587 * set.q: Comment fixes.
8588 (custom_results) Conditionalizes on `compat'.
8589 (custom_log) Calls custom_journal().
8590 (set_ccx) New function.
8591 (cmd_set) Calls init_compat_dependent() when `compat' changes.
8592 Calls set_ccx() to handle CCA...CCE. Sets set_grouping
8593 when set_decimal changes. Range-checks values for MITERATE,
8594 MNEST. Message fixes.
8596 * settings.h: Comment fixes.
8597 (struct set_cust_currency) New struct.
8598 (set_cc[], set_grouping, set_seed_used) New global vars.
8600 * var.h: (FMT_CCA...FMT_CCE) New output formats.
8601 (FCAT_OUTPUT_ONLY) New FCAT_* constant.
8603 Thu Nov 28 23:14:07 1996 Ben Pfaff <blp@gnu.org>
8605 * glob.c: Revised variables to correspond to settings.h.
8606 (init_glob) Initializes variables from settings.h properly.
8608 * set.q: Began long-overdue major revision to correspond to new
8609 philosophy. Most code changed.
8611 * settings.h: Mostly changed; reorganized, reordered, large new
8614 Thu Nov 28 19:46:10 1996 Ben Pfaff <blp@gnu.org>
8616 * get.c: (cmd_save_internal) No longer forces compression off.
8618 * sfm-read.c: (read_compressed_data) If eof is reached when
8619 reading a new instruction octet, only signal error if we're in the
8622 * sfm-write.c: (COMPRESSION_BIAS) New #define.
8623 (struct sfm_fhuser_ext) New member `end'.
8624 (write_header) Refers to COMPRESSION_BIAS instead of magic 100.0.
8625 (ensure_buf_space) New function.
8626 (sfm_write_case) Reimplemented in order to support compression.
8627 (sfm_close) Writes out the remaining contents of the compression
8630 Wed Nov 27 23:18:35 1996 Ben Pfaff <blp@gnu.org>
8632 * command.c: Defined SAVE and XSAVE commands in command table.
8634 * common.h: second_lowest_value is of type flt64, not double.
8636 * file-handle.h: Comment fix.
8638 * get.c: Comment fixes.
8639 (static var `trns') New.
8640 (save_write_case_func, save_trns_proc, save_trns_free, null_func,
8641 cmd_save_internal, cmd_save, cmd_xsave) New functions.
8642 (dict_delete_run) Clears the variables and frees them now.
8643 (trim_dictionary) Sets default for compression.
8644 On KEEP subcommand, frees deleted variables as well as clearing
8645 them. Finally got the sense of the test for deleting all
8647 [DEBUGGING] (dump_dict_variables) Message fix.
8649 * glob.c: (init_glob) set_compression set to 1 by default.
8651 * list.q: Properly #includes config.h.
8653 * misc.h: New macro REM_RND_UP.
8655 * settings.h: Comment fix.
8657 * sfm-read.c: (structs sysfile_header, sysfile_format,
8658 sysfile_variable; inline function bswap_int32) Moved to new file
8660 (corrupt_msg) [__CHECKER__] No longer induces segfault.
8661 (sfm_read_dictionary) Fixed bug caused by failing to initialize
8663 (read_machine_flt64_info) Fixed some problems caused by confusion
8664 between flt64 and double types.
8665 (read_header) Message fix.
8666 (read_variables) Fixed set of cases in which we byte-swap sv.print
8667 and sv.write. Fixed confusion of flt64 and double.
8669 * sfm.h: (struct sfm_write_info) New.
8671 * som-high.c: (som_draw_title) Properly frees `s'.
8673 * temporary.c: (save_dictionary) Comment fix.
8675 * var.h: Comment fixes. New FMT_* enum, FMT_NUMBER_OF_FORMATS.
8676 (struct trns_header) Formatting fix.
8677 (struct save_trns) New.
8679 * vars-atr.c: (discard_variables) Comment fix.
8681 * sfm-write.c: New file, baseline release.
8683 * sfmP.h: New file, baseline release.
8685 Sun Nov 24 14:53:53 1996 Ben Pfaff <blp@gnu.org>
8687 * cmdline.c: (parse_command_line) `--version' output updated.
8688 (glob var syntax_message[]) Added my e-mail address.
8690 * file-handle.q, lexer.c, vfm.c: Changed many instances of
8691 `illegal' to `invalid'.
8693 * sfm-read.c: (struct sfm_fhuser_ext) New fields used as
8694 uncompression buffer.
8695 (sfm_close) Frees decompression buffer.
8696 (sfm_read_dictionary) Initializes decompression buffer.
8697 (buffer_input, read_compressed_data) New functions.
8698 (sfm_read_case) Restructured; now calls read_compressed_data() to
8699 handle compressed system file data.
8701 * var.h: Comment fix.
8703 Mon Nov 11 15:34:09 1996 Ben Pfaff <blp@gnu.org>
8705 * dfm.c: (dfm_close) Does not set h->{ext,class} because the
8708 * get.c: New comments. New static var `get_file'.
8709 (cmd_get) Now fully implemented. Calls discard_variables();
8710 initializes fv and lv for all variables; new debug code; sets
8711 up the dictionary; sets up the input program.
8712 (read_from_get, cancel_get) New functions.
8714 * sfm-read.c: Comment fixes.
8715 (sfm_close) New static function.
8716 (sfm_read_dictionary) Properly sets up the class of the
8717 file_handle. No longer cares what size the data is in records of
8718 type 7. Also, on failure, properly cleans up the file_handle and
8720 (read_variables) No longer thinks it knows `nval' of the
8721 dictionary. Now sets p.get.fv, etc., instead of speculatively
8723 (read_value_labels) Fixed off-by-one error in indexing of
8725 (sfm_read_case) New function.
8726 (sfm_r_class) New static var.
8728 * var.h: (get_proc) New struct.
8729 (struct variable) New member p.get.
8731 Thu Nov 7 20:52:28 1996 Ben Pfaff <blp@gnu.org>
8733 * get.c: Removed GTSV_OPT_MAP because of a misinterpretation of
8734 the manual's meaning.
8735 (rename_variables) New function.
8736 (trim_variables) Doesn't try to parse MAP any more. Removed debug
8737 code. Now properly reorders the dictionary on the KEEP keyword.
8739 * sfm-read.c: (read_value_labels) Fixed some bugs regarding
8742 * vars-atr.c: (clear_variable) New argument `dictionary *'.
8743 (rename_variable) New function.
8744 (free_val_lab) Reformatted.
8746 Thu Nov 7 17:29:16 1996 Ben Pfaff <blp@gnu.org>
8748 * var.h: Reindented entire file. Comment fixes.
8749 (glob vars var, var_by_name, nvar, N, nval, n_splits, splits)
8751 (glob var default_dict) New.
8752 (struct indirect_dictionary) Removed.
8754 * Many other source files were changed to add `default_dict.'
8755 before all references to the dictionary of the active file.
8757 * vars-atr.c: (make_indirect_dictionary) Removed.
8759 * glob.c: Reindented all variable declarations. Updated for
8760 changed var.h. Comment fixes.
8762 * temporary.c: (restore_dictionary, save_dictionary) Simplified
8763 because now we can mainly copy dictionary structs.
8765 * vars-prs.c: (is_dict_varname, parse_dict_variable,
8766 parse_variables) Takes dictionary instead of indirect_dictionary
8768 (parse_variables) Instead of calling make_indirect_dictionary,
8769 just sets DICT to &default_dict if DICT is NULL. Of course, lots
8770 of `*dict.' references had to be changed to `dict->'. Removed
8773 Thu Nov 7 15:48:52 1996 Ben Pfaff <blp@gnu.org>
8775 * get.c: Added GTSV_OPT_* series of enums.
8776 (trim_dictionary, dict_delete_run) New functions.
8777 [DEBUGGING] (dump_dict_variables) New function.
8778 (cmd_get) Calls trim_dictionary() to get dictionary fully set-up.
8779 [DEBUGGING] Calls dump_dict_variables() to display results.
8781 * glob.c: (cmp_variable) Now a public function declared in var.h.
8783 * sfm-read.c: Turned off debug code. Comment fixes.
8784 (read_machine_int32_info, read_machine_flt64_info) New functions
8785 to parse type 7 records.
8786 (sfm_read_dictionary) Properly byteswaps several fields now.
8787 Calls read_machine_*_info() to parse type 7 subtypes 3 and 4
8788 records. [DEBUGGING] Dumps dictionary.
8789 (read_variables) Sets `index' field of variables created properly.
8790 Constructs avl tree of variables in dictionary. [DEBUGGING] No
8791 longer dumps dictionary.
8792 (read_value_labels) Properly byteswaps fields. [DEBUGGING] New
8794 [DEBUGGING] (dump_dictionary) No longer stubbed out.
8796 * temporary.c: (restore_dictionary) Destroys `var_by_name' glob
8797 var before destroying any variables just to save a little time.
8799 * var.h: (struct variable) Reordered in order to make name[] the
8800 first member; this makes pointers to `variable' pointers to the
8801 variable name, simplifying avl trees, etc.
8802 (struct indirect_dictionary) New struct.
8804 * vars-atr.c: (find_variable) Rewritten for efficiency.
8805 (make_indirect_dictionary, is_dict_varname, parse_dict_variable)
8807 (is_varname) Rewritten for efficiency.
8808 (parse_variables) New argument, which is a `dictionary *'. All
8809 references changed. This function now reads variable names from
8810 the dictionary passed, or from the default dictionary if NULL.
8812 Tue Nov 5 18:34:59 1996 Ben Pfaff <blp@gnu.org>
8814 * misc.h: Added new macro DIV_RND_UP to perform integer division,
8815 rounding up. Changed many references to ROUND_UP to use this
8818 * sfm-read.c: Includes avl.h.
8819 (corrupt_msg) Induces a segfault under Checker.
8820 (macro assertive_bufread) New. Many references to bufread() now
8822 (sfm_read_dictionary) Split up into several functions. Added code
8823 to read dictionary records following the the type 2 records. Not
8824 quite complete. New variable `var_by_index'.
8825 (read_header, read_variables) New functions extracted from
8826 sfm_read_dictionary().
8827 (read_value_labels) New function.
8828 (bufread) Checks ferror() if fread() doesn't return the expected
8829 value; if ferror() is zero it's just EOF.
8830 (dump_dictionary) Stubbed out.
8832 * BTW: The source code now exceeds 50000 lines!
8834 Mon Nov 4 22:03:28 1996 Ben Pfaff <blp@gnu.org>
8836 * command.c: Added GET to cmd_table[].
8838 * list.q: Removed reference to alloca headers.
8839 (cmd_list) Gave prototype.
8841 * sfm-read.c: Added DEBUGGING comments.
8842 (sfm_read_dictionary) Checks bias correctly. Sets
8843 dict->var_by_name to NULL. Calculates long_string_count
8844 correctly. realloc's dict->var[] array to minimum size.
8845 [DEBUGGING] Calls dump_dictionary.
8846 [DEBUGGING] (dump_dictionary) New function.
8848 * temporary.c: (save_dictionary) Sets var_by_name to NULL.
8849 (restore_dictionary) If the dictionary contains a non-NULL
8850 var_by_name, uses that instead of generating one.
8851 (free_dictionary) Destroys var_by_name.
8853 * var.h: (struct dictionary) Added field `var_by_name'.
8855 * get.c: New file, not complete.
8857 Sun Nov 3 12:24:36 1996 Ben Pfaff <blp@gnu.org>
8859 * mis-val.c: New enums MV_NOR_*. New struct num_or_range.
8860 (parse_num_or_range) New function.
8861 (parse_numeric) Reimplemented in order to support LOW THRU <n> and
8862 <n> THRU HIGH missing values.
8864 * output.h: [__GNUC__>1 && __OPTIMIZE__] (width, height) Made
8865 __attribute__((const)).
8867 * q2c.c: (get_token) Merged isdigit || isalpha into isalnum.
8869 * sfm-read.c: Finished reference implementation.
8871 * sfm.h: Includes var.h.
8873 * var.h: Comment fixes.
8874 (struct `variable') Reordered some fields.
8876 * vars-atr.c: (is_num_user_missing) Added support for MISSING_*
8877 constants added previously.
8879 Wed Oct 30 17:13:08 1996 Ben Pfaff <blp@gnu.org>
8881 * common.h: Comment fixes. Added declaration of
8882 `second_lowest_value' as variable or macro. Made `compat_type',
8883 `pgm_state_type' into anonymous enums.
8885 * display.c: Comment fix.
8887 * glob.c: [ENDIAN==UNKNOWN] Added definition for `endian' global
8889 [!defined SECOND_LOWEST_VALUE] Added definition for
8890 `second_lowest_value' global var.
8891 (compat, pgm_state global vars) Changed types to `int'.
8892 (init_glob) Initializes `second_lowest_value'.
8894 * sfm-read.c: Continued work, not complete.
8896 * var.h: Added new MISSING_* constants to handle LOWEST and
8899 Sat Oct 26 23:06:06 1996 Ben Pfaff <blp@gnu.org>
8901 * sfm-read.c: New file, not complete.
8903 * cases.c: (vec_insert) Changed vector expansion algorithm.
8904 (vec_delete) Fixed bug that screwed up deletion sometimes, it was
8905 mucking up the RECODE transformation in particular.
8906 (envector) Harmless change in notation.
8908 dfm is now fairly well tested again.
8909 * dfm.c: (dfm_get_record) Only returns ext->ptr if ext is
8911 (cmd_begin_data) if(ext->line) replaced by if(ext && ext->line).
8913 * recode.c: Comment fix.
8915 * sfm.h: Interface should be fairly final now, or at least for a
8918 * vfm.c: [DEBUGGING] (index_to_varname) New function.
8919 (open_active_file) [DEBUGGING] Translates ccase indices into
8920 variable names now to make it easier to understand what's really
8923 Sat Oct 26 20:46:31 1996 Ben Pfaff <blp@gnu.org>
8925 * data-in.c: Comment fix.
8927 * data-list.c: Includes dfm.h.
8928 (do_reading) Uses new function dfm_push_cust().
8930 * data-out.c: (convert_time, convert_WKDAY, convert_MONTH) Added
8933 * file-handle.h: Completely changed. Some parts split off into
8934 new file dfm.h. Implemented in file-handle.q.
8935 (enum FH_*) Removed.
8936 (struct fh_ext_class) New struct.
8937 (struct file_handle) Retained only these fields: name, norm_fn,
8938 fn, recform, lrecl, mode. New fields class, ext.
8939 (get_handle_by_name, get_handle_by_filename, parse_file_handle,
8940 close_handle, handle_name) Added `fh_' prefix to name, all
8943 * dfm.h: New file, implemented in dfm.c.
8944 (get_record, put_record, fwd_record, bkwd_record, set_record,
8945 get_cur_col) Functions moved from file-handle.h, now prefixed with
8947 (dfm_push_cust) New function.
8949 * sfm.h: New file. Incomplete.
8951 * dfm.c: All functions adjusted/rewritten for new dfm/fhp
8952 interface. Functions reordered, comments changed. Not well
8953 tested, probably full of bugs.
8954 (struct dfm_fhuser_ext) New struct.
8955 (dfm_close) New function.
8956 (open_file_r) Pickier about finding `BEGIN DATA.' line.
8957 (open_file_w) User messages changed.
8958 (get_record) Comment fixed.
8959 (read_record) Increments ext->ln even for inline_file. Calls
8960 dfm_close() for inline_file when `END DATA.' encountered.
8961 (dfm_get_record) Experimental restructuring.
8962 (dfm_push_cust) New function.
8963 (cmd_begin_data) Detects whether the inline file was fully read by
8964 checking whether it is still open; detects whether it was read at
8965 all by checking whether the line number is greater than zero.
8967 * file-handle.q: All functions adjust/rewritten for new dfm/fhp
8968 interface. Functions reordered, comments changed. Not well
8969 tested, probably full of bugs.
8970 (init_file_handle) Removed initializers for obsolete fields, added
8972 (fh_close_handle) Much simpler, now mainly calls the class
8974 (fh_init_files) Renamed inline file internal filename.
8976 * file-type.c: Includes dfm.h.
8977 (read_from_file_type) Doesn't use dfm internal state anymore.
8979 * inpt-pgm.c, print.c: Include dfm.h.
8981 * recode.c: (internal_cmd_recode) Casts strlen() return value to
8982 int in comparison with other int.
8984 * som-high.c: (build_target) Fixed operator precedence problem in
8985 if statement (& versus ==).
8987 Sat Oct 26 10:39:25 1996 Ben Pfaff <blp@gnu.org>
8989 * dfm.c: (read_record) Can now read fixed-length records; not
8991 (put_record) Can now write fixed-length records; not tested.
8993 * file-handle.h: FH_* defines changed to enums. New enum series
8995 (struct file_handle) New members recform, lrecl, mode.
8997 * file-handle.q: Parser changed.
8998 (internal_cmd_file_handle) Added support for new /RECFORM, /MODE,
8999 /LRECL subcommands. These are compatible with Windows.
9000 (init_file_handle) Initializes recform, mode fields.
9002 * q2c.c: (get_line) When outputting `!' comment lines, now
9003 increments the output file line number so that `#line' directives
9005 (make_identifier) New function that converts an arbitrary string
9006 into a valid C identifier.
9007 (dump_vars) Calls make_identifier() in two places in order to
9008 suppress some errors for bad identifiers.
9009 (make_match) Allows TRUE as synonym for YES and FALSE as synonym
9010 for NO. Allows numbers to be prefixed by underscores to make them
9011 acceptable C identifiers but still to be parsed as numbers by the
9014 Thu Oct 24 20:13:42 1996 Ben Pfaff <blp@gnu.org>
9016 * command.c: Re-enabled RECODE, SAMPLE, SELECT IF.
9018 * dfm.c: Comment fixes. (get_record) Gives error if file handle
9019 was opened for writing.
9020 (open_file_w) New function.
9021 (read_record) Uses strncasecmp if available. Improved error
9023 (put_record) New function.
9025 * file-handle.h: Moved function comments into dfm.c and
9026 file-handle.q. Comment fixes. Removed declarations of
9027 tilde_expand() and normalize_filename().
9028 (struct file_handle) Changed `open' from boolean to enumerated
9029 field to allow for three states--closed, open for reading, open
9030 for writing--all references changed.
9032 * file-handle.q: Includes filename.h.
9034 * print.c: (CMD_* enums) Renamed PRT_* and moved into var.h; all
9036 (alloc_line) Makes allowance for line terminator characters in
9038 (print_trns_proc) Now handles OUTFILE, WRITE differences.
9039 (print_space_trns_proc) Handles OUTFILE differences.
9041 * recode.c, sample.c: Comment fixes.
9043 * var.h: (struct print_trns) Changed boolean field `eject' to
9044 bitmapped field `options'; all references changed. New enums
9045 PRT_* for use with this field.
9047 * exception.h, test-exception.c: Removed.
9049 Thu Oct 24 17:47:14 1996 Ben Pfaff <blp@gnu.org>
9051 * ascii.c: (delineate) Turned off debug output.
9053 * common.c: [Checker and Linux] (__assert_fail, __eprintf) Moved
9056 * data-in.c: (parse_string_as_format) Sets the entire string value
9057 to spaces, not just the short string part of it. Is this correct
9060 * data-out.c: (convert_date) Fixed DATETIME format problems with
9061 decimal places, removed debug code.
9063 * dfm.c: (open_file_r) Fixed bug where an error would occur in the
9064 middle of parsing BEGIN DATA that would cause the lexer to read
9065 from a wild pointer `prog'; now calls new function
9066 preprocess_line() in lexer.c.
9068 * error.c: [__CHECKER__] (hcf) Calls induce_segfault() on improper
9070 [Checker and Linux] (__assert_fail, _eprintf) Moved from common.c.
9071 Now call induce_segfault() to induce the segfault.
9072 (induce_segfault) New function.
9074 * expr-opt.c: Comment fix.
9075 (parse_sysvar) New function.
9076 (parse_primary) Added system variable support--calls
9078 (global var ops) Added OP_CASENUM operator.
9080 * expr.h: Comment fixes.
9081 (OP_* enum) added OP_CASENUM operator.
9082 (struct casenum_node) New struct.
9083 (union any_union_union) New member `cas' of type `casenum_node'.
9085 * glob.c: (global var last_vfm_invocation) New var.
9086 (init_glob) Initializes last_vfm_invocation.
9088 * lexer.c: (lookahead) Fixed reversed condition on if statement.
9090 * getline.c: (get_line) Split into get_line() and preprocess_line().
9091 (preprocess_line) New function.
9093 * var.h: Declares last_vfm_invocation.
9095 * vfm.c: (procedure) Sets last_vfm_invocation.
9097 Wed Oct 23 21:53:43 1996 Ben Pfaff <blp@gnu.org>
9099 * command.c: (parse_cmd) Fixed bad assertion related to
9102 * data-in.c: (parse_month) Implemented to parse months according
9103 to full interpretation of standard.
9104 (to_roman) New function.
9105 (parse_wk_delimiter) Bug fix (forgot to skip `WK' in string).
9106 (parse_weekday) Bug fix (forgot to skip all the day name).
9108 * data-list.c: (read_from_data_list_fixed) Fixed bug that screwed
9109 up parsing of multirecord data items. Also fixed user message.
9111 * data-out.c: Comment fix.
9112 (year2, year4, convert_date, convert_time, convert_WKDAY,
9113 convert_MONTH) New functions to support time & date output.
9114 (convert_format_to_string) Calls new time & date output routines.
9116 * expr-prs.c: (nary_num_func) Found a bug, but didn't fix it yet.
9118 * lexer.c: (lookahead) Noted a previously unnoticed caveat in
9121 * main.c: [DEBUGGING] (dump_token) Updated to handle getline.h.
9123 * misc.c: (global var formats) Fixed declarations of DATETIME,
9126 * postscript.c: (text) Fixed a pair of bugs in the reallocation of
9127 the output_char buffer.
9129 * vars-prs.c: (parse_DATA_LIST_vars) Fixed a failure to free
9130 memory bug. Fixed user messages.
9132 Tue Oct 22 17:27:04 1996 Ben Pfaff <blp@gnu.org>
9134 * Removed #pragma argsused from lots of places.
9136 * data-in.c: Implemented zoned decimal and time-date formats.
9137 Untested. This is a huge chunk of code--maybe 1000 lines and 50
9140 * data-out.c: Implemented zoned decimal format.
9142 * expr.h: Moved yrmoda() declaration here from exprP.h.
9144 * misc.c: (global var formats) Minor fixes--added
9145 FCAT_SHIFT_DECIMAL to formats N and Z.
9146 (convert_fmt_ItoO) Added support for format Z.
9148 * som-frnt.c: (som_set_value) Fixed bug regarding string values.
9150 Mon Oct 21 20:39:59 1996 Ben Pfaff <blp@gnu.org>
9152 * command.c: (parse_cmd) [GLOBAL_DEBUGGING] Inserted call to
9153 som_check_workspace() that is activated between commands.
9155 * data-list.c: (dump_fixed_table, dump_free_table) Finished these
9158 * list.q: (begin_row) Changed title expansion style from
9159 SOPT_X_VERT to SOPT_X_SHSP.
9161 * som-frnt.c: Now includes `somP.h'.
9162 (som_push_workspace, som_pop_workspace) New functions that, taken
9163 together, form a solution to the recursive table building problem
9164 mentioned yesterday. Surrounded every table output routine
9165 throughout the program with calls to these functions.
9166 [GLOBAL_DEBUGGING] (som_check_workspace) New function.
9167 (som_create_table) Checks that there's an active workspace.
9168 (som_destroy_all_tables, som_crush) Removed.
9170 * som-high.c: (global var som_preserve_tables) Removed, all
9172 (som_submit_table) Checks that there's an active workspace.
9173 (dump_columnated_table) Doesn't columnate tables that would have
9174 just one row per column.
9175 (dump_crush_page, som_dump_crush_page) Removed debugging code.
9176 (som_dump_crush_page) Moved row number labels from left side of
9177 tables to right side.
9178 (som_get_table_size) Added support for SOPT_X_SHSP.
9180 * som.h: New cell expansion type SOPT_X_SHSP.
9182 * somP.h: (global vars arena_stack, n_arena_stack, m_arena_stack)
9184 (global var curtab_arena) Moved from som-frnt.c.
9186 Sun Oct 20 13:45:28 1996 Ben Pfaff <blp@gnu.org>
9188 * ascii.c: [GLOBAL_DEBUGGING] (SUPPRESS_WARNINGS) New debug option
9189 that causes bad location warnings to be suppressed.
9190 (delineate) Saves current font when calling draw_text(); fixed
9191 handling of NULLs when backing up. Also fixed line-wrapping bug.
9193 * command.c: Re-enabled `LEAVE', `NUMERIC', `PRINT', `PRINT EJECT',
9194 `PRINT FORMATS', `PRINT SPACE', `STRING', `TITLE', `WRITE'.
9196 * common.c: Added code to cause assertion failure to dump core
9197 when run under Checker.
9199 * data-list.c: (dump_fixed_table) Fixed some inconsistencies, but
9200 there are still bugs.
9202 * glob.c: (__eprintf) Removed.
9204 * list.q: Inserted som_preserve_tables kluge that prevents tables
9205 from being thrown away due to recursive table building through
9206 som_output_line being called from a transformation during the LIST
9207 procedure invocation. This is a general problem that must be
9208 solved in a better way since it applies to all procedures in
9210 (begin_row) Changed title options to SOM_X_VERT from SOM_X_BOTH.
9211 (flush_table) Removed SOM_TOPT_PRESERVE from submission options.
9213 * numeric.c: Fixed several errors in the form of msg() calls.
9215 * print.c: Updated for use of som.
9216 (dump_table) Reimplemented.
9217 (print_trns_proc) Calls som_eject_page() instead of eject_page().
9218 Calls som_output_text() instead of outs_line().
9220 * som-frnt.c: (som_destroy_all_tables) Sets som_preserve_tables to
9222 (som_output_text) Function moved from som-low.c. Interface
9225 * som-high.c: (som_preserve_tables) New global public variable
9227 (som_submit_table) Destroys the tables only if som_preserve_tables
9229 (paginate_horizontally) Bugfix: sets som.mpw even if there's only
9230 one subrow per row. Now labels subrows if there's more than one
9232 (dump_crush_table) Added wishlist comment.
9233 (som_eject_page) New public function declared in som.h.
9235 * som-low.c: (som_dump_crush_page) Draws row labels if there's
9236 more than one subrow per row.
9237 (som_output_text) Moved to som-frnt.c.
9239 * som.h: (SOM_TOPT_PRESERVE) Removed.
9241 * title.c: (get_title) Changed interface.
9242 (cmd_title) Changed `title' to `outp_title'.
9243 (cmd_subtitle) Changed `subtitle' to `outp_subtitle'.
9245 Sun Oct 20 09:04:15 1996 Ben Pfaff <blp@gnu.org>
9247 * list.q: (flush_table) Conforms to new partial options in
9248 som_submission_form.
9250 * som-high.c: (paginate_horizontally) Changed form of subrow
9252 (build_target) Omits spacing before table if
9253 SOM_TOPT_PARTIAL_OMIT_TOP is selected.
9254 (dump_crush_page) Changed interface. Only trims bottom rule if
9255 SOM_TOPT_PARTIAL_OMIT_BTM is not selected.
9256 (dump_crush_table) Handles partial tables.
9257 (output_row_label) New function.
9258 (som_dump_crush_page) Emits subrow number labels. Draws vertical
9259 rule on the right edge of narrow subrows.
9261 * som.h: Changed SOM_SUB_PARTIAL_* series of submission type
9262 constants to a series of SOM_TOPT_PARTIAL_* submission options.
9263 All references updated.
9265 Fri Oct 18 19:46:49 1996 Ben Pfaff <blp@gnu.org>
9267 * misc.c: Comment fix.
9269 * som-high.c: (examine_table) Treats crushed tables separates for
9270 purpose of determining header size.
9271 (paginate_horizontally) Allots space for line numbers in crushed
9272 tables with lots of subrows per row. Calculates the `maximum page
9273 width', the width of the widest horizontal page.
9274 (build_target) Removed trim argument; all references changed.
9275 Stricter assertions. (dump_crush_page) New function.
9276 (dump_crush_table) Reimplemented.
9278 * som-low.c: (som_dump_page) Uses new RULE_ROW &c. constants.
9279 (som_dump_crush_page) Reimplemented, interface changed.
9281 * somP.h: Many many new helper macros for use with crushed tables.
9282 (global var som) Removed `tv', `cum_y' members; all references
9283 removed. New members `mpw', `digit_space'.
9285 Sun Sep 29 19:37:03 1996 Ben Pfaff <blp@gnu.org>
9287 * arena.c: (arena_alloc) [!DISCRETE_BLOCKS] Removed `size'
9288 variable, changed to constant 1024.
9289 (arena_ca_strdup) Changed `sizeof(a_string)' to
9291 (arena_ca_strdup) [!DISCRETE_BLOCKS] Changed bad cast from
9292 `(c_string *)' to `(char *)'; this fixed some offset problems.
9294 * filename.c: (readlink_malloc) Changed initial allocation from
9296 (good_getcwd) Changed from xmalloc() to local_alloc(); removed
9299 * postscript.c: (read_fontmap) Fixed leak by changing &owner to
9300 &fm->owner in several places.
9302 * som-high.c: (output_table) Changed interface to rest of world.
9303 (examine_crush_table) Removed. Crushed tables are re-broken now,
9304 in preparation for rewrite.
9306 * som.h: Comment fix.
9308 Sat Sep 28 21:28:07 1996 Ben Pfaff <blp@gnu.org>
9310 * ascii.c: (ascii_init_driver) Disposes of x->file.filename and x
9311 itself in the cleanup stage.
9313 * descript.q: (display) At least temporarily, changed the table
9314 format to a crushed table.
9316 * list.q: (begin_row) At least temporarily, added horizontal lines
9319 * som-high.c: (examine_crush_table) Sets som.hh to the width of
9320 the horizontal "headers," that is, to the width of the far left
9321 and far right rules.
9322 (justify_pagination) Sets som.th to the width of the widest row
9323 in the crushed table. Fixed inner loop off-by-one error.
9325 * som-low.c: (som_dump_crush_page) Added code to draw horizontal
9328 * somP.h: Comment fix.
9330 Fri Sep 27 20:08:39 1996 Ben Pfaff <blp@gnu.org>
9332 * filename.c: (open_file_ext) Now, doesn't set f->file to NULL
9333 before closing it; also, opens the constructed filename `s'
9334 instead of f->filename.
9336 * postscript.c: Moved initialization of x->loaded, x->prop,
9337 x->fixed, x->current, also the add_encoding() calls, into
9339 (preclose) Destroys x->combos; sets x->loaded, x->combos to NULL;
9340 sets x->last_font to NULL; sets x->next_combo to zero.
9342 * som-high.c: (crushed_row_height) Moved definition farther up.
9343 (som_submit_table) Doesn't calculate line width, font size until
9344 after calling open_page(), to accomodate changes to PostScript
9346 (vert_headers) Removed; equivalent functionality moved to
9347 examine_table(), examine_crush_table().
9348 (justify_pagination) Replaced with different algorithm.
9349 (dump_crush_table) Bugfix that caused tables to fail to be clipped
9350 at the bottom of the page.
9352 Thu Sep 26 22:20:26 1996 Ben Pfaff <blp@gnu.org>
9354 * command.c: Added cmd_list back into cmd_table.
9356 * freq.c, frequencies.q, repeat.c, list.q, vars-atr.c, vfm.c:
9357 Comment fix: `#define DEBUGGING' --> `#define DEBUGGING 1'.
9359 * list.q: (flush_table) Updated to new som_submission_form format.
9361 * som-frnt.c: Comment fix.
9363 * som-high.c: Changed `#endif' to `#undef EXTERN'.
9364 (output_table) Calls som_get_table_size() directly; handles
9366 (examine_crush_table) New function; calls vert_headers().
9367 (examine_table) Moved some code into new function, vert_headers().
9368 (justify_pagination) New function.
9369 (dump_plain_table) Removed `static' from `cy'.
9370 (dump_crush_table) New function.
9372 * som-low.c: (som_dump_crush_page) New function.
9374 * som.h: Comment fixes.
9375 (enum SOM_TOPT_CRUSH) New.
9376 (SOM_SUB_PARTIAL_BEG, SOM_SUB_PARTIAL_MID, SOM_SUB_PARTIAL_END)
9377 Temporarily set to zero to make do with LIST procedure.
9379 * somP.h: Re-ordering.
9381 Wed Sep 25 19:36:11 1996 Ben Pfaff <blp@gnu.org>
9383 * som.c: Split into som-frnt.c, som-high.c, som-low.c.
9385 * somP.h: New file for use by som-high.c, som-low.c.
9387 * q2c.c: Added definition for VME.
9388 (get_line) Now dumps `!' comment lines to the output file
9391 * crosstabs.q, descript.q, file-handle.q, frequencies.q, list.q,
9392 set.q: Changed format of `!' comment lines.
9394 Tue Sep 24 18:39:09 1996 Ben Pfaff <blp@gnu.org>
9396 * All source files: Added copyright notice.
9398 * common.c: (xmalloc, xrealloc, xstrdup) Cast size_t's to unsigned
9399 longs in msg() calls.
9401 * con32s.c: (xmalloc, xrealloc) Updated from common.c.
9403 * q2c.c: (xmalloc, xrealloc, xstrdup) Updated from common.c.
9405 Sat Sep 21 23:16:31 1996 Ben Pfaff <blp@gnu.org>
9407 * output.c: (outp_read_devices) Changed criteria for
9408 distinguishing different types of lines.
9410 Fri Sep 20 22:52:28 1996 Ben Pfaff <blp@gnu.org>
9412 * cmdline.c: Changed syntax message.
9414 * filename.c: (good_getcwd) Bug fix (?).
9415 (normalize_filename) [__BORLANDC__] Uses _fullpath() library
9417 (search_path) Appends DIR_SEPARATOR to directory name only if it
9418 does not already end with one.
9420 * glob.c: Checks STAT_PAGER envvar before PAGER.
9422 * output.c: Checks environment variables instead of just local
9425 Tue Sep 10 21:39:00 1996 Ben Pfaff <blp@gnu.org>
9427 * arena.c: (arena_destroy) Swatted a subtle bug that cropped up
9428 when the pointer passed to the function was within the arena
9429 itself, so that it couldn't properly be set to NULL _after the
9432 * command.c: Re-enabled DISPLAY.
9434 * display.c: Rewritten to handle tables. Untested.
9436 * filename.c: (search_path) Fixed memory leak.
9438 * frequencies.q: (cmd_frequencies) Frees v_variables.
9439 (postcalc) Calls cleanup_freq_tab() after displaying statistics.
9440 (cleanup_freq_tab) New function to garbage collect.
9441 (dump_full) Elegantized.
9443 * main.c: New comment.
9445 * output.h: New tag for tagged quotes: TAG_NEWLINE.
9447 * postscript.c: Comment fix.
9448 (release_fontmap, free_font_entry) New functions.
9449 (ps_init_driver) Sets free_font_entry() as the freefunc for
9450 hashtable `loaded'. Calls release_fontmap() when destroying a
9451 driver; also frees the output filename; also frees the
9452 ps_driver_ext block.
9453 (free_ps_encoding) Frees the filename as well as the encoding
9455 (output_encodings) Frees the line buffer and pops the msg-filename
9457 (read_fontmap) Frees the fontmap filename and the line buffer.
9458 (postopen, preclose) Misc. garbage collection fixes.
9459 (ps_open_page) Destroys the `combos' hash table; sets `last_font'
9460 to NULL; this fixes some output problems.
9461 (text) Handles TAG_NEWLINE. Untested.
9463 * som.c: (cell_byte_size) Merged SCON_VALUE and SCON_TEXT cases.
9464 (som_set_string) Removed. All references changed to
9466 (som_set_text) Rewritten. New interface. More general.
9468 * som.h: Minor format changes.
9469 (struct som_value_cell) Removed; all references changed to
9471 (enums SOT_*) Changed.
9473 Mon Sep 9 21:43:13 1996 Ben Pfaff <blp@gnu.org>
9475 * command.c: Re-enabled SPLIT FILE.
9477 * postscript.c: Comment fix.
9479 * som.h: Added `SOT_NONE'.
9481 * split-file.h: (cmd_split_file) Removed superfluous parenthesis.
9483 * vfm.c: (dump_splits) Reimplemented.
9485 Sat Sep 7 22:35:12 1996 Ben Pfaff <blp@gnu.org>
9487 * Compiled the project under gcc 2.7.2, which gave some new
9488 warnings. This led to many additions of casts from unsigned to
9489 int sprinkled throughout the code.
9491 * arena.c: Many uses of `unsigned' changed to `size_t'.
9493 * command.c: Added END FILE, END REPEAT to command table.
9494 (var cmd_end_repeat) Renamed cmd_end_repeat_p.
9495 (find_command, FILE_TYPE_okay) Not commented out anymore.
9496 (parse_cmd) Calls FILE_TYPE_okay again.
9497 (output_line) Added calls to som_output_text() to put the line
9498 in the output files.
9500 * common.c: (macro VME) Format changes.
9501 (xstrdup) Asserts that its argument is not NULL.
9503 * data-list.c: Implemented dump_fixed_table().
9505 * inpt-pgm.c: Formatting changes. Comment changes.
9506 (end_case_proc) Renamed end_case_trns_proc.
9507 (cmd_end_file, end_file_trns_proc) New functions.
9509 * misc.c: Many uses of `int' and `unsigned' changed to `size_t'.
9511 * misc.h: (local_strdup) New macro corresponding to strdup() but
9512 allocating its data through local_alloc() if possible--that is, if
9515 * postscript.c: Comment changes.
9516 (quote_ps_name, quote_ps_string, output_encodings) New functions.
9517 (output_line, add_string) New macros supporting
9519 (postopen) Fixed contents of ${fixed-font} and ${prop-font}
9520 substitution vars. Calls output_encodings() when a line
9521 consisting of `!encodings' is encountered.
9522 (preclose) Some code moved into quote_ps_string().
9523 (dump_line) Changed into macro supporting dump_fancy_line().
9524 (switch_font) Now outputs DSC "%%IncludeResource: font (...)"
9525 command when appropriate.
9526 (write_text) Fixed `literal_char' array (I think it's fixed, at
9528 (text) Fixed bug when width was zero. Now exits immediately on
9529 zero height_left. Now, when executing `goto restart;', checks
9530 that cp<end, so that we don't read beyond end-of-string. Also,
9531 outputs the correct code to the output file by outputting the code
9532 from the metric instead of the internal metric index.
9534 * repeat.c: (cmd_end_repeat) New function.
9536 * som.c: (var som) `headers' renamed `options' and semantics
9537 changed. All references changed.
9538 (draw_title) `if(px!=-1 || px!=-1)' --> `if(px!=-1 || py!=-1)'.
9539 (build_target) Only inserts spacing if SOM_TOPT_SPACING not
9541 (som_text_table) Removed.
9542 (som_output_text) New function.
9544 * som.h: (struct som_submission_form) Removed `header', `reuse',
9545 replaced with bitmapped field `options'.
9546 (SOM_TOPT_*) New enum set for som_submission_form.options.
9547 (SOT_*) New enum set for som_output_text().
9549 * temporary.c: (copy_variable) When copying the var label, only
9550 calls xstrdup() if it's non-NULL.
9552 * var.h: (enum type `vartype') Removed; all references changed to
9555 * vars-atr.c: (init_variable) Changed local var `nbytes' from
9558 Thu Sep 5 22:05:56 1996 Ben Pfaff <blp@gnu.org>
9560 * font.h: Comment changes.
9562 * groff-font.c: (groff_read_font) Initializes `name' field to
9563 NULL. Handles `encoding' field.
9565 * hash.c: (hsh_dump) [GLOBAL_DEBUGGING] Output formatting changes.
9567 * postscript.c: (struct font_entry) Removed `position' field.
9568 (struct ps_font_combo) New struct.
9569 (struct ps_driver_ext) Removed field `next_position'. New fields
9570 `combos', `next_combo'. `last_font' field changed from
9571 `font_entry *' to `ps_font_combo *'.
9572 (ps_init_driver) Reformatted; handles new fields. When
9573 OPO_AUTO_ENCODE is set, adds the two default fonts' encodings to
9575 (get_encoding, find_encoding_file) New functions.
9576 (add_encoding) Some code moved out into find_encoding_file().
9577 (postopen) Changed value for ${title}.
9578 (preclose) Sets `loaded' field to NULL after destroying the hash
9580 (ps_open_page) Added comment. Inits the `combos' and `next_combo'
9582 (ps_text_set_font_by_position) Figures out the current family if
9584 (compare_ps_combo, hash_ps_combo, free_ps_combo) New functions.
9585 (switch_font) Implemented.
9586 (write_text) Calls switch_font() more often. Format changes.
9587 #undefs its macros after they're no longer useful.
9588 (text) Changed `continue' at one point to a jump to the top of the
9589 loop because we don't want `separate' reset to 0 at that point.
9590 (load_font) No longer sets `position' in the font_entry created.
9592 Wed Sep 4 21:45:35 1996 Ben Pfaff <blp@gnu.org>
9594 * font.h: (struct font_desc) New member `encoding', which is not
9595 properly handled yet.
9597 * glob.c: (init_glob) Some new i18n code, which is probably
9600 * output.c: (outp_read_devices, outp_get_paper_size) Changed
9601 `size' local from `int' to `size_t'.
9603 * postscript.c: New driver configuration parameter `auto-encode'.
9604 New enums OPO_AUTO_ENCODE, ODA_COUNT.
9605 (struct font_entry) New member `position'.
9606 (struct ps_driver_ext) Reordered. New hash table member
9607 `encodings'; new members `next_position', `next_encoding',
9608 `last_font'. Members `current', `prop', `fixed' changed from type
9609 `font_desc *' to `font_entry *'; all references changed.
9610 (struct ps_encoding) New struct.
9611 (read_ps_encodings, compare_ps_encoding, hash_ps_encoding,
9612 free_ps_encoding, add_encoding) New functions.
9613 (ps_init_driver) Added OPO_AUTO_ENCODE to default
9614 x->output_options. Initializes new members of ps_driver_ext.
9615 Changed default value for prologue_fn, encoding_fn. Calls
9616 read_ps_encodings after loading default fonts.
9617 (option_tab[], ps_option) Handle new configuration parameter.
9618 (switch_font) New function.
9619 (struct output_char) `font' member changed from `font_desc *' to
9620 `font_entry *'. New member `separate'.
9621 (read_fontmap) Changed `size' from `int' to `size_t'.
9622 (output_line, put_number) New macros for write_text().
9623 (write_text) Optimizes text output by consolidating multiple
9624 calls to PostScript `show' operator.
9625 (text) Keeps track of when text arguments can't be consolidated by
9626 write_text(), and marks those spots in the output stream.
9627 (load_font) Sets `position' of the allocated font_entry to -1, cuz
9628 the font hasn't been switched to by switch_font(), which is where
9629 the position is important--the PostScript is what cares about the
9632 Sat Aug 31 23:52:38 1996 Ben Pfaff <blp@gnu.org>
9634 * hash.c: (hsh_destroy) Ignores NULL argument. Doesn't try to
9635 call a NULL free_func.
9636 (hsh_rehash) Elegantized.
9637 (hsh_probe) Fix bug that manifested when the table was expanded
9638 and thus had to change location in memory. Good thing
9639 too--otherwise could have been much more subtle.
9640 (hsh_find) [GLOBAL_DEBUGGING] Not stubbed out anymore.
9641 (hsh_foreach) New function for hash table iteration.
9643 * hash.h: (struct hsh_iterator) New.
9645 * lexer.c: (parse_tagged_quote) Font and family name strings in
9646 tags are now null-terminated.
9648 * output.c: (outp_evaluate_dimension) Fixed over-aggressive unit
9650 (internal_get_paper_size, outp_get_paper_size) Fixed; now work as
9651 documented. (Never before tested?)
9653 * output.h: Comment changes.
9655 * postscript.c: New driver options `optimize-text-size',
9656 `optimize-line-size', `max-fonts-simult'. New enum set for
9657 specing cached line types. Comment fixes.
9658 (struct line_form) New struct.
9659 (struct ps_driver_struct) New members `text_opt', `line_opt',
9660 `max_fonts', `lines'.
9661 (ps_init_driver) Initializes new members of ps_driver_struct.
9662 (user option type enum set) New member `nonneg_int_arg'.
9663 (static var option_tab[]) Supports new options.
9664 (ps_option) Handles new options.
9665 (find_ps_file) Made static. No longer calls hsh_dump().
9666 (ps_get_var) Made static.
9667 (preclose) Dumps out proper DSC trailer.
9668 (ps_open_page) Elegantized.
9669 (ps_close_page) Calls dump_lines() if appropriate.
9670 (ps_line_horz, ps_line_vert, ps_line_intersection) Reduced to
9671 wrappers around line().
9672 (int_2_compare, compare_line, dump_line, dump_fancy_line,
9673 dump_lines, hash_line, free_line, line) New functions for support
9675 (write_text, text) Made static.
9676 (text) Added to font support, not finished.
9678 Thu Aug 29 21:36:41 1996 Ben Pfaff <blp@gnu.org>
9680 * font.h: (struct font_desc) New members ascent, descent.
9682 * groff-font.c: (groff_read_font) Calculates font ascent and
9683 descent from the ascent and descent of the `d' and `p' characters,
9684 respectively, as per a suggestion on comp.fonts.
9686 * postscript.c: (ps_open_page, ps_close_page, ps_line_horz,
9687 ps_line_vert, ps_line_intersection) Rewritten to deal with changed
9689 (write_text) Handles text right-justification and centering (not
9690 full justification). Still very inefficient. (One output line
9692 (struct output_char) Added fields for font and font size.
9693 (text) Many bugfixes.
9695 Sat Aug 24 23:26:00 1996 Ben Pfaff <blp@gnu.org>
9697 * cmdline.c: (usage) Calls outp_list_classes().
9699 * font.h: Comment fix.
9701 * groff-font.c: New exported global var `space_index'.
9702 (groff_init) New function to initialize `space_index'.
9703 (hash_kern) Casts result to unsigned.
9704 (font_name_to_index) Renamed font_char_name_to_index. All
9705 references changed. Also, now returns the value of `space_index'
9706 when passed an ASCII space character as an argument. Fixed
9708 (font_get_kern_adjust) Changed i from `int' to `unsigned'.
9709 Handles passed NULL pointers properly.
9711 * lexer.c: (parse_tagged_quote) Comment fix. Better range
9714 * output.c: (outp_list_drivers) Removed. Removed all references.
9716 * output.h: Comment fixes.
9718 * postscript.c: (ps_open_global) Calls groff_init().
9719 (output_char) New structure.
9720 (write_text) New function.
9721 (text) No longer stubbed out! Now the output is correct--with a
9722 few exceptions, one of them being that the page has to be held
9723 upside down into a mirror.
9725 Sun Aug 11 21:31:22 1996 Ben Pfaff <blp@gnu.org>
9727 * font.h: Comment fix.
9729 * font.c: (name_to_index) Renamed font_name_to_index, made extern.
9730 All callers changed.
9731 (number_to_index) Renamed font_number_to_index, made extern. All
9733 (font_get_kern_adjust, font_get_char_metrics) New functions.
9735 * output.h: New constant OUTP_T_INTERNAL_DRAW.
9737 * postscript.c: Changed default line width back to 1/2 point.
9738 (ps_line_horz, ps_line_vert, ps_line_intersection) Now lines are
9739 in the center of the space allotted for them, not just a fixed
9740 offset from the edge of the space; this fixes some bugs.
9741 (ps_line_intersection) Now supports all command line styles.
9742 (ps_text_get_size) Bug fix in computation of em width.
9743 (text) New function, the meat behind ps_text_metrics and
9744 ps_text_draw. Not complete.
9745 (ps_text_metrics, ps_text_draw) Removed the stub taken from
9746 ascii.c; call text().
9748 Sat Aug 10 23:28:17 1996 Ben Pfaff <blp@gnu.org>
9750 * arena.c: (arena_free) Assert that the argument is non-NULL.
9752 * groff-font.c: (add_kern) Calls arena_free() for old_kern if and
9753 only if old_kern is non-NULL.
9755 * postscript.c: (ps_init_driver) Changed default line width to 1
9757 (postopen) New prologue variables.
9758 (ps_line_horz, ps_line_vert, ps_line_intersection) Implements some
9759 more of the common line styles properly, but not all.
9760 (ps_text_metrics) Fixed problem with this stubbed out version that
9761 kept it from taking font sizes into account.
9763 Thu Aug 8 22:31:11 1996 Ben Pfaff <blp@gnu.org>
9765 * arena.c: (arena_malloc) Bug fix.
9766 (arena_dump) [GLOBAL_DEBUGGING] New function.
9768 * ascii.c: Comment fix.
9769 (count_fancy_chars, delineate) Now static functions.
9771 * filename.c: (interp_vars) Bug fixes.
9773 * font.h: Comment fixes.
9775 * glob.c: (init_glob) Sets set_viewwidth, set_viewlength at
9776 beginning in case we have an error message to display before
9777 initializing the display.
9779 * groff-font.c: Comment fix. Changed rehash threshold from 2/3
9781 (groff_read_font) Bug fixes.
9782 (name_to_index) Increments hash.used. Sets `name' field of hash
9784 (add_kern) Sets kern_max_used after rehashing. Other bug fixes.
9786 * hash.c: Return type changed.
9788 * postscript.c: Continued development. Now marks lines on the
9789 paper, but very buggy.
9791 Sat Aug 3 20:50:35 1996 Ben Pfaff <blp@gnu.org>
9793 * Changed comments in many source files from `/* xxx /* yyy */' to
9794 `/* xxx */ /* yyy */' for cleanliness.
9796 * arena.c: (arena_sd_strdup) New function.
9798 * ascii.c: (struct ascii_driver_ext) New member `file'.
9799 (ascii_init_driver) Fills out member `file' for initing; uses
9800 close_file_ext for closing drivers.
9801 (ascii_option) Changed %.*s back to %s because the a_string's are
9802 always null-terminated.
9803 (postopen, preclose) New functions.
9804 (ascii_open_page) Uses new style of open_file_ext.
9805 (ascii_option, commit_line_buf, output_lines) Use ext->file.file
9806 instead of this->output.
9807 (__assert_fail) Removed.
9809 * cmdline.c: Changed syntax_message[].
9811 * error.c: #include's <readline/history.h> only if the history
9812 library is available, not if just the readline library is
9815 * filename.c: (expand_line) Removed alloca() support.
9816 (interp_vars) No longer tilde-expands argument. Limit on output
9818 (tilde_expand) Now treats argument as path rather than filename.
9819 [!unix] Now is a no-op function.
9820 (search_path) Better verbose message formatting.
9821 (open_file, close_file) Comment fixes.
9822 (close_file) [!unix] Doesn't bother with pipes.
9823 (open_file_ext) Completely rewritten, interface revamped.
9824 (close_file_ext) New function.
9826 * font.h: Comment changes.
9828 * frequencies.q: Removed AIX alloca support since it doesn't use
9831 * hash.c: Comment changes & additions.
9832 (hsh_create) Initializes entire table instead of first M entries.
9833 (hsh_probe) Stupid bug fixed. Now it works.
9834 (hsh_dump) [GLOBAL_DEBUGGING] New function.
9836 * main.c: (parse) Detects EOF properly in token-eating loop.
9837 Should the STOP token have its value changed to 0?
9839 * misc.c: (blp_getdelim) [HAVE_GETDELIM] Now it's a macro.
9840 (blp_getline) Now it's a macro.
9842 * output.h: (struct outp_driver) Removed members output, filename.
9844 * output.c: (outp_init) [!NO_POSTSCRIPT] Installs PostScript
9845 drivers in driver table.
9846 (outp_read_devices) Frees buf. Warns if there are no active
9848 (outp_configure_clear) Sets outp_configure_vec to NULL after
9849 deleting its elements.
9850 (configure_driver, destroy_driver) Removed references to output,
9851 filename members of outp_driver.
9852 (outp_evaluate_dimension, internal_get_paper_size,
9853 outp_get_paper_size) New functions.
9855 * postscript.c: Continued development. Now links but doesn't make
9856 any marks on the page. Lotsa bugs I suppose.
9858 * str.c: (strcasecmp) [!HAVE_STRCASECMP] New function.
9860 * str.h: Comment changes.
9862 Sat Jul 27 22:32:38 1996 Ben Pfaff <blp@gnu.org>
9864 * Removed dependencies on non-nested comments in several files.
9865 Also removed references to (unix || __unix__) in #if's since
9866 prefh.orig makes those two equivalent.
9868 * ascii.c: (ascii_open_global) Creates ascii_arena.
9869 (ascii_close_global) Destroys ascii_arena.
9870 (ascii_init_driver) Doesn't create ascii_arena.
9871 (ascii_copy_driver) Removed.
9872 (ascii_option) Possible bugfix regarding %s vs. %.*s with a_string's.
9873 (outp_class ascii_class) Removed ascii_copy_driver reference.
9875 * frequencies.q: Now can display all statistics except median.
9878 * output.c: Handles outp_class.ref_count so output class
9879 destructors are called properly.
9880 (add_class) Sets ref_count to 0.
9881 (configure_driver) Initializes class if ref_count++ is 0.
9882 (destroy_driver) Destructs class if --ref_count is 0. Frees the
9883 class output file name.
9885 * output.h: (struct outp_class) Removed copy_driver, inited.
9888 * postscript.c: Completely replaced but not finished.
9890 Tue Jul 23 21:48:36 1996 Ben Pfaff <blp@gnu.org>
9892 * approx.h: #includes <float.h>.
9894 * arena.h, arena.c: Many functions changed to take an arena **
9895 instead of an arena *, for consistency. All callers changed.
9896 (arena_alloc) Now creates a new arena if passed *A that is NULL.
9897 (arena_destroy) Sets *A to NULL.
9899 * ascii.c: (delineate) Implements OUTP_T_VERT correctly. Removed
9900 assertion that `width' be positive.
9902 * command.c: Removed #if's from cmd_table.
9903 (walk_cmdtable_func) [0] New function (debug code).
9904 (init_cmd_parser) [0] Dumps out cmd_table (debug code).
9905 (parse_cmd) Doesn't return failure for unimplemented commands.
9907 * common.h: (SYSMIS) Changed from DBL_MAX to -DBL_MAX.
9908 (SYSCODE) New constant macro.
9910 * descript.q: Checks for positive n_variables before performing
9913 * file-handle.q: (get_handle_by_filename) Bug fix: passes &f to
9914 avl_find instead of &fp as arg 2.
9916 * frequencies.g, frequencies.q: Continued updating; now compiles &
9917 works again, but not complete.
9919 * main.c: Changes to user messages.
9921 * misc.c: (reverse) [0] New function.
9923 * settings.h: Comment removed. #includes "common.h".
9925 * som.c: (som_set_null) New function.
9926 (som_set_value, som_set_string, som_set_text) More detailing
9928 (som_set_float) Implemented function.
9929 (dump_columnated_table) Bug fix regarding page breaks.
9930 (draw_cell) Bug fix regarding text that spilled out of a cell.
9931 (draw_intersection, draw_horz_rule, draw_vert_rule) No longer draw
9933 (get_cell_size) Support SCON_EMPTY cells.
9934 (get_table_size) When calculating rules' widths and heights, mask
9935 out SLIN_SPACING bit. Added SOPT_X_HLTL support.
9937 * som.h: (som_any_cell) New option SOPT_X_HTLT. Removed
9939 (struct som_submission_form) New member `header'; all users
9942 * val-labs.c: (get_label) User messages changed.
9944 * var.h: Changed FREQUENCIES structures.
9946 * vars-atr.c: (is_num_user_missing, is_str_user_missing) Made
9949 Fri Jul 19 19:11:13 1996 Ben Pfaff <blp@gnu.org>
9951 * approx.h: Definition of EPSILON now depends on system's
9952 DBL_EPSILON. Removed GNU C specific code.
9953 (cmpapx) Renamed approx_compare.
9955 * frequencies.g, frequencies.q: Continued updating; still doesn't
9958 * groff-font.c: (name_to_index) Fix bug that kept it from
9961 * hash.c, hash.h: Completed work.
9963 * var.h: Changes to freq_tab, frequencies_proc.
9965 Wed Jul 17 21:23:36 1996 Ben Pfaff <blp@gnu.org>
9968 * hash.c, hash.h: New files. Not completed.
9969 * Makefile.am: Added hash.c to source file list.
9970 * font.h: (struct font_desc) New member kern_size_p.
9971 * groff-font.c: Uses hash.h.
9972 (hashpjw) Moved to hash.c.
9973 (next_prime_power) Rewrote, renamed hsh_next_prime, moved to
9975 (static var hash) New member size_p.
9976 * var.h: Includes hash.h.
9977 (struct freq_tab) Changed AVL_TREE to hash_tab.
9979 * vars-prs.c: Comment, formatting fixes.
9981 * frequencies.g, frequencies.q: Continued updating. Not yet
9984 * formats.c: Bug fix.
9986 Tue Jul 16 22:10:04 1996 Ben Pfaff <blp@gnu.org>
9988 Increasing parallelism between DESCRIPTIVES and FREQUENCIES.
9989 * descript.g: Comment fixes.
9990 * descript.q: Comment fixes. Moved some declarations into var.h.
9991 Made dsc_info a static table. Updated FIXMEs.
9992 (internal_cmd_descriptives) Beautified.
9994 * frequencies.q: Started updating into working order.
9995 * frequencies.g: New file analogous to descript.g.
9996 * var.h: Comment fixes. Added structures for FREQUENCIES.
9998 * som.c: Removed vestiges of crushing and partial table support.
10000 Sun Jul 14 15:45:31 1996 Ben Pfaff <blp@gnu.org>
10002 * Many more changes to som.c especially, but these will not be
10003 documented as I have resolved to remove them. This patchlevel is
10004 being released solely so that I can fall back to it if I decide
10005 that removing the changes is not a good idea.
10007 Sat Jul 13 09:58:44 1996 Ben Pfaff <blp@gnu.org>
10009 * som.c: (global var som) New member `cum_y'.
10010 (build_target) Properly handles titles for partial tables.
10011 (dump_partial_beg, dump_partial_mid, dump_partial_end)
10012 Merged into single new function dump_partial(). Fixed problem
10013 with titles on partial tables.
10014 (dump_table) Calls dump_partial() for all parts of partial tables.
10015 (dump_page) Criteria for drawing title changed.
10017 Fri Jul 12 22:03:36 1996 Ben Pfaff <blp@gnu.org>
10019 * command.c: (cmd_table) Added LIST, WEIGHT.
10021 * command.c: (cmd_remark) No longer frees `s' since it's not
10022 dynamically allocated.
10024 * data-out.c: (convert_f) Now correctly handles the case where
10025 abs(v->f)<1 but v->f rounds to a value of 1.00 given the specified
10026 number of decimals.
10027 (som_destroy_all_tables) Removed argument. All callers changed.
10028 (som_vline, som_hline) Argument validity checking corrected.
10029 (som_set_value) Implemented half-heartedly.
10030 (replicate_table) Copies tables piece-by-piece when using Checker.
10032 * som.h: New line style SLIN_1THIN, currently equivalent to
10033 SLIN_0. New enum set SOM_SUB_*.
10034 (struct som_submission_form) Removed `seq_no'. Added `type'.
10036 * list.q: Newly working file; uses partial tables.
10038 * som.c: (som_reduce_table) Renamed som_set_table_height().
10039 (som_crush) Removed argument `group'.
10040 (global var som) Removed `nt', `seq_no'. Added `type'.
10041 (som_submit_table) Arguments changed.
10042 (output_table) Removed partial table code.
10043 (build_target) New arg; partial table support added. All callers
10045 (dump_plain_table) Removed partial table code.
10046 (dump_partial_beg, dump_partial_mid, dump_partial_end) New functions.
10047 (dump_table) Supports partial tables.
10048 (dump_page) New argument to allow not drawing top and/or bottom
10049 headers. All callers changed. Supports partial tables.
10051 Sat Jul 6 22:22:25 1996 Ben Pfaff <blp@gnu.org>
10053 * data-out.c: Changed `#include <approx.h>' to `#include
10055 (convert_F) Comment fix. Now won't print `-.000', etc.
10057 * descript.q: Now Z-scores work, although there appears to
10058 be a bug (which might actually be in data-out.c:convert_F()).
10059 (descriptives_trns_proc, descriptives_trns_free) New functions.
10060 (run_z_pass) Implemented.
10062 * var.h: Comment fixes.
10063 (dsc_z_score, descriptives_trns) New structs.
10064 (descriptives_trns) Added to any_trns as `dsc'.
10066 * error.c, error.h: New error class, IS (Installation Script
10067 error), used in those instances where the error is in the
10068 installation, but there is a script file or installation file that
10069 can be usefully referred to.
10071 * output.c: Change many IE classes to IS classes.
10073 * cases.c, command.c, common.c, crosstabs.q, expr-evl.c,
10074 frequencies.q, list.q, vars-prs.c, vfm.c: Removed reference to
10075 HAVE_MALLOC_H because Borland C++ alloca() is broken, so why
10076 include the corresponding header?
10078 * glob.c: (init_glob) Don't malloc term_buffer under Checker.
10079 Don't bail out if termcap can't be read.
10081 * som.c: (som_destroy_table) Removed.
10082 (som_reduce_table, som_destroy_all_tables) New functions.
10083 (som_crush) New function, not implemented.
10085 * som.h: New table option STAB_CRUSH. Comment fix. New struct
10086 som_submission_form. Function prototypes revised.
10088 Outputting huge tables (1000s of rows) a few rows at a time
10089 is supported, though untested. May even break everything.
10090 Actually, the code doesn't even compile right now.
10091 * som.c: (struct som) New fields htv, nt, seq_no.
10092 (som_submit_table) Multiple arguments changed to a single
10093 pointer to struct submission_form. Only increments subtable_num
10094 if seq_no is zero. Only destroys table if it's not going to
10096 (replicate_table) New function.
10097 (output_table) Comment fix.
10098 (examine_table) Changed inline code to code calling
10099 replicate_table(). Calculates htv. Supports partial tables.
10100 (draw_title) Removed comment.
10101 (build_target) Only allows for title on first part of partial
10103 (dump_plain_table) Only resets table chunk number on first part
10104 of partial tables; FIXME: doesn't work quite right. Supports
10106 (dump_page) Titles only on first part of partial tables.
10108 Fri Jul 5 20:16:19 1996 Ben Pfaff <blp@gnu.org>
10110 * Thanks to an unreliable IDE hard drive, I have spent the last
10111 day reconstructing my Debian GNU/Linux installation and redoing
10112 the previous day's changes--somehow I managed to save every file
10113 except for output.c and output.h. So the following changes could
10114 really be considered independent of the output.c, output.h changes
10117 * output.h, output.c: Moved the outp_configure_vec global var,
10118 outp_names struct, and enum set OUTP_S_* from output.h to output.c.
10119 outp_configure_vec is now static.
10121 Thu Jul 4 20:20:24 1996 Ben Pfaff <blp@gnu.org>
10123 * The entire philosophy behind configuration of the output drivers
10124 changed. Now there is a termcap-type configuration where drivers
10125 to be read are determined beforehand, rather than parsing the
10126 entire output init file and storing it in memory & deciding what
10127 to actually use later. Faster & more memory-efficient at the same
10130 * output.c: Comment fix. Removed outp_init_drivers global var.
10131 Removed all references to synonyms. New structure outp_defn. New
10132 global vars outp_macros, outp_configure_vec.
10133 (search_name, delete_name, add_name, check_configure_vec,
10134 expand_name, find_defn_value) New static functions.
10135 (outp_configure_clear, outp_configure_add, outp_configure_macro,
10136 outp_read_devices) New extern functions.
10137 (outp_init) Much functionality moved into outp_read_devices.
10138 (outp_read_devices) Format of output init file changed; name of
10139 file is `devices' rather than `output' to avoid Makefile
10141 (outp_clear) Renamed outp_done.
10142 (outp_list_classes) Bug fix, cleaned up.
10143 (outp_list_drivers) Not implemented anymore.
10144 (outp_configure_driver) Now a static function; simplified; now
10145 interpolates macros; supports new structure.
10146 (outp_enable_driver, match_synonym) Removed; all references
10148 (find_driver) First argument removed.
10150 * output.h: Global var outp_init_drivers removed; new structure
10151 outp_names; new enum set OUTP_S_*; new global var
10152 outp_configure_vec; function prototypes for output.c exports
10155 * main.c: (main) Calls outp_read_devices() after parsing the
10158 * cmdline.c: (parse_command_line) New option -v --verbose;
10159 --version changed to -V. --device option changed syntax to just
10160 take a single device name. Accepts key=value declaration of
10161 output init file macros. Syntax message updated.
10163 * filename.c: (expand_line) New function.
10164 (interp_environ_vars) Renamed interp_vars; no longer uses
10166 (blp_getenv) Allows $ARCH and $VER pseudo-environment-vars to be
10167 overridden by real environment vars.
10168 (search_path) Uses verbose_msg() instead of #ifdef'd printf().
10169 * filename.h: interp_environ_vars() renamed interp_vars().
10171 * error.c, error.h: Added extern variable `verbosity', message
10174 * error.c: (vmsg) Support message class MM.
10175 (verbose_msg) New function.
10177 * descript.q: (generate_z_varname) Bug fix in generation of
10179 (dump_z_table) Bug fix in column headers.
10181 * ascii.c: (ascii_init_driver) Changed minimum number of lines per
10182 page from 29 to 15. Don't set a default for ops[OPS_INIT,
10183 OPS_DONE]. Writes the uninit string when the driver is closed.
10184 (ascii_open_page) Write the init string before the first page.
10185 (output_shorts) Form of main loop changed from `while' to `for'.
10186 Bug fix with overstrikes: the character is printed *after* the
10187 backspace. Eliminated a lot of `& 0xff' modifiers.
10188 (advance_to_left_margin) New function.
10189 (return_carriage, output_lines) Handle left margin.
10191 Thu Jul 4 00:35:59 1996 Ben Pfaff <blp@gnu.org>
10193 * ascii.c: New option `carriage-return-style'.
10195 * ascii.c: (count_fancy_chars) New function.
10196 (delineate, text_metrics) Use new function; bug fixes regarding
10198 (text_draw) Bug fix with rich text.
10199 (output_string, output_shorts) Reordered.
10200 (output_shorts) Now handles boxchars and some overstrike font
10202 (output_char, return_carriage) New functions.
10203 (output_lines) Now handles overstriking and font changes properly;
10204 some code moved to output_shorts.
10206 Tue Jul 2 22:13:23 1996 Ben Pfaff <blp@gnu.org>
10209 * ascii.c: New member `debug' in ascii_driver_ext.
10210 (ascii_init_driver, delineate) Uses new member.
10212 Now you can set a vertical height on writing text.
10213 * ascii.c: (delineate) Keeps track of vertical position.
10214 (text_draw) No longer considers fully justified text an internal
10217 * output.h: New flag OUTP_T_VERT; other OUTP_T_ values changed.
10219 Tables' titles are drawn; they can have variable height.
10220 * som.c: `som' struct has new member, title_height.
10221 (draw_title) New argument. Moved within file. All caller
10223 (build_target) New argument, amount of space needed for first row.
10224 Calculates height of title, takes that into account. All callers
10226 (dump_plain_table, dump_columnated_table) Took calculation of y1,
10228 (dump_columnated_table) [GLOBAL_DEBUGGING] Debugging code
10230 (dump_columnated_table) Organized for readability.
10231 (dump_page) Makes use of som.title_height.
10233 * som.c: Many comment bug fixes.
10235 * descript.q: (try_name, generate_z_name) Bug fix regarding
10236 generation of Z-score variable names.
10237 * var.h: Removed num from descriptives_proc; all referents removed.
10239 Mon Jul 1 22:13:39 1996 Ben Pfaff <blp@gnu.org>
10241 * ascii.c: (ascii_line_horz, ascii_line_vert,
10242 ascii_line_intersection) Added debugging code.
10244 Added a descriptive line above each table to describe it.
10245 * command.c: (parse_cmd) Calls som_new_series.
10247 * som.c: New static vars table_num, subtable_num. New `som'
10249 (dump_page) New arguments.
10250 (som_submit_table) Handle new variables.
10252 * som.c, som.h: (som_submit_table) New arguments. All callers
10254 (som_new_series) New function.
10255 (build_target) Makes room for extra line.
10256 (draw_title) New function.
10257 (dump_page) Calls draw_title. Bug fix: doesn't always set
10260 Columnation of tables support.
10261 * som.h: Deleted fr, lr, ri from som_table. Reorganized.
10263 * som.c: Deleted references to fr, lr, ri.
10264 (som_columnate) Bux fix: sets group member of table.
10265 (som_add_options) Function removed.
10266 (dump_table) Split into three functions; extensively reworked.
10268 * descript.q: (dump_z_table) Better output table formatting; added
10269 title support to correspond to som.h changes.
10270 (display) Title support.
10272 * output.h: Added OUTP_T_NONE.
10274 Mon Jul 1 13:00:00 1996 Ben Pfaff <blp@gnu.org>
10276 * descript.q: Improved handling of Z scores; still not perfect.
10278 * output.h, ascii.c: Added hook for getting em width of current
10281 * som.c: Uses new em-width hook. Added debugging code to
10283 (som_columnate) New argument.
10284 (som_add_options) Removed.
10286 Jun 29 17:40:47 1996 Ben Pfaff <blp@gnu.org>
10288 * som.h, som.c, output.c, output.h, ascii.c: Updated to work with
10289 rules as a property of the table instead of as a property of the
10292 * ascii.c: Added `header' to table of options.
10294 * descript.q: Added even shorter statistic names; modified to work
10295 with new som interface.
10297 * misc.c (blp_getdelim): Bug fix.
10299 * version.c: includes 'conf.h'.
10301 ----------------------------------------------------------------------
10304 version-control: never
projects / pspp-builds.git / blob