Ben Pfaff [Mon, 5 Aug 2013 02:20:14 +0000 (19:20 -0700)]
Work on getting rid of trns_chain_finalize().
Ben Pfaff [Sat, 18 May 2013 22:48:44 +0000 (15:48 -0700)]
work on making transformations use relative return values
Ben Pfaff [Sat, 3 Aug 2013 23:51:31 +0000 (16:51 -0700)]
control-stack: Move from language to data directory.
Ben Pfaff [Tue, 14 May 2013 00:04:30 +0000 (17:04 -0700)]
transformations: Remove finalize functions.
Ben Pfaff [Mon, 13 May 2013 04:34:46 +0000 (21:34 -0700)]
casereader: Implement save, load.
Ben Pfaff [Fri, 10 May 2013 05:56:26 +0000 (22:56 -0700)]
case, caseproto: Implement save and load.
Ben Pfaff [Mon, 16 Feb 2015 19:24:46 +0000 (11:24 -0800)]
pxd: initial work
GET SESSION works for my simple test case
Ben Pfaff [Fri, 27 Aug 2010 05:49:53 +0000 (22:49 -0700)]
integer-format: New functions and macros for endian conversion.
Ben Pfaff [Tue, 20 Nov 2012 05:38:18 +0000 (21:38 -0800)]
hmap: Replace 'mask' by 'shift'.
Ben Pfaff [Mon, 16 Feb 2015 17:33:43 +0000 (09:33 -0800)]
doc: MATCH FILES/ADD FILES/UPDATE can combine any number of files.
Suggested by Daniel Schlieper.
John Darrington [Mon, 16 Feb 2015 08:17:12 +0000 (09:17 +0100)]
tests/math/decimal-test.c (canonicalise-string): Fix uninitialised return value
Ben Pfaff [Sun, 15 Feb 2015 22:52:11 +0000 (14:52 -0800)]
COUNT: Correct treatment of missing values.
COUNT didn't properly handle user-missing values or the MISSING
keyword. This corrects the problem.
Thanks to ftr <news.ftr@free.fr> for reporting this bug.
Bug #44157.
John Darrington [Sun, 15 Feb 2015 12:08:59 +0000 (13:08 +0100)]
Smake: Made the configure target slightly more fail safe
John Darrington [Sun, 15 Feb 2015 11:56:29 +0000 (12:56 +0100)]
Makefile rule pspp.xml: Simplify slightly
John Darrington [Sat, 14 Feb 2015 19:39:21 +0000 (20:39 +0100)]
Examine Dialog: Fix widget focus order
John Darrington [Sat, 14 Feb 2015 14:19:33 +0000 (15:19 +0100)]
Dialog boxes: Grab focus of the source widget on reset
John Darrington [Thu, 12 Feb 2015 19:38:11 +0000 (20:38 +0100)]
Minor update to documentation for FREQUENCIES
John Darrington [Mon, 9 Feb 2015 06:37:36 +0000 (07:37 +0100)]
Documentation: Tidy up notes about histogram bin widths
John Darrington [Sat, 24 Jan 2015 15:42:07 +0000 (16:42 +0100)]
Added the /BARCHART option to CROSSTABS
John Darrington [Sat, 7 Feb 2015 13:13:24 +0000 (14:13 +0100)]
tests/chart.at: -O format=csv changed to -o pspp.txt
If no output file is specified, no charts get generated. Since these
tests are "no crash only" tests, we want to exercise as much code as
possible
John Darrington [Mon, 2 Feb 2015 07:28:03 +0000 (08:28 +0100)]
Corrected typo in syntax generation for value chooser.
Closes bug #43623
John Darrington [Fri, 23 Jan 2015 18:26:26 +0000 (19:26 +0100)]
Remove untrue statement from comment
John Darrington [Fri, 23 Jan 2015 18:23:43 +0000 (19:23 +0100)]
Ensure that example_dir is relocatable.
commit
be1157c5591142920a95d587acf97f5eaf3d04fe added a reference to the
installed data directory. Unfortunately I forgot to allow for relocatable
installations. This change fixes that.
John Darrington [Thu, 22 Jan 2015 19:56:19 +0000 (20:56 +0100)]
Add examples directory "shortcut" to file_open dialog
John Darrington [Sun, 18 Jan 2015 10:43:06 +0000 (11:43 +0100)]
Frequencies: Added the /BARCHART subcommand.
John Darrington [Sun, 18 Jan 2015 14:19:10 +0000 (15:19 +0100)]
Piecharts: Avoid the segment fill obscuring the labels
John Darrington [Mon, 19 Jan 2015 15:01:06 +0000 (16:01 +0100)]
Piecharts: Remove trailing whitespace from slice labels
John Darrington [Sat, 17 Jan 2015 12:04:52 +0000 (13:04 +0100)]
Fix logic error in previous commit
John Darrington [Fri, 16 Jan 2015 13:43:48 +0000 (14:43 +0100)]
replace_file_start: On error, ensure that the appropriate errno value is held
John Darrington [Tue, 6 Jan 2015 06:25:21 +0000 (07:25 +0100)]
New module to perform decimal floating point arithmetic for charts.
This change adds a small module to perform floating point arithmetic
with a decimal base, and uses it to calculate the graticule marks for
charts.
Rationale: Graticule marks want to be displayed in decimal. However
not all decimal values can be represented in a double precision
floating point binary. This approach pushes the precision loss from
the value of the mark, to the position on the chart - we don't
particularly care if a tick mark is a fraction of a pixel out of place,
but we do care if 4.0 is displayed as 3.
9999999999
Reviewed-by: Ben Pfaff
Ben Pfaff [Thu, 15 Jan 2015 15:22:15 +0000 (07:22 -0800)]
build-aux/icon-list: Make executable.
Somehow I checked in this script as non-executable. This fixes the
problem.
Reported by Harry Thijssen.
Ben Pfaff [Mon, 12 Jan 2015 00:05:44 +0000 (16:05 -0800)]
Smake: Factor output repetitive code into new script in build-aux.
I planned to add another kind of icon but even without that change
this makes the code more readable.
John Darrington [Fri, 9 Jan 2015 08:50:42 +0000 (09:50 +0100)]
Fix minor typos in documentation
John Darrington [Wed, 7 Jan 2015 19:03:09 +0000 (20:03 +0100)]
Syntax Window: Simplify the Edit|Paste callback.
Apparently pasting into the Syntax Window under Windoze didn't work.
This change makes the EditPaste callback simpler and apparently it
fixes the problem.
Thanks to Alan Mead for reporting the problem and to Harry Thissen
for testing the fix.
John Darrington [Sat, 3 Jan 2015 14:48:35 +0000 (15:48 +0100)]
Fix compiler warnings on 64 bit machines
Ben Pfaff [Sun, 4 Jan 2015 19:14:01 +0000 (11:14 -0800)]
cairo: Remove claim that a null 'cairo' can work.
We found out in bug #43816 that it doesn't really work and isn't
worth maintaining anyhow.
Ben Pfaff [Sun, 4 Jan 2015 19:13:01 +0000 (11:13 -0800)]
psppire-output-view: Fix segfault during printing.
psppire-output-view tried to make use of a special feature in the
cairo output driver that allowed the cairo_t to be omitted to avoid
actually rendering anything, for pagination purposes, but the cairo
code had changed and this feature had not been carefully maintained,
resulting in a segfault. This commit stops trying to use that
feature, since it seems like it could easily get broken again in the
future and doesn't have much benefit anyhow.
Bug #43816.
Reported by John Darrington.
John Darrington [Sat, 3 Jan 2015 10:37:11 +0000 (11:37 +0100)]
Correct documentation example and add a corresponding test.
The tutorial section of the manual contained an example which
did not correspond to real results. This change corrects the
example and adds a test for it.
Reported-by: Robin Reeves <robin.r@hotmail.co.uk>
John Darrington [Fri, 2 Jan 2015 13:42:15 +0000 (14:42 +0100)]
Examine: Change the positioning of the whiskers on boxplots.
The positioning of the whiskers on boxplots was unconventional.
This change places the whiskers on the highest/lowest datum which
is not an outlier.
Thanks to Alan Mead for reporting this.
John Darrington [Mon, 29 Dec 2014 08:31:48 +0000 (09:31 +0100)]
Factor: fix memory leaks relating to PROMAX and update NEWS
Ben Pfaff [Sun, 28 Dec 2014 16:49:50 +0000 (08:49 -0800)]
factor: Comment out unused functions.
Ben Pfaff [Sun, 28 Dec 2014 16:49:36 +0000 (08:49 -0800)]
configure: Drop -Wdeclaration-after-statement.
We keep getting new instances of this warning in the tree, and it's
not really necessary these days since even MSVC supports mid-block
declarations now.
Ben Pfaff [Sun, 28 Dec 2014 16:46:49 +0000 (08:46 -0800)]
doc: Document pspp-dump-sav.
Requested by Harry Thijssen.
Bug #43857.
John Darrington [Fri, 19 Dec 2014 10:30:17 +0000 (11:30 +0100)]
Add some entries to .gitignore
John Darrington [Thu, 18 Dec 2014 14:37:22 +0000 (15:37 +0100)]
FACTOR: Added PROMAX rotation.
John Darrington [Sun, 14 Dec 2014 00:51:44 +0000 (01:51 +0100)]
File Export: Added a "plain text" option.
In the File|Export menu of the output window, enabled unicode box characters for
the "Text" output, and added a "Text (plain)" menuitem without this feature.
Ben Pfaff [Mon, 8 Dec 2014 06:36:36 +0000 (22:36 -0800)]
doc: Add section on how to exit PSPP to the tutorial.
Daniel Schlieper reported that he had trouble figuring out how to
exit. The FINISH command was already documented, but it wasn't
mentioned in the tutorial, so perhaps this will help.
Bug #43766.
Ben Pfaff [Mon, 8 Dec 2014 06:34:21 +0000 (22:34 -0800)]
command: Fix delayed execution of FINISH.
PSPP delayed the execution of FINISH until it read the first token
of the next command. This commit changes it to execute immediately,
as one would expect..
Reported by Daniel Schlieper.
Bug #43766.
Daniel Schlieper [Mon, 8 Dec 2014 06:17:30 +0000 (22:17 -0800)]
command: Add STEMLEAF to list of unimplemented commands.
Ben Pfaff [Mon, 8 Dec 2014 06:13:44 +0000 (22:13 -0800)]
README.Git: Upgrade recommended Gnulib version.
Harry Thijssen reported that the older version of Gnulib failed to
build (in msvc-inval.c) on Windows, but that the newer version built
fine with the exception of the error that should have been fixed by
the previous commit.
Discussion at:
http://lists.gnu.org/archive/html/pspp-dev/2014-12/msg00014.html
Ben Pfaff [Mon, 8 Dec 2014 06:10:54 +0000 (22:10 -0800)]
lexer: Include <unistd.h> to ensure 'read' is consistently replaced.
On some platforms, Gnulib #defines read to rpl_read. The lexer uses
an unreleated function pointer member named 'read' in struct
lex_reader_class. It doesn't really matter whether this name gets
replaced with rpl_read as long as it always happens consistently.
Adding "#include <unistd.h>" to lexer.h should ensure that.
Reported by Harry Thijssen.
Ben Pfaff [Mon, 8 Dec 2014 05:32:40 +0000 (21:32 -0800)]
tests: Fix unintended platform dependency in portable file test.
Reported by Jeremy Lavergne.
Daniel Schlieper [Sun, 7 Dec 2014 17:31:34 +0000 (09:31 -0800)]
doc: Describe how bin sizes are chosen for histograms.
John Darrington [Fri, 5 Dec 2014 10:53:13 +0000 (11:53 +0100)]
FREQUENCIES: Fix bug when combining HISTOGRAM with PERCENTILES.
This bug was reported only on windows, but had the potential to
affect any system.
Thanks to "Dr. Yaron Ghilay" <gy21@inter.net.il> for reporting
the bug, and to Kai.Borgolte@gmx.de for diagnosing it.
Ben Pfaff [Sun, 30 Nov 2014 21:19:05 +0000 (13:19 -0800)]
FREQUENCIES: Allow percentiles to be comma-separated.
Reported by Dr. Yaron Ghilay.
Ben Pfaff [Sat, 29 Nov 2014 20:03:06 +0000 (12:03 -0800)]
po: Add Polish translation.
Ben Pfaff [Sat, 29 Nov 2014 19:56:15 +0000 (11:56 -0800)]
Add support for weighting variables in SPSS/PC+ system files.
Based on a file provided by Alan Mead.
Ben Pfaff [Sat, 29 Nov 2014 05:16:23 +0000 (21:16 -0800)]
Add support for reading SPSS/PC+ system files.
Thanks to Alan Mead for supplying most of the files in the corpus used to
determine the SPSS/PC+ system file format.
Ben Pfaff [Sat, 15 Nov 2014 18:36:32 +0000 (10:36 -0800)]
po: Update translations from translationproject.org.
John Darrington [Wed, 29 Oct 2014 15:22:05 +0000 (16:22 +0100)]
Documentation: Add some comments to the bugs chapter
Ben Pfaff [Tue, 4 Nov 2014 16:28:59 +0000 (08:28 -0800)]
po: Add Galician translation.
John Darrington [Tue, 28 Oct 2014 15:21:02 +0000 (16:21 +0100)]
FREQUENCIES: Fixed crash when there was no valid data
John Darrington [Tue, 28 Oct 2014 16:39:27 +0000 (17:39 +0100)]
GRAPH: Use complete strings instead of constructing them
This makes life easier for the translators.
Ben Pfaff [Sat, 25 Oct 2014 16:32:35 +0000 (09:32 -0700)]
po: Update translations from translationproject.org.
Ben Pfaff [Sat, 18 Oct 2014 19:11:34 +0000 (12:11 -0700)]
cairo: Add .5pt gutter around table rules.
Commit
d3fef25674baf4f4 (output: Add footnote support.) removed the 3-pt
gutter around table rules, instead putting a margin around cell contents.
This usually worked out fine, but for some tables in the GUI it caused the
rightmost rule in the table to disappear. This is probably some kind of
off-by-one error in table size computation or clipping. We may have to
eventually resolve that. However, this commit seems like an adequate
temporary fix: instead of fixing the off-by-one error, add a thin gutter
around the rules, so that the actual content of the rule doesn't get
clipped off.
Ben Pfaff [Sat, 18 Oct 2014 19:06:11 +0000 (12:06 -0700)]
pspp-dev.texi: Add authors as @author arguments.
With a blank @author, makeinfo complains.
Without @author at all, the title page in TeX output looks funny.
So this commit simply names the authors, as determined by "git log" on
the doc/dev directory.
Ben Pfaff [Sat, 18 Oct 2014 17:38:53 +0000 (10:38 -0700)]
psppire-output-view: Properly render the first few items of output.
Commit
18f9e37c8bc5 (psppire-output-view: Only render output items once the
window is realized.) fixed a crashing bug, but when I tested it I didn't
carefully look at the output. In fact, any output items that were rendered
before the window was realized were not displayed, because the widgets
created for them were never shown or properly initialized. This commit
fixes the problem.
Reported by Adam Zammit.
Bug #43362.
John Darrington [Sat, 18 Oct 2014 06:30:10 +0000 (08:30 +0200)]
FREQUENCIES: Fix the default /STATISTICS.
The subcommand /STATISTICS (with nothing following) should be the same as /STATISTICS = DEFAULT.
John Darrington [Sat, 18 Oct 2014 06:56:56 +0000 (08:56 +0200)]
Frequencies.c: Use BIT_INDEX (FRQ_ST_MEDIAN) instead of FRQ_ST_MEDIAN.
Closes bug #43427
Ben Pfaff [Sun, 12 Oct 2014 16:49:49 +0000 (09:49 -0700)]
DISPLAY: Fix crash bugs in DISPLAY INDEX and DISPLAY NAMES.
Bug #43365.
Thanks to Mindaugus for reporting this bug.
Ben Pfaff [Thu, 9 Oct 2014 05:39:18 +0000 (22:39 -0700)]
psppire-output-view: Only render output items once the window is realized.
Otherwise, in environments where the output view is not rendered
immediately upon the call to gtk_widget_show_all() from
psppire_output_submit(), psppire_output_view_put() called later in that
function would dereference a null pointer trying to create a rendering
from a null GTK_WIDGET (view->output)->window.
Bug #43362.
Ben Pfaff [Tue, 7 Oct 2014 15:20:46 +0000 (08:20 -0700)]
Updated localisations from translation-project.org.
Friedrich Beckmann [Sun, 5 Oct 2014 20:07:23 +0000 (22:07 +0200)]
gui: Set StartupNotify=false because Startup Notification does not work.
Ben Pfaff [Sat, 4 Oct 2014 18:01:16 +0000 (11:01 -0700)]
po: Update translations from translationproject.org.
Friedrich Beckmann [Tue, 30 Sep 2014 07:57:04 +0000 (09:57 +0200)]
doc: Add PSPPIRE manpage, add example to manpages, install manpages.
Friedrich Beckmann [Sun, 28 Sep 2014 23:46:07 +0000 (16:46 -0700)]
render-test: Fix invocation of tab_footnote().
Fixes this GCC warning:
tests/output/render-test.c: In function ‘read_table’:
tests/output/render-test.c:491:19: error: format not a string literal and
no format arguments [-Werror=format-security]
Ben Pfaff [Sun, 28 Sep 2014 16:38:26 +0000 (09:38 -0700)]
po: Update translations from translationproject.org.
Friedrich Beckmann [Sun, 28 Sep 2014 04:32:17 +0000 (21:32 -0700)]
Add GRAPH command initially with just scatterplots and histograms.
Ben Pfaff [Sun, 28 Sep 2014 04:23:33 +0000 (21:23 -0700)]
doc: Add --enable-silent-rules support to more targets.
Ben Pfaff [Sat, 27 Sep 2014 22:24:51 +0000 (15:24 -0700)]
Update to version 0.8.4.
Ben Pfaff [Sat, 27 Sep 2014 16:24:25 +0000 (09:24 -0700)]
Update to newer texinfo.tex.
Ben Pfaff [Sat, 27 Sep 2014 16:23:54 +0000 (09:23 -0700)]
configure: Change the way we work around missing $(AM_V_P).
The existing approach didn't work because AM_V_P was introduced after
AM_SILENT_RULES.
Ben Pfaff [Sat, 27 Sep 2014 04:40:52 +0000 (21:40 -0700)]
Makefiles: Support --enable-silent-rules for one more target.
Ben Pfaff [Sat, 27 Sep 2014 04:21:51 +0000 (21:21 -0700)]
Makefiles: Make most of the handwritten rules support --enable-silent-rules.
Ben Pfaff [Sat, 27 Sep 2014 03:55:02 +0000 (20:55 -0700)]
gui: Suppress compiler warning for call to deprecated g_thread_init().
Ben Pfaff [Sat, 27 Sep 2014 03:45:42 +0000 (20:45 -0700)]
doc: Rename .texinfo files to use .texi extension.
Newer versions of Automake complained that the .texinfo extension was
deprecated.
Ben Pfaff [Sat, 27 Sep 2014 03:40:50 +0000 (20:40 -0700)]
configure: Allow --enable-silent-rules when Automake supports it.
I personally find this makes the build easier to follow.
John Darrington [Sat, 20 Sep 2014 21:04:32 +0000 (23:04 +0200)]
Added Turkish localisation
Ben Pfaff [Tue, 16 Sep 2014 03:56:20 +0000 (20:56 -0700)]
FREQUENCIES: Fix treatment of string variables.
Reported by Richard Lee Rogers on pspp-users:
http://lists.gnu.org/archive/html/pspp-users/2014-09/msg00003.html
Ben Pfaff [Tue, 16 Sep 2014 03:36:05 +0000 (20:36 -0700)]
output: Add support for captions.
This brings the output format a small step closer to the SPSS output model,
which has separate title and caption for tables.
Ben Pfaff [Sun, 14 Sep 2014 19:35:53 +0000 (12:35 -0700)]
render: Fix bug in render_pager_draw_region().
This bug, introduced in commit
f1db96caae4 (ender: Fold caption drawing
into rendering engine.), could cause the title and body of a table to be
drawn overlapping.
Ben Pfaff [Sun, 14 Sep 2014 00:57:12 +0000 (17:57 -0700)]
doc: Update documentation to match renaming of captions to titles.
Ben Pfaff [Sat, 13 Sep 2014 23:55:19 +0000 (16:55 -0700)]
output: Rename caption to title.
This brings PSPP a small step closer to the table model that SPSS uses,
which allows for a brief title above the table and a more verbose caption
below it.
Ben Pfaff [Sat, 13 Sep 2014 23:41:08 +0000 (16:41 -0700)]
output: Add footnote support.
The initials support for footnotes does not allow the client to specify
the markers and does not merge footnotes with the same text so that they
have the same markers. It might be necessary to implement one or both of
those features.
The footnote feature doesn't have any users yet, outside of the tests.
Ben Pfaff [Mon, 8 Sep 2014 04:05:09 +0000 (21:05 -0700)]
render: Fold caption drawing into rendering engine.
This factors code out of the individual drivers.
Ben Pfaff [Sun, 7 Sep 2014 18:22:35 +0000 (11:22 -0700)]
render: Render table_items instead of tables.
A table_item includes the caption, which future commits will want to have
render_pager render, so the table_item is a more natural target.
Ben Pfaff [Sat, 13 Sep 2014 17:39:38 +0000 (10:39 -0700)]
render: Push all rendering, not just pagination, into render_pager.
In future commits this will allow adding support for rendering captions and
(to be introduced) footnotes in render_pager.
Ben Pfaff [Sat, 13 Sep 2014 17:24:59 +0000 (10:24 -0700)]
render: Introduce render_pager to factor out code from drivers.
The render_break abstraction requires quite a bit of assistance from
drivers. By introducing a high-level render_pager abstraction we factor
out a bit of common code. Future refinements will allow putting more and
more functional in the common "render" interface.
Ben Pfaff [Mon, 8 Sep 2014 06:02:03 +0000 (23:02 -0700)]
str: Make str_format_26adic() able to use lowercase.
The output engine will use lowercase for footnote markers.
Ben Pfaff [Sat, 13 Sep 2014 18:04:45 +0000 (11:04 -0700)]
RUNS: Correct calculation of significance.
Reported by Douglas Bonett <dgbonett@ucsc.edu>.