Ben Pfaff [Sat, 16 Nov 2013 04:32:28 +0000 (20:32 -0800)]
psppire-data-window: Set default filter in File|Save As to show all files.
The File|Save As dialog box showed "System Files" in two places: in the
filter dropdown and in the format dropdown. It was surprising to users
that changing the filter dropdown had no effect on the format of the file
actually saved. This commit makes it more obvious which dropdown needs to
be changed, by only showing "System Files" in the right place.
Ben Pfaff [Fri, 15 Nov 2013 00:41:32 +0000 (16:41 -0800)]
render-test: Render to PDF only if --pdf specified on command line.
Difference in font metrics on Guix lead to errors trying to render to PDF
in some tests. The tests don't actually check anything in the PDF output
so we might as well just leave that for manual testing. Adding an option
accomplishes that well enough.
Reported by Andreas Enge.
Root caused discovered by John Darrington.
Bug #40213.
Ben Pfaff [Sun, 20 Oct 2013 16:44:09 +0000 (09:44 -0700)]
i18n: Make recode_substring_pool() always return a pool_malloc()'d string.
recode_substring_pool() generally returned a string allocated by
pool_malloc(), but when there was an error finding the converter it
returned a string that was allocated by pool_alloc(). This was a problem
for parse_value_labels() in the system file reader, because that function
frees all the strings it recodes. This commit fixes the problem by
always using pool_malloc() in recode_substring_pool().
Ben Pfaff [Sun, 20 Oct 2013 16:36:26 +0000 (09:36 -0700)]
csv-file-writer: Use comma as default delimiter.
The previous default delimiter was a null byte, which isn't reasonable.
(This didn't manifest anywhere because the only existing user of the
CSV file writer always overrides the default.)
Ben Pfaff [Wed, 23 Oct 2013 05:13:30 +0000 (22:13 -0700)]
por-file-writer: Rename 'fv' member to 'case_index'.
'fv' used to be used throughout the tree to refer to the first of possibly
several sequential indexes into a case, but it is now obsolescent. The
term 'case_index' is now widely used.
Ben Pfaff [Tue, 8 Oct 2013 03:40:24 +0000 (20:40 -0700)]
comments-dialog: Avoid segfault in comments dialog pasting very long text.
The code in wrap_line() used a GtkTextIter after an insertion invalidated
it. In some setups, with a sufficiently long pasted text, this caused a
Gtk-WARNING and a subsequent segfault. This commit fixes the problem by
removing the offending code. In my testing, this didn't cause a UI
regression.
Reported by Bastián Díaz in the thread starting at
http://lists.gnu.org/archive/html/bug-gnu-pspp/2013-10/msg00005.html
Bastián Díaz [Sun, 6 Oct 2013 22:21:18 +0000 (19:21 -0300)]
Provisional new image is added for univariate analysis.
Added a provisional icon to the univariate analysis (experimental).
The image will be updated to a new icon in the next update of
artwork (0.2.1 version).
Changes:
*analyze-univariate-analysis is added
*Smake is edited
*data-editor.ui is edited
John Darrington [Wed, 2 Oct 2013 13:14:15 +0000 (15:14 +0200)]
Replace checkbox-treeview functions with a object PsppireCheckboxTreeview
Prior to this change there existed a function which operated on
a GtkTreeView which populated it with a model and renderers such
that it would display a list of annotated checkboxes.
This change subclasses GtkTreeView and moves the function to a
method of that class.
I anticipate this will ease implementation of upcoming functionality.
John Darrington [Tue, 1 Oct 2013 07:36:06 +0000 (09:36 +0200)]
Detect absence of rl_outstream and handle accordingly.
Older versions of readline do not appear to have the variable rl_outstream. This variable,
almost certainly points to the same stream as stdout, so this change detects its absence
and uses stdout in those cases.
gui: Support for more flat icons and tag loss fixing in some menus.
→ Icons for "new syntax", "new data", "Display information in working
file and external file are added.
→ Add the reference to the new icons to Smake an *.ui files
→ Replacement of some icons (bug fixes)
It improves the esthetics and visual definition of application icon in different sizes of canvas, and adds a scalable version for desktop environments that use that value.
Ben Pfaff [Mon, 30 Sep 2013 07:12:35 +0000 (00:12 -0700)]
variable: Complete renaming of ROLE_OUTPUT to ROLE_TARGET.
Commit 47d59628a7d51a (psppire-var-sheet: Rename references to the icons
for align, measure and role icons) renamed some but not all uses of
ROLE_OUTPUT, breaking the build. This commit completes the rename.
According to Bastián Díaz, "target" is better than "output" because it
is "a broader concept for function".
Ben Pfaff [Mon, 30 Sep 2013 02:11:41 +0000 (19:11 -0700)]
sys-file-reader: Add support for long string missing values.
I assumed earlier that long string missing values used the same fields in
the system file as other missing values, but I was wrong. This commit
updates the support to match what I've seen in actual system files.
Reported by Przemek Powalko <pp.alter.ego@gmail.com>.
Ben Pfaff [Mon, 30 Sep 2013 01:55:38 +0000 (18:55 -0700)]
missing-values: Make mv_add_str() easier to use.
Both existing callers of mv_add_str() were applying their own padding to
the string value. This commit moves the padding into mv_add_str() itself.
This commit also fixes a minor to-do item in the MISSING VALUES command
whereby truncation of too-long missing values was done bytewise rather than
on the basis of full characters.
Ben Pfaff [Sat, 28 Sep 2013 23:26:08 +0000 (16:26 -0700)]
psppire-data-store: Don't try to parse strings as custom currency formats.
Custom currency formats are not usable for input, only for output, but this
code tried to use them for input if the format was changed to a custom
currency format in the GUI. This commit fixes the problem by using a
DOLLAR format, instead, for parsing.
Reported by Bastián Díaz <diaz.bastian@ymail.com>.
Ben Pfaff [Sat, 28 Sep 2013 23:03:32 +0000 (16:03 -0700)]
variable: Only notify variable width change if it really did change.
This code was notifying a width change every time, even if the width did
not really change, which is wasteful. This had a side effect of revealing
a bug in the GUI code which caused an assertion failure. The bug still
remains in the GUI code, though it is now slightly harder to trigger, and
will be fixed separately in an upcoming commit.
John Darrington [Sat, 28 Sep 2013 06:12:53 +0000 (08:12 +0200)]
Documentation: Explain locale issues in the tutorial.
Mention that explicitly setting the input format is necessary if the user wishes
to ignore the system's LC_NUMERIC setting. Otherwise, following the tutorial
strictly to the letter will result in confusing for users whose locale uses a
comma as the decimal separator.
projects / pspp / log