Ben Pfaff [Wed, 16 Jun 2010 04:30:12 +0000 (21:30 -0700)]
pspp: Mark the pspp --help text as translatable.
Ben Pfaff [Wed, 16 Jun 2010 04:29:50 +0000 (21:29 -0700)]
psppire: Re-implement --help and --version options.
Commit
f51ecb4802 "Greatly simplify PSPP configuration." accidentally
removed PSPPIRE support for the --help and --version options. This commit
restores it (and improves upon the text previously displayed).
Ben Pfaff [Wed, 16 Jun 2010 03:41:12 +0000 (20:41 -0700)]
Do not treat isolated CR in input data as new-line.
User "tvw" on IRC reported that PSPP failed to parse data that SPSS 18
accepted. We found that the problem was carriage return (CR) characters
in the middle of a line. PSPP treated these as new-lines, but SPSS did
not. This commit adopts the SPSS behavior in PSPP and adjusts one test
that checks this behavior.
This will break reading some old Mac OS files, since Mac OS before version
10 used CR without LF as new-line. Time will tell whether this is a real
problem for our users.
John Darrington [Tue, 15 Jun 2010 18:31:02 +0000 (20:31 +0200)]
Remove unused functions make_temp_file and make_unique_file_stream
Ben Pfaff [Sat, 12 Jun 2010 03:40:35 +0000 (20:40 -0700)]
tests: Fix test failures in calendar and expressions tests.
Ben Pfaff [Fri, 11 Jun 2010 04:31:59 +0000 (21:31 -0700)]
tmpfile: Rename "struct tmpfile" to "struct temp_file".
Mingw builds were failing because Gnulib was replacing "tmpfile" by
"rpl_tmpfile", and this was visible only to some users of "struct tmpfile".
The safest fix seems to be just renaming struct tmpfile, so that's what
this commit does.
Thanks to Harry Thijssen <pspp@sjpaes.nl> for reporting the problem.
Bug #29965.
John Darrington [Wed, 9 Jun 2010 19:50:10 +0000 (21:50 +0200)]
Remove unnecessary translatiosn of stock items.
Stock items have their own translations, so it's counter
productive to ask pspp's translators to re-translate them
without good reason.
John Darrington [Wed, 9 Jun 2010 18:22:43 +0000 (20:22 +0200)]
perl-module/Makefile.PL: Change DLEXT to SO
Apparently the former is for dynamically loaded modules,
whereas the latter is for shared libraries. So SO is
appropriate here. Thanks to Jeremy Lavergne for reporting
this.
Ben Pfaff [Wed, 9 Jun 2010 17:26:55 +0000 (10:26 -0700)]
README.Git: Update to latest Gnulib.
The newest Gnulib fixes problems building the relocation wrapper used on
some OSes (e.g. OpenBSD) when PSPP is configured with --enable-relocatable.
Ben Pfaff [Wed, 9 Jun 2010 17:10:03 +0000 (10:10 -0700)]
configure.ac: Do not define DEPENDS_ON_LIBINTL.
If <config.h> defines DEPENDS_ON_LIBINTL, then the relocation wrapper fails
to link at install time when --enable-relocatable is used on a system that
requires the relocation wrapper (e.g. OpenBSD), because the relocation
wrapper does not link against libintl.
Ben Pfaff [Wed, 9 Jun 2010 04:36:51 +0000 (21:36 -0700)]
inexactify: #include <config.h>
This fixes a problem with redefined "struct option" under OpenBSD 4.7.
Ben Pfaff [Tue, 8 Jun 2010 05:57:26 +0000 (22:57 -0700)]
Smake: Don't create .cvsignore files.
Clearly these files aren't useful anymore, since we no longer use CVS.
Ben Pfaff [Tue, 8 Jun 2010 16:36:08 +0000 (09:36 -0700)]
gui: Fix permissions when creating configuration directory.
http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html says
that the configuration directory should have mode 0700, so use that.
Reported by John Darrington.
Ben Pfaff [Tue, 8 Jun 2010 04:45:33 +0000 (21:45 -0700)]
gui: Create user settings directory if it doesn't already exist.
The user settings directory doesn't necessarily exist. Some program has to
create it, and PSPPIRE might be the first program that wants it, so it
should try to create it.
Discovered on OpenBSD.
Ben Pfaff [Tue, 8 Jun 2010 04:42:25 +0000 (21:42 -0700)]
po: Avoid passing nonportable -D option to "install" program.
OpenBSD "install" and "install-sh" distributed with Autoconf do not
support -D, so we should not try to use it.
Ben Pfaff [Sun, 6 Jun 2010 19:45:01 +0000 (12:45 -0700)]
DEBUG EVALUATE: Eliminate lexical corner case, rewrite tests in Autotest.
The DEBUG EVALUATE command, used only for testing, used the
lex_rest_of_line() function. I'd like to eventually get rid of all of the
uses of this function and other unusual lexical corner cases, so this
commit starts off by removing this one.
Ben Pfaff [Sun, 6 Jun 2010 19:23:33 +0000 (12:23 -0700)]
expressions: Improve error message for bad quarter argument to DATE.QYR.
The error message issued by DATE.QYR for an invalid "quarter" argument
referred instead to a "month" value. This makes the error message more
understandable.
Ben Pfaff [Sun, 6 Jun 2010 19:19:19 +0000 (12:19 -0700)]
expressions: Improve error messages evaluating invalid Boolean values.
The error message used for an invalid Boolean value was terribly generic.
This commit adds the name of the operator to the error message.
Ben Pfaff [Sun, 6 Jun 2010 19:14:19 +0000 (12:14 -0700)]
expressions: Don't abbreviate "number" as "num" in error messages.
Ben Pfaff [Sun, 6 Jun 2010 19:41:08 +0000 (12:41 -0700)]
expressions: Improve "type mismatch" error messages from expression parser.
Before this commit, type mismatches invoking functions in expressions would
yield confusing error messages due to missing type names, e.g.:
Type mismatch invoking MISSING(number) as missing(string).
This commit fills in the missing type names:
Type mismatch invoking MISSING(number) as missing().
An upcoming commit will start checking error messages as part of the tests
for expressions, which should ensure that the problem does not recur.
Ben Pfaff [Sun, 6 Jun 2010 19:43:10 +0000 (12:43 -0700)]
MOMENTS: Avoid lexical corner case in test case.
The DEBUG MOMENTS command, used only for testing, used the
lex_rest_of_line() function. I'd like to eventually get rid of all of the
uses of this function and other unusual lexical corner cases, so this
commit starts off by removing this one.
Ben Pfaff [Thu, 3 Jun 2010 05:02:42 +0000 (22:02 -0700)]
pspp: Add --no-output option to allow entirely disabling output.
John Darrington [Fri, 4 Jun 2010 07:15:12 +0000 (09:15 +0200)]
en_GB.po: Attended to fuzzy entries
John Darrington [Wed, 2 Jun 2010 08:32:38 +0000 (10:32 +0200)]
Fix memory leak in casewriter_make_reader.
The proto member was not being unrefed when it should have been.
Reviewed by Ben Pfaff.
Ben Pfaff [Sat, 29 May 2010 21:16:14 +0000 (14:16 -0700)]
gui: Speed up rendering of large tables that are only partly visible.
Ben Pfaff [Sat, 29 May 2010 03:35:28 +0000 (20:35 -0700)]
Remove 255-byte limit on the length of literal strings.
I don't see a reason for this restriction. I think it must date to before
support for 32767-byte string variables.
Problem reported by Dr Eberhard W Lisse <el@lisse.NA>.
John Darrington [Fri, 28 May 2010 11:49:43 +0000 (13:49 +0200)]
Fix inconsistent label positions on piecharts.
The labels of piechart slices did not match the positions
of the slices (possibly due to libplot legacy). This
change fixes this problem.
John Darrington [Thu, 27 May 2010 14:33:44 +0000 (16:33 +0200)]
Documentation: Added concept indices for various charts
John Darrington [Thu, 27 May 2010 14:29:10 +0000 (16:29 +0200)]
Added some very rudimentary tests for charts.
Currently, all these tests do is ensure that the syntax which
should generate charts, can run without crashing. More
rigourous tests should be added in the future, when the infrastructure
allows.
John Darrington [Thu, 27 May 2010 14:11:58 +0000 (16:11 +0200)]
Be more forgiving about ROC syntax
John Darrington [Thu, 27 May 2010 14:10:08 +0000 (16:10 +0200)]
Fix crash on erroneous ROC input
John Darrington [Wed, 26 May 2010 20:14:10 +0000 (22:14 +0200)]
Create the detrended np plot instead of a second normal one
John Darrington [Wed, 26 May 2010 20:02:39 +0000 (22:02 +0200)]
Removed uninitialised variable.
Removed an uninitialised variable which was being
dereferenced and hence crashing.
Ben Pfaff [Sun, 18 Oct 2009 00:12:58 +0000 (17:12 -0700)]
Fix tests/command/sample.sh test on Mingw.
On Mingw pspp.list contains CR-LF line ends, so the "grep" command to
skip blank lines needs to allow for that.
Ben Pfaff [Sun, 18 Oct 2009 00:12:19 +0000 (17:12 -0700)]
Fix tests/formats/num-out.sh test on Mingw.
inexactify needs an .exe extension on Mingw.
Ben Pfaff [Sat, 17 Oct 2009 23:57:42 +0000 (16:57 -0700)]
Fix Mingw test failures due to differences in line endings.
This commit changes "diff" invocations to ignore changes in white space to
avoid spurious test failures due to differences in line endings.
Ben Pfaff [Sat, 17 Oct 2009 23:46:21 +0000 (16:46 -0700)]
Fix get-data-txt-importcases.sh test on Mingw.
On Mingw, ftell() and ftello() are unreliable when used on text files with
plain LF line endings:
http://article.gmane.org/gmane.comp.gnu.m4.bugs/2224
This made the get-data-txt-importcases.sh test fail, because
dfm_get_percent_read() that it depends upon to determine the percentage of
the file that has been read uses ftello(). The solution is to always open
the text file as a binary file. According to my audit of the ways that
the text file is read, this should not cause other problems. In
particular, ds_read_line() handles both LF and CR-LF line endings. But it
cannot handle negative effects on Unix platforms anyway, since they do not
distinguish text and binary modes.
Ben Pfaff [Wed, 26 May 2010 05:06:57 +0000 (22:06 -0700)]
Add $EXEEXT to names of binaries executed in tests.
This makes "make check" work much better when building for Windows with
the mingw cross-compiler suite.
Ben Pfaff [Tue, 13 Oct 2009 05:10:55 +0000 (22:10 -0700)]
Move auxiliary files used for build into "build-aux" directory.
This reduces clutter in the root directory of the PSPP distribution. It
is common practice for GNU software these days.
Ben Pfaff [Wed, 26 May 2010 04:46:23 +0000 (21:46 -0700)]
perl-module: Copy perl-module files if missing as well as if changed.
I don't know why the behavior here changed, because I don't see any changes
that would cause the problem, but at least the new version makes equal
sense.
Ben Pfaff [Wed, 26 May 2010 03:42:19 +0000 (20:42 -0700)]
po: Update Dutch translation.
Thanks to the Dutch translation team and the translationproject.org
coordinators.
John Darrington [Tue, 25 May 2010 08:53:53 +0000 (10:53 +0200)]
Output viewer: Guess file type from filename suffix.
When choosing File|Export in the output viewer,
the dialog box now guesses the desired file format
based upon the given filename suffix.
Closes bug #29867
John Darrington [Mon, 24 May 2010 13:28:18 +0000 (15:28 +0200)]
Use gtk stock item instead of a custom one
John Darrington [Mon, 24 May 2010 13:19:29 +0000 (15:19 +0200)]
Fix compiler warnings
John Darrington [Mon, 24 May 2010 10:09:11 +0000 (12:09 +0200)]
Added remaining relevant unicode box characters
John Darrington [Mon, 24 May 2010 09:41:01 +0000 (11:41 +0200)]
Entered some extra unicode box chars in the table
John Darrington [Mon, 24 May 2010 08:22:20 +0000 (10:22 +0200)]
Call expand all on Edit->SelectAll
Expand the treeview widget before calling
select_all, since this is probably what the
user wants.
John Darrington [Mon, 24 May 2010 08:19:51 +0000 (10:19 +0200)]
Added an ODT target to the output viewer clipboard
John Darrington [Mon, 24 May 2010 07:50:50 +0000 (09:50 +0200)]
Added a SelectAll menuitem to the output viewer
John Darrington [Mon, 24 May 2010 07:34:00 +0000 (09:34 +0200)]
Add html target to output viewer clipboard
John Darrington [Mon, 24 May 2010 07:21:22 +0000 (09:21 +0200)]
Added basic clipboard functionality to the output viewer.
This version only allows pasting to text and utf8 targets.
John Darrington [Mon, 24 May 2010 06:19:59 +0000 (08:19 +0200)]
Replace LDFLAGS setting inadvertently removed by commit
3fac2920b97a068e156c376afd05583b481801ac
John Darrington [Sun, 23 May 2010 15:37:36 +0000 (17:37 +0200)]
Added a GTK_STOCK_INFO icon to the file information menu
John Darrington [Sun, 23 May 2010 15:31:01 +0000 (17:31 +0200)]
Use meaningful identifier for the Edit|Copy action
John Darrington [Sun, 23 May 2010 08:58:13 +0000 (10:58 +0200)]
Update required versions of the GSL and GTK libraries
Ben Pfaff [Sat, 22 May 2010 18:33:48 +0000 (11:33 -0700)]
sys-file-reader: Fix reading overlong value labels for long string variables.
Commit
6b562f8a8 "Add support for value labels on long string variables"
that added support for reading value labels for long string variables from
system files had a logic error in dealing with too-long label strings: the
sign of the subtraction was reversed.
Problem reported by Michel Boaventura <michel@michelboaventura.com>.
Ben Pfaff [Sat, 22 May 2010 18:28:51 +0000 (11:28 -0700)]
dissect-sysfile: Eliminate harmless GCC warning.
Ben Pfaff [Sat, 22 May 2010 18:28:18 +0000 (11:28 -0700)]
dissect-sysfile: Allow padding compressed data at end of file without error.
Compressed data in a system file can end either with a special opcode or
by padding out the last set of opcodes to an 8-byte boundary with null
bytes. Until now, dissect-sysfile has complained about last with
"unexpected end of file". This commit fixes the problem.
Ben Pfaff [Sat, 22 May 2010 18:24:48 +0000 (11:24 -0700)]
dissect-sysfile: Properly interpret padding bytes in compressed data.
Ben Pfaff [Fri, 21 May 2010 23:44:18 +0000 (16:44 -0700)]
configure.ac: Increase version number to 0.7.5 for translationproject.
translationproject.org needs a version number increment to submit a new
pspp.pot.
Jason H Stover [Fri, 21 May 2010 16:02:56 +0000 (12:02 -0400)]
Removed unused function
John Darrington [Fri, 21 May 2010 15:33:00 +0000 (17:33 +0200)]
Removed src/math/coefficient.[ch] which are no longer used
John Darrington [Fri, 21 May 2010 14:08:46 +0000 (16:08 +0200)]
Fix problem opening files with non-ascii names on Windows
John Darrington [Fri, 21 May 2010 11:11:04 +0000 (13:11 +0200)]
Fix crash on Windows when calculating a covariance matrix of dimension 1.
Calculating a covariance matrix on a single variable crashed under Windows.
This change fixes that. It also prevents GUI users from attempting to
perform a correlation with only one variable, since if they are trying to
do that, then the have probably made a mistake.
John Darrington [Fri, 21 May 2010 11:03:03 +0000 (13:03 +0200)]
Revert "Removed src/math/interaction.[ch] which has been superseded by categoricals.[ch]"
This reverts commit
a456c361c0d324475da63d8420a2f0b108b61243.
It's still needed after all.
John Darrington [Fri, 21 May 2010 10:32:53 +0000 (12:32 +0200)]
Removed src/math/interaction.[ch] which has been superseded by categoricals.[ch]
John Darrington [Fri, 21 May 2010 10:22:51 +0000 (12:22 +0200)]
Merge commit 'origin/covariance'
Conflicts:
src/data/dictionary.c
src/language/stats/correlations.c
src/language/stats/regression.q
src/math/automake.mk
John Darrington [Fri, 21 May 2010 08:07:02 +0000 (10:07 +0200)]
Added brief documentation about the FACTOR command's rotation feature
John Darrington [Fri, 21 May 2010 07:59:30 +0000 (09:59 +0200)]
Implemented a rotations subdialog for the FACTOR command
John Darrington [Thu, 20 May 2010 15:32:31 +0000 (17:32 +0200)]
Added ROTATION to this list of default tables
Ben Pfaff [Fri, 21 May 2010 04:56:48 +0000 (21:56 -0700)]
sys-file-reader: Variable attributes record uses long variable names.
Michel Boaventura provided a system file for which PSPP complained about
bad variable attributes records. I found out that this was because the
variables were specified using long names, not short names. This commit
allows PSPP to read these variable attributes properly.
Ben Pfaff [Fri, 21 May 2010 04:54:56 +0000 (21:54 -0700)]
sys-file-reader: Tolerate variable labels longer than 255 bytes.
Michel Boaventura provided a system file with a 256-byte variable label
that PSPP rejected. This commit allows it to be read.
John Darrington [Thu, 20 May 2010 15:04:03 +0000 (17:04 +0200)]
Updated tests to take account of factor rotations
John Darrington [Thu, 20 May 2010 14:26:53 +0000 (16:26 +0200)]
Added proper convergence criteria for rotation phase
John Darrington [Thu, 20 May 2010 13:36:21 +0000 (15:36 +0200)]
Print the rotated sums of squared loadings
John Darrington [Thu, 20 May 2010 12:41:32 +0000 (14:41 +0200)]
First working version with Factor Rotations
John Darrington [Thu, 20 May 2010 15:15:18 +0000 (17:15 +0200)]
Update manual's licence to FDL 1.3
The copyright notice said that a copy of FDLv1.3 was included.
But infact it was an older version. This change fixes that.
Ben Pfaff [Thu, 20 May 2010 14:22:52 +0000 (07:22 -0700)]
cairo: Implement xr_driver_destroy() and use it during printing.
This function was omitted by oversight earlier.
Ben Pfaff [Thu, 20 May 2010 03:59:28 +0000 (20:59 -0700)]
README.Git: Update to newest Gnulib.
This should fix build failures on OpenSUSE, OpenBSD, and possibly on other
platforms that have libintl but on which libintl does not contain a
definition of __printf__, by integrating the following commit:
commit
a43e24168368619e2d51fe7a37abc4969d7a87fe
Author: Bruno Haible <bruno@clisp.org>
Date: Sun May 16 14:16:03 2010 +0200
Fix collision between gnulib's and libintl's printf replacements.
John Darrington [Wed, 19 May 2010 15:27:51 +0000 (17:27 +0200)]
Implemented the Binomial Test dialog box.
John Darrington [Wed, 19 May 2010 14:31:08 +0000 (16:31 +0200)]
Fixed bug parsing binomial test.
The NPAR TEST /BINOMIAL subcommand was supposed
to take a default P value. But it didn't work.
This change fixes that problem.
John Darrington [Wed, 19 May 2010 12:06:36 +0000 (14:06 +0200)]
Added an implementation of the Chi-Square dialog box
John Darrington [Wed, 19 May 2010 06:57:04 +0000 (08:57 +0200)]
Add stock items to output viewer menuitems
John Darrington [Wed, 19 May 2010 06:53:10 +0000 (08:53 +0200)]
Removed diagnostic messages from print operation callbacks
Ben Pfaff [Wed, 19 May 2010 05:05:52 +0000 (22:05 -0700)]
Merge "paginate" branch into "master".
This adds printing support to the PSPPIRE output viewer on the master
branch.
Ben Pfaff [Wed, 19 May 2010 04:35:05 +0000 (21:35 -0700)]
psppire-axis: Use rint() instead of nearbyint(), for portability.
rint() and nearbyint() are identical except that nearbyint() will not
raise the inexact result exception, which we don't care about. OpenBSD
and probably other OSes have rint() but not nearbyint().
Perhaps a better fix would be to add a nearbyint module to Gnulib.
John Darrington [Tue, 18 May 2010 15:31:46 +0000 (17:31 +0200)]
Added tests for the FACTOR command
Ben Pfaff [Tue, 18 May 2010 04:46:41 +0000 (21:46 -0700)]
compiler: Fix SENTINEL macro in non-GCC case.
Jason H Stover [Mon, 17 May 2010 20:40:38 +0000 (16:40 -0400)]
New function covariance_calculate_unnormalized
Jason H Stover [Mon, 17 May 2010 20:39:28 +0000 (16:39 -0400)]
Rewrote to use new covariance functions.
John Darrington [Sun, 16 May 2010 11:30:38 +0000 (13:30 +0200)]
Renamed function to reflect change of purpose from previous commit
John Darrington [Sun, 16 May 2010 11:21:47 +0000 (13:21 +0200)]
Paste to a single common syntax window instead of a new one.
Previously, when a dialog box's "paste" button was pressed, a
new syntax window was created and the syntax pasted to it. This
change alters that behaviour. Now there is just one syntax window
that is used for all paste operations. Fixes bug #27686
John Darrington [Sun, 16 May 2010 10:48:57 +0000 (12:48 +0200)]
Expanded comments to src/libpspp/i18n.[ch]
John Darrington [Sat, 15 May 2010 12:26:38 +0000 (14:26 +0200)]
Update nl.po from translationproject.org
John Darrington [Fri, 14 May 2010 16:20:48 +0000 (18:20 +0200)]
Translate the contents of frequencies and descriptives checkbox treeviews
Call gettext on the translatable strings which populate the
contents of "Statistics" treeviews in checkbox dialogs.
Thanks to Harry Thijssen for reporting this.
John Darrington [Fri, 14 May 2010 13:29:37 +0000 (15:29 +0200)]
Merge branch 'master' of ssh://jmd@git.sv.gnu.org/srv/git/pspp
Ben Pfaff [Thu, 13 May 2010 04:58:40 +0000 (21:58 -0700)]
gui: Configure page setup when printing in the GUI.
The page setup has to be passed down to the Cairo output driver or it
doesn't know how to paginate the output properly.
Ben Pfaff [Thu, 13 May 2010 04:54:10 +0000 (21:54 -0700)]
gui: Factor out creation of Cairo output driver in printing code.
The following commit will add a lot more code here, so it's best to avoid
duplication.
Ben Pfaff [Thu, 13 May 2010 04:41:21 +0000 (21:41 -0700)]
cairo: Allow xr_driver_create()'s caller to usefully set more options.
Until now, xr_driver_create() has only parsed a few of the Cairo driver
options. This commit makes it parse more of them, in preparation for
output viewer printing to set more of them.
Ben Pfaff [Thu, 13 May 2010 04:25:37 +0000 (21:25 -0700)]
cairo: Apply margins to pages added with xr_driver_next_page().
This properly adds margins to pages printed by the GUI.