John Darrington [Fri, 21 Feb 2014 09:06:00 +0000 (10:06 +0100)]
Replace syntactical keywords in error/warning messages by printf directives.
A number of translators are still making the mistake of translating syntax
keywords in messages (such as "REPEAT") into thier literal equivalents in
the target language. This change avoids the posibility of that mistake,
by removing the keywords from the translatable string.
Ben Pfaff [Thu, 20 Feb 2014 16:33:21 +0000 (08:33 -0800)]
sys-file-reader: Don't skip "too many value labels" test anymore.
Previously the maximum number of value labels depended on the size of
size_t, so that it was impossible to have too many on 64-bit systems, but
a recent change made the maximum number of value labels depend on the
size of unsigned int instead, so now 32- and 64-bit systems are the same.
This commit reverts the code that skips the test.
Ben Pfaff [Thu, 20 Feb 2014 16:25:13 +0000 (08:25 -0800)]
i18n: Fix typo in test.
UTF8 is written UTF-8 elsewhere. It looks like Mac OS X only accepts the
latter spelling.
Reported by Jeremy Lavergne.
John Darrington [Thu, 6 Feb 2014 20:50:11 +0000 (21:50 +0100)]
Means Dialog: Fix issue where the wrong syntax was generated.
Addresses Bug #41433
John Darrington [Sun, 16 Feb 2014 10:11:45 +0000 (11:11 +0100)]
psppire-var-view.c: Allow multiple selections
Ben Pfaff [Mon, 17 Feb 2014 05:28:26 +0000 (21:28 -0800)]
data-out: Avoid excessive spaces in data_out_stretchy() output.
By formatting all numbers with width 40, the output almost always began
with a long string of spaces. That tended to stretch out table cells.
This commit fixes the problem.
Ben Pfaff [Tue, 18 Feb 2014 01:57:46 +0000 (17:57 -0800)]
dialog: Avoid assumption that enum val_type can have negative value.
Reported by Clang.
Ben Pfaff [Tue, 18 Feb 2014 01:55:51 +0000 (17:55 -0800)]
psppire-var-sheet: Remove unneeded and useless check of unsigned for >= 0.
Reported by Clang.
Ben Pfaff [Mon, 17 Feb 2014 23:48:43 +0000 (15:48 -0800)]
pspp-widget-facade: Remove odd statement "xalign = xalign;".
Reported by Clang.
Ben Pfaff [Mon, 17 Feb 2014 23:39:29 +0000 (15:39 -0800)]
Fix printf() format specifiers.
My main development machine is 32-bit, so I didn't see these.
Ben Pfaff [Mon, 17 Feb 2014 23:38:01 +0000 (15:38 -0800)]
numeric: Avoid using invalid FMT_* as special value.
Clang reported that "f.type != -1" is always true, so I guess it treats
enum fmt_type as unsigned. This commit fixes the problem.
Ben Pfaff [Mon, 17 Feb 2014 23:28:29 +0000 (15:28 -0800)]
sys-file-reader: Fix confusion of types between size_t and unsigned int.
Reported by Clang.
Ben Pfaff [Mon, 17 Feb 2014 23:23:09 +0000 (15:23 -0800)]
message: Add prototype for vmsg() function.
Reported by Clang.
John Darrington [Mon, 17 Feb 2014 19:36:00 +0000 (20:36 +0100)]
Fix memory fault reading ODS file.
Partial fix for bug #41620
Ben Pfaff [Wed, 2 Oct 2013 05:20:12 +0000 (22:20 -0700)]
cairo: Let xr_layout_cell() assume its parameters are nonnull.
This slightly simplifies the logic and all the callers appear to satisfy
this requirement.
Ben Pfaff [Sun, 16 Feb 2014 23:24:16 +0000 (15:24 -0800)]
po: Update translations from translationproject.org.
Ben Pfaff [Sun, 16 Feb 2014 22:59:54 +0000 (14:59 -0800)]
Make SYSFILE INFO able to analyze valid encodings for a system file.
Also, warn when opening a system file that does not identify its encoding.
Ben Pfaff [Sun, 16 Feb 2014 22:46:27 +0000 (14:46 -0800)]
sys-file-reader: Add character encoding record to all the tests.
This will avoid a warning added in a later commit when reading a system
file with no encoding record and no specific encoding specified.
Ben Pfaff [Sun, 16 Feb 2014 22:43:53 +0000 (14:43 -0800)]
sack: Drop md5sum generation and checking.
md5sums made it hard to update the tests, and I don't recall the md5sums
every actually helping to make sure that the test input was correct.
Ben Pfaff [Sat, 15 Feb 2014 23:46:23 +0000 (15:46 -0800)]
sys-file-reader: Break multiple response set decoding into two stages.
This allows the multiple response set names to be obtained before
the encoding used for their names has been determined.
Ben Pfaff [Sun, 9 Feb 2014 21:26:32 +0000 (13:26 -0800)]
sys-file-reader: Break reading a system file into two stages.
This paves the way to add a way to obtain strings from the system file, to
allow to more intelligently offer users a choice of encodings, by allowing
a client to open a system file before deciding what encoding should be
used to decode it.
Ben Pfaff [Sun, 16 Feb 2014 07:11:56 +0000 (23:11 -0800)]
sys-file-reader: Get rid of longjmp().
longjmp() makes code harder to understand, and I was finding its
usage here was making it harder for me to make reasonable changes
to the system file reader.
Ben Pfaff [Sun, 16 Feb 2014 03:22:07 +0000 (19:22 -0800)]
pspp-dump-sav: Print variable sets.
I'm thinking about implementing these, and it's easier to understand the
format if pspp-dump-sav prints the contents.
Ben Pfaff [Sun, 16 Feb 2014 07:06:13 +0000 (23:06 -0800)]
pspp-dump-sav: More gracefully handle empty multiple response sets.
Some multiple response sets have no variables, although I don't know why,
and pspp-dump-sav is more useful if it doesn't stop reading when it arrives
at one.
Ben Pfaff [Sun, 16 Feb 2014 03:19:58 +0000 (19:19 -0800)]
sys-file-reader: Handle multiple response sets with extra line feeds.
Some system files have these, although I don't know why.
Ben Pfaff [Sun, 9 Feb 2014 06:07:58 +0000 (22:07 -0800)]
sys-file-reader: Ignore string weighting variable instead of aborting.
Ben Pfaff [Tue, 11 Feb 2014 04:59:49 +0000 (20:59 -0800)]
i18n: Correctly recode windows-1258 and others with combining diacritics.
Without this change, recoding a string from windows-1258 often drops the
last character.
Ben Pfaff [Sat, 8 Feb 2014 21:45:15 +0000 (13:45 -0800)]
Remove old changelogs from tree.
They tend to result in false positive "grep" hits and are too old to help
most queries. They are still available in the Git history, of course.
Ben Pfaff [Sat, 8 Feb 2014 16:57:08 +0000 (08:57 -0800)]
doc: Add files generated by TeX to gitignore.
Ben Pfaff [Sat, 8 Feb 2014 16:56:45 +0000 (08:56 -0800)]
sys-file-reader: Successfully read files with duplicate names.
This allows PSPP to read some files written by SPSS.
Bug #41475.
Ben Pfaff [Tue, 4 Feb 2014 06:56:00 +0000 (22:56 -0800)]
gui: Allow File|Open to select an encoding for system files.
This should allow old files in unexpected encodings to be more easily read.
Problem reported by Przemek Powalko <pp.alter.ego@gmail.com>.
Ben Pfaff [Tue, 4 Feb 2014 06:53:10 +0000 (22:53 -0800)]
SYSFILE INFO: Add ENCODING subcommand.
Ben Pfaff [Tue, 4 Feb 2014 05:37:53 +0000 (21:37 -0800)]
Change many %g format specifiers to %.*g with precision DBL_DIG + 1.
The high precision should ensure that in most cases the value is formatted
with enough digits to fully express the internal precision. Without this
change, %g by itself only expresses 6 digits of precision, so that an
integer value like
99999999 is formatted as 1e8. This fixes the problem.
This commit adds a test to MISSING VALUES because this was in particular
reported as a problem.
Thanks to Andre Müller <Andre.Mueller@gesis.org> for reporting this issue.
John Darrington [Thu, 30 Jan 2014 19:45:59 +0000 (20:45 +0100)]
Updated translations from TP
John Darrington [Thu, 30 Jan 2014 08:23:51 +0000 (09:23 +0100)]
Remove Gtk-2.22 bug workaround.
Since we now depend on Gtk+2.24, this workaround is no longer relevant
John Darrington [Tue, 28 Jan 2014 18:52:52 +0000 (19:52 +0100)]
Fix broken build with ./configure --without-cairo
Ben Pfaff [Wed, 22 Jan 2014 15:35:14 +0000 (07:35 -0800)]
po: Update translations from translationproject.org.
John Darrington [Mon, 20 Jan 2014 17:59:35 +0000 (18:59 +0100)]
Pass LIBREADLINE arguments to those autoconf tests which need it.
This should hopefully resolve problems on some systems which incorrectly
detected readline library attributes.
John Darrington [Sun, 19 Jan 2014 13:50:05 +0000 (14:50 +0100)]
Pulled German translation from TP
John Darrington [Sun, 19 Jan 2014 09:19:05 +0000 (10:19 +0100)]
Pulled translations from TP
John Darrington [Sun, 19 Jan 2014 09:13:33 +0000 (10:13 +0100)]
REGRESSION: Show tooltips for Statistics items in sub-dialog.
This should make it easier for GUI users who don't read user manuals.
John Darrington [Sat, 18 Jan 2014 17:38:20 +0000 (18:38 +0100)]
Do not attempt to replace rl_echo_signal_char if no readline is in use
John Darrington [Sat, 18 Jan 2014 09:36:25 +0000 (10:36 +0100)]
Smake: add --copy flag to libtoolize
John Darrington [Thu, 16 Jan 2014 11:45:54 +0000 (12:45 +0100)]
LOGISTIC REGRESSION: Allow fractional confidence interval
John Darrington [Wed, 15 Jan 2014 18:19:13 +0000 (19:19 +0100)]
REGRESSION: Add gui option for the confidence interval
John Darrington [Mon, 13 Jan 2014 09:32:59 +0000 (10:32 +0100)]
REGRESSION: Added calculation of the coefficients' confidence interval.
John Darrington [Mon, 13 Jan 2014 08:34:41 +0000 (09:34 +0100)]
REGRESSION: Add parser framework for confidence interval
Ben Pfaff [Tue, 14 Jan 2014 05:41:40 +0000 (21:41 -0800)]
configure: Update version number to 0.8.2.
Ben Pfaff [Fri, 10 Jan 2014 05:08:10 +0000 (21:08 -0800)]
pspp-convert: Fix Mac OS build by eliminating redundant linking.
The Mach-O object format used on Mac OS handles redundant linking against
a shared object badly, whereas ELF doesn't have a problem, so this commit
fixes a crash on Mac OS.
Reported by Jeremy Lavergne.
Ben Pfaff [Thu, 9 Jan 2014 06:20:32 +0000 (22:20 -0800)]
po: Update translations from translationproject.org.
John Darrington [Wed, 8 Jan 2014 13:52:43 +0000 (14:52 +0100)]
T-Test indendendent variable test: Add vertical line to seperate variable name
from group values.
Reported-By: Douglas Bonett <dgbonett@ucsc.edu>
John Darrington [Wed, 8 Jan 2014 11:54:52 +0000 (12:54 +0100)]
Change "Significance" to "Sig." in linear regression and one-way ANOVA
output to be consistent with other PSPP analyses and with other software.
Reported-By: Douglas Bonett <dgbonett@ucsc.edu>
John Darrington [Wed, 8 Jan 2014 08:49:17 +0000 (09:49 +0100)]
Paired T-Test: Label first pair as 'Pair 1' instead of 'Pair 0'.
Reported-By: Douglas Bonett <dgbonett@ucsc.edu>
John Darrington [Fri, 3 Jan 2014 06:22:19 +0000 (07:22 +0100)]
doc/tutorial.texi: Correct the text describing intepretation of the Levene test.
The text which described the interpretation of the Levene test, in the
independent samples T-TEST output erroneously inverted the sense of the conclusion.
This change corrects the text.
Reported-by: Jernej Pleteršek <jernej.pletersek@gmail.com>
John Darrington [Mon, 30 Dec 2013 09:24:28 +0000 (10:24 +0100)]
Update and correct minor typographical errors in INSTALL
John Darrington [Mon, 30 Dec 2013 09:13:16 +0000 (10:13 +0100)]
QUICK CLUSTER: Fix crash on negative parameters
Ben Pfaff [Mon, 30 Dec 2013 00:46:22 +0000 (16:46 -0800)]
tests: Make pspp-convert respect "make check-valgrind".
John Darrington [Thu, 26 Dec 2013 20:10:03 +0000 (21:10 +0100)]
configure.ac: Update dependency from gsl 1.12 to 1.13
Until version 1.13 gsl_matrix_free would crash when passed NULL.
Reported-by: Frans Houweling <fhouweling@email.it>
John Darrington [Mon, 23 Dec 2013 16:49:21 +0000 (17:49 +0100)]
src/data/sys-file-encryption.c (encrypted_sys_file_open): fn_open was used to open, so fn_close should be used to close
Ben Pfaff [Tue, 24 Dec 2013 16:18:53 +0000 (08:18 -0800)]
Makefile: Use C locale for checking files to distribute.
Otherwise a bad report can result if the two targets are run in different
locales (in different runs of "make").
Reported by John Darrington.
Ben Pfaff [Tue, 24 Dec 2013 03:24:42 +0000 (19:24 -0800)]
cmac-aes256: Correct size of local rk[] array.
This array was undersized, yielding undefined behavior. It happened to
work OK when compiled -O2 with GCC 4.7.x for x86, and fail with compiled
-O0 in the same environment. This fixes the problem.
Reported by John Darrington.
Ben Pfaff [Mon, 23 Dec 2013 17:02:54 +0000 (09:02 -0800)]
Makefile.am: Add rule to make sure every file gets distributed.
This helps to prevent adding files to the Git repository but forgetting to
ensure that they get distributed.
Ben Pfaff [Mon, 23 Dec 2013 17:00:35 +0000 (09:00 -0800)]
Distribute lots of files that had been missed.
Ben Pfaff [Mon, 23 Dec 2013 17:00:11 +0000 (09:00 -0800)]
Makefile.am: Add rule to ensure that glade/OChangeLog is always distributed.
Otherwise it only gets distributed if configured --with-gui-tools.
Ben Pfaff [Mon, 23 Dec 2013 16:59:36 +0000 (08:59 -0800)]
po: Rename ChangeLog to its normal spelling.
Ben Pfaff [Mon, 23 Dec 2013 16:53:32 +0000 (08:53 -0800)]
src/math/ts: Remove entire directory, which is unused.
Nothing actually builds or uses anything in this directory.
Ben Pfaff [Tue, 19 Nov 2013 06:57:27 +0000 (22:57 -0800)]
sys-file-info: Avoid duplicate variable name in inner scope.
No actual harm done in this case, I think, but still bad form.
Ben Pfaff [Sun, 22 Dec 2013 19:10:49 +0000 (11:10 -0800)]
DISPLAY DICTIONARY: Add "Label: " prefix for variable labels in output.
Bug #40864.
Ben Pfaff [Sun, 22 Dec 2013 07:33:57 +0000 (23:33 -0800)]
pspp-convert: Add support for decrypting encrypted system files.
Ben Pfaff [Sun, 22 Dec 2013 07:14:19 +0000 (23:14 -0800)]
pspp-convert: Use null encoding rather than "Auto" by default.
This avoids errors trying to create a converter to and from a nonexistent
"Auto" encoding.
John Darrington [Wed, 18 Dec 2013 17:28:24 +0000 (18:28 +0100)]
Documentation: Change index entry to be consistent with that in
the tutorial section.
John Darrington [Sun, 8 Dec 2013 14:36:49 +0000 (15:36 +0100)]
src/data/any-reader.c (any_reader_may_open): Return tri-state value.
Previously, any_reader_may_open returned bool. This change makes it
return a tri-state variable. YES, NO or ERROR. This is useful to
distinguish between a file which is not "readable" (ie not in a format
which PSPP knows how to read) and a file which cannot be opened due
to lack of permission or other lower level errors.
John Darrington [Sun, 15 Dec 2013 16:18:41 +0000 (17:18 +0100)]
Avoid crash when attempting to open files with invalid encoding
Ben Pfaff [Sat, 14 Dec 2013 21:47:32 +0000 (13:47 -0800)]
po: Update translations from translationproject.org.
John Darrington [Sat, 23 Nov 2013 18:51:44 +0000 (19:51 +0100)]
Fix incorrect table range selection in CORRELATIONS
Fixed a problem were non-square correlations (those where the
WITH keyword was used) displayed the wrong part of the correlation
table.
Fixes bug #40661
John Darrington [Sun, 17 Nov 2013 10:13:24 +0000 (11:13 +0100)]
Updated translations from translationproject.org
Ben Pfaff [Sat, 16 Nov 2013 17:54:46 +0000 (09:54 -0800)]
po: Update Ukrainian and Dutch translations, from translationproject.
Ben Pfaff [Sat, 16 Nov 2013 17:47:20 +0000 (09:47 -0800)]
Smake: Break svg2png out as separate script.
This makes the output of "make -f Smake" shorter and easier to read.
Ben Pfaff [Sat, 16 Nov 2013 04:32:28 +0000 (20:32 -0800)]
psppire-data-window: Set default filter in File|Save As to show all files.
The File|Save As dialog box showed "System Files" in two places: in the
filter dropdown and in the format dropdown. It was surprising to users
that changing the filter dropdown had no effect on the format of the file
actually saved. This commit makes it more obvious which dropdown needs to
be changed, by only showing "System Files" in the right place.
Reported by Harry Thijssen.
Bug #39648.
Ben Pfaff [Fri, 15 Nov 2013 06:25:44 +0000 (22:25 -0800)]
psppire-data-sheet: Show combo boxes only when value labels are displayed.
A number of users chimed in that this made more sense.
Requested by Bernhard Baermann.
Ben Pfaff [Fri, 15 Nov 2013 00:41:32 +0000 (16:41 -0800)]
render-test: Render to PDF only if --pdf specified on command line.
Difference in font metrics on Guix lead to errors trying to render to PDF
in some tests. The tests don't actually check anything in the PDF output
so we might as well just leave that for manual testing. Adding an option
accomplishes that well enough.
Reported by Andreas Enge.
Root caused discovered by John Darrington.
Bug #40213.
Ben Pfaff [Sun, 10 Nov 2013 01:19:35 +0000 (17:19 -0800)]
Update version number to 0.8.1.1 to send to translationproject.
Ben Pfaff [Sun, 10 Nov 2013 00:15:33 +0000 (16:15 -0800)]
Update Ukrainian translation.
John Darrington [Thu, 7 Nov 2013 14:48:32 +0000 (15:48 +0100)]
Smake: Added the -background transparent flag to the convert call
John Darrington [Thu, 7 Nov 2013 08:57:54 +0000 (09:57 +0100)]
Added new map entries from Gtk stock items to pspp stock items
This method allows us to use our own icons, but all other properties
(labels, translations etc) from the Gtk library.
These missing entries meant that labels were missing from the
syntax editor.
Reported-by: Bastian Diaz
Bastián Díaz [Thu, 7 Nov 2013 06:33:18 +0000 (03:33 -0300)]
Support for images 24x24 and 32x32 canvas for some flat icons
Added support for new images in arger sizes to be included in a future
in the toolbar (data editor, syntax editor and output windows).
John Darrington [Sun, 3 Nov 2013 07:16:38 +0000 (08:16 +0100)]
Added the pspp.appdata.xml file.
Apparently upcoming Gnome versions require this file.
Closes bug #40453
John Darrington [Sun, 3 Nov 2013 06:59:55 +0000 (07:59 +0100)]
Corrected typo in description string
John Darrington [Sat, 2 Nov 2013 15:42:26 +0000 (16:42 +0100)]
Updated Ukrainian translation from tp
John Darrington [Fri, 1 Nov 2013 18:19:18 +0000 (19:19 +0100)]
Corrected various typos in printed strings and documentation.
Reported-by: anonymous
Fixes bug 40447
John Darrington [Wed, 30 Oct 2013 19:47:07 +0000 (20:47 +0100)]
Fix problem with non-reentrant journal driver
John Darrington [Tue, 29 Oct 2013 16:59:07 +0000 (17:59 +0100)]
journal.c: Made journal_file_name a member of the journal struct
Bastián Díaz [Thu, 31 Oct 2013 09:00:00 +0000 (06:00 -0300)]
Correct error from previous commit "Reference is added to the image ZSAV files in Smake"
The inclusion of new references of ZSAV files, is omitted one of the backslash "\". In this commit fix the problem.
John Darrington [Wed, 30 Oct 2013 11:46:43 +0000 (12:46 +0100)]
Updated translations from translationproject.org
Bastián Díaz [Tue, 29 Oct 2013 06:13:39 +0000 (03:13 -0300)]
Update on the design of some flat icons
Bastián Díaz [Mon, 28 Oct 2013 18:41:04 +0000 (15:41 -0300)]
Reference is added to the image to ZSAV files in Smake
Bastián Díaz [Mon, 28 Oct 2013 10:03:52 +0000 (07:03 -0300)]
New pictogram for "split-file"
The new icon is more harmonious with the other icons.
Bastián Díaz [Mon, 28 Oct 2013 09:05:44 +0000 (06:05 -0300)]
Tradicional style pictograms weight cases and tag
Little improvement in using simple pictograms and more representative.
Bastián Díaz [Sun, 27 Oct 2013 04:46:42 +0000 (01:46 -0300)]
New version of icons for mimetypes supported by PSPP
→ Improved display for *.sav, *.por and *.sps
→ New icon for *.zsav
Ben Pfaff [Sat, 26 Oct 2013 19:52:54 +0000 (12:52 -0700)]
Updated uk.po from TPO