John Darrington [Sat, 13 Jul 2019 18:33:22 +0000 (20:33 +0200)]
doc/dev/*.texi: Add copyright and licence notices
John Darrington [Sat, 13 Jul 2019 10:36:22 +0000 (12:36 +0200)]
doc/automake.mk: Add copyright and licence notice
John Darrington [Sat, 13 Jul 2019 09:05:15 +0000 (11:05 +0200)]
Add copyright and licence notice to Makefile.am
Ben Pfaff [Mon, 22 Jul 2019 00:16:36 +0000 (17:16 -0700)]
value: Get rid of value_str(), value_str_rw(), value_num().
These can now all be replaced now by plain ->s or ->f, which is
shorter and clearer anyway.
Ben Pfaff [Sun, 21 Jul 2019 02:18:53 +0000 (19:18 -0700)]
value: Drop distinction between long and short string values.
The time has passed when this is a super valuable distinction. There is
basically no distinction in the language itself anymore, the efficiency
gains sound pretty marginal, and the differences lead to bugs, both
correctness- and memory leak-wise, that are hard to test for (because the
developer must make sure to test both short and long strings everywhere).
This commit changes the code so that both short and long strings are
represented the way that long strings were previously.
Ben Pfaff [Mon, 22 Jul 2019 00:16:07 +0000 (17:16 -0700)]
t-test-parser: Re-fix memory leak.
I managed to screw this up in untabification.
Fixes: 759791b6dee8 ("t-test-parser: Untabify.")
Ben Pfaff [Sun, 21 Jul 2019 18:27:19 +0000 (11:27 -0700)]
perl-module: Init and destroy for long strings in set_missing_values().
Otherwise long strings segfault.
Ben Pfaff [Sun, 21 Jul 2019 17:34:39 +0000 (10:34 -0700)]
t-test-parser: Untabify.
This file was inconsistent on tabs versus spaces. Usually we use spaces
in PSPP.
Ben Pfaff [Sun, 21 Jul 2019 17:34:23 +0000 (10:34 -0700)]
t-test-parser: Force values to be specified with a string vars on GROUPS.
Ben Pfaff [Sun, 21 Jul 2019 17:29:56 +0000 (10:29 -0700)]
t-test-parser: Fix memory leak with GROUPS and long strings.
Ben Pfaff [Sun, 21 Jul 2019 17:07:15 +0000 (10:07 -0700)]
categoricals: Fix memory leak allocating long string categoricals.
Ben Pfaff [Sun, 21 Jul 2019 04:34:41 +0000 (21:34 -0700)]
shapiro-wilk: Fix memory leak.
CC: John Darrington <john@darrington.wattle.id.au>
Fixes: 0b7e8882ce9b ("EXAMINE: Implement the Shapiro-Wilk Test.")
Ben Pfaff [Sun, 21 Jul 2019 02:58:56 +0000 (19:58 -0700)]
EXAMINE: Fix leak in Shapiro-Wilk test.
CC: John Darrington <john@darrington.wattle.id.au>
Fixes: 0b7e8882ce9b ("EXAMINE: Implement the Shapiro-Wilk Test.")
Ben Pfaff [Sun, 7 Jul 2019 20:37:18 +0000 (13:37 -0700)]
AUTORECODE: Declare index variables inside 'for' loops.
Just a style update.
John Darrington [Fri, 12 Jul 2019 10:54:30 +0000 (12:54 +0200)]
ABOUT-NLS: Update to most recent version from gettext-0.20
Ben Pfaff [Sun, 7 Jul 2019 18:48:22 +0000 (11:48 -0700)]
AUTORECODE: Always report parse errors.
The code didn't always report syntax errors that it found.
Ben Pfaff [Sun, 7 Jul 2019 18:44:43 +0000 (11:44 -0700)]
lexer: Make lex_error_expecting() easier to use.
With this change, the caller doesn't have to explicitly supply the null
sentinel since the macro does it automatically.
Ben Pfaff [Sun, 7 Jul 2019 04:36:59 +0000 (21:36 -0700)]
pivot-table: Properly allocate pivot_table's current_layer.
The default current_layer should be all-zeros, but the code wasn't
allocating current_layer at all. This didn't cause much of a problem
because nothing in the current tree allocates layers, but it will as
layers are added.
Thanks to John Darrington for reporting the bug.
Ben Pfaff [Sun, 7 Jul 2019 02:12:01 +0000 (19:12 -0700)]
system-file-format.texi: Correct typo.
Bug #56547.
Ben Pfaff [Thu, 4 Jul 2019 23:23:06 +0000 (16:23 -0700)]
README.Git: Advance to Gnulib commit
9ce9be2ef0cb ("autoupdate").
A recent commit to PSPP depended on a more recent version of Gnulib that
includes Gnulib commit
3cd207e1d0fd ("fatal-signal: Pass the signal number
to the action.") but the PSPP commit did not actually advance the Gnulib
dependency to that commit. This commit does that (actually it advances to
Gnulib tip of master).
Fixes: 21d2449f801c ("unlink_replace_files: Change signature to avoid compiler warning.")
John Darrington [Wed, 3 Jul 2019 18:01:30 +0000 (20:01 +0200)]
Remove UNUSED attributes where they were inappropriate.
These parameters were marked UNUSED, when they were in fact,
used.
John Darrington [Mon, 1 Jul 2019 19:18:49 +0000 (21:18 +0200)]
Recent to GTK+3.22
John Darrington [Tue, 2 Jul 2019 16:29:42 +0000 (18:29 +0200)]
means-calc.c: Add comments where needed.
John Darrington [Sun, 30 Jun 2019 09:17:15 +0000 (11:17 +0200)]
Apply Dictionary: Fix memory leak.
John Darrington [Sun, 30 Jun 2019 08:23:44 +0000 (10:23 +0200)]
Added test for the APPLY DICTIONARY command.
There appeared to be no existing test for this command.
John Darrington [Sat, 29 Jun 2019 13:05:26 +0000 (15:05 +0200)]
PsppireOutputView.c: Fix memory leak.
John Darrington [Sat, 29 Jun 2019 12:46:11 +0000 (14:46 +0200)]
Constness
John Darrington [Sat, 29 Jun 2019 11:27:27 +0000 (13:27 +0200)]
PSPP.xs: Remove unused variables.
John Darrington [Sat, 29 Jun 2019 11:17:17 +0000 (13:17 +0200)]
terminal-reader.c: Remove unused variable.
John Darrington [Sat, 29 Jun 2019 11:05:12 +0000 (13:05 +0200)]
PsppireOutputViewer.c: Remove non-functional debug feature.
John Darrington [Sat, 29 Jun 2019 10:11:48 +0000 (12:11 +0200)]
Use non-deprecated gtk things
John Darrington [Sat, 29 Jun 2019 06:26:33 +0000 (08:26 +0200)]
unlink_replace_files: Change signature to avoid compiler warning.
John Darrington [Sat, 29 Jun 2019 06:15:58 +0000 (08:15 +0200)]
MEANS: Don't compile debugging functions
John Darrington [Sat, 29 Jun 2019 06:06:11 +0000 (08:06 +0200)]
PsppireDict: Constness
John Darrington [Sat, 29 Jun 2019 05:57:34 +0000 (07:57 +0200)]
Descriptives: Constness
John Darrington [Mon, 24 Jun 2019 17:22:34 +0000 (19:22 +0200)]
TEST Examine unrepresentable graphs: Ignore stderr
John Darrington [Sun, 23 Jun 2019 16:49:47 +0000 (18:49 +0200)]
MEANS: Fix output with unusual formats
John Darrington [Sun, 23 Jun 2019 15:57:30 +0000 (17:57 +0200)]
MEANS: Change the statistic formats to follow their respective variables
John Darrington [Sun, 23 Jun 2019 04:37:45 +0000 (06:37 +0200)]
Don't crash when inserting variables into an empty sheet.
Fixes bug #56392.
John Darrington [Sun, 23 Jun 2019 04:36:48 +0000 (06:36 +0200)]
Add a comment
John Darrington [Sat, 22 Jun 2019 06:46:38 +0000 (08:46 +0200)]
MEANS: Fix behaviour when splits is active.
John Darrington [Thu, 20 Jun 2019 18:38:37 +0000 (20:38 +0200)]
MEANS: Fix memory leak
John Darrington [Thu, 20 Jun 2019 09:10:00 +0000 (11:10 +0200)]
Re-implement MEANS.
Fixes bug #44264.
Ben Pfaff [Thu, 13 Jun 2019 17:15:15 +0000 (10:15 -0700)]
pivot-table: Better document how to hide empty rows and columns.
Suggested by John Darrington.
John Darrington [Thu, 13 Jun 2019 15:03:00 +0000 (17:03 +0200)]
quick-cluster.c Fix uninitialised variables.
Gcc 7.4 issued a warning about this.
Ben Pfaff [Fri, 7 Jun 2019 00:32:22 +0000 (17:32 -0700)]
doc: Better describe the effect of OUTFILE on PRINT.
Reported by Nolan Void <nolvoa@hanakami.com>.
John Darrington [Thu, 6 Jun 2019 15:29:46 +0000 (17:29 +0200)]
Revert "Restart of new means implementation"
This reverts commit
ad7ae8bb105c925b951e241fd6a3d1cb93d614a0.
I inadvertently pushed this!
John Darrington [Thu, 6 Jun 2019 15:27:27 +0000 (17:27 +0200)]
Revert "Remove bad tests"
This reverts commit
b9a1a1c32d5589e208ea751911d35177b7751720.
I inadvertently pushed this!
John Darrington [Thu, 6 Jun 2019 15:26:13 +0000 (17:26 +0200)]
Remove bad tests
John Darrington [Thu, 6 Jun 2019 14:20:49 +0000 (16:20 +0200)]
Restart of new means implementation
John Darrington [Thu, 23 May 2019 08:05:06 +0000 (10:05 +0200)]
Matrix reader: Remove reliance on hash functions.
This code made inappropriate use of hash functions to identify
uniqueness in sets of values. This code removes that code, and
compares them explicitly.
Partial fix for bug #56363
John Darrington [Thu, 23 May 2019 05:33:55 +0000 (07:33 +0200)]
Matrix Data: Identify splits explicitly instead of with hashes.
The MATRIX DATA command was using hashes to identify splits in the
input. This works most of the time, but it is not guaranteed that
every combination of split values will produce a unique hash.
This change explicitly compares the values instead.
Partial fix for bug #56363
John Darrington [Thu, 23 May 2019 05:07:07 +0000 (07:07 +0200)]
src/libpspp/hash-functions.c: Add a preprocessor switch to help test hash table implementation.
John Darrington [Sun, 19 May 2019 08:10:23 +0000 (10:10 +0200)]
src/libpspp/copyleft.c: Add copyright and licence notice and an explanitory comment.
John Darrington [Sat, 18 May 2019 06:53:22 +0000 (08:53 +0200)]
examine.c: Add note to translators.
John Darrington [Fri, 10 May 2019 16:38:08 +0000 (18:38 +0200)]
Use msgmerge --previous when merging po files.
John Darrington [Tue, 21 May 2019 13:56:44 +0000 (15:56 +0200)]
NEWS: fix typo.
John Darrington [Tue, 21 May 2019 13:46:51 +0000 (15:46 +0200)]
src/math/levene.c: Fix crash resolving hmap collisions.
Partial fix for bug #56363
John Darrington [Tue, 21 May 2019 13:35:42 +0000 (15:35 +0200)]
Remove diagnostic printf
John Darrington [Tue, 21 May 2019 12:30:46 +0000 (14:30 +0200)]
Add the WARN_UNUSED_RESULT attribute to all hash functions.
A hash function has no purpose if the result is unused, and
tests will typically not pick up a mistake where the
programmer forgets to assign the result - the hash table will
merely degenerate to a linear searched array.
John Darrington [Tue, 21 May 2019 05:50:48 +0000 (07:50 +0200)]
roc.at: Remove comma terminating test keywords.
This was confusing me when trying to run all the ROC tests.
John Darrington [Thu, 9 May 2019 17:25:24 +0000 (19:25 +0200)]
src/language/stats/examine.c: Whitespace changes only.
John Darrington [Thu, 9 May 2019 16:37:14 +0000 (18:37 +0200)]
src/data/data-in.c: Whitespace change only.
John Darrington [Wed, 8 May 2019 07:08:09 +0000 (09:08 +0200)]
QUICK CLUSTER: Move the parser into its own function.
John Darrington [Tue, 7 May 2019 19:55:27 +0000 (21:55 +0200)]
QUICK CLUSTER (documentation): Clarify behaviour of the SAVE subcommand.
John Darrington [Tue, 7 May 2019 18:57:33 +0000 (20:57 +0200)]
Fix cut and paste error
John Darrington [Tue, 7 May 2019 08:07:05 +0000 (10:07 +0200)]
QUICK CLUSTER: Implement the /SAVE sub-command.
John Darrington [Tue, 7 May 2019 08:39:44 +0000 (10:39 +0200)]
quick-cluster.c: whitespace changes only.
John Darrington [Mon, 6 May 2019 11:12:58 +0000 (13:12 +0200)]
Adjust test to fix previous change
John Darrington [Mon, 6 May 2019 09:06:55 +0000 (11:06 +0200)]
Spelling: nonnegative -> non-negative
John Darrington [Mon, 6 May 2019 09:06:21 +0000 (11:06 +0200)]
Spelling: criterium -> criterion
John Darrington [Mon, 6 May 2019 07:06:10 +0000 (09:06 +0200)]
Remove en_GB.po
This file was very out of date, and today there are no strings
which need to be translated anyway.
John Darrington [Sun, 5 May 2019 12:09:47 +0000 (14:09 +0200)]
GRAPH (barchart): Percentages display subcategorial percentages.
When calculating the values for a categorical barchart displaying
percentages, use the sub-category totals as the denominator, rather
than the primary totals.
Fixes bug #56247
John Darrington [Sun, 5 May 2019 14:50:25 +0000 (16:50 +0200)]
Dump barchart when in testing mode.
This change adds a routine to barcharts to print the parameters of the
chart to stdout when --testing is passed.
John Darrington [Sun, 5 May 2019 14:13:56 +0000 (16:13 +0200)]
Barchart.h: Add comment.
John Darrington [Sun, 5 May 2019 10:19:42 +0000 (12:19 +0200)]
graph.c (run_barchart): Add assertion.
We don't support multidimensional barcharts.
John Darrington [Sun, 5 May 2019 10:13:40 +0000 (12:13 +0200)]
graph.c: "freqs" --> "cells".
The name "cells" is more meaningful in this context.
John Darrington [Sat, 4 May 2019 06:20:09 +0000 (08:20 +0200)]
EXAMINE: Implement the Shapiro-Wilk Test.
Closes bug #42511
John Darrington [Sat, 4 May 2019 05:56:06 +0000 (07:56 +0200)]
NEWS: spelling
John Darrington [Sat, 4 May 2019 05:51:01 +0000 (07:51 +0200)]
Update translations from translationproject.org
John Darrington [Sat, 4 May 2019 04:55:07 +0000 (06:55 +0200)]
Correct thinko in previous commit
John Darrington [Sat, 4 May 2019 04:29:44 +0000 (06:29 +0200)]
EXAMINE: Don't crash when unrenderable graphs are requested.
This change fixes a crash in the cleanup of the cairo driver when
a graph which is not representable was attempted to be rendered.
John Darrington [Fri, 3 May 2019 15:53:24 +0000 (17:53 +0200)]
Update translatable strings relating to internal errors.
John Darrington [Fri, 3 May 2019 14:31:50 +0000 (16:31 +0200)]
EXAMINE: Correct bug where /PLOT=ALL would not include the spreadlevel plot
John Darrington [Wed, 1 May 2019 06:44:10 +0000 (08:44 +0200)]
crosstabs.q: Replace 'Approx Sig.' with 'Approx. Sig.'
Not only is this a orthographical improvement, but it is also consistent
with other strings in this file and elsewhere, and avoids gratuitiously
adding an extra string for translators to deal with.
John Darrington [Wed, 1 May 2019 06:23:41 +0000 (08:23 +0200)]
graph.c: Whitespace changes only. Fold some very long lines.
John Darrington [Sun, 28 Apr 2019 15:24:36 +0000 (17:24 +0200)]
GUI: Scroll to correct datasheet position after deleting/inserting variables.
* src/ui/gui/psppire-data-sheet.h (psppire_data_sheet_delete_variables,
psppire_data_sheet_insert_new_variable_at_posn): New functions
* src/ui/gui/psppire-data-sheet.c: insert_new_variable ->
psppire_data_sheet_insert_new_variable_at_posn.
* src/ui/gui/psppire-data-sheet.c: delete_variables ->
psppire_data_sheet_delete_variables.
* src/ui/gui/psppire-data-editor.c:
(psppire_data_editor_data_delete_variables,
psppire_data_editor_insert_new_variable_at_posn): Reimplement.
John Darrington [Sun, 28 Apr 2019 13:09:02 +0000 (15:09 +0200)]
src/output/driver.c: Change engine_stack from an array to a list.
The structure called engine_stack was formerly implemented as a heap
based array allocated with realloc. However when realloc moves data
it makes only shallow copies and does not copy referand of pointers.
This was causing crashes under certain circumstances.
Rather than trying to fix this, this change re-implements engine_stack
using the linked list structure from ll.h
John Darrington [Sat, 27 Apr 2019 11:51:29 +0000 (13:51 +0200)]
NEWS: correct misleading entry
John Darrington [Sat, 27 Apr 2019 11:31:07 +0000 (13:31 +0200)]
FREQUENCIES: Warn the user if any weight values are missing.
John Darrington [Sat, 20 Apr 2019 13:58:03 +0000 (15:58 +0200)]
piechart-cairo.c: Remove erroneous duplicate line.
Ayhan Yalçınsoy [Tue, 16 Apr 2019 17:02:21 +0000 (19:02 +0200)]
Oneway GUI: Add dialog box for the posthoc tests.
John Darrington [Sun, 14 Apr 2019 14:57:42 +0000 (16:57 +0200)]
Fix crash in lexer due to integer overflow.
Fixes bug #54684
John Darrington [Sun, 14 Apr 2019 14:46:26 +0000 (16:46 +0200)]
lexer: Token testing functions now take a const argument.
John Darrington [Sat, 13 Apr 2019 18:55:19 +0000 (20:55 +0200)]
Fix crash in gui, when T-TEST or ONEWAY while a filter is set.
Fixes bug #54784
Ayhan Yalçınsoy [Sun, 31 Mar 2019 07:06:25 +0000 (09:06 +0200)]
Linear Regression GUI: Add checkbox for tolerance.
John Darrington [Wed, 27 Mar 2019 14:03:55 +0000 (15:03 +0100)]
array.c: Add missing include directive
John Darrington [Tue, 12 Mar 2019 16:30:56 +0000 (17:30 +0100)]
REGRESSION: Fix bug when printing tolerance of multiple variables.
John Darrington [Mon, 11 Mar 2019 09:10:45 +0000 (10:10 +0100)]
REGRESSION: Rename COLLIN to TOL
This is now consistent with other software.
John Darrington [Sun, 10 Mar 2019 18:50:17 +0000 (19:50 +0100)]
Update version number, as there have been a number of changes since the last release