John Darrington [Tue, 5 Apr 2016 19:08:50 +0000 (21:08 +0200)]
Fixed a crash when data for correlations was empty.
Found by zzuf.
John Darrington [Tue, 5 Apr 2016 18:01:35 +0000 (20:01 +0200)]
Add test for PERMISSIONS with bad syntax
John Darrington [Mon, 4 Apr 2016 11:42:21 +0000 (13:42 +0200)]
Fix crash in T-Test after parsing a null terminated string.
Found by zzuf.
Ben Pfaff [Sun, 3 Apr 2016 18:52:55 +0000 (11:52 -0700)]
tests: Fix a deeper bug in null byte check in testsuite.
Thanks to Jeremy Lavergne for reporting the problem.
Ben Pfaff [Sun, 3 Apr 2016 18:20:27 +0000 (11:20 -0700)]
tests: Fix bug in null byte check in testsuite.
Thanks to Jeremy Lavergne for reporting the problem.
Ben Pfaff [Sun, 3 Apr 2016 03:50:51 +0000 (20:50 -0700)]
Update version number to 0.10.2.
Ben Pfaff [Sun, 3 Apr 2016 03:37:15 +0000 (20:37 -0700)]
Release PSPP 0.10.1.
Ben Pfaff [Sun, 3 Apr 2016 00:53:52 +0000 (17:53 -0700)]
lexer: Treat null characters in input as spaces.
In some circumstances nulls could confuse the lexer and cause crashes.
Thanks to John Darrington for reporting the problem.
Bug #47602.
Ben Pfaff [Sat, 2 Apr 2016 23:41:13 +0000 (16:41 -0700)]
lexer: Add comments and update style in lex_source_get__().
Ben Pfaff [Sat, 2 Apr 2016 18:09:15 +0000 (11:09 -0700)]
CROSSTABS: Fix corner case in integer mode.
I'm not really sure what I was thinking when I wrote this code, but the
off-by-one errors could cause a crash.
Thanks to John Darrington for reporting the problem.
Bug #47600.
John Darrington [Sat, 2 Apr 2016 08:21:09 +0000 (10:21 +0200)]
Documentation: Update copyright notice to reflect recent changes
John Darrington [Sat, 2 Apr 2016 04:01:43 +0000 (06:01 +0200)]
Fix date format tests when running under wine
Ben Pfaff [Sat, 2 Apr 2016 03:12:29 +0000 (05:12 +0200)]
Replace valgrind-wrapper with a generic wrapper.
One potential use is to run tests under an emulator such as wine.
John Darrington [Fri, 1 Apr 2016 13:38:37 +0000 (15:38 +0200)]
lexer.h: Add WARN_UNUSED_RESULT to lex_force functions.
There does not seem to be any sensible and safe use of these
functions unless the return value is used somehow.
John Darrington [Fri, 1 Apr 2016 10:16:15 +0000 (12:16 +0200)]
Check the return value of various calls to lex_force_match.
John Darrington [Fri, 1 Apr 2016 09:44:17 +0000 (11:44 +0200)]
output.c: cmd_output: Check return values of lex_force_match
John Darrington [Fri, 1 Apr 2016 09:37:02 +0000 (11:37 +0200)]
variable-display.c (cmd_variable_level): Check return value of lex_force_match
John Darrington [Fri, 1 Apr 2016 09:30:44 +0000 (11:30 +0200)]
value-parser.c (parse_number): Simplified logic and removed redundant lines.
John Darrington [Thu, 31 Mar 2016 20:27:52 +0000 (22:27 +0200)]
Fix crash in NPAR when no variables were parsed.
Found by zzuf.
John Darrington [Thu, 31 Mar 2016 19:57:17 +0000 (21:57 +0200)]
Fix typo in NEWS
John Darrington [Thu, 31 Mar 2016 19:51:25 +0000 (21:51 +0200)]
Fixed a bug where frequencies/histogram would crash when all data had missing wieghts.
Found by zzuf.
Ben Pfaff [Thu, 31 Mar 2016 19:44:24 +0000 (12:44 -0700)]
po: Update Dutch translation.
John Darrington [Thu, 31 Mar 2016 08:19:07 +0000 (10:19 +0200)]
Updated NEWS to mention bugs fixed in command parser
John Darrington [Thu, 31 Mar 2016 08:14:05 +0000 (10:14 +0200)]
Fix crash when ROC was passed a non-number where a number was expected.
Found by zzuf.
John Darrington [Thu, 31 Mar 2016 07:19:35 +0000 (09:19 +0200)]
Fixed by where pspp would crash if ELSE appeared without a DO IF.
Found by zzuf.
John Darrington [Thu, 31 Mar 2016 06:22:44 +0000 (08:22 +0200)]
Fixed a bug where INSERT would crash when an unterminated string was given.
Found by zzuf.
Ben Pfaff [Thu, 31 Mar 2016 15:14:52 +0000 (08:14 -0700)]
po: Update German translation from translationproject.org.
John Darrington [Thu, 31 Mar 2016 12:44:57 +0000 (14:44 +0200)]
Fix crash when ONEWAY/CONTRASTS contained an empty list.
Found by zzuf.
John Darrington [Wed, 30 Mar 2016 15:42:44 +0000 (17:42 +0200)]
PsppireSelector: Do not add a default selector func, if an explicit one already exists
Fixes bug #47573.
John Darrington [Wed, 30 Mar 2016 06:17:48 +0000 (08:17 +0200)]
Fixed crash when processing malformed NPAR TESTS BINOMIAL command.
Found by zzuf.
Ben Pfaff [Wed, 30 Mar 2016 15:34:06 +0000 (08:34 -0700)]
po: Update Lithuanian translation.
John Darrington [Wed, 30 Mar 2016 10:04:54 +0000 (12:04 +0200)]
Avoid possible memory allocation error on erroneous input.
Valgrind showed a possible problem here.
John Darrington [Tue, 29 Mar 2016 11:17:25 +0000 (13:17 +0200)]
Cleanup the RENAME VARIABLES command.
Also fix some crashes which occured on invalid syntax.
Friedrich Beckmann [Tue, 29 Mar 2016 00:11:59 +0000 (02:11 +0200)]
use fixed format string to avoid -Wformat-security warning
The debian build fails due to the -Wformat-security check. This
change replaces a variable format string with a fixed format
string.
Ben Pfaff [Mon, 28 Mar 2016 15:31:46 +0000 (08:31 -0700)]
po: Update translations from translationproject.org.
John Darrington [Sun, 27 Mar 2016 11:51:53 +0000 (13:51 +0200)]
Fixed bug in EXAMINE where the parametric calculation would crash if the weight
variable contained a missing value.
Found by zzuf.
John Darrington [Sat, 26 Mar 2016 17:34:02 +0000 (18:34 +0100)]
Fix bug in EXAMINE when an invalid dependent variable was specified.
Found by zzuf.
John Darrington [Sun, 27 Mar 2016 06:11:38 +0000 (08:11 +0200)]
Update NEWS to keep make dist happy
John Darrington [Sun, 27 Mar 2016 05:08:20 +0000 (07:08 +0200)]
Update version number to 0.10.1
Ben Pfaff [Sat, 26 Mar 2016 17:30:51 +0000 (10:30 -0700)]
Update version number to 0.10.0.
John Darrington [Sat, 26 Mar 2016 16:36:59 +0000 (17:36 +0100)]
Fix bug in GRAPH when a bad dependent variable was specified.
Found by zzuf.
John Darrington [Sat, 26 Mar 2016 15:57:16 +0000 (16:57 +0100)]
Fix crash in FLIP with no variables.
Found by zzuf.
John Darrington [Sat, 26 Mar 2016 15:34:20 +0000 (16:34 +0100)]
Fix double heap deallocation when erroneous SET was specified.
Found by zzuf.
John Darrington [Sat, 26 Mar 2016 15:13:50 +0000 (16:13 +0100)]
Fixed crash in MODIFY OUTPUT when no valid FORMAT clause was specified.
Found by zzuf.
John Darrington [Sat, 26 Mar 2016 14:22:47 +0000 (15:22 +0100)]
Fix crash in oneway when an invalid dependent variable was specified.
Found by zzuf
John Darrington [Sat, 26 Mar 2016 07:48:14 +0000 (08:48 +0100)]
Fix crash in recode when the INTO variable was invalid.
Found by zzuf.
John Darrington [Sat, 26 Mar 2016 07:17:37 +0000 (08:17 +0100)]
Fix assertion failure when using PRINT with an empty argument.
Found by zzuf.
John Darrington [Fri, 25 Mar 2016 20:25:49 +0000 (21:25 +0100)]
Fix crash in ROC command when no valid state variable is given.
Found by zzuf.
John Darrington [Fri, 25 Mar 2016 19:13:46 +0000 (20:13 +0100)]
Fix crash when no indepdendent variable in NPAR is given.
Found by zzuf.
John Darrington [Fri, 25 Mar 2016 13:16:03 +0000 (14:16 +0100)]
Fix crash in DATA LIST when RECORDS and/or SKIP is negative
Found by zzuf
John Darrington [Fri, 25 Mar 2016 10:16:22 +0000 (11:16 +0100)]
Fix crash in LIST when no valid variables exist.
Found by zzuf.
John Darrington [Thu, 24 Mar 2016 22:13:18 +0000 (23:13 +0100)]
Fix crash in histogram when all values are missing.
Found by zzuf.
John Darrington [Thu, 24 Mar 2016 20:07:04 +0000 (21:07 +0100)]
Fix crash when running GET DATA with incomplete command.
Found by zzuf.
John Darrington [Thu, 24 Mar 2016 19:30:36 +0000 (20:30 +0100)]
Fixed crash in T-TEST when a non-number was passed where a number was expected.
Found by zzuf.
John Darrington [Thu, 24 Mar 2016 19:07:11 +0000 (20:07 +0100)]
Fix crash in correlations with empty dataset.
Found by zzuf.
John Darrington [Sun, 20 Mar 2016 19:41:14 +0000 (20:41 +0100)]
Provide an environment where cross-compiled tests can run in an emulator
This change allows some of the tests to run successfully under wine when
cross-compiled with mingw
John Darrington [Sun, 20 Mar 2016 18:34:34 +0000 (19:34 +0100)]
Prevent link error when cross compiling with mingw
John Darrington [Sun, 13 Mar 2016 08:54:36 +0000 (09:54 +0100)]
spreadsheet-reader.c: Do not export local symbols
Ben Pfaff [Sun, 20 Mar 2016 16:49:26 +0000 (09:49 -0700)]
SORT VARIABLES: Add test.
This should have been in the initial commit; sorry.
John Darrington [Sun, 20 Mar 2016 06:37:08 +0000 (07:37 +0100)]
README.Git: Update required Texinfo version
It seems that older makeinfo does not correctly generate the docbook format. Thanks to
Harry for finding this.
Ben Pfaff [Sun, 20 Mar 2016 00:19:45 +0000 (17:19 -0700)]
Implement new command SORT VARIABLES.
John Darrington [Sat, 19 Mar 2016 18:41:35 +0000 (19:41 +0100)]
Fix error in dist-hook-git.
The previous commit introduced a new "meta" file. But it provoked our test for
missing distribution files. This change fixes that.
John Darrington [Fri, 18 Mar 2016 10:14:20 +0000 (11:14 +0100)]
Added a "meta" file, explaining administrative procedures for bug handling
Ben Pfaff [Sun, 13 Mar 2016 19:10:22 +0000 (12:10 -0700)]
expressions: Add support for mult and fuzzbits arguments to TRUNC function.
Ben Pfaff [Sun, 13 Mar 2016 18:39:29 +0000 (11:39 -0700)]
expressions: Implement the STRUNC function.
Ben Pfaff [Sun, 13 Mar 2016 18:20:22 +0000 (11:20 -0700)]
expressions: Implement the MEDIAN function.
Ben Pfaff [Sun, 13 Mar 2016 17:10:35 +0000 (10:10 -0700)]
doc: Document that value labels are case sensitive.
This was not documented and a user found it surprising.
Also, long string variables can now be labeled.
Reported by Robert Pittman.
John Darrington [Sun, 13 Mar 2016 12:19:10 +0000 (13:19 +0100)]
Enable case insensitivity test.
The operative part of this test seemed to have been inadvertently omitted.
John Darrington [Mon, 7 Mar 2016 18:16:00 +0000 (19:16 +0100)]
PsppireKeypad: Remove gdkkeysyms-compat.h
John Darrington [Fri, 4 Mar 2016 19:09:00 +0000 (20:09 +0100)]
Pipe read test: Replace "echo" with "printf"
This test was failing on GuixSD
John Darrington [Tue, 1 Mar 2016 18:28:20 +0000 (19:28 +0100)]
DATA LIST: Do not treat the comma as a field separator if DECIMAL=COMMA
Closes bug #47253
John Darrington [Tue, 1 Mar 2016 05:24:54 +0000 (06:24 +0100)]
Speed up rendering of columns in sheet.
This change causes _pspp_sheet_view_install_mark_rows_col_dirty to be called once
per sheet, instead of once per column when adding/deleting columns. Hence there
is a significant speed improvement when dealing with a data sheet with a large
number of variables.
Fixes bug #47090
Ben Pfaff [Sun, 28 Feb 2016 00:47:27 +0000 (16:47 -0800)]
psppire: Remove unused function.
Ben Pfaff [Sat, 27 Feb 2016 22:53:59 +0000 (14:53 -0800)]
gui: Add some generated files to .gitignore files.
Reported by Friedrich Beckmann.
Bug #47265.
John Darrington [Fri, 26 Feb 2016 16:39:48 +0000 (17:39 +0100)]
Remove attempts do destroy windows before quit.
This change deletes an attempt to remove all existing
windows from a list (and thereby unreffing and deleting them).
The attempt fails, because lists may not be altered whilst
iterating them. This resulted only in a Critical Warning.
It is also pointless to attempt to destroy windows immediately
priot to quit.
John Darrington [Fri, 26 Feb 2016 15:29:25 +0000 (16:29 +0100)]
Updated de.po from translationproject.org
John Darrington [Fri, 29 Jan 2016 07:02:47 +0000 (08:02 +0100)]
psppire-selector.c: Remove unused preprocessor macro
Ben Pfaff [Sun, 21 Feb 2016 19:51:05 +0000 (11:51 -0800)]
Fix several cases where lex_integer() or lex_number() could assert-fail.
The caller always needs to make sure in advance that the token is in fact
an integer or a number.
Ben Pfaff [Sun, 21 Feb 2016 05:38:38 +0000 (21:38 -0800)]
EXAMINE: Fix memory leak in box-whisker plots.
Found by valgrind.
Reported by John Darrington.
Bug #47074.
Ben Pfaff [Sun, 21 Feb 2016 05:21:06 +0000 (21:21 -0800)]
render: Fix memory leaks in rendering.
References were being taken that should not have been.
Found by valgrind.
Reported by John Darrington.
Bug #47074.
Ben Pfaff [Sun, 21 Feb 2016 05:20:03 +0000 (21:20 -0800)]
cairo: Fix memory leak of pango_layout_iter.
Found by valgrind.
Reported by John Darrington.
Bug #47074.
Ben Pfaff [Sun, 21 Feb 2016 04:29:38 +0000 (20:29 -0800)]
table: Fix memory leak.
table_create_nested_item() was documented to take ownership of its
argument but in fact it took a reference on it, creating a leak.
Found by valgrind.
Reported by John Darrington.
Bug #47074.
Ben Pfaff [Sun, 21 Feb 2016 04:05:12 +0000 (20:05 -0800)]
pc+-file-reader: Fix memory leak.
Found by valgrind.
Ben Pfaff [Sun, 21 Feb 2016 01:12:17 +0000 (17:12 -0800)]
expressions: Implement the REPLACE string function.
Requested by Frans Houweling.
Ben Pfaff [Sun, 21 Feb 2016 00:43:21 +0000 (16:43 -0800)]
expressions: Merge all the little generator programs into generate.pl.
The little generator programs had a bizarre flaw: they silently produced
no output if there was an error parsing their input. This was due to the
use of the Perl "do" construct for executing generate.pl, which just
returns the message if the nested code exits with "die". I know that the
generators actually worked better at one point...
Anyway, the simplest solution seems to be to just merge all the little
output generator programs into generate.pl. It doesn't make the code any
harder to understand, so that's what this commit does.
Ben Pfaff [Sun, 21 Feb 2016 00:33:54 +0000 (16:33 -0800)]
Makefiles: Fix use of $(AM_V_at) in makefile rules.
These are only for use at the beginning of a rule and cause weirdness in
the middle since they expand to directives that begin with @, which "make"
understands but the shell does not.
Ben Pfaff [Sat, 20 Feb 2016 18:14:22 +0000 (10:14 -0800)]
pspp-convert: Fix use of uninitialized data in error case.
Found by GCC.
Ben Pfaff [Sat, 20 Feb 2016 18:12:48 +0000 (10:12 -0800)]
sys-file-reader: Read system files with multiple subtype-18 extensions.
These are written by "Stata 14.1/-savespss- 1.77 by S.Radyakin". I think
it's really a bug in that writer, but if SPSS accepts these files then I
guess PSPP should too.
Reported by news <news.ftr@free.fr>.
Bug #47089.
John Darrington [Sat, 20 Feb 2016 12:12:06 +0000 (13:12 +0100)]
FREQUENCIES BARCHART: Honour then PERCENT option
Fixes bug: #47180
Ben Pfaff [Sat, 20 Feb 2016 05:35:53 +0000 (21:35 -0800)]
MISSING VALUES: Report an error when too many missing values are specified.
Reported by news <news.ftr@free.fr>.
John Darrington [Thu, 18 Feb 2016 07:23:28 +0000 (08:23 +0100)]
Barchart.c: Change type of flag from int to bool
John Darrington [Thu, 18 Feb 2016 06:56:42 +0000 (07:56 +0100)]
Do not attempt to draw whiskers on boxplots if they are NaN.
Reported by: Friedrich Beckmann
Closes Bug: #47140
John Darrington [Thu, 18 Feb 2016 05:51:07 +0000 (06:51 +0100)]
Fixed bug where an empty chart (one with no data) would crash.
Reported by: Friedrich Beckmann
Fixes bug: #47181
John Darrington [Tue, 16 Feb 2016 11:35:17 +0000 (12:35 +0100)]
Boxplot: Do not attempt to draw whiskers if they are not defined
Friedrich Beckmann [Tue, 16 Feb 2016 09:30:32 +0000 (10:30 +0100)]
histogram - added another upper bin to include cases which have max values
This fixes the problem that cases which have values exactly at the upper
bin limit of the upper bin are not included in the binning. The fix
is based on the idea from John to just add another bin when the bin
limit is just equal to the maximum case value.
Friedrich Beckmann [Tue, 16 Feb 2016 09:16:22 +0000 (10:16 +0100)]
Revert "histogram - fixed missing cases which have the maximum value"
This reverts commit
ca4012bcf0f8790ceb8539b55bbc296d0802d5d7.
Friedrich Beckmann [Mon, 15 Feb 2016 18:40:22 +0000 (19:40 +0100)]
histogram - changed bin range computation
The bin range computation for the histogram showed bin limits at 4.999999
when 5.0 was expected. Added values with value 5.0 were therefore added
to the following bin. With this change the bin limits do not show the
rounding error. At least I could not reproduce the error that showed
up when using the routing from gsl_histogram_set_ranges_uniform.
Friedrich Beckmann [Mon, 15 Feb 2016 18:26:43 +0000 (19:26 +0100)]
histogram - fixed missing cases which have the maximum value
The histogram uses gsl_histogram routines which exclude values from
the last bin when the value is exactly the maximum value, i.e. the upper
value of the last bin. This results in excluded cases in the histogram.
This fixes bug #47139: https://savannah.gnu.org/bugs/?47139
Friedrich Beckmann [Sun, 14 Feb 2016 19:44:15 +0000 (20:44 +0100)]
MacOS build - fixed src/libpspp/automake.c version.c generation
The build on MacOS failed because echo introduces newlines which
produces syntax errors in the generated version.c file. I replaced the
echo with printf.
Fixes bug #47143: http://savannah.gnu.org/bugs/?47143
John Darrington [Tue, 9 Feb 2016 01:52:33 +0000 (02:52 +0100)]
Update fr.po from translationproject.org