Fixed a bug where frequencies/histogram would crash when all data had missing wieghts.

Found by zzuf.

diff --git a/src/language/stats/frequencies.c b/src/language/stats/frequencies.c
index dc18ed83c79589cf3c028cc872e84fb934dabfe8..cb963897786d6f19c9c44cb8b12dca5cc4f1a460 100644 (file)
--- a/src/language/stats/frequencies.c
+++ b/src/language/stats/frequencies.c
@@ -1324,6 +1324,8 @@ freq_tab_to_hist (const struct frq_proc *frq, const struct freq_tab *ft,
         }
     }
 
+  if (valid_freq <= 0)
+    return NULL;
 
   iqr = calculate_iqr (frq);
 

diff --git a/tests/language/stats/frequencies.at b/tests/language/stats/frequencies.at
index 0d6433c5b938c7eb25bdea3a3bb2367b987d6b4d..f0d81c321075d4edec21af52a38520acf88fd03a 100644 (file)
--- a/tests/language/stats/frequencies.at
+++ b/tests/language/stats/frequencies.at
@@ -739,3 +739,25 @@ Percentiles,,.
 ])
 
 AT_CLEANUP
+
+
+AT_SETUP([FREQUENCIES histogram no valid cases])
+AT_DATA([empty.sps], [dnl
+data list notable list /x w *.
+begin data.
+1 .
+2 .
+3 .
+end data.
+
+weight by w.
+
+FREQUENCIES
+       /VARIABLES = x
+       /histogram
+       .
+])
+
+AT_CHECK([pspp empty.sps -O format=csv], [0],  [ignore])
+
+AT_CLEANUP