Friedrich Beckmann [Fri, 22 May 2015 07:44:19 +0000 (09:44 +0200)]
repair glade; switched to gladeui-2.0; removed the internal-child in psppire-dialog.
Friedrich Beckmann [Thu, 21 May 2015 21:46:22 +0000 (23:46 +0200)]
gtk3: replaced gtk_widget_register_window with older code depending on gtk version (pre 3.8)
Friedrich Beckmann [Thu, 21 May 2015 06:18:58 +0000 (08:18 +0200)]
gtk3 - fix to show selected cells with adwaita theme
Friedrich Beckmann [Sun, 17 May 2015 13:01:16 +0000 (15:01 +0200)]
gtk3 - adapted draw routine to gtk_cairo_should_draw_window. gtk-criticals with undefined drag window disappeared. The gtk-criticals showed up in debian 8.
John Darrington [Wed, 20 May 2015 14:29:57 +0000 (16:29 +0200)]
gtk3: Replace gdk_window_get_pointer with gdk_window_get_device_position
John Darrington [Tue, 19 May 2015 16:12:37 +0000 (18:12 +0200)]
Gtk+3: Replace deprecated gtk_layout_get_vadjustment with gtk_scrollable_get_vadjustment
John Darrington [Tue, 19 May 2015 15:09:54 +0000 (17:09 +0200)]
Gtk+3: Replace deprecated gtk_widget_size_request with gtk_widget_get_preferred_size
John Darrington [Tue, 19 May 2015 14:51:23 +0000 (16:51 +0200)]
Gtk+3: Replace deprecated gtk_cell_renderer_get_size with gtk_cell_renderer_get_preferred_width
Friedrich Beckmann [Sun, 17 May 2015 14:20:57 +0000 (16:20 +0200)]
gtk3 - added NULL check to tt_test_options_dialog_destroy - psppire crashed during exit on debian 8
John Darrington [Sun, 17 May 2015 06:20:04 +0000 (08:20 +0200)]
Fix GtkCritical whilst displaying last line of variable view.
Closes bug #45112
John Darrington [Sat, 16 May 2015 12:25:25 +0000 (14:25 +0200)]
Fix crash when cancelling variable type dialog.
Fixes bug #45114
John Darrington [Thu, 14 May 2015 17:01:24 +0000 (19:01 +0200)]
Sheet View optimisation: Do not attempt to draw sheet cells which lie outside of the exposed area.
Friedrich Beckmann [Sun, 3 May 2015 20:22:02 +0000 (22:22 +0200)]
fixed initial show of names in header window. Variable names only showed up after switching between variable and data window. The reason is that the buttons of the columns are not created. This is due to interdependency between the size allocation and the button creation. I removed the need_button mechanism.
Friedrich Beckmann [Sun, 3 May 2015 18:50:31 +0000 (20:50 +0200)]
Fixed horizontal scrolling for header window (variable names)
Friedrich Beckmann [Fri, 1 May 2015 09:04:20 +0000 (11:04 +0200)]
merge master->gtk3, fixed psppire-output-view.c refactoring; this compiles and runs but the window update is only working partly
Friedrich Beckmann [Fri, 24 Apr 2015 16:53:13 +0000 (18:53 +0200)]
Switch the order in which scatterplot axes appear in the graphic's caption.
Hulliger Beat <beat.hulliger@fhnw.ch> Reported that scatterplots were titled 'x vs. y'
where x and y were opposite to what is conventional. This change fixes that.
Friedrich Beckmann [Fri, 24 Apr 2015 16:42:57 +0000 (18:42 +0200)]
Allow data used by GRAPH /SCATTERPLOT to persist after the procedure has ended.
Fixes bug #44877
Friedrich Beckmann [Fri, 24 Apr 2015 16:21:11 +0000 (18:21 +0200)]
Whitespace changes only.
Ben Pfaff [Thu, 23 Apr 2015 01:56:16 +0000 (18:56 -0700)]
po: Update translations from translationproject.org.
John Darrington [Wed, 8 Apr 2015 08:54:35 +0000 (10:54 +0200)]
Update glib requirements to version 2.32 or later
Ben Pfaff [Thu, 26 Mar 2015 04:47:17 +0000 (21:47 -0700)]
po: Update translations from translationproject.org.
Ben Pfaff [Sat, 14 Mar 2015 19:38:43 +0000 (12:38 -0700)]
po: Add Chinese (simplified) translation.
Ben Pfaff [Tue, 10 Mar 2015 02:45:32 +0000 (19:45 -0700)]
help-pages-list: Distribute.
Otherwise "make distcheck" will have to regenerate it, which means
that it will have to regenerate doc/pspp.xml (because it depends on
help-pages-list) but that's not possible under "make distcheck"
because it makes the source directory read-only.
Found by PSPP autobuilder.
Ben Pfaff [Sun, 8 Mar 2015 20:41:01 +0000 (13:41 -0700)]
RELIABILITY: Ignore STATISTICS subcommand.
Statistics aren't yet implemented but it's more friendly to produce
everything we can than to fail the whole command.
Thanks to Tom Smekens for reporting the problem.
Ben Pfaff [Sun, 8 Mar 2015 20:34:10 +0000 (13:34 -0700)]
configure: Create "doc" directory in build directory.
Otherwise we get build failures from the autobuilder when the rule
in gui/automake.mk tries to create doc/help-pages-list. Problem
introduced in commit
531de52e961c (PsppireDialog: New property:
help-page).
Developers probably didn't notice this problem because they probably
already had doc/ directories in their build directories due to
building PDF versions of the documentation at one time or another, or
because they do builds in the source directory.
Found by examining autobuilder failures.
Ben Pfaff [Sun, 8 Mar 2015 20:20:26 +0000 (13:20 -0700)]
FACTOR: Support ANALYSIS subcommand.
This appears in syntax generated by SPSS.
Thanks to Tom Smekens for reporting the omission.
Ben Pfaff [Sat, 7 Mar 2015 08:36:42 +0000 (00:36 -0800)]
expressions: Add support for 2- and 3-operand RND function.
Requested by Tom Smekens.
Ben Pfaff [Sat, 7 Mar 2015 07:47:36 +0000 (23:47 -0800)]
FREQUENCIES: Accept (but ignore) ORDER subcommand.
Allows syntax generated by SPSS to work.
Reported by Tom Smekens.
Ben Pfaff [Fri, 6 Mar 2015 05:27:56 +0000 (21:27 -0800)]
RENAME VARIABLES: Make parentheses optional for single variables.
This matches SPSS documented behavior.
Reported by Tom Smekens.
Ben Pfaff [Fri, 6 Mar 2015 04:43:50 +0000 (20:43 -0800)]
psppire-dialog: Fix incompatible pointer type.
Ben Pfaff [Fri, 6 Mar 2015 04:43:31 +0000 (20:43 -0800)]
doc: Fix use of $(AM_V_at).
It has to come at the beginning of the command since it expands to
@ and only "make" (not the shell) understands that.
Ben Pfaff [Tue, 24 Feb 2015 16:30:08 +0000 (08:30 -0800)]
doc: Document decryption support in pspp-convert.
Reported by tylar <murray.tylar@gmail.com>.
John Darrington [Sat, 21 Feb 2015 12:27:24 +0000 (13:27 +0100)]
Frequencies Dialog: Add the ability to specify a bar chart
John Darrington [Sun, 15 Feb 2015 16:26:00 +0000 (17:26 +0100)]
PsppireDialog: New property: help-page
New property to indicate the manual page which should be opened
when the Help button is clicked.
Ben Pfaff [Mon, 16 Feb 2015 17:33:43 +0000 (09:33 -0800)]
doc: MATCH FILES/ADD FILES/UPDATE can combine any number of files.
Suggested by Daniel Schlieper.
John Darrington [Mon, 16 Feb 2015 08:17:12 +0000 (09:17 +0100)]
tests/math/decimal-test.c (canonicalise-string): Fix uninitialised return value
Ben Pfaff [Sun, 15 Feb 2015 22:52:11 +0000 (14:52 -0800)]
COUNT: Correct treatment of missing values.
COUNT didn't properly handle user-missing values or the MISSING
keyword. This corrects the problem.
Thanks to ftr <news.ftr@free.fr> for reporting this bug.
Bug #44157.
John Darrington [Sun, 15 Feb 2015 12:08:59 +0000 (13:08 +0100)]
Smake: Made the configure target slightly more fail safe
John Darrington [Sun, 15 Feb 2015 11:56:29 +0000 (12:56 +0100)]
Makefile rule pspp.xml: Simplify slightly
John Darrington [Sat, 14 Feb 2015 19:39:21 +0000 (20:39 +0100)]
Examine Dialog: Fix widget focus order
John Darrington [Sat, 14 Feb 2015 14:19:33 +0000 (15:19 +0100)]
Dialog boxes: Grab focus of the source widget on reset
John Darrington [Thu, 12 Feb 2015 19:38:11 +0000 (20:38 +0100)]
Minor update to documentation for FREQUENCIES
John Darrington [Mon, 9 Feb 2015 06:37:36 +0000 (07:37 +0100)]
Documentation: Tidy up notes about histogram bin widths
John Darrington [Sat, 24 Jan 2015 15:42:07 +0000 (16:42 +0100)]
Added the /BARCHART option to CROSSTABS
John Darrington [Sat, 7 Feb 2015 13:13:24 +0000 (14:13 +0100)]
tests/chart.at: -O format=csv changed to -o pspp.txt
If no output file is specified, no charts get generated. Since these
tests are "no crash only" tests, we want to exercise as much code as
possible
John Darrington [Mon, 2 Feb 2015 07:28:03 +0000 (08:28 +0100)]
Corrected typo in syntax generation for value chooser.
Closes bug #43623
John Darrington [Fri, 23 Jan 2015 18:26:26 +0000 (19:26 +0100)]
Remove untrue statement from comment
John Darrington [Fri, 23 Jan 2015 18:23:43 +0000 (19:23 +0100)]
Ensure that example_dir is relocatable.
commit
be1157c5591142920a95d587acf97f5eaf3d04fe added a reference to the
installed data directory. Unfortunately I forgot to allow for relocatable
installations. This change fixes that.
John Darrington [Thu, 22 Jan 2015 19:56:19 +0000 (20:56 +0100)]
Add examples directory "shortcut" to file_open dialog
John Darrington [Sun, 18 Jan 2015 10:43:06 +0000 (11:43 +0100)]
Frequencies: Added the /BARCHART subcommand.
John Darrington [Sun, 18 Jan 2015 14:19:10 +0000 (15:19 +0100)]
Piecharts: Avoid the segment fill obscuring the labels
John Darrington [Mon, 19 Jan 2015 15:01:06 +0000 (16:01 +0100)]
Piecharts: Remove trailing whitespace from slice labels
John Darrington [Sat, 17 Jan 2015 12:04:52 +0000 (13:04 +0100)]
Fix logic error in previous commit
John Darrington [Fri, 16 Jan 2015 13:43:48 +0000 (14:43 +0100)]
replace_file_start: On error, ensure that the appropriate errno value is held
John Darrington [Tue, 6 Jan 2015 06:25:21 +0000 (07:25 +0100)]
New module to perform decimal floating point arithmetic for charts.
This change adds a small module to perform floating point arithmetic
with a decimal base, and uses it to calculate the graticule marks for
charts.
Rationale: Graticule marks want to be displayed in decimal. However
not all decimal values can be represented in a double precision
floating point binary. This approach pushes the precision loss from
the value of the mark, to the position on the chart - we don't
particularly care if a tick mark is a fraction of a pixel out of place,
but we do care if 4.0 is displayed as 3.
9999999999
Reviewed-by: Ben Pfaff
Ben Pfaff [Thu, 15 Jan 2015 15:22:15 +0000 (07:22 -0800)]
build-aux/icon-list: Make executable.
Somehow I checked in this script as non-executable. This fixes the
problem.
Reported by Harry Thijssen.
Ben Pfaff [Mon, 12 Jan 2015 00:05:44 +0000 (16:05 -0800)]
Smake: Factor output repetitive code into new script in build-aux.
I planned to add another kind of icon but even without that change
this makes the code more readable.
John Darrington [Fri, 9 Jan 2015 08:50:42 +0000 (09:50 +0100)]
Fix minor typos in documentation
John Darrington [Wed, 7 Jan 2015 19:03:09 +0000 (20:03 +0100)]
Syntax Window: Simplify the Edit|Paste callback.
Apparently pasting into the Syntax Window under Windoze didn't work.
This change makes the EditPaste callback simpler and apparently it
fixes the problem.
Thanks to Alan Mead for reporting the problem and to Harry Thissen
for testing the fix.
John Darrington [Sat, 3 Jan 2015 14:48:35 +0000 (15:48 +0100)]
Fix compiler warnings on 64 bit machines
Ben Pfaff [Sun, 4 Jan 2015 19:14:01 +0000 (11:14 -0800)]
cairo: Remove claim that a null 'cairo' can work.
We found out in bug #43816 that it doesn't really work and isn't
worth maintaining anyhow.
Ben Pfaff [Sun, 4 Jan 2015 19:13:01 +0000 (11:13 -0800)]
psppire-output-view: Fix segfault during printing.
psppire-output-view tried to make use of a special feature in the
cairo output driver that allowed the cairo_t to be omitted to avoid
actually rendering anything, for pagination purposes, but the cairo
code had changed and this feature had not been carefully maintained,
resulting in a segfault. This commit stops trying to use that
feature, since it seems like it could easily get broken again in the
future and doesn't have much benefit anyhow.
Bug #43816.
Reported by John Darrington.
John Darrington [Sat, 3 Jan 2015 10:37:11 +0000 (11:37 +0100)]
Correct documentation example and add a corresponding test.
The tutorial section of the manual contained an example which
did not correspond to real results. This change corrects the
example and adds a test for it.
Reported-by: Robin Reeves <robin.r@hotmail.co.uk>
John Darrington [Fri, 2 Jan 2015 13:42:15 +0000 (14:42 +0100)]
Examine: Change the positioning of the whiskers on boxplots.
The positioning of the whiskers on boxplots was unconventional.
This change places the whiskers on the highest/lowest datum which
is not an outlier.
Thanks to Alan Mead for reporting this.
John Darrington [Mon, 29 Dec 2014 08:31:48 +0000 (09:31 +0100)]
Factor: fix memory leaks relating to PROMAX and update NEWS
Ben Pfaff [Sun, 28 Dec 2014 16:49:50 +0000 (08:49 -0800)]
factor: Comment out unused functions.
Ben Pfaff [Sun, 28 Dec 2014 16:49:36 +0000 (08:49 -0800)]
configure: Drop -Wdeclaration-after-statement.
We keep getting new instances of this warning in the tree, and it's
not really necessary these days since even MSVC supports mid-block
declarations now.
Ben Pfaff [Sun, 28 Dec 2014 16:46:49 +0000 (08:46 -0800)]
doc: Document pspp-dump-sav.
Requested by Harry Thijssen.
Bug #43857.
John Darrington [Fri, 19 Dec 2014 10:30:17 +0000 (11:30 +0100)]
Add some entries to .gitignore
John Darrington [Thu, 18 Dec 2014 14:37:22 +0000 (15:37 +0100)]
FACTOR: Added PROMAX rotation.
John Darrington [Sun, 14 Dec 2014 00:51:44 +0000 (01:51 +0100)]
File Export: Added a "plain text" option.
In the File|Export menu of the output window, enabled unicode box characters for
the "Text" output, and added a "Text (plain)" menuitem without this feature.
Ben Pfaff [Mon, 8 Dec 2014 06:36:36 +0000 (22:36 -0800)]
doc: Add section on how to exit PSPP to the tutorial.
Daniel Schlieper reported that he had trouble figuring out how to
exit. The FINISH command was already documented, but it wasn't
mentioned in the tutorial, so perhaps this will help.
Bug #43766.
Ben Pfaff [Mon, 8 Dec 2014 06:34:21 +0000 (22:34 -0800)]
command: Fix delayed execution of FINISH.
PSPP delayed the execution of FINISH until it read the first token
of the next command. This commit changes it to execute immediately,
as one would expect..
Reported by Daniel Schlieper.
Bug #43766.
Daniel Schlieper [Mon, 8 Dec 2014 06:17:30 +0000 (22:17 -0800)]
command: Add STEMLEAF to list of unimplemented commands.
Ben Pfaff [Mon, 8 Dec 2014 06:13:44 +0000 (22:13 -0800)]
README.Git: Upgrade recommended Gnulib version.
Harry Thijssen reported that the older version of Gnulib failed to
build (in msvc-inval.c) on Windows, but that the newer version built
fine with the exception of the error that should have been fixed by
the previous commit.
Discussion at:
http://lists.gnu.org/archive/html/pspp-dev/2014-12/msg00014.html
Ben Pfaff [Mon, 8 Dec 2014 06:10:54 +0000 (22:10 -0800)]
lexer: Include <unistd.h> to ensure 'read' is consistently replaced.
On some platforms, Gnulib #defines read to rpl_read. The lexer uses
an unreleated function pointer member named 'read' in struct
lex_reader_class. It doesn't really matter whether this name gets
replaced with rpl_read as long as it always happens consistently.
Adding "#include <unistd.h>" to lexer.h should ensure that.
Reported by Harry Thijssen.
Ben Pfaff [Mon, 8 Dec 2014 05:32:40 +0000 (21:32 -0800)]
tests: Fix unintended platform dependency in portable file test.
Reported by Jeremy Lavergne.
Daniel Schlieper [Sun, 7 Dec 2014 17:31:34 +0000 (09:31 -0800)]
doc: Describe how bin sizes are chosen for histograms.
John Darrington [Fri, 5 Dec 2014 10:53:13 +0000 (11:53 +0100)]
FREQUENCIES: Fix bug when combining HISTOGRAM with PERCENTILES.
This bug was reported only on windows, but had the potential to
affect any system.
Thanks to "Dr. Yaron Ghilay" <gy21@inter.net.il> for reporting
the bug, and to Kai.Borgolte@gmx.de for diagnosing it.
Ben Pfaff [Sun, 30 Nov 2014 21:19:05 +0000 (13:19 -0800)]
FREQUENCIES: Allow percentiles to be comma-separated.
Reported by Dr. Yaron Ghilay.
Ben Pfaff [Sat, 29 Nov 2014 20:03:06 +0000 (12:03 -0800)]
po: Add Polish translation.
Ben Pfaff [Sat, 29 Nov 2014 19:56:15 +0000 (11:56 -0800)]
Add support for weighting variables in SPSS/PC+ system files.
Based on a file provided by Alan Mead.
Ben Pfaff [Sat, 29 Nov 2014 05:16:23 +0000 (21:16 -0800)]
Add support for reading SPSS/PC+ system files.
Thanks to Alan Mead for supplying most of the files in the corpus used to
determine the SPSS/PC+ system file format.
Ben Pfaff [Sat, 15 Nov 2014 18:36:32 +0000 (10:36 -0800)]
po: Update translations from translationproject.org.
John Darrington [Wed, 29 Oct 2014 15:22:05 +0000 (16:22 +0100)]
Documentation: Add some comments to the bugs chapter
Ben Pfaff [Tue, 4 Nov 2014 16:28:59 +0000 (08:28 -0800)]
po: Add Galician translation.
John Darrington [Tue, 28 Oct 2014 15:21:02 +0000 (16:21 +0100)]
FREQUENCIES: Fixed crash when there was no valid data
John Darrington [Tue, 28 Oct 2014 16:39:27 +0000 (17:39 +0100)]
GRAPH: Use complete strings instead of constructing them
This makes life easier for the translators.
Ben Pfaff [Sat, 25 Oct 2014 16:32:35 +0000 (09:32 -0700)]
po: Update translations from translationproject.org.
Ben Pfaff [Sat, 18 Oct 2014 19:11:34 +0000 (12:11 -0700)]
cairo: Add .5pt gutter around table rules.
Commit
d3fef25674baf4f4 (output: Add footnote support.) removed the 3-pt
gutter around table rules, instead putting a margin around cell contents.
This usually worked out fine, but for some tables in the GUI it caused the
rightmost rule in the table to disappear. This is probably some kind of
off-by-one error in table size computation or clipping. We may have to
eventually resolve that. However, this commit seems like an adequate
temporary fix: instead of fixing the off-by-one error, add a thin gutter
around the rules, so that the actual content of the rule doesn't get
clipped off.
Ben Pfaff [Sat, 18 Oct 2014 19:06:11 +0000 (12:06 -0700)]
pspp-dev.texi: Add authors as @author arguments.
With a blank @author, makeinfo complains.
Without @author at all, the title page in TeX output looks funny.
So this commit simply names the authors, as determined by "git log" on
the doc/dev directory.
Ben Pfaff [Sat, 18 Oct 2014 17:38:53 +0000 (10:38 -0700)]
psppire-output-view: Properly render the first few items of output.
Commit
18f9e37c8bc5 (psppire-output-view: Only render output items once the
window is realized.) fixed a crashing bug, but when I tested it I didn't
carefully look at the output. In fact, any output items that were rendered
before the window was realized were not displayed, because the widgets
created for them were never shown or properly initialized. This commit
fixes the problem.
Reported by Adam Zammit.
Bug #43362.
John Darrington [Sat, 18 Oct 2014 06:30:10 +0000 (08:30 +0200)]
FREQUENCIES: Fix the default /STATISTICS.
The subcommand /STATISTICS (with nothing following) should be the same as /STATISTICS = DEFAULT.
John Darrington [Sat, 18 Oct 2014 06:56:56 +0000 (08:56 +0200)]
Frequencies.c: Use BIT_INDEX (FRQ_ST_MEDIAN) instead of FRQ_ST_MEDIAN.
Closes bug #43427
Ben Pfaff [Sun, 12 Oct 2014 16:49:49 +0000 (09:49 -0700)]
DISPLAY: Fix crash bugs in DISPLAY INDEX and DISPLAY NAMES.
Bug #43365.
Thanks to Mindaugus for reporting this bug.
Ben Pfaff [Thu, 9 Oct 2014 05:39:18 +0000 (22:39 -0700)]
psppire-output-view: Only render output items once the window is realized.
Otherwise, in environments where the output view is not rendered
immediately upon the call to gtk_widget_show_all() from
psppire_output_submit(), psppire_output_view_put() called later in that
function would dereference a null pointer trying to create a rendering
from a null GTK_WIDGET (view->output)->window.
Bug #43362.
Ben Pfaff [Tue, 7 Oct 2014 15:20:46 +0000 (08:20 -0700)]
Updated localisations from translation-project.org.
Friedrich Beckmann [Sun, 5 Oct 2014 20:07:23 +0000 (22:07 +0200)]
gui: Set StartupNotify=false because Startup Notification does not work.
Ben Pfaff [Sat, 4 Oct 2014 18:01:16 +0000 (11:01 -0700)]
po: Update translations from translationproject.org.
Friedrich Beckmann [Tue, 30 Sep 2014 07:57:04 +0000 (09:57 +0200)]
doc: Add PSPPIRE manpage, add example to manpages, install manpages.