Prevent crash under certain pathological results.

[pspp-builds.git] / src / ui / gui / variable-info-dialog.c

diff --git a/src/ui/gui/variable-info-dialog.c b/src/ui/gui/variable-info-dialog.c
index 04e38f273602a7ab2282c664e303acd63f104bde..ba9c043dcd53fb0eaf5cc5a8239f5636327cb838 100644 (file)
--- a/src/ui/gui/variable-info-dialog.c
+++ b/src/ui/gui/variable-info-dialog.c
@@ -76,6 +76,8 @@ populate_text (GtkTreeView *treeview, gpointer data)
 
   GtkTextBuffer *textbuffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW(data));
   const struct variable *var = get_selected_variable (treeview);
+  if ( var == NULL)
+    return;
 
   gstring = g_string_sized_new (200);
   text = name_to_string (var, NULL);
@@ -142,6 +144,21 @@ populate_text (GtkTreeView *treeview, gpointer data)
   g_string_free (gstring, TRUE);
 }
 
+static gboolean
+treeview_item_selected (gpointer data)
+{
+  GtkTreeView *tv = GTK_TREE_VIEW (data);
+  GtkTreeModel *model = gtk_tree_view_get_model (tv);
+
+  gint n_rows = gtk_tree_model_iter_n_children  (model, NULL);
+
+  if ( n_rows == 0 )
+    return FALSE;
+
+  return TRUE;
+}
+
+
 static gchar * generate_syntax (GtkTreeView *treeview);
 
 
@@ -158,11 +175,9 @@ variable_info_dialog (GObject *o, gpointer data)
   GtkWidget *treeview = get_widget_assert (xml, "treeview2");
   GtkWidget *textview = get_widget_assert (xml, "textview1");
 
-  GtkSheet *var_sheet =
-    GTK_SHEET (get_widget_assert (de->xml, "variable_sheet"));
-
+  PsppireVarStore *vs = NULL;
 
-  PsppireVarStore *vs = PSPPIRE_VAR_STORE (gtk_sheet_get_model (var_sheet));
+  g_object_get (de->data_editor, "var-store", &vs, NULL);
 
   gtk_window_set_transient_for (GTK_WINDOW (dialog), de->parent.window);
 
@@ -178,39 +193,24 @@ variable_info_dialog (GObject *o, gpointer data)
 
   gtk_text_view_set_indent (GTK_TEXT_VIEW (textview), -5);
 
+  psppire_dialog_set_valid_predicate (PSPPIRE_DIALOG (dialog),
+                                     treeview_item_selected, treeview);
+
   response = psppire_dialog_run (PSPPIRE_DIALOG (dialog));
 
   switch (response)
     {
     case PSPPIRE_RESPONSE_GOTO:
       {
-       gint row, col;
-       GtkNotebook *notebook = GTK_NOTEBOOK
-         (get_widget_assert (de->xml,"notebook"));
-
        const struct variable *var =
          get_selected_variable (GTK_TREE_VIEW (treeview));
 
+       if ( NULL == var)
+         goto done;
 
-       if (PAGE_VAR_SHEET == gtk_notebook_get_current_page (notebook))
-         {
-           GtkSheet *var_sheet =
-             GTK_SHEET (get_widget_assert (de->xml, "variable_sheet"));
-
-           gtk_sheet_get_active_cell (var_sheet, &row, &col);
-           row = var_get_dict_index (var);
-           gtk_sheet_set_active_cell (var_sheet, row, col);
-         }
-       else
-         {
-           GtkSheet *data_sheet =
-             GTK_SHEET (get_widget_assert (de->xml, "data_sheet"));
-
-           gtk_sheet_get_active_cell (data_sheet, &row, &col);
-           col = var_get_dict_index (var);
-           gtk_sheet_set_active_cell (data_sheet, row, col);
-         }
+       g_object_set (de->data_editor, "current-variable",  var_get_dict_index (var), NULL);
       }
+
       break;
     case PSPPIRE_RESPONSE_PASTE:
       {
@@ -228,8 +228,8 @@ variable_info_dialog (GObject *o, gpointer data)
       break;
     }
 
+ done:
   g_object_unref (xml);
-
 }
 
 static gchar *