Value Label Dialog: Do not attempt to read selection if there is none.

[pspp] / src / ui / gui / var-type-dialog.c

diff --git a/src/ui/gui/var-type-dialog.c b/src/ui/gui/var-type-dialog.c
index 8ca7b1c92d98735e6fc8e6ea29c117154ef699ee..52811c9af5047c5af6205452f5c0198166b0e381 100644 (file)
--- a/src/ui/gui/var-type-dialog.c
+++ b/src/ui/gui/var-type-dialog.c
@@ -84,6 +84,9 @@ static GObject *psppire_var_type_dialog_constructor (GType type, guint,
                                                      GObjectConstructParam *);
 static void psppire_var_type_dialog_set_state (PsppireVarTypeDialog *);
 
+static void psppire_var_type_dialog_set_format (PsppireVarTypeDialog *dialog,
+                                               const struct fmt_spec *format);
+
 static int find_format (const struct fmt_spec *target,
                         const struct fmt_spec formats[], int n_formats);
 static int find_format_type (int target, const int types[], int n_types);
@@ -145,7 +148,7 @@ psppire_var_type_dialog_get_property (GObject      *object,
     }
 }
 
-void
+static void
 psppire_var_type_dialog_set_format (PsppireVarTypeDialog *dialog,
                                     const struct fmt_spec *format)
 {
@@ -153,7 +156,7 @@ psppire_var_type_dialog_set_format (PsppireVarTypeDialog *dialog,
   psppire_var_type_dialog_set_state (dialog);
 }
 
-const struct fmt_spec *
+static const struct fmt_spec *
 psppire_var_type_dialog_get_format (const PsppireVarTypeDialog *dialog)
 {
   return &dialog->fmt_l;
@@ -454,6 +457,9 @@ get_index_from_treeview (GtkTreeView *treeview)
   GtkTreeIter iter;
   gint index;
 
+  if (selection == NULL)
+    return -1;
+
   gtk_tree_selection_get_selected (selection, &model, &iter);
   path = gtk_tree_model_get_path (model, &iter);
   if (!path || gtk_tree_path_get_depth (path) < 1)
@@ -471,7 +477,11 @@ static void
 set_date_format_from_treeview (GtkTreeView *treeview,
                                PsppireVarTypeDialog *dialog)
 {
-  dialog->fmt_l = date_format[get_index_from_treeview (treeview)];
+  gint idx = get_index_from_treeview (treeview);
+  if (idx < 0)
+    return;
+
+  dialog->fmt_l = date_format[idx];
 }
 
 /* Callback for when a dollar treeview row is changed.
@@ -480,7 +490,11 @@ static void
 set_dollar_format_from_treeview (GtkTreeView *treeview,
                                  PsppireVarTypeDialog *dialog)
 {
-  dialog->fmt_l = dollar_format[get_index_from_treeview (treeview)];
+  gint idx = get_index_from_treeview (treeview);
+  if (idx < 0)
+    return;
+
+  dialog->fmt_l = dollar_format[idx];
 }
 
 /* Callback for when a treeview row is changed.
@@ -489,7 +503,11 @@ static void
 set_custom_format_from_treeview (GtkTreeView *treeview,
                                  PsppireVarTypeDialog *dialog)
 {
-  dialog->fmt_l.type = cc_format[get_index_from_treeview (treeview)];
+  gint idx = get_index_from_treeview (treeview);
+  if (idx < 0)
+    return;
+
+  dialog->fmt_l.type = cc_format[idx];
   update_adj_ranges (dialog);
   fmt_fix_output (&dialog->fmt_l);
   update_width_decimals (dialog);