output-item: Collapse the inheritance hierarchy into a single struct.
[pspp] / src / ui / gui / psppire-window.c
index 48a64c6f72356fcbd614a45c04ff16e68521adc7..4b40f94d1e04e0a055a58703ad21d47b66adfc8a 100644 (file)
@@ -1,5 +1,5 @@
 /* PSPPIRE - a graphical user interface for PSPP.
-   Copyright (C) 2009, 2010, 2011, 2013, 2014  Free Software Foundation
+   Copyright (C) 2009, 2010, 2011, 2013, 2014, 2020 Free Software Foundation
 
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -32,7 +32,7 @@
 #include "data/file-handle-def.h"
 #include "data/dataset.h"
 #include "libpspp/version.h"
-#include "output/group-item.h"
+#include "output/output-item.h"
 #include "output/pivot-table.h"
 #include "output/spv/spv.h"
 #include "output/spv/spv-output.h"
 #include "psppire-syntax-window.h"
 #include "psppire-window-register.h"
 
-static void psppire_window_base_init     (PsppireWindowClass *class);
 static void psppire_window_class_init    (PsppireWindowClass *class);
 static void psppire_window_init          (PsppireWindow      *window);
 
-
 static GObjectClass *parent_class;
 
-GType
-psppire_window_get_type (void)
-{
-  static GType psppire_window_type = 0;
-
-  if (!psppire_window_type)
-    {
-      static const GTypeInfo psppire_window_info =
-      {
-       sizeof (PsppireWindowClass),
-       (GBaseInitFunc) psppire_window_base_init,
-        (GBaseFinalizeFunc) NULL,
-       (GClassInitFunc) psppire_window_class_init,
-       (GClassFinalizeFunc) NULL,
-       NULL,
-        sizeof (PsppireWindow),
-       0,
-       (GInstanceInitFunc) psppire_window_init,
-      };
-
-      psppire_window_type =
-       g_type_register_static (PSPPIRE_TYPE_WINDOW_BASE, "PsppireWindow",
-                               &psppire_window_info, G_TYPE_FLAG_ABSTRACT);
-    }
-
-  return psppire_window_type;
-}
-
+G_DEFINE_ABSTRACT_TYPE (PsppireWindow, psppire_window, PSPPIRE_TYPE_WINDOW_BASE)
 
 /* Properties */
 enum
@@ -95,7 +66,7 @@ psppire_window_set_title (PsppireWindow *window)
 {
   GString *title = g_string_sized_new (80);
 
-  if (window->dirty)
+  if (window->edited != NULL)
     g_string_append_c (title, '*');
 
   if (window->basename || window->id)
@@ -245,6 +216,9 @@ psppire_window_finalize (GObject *object)
 
   PsppireWindowRegister *reg = psppire_window_register_new ();
 
+  if (window->edited)
+    g_date_time_unref (window->edited);
+
   g_signal_handler_disconnect (reg, window->remove_handler);
   g_signal_handler_disconnect (reg, window->insert_handler);
   psppire_window_register_remove (reg, window->list_name);
@@ -265,6 +239,8 @@ psppire_window_class_init (PsppireWindowClass *class)
 {
   GObjectClass *object_class = G_OBJECT_CLASS (class);
 
+  object_class->finalize = psppire_window_finalize;
+
   GParamSpec *description_spec =
     null_if_empty_param ("description",
                       "Description",
@@ -306,16 +282,6 @@ psppire_window_class_init (PsppireWindowClass *class)
 }
 
 
-static void
-psppire_window_base_init (PsppireWindowClass *class)
-{
-  GObjectClass *object_class = G_OBJECT_CLASS (class);
-
-  object_class->finalize = psppire_window_finalize;
-}
-
-
-
 static void
 insert_menuitem_into_menu (PsppireWindow *window, gpointer key)
 {
@@ -323,6 +289,7 @@ insert_menuitem_into_menu (PsppireWindow *window, gpointer key)
   GtkWidget *item;
   filename = g_filename_display_name (key);
   item = gtk_check_menu_item_new_with_label (filename);
+  g_object_ref_sink (item);
   g_free (filename);
 
   g_hash_table_insert (window->menuitem_table, key, item);
@@ -368,7 +335,7 @@ on_delete (PsppireWindow *w, GdkEvent *event, gpointer user_data)
 {
   PsppireWindowRegister *reg = psppire_window_register_new ();
 
-  if (w->dirty)
+  if (w->edited != NULL)
     {
       gint response = psppire_window_query_save (w);
 
@@ -380,7 +347,7 @@ on_delete (PsppireWindow *w, GdkEvent *event, gpointer user_data)
          break;
        case GTK_RESPONSE_APPLY:
          psppire_window_save (w);
-          if (w->dirty)
+          if (w->edited != NULL)
             {
               /* Save failed, or user exited Save As dialog with Cancel. */
               return TRUE;
@@ -406,24 +373,26 @@ psppire_window_init (PsppireWindow *window)
   window->id = NULL;
   window->description = NULL;
   window->list_name = NULL;
+  window->edited = NULL;
 
-  window->menuitem_table  = g_hash_table_new (g_str_hash, g_str_equal);
+  window->menuitem_table  = g_hash_table_new_full (g_str_hash, g_str_equal,
+                                                   NULL, g_object_unref);
 
 
   g_signal_connect (window,  "realize", G_CALLBACK (insert_existing_items), NULL);
 
-  window->insert_handler = g_signal_connect (psppire_window_register_new (),
+  PsppireWindowRegister *reg = psppire_window_register_new ();
+  window->insert_handler = g_signal_connect (reg,
                                             "inserted",
                                             G_CALLBACK (insert_menuitem),
                                             window);
 
-  window->remove_handler = g_signal_connect (psppire_window_register_new (),
+  window->remove_handler = g_signal_connect (reg,
                                             "removed",
                                             G_CALLBACK (remove_menuitem),
                                             window);
 
   window->added_separator = FALSE;
-  window->dirty = FALSE;
 
   g_signal_connect_swapped (window, "delete-event", G_CALLBACK (on_delete), window);
 
@@ -443,9 +412,9 @@ psppire_window_query_save (PsppireWindow *se)
 
   gchar *description;
 
-  GTimeVal time;
-
-  g_get_current_time (&time);
+  GDateTime *now = g_date_time_new_now_utc ();
+  GTimeSpan timespan = g_date_time_difference (now, se->edited);
+  g_date_time_unref (now);
 
   if (se->filename)
     description = g_filename_display_basename (se->filename);
@@ -466,7 +435,7 @@ psppire_window_query_save (PsppireWindow *se)
 
   gtk_message_dialog_format_secondary_text (GTK_MESSAGE_DIALOG (dialog),
                                            _("If you don't save, changes from the last %ld seconds will be permanently lost."),
-                                           time.tv_sec - se->savetime.tv_sec);
+                                           (long int) (timespan / G_TIME_SPAN_SECOND));
 
   gtk_dialog_add_button  (GTK_DIALOG (dialog),
                          _("Close _without saving"),
@@ -508,10 +477,8 @@ psppire_window_set_filename (PsppireWindow *w, const gchar *filename)
 void
 psppire_window_set_unsaved (PsppireWindow *w)
 {
-  if (w->dirty == FALSE)
-    g_get_current_time (&w->savetime);
-
-  w->dirty = TRUE;
+  if (w->edited == NULL)
+    w->edited = g_date_time_new_now_utc ();
 
   psppire_window_set_title (w);
 }
@@ -519,7 +486,7 @@ psppire_window_set_unsaved (PsppireWindow *w)
 gboolean
 psppire_window_get_unsaved (PsppireWindow *w)
 {
-  return w->dirty;
+  return w->edited != NULL;
 }
 
 
@@ -561,7 +528,8 @@ psppire_window_model_get_type (void)
        NULL,           /* class_data */
        0,
        0,              /* n_preallocs */
-       NULL
+       NULL,
+       NULL            /* value_table */
       };
 
       window_model_type =
@@ -588,7 +556,10 @@ psppire_window_save (PsppireWindow *w)
   else
     {
       i->save (w);
-      w->dirty = FALSE;
+      if (w->edited)
+        g_date_time_unref (w->edited);
+      w->edited = NULL;
+
       psppire_window_set_title (w);
     }
 }
@@ -635,7 +606,9 @@ psppire_window_load (PsppireWindow *w, const gchar *file,
   if (ok)
     {
       psppire_window_set_filename (w, file);
-      w->dirty = FALSE;
+      if (w->edited)
+        g_date_time_unref (w->edited);
+      w->edited = NULL;
     }
   else
     delete_recent (file);
@@ -790,10 +763,11 @@ dump_heading_transition (const struct spv_item *old,
       break;
 
   for (size_t i = common; i < old_path.n; i++)
-    group_close_item_submit (group_close_item_create ());
+    output_item_submit (group_close_item_create ());
   for (size_t i = common; i < new_path.n; i++)
-    group_open_item_submit (group_open_item_create (
-                              new_path.nodes[i]->command_id));
+    output_item_submit (group_open_item_create (
+                              new_path.nodes[i]->command_id,
+                              new_path.nodes[i]->label));
 
   free_path (&old_path);
   free_path (&new_path);
@@ -823,7 +797,13 @@ read_spv_file (const char *filename)
       if (items[i]->type == SPV_ITEM_TEXT)
         spv_text_submit (items[i]);
       else if (items[i]->type == SPV_ITEM_TABLE)
-        pivot_table_submit (spv_item_get_table (items[i]));
+        pivot_table_submit (pivot_table_ref (spv_item_get_table (items[i])));
+      else if (items[i]->type == SPV_ITEM_IMAGE)
+        {
+          cairo_surface_t *image = spv_item_get_image (items[i]);
+          output_item_submit (image_item_create (cairo_surface_reference (
+                                                   image)));
+        }
       prev_heading = heading;
     }
   dump_heading_transition (prev_heading, spv_get_root (spv));
@@ -935,4 +915,3 @@ delete_recent (const char *file_name)
 
   g_free (uri);
 }
-