VARIABLE ROLE: Use correct system file representation.
[pspp] / src / ui / gui / psppire-var-sheet.c
index 930c27797ff8c0b2d5ec0da37567d7e5e1bc0c38..b5f305cee38c25c7a08e45cc354fb2560ae12d31 100644 (file)
@@ -1,5 +1,5 @@
 /* PSPPIRE - a graphical user interface for PSPP.
-   Copyright (C) 2011, 2012 Free Software Foundation, Inc.
+   Copyright (C) 2008, 2009, 2011, 2012, 2013 Free Software Foundation, Inc.
 
    This program is free software: you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 #include "ui/gui/psppire-data-editor.h"
 #include "ui/gui/psppire-data-window.h"
 #include "ui/gui/psppire-dialog-action-var-info.h"
+#include "ui/gui/psppire-dictview.h"
 #include "ui/gui/psppire-empty-list-store.h"
 #include "ui/gui/psppire-marshal.h"
 #include "ui/gui/val-labs-dialog.h"
+#include "ui/gui/var-type-dialog.h"
 #include "ui/gui/var-display.h"
 #include "ui/gui/var-type-dialog.h"
 
@@ -52,7 +54,8 @@ enum vs_column
     VS_MISSING,
     VS_COLUMNS,
     VS_ALIGN,
-    VS_MEASURE
+    VS_MEASURE,
+    VS_ROLE
   };
 
 G_DEFINE_TYPE (PsppireVarSheet, psppire_var_sheet, PSPP_TYPE_SHEET_VIEW);
@@ -224,8 +227,8 @@ on_var_column_edited (GtkCellRendererText *cell,
 
           format = *var_get_print_format (var);
           fmt_change_width (&format, width, var_sheet->format_use);
-          var_set_print_format (var, &format);
           var_set_width (var, fmt_var_width (&format));
+          var_set_both_formats (var, &format);
         }
       break;
 
@@ -272,6 +275,21 @@ on_var_column_edited (GtkCellRendererText *cell,
       else if (!strcmp (new_text, measure_to_string (MEASURE_SCALE)))
         var_set_measure (var, MEASURE_SCALE);
       break;
+
+    case VS_ROLE:
+      if (!strcmp (new_text, var_role_to_string (ROLE_INPUT)))
+        var_set_role (var, ROLE_INPUT);
+      else if (!strcmp (new_text, var_role_to_string (ROLE_OUTPUT)))
+        var_set_role (var, ROLE_OUTPUT);
+      else if (!strcmp (new_text, var_role_to_string (ROLE_BOTH)))
+        var_set_role (var, ROLE_BOTH);
+      else if (!strcmp (new_text, var_role_to_string (ROLE_NONE)))
+        var_set_role (var, ROLE_NONE);
+      else if (!strcmp (new_text, var_role_to_string (ROLE_PARTITION)))
+        var_set_role (var, ROLE_PARTITION);
+      else if (!strcmp (new_text, var_role_to_string (ROLE_SPLIT)))
+        var_set_role (var, ROLE_SPLIT);
+      break;
     }
 }
 
@@ -291,6 +309,25 @@ render_popup_cell (PsppSheetViewColumn *tree_column,
                 NULL);
 }
 
+const char *
+get_var_align_stock_id (const struct variable *var)
+{
+  switch (var_get_alignment (var))
+    {
+    case ALIGN_LEFT:
+      return GTK_STOCK_JUSTIFY_LEFT;
+
+    case ALIGN_CENTRE:
+      return GTK_STOCK_JUSTIFY_CENTER;
+
+    case ALIGN_RIGHT:
+      return GTK_STOCK_JUSTIFY_RIGHT;
+
+    default:
+      g_return_val_if_reached ("");
+    }
+}
+
 static void
 render_var_cell (PsppSheetViewColumn *tree_column,
                  GtkCellRenderer *cell,
@@ -310,14 +347,19 @@ render_var_cell (PsppSheetViewColumn *tree_column,
 
   if (row >= psppire_dict_get_var_cnt (var_sheet->dict))
     {
-      g_object_set (cell,
-                    "text", "",
-                    "editable", column_id == VS_NAME,
-                    NULL);
-      if (column_id == VS_WIDTH
-          || column_id == VS_DECIMALS
-          || column_id == VS_COLUMNS)
-        g_object_set (cell, "adjustment", NULL, NULL);
+      if (GTK_IS_CELL_RENDERER_TEXT (cell))
+        {
+          g_object_set (cell,
+                        "text", "",
+                        "editable", column_id == VS_NAME,
+                        NULL);
+          if (column_id == VS_WIDTH
+              || column_id == VS_DECIMALS
+              || column_id == VS_COLUMNS)
+            g_object_set (cell, "adjustment", NULL, NULL);
+        }
+      else
+        g_object_set (cell, "stock-id", "", NULL);
       return;
     }
 
@@ -341,16 +383,10 @@ render_var_cell (PsppSheetViewColumn *tree_column,
       break;
 
     case VS_WIDTH:
-      {
-        int step = fmt_step_width (print->type);
-        if (var_is_numeric (var))
-          set_spin_cell (cell, print->w,
-                         fmt_min_width (print->type, var_sheet->format_use),
-                         fmt_max_width (print->type, var_sheet->format_use),
-                         step);
-        else
-          set_spin_cell (cell, print->w, 0, 0, step);
-      }
+      set_spin_cell (cell, print->w,
+                     fmt_min_width (print->type, var_sheet->format_use),
+                     fmt_max_width (print->type, var_sheet->format_use),
+                     fmt_step_width (print->type));
       break;
 
     case VS_DECIMALS:
@@ -391,6 +427,7 @@ render_var_cell (PsppSheetViewColumn *tree_column,
           free (vstr);
 
           g_object_set (cell, "text", text, NULL);
+          free (text);
           free (labels);
         }
       break;
@@ -411,15 +448,30 @@ render_var_cell (PsppSheetViewColumn *tree_column,
       break;
 
     case VS_ALIGN:
-      g_object_set (cell,
-                    "text", alignment_to_string (var_get_alignment (var)),
-                    "editable", TRUE,
-                    NULL);
+      if (GTK_IS_CELL_RENDERER_TEXT (cell))
+        g_object_set (cell,
+                      "text", alignment_to_string (var_get_alignment (var)),
+                      "editable", TRUE,
+                      NULL);
+      else
+        g_object_set (cell, "stock-id", get_var_align_stock_id (var), NULL);
       break;
 
     case VS_MEASURE:
+      if (GTK_IS_CELL_RENDERER_TEXT (cell))
+        g_object_set (cell,
+                      "text", measure_to_string (var_get_measure (var)),
+                      "editable", TRUE,
+                      NULL);
+      else
+        g_object_set (cell, "stock-id",
+                      psppire_dict_view_get_var_measurement_stock_id (var),
+                      NULL);
+      break;
+
+    case VS_ROLE:
       g_object_set (cell,
-                    "text", measure_to_string (var_get_measure (var)),
+                    "text", var_role_to_string (var_get_role (var)),
                     "editable", TRUE,
                     NULL);
       break;
@@ -448,8 +500,17 @@ on_type_click (PsppireCellRendererButton *cell,
                gchar *path,
                PsppireVarSheet *var_sheet)
 {
-  var_sheet->var_type_dialog->pv = path_string_to_variable (var_sheet, path);
-  var_type_dialog_show (var_sheet->var_type_dialog);
+  GtkWidget *toplevel = gtk_widget_get_toplevel (GTK_WIDGET (var_sheet));
+  struct fmt_spec format;
+  struct variable *var;
+
+  var = path_string_to_variable (var_sheet, path);
+  g_return_if_fail (var != NULL);
+
+  format = *var_get_print_format (var);
+  psppire_var_type_dialog_run (GTK_WINDOW (toplevel), &format);
+
+  var_set_width_and_formats (var, fmt_var_width (&format), &format, &format);
 }
 
 static void
@@ -457,9 +518,19 @@ on_value_labels_click (PsppireCellRendererButton *cell,
                        gchar *path,
                        PsppireVarSheet *var_sheet)
 {
-  struct variable *var = path_string_to_variable (var_sheet, path);
-  val_labs_dialog_set_target_variable (var_sheet->val_labs_dialog, var);
-  val_labs_dialog_show (var_sheet->val_labs_dialog);
+  GtkWidget *toplevel = gtk_widget_get_toplevel (GTK_WIDGET (var_sheet));
+  struct val_labs *labels;
+  struct variable *var;
+
+  var = path_string_to_variable (var_sheet, path);
+  g_return_if_fail (var != NULL);
+
+  labels = psppire_val_labs_dialog_run (GTK_WINDOW (toplevel), var);
+  if (labels)
+    {
+      var_set_value_labels (var, labels);
+      val_labs_destroy (labels);
+    }
 }
 
 static void
@@ -467,9 +538,16 @@ on_missing_values_click (PsppireCellRendererButton *cell,
                          gchar *path,
                          PsppireVarSheet *var_sheet)
 {
-  var_sheet->missing_val_dialog->pv = path_string_to_variable (var_sheet,
-                                                               path);
-  missing_val_dialog_show (var_sheet->missing_val_dialog);
+  GtkWidget *toplevel = gtk_widget_get_toplevel (GTK_WIDGET (var_sheet));
+  struct missing_values mv;
+  struct variable *var;
+
+  var = path_string_to_variable (var_sheet, path);
+  g_return_if_fail (var != NULL);
+
+  psppire_missing_val_dialog_run (GTK_WINDOW (toplevel), var, &mv);
+  var_set_missing_values (var, &mv);
+  mv_destroy (&mv);
 }
 
 static gint
@@ -735,6 +813,7 @@ on_query_var_tooltip (GtkWidget *widget, gint wx, gint wy,
 
           gtk_tooltip_set_text (tooltip, ds_cstr (&s));
           ds_destroy (&s);
+          free (labels);
 
           return TRUE;
         }
@@ -893,20 +972,6 @@ psppire_var_sheet_get_property (GObject      *object,
     }
 }
 
-static void
-psppire_var_sheet_realize (GtkWidget *w)
-{
-  PsppireVarSheet *var_sheet = PSPPIRE_VAR_SHEET (w);
-  GtkWindow *toplevel;
-
-  GTK_WIDGET_CLASS (psppire_var_sheet_parent_class)->realize (w);
-
-  toplevel = GTK_WINDOW (gtk_widget_get_toplevel (w));
-  var_sheet->val_labs_dialog = val_labs_dialog_create (toplevel);
-  var_sheet->missing_val_dialog = missing_val_dialog_create (toplevel);
-  var_sheet->var_type_dialog = var_type_dialog_create (toplevel);
-}
-
 static void
 psppire_var_sheet_dispose (GObject *obj)
 {
@@ -945,15 +1010,12 @@ static void
 psppire_var_sheet_class_init (PsppireVarSheetClass *class)
 {
   GObjectClass *gobject_class = G_OBJECT_CLASS (class);
-  GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (class);
   GParamSpec *pspec;
 
   gobject_class->set_property = psppire_var_sheet_set_property;
   gobject_class->get_property = psppire_var_sheet_get_property;
   gobject_class->dispose = psppire_var_sheet_dispose;
 
-  widget_class->realize = psppire_var_sheet_realize;
-
   g_signal_new ("var-double-clicked",
                 G_OBJECT_CLASS_TYPE (gobject_class),
                 G_SIGNAL_RUN_LAST,
@@ -1048,6 +1110,16 @@ psppire_var_sheet_row_number_double_clicked (PsppireCellRendererButton *button,
   gtk_tree_path_free (path);
 }
 
+static void
+psppire_var_sheet_variables_column_clicked (PsppSheetViewColumn *column,
+                                            PsppireVarSheet *var_sheet)
+{
+  PsppSheetView *sheet_view = PSPP_SHEET_VIEW (var_sheet);
+  PsppSheetSelection *selection = pspp_sheet_view_get_selection (sheet_view);
+
+  pspp_sheet_selection_select_all (selection);
+}
+
 static PsppSheetViewColumn *
 make_row_number_column (PsppireVarSheet *var_sheet)
 {
@@ -1062,9 +1134,14 @@ make_row_number_column (PsppireVarSheet *var_sheet)
 
   column = pspp_sheet_view_column_new_with_attributes (_("Variable"),
                                                        renderer, NULL);
+  pspp_sheet_view_column_set_clickable (column, TRUE);
   pspp_sheet_view_column_set_cell_data_func (
     column, renderer, render_row_number_cell, var_sheet, NULL);
   pspp_sheet_view_column_set_fixed_width (column, 50);
+  g_signal_connect (column, "clicked",
+                    G_CALLBACK (psppire_var_sheet_variables_column_clicked),
+                    var_sheet);
+
   return column;
 }
 
@@ -1158,11 +1235,12 @@ psppire_var_sheet_init (PsppireVarSheet *obj)
 {
   PsppSheetView *sheet_view = PSPP_SHEET_VIEW (obj);
   PsppSheetViewColumn *column;
+  GtkCellRenderer *cell;
   GtkAction *action;
   GList *list;
 
   obj->dict = NULL;
-  obj->format_use = PSPPIRE_TYPE_FMT_USE;
+  obj->format_use = FMT_FOR_OUTPUT;
   obj->may_create_vars = TRUE;
   obj->may_delete_vars = TRUE;
 
@@ -1197,16 +1275,37 @@ psppire_var_sheet_init (PsppireVarSheet *obj)
 
   add_spin_column (obj, VS_COLUMNS, _("Columns"), 3);
 
-  add_combo_column (obj, VS_ALIGN, _("Align"), 6,
-                    alignment_to_string (ALIGN_LEFT), ALIGN_LEFT,
-                    alignment_to_string (ALIGN_CENTRE), ALIGN_CENTRE,
-                    alignment_to_string (ALIGN_RIGHT), ALIGN_RIGHT,
-                    NULL);
-
-  add_combo_column (obj, VS_MEASURE, _("Measure"), 10,
-                    measure_to_string (MEASURE_NOMINAL), MEASURE_NOMINAL,
-                    measure_to_string (MEASURE_ORDINAL), MEASURE_ORDINAL,
-                    measure_to_string (MEASURE_SCALE), MEASURE_SCALE,
+  column
+   = add_combo_column (obj, VS_ALIGN, _("Align"), 8,
+                       alignment_to_string (ALIGN_LEFT), ALIGN_LEFT,
+                       alignment_to_string (ALIGN_CENTRE), ALIGN_CENTRE,
+                       alignment_to_string (ALIGN_RIGHT), ALIGN_RIGHT,
+                       NULL);
+  cell = gtk_cell_renderer_pixbuf_new ();
+  g_object_set (cell, "width", 16, "height", 16, NULL);
+  pspp_sheet_view_column_pack_end (column, cell, FALSE);
+  pspp_sheet_view_column_set_cell_data_func (
+    column, cell, render_var_cell, obj, NULL);
+
+  column
+    = add_combo_column (obj, VS_MEASURE, _("Measure"), 12,
+                        measure_to_string (MEASURE_NOMINAL), MEASURE_NOMINAL,
+                        measure_to_string (MEASURE_ORDINAL), MEASURE_ORDINAL,
+                        measure_to_string (MEASURE_SCALE), MEASURE_SCALE,
+                        NULL);
+  cell = gtk_cell_renderer_pixbuf_new ();
+  g_object_set (cell, "width", 16, "height", 16, NULL);
+  pspp_sheet_view_column_pack_end (column, cell, FALSE);
+  pspp_sheet_view_column_set_cell_data_func (
+    column, cell, render_var_cell, obj, NULL);
+
+  add_combo_column (obj, VS_ROLE, _("Role"), 12,
+                    var_role_to_string (ROLE_INPUT), ROLE_INPUT,
+                    var_role_to_string (ROLE_OUTPUT), ROLE_OUTPUT,
+                    var_role_to_string (ROLE_BOTH), ROLE_BOTH,
+                    var_role_to_string (ROLE_NONE), ROLE_NONE,
+                    var_role_to_string (ROLE_PARTITION), ROLE_PARTITION,
+                    var_role_to_string (ROLE_SPLIT), ROLE_SPLIT,
                     NULL);
 
   pspp_sheet_view_set_rubber_banding (sheet_view, TRUE);
@@ -1266,6 +1365,22 @@ refresh_model (PsppireVarSheet *var_sheet)
     }
 }
 
+static void
+on_var_changed (PsppireDict *dict, glong row,
+               guint what, const struct variable *oldvar,
+               PsppireVarSheet *var_sheet)
+{
+  PsppireEmptyListStore *store;
+
+  g_return_if_fail (dict == var_sheet->dict);
+
+  store = PSPPIRE_EMPTY_LIST_STORE (pspp_sheet_view_get_model (
+                                      PSPP_SHEET_VIEW (var_sheet)));
+  g_return_if_fail (store != NULL);
+
+  psppire_empty_list_store_row_changed (store, row);
+}
+
 static void
 on_var_inserted (PsppireDict *dict, glong row, PsppireVarSheet *var_sheet)
 {
@@ -1341,6 +1456,10 @@ psppire_var_sheet_set_dictionary (PsppireVarSheet *var_sheet,
         = g_signal_connect (dict, "backend-changed",
                             G_CALLBACK (on_backend_changed), var_sheet);
 
+      var_sheet->dict_signals[PSPPIRE_VAR_SHEET_VARIABLE_CHANGED]
+        = g_signal_connect (dict, "variable-changed",
+                            G_CALLBACK (on_var_changed), var_sheet);
+
       var_sheet->dict_signals[PSPPIRE_VAR_SHEET_VARIABLE_DELETED]
         = g_signal_connect (dict, "variable-inserted",
                             G_CALLBACK (on_var_inserted), var_sheet);