output-item: Make command name part of every output_item.

[pspp] / src / output / table-item.c

diff --git a/src/output/table-item.c b/src/output/table-item.c
index 45add25f346635e8ebc4ae67f94471876b11179d..5d63be972a3bad004925cdbcefc93736a844cd46 100644 (file)
--- a/src/output/table-item.c
+++ b/src/output/table-item.c
@@ -24,51 +24,31 @@
 #include "libpspp/cast.h"
 #include "output/driver.h"
 #include "output/output-item-provider.h"
+#include "output/pivot-table.h"
 #include "output/table-item.h"
+#include "output/table-provider.h"
 
 #include "gl/xalloc.h"
 
-/* Initializes ITEM as a table item for rendering TABLE.  The new table item
-   initially has the specified TITLE, which may be NULL if no title is yet
-   available.  The caller retains ownership of TITLE. */
+#include "gettext.h"
+#define _(msgid) gettext (msgid)
+
+/* Initializes ITEM as a table item for rendering PT.  Takes ownership of
+   PT. */
 struct table_item *
-table_item_create (struct table *table, const char *title)
+table_item_create (struct pivot_table *pt)
 {
+  pivot_table_assign_label_depth (pt);
+
   struct table_item *item = xmalloc (sizeof *item);
-  output_item_init (&item->output_item, &table_item_class);
-  item->table = table;
-  item->title = title != NULL ? xstrdup (title) : NULL;
+  *item = (struct table_item) {
+    .output_item = OUTPUT_ITEM_INITIALIZER (&table_item_class),
+    .output_item.command_name = xstrdup_if_nonnull (pt->command_c),
+    .pt = pt,
+  };
   return item;
 }
 
-/* Returns the table contained by TABLE_ITEM.  The caller must not modify or
-   unref the returned table. */
-const struct table *
-table_item_get_table (const struct table_item *table_item)
-{
-  return table_item->table;
-}
-
-/* Returns ITEM's title, which is a null pointer if no title has been
-   set. */
-const char *
-table_item_get_title (const struct table_item *item)
-{
-  return item->title;
-}
-
-/* Sets ITEM's title to TITLE, replacing any previous title.  Specify NULL for
-   TITLE to clear any title from ITEM.  The caller retains ownership of TITLE.
-
-   This function may only be used on a table_item that is unshared. */
-void
-table_item_set_title (struct table_item *item, const char *title)
-{
-  assert (!table_item_is_shared (item));
-  free (item->title);
-  item->title = title != NULL ? xstrdup (title) : NULL;
-}
-
 /* Submits TABLE_ITEM to the configured output drivers, and transfers ownership
    to the output subsystem. */
 void
@@ -77,16 +57,32 @@ table_item_submit (struct table_item *table_item)
   output_submit (&table_item->output_item);
 }
 \f
+static const char *
+table_item_get_label (const struct output_item *output_item)
+{
+  struct table_item *item = to_table_item (output_item);
+
+  if (!item->cached_label)
+    {
+      if (!item->pt->title)
+        return _("Table");
+
+      item->cached_label = pivot_value_to_string (item->pt->title, item->pt);
+    }
+  return item->cached_label;
+}
+
 static void
 table_item_destroy (struct output_item *output_item)
 {
   struct table_item *item = to_table_item (output_item);
-  free (item->title);
-  table_unref (item->table);
+  pivot_table_unref (item->pt);
+  free (item->cached_label);
   free (item);
 }
 
 const struct output_item_class table_item_class =
   {
+    table_item_get_label,
     table_item_destroy,
   };