Histograms: Rotate labels when there are lots of bins

[pspp] / src / output / charts / plot-hist-cairo.c

diff --git a/src/output/charts/plot-hist-cairo.c b/src/output/charts/plot-hist-cairo.c
index 9ce4abb3ed09fec2796c25e4077e9520893116fc..a9a5d44f58b475aef164f8fe9077008d4264ece8 100644 (file)
--- a/src/output/charts/plot-hist-cairo.c
+++ b/src/output/charts/plot-hist-cairo.c
@@ -38,7 +38,7 @@ histogram_write_legend (cairo_t *cr, const struct xrchart_geometry *geom,
 
   if (n != SYSMIS)
     {
-      char *buf = xasprintf ("N = %.2f", n);
+      char *buf = xasprintf (_("N = %.2f"), n);
       cairo_move_to (cr, geom->legend_left, y);
       xrchart_label (cr, 'l', 'b', geom->font_size, buf);
       y += geom->font_size * 1.5;
@@ -47,7 +47,7 @@ histogram_write_legend (cairo_t *cr, const struct xrchart_geometry *geom,
 
   if (mean != SYSMIS)
     {
-      char *buf = xasprintf ("Mean = %.1f", mean);
+      char *buf = xasprintf (_("Mean = %.1f"), mean);
       cairo_move_to (cr,geom->legend_left, y);
       xrchart_label (cr, 'l', 'b', geom->font_size, buf);
       y += geom->font_size * 1.5;
@@ -56,7 +56,7 @@ histogram_write_legend (cairo_t *cr, const struct xrchart_geometry *geom,
 
   if (stddev != SYSMIS)
     {
-      char *buf = xasprintf ("Std. Dev = %.2f", stddev);
+      char *buf = xasprintf (_("Std. Dev = %.2f"), stddev);
       cairo_move_to (cr, geom->legend_left, y);
       xrchart_label (cr, 'l', 'b', geom->font_size, buf);
       free (buf);
@@ -67,25 +67,30 @@ histogram_write_legend (cairo_t *cr, const struct xrchart_geometry *geom,
 
 static void
 hist_draw_bar (cairo_t *cr, const struct xrchart_geometry *geom,
-               const gsl_histogram *h, int bar)
+               const gsl_histogram *h, int bar, bool label)
 {
   double upper;
   double lower;
   double height;
 
   const size_t bins = gsl_histogram_bins (h);
-  const double x_pos = (geom->axis[SCALE_ABSCISSA].data_max - geom->axis[SCALE_ABSCISSA].data_min) * bar / (double) bins ;
-  const double width = (geom->axis[SCALE_ABSCISSA].data_max - geom->axis[SCALE_ABSCISSA].data_min) / (double) bins ;
+
+  const double x_pos =
+    (geom->axis[SCALE_ABSCISSA].data_max - geom->axis[SCALE_ABSCISSA].data_min) *
+    bar / (double) bins ;
+
+  const double width =
+    (geom->axis[SCALE_ABSCISSA].data_max - geom->axis[SCALE_ABSCISSA].data_min) / (double) bins ;
 
   assert ( 0 == gsl_histogram_get_range (h, bar, &lower, &upper));
 
   assert ( upper >= lower);
 
-  height = gsl_histogram_get (h, bar) /
-    (geom->axis[SCALE_ORDINATE].max - geom->axis[SCALE_ORDINATE].min) *
-    (geom->axis[SCALE_ORDINATE].data_max - geom->axis[SCALE_ORDINATE].data_min);
+  height = geom->axis[SCALE_ORDINATE].scale * gsl_histogram_get (h, bar);
 
-  cairo_rectangle (cr, geom->axis[SCALE_ABSCISSA].data_min + x_pos, geom->axis[SCALE_ORDINATE].data_min,
+  cairo_rectangle (cr,
+                  geom->axis[SCALE_ABSCISSA].data_min + x_pos,
+                  geom->axis[SCALE_ORDINATE].data_min,
                    width, height);
   cairo_save (cr);
   cairo_set_source_rgb (cr,
@@ -96,8 +101,9 @@ hist_draw_bar (cairo_t *cr, const struct xrchart_geometry *geom,
   cairo_restore (cr);
   cairo_stroke (cr);
 
-  draw_tick (cr, geom, SCALE_ABSCISSA,
-             x_pos + width / 2.0, "%g", (upper + lower) / 2.0);
+  if (label)
+    draw_tick (cr, geom, SCALE_ABSCISSA, bins > 10,
+              x_pos + width / 2.0, "%g", (upper + lower) / 2.0);
 }
 
 void
@@ -124,7 +130,9 @@ xrchart_draw_histogram (const struct chart_item *chart_item, cairo_t *cr,
   xrchart_write_yscale (cr, geom, 0, gsl_histogram_max_val (h->gsl_hist), 5);
 
   for (i = 0; i < bins; i++)
-    hist_draw_bar (cr, geom, h->gsl_hist, i);
+    {
+      hist_draw_bar (cr, geom, h->gsl_hist, i, true);
+    }
 
   histogram_write_legend (cr, geom, h->n, h->mean, h->stddev);