#include <unistd.h>
#include "libpspp/cast.h"
+#include "libpspp/intern.h"
#include "libpspp/str.h"
#include "libpspp/version.h"
#include "data/settings.h"
void
vmsg (enum msg_class class, const char *format, va_list args)
{
- struct msg m = {
+ struct msg *m = xmalloc (sizeof *m);
+ *m = (struct msg) {
.category = msg_class_to_category (class),
.severity = msg_class_to_severity (class),
.text = xvasprintf (format, args),
};
-
- msg_emit (&m);
+ msg_emit (m);
}
/* Writes error message in CLASS, with text FORMAT, formatted with
{
va_list args;
va_start (args, format);
- char *e = xvasprintf (format, args);
+ struct string s = DS_EMPTY_INITIALIZER;
+ ds_put_vformat (&s, format, args);
va_end (args);
+ ds_put_format (&s, ": %s", strerror (errnum));
- struct msg m = {
+ struct msg *m = xmalloc (sizeof *m);
+ *m = (struct msg) {
.category = MSG_C_GENERAL,
.severity = MSG_S_ERROR,
- .file_name = NULL,
- .text = xasprintf (_("%s: %s"), e, strerror (errnum)),
+ .text = ds_steal_cstr (&s),
};
- msg_emit (&m);
-
- free (e);
+ msg_emit (m);
}
msg_aux = aux;
}
\f
+/* msg_location. */
+
+void
+msg_location_uninit (struct msg_location *loc)
+{
+ intern_unref (loc->file_name);
+}
+
+void
+msg_location_destroy (struct msg_location *loc)
+{
+ if (loc)
+ {
+ msg_location_uninit (loc);
+ free (loc);
+ }
+}
+
+struct msg_location *
+msg_location_dup (const struct msg_location *src)
+{
+ if (!src)
+ return NULL;
+
+ struct msg_location *dst = xmalloc (sizeof *dst);
+ *dst = (struct msg_location) {
+ .file_name = intern_new_if_nonnull (src->file_name),
+ .first_line = src->first_line,
+ .last_line = src->last_line,
+ .first_column = src->first_column,
+ .last_column = src->last_column,
+ };
+ return dst;
+}
+
+bool
+msg_location_is_empty (const struct msg_location *loc)
+{
+ return !loc || (!loc->file_name
+ && loc->first_line <= 0
+ && loc->first_column <= 0);
+}
+
+void
+msg_location_format (const struct msg_location *loc, struct string *s)
+{
+ if (!loc)
+ return;
+
+ if (loc->file_name)
+ ds_put_cstr (s, loc->file_name);
+
+ int l1 = loc->first_line;
+ int l2 = MAX (loc->first_line, loc->last_line - 1);
+ int c1 = loc->first_column;
+ int c2 = MAX (loc->first_column, loc->last_column - 1);
+
+ if (l1 > 0)
+ {
+ if (loc->file_name)
+ ds_put_byte (s, ':');
+
+ if (l2 > l1)
+ {
+ if (c1 > 0)
+ ds_put_format (s, "%d.%d-%d.%d", l1, c1, l2, c2);
+ else
+ ds_put_format (s, "%d-%d", l1, l2);
+ }
+ else
+ {
+ if (c1 > 0)
+ {
+ if (c2 > c1)
+ {
+ /* The GNU coding standards say to use
+ LINENO-1.COLUMN-1-COLUMN-2 for this case, but GNU
+ Emacs interprets COLUMN-2 as LINENO-2 if I do that.
+ I've submitted an Emacs bug report:
+ http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7725.
+
+ For now, let's be compatible. */
+ ds_put_format (s, "%d.%d-%d.%d", l1, c1, l1, c2);
+ }
+ else
+ ds_put_format (s, "%d.%d", l1, c1);
+ }
+ else
+ ds_put_format (s, "%d", l1);
+ }
+ }
+ else if (c1 > 0)
+ {
+ if (c2 > c1)
+ ds_put_format (s, ".%d-%d", c1, c2);
+ else
+ ds_put_format (s, ".%d", c1);
+ }
+}
+\f
+/* msg_stack */
+
+void
+msg_stack_destroy (struct msg_stack *stack)
+{
+ if (stack)
+ {
+ msg_location_destroy (stack->location);
+ free (stack->description);
+ free (stack);
+ }
+}
+
+struct msg_stack *
+msg_stack_dup (const struct msg_stack *src)
+{
+ struct msg_stack *dst = xmalloc (sizeof *src);
+ *dst = (struct msg_stack) {
+ .location = msg_location_dup (src->location),
+ .description = xstrdup_if_nonnull (src->description),
+ };
+ return dst;
+}
+\f
/* Working with messages. */
const char *
/* Duplicate a message */
struct msg *
-msg_dup (const struct msg *m)
+msg_dup (const struct msg *src)
{
- struct msg *new_msg;
-
- new_msg = xmemdup (m, sizeof *m);
- if (m->file_name != NULL)
- new_msg->file_name = xstrdup (m->file_name);
- if (m->command_name != NULL)
- new_msg->command_name = xstrdup (m->command_name);
- new_msg->text = xstrdup (m->text);
-
- return new_msg;
+ struct msg_stack **ms = xmalloc (src->n_stack * sizeof *ms);
+ for (size_t i = 0; i < src->n_stack; i++)
+ ms[i] = msg_stack_dup (src->stack[i]);
+
+ struct msg *dst = xmalloc (sizeof *dst);
+ *dst = (struct msg) {
+ .category = src->category,
+ .severity = src->severity,
+ .stack = ms,
+ .n_stack = src->n_stack,
+ .location = msg_location_dup (src->location),
+ .command_name = xstrdup_if_nonnull (src->command_name),
+ .text = xstrdup (src->text),
+ };
+ return dst;
}
/* Frees a message created by msg_dup().
void
msg_destroy (struct msg *m)
{
- free (m->file_name);
- free (m->text);
- free (m->command_name);
- free (m);
+ if (m)
+ {
+ for (size_t i = 0; i < m->n_stack; i++)
+ msg_stack_destroy (m->stack[i]);
+ free (m->stack);
+ msg_location_destroy (m->location);
+ free (m->text);
+ free (m->command_name);
+ free (m);
+ }
}
char *
ds_init_empty (&s);
- if (m->category != MSG_C_GENERAL
- && (m->file_name || m->first_line > 0 || m->first_column > 0))
+ for (size_t i = 0; i < m->n_stack; i++)
{
- int l1 = m->first_line;
- int l2 = MAX (m->first_line, m->last_line - 1);
- int c1 = m->first_column;
- int c2 = MAX (m->first_column, m->last_column - 1);
-
- if (m->file_name)
- ds_put_format (&s, "%s", m->file_name);
-
- if (l1 > 0)
+ const struct msg_stack *ms = m->stack[i];
+ if (!msg_location_is_empty (ms->location))
{
- if (!ds_is_empty (&s))
- ds_put_byte (&s, ':');
-
- if (l2 > l1)
- {
- if (c1 > 0)
- ds_put_format (&s, "%d.%d-%d.%d", l1, c1, l2, c2);
- else
- ds_put_format (&s, "%d-%d", l1, l2);
- }
- else
- {
- if (c1 > 0)
- {
- if (c2 > c1)
- {
- /* The GNU coding standards say to use
- LINENO-1.COLUMN-1-COLUMN-2 for this case, but GNU
- Emacs interprets COLUMN-2 as LINENO-2 if I do that.
- I've submitted an Emacs bug report:
- http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7725.
-
- For now, let's be compatible. */
- ds_put_format (&s, "%d.%d-%d.%d", l1, c1, l1, c2);
- }
- else
- ds_put_format (&s, "%d.%d", l1, c1);
- }
- else
- ds_put_format (&s, "%d", l1);
- }
- }
- else if (c1 > 0)
- {
- if (c2 > c1)
- ds_put_format (&s, ".%d-%d", c1, c2);
- else
- ds_put_format (&s, ".%d", c1);
+ msg_location_format (ms->location, &s);
+ ds_put_cstr (&s, ": ");
}
+ ds_put_format (&s, "%s\n", ms->description);
+ }
+ if (m->category != MSG_C_GENERAL && !msg_location_is_empty (m->location))
+ {
+ msg_location_format (m->location, &s);
ds_put_cstr (&s, ": ");
}
static void
-ship_message (struct msg *m)
+ship_message (const struct msg *m)
{
enum { MAX_STACK = 4 };
- static struct msg *stack[MAX_STACK];
+ static const struct msg *stack[MAX_STACK];
static size_t n;
/* If we're recursing on a given message, or recursing deeply, drop it. */
free (s);
}
-
-
static void
process_msg (struct msg *m)
{
}
-/* Emits M as an error message.
- Frees allocated data in M. */
+/* Emits M as an error message. Takes ownership of M. */
void
msg_emit (struct msg *m)
{
if (!messages_disabled)
- process_msg (m);
-
- free (m->text);
- free (m->command_name);
+ process_msg (m);
+ msg_destroy (m);
}
/* Disables message output until the next call to msg_enable. If