/* PSPP - a program for statistical analysis.
- Copyright (C) 1997-9, 2000, 2007, 2009, 2010 Free Software Foundation, Inc.
+ Copyright (C) 1997-9, 2000, 2007, 2009, 2010, 2011 Free Software Foundation, Inc.
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
#include "data/case.h"
#include "data/casegrouper.h"
#include "data/casereader.h"
+#include "data/dataset.h"
#include "data/dictionary.h"
#include "data/format.h"
-#include "data/procedure.h"
#include "data/settings.h"
#include "data/value-labels.h"
#include "data/variable.h"
#include "libpspp/str.h"
#include "math/histogram.h"
#include "math/moments.h"
+#include "math/chart-geometry.h"
+
#include "output/chart-item.h"
#include "output/charts/piechart.h"
#include "output/charts/plot-hist.h"
/* Variable attributes. */
int width;
- struct fmt_spec print;
};
struct frq_proc
if (hist->x_min != SYSMIS && hist->x_max != SYSMIS
&& hist->x_min >= hist->x_max)
{
- msg (SE, _("MAX for histogram must be greater than or equal to MIN, "
- "but MIN was specified as %.15g and MAX as %.15g. "
- "MIN and MAX will be ignored."),
- hist->x_min, hist->x_max);
+ msg (SE, _("%s for histogram must be greater than or equal to %s, "
+ "but %s was specified as %.15g and %s as %.15g. "
+ "%s and %s will be ignored."),
+ "MAX", "MIN",
+ "MIN", hist->x_min,
+ "MAX", hist->x_max,
+ "MIN", "MAX");
hist->x_min = hist->x_max = SYSMIS;
}
}
if (pie->x_min != SYSMIS && pie->x_max != SYSMIS
&& pie->x_min >= pie->x_max)
{
- msg (SE, _("MAX for pie chart must be greater than or equal to MIN, "
- "but MIN was specified as %.15g and MAX as %.15g. "
- "MIN and MAX will be ignored."), pie->x_min, pie->x_max);
+ msg (SE, _("%s for pie chart must be greater than or equal to %s, "
+ "but %s was specified as %.15g and %s as %.15g. "
+ "%s and %s will be ignored."),
+ "MAX", "MIN",
+ "MIN", pie->x_min,
+ "MAX", pie->x_max,
+ "MIN", "MAX");
pie->x_min = pie->x_max = SYSMIS;
}
}
histogram = freq_tab_to_hist (frq, &vf->tab, vf->var);
- chart_item_submit (histogram_chart_create (
+ if ( histogram)
+ {
+ chart_item_submit (histogram_chart_create (
histogram->gsl_hist, var_to_string(vf->var),
vf->tab.valid_cases,
d[FRQ_MEAN],
d[FRQ_STDDEV],
frq->hist->draw_normal));
- statistic_destroy (&histogram->parent);
+ statistic_destroy (&histogram->parent);
+ }
}
if (frq->pie)
lex_match (lexer, T_EQUALS);
if (lex_token (lexer) != T_ALL
&& (lex_token (lexer) != T_ID
- || dict_lookup_var (dataset_dict (ds), lex_tokid (lexer)) == NULL))
+ || dict_lookup_var (dataset_dict (ds), lex_tokcstr (lexer)) == NULL))
return 2;
/* Get list of current variables, to avoid duplicates. */
vf->n_groups = 0;
vf->groups = NULL;
vf->width = var_get_width (var);
- vf->print = *var_get_print_format (var);
}
frq->n_vars = n_vars;
struct frq_proc *frq = frq_;
lex_match (lexer, T_EQUALS);
- if ((lex_token (lexer) == T_ID && dict_lookup_var (dataset_dict (ds), lex_tokid (lexer)) != NULL)
+ if ((lex_token (lexer) == T_ID
+ && dict_lookup_var (dataset_dict (ds), lex_tokcstr (lexer)) != NULL)
|| lex_token (lexer) == T_ID)
for (;;)
{
if (!lex_match (lexer, T_RPAREN))
{
free (v);
- msg (SE, _("`)' expected after GROUPED interval list."));
+ lex_error_expecting (lexer, "`)'", NULL_SENTINEL);
return 0;
}
}
{
if (vf->groups != NULL)
msg (SE, _("Variables %s specified multiple times on "
- "GROUPED subcommand."), var_get_name (v[i]));
+ "%s subcommand."), var_get_name (v[i]), "GROUPED");
else
{
vf->n_groups = nl;
goto found;
}
}
- msg (SE, _("Variables %s specified on GROUPED but not on "
- "VARIABLES."), var_get_name (v[i]));
+ msg (SE, _("Variables %s specified on %s but not on "
+ "%s."), var_get_name (v[i]), "GROUPED", "VARIABLES");
found:;
}
free (v);
- if (!lex_match (lexer, T_SLASH))
- break;
- if ((lex_token (lexer) != T_ID || dict_lookup_var (dataset_dict (ds), lex_tokid (lexer)) != NULL)
- && lex_token (lexer) != T_ALL)
- {
- lex_put_back (lexer, T_SLASH);
- break;
- }
+ if (lex_token (lexer) != T_SLASH)
+ break;
+
+ if ((lex_next_token (lexer, 1) == T_ID
+ && dict_lookup_var (dataset_dict (ds),
+ lex_next_tokcstr (lexer, 1)))
+ || lex_next_token (lexer, 1) == T_ALL)
+ {
+ /* The token after the slash is a variable name. Keep parsing. */
+ lex_get (lexer);
+ }
+ else
+ {
+ /* The token after the slash must be the start of a new
+ subcommand. Let the caller see the slash. */
+ break;
+ }
}
return 1;
if (label != NULL)
tab_text (t, 0, r, TAB_LEFT, label);
- tab_value (t, 1, r, TAB_NONE, &f->value, ft->dict, &vf->print);
+ tab_value (t, 1, r, TAB_NONE, &f->value, vf->var, NULL);
tab_double (t, 2, r, TAB_NONE, f->count, wfmt);
tab_double (t, 3, r, TAB_NONE, percent, NULL);
tab_double (t, 4, r, TAB_NONE, valid_percent, NULL);
if (label != NULL)
tab_text (t, 0, r, TAB_LEFT, label);
- tab_value (t, 1, r, TAB_NONE, &f->value, ft->dict, &vf->print);
+ tab_value (t, 1, r, TAB_NONE, &f->value, vf->var, NULL);
tab_double (t, 2, r, TAB_NONE, f->count, wfmt);
tab_double (t, 3, r, TAB_NONE,
f->count / ft->total_cases * 100.0, NULL);
if (rank <= tp)
break;
- if (f->count > 1
- && (rank - (f->count - 1) > tp || f + 1 >= ft->missing))
+ if (tp + 1 < rank || f + 1 >= ft->missing)
pc->value = f->value.f;
else
pc->value = calc_percentile (pc->p, W, f->value.f, f[1].value.f);
tab_double (t, 2, 0, TAB_NONE, ft->valid_cases, wfmt);
tab_double (t, 2, 1, TAB_NONE, ft->total_cases - ft->valid_cases, wfmt);
- for (i = 0; i < frq->n_percentiles; i++, r++)
+ for (i = 0; i < frq->n_percentiles; i++)
{
struct percentile *pc = &frq->percentiles[i];
tab_fixed (t, 1, r, TAB_LEFT, pc->p * 100, 3, 0);
tab_double (t, 2, r, TAB_NONE, pc->value,
var_get_print_format (vf->var));
+ r++;
}
tab_title (t, "%s", var_to_string (vf->var));
{
double x_min, x_max, valid_freq;
int i;
-
+ double bin_width;
struct histogram *histogram;
double iqr;
- int bins;
/* Find out the extremes of the x value, within the range to be included in
the histogram, and sum the total frequency of those values. */
/* Freedman-Diaconis' choice of bin width. */
iqr = calculate_iqr (frq);
- if (iqr != SYSMIS)
- {
- double bin_width = 2 * iqr / pow (valid_freq, 1.0 / 3.0);
- bins = (x_max - x_min) / bin_width;
- if (bins < 5)
- bins = 5;
- else if (bins > 400)
- bins = 400;
- }
- else
- bins = 5;
+ bin_width = 2 * iqr / pow (valid_freq, 1.0 / 3.0);
+
+ histogram = histogram_create (bin_width, x_min, x_max);
+
+ if ( histogram == NULL)
+ return NULL;
- histogram = histogram_create (bins, x_min, x_max);
for (i = 0; i < ft->n_valid; i++)
{
const struct freq *f = &ft->valid[i];