gsl_vector_free (id->msr);
gsl_vector_free (id->eval);
gsl_matrix_free (id->evec);
- if (id->mm.cov != NULL)
- gsl_matrix_free (id->mm.cov);
- if (id->mm.corr != NULL)
- gsl_matrix_free (CONST_CAST (gsl_matrix *, id->mm.corr));
free (id);
}
static bool run_factor (struct dataset *ds, const struct cmd_factor *factor);
-static void do_factor_by_matrix (const struct cmd_factor *factor, struct idata *idata);
+static bool do_factor_by_matrix (const struct cmd_factor *factor, struct idata *idata);
if (factor.n_vars < 2)
msg (MW, _("Factor analysis on a single variable is not useful."));
+ if (factor.n_vars < 1)
+ {
+ msg (ME, _("Factor analysis without variables is not possible."));
+ goto error;
+ }
+
if (matrix_reader)
{
struct idata *id = idata_alloc (factor.n_vars);
{
do_factor_by_matrix (&factor, id);
+ gsl_matrix_free (id->mm.corr);
id->mm.corr = NULL;
+ gsl_matrix_free (id->mm.cov);
id->mm.cov = NULL;
}
/* Return the communality of variable N, calculated to N_FACTORS */
static double
-communality (struct idata *idata, int n, int n_factors)
+communality (const struct idata *idata, int n, int n_factors)
{
return the_communality (idata->evec, idata->eval, n, n_factors);
}
static void
-show_scree (const struct cmd_factor *f, struct idata *idata)
+show_scree (const struct cmd_factor *f, const struct idata *idata)
{
struct scree *s;
const char *label ;
static void
-show_factor_matrix (const struct cmd_factor *factor, struct idata *idata, const char *title, const gsl_matrix *fm)
+show_factor_matrix (const struct cmd_factor *factor, const struct idata *idata, const char *title, const gsl_matrix *fm)
{
int i;
static void
-show_explained_variance (const struct cmd_factor * factor, struct idata *idata,
+show_explained_variance (const struct cmd_factor * factor,
+ const struct idata *idata,
const gsl_vector *initial_eigenvalues,
const gsl_vector *extracted_eigenvalues,
const gsl_vector *rotated_loadings)
struct idata *idata = idata_alloc (factor->n_vars);
idata->cvm = covariance_1pass_create (factor->n_vars, factor->vars,
- factor->wv, factor->exclude);
+ factor->wv, factor->exclude, true);
for ( ; (c = casereader_read (r) ); case_unref (c))
{
do_factor_by_matrix (factor, idata);
finish:
+ gsl_matrix_free (idata->mm.corr);
+ gsl_matrix_free (idata->mm.cov);
+
idata_free (idata);
casereader_destroy (r);
}
-static void
+static bool
do_factor_by_matrix (const struct cmd_factor *factor, struct idata *idata)
{
+ if (!idata->mm.cov && !idata->mm.corr)
+ {
+ msg (ME, _("The dataset has no complete covariance or correlation matrix."));
+ return false;
+ }
+
if (idata->mm.cov && !idata->mm.corr)
idata->mm.corr = correlation_from_covariance (idata->mm.cov, idata->mm.var_matrix);
if (idata->mm.corr && !idata->mm.cov)