refacotring

[pspp] / src / language / stats / ctables.c

diff --git a/src/language/stats/ctables.c b/src/language/stats/ctables.c
index fc58d4b704b1029cdf3687c0909c4e711aeb38a7..6c8812a1a4bc2c3506d097de63eae0416ad9841a 100644 (file)
--- a/src/language/stats/ctables.c
+++ b/src/language/stats/ctables.c
@@ -4692,107 +4692,64 @@ ctables_prepare_table (struct ctables_table *t)
                   }
 
                 size_t n_drop;
+                bool drop_inner = false;
                 if (at == CTAT_SUBTABLE
-                    && t->clabels_from_axis != PIVOT_AXIS_LAYER
-                    && t->clabels_to_axis != PIVOT_AXIS_LAYER)
-                  n_drop = a == t->clabels_from_axis ? 2 : 0;
-                else if (at == CTAT_SUBTABLE && t->label_axis[PIVOT_AXIS_ROW] == PIVOT_AXIS_LAYER)
+                    && t->clabels_from_axis != PIVOT_AXIS_LAYER)
                   {
-                    if (a == PIVOT_AXIS_COLUMN)
-                      n_drop = 1;
+                    if (t->clabels_to_axis != PIVOT_AXIS_LAYER)
+                      n_drop = a == t->clabels_from_axis ? 2 : 0;
                     else
                       {
-                        if (a == PIVOT_AXIS_ROW)
-                          {
-                            size_t n = nest->n_areas[at];
-                            if (n > 1)
-                              {
-                                nest->areas[at][n - 2] = nest->areas[at][n - 1];
-                                nest->n_areas[at]--;
-                              }
-                          }
-                        n_drop = 0;
-                      }
-                  }
-                else if (at == CTAT_SUBTABLE && t->label_axis[PIVOT_AXIS_COLUMN] == PIVOT_AXIS_LAYER)
-                  {
-                    if (a == PIVOT_AXIS_ROW)
-                      n_drop = 1;
-                    else
-                      {
-                        if (a == PIVOT_AXIS_COLUMN)
-                          {
-                            size_t n = nest->n_areas[at];
-                            if (n > 1)
-                              {
-                                nest->areas[at][n - 2] = nest->areas[at][n - 1];
-                                nest->n_areas[at]--;
-                              }
-                          }
-                        n_drop = 0;
+                        drop_inner = a == t->clabels_from_axis;
+                        n_drop = a != t->clabels_from_axis && a != PIVOT_AXIS_LAYER;
                       }
                   }
                 else if (at == CTAT_ROW && a == PIVOT_AXIS_COLUMN && t->label_axis[PIVOT_AXIS_ROW] == PIVOT_AXIS_COLUMN)
                   n_drop = 0;
-                else if (at == CTAT_COL && a == PIVOT_AXIS_ROW && t->label_axis[PIVOT_AXIS_ROW] == PIVOT_AXIS_COLUMN)
+                else if (at == CTAT_ROW && a == PIVOT_AXIS_COLUMN && t->label_axis[PIVOT_AXIS_COLUMN] == PIVOT_AXIS_ROW)
                   {
-                    size_t n = nest->n_areas[at];
-                    if (n > 1)
-                      {
-                        nest->areas[at][n - 2] = nest->areas[at][n - 1];
-                        nest->n_areas[at]--;
-                      }
+                    drop_inner = true;
                     n_drop = 0;
                   }
-                else if (at == CTAT_COL && a == PIVOT_AXIS_ROW && t->label_axis[PIVOT_AXIS_COLUMN] == PIVOT_AXIS_ROW)
-                  continue;
-                else if (at == CTAT_ROW && a == PIVOT_AXIS_COLUMN && t->label_axis[PIVOT_AXIS_COLUMN] == PIVOT_AXIS_ROW)
+                else if (at == CTAT_ROW && a == PIVOT_AXIS_COLUMN && t->label_axis[PIVOT_AXIS_COLUMN] == PIVOT_AXIS_LAYER)
                   {
-                    size_t n = nest->n_areas[at];
-                    if (n > 1)
-                      {
-                        nest->areas[at][n - 2] = nest->areas[at][n - 1];
-                        nest->n_areas[at]--;
-                      }
+                    drop_inner = true;
                     n_drop = 0;
                   }
-                else if (at == CTAT_COL && a == PIVOT_AXIS_ROW && t->label_axis[PIVOT_AXIS_ROW] == PIVOT_AXIS_LAYER)
+                else if (at == CTAT_COL && a == PIVOT_AXIS_ROW && t->label_axis[PIVOT_AXIS_ROW] == PIVOT_AXIS_COLUMN)
                   {
-                    size_t n = nest->n_areas[at];
-                    if (n > 1)
-                      {
-                        nest->areas[at][n - 2] = nest->areas[at][n - 1];
-                        nest->n_areas[at]--;
-                      }
+                    drop_inner = true;
                     n_drop = 0;
                   }
-                else if (at == CTAT_ROW && a == PIVOT_AXIS_COLUMN && t->label_axis[PIVOT_AXIS_COLUMN] == PIVOT_AXIS_LAYER)
+                else if (at == CTAT_COL && a == PIVOT_AXIS_ROW && t->label_axis[PIVOT_AXIS_COLUMN] == PIVOT_AXIS_ROW)
+                  n_drop = 0;
+                else if (at == CTAT_COL && a == PIVOT_AXIS_ROW && t->label_axis[PIVOT_AXIS_ROW] == PIVOT_AXIS_LAYER)
                   {
-                    size_t n = nest->n_areas[at];
-                    if (n > 1)
-                      {
-                        nest->areas[at][n - 2] = nest->areas[at][n - 1];
-                        nest->n_areas[at]--;
-                      }
+                    drop_inner = true;
                     n_drop = 0;
                   }
                 else
                   {
-                    bool drop_last = (at == CTAT_SUBTABLE ? a != PIVOT_AXIS_LAYER
-                                      : at == CTAT_ROW ? a == PIVOT_AXIS_COLUMN
-                                      : at == CTAT_COL ? a == PIVOT_AXIS_ROW
-                                      : false);
-                    bool drop_additional
-                      = ((t->label_axis[PIVOT_AXIS_ROW] == PIVOT_AXIS_COLUMN && (at == CTAT_ROW || at == CTAT_LAYERROW) && a == PIVOT_AXIS_ROW)
-                         || (t->label_axis[PIVOT_AXIS_COLUMN] == PIVOT_AXIS_ROW && (at == CTAT_COL || at == CTAT_LAYERCOL) && a == PIVOT_AXIS_COLUMN));
-
                     n_drop = 0;
-                    if (drop_last)
+                    if (at == CTAT_SUBTABLE ? a != PIVOT_AXIS_LAYER
+                        : at == CTAT_ROW ? a == PIVOT_AXIS_COLUMN
+                        : at == CTAT_COL ? a == PIVOT_AXIS_ROW
+                        : false)
                       n_drop++;
-                    if (drop_additional)
+                    if (((at == CTAT_ROW || at == CTAT_LAYERROW) && t->label_axis[PIVOT_AXIS_ROW] == PIVOT_AXIS_COLUMN && a == PIVOT_AXIS_ROW)
+                        || ((at == CTAT_COL || at == CTAT_LAYERCOL) && t->label_axis[PIVOT_AXIS_COLUMN] == PIVOT_AXIS_ROW && a == PIVOT_AXIS_COLUMN))
                       n_drop++;
                   }
 
+                if (drop_inner)
+                  {
+                    size_t n = nest->n_areas[at];
+                    if (n > 1)
+                      {
+                        nest->areas[at][n - 2] = nest->areas[at][n - 1];
+                        nest->n_areas[at]--;
+                      }
+                  }
                 for (size_t i = 0; i < n_drop; i++)
                   if (nest->n_areas[at] > 0)
                     nest->n_areas[at]--;