refactoring?

[pspp] / src / language / stats / ctables.c

diff --git a/src/language/stats/ctables.c b/src/language/stats/ctables.c
index 5aa92f7e46ee6743d3b9611f0e7ba6783d47bd86..2b8636581d0bb07eb044b4206b3ad3cdb3bf3838 100644 (file)
--- a/src/language/stats/ctables.c
+++ b/src/language/stats/ctables.c
@@ -4677,11 +4677,11 @@ ctables_prepare_table (struct ctables_table *t)
                     atb = PIVOT_AXIS_ROW;
                   }
 
-                if (((at == CTAT_LAYERCOL || at == CTAT_LAYERROW)
-                     && a == atb && t->label_axis[a] != a)
-                    || (at == CTAT_LAYER
-                        && a != PIVOT_AXIS_LAYER
-                        && t->label_axis[a] == PIVOT_AXIS_LAYER))
+                if (at == CTAT_LAYER
+                    ? a != PIVOT_AXIS_LAYER && t->label_axis[a] == PIVOT_AXIS_LAYER
+                    : at == CTAT_LAYERCOL || at == CTAT_LAYERROW
+                    ? a == atb && t->label_axis[a] != a
+                    : false)
                   {
                     for (size_t k = nest->n - 1; k < nest->n; k--)
                       if (k != nest->scale_idx)
@@ -4692,29 +4692,26 @@ ctables_prepare_table (struct ctables_table *t)
                     continue;
                   }
 
-                if (at == CTAT_LAYER ? a == PIVOT_AXIS_LAYER
-                    : at == CTAT_LAYERROW || at == CTAT_LAYERCOL ? a != atb
-                    : at == CTAT_TABLE ? false
-                    : true)
-                  for (size_t k = 0; k < nest->n; k++)
-                    {
-                      if (k == nest->scale_idx)
-                        continue;
-                      nest->areas[at][nest->n_areas[at]++] = k;
-                    }
+                if (at == CTAT_LAYER ? a != PIVOT_AXIS_LAYER
+                    : at == CTAT_LAYERROW || at == CTAT_LAYERCOL ? a == atb
+                    : at == CTAT_TABLE ? true
+                    : false)
+                  continue;
 
-                int n_drop = 0;
+                for (size_t k = 0; k < nest->n; k++)
+                  if (k != nest->scale_idx)
+                    nest->areas[at][nest->n_areas[at]++] = k;
+
+                int n_drop;
                 switch (at)
                   {
                   case CTAT_SUBTABLE:
-                    if (t->clabels_from_axis == PIVOT_AXIS_LAYER)
-                      n_drop = a != PIVOT_AXIS_LAYER;
-                    else if (t->clabels_to_axis != PIVOT_AXIS_LAYER)
-                      n_drop = a == t->clabels_from_axis ? 2 : 0;
-                    else if (a == t->clabels_from_axis)
-                      n_drop = -1;
-                    else
-                      n_drop = a != PIVOT_AXIS_LAYER;
+#define L PIVOT_AXIS_LAYER
+                    n_drop = (t->clabels_from_axis == L ? a != L
+                              : t->clabels_to_axis != L ? (a == t->clabels_from_axis ? 2 : 0)
+                              : a == t->clabels_from_axis ? -1
+                              : a != L);
+#undef L
                     break;
 
                   case CTAT_LAYERROW:
@@ -4724,19 +4721,16 @@ ctables_prepare_table (struct ctables_table *t)
 
                   case CTAT_ROW:
                   case CTAT_COL:
-                    if (a == atb)
-                      {
-                        if (t->clabels_from_axis == atb)
-                          n_drop = -1;
-                        else if (t->clabels_to_axis != atb)
-                          n_drop = 1;
-                      }
-                    else if (a == ata)
-                      n_drop = t->label_axis[ata] == atb;
+                    n_drop = (a == ata ? t->label_axis[ata] == atb
+                              : a != atb ? 0
+                              : t->clabels_from_axis == atb ? -1
+                              : t->clabels_to_axis != atb ? 1
+                              : 0);
                     break;
 
                   case CTAT_LAYER:
                   case CTAT_TABLE:
+                    n_drop = 0;
                     break;
                   }