check label positions for =OPPOSITE or =LAYER
[pspp] / src / language / stats / ctables.c
index 99efc09c5a2c339644b2981920fef47659d8f454..0ce4a333e922d998effd86f9ade28b7c50822e86 100644 (file)
@@ -22,6 +22,7 @@
 #include "data/dataset.h"
 #include "data/dictionary.h"
 #include "data/mrset.h"
+#include "data/value-labels.h"
 #include "language/command.h"
 #include "language/lexer/format-parser.h"
 #include "language/lexer/lexer.h"
@@ -284,6 +285,19 @@ enum ctables_label_position
     CTLP_LAYER,
   };
 
+static const char *
+ctables_label_position_to_string (enum ctables_label_position p)
+{
+  switch (p)
+    {
+    case CTLP_NORMAL: return "NORMAL";
+    case CTLP_OPPOSITE: return "OPPOSITE";
+    case CTLP_LAYER: return "LAYER";
+    }
+
+  NOT_REACHED ();
+}
+
 struct ctables_summary_spec_set
   {
     struct ctables_summary_spec *specs;
@@ -321,10 +335,11 @@ struct ctables_table
     struct ctables_axis *axes[PIVOT_N_AXES];
     struct ctables_stack stacks[PIVOT_N_AXES];
     enum pivot_axis_type summary_axis;
+    struct ctables_summary_spec_set summary_specs;
     struct hmap cells;
     struct hmap domains[N_CTDTS];
 
-    enum pivot_axis_type slabels_position;
+    enum pivot_axis_type slabels_axis;
     bool slabels_visible;
 
     enum ctables_label_position row_labels;
@@ -450,6 +465,46 @@ ctables_category_uninit (struct ctables_category *cat)
     }
 }
 
+static bool
+ctables_category_equal (const struct ctables_category *a,
+                        const struct ctables_category *b)
+{
+  if (a->type != b->type)
+    return false;
+
+  switch (a->type)
+    {
+    case CCT_NUMBER:
+      return a->number == b->number;
+
+    case CCT_STRING:
+      return strcmp (a->string, b->string);
+
+    case CCT_RANGE:
+      return a->range[0] == b->range[0] && a->range[1] == b->range[1];
+
+    case CCT_MISSING:
+    case CCT_OTHERNM:
+      return true;
+
+    case CCT_SUBTOTAL:
+    case CCT_HSUBTOTAL:
+    case CCT_TOTAL:
+      return !strcmp (a->total_label, b->total_label);
+
+    case CCT_VALUE:
+    case CCT_LABEL:
+    case CCT_FUNCTION:
+      return (a->include_missing == b->include_missing
+              && a->sort_ascending == b->sort_ascending
+              && a->sort_function == b->sort_function
+              && a->sort_var == b->sort_var
+              && a->percentile == b->percentile);
+    }
+
+  NOT_REACHED ();
+}
+
 static void
 ctables_categories_unref (struct ctables_categories *c)
 {
@@ -466,6 +521,20 @@ ctables_categories_unref (struct ctables_categories *c)
   free (c);
 }
 
+static bool
+ctables_categories_equal (const struct ctables_categories *a,
+                          const struct ctables_categories *b)
+{
+  if (a->n_cats != b->n_cats || a->show_empty != b->show_empty)
+    return false;
+
+  for (size_t i = 0; i < a->n_cats; i++)
+    if (!ctables_category_equal (&a->cats[i], &b->cats[i]))
+      return false;
+
+  return true;
+}
+
 /* Chi-square test (SIGTEST). */
 struct ctables_chisq
   {
@@ -540,6 +609,7 @@ struct ctables_summary_spec
     double percentile;          /* CTSF_PTILE only. */
     char *label;
     struct fmt_spec format;     /* XXX extra CTABLES formats */
+    size_t axis_idx;
   };
 
 static void
@@ -894,6 +964,12 @@ ctables_axis_parse_primary (struct ctables_axis_parse_ctx *ctx)
   return axis;
 }
 
+static bool
+has_digit (const char *s)
+{
+  return s[strcspn (s, "0123456789")] != '\0';
+}
+
 static struct ctables_axis *
 ctables_axis_parse_postfix (struct ctables_axis_parse_ctx *ctx)
 {
@@ -934,7 +1010,8 @@ ctables_axis_parse_postfix (struct ctables_axis_parse_ctx *ctx)
       /* Parse format. */
       struct fmt_spec format;
       const struct fmt_spec *formatp;
-      if (lex_token (ctx->lexer) == T_ID)
+      if (lex_token (ctx->lexer) == T_ID
+          && has_digit (lex_tokcstr (ctx->lexer)))
         {
           if (!parse_format_specifier (ctx->lexer, &format)
               || !fmt_check_output (&format)
@@ -961,14 +1038,12 @@ ctables_axis_parse_postfix (struct ctables_axis_parse_ctx *ctx)
             goto error;
           sv = CSV_TOTAL;
         }
-      else if (lex_force_match (ctx->lexer, T_RBRACK))
+      else if (lex_match (ctx->lexer, T_RBRACK))
         {
           if (sv == CSV_TOTAL && !lex_force_match (ctx->lexer, T_RBRACK))
             goto error;
           return sub;
         }
-      else
-        goto error;
     }
 
 error:
@@ -2427,107 +2502,510 @@ ctables_cell_insert (struct ctables_table *t,
     }
 }
 
-static bool
-ctables_execute (struct dataset *ds, struct ctables *ct)
+struct merge_item
+  {
+    const struct ctables_summary_spec_set *set;
+    size_t ofs;
+  };
+
+static int
+merge_item_compare_3way (const struct merge_item *a, const struct merge_item *b)
 {
-  for (size_t i = 0; i < ct->n_tables; i++)
+  const struct ctables_summary_spec *as = &a->set->specs[a->ofs];
+  const struct ctables_summary_spec *bs = &b->set->specs[b->ofs];
+  if (as->function != bs->function)
+    return as->function > bs->function ? 1 : -1;
+  else if (as->percentile != bs->percentile)
+    return as->percentile < bs->percentile ? 1 : -1;
+  return strcmp (as->label, bs->label);
+}
+
+static void
+ctables_table_output_same_axis (struct ctables *ct, struct ctables_table *t)
+{
+  struct pivot_table *pt = pivot_table_create__ (
+    (t->title
+     ? pivot_value_new_user_text (t->title, SIZE_MAX)
+     : pivot_value_new_text (N_("Custom Tables"))),
+    "Custom Tables");
+  if (t->caption)
+    pivot_table_set_caption (
+      pt, pivot_value_new_user_text (t->caption, SIZE_MAX));
+  if (t->corner)
+    pivot_table_set_caption (
+      pt, pivot_value_new_user_text (t->corner, SIZE_MAX));
+
+  pivot_table_set_look (pt, ct->look);
+  struct pivot_dimension *d[PIVOT_N_AXES];
+  for (enum pivot_axis_type a = 0; a < PIVOT_N_AXES; a++)
     {
-      struct ctables_table *t = ct->tables[i];
-      for (enum pivot_axis_type a = 0; a < PIVOT_N_AXES; a++)
-        if (t->axes[a])
-          {
-            t->stacks[a] = enumerate_fts (a, t->axes[a]);
+      static const char *names[] = {
+        [PIVOT_AXIS_ROW] = N_("Rows"),
+        [PIVOT_AXIS_COLUMN] = N_("Columns"),
+        [PIVOT_AXIS_LAYER] = N_("Layers"),
+      };
+      d[a] = (t->axes[a] || a == t->summary_axis
+              ? pivot_dimension_create (pt, a, names[a])
+              : NULL);
+      if (!d[a])
+        continue;
+
+      assert (t->axes[a]);
+
+      struct ctables_cell **sorted = xnmalloc (t->cells.count, sizeof *sorted);
+
+      struct ctables_cell *cell;
+      size_t n = 0;
+      HMAP_FOR_EACH (cell, struct ctables_cell, node, &t->cells)
+        if (!cell->hide)
+          sorted[n++] = cell;
+      assert (n <= t->cells.count);
+
+      struct ctables_cell_sort_aux aux = { .t = t, .a = a };
+      sort (sorted, n, sizeof *sorted, ctables_cell_compare_3way, &aux);
+
+      size_t max_depth = 0;
+      for (size_t j = 0; j < t->stacks[a].n; j++)
+        if (t->stacks[a].nests[j].n > max_depth)
+          max_depth = t->stacks[a].nests[j].n;
+
+      struct pivot_category **groups = xnmalloc (max_depth, sizeof *groups);
+      struct pivot_category *top = NULL;
+      int prev_leaf = 0;
+      for (size_t j = 0; j < n; j++)
+        {
+          struct ctables_cell *cell = sorted[j];
+          const struct ctables_nest *nest = &t->stacks[a].nests[cell->axes[a].stack_idx];
 
-            for (size_t j = 0; j < t->stacks[a].n; j++)
+          size_t n_common = 0;
+          bool new_subtable = false;
+          if (j > 0)
+            {
+              struct ctables_cell *prev = sorted[j - 1];
+              if (prev->axes[a].stack_idx == cell->axes[a].stack_idx)
+                {
+                  for (; n_common < nest->n; n_common++)
+                    if (n_common != nest->scale_idx
+                        && (prev->axes[a].cvs[n_common].category
+                            != cell->axes[a].cvs[n_common].category
+                            || !value_equal (&prev->axes[a].cvs[n_common].value,
+                                             &cell->axes[a].cvs[n_common].value,
+                                             var_get_type (nest->vars[n_common]))))
+                      break;
+                }
+              else
+                new_subtable = true;
+            }
+          else
+            new_subtable = true;
+
+          if (new_subtable)
+            {
+              enum ctables_vlabel vlabel = ct->vlabels[var_get_dict_index (nest->vars[0])];
+              top = d[a]->root;
+              if (vlabel != CTVL_NONE)
+                top = pivot_category_create_group__ (
+                  top, pivot_value_new_variable (nest->vars[0]));
+            }
+          if (n_common == nest->n)
+            {
+              cell->axes[a].leaf = prev_leaf;
+              continue;
+            }
+
+          for (size_t k = n_common; k < nest->n; k++)
+            {
+              struct pivot_category *parent = k > 0 ? groups[k - 1] : top;
+
+              struct pivot_value *label
+                = (k == nest->scale_idx ? NULL
+                   : (cell->axes[a].cvs[k].category->type == CCT_TOTAL
+                      || cell->axes[a].cvs[k].category->type == CCT_SUBTOTAL
+                      || cell->axes[a].cvs[k].category->type == CCT_HSUBTOTAL)
+                   ? pivot_value_new_user_text (cell->axes[a].cvs[k].category->total_label,
+                                                SIZE_MAX)
+                   : pivot_value_new_var_value (nest->vars[k],
+                                                &cell->axes[a].cvs[k].value));
+              if (k == nest->n - 1)
+                {
+                  if (a == t->summary_axis)
+                    {
+                      if (label)
+                        parent = pivot_category_create_group__ (parent, label);
+                      const struct ctables_summary_spec_set *specs = &nest->specs[cell->sv];
+                      for (size_t m = 0; m < specs->n; m++)
+                        {
+                          int leaf = pivot_category_create_leaf (
+                            parent, pivot_value_new_text (specs->specs[m].label));
+                          if (m == 0)
+                            prev_leaf = leaf;
+                        }
+                    }
+                  else
+                    {
+                      /* This assertion is true as long as the summary axis
+                         is the axis where the summaries are displayed. */
+                      assert (label);
+
+                      prev_leaf = pivot_category_create_leaf (parent, label);
+                    }
+                  break;
+                }
+
+              if (label)
+                parent = pivot_category_create_group__ (parent, label);
+
+              enum ctables_vlabel vlabel = ct->vlabels[var_get_dict_index (nest->vars[k + 1])];
+              if (vlabel != CTVL_NONE)
+                parent = pivot_category_create_group__ (
+                  parent, pivot_value_new_variable (nest->vars[k + 1]));
+              groups[k] = parent;
+            }
+
+          cell->axes[a].leaf = prev_leaf;
+        }
+      free (sorted);
+      free (groups);
+    }
+  struct ctables_cell *cell;
+  HMAP_FOR_EACH (cell, struct ctables_cell, node, &t->cells)
+    {
+      if (cell->hide)
+        continue;
+
+      const struct ctables_nest *nest = &t->stacks[t->summary_axis].nests[cell->axes[t->summary_axis].stack_idx];
+      const struct ctables_summary_spec_set *specs = &nest->specs[cell->sv];
+      for (size_t j = 0; j < specs->n; j++)
+        {
+          size_t dindexes[3];
+          size_t n_dindexes = 0;
+
+          for (enum pivot_axis_type a = 0; a < PIVOT_N_AXES; a++)
+            if (d[a])
               {
-                struct ctables_nest *nest = &t->stacks[a].nests[j];
-                for (enum ctables_domain_type dt = 0; dt < N_CTDTS; dt++)
+                int leaf = cell->axes[a].leaf;
+                if (a == t->summary_axis)
+                  leaf += j;
+                dindexes[n_dindexes++] = leaf;
+              }
+
+          double d = ctables_summary_value (cell, &cell->summaries[j], &specs->specs[j]);
+          struct pivot_value *value = pivot_value_new_number (d);
+          value->numeric.format = specs->specs[j].format;
+          pivot_table_put (pt, dindexes, n_dindexes, value);
+        }
+    }
+
+  pivot_table_submit (pt);
+}
+
+
+static void
+ctables_table_output_different_axis (struct ctables *ct, struct ctables_table *t)
+{
+  struct pivot_table *pt = pivot_table_create__ (
+    (t->title
+     ? pivot_value_new_user_text (t->title, SIZE_MAX)
+     : pivot_value_new_text (N_("Custom Tables"))),
+    "Custom Tables");
+  if (t->caption)
+    pivot_table_set_caption (
+      pt, pivot_value_new_user_text (t->caption, SIZE_MAX));
+  if (t->corner)
+    pivot_table_set_caption (
+      pt, pivot_value_new_user_text (t->corner, SIZE_MAX));
+
+  pivot_table_set_look (pt, ct->look);
+  struct pivot_dimension *d[PIVOT_N_AXES];
+  for (enum pivot_axis_type a = 0; a < PIVOT_N_AXES; a++)
+    {
+      static const char *names[] = {
+        [PIVOT_AXIS_ROW] = N_("Rows"),
+        [PIVOT_AXIS_COLUMN] = N_("Columns"),
+        [PIVOT_AXIS_LAYER] = N_("Layers"),
+      };
+      d[a] = (t->axes[a] || a == t->summary_axis
+              ? pivot_dimension_create (pt, a, names[a])
+              : NULL);
+      if (!d[a])
+        continue;
+
+      assert (t->axes[a]);
+
+      struct ctables_cell **sorted = xnmalloc (t->cells.count, sizeof *sorted);
+
+      struct ctables_cell *cell;
+      size_t n = 0;
+      HMAP_FOR_EACH (cell, struct ctables_cell, node, &t->cells)
+        if (!cell->hide)
+          sorted[n++] = cell;
+      assert (n <= t->cells.count);
+
+      struct ctables_cell_sort_aux aux = { .t = t, .a = a };
+      sort (sorted, n, sizeof *sorted, ctables_cell_compare_3way, &aux);
+
+      size_t max_depth = 0;
+      for (size_t j = 0; j < t->stacks[a].n; j++)
+        if (t->stacks[a].nests[j].n > max_depth)
+          max_depth = t->stacks[a].nests[j].n;
+
+      struct pivot_category **groups = xnmalloc (max_depth, sizeof *groups);
+      struct pivot_category *top = NULL;
+      int prev_leaf = 0;
+      for (size_t j = 0; j < n; j++)
+        {
+          struct ctables_cell *cell = sorted[j];
+          const struct ctables_nest *nest = &t->stacks[a].nests[cell->axes[a].stack_idx];
+
+          size_t n_common = 0;
+          bool new_subtable = false;
+          if (j > 0)
+            {
+              struct ctables_cell *prev = sorted[j - 1];
+              if (prev->axes[a].stack_idx == cell->axes[a].stack_idx)
+                {
+                  for (; n_common < nest->n; n_common++)
+                    if (n_common != nest->scale_idx
+                        && (prev->axes[a].cvs[n_common].category
+                            != cell->axes[a].cvs[n_common].category
+                            || !value_equal (&prev->axes[a].cvs[n_common].value,
+                                             &cell->axes[a].cvs[n_common].value,
+                                             var_get_type (nest->vars[n_common]))))
+                      break;
+                }
+              else
+                new_subtable = true;
+            }
+          else
+            new_subtable = true;
+
+          if (new_subtable)
+            {
+              enum ctables_vlabel vlabel = ct->vlabels[var_get_dict_index (nest->vars[0])];
+              top = d[a]->root;
+              if (vlabel != CTVL_NONE)
+                top = pivot_category_create_group__ (
+                  top, pivot_value_new_variable (nest->vars[0]));
+            }
+          if (n_common == nest->n)
+            {
+              cell->axes[a].leaf = prev_leaf;
+              continue;
+            }
+
+          for (size_t k = n_common; k < nest->n; k++)
+            {
+              struct pivot_category *parent = k > 0 ? groups[k - 1] : top;
+
+              struct pivot_value *label
+                = (k == nest->scale_idx ? NULL
+                   : (cell->axes[a].cvs[k].category->type == CCT_TOTAL
+                      || cell->axes[a].cvs[k].category->type == CCT_SUBTOTAL
+                      || cell->axes[a].cvs[k].category->type == CCT_HSUBTOTAL)
+                   ? pivot_value_new_user_text (cell->axes[a].cvs[k].category->total_label,
+                                                SIZE_MAX)
+                   : pivot_value_new_var_value (nest->vars[k],
+                                                &cell->axes[a].cvs[k].value));
+              if (k == nest->n - 1)
+                {
+                  if (a == t->slabels_axis)
+                    {
+                      if (label)
+                        parent = pivot_category_create_group__ (parent, label);
+                      const struct ctables_summary_spec_set *specs = &t->summary_specs;
+                      for (size_t m = 0; m < specs->n; m++)
+                        {
+                          int leaf = pivot_category_create_leaf (
+                            parent, pivot_value_new_text (specs->specs[m].label));
+                          if (m == 0)
+                            prev_leaf = leaf;
+                        }
+                    }
+                  else
+                    {
+                      prev_leaf = pivot_category_create_leaf (parent, label ? label : pivot_value_new_user_text ("text", SIZE_MAX));
+                    }
+                  break;
+                }
+
+              if (label)
+                parent = pivot_category_create_group__ (parent, label);
+
+              enum ctables_vlabel vlabel = ct->vlabels[var_get_dict_index (nest->vars[k + 1])];
+              if (vlabel != CTVL_NONE)
+                parent = pivot_category_create_group__ (
+                  parent, pivot_value_new_variable (nest->vars[k + 1]));
+              groups[k] = parent;
+            }
+
+          cell->axes[a].leaf = prev_leaf;
+        }
+      free (sorted);
+      free (groups);
+    }
+  pivot_table_submit (pt);
+}
+
+
+static void
+ctables_prepare_table (struct ctables_table *t)
+{
+  for (enum pivot_axis_type a = 0; a < PIVOT_N_AXES; a++)
+    if (t->axes[a])
+      {
+        t->stacks[a] = enumerate_fts (a, t->axes[a]);
+
+        for (size_t j = 0; j < t->stacks[a].n; j++)
+          {
+            struct ctables_nest *nest = &t->stacks[a].nests[j];
+            for (enum ctables_domain_type dt = 0; dt < N_CTDTS; dt++)
+              {
+                nest->domains[dt] = xmalloc (nest->n * sizeof *nest->domains[dt]);
+                nest->n_domains[dt] = 0;
+
+                for (size_t k = 0; k < nest->n; k++)
                   {
-                    nest->domains[dt] = xmalloc (nest->n * sizeof *nest->domains[dt]);
-                    nest->n_domains[dt] = 0;
+                    if (k == nest->scale_idx)
+                      continue;
 
-                    for (size_t k = 0; k < nest->n; k++)
+                    switch (dt)
                       {
-                        if (k == nest->scale_idx)
-                          continue;
+                      case CTDT_TABLE:
+                        continue;
 
-                        switch (dt)
+                      case CTDT_LAYER:
+                        if (a != PIVOT_AXIS_LAYER)
+                          continue;
+                        break;
+
+                      case CTDT_SUBTABLE:
+                      case CTDT_ROW:
+                      case CTDT_COL:
+                        if (dt == CTDT_SUBTABLE ? a != PIVOT_AXIS_LAYER
+                            : dt == CTDT_ROW ? a == PIVOT_AXIS_COLUMN
+                            : a == PIVOT_AXIS_ROW)
                           {
-                          case CTDT_TABLE:
-                            continue;
-
-                          case CTDT_LAYER:
-                            if (a != PIVOT_AXIS_LAYER)
-                              continue;
-                            break;
-
-                          case CTDT_SUBTABLE:
-                          case CTDT_ROW:
-                          case CTDT_COL:
-                            if (dt == CTDT_SUBTABLE ? a != PIVOT_AXIS_LAYER
-                                : dt == CTDT_ROW ? a == PIVOT_AXIS_COLUMN
-                                : a == PIVOT_AXIS_ROW)
-                              {
-                                if (k == nest->n - 1
-                                    || (nest->scale_idx == nest->n - 1
-                                        && k == nest->n - 2))
-                                  continue;
-                              }
-                            break;
-
-                          case CTDT_LAYERROW:
-                            if (a == PIVOT_AXIS_COLUMN)
+                            if (k == nest->n - 1
+                                || (nest->scale_idx == nest->n - 1
+                                    && k == nest->n - 2))
                               continue;
-                            break;
-
-                          case CTDT_LAYERCOL:
-                            if (a == PIVOT_AXIS_ROW)
-                              continue;
-                            break;
                           }
+                        break;
+
+                      case CTDT_LAYERROW:
+                        if (a == PIVOT_AXIS_COLUMN)
+                          continue;
+                        break;
 
-                        nest->domains[dt][nest->n_domains[dt]++] = k;
+                      case CTDT_LAYERCOL:
+                        if (a == PIVOT_AXIS_ROW)
+                          continue;
+                        break;
                       }
+
+                    nest->domains[dt][nest->n_domains[dt]++] = k;
                   }
               }
           }
-        else
-          {
-            struct ctables_nest *nest = xmalloc (sizeof *nest);
-            *nest = (struct ctables_nest) { .n = 0 };
-            t->stacks[a] = (struct ctables_stack) { .nests = nest, .n = 1 };
-          }
+      }
+    else
+      {
+        struct ctables_nest *nest = xmalloc (sizeof *nest);
+        *nest = (struct ctables_nest) { .n = 0 };
+        t->stacks[a] = (struct ctables_stack) { .nests = nest, .n = 1 };
+      }
 
-      for (size_t i = 0; i < t->stacks[t->summary_axis].n; i++)
+  struct ctables_stack *stack = &t->stacks[t->summary_axis];
+  for (size_t i = 0; i < stack->n; i++)
+    {
+      struct ctables_nest *nest = &stack->nests[i];
+      if (!nest->specs[CSV_CELL].n)
         {
-          struct ctables_nest *nest = &t->stacks[t->summary_axis].nests[i];
-          if (!nest->specs[CSV_CELL].n)
-            {
-              struct ctables_summary_spec_set *specs = &nest->specs[CSV_CELL];
-              specs->specs = xmalloc (sizeof *specs->specs);
-              specs->n = 1;
-
-              enum ctables_summary_function function
-                = specs->var ? CTSF_MEAN : CTSF_COUNT;
-              struct ctables_var var = { .is_mrset = false, .var = specs->var };
-
-              *specs->specs = (struct ctables_summary_spec) {
-                .function = function,
-                .format = ctables_summary_default_format (function, &var),
-                .label = ctables_summary_default_label (function, 0),
-              };
-              if (!specs->var)
-                specs->var = nest->vars[0];
+          struct ctables_summary_spec_set *specs = &nest->specs[CSV_CELL];
+          specs->specs = xmalloc (sizeof *specs->specs);
+          specs->n = 1;
+
+          enum ctables_summary_function function
+            = specs->var ? CTSF_MEAN : CTSF_COUNT;
+          struct ctables_var var = { .is_mrset = false, .var = specs->var };
+
+          *specs->specs = (struct ctables_summary_spec) {
+            .function = function,
+            .format = ctables_summary_default_format (function, &var),
+            .label = ctables_summary_default_label (function, 0),
+          };
+          if (!specs->var)
+            specs->var = nest->vars[0];
 
-              ctables_summary_spec_set_clone (&nest->specs[CSV_TOTAL],
-                                              &nest->specs[CSV_CELL]);
+          ctables_summary_spec_set_clone (&nest->specs[CSV_TOTAL],
+                                          &nest->specs[CSV_CELL]);
+        }
+      else if (!nest->specs[CSV_TOTAL].n)
+        ctables_summary_spec_set_clone (&nest->specs[CSV_TOTAL],
+                                        &nest->specs[CSV_CELL]);
+    }
+
+  struct ctables_summary_spec_set *merged = &t->summary_specs;
+  struct merge_item *items = xnmalloc (2 * stack->n, sizeof *items);
+  size_t n_left = 0;
+  for (size_t j = 0; j < stack->n; j++)
+    {
+      const struct ctables_nest *nest = &stack->nests[j];
+      if (nest->n)
+        for (enum ctables_summary_variant sv = 0; sv < N_CSVS; sv++)
+          items[n_left++] = (struct merge_item) { .set = &nest->specs[sv] };
+    }
+
+  while (n_left > 0)
+    {
+      struct merge_item min = items[0];
+      for (size_t j = 1; j < n_left; j++)
+        if (merge_item_compare_3way (&items[j], &min) < 0)
+          min = items[j];
+
+      if (merged->n >= merged->allocated)
+        merged->specs = x2nrealloc (merged->specs, &merged->allocated,
+                                    sizeof *merged->specs);
+      merged->specs[merged->n++] = min.set->specs[min.ofs];
+
+      for (size_t j = 0; j < n_left; )
+        {
+          if (merge_item_compare_3way (&items[j], &min) == 0)
+            {
+              struct merge_item *item = &items[j];
+              item->set->specs[item->ofs].axis_idx = merged->n - 1;
+              if (++item->ofs >= item->set->n)
+                {
+                  items[j] = items[--n_left];
+                  continue;
+                }
             }
-          else if (!nest->specs[CSV_TOTAL].n)
-            ctables_summary_spec_set_clone (&nest->specs[CSV_TOTAL],
-                                            &nest->specs[CSV_CELL]);
+          j++;
         }
     }
 
+#if 0
+  for (size_t j = 0; j < merged->n; j++)
+    printf ("%s\n", ctables_summary_function_name (merged->specs[j].function));
+
+  for (size_t j = 0; j < stack->n; j++)
+    {
+      const struct ctables_nest *nest = &stack->nests[j];
+      for (enum ctables_summary_variant sv = 0; sv < N_CSVS; sv++)
+        {
+          const struct ctables_summary_spec_set *specs = &nest->specs[sv];
+          for (size_t k = 0; k < specs->n; k++)
+            printf ("(%s, %zu) ", ctables_summary_function_name (specs->specs[k].function),
+                    specs->specs[k].axis_idx);
+          printf ("\n");
+        }
+    }
+#endif
+}
+
+static bool
+ctables_execute (struct dataset *ds, struct ctables *ct)
+{
   struct casereader *input = casereader_create_filter_weight (proc_open (ds),
                                                               dataset_dict (ds),
                                                               NULL, NULL);
@@ -2555,184 +3033,79 @@ ctables_execute (struct dataset *ds, struct ctables *ct)
   for (size_t i = 0; i < ct->n_tables; i++)
     {
       struct ctables_table *t = ct->tables[i];
+      if (t->summary_axis == t->slabels_axis)
+        ctables_table_output_same_axis (ct, ct->tables[i]);
+      else
+        ctables_table_output_different_axis (ct, ct->tables[i]);
+    }
+  return proc_commit (ds);
+}
 
-      struct pivot_table *pt = pivot_table_create__ (
-        (t->title
-         ? pivot_value_new_user_text (t->title, SIZE_MAX)
-         : pivot_value_new_text (N_("Custom Tables"))),
-        "Custom Tables");
-      if (t->caption)
-        pivot_table_set_caption (
-          pt, pivot_value_new_user_text (t->caption, SIZE_MAX));
-      if (t->corner)
-        pivot_table_set_caption (
-          pt, pivot_value_new_user_text (t->corner, SIZE_MAX));
-
-      pivot_table_set_look (pt, ct->look);
-      struct pivot_dimension *d[PIVOT_N_AXES];
-      for (enum pivot_axis_type a = 0; a < PIVOT_N_AXES; a++)
-        {
-          static const char *names[] = {
-            [PIVOT_AXIS_ROW] = N_("Rows"),
-            [PIVOT_AXIS_COLUMN] = N_("Columns"),
-            [PIVOT_AXIS_LAYER] = N_("Layers"),
-          };
-          d[a] = (t->axes[a] || a == t->summary_axis
-                  ? pivot_dimension_create (pt, a, names[a])
-                  : NULL);
-          if (!d[a])
-            continue;
-
-          assert (t->axes[a]);
-
-          struct ctables_cell **sorted = xnmalloc (t->cells.count, sizeof *sorted);
-
-          struct ctables_cell *cell;
-          size_t n = 0;
-          HMAP_FOR_EACH (cell, struct ctables_cell, node, &t->cells)
-            if (!cell->hide)
-              sorted[n++] = cell;
-          assert (n <= t->cells.count);
-
-          struct ctables_cell_sort_aux aux = { .t = t, .a = a };
-          sort (sorted, n, sizeof *sorted, ctables_cell_compare_3way, &aux);
-
-          size_t max_depth = 0;
-          for (size_t j = 0; j < t->stacks[a].n; j++)
-            if (t->stacks[a].nests[j].n > max_depth)
-              max_depth = t->stacks[a].nests[j].n;
-
-          struct pivot_category **groups = xnmalloc (max_depth, sizeof *groups);
-          struct pivot_category *top = NULL;
-          int prev_leaf = 0;
-          for (size_t j = 0; j < n; j++)
-            {
-              struct ctables_cell *cell = sorted[j];
-              const struct ctables_nest *nest = &t->stacks[a].nests[cell->axes[a].stack_idx];
-
-              size_t n_common = 0;
-              bool new_subtable = false;
-              if (j > 0)
-                {
-                  struct ctables_cell *prev = sorted[j - 1];
-                  if (prev->axes[a].stack_idx == cell->axes[a].stack_idx)
-                    {
-                      for (; n_common < nest->n; n_common++)
-                        if (n_common != nest->scale_idx
-                            && (prev->axes[a].cvs[n_common].category
-                                != cell->axes[a].cvs[n_common].category
-                                || !value_equal (&prev->axes[a].cvs[n_common].value,
-                                                 &cell->axes[a].cvs[n_common].value,
-                                                 var_get_type (nest->vars[n_common]))))
-                          break;
-                    }
-                  else
-                    new_subtable = true;
-                }
-              else
-                new_subtable = true;
-
-              if (new_subtable)
-                {
-                  enum ctables_vlabel vlabel = ct->vlabels[var_get_dict_index (nest->vars[0])];
-                  top = d[a]->root;
-                  if (vlabel != CTVL_NONE)
-                    top = pivot_category_create_group__ (
-                      top, pivot_value_new_variable (nest->vars[0]));
-                }
-              if (n_common == nest->n)
-                {
-                  cell->axes[a].leaf = prev_leaf;
-                  continue;
-                }
+static bool
+ctables_check_label_position (struct ctables_table *t,
+                              enum pivot_axis_type axis,
+                              enum ctables_label_position label_pos,
+                              const char *subcommand_name)
+{
+  if (label_pos == CTLP_NORMAL)
+    return true;
 
-              for (size_t k = n_common; k < nest->n; k++)
-                {
-                  struct pivot_category *parent = k > 0 ? groups[k - 1] : top;
-
-                  struct pivot_value *label
-                    = (k == nest->scale_idx ? NULL
-                       : (cell->axes[a].cvs[k].category->type == CCT_TOTAL
-                          || cell->axes[a].cvs[k].category->type == CCT_SUBTOTAL
-                          || cell->axes[a].cvs[k].category->type == CCT_HSUBTOTAL)
-                       ? pivot_value_new_user_text (cell->axes[a].cvs[k].category->total_label,
-                                                    SIZE_MAX)
-                       : pivot_value_new_var_value (nest->vars[k],
-                                                    &cell->axes[a].cvs[k].value));
-                  if (k == nest->n - 1)
-                    {
-                      if (a == t->summary_axis)
-                        {
-                          if (label)
-                            parent = pivot_category_create_group__ (parent, label);
-                          const struct ctables_summary_spec_set *specs = &nest->specs[cell->sv];
-                          for (size_t m = 0; m < specs->n; m++)
-                            {
-                              int leaf = pivot_category_create_leaf (
-                                parent, pivot_value_new_text (specs->specs[m].label));
-                              if (m == 0)
-                                prev_leaf = leaf;
-                            }
-                        }
-                      else
-                        {
-                          /* This assertion is true as long as the summary axis
-                             is the axis where the summaries are displayed. */
-                          assert (label);
+  const struct ctables_stack *stack = &t->stacks[axis];
+  if (!stack->n)
+    return true;
 
-                          prev_leaf = pivot_category_create_leaf (parent, label);
-                        }
-                      break;
-                    }
+  const struct ctables_nest *n0 = &stack->nests[0];
+  const struct variable *v0 = n0->vars[n0->n - 1];
+  struct ctables_categories *c0 = t->categories[var_get_dict_index (v0)];
 
-                  if (label)
-                    parent = pivot_category_create_group__ (parent, label);
+  for (size_t i = 0; i < c0->n_cats; i++)
+    if (c0->cats[i].type == CCT_FUNCTION)
+      {
+        msg (SE, _("%s=%s is not allowed with sorting based "
+                   "on a summary function."),
+             subcommand_name, ctables_label_position_to_string (label_pos));
+        return false;
+      }
 
-                  enum ctables_vlabel vlabel = ct->vlabels[var_get_dict_index (nest->vars[k + 1])];
-                  if (vlabel != CTVL_NONE)
-                    parent = pivot_category_create_group__ (
-                      parent, pivot_value_new_variable (nest->vars[k + 1]));
-                  groups[k] = parent;
-                }
+  for (size_t i = 1; i < stack->n; i++)
+    {
+      const struct ctables_nest *ni = &stack->nests[i];
+      const struct variable *vi = ni->vars[ni->n - 1];
+      struct ctables_categories *ci = t->categories[var_get_dict_index (vi)];
 
-              cell->axes[a].leaf = prev_leaf;
-            }
-          free (sorted);
-          free (groups);
+      if (var_get_width (v0) != var_get_width (vi))
+        {
+          msg (SE, _("%s=%s requires the variables to be "
+                     "moved to have the same width, but %s has "
+                     "width %d and %s has width %d."),
+               subcommand_name, ctables_label_position_to_string (label_pos),
+               var_get_name (v0), var_get_width (v0),
+               var_get_name (vi), var_get_width (vi));
+          return false;
         }
-      struct ctables_cell *cell;
-      HMAP_FOR_EACH (cell, struct ctables_cell, node, &t->cells)
+      if (!val_labs_equal (var_get_value_labels (v0),
+                           var_get_value_labels (vi)))
         {
-          if (cell->hide)
-            continue;
-
-          const struct ctables_nest *nest = &t->stacks[t->summary_axis].nests[cell->axes[t->summary_axis].stack_idx];
-          const struct ctables_summary_spec_set *specs = &nest->specs[cell->sv];
-          for (size_t j = 0; j < specs->n; j++)
-            {
-              size_t dindexes[3];
-              size_t n_dindexes = 0;
-
-              for (enum pivot_axis_type a = 0; a < PIVOT_N_AXES; a++)
-                if (d[a])
-                  {
-                    int leaf = cell->axes[a].leaf;
-                    if (a == t->summary_axis)
-                      leaf += j;
-                    dindexes[n_dindexes++] = leaf;
-                  }
-
-              double d = ctables_summary_value (cell, &cell->summaries[j], &specs->specs[j]);
-              struct pivot_value *value = pivot_value_new_number (d);
-              value->numeric.format = specs->specs[j].format;
-              pivot_table_put (pt, dindexes, n_dindexes, value);
-            }
+          msg (SE, _("%s=%s requires the variables to be "
+                     "moved to have the same value labels, but %s "
+                     "and %s have different value labels."),
+               subcommand_name, ctables_label_position_to_string (label_pos),
+               var_get_name (v0), var_get_name (vi));
+          return false;
+        }
+      if (!ctables_categories_equal (c0, ci))
+        {
+          msg (SE, _("%s=%s requires the variables to be "
+                     "moved to have the same category "
+                     "specifications, but %s and %s have different "
+                     "category specifications."),
+               subcommand_name, ctables_label_position_to_string (label_pos),
+               var_get_name (v0), var_get_name (vi));
+          return false;
         }
-
-      pivot_table_submit (pt);
     }
 
-  return proc_commit (ds);
+  return true;
 }
 
 int
@@ -2970,7 +3343,7 @@ cmd_ctables (struct lexer *lexer, struct dataset *ds)
       struct ctables_table *t = xmalloc (sizeof *t);
       *t = (struct ctables_table) {
         .cells = HMAP_INITIALIZER (t->cells),
-        .slabels_position = PIVOT_AXIS_COLUMN,
+        .slabels_axis = PIVOT_AXIS_COLUMN,
         .slabels_visible = true,
         .row_labels = CTLP_NORMAL,
         .col_labels = CTLP_NORMAL,
@@ -3069,17 +3442,17 @@ cmd_ctables (struct lexer *lexer, struct dataset *ds)
         {
           if (lex_match_id (lexer, "SLABELS"))
             {
-              while (lex_token (lexer) != T_SLASH)
+              while (lex_token (lexer) != T_SLASH && lex_token (lexer) != T_ENDCMD)
                 {
                   if (lex_match_id (lexer, "POSITION"))
                     {
                       lex_match (lexer, T_EQUALS);
                       if (lex_match_id (lexer, "COLUMN"))
-                        t->slabels_position = PIVOT_AXIS_COLUMN;
+                        t->slabels_axis = PIVOT_AXIS_COLUMN;
                       else if (lex_match_id (lexer, "ROW"))
-                        t->slabels_position = PIVOT_AXIS_ROW;
+                        t->slabels_axis = PIVOT_AXIS_ROW;
                       else if (lex_match_id (lexer, "LAYER"))
-                        t->slabels_position = PIVOT_AXIS_LAYER;
+                        t->slabels_axis = PIVOT_AXIS_LAYER;
                       else
                         {
                           lex_error_expecting (lexer, "COLUMN", "ROW", "LAYER");
@@ -3101,7 +3474,7 @@ cmd_ctables (struct lexer *lexer, struct dataset *ds)
             }
           else if (lex_match_id (lexer, "CLABELS"))
             {
-              while (lex_token (lexer) != T_SLASH)
+              while (lex_token (lexer) != T_SLASH && lex_token (lexer) != T_ENDCMD)
                 {
                   if (lex_match_id (lexer, "AUTO"))
                     t->row_labels = t->col_labels = CTLP_NORMAL;
@@ -3405,6 +3778,12 @@ cmd_ctables (struct lexer *lexer, struct dataset *ds)
           goto error;
         }
 
+      ctables_prepare_table (t);
+
+      ctables_check_label_position (t, PIVOT_AXIS_ROW, t->row_labels,
+                                    "ROWLABELS");
+      ctables_check_label_position (t, PIVOT_AXIS_COLUMN, t->col_labels,
+                                    "COLLABELS");
     }
   while (lex_token (lexer) != T_ENDCMD);