PRINT: Improve error messages.

[pspp] / src / language / dictionary / vector.c

diff --git a/src/language/dictionary/vector.c b/src/language/dictionary/vector.c
index 16617f87e0b9e74f0864a22ccc285ee945d40f93..35e47380555ffb6693b5251dc97474d19a501435 100644 (file)
--- a/src/language/dictionary/vector.c
+++ b/src/language/dictionary/vector.c
@@ -51,9 +51,15 @@ cmd_vector (struct lexer *lexer, struct dataset *ds)
       size_t n_vectors, allocated_vectors;
 
       /* Get the name(s) of the new vector(s). */
-      if (!lex_force_id (lexer)
-          || !dict_id_is_valid (dict, lex_tokcstr (lexer), true))
+      if (!lex_force_id (lexer))
        return CMD_CASCADING_FAILURE;
+      char *error = dict_id_is_valid__ (dict, lex_tokcstr (lexer));
+      if (error)
+        {
+          lex_error (lexer, "%s", error);
+          free (error);
+          return CMD_CASCADING_FAILURE;
+        }
 
       vectors = NULL;
       n_vectors = allocated_vectors = 0;
@@ -63,16 +69,18 @@ cmd_vector (struct lexer *lexer, struct dataset *ds)
 
          if (dict_lookup_vector (dict, lex_tokcstr (lexer)))
            {
-             msg (SE, _("A vector named %s already exists."),
-                   lex_tokcstr (lexer));
+             lex_next_error (lexer, 0, 0,
+                              _("A vector named %s already exists."),
+                              lex_tokcstr (lexer));
              goto fail;
            }
 
           for (i = 0; i < n_vectors; i++)
             if (!utf8_strcasecmp (vectors[i], lex_tokcstr (lexer)))
              {
-               msg (SE, _("Vector name %s is given twice."),
-                     lex_tokcstr (lexer));
+               lex_next_error (lexer, 0, 0,
+                                _("Vector name %s is given twice."),
+                                lex_tokcstr (lexer));
                goto fail;
              }
 
@@ -95,8 +103,8 @@ cmd_vector (struct lexer *lexer, struct dataset *ds)
 
          if (n_vectors > 1)
            {
-             msg (SE, _("A slash must separate each vector "
-                         "specification in VECTOR's long form."));
+             lex_error (lexer, _("A slash must separate each vector "
+                                  "specification in VECTOR's long form."));
              goto fail;
            }
 
@@ -109,17 +117,10 @@ cmd_vector (struct lexer *lexer, struct dataset *ds)
       else if (lex_match (lexer, T_LPAREN))
        {
           /* Short form. */
-          struct fmt_spec format;
+          struct fmt_spec format = fmt_for_output (FMT_F, 8, 2);
           bool seen_format = false;
-
-          struct variable **vars;
-          int n_vars;
-
-          size_t i;
-
-          n_vars = 0;
-          format = fmt_for_output (FMT_F, 8, 2);
-          seen_format = false;
+          size_t n_vars = 0;
+          int start_ofs = lex_ofs (lexer) - 2;
           while (!lex_match (lexer, T_RPAREN))
             {
               if (lex_is_integer (lexer) && n_vars == 0)
@@ -132,9 +133,15 @@ cmd_vector (struct lexer *lexer, struct dataset *ds)
               else if (lex_token (lexer) == T_ID && !seen_format)
                 {
                   seen_format = true;
-                  if (!parse_format_specifier (lexer, &format)
-                      || !fmt_check_output (&format))
+                  if (!parse_format_specifier (lexer, &format))
                     goto fail;
+                  char *error = fmt_check_output__ (&format);
+                  if (error)
+                    {
+                      lex_next_error (lexer, -1, -1, "%s", error);
+                      free (error);
+                      goto fail;
+                    }
                 }
               else
                 {
@@ -143,28 +150,34 @@ cmd_vector (struct lexer *lexer, struct dataset *ds)
                 }
               lex_match (lexer, T_COMMA);
             }
+          int end_ofs = lex_ofs (lexer) - 1;
           if (n_vars == 0)
             {
-              lex_error (lexer, _("expecting vector length"));
+              lex_error (lexer, _("Syntax error expecting vector length."));
               goto fail;
             }
 
          /* Check that none of the variables exist and that their names are
              not excessively long. */
-          for (i = 0; i < n_vectors; i++)
+          for (size_t i = 0; i < n_vectors; i++)
            {
               int j;
              for (j = 0; j < n_vars; j++)
                {
                   char *name = xasprintf ("%s%d", vectors[i], j + 1);
-                  if (!dict_id_is_valid (dict, name, true))
+                  char *error = dict_id_is_valid__ (dict, name);
+                  if (error)
                     {
+                      lex_ofs_error (lexer, start_ofs, end_ofs, "%s", error);
+                      free (error);
                       free (name);
                       goto fail;
                     }
                   if (dict_lookup_var (dict, name))
                    {
-                     msg (SE, _("%s is an existing variable name."), name);
+                     lex_ofs_error (lexer, start_ofs, end_ofs,
+                                     _("%s is an existing variable name."),
+                                     name);
                       free (name);
                      goto fail;
                    }
@@ -173,13 +186,12 @@ cmd_vector (struct lexer *lexer, struct dataset *ds)
            }
 
          /* Finally create the variables and vectors. */
-          vars = pool_nmalloc (pool, n_vars, sizeof *vars);
-          for (i = 0; i < n_vectors; i++)
+          struct variable **vars = pool_nmalloc (pool, n_vars, sizeof *vars);
+          for (size_t i = 0; i < n_vectors; i++)
            {
-              int j;
-             for (j = 0; j < n_vars; j++)
+             for (size_t j = 0; j < n_vars; j++)
                {
-                  char *name = xasprintf ("%s%d", vectors[i], j + 1);
+                  char *name = xasprintf ("%s%zu", vectors[i], j + 1);
                  vars[j] = dict_create_var_assert (dict, name,
                                                     fmt_var_width (&format));
                   var_set_both_formats (vars[j], &format);