Refine knowledge of data intro.

[pspp] / dump.c

diff --git a/dump.c b/dump.c
index bf6003e9b1255079f73f9ebfdec6dd51dad8a4eb..3be7d5a9d6e94391b9adffb1d3cd062bdc4cac91 100644 (file)
--- a/dump.c
+++ b/dump.c
@@ -204,24 +204,17 @@ dump_value_31(void)
     match_byte_assert (0x58);
 }
 
-static void dump_value(int level, bool match1);
-static void dump_substs(void (*dump)(int level), int level);
-static void dump_value__(int level, bool match1);
-
 static void
-dump_value__with_preskip(int level)
+dump_value__(int level, bool match1)
 {
+  for (int i = 0; i <= level; i++)
+    printf ("    ");
+
   match_byte(0);
   match_byte(0);
   match_byte(0);
   match_byte(0);
-  dump_value__ (level, false);
-  putchar('\n');
-}
 
-static void
-dump_value__(int level, bool match1)
-{
   if (match_byte (3))
     {
       char *s1 = get_string();
@@ -289,42 +282,38 @@ dump_value__(int level, bool match1)
         match_byte (1);
     }
   else
-    dump_substs(dump_value__with_preskip, level + 1);
-}
-
-static void
-dump_value(int level, bool match1)
-{
-  for (int i = 0; i <= level; i++)
-    printf ("    ");
+    {
+      dump_value_31();
 
-  match_byte (0);
-  match_byte (0);
-  match_byte (0);
-  match_byte (0);
-  dump_value__(level, match1);
-  match_byte(0);
-  match_byte(0);
-  match_byte(0);
+      char *base = get_string();
+      int x = get_u32();
+      printf ("\"%s\" with %d variables:\n", base, x);
+      for (int i = 0; i < x; i++)
+        {
+          int y = get_u32();
+          if (!y)
+            y = 1;
+          else
+            match_u32_assert(0);
+          for (int j = 0; j <= level; j++)
+            printf ("    ");
+          printf("variable %d has %d values:\n", i, y);
+          for (int j = 0; j < y; j++)
+            {
+              dump_value__ (level + 1, false);
+              putchar('\n');
+            }
+        }
+    }
 }
 
 static void
-dump_dim_value(int level)
+dump_category(int level)
 {
-  for (int i = 0; i <= level; i++)
-    printf ("    ");
-
+  dump_value__ (level, true);
   match_byte(0);
   match_byte(0);
   match_byte(0);
-  match_byte(0);
-  dump_value__(level, true);
-}
-
-static void
-dump_category(int level)
-{
-  dump_value (level, true);
 
   if (match_u32 (1))
     match_byte (0);
@@ -353,7 +342,7 @@ dump_dim(void)
 {
   int n_categories;
   printf("next dim\n");
-  dump_dim_value(0);
+  dump_value__ (0, false);
 
   /* This byte is usually 0x02 but 0x00 and 0x75 (!) have also been spotted. */
   pos++;
@@ -386,121 +375,61 @@ dump_dims(void)
     }
 }
 
-static void
-dump_substs(void (*dump)(int level), int level)
+static int
+compare_int(const void *a_, const void *b_)
 {
-  dump_value_31();
-
-  char *base = get_string();
-  int x = get_u32();
-  printf ("\"%s\" with %d variables:\n", base, x);
-  for (int i = 0; i < x; i++)
-    {
-      int y = get_u32();
-      if (!y)
-        y = 1;
-      else
-        match_u32_assert(0);
-      for (int j = 0; j <= level; j++)
-        printf ("    ");
-      printf("variable %d has %d values:\n", i, y);
-      for (int j = 0; j < y; j++)
-        {
-          dump (level+1);
-          putchar('\n');
-        }
-    }
+  const int *a = a_;
+  const int *b = b_;
+  return *a < *b ? -1 : *a > *b;
 }
 
 static void
-dump_data_value(int level)
+dump_data(void)
 {
-  for (int i = 0; i <= level; i++)
-    printf ("    ");
+  /* The first three numbers add to the number of dimensions. */
+  int t = get_u32();
+  t += get_u32();
+  match_u32_assert(n_dims - t);
 
-  match_byte(0);
-  match_byte(0);
-  match_byte(0);
-  match_byte(0);
-  if (data[pos] <= 5)
-    dump_value__(0, false);
-  else
-    dump_substs (dump_data_value, level + 1);
-}
+  /* The next n_dims numbers are a permutation of the dimension numbers. */
+  int a[n_dims], b[n_dims];
+  for (int i = 0; i < n_dims; i++)
+    a[i] = b[i] = get_u32();
+  qsort(b, n_dims, sizeof *b, compare_int);
+  for (int i = 0; i < n_dims; i++)
+    if (b[i] != i)
+      {
+        fprintf(stderr, "bad dimension permutation:");
+        for (int i = 0; i < n_dims; i++)
+          fprintf(stderr, " %d", a[i]);
+        putc('\n', stderr);
+        exit(1);
+      }
 
-static void
-dump_data(void)
-{
-#if 1
-  int a[16];
-  for (int i = 0; i < 3 + n_dims; i++)
-    a[i] = get_u32();
-  printf ("data intro:");
-  for (int i = 0; i < 3 + n_dims; i++)
-    printf(" %d", a[i]);
-  printf("\n");
-#else
-  fprintf (stderr,"data intro (%d dims):", n_dims);
-  for (int i = 0; i < 3+n_dims; i++)
-    fprintf (stderr," %d", get_u32());
-  fprintf(stderr,"\n");
-#endif
   int x = get_u32();
   printf ("%d data values, starting at %08x\n", x, pos);
   for (int i = 0; i < x; i++)
     {
       printf("%08x, index %d:\n", pos, get_u32());
       match_u32_assert(0);
-      dump_data_value(0);
+      dump_value__(0, false);
       putchar('\n');
     }
 }
 
-static void
-dump_title_value(int level)
-{
-  for (int i = 0; i <= level; i++)
-    printf ("    ");
-
-  match_byte (0);
-  match_byte (0);
-  match_byte (0);
-  match_byte (0);
-  if (data[pos] <= 5)
-    dump_value__(level, true);
-  else
-    dump_substs(dump_title_value, level + 1);
-}
-
-static void
-dump_footnote_value(int level)
-{
-  for (int i = 0; i <= level; i++)
-    printf ("    ");
-
-  match_byte (0);
-  match_byte (0);
-  match_byte (0);
-  match_byte (0);
-  if (data[pos] <= 5)
-    dump_value__(level, false);
-  else
-    dump_substs(dump_footnote_value, level + 1);
-}
-
 static void
 dump_title(void)
 {
   pos = 0x27;
-  dump_title_value(0); putchar('\n');
-  dump_title_value(0); putchar('\n');
+  dump_value__(0, true); putchar('\n');
+  dump_value__(0, true); putchar('\n');
   match_byte_assert(0x31);
-  dump_title_value(0); putchar('\n');
+  dump_value__(0, true); putchar('\n');
   match_byte(0);
   match_byte_assert(0x58);
   if (match_byte(0x31))
     {
-      dump_footnote_value(0); putchar('\n');
+      dump_value__(0, false); putchar('\n');
     }
   else
     match_byte_assert(0x58);
@@ -519,7 +448,7 @@ dump_title(void)
       for (int i = 0; i < n_footnotes; i++)
         {
           printf("footnote %d:\n", i);
-          dump_footnote_value(0);
+          dump_value__(0, false);
           if (match_byte (0x31))
             {
               /* Custom footnote marker string. */