projects
/
pspp
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
MEANS: remove arguments to callbacks which were always unused
[pspp]
/
src
/
ui
/
gui
/
sort-cases-dialog.c
diff --git
a/src/ui/gui/sort-cases-dialog.c
b/src/ui/gui/sort-cases-dialog.c
index 337aaf053ffba5620de4f6436b09a0f0b602d0a0..62d738c96db5ee08307d4b1e02bc69f25c730176 100644
(file)
--- a/
src/ui/gui/sort-cases-dialog.c
+++ b/
src/ui/gui/sort-cases-dialog.c
@@
-1,5
+1,5
@@
/* PSPPIRE - a graphical user interface for PSPP.
/* PSPPIRE - a graphical user interface for PSPP.
- Copyright (C) 2007 Free Software Foundation
+ Copyright (C) 2007
, 2010, 2011, 2012
Free Software Foundation
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
@@
-24,23
+24,24
@@
#include "dialog-common.h"
#include "psppire-selector.h"
#include "dict-display.h"
#include "dialog-common.h"
#include "psppire-selector.h"
#include "dict-display.h"
+#include "psppire-var-view.h"
-#include
<language/syntax-string-source.h>
+#include
"builder-wrapper.h"
#include "helper.h"
#include "helper.h"
+
static void
refresh (PsppireDialog *dialog, GtkTreeView *dest)
{
GtkTreeModel *liststore = gtk_tree_view_get_model (dest);
static void
refresh (PsppireDialog *dialog, GtkTreeView *dest)
{
GtkTreeModel *liststore = gtk_tree_view_get_model (dest);
-
gtk_list_store_clear (GTK_LIST_STORE (liststore));
}
struct sort_cases_dialog
{
gtk_list_store_clear (GTK_LIST_STORE (liststore));
}
struct sort_cases_dialog
{
-
GtkTree
View *tv;
+
PsppireVar
View *tv;
PsppireDict *dict;
GtkToggleButton *ascending;
};
PsppireDict *dict;
GtkToggleButton *ascending;
};
@@
-50,7
+51,7
@@
static gboolean
dialog_state_valid (gpointer data)
{
struct sort_cases_dialog *scd = data;
dialog_state_valid (gpointer data)
{
struct sort_cases_dialog *scd = data;
- GtkTreeModel *model = gtk_tree_view_get_model (
scd->tv
);
+ GtkTreeModel *model = gtk_tree_view_get_model (
GTK_TREE_VIEW (scd->tv)
);
gint n_rows = gtk_tree_model_iter_n_children (model, NULL);
gint n_rows = gtk_tree_model_iter_n_children (model, NULL);
@@
-65,8
+66,8
@@
generate_syntax (const struct sort_cases_dialog *scd)
{
gchar *text;
GString *string = g_string_new ("SORT CASES BY ");
{
gchar *text;
GString *string = g_string_new ("SORT CASES BY ");
- gint n_vars = append_variable_names (string,
-
scd->dict, GTK_TREE_VIEW (scd->tv), 0
);
+
+
gint n_vars = psppire_var_view_append_names (scd->tv, 0, string
);
if ( n_vars == 0 )
g_string_assign (string, "");
if ( n_vars == 0 )
g_string_assign (string, "");
@@
-89,10
+90,9
@@
generate_syntax (const struct sort_cases_dialog *scd)
/* Pops up the Sort Cases dialog box */
void
/* Pops up the Sort Cases dialog box */
void
-sort_cases_dialog (
GObject *o, gpointer data
)
+sort_cases_dialog (
PsppireDataWindow *de
)
{
gint response;
{
gint response;
- PsppireDataWindow *de = PSPPIRE_DATA_WINDOW (data);
struct sort_cases_dialog scd;
struct sort_cases_dialog scd;
@@
-102,9
+102,7
@@
sort_cases_dialog (GObject *o, gpointer data)
GtkWidget *source = get_widget_assert (xml, "sort-cases-treeview1");
GtkWidget *source = get_widget_assert (xml, "sort-cases-treeview1");
- GtkWidget *selector = get_widget_assert (xml, "sort-cases-selector");
GtkWidget *dest = get_widget_assert (xml, "sort-cases-treeview2");
GtkWidget *dest = get_widget_assert (xml, "sort-cases-treeview2");
-
PsppireVarStore *vs = NULL;
g_object_get (de->data_editor, "var-store", &vs, NULL);
PsppireVarStore *vs = NULL;
g_object_get (de->data_editor, "var-store", &vs, NULL);
@@
-114,15
+112,9
@@
sort_cases_dialog (GObject *o, gpointer data)
g_object_get (vs, "dictionary", &scd.dict, NULL);
g_object_set (source, "model", scd.dict, NULL);
g_object_get (vs, "dictionary", &scd.dict, NULL);
g_object_set (source, "model", scd.dict, NULL);
- set_dest_model (GTK_TREE_VIEW (dest), scd.dict);
-
- psppire_selector_set_select_func (PSPPIRE_SELECTOR (selector),
- insert_source_row_into_tree_view,
- NULL);
-
g_signal_connect (dialog, "refresh", G_CALLBACK (refresh), dest);
g_signal_connect (dialog, "refresh", G_CALLBACK (refresh), dest);
- scd.tv =
GTK_TREE
_VIEW (dest);
+ scd.tv =
PSPPIRE_VAR
_VIEW (dest);
scd.ascending =
GTK_TOGGLE_BUTTON (get_widget_assert (xml, "sort-cases-radiobutton0"));
scd.ascending =
GTK_TOGGLE_BUTTON (get_widget_assert (xml, "sort-cases-radiobutton0"));
@@
-137,22
+129,10
@@
sort_cases_dialog (GObject *o, gpointer data)
switch (response)
{
case GTK_RESPONSE_OK:
switch (response)
{
case GTK_RESPONSE_OK:
- {
- gchar *syntax = generate_syntax (&scd);
-
- struct getl_interface *sss = create_syntax_string_source (syntax);
- execute_syntax (sss);
-
- g_free (syntax);
- }
+ g_free (execute_syntax_string (de, generate_syntax (&scd)));
break;
case PSPPIRE_RESPONSE_PASTE:
break;
case PSPPIRE_RESPONSE_PASTE:
- {
- gchar *syntax = generate_syntax (&scd);
- paste_syntax_in_new_window (syntax);
-
- g_free (syntax);
- }
+ g_free (paste_syntax_to_window (generate_syntax (&scd)));
break;
default:
break;
break;
default:
break;