projects
/
pspp
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Issue an error if no valid data are found
[pspp]
/
src
/
language
/
stats
/
oneway.q
diff --git
a/src/language/stats/oneway.q
b/src/language/stats/oneway.q
index ed0add5835e62691ab1009b286b864f2c90d51f9..9b45119f8664f1ae948a5bfc838479fa8115f921 100644
(file)
--- a/
src/language/stats/oneway.q
+++ b/
src/language/stats/oneway.q
@@
-1,6
+1,6
@@
/* PSPP - One way ANOVA. -*-c-*-
/* PSPP - One way ANOVA. -*-c-*-
-Copyright (C) 1997-9, 2000 Free Software Foundation, Inc.
+Copyright (C) 1997-9, 2000
, 2007
Free Software Foundation, Inc.
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License as
This program is free software; you can redistribute it and/or
modify it under the terms of the GNU General Public License as
@@
-71,13
+71,13
@@
static bool bad_weight_warn = true;
static struct cmd_oneway cmd;
/* The independent variable */
static struct cmd_oneway cmd;
/* The independent variable */
-static struct variable *indep_var;
+static
const
struct variable *indep_var;
/* Number of dependent variables */
static size_t n_vars;
/* The dependent variables */
/* Number of dependent variables */
static size_t n_vars;
/* The dependent variables */
-static struct variable **vars;
+static
const
struct variable **vars;
/* A hash table containing all the distinct values of the independent
/* A hash table containing all the distinct values of the independent
@@
-175,7
+175,8
@@
output_oneway(void)
sum += subc_list_double_at(&cmd.dl_contrast[i],j);
if ( sum != 0.0 )
sum += subc_list_double_at(&cmd.dl_contrast[i],j);
if ( sum != 0.0 )
- msg(SW,_("Coefficients for contrast %d do not total zero"),i + 1);
+ msg(SW,_("Coefficients for contrast %d do not total zero"),
+ (int) i + 1);
}
if ( stat_tables & STAT_DESC )
}
if ( stat_tables & STAT_DESC )
@@
-224,7
+225,7
@@
oneway_custom_variables (struct lexer *lexer,
&& lex_token (lexer) != T_ALL)
return 2;
&& lex_token (lexer) != T_ALL)
return 2;
- if (!parse_variables (lexer, dict, &vars, &n_vars,
+ if (!parse_variables
_const
(lexer, dict, &vars, &n_vars,
PV_DUPLICATE
| PV_NUMERIC | PV_NO_SCRATCH) )
{
PV_DUPLICATE
| PV_NUMERIC | PV_NO_SCRATCH) )
{
@@
-879,6
+880,12
@@
precalc ( struct cmd_oneway *cmd UNUSED )
}
}
}
}
+static void
+free_value (void *value_, const void *aux UNUSED)
+{
+ union value *value = value_;
+ free (value);
+}
static bool
run_oneway(const struct ccase *first, const struct casefile *cf,
static bool
run_oneway(const struct ccase *first, const struct casefile *cf,
@@
-895,12
+902,13
@@
run_oneway(const struct ccase *first, const struct casefile *cf,
global_group_hash = hsh_create(4,
(hsh_compare_func *) compare_values,
(hsh_hash_func *) hash_value,
global_group_hash = hsh_create(4,
(hsh_compare_func *) compare_values,
(hsh_hash_func *) hash_value,
-
0
,
+
free_value
,
(void *) var_get_width (indep_var) );
precalc(cmd);
(void *) var_get_width (indep_var) );
precalc(cmd);
- filter = casefilter_create ( (cmd->incl != ONEWAY_INCLUDE),
+ filter = casefilter_create ( (cmd->incl != ONEWAY_INCLUDE
+ ? MV_ANY : MV_SYSTEM),
vars, n_vars );
for(r = casefile_get_reader (cf, filter);
vars, n_vars );
for(r = casefile_get_reader (cf, filter);
@@
-911,13
+919,17
@@
run_oneway(const struct ccase *first, const struct casefile *cf,
const double weight =
dict_get_case_weight (dataset_dict (ds), &c, &bad_weight_warn);
const double weight =
dict_get_case_weight (dataset_dict (ds), &c, &bad_weight_warn);
-
- const union value *indep_val;
+ const union value *indep_val;
+ void **p;
+
if ( casefilter_variable_missing (filter, &c, indep_var))
continue;
indep_val = case_data (&c, indep_var);
if ( casefilter_variable_missing (filter, &c, indep_var))
continue;
indep_val = case_data (&c, indep_var);
+ p = hsh_probe (global_group_hash, indep_val);
+ if (*p == NULL)
+ *p = value_dup (indep_val, var_get_width (indep_var));
hsh_insert ( global_group_hash, (void *) indep_val );
hsh_insert ( global_group_hash, (void *) indep_val );