projects
/
pspp
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
EXAMINE: Don't crash when unrenderable graphs are requested.
[pspp]
/
src
/
language
/
control
/
repeat.c
diff --git
a/src/language/control/repeat.c
b/src/language/control/repeat.c
index b2c2bb413e501bda41721c95b8ded972fd02950b..c73d02827149290d9af9dd05dbf5992000e2600b 100644
(file)
--- a/
src/language/control/repeat.c
+++ b/
src/language/control/repeat.c
@@
-38,6
+38,7
@@
#include "gl/ftoastr.h"
#include "gl/minmax.h"
#include "gl/xalloc.h"
#include "gl/ftoastr.h"
#include "gl/minmax.h"
#include "gl/xalloc.h"
+#include "gl/xmemdup0.h"
#include "gettext.h"
#define _(msgid) gettext (msgid)
#include "gettext.h"
#define _(msgid) gettext (msgid)
@@
-46,6
+47,7
@@
struct dummy_var
{
struct hmap_node hmap_node;
char *name;
{
struct hmap_node hmap_node;
char *name;
+ size_t name_len;
char **values;
size_t n_values;
};
char **values;
size_t n_values;
};
@@
-89,7
+91,7
@@
find_dummy_var (struct hmap *hmap, const char *name, size_t name_len)
HMAP_FOR_EACH_WITH_HASH (dv, struct dummy_var, hmap_node,
hash_dummy (name, name_len), hmap)
HMAP_FOR_EACH_WITH_HASH (dv, struct dummy_var, hmap_node,
hash_dummy (name, name_len), hmap)
- if (
utf8_strcasecmp (dv->name, name
))
+ if (
!utf8_strncasecmp (dv->name, dv->name_len, name, name_len
))
return dv;
return NULL;
return dv;
return NULL;
@@
-117,7
+119,9
@@
parse_specification (struct lexer *lexer, struct dictionary *dict,
if (dict_lookup_var (dict, name))
msg (SW, _("Dummy variable name `%s' hides dictionary variable `%s'."),
name, name);
if (dict_lookup_var (dict, name))
msg (SW, _("Dummy variable name `%s' hides dictionary variable `%s'."),
name, name);
- if (find_dummy_var (dummies, name, strlen (name)))
+
+ size_t name_len = strlen (name);
+ if (find_dummy_var (dummies, name, name_len))
{
msg (SE, _("Dummy variable name `%s' is given twice."), name);
goto error;
{
msg (SE, _("Dummy variable name `%s' is given twice."), name);
goto error;
@@
-125,7
+129,8
@@
parse_specification (struct lexer *lexer, struct dictionary *dict,
/* Make a new macro. */
dv = xmalloc (sizeof *dv);
/* Make a new macro. */
dv = xmalloc (sizeof *dv);
- dv->name = xstrdup (name);
+ dv->name = xmemdup0 (name, name_len);
+ dv->name_len = name_len;
dv->values = NULL;
dv->n_values = 0;
hmap_insert (dummies, &dv->hmap_node, hash_dummy (name, strlen (name)));
dv->values = NULL;
dv->n_values = 0;
hmap_insert (dummies, &dv->hmap_node, hash_dummy (name, strlen (name)));
@@
-205,7
+210,7
@@
do_parse_commands (struct substring s, enum segmenter_mode mode,
enum segment_type type;
int n;
enum segment_type type;
int n;
- n = segmenter_push (&segmenter, s.string, s.length, &type);
+ n = segmenter_push (&segmenter, s.string, s.length,
true,
&type);
assert (n >= 0);
if (type == SEG_DO_REPEAT_COMMAND)
assert (n >= 0);
if (type == SEG_DO_REPEAT_COMMAND)
@@
-215,7
+220,7
@@
do_parse_commands (struct substring s, enum segmenter_mode mode,
int k;
k = segmenter_push (&segmenter, s.string + n, s.length - n,
int k;
k = segmenter_push (&segmenter, s.string + n, s.length - n,
- &type);
+
true,
&type);
if (type != SEG_NEWLINE && type != SEG_DO_REPEAT_COMMAND)
break;
if (type != SEG_NEWLINE && type != SEG_DO_REPEAT_COMMAND)
break;
@@
-270,9
+275,6
@@
parse_commands (struct lexer *lexer, struct hmap *dummies)
ds_put_byte (&input, '\n');
lex_get (lexer);
}
ds_put_byte (&input, '\n');
lex_get (lexer);
}
- if (ds_is_empty (&input))
- ds_put_byte (&input, '\n');
- ds_put_byte (&input, '\0');
n_values = count_values (dummies);
outputs = xmalloc (n_values * sizeof *outputs);
n_values = count_values (dummies);
outputs = xmalloc (n_values * sizeof *outputs);
@@
-305,9
+307,8
@@
parse_commands (struct lexer *lexer, struct hmap *dummies)
for (i = 0; i < n_values; i++)
{
struct string *output = &outputs[n_values - i - 1];
for (i = 0; i < n_values; i++)
{
struct string *output = &outputs[n_values - i - 1];
- struct lex_reader *reader;
-
- reader = lex_reader_for_substring_nocopy (ds_ss (output));
+ const char *encoding = lex_get_encoding (lexer);
+ struct lex_reader *reader = lex_reader_for_substring_nocopy (ds_ss (output), encoding);
lex_reader_set_file_name (reader, file_name);
reader->line_number = line_number;
lex_include (lexer, reader);
lex_reader_set_file_name (reader, file_name);
reader->line_number = line_number;
lex_include (lexer, reader);
@@
-439,6
+440,6
@@
parse_strings (struct lexer *lexer, struct dummy_var *dv)
int
cmd_end_repeat (struct lexer *lexer UNUSED, struct dataset *ds UNUSED)
{
int
cmd_end_repeat (struct lexer *lexer UNUSED, struct dataset *ds UNUSED)
{
- msg (SE, _("No matching
DO REPEAT.")
);
+ msg (SE, _("No matching
%s."), "DO REPEAT"
);
return CMD_CASCADING_FAILURE;
}
return CMD_CASCADING_FAILURE;
}