1 Sat Dec 16 22:16:18 2006 Ben Pfaff <blp@gnu.org>
3 Make it possible to pull cases from the active file with a
4 function call, instead of requiring indirection through a callback
7 * automake.mk: Removed matrix-data.c.
9 * matrix-data.c: Removed.
11 * data-list.c (data_list_source_read): Conform with new
12 case_source_class interface.
13 (data_list_source_destroy): Ditto.
15 * get.c (case_reader_source_class): Ditto.
16 (case_reader_source_destroy): Ditto.
17 (parse_output_proc): Take advantage of new procedure interface.
18 (output_proc): Removed.
19 (struct mtf_file): Add "struct ccase *" member to allow use of new
21 (cmd_match_files): Take advantage of new procedure interface.
22 (mtf_processing_finish): Removed.
23 (mtf_read_nonactive_records): Renamed mtf_read_records. Now reads
24 from every file, without any exception for the active file.
25 (mtf_compare_BY_values): Simplify for new interface.
26 (mtf_processing): Simplify for new interface.
28 * inpt-pgm.c (is_valid_state): New function.
29 (input_program_source_read): Conform with new case_source_class
31 (input_program_source_destroy): Ditto.
32 (end_case_trns_proc): Now just needs to return TRNS_END_CASE.
34 Sat Dec 9 18:43:34 2006 Ben Pfaff <blp@gnu.org>
36 * list.q (cmd_list): Use new var_create, var_destroy functions.
38 Thu Nov 30 21:51:58 2006 Ben Pfaff <blp@gnu.org>
40 * inpt-pgm.c (cmd_reread): Always return error code upon detecting
41 syntax error. Fixes bug #18419. Thanks to John Darrington for
44 Sun Nov 19 09:17:45 2006 Ben Pfaff <blp@gnu.org>
46 * data-list.c (parse_free): Follow documented (but odd) rule that
47 N format is treated as F format for free-field input.
49 * data-reader.c (read_file_record): Drop new-line character from
50 input text lines. This is symmetrical with the recently changed
51 dfm_put_record semantics.
53 Thu Nov 2 20:56:03 2006 Ben Pfaff <blp@gnu.org>
55 Implement SKIP keyword on DATA LIST. Fixes bug #17099.
57 * data-list.c: (struct data_list_pgm) Add `skip_records' members.
58 (cmd_data_list) Set skip_records based on user input.
59 (data_list_source_read) Skip records requested by user.
61 Tue Oct 31 20:04:06 2006 Ben Pfaff <blp@gnu.org>
63 * placement-parser.c: (PRS_TYPE_T) Now that struct fmt_spec uses
64 an enum fmt_type for its type member, we can't depend on the
65 ability to put negative values into that member as out-of-band
66 values, because enum fmt_type might be an unsigned type. So use
67 values around SCHAR_MAX instead, because we know that SCHAR_MAX
68 will fit into any type, signed or unsigned, and there aren't
69 nearly that many format types.
70 (parse_var_placements) Add for_input parameter to specify whether
71 we're parsing input or output formats. Update all callers.
72 (fixed_parse_columns) Ditto.
73 (fixed_parse_fortran) Ditto.
75 Tue Oct 31 18:21:48 2006 Ben Pfaff <blp@gnu.org>
77 * print-space.c (print_space_trns_proc): Let dfm_put_record add
78 the new-line character, to match dfm_put_record change below.
80 Sat Oct 28 11:57:19 2006 Ben Pfaff <blp@gnu.org>
82 * data-writer.c (struct dfm_writer): Removed `bounce' member, and
84 (dfm_put_record) Change semantics so that it adds formatting
85 itself, such as new-line characters, instead of putting that
86 responsibility on the caller. Also, pad binary records with
87 spaces instead of zeros, for compatibility.
89 * print.c (struct prt_out_spec) New member `sysmis_as_spaces'.
90 (struct print_trns) Remove `omit_new_lines' and all references,
91 since dfm_put_record() is taking care of that. Add
93 (internal_cmd_print) Allow an empty set of data to print. Set
95 (parse_specs) Allow an empty set of data to print.
96 (parse_variable_argument) Only add space with PRINT command. Set
98 (print_trns_proc) Indent records if include_prefix is set, for
99 compatibility. Output SYSMIS as spaces if sysmis_as_spaces is
100 set. Put "1" in first column if PRINT EJECT is used with an
101 external output file.
102 (flush_records) Ditto.
104 Sat Oct 28 16:19:57 WST 2006 John Darrington <john@darrington.wattle.id.au>
106 * data-reader.c: Eliminated references to extern variable getl_buf
108 Sat Aug 5 08:25:07 2006 Ben Pfaff <blp@gnu.org>
110 Fix bug #17329 in REREAD parsing, reported by John Darrington.
112 * inpt-pgm.c (cmd_reread): Fix file handle parsing.
114 Mon Jul 31 10:32:31 2006 Ben Pfaff <blp@gnu.org>
116 * print.c (parse_specs): Allow a comma between specifications.
118 Sun Jul 16 19:57:10 2006 Ben Pfaff <blp@gnu.org>
120 * automake.mk: (src_language_data_io_libdata_io_a_SOURCE) Add
121 print-space.c, placement-parser.c, placement-parser.h.
123 * data-list.c: Basically rewrote the whole thing. Broke out a lot
124 of code into placement-parser.c. Code is much cleaner now.
126 * placement-parser.c: New file.
128 * placement-parser.h: New file.
130 * print.c: Basically rewrote the whole thing. Broke out PRINT
131 SPACE into print-space.c. Code is much cleaner now.
133 * print-space.c: New file.
135 Sat Jul 1 17:39:40 2006 Ben Pfaff <blp@gnu.org>
137 Fix bug #11612, "q2c documentation does not agree with code".
139 * list.q: Audit use of q2c "+" prefixes that indicate that a
140 command may appear multiple times.
142 Sat Jul 1 20:44:22 2006 Ben Pfaff <blp@gnu.org>
144 Fix bug #15786: System File Creation crashes if directoy is
147 * get.c (parse_write_command): Check that the any_writer open
150 Tue Jun 27 22:44:28 2006 Ben Pfaff <blp@gnu.org>
152 Fix regression in command name completion reported by John
153 Darrington. Now completion is again state-dependent and occurs
154 only on the first line of a command.
156 * inpt-pgm.c: (cmd_input_program) Reading of first token in
157 command moved into cmd_parse.
159 Fri Jun 9 13:56:00 2006 Ben Pfaff <blp@gnu.org>
161 Reform string library.
163 * matrix-data.c (context): Use dynamic string.
164 (another_token) Deal with changed dfm_get_record() interface.
168 * data-list.c (struct data_list_pgm) Delete delims, delim_cnt
169 members, replacing them by struct string delims. Update all
170 references to use struct string functions.
171 (cut_field) Change interface to avoid needing "end_blank", by
172 getting the data-reader to remember that state for us. Change
173 internals to use substring. Update both callers.
175 * data-reader.c (read_file_record): Use ds_read_stream().
176 (dfm_get_record) Change interface to return substring. Updated
178 (dfm_expand_tabs) Use ds_find_char(). Now maintain position
179 relative to end-of-line. Use ds_swap().
180 (dfm_reread_record) Don't limit position by line length.
181 (dfm_column_start) Make parameter const.
182 (dfm_columns_past_end) New function.
183 (dfm_get_column) New function.
185 Thu May 25 18:26:26 WST 2006 John Darrington <john@darrington.wattle.id.au>
187 * print.c (print_trns_free): Made the code agree with the comment, by
188 not freeing PRT. Has the side effect that the command no longer
189 crashes on invalid syntax.
191 Tue May 9 20:55:46 2006 Ben Pfaff <blp@gnu.org>
193 * get.c (cmd_match_files): Fix memory leak replacing default_dict.
195 Sat May 6 22:25:09 2006 Ben Pfaff <blp@gnu.org>
199 * list.q (write_fallback_headers): (write_fallback_headers)
200 Properly record width of leader and pass it to write_varname().
202 Sat May 6 19:03:13 2006 Ben Pfaff <blp@gnu.org>
204 * get.c: (mtf_merge_dictionary) Fix value label memory leak.
206 Sat May 6 13:51:16 2006 Ben Pfaff <blp@gnu.org>
208 Use a casefile, instead of a case sink, for MATCH FILES output.
209 It's more straightforward, although it has the same effect.
211 * get.c: (struct mtf_proc) Replace `sink' case sink member by
212 `output' casefile member.
213 (cmd_match_files) Work with casefile instead of sink.
214 (mtf_processing) Add case to casefile instead of sink.
216 Sat May 6 10:43:07 2006 Ben Pfaff <blp@gnu.org>
218 Continue reforming procedure execution. In this phase, get rid of
219 the output code for SPLIT FILE groups in procedure.c, which really
220 shouldn't be doing any output. Move it into the individual
221 procedures instead. This also adds some flexibility.
223 * list.q (write_all_headers): Call output_split_file_values().
225 Wed May 3 23:00:17 2006 Ben Pfaff <blp@gnu.org>
227 Continue reforming procedure execution. In this phase, get rid of
228 many global variables, consolidating procedure execution in
229 procedure.c. Encapsulate transformations in new "struct
230 trns_chain". Also, change implementation of N OF CASES, FILTER,
231 and PROCESS IF from special cases to transformations.
233 * data-list.c: (data_list_trns_proc) Return TRNS_END_FILE at end
234 of file. (Why didn't we do this before?)
235 (cmd_match_files) Direct procedure output to null sink.
236 Use discard_variables() instead of indirect version.
238 * inpt-pgm.c: Use transformation chain.
239 (struct input_program_pgm) Add trns_chain member.
240 (cmd_input_program) Initialize trns_chain member and capture
241 transformations with proc_capture_transformations().
242 (input_program_source_read) Use trns_chain_execute().
243 (destroy_input_program) Destroy input chain.
245 Tue May 2 10:39:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
247 * list.q Changed from using fixed length char buffers to struct
248 string so that any length variables can be used.
250 Mon May 1 18:21:19 2006 Ben Pfaff <blp@gnu.org>
252 Further clean up the CMD_* command result codes.
254 * (enum cmd_result_extensions) New. Add CMD_END_INPUT_PROGRAM and
255 CMD_END_CASE result codes.
256 (struct input_program_pgm) Added case_nr, write_case, wc_data
257 members for use by END CASE transformation.
258 (emit_END_CASE) New function.
259 (cmd_input_program) Interpret CMD_END_CASE by outputting an END
260 CASE transformation. If none is output by the input program
261 itself, add one automatically at the end. Change lack of
262 variables from warning to error.
263 (cmd_end_input_program) Return CMD_END_INPUT_PROGRAM instead of
265 (input_program_source_read) No longer any need to special-case END
266 CASE. Handle TRNS_DROP_CASE properly. Initialize new members in
267 inp for use by END CASE transformation.
268 (destroy_input_program) New function.
269 (input_program_source_destroy) Just call destroy_input_program().
270 (cmd_end_case) Just return CMD_END_CASE.
271 (end_case_trns_proc) No longer a stub handled by
272 input_program_source_read(). Actually output the case and
273 increment the case number.
275 Mon May 1 16:06:30 2006 Ben Pfaff <blp@gnu.org>
277 Remove vestiges of REPEATING DATA support.
279 * data-list.c: (struct rpd_num_or_var) Removed.
280 (struct repeating_data_trns) Removed.
281 (cmd_repeating_data) Removed.
282 (find_variable_input_spec) Removed.
283 (parse_num_or_var) Removed.
284 (parse_repeating_data) Removed.
285 (realize_value) Removed.
286 (struct rpd_parse_info) Removed.
287 (rpd_parse_record) Removed.
288 (repeating_data_trns_proc) Removed.
289 (repeating_data_trns_free) Removed.
290 (repeating_data_set_write_case) Removed.
293 * inpt-pgm.c: (input_program_source_read) Don't deal with
296 * data-list.h: Removed.
298 * automake.mk (src_language_data_io_libdata_io_a_SOURCES): Removed
301 Mon May 1 15:58:28 2006 Ben Pfaff <blp@gnu.org>
303 Remove vestiges of FILE TYPE support.
305 * data-list.c: (cmd_data_list) Don't check for FILE TYPE.
306 (cmd_repeating_data) Ditto.
308 * automake.mk (src_language_data_io_libdata_io_a_SOURCES): Remove
309 file-type.c, file-type.h.
311 * file-type.c: Removed.
313 * file-type.h: Removed.
315 Wed Apr 26 13:16:28 2006 Ben Pfaff <blp@gnu.org>
317 Improve the way we handle the various parsing "states". Until now
318 we've hard-coded the state transitions in the command definition
319 file, but that's error-prone and, worse, it's redundant--we can
320 figure out what state we're in anyhow. We can cleanly handle
321 INPUT PROGRAM and FILE TYPE with a nested command-processing loop.
323 * data-list.c: (cmd_data_list) Use in_file_type() or
324 in_input_program() in place of case_source_is_class() or
325 case_source_is_complex().
327 * file-type.c: NB: Not really fixed except minimally to compile,
328 because it doesn't work anyway.
329 (in_file_type) New function.
330 (cmd_record_type) No need to check that we're in FILE TYPE.
331 (cmd_end_file_type) Ditto.
332 (var file_type_source_class) Make static.
334 * get.c: (cmd_match_files) Check vfm_source instead of pgm_state.
336 * inpt-pgm.c: (in_input_program) New function.
337 (cmd_input_program) Rewrite to include nested command processing
339 (cmd_end_input_program) Just return CMD_END_SUBLOOP.
340 (var input_program_source_class) Make static.
341 (cmd_end_case) No need to check that we're in INPUT PROGRAM.
342 (cmd_end_file) Ditto.
344 * automake.mk (src_language_data_io_libdata_io_a_SOURCES): Add
345 file-type.h, inpt-pgm.h.
347 * file-type.h: New file.
349 * inpt-pgm.h: New file.
351 Tue Apr 25 13:11:55 2006 Ben Pfaff <blp@gnu.org>
353 * print.c: Don't special-case MS-DOS line terminators.
354 (macro LINE_END_WIDTH) Removed.
355 (alloc_line) Line ends are 1 byte.
356 (print_trns_proc) Just output \n for line end.
358 Sun Apr 23 22:05:58 2006 Ben Pfaff <blp@gnu.org>
360 Continue reforming error message support. In this phase, get rid
361 of message "titles" and put the message text in `struct error'.
362 Now `struct error' encapsulates a message more properly.
364 * data-list.c: (macro RPD_ERR) Removed.
365 (rpd_msg) New function. Updated all references to tmsg() to call
366 this function instead.
368 Sat Apr 15 19:38:13 2006 Ben Pfaff <blp@gnu.org>
370 Remove last users of struct file_ext so we can get rid of it
373 * data-reader.c: (struct dfm_reader) Change file member from
374 struct file_ext to FILE *. Updated all references.
375 (dfm_close_reader) Close file with fn_close() instead of
376 fn_close_ext(). Also, make a copy of the file name from the file
377 handle before closing it, because we can't extract it after we
379 (dfm_open_reader) Open file with fn_open() instead of
382 * data-writer.c: (struct dfm_writer) Change file member
383 struct file_ext to FILE *. Updated all references.
384 (dfm_close_writer) Close file with fn_close() instead of
385 fn_close_ext(). Also, make a copy of the file name from the file
386 handle before closing it, because we can't extract it after we
388 (dfm_open_writer) Open file with fn_open() instead of
391 Sat Apr 15 18:00:32 2006 Ben Pfaff <blp@gnu.org>
393 * data-list.c: Add prototype to suppress warning for
394 cmd_repeating_data().
396 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
398 * Moved files from src directory