1 2007-06-06 Ben Pfaff <blp@gnu.org>
3 In a couple of places we calculate the maximum number of cases to
4 keep in memory based on the user-defined workspace. Enable
5 centralizing the calculation through a new function.
7 * settings.c (get_workspace_cases): New function.
9 2007-06-06 Ben Pfaff <blp@gnu.org>
11 The casenumber type is defined in transformations.h, but case.h is
12 a more sensible place. Move it.
14 * case.h (CASENUMBER_MAX): New macro.
15 (typedef casenumber): Move here, from transformations.h.
17 2007-06-03 Ben Pfaff <blp@gnu.org>
19 Slightly generalize case_to_values and case_from_values functions.
21 * case.c (case_to_values): Rename case_copy_out, change interface.
22 (case_from_values): Rename case_copy_in, change interface.
24 * fastfile.c (fastfilereader_get_next_case): Update caller.
25 (write_case_to_disk): Ditto.
27 2007-06-02 Ben Pfaff <blp@gnu.org>
29 Clean up after a forgotten part of patch #5829.
31 * casedeque.h: Remove unused file.
33 * automake.mk: Remove casedeque.h from sources.
35 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
37 * category.c: Removed redundant #include
39 2007-05-06 Ben Pfaff <blp@gnu.org>
41 Abstract the documents within a dictionary a little better.
42 Thanks to John Darrington for suggestion, initial version, and
45 * dictionary.c (struct dictionary): Change `documents' member from
46 char * to struct string.
47 (dict_clear): Destroy struct string.
48 (dict_get_documents): Convert struct string to char *.
49 (dict_set_documents): Set struct string. Pad to 80-character
51 (dict_clear_documents): New function.
52 (dict_add_document_line): New function.
53 (dict_get_document_line_cnt): New function.
54 (dict_get_document_line): New function.
56 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
58 * sys-file-reader.c (read_documents): Use new document functions.
60 2007-04-19 John Darrington <john@darrington.wattle.id.au>
62 * sys-file-reader.c: When reading a system file which has no
63 long name table, automatically create one where the long names
64 are the lower case versions of the short names.
66 2007-04-22 Ben Pfaff <blp@gnu.org>
68 * dictionary.c (dict_set_split_vars): dict_destroy expects that
69 dict_clear will free most data related to the dictionary.
70 dict_clear does a decent job, except that dict_set_split_vars on
71 some systems won't actually free the dict's "split" member.
72 Instead, it'll allocate a 1-byte region. Fix this.
74 * value.c (value_copy): New function.
75 (value_set_missing): Ditto.
77 2007-04-22 John Darrington <john@darrington.wattle.id.au>
79 * Deleted existing category.h and moved cat-routines.h into
80 category.h Encapsulated struct cat_vals better.
82 2007-04-19 John Darrington <john@darrington.wattle.id.au>
84 * sys-file-reader.c: When reading a system file which has no
85 long name table, automatically create one where the long names
86 are the lower case versions of the short names.
88 2007-04-16 John Darrington <john@darrington.wattle.id.au>
90 * sys-file-reader.c: Some versions of Other Software seem to
91 produce system files with string variables' measure set to
92 zero. We'll assume these are supposed to be nominal variables.
94 2007-03-30 Ben Pfaff <blp@gnu.org>
96 * procedure.c: Adapt to new deque data structure.
98 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
99 Ben Pfaff <blp@gnu.org>
101 * file-name.c: Mingw compatibility fixes.
102 (fn_search_path): Use ISSLASH instead of comparing against '/'
104 (fn_dir_name): Use dir_name from gnulib.
105 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
106 (fn_get_identity): Use GetFullPathName instead of canonicalize
107 from gnulib, because the latter does not fully support
108 Windows-style path names. Use this implementation based on the
109 detected presence of Windows instead of the absence of Unix, since
110 the new implementation is Windows-specific.
111 (fn_compare_file_identities): In Windows implementation, compare
112 names case-insensitively.
114 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
116 * make-file.c: Don't include mkstemp.h, because gnulib now causes
117 <stdlib.h> to have the same effect.
119 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
121 * por-file-reader.c: Add missing _() around messages.
123 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
125 * make-file.c: Include "mkstemp.h", without which linking on
128 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
130 Reduce platform dependence.
132 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
133 Everywhere we using this, we really should have just depended on
134 the shell to expand tildes.
135 (fn_search_path): Simplify, given that we don't do tilde expansion
137 (fn_normalize): Removed. Caller changed to use the canonicalize
139 (fn_get_cwd): Removed. Only user was fn_normalize.
140 (fn_is_absolute): Really only test for absolute names.
141 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
143 (fn_readlink): Removed, as it was only used fn_normalize.
144 (fn_exists): Assume the stat function is available; gnulib does.
145 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
147 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
149 * dictionary.c (dict_create_vector_assert): New function.
151 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
153 * file-name.c (fn_normalize): Correct name of function
154 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
155 for pointing this out.
157 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
159 We are using a single member in struct file_handle, the "name"
160 field, for more than one purpose. When it begins with '"', it's a
161 file name; otherwise, it's a token that can be used to identify
162 it. When that assertion fires, it's because we searched for the
163 name case-sensitively as a file name (so that there was no match),
164 and then we try to insert it case-insensitively as a token, which
165 fails because duplicates aren't allowed.
167 Solution: break the two purposes into two separate fields. This
168 fixes the problem and likely makes the code easier to read too.
170 Fixes bug #18922. Thanks to John Darrington for bug report and
173 * file-handle-def.c (struct file_handle): New `id' member.
174 (fh_from_name): Rename fh_from_id. Update all callers.
175 (create_handle): New `id' parameter. Update all callers.
176 (fh_create_file): Ditto.
177 (fh_get_id): New function.
179 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
181 * case.c (case_is_null): Change return type to bool.
183 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
187 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
188 reference counting to share data. This makes it easy for
189 valgrind, etc. to find accesses to cases that have been destroyed
190 but have been kept around by another user's ref-count. This often
191 happens when the data set is small enough to find in memory; if a
192 bigger data set that would overflow to disk were used, then data
193 corruption would occur.
195 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
199 * case.c (case_unshare): Make it check internally whether the
200 ref_cnt is greater than 1, so that the callers don't have to.
201 Update callers not to check.
203 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
205 Before, I was thinking that I might want to get rid of reference
206 counting at some point. Now, I'm pretty sure that it's here to
207 stay. Thus, because we have to store the value_cnt anyway for
208 reference-counted cases, we might as well expose it to users.
210 * case.c (case_get_value_cnt): New function.
211 (case_resize): Drop OLD_CNT argument. Update all callers. Only
212 resize case if its size actually changed.
214 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
215 instead of peeking inside struct case directly.
216 (casefile_append): Ditto.
218 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
220 Get rid of the inlines for the case functions, which made the
221 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
222 the inlines didn't speed up "make check" at all, which is not a
223 perfect benchmark but seems indicative.)
225 * case.c: Remove #ifdef DEBUGGING...#endif around many function
226 definitions. Remove some assertions on nonnull pointers that were
227 redundant with a pointer dereference soon after in the function.
229 (struct case_data): Move definition here from case.h.
233 (case_data_wr): Ditto.
235 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
237 * automake.mk: Add casedeque.h to sources.
239 * casedeque.h: New file.
241 * procedure.c: (struct dataset) Change lag_count, lag_head,
242 lag_queue member into single struct casedeque member. Update all
243 users to use the casedeque instead.
246 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
248 * procedure.c: Simplify lagged cases interface. Updated all
249 clients--well, the only client--to use the simplified interface.
250 (dataset_n_lag) Removed.
251 (dataset_set_n_lag) Removed.
252 (dataset_need_lag) New function.
254 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
256 * dictionary.c procedure.c: More changes to ensure that callbacks occur
257 whenever appropriate, but only when the dataset/dictionary is in a
260 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
262 * dictionary.c dictionary.h : Added callbacks for change of filter and
263 split variables. Refactored some code to ensure that callbacks get
264 invoked when appropriate.
266 * procedure.c (proc_cancel_temporary_transformations): Make sure that
267 replace_dict callback occurs when permanent_dict replaces the current
270 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
272 * dictionary.c dictionary.h : Added callback for when the weight
273 variable of a dictionary changes.
275 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
277 * dictionary.c dictionary.h : Added replace_source and replace_dict
278 callbacks, and functions to deal with them.
280 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
282 Simplify missing value handling.
284 * missing-values.h (enum mv_class): New type.
285 (enum mv_type): Moved definition into missing-values.c and renamed
286 each MV_* to MVT_*, to distinguish them from the exposed mv_class
287 enums. Updated all uses.
288 (struct missing_values): Changed type of `type' from `enum
289 mv_type' to `int' because the definition is no longer exposed.
291 * missing-values.c (mv_is_value_missing): Add new enum mv_class
292 parameter. Update all callers.
293 (mv_is_num_missing): Ditto.
294 (mv_is_str_missing): Ditto.
295 (mv_is_value_user_missing): Removed. Changed callers to use
297 (mv_is_num_user_missing): Removed. Changed callers to use
299 (mv_is_str_user_missing): Removed. Changed callers to use
301 (mv_is_value_system_missing): Removed. Changed callers to use
303 (mv_set_type): Removed. Changed callers to use mv_clear.
304 (mv_clear): New function.
306 * variable.c (var_is_value_missing): Add new enum mv_class
307 parameter. Update all callers.
308 (var_is_num_missing): Ditto.
309 (var_is_str_missing): Ditto.
310 (var_is_value_user_missing): Removed. Changed callers to use
311 var_is_value_missing.
312 (var_is_num_user_missing): Removed. Changed callers to use
314 (var_is_str_user_missing): Removed. Changed callers to use
316 (var_is_value_system_missing): Removed. Changed callers to use
317 var_is_value_missing.
319 * casefilter.c (struct casefilter): Use enum mv_class in place of
321 (casefilter_variable_missing): Adapt to new member.
322 (casefilter_create): Change signature to take enum mv_class,
325 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
327 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
329 * case-sink.c case-sink.h procedure.c procedure.h
330 storage-stream.c: Now uses the factory.
332 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
334 Make it possible to pull cases from the active file with a
335 function call, instead of requiring indirection through a callback
338 * case-source.h (struct case_source_class): Change ->read function
339 to return a single case, instead of calling a callback function
340 for each case. Change ->destroy function to return an error
343 * case-source.c (free_case_source): Pass along the value returned
344 by the case_source ->destroy function.
346 * procedure.c (struct write_case_data): Removed.
347 (struct dataset): Added some members to track procedure state.
348 (procedure): Optimize the trivial case at this level.
349 (internal_procedure): Re-implement in terms of proc_open,
350 proc_read, proc_close.
351 (proc_open) New function.
352 (proc_read) New function.
353 (proc_close) New function.
354 (write_case) Moved into proc_read.
355 (close_active_file) Moved closing of data source into proc_close.
357 * storage-source.c: Rewrote to conform with modified
358 case_source_class interface.
360 * transformations.c (trns_chain_execute): Added argument to allow
361 starting execution from an arbitrary transformation. Updated
364 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
366 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
368 * sys-file-reader.c (read_display_parameters): Don't assume that
369 MEASURE_* and ALIGN_* have the same values found in system files.
371 * sys-file-writer.c (write_variable_display_parameters): Ditto.
373 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
374 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
375 the value of n_MEASURES, which was off by 1 (at least from my
378 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
380 * dictionary.c dictionary.h vardict.h variable.c: Added optional
381 callbacks which are invoked when the dictionary or its
382 variables are changed.
384 * missing-values.c missing-values.h value-labels.c: Tidied up
385 consistency checks, and made some of them return false
386 instead of assert-failing.
388 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
390 * calendar.c (calendar_days_in_month): New function.
392 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
394 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
395 the value label's width.
397 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
399 * sfm-private.h: Move contents into sys-file-writer.c, which is
400 the only remaining user. Removed Borland C++-specific directives.
402 * sys-file-reader.c: Clean up and rewrite entire file. The
403 rewritten version is simpler and better abstracted, and should be
404 easier to maintain and extend. It avoids using structures to read
405 file data, which is prone to padding variations among compilers.
406 It should also handle non-IEEE 754 system files, although I
407 haven't been able to find any. It has been tested against many
408 .sav files obtained from the Web and found to produce the same
409 results as the earlier version of the code, or in some cases
410 improved results. It is more tolerant of format variations found
413 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
414 member, putting an enum integer_format in its place. New member
415 `float_format'. Changed `compressed' member to type bool.
417 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
419 * dictionary.c (dict_delete_consecutive_vars): New function.
421 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
423 * file-name.c (fn_search_path): Remove prefix arg that was unused
424 by any caller. Updated all callers.
426 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
428 * format.c (fmt_dollar_template): Use user's decimal point
429 character. Add assertion.
431 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
433 * format.c (fmt_dollar_template): New function, based on
434 dollar_format_template from var-type-dialog.c.
436 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
438 * data-out.c (output_scientific): Fix bad assumption that "buf" is
441 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
443 Finish converting struct variable to an opaque type. In this
444 phase, we add remaining setter and getter functions, convert the
445 remaining PSPP code to use them, and do a bunch of cleanup. The
446 resulting changes are pervasive but mostly trivial, and only the
447 notable changes are logged.
449 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
452 * case.c (case_data): Renamed case_data_idx.
453 (case_num): Renamed case_num_idx.
454 (case_str): Renamed case_str_idx.
455 (case_data_rw): Renamed case_data_rw_idx.
457 * case.h (case_data): New function with old name and an interface
458 that takes a variable instead of an index, which is easier to
459 use. Updated all callers to use the new interface, or to use the
460 new *_idx function (see above).
463 (case_data_rw): Ditto.
465 * category.c (cat_stored_values_destroy): Changed interface to
466 take a struct cat_vals * instead of a struct variable *.
468 * dictionary.c (dict_clone): Use new vector_clone function.
469 (dict_clear) Use new var_destroy function.
470 (add_var) New function.
471 (dict_create_var) Rewrite in terms of dict_create_var_assert.
472 (dict_create_var_assert) Rewrite in terms of add_var.
473 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
474 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
475 (dict_lookup_var) Use new var_create, var_destroy functions.
476 (dict_contains_var) Rewrite in terms of new vardict functionality.
477 (set_var_dict_index) New function.
478 (set_var_case_index) New function.
479 (reindex_vars) New function.
480 (dict_delete_var) Rewrite in terms of new vardict functionality.
481 (dict_reorder_var) Ditto.
482 (dict_reorder_vars) Ditto.
483 (rename_var) New function.
484 (dict_rename_var) Use rename_var.
485 (dict_rename_vars) Use pool to simplify code. Use rename_var.
486 (dict_get_compacted_idx_to_fv) Rename
487 dict_get_compacted_dict_index_to_case_index, update callers.
488 (dict_create_vector) Use new vector_create function.
489 (dict_clear_vectors) Use new vector_destroy function.
490 (set_var_short_name_suffix) Move here from variable.c, renamed
491 from var_set_short_name_suffix, make static, update caller.
493 * sys-file-private.c: New file.
494 (sfm_width_to_bytes) Moved here from variable.c, renamed from
495 width_to_bytes, update callers.
497 * sys-file-private.h: New file. Later it will supplant
498 sfm-private.h; for now it supplements it.
499 (macro MIN_VERY_LONG_STRING) New macro.
500 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
502 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
503 MAX_LONG_STRING was used before.
505 * sys-file-writer.c: Ditto.
507 * value-labels.c: Change the paradigm here to be that a null
508 pointer is OK for a struct val_labs * in most cases; it just
509 represents an empty set of value labels.
510 (val_labs_copy) A copy of a null set is a null set.
511 (val_labs_count) A null set has 0 labels.
512 (val_labs_replace) Change return type to void. Rewrite for
514 (val_labs_find) A null set does not contain the value.
515 (value_to_string) Moved to variable.c, renamed var_get_value_name,
516 transposed argument order, updated all callers.
519 (value_dup) Moved here from variable.c.
520 (compare_values) Ditto.
523 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
524 (macro MAX_LONG_STRING) Removed, because it was only interesting
525 for system files, not for general code.
526 (macro MAX_VERY_LONG_STRING) Ditto.
527 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
528 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
530 * vardict.h: New file, for an interface between variables and
533 * variable.c: A lot of functions were moved around, for better
535 (struct variable) Move definition here, from variable.h.
536 (var_type_adj) Removed--makes i18n hard.
537 (var_type_noun) Ditto.
538 (var_create) New function.
539 (var_clone) New function.
540 (var_destroy) New function.
541 (var_set_name) Assert that variable is not in a dictionary.
542 (compare_var_names) Rename compare_vars_by_name and fix a couple
543 of callers who thought the args were strings.
544 (hash_var_name) Rename hash_var_by_name.
545 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
546 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
547 (var_is_very_long_string) Removed, because it was only interesting
549 (var_set_missing_values) Allow the argument to be the wrong width,
550 as long as we can resize it. Simplify callers who were doing the
552 (var_get_value_labels) New function.
553 (var_has_value_labels) New function.
554 (var_set_value_labels) New function.
555 (alloc_value_labels) New function.
556 (var_add_value_label) New function.
557 (var_replace_value_label) New function.
558 (var_clear_value_labels) New function.
559 (var_lookup_value_label) New function.
560 (var_get_value_name) Moved here from variable.c, renamed from
561 var_get_value_name, transposed argument order, updated all
563 (var_to_string) Moved here, from variable-label.c.
564 (var_set_leave) New function.
565 (var_get_leave) New function.
566 (var_must_leave) New function.
567 (var_set_short_name_suffix) Moved to dictionary.c, renamed
568 set_var_short_name_suffix.
569 (var_get_dict_index) New function.
570 (var_get_case_index) New function.
571 (var_get_obs_vals) New function.
572 (var_set_obs_vals) New function.
573 (var_has_obs_vals) New function.
574 (var_get_vardict) New function.
575 (var_set_vardict) New function.
576 (var_has_vardict) New function.
577 (var_clear_vardict) New function.
578 (value_dup) Moved to value.c.
579 (compare_values) Ditto.
582 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
583 (enum ALPHA) Rename VAR_STRING, update all users.
585 * vector.c: New file.
586 (struct vector) Moved here, from variable.h.
587 (check_widths) New function.
588 (vector_create) New function.
589 (vector_clone) New function.
590 (vector_destroy) New function.
591 (vector_get_name) New function.
592 (vector_get_var) New function.
593 (vector_get_var_cnt) New function.
594 (compare_vector_ptrs_by_name) New function.
596 * vector.h: New file.
598 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
600 * casefilter.c (casefilter_variable_missing): Avoided comparision of
601 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
604 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
606 * value-labels.c (destroy_atoms): New function.
607 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
609 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
611 Thanks to Jason Stover for pointing out this problem.
613 * data-out.c (output_number): Use gsl_finite from GSL, which is
614 portable, instead of isfinite, which is not.
617 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
619 * variable.c variable.h (value_dup): New function.
621 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
623 Start converting struct variable to an opaque type. In this
624 phase, we add a bunch of setter and getter functions and convert
625 most of the PSPP code to use them. The resulting changes are
626 pervasive but mostly trivial, and only the notable changes are
629 * format.c (fmt_equal): New function.
631 * variable.c (var_type_is_valid): New function.
632 (measure_is_valid) Moved here, from format.c.
633 (alignment_is_valid) Moved here, from format.c.
634 (var_get_name) New function.
635 (var_set_name) New function.
636 (width_to_type) New function.
637 (var_get_type) New function.
638 (var_get_width) New function.
639 (var_set_width) New function.
640 (var_is_numeric) New function.
641 (var_is_alpha) New function.
642 (var_is_short_string) New function.
643 (var_is_long_string) New function.
644 (var_is_very_long_string) New function.
645 (var_get_missing_values) New function.
646 (var_set_missing_values) New function.
647 (var_clear_missing_values) New function.
648 (var_has_missing_values) New function.
649 (var_is_value_missing) New function.
650 (var_is_num_missing) New function.
651 (var_is_str_missing) New function.
652 (var_is_value_user_missing) New function.
653 (var_is_num_user_missing) New function.
654 (var_is_str_user_missing) New function.
655 (var_is_value_system_missing) New function.
656 (var_get_print_format) New function.
657 (var_set_print_format) New function.
658 (var_get_write_format) New function.
659 (var_set_write_format) New function.
660 (var_set_both_formats) New function.
661 (var_get_label) New function.
662 (var_set_label) New function.
663 (var_clear_label) New function.
664 (var_has_label) New function.
665 (var_get_measure) New function.
666 (var_set_measure) New function.
667 (var_get_display_width) New function.
668 (var_set_display_width) New function.
669 (var_get_alignment) New function.
670 (var_set_alignment) New function.
671 (var_get_value_cnt) New function.
672 (var_get_leave) New function.
673 (var_get_short_name) New function.
675 * variable.h: (struct variable) Removed "type" and "nv" members;
676 they are now computed from "width" where needed.
678 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
680 * missing-values.c (mv_resize): Don't write beyond end of the
681 allocated buffer when resizing a long string.
683 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
685 Clean up identifier code: don't require identifier enumerations to
686 be in a particular order; make better use of string library;
687 expose less of the internals.
689 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
690 change interface. Updated all callers.
691 (lex_id_match) Change interface to use struct substring, update
693 (lex_id_match_len) Removed. Update callers to use lex_id_match.
694 (global array keywords[]) Make static, change form. Update all
695 users to use lex_id_name instead.
696 (lex_is_keyword) New function.
697 (lex_id_to_token) Change interface to use struct substring, update
699 (lex_id_name) New function.
701 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
702 lex_is_keyword instead.
703 (T_LAST_KEYWORD) Removed.
704 (T_N_KEYWORDS) Removed.
706 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
708 * format.c: (fmt_date_template) Distinguish characters for which a
709 space is output and any date delimiter is allowed on input, from
710 those for which a space is output and only a space is allowed on
711 input. The former is represented by X, the latter by a space.
712 Also, drop distinction between h and H, changing the former to the
715 * data-in.c: Completely rewrite internals to conform to SPSS input
716 formats as closely as possible.
717 (data_in) Changed external interface by replacing the structure
718 that was used as a single argument by a set of arguments. Updated
720 (data_in_finite_line) Removed. Converted all callers to use plain
722 (data_in_get_integer_format) New function.
723 (data_in_set_integer_format) New function.
724 (data_in_get_float_format) New function.
725 (data_in_set_float_format) New function.
727 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
728 (struct data_in) Removed.
730 * data-out.c: (output_date) Drop each component from the input as
731 it is output, to allow us to drop the distinction between h (a
732 count of hours) and H (the hour of day) template characters.
733 Also, handle new X template character.
734 (output_scientific) Follow more rational rule on when to drop
735 fraction introduced between SPSS 13 and 15. Updated test case to
738 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
740 Fix buffer overflow reported by John Darrington.
742 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
743 realize that DIGITS is a count of nibbles, not of bytes.
745 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
747 * calendar.c (calendar_offset_to_gregorian) Also return the
748 year-of-day. Change callers to new interface.
750 * data-out.c: Completely rewrite internals to conform to SPSS
751 output formats as completely as possible.
752 (data_out) Change interface to put input parameters before output
753 parameters, for consistency with the style I now prefer. Update
755 (data_out_get_integer_format) New public function.
756 (data_out_set_integer_format) New public function.
757 (data_out_get_float_format) New public function.
758 (data_out_set_float_format) New public function.
760 * data-out.h: New file. Move prototype for data_out here, from
763 * format.c: (fmt_step_width) Use equality comparison instead of
764 bitwise and, for clarity.
765 (fmt_is_string) Ditto.
766 (fmt_input_to_output) Fix categories that are translated to F
769 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
771 * casefilter.c casefilter.h (new files), casefile.c casefile.h
772 casefile-private.h: Added casefilter to assist commands with missing
775 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
777 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
779 * settings.c: (route_errors_to_terminal) New variable.
780 (route_errors_to_listing) New variable.
781 (get_error_routing_to_terminal) New function.
782 (set_error_routing_to_terminal) New function.
783 (get_error_routing_to_listing) New function.
784 (set_error_routing_to_listing) New function.
786 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
788 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
790 * format.c: Completely rewrite, to achieve better abstraction.
791 Rewrite all references to formats in other files.
793 * format.def: Rewrite and reorganize.
795 * settings.c: Move everything related to custom currency formats
796 into format.[ch], changing them in form, so as to group related
797 code and definitions better. Changed all references to use the
799 (static var decimal) Removed.
800 (static var grouping) Removed.
801 (static var cc) Removed.
802 (get_decimal) Removed.
803 (set_decimal) Removed.
804 (get_grouping) Removed.
805 (set_grouping) Removed.
809 * settings.h: (macro CC_CNT) Removed.
810 (macro CC_WIDTH) Removed.
811 (struct custom_currency) Removed.
813 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
815 * data-in.c (data_in): Use switch statement instead of table, to
816 avoid dependence on the order of the FMT_* enums.
818 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
820 * data-out.c: (num_to_string) Removed, because it was dead code.
822 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
824 * data-in.c (parse_trailer): Fix error message.
826 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
828 * format.c (fmt_is_binary): New function.
830 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
832 * procedure.c procedure.h: Encapsulated the static data into a single
835 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
837 * casefile.c (casereader_read_xfer): Always initialize the case,
838 even on an error condition.
840 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
842 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
843 entire function useless.
845 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
847 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
848 casereader method casereader_clone.
850 * procedure.c pransformations.h: Introduced new type casenum_t
852 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
854 * variable.c: (width_to_bytes) Rephrase code for clarify.
856 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
858 * format.c: (fmt_type_from_string) New function.
859 (fmt_to_string) Include decimals in output if the format has
860 decimals, even if the format type does not. This way, we can
861 accurately reproduce incorrect formats in user output.
862 (check_common_specifier) Make the check for a bad format type an
863 assertion, so we get bug reports if they show up. Fix message.
864 Check for decimal places with a format type that doesn't allow
866 (check_input_specifier) Remove check for FMT_X, which has been
868 (check_output_specifier) Ditto.
870 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
872 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
873 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
874 (enum fmt_parse_flags) Removed.
876 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
878 * casefile.c casefile.h: Converted to an abstract base class.
879 * casefile-private.h fastfile.c fastfile.h: New files.
880 * automake.mk procedure.c scratch-writer.c storage-stream.c
882 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
884 * procedure.c (internal_procedure): Create sink_case with only as
885 many values as the compacted dictionary.
887 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
889 Remove "debugging" code that caused plenty of false positives and
892 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
894 * case.c: Remove all references to `this' member.
896 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
898 Fix link error noted by Jason Stover.
900 * storage-stream.c: Include <assert.h>.
902 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
904 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
905 ALL) and additional underlying system file issues.
907 Thanks to John Darrington for review.
909 First problem: var_hash points to variables not owned by the
910 sys-file-reader, which the caller may free or modify. Use an
911 array of sfm_vars instead, as done earlier (e.g. CVS version
914 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
915 members and remove all code that references it. Add vars, var_cnt
916 members. Remove fix_specials member, which was unused.
917 (struct sfm_var) Remove name member, which was unused.
918 (sfm_close_reader) Free vars member instead of var_hash.
919 (compare_var_shortnames) Removed.
920 (hash_var_shortname) Removed.
921 (sfm_open_reader) Fill out vars array.
922 (compare_var_index) Removed.
923 (sfm_read_case) Use vars instead of var_hash.
925 Second problem: we're confused about when we actually have very
926 long strings, causing us to choose incorrectly between slow path
927 and fast path in sfm_read_case.
929 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
930 have very long strings, not when we have long variable names,
931 which is an unrelated feature.
933 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
935 * variable.h: Move var_set and variable parsing declarations to
936 new header, src/language/lexer/variable-parser.h. Modified lots
937 of files to include the new header.
939 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
941 * value-labels.c (value_to_string): When there's no value label,
942 format the variable according to its print format, instead of
943 always effectively using A or F format.
945 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
947 * casefile.c (casefile_get_random_reader): Nasty hack to get around
950 * format.c: Removed tortological assertion.
952 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
954 Reform string library.
956 * file-name.c (fn_interp_vars): Change interface to take a
957 substring as input. Updated all users.
959 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
961 * format.c (measure_is_valid): Really return false when m >=
964 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
966 Implement random access to casefiles, for use in GUI.
968 * casefile.c: (struct casereader) Add `random', `file_ofs',
969 `buffer_ofs' members.
970 (casefile_get_random_reader) New function.
971 (read_open_file) Break part into new function
972 seek_and_fill_buffer().
973 (fill_buffer) Update buffer_ofs, file_ofs.
974 (casereader_seek) New function.
976 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
978 * settings.c: Added call to i18n{done, init}.
980 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
982 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
985 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
987 * casefile.c: Convert many uses of `int' to `bool'.
989 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
991 * transformations.c (trns_chain_destroy): Destroy chain's trns
992 member, to fix memory leak.
994 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
996 * storage-stream.c (storage_source_decapsulate): Destroy case
997 source to fix memory leak.
999 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1001 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1002 case passed as argument instead of initializing the argument as a
1003 case. Fixes memory leak that showed up in
1004 tests/command/aggregate.sh with scratch files.
1006 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1008 * procedure.c (proc_done): Destroy default_dict, to fix memory
1011 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1013 Simplify procedure_with_splits().
1015 * procedure.c (struct split_aux_data): Removed case_count member.
1016 (procedure_with_splits) Don't initialize case_count.
1017 (split_procedure_case_func) Check whether prev_case is null
1018 instead of case_count.
1019 (split_procedure_end_func) Ditto.
1021 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1023 * case.c (case_move): Do nothing if dst and src are the same
1025 (case_try_create) Merge two similar cases.
1026 (case_copy) Unshare only if data must be actually copied.
1028 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1030 * data-in.c data-out.c dictionary.c sys-file-reader.c
1031 sys-file-writer.c variable.c variable.h: Reworked very long string
1032 support for better encapsulation.
1034 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1036 * value-labels.c (val_labs_can_set_width): New function.
1037 (val_labs_set_width) Clear labels if increasing width to long
1039 (val_labs_destroy) Remove unneeded test for null.
1041 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1043 * value-labels.h: Remove unneeded dependency on variable.h.
1045 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1047 Get rid of `char *c' member in union value, for cleanliness.
1049 * value.h: (union value) Remove `c' member.
1051 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1053 Make dictionary compacting functions a little more general.
1055 * sys-file-writer.c (sfm_open_writer): Use
1056 dict_compacting_would_change().
1057 (does_dict_need_translation) Removed.
1059 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1061 Make dictionary compacting functions a little more general.
1063 * dictionary.c (dict_needs_compaction): Rename
1064 dict_compacting_would_shrink(). Update all callers.
1065 (dict_compacting_would_change) New function.
1067 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1069 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1070 inverted return value (!).
1072 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1074 Continue reforming procedure execution.
1076 * procedure.c: Search and replace "vfm" by "proc". Notably:
1077 (static var vfm_source) Rename proc_source. Update all
1079 (static var vfm_sink) Rename proc_sink. Update all references.
1081 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1083 Continue reforming procedure execution. In this phase, remove
1084 PROCESS IF, which was deprecated anyway and can be easily
1085 simulated with TEMPORARY followed by SELECT IF.
1087 * procedure.c: (open_active_file) Don't call
1088 add_process_if_trns().
1089 (discard_variables) Get rid of redundant call to
1090 proc_cancel_all_transformations().
1091 (add_process_if_trns) Removed.
1092 (process_if_trns_proc) Removed.
1093 (process_if_trns_free) Removed.
1095 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1097 Continue reforming procedure execution. In this phase, add
1098 `const' to the case passed to procedure()'s callback.
1100 Updated all users of procedure() as well.
1102 * procedure.c: (struct write_case_data) Add "const" to ccase
1103 parameter for case_func member.
1104 (procedure) Add "const" to ccase parameter for proc_func
1106 (multipass_case_func) Make ccase parameter const.
1107 (internal_procedure) Add "const" to ccase parameter for case_func
1109 (split_procedure_case_func) Make ccase parameter const.
1110 (multipass_split_case_func) Make ccase parameter const.
1112 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1114 Continue reforming procedure execution. In this phase, get rid of
1115 the output code for SPLIT FILE groups in procedure.c, which really
1116 shouldn't be doing any output. Move it into the individual
1117 procedures instead. This also adds some flexibility.
1119 Updated many users of procedure_with_splits() and
1120 multipass_procedure_with_splits() to call
1121 output_split_file_values() and to deal with increased use of
1124 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1125 parameter to begin_func member.
1126 (procedure_with_splits) Add "const struct ccase *" parameter to
1127 begin_func parameter. Make ccase parameter const in proc_func
1129 (split_procedure_case_func) Don't dump split file group. Pass
1131 (dump_splits) Moved to language/dictionary/split-file.c as
1132 output_split_file_values().
1133 (struct multipass_split_aux_data) Add "const struct ccase *"
1134 parameter to split_func member.
1135 (multipass_procedure_with_splits) Add "const struct ccase *"
1136 parameter to split_func parameter.
1137 (multipass_split_case_func) Save new SPLIT FILE case before
1139 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1141 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1143 Continue reforming procedure execution. Change
1144 internal_procedure() so that it calls open_active_file() and
1145 close_active_file(), which isolates most of the actual procedure
1148 * procedure.c: (struct write_case_data) Rename `proc_func' member
1149 to `case_func' and update all references.
1150 (procedure) Rewrite as one-line wrapper around
1151 internal_procedure().
1152 (struct multipass_aux_data) New.
1153 (multipass_callback) Renamed multipass_case_func(). Use struct
1154 multipass_aux_data as auxiliary data.
1155 (multipass_end_func) New function.
1156 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1157 that uses multipass_case_func, multipass_end_func.
1158 (internal_procedure) Add `end_func' argument. Move optimization
1159 of trivial case in here. Move call to open_active_file() and
1160 close_active_file() in here. Now assert that vfm_source is
1162 (procedure_with_splits_callback) Rename
1163 split_procedure_case_func().
1164 (split_procedure_end_func) New function.
1165 (multipass_split_callback) Rename multipass_split_case_func.
1166 (multipass_split_end_func) New function.
1167 (discard_variables) No need to test for nonnull vfm_source.
1169 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1171 Continue reforming procedure execution. Get rid of unused member.
1173 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1175 (write_case) Don't increment cases_analyzed.
1177 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1179 Continue reforming procedure execution. In this phase, move
1180 procedure.c and procedure.h from src to src/data. Update
1181 makefiles and #includes accordingly.
1183 * procedure.c: Moved here from src/.
1185 * procedure.h: Moved here from src/.
1187 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1189 Continue reforming procedure execution. In this phase, get rid of
1190 many global variables, consolidating procedure execution in
1191 procedure.c. Encapsulate transformations in new "struct
1192 trns_chain". Also, change implementation of N OF CASES, FILTER,
1193 and PROCESS IF from special cases to transformations.
1195 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1198 * dictionary.c: (global variable default_dict) Move to
1201 * variable.h: (TRNS_*) Move to transformations.h.
1202 (struct transformation) Move to transformations.c.
1204 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1206 * sys-file-reader.c: Fixed invalid read problems.
1208 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1210 * storage-stream.c: Add missing function comments.
1212 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1214 Continue reforming procedure execution. In this phase, add some
1215 new, needed functionality to storage-stream.
1217 * storage-stream.c: (storage_source_decapsulate) New function.
1219 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1221 * variable.c (width_to_bytes): Declarations must precede
1222 statements for C90 compliance.
1224 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1226 * data-out.c, data-in.c, variable.c, variable.h: New functions
1227 copy_mangle and copy_demangle for reading/writing cases; emulates the
1228 way SPSS deals with strings > 255 bytes.
1230 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1231 subtype 14 needed for strings longer than 255 bytes.
1233 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1234 instead of literal values. Also fixed some constness issues.
1236 * format.h: Constness
1238 * sfm-private.h: Renamed the case_size identifier, since I discovered
1239 that SPSS's respect for this variable is very nominal.
1241 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1243 Change case limit type from int to size_t.
1245 * dictionary.c: (struct dictionary) Change type of case_limit
1247 (dict_get_case_limit) Change return type.
1248 (dict_set_case_limit) Change parameter type.
1250 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1252 * variable.h: (struct variable) Rename `reinit' member as `leave'
1253 and invert sense. Fix up all references.
1255 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1257 Continue reforming procedure execution. In this phase, break
1258 procedure.c into multiple files.
1260 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1262 * case-sink.c: New file.
1264 * case-sink.h: New file.
1266 * case-source.c: New file.
1268 * case-source.h: New file.
1270 * storage-stream.c: New file.
1272 * storage-stream.h: New file.
1274 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1276 * variable.h: (struct variable) Remove `init' member and all
1277 references to it from other files. It was initialized in several
1278 places, but nothing really ever used it for anything worthwhile.
1279 Thanks to Jason Stover for pointing out how confusing this
1282 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1284 Continue reforming error message support. In this phase, get rid
1285 of message "titles" and put the message text in `struct error'.
1286 Now `struct error' encapsulates a message more properly.
1288 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1289 Format message ourselves.
1291 * data-in.c: (vdls_error) Ditto.
1293 * por-file-reader.c: (error) Ditto.
1295 * sys-file-reader.c: (corrupt_msg) Ditto.
1297 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1299 GNU standards require "file name" instead of "filename" in
1300 documentation. It's nice for our code to follow the convention
1303 * casefile.c: (struct casefile) Rename `filename' member to
1304 `file_name'. Updated all references.
1306 * file-name.c: [!unix] (struct file_identity) Rename
1307 normalized_filename member to normalized_file_name. Updated all
1310 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1312 We don't really support anything but Unix-like environments well,
1313 so we might as well de-obfuscate by writing directory and path
1314 separators explicitly.
1316 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1318 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1319 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1321 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1324 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1326 GNU standards require "file name" instead of "filename" in
1327 documentation. It's nice for our code to follow the convention
1330 * filename.c: Rename to file-name.c.
1332 * filename.h: Rename to file-name.h. Update all inclusions.
1333 Update header guards.
1335 * automake.mk: Update file names.
1337 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1339 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1341 (fn_basename) Removed (dead code).
1342 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1343 (fn_special_p) Renamed fn_is_special(), all references updated.
1344 (fn_exists_p) Renamed fn_exists(), all references updated.
1346 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1348 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1349 Also, now it only tilde-expands file names, not paths.
1350 (fn_search_path) Tilde-expand one directory at a time.
1352 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1354 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1355 get rid of non-Unixlike version of the code, which has probably
1357 (fn_prepend_dir) Removed (dead code).
1359 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1360 (macro PATH_SEPARATOR_STRING) New.
1361 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1363 Continue reforming error message support. In this phase, we get
1364 rid of VM() and the other msg() support for "verbosity", replacing
1365 it by a new function verbose_msg().
1367 * filename.c: (fn_search_path) Use verbose_msg() instead of
1370 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1372 * sfm-private.h: Get rid of #defines after #error, which makes no
1375 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1377 Get rid of our own int32 type in favor of the standard int32_t
1380 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1383 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1385 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1387 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1389 Remove ill-considered file routines that are no longer used.
1391 * filename.c: (fn_open_ext) Removed.
1392 (fn_close_ext) Removed.
1394 * filename.h: (struct file_ext) Removed.
1396 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1398 * variable.c (var_is_valid_name): Move declarations before code
1401 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1403 * filename.ch (fn_interp_vars): Fixed small buglet.
1405 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1407 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1408 so as to modify the string inline. Thus makeing it easier to
1409 destroy the results when no longer needed.
1411 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1413 * category.c (cat_stored_values_destroy): Fixed memory leak.
1415 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1417 Add some missing frees. Thanks to John Darrington for reporting
1420 * any-writer.c (any_writer_close): Free writer.
1422 * any-reader.c (any_reader_close): Free reader.
1424 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1426 * por-file-reader.c: (error) Mark as NO_RETURN.
1428 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1430 * settings.c: Changed default value of scompress to true.
1432 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1434 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1436 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1439 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1440 here from pref.h.orig.
1442 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1444 * sys-file-reader.c: Fixed bug reading compressed files.
1446 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1448 * Numerous renames. See src/ChangeLog for details.
1450 * Moved files from src directory