1 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
3 * format.c (fmt_dollar_template): New function, based on
4 dollar_format_template from var-type-dialog.c.
6 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
8 * data-out.c (output_scientific): Fix bad assumption that "buf" is
11 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
13 Finish converting struct variable to an opaque type. In this
14 phase, we add remaining setter and getter functions, convert the
15 remaining PSPP code to use them, and do a bunch of cleanup. The
16 resulting changes are pervasive but mostly trivial, and only the
17 notable changes are logged.
19 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
22 * case.c (case_data): Renamed case_data_idx.
23 (case_num): Renamed case_num_idx.
24 (case_str): Renamed case_str_idx.
25 (case_data_rw): Renamed case_data_rw_idx.
27 * case.h (case_data): New function with old name and an interface
28 that takes a variable instead of an index, which is easier to
29 use. Updated all callers to use the new interface, or to use the
30 new *_idx function (see above).
33 (case_data_rw): Ditto.
35 * category.c (cat_stored_values_destroy): Changed interface to
36 take a struct cat_vals * instead of a struct variable *.
38 * dictionary.c (dict_clone): Use new vector_clone function.
39 (dict_clear) Use new var_destroy function.
40 (add_var) New function.
41 (dict_create_var) Rewrite in terms of dict_create_var_assert.
42 (dict_create_var_assert) Rewrite in terms of add_var.
43 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
44 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
45 (dict_lookup_var) Use new var_create, var_destroy functions.
46 (dict_contains_var) Rewrite in terms of new vardict functionality.
47 (set_var_dict_index) New function.
48 (set_var_case_index) New function.
49 (reindex_vars) New function.
50 (dict_delete_var) Rewrite in terms of new vardict functionality.
51 (dict_reorder_var) Ditto.
52 (dict_reorder_vars) Ditto.
53 (rename_var) New function.
54 (dict_rename_var) Use rename_var.
55 (dict_rename_vars) Use pool to simplify code. Use rename_var.
56 (dict_get_compacted_idx_to_fv) Rename
57 dict_get_compacted_dict_index_to_case_index, update callers.
58 (dict_create_vector) Use new vector_create function.
59 (dict_clear_vectors) Use new vector_destroy function.
60 (set_var_short_name_suffix) Move here from variable.c, renamed
61 from var_set_short_name_suffix, make static, update caller.
63 * sys-file-private.c: New file.
64 (sfm_width_to_bytes) Moved here from variable.c, renamed from
65 width_to_bytes, update callers.
67 * sys-file-private.h: New file. Later it will supplant
68 sfm-private.h; for now it supplements it.
69 (macro MIN_VERY_LONG_STRING) New macro.
70 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
72 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
73 MAX_LONG_STRING was used before.
75 * sys-file-writer.c: Ditto.
77 * value-labels.c: Change the paradigm here to be that a null
78 pointer is OK for a struct val_labs * in most cases; it just
79 represents an empty set of value labels.
80 (val_labs_copy) A copy of a null set is a null set.
81 (val_labs_count) A null set has 0 labels.
82 (val_labs_replace) Change return type to void. Rewrite for
84 (val_labs_find) A null set does not contain the value.
85 (value_to_string) Moved to variable.c, renamed var_get_value_name,
86 transposed argument order, updated all callers.
89 (value_dup) Moved here from variable.c.
90 (compare_values) Ditto.
93 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
94 (macro MAX_LONG_STRING) Removed, because it was only interesting
95 for system files, not for general code.
96 (macro MAX_VERY_LONG_STRING) Ditto.
97 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
98 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
100 * vardict.h: New file, for an interface between variables and
103 * variable.c: A lot of functions were moved around, for better
105 (struct variable) Move definition here, from variable.h.
106 (var_type_adj) Removed--makes i18n hard.
107 (var_type_noun) Ditto.
108 (var_create) New function.
109 (var_clone) New function.
110 (var_destroy) New function.
111 (var_set_name) Assert that variable is not in a dictionary.
112 (compare_var_names) Rename compare_vars_by_name and fix a couple
113 of callers who thought the args were strings.
114 (hash_var_name) Rename hash_var_by_name.
115 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
116 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
117 (var_is_very_long_string) Removed, because it was only interesting
119 (var_set_missing_values) Allow the argument to be the wrong width,
120 as long as we can resize it. Simplify callers who were doing the
122 (var_get_value_labels) New function.
123 (var_has_value_labels) New function.
124 (var_set_value_labels) New function.
125 (alloc_value_labels) New function.
126 (var_add_value_label) New function.
127 (var_replace_value_label) New function.
128 (var_clear_value_labels) New function.
129 (var_lookup_value_label) New function.
130 (var_get_value_name) Moved here from variable.c, renamed from
131 var_get_value_name, transposed argument order, updated all
133 (var_to_string) Moved here, from variable-label.c.
134 (var_set_leave) New function.
135 (var_get_leave) New function.
136 (var_must_leave) New function.
137 (var_set_short_name_suffix) Moved to dictionary.c, renamed
138 set_var_short_name_suffix.
139 (var_get_dict_index) New function.
140 (var_get_case_index) New function.
141 (var_get_obs_vals) New function.
142 (var_set_obs_vals) New function.
143 (var_has_obs_vals) New function.
144 (var_get_vardict) New function.
145 (var_set_vardict) New function.
146 (var_has_vardict) New function.
147 (var_clear_vardict) New function.
148 (value_dup) Moved to value.c.
149 (compare_values) Ditto.
152 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
153 (enum ALPHA) Rename VAR_STRING, update all users.
155 * vector.c: New file.
156 (struct vector) Moved here, from variable.h.
157 (check_widths) New function.
158 (vector_create) New function.
159 (vector_clone) New function.
160 (vector_destroy) New function.
161 (vector_get_name) New function.
162 (vector_get_var) New function.
163 (vector_get_var_cnt) New function.
164 (compare_vector_ptrs_by_name) New function.
166 * vector.h: New file.
168 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
170 * casefilter.c (casefilter_variable_missing): Avoided comparision of
171 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
174 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
176 * value-labels.c (destroy_atoms): New function.
177 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
179 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
181 Thanks to Jason Stover for pointing out this problem.
183 * data-out.c (output_number): Use gsl_finite from GSL, which is
184 portable, instead of isfinite, which is not.
187 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
189 * variable.c variable.h (value_dup): New function.
191 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
193 Start converting struct variable to an opaque type. In this
194 phase, we add a bunch of setter and getter functions and convert
195 most of the PSPP code to use them. The resulting changes are
196 pervasive but mostly trivial, and only the notable changes are
199 * format.c (fmt_equal): New function.
201 * variable.c (var_type_is_valid): New function.
202 (measure_is_valid) Moved here, from format.c.
203 (alignment_is_valid) Moved here, from format.c.
204 (var_get_name) New function.
205 (var_set_name) New function.
206 (width_to_type) New function.
207 (var_get_type) New function.
208 (var_get_width) New function.
209 (var_set_width) New function.
210 (var_is_numeric) New function.
211 (var_is_alpha) New function.
212 (var_is_short_string) New function.
213 (var_is_long_string) New function.
214 (var_is_very_long_string) New function.
215 (var_get_missing_values) New function.
216 (var_set_missing_values) New function.
217 (var_clear_missing_values) New function.
218 (var_has_missing_values) New function.
219 (var_is_value_missing) New function.
220 (var_is_num_missing) New function.
221 (var_is_str_missing) New function.
222 (var_is_value_user_missing) New function.
223 (var_is_num_user_missing) New function.
224 (var_is_str_user_missing) New function.
225 (var_is_value_system_missing) New function.
226 (var_get_print_format) New function.
227 (var_set_print_format) New function.
228 (var_get_write_format) New function.
229 (var_set_write_format) New function.
230 (var_set_both_formats) New function.
231 (var_get_label) New function.
232 (var_set_label) New function.
233 (var_clear_label) New function.
234 (var_has_label) New function.
235 (var_get_measure) New function.
236 (var_set_measure) New function.
237 (var_get_display_width) New function.
238 (var_set_display_width) New function.
239 (var_get_alignment) New function.
240 (var_set_alignment) New function.
241 (var_get_value_cnt) New function.
242 (var_get_leave) New function.
243 (var_get_short_name) New function.
245 * variable.h: (struct variable) Removed "type" and "nv" members;
246 they are now computed from "width" where needed.
248 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
250 * missing-values.c (mv_resize): Don't write beyond end of the
251 allocated buffer when resizing a long string.
253 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
255 Clean up identifier code: don't require identifier enumerations to
256 be in a particular order; make better use of string library;
257 expose less of the internals.
259 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
260 change interface. Updated all callers.
261 (lex_id_match) Change interface to use struct substring, update
263 (lex_id_match_len) Removed. Update callers to use lex_id_match.
264 (global array keywords[]) Make static, change form. Update all
265 users to use lex_id_name instead.
266 (lex_is_keyword) New function.
267 (lex_id_to_token) Change interface to use struct substring, update
269 (lex_id_name) New function.
271 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
272 lex_is_keyword instead.
273 (T_LAST_KEYWORD) Removed.
274 (T_N_KEYWORDS) Removed.
276 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
278 * format.c: (fmt_date_template) Distinguish characters for which a
279 space is output and any date delimiter is allowed on input, from
280 those for which a space is output and only a space is allowed on
281 input. The former is represented by X, the latter by a space.
282 Also, drop distinction between h and H, changing the former to the
285 * data-in.c: Completely rewrite internals to conform to SPSS input
286 formats as closely as possible.
287 (data_in) Changed external interface by replacing the structure
288 that was used as a single argument by a set of arguments. Updated
290 (data_in_finite_line) Removed. Converted all callers to use plain
292 (data_in_get_integer_format) New function.
293 (data_in_set_integer_format) New function.
294 (data_in_get_float_format) New function.
295 (data_in_set_float_format) New function.
297 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
298 (struct data_in) Removed.
300 * data-out.c: (output_date) Drop each component from the input as
301 it is output, to allow us to drop the distinction between h (a
302 count of hours) and H (the hour of day) template characters.
303 Also, handle new X template character.
304 (output_scientific) Follow more rational rule on when to drop
305 fraction introduced between SPSS 13 and 15. Updated test case to
308 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
310 Fix buffer overflow reported by John Darrington.
312 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
313 realize that DIGITS is a count of nibbles, not of bytes.
315 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
317 * calendar.c (calendar_offset_to_gregorian) Also return the
318 year-of-day. Change callers to new interface.
320 * data-out.c: Completely rewrite internals to conform to SPSS
321 output formats as completely as possible.
322 (data_out) Change interface to put input parameters before output
323 parameters, for consistency with the style I now prefer. Update
325 (data_out_get_integer_format) New public function.
326 (data_out_set_integer_format) New public function.
327 (data_out_get_float_format) New public function.
328 (data_out_set_float_format) New public function.
330 * data-out.h: New file. Move prototype for data_out here, from
333 * format.c: (fmt_step_width) Use equality comparison instead of
334 bitwise and, for clarity.
335 (fmt_is_string) Ditto.
336 (fmt_input_to_output) Fix categories that are translated to F
339 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
341 * casefilter.c casefilter.h (new files), casefile.c casefile.h
342 casefile-private.h: Added casefilter to assist commands with missing
345 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
347 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
349 * settings.c: (route_errors_to_terminal) New variable.
350 (route_errors_to_listing) New variable.
351 (get_error_routing_to_terminal) New function.
352 (set_error_routing_to_terminal) New function.
353 (get_error_routing_to_listing) New function.
354 (set_error_routing_to_listing) New function.
356 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
358 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
360 * format.c: Completely rewrite, to achieve better abstraction.
361 Rewrite all references to formats in other files.
363 * format.def: Rewrite and reorganize.
365 * settings.c: Move everything related to custom currency formats
366 into format.[ch], changing them in form, so as to group related
367 code and definitions better. Changed all references to use the
369 (static var decimal) Removed.
370 (static var grouping) Removed.
371 (static var cc) Removed.
372 (get_decimal) Removed.
373 (set_decimal) Removed.
374 (get_grouping) Removed.
375 (set_grouping) Removed.
379 * settings.h: (macro CC_CNT) Removed.
380 (macro CC_WIDTH) Removed.
381 (struct custom_currency) Removed.
383 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
385 * data-in.c (data_in): Use switch statement instead of table, to
386 avoid dependence on the order of the FMT_* enums.
388 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
390 * data-out.c: (num_to_string) Removed, because it was dead code.
392 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
394 * data-in.c (parse_trailer): Fix error message.
396 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
398 * format.c (fmt_is_binary): New function.
400 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
402 * procedure.c procedure.h: Encapsulated the static data into a single
405 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
407 * casefile.c (casereader_read_xfer): Always initialize the case,
408 even on an error condition.
410 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
412 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
413 entire function useless.
415 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
417 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
418 casereader method casereader_clone.
420 * procedure.c pransformations.h: Introduced new type casenum_t
422 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
424 * variable.c: (width_to_bytes) Rephrase code for clarify.
426 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
428 * format.c: (fmt_type_from_string) New function.
429 (fmt_to_string) Include decimals in output if the format has
430 decimals, even if the format type does not. This way, we can
431 accurately reproduce incorrect formats in user output.
432 (check_common_specifier) Make the check for a bad format type an
433 assertion, so we get bug reports if they show up. Fix message.
434 Check for decimal places with a format type that doesn't allow
436 (check_input_specifier) Remove check for FMT_X, which has been
438 (check_output_specifier) Ditto.
440 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
442 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
443 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
444 (enum fmt_parse_flags) Removed.
446 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
448 * casefile.c casefile.h: Converted to an abstract base class.
449 * casefile-private.h fastfile.c fastfile.h: New files.
450 * automake.mk procedure.c scratch-writer.c storage-stream.c
452 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
454 * procedure.c (internal_procedure): Create sink_case with only as
455 many values as the compacted dictionary.
457 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
459 Remove "debugging" code that caused plenty of false positives and
462 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
464 * case.c: Remove all references to `this' member.
466 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
468 Fix link error noted by Jason Stover.
470 * storage-stream.c: Include <assert.h>.
472 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
474 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
475 ALL) and additional underlying system file issues.
477 Thanks to John Darrington for review.
479 First problem: var_hash points to variables not owned by the
480 sys-file-reader, which the caller may free or modify. Use an
481 array of sfm_vars instead, as done earlier (e.g. CVS version
484 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
485 members and remove all code that references it. Add vars, var_cnt
486 members. Remove fix_specials member, which was unused.
487 (struct sfm_var) Remove name member, which was unused.
488 (sfm_close_reader) Free vars member instead of var_hash.
489 (compare_var_shortnames) Removed.
490 (hash_var_shortname) Removed.
491 (sfm_open_reader) Fill out vars array.
492 (compare_var_index) Removed.
493 (sfm_read_case) Use vars instead of var_hash.
495 Second problem: we're confused about when we actually have very
496 long strings, causing us to choose incorrectly between slow path
497 and fast path in sfm_read_case.
499 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
500 have very long strings, not when we have long variable names,
501 which is an unrelated feature.
503 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
505 * variable.h: Move var_set and variable parsing declarations to
506 new header, src/language/lexer/variable-parser.h. Modified lots
507 of files to include the new header.
509 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
511 * value-labels.c (value_to_string): When there's no value label,
512 format the variable according to its print format, instead of
513 always effectively using A or F format.
515 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
517 * casefile.c (casefile_get_random_reader): Nasty hack to get around
520 * format.c: Removed tortological assertion.
522 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
524 Reform string library.
526 * file-name.c (fn_interp_vars): Change interface to take a
527 substring as input. Updated all users.
529 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
531 * format.c (measure_is_valid): Really return false when m >=
534 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
536 Implement random access to casefiles, for use in GUI.
538 * casefile.c: (struct casereader) Add `random', `file_ofs',
539 `buffer_ofs' members.
540 (casefile_get_random_reader) New function.
541 (read_open_file) Break part into new function
542 seek_and_fill_buffer().
543 (fill_buffer) Update buffer_ofs, file_ofs.
544 (casereader_seek) New function.
546 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
548 * settings.c: Added call to i18n{done, init}.
550 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
552 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
555 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
557 * casefile.c: Convert many uses of `int' to `bool'.
559 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
561 * transformations.c (trns_chain_destroy): Destroy chain's trns
562 member, to fix memory leak.
564 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
566 * storage-stream.c (storage_source_decapsulate): Destroy case
567 source to fix memory leak.
569 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
571 * scratch-reader.c (scratch_reader_read_case): Copy into existing
572 case passed as argument instead of initializing the argument as a
573 case. Fixes memory leak that showed up in
574 tests/command/aggregate.sh with scratch files.
576 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
578 * procedure.c (proc_done): Destroy default_dict, to fix memory
581 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
583 Simplify procedure_with_splits().
585 * procedure.c (struct split_aux_data): Removed case_count member.
586 (procedure_with_splits) Don't initialize case_count.
587 (split_procedure_case_func) Check whether prev_case is null
588 instead of case_count.
589 (split_procedure_end_func) Ditto.
591 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
593 * case.c (case_move): Do nothing if dst and src are the same
595 (case_try_create) Merge two similar cases.
596 (case_copy) Unshare only if data must be actually copied.
598 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
600 * data-in.c data-out.c dictionary.c sys-file-reader.c
601 sys-file-writer.c variable.c variable.h: Reworked very long string
602 support for better encapsulation.
604 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
606 * value-labels.c (val_labs_can_set_width): New function.
607 (val_labs_set_width) Clear labels if increasing width to long
609 (val_labs_destroy) Remove unneeded test for null.
611 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
613 * value-labels.h: Remove unneeded dependency on variable.h.
615 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
617 Get rid of `char *c' member in union value, for cleanliness.
619 * value.h: (union value) Remove `c' member.
621 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
623 Make dictionary compacting functions a little more general.
625 * sys-file-writer.c (sfm_open_writer): Use
626 dict_compacting_would_change().
627 (does_dict_need_translation) Removed.
629 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
631 Make dictionary compacting functions a little more general.
633 * dictionary.c (dict_needs_compaction): Rename
634 dict_compacting_would_shrink(). Update all callers.
635 (dict_compacting_would_change) New function.
637 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
639 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
640 inverted return value (!).
642 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
644 Continue reforming procedure execution.
646 * procedure.c: Search and replace "vfm" by "proc". Notably:
647 (static var vfm_source) Rename proc_source. Update all
649 (static var vfm_sink) Rename proc_sink. Update all references.
651 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
653 Continue reforming procedure execution. In this phase, remove
654 PROCESS IF, which was deprecated anyway and can be easily
655 simulated with TEMPORARY followed by SELECT IF.
657 * procedure.c: (open_active_file) Don't call
658 add_process_if_trns().
659 (discard_variables) Get rid of redundant call to
660 proc_cancel_all_transformations().
661 (add_process_if_trns) Removed.
662 (process_if_trns_proc) Removed.
663 (process_if_trns_free) Removed.
665 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
667 Continue reforming procedure execution. In this phase, add
668 `const' to the case passed to procedure()'s callback.
670 Updated all users of procedure() as well.
672 * procedure.c: (struct write_case_data) Add "const" to ccase
673 parameter for case_func member.
674 (procedure) Add "const" to ccase parameter for proc_func
676 (multipass_case_func) Make ccase parameter const.
677 (internal_procedure) Add "const" to ccase parameter for case_func
679 (split_procedure_case_func) Make ccase parameter const.
680 (multipass_split_case_func) Make ccase parameter const.
682 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
684 Continue reforming procedure execution. In this phase, get rid of
685 the output code for SPLIT FILE groups in procedure.c, which really
686 shouldn't be doing any output. Move it into the individual
687 procedures instead. This also adds some flexibility.
689 Updated many users of procedure_with_splits() and
690 multipass_procedure_with_splits() to call
691 output_split_file_values() and to deal with increased use of
694 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
695 parameter to begin_func member.
696 (procedure_with_splits) Add "const struct ccase *" parameter to
697 begin_func parameter. Make ccase parameter const in proc_func
699 (split_procedure_case_func) Don't dump split file group. Pass
701 (dump_splits) Moved to language/dictionary/split-file.c as
702 output_split_file_values().
703 (struct multipass_split_aux_data) Add "const struct ccase *"
704 parameter to split_func member.
705 (multipass_procedure_with_splits) Add "const struct ccase *"
706 parameter to split_func parameter.
707 (multipass_split_case_func) Save new SPLIT FILE case before
709 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
711 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
713 Continue reforming procedure execution. Change
714 internal_procedure() so that it calls open_active_file() and
715 close_active_file(), which isolates most of the actual procedure
718 * procedure.c: (struct write_case_data) Rename `proc_func' member
719 to `case_func' and update all references.
720 (procedure) Rewrite as one-line wrapper around
721 internal_procedure().
722 (struct multipass_aux_data) New.
723 (multipass_callback) Renamed multipass_case_func(). Use struct
724 multipass_aux_data as auxiliary data.
725 (multipass_end_func) New function.
726 (multipass_procedure) Rewrite as wrapper for internal_procedure()
727 that uses multipass_case_func, multipass_end_func.
728 (internal_procedure) Add `end_func' argument. Move optimization
729 of trivial case in here. Move call to open_active_file() and
730 close_active_file() in here. Now assert that vfm_source is
732 (procedure_with_splits_callback) Rename
733 split_procedure_case_func().
734 (split_procedure_end_func) New function.
735 (multipass_split_callback) Rename multipass_split_case_func.
736 (multipass_split_end_func) New function.
737 (discard_variables) No need to test for nonnull vfm_source.
739 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
741 Continue reforming procedure execution. Get rid of unused member.
743 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
745 (write_case) Don't increment cases_analyzed.
747 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
749 Continue reforming procedure execution. In this phase, move
750 procedure.c and procedure.h from src to src/data. Update
751 makefiles and #includes accordingly.
753 * procedure.c: Moved here from src/.
755 * procedure.h: Moved here from src/.
757 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
759 Continue reforming procedure execution. In this phase, get rid of
760 many global variables, consolidating procedure execution in
761 procedure.c. Encapsulate transformations in new "struct
762 trns_chain". Also, change implementation of N OF CASES, FILTER,
763 and PROCESS IF from special cases to transformations.
765 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
768 * dictionary.c: (global variable default_dict) Move to
771 * variable.h: (TRNS_*) Move to transformations.h.
772 (struct transformation) Move to transformations.c.
774 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
776 * sys-file-reader.c: Fixed invalid read problems.
778 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
780 * storage-stream.c: Add missing function comments.
782 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
784 Continue reforming procedure execution. In this phase, add some
785 new, needed functionality to storage-stream.
787 * storage-stream.c: (storage_source_decapsulate) New function.
789 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
791 * variable.c (width_to_bytes): Declarations must precede
792 statements for C90 compliance.
794 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
796 * data-out.c, data-in.c, variable.c, variable.h: New functions
797 copy_mangle and copy_demangle for reading/writing cases; emulates the
798 way SPSS deals with strings > 255 bytes.
800 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
801 subtype 14 needed for strings longer than 255 bytes.
803 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
804 instead of literal values. Also fixed some constness issues.
806 * format.h: Constness
808 * sfm-private.h: Renamed the case_size identifier, since I discovered
809 that SPSS's respect for this variable is very nominal.
811 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
813 Change case limit type from int to size_t.
815 * dictionary.c: (struct dictionary) Change type of case_limit
817 (dict_get_case_limit) Change return type.
818 (dict_set_case_limit) Change parameter type.
820 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
822 * variable.h: (struct variable) Rename `reinit' member as `leave'
823 and invert sense. Fix up all references.
825 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
827 Continue reforming procedure execution. In this phase, break
828 procedure.c into multiple files.
830 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
832 * case-sink.c: New file.
834 * case-sink.h: New file.
836 * case-source.c: New file.
838 * case-source.h: New file.
840 * storage-stream.c: New file.
842 * storage-stream.h: New file.
844 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
846 * variable.h: (struct variable) Remove `init' member and all
847 references to it from other files. It was initialized in several
848 places, but nothing really ever used it for anything worthwhile.
849 Thanks to Jason Stover for pointing out how confusing this
852 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
854 Continue reforming error message support. In this phase, get rid
855 of message "titles" and put the message text in `struct error'.
856 Now `struct error' encapsulates a message more properly.
858 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
859 Format message ourselves.
861 * data-in.c: (vdls_error) Ditto.
863 * por-file-reader.c: (error) Ditto.
865 * sys-file-reader.c: (corrupt_msg) Ditto.
867 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
869 GNU standards require "file name" instead of "filename" in
870 documentation. It's nice for our code to follow the convention
873 * casefile.c: (struct casefile) Rename `filename' member to
874 `file_name'. Updated all references.
876 * file-name.c: [!unix] (struct file_identity) Rename
877 normalized_filename member to normalized_file_name. Updated all
880 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
882 We don't really support anything but Unix-like environments well,
883 so we might as well de-obfuscate by writing directory and path
884 separators explicitly.
886 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
888 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
889 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
891 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
894 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
896 GNU standards require "file name" instead of "filename" in
897 documentation. It's nice for our code to follow the convention
900 * filename.c: Rename to file-name.c.
902 * filename.h: Rename to file-name.h. Update all inclusions.
903 Update header guards.
905 * automake.mk: Update file names.
907 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
909 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
911 (fn_basename) Removed (dead code).
912 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
913 (fn_special_p) Renamed fn_is_special(), all references updated.
914 (fn_exists_p) Renamed fn_exists(), all references updated.
916 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
918 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
919 Also, now it only tilde-expands file names, not paths.
920 (fn_search_path) Tilde-expand one directory at a time.
922 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
924 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
925 get rid of non-Unixlike version of the code, which has probably
927 (fn_prepend_dir) Removed (dead code).
929 * filename.h: (macro DIR_SEPARATOR_STRING) New.
930 (macro PATH_SEPARATOR_STRING) New.
931 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
933 Continue reforming error message support. In this phase, we get
934 rid of VM() and the other msg() support for "verbosity", replacing
935 it by a new function verbose_msg().
937 * filename.c: (fn_search_path) Use verbose_msg() instead of
940 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
942 * sfm-private.h: Get rid of #defines after #error, which makes no
945 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
947 Get rid of our own int32 type in favor of the standard int32_t
950 * sfm-private.h: (int32 macro) Don't define this anymore. Do
953 * sys-file-reader.c: Use int32_t instead of int32 throughout.
955 * sys-file-writer.c: Use int32_t instead of int32 throughout.
957 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
959 Remove ill-considered file routines that are no longer used.
961 * filename.c: (fn_open_ext) Removed.
962 (fn_close_ext) Removed.
964 * filename.h: (struct file_ext) Removed.
966 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
968 * variable.c (var_is_valid_name): Move declarations before code
971 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
973 * filename.ch (fn_interp_vars): Fixed small buglet.
975 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
977 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
978 so as to modify the string inline. Thus makeing it easier to
979 destroy the results when no longer needed.
981 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
983 * category.c (cat_stored_values_destroy): Fixed memory leak.
985 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
987 Add some missing frees. Thanks to John Darrington for reporting
990 * any-writer.c (any_writer_close): Free writer.
992 * any-reader.c (any_reader_close): Free reader.
994 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
996 * por-file-reader.c: (error) Mark as NO_RETURN.
998 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1000 * settings.c: Changed default value of scompress to true.
1002 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1004 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1006 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1009 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1010 here from pref.h.orig.
1012 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1014 * sys-file-reader.c: Fixed bug reading compressed files.
1016 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1018 * Numerous renames. See src/ChangeLog for details.
1020 * Moved files from src directory