1 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
3 * data-in.c (parse_trailer): Fix error message.
5 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
7 * format.c (fmt_is_binary): New function.
9 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
11 * procedure.c procedure.h: Encapsulated the static data into a single
14 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
16 * casefile.c (casereader_read_xfer): Always initialize the case,
17 even on an error condition.
19 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
21 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
22 entire function useless.
24 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
26 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
27 casereader method casereader_clone.
29 * procedure.c pransformations.h: Introduced new type casenum_t
31 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
33 * variable.c: (width_to_bytes) Rephrase code for clarify.
35 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
37 * format.c: (fmt_type_from_string) New function.
38 (fmt_to_string) Include decimals in output if the format has
39 decimals, even if the format type does not. This way, we can
40 accurately reproduce incorrect formats in user output.
41 (check_common_specifier) Make the check for a bad format type an
42 assertion, so we get bug reports if they show up. Fix message.
43 Check for decimal places with a format type that doesn't allow
45 (check_input_specifier) Remove check for FMT_X, which has been
47 (check_output_specifier) Ditto.
49 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
51 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
52 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
53 (enum fmt_parse_flags) Removed.
55 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
57 * casefile.c casefile.h: Converted to an abstract base class.
58 * casefile-private.h fastfile.c fastfile.h: New files.
59 * automake.mk procedure.c scratch-writer.c storage-stream.c
61 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
63 * procedure.c (internal_procedure): Create sink_case with only as
64 many values as the compacted dictionary.
66 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
68 Remove "debugging" code that caused plenty of false positives and
71 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
73 * case.c: Remove all references to `this' member.
75 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
77 Fix link error noted by Jason Stover.
79 * storage-stream.c: Include <assert.h>.
81 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
83 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
84 ALL) and additional underlying system file issues.
86 Thanks to John Darrington for review.
88 First problem: var_hash points to variables not owned by the
89 sys-file-reader, which the caller may free or modify. Use an
90 array of sfm_vars instead, as done earlier (e.g. CVS version
93 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
94 members and remove all code that references it. Add vars, var_cnt
95 members. Remove fix_specials member, which was unused.
96 (struct sfm_var) Remove name member, which was unused.
97 (sfm_close_reader) Free vars member instead of var_hash.
98 (compare_var_shortnames) Removed.
99 (hash_var_shortname) Removed.
100 (sfm_open_reader) Fill out vars array.
101 (compare_var_index) Removed.
102 (sfm_read_case) Use vars instead of var_hash.
104 Second problem: we're confused about when we actually have very
105 long strings, causing us to choose incorrectly between slow path
106 and fast path in sfm_read_case.
108 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
109 have very long strings, not when we have long variable names,
110 which is an unrelated feature.
112 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
114 * variable.h: Move var_set and variable parsing declarations to
115 new header, src/language/lexer/variable-parser.h. Modified lots
116 of files to include the new header.
118 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
120 * value-labels.c (value_to_string): When there's no value label,
121 format the variable according to its print format, instead of
122 always effectively using A or F format.
124 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
126 * casefile.c (casefile_get_random_reader): Nasty hack to get around
129 * format.c: Removed tortological assertion.
131 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
133 Reform string library.
135 * file-name.c (fn_interp_vars): Change interface to take a
136 substring as input. Updated all users.
138 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
140 * format.c (measure_is_valid): Really return false when m >=
143 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
145 Implement random access to casefiles, for use in GUI.
147 * casefile.c: (struct casereader) Add `random', `file_ofs',
148 `buffer_ofs' members.
149 (casefile_get_random_reader) New function.
150 (read_open_file) Break part into new function
151 seek_and_fill_buffer().
152 (fill_buffer) Update buffer_ofs, file_ofs.
153 (casereader_seek) New function.
155 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
157 * settings.c: Added call to i18n{done, init}.
159 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
161 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
164 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
166 * casefile.c: Convert many uses of `int' to `bool'.
168 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
170 * transformations.c (trns_chain_destroy): Destroy chain's trns
171 member, to fix memory leak.
173 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
175 * storage-stream.c (storage_source_decapsulate): Destroy case
176 source to fix memory leak.
178 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
180 * scratch-reader.c (scratch_reader_read_case): Copy into existing
181 case passed as argument instead of initializing the argument as a
182 case. Fixes memory leak that showed up in
183 tests/command/aggregate.sh with scratch files.
185 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
187 * procedure.c (proc_done): Destroy default_dict, to fix memory
190 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
192 Simplify procedure_with_splits().
194 * procedure.c (struct split_aux_data): Removed case_count member.
195 (procedure_with_splits) Don't initialize case_count.
196 (split_procedure_case_func) Check whether prev_case is null
197 instead of case_count.
198 (split_procedure_end_func) Ditto.
200 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
202 * case.c (case_move): Do nothing if dst and src are the same
204 (case_try_create) Merge two similar cases.
205 (case_copy) Unshare only if data must be actually copied.
207 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
209 * data-in.c data-out.c dictionary.c sys-file-reader.c
210 sys-file-writer.c variable.c variable.h: Reworked very long string
211 support for better encapsulation.
213 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
215 * value-labels.c (val_labs_can_set_width): New function.
216 (val_labs_set_width) Clear labels if increasing width to long
218 (val_labs_destroy) Remove unneeded test for null.
220 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
222 * value-labels.h: Remove unneeded dependency on variable.h.
224 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
226 Get rid of `char *c' member in union value, for cleanliness.
228 * value.h: (union value) Remove `c' member.
230 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
232 Make dictionary compacting functions a little more general.
234 * sys-file-writer.c (sfm_open_writer): Use
235 dict_compacting_would_change().
236 (does_dict_need_translation) Removed.
238 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
240 Make dictionary compacting functions a little more general.
242 * dictionary.c (dict_needs_compaction): Rename
243 dict_compacting_would_shrink(). Update all callers.
244 (dict_compacting_would_change) New function.
246 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
248 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
249 inverted return value (!).
251 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
253 Continue reforming procedure execution.
255 * procedure.c: Search and replace "vfm" by "proc". Notably:
256 (static var vfm_source) Rename proc_source. Update all
258 (static var vfm_sink) Rename proc_sink. Update all references.
260 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
262 Continue reforming procedure execution. In this phase, remove
263 PROCESS IF, which was deprecated anyway and can be easily
264 simulated with TEMPORARY followed by SELECT IF.
266 * procedure.c: (open_active_file) Don't call
267 add_process_if_trns().
268 (discard_variables) Get rid of redundant call to
269 proc_cancel_all_transformations().
270 (add_process_if_trns) Removed.
271 (process_if_trns_proc) Removed.
272 (process_if_trns_free) Removed.
274 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
276 Continue reforming procedure execution. In this phase, add
277 `const' to the case passed to procedure()'s callback.
279 Updated all users of procedure() as well.
281 * procedure.c: (struct write_case_data) Add "const" to ccase
282 parameter for case_func member.
283 (procedure) Add "const" to ccase parameter for proc_func
285 (multipass_case_func) Make ccase parameter const.
286 (internal_procedure) Add "const" to ccase parameter for case_func
288 (split_procedure_case_func) Make ccase parameter const.
289 (multipass_split_case_func) Make ccase parameter const.
291 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
293 Continue reforming procedure execution. In this phase, get rid of
294 the output code for SPLIT FILE groups in procedure.c, which really
295 shouldn't be doing any output. Move it into the individual
296 procedures instead. This also adds some flexibility.
298 Updated many users of procedure_with_splits() and
299 multipass_procedure_with_splits() to call
300 output_split_file_values() and to deal with increased use of
303 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
304 parameter to begin_func member.
305 (procedure_with_splits) Add "const struct ccase *" parameter to
306 begin_func parameter. Make ccase parameter const in proc_func
308 (split_procedure_case_func) Don't dump split file group. Pass
310 (dump_splits) Moved to language/dictionary/split-file.c as
311 output_split_file_values().
312 (struct multipass_split_aux_data) Add "const struct ccase *"
313 parameter to split_func member.
314 (multipass_procedure_with_splits) Add "const struct ccase *"
315 parameter to split_func parameter.
316 (multipass_split_case_func) Save new SPLIT FILE case before
318 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
320 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
322 Continue reforming procedure execution. Change
323 internal_procedure() so that it calls open_active_file() and
324 close_active_file(), which isolates most of the actual procedure
327 * procedure.c: (struct write_case_data) Rename `proc_func' member
328 to `case_func' and update all references.
329 (procedure) Rewrite as one-line wrapper around
330 internal_procedure().
331 (struct multipass_aux_data) New.
332 (multipass_callback) Renamed multipass_case_func(). Use struct
333 multipass_aux_data as auxiliary data.
334 (multipass_end_func) New function.
335 (multipass_procedure) Rewrite as wrapper for internal_procedure()
336 that uses multipass_case_func, multipass_end_func.
337 (internal_procedure) Add `end_func' argument. Move optimization
338 of trivial case in here. Move call to open_active_file() and
339 close_active_file() in here. Now assert that vfm_source is
341 (procedure_with_splits_callback) Rename
342 split_procedure_case_func().
343 (split_procedure_end_func) New function.
344 (multipass_split_callback) Rename multipass_split_case_func.
345 (multipass_split_end_func) New function.
346 (discard_variables) No need to test for nonnull vfm_source.
348 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
350 Continue reforming procedure execution. Get rid of unused member.
352 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
354 (write_case) Don't increment cases_analyzed.
356 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
358 Continue reforming procedure execution. In this phase, move
359 procedure.c and procedure.h from src to src/data. Update
360 makefiles and #includes accordingly.
362 * procedure.c: Moved here from src/.
364 * procedure.h: Moved here from src/.
366 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
368 Continue reforming procedure execution. In this phase, get rid of
369 many global variables, consolidating procedure execution in
370 procedure.c. Encapsulate transformations in new "struct
371 trns_chain". Also, change implementation of N OF CASES, FILTER,
372 and PROCESS IF from special cases to transformations.
374 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
377 * dictionary.c: (global variable default_dict) Move to
380 * variable.h: (TRNS_*) Move to transformations.h.
381 (struct transformation) Move to transformations.c.
383 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
385 * sys-file-reader.c: Fixed invalid read problems.
387 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
389 * storage-stream.c: Add missing function comments.
391 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
393 Continue reforming procedure execution. In this phase, add some
394 new, needed functionality to storage-stream.
396 * storage-stream.c: (storage_source_decapsulate) New function.
398 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
400 * variable.c (width_to_bytes): Declarations must precede
401 statements for C90 compliance.
403 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
405 * data-out.c, data-in.c, variable.c, variable.h: New functions
406 copy_mangle and copy_demangle for reading/writing cases; emulates the
407 way SPSS deals with strings > 255 bytes.
409 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
410 subtype 14 needed for strings longer than 255 bytes.
412 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
413 instead of literal values. Also fixed some constness issues.
415 * format.h: Constness
417 * sfm-private.h: Renamed the case_size identifier, since I discovered
418 that SPSS's respect for this variable is very nominal.
420 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
422 Change case limit type from int to size_t.
424 * dictionary.c: (struct dictionary) Change type of case_limit
426 (dict_get_case_limit) Change return type.
427 (dict_set_case_limit) Change parameter type.
429 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
431 * variable.h: (struct variable) Rename `reinit' member as `leave'
432 and invert sense. Fix up all references.
434 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
436 Continue reforming procedure execution. In this phase, break
437 procedure.c into multiple files.
439 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
441 * case-sink.c: New file.
443 * case-sink.h: New file.
445 * case-source.c: New file.
447 * case-source.h: New file.
449 * storage-stream.c: New file.
451 * storage-stream.h: New file.
453 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
455 * variable.h: (struct variable) Remove `init' member and all
456 references to it from other files. It was initialized in several
457 places, but nothing really ever used it for anything worthwhile.
458 Thanks to Jason Stover for pointing out how confusing this
461 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
463 Continue reforming error message support. In this phase, get rid
464 of message "titles" and put the message text in `struct error'.
465 Now `struct error' encapsulates a message more properly.
467 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
468 Format message ourselves.
470 * data-in.c: (vdls_error) Ditto.
472 * por-file-reader.c: (error) Ditto.
474 * sys-file-reader.c: (corrupt_msg) Ditto.
476 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
478 GNU standards require "file name" instead of "filename" in
479 documentation. It's nice for our code to follow the convention
482 * casefile.c: (struct casefile) Rename `filename' member to
483 `file_name'. Updated all references.
485 * file-name.c: [!unix] (struct file_identity) Rename
486 normalized_filename member to normalized_file_name. Updated all
489 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
491 We don't really support anything but Unix-like environments well,
492 so we might as well de-obfuscate by writing directory and path
493 separators explicitly.
495 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
497 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
498 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
500 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
503 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
505 GNU standards require "file name" instead of "filename" in
506 documentation. It's nice for our code to follow the convention
509 * filename.c: Rename to file-name.c.
511 * filename.h: Rename to file-name.h. Update all inclusions.
512 Update header guards.
514 * automake.mk: Update file names.
516 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
518 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
520 (fn_basename) Removed (dead code).
521 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
522 (fn_special_p) Renamed fn_is_special(), all references updated.
523 (fn_exists_p) Renamed fn_exists(), all references updated.
525 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
527 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
528 Also, now it only tilde-expands file names, not paths.
529 (fn_search_path) Tilde-expand one directory at a time.
531 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
533 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
534 get rid of non-Unixlike version of the code, which has probably
536 (fn_prepend_dir) Removed (dead code).
538 * filename.h: (macro DIR_SEPARATOR_STRING) New.
539 (macro PATH_SEPARATOR_STRING) New.
540 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
542 Continue reforming error message support. In this phase, we get
543 rid of VM() and the other msg() support for "verbosity", replacing
544 it by a new function verbose_msg().
546 * filename.c: (fn_search_path) Use verbose_msg() instead of
549 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
551 * sfm-private.h: Get rid of #defines after #error, which makes no
554 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
556 Get rid of our own int32 type in favor of the standard int32_t
559 * sfm-private.h: (int32 macro) Don't define this anymore. Do
562 * sys-file-reader.c: Use int32_t instead of int32 throughout.
564 * sys-file-writer.c: Use int32_t instead of int32 throughout.
566 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
568 Remove ill-considered file routines that are no longer used.
570 * filename.c: (fn_open_ext) Removed.
571 (fn_close_ext) Removed.
573 * filename.h: (struct file_ext) Removed.
575 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
577 * variable.c (var_is_valid_name): Move declarations before code
580 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
582 * filename.ch (fn_interp_vars): Fixed small buglet.
584 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
586 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
587 so as to modify the string inline. Thus makeing it easier to
588 destroy the results when no longer needed.
590 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
592 * category.c (cat_stored_values_destroy): Fixed memory leak.
594 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
596 Add some missing frees. Thanks to John Darrington for reporting
599 * any-writer.c (any_writer_close): Free writer.
601 * any-reader.c (any_reader_close): Free reader.
603 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
605 * por-file-reader.c: (error) Mark as NO_RETURN.
607 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
609 * settings.c: Changed default value of scompress to true.
611 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
613 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
615 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
618 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
619 here from pref.h.orig.
621 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
623 * sys-file-reader.c: Fixed bug reading compressed files.
625 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
627 * Numerous renames. See src/ChangeLog for details.
629 * Moved files from src directory