1 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
3 * casefile.c (casereader_read_xfer): Always initialize the case,
4 even on an error condition.
6 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
8 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
9 entire function useless.
11 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
13 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
14 casereader method casereader_clone.
16 * procedure.c pransformations.h: Introduced new type casenum_t
18 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
20 * variable.c: (width_to_bytes) Rephrase code for clarify.
22 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
24 * format.c: (fmt_type_from_string) New function.
25 (fmt_to_string) Include decimals in output if the format has
26 decimals, even if the format type does not. This way, we can
27 accurately reproduce incorrect formats in user output.
28 (check_common_specifier) Make the check for a bad format type an
29 assertion, so we get bug reports if they show up. Fix message.
30 Check for decimal places with a format type that doesn't allow
32 (check_input_specifier) Remove check for FMT_X, which has been
34 (check_output_specifier) Ditto.
36 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
38 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
39 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
40 (enum fmt_parse_flags) Removed.
42 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
44 * casefile.c casefile.h: Converted to an abstract base class.
45 * casefile-private.h fastfile.c fastfile.h: New files.
46 * automake.mk procedure.c scratch-writer.c storage-stream.c
48 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
50 * procedure.c (internal_procedure): Create sink_case with only as
51 many values as the compacted dictionary.
53 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
55 Remove "debugging" code that caused plenty of false positives and
58 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
60 * case.c: Remove all references to `this' member.
62 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
64 Fix link error noted by Jason Stover.
66 * storage-stream.c: Include <assert.h>.
68 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
70 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
71 ALL) and additional underlying system file issues.
73 Thanks to John Darrington for review.
75 First problem: var_hash points to variables not owned by the
76 sys-file-reader, which the caller may free or modify. Use an
77 array of sfm_vars instead, as done earlier (e.g. CVS version
80 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
81 members and remove all code that references it. Add vars, var_cnt
82 members. Remove fix_specials member, which was unused.
83 (struct sfm_var) Remove name member, which was unused.
84 (sfm_close_reader) Free vars member instead of var_hash.
85 (compare_var_shortnames) Removed.
86 (hash_var_shortname) Removed.
87 (sfm_open_reader) Fill out vars array.
88 (compare_var_index) Removed.
89 (sfm_read_case) Use vars instead of var_hash.
91 Second problem: we're confused about when we actually have very
92 long strings, causing us to choose incorrectly between slow path
93 and fast path in sfm_read_case.
95 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
96 have very long strings, not when we have long variable names,
97 which is an unrelated feature.
99 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
101 * variable.h: Move var_set and variable parsing declarations to
102 new header, src/language/lexer/variable-parser.h. Modified lots
103 of files to include the new header.
105 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
107 * value-labels.c (value_to_string): When there's no value label,
108 format the variable according to its print format, instead of
109 always effectively using A or F format.
111 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
113 * casefile.c (casefile_get_random_reader): Nasty hack to get around
116 * format.c: Removed tortological assertion.
118 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
120 Reform string library.
122 * file-name.c (fn_interp_vars): Change interface to take a
123 substring as input. Updated all users.
125 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
127 * format.c (measure_is_valid): Really return false when m >=
130 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
132 Implement random access to casefiles, for use in GUI.
134 * casefile.c: (struct casereader) Add `random', `file_ofs',
135 `buffer_ofs' members.
136 (casefile_get_random_reader) New function.
137 (read_open_file) Break part into new function
138 seek_and_fill_buffer().
139 (fill_buffer) Update buffer_ofs, file_ofs.
140 (casereader_seek) New function.
142 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
144 * settings.c: Added call to i18n{done, init}.
146 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
148 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
151 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
153 * casefile.c: Convert many uses of `int' to `bool'.
155 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
157 * transformations.c (trns_chain_destroy): Destroy chain's trns
158 member, to fix memory leak.
160 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
162 * storage-stream.c (storage_source_decapsulate): Destroy case
163 source to fix memory leak.
165 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
167 * scratch-reader.c (scratch_reader_read_case): Copy into existing
168 case passed as argument instead of initializing the argument as a
169 case. Fixes memory leak that showed up in
170 tests/command/aggregate.sh with scratch files.
172 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
174 * procedure.c (proc_done): Destroy default_dict, to fix memory
177 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
179 Simplify procedure_with_splits().
181 * procedure.c (struct split_aux_data): Removed case_count member.
182 (procedure_with_splits) Don't initialize case_count.
183 (split_procedure_case_func) Check whether prev_case is null
184 instead of case_count.
185 (split_procedure_end_func) Ditto.
187 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
189 * case.c (case_move): Do nothing if dst and src are the same
191 (case_try_create) Merge two similar cases.
192 (case_copy) Unshare only if data must be actually copied.
194 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
196 * data-in.c data-out.c dictionary.c sys-file-reader.c
197 sys-file-writer.c variable.c variable.h: Reworked very long string
198 support for better encapsulation.
200 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
202 * value-labels.c (val_labs_can_set_width): New function.
203 (val_labs_set_width) Clear labels if increasing width to long
205 (val_labs_destroy) Remove unneeded test for null.
207 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
209 * value-labels.h: Remove unneeded dependency on variable.h.
211 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
213 Get rid of `char *c' member in union value, for cleanliness.
215 * value.h: (union value) Remove `c' member.
217 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
219 Make dictionary compacting functions a little more general.
221 * sys-file-writer.c (sfm_open_writer): Use
222 dict_compacting_would_change().
223 (does_dict_need_translation) Removed.
225 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
227 Make dictionary compacting functions a little more general.
229 * dictionary.c (dict_needs_compaction): Rename
230 dict_compacting_would_shrink(). Update all callers.
231 (dict_compacting_would_change) New function.
233 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
235 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
236 inverted return value (!).
238 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
240 Continue reforming procedure execution.
242 * procedure.c: Search and replace "vfm" by "proc". Notably:
243 (static var vfm_source) Rename proc_source. Update all
245 (static var vfm_sink) Rename proc_sink. Update all references.
247 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
249 Continue reforming procedure execution. In this phase, remove
250 PROCESS IF, which was deprecated anyway and can be easily
251 simulated with TEMPORARY followed by SELECT IF.
253 * procedure.c: (open_active_file) Don't call
254 add_process_if_trns().
255 (discard_variables) Get rid of redundant call to
256 proc_cancel_all_transformations().
257 (add_process_if_trns) Removed.
258 (process_if_trns_proc) Removed.
259 (process_if_trns_free) Removed.
261 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
263 Continue reforming procedure execution. In this phase, add
264 `const' to the case passed to procedure()'s callback.
266 Updated all users of procedure() as well.
268 * procedure.c: (struct write_case_data) Add "const" to ccase
269 parameter for case_func member.
270 (procedure) Add "const" to ccase parameter for proc_func
272 (multipass_case_func) Make ccase parameter const.
273 (internal_procedure) Add "const" to ccase parameter for case_func
275 (split_procedure_case_func) Make ccase parameter const.
276 (multipass_split_case_func) Make ccase parameter const.
278 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
280 Continue reforming procedure execution. In this phase, get rid of
281 the output code for SPLIT FILE groups in procedure.c, which really
282 shouldn't be doing any output. Move it into the individual
283 procedures instead. This also adds some flexibility.
285 Updated many users of procedure_with_splits() and
286 multipass_procedure_with_splits() to call
287 output_split_file_values() and to deal with increased use of
290 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
291 parameter to begin_func member.
292 (procedure_with_splits) Add "const struct ccase *" parameter to
293 begin_func parameter. Make ccase parameter const in proc_func
295 (split_procedure_case_func) Don't dump split file group. Pass
297 (dump_splits) Moved to language/dictionary/split-file.c as
298 output_split_file_values().
299 (struct multipass_split_aux_data) Add "const struct ccase *"
300 parameter to split_func member.
301 (multipass_procedure_with_splits) Add "const struct ccase *"
302 parameter to split_func parameter.
303 (multipass_split_case_func) Save new SPLIT FILE case before
305 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
307 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
309 Continue reforming procedure execution. Change
310 internal_procedure() so that it calls open_active_file() and
311 close_active_file(), which isolates most of the actual procedure
314 * procedure.c: (struct write_case_data) Rename `proc_func' member
315 to `case_func' and update all references.
316 (procedure) Rewrite as one-line wrapper around
317 internal_procedure().
318 (struct multipass_aux_data) New.
319 (multipass_callback) Renamed multipass_case_func(). Use struct
320 multipass_aux_data as auxiliary data.
321 (multipass_end_func) New function.
322 (multipass_procedure) Rewrite as wrapper for internal_procedure()
323 that uses multipass_case_func, multipass_end_func.
324 (internal_procedure) Add `end_func' argument. Move optimization
325 of trivial case in here. Move call to open_active_file() and
326 close_active_file() in here. Now assert that vfm_source is
328 (procedure_with_splits_callback) Rename
329 split_procedure_case_func().
330 (split_procedure_end_func) New function.
331 (multipass_split_callback) Rename multipass_split_case_func.
332 (multipass_split_end_func) New function.
333 (discard_variables) No need to test for nonnull vfm_source.
335 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
337 Continue reforming procedure execution. Get rid of unused member.
339 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
341 (write_case) Don't increment cases_analyzed.
343 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
345 Continue reforming procedure execution. In this phase, move
346 procedure.c and procedure.h from src to src/data. Update
347 makefiles and #includes accordingly.
349 * procedure.c: Moved here from src/.
351 * procedure.h: Moved here from src/.
353 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
355 Continue reforming procedure execution. In this phase, get rid of
356 many global variables, consolidating procedure execution in
357 procedure.c. Encapsulate transformations in new "struct
358 trns_chain". Also, change implementation of N OF CASES, FILTER,
359 and PROCESS IF from special cases to transformations.
361 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
364 * dictionary.c: (global variable default_dict) Move to
367 * variable.h: (TRNS_*) Move to transformations.h.
368 (struct transformation) Move to transformations.c.
370 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
372 * sys-file-reader.c: Fixed invalid read problems.
374 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
376 * storage-stream.c: Add missing function comments.
378 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
380 Continue reforming procedure execution. In this phase, add some
381 new, needed functionality to storage-stream.
383 * storage-stream.c: (storage_source_decapsulate) New function.
385 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
387 * variable.c (width_to_bytes): Declarations must precede
388 statements for C90 compliance.
390 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
392 * data-out.c, data-in.c, variable.c, variable.h: New functions
393 copy_mangle and copy_demangle for reading/writing cases; emulates the
394 way SPSS deals with strings > 255 bytes.
396 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
397 subtype 14 needed for strings longer than 255 bytes.
399 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
400 instead of literal values. Also fixed some constness issues.
402 * format.h: Constness
404 * sfm-private.h: Renamed the case_size identifier, since I discovered
405 that SPSS's respect for this variable is very nominal.
407 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
409 Change case limit type from int to size_t.
411 * dictionary.c: (struct dictionary) Change type of case_limit
413 (dict_get_case_limit) Change return type.
414 (dict_set_case_limit) Change parameter type.
416 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
418 * variable.h: (struct variable) Rename `reinit' member as `leave'
419 and invert sense. Fix up all references.
421 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
423 Continue reforming procedure execution. In this phase, break
424 procedure.c into multiple files.
426 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
428 * case-sink.c: New file.
430 * case-sink.h: New file.
432 * case-source.c: New file.
434 * case-source.h: New file.
436 * storage-stream.c: New file.
438 * storage-stream.h: New file.
440 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
442 * variable.h: (struct variable) Remove `init' member and all
443 references to it from other files. It was initialized in several
444 places, but nothing really ever used it for anything worthwhile.
445 Thanks to Jason Stover for pointing out how confusing this
448 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
450 Continue reforming error message support. In this phase, get rid
451 of message "titles" and put the message text in `struct error'.
452 Now `struct error' encapsulates a message more properly.
454 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
455 Format message ourselves.
457 * data-in.c: (vdls_error) Ditto.
459 * por-file-reader.c: (error) Ditto.
461 * sys-file-reader.c: (corrupt_msg) Ditto.
463 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
465 GNU standards require "file name" instead of "filename" in
466 documentation. It's nice for our code to follow the convention
469 * casefile.c: (struct casefile) Rename `filename' member to
470 `file_name'. Updated all references.
472 * file-name.c: [!unix] (struct file_identity) Rename
473 normalized_filename member to normalized_file_name. Updated all
476 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
478 We don't really support anything but Unix-like environments well,
479 so we might as well de-obfuscate by writing directory and path
480 separators explicitly.
482 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
484 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
485 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
487 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
490 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
492 GNU standards require "file name" instead of "filename" in
493 documentation. It's nice for our code to follow the convention
496 * filename.c: Rename to file-name.c.
498 * filename.h: Rename to file-name.h. Update all inclusions.
499 Update header guards.
501 * automake.mk: Update file names.
503 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
505 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
507 (fn_basename) Removed (dead code).
508 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
509 (fn_special_p) Renamed fn_is_special(), all references updated.
510 (fn_exists_p) Renamed fn_exists(), all references updated.
512 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
514 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
515 Also, now it only tilde-expands file names, not paths.
516 (fn_search_path) Tilde-expand one directory at a time.
518 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
520 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
521 get rid of non-Unixlike version of the code, which has probably
523 (fn_prepend_dir) Removed (dead code).
525 * filename.h: (macro DIR_SEPARATOR_STRING) New.
526 (macro PATH_SEPARATOR_STRING) New.
527 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
529 Continue reforming error message support. In this phase, we get
530 rid of VM() and the other msg() support for "verbosity", replacing
531 it by a new function verbose_msg().
533 * filename.c: (fn_search_path) Use verbose_msg() instead of
536 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
538 * sfm-private.h: Get rid of #defines after #error, which makes no
541 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
543 Get rid of our own int32 type in favor of the standard int32_t
546 * sfm-private.h: (int32 macro) Don't define this anymore. Do
549 * sys-file-reader.c: Use int32_t instead of int32 throughout.
551 * sys-file-writer.c: Use int32_t instead of int32 throughout.
553 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
555 Remove ill-considered file routines that are no longer used.
557 * filename.c: (fn_open_ext) Removed.
558 (fn_close_ext) Removed.
560 * filename.h: (struct file_ext) Removed.
562 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
564 * variable.c (var_is_valid_name): Move declarations before code
567 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
569 * filename.ch (fn_interp_vars): Fixed small buglet.
571 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
573 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
574 so as to modify the string inline. Thus makeing it easier to
575 destroy the results when no longer needed.
577 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
579 * category.c (cat_stored_values_destroy): Fixed memory leak.
581 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
583 Add some missing frees. Thanks to John Darrington for reporting
586 * any-writer.c (any_writer_close): Free writer.
588 * any-reader.c (any_reader_close): Free reader.
590 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
592 * por-file-reader.c: (error) Mark as NO_RETURN.
594 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
596 * settings.c: Changed default value of scompress to true.
598 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
600 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
602 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
605 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
606 here from pref.h.orig.
608 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
610 * sys-file-reader.c: Fixed bug reading compressed files.
612 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
614 * Numerous renames. See src/ChangeLog for details.
616 * Moved files from src directory