1 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
3 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
4 the value label's width.
6 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
8 * sfm-private.h: Move contents into sys-file-writer.c, which is
9 the only remaining user. Removed Borland C++-specific directives.
11 * sys-file-reader.c: Clean up and rewrite entire file. The
12 rewritten version is simpler and better abstracted, and should be
13 easier to maintain and extend. It avoids using structures to read
14 file data, which is prone to padding variations among compilers.
15 It should also handle non-IEEE 754 system files, although I
16 haven't been able to find any. It has been tested against many
17 .sav files obtained from the Web and found to produce the same
18 results as the earlier version of the code, or in some cases
19 improved results. It is more tolerant of format variations found
22 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
23 member, putting an enum integer_format in its place. New member
24 `float_format'. Changed `compressed' member to type bool.
26 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
28 * dictionary.c (dict_delete_consecutive_vars): New function.
30 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
32 * file-name.c (fn_search_path): Remove prefix arg that was unused
33 by any caller. Updated all callers.
35 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
37 * format.c (fmt_dollar_template): Use user's decimal point
38 character. Add assertion.
40 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
42 * format.c (fmt_dollar_template): New function, based on
43 dollar_format_template from var-type-dialog.c.
45 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
47 * data-out.c (output_scientific): Fix bad assumption that "buf" is
50 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
52 Finish converting struct variable to an opaque type. In this
53 phase, we add remaining setter and getter functions, convert the
54 remaining PSPP code to use them, and do a bunch of cleanup. The
55 resulting changes are pervasive but mostly trivial, and only the
56 notable changes are logged.
58 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
61 * case.c (case_data): Renamed case_data_idx.
62 (case_num): Renamed case_num_idx.
63 (case_str): Renamed case_str_idx.
64 (case_data_rw): Renamed case_data_rw_idx.
66 * case.h (case_data): New function with old name and an interface
67 that takes a variable instead of an index, which is easier to
68 use. Updated all callers to use the new interface, or to use the
69 new *_idx function (see above).
72 (case_data_rw): Ditto.
74 * category.c (cat_stored_values_destroy): Changed interface to
75 take a struct cat_vals * instead of a struct variable *.
77 * dictionary.c (dict_clone): Use new vector_clone function.
78 (dict_clear) Use new var_destroy function.
79 (add_var) New function.
80 (dict_create_var) Rewrite in terms of dict_create_var_assert.
81 (dict_create_var_assert) Rewrite in terms of add_var.
82 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
83 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
84 (dict_lookup_var) Use new var_create, var_destroy functions.
85 (dict_contains_var) Rewrite in terms of new vardict functionality.
86 (set_var_dict_index) New function.
87 (set_var_case_index) New function.
88 (reindex_vars) New function.
89 (dict_delete_var) Rewrite in terms of new vardict functionality.
90 (dict_reorder_var) Ditto.
91 (dict_reorder_vars) Ditto.
92 (rename_var) New function.
93 (dict_rename_var) Use rename_var.
94 (dict_rename_vars) Use pool to simplify code. Use rename_var.
95 (dict_get_compacted_idx_to_fv) Rename
96 dict_get_compacted_dict_index_to_case_index, update callers.
97 (dict_create_vector) Use new vector_create function.
98 (dict_clear_vectors) Use new vector_destroy function.
99 (set_var_short_name_suffix) Move here from variable.c, renamed
100 from var_set_short_name_suffix, make static, update caller.
102 * sys-file-private.c: New file.
103 (sfm_width_to_bytes) Moved here from variable.c, renamed from
104 width_to_bytes, update callers.
106 * sys-file-private.h: New file. Later it will supplant
107 sfm-private.h; for now it supplements it.
108 (macro MIN_VERY_LONG_STRING) New macro.
109 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
111 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
112 MAX_LONG_STRING was used before.
114 * sys-file-writer.c: Ditto.
116 * value-labels.c: Change the paradigm here to be that a null
117 pointer is OK for a struct val_labs * in most cases; it just
118 represents an empty set of value labels.
119 (val_labs_copy) A copy of a null set is a null set.
120 (val_labs_count) A null set has 0 labels.
121 (val_labs_replace) Change return type to void. Rewrite for
123 (val_labs_find) A null set does not contain the value.
124 (value_to_string) Moved to variable.c, renamed var_get_value_name,
125 transposed argument order, updated all callers.
128 (value_dup) Moved here from variable.c.
129 (compare_values) Ditto.
132 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
133 (macro MAX_LONG_STRING) Removed, because it was only interesting
134 for system files, not for general code.
135 (macro MAX_VERY_LONG_STRING) Ditto.
136 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
137 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
139 * vardict.h: New file, for an interface between variables and
142 * variable.c: A lot of functions were moved around, for better
144 (struct variable) Move definition here, from variable.h.
145 (var_type_adj) Removed--makes i18n hard.
146 (var_type_noun) Ditto.
147 (var_create) New function.
148 (var_clone) New function.
149 (var_destroy) New function.
150 (var_set_name) Assert that variable is not in a dictionary.
151 (compare_var_names) Rename compare_vars_by_name and fix a couple
152 of callers who thought the args were strings.
153 (hash_var_name) Rename hash_var_by_name.
154 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
155 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
156 (var_is_very_long_string) Removed, because it was only interesting
158 (var_set_missing_values) Allow the argument to be the wrong width,
159 as long as we can resize it. Simplify callers who were doing the
161 (var_get_value_labels) New function.
162 (var_has_value_labels) New function.
163 (var_set_value_labels) New function.
164 (alloc_value_labels) New function.
165 (var_add_value_label) New function.
166 (var_replace_value_label) New function.
167 (var_clear_value_labels) New function.
168 (var_lookup_value_label) New function.
169 (var_get_value_name) Moved here from variable.c, renamed from
170 var_get_value_name, transposed argument order, updated all
172 (var_to_string) Moved here, from variable-label.c.
173 (var_set_leave) New function.
174 (var_get_leave) New function.
175 (var_must_leave) New function.
176 (var_set_short_name_suffix) Moved to dictionary.c, renamed
177 set_var_short_name_suffix.
178 (var_get_dict_index) New function.
179 (var_get_case_index) New function.
180 (var_get_obs_vals) New function.
181 (var_set_obs_vals) New function.
182 (var_has_obs_vals) New function.
183 (var_get_vardict) New function.
184 (var_set_vardict) New function.
185 (var_has_vardict) New function.
186 (var_clear_vardict) New function.
187 (value_dup) Moved to value.c.
188 (compare_values) Ditto.
191 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
192 (enum ALPHA) Rename VAR_STRING, update all users.
194 * vector.c: New file.
195 (struct vector) Moved here, from variable.h.
196 (check_widths) New function.
197 (vector_create) New function.
198 (vector_clone) New function.
199 (vector_destroy) New function.
200 (vector_get_name) New function.
201 (vector_get_var) New function.
202 (vector_get_var_cnt) New function.
203 (compare_vector_ptrs_by_name) New function.
205 * vector.h: New file.
207 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
209 * casefilter.c (casefilter_variable_missing): Avoided comparision of
210 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
213 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
215 * value-labels.c (destroy_atoms): New function.
216 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
218 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
220 Thanks to Jason Stover for pointing out this problem.
222 * data-out.c (output_number): Use gsl_finite from GSL, which is
223 portable, instead of isfinite, which is not.
226 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
228 * variable.c variable.h (value_dup): New function.
230 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
232 Start converting struct variable to an opaque type. In this
233 phase, we add a bunch of setter and getter functions and convert
234 most of the PSPP code to use them. The resulting changes are
235 pervasive but mostly trivial, and only the notable changes are
238 * format.c (fmt_equal): New function.
240 * variable.c (var_type_is_valid): New function.
241 (measure_is_valid) Moved here, from format.c.
242 (alignment_is_valid) Moved here, from format.c.
243 (var_get_name) New function.
244 (var_set_name) New function.
245 (width_to_type) New function.
246 (var_get_type) New function.
247 (var_get_width) New function.
248 (var_set_width) New function.
249 (var_is_numeric) New function.
250 (var_is_alpha) New function.
251 (var_is_short_string) New function.
252 (var_is_long_string) New function.
253 (var_is_very_long_string) New function.
254 (var_get_missing_values) New function.
255 (var_set_missing_values) New function.
256 (var_clear_missing_values) New function.
257 (var_has_missing_values) New function.
258 (var_is_value_missing) New function.
259 (var_is_num_missing) New function.
260 (var_is_str_missing) New function.
261 (var_is_value_user_missing) New function.
262 (var_is_num_user_missing) New function.
263 (var_is_str_user_missing) New function.
264 (var_is_value_system_missing) New function.
265 (var_get_print_format) New function.
266 (var_set_print_format) New function.
267 (var_get_write_format) New function.
268 (var_set_write_format) New function.
269 (var_set_both_formats) New function.
270 (var_get_label) New function.
271 (var_set_label) New function.
272 (var_clear_label) New function.
273 (var_has_label) New function.
274 (var_get_measure) New function.
275 (var_set_measure) New function.
276 (var_get_display_width) New function.
277 (var_set_display_width) New function.
278 (var_get_alignment) New function.
279 (var_set_alignment) New function.
280 (var_get_value_cnt) New function.
281 (var_get_leave) New function.
282 (var_get_short_name) New function.
284 * variable.h: (struct variable) Removed "type" and "nv" members;
285 they are now computed from "width" where needed.
287 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
289 * missing-values.c (mv_resize): Don't write beyond end of the
290 allocated buffer when resizing a long string.
292 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
294 Clean up identifier code: don't require identifier enumerations to
295 be in a particular order; make better use of string library;
296 expose less of the internals.
298 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
299 change interface. Updated all callers.
300 (lex_id_match) Change interface to use struct substring, update
302 (lex_id_match_len) Removed. Update callers to use lex_id_match.
303 (global array keywords[]) Make static, change form. Update all
304 users to use lex_id_name instead.
305 (lex_is_keyword) New function.
306 (lex_id_to_token) Change interface to use struct substring, update
308 (lex_id_name) New function.
310 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
311 lex_is_keyword instead.
312 (T_LAST_KEYWORD) Removed.
313 (T_N_KEYWORDS) Removed.
315 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
317 * format.c: (fmt_date_template) Distinguish characters for which a
318 space is output and any date delimiter is allowed on input, from
319 those for which a space is output and only a space is allowed on
320 input. The former is represented by X, the latter by a space.
321 Also, drop distinction between h and H, changing the former to the
324 * data-in.c: Completely rewrite internals to conform to SPSS input
325 formats as closely as possible.
326 (data_in) Changed external interface by replacing the structure
327 that was used as a single argument by a set of arguments. Updated
329 (data_in_finite_line) Removed. Converted all callers to use plain
331 (data_in_get_integer_format) New function.
332 (data_in_set_integer_format) New function.
333 (data_in_get_float_format) New function.
334 (data_in_set_float_format) New function.
336 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
337 (struct data_in) Removed.
339 * data-out.c: (output_date) Drop each component from the input as
340 it is output, to allow us to drop the distinction between h (a
341 count of hours) and H (the hour of day) template characters.
342 Also, handle new X template character.
343 (output_scientific) Follow more rational rule on when to drop
344 fraction introduced between SPSS 13 and 15. Updated test case to
347 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
349 Fix buffer overflow reported by John Darrington.
351 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
352 realize that DIGITS is a count of nibbles, not of bytes.
354 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
356 * calendar.c (calendar_offset_to_gregorian) Also return the
357 year-of-day. Change callers to new interface.
359 * data-out.c: Completely rewrite internals to conform to SPSS
360 output formats as completely as possible.
361 (data_out) Change interface to put input parameters before output
362 parameters, for consistency with the style I now prefer. Update
364 (data_out_get_integer_format) New public function.
365 (data_out_set_integer_format) New public function.
366 (data_out_get_float_format) New public function.
367 (data_out_set_float_format) New public function.
369 * data-out.h: New file. Move prototype for data_out here, from
372 * format.c: (fmt_step_width) Use equality comparison instead of
373 bitwise and, for clarity.
374 (fmt_is_string) Ditto.
375 (fmt_input_to_output) Fix categories that are translated to F
378 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
380 * casefilter.c casefilter.h (new files), casefile.c casefile.h
381 casefile-private.h: Added casefilter to assist commands with missing
384 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
386 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
388 * settings.c: (route_errors_to_terminal) New variable.
389 (route_errors_to_listing) New variable.
390 (get_error_routing_to_terminal) New function.
391 (set_error_routing_to_terminal) New function.
392 (get_error_routing_to_listing) New function.
393 (set_error_routing_to_listing) New function.
395 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
397 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
399 * format.c: Completely rewrite, to achieve better abstraction.
400 Rewrite all references to formats in other files.
402 * format.def: Rewrite and reorganize.
404 * settings.c: Move everything related to custom currency formats
405 into format.[ch], changing them in form, so as to group related
406 code and definitions better. Changed all references to use the
408 (static var decimal) Removed.
409 (static var grouping) Removed.
410 (static var cc) Removed.
411 (get_decimal) Removed.
412 (set_decimal) Removed.
413 (get_grouping) Removed.
414 (set_grouping) Removed.
418 * settings.h: (macro CC_CNT) Removed.
419 (macro CC_WIDTH) Removed.
420 (struct custom_currency) Removed.
422 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
424 * data-in.c (data_in): Use switch statement instead of table, to
425 avoid dependence on the order of the FMT_* enums.
427 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
429 * data-out.c: (num_to_string) Removed, because it was dead code.
431 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
433 * data-in.c (parse_trailer): Fix error message.
435 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
437 * format.c (fmt_is_binary): New function.
439 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
441 * procedure.c procedure.h: Encapsulated the static data into a single
444 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
446 * casefile.c (casereader_read_xfer): Always initialize the case,
447 even on an error condition.
449 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
451 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
452 entire function useless.
454 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
456 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
457 casereader method casereader_clone.
459 * procedure.c pransformations.h: Introduced new type casenum_t
461 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
463 * variable.c: (width_to_bytes) Rephrase code for clarify.
465 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
467 * format.c: (fmt_type_from_string) New function.
468 (fmt_to_string) Include decimals in output if the format has
469 decimals, even if the format type does not. This way, we can
470 accurately reproduce incorrect formats in user output.
471 (check_common_specifier) Make the check for a bad format type an
472 assertion, so we get bug reports if they show up. Fix message.
473 Check for decimal places with a format type that doesn't allow
475 (check_input_specifier) Remove check for FMT_X, which has been
477 (check_output_specifier) Ditto.
479 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
481 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
482 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
483 (enum fmt_parse_flags) Removed.
485 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
487 * casefile.c casefile.h: Converted to an abstract base class.
488 * casefile-private.h fastfile.c fastfile.h: New files.
489 * automake.mk procedure.c scratch-writer.c storage-stream.c
491 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
493 * procedure.c (internal_procedure): Create sink_case with only as
494 many values as the compacted dictionary.
496 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
498 Remove "debugging" code that caused plenty of false positives and
501 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
503 * case.c: Remove all references to `this' member.
505 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
507 Fix link error noted by Jason Stover.
509 * storage-stream.c: Include <assert.h>.
511 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
513 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
514 ALL) and additional underlying system file issues.
516 Thanks to John Darrington for review.
518 First problem: var_hash points to variables not owned by the
519 sys-file-reader, which the caller may free or modify. Use an
520 array of sfm_vars instead, as done earlier (e.g. CVS version
523 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
524 members and remove all code that references it. Add vars, var_cnt
525 members. Remove fix_specials member, which was unused.
526 (struct sfm_var) Remove name member, which was unused.
527 (sfm_close_reader) Free vars member instead of var_hash.
528 (compare_var_shortnames) Removed.
529 (hash_var_shortname) Removed.
530 (sfm_open_reader) Fill out vars array.
531 (compare_var_index) Removed.
532 (sfm_read_case) Use vars instead of var_hash.
534 Second problem: we're confused about when we actually have very
535 long strings, causing us to choose incorrectly between slow path
536 and fast path in sfm_read_case.
538 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
539 have very long strings, not when we have long variable names,
540 which is an unrelated feature.
542 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
544 * variable.h: Move var_set and variable parsing declarations to
545 new header, src/language/lexer/variable-parser.h. Modified lots
546 of files to include the new header.
548 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
550 * value-labels.c (value_to_string): When there's no value label,
551 format the variable according to its print format, instead of
552 always effectively using A or F format.
554 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
556 * casefile.c (casefile_get_random_reader): Nasty hack to get around
559 * format.c: Removed tortological assertion.
561 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
563 Reform string library.
565 * file-name.c (fn_interp_vars): Change interface to take a
566 substring as input. Updated all users.
568 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
570 * format.c (measure_is_valid): Really return false when m >=
573 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
575 Implement random access to casefiles, for use in GUI.
577 * casefile.c: (struct casereader) Add `random', `file_ofs',
578 `buffer_ofs' members.
579 (casefile_get_random_reader) New function.
580 (read_open_file) Break part into new function
581 seek_and_fill_buffer().
582 (fill_buffer) Update buffer_ofs, file_ofs.
583 (casereader_seek) New function.
585 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
587 * settings.c: Added call to i18n{done, init}.
589 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
591 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
594 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
596 * casefile.c: Convert many uses of `int' to `bool'.
598 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
600 * transformations.c (trns_chain_destroy): Destroy chain's trns
601 member, to fix memory leak.
603 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
605 * storage-stream.c (storage_source_decapsulate): Destroy case
606 source to fix memory leak.
608 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
610 * scratch-reader.c (scratch_reader_read_case): Copy into existing
611 case passed as argument instead of initializing the argument as a
612 case. Fixes memory leak that showed up in
613 tests/command/aggregate.sh with scratch files.
615 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
617 * procedure.c (proc_done): Destroy default_dict, to fix memory
620 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
622 Simplify procedure_with_splits().
624 * procedure.c (struct split_aux_data): Removed case_count member.
625 (procedure_with_splits) Don't initialize case_count.
626 (split_procedure_case_func) Check whether prev_case is null
627 instead of case_count.
628 (split_procedure_end_func) Ditto.
630 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
632 * case.c (case_move): Do nothing if dst and src are the same
634 (case_try_create) Merge two similar cases.
635 (case_copy) Unshare only if data must be actually copied.
637 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
639 * data-in.c data-out.c dictionary.c sys-file-reader.c
640 sys-file-writer.c variable.c variable.h: Reworked very long string
641 support for better encapsulation.
643 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
645 * value-labels.c (val_labs_can_set_width): New function.
646 (val_labs_set_width) Clear labels if increasing width to long
648 (val_labs_destroy) Remove unneeded test for null.
650 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
652 * value-labels.h: Remove unneeded dependency on variable.h.
654 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
656 Get rid of `char *c' member in union value, for cleanliness.
658 * value.h: (union value) Remove `c' member.
660 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
662 Make dictionary compacting functions a little more general.
664 * sys-file-writer.c (sfm_open_writer): Use
665 dict_compacting_would_change().
666 (does_dict_need_translation) Removed.
668 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
670 Make dictionary compacting functions a little more general.
672 * dictionary.c (dict_needs_compaction): Rename
673 dict_compacting_would_shrink(). Update all callers.
674 (dict_compacting_would_change) New function.
676 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
678 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
679 inverted return value (!).
681 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
683 Continue reforming procedure execution.
685 * procedure.c: Search and replace "vfm" by "proc". Notably:
686 (static var vfm_source) Rename proc_source. Update all
688 (static var vfm_sink) Rename proc_sink. Update all references.
690 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
692 Continue reforming procedure execution. In this phase, remove
693 PROCESS IF, which was deprecated anyway and can be easily
694 simulated with TEMPORARY followed by SELECT IF.
696 * procedure.c: (open_active_file) Don't call
697 add_process_if_trns().
698 (discard_variables) Get rid of redundant call to
699 proc_cancel_all_transformations().
700 (add_process_if_trns) Removed.
701 (process_if_trns_proc) Removed.
702 (process_if_trns_free) Removed.
704 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
706 Continue reforming procedure execution. In this phase, add
707 `const' to the case passed to procedure()'s callback.
709 Updated all users of procedure() as well.
711 * procedure.c: (struct write_case_data) Add "const" to ccase
712 parameter for case_func member.
713 (procedure) Add "const" to ccase parameter for proc_func
715 (multipass_case_func) Make ccase parameter const.
716 (internal_procedure) Add "const" to ccase parameter for case_func
718 (split_procedure_case_func) Make ccase parameter const.
719 (multipass_split_case_func) Make ccase parameter const.
721 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
723 Continue reforming procedure execution. In this phase, get rid of
724 the output code for SPLIT FILE groups in procedure.c, which really
725 shouldn't be doing any output. Move it into the individual
726 procedures instead. This also adds some flexibility.
728 Updated many users of procedure_with_splits() and
729 multipass_procedure_with_splits() to call
730 output_split_file_values() and to deal with increased use of
733 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
734 parameter to begin_func member.
735 (procedure_with_splits) Add "const struct ccase *" parameter to
736 begin_func parameter. Make ccase parameter const in proc_func
738 (split_procedure_case_func) Don't dump split file group. Pass
740 (dump_splits) Moved to language/dictionary/split-file.c as
741 output_split_file_values().
742 (struct multipass_split_aux_data) Add "const struct ccase *"
743 parameter to split_func member.
744 (multipass_procedure_with_splits) Add "const struct ccase *"
745 parameter to split_func parameter.
746 (multipass_split_case_func) Save new SPLIT FILE case before
748 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
750 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
752 Continue reforming procedure execution. Change
753 internal_procedure() so that it calls open_active_file() and
754 close_active_file(), which isolates most of the actual procedure
757 * procedure.c: (struct write_case_data) Rename `proc_func' member
758 to `case_func' and update all references.
759 (procedure) Rewrite as one-line wrapper around
760 internal_procedure().
761 (struct multipass_aux_data) New.
762 (multipass_callback) Renamed multipass_case_func(). Use struct
763 multipass_aux_data as auxiliary data.
764 (multipass_end_func) New function.
765 (multipass_procedure) Rewrite as wrapper for internal_procedure()
766 that uses multipass_case_func, multipass_end_func.
767 (internal_procedure) Add `end_func' argument. Move optimization
768 of trivial case in here. Move call to open_active_file() and
769 close_active_file() in here. Now assert that vfm_source is
771 (procedure_with_splits_callback) Rename
772 split_procedure_case_func().
773 (split_procedure_end_func) New function.
774 (multipass_split_callback) Rename multipass_split_case_func.
775 (multipass_split_end_func) New function.
776 (discard_variables) No need to test for nonnull vfm_source.
778 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
780 Continue reforming procedure execution. Get rid of unused member.
782 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
784 (write_case) Don't increment cases_analyzed.
786 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
788 Continue reforming procedure execution. In this phase, move
789 procedure.c and procedure.h from src to src/data. Update
790 makefiles and #includes accordingly.
792 * procedure.c: Moved here from src/.
794 * procedure.h: Moved here from src/.
796 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
798 Continue reforming procedure execution. In this phase, get rid of
799 many global variables, consolidating procedure execution in
800 procedure.c. Encapsulate transformations in new "struct
801 trns_chain". Also, change implementation of N OF CASES, FILTER,
802 and PROCESS IF from special cases to transformations.
804 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
807 * dictionary.c: (global variable default_dict) Move to
810 * variable.h: (TRNS_*) Move to transformations.h.
811 (struct transformation) Move to transformations.c.
813 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
815 * sys-file-reader.c: Fixed invalid read problems.
817 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
819 * storage-stream.c: Add missing function comments.
821 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
823 Continue reforming procedure execution. In this phase, add some
824 new, needed functionality to storage-stream.
826 * storage-stream.c: (storage_source_decapsulate) New function.
828 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
830 * variable.c (width_to_bytes): Declarations must precede
831 statements for C90 compliance.
833 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
835 * data-out.c, data-in.c, variable.c, variable.h: New functions
836 copy_mangle and copy_demangle for reading/writing cases; emulates the
837 way SPSS deals with strings > 255 bytes.
839 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
840 subtype 14 needed for strings longer than 255 bytes.
842 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
843 instead of literal values. Also fixed some constness issues.
845 * format.h: Constness
847 * sfm-private.h: Renamed the case_size identifier, since I discovered
848 that SPSS's respect for this variable is very nominal.
850 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
852 Change case limit type from int to size_t.
854 * dictionary.c: (struct dictionary) Change type of case_limit
856 (dict_get_case_limit) Change return type.
857 (dict_set_case_limit) Change parameter type.
859 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
861 * variable.h: (struct variable) Rename `reinit' member as `leave'
862 and invert sense. Fix up all references.
864 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
866 Continue reforming procedure execution. In this phase, break
867 procedure.c into multiple files.
869 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
871 * case-sink.c: New file.
873 * case-sink.h: New file.
875 * case-source.c: New file.
877 * case-source.h: New file.
879 * storage-stream.c: New file.
881 * storage-stream.h: New file.
883 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
885 * variable.h: (struct variable) Remove `init' member and all
886 references to it from other files. It was initialized in several
887 places, but nothing really ever used it for anything worthwhile.
888 Thanks to Jason Stover for pointing out how confusing this
891 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
893 Continue reforming error message support. In this phase, get rid
894 of message "titles" and put the message text in `struct error'.
895 Now `struct error' encapsulates a message more properly.
897 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
898 Format message ourselves.
900 * data-in.c: (vdls_error) Ditto.
902 * por-file-reader.c: (error) Ditto.
904 * sys-file-reader.c: (corrupt_msg) Ditto.
906 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
908 GNU standards require "file name" instead of "filename" in
909 documentation. It's nice for our code to follow the convention
912 * casefile.c: (struct casefile) Rename `filename' member to
913 `file_name'. Updated all references.
915 * file-name.c: [!unix] (struct file_identity) Rename
916 normalized_filename member to normalized_file_name. Updated all
919 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
921 We don't really support anything but Unix-like environments well,
922 so we might as well de-obfuscate by writing directory and path
923 separators explicitly.
925 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
927 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
928 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
930 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
933 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
935 GNU standards require "file name" instead of "filename" in
936 documentation. It's nice for our code to follow the convention
939 * filename.c: Rename to file-name.c.
941 * filename.h: Rename to file-name.h. Update all inclusions.
942 Update header guards.
944 * automake.mk: Update file names.
946 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
948 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
950 (fn_basename) Removed (dead code).
951 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
952 (fn_special_p) Renamed fn_is_special(), all references updated.
953 (fn_exists_p) Renamed fn_exists(), all references updated.
955 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
957 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
958 Also, now it only tilde-expands file names, not paths.
959 (fn_search_path) Tilde-expand one directory at a time.
961 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
963 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
964 get rid of non-Unixlike version of the code, which has probably
966 (fn_prepend_dir) Removed (dead code).
968 * filename.h: (macro DIR_SEPARATOR_STRING) New.
969 (macro PATH_SEPARATOR_STRING) New.
970 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
972 Continue reforming error message support. In this phase, we get
973 rid of VM() and the other msg() support for "verbosity", replacing
974 it by a new function verbose_msg().
976 * filename.c: (fn_search_path) Use verbose_msg() instead of
979 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
981 * sfm-private.h: Get rid of #defines after #error, which makes no
984 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
986 Get rid of our own int32 type in favor of the standard int32_t
989 * sfm-private.h: (int32 macro) Don't define this anymore. Do
992 * sys-file-reader.c: Use int32_t instead of int32 throughout.
994 * sys-file-writer.c: Use int32_t instead of int32 throughout.
996 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
998 Remove ill-considered file routines that are no longer used.
1000 * filename.c: (fn_open_ext) Removed.
1001 (fn_close_ext) Removed.
1003 * filename.h: (struct file_ext) Removed.
1005 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1007 * variable.c (var_is_valid_name): Move declarations before code
1010 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1012 * filename.ch (fn_interp_vars): Fixed small buglet.
1014 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1016 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1017 so as to modify the string inline. Thus makeing it easier to
1018 destroy the results when no longer needed.
1020 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1022 * category.c (cat_stored_values_destroy): Fixed memory leak.
1024 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1026 Add some missing frees. Thanks to John Darrington for reporting
1029 * any-writer.c (any_writer_close): Free writer.
1031 * any-reader.c (any_reader_close): Free reader.
1033 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1035 * por-file-reader.c: (error) Mark as NO_RETURN.
1037 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1039 * settings.c: Changed default value of scompress to true.
1041 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1043 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1045 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1048 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1049 here from pref.h.orig.
1051 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1053 * sys-file-reader.c: Fixed bug reading compressed files.
1055 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1057 * Numerous renames. See src/ChangeLog for details.
1059 * Moved files from src directory