1 2007-09-24 Ben Pfaff <blp@gnu.org>
3 Patch #6210. Reviewed by John Darrington.
4 * settings.c: Drop "long view", which is not needed any longer.
5 (static var long_view): Removed.
6 (force_long_view): Removed.
7 (get_viewwidth): Removed.
8 (init_viewport): Removed long_view reference.
10 2007-09-19 John Darrington <john@darrington.wattle.id.au>
12 * settings.c settings.h: Changed viewport's length and width to be
13 owned by the user interface which uses the data library. This allows
14 better abstraction, and makes dynamically adjustable dimensions easier.
16 2007-09-18 Ben Pfaff <blp@gnu.org>
18 * procedure.c (proc_extract_active_file_data): New function.
20 * lazy-casereader.h: New file.
22 * lazy-casereader.c: New file.
24 * casereader.c (casereader_dynamic_cast): New function.
26 2007-09-14 Ben Pfaff <blp@gnu.org>
28 * dictionary.c (dict_clone): Copy case indexes from cloned
29 dictionary. Fixes bug #21061. Reviewed by John Darrington.
31 2007-09-13 John Darrington <john@darrington.wattle.id.au>
33 * value.c value.h (create_value): New function.
35 2007-09-12 Ben Pfaff <blp@gnu.org>
37 Make it clear that translator casereader and casewriter translate
38 functions are supposed to destroy their input case.
40 * casereader-translator.c (struct casereader_translator): Change
41 input case parameter of translate member function from const
42 struct ccase * to struct ccase *.
43 (casereader_create_translator): Ditto, for translate parameter.
45 * casewriter-translator.c (struct casewriter_translator): Ditto.
46 (casewriter_create_translator): Ditto.
48 2007-08-27 John Darrington <john@darrington.wattle.id.au>
50 * sys-file-reader.c (read_display_parameters): Force display width
51 to 8, if the sys file says 0 (like SPSS does).
53 2007-08-12 Ben Pfaff <blp@gnu.org>
55 * dictionary.c (dict_dump): New function.
57 2007-08-12 Ben Pfaff <blp@gnu.org>
59 Drop dict_compactor in favor of using the new struct case_map.
61 * dictionary.c (struct copy_map): Removed.
62 (struct dict_compactor): Removed.
63 (dict_make_compactor): Removed.
64 (dict_compactor_compact): Removed.
65 (dict_compactor_destroy): Removed.
67 * procedure.c (struct data_set): Change `compactor' member to be a
69 (proc_open): Use case_map_to_compact_dict instead of
71 (proc_casereader_read): Use case_map_execute instead of
72 dict_compactor_compact.
73 (proc_commit): Use case_map_destroy instead of
74 dict_compactor_destroy.
76 * scratch-writer.c (struct scratch_writer): Change `compactor'
77 member to be a struct case_map *.
78 (scratch_writer_open): Use case_map_to_compact_dict instead of
80 (scratch_writer_casewriter_write): Use case_map_execute instead of
81 dict_compactor_compact.
83 2007-08-12 Ben Pfaff <blp@gnu.org>
85 * automake.mk: Add case-map.c, case-map.h.
87 * case-map.c: New file.
89 * case-map.h: New file.
91 2007-08-12 Ben Pfaff <blp@gnu.org>
93 * dictionary.c (dict_compact_values): Don't delete scratch
94 variables as well as compacting case indexes. Update all callers.
95 (dict_get_compacted_value_cnt): Rename dict_count_values and
96 change interface. Update all callers.
97 (dict_get_compacted_value_cnt): Remove.
98 (dict_compacting_would_shrink): Remove.
99 (dict_compacting_would_change): Remove.
100 (dict_make_compactor): Add new parameter. Update all callers.
102 * procedure.c (proc_casereader_read): Use casewriter_get_value_cnt
103 instead of dict_count_values, changing an O(N) operation into
106 2007-08-12 Ben Pfaff <blp@gnu.org>
108 * casereader.c (casereader_read): Don't require cases read by a
109 casereader to be exactly the expected size: as long as they're big
112 2007-08-12 Ben Pfaff <blp@gnu.org>
114 Make casewriters keep track of the number of `union value's in
115 each case. This is useful for two reasons: casewriter_write can
116 then check that the case being written is large enough, and later
117 recipients of the casewriter can determine the size of the case.
119 * casewriter-translator.c (casewriter_create_translator): Add
122 * casewriter.c (struct casewriter): Add value_cnt member.
123 (casewriter_write): Check that the case passed in is big enough.
124 (casewriter_get_value_cnt): New function.
125 (casewriter_create): Add value_cnt parameter.
127 2007-08-09 Ben Pfaff <blp@gnu.org>
129 Fix bug reported by Jason Stover.
130 * settings.c: Move get_termcap_viewport and in particular the
131 #include for <curses.h> to the end of the file. curses.h
132 redefines bool on some systems (e.g. OpenBSD), which causes
133 disagreement between uses of bool before its inclusion and
135 Tested by Jason Stover.
137 2007-07-29 Ben Pfaff <blp@gnu.org>
139 Provisional fix for bug #18692 and bug #20161. Reviewed by John
142 * file-name.c (fn_open): Only pass "r" or "w" to popen as mode
143 argument (never "rb" or "wb") because SUSv3 says that only those
144 modes are defined, and glibc in fact rejects other modes.
146 Open portable files with fn_open so that they can be read from
147 pipes. Fix missing fh_close call to go along with fh_open.
148 Report an error if the file close reports an error.
149 * por-file-reader.c (close_reader): New function.
150 (por_file_casereader_destroy): Use close_reader.
151 (pfm_open_reader): Open file with fn_open.
153 2007-07-28 Ben Pfaff <blp@gnu.org>
155 Make PSPP able to read all the portable files I could find on the
156 web. Thanks to John Darrington for review. Bug #17620.
157 * por-file-reader.c (struct pfm_reader): New member `line_length'.
158 (error): Print file offset in hexadecimal.
159 (warning): New function.
160 (advance): Treat lines less than 80 bytes long as padded to 80
162 (pfm_open_reader): Call read_documents if we find an "E" record.
163 (convert_format): Convert invalid formats to the default format
164 instead of aborting reading the file.
165 (read_variables): Rename duplicate variable names instead of
166 aborting reading the file.
167 (read_value_label): Allow string variables of different widths to
168 be assigned value labels in the same record. Replace duplicate
169 value labels instead of aborting.
170 (read_documents): New function.
172 * por-file-writer.c (pfm_open_writer): Call write_documents if the
173 dictionary has documents.
174 (write_documents): New function.
176 2007-07-25 Ben Pfaff <blp@gnu.org>
178 Fix bugs related to bug #17213.
180 * settings.c: Use HAVE_LIBNCURSES instead of HAVE_LIBTERMCAP,
181 since the former is what config.h has. Include the needed ncurses
183 (static var echo) Rename to `do_echo' because the original name is
184 the same as an ncurses identifier.
185 (get_termcap_viewport) Use error instead of msg.
187 * file-name.c (fn_interp_vars): Fix interpolation of $VARS.
188 (fn_close): Don't close stdin, stdout, stderr.
190 2007-07-26 John Darrington <john@darrington.wattle.id.au>
192 * procedure.c procedure.h: Added callbacks which get invoked whenever
193 a dataset's transformation chain changes.
195 2007-07-24 Ben Pfaff <blp@gnu.org>
198 * sys-file-writer.c (write_variable_display_parameters): Use new
199 var_default_display_width function to choose display width of
200 segments after the first one in a given variable.
201 * variable.c (var_create): Use var_default_display_width to pick
202 new variable's display width.
203 (var_default_display_width): New function.
204 Reviewed by John Darrington.
206 2007-07-24 Ben Pfaff <blp@gnu.org>
209 * por-file-writer.c (write_variables): Write weight variable.
210 Reviewed by John Darrington.
212 2007-07-23 Ben Pfaff <blp@gnu.org>
214 Improvements to system file reader and writer.
216 First, move all detailed knowledge of very long strings into
217 sys-file-private.[ch], so that this nasty stuff can be isolated.
219 * sys-file-private.c (REAL_VLS_CHUNK): New macro.
220 (EFFECTIVE_VLS_CHUNK): New macro.
221 (min_int): New function.
222 (max_int): New function.
223 (sfm_width_to_bytes): Rewrite.
224 (sfm_width_to_octs): New function.
225 (sfm_segment_alloc_width): New function.
226 (sfm_segment_alloc_bytes): New function.
227 (sfm_segment_used_bytes): New function.
228 (sfm_segment_offset): New function.
229 (sfm_segment_effective_offset): New function.
230 (sfm_dictionary_to_sfm_vars): New function.
232 * sys-file-private.h (MIN_VERY_LONG_STRING): Removed.
233 (EFFECTIVE_LONG_STRING_LENGTH): Removed.
234 (struct sfm_var): New structure.
236 Next, improvements to the system file reader.
238 * sys-file-reader.h (struct sfm_read_info): Changed `case_cnt' to
239 type casenumber. Added `version_major', `version_minor',
242 * sys-file-reader.c (struct sfm_reader): Replaced `flt64_cnt' by
243 `oct_cnt'. Rename `vars', `var_cnt' to `sfm_vars', `sfm_var_cnt'.
244 Change `case_cnt' to type casenumber. Removed `has_vls'.
245 (struct sfm_var): Removed.
246 (sfm_open_reader): Don't warn on wrong case size if the file was
247 written by SPSS 13, which tends to get it wrong. Use
248 sfm_dictionary_to_sfm_vars.
249 (read_header): Always output system file info.
250 (read_variable_record): Simplify code for reading missing values.
251 (read_machine_int32_info): Save version numbers from system file
252 into info struct passed as new argument.
253 (read_long_string_map): Restructured to use new sys-file-private
255 (read_value_labels): Use size_overflow_p.
256 (sys_file_casereader_read): Get rid of distinction between fast
257 and slow paths. Use information provided by sys-file-primate's
258 struct sfm_var to simplify code.
259 (skip_whole_strings): New function.
260 (read_int32): Renamed read_int. Changed return value to int.
262 (read_flt64): Renamed read_float. Changed return value to
263 double. Updated all callers.
264 (int32_to_native): Removed. Changed callers to use
266 (flt64_to_double): Removed. Changed callers to use float_convert.
268 Finally, get rid of int32, flt64 terminology and types in system
269 file writer. The former wasn't very useful since a POSIX "int"
270 can hold the whole range of int32 and we generally didn't have a
271 need for it to be exactly-32-bits, just at-least-32-bits. The
272 latter was inconvenient because we had to assume that it could be
273 different from double and thereby convert special values SYSMIS,
274 HIGHEST, LOWEST to and from it in multiple places. Instead, now
275 we just use "int" and "double" in most places, and do conversions,
276 if necessary, very close to where we do I/O. This change meant
277 that the writer code couldn't represent records in the file as C
278 structs any longer, but that's no great loss. The code actually
279 seems to be more readable without them.
281 Simplify the compression buffering code: only buffer as much as
282 necessary, which is no more than eight 8-byte units at any given
285 * sys-file-writer.c (typedef flt64): Removed.
286 (macro second_lowest_flt64): Removed.
287 (struct sysfile_header): Removed.
288 (struct sysfile_variable): Removed.
289 (struct sfm_writer): Removed `needs_translation', `has_vls',
290 `flt64_cnt'. Changed `compress' to type bool and `case_cnt' to
291 type casenumber. Renamed `vars' to `sfm_vars', `var_cnt' to
292 `sfm_var_cnt'. Replaced `buf', `end', `ptr', `x', `y' for
293 compression buffering by `opcodes', `opcode_cnt', `data',
294 `data_cnt'. Renamed `var_cnt_vls' as `segment_cnt'.
295 (sfm_open_writer): Use sfm_dictionary_to_sfm_vars. Use simple
296 data writer functions instead of structures.
297 (calc_oct_idx): New function.
298 (write_header): Use simple data writer functions instead of
300 (write_format_spec): Renamed write_format. New argument.
301 (write_variable_continuation_records): New function.
302 (write_variable): Use simple data writer functions instead of
303 structures. Use write_variable_continuation_records. Write
304 entire very long string instead of requiring caller to understand
306 (write_value_labels): Use simple data writer functions instead of
308 (write_documents): Ditto.
309 (write_variable_display_parameters): Use sys-file-private
310 functions to simplify. Use simple data writer functions instead
312 (write_vls_length_table): Use simple data writer functions instead
314 (write_longvar_table): Ditto.
315 (write_rec_7_34): Break into new functions
316 write_integer_info_record, write_float_info_record. Use simple
317 data writer functions instead of structures.
318 (buf_write): Removed.
319 (append_string_max): Removed.
320 (ensure_buf_space): Removed.
321 (sys_file_casewriter_write): Get rid of the distinction between
322 fast and slow paths, which didn't seem to be too useful. Use new
323 functions write_case_uncompressed, write_case_compressed.
324 (put_instruction): Removed.
325 (put_element): Removed.
326 (write_compressed_data): Removed.
327 (close_writer): Use flush_compressed. Only write case count to
328 system file if it will fit in the field.
329 (write_case_compressed): New function.
330 (write_case_uncompressed): New function.
331 (flush_compressed): New function.
332 (put_cmp_opcode): New function.
333 (put_cmp_number): New function.
334 (write_int): New function.
335 (convert_double_to_output_format): New function.
336 (write_float): New function.
337 (write_value): New function.
338 (write_string): New function.
339 (write_bytes): New function.
340 (write_zeros): New function.
341 (write_spaces): New function.
343 Reviewed by John Darrington.
345 2007-07-22 Ben Pfaff <blp@gnu.org>
347 Don't try to write very long strings to portable files. The
348 format does not support it.
350 * por-file-writer.c (MAX_POR_WIDTH): New macro.
351 (pfm_open_writer): Limit output width to MAX_POR_WIDTH.
352 (write_format): Add arg to take width to resize format to.
353 (write_value): Limit width of value written to MAX_POR_WIDTH.
354 (write_variables): Limit width of variable and its output formats
356 Reviewed by John Darrington.
358 2007-07-22 Ben Pfaff <blp@gnu.org>
360 * sys-file-reader.c (read_variable_to_value_map): Use max_warnings
361 local variable instead of literal 5.
362 Reviewed by John Darrington.
364 2007-07-22 Ben Pfaff <blp@gnu.org>
366 Fix problems with uniqueness of short names in system files with
367 very long string variables. Now a variable may have multiple
370 * automake.mk (src_data_libdata_a_SOURCES): Add new files
371 short-names.c, short-names.h.
373 * dictionary.c (dict_clone): Clone all the short names.
374 (compare_strings): Move into short-names.c.
375 (hash_strings): Ditto.
376 (set_var_short_name_suffix): Ditto.
377 (dict_assign_short_names): Ditto, rename short_names_assign,
378 change to assign all short names.
380 * por-file-writer.c (write_variables): Use short_names_assign
381 instead of dict_assign_short_names.
383 * short-names.c: New file.
385 * short-names.h: New file.
387 * sys-file-private.c (sfm_width_to_segments): New function.
389 * sys-file-reader.c (read_long_var_name_map): Save and restore all
390 the short names, not just the first one.
392 * sys-file-writer.c (cont_var_name): Removed.
393 (sfm_open_writer): Use short_names_assign instead of
394 dict_assign_short_names. Use unique short names assigned by
395 short_names_assign instead of those generated by cont_var_name.
397 * variable.c (struct variable): Remove `short_name' member,
398 replace by `short_names' and `short_name_cnt'.
399 (var_create) Initialize new members.
400 (var_get_short_name_cnt): New function.
401 (var_get_short_name): Now takes an index argument. Changed most
403 (var_set_short_name): Ditto.
404 (var_clear_short_name): Renamed var_clear_short_names, changed to
405 clear all short names.
407 Reviewed by John Darrington.
409 2007-07-22 Ben Pfaff <blp@gnu.org>
411 * variable.c (var_set_width): Use new var_set_width function.
413 * missing-values.c (mv_n_values): Drop assertion, which was not
416 * format.c (fmt_default_for_width): New function.
417 (fmt_resize): New function.
419 Reviewed by John Darrington.
421 2007-07-18 John Darrington <john@darrington.wattle.id.au>
423 * datasheet.c (datasheet_delete_columns): Added assertion to check
424 we're not deleting outside the range of the sheet.
427 * dictionary.c dictionary.h variable.c: Added the ability for string
428 variables to be resized.
430 * vardict.h: Added some prototypes (moved from dictionary.h) as
431 these should only be called by variable.c
434 2007-07-14 John Darrington <john@darrington.wattle.id.au>
436 * sfm-reader.c: Respect case_cnt field in file header.
438 2007-07-01 John Darrington <john@darrington.wattle.id.au>
440 * transformation.c transformation.h (trns_chain_execute): Changed the
441 signature (Patch #6057)
443 2007-06-10 Ben Pfaff <blp@gnu.org>
445 * casereader-filter.c (casereader_filter_destroy): Make sure to
446 write all the remaining excluded cases to the casewriter, if any.
448 * caseinit.c (init_list_destroy): Rewrite.
449 (init_list_clear): Ditto.
451 * casegrouper.c (casegrouper_get_next_group): Always set *reader
452 to null when returning false.
454 2007-06-06 Ben Pfaff <blp@gnu.org>
456 Actually implement the new procedure code and adapt all of its
457 clients to match. Also adapt all of the other case sources and
458 sinks in the tree and their clients to use the
459 casereader/casewriter infrastructure.
461 * automake.mk: Add and remove files.
463 * any-reader.c: Change into a casereader.
464 * por-file-reader.c: Ditto.
465 * scratch-reader.c: Ditto.
466 * sys-file-reader.c: Ditto.
468 * any-writer.c: Change into a casewriter.
469 * por-file-writer.c: Ditto.
470 * scratch-writer.c: Ditto.
471 * sys-file-writer.c: Ditto.
473 * procedure.c: Change to use casereader, casewriter, caseinit, and
474 other new infrastructure.
476 * scratch-handle.c: Adapt to new infrastructure.
478 * case-sink.c: Removed, now dead code.
479 * case-sink.h: Ditto.
480 * case-source.c: Ditto.
481 * case-source.h: Ditto.
482 * casefile-factory.c: Ditto.
483 * casefile-private.h: Ditto.
486 * casefilter.c: Ditto.
487 * casefilter.h: Ditto.
490 * fastfile-factory.c: Ditto.
491 * fastfile-factory.h: Ditto.
492 * storage-stream.c: Ditto.
493 * storage-stream.h: Ditto.
495 2007-06-06 Ben Pfaff <blp@gnu.org>
499 * automake.mk: Add new files.
501 * datasheet.c: New file.
503 * datasheet.h: New file.
505 2007-06-06 Ben Pfaff <blp@gnu.org>
507 Until now, the procedure code has provided a case to the
508 case_source, which has filled in the data values that come from
509 the active file. "Left" data values that don't come from the
510 active file naturally stay the same from case to case, because the
511 procedure code keeps using that same case.
513 One of the compromises that comes with the new procedure code is
514 that the active file allocates and provides its own case, which
515 the procedure code then has to resize to provide room for any
516 other variables that should go in the case and then fill in the
517 values of "left" variables. Then, when we're done with that case,
518 we have to save the values of "left" variables to copy into the
519 next case read from the active file.
521 The caseinit code helps with this.
523 * automake.mk: Add new files.
525 * caseinit.c: New file.
527 * caseinit.h: New file.
529 2007-06-06 Ben Pfaff <blp@gnu.org>
531 * value.h (value_cnt_from_width): New function.
533 * variable.c (var_get_value_cnt): Use new function.
535 2007-06-06 Ben Pfaff <blp@gnu.org>
537 Add casegrouper, to allow cases read from a given casereader to be
538 broken into groups, each of which has its own casereader.
539 Generally cases are grouped based on having equal values for some
542 * automake.mk: Add new files.
544 * casegrouper.c: New file.
546 * casegrouper.h: New file.
548 2007-06-06 Ben Pfaff <blp@gnu.org>
550 Add interface to lexicographical ordering of cases.
552 * automake.mk: Add new files.
554 * case-ordering.c: New file.
556 * case-ordering.h: New file.
558 2007-06-06 Ben Pfaff <blp@gnu.org>
560 Add casereaders and casewriters, the basis of the new data processing
561 implementation. A casereader is a uniform interface to reading cases
562 from a data source; a casewriter is a uniform interface to writing
563 cases to a data sink.
565 * automake.mk: Add new files.
567 * casereader-filter.c: New file.
569 * casereader-provider.h: New file.
571 * casereader-translator.c: New file.
573 * casereader.c: New file.
575 * casereader.h: New file.
577 * casewriter-provider.h: New file.
579 * casewriter-translator.c: New file.
581 * casewriter.c: New file.
583 * casewriter.h: New file.
585 2007-06-06 Ben Pfaff <blp@gnu.org>
587 "casewindow" data structure that extends the deque (from libpspp)
588 of cases with the ability to dump cases to disk if we get too many
591 * automake.mk: Add new files.
593 * casewindow.c: New file.
595 * casewindow.h: New file.
597 2007-06-06 Ben Pfaff <blp@gnu.org>
599 sparse_cases data structure that augments a sparse_array of cases
600 with the ability to dump cases to disk if we get too many cases in
603 * automake.mk: Add new files.
605 * sparse-cases.c: New file.
607 * sparse-cases.h: New file.
609 2007-06-06 Ben Pfaff <blp@gnu.org>
611 Adds a low-level on-disk case array data structure.
613 * automake.mk: Add new files.
615 * case-tmpfile.c: New file.
617 * case-tmpfile.h: New file.
619 2007-06-06 Ben Pfaff <blp@gnu.org>
621 In a couple of places we calculate the maximum number of cases to
622 keep in memory based on the user-defined workspace. Enable
623 centralizing the calculation through a new function.
625 * settings.c (get_workspace_cases): New function.
627 2007-06-06 Ben Pfaff <blp@gnu.org>
629 The casenumber type is defined in transformations.h, but case.h is
630 a more sensible place. Move it.
632 * case.h (CASENUMBER_MAX): New macro.
633 (typedef casenumber): Move here, from transformations.h.
635 2007-06-03 Ben Pfaff <blp@gnu.org>
637 Slightly generalize case_to_values and case_from_values functions.
639 * case.c (case_to_values): Rename case_copy_out, change interface.
640 (case_from_values): Rename case_copy_in, change interface.
642 * fastfile.c (fastfilereader_get_next_case): Update caller.
643 (write_case_to_disk): Ditto.
645 2007-06-02 Ben Pfaff <blp@gnu.org>
647 Clean up after a forgotten part of patch #5829.
649 * casedeque.h: Remove unused file.
651 * automake.mk: Remove casedeque.h from sources.
653 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
655 * category.c: Removed redundant #include
657 2007-05-06 Ben Pfaff <blp@gnu.org>
659 Abstract the documents within a dictionary a little better.
660 Thanks to John Darrington for suggestion, initial version, and
663 * dictionary.c (struct dictionary): Change `documents' member from
664 char * to struct string.
665 (dict_clear): Destroy struct string.
666 (dict_get_documents): Convert struct string to char *.
667 (dict_set_documents): Set struct string. Pad to 80-character
669 (dict_clear_documents): New function.
670 (dict_add_document_line): New function.
671 (dict_get_document_line_cnt): New function.
672 (dict_get_document_line): New function.
674 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
676 * sys-file-reader.c (read_documents): Use new document functions.
678 2007-04-19 John Darrington <john@darrington.wattle.id.au>
680 * sys-file-reader.c: When reading a system file which has no
681 long name table, automatically create one where the long names
682 are the lower case versions of the short names.
684 2007-04-22 Ben Pfaff <blp@gnu.org>
686 * dictionary.c (dict_set_split_vars): dict_destroy expects that
687 dict_clear will free most data related to the dictionary.
688 dict_clear does a decent job, except that dict_set_split_vars on
689 some systems won't actually free the dict's "split" member.
690 Instead, it'll allocate a 1-byte region. Fix this.
692 * value.c (value_copy): New function.
693 (value_set_missing): Ditto.
695 2007-04-22 John Darrington <john@darrington.wattle.id.au>
697 * Deleted existing category.h and moved cat-routines.h into
698 category.h Encapsulated struct cat_vals better.
700 2007-04-19 John Darrington <john@darrington.wattle.id.au>
702 * sys-file-reader.c: When reading a system file which has no
703 long name table, automatically create one where the long names
704 are the lower case versions of the short names.
706 2007-04-16 John Darrington <john@darrington.wattle.id.au>
708 * sys-file-reader.c: Some versions of Other Software seem to
709 produce system files with string variables' measure set to
710 zero. We'll assume these are supposed to be nominal variables.
712 2007-03-30 Ben Pfaff <blp@gnu.org>
714 * procedure.c: Adapt to new deque data structure.
716 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
717 Ben Pfaff <blp@gnu.org>
719 * file-name.c: Mingw compatibility fixes.
720 (fn_search_path): Use ISSLASH instead of comparing against '/'
722 (fn_dir_name): Use dir_name from gnulib.
723 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
724 (fn_get_identity): Use GetFullPathName instead of canonicalize
725 from gnulib, because the latter does not fully support
726 Windows-style path names. Use this implementation based on the
727 detected presence of Windows instead of the absence of Unix, since
728 the new implementation is Windows-specific.
729 (fn_compare_file_identities): In Windows implementation, compare
730 names case-insensitively.
732 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
734 * make-file.c: Don't include mkstemp.h, because gnulib now causes
735 <stdlib.h> to have the same effect.
737 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
739 * por-file-reader.c: Add missing _() around messages.
741 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
743 * make-file.c: Include "mkstemp.h", without which linking on
746 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
748 Reduce platform dependence.
750 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
751 Everywhere we using this, we really should have just depended on
752 the shell to expand tildes.
753 (fn_search_path): Simplify, given that we don't do tilde expansion
755 (fn_normalize): Removed. Caller changed to use the canonicalize
757 (fn_get_cwd): Removed. Only user was fn_normalize.
758 (fn_is_absolute): Really only test for absolute names.
759 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
761 (fn_readlink): Removed, as it was only used fn_normalize.
762 (fn_exists): Assume the stat function is available; gnulib does.
763 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
765 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
767 * dictionary.c (dict_create_vector_assert): New function.
769 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
771 * file-name.c (fn_normalize): Correct name of function
772 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
773 for pointing this out.
775 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
777 We are using a single member in struct file_handle, the "name"
778 field, for more than one purpose. When it begins with '"', it's a
779 file name; otherwise, it's a token that can be used to identify
780 it. When that assertion fires, it's because we searched for the
781 name case-sensitively as a file name (so that there was no match),
782 and then we try to insert it case-insensitively as a token, which
783 fails because duplicates aren't allowed.
785 Solution: break the two purposes into two separate fields. This
786 fixes the problem and likely makes the code easier to read too.
788 Fixes bug #18922. Thanks to John Darrington for bug report and
791 * file-handle-def.c (struct file_handle): New `id' member.
792 (fh_from_name): Rename fh_from_id. Update all callers.
793 (create_handle): New `id' parameter. Update all callers.
794 (fh_create_file): Ditto.
795 (fh_get_id): New function.
797 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
799 * case.c (case_is_null): Change return type to bool.
801 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
805 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
806 reference counting to share data. This makes it easy for
807 valgrind, etc. to find accesses to cases that have been destroyed
808 but have been kept around by another user's ref-count. This often
809 happens when the data set is small enough to find in memory; if a
810 bigger data set that would overflow to disk were used, then data
811 corruption would occur.
813 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
817 * case.c (case_unshare): Make it check internally whether the
818 ref_cnt is greater than 1, so that the callers don't have to.
819 Update callers not to check.
821 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
823 Before, I was thinking that I might want to get rid of reference
824 counting at some point. Now, I'm pretty sure that it's here to
825 stay. Thus, because we have to store the value_cnt anyway for
826 reference-counted cases, we might as well expose it to users.
828 * case.c (case_get_value_cnt): New function.
829 (case_resize): Drop OLD_CNT argument. Update all callers. Only
830 resize case if its size actually changed.
832 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
833 instead of peeking inside struct case directly.
834 (casefile_append): Ditto.
836 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
838 Get rid of the inlines for the case functions, which made the
839 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
840 the inlines didn't speed up "make check" at all, which is not a
841 perfect benchmark but seems indicative.)
843 * case.c: Remove #ifdef DEBUGGING...#endif around many function
844 definitions. Remove some assertions on nonnull pointers that were
845 redundant with a pointer dereference soon after in the function.
847 (struct case_data): Move definition here from case.h.
851 (case_data_wr): Ditto.
853 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
855 * automake.mk: Add casedeque.h to sources.
857 * casedeque.h: New file.
859 * procedure.c: (struct dataset) Change lag_count, lag_head,
860 lag_queue member into single struct casedeque member. Update all
861 users to use the casedeque instead.
864 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
866 * procedure.c: Simplify lagged cases interface. Updated all
867 clients--well, the only client--to use the simplified interface.
868 (dataset_n_lag) Removed.
869 (dataset_set_n_lag) Removed.
870 (dataset_need_lag) New function.
872 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
874 * dictionary.c procedure.c: More changes to ensure that callbacks occur
875 whenever appropriate, but only when the dataset/dictionary is in a
878 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
880 * dictionary.c dictionary.h : Added callbacks for change of filter and
881 split variables. Refactored some code to ensure that callbacks get
882 invoked when appropriate.
884 * procedure.c (proc_cancel_temporary_transformations): Make sure that
885 replace_dict callback occurs when permanent_dict replaces the current
888 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
890 * dictionary.c dictionary.h : Added callback for when the weight
891 variable of a dictionary changes.
893 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
895 * dictionary.c dictionary.h : Added replace_source and replace_dict
896 callbacks, and functions to deal with them.
898 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
900 Simplify missing value handling.
902 * missing-values.h (enum mv_class): New type.
903 (enum mv_type): Moved definition into missing-values.c and renamed
904 each MV_* to MVT_*, to distinguish them from the exposed mv_class
905 enums. Updated all uses.
906 (struct missing_values): Changed type of `type' from `enum
907 mv_type' to `int' because the definition is no longer exposed.
909 * missing-values.c (mv_is_value_missing): Add new enum mv_class
910 parameter. Update all callers.
911 (mv_is_num_missing): Ditto.
912 (mv_is_str_missing): Ditto.
913 (mv_is_value_user_missing): Removed. Changed callers to use
915 (mv_is_num_user_missing): Removed. Changed callers to use
917 (mv_is_str_user_missing): Removed. Changed callers to use
919 (mv_is_value_system_missing): Removed. Changed callers to use
921 (mv_set_type): Removed. Changed callers to use mv_clear.
922 (mv_clear): New function.
924 * variable.c (var_is_value_missing): Add new enum mv_class
925 parameter. Update all callers.
926 (var_is_num_missing): Ditto.
927 (var_is_str_missing): Ditto.
928 (var_is_value_user_missing): Removed. Changed callers to use
929 var_is_value_missing.
930 (var_is_num_user_missing): Removed. Changed callers to use
932 (var_is_str_user_missing): Removed. Changed callers to use
934 (var_is_value_system_missing): Removed. Changed callers to use
935 var_is_value_missing.
937 * casefilter.c (struct casefilter): Use enum mv_class in place of
939 (casefilter_variable_missing): Adapt to new member.
940 (casefilter_create): Change signature to take enum mv_class,
943 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
945 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
947 * case-sink.c case-sink.h procedure.c procedure.h
948 storage-stream.c: Now uses the factory.
950 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
952 Make it possible to pull cases from the active file with a
953 function call, instead of requiring indirection through a callback
956 * case-source.h (struct case_source_class): Change ->read function
957 to return a single case, instead of calling a callback function
958 for each case. Change ->destroy function to return an error
961 * case-source.c (free_case_source): Pass along the value returned
962 by the case_source ->destroy function.
964 * procedure.c (struct write_case_data): Removed.
965 (struct dataset): Added some members to track procedure state.
966 (procedure): Optimize the trivial case at this level.
967 (internal_procedure): Re-implement in terms of proc_open,
968 proc_read, proc_close.
969 (proc_open) New function.
970 (proc_read) New function.
971 (proc_close) New function.
972 (write_case) Moved into proc_read.
973 (close_active_file) Moved closing of data source into proc_close.
975 * storage-source.c: Rewrote to conform with modified
976 case_source_class interface.
978 * transformations.c (trns_chain_execute): Added argument to allow
979 starting execution from an arbitrary transformation. Updated
982 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
984 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
986 * sys-file-reader.c (read_display_parameters): Don't assume that
987 MEASURE_* and ALIGN_* have the same values found in system files.
989 * sys-file-writer.c (write_variable_display_parameters): Ditto.
991 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
992 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
993 the value of n_MEASURES, which was off by 1 (at least from my
996 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
998 * dictionary.c dictionary.h vardict.h variable.c: Added optional
999 callbacks which are invoked when the dictionary or its
1000 variables are changed.
1002 * missing-values.c missing-values.h value-labels.c: Tidied up
1003 consistency checks, and made some of them return false
1004 instead of assert-failing.
1006 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
1008 * calendar.c (calendar_days_in_month): New function.
1010 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
1012 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
1013 the value label's width.
1015 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
1017 * sfm-private.h: Move contents into sys-file-writer.c, which is
1018 the only remaining user. Removed Borland C++-specific directives.
1020 * sys-file-reader.c: Clean up and rewrite entire file. The
1021 rewritten version is simpler and better abstracted, and should be
1022 easier to maintain and extend. It avoids using structures to read
1023 file data, which is prone to padding variations among compilers.
1024 It should also handle non-IEEE 754 system files, although I
1025 haven't been able to find any. It has been tested against many
1026 .sav files obtained from the Web and found to produce the same
1027 results as the earlier version of the code, or in some cases
1028 improved results. It is more tolerant of format variations found
1031 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
1032 member, putting an enum integer_format in its place. New member
1033 `float_format'. Changed `compressed' member to type bool.
1035 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
1037 * dictionary.c (dict_delete_consecutive_vars): New function.
1039 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
1041 * file-name.c (fn_search_path): Remove prefix arg that was unused
1042 by any caller. Updated all callers.
1044 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
1046 * format.c (fmt_dollar_template): Use user's decimal point
1047 character. Add assertion.
1049 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
1051 * format.c (fmt_dollar_template): New function, based on
1052 dollar_format_template from var-type-dialog.c.
1054 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
1056 * data-out.c (output_scientific): Fix bad assumption that "buf" is
1059 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
1061 Finish converting struct variable to an opaque type. In this
1062 phase, we add remaining setter and getter functions, convert the
1063 remaining PSPP code to use them, and do a bunch of cleanup. The
1064 resulting changes are pervasive but mostly trivial, and only the
1065 notable changes are logged.
1067 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
1070 * case.c (case_data): Renamed case_data_idx.
1071 (case_num): Renamed case_num_idx.
1072 (case_str): Renamed case_str_idx.
1073 (case_data_rw): Renamed case_data_rw_idx.
1075 * case.h (case_data): New function with old name and an interface
1076 that takes a variable instead of an index, which is easier to
1077 use. Updated all callers to use the new interface, or to use the
1078 new *_idx function (see above).
1081 (case_data_rw): Ditto.
1083 * category.c (cat_stored_values_destroy): Changed interface to
1084 take a struct cat_vals * instead of a struct variable *.
1086 * dictionary.c (dict_clone): Use new vector_clone function.
1087 (dict_clear) Use new var_destroy function.
1088 (add_var) New function.
1089 (dict_create_var) Rewrite in terms of dict_create_var_assert.
1090 (dict_create_var_assert) Rewrite in terms of add_var.
1091 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
1092 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
1093 (dict_lookup_var) Use new var_create, var_destroy functions.
1094 (dict_contains_var) Rewrite in terms of new vardict functionality.
1095 (set_var_dict_index) New function.
1096 (set_var_case_index) New function.
1097 (reindex_vars) New function.
1098 (dict_delete_var) Rewrite in terms of new vardict functionality.
1099 (dict_reorder_var) Ditto.
1100 (dict_reorder_vars) Ditto.
1101 (rename_var) New function.
1102 (dict_rename_var) Use rename_var.
1103 (dict_rename_vars) Use pool to simplify code. Use rename_var.
1104 (dict_get_compacted_idx_to_fv) Rename
1105 dict_get_compacted_dict_index_to_case_index, update callers.
1106 (dict_create_vector) Use new vector_create function.
1107 (dict_clear_vectors) Use new vector_destroy function.
1108 (set_var_short_name_suffix) Move here from variable.c, renamed
1109 from var_set_short_name_suffix, make static, update caller.
1111 * sys-file-private.c: New file.
1112 (sfm_width_to_bytes) Moved here from variable.c, renamed from
1113 width_to_bytes, update callers.
1115 * sys-file-private.h: New file. Later it will supplant
1116 sfm-private.h; for now it supplements it.
1117 (macro MIN_VERY_LONG_STRING) New macro.
1118 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
1120 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
1121 MAX_LONG_STRING was used before.
1123 * sys-file-writer.c: Ditto.
1125 * value-labels.c: Change the paradigm here to be that a null
1126 pointer is OK for a struct val_labs * in most cases; it just
1127 represents an empty set of value labels.
1128 (val_labs_copy) A copy of a null set is a null set.
1129 (val_labs_count) A null set has 0 labels.
1130 (val_labs_replace) Change return type to void. Rewrite for
1132 (val_labs_find) A null set does not contain the value.
1133 (value_to_string) Moved to variable.c, renamed var_get_value_name,
1134 transposed argument order, updated all callers.
1136 * value.c: New file.
1137 (value_dup) Moved here from variable.c.
1138 (compare_values) Ditto.
1141 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
1142 (macro MAX_LONG_STRING) Removed, because it was only interesting
1143 for system files, not for general code.
1144 (macro MAX_VERY_LONG_STRING) Ditto.
1145 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
1146 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
1148 * vardict.h: New file, for an interface between variables and
1151 * variable.c: A lot of functions were moved around, for better
1153 (struct variable) Move definition here, from variable.h.
1154 (var_type_adj) Removed--makes i18n hard.
1155 (var_type_noun) Ditto.
1156 (var_create) New function.
1157 (var_clone) New function.
1158 (var_destroy) New function.
1159 (var_set_name) Assert that variable is not in a dictionary.
1160 (compare_var_names) Rename compare_vars_by_name and fix a couple
1161 of callers who thought the args were strings.
1162 (hash_var_name) Rename hash_var_by_name.
1163 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
1164 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
1165 (var_is_very_long_string) Removed, because it was only interesting
1166 to system file code.
1167 (var_set_missing_values) Allow the argument to be the wrong width,
1168 as long as we can resize it. Simplify callers who were doing the
1169 resizing themselves.
1170 (var_get_value_labels) New function.
1171 (var_has_value_labels) New function.
1172 (var_set_value_labels) New function.
1173 (alloc_value_labels) New function.
1174 (var_add_value_label) New function.
1175 (var_replace_value_label) New function.
1176 (var_clear_value_labels) New function.
1177 (var_lookup_value_label) New function.
1178 (var_get_value_name) Moved here from variable.c, renamed from
1179 var_get_value_name, transposed argument order, updated all
1181 (var_to_string) Moved here, from variable-label.c.
1182 (var_set_leave) New function.
1183 (var_get_leave) New function.
1184 (var_must_leave) New function.
1185 (var_set_short_name_suffix) Moved to dictionary.c, renamed
1186 set_var_short_name_suffix.
1187 (var_get_dict_index) New function.
1188 (var_get_case_index) New function.
1189 (var_get_obs_vals) New function.
1190 (var_set_obs_vals) New function.
1191 (var_has_obs_vals) New function.
1192 (var_get_vardict) New function.
1193 (var_set_vardict) New function.
1194 (var_has_vardict) New function.
1195 (var_clear_vardict) New function.
1196 (value_dup) Moved to value.c.
1197 (compare_values) Ditto.
1200 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
1201 (enum ALPHA) Rename VAR_STRING, update all users.
1203 * vector.c: New file.
1204 (struct vector) Moved here, from variable.h.
1205 (check_widths) New function.
1206 (vector_create) New function.
1207 (vector_clone) New function.
1208 (vector_destroy) New function.
1209 (vector_get_name) New function.
1210 (vector_get_var) New function.
1211 (vector_get_var_cnt) New function.
1212 (compare_vector_ptrs_by_name) New function.
1214 * vector.h: New file.
1216 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1218 * casefilter.c (casefilter_variable_missing): Avoided comparision of
1219 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
1222 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
1224 * value-labels.c (destroy_atoms): New function.
1225 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
1227 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
1229 Thanks to Jason Stover for pointing out this problem.
1231 * data-out.c (output_number): Use gsl_finite from GSL, which is
1232 portable, instead of isfinite, which is not.
1235 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
1237 * variable.c variable.h (value_dup): New function.
1239 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
1241 Start converting struct variable to an opaque type. In this
1242 phase, we add a bunch of setter and getter functions and convert
1243 most of the PSPP code to use them. The resulting changes are
1244 pervasive but mostly trivial, and only the notable changes are
1247 * format.c (fmt_equal): New function.
1249 * variable.c (var_type_is_valid): New function.
1250 (measure_is_valid) Moved here, from format.c.
1251 (alignment_is_valid) Moved here, from format.c.
1252 (var_get_name) New function.
1253 (var_set_name) New function.
1254 (width_to_type) New function.
1255 (var_get_type) New function.
1256 (var_get_width) New function.
1257 (var_set_width) New function.
1258 (var_is_numeric) New function.
1259 (var_is_alpha) New function.
1260 (var_is_short_string) New function.
1261 (var_is_long_string) New function.
1262 (var_is_very_long_string) New function.
1263 (var_get_missing_values) New function.
1264 (var_set_missing_values) New function.
1265 (var_clear_missing_values) New function.
1266 (var_has_missing_values) New function.
1267 (var_is_value_missing) New function.
1268 (var_is_num_missing) New function.
1269 (var_is_str_missing) New function.
1270 (var_is_value_user_missing) New function.
1271 (var_is_num_user_missing) New function.
1272 (var_is_str_user_missing) New function.
1273 (var_is_value_system_missing) New function.
1274 (var_get_print_format) New function.
1275 (var_set_print_format) New function.
1276 (var_get_write_format) New function.
1277 (var_set_write_format) New function.
1278 (var_set_both_formats) New function.
1279 (var_get_label) New function.
1280 (var_set_label) New function.
1281 (var_clear_label) New function.
1282 (var_has_label) New function.
1283 (var_get_measure) New function.
1284 (var_set_measure) New function.
1285 (var_get_display_width) New function.
1286 (var_set_display_width) New function.
1287 (var_get_alignment) New function.
1288 (var_set_alignment) New function.
1289 (var_get_value_cnt) New function.
1290 (var_get_leave) New function.
1291 (var_get_short_name) New function.
1293 * variable.h: (struct variable) Removed "type" and "nv" members;
1294 they are now computed from "width" where needed.
1296 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
1298 * missing-values.c (mv_resize): Don't write beyond end of the
1299 allocated buffer when resizing a long string.
1301 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
1303 Clean up identifier code: don't require identifier enumerations to
1304 be in a particular order; make better use of string library;
1305 expose less of the internals.
1307 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
1308 change interface. Updated all callers.
1309 (lex_id_match) Change interface to use struct substring, update
1311 (lex_id_match_len) Removed. Update callers to use lex_id_match.
1312 (global array keywords[]) Make static, change form. Update all
1313 users to use lex_id_name instead.
1314 (lex_is_keyword) New function.
1315 (lex_id_to_token) Change interface to use struct substring, update
1317 (lex_id_name) New function.
1319 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
1320 lex_is_keyword instead.
1321 (T_LAST_KEYWORD) Removed.
1322 (T_N_KEYWORDS) Removed.
1324 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
1326 * format.c: (fmt_date_template) Distinguish characters for which a
1327 space is output and any date delimiter is allowed on input, from
1328 those for which a space is output and only a space is allowed on
1329 input. The former is represented by X, the latter by a space.
1330 Also, drop distinction between h and H, changing the former to the
1333 * data-in.c: Completely rewrite internals to conform to SPSS input
1334 formats as closely as possible.
1335 (data_in) Changed external interface by replacing the structure
1336 that was used as a single argument by a set of arguments. Updated
1338 (data_in_finite_line) Removed. Converted all callers to use plain
1340 (data_in_get_integer_format) New function.
1341 (data_in_set_integer_format) New function.
1342 (data_in_get_float_format) New function.
1343 (data_in_set_float_format) New function.
1345 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
1346 (struct data_in) Removed.
1348 * data-out.c: (output_date) Drop each component from the input as
1349 it is output, to allow us to drop the distinction between h (a
1350 count of hours) and H (the hour of day) template characters.
1351 Also, handle new X template character.
1352 (output_scientific) Follow more rational rule on when to drop
1353 fraction introduced between SPSS 13 and 15. Updated test case to
1356 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
1358 Fix buffer overflow reported by John Darrington.
1360 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
1361 realize that DIGITS is a count of nibbles, not of bytes.
1363 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
1365 * calendar.c (calendar_offset_to_gregorian) Also return the
1366 year-of-day. Change callers to new interface.
1368 * data-out.c: Completely rewrite internals to conform to SPSS
1369 output formats as completely as possible.
1370 (data_out) Change interface to put input parameters before output
1371 parameters, for consistency with the style I now prefer. Update
1373 (data_out_get_integer_format) New public function.
1374 (data_out_set_integer_format) New public function.
1375 (data_out_get_float_format) New public function.
1376 (data_out_set_float_format) New public function.
1378 * data-out.h: New file. Move prototype for data_out here, from
1381 * format.c: (fmt_step_width) Use equality comparison instead of
1382 bitwise and, for clarity.
1383 (fmt_is_string) Ditto.
1384 (fmt_input_to_output) Fix categories that are translated to F
1387 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
1389 * casefilter.c casefilter.h (new files), casefile.c casefile.h
1390 casefile-private.h: Added casefilter to assist commands with missing
1393 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
1395 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
1397 * settings.c: (route_errors_to_terminal) New variable.
1398 (route_errors_to_listing) New variable.
1399 (get_error_routing_to_terminal) New function.
1400 (set_error_routing_to_terminal) New function.
1401 (get_error_routing_to_listing) New function.
1402 (set_error_routing_to_listing) New function.
1404 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
1406 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
1408 * format.c: Completely rewrite, to achieve better abstraction.
1409 Rewrite all references to formats in other files.
1411 * format.def: Rewrite and reorganize.
1413 * settings.c: Move everything related to custom currency formats
1414 into format.[ch], changing them in form, so as to group related
1415 code and definitions better. Changed all references to use the
1417 (static var decimal) Removed.
1418 (static var grouping) Removed.
1419 (static var cc) Removed.
1420 (get_decimal) Removed.
1421 (set_decimal) Removed.
1422 (get_grouping) Removed.
1423 (set_grouping) Removed.
1427 * settings.h: (macro CC_CNT) Removed.
1428 (macro CC_WIDTH) Removed.
1429 (struct custom_currency) Removed.
1431 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
1433 * data-in.c (data_in): Use switch statement instead of table, to
1434 avoid dependence on the order of the FMT_* enums.
1436 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
1438 * data-out.c: (num_to_string) Removed, because it was dead code.
1440 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
1442 * data-in.c (parse_trailer): Fix error message.
1444 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
1446 * format.c (fmt_is_binary): New function.
1448 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
1450 * procedure.c procedure.h: Encapsulated the static data into a single
1453 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
1455 * casefile.c (casereader_read_xfer): Always initialize the case,
1456 even on an error condition.
1458 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
1460 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
1461 entire function useless.
1463 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
1465 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
1466 casereader method casereader_clone.
1468 * procedure.c pransformations.h: Introduced new type casenum_t
1470 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
1472 * variable.c: (width_to_bytes) Rephrase code for clarify.
1474 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
1476 * format.c: (fmt_type_from_string) New function.
1477 (fmt_to_string) Include decimals in output if the format has
1478 decimals, even if the format type does not. This way, we can
1479 accurately reproduce incorrect formats in user output.
1480 (check_common_specifier) Make the check for a bad format type an
1481 assertion, so we get bug reports if they show up. Fix message.
1482 Check for decimal places with a format type that doesn't allow
1484 (check_input_specifier) Remove check for FMT_X, which has been
1486 (check_output_specifier) Ditto.
1488 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
1490 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
1491 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
1492 (enum fmt_parse_flags) Removed.
1494 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
1496 * casefile.c casefile.h: Converted to an abstract base class.
1497 * casefile-private.h fastfile.c fastfile.h: New files.
1498 * automake.mk procedure.c scratch-writer.c storage-stream.c
1500 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
1502 * procedure.c (internal_procedure): Create sink_case with only as
1503 many values as the compacted dictionary.
1505 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
1507 Remove "debugging" code that caused plenty of false positives and
1510 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
1512 * case.c: Remove all references to `this' member.
1514 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
1516 Fix link error noted by Jason Stover.
1518 * storage-stream.c: Include <assert.h>.
1520 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
1522 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
1523 ALL) and additional underlying system file issues.
1525 Thanks to John Darrington for review.
1527 First problem: var_hash points to variables not owned by the
1528 sys-file-reader, which the caller may free or modify. Use an
1529 array of sfm_vars instead, as done earlier (e.g. CVS version
1532 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
1533 members and remove all code that references it. Add vars, var_cnt
1534 members. Remove fix_specials member, which was unused.
1535 (struct sfm_var) Remove name member, which was unused.
1536 (sfm_close_reader) Free vars member instead of var_hash.
1537 (compare_var_shortnames) Removed.
1538 (hash_var_shortname) Removed.
1539 (sfm_open_reader) Fill out vars array.
1540 (compare_var_index) Removed.
1541 (sfm_read_case) Use vars instead of var_hash.
1543 Second problem: we're confused about when we actually have very
1544 long strings, causing us to choose incorrectly between slow path
1545 and fast path in sfm_read_case.
1547 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
1548 have very long strings, not when we have long variable names,
1549 which is an unrelated feature.
1551 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
1553 * variable.h: Move var_set and variable parsing declarations to
1554 new header, src/language/lexer/variable-parser.h. Modified lots
1555 of files to include the new header.
1557 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
1559 * value-labels.c (value_to_string): When there's no value label,
1560 format the variable according to its print format, instead of
1561 always effectively using A or F format.
1563 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
1565 * casefile.c (casefile_get_random_reader): Nasty hack to get around
1568 * format.c: Removed tortological assertion.
1570 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
1572 Reform string library.
1574 * file-name.c (fn_interp_vars): Change interface to take a
1575 substring as input. Updated all users.
1577 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
1579 * format.c (measure_is_valid): Really return false when m >=
1582 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
1584 Implement random access to casefiles, for use in GUI.
1586 * casefile.c: (struct casereader) Add `random', `file_ofs',
1587 `buffer_ofs' members.
1588 (casefile_get_random_reader) New function.
1589 (read_open_file) Break part into new function
1590 seek_and_fill_buffer().
1591 (fill_buffer) Update buffer_ofs, file_ofs.
1592 (casereader_seek) New function.
1594 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1596 * settings.c: Added call to i18n{done, init}.
1598 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
1600 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
1603 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
1605 * casefile.c: Convert many uses of `int' to `bool'.
1607 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
1609 * transformations.c (trns_chain_destroy): Destroy chain's trns
1610 member, to fix memory leak.
1612 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
1614 * storage-stream.c (storage_source_decapsulate): Destroy case
1615 source to fix memory leak.
1617 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
1619 * scratch-reader.c (scratch_reader_read_case): Copy into existing
1620 case passed as argument instead of initializing the argument as a
1621 case. Fixes memory leak that showed up in
1622 tests/command/aggregate.sh with scratch files.
1624 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
1626 * procedure.c (proc_done): Destroy default_dict, to fix memory
1629 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
1631 Simplify procedure_with_splits().
1633 * procedure.c (struct split_aux_data): Removed case_count member.
1634 (procedure_with_splits) Don't initialize case_count.
1635 (split_procedure_case_func) Check whether prev_case is null
1636 instead of case_count.
1637 (split_procedure_end_func) Ditto.
1639 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
1641 * case.c (case_move): Do nothing if dst and src are the same
1643 (case_try_create) Merge two similar cases.
1644 (case_copy) Unshare only if data must be actually copied.
1646 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1648 * data-in.c data-out.c dictionary.c sys-file-reader.c
1649 sys-file-writer.c variable.c variable.h: Reworked very long string
1650 support for better encapsulation.
1652 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1654 * value-labels.c (val_labs_can_set_width): New function.
1655 (val_labs_set_width) Clear labels if increasing width to long
1657 (val_labs_destroy) Remove unneeded test for null.
1659 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1661 * value-labels.h: Remove unneeded dependency on variable.h.
1663 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1665 Get rid of `char *c' member in union value, for cleanliness.
1667 * value.h: (union value) Remove `c' member.
1669 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1671 Make dictionary compacting functions a little more general.
1673 * sys-file-writer.c (sfm_open_writer): Use
1674 dict_compacting_would_change().
1675 (does_dict_need_translation) Removed.
1677 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1679 Make dictionary compacting functions a little more general.
1681 * dictionary.c (dict_needs_compaction): Rename
1682 dict_compacting_would_shrink(). Update all callers.
1683 (dict_compacting_would_change) New function.
1685 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1687 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1688 inverted return value (!).
1690 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1692 Continue reforming procedure execution.
1694 * procedure.c: Search and replace "vfm" by "proc". Notably:
1695 (static var vfm_source) Rename proc_source. Update all
1697 (static var vfm_sink) Rename proc_sink. Update all references.
1699 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1701 Continue reforming procedure execution. In this phase, remove
1702 PROCESS IF, which was deprecated anyway and can be easily
1703 simulated with TEMPORARY followed by SELECT IF.
1705 * procedure.c: (open_active_file) Don't call
1706 add_process_if_trns().
1707 (discard_variables) Get rid of redundant call to
1708 proc_cancel_all_transformations().
1709 (add_process_if_trns) Removed.
1710 (process_if_trns_proc) Removed.
1711 (process_if_trns_free) Removed.
1713 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1715 Continue reforming procedure execution. In this phase, add
1716 `const' to the case passed to procedure()'s callback.
1718 Updated all users of procedure() as well.
1720 * procedure.c: (struct write_case_data) Add "const" to ccase
1721 parameter for case_func member.
1722 (procedure) Add "const" to ccase parameter for proc_func
1724 (multipass_case_func) Make ccase parameter const.
1725 (internal_procedure) Add "const" to ccase parameter for case_func
1727 (split_procedure_case_func) Make ccase parameter const.
1728 (multipass_split_case_func) Make ccase parameter const.
1730 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1732 Continue reforming procedure execution. In this phase, get rid of
1733 the output code for SPLIT FILE groups in procedure.c, which really
1734 shouldn't be doing any output. Move it into the individual
1735 procedures instead. This also adds some flexibility.
1737 Updated many users of procedure_with_splits() and
1738 multipass_procedure_with_splits() to call
1739 output_split_file_values() and to deal with increased use of
1742 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1743 parameter to begin_func member.
1744 (procedure_with_splits) Add "const struct ccase *" parameter to
1745 begin_func parameter. Make ccase parameter const in proc_func
1747 (split_procedure_case_func) Don't dump split file group. Pass
1749 (dump_splits) Moved to language/dictionary/split-file.c as
1750 output_split_file_values().
1751 (struct multipass_split_aux_data) Add "const struct ccase *"
1752 parameter to split_func member.
1753 (multipass_procedure_with_splits) Add "const struct ccase *"
1754 parameter to split_func parameter.
1755 (multipass_split_case_func) Save new SPLIT FILE case before
1757 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1759 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1761 Continue reforming procedure execution. Change
1762 internal_procedure() so that it calls open_active_file() and
1763 close_active_file(), which isolates most of the actual procedure
1766 * procedure.c: (struct write_case_data) Rename `proc_func' member
1767 to `case_func' and update all references.
1768 (procedure) Rewrite as one-line wrapper around
1769 internal_procedure().
1770 (struct multipass_aux_data) New.
1771 (multipass_callback) Renamed multipass_case_func(). Use struct
1772 multipass_aux_data as auxiliary data.
1773 (multipass_end_func) New function.
1774 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1775 that uses multipass_case_func, multipass_end_func.
1776 (internal_procedure) Add `end_func' argument. Move optimization
1777 of trivial case in here. Move call to open_active_file() and
1778 close_active_file() in here. Now assert that vfm_source is
1780 (procedure_with_splits_callback) Rename
1781 split_procedure_case_func().
1782 (split_procedure_end_func) New function.
1783 (multipass_split_callback) Rename multipass_split_case_func.
1784 (multipass_split_end_func) New function.
1785 (discard_variables) No need to test for nonnull vfm_source.
1787 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1789 Continue reforming procedure execution. Get rid of unused member.
1791 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1793 (write_case) Don't increment cases_analyzed.
1795 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1797 Continue reforming procedure execution. In this phase, move
1798 procedure.c and procedure.h from src to src/data. Update
1799 makefiles and #includes accordingly.
1801 * procedure.c: Moved here from src/.
1803 * procedure.h: Moved here from src/.
1805 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1807 Continue reforming procedure execution. In this phase, get rid of
1808 many global variables, consolidating procedure execution in
1809 procedure.c. Encapsulate transformations in new "struct
1810 trns_chain". Also, change implementation of N OF CASES, FILTER,
1811 and PROCESS IF from special cases to transformations.
1813 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1816 * dictionary.c: (global variable default_dict) Move to
1819 * variable.h: (TRNS_*) Move to transformations.h.
1820 (struct transformation) Move to transformations.c.
1822 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1824 * sys-file-reader.c: Fixed invalid read problems.
1826 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1828 * storage-stream.c: Add missing function comments.
1830 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1832 Continue reforming procedure execution. In this phase, add some
1833 new, needed functionality to storage-stream.
1835 * storage-stream.c: (storage_source_decapsulate) New function.
1837 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1839 * variable.c (width_to_bytes): Declarations must precede
1840 statements for C90 compliance.
1842 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1844 * data-out.c, data-in.c, variable.c, variable.h: New functions
1845 copy_mangle and copy_demangle for reading/writing cases; emulates the
1846 way SPSS deals with strings > 255 bytes.
1848 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1849 subtype 14 needed for strings longer than 255 bytes.
1851 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1852 instead of literal values. Also fixed some constness issues.
1854 * format.h: Constness
1856 * sfm-private.h: Renamed the case_size identifier, since I discovered
1857 that SPSS's respect for this variable is very nominal.
1859 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1861 Change case limit type from int to size_t.
1863 * dictionary.c: (struct dictionary) Change type of case_limit
1865 (dict_get_case_limit) Change return type.
1866 (dict_set_case_limit) Change parameter type.
1868 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1870 * variable.h: (struct variable) Rename `reinit' member as `leave'
1871 and invert sense. Fix up all references.
1873 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1875 Continue reforming procedure execution. In this phase, break
1876 procedure.c into multiple files.
1878 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1880 * case-sink.c: New file.
1882 * case-sink.h: New file.
1884 * case-source.c: New file.
1886 * case-source.h: New file.
1888 * storage-stream.c: New file.
1890 * storage-stream.h: New file.
1892 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1894 * variable.h: (struct variable) Remove `init' member and all
1895 references to it from other files. It was initialized in several
1896 places, but nothing really ever used it for anything worthwhile.
1897 Thanks to Jason Stover for pointing out how confusing this
1900 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1902 Continue reforming error message support. In this phase, get rid
1903 of message "titles" and put the message text in `struct error'.
1904 Now `struct error' encapsulates a message more properly.
1906 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1907 Format message ourselves.
1909 * data-in.c: (vdls_error) Ditto.
1911 * por-file-reader.c: (error) Ditto.
1913 * sys-file-reader.c: (corrupt_msg) Ditto.
1915 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1917 GNU standards require "file name" instead of "filename" in
1918 documentation. It's nice for our code to follow the convention
1921 * casefile.c: (struct casefile) Rename `filename' member to
1922 `file_name'. Updated all references.
1924 * file-name.c: [!unix] (struct file_identity) Rename
1925 normalized_filename member to normalized_file_name. Updated all
1928 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1930 We don't really support anything but Unix-like environments well,
1931 so we might as well de-obfuscate by writing directory and path
1932 separators explicitly.
1934 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1936 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1937 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1939 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1942 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1944 GNU standards require "file name" instead of "filename" in
1945 documentation. It's nice for our code to follow the convention
1948 * filename.c: Rename to file-name.c.
1950 * filename.h: Rename to file-name.h. Update all inclusions.
1951 Update header guards.
1953 * automake.mk: Update file names.
1955 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1957 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1959 (fn_basename) Removed (dead code).
1960 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1961 (fn_special_p) Renamed fn_is_special(), all references updated.
1962 (fn_exists_p) Renamed fn_exists(), all references updated.
1964 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1966 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1967 Also, now it only tilde-expands file names, not paths.
1968 (fn_search_path) Tilde-expand one directory at a time.
1970 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1972 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1973 get rid of non-Unixlike version of the code, which has probably
1975 (fn_prepend_dir) Removed (dead code).
1977 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1978 (macro PATH_SEPARATOR_STRING) New.
1979 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1981 Continue reforming error message support. In this phase, we get
1982 rid of VM() and the other msg() support for "verbosity", replacing
1983 it by a new function verbose_msg().
1985 * filename.c: (fn_search_path) Use verbose_msg() instead of
1988 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1990 * sfm-private.h: Get rid of #defines after #error, which makes no
1993 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1995 Get rid of our own int32 type in favor of the standard int32_t
1998 * sfm-private.h: (int32 macro) Don't define this anymore. Do
2001 * sys-file-reader.c: Use int32_t instead of int32 throughout.
2003 * sys-file-writer.c: Use int32_t instead of int32 throughout.
2005 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
2007 Remove ill-considered file routines that are no longer used.
2009 * filename.c: (fn_open_ext) Removed.
2010 (fn_close_ext) Removed.
2012 * filename.h: (struct file_ext) Removed.
2014 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
2016 * variable.c (var_is_valid_name): Move declarations before code
2019 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
2021 * filename.ch (fn_interp_vars): Fixed small buglet.
2023 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
2025 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
2026 so as to modify the string inline. Thus makeing it easier to
2027 destroy the results when no longer needed.
2029 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
2031 * category.c (cat_stored_values_destroy): Fixed memory leak.
2033 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
2035 Add some missing frees. Thanks to John Darrington for reporting
2038 * any-writer.c (any_writer_close): Free writer.
2040 * any-reader.c (any_reader_close): Free reader.
2042 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
2044 * por-file-reader.c: (error) Mark as NO_RETURN.
2046 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
2048 * settings.c: Changed default value of scompress to true.
2050 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
2052 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
2054 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
2057 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
2058 here from pref.h.orig.
2060 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
2062 * sys-file-reader.c: Fixed bug reading compressed files.
2064 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
2066 * Numerous renames. See src/ChangeLog for details.
2068 * Moved files from src directory