1 2007-06-02 Ben Pfaff <blp@gnu.org>
3 Clean up after a forgotten part of patch #5829.
5 * casedeque.h: Remove unused file.
7 * automake.mk: Remove casedeque.h from sources.
9 2007-05-10 Jason Stover <jhs@math.gcsu.edu>
11 * category.c: Removed redundant #include
13 2007-05-06 Ben Pfaff <blp@gnu.org>
15 Abstract the documents within a dictionary a little better.
16 Thanks to John Darrington for suggestion, initial version, and
19 * dictionary.c (struct dictionary): Change `documents' member from
20 char * to struct string.
21 (dict_clear): Destroy struct string.
22 (dict_get_documents): Convert struct string to char *.
23 (dict_set_documents): Set struct string. Pad to 80-character
25 (dict_clear_documents): New function.
26 (dict_add_document_line): New function.
27 (dict_get_document_line_cnt): New function.
28 (dict_get_document_line): New function.
30 * dictionary.h (macro DOC_LINE_LENGTH): New macro.
32 * sys-file-reader.c (read_documents): Use new document functions.
34 2007-04-19 John Darrington <john@darrington.wattle.id.au>
36 * sys-file-reader.c: When reading a system file which has no
37 long name table, automatically create one where the long names
38 are the lower case versions of the short names.
40 2007-04-22 Ben Pfaff <blp@gnu.org>
42 * dictionary.c (dict_set_split_vars): dict_destroy expects that
43 dict_clear will free most data related to the dictionary.
44 dict_clear does a decent job, except that dict_set_split_vars on
45 some systems won't actually free the dict's "split" member.
46 Instead, it'll allocate a 1-byte region. Fix this.
48 * value.c (value_copy): New function.
49 (value_set_missing): Ditto.
51 2007-04-22 John Darrington <john@darrington.wattle.id.au>
53 * Deleted existing category.h and moved cat-routines.h into
54 category.h Encapsulated struct cat_vals better.
56 2007-04-19 John Darrington <john@darrington.wattle.id.au>
58 * sys-file-reader.c: When reading a system file which has no
59 long name table, automatically create one where the long names
60 are the lower case versions of the short names.
62 2007-04-16 John Darrington <john@darrington.wattle.id.au>
64 * sys-file-reader.c: Some versions of Other Software seem to
65 produce system files with string variables' measure set to
66 zero. We'll assume these are supposed to be nominal variables.
68 2007-03-30 Ben Pfaff <blp@gnu.org>
70 * procedure.c: Adapt to new deque data structure.
72 Mon Feb 19 10:53:21 2007 John McCabe-Dansted <gmatht@gmail.com>
73 Ben Pfaff <blp@gnu.org>
75 * file-name.c: Mingw compatibility fixes.
76 (fn_search_path): Use ISSLASH instead of comparing against '/'
78 (fn_dir_name): Use dir_name from gnulib.
79 (fn_is_absolute): Use IS_ABSOLUTE_FILE_NAME from gnulib.
80 (fn_get_identity): Use GetFullPathName instead of canonicalize
81 from gnulib, because the latter does not fully support
82 Windows-style path names. Use this implementation based on the
83 detected presence of Windows instead of the absence of Unix, since
84 the new implementation is Windows-specific.
85 (fn_compare_file_identities): In Windows implementation, compare
86 names case-insensitively.
88 Sun Feb 18 13:28:02 2007 Ben Pfaff <blp@gnu.org>
90 * make-file.c: Don't include mkstemp.h, because gnulib now causes
91 <stdlib.h> to have the same effect.
93 Sun Feb 18 11:20:24 2007 Ben Pfaff <blp@gnu.org>
95 * por-file-reader.c: Add missing _() around messages.
97 Sun Feb 11 20:44:13 2007 Ben Pfaff <blp@gnu.org>
99 * make-file.c: Include "mkstemp.h", without which linking on
102 Thu Feb 8 14:59:05 2007 Ben Pfaff <blp@gnu.org>
104 Reduce platform dependence.
106 * file-name.c (fn_tilde_expand): Removed, and removed calls to it.
107 Everywhere we using this, we really should have just depended on
108 the shell to expand tildes.
109 (fn_search_path): Simplify, given that we don't do tilde expansion
111 (fn_normalize): Removed. Caller changed to use the canonicalize
113 (fn_get_cwd): Removed. Only user was fn_normalize.
114 (fn_is_absolute): Really only test for absolute names.
115 (fn_is_special): Use pipe files if HAVE_POPEN, not if we're in
117 (fn_readlink): Removed, as it was only used fn_normalize.
118 (fn_exists): Assume the stat function is available; gnulib does.
119 (fn_open): Use pipe files if HAVE_POPEN, not if we're in unix.
121 Sat Feb 3 21:52:17 2007 Ben Pfaff <blp@gnu.org>
123 * dictionary.c (dict_create_vector_assert): New function.
125 Wed Feb 7 21:25:15 2007 Ben Pfaff <blp@gnu.org>
127 * file-name.c (fn_normalize): Correct name of function
128 fn_is_special. Thanks to John McCabe-Dansted <gmatht@gmail.com>
129 for pointing this out.
131 Thu Feb 1 16:53:37 2007 Ben Pfaff <blp@gnu.org>
133 We are using a single member in struct file_handle, the "name"
134 field, for more than one purpose. When it begins with '"', it's a
135 file name; otherwise, it's a token that can be used to identify
136 it. When that assertion fires, it's because we searched for the
137 name case-sensitively as a file name (so that there was no match),
138 and then we try to insert it case-insensitively as a token, which
139 fails because duplicates aren't allowed.
141 Solution: break the two purposes into two separate fields. This
142 fixes the problem and likely makes the code easier to read too.
144 Fixes bug #18922. Thanks to John Darrington for bug report and
147 * file-handle-def.c (struct file_handle): New `id' member.
148 (fh_from_name): Rename fh_from_id. Update all callers.
149 (create_handle): New `id' parameter. Update all callers.
150 (fh_create_file): Ditto.
151 (fh_get_id): New function.
153 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
155 * case.c (case_is_null): Change return type to bool.
157 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
161 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
162 reference counting to share data. This makes it easy for
163 valgrind, etc. to find accesses to cases that have been destroyed
164 but have been kept around by another user's ref-count. This often
165 happens when the data set is small enough to find in memory; if a
166 bigger data set that would overflow to disk were used, then data
167 corruption would occur.
169 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
173 * case.c (case_unshare): Make it check internally whether the
174 ref_cnt is greater than 1, so that the callers don't have to.
175 Update callers not to check.
177 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
179 Before, I was thinking that I might want to get rid of reference
180 counting at some point. Now, I'm pretty sure that it's here to
181 stay. Thus, because we have to store the value_cnt anyway for
182 reference-counted cases, we might as well expose it to users.
184 * case.c (case_get_value_cnt): New function.
185 (case_resize): Drop OLD_CNT argument. Update all callers. Only
186 resize case if its size actually changed.
188 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
189 instead of peeking inside struct case directly.
190 (casefile_append): Ditto.
192 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
194 Get rid of the inlines for the case functions, which made the
195 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
196 the inlines didn't speed up "make check" at all, which is not a
197 perfect benchmark but seems indicative.)
199 * case.c: Remove #ifdef DEBUGGING...#endif around many function
200 definitions. Remove some assertions on nonnull pointers that were
201 redundant with a pointer dereference soon after in the function.
203 (struct case_data): Move definition here from case.h.
207 (case_data_wr): Ditto.
209 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
211 * automake.mk: Add casedeque.h to sources.
213 * casedeque.h: New file.
215 * procedure.c: (struct dataset) Change lag_count, lag_head,
216 lag_queue member into single struct casedeque member. Update all
217 users to use the casedeque instead.
220 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
222 * procedure.c: Simplify lagged cases interface. Updated all
223 clients--well, the only client--to use the simplified interface.
224 (dataset_n_lag) Removed.
225 (dataset_set_n_lag) Removed.
226 (dataset_need_lag) New function.
228 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
230 * dictionary.c procedure.c: More changes to ensure that callbacks occur
231 whenever appropriate, but only when the dataset/dictionary is in a
234 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
236 * dictionary.c dictionary.h : Added callbacks for change of filter and
237 split variables. Refactored some code to ensure that callbacks get
238 invoked when appropriate.
240 * procedure.c (proc_cancel_temporary_transformations): Make sure that
241 replace_dict callback occurs when permanent_dict replaces the current
244 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
246 * dictionary.c dictionary.h : Added callback for when the weight
247 variable of a dictionary changes.
249 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
251 * dictionary.c dictionary.h : Added replace_source and replace_dict
252 callbacks, and functions to deal with them.
254 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
256 Simplify missing value handling.
258 * missing-values.h (enum mv_class): New type.
259 (enum mv_type): Moved definition into missing-values.c and renamed
260 each MV_* to MVT_*, to distinguish them from the exposed mv_class
261 enums. Updated all uses.
262 (struct missing_values): Changed type of `type' from `enum
263 mv_type' to `int' because the definition is no longer exposed.
265 * missing-values.c (mv_is_value_missing): Add new enum mv_class
266 parameter. Update all callers.
267 (mv_is_num_missing): Ditto.
268 (mv_is_str_missing): Ditto.
269 (mv_is_value_user_missing): Removed. Changed callers to use
271 (mv_is_num_user_missing): Removed. Changed callers to use
273 (mv_is_str_user_missing): Removed. Changed callers to use
275 (mv_is_value_system_missing): Removed. Changed callers to use
277 (mv_set_type): Removed. Changed callers to use mv_clear.
278 (mv_clear): New function.
280 * variable.c (var_is_value_missing): Add new enum mv_class
281 parameter. Update all callers.
282 (var_is_num_missing): Ditto.
283 (var_is_str_missing): Ditto.
284 (var_is_value_user_missing): Removed. Changed callers to use
285 var_is_value_missing.
286 (var_is_num_user_missing): Removed. Changed callers to use
288 (var_is_str_user_missing): Removed. Changed callers to use
290 (var_is_value_system_missing): Removed. Changed callers to use
291 var_is_value_missing.
293 * casefilter.c (struct casefilter): Use enum mv_class in place of
295 (casefilter_variable_missing): Adapt to new member.
296 (casefilter_create): Change signature to take enum mv_class,
299 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
301 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
303 * case-sink.c case-sink.h procedure.c procedure.h
304 storage-stream.c: Now uses the factory.
306 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
308 Make it possible to pull cases from the active file with a
309 function call, instead of requiring indirection through a callback
312 * case-source.h (struct case_source_class): Change ->read function
313 to return a single case, instead of calling a callback function
314 for each case. Change ->destroy function to return an error
317 * case-source.c (free_case_source): Pass along the value returned
318 by the case_source ->destroy function.
320 * procedure.c (struct write_case_data): Removed.
321 (struct dataset): Added some members to track procedure state.
322 (procedure): Optimize the trivial case at this level.
323 (internal_procedure): Re-implement in terms of proc_open,
324 proc_read, proc_close.
325 (proc_open) New function.
326 (proc_read) New function.
327 (proc_close) New function.
328 (write_case) Moved into proc_read.
329 (close_active_file) Moved closing of data source into proc_close.
331 * storage-source.c: Rewrote to conform with modified
332 case_source_class interface.
334 * transformations.c (trns_chain_execute): Added argument to allow
335 starting execution from an arbitrary transformation. Updated
338 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
340 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
342 * sys-file-reader.c (read_display_parameters): Don't assume that
343 MEASURE_* and ALIGN_* have the same values found in system files.
345 * sys-file-writer.c (write_variable_display_parameters): Ditto.
347 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
348 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
349 the value of n_MEASURES, which was off by 1 (at least from my
352 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
354 * dictionary.c dictionary.h vardict.h variable.c: Added optional
355 callbacks which are invoked when the dictionary or its
356 variables are changed.
358 * missing-values.c missing-values.h value-labels.c: Tidied up
359 consistency checks, and made some of them return false
360 instead of assert-failing.
362 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
364 * calendar.c (calendar_days_in_month): New function.
366 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
368 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
369 the value label's width.
371 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
373 * sfm-private.h: Move contents into sys-file-writer.c, which is
374 the only remaining user. Removed Borland C++-specific directives.
376 * sys-file-reader.c: Clean up and rewrite entire file. The
377 rewritten version is simpler and better abstracted, and should be
378 easier to maintain and extend. It avoids using structures to read
379 file data, which is prone to padding variations among compilers.
380 It should also handle non-IEEE 754 system files, although I
381 haven't been able to find any. It has been tested against many
382 .sav files obtained from the Web and found to produce the same
383 results as the earlier version of the code, or in some cases
384 improved results. It is more tolerant of format variations found
387 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
388 member, putting an enum integer_format in its place. New member
389 `float_format'. Changed `compressed' member to type bool.
391 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
393 * dictionary.c (dict_delete_consecutive_vars): New function.
395 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
397 * file-name.c (fn_search_path): Remove prefix arg that was unused
398 by any caller. Updated all callers.
400 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
402 * format.c (fmt_dollar_template): Use user's decimal point
403 character. Add assertion.
405 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
407 * format.c (fmt_dollar_template): New function, based on
408 dollar_format_template from var-type-dialog.c.
410 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
412 * data-out.c (output_scientific): Fix bad assumption that "buf" is
415 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
417 Finish converting struct variable to an opaque type. In this
418 phase, we add remaining setter and getter functions, convert the
419 remaining PSPP code to use them, and do a bunch of cleanup. The
420 resulting changes are pervasive but mostly trivial, and only the
421 notable changes are logged.
423 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
426 * case.c (case_data): Renamed case_data_idx.
427 (case_num): Renamed case_num_idx.
428 (case_str): Renamed case_str_idx.
429 (case_data_rw): Renamed case_data_rw_idx.
431 * case.h (case_data): New function with old name and an interface
432 that takes a variable instead of an index, which is easier to
433 use. Updated all callers to use the new interface, or to use the
434 new *_idx function (see above).
437 (case_data_rw): Ditto.
439 * category.c (cat_stored_values_destroy): Changed interface to
440 take a struct cat_vals * instead of a struct variable *.
442 * dictionary.c (dict_clone): Use new vector_clone function.
443 (dict_clear) Use new var_destroy function.
444 (add_var) New function.
445 (dict_create_var) Rewrite in terms of dict_create_var_assert.
446 (dict_create_var_assert) Rewrite in terms of add_var.
447 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
448 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
449 (dict_lookup_var) Use new var_create, var_destroy functions.
450 (dict_contains_var) Rewrite in terms of new vardict functionality.
451 (set_var_dict_index) New function.
452 (set_var_case_index) New function.
453 (reindex_vars) New function.
454 (dict_delete_var) Rewrite in terms of new vardict functionality.
455 (dict_reorder_var) Ditto.
456 (dict_reorder_vars) Ditto.
457 (rename_var) New function.
458 (dict_rename_var) Use rename_var.
459 (dict_rename_vars) Use pool to simplify code. Use rename_var.
460 (dict_get_compacted_idx_to_fv) Rename
461 dict_get_compacted_dict_index_to_case_index, update callers.
462 (dict_create_vector) Use new vector_create function.
463 (dict_clear_vectors) Use new vector_destroy function.
464 (set_var_short_name_suffix) Move here from variable.c, renamed
465 from var_set_short_name_suffix, make static, update caller.
467 * sys-file-private.c: New file.
468 (sfm_width_to_bytes) Moved here from variable.c, renamed from
469 width_to_bytes, update callers.
471 * sys-file-private.h: New file. Later it will supplant
472 sfm-private.h; for now it supplements it.
473 (macro MIN_VERY_LONG_STRING) New macro.
474 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
476 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
477 MAX_LONG_STRING was used before.
479 * sys-file-writer.c: Ditto.
481 * value-labels.c: Change the paradigm here to be that a null
482 pointer is OK for a struct val_labs * in most cases; it just
483 represents an empty set of value labels.
484 (val_labs_copy) A copy of a null set is a null set.
485 (val_labs_count) A null set has 0 labels.
486 (val_labs_replace) Change return type to void. Rewrite for
488 (val_labs_find) A null set does not contain the value.
489 (value_to_string) Moved to variable.c, renamed var_get_value_name,
490 transposed argument order, updated all callers.
493 (value_dup) Moved here from variable.c.
494 (compare_values) Ditto.
497 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
498 (macro MAX_LONG_STRING) Removed, because it was only interesting
499 for system files, not for general code.
500 (macro MAX_VERY_LONG_STRING) Ditto.
501 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
502 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
504 * vardict.h: New file, for an interface between variables and
507 * variable.c: A lot of functions were moved around, for better
509 (struct variable) Move definition here, from variable.h.
510 (var_type_adj) Removed--makes i18n hard.
511 (var_type_noun) Ditto.
512 (var_create) New function.
513 (var_clone) New function.
514 (var_destroy) New function.
515 (var_set_name) Assert that variable is not in a dictionary.
516 (compare_var_names) Rename compare_vars_by_name and fix a couple
517 of callers who thought the args were strings.
518 (hash_var_name) Rename hash_var_by_name.
519 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
520 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
521 (var_is_very_long_string) Removed, because it was only interesting
523 (var_set_missing_values) Allow the argument to be the wrong width,
524 as long as we can resize it. Simplify callers who were doing the
526 (var_get_value_labels) New function.
527 (var_has_value_labels) New function.
528 (var_set_value_labels) New function.
529 (alloc_value_labels) New function.
530 (var_add_value_label) New function.
531 (var_replace_value_label) New function.
532 (var_clear_value_labels) New function.
533 (var_lookup_value_label) New function.
534 (var_get_value_name) Moved here from variable.c, renamed from
535 var_get_value_name, transposed argument order, updated all
537 (var_to_string) Moved here, from variable-label.c.
538 (var_set_leave) New function.
539 (var_get_leave) New function.
540 (var_must_leave) New function.
541 (var_set_short_name_suffix) Moved to dictionary.c, renamed
542 set_var_short_name_suffix.
543 (var_get_dict_index) New function.
544 (var_get_case_index) New function.
545 (var_get_obs_vals) New function.
546 (var_set_obs_vals) New function.
547 (var_has_obs_vals) New function.
548 (var_get_vardict) New function.
549 (var_set_vardict) New function.
550 (var_has_vardict) New function.
551 (var_clear_vardict) New function.
552 (value_dup) Moved to value.c.
553 (compare_values) Ditto.
556 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
557 (enum ALPHA) Rename VAR_STRING, update all users.
559 * vector.c: New file.
560 (struct vector) Moved here, from variable.h.
561 (check_widths) New function.
562 (vector_create) New function.
563 (vector_clone) New function.
564 (vector_destroy) New function.
565 (vector_get_name) New function.
566 (vector_get_var) New function.
567 (vector_get_var_cnt) New function.
568 (compare_vector_ptrs_by_name) New function.
570 * vector.h: New file.
572 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
574 * casefilter.c (casefilter_variable_missing): Avoided comparision of
575 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
578 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
580 * value-labels.c (destroy_atoms): New function.
581 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
583 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
585 Thanks to Jason Stover for pointing out this problem.
587 * data-out.c (output_number): Use gsl_finite from GSL, which is
588 portable, instead of isfinite, which is not.
591 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
593 * variable.c variable.h (value_dup): New function.
595 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
597 Start converting struct variable to an opaque type. In this
598 phase, we add a bunch of setter and getter functions and convert
599 most of the PSPP code to use them. The resulting changes are
600 pervasive but mostly trivial, and only the notable changes are
603 * format.c (fmt_equal): New function.
605 * variable.c (var_type_is_valid): New function.
606 (measure_is_valid) Moved here, from format.c.
607 (alignment_is_valid) Moved here, from format.c.
608 (var_get_name) New function.
609 (var_set_name) New function.
610 (width_to_type) New function.
611 (var_get_type) New function.
612 (var_get_width) New function.
613 (var_set_width) New function.
614 (var_is_numeric) New function.
615 (var_is_alpha) New function.
616 (var_is_short_string) New function.
617 (var_is_long_string) New function.
618 (var_is_very_long_string) New function.
619 (var_get_missing_values) New function.
620 (var_set_missing_values) New function.
621 (var_clear_missing_values) New function.
622 (var_has_missing_values) New function.
623 (var_is_value_missing) New function.
624 (var_is_num_missing) New function.
625 (var_is_str_missing) New function.
626 (var_is_value_user_missing) New function.
627 (var_is_num_user_missing) New function.
628 (var_is_str_user_missing) New function.
629 (var_is_value_system_missing) New function.
630 (var_get_print_format) New function.
631 (var_set_print_format) New function.
632 (var_get_write_format) New function.
633 (var_set_write_format) New function.
634 (var_set_both_formats) New function.
635 (var_get_label) New function.
636 (var_set_label) New function.
637 (var_clear_label) New function.
638 (var_has_label) New function.
639 (var_get_measure) New function.
640 (var_set_measure) New function.
641 (var_get_display_width) New function.
642 (var_set_display_width) New function.
643 (var_get_alignment) New function.
644 (var_set_alignment) New function.
645 (var_get_value_cnt) New function.
646 (var_get_leave) New function.
647 (var_get_short_name) New function.
649 * variable.h: (struct variable) Removed "type" and "nv" members;
650 they are now computed from "width" where needed.
652 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
654 * missing-values.c (mv_resize): Don't write beyond end of the
655 allocated buffer when resizing a long string.
657 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
659 Clean up identifier code: don't require identifier enumerations to
660 be in a particular order; make better use of string library;
661 expose less of the internals.
663 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
664 change interface. Updated all callers.
665 (lex_id_match) Change interface to use struct substring, update
667 (lex_id_match_len) Removed. Update callers to use lex_id_match.
668 (global array keywords[]) Make static, change form. Update all
669 users to use lex_id_name instead.
670 (lex_is_keyword) New function.
671 (lex_id_to_token) Change interface to use struct substring, update
673 (lex_id_name) New function.
675 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
676 lex_is_keyword instead.
677 (T_LAST_KEYWORD) Removed.
678 (T_N_KEYWORDS) Removed.
680 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
682 * format.c: (fmt_date_template) Distinguish characters for which a
683 space is output and any date delimiter is allowed on input, from
684 those for which a space is output and only a space is allowed on
685 input. The former is represented by X, the latter by a space.
686 Also, drop distinction between h and H, changing the former to the
689 * data-in.c: Completely rewrite internals to conform to SPSS input
690 formats as closely as possible.
691 (data_in) Changed external interface by replacing the structure
692 that was used as a single argument by a set of arguments. Updated
694 (data_in_finite_line) Removed. Converted all callers to use plain
696 (data_in_get_integer_format) New function.
697 (data_in_set_integer_format) New function.
698 (data_in_get_float_format) New function.
699 (data_in_set_float_format) New function.
701 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
702 (struct data_in) Removed.
704 * data-out.c: (output_date) Drop each component from the input as
705 it is output, to allow us to drop the distinction between h (a
706 count of hours) and H (the hour of day) template characters.
707 Also, handle new X template character.
708 (output_scientific) Follow more rational rule on when to drop
709 fraction introduced between SPSS 13 and 15. Updated test case to
712 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
714 Fix buffer overflow reported by John Darrington.
716 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
717 realize that DIGITS is a count of nibbles, not of bytes.
719 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
721 * calendar.c (calendar_offset_to_gregorian) Also return the
722 year-of-day. Change callers to new interface.
724 * data-out.c: Completely rewrite internals to conform to SPSS
725 output formats as completely as possible.
726 (data_out) Change interface to put input parameters before output
727 parameters, for consistency with the style I now prefer. Update
729 (data_out_get_integer_format) New public function.
730 (data_out_set_integer_format) New public function.
731 (data_out_get_float_format) New public function.
732 (data_out_set_float_format) New public function.
734 * data-out.h: New file. Move prototype for data_out here, from
737 * format.c: (fmt_step_width) Use equality comparison instead of
738 bitwise and, for clarity.
739 (fmt_is_string) Ditto.
740 (fmt_input_to_output) Fix categories that are translated to F
743 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
745 * casefilter.c casefilter.h (new files), casefile.c casefile.h
746 casefile-private.h: Added casefilter to assist commands with missing
749 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
751 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
753 * settings.c: (route_errors_to_terminal) New variable.
754 (route_errors_to_listing) New variable.
755 (get_error_routing_to_terminal) New function.
756 (set_error_routing_to_terminal) New function.
757 (get_error_routing_to_listing) New function.
758 (set_error_routing_to_listing) New function.
760 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
762 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
764 * format.c: Completely rewrite, to achieve better abstraction.
765 Rewrite all references to formats in other files.
767 * format.def: Rewrite and reorganize.
769 * settings.c: Move everything related to custom currency formats
770 into format.[ch], changing them in form, so as to group related
771 code and definitions better. Changed all references to use the
773 (static var decimal) Removed.
774 (static var grouping) Removed.
775 (static var cc) Removed.
776 (get_decimal) Removed.
777 (set_decimal) Removed.
778 (get_grouping) Removed.
779 (set_grouping) Removed.
783 * settings.h: (macro CC_CNT) Removed.
784 (macro CC_WIDTH) Removed.
785 (struct custom_currency) Removed.
787 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
789 * data-in.c (data_in): Use switch statement instead of table, to
790 avoid dependence on the order of the FMT_* enums.
792 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
794 * data-out.c: (num_to_string) Removed, because it was dead code.
796 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
798 * data-in.c (parse_trailer): Fix error message.
800 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
802 * format.c (fmt_is_binary): New function.
804 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
806 * procedure.c procedure.h: Encapsulated the static data into a single
809 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
811 * casefile.c (casereader_read_xfer): Always initialize the case,
812 even on an error condition.
814 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
816 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
817 entire function useless.
819 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
821 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
822 casereader method casereader_clone.
824 * procedure.c pransformations.h: Introduced new type casenum_t
826 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
828 * variable.c: (width_to_bytes) Rephrase code for clarify.
830 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
832 * format.c: (fmt_type_from_string) New function.
833 (fmt_to_string) Include decimals in output if the format has
834 decimals, even if the format type does not. This way, we can
835 accurately reproduce incorrect formats in user output.
836 (check_common_specifier) Make the check for a bad format type an
837 assertion, so we get bug reports if they show up. Fix message.
838 Check for decimal places with a format type that doesn't allow
840 (check_input_specifier) Remove check for FMT_X, which has been
842 (check_output_specifier) Ditto.
844 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
846 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
847 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
848 (enum fmt_parse_flags) Removed.
850 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
852 * casefile.c casefile.h: Converted to an abstract base class.
853 * casefile-private.h fastfile.c fastfile.h: New files.
854 * automake.mk procedure.c scratch-writer.c storage-stream.c
856 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
858 * procedure.c (internal_procedure): Create sink_case with only as
859 many values as the compacted dictionary.
861 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
863 Remove "debugging" code that caused plenty of false positives and
866 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
868 * case.c: Remove all references to `this' member.
870 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
872 Fix link error noted by Jason Stover.
874 * storage-stream.c: Include <assert.h>.
876 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
878 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
879 ALL) and additional underlying system file issues.
881 Thanks to John Darrington for review.
883 First problem: var_hash points to variables not owned by the
884 sys-file-reader, which the caller may free or modify. Use an
885 array of sfm_vars instead, as done earlier (e.g. CVS version
888 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
889 members and remove all code that references it. Add vars, var_cnt
890 members. Remove fix_specials member, which was unused.
891 (struct sfm_var) Remove name member, which was unused.
892 (sfm_close_reader) Free vars member instead of var_hash.
893 (compare_var_shortnames) Removed.
894 (hash_var_shortname) Removed.
895 (sfm_open_reader) Fill out vars array.
896 (compare_var_index) Removed.
897 (sfm_read_case) Use vars instead of var_hash.
899 Second problem: we're confused about when we actually have very
900 long strings, causing us to choose incorrectly between slow path
901 and fast path in sfm_read_case.
903 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
904 have very long strings, not when we have long variable names,
905 which is an unrelated feature.
907 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
909 * variable.h: Move var_set and variable parsing declarations to
910 new header, src/language/lexer/variable-parser.h. Modified lots
911 of files to include the new header.
913 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
915 * value-labels.c (value_to_string): When there's no value label,
916 format the variable according to its print format, instead of
917 always effectively using A or F format.
919 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
921 * casefile.c (casefile_get_random_reader): Nasty hack to get around
924 * format.c: Removed tortological assertion.
926 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
928 Reform string library.
930 * file-name.c (fn_interp_vars): Change interface to take a
931 substring as input. Updated all users.
933 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
935 * format.c (measure_is_valid): Really return false when m >=
938 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
940 Implement random access to casefiles, for use in GUI.
942 * casefile.c: (struct casereader) Add `random', `file_ofs',
943 `buffer_ofs' members.
944 (casefile_get_random_reader) New function.
945 (read_open_file) Break part into new function
946 seek_and_fill_buffer().
947 (fill_buffer) Update buffer_ofs, file_ofs.
948 (casereader_seek) New function.
950 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
952 * settings.c: Added call to i18n{done, init}.
954 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
956 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
959 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
961 * casefile.c: Convert many uses of `int' to `bool'.
963 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
965 * transformations.c (trns_chain_destroy): Destroy chain's trns
966 member, to fix memory leak.
968 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
970 * storage-stream.c (storage_source_decapsulate): Destroy case
971 source to fix memory leak.
973 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
975 * scratch-reader.c (scratch_reader_read_case): Copy into existing
976 case passed as argument instead of initializing the argument as a
977 case. Fixes memory leak that showed up in
978 tests/command/aggregate.sh with scratch files.
980 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
982 * procedure.c (proc_done): Destroy default_dict, to fix memory
985 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
987 Simplify procedure_with_splits().
989 * procedure.c (struct split_aux_data): Removed case_count member.
990 (procedure_with_splits) Don't initialize case_count.
991 (split_procedure_case_func) Check whether prev_case is null
992 instead of case_count.
993 (split_procedure_end_func) Ditto.
995 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
997 * case.c (case_move): Do nothing if dst and src are the same
999 (case_try_create) Merge two similar cases.
1000 (case_copy) Unshare only if data must be actually copied.
1002 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1004 * data-in.c data-out.c dictionary.c sys-file-reader.c
1005 sys-file-writer.c variable.c variable.h: Reworked very long string
1006 support for better encapsulation.
1008 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
1010 * value-labels.c (val_labs_can_set_width): New function.
1011 (val_labs_set_width) Clear labels if increasing width to long
1013 (val_labs_destroy) Remove unneeded test for null.
1015 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
1017 * value-labels.h: Remove unneeded dependency on variable.h.
1019 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
1021 Get rid of `char *c' member in union value, for cleanliness.
1023 * value.h: (union value) Remove `c' member.
1025 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
1027 Make dictionary compacting functions a little more general.
1029 * sys-file-writer.c (sfm_open_writer): Use
1030 dict_compacting_would_change().
1031 (does_dict_need_translation) Removed.
1033 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
1035 Make dictionary compacting functions a little more general.
1037 * dictionary.c (dict_needs_compaction): Rename
1038 dict_compacting_would_shrink(). Update all callers.
1039 (dict_compacting_would_change) New function.
1041 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
1043 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
1044 inverted return value (!).
1046 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
1048 Continue reforming procedure execution.
1050 * procedure.c: Search and replace "vfm" by "proc". Notably:
1051 (static var vfm_source) Rename proc_source. Update all
1053 (static var vfm_sink) Rename proc_sink. Update all references.
1055 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
1057 Continue reforming procedure execution. In this phase, remove
1058 PROCESS IF, which was deprecated anyway and can be easily
1059 simulated with TEMPORARY followed by SELECT IF.
1061 * procedure.c: (open_active_file) Don't call
1062 add_process_if_trns().
1063 (discard_variables) Get rid of redundant call to
1064 proc_cancel_all_transformations().
1065 (add_process_if_trns) Removed.
1066 (process_if_trns_proc) Removed.
1067 (process_if_trns_free) Removed.
1069 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
1071 Continue reforming procedure execution. In this phase, add
1072 `const' to the case passed to procedure()'s callback.
1074 Updated all users of procedure() as well.
1076 * procedure.c: (struct write_case_data) Add "const" to ccase
1077 parameter for case_func member.
1078 (procedure) Add "const" to ccase parameter for proc_func
1080 (multipass_case_func) Make ccase parameter const.
1081 (internal_procedure) Add "const" to ccase parameter for case_func
1083 (split_procedure_case_func) Make ccase parameter const.
1084 (multipass_split_case_func) Make ccase parameter const.
1086 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
1088 Continue reforming procedure execution. In this phase, get rid of
1089 the output code for SPLIT FILE groups in procedure.c, which really
1090 shouldn't be doing any output. Move it into the individual
1091 procedures instead. This also adds some flexibility.
1093 Updated many users of procedure_with_splits() and
1094 multipass_procedure_with_splits() to call
1095 output_split_file_values() and to deal with increased use of
1098 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
1099 parameter to begin_func member.
1100 (procedure_with_splits) Add "const struct ccase *" parameter to
1101 begin_func parameter. Make ccase parameter const in proc_func
1103 (split_procedure_case_func) Don't dump split file group. Pass
1105 (dump_splits) Moved to language/dictionary/split-file.c as
1106 output_split_file_values().
1107 (struct multipass_split_aux_data) Add "const struct ccase *"
1108 parameter to split_func member.
1109 (multipass_procedure_with_splits) Add "const struct ccase *"
1110 parameter to split_func parameter.
1111 (multipass_split_case_func) Save new SPLIT FILE case before
1113 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
1115 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
1117 Continue reforming procedure execution. Change
1118 internal_procedure() so that it calls open_active_file() and
1119 close_active_file(), which isolates most of the actual procedure
1122 * procedure.c: (struct write_case_data) Rename `proc_func' member
1123 to `case_func' and update all references.
1124 (procedure) Rewrite as one-line wrapper around
1125 internal_procedure().
1126 (struct multipass_aux_data) New.
1127 (multipass_callback) Renamed multipass_case_func(). Use struct
1128 multipass_aux_data as auxiliary data.
1129 (multipass_end_func) New function.
1130 (multipass_procedure) Rewrite as wrapper for internal_procedure()
1131 that uses multipass_case_func, multipass_end_func.
1132 (internal_procedure) Add `end_func' argument. Move optimization
1133 of trivial case in here. Move call to open_active_file() and
1134 close_active_file() in here. Now assert that vfm_source is
1136 (procedure_with_splits_callback) Rename
1137 split_procedure_case_func().
1138 (split_procedure_end_func) New function.
1139 (multipass_split_callback) Rename multipass_split_case_func.
1140 (multipass_split_end_func) New function.
1141 (discard_variables) No need to test for nonnull vfm_source.
1143 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
1145 Continue reforming procedure execution. Get rid of unused member.
1147 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
1149 (write_case) Don't increment cases_analyzed.
1151 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1153 Continue reforming procedure execution. In this phase, move
1154 procedure.c and procedure.h from src to src/data. Update
1155 makefiles and #includes accordingly.
1157 * procedure.c: Moved here from src/.
1159 * procedure.h: Moved here from src/.
1161 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1163 Continue reforming procedure execution. In this phase, get rid of
1164 many global variables, consolidating procedure execution in
1165 procedure.c. Encapsulate transformations in new "struct
1166 trns_chain". Also, change implementation of N OF CASES, FILTER,
1167 and PROCESS IF from special cases to transformations.
1169 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1172 * dictionary.c: (global variable default_dict) Move to
1175 * variable.h: (TRNS_*) Move to transformations.h.
1176 (struct transformation) Move to transformations.c.
1178 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1180 * sys-file-reader.c: Fixed invalid read problems.
1182 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1184 * storage-stream.c: Add missing function comments.
1186 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1188 Continue reforming procedure execution. In this phase, add some
1189 new, needed functionality to storage-stream.
1191 * storage-stream.c: (storage_source_decapsulate) New function.
1193 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1195 * variable.c (width_to_bytes): Declarations must precede
1196 statements for C90 compliance.
1198 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1200 * data-out.c, data-in.c, variable.c, variable.h: New functions
1201 copy_mangle and copy_demangle for reading/writing cases; emulates the
1202 way SPSS deals with strings > 255 bytes.
1204 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1205 subtype 14 needed for strings longer than 255 bytes.
1207 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1208 instead of literal values. Also fixed some constness issues.
1210 * format.h: Constness
1212 * sfm-private.h: Renamed the case_size identifier, since I discovered
1213 that SPSS's respect for this variable is very nominal.
1215 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1217 Change case limit type from int to size_t.
1219 * dictionary.c: (struct dictionary) Change type of case_limit
1221 (dict_get_case_limit) Change return type.
1222 (dict_set_case_limit) Change parameter type.
1224 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1226 * variable.h: (struct variable) Rename `reinit' member as `leave'
1227 and invert sense. Fix up all references.
1229 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1231 Continue reforming procedure execution. In this phase, break
1232 procedure.c into multiple files.
1234 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1236 * case-sink.c: New file.
1238 * case-sink.h: New file.
1240 * case-source.c: New file.
1242 * case-source.h: New file.
1244 * storage-stream.c: New file.
1246 * storage-stream.h: New file.
1248 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1250 * variable.h: (struct variable) Remove `init' member and all
1251 references to it from other files. It was initialized in several
1252 places, but nothing really ever used it for anything worthwhile.
1253 Thanks to Jason Stover for pointing out how confusing this
1256 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1258 Continue reforming error message support. In this phase, get rid
1259 of message "titles" and put the message text in `struct error'.
1260 Now `struct error' encapsulates a message more properly.
1262 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1263 Format message ourselves.
1265 * data-in.c: (vdls_error) Ditto.
1267 * por-file-reader.c: (error) Ditto.
1269 * sys-file-reader.c: (corrupt_msg) Ditto.
1271 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1273 GNU standards require "file name" instead of "filename" in
1274 documentation. It's nice for our code to follow the convention
1277 * casefile.c: (struct casefile) Rename `filename' member to
1278 `file_name'. Updated all references.
1280 * file-name.c: [!unix] (struct file_identity) Rename
1281 normalized_filename member to normalized_file_name. Updated all
1284 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1286 We don't really support anything but Unix-like environments well,
1287 so we might as well de-obfuscate by writing directory and path
1288 separators explicitly.
1290 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1292 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1293 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1295 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1298 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1300 GNU standards require "file name" instead of "filename" in
1301 documentation. It's nice for our code to follow the convention
1304 * filename.c: Rename to file-name.c.
1306 * filename.h: Rename to file-name.h. Update all inclusions.
1307 Update header guards.
1309 * automake.mk: Update file names.
1311 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1313 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1315 (fn_basename) Removed (dead code).
1316 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1317 (fn_special_p) Renamed fn_is_special(), all references updated.
1318 (fn_exists_p) Renamed fn_exists(), all references updated.
1320 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1322 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1323 Also, now it only tilde-expands file names, not paths.
1324 (fn_search_path) Tilde-expand one directory at a time.
1326 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1328 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1329 get rid of non-Unixlike version of the code, which has probably
1331 (fn_prepend_dir) Removed (dead code).
1333 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1334 (macro PATH_SEPARATOR_STRING) New.
1335 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1337 Continue reforming error message support. In this phase, we get
1338 rid of VM() and the other msg() support for "verbosity", replacing
1339 it by a new function verbose_msg().
1341 * filename.c: (fn_search_path) Use verbose_msg() instead of
1344 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1346 * sfm-private.h: Get rid of #defines after #error, which makes no
1349 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1351 Get rid of our own int32 type in favor of the standard int32_t
1354 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1357 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1359 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1361 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1363 Remove ill-considered file routines that are no longer used.
1365 * filename.c: (fn_open_ext) Removed.
1366 (fn_close_ext) Removed.
1368 * filename.h: (struct file_ext) Removed.
1370 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1372 * variable.c (var_is_valid_name): Move declarations before code
1375 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1377 * filename.ch (fn_interp_vars): Fixed small buglet.
1379 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1381 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1382 so as to modify the string inline. Thus makeing it easier to
1383 destroy the results when no longer needed.
1385 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1387 * category.c (cat_stored_values_destroy): Fixed memory leak.
1389 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1391 Add some missing frees. Thanks to John Darrington for reporting
1394 * any-writer.c (any_writer_close): Free writer.
1396 * any-reader.c (any_reader_close): Free reader.
1398 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1400 * por-file-reader.c: (error) Mark as NO_RETURN.
1402 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1404 * settings.c: Changed default value of scompress to true.
1406 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1408 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1410 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1413 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1414 here from pref.h.orig.
1416 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1418 * sys-file-reader.c: Fixed bug reading compressed files.
1420 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1422 * Numerous renames. See src/ChangeLog for details.
1424 * Moved files from src directory
projects / pspp-builds.git / blob