1 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
3 * format.c: (fmt_type_from_string) New function.
4 (fmt_to_string) Include decimals in output if the format has
5 decimals, even if the format type does not. This way, we can
6 accurately reproduce incorrect formats in user output.
7 (check_common_specifier) Make the check for a bad format type an
8 assertion, so we get bug reports if they show up. Fix message.
9 Check for decimal places with a format type that doesn't allow
11 (check_input_specifier) Remove check for FMT_X, which has been
13 (check_output_specifier) Ditto.
15 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
17 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
18 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
19 (enum fmt_parse_flags) Removed.
21 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
23 * casefile.c casefile.h: Converted to an abstract base class.
24 * casefile-private.h fastfile.c fastfile.h: New files.
25 * automake.mk procedure.c scratch-writer.c storage-stream.c
27 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
29 * procedure.c (internal_procedure): Create sink_case with only as
30 many values as the compacted dictionary.
32 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
34 Remove "debugging" code that caused plenty of false positives and
37 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
39 * case.c: Remove all references to `this' member.
41 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
43 Fix link error noted by Jason Stover.
45 * storage-stream.c: Include <assert.h>.
47 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
49 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
50 ALL) and additional underlying system file issues.
52 Thanks to John Darrington for review.
54 First problem: var_hash points to variables not owned by the
55 sys-file-reader, which the caller may free or modify. Use an
56 array of sfm_vars instead, as done earlier (e.g. CVS version
59 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
60 members and remove all code that references it. Add vars, var_cnt
61 members. Remove fix_specials member, which was unused.
62 (struct sfm_var) Remove name member, which was unused.
63 (sfm_close_reader) Free vars member instead of var_hash.
64 (compare_var_shortnames) Removed.
65 (hash_var_shortname) Removed.
66 (sfm_open_reader) Fill out vars array.
67 (compare_var_index) Removed.
68 (sfm_read_case) Use vars instead of var_hash.
70 Second problem: we're confused about when we actually have very
71 long strings, causing us to choose incorrectly between slow path
72 and fast path in sfm_read_case.
74 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
75 have very long strings, not when we have long variable names,
76 which is an unrelated feature.
78 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
80 * variable.h: Move var_set and variable parsing declarations to
81 new header, src/language/lexer/variable-parser.h. Modified lots
82 of files to include the new header.
84 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
86 * value-labels.c (value_to_string): When there's no value label,
87 format the variable according to its print format, instead of
88 always effectively using A or F format.
90 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
92 * casefile.c (casefile_get_random_reader): Nasty hack to get around
95 * format.c: Removed tortological assertion.
97 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
99 Reform string library.
101 * file-name.c (fn_interp_vars): Change interface to take a
102 substring as input. Updated all users.
104 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
106 * format.c (measure_is_valid): Really return false when m >=
109 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
111 Implement random access to casefiles, for use in GUI.
113 * casefile.c: (struct casereader) Add `random', `file_ofs',
114 `buffer_ofs' members.
115 (casefile_get_random_reader) New function.
116 (read_open_file) Break part into new function
117 seek_and_fill_buffer().
118 (fill_buffer) Update buffer_ofs, file_ofs.
119 (casereader_seek) New function.
121 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
123 * settings.c: Added call to i18n{done, init}.
125 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
127 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
130 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
132 * casefile.c: Convert many uses of `int' to `bool'.
134 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
136 * transformations.c (trns_chain_destroy): Destroy chain's trns
137 member, to fix memory leak.
139 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
141 * storage-stream.c (storage_source_decapsulate): Destroy case
142 source to fix memory leak.
144 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
146 * scratch-reader.c (scratch_reader_read_case): Copy into existing
147 case passed as argument instead of initializing the argument as a
148 case. Fixes memory leak that showed up in
149 tests/command/aggregate.sh with scratch files.
151 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
153 * procedure.c (proc_done): Destroy default_dict, to fix memory
156 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
158 Simplify procedure_with_splits().
160 * procedure.c (struct split_aux_data): Removed case_count member.
161 (procedure_with_splits) Don't initialize case_count.
162 (split_procedure_case_func) Check whether prev_case is null
163 instead of case_count.
164 (split_procedure_end_func) Ditto.
166 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
168 * case.c (case_move): Do nothing if dst and src are the same
170 (case_try_create) Merge two similar cases.
171 (case_copy) Unshare only if data must be actually copied.
173 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
175 * data-in.c data-out.c dictionary.c sys-file-reader.c
176 sys-file-writer.c variable.c variable.h: Reworked very long string
177 support for better encapsulation.
179 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
181 * value-labels.c (val_labs_can_set_width): New function.
182 (val_labs_set_width) Clear labels if increasing width to long
184 (val_labs_destroy) Remove unneeded test for null.
186 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
188 * value-labels.h: Remove unneeded dependency on variable.h.
190 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
192 Get rid of `char *c' member in union value, for cleanliness.
194 * value.h: (union value) Remove `c' member.
196 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
198 Make dictionary compacting functions a little more general.
200 * sys-file-writer.c (sfm_open_writer): Use
201 dict_compacting_would_change().
202 (does_dict_need_translation) Removed.
204 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
206 Make dictionary compacting functions a little more general.
208 * dictionary.c (dict_needs_compaction): Rename
209 dict_compacting_would_shrink(). Update all callers.
210 (dict_compacting_would_change) New function.
212 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
214 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
215 inverted return value (!).
217 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
219 Continue reforming procedure execution.
221 * procedure.c: Search and replace "vfm" by "proc". Notably:
222 (static var vfm_source) Rename proc_source. Update all
224 (static var vfm_sink) Rename proc_sink. Update all references.
226 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
228 Continue reforming procedure execution. In this phase, remove
229 PROCESS IF, which was deprecated anyway and can be easily
230 simulated with TEMPORARY followed by SELECT IF.
232 * procedure.c: (open_active_file) Don't call
233 add_process_if_trns().
234 (discard_variables) Get rid of redundant call to
235 proc_cancel_all_transformations().
236 (add_process_if_trns) Removed.
237 (process_if_trns_proc) Removed.
238 (process_if_trns_free) Removed.
240 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
242 Continue reforming procedure execution. In this phase, add
243 `const' to the case passed to procedure()'s callback.
245 Updated all users of procedure() as well.
247 * procedure.c: (struct write_case_data) Add "const" to ccase
248 parameter for case_func member.
249 (procedure) Add "const" to ccase parameter for proc_func
251 (multipass_case_func) Make ccase parameter const.
252 (internal_procedure) Add "const" to ccase parameter for case_func
254 (split_procedure_case_func) Make ccase parameter const.
255 (multipass_split_case_func) Make ccase parameter const.
257 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
259 Continue reforming procedure execution. In this phase, get rid of
260 the output code for SPLIT FILE groups in procedure.c, which really
261 shouldn't be doing any output. Move it into the individual
262 procedures instead. This also adds some flexibility.
264 Updated many users of procedure_with_splits() and
265 multipass_procedure_with_splits() to call
266 output_split_file_values() and to deal with increased use of
269 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
270 parameter to begin_func member.
271 (procedure_with_splits) Add "const struct ccase *" parameter to
272 begin_func parameter. Make ccase parameter const in proc_func
274 (split_procedure_case_func) Don't dump split file group. Pass
276 (dump_splits) Moved to language/dictionary/split-file.c as
277 output_split_file_values().
278 (struct multipass_split_aux_data) Add "const struct ccase *"
279 parameter to split_func member.
280 (multipass_procedure_with_splits) Add "const struct ccase *"
281 parameter to split_func parameter.
282 (multipass_split_case_func) Save new SPLIT FILE case before
284 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
286 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
288 Continue reforming procedure execution. Change
289 internal_procedure() so that it calls open_active_file() and
290 close_active_file(), which isolates most of the actual procedure
293 * procedure.c: (struct write_case_data) Rename `proc_func' member
294 to `case_func' and update all references.
295 (procedure) Rewrite as one-line wrapper around
296 internal_procedure().
297 (struct multipass_aux_data) New.
298 (multipass_callback) Renamed multipass_case_func(). Use struct
299 multipass_aux_data as auxiliary data.
300 (multipass_end_func) New function.
301 (multipass_procedure) Rewrite as wrapper for internal_procedure()
302 that uses multipass_case_func, multipass_end_func.
303 (internal_procedure) Add `end_func' argument. Move optimization
304 of trivial case in here. Move call to open_active_file() and
305 close_active_file() in here. Now assert that vfm_source is
307 (procedure_with_splits_callback) Rename
308 split_procedure_case_func().
309 (split_procedure_end_func) New function.
310 (multipass_split_callback) Rename multipass_split_case_func.
311 (multipass_split_end_func) New function.
312 (discard_variables) No need to test for nonnull vfm_source.
314 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
316 Continue reforming procedure execution. Get rid of unused member.
318 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
320 (write_case) Don't increment cases_analyzed.
322 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
324 Continue reforming procedure execution. In this phase, move
325 procedure.c and procedure.h from src to src/data. Update
326 makefiles and #includes accordingly.
328 * procedure.c: Moved here from src/.
330 * procedure.h: Moved here from src/.
332 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
334 Continue reforming procedure execution. In this phase, get rid of
335 many global variables, consolidating procedure execution in
336 procedure.c. Encapsulate transformations in new "struct
337 trns_chain". Also, change implementation of N OF CASES, FILTER,
338 and PROCESS IF from special cases to transformations.
340 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
343 * dictionary.c: (global variable default_dict) Move to
346 * variable.h: (TRNS_*) Move to transformations.h.
347 (struct transformation) Move to transformations.c.
349 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
351 * sys-file-reader.c: Fixed invalid read problems.
353 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
355 * storage-stream.c: Add missing function comments.
357 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
359 Continue reforming procedure execution. In this phase, add some
360 new, needed functionality to storage-stream.
362 * storage-stream.c: (storage_source_decapsulate) New function.
364 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
366 * variable.c (width_to_bytes): Declarations must precede
367 statements for C90 compliance.
369 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
371 * data-out.c, data-in.c, variable.c, variable.h: New functions
372 copy_mangle and copy_demangle for reading/writing cases; emulates the
373 way SPSS deals with strings > 255 bytes.
375 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
376 subtype 14 needed for strings longer than 255 bytes.
378 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
379 instead of literal values. Also fixed some constness issues.
381 * format.h: Constness
383 * sfm-private.h: Renamed the case_size identifier, since I discovered
384 that SPSS's respect for this variable is very nominal.
386 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
388 Change case limit type from int to size_t.
390 * dictionary.c: (struct dictionary) Change type of case_limit
392 (dict_get_case_limit) Change return type.
393 (dict_set_case_limit) Change parameter type.
395 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
397 * variable.h: (struct variable) Rename `reinit' member as `leave'
398 and invert sense. Fix up all references.
400 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
402 Continue reforming procedure execution. In this phase, break
403 procedure.c into multiple files.
405 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
407 * case-sink.c: New file.
409 * case-sink.h: New file.
411 * case-source.c: New file.
413 * case-source.h: New file.
415 * storage-stream.c: New file.
417 * storage-stream.h: New file.
419 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
421 * variable.h: (struct variable) Remove `init' member and all
422 references to it from other files. It was initialized in several
423 places, but nothing really ever used it for anything worthwhile.
424 Thanks to Jason Stover for pointing out how confusing this
427 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
429 Continue reforming error message support. In this phase, get rid
430 of message "titles" and put the message text in `struct error'.
431 Now `struct error' encapsulates a message more properly.
433 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
434 Format message ourselves.
436 * data-in.c: (vdls_error) Ditto.
438 * por-file-reader.c: (error) Ditto.
440 * sys-file-reader.c: (corrupt_msg) Ditto.
442 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
444 GNU standards require "file name" instead of "filename" in
445 documentation. It's nice for our code to follow the convention
448 * casefile.c: (struct casefile) Rename `filename' member to
449 `file_name'. Updated all references.
451 * file-name.c: [!unix] (struct file_identity) Rename
452 normalized_filename member to normalized_file_name. Updated all
455 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
457 We don't really support anything but Unix-like environments well,
458 so we might as well de-obfuscate by writing directory and path
459 separators explicitly.
461 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
463 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
464 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
466 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
469 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
471 GNU standards require "file name" instead of "filename" in
472 documentation. It's nice for our code to follow the convention
475 * filename.c: Rename to file-name.c.
477 * filename.h: Rename to file-name.h. Update all inclusions.
478 Update header guards.
480 * automake.mk: Update file names.
482 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
484 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
486 (fn_basename) Removed (dead code).
487 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
488 (fn_special_p) Renamed fn_is_special(), all references updated.
489 (fn_exists_p) Renamed fn_exists(), all references updated.
491 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
493 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
494 Also, now it only tilde-expands file names, not paths.
495 (fn_search_path) Tilde-expand one directory at a time.
497 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
499 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
500 get rid of non-Unixlike version of the code, which has probably
502 (fn_prepend_dir) Removed (dead code).
504 * filename.h: (macro DIR_SEPARATOR_STRING) New.
505 (macro PATH_SEPARATOR_STRING) New.
506 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
508 Continue reforming error message support. In this phase, we get
509 rid of VM() and the other msg() support for "verbosity", replacing
510 it by a new function verbose_msg().
512 * filename.c: (fn_search_path) Use verbose_msg() instead of
515 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
517 * sfm-private.h: Get rid of #defines after #error, which makes no
520 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
522 Get rid of our own int32 type in favor of the standard int32_t
525 * sfm-private.h: (int32 macro) Don't define this anymore. Do
528 * sys-file-reader.c: Use int32_t instead of int32 throughout.
530 * sys-file-writer.c: Use int32_t instead of int32 throughout.
532 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
534 Remove ill-considered file routines that are no longer used.
536 * filename.c: (fn_open_ext) Removed.
537 (fn_close_ext) Removed.
539 * filename.h: (struct file_ext) Removed.
541 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
543 * variable.c (var_is_valid_name): Move declarations before code
546 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
548 * filename.ch (fn_interp_vars): Fixed small buglet.
550 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
552 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
553 so as to modify the string inline. Thus makeing it easier to
554 destroy the results when no longer needed.
556 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
558 * category.c (cat_stored_values_destroy): Fixed memory leak.
560 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
562 Add some missing frees. Thanks to John Darrington for reporting
565 * any-writer.c (any_writer_close): Free writer.
567 * any-reader.c (any_reader_close): Free reader.
569 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
571 * por-file-reader.c: (error) Mark as NO_RETURN.
573 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
575 * settings.c: Changed default value of scompress to true.
577 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
579 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
581 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
584 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
585 here from pref.h.orig.
587 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
589 * sys-file-reader.c: Fixed bug reading compressed files.
591 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
593 * Numerous renames. See src/ChangeLog for details.
595 * Moved files from src directory