1 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
3 * format.c (fmt_is_binary): New function.
5 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
7 * procedure.c procedure.h: Encapsulated the static data into a single
10 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
12 * casefile.c (casereader_read_xfer): Always initialize the case,
13 even on an error condition.
15 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
17 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
18 entire function useless.
20 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
22 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
23 casereader method casereader_clone.
25 * procedure.c pransformations.h: Introduced new type casenum_t
27 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
29 * variable.c: (width_to_bytes) Rephrase code for clarify.
31 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
33 * format.c: (fmt_type_from_string) New function.
34 (fmt_to_string) Include decimals in output if the format has
35 decimals, even if the format type does not. This way, we can
36 accurately reproduce incorrect formats in user output.
37 (check_common_specifier) Make the check for a bad format type an
38 assertion, so we get bug reports if they show up. Fix message.
39 Check for decimal places with a format type that doesn't allow
41 (check_input_specifier) Remove check for FMT_X, which has been
43 (check_output_specifier) Ditto.
45 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
47 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
48 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
49 (enum fmt_parse_flags) Removed.
51 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
53 * casefile.c casefile.h: Converted to an abstract base class.
54 * casefile-private.h fastfile.c fastfile.h: New files.
55 * automake.mk procedure.c scratch-writer.c storage-stream.c
57 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
59 * procedure.c (internal_procedure): Create sink_case with only as
60 many values as the compacted dictionary.
62 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
64 Remove "debugging" code that caused plenty of false positives and
67 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
69 * case.c: Remove all references to `this' member.
71 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
73 Fix link error noted by Jason Stover.
75 * storage-stream.c: Include <assert.h>.
77 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
79 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
80 ALL) and additional underlying system file issues.
82 Thanks to John Darrington for review.
84 First problem: var_hash points to variables not owned by the
85 sys-file-reader, which the caller may free or modify. Use an
86 array of sfm_vars instead, as done earlier (e.g. CVS version
89 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
90 members and remove all code that references it. Add vars, var_cnt
91 members. Remove fix_specials member, which was unused.
92 (struct sfm_var) Remove name member, which was unused.
93 (sfm_close_reader) Free vars member instead of var_hash.
94 (compare_var_shortnames) Removed.
95 (hash_var_shortname) Removed.
96 (sfm_open_reader) Fill out vars array.
97 (compare_var_index) Removed.
98 (sfm_read_case) Use vars instead of var_hash.
100 Second problem: we're confused about when we actually have very
101 long strings, causing us to choose incorrectly between slow path
102 and fast path in sfm_read_case.
104 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
105 have very long strings, not when we have long variable names,
106 which is an unrelated feature.
108 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
110 * variable.h: Move var_set and variable parsing declarations to
111 new header, src/language/lexer/variable-parser.h. Modified lots
112 of files to include the new header.
114 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
116 * value-labels.c (value_to_string): When there's no value label,
117 format the variable according to its print format, instead of
118 always effectively using A or F format.
120 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
122 * casefile.c (casefile_get_random_reader): Nasty hack to get around
125 * format.c: Removed tortological assertion.
127 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
129 Reform string library.
131 * file-name.c (fn_interp_vars): Change interface to take a
132 substring as input. Updated all users.
134 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
136 * format.c (measure_is_valid): Really return false when m >=
139 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
141 Implement random access to casefiles, for use in GUI.
143 * casefile.c: (struct casereader) Add `random', `file_ofs',
144 `buffer_ofs' members.
145 (casefile_get_random_reader) New function.
146 (read_open_file) Break part into new function
147 seek_and_fill_buffer().
148 (fill_buffer) Update buffer_ofs, file_ofs.
149 (casereader_seek) New function.
151 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
153 * settings.c: Added call to i18n{done, init}.
155 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
157 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
160 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
162 * casefile.c: Convert many uses of `int' to `bool'.
164 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
166 * transformations.c (trns_chain_destroy): Destroy chain's trns
167 member, to fix memory leak.
169 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
171 * storage-stream.c (storage_source_decapsulate): Destroy case
172 source to fix memory leak.
174 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
176 * scratch-reader.c (scratch_reader_read_case): Copy into existing
177 case passed as argument instead of initializing the argument as a
178 case. Fixes memory leak that showed up in
179 tests/command/aggregate.sh with scratch files.
181 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
183 * procedure.c (proc_done): Destroy default_dict, to fix memory
186 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
188 Simplify procedure_with_splits().
190 * procedure.c (struct split_aux_data): Removed case_count member.
191 (procedure_with_splits) Don't initialize case_count.
192 (split_procedure_case_func) Check whether prev_case is null
193 instead of case_count.
194 (split_procedure_end_func) Ditto.
196 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
198 * case.c (case_move): Do nothing if dst and src are the same
200 (case_try_create) Merge two similar cases.
201 (case_copy) Unshare only if data must be actually copied.
203 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
205 * data-in.c data-out.c dictionary.c sys-file-reader.c
206 sys-file-writer.c variable.c variable.h: Reworked very long string
207 support for better encapsulation.
209 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
211 * value-labels.c (val_labs_can_set_width): New function.
212 (val_labs_set_width) Clear labels if increasing width to long
214 (val_labs_destroy) Remove unneeded test for null.
216 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
218 * value-labels.h: Remove unneeded dependency on variable.h.
220 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
222 Get rid of `char *c' member in union value, for cleanliness.
224 * value.h: (union value) Remove `c' member.
226 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
228 Make dictionary compacting functions a little more general.
230 * sys-file-writer.c (sfm_open_writer): Use
231 dict_compacting_would_change().
232 (does_dict_need_translation) Removed.
234 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
236 Make dictionary compacting functions a little more general.
238 * dictionary.c (dict_needs_compaction): Rename
239 dict_compacting_would_shrink(). Update all callers.
240 (dict_compacting_would_change) New function.
242 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
244 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
245 inverted return value (!).
247 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
249 Continue reforming procedure execution.
251 * procedure.c: Search and replace "vfm" by "proc". Notably:
252 (static var vfm_source) Rename proc_source. Update all
254 (static var vfm_sink) Rename proc_sink. Update all references.
256 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
258 Continue reforming procedure execution. In this phase, remove
259 PROCESS IF, which was deprecated anyway and can be easily
260 simulated with TEMPORARY followed by SELECT IF.
262 * procedure.c: (open_active_file) Don't call
263 add_process_if_trns().
264 (discard_variables) Get rid of redundant call to
265 proc_cancel_all_transformations().
266 (add_process_if_trns) Removed.
267 (process_if_trns_proc) Removed.
268 (process_if_trns_free) Removed.
270 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
272 Continue reforming procedure execution. In this phase, add
273 `const' to the case passed to procedure()'s callback.
275 Updated all users of procedure() as well.
277 * procedure.c: (struct write_case_data) Add "const" to ccase
278 parameter for case_func member.
279 (procedure) Add "const" to ccase parameter for proc_func
281 (multipass_case_func) Make ccase parameter const.
282 (internal_procedure) Add "const" to ccase parameter for case_func
284 (split_procedure_case_func) Make ccase parameter const.
285 (multipass_split_case_func) Make ccase parameter const.
287 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
289 Continue reforming procedure execution. In this phase, get rid of
290 the output code for SPLIT FILE groups in procedure.c, which really
291 shouldn't be doing any output. Move it into the individual
292 procedures instead. This also adds some flexibility.
294 Updated many users of procedure_with_splits() and
295 multipass_procedure_with_splits() to call
296 output_split_file_values() and to deal with increased use of
299 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
300 parameter to begin_func member.
301 (procedure_with_splits) Add "const struct ccase *" parameter to
302 begin_func parameter. Make ccase parameter const in proc_func
304 (split_procedure_case_func) Don't dump split file group. Pass
306 (dump_splits) Moved to language/dictionary/split-file.c as
307 output_split_file_values().
308 (struct multipass_split_aux_data) Add "const struct ccase *"
309 parameter to split_func member.
310 (multipass_procedure_with_splits) Add "const struct ccase *"
311 parameter to split_func parameter.
312 (multipass_split_case_func) Save new SPLIT FILE case before
314 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
316 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
318 Continue reforming procedure execution. Change
319 internal_procedure() so that it calls open_active_file() and
320 close_active_file(), which isolates most of the actual procedure
323 * procedure.c: (struct write_case_data) Rename `proc_func' member
324 to `case_func' and update all references.
325 (procedure) Rewrite as one-line wrapper around
326 internal_procedure().
327 (struct multipass_aux_data) New.
328 (multipass_callback) Renamed multipass_case_func(). Use struct
329 multipass_aux_data as auxiliary data.
330 (multipass_end_func) New function.
331 (multipass_procedure) Rewrite as wrapper for internal_procedure()
332 that uses multipass_case_func, multipass_end_func.
333 (internal_procedure) Add `end_func' argument. Move optimization
334 of trivial case in here. Move call to open_active_file() and
335 close_active_file() in here. Now assert that vfm_source is
337 (procedure_with_splits_callback) Rename
338 split_procedure_case_func().
339 (split_procedure_end_func) New function.
340 (multipass_split_callback) Rename multipass_split_case_func.
341 (multipass_split_end_func) New function.
342 (discard_variables) No need to test for nonnull vfm_source.
344 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
346 Continue reforming procedure execution. Get rid of unused member.
348 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
350 (write_case) Don't increment cases_analyzed.
352 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
354 Continue reforming procedure execution. In this phase, move
355 procedure.c and procedure.h from src to src/data. Update
356 makefiles and #includes accordingly.
358 * procedure.c: Moved here from src/.
360 * procedure.h: Moved here from src/.
362 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
364 Continue reforming procedure execution. In this phase, get rid of
365 many global variables, consolidating procedure execution in
366 procedure.c. Encapsulate transformations in new "struct
367 trns_chain". Also, change implementation of N OF CASES, FILTER,
368 and PROCESS IF from special cases to transformations.
370 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
373 * dictionary.c: (global variable default_dict) Move to
376 * variable.h: (TRNS_*) Move to transformations.h.
377 (struct transformation) Move to transformations.c.
379 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
381 * sys-file-reader.c: Fixed invalid read problems.
383 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
385 * storage-stream.c: Add missing function comments.
387 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
389 Continue reforming procedure execution. In this phase, add some
390 new, needed functionality to storage-stream.
392 * storage-stream.c: (storage_source_decapsulate) New function.
394 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
396 * variable.c (width_to_bytes): Declarations must precede
397 statements for C90 compliance.
399 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
401 * data-out.c, data-in.c, variable.c, variable.h: New functions
402 copy_mangle and copy_demangle for reading/writing cases; emulates the
403 way SPSS deals with strings > 255 bytes.
405 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
406 subtype 14 needed for strings longer than 255 bytes.
408 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
409 instead of literal values. Also fixed some constness issues.
411 * format.h: Constness
413 * sfm-private.h: Renamed the case_size identifier, since I discovered
414 that SPSS's respect for this variable is very nominal.
416 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
418 Change case limit type from int to size_t.
420 * dictionary.c: (struct dictionary) Change type of case_limit
422 (dict_get_case_limit) Change return type.
423 (dict_set_case_limit) Change parameter type.
425 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
427 * variable.h: (struct variable) Rename `reinit' member as `leave'
428 and invert sense. Fix up all references.
430 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
432 Continue reforming procedure execution. In this phase, break
433 procedure.c into multiple files.
435 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
437 * case-sink.c: New file.
439 * case-sink.h: New file.
441 * case-source.c: New file.
443 * case-source.h: New file.
445 * storage-stream.c: New file.
447 * storage-stream.h: New file.
449 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
451 * variable.h: (struct variable) Remove `init' member and all
452 references to it from other files. It was initialized in several
453 places, but nothing really ever used it for anything worthwhile.
454 Thanks to Jason Stover for pointing out how confusing this
457 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
459 Continue reforming error message support. In this phase, get rid
460 of message "titles" and put the message text in `struct error'.
461 Now `struct error' encapsulates a message more properly.
463 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
464 Format message ourselves.
466 * data-in.c: (vdls_error) Ditto.
468 * por-file-reader.c: (error) Ditto.
470 * sys-file-reader.c: (corrupt_msg) Ditto.
472 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
474 GNU standards require "file name" instead of "filename" in
475 documentation. It's nice for our code to follow the convention
478 * casefile.c: (struct casefile) Rename `filename' member to
479 `file_name'. Updated all references.
481 * file-name.c: [!unix] (struct file_identity) Rename
482 normalized_filename member to normalized_file_name. Updated all
485 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
487 We don't really support anything but Unix-like environments well,
488 so we might as well de-obfuscate by writing directory and path
489 separators explicitly.
491 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
493 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
494 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
496 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
499 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
501 GNU standards require "file name" instead of "filename" in
502 documentation. It's nice for our code to follow the convention
505 * filename.c: Rename to file-name.c.
507 * filename.h: Rename to file-name.h. Update all inclusions.
508 Update header guards.
510 * automake.mk: Update file names.
512 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
514 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
516 (fn_basename) Removed (dead code).
517 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
518 (fn_special_p) Renamed fn_is_special(), all references updated.
519 (fn_exists_p) Renamed fn_exists(), all references updated.
521 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
523 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
524 Also, now it only tilde-expands file names, not paths.
525 (fn_search_path) Tilde-expand one directory at a time.
527 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
529 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
530 get rid of non-Unixlike version of the code, which has probably
532 (fn_prepend_dir) Removed (dead code).
534 * filename.h: (macro DIR_SEPARATOR_STRING) New.
535 (macro PATH_SEPARATOR_STRING) New.
536 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
538 Continue reforming error message support. In this phase, we get
539 rid of VM() and the other msg() support for "verbosity", replacing
540 it by a new function verbose_msg().
542 * filename.c: (fn_search_path) Use verbose_msg() instead of
545 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
547 * sfm-private.h: Get rid of #defines after #error, which makes no
550 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
552 Get rid of our own int32 type in favor of the standard int32_t
555 * sfm-private.h: (int32 macro) Don't define this anymore. Do
558 * sys-file-reader.c: Use int32_t instead of int32 throughout.
560 * sys-file-writer.c: Use int32_t instead of int32 throughout.
562 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
564 Remove ill-considered file routines that are no longer used.
566 * filename.c: (fn_open_ext) Removed.
567 (fn_close_ext) Removed.
569 * filename.h: (struct file_ext) Removed.
571 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
573 * variable.c (var_is_valid_name): Move declarations before code
576 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
578 * filename.ch (fn_interp_vars): Fixed small buglet.
580 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
582 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
583 so as to modify the string inline. Thus makeing it easier to
584 destroy the results when no longer needed.
586 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
588 * category.c (cat_stored_values_destroy): Fixed memory leak.
590 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
592 Add some missing frees. Thanks to John Darrington for reporting
595 * any-writer.c (any_writer_close): Free writer.
597 * any-reader.c (any_reader_close): Free reader.
599 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
601 * por-file-reader.c: (error) Mark as NO_RETURN.
603 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
605 * settings.c: Changed default value of scompress to true.
607 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
609 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
611 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
614 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
615 here from pref.h.orig.
617 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
619 * sys-file-reader.c: Fixed bug reading compressed files.
621 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
623 * Numerous renames. See src/ChangeLog for details.
625 * Moved files from src directory