1 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
3 Implement random access to casefiles, for use in GUI.
5 * casefile.c: (struct casereader) Add `random', `file_ofs',
7 (casefile_get_random_reader) New function.
8 (read_open_file) Break part into new function
9 seek_and_fill_buffer().
10 (fill_buffer) Update buffer_ofs, file_ofs.
11 (casereader_seek) New function.
13 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
15 * settings.c: Added call to i18n{done, init}.
17 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
19 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
22 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
24 * casefile.c: Convert many uses of `int' to `bool'.
26 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
28 * transformations.c (trns_chain_destroy): Destroy chain's trns
29 member, to fix memory leak.
31 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
33 * storage-stream.c (storage_source_decapsulate): Destroy case
34 source to fix memory leak.
36 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
38 * scratch-reader.c (scratch_reader_read_case): Copy into existing
39 case passed as argument instead of initializing the argument as a
40 case. Fixes memory leak that showed up in
41 tests/command/aggregate.sh with scratch files.
43 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
45 * procedure.c (proc_done): Destroy default_dict, to fix memory
48 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
50 Simplify procedure_with_splits().
52 * procedure.c (struct split_aux_data): Removed case_count member.
53 (procedure_with_splits) Don't initialize case_count.
54 (split_procedure_case_func) Check whether prev_case is null
55 instead of case_count.
56 (split_procedure_end_func) Ditto.
58 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
60 * case.c (case_move): Do nothing if dst and src are the same
62 (case_try_create) Merge two similar cases.
63 (case_copy) Unshare only if data must be actually copied.
65 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
67 * data-in.c data-out.c dictionary.c sys-file-reader.c
68 sys-file-writer.c variable.c variable.h: Reworked very long string
69 support for better encapsulation.
71 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
73 * value-labels.c (val_labs_can_set_width): New function.
74 (val_labs_set_width) Clear labels if increasing width to long
76 (val_labs_destroy) Remove unneeded test for null.
78 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
80 * value-labels.h: Remove unneeded dependency on variable.h.
82 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
84 Get rid of `char *c' member in union value, for cleanliness.
86 * value.h: (union value) Remove `c' member.
88 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
90 Make dictionary compacting functions a little more general.
92 * sys-file-writer.c (sfm_open_writer): Use
93 dict_compacting_would_change().
94 (does_dict_need_translation) Removed.
96 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
98 Make dictionary compacting functions a little more general.
100 * dictionary.c (dict_needs_compaction): Rename
101 dict_compacting_would_shrink(). Update all callers.
102 (dict_compacting_would_change) New function.
104 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
106 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
107 inverted return value (!).
109 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
111 Continue reforming procedure execution.
113 * procedure.c: Search and replace "vfm" by "proc". Notably:
114 (static var vfm_source) Rename proc_source. Update all
116 (static var vfm_sink) Rename proc_sink. Update all references.
118 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
120 Continue reforming procedure execution. In this phase, remove
121 PROCESS IF, which was deprecated anyway and can be easily
122 simulated with TEMPORARY followed by SELECT IF.
124 * procedure.c: (open_active_file) Don't call
125 add_process_if_trns().
126 (discard_variables) Get rid of redundant call to
127 proc_cancel_all_transformations().
128 (add_process_if_trns) Removed.
129 (process_if_trns_proc) Removed.
130 (process_if_trns_free) Removed.
132 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
134 Continue reforming procedure execution. In this phase, add
135 `const' to the case passed to procedure()'s callback.
137 Updated all users of procedure() as well.
139 * procedure.c: (struct write_case_data) Add "const" to ccase
140 parameter for case_func member.
141 (procedure) Add "const" to ccase parameter for proc_func
143 (multipass_case_func) Make ccase parameter const.
144 (internal_procedure) Add "const" to ccase parameter for case_func
146 (split_procedure_case_func) Make ccase parameter const.
147 (multipass_split_case_func) Make ccase parameter const.
149 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
151 Continue reforming procedure execution. In this phase, get rid of
152 the output code for SPLIT FILE groups in procedure.c, which really
153 shouldn't be doing any output. Move it into the individual
154 procedures instead. This also adds some flexibility.
156 Updated many users of procedure_with_splits() and
157 multipass_procedure_with_splits() to call
158 output_split_file_values() and to deal with increased use of
161 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
162 parameter to begin_func member.
163 (procedure_with_splits) Add "const struct ccase *" parameter to
164 begin_func parameter. Make ccase parameter const in proc_func
166 (split_procedure_case_func) Don't dump split file group. Pass
168 (dump_splits) Moved to language/dictionary/split-file.c as
169 output_split_file_values().
170 (struct multipass_split_aux_data) Add "const struct ccase *"
171 parameter to split_func member.
172 (multipass_procedure_with_splits) Add "const struct ccase *"
173 parameter to split_func parameter.
174 (multipass_split_case_func) Save new SPLIT FILE case before
176 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
178 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
180 Continue reforming procedure execution. Change
181 internal_procedure() so that it calls open_active_file() and
182 close_active_file(), which isolates most of the actual procedure
185 * procedure.c: (struct write_case_data) Rename `proc_func' member
186 to `case_func' and update all references.
187 (procedure) Rewrite as one-line wrapper around
188 internal_procedure().
189 (struct multipass_aux_data) New.
190 (multipass_callback) Renamed multipass_case_func(). Use struct
191 multipass_aux_data as auxiliary data.
192 (multipass_end_func) New function.
193 (multipass_procedure) Rewrite as wrapper for internal_procedure()
194 that uses multipass_case_func, multipass_end_func.
195 (internal_procedure) Add `end_func' argument. Move optimization
196 of trivial case in here. Move call to open_active_file() and
197 close_active_file() in here. Now assert that vfm_source is
199 (procedure_with_splits_callback) Rename
200 split_procedure_case_func().
201 (split_procedure_end_func) New function.
202 (multipass_split_callback) Rename multipass_split_case_func.
203 (multipass_split_end_func) New function.
204 (discard_variables) No need to test for nonnull vfm_source.
206 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
208 Continue reforming procedure execution. Get rid of unused member.
210 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
212 (write_case) Don't increment cases_analyzed.
214 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
216 Continue reforming procedure execution. In this phase, move
217 procedure.c and procedure.h from src to src/data. Update
218 makefiles and #includes accordingly.
220 * procedure.c: Moved here from src/.
222 * procedure.h: Moved here from src/.
224 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
226 Continue reforming procedure execution. In this phase, get rid of
227 many global variables, consolidating procedure execution in
228 procedure.c. Encapsulate transformations in new "struct
229 trns_chain". Also, change implementation of N OF CASES, FILTER,
230 and PROCESS IF from special cases to transformations.
232 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
235 * dictionary.c: (global variable default_dict) Move to
238 * variable.h: (TRNS_*) Move to transformations.h.
239 (struct transformation) Move to transformations.c.
241 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
243 * sys-file-reader.c: Fixed invalid read problems.
245 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
247 * storage-stream.c: Add missing function comments.
249 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
251 Continue reforming procedure execution. In this phase, add some
252 new, needed functionality to storage-stream.
254 * storage-stream.c: (storage_source_decapsulate) New function.
256 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
258 * variable.c (width_to_bytes): Declarations must precede
259 statements for C90 compliance.
261 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
263 * data-out.c, data-in.c, variable.c, variable.h: New functions
264 copy_mangle and copy_demangle for reading/writing cases; emulates the
265 way SPSS deals with strings > 255 bytes.
267 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
268 subtype 14 needed for strings longer than 255 bytes.
270 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
271 instead of literal values. Also fixed some constness issues.
273 * format.h: Constness
275 * sfm-private.h: Renamed the case_size identifier, since I discovered
276 that SPSS's respect for this variable is very nominal.
278 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
280 Change case limit type from int to size_t.
282 * dictionary.c: (struct dictionary) Change type of case_limit
284 (dict_get_case_limit) Change return type.
285 (dict_set_case_limit) Change parameter type.
287 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
289 * variable.h: (struct variable) Rename `reinit' member as `leave'
290 and invert sense. Fix up all references.
292 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
294 Continue reforming procedure execution. In this phase, break
295 procedure.c into multiple files.
297 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
299 * case-sink.c: New file.
301 * case-sink.h: New file.
303 * case-source.c: New file.
305 * case-source.h: New file.
307 * storage-stream.c: New file.
309 * storage-stream.h: New file.
311 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
313 * variable.h: (struct variable) Remove `init' member and all
314 references to it from other files. It was initialized in several
315 places, but nothing really ever used it for anything worthwhile.
316 Thanks to Jason Stover for pointing out how confusing this
319 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
321 Continue reforming error message support. In this phase, get rid
322 of message "titles" and put the message text in `struct error'.
323 Now `struct error' encapsulates a message more properly.
325 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
326 Format message ourselves.
328 * data-in.c: (vdls_error) Ditto.
330 * por-file-reader.c: (error) Ditto.
332 * sys-file-reader.c: (corrupt_msg) Ditto.
334 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
336 GNU standards require "file name" instead of "filename" in
337 documentation. It's nice for our code to follow the convention
340 * casefile.c: (struct casefile) Rename `filename' member to
341 `file_name'. Updated all references.
343 * file-name.c: [!unix] (struct file_identity) Rename
344 normalized_filename member to normalized_file_name. Updated all
347 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
349 We don't really support anything but Unix-like environments well,
350 so we might as well de-obfuscate by writing directory and path
351 separators explicitly.
353 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
355 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
356 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
358 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
361 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
363 GNU standards require "file name" instead of "filename" in
364 documentation. It's nice for our code to follow the convention
367 * filename.c: Rename to file-name.c.
369 * filename.h: Rename to file-name.h. Update all inclusions.
370 Update header guards.
372 * automake.mk: Update file names.
374 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
376 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
378 (fn_basename) Removed (dead code).
379 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
380 (fn_special_p) Renamed fn_is_special(), all references updated.
381 (fn_exists_p) Renamed fn_exists(), all references updated.
383 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
385 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
386 Also, now it only tilde-expands file names, not paths.
387 (fn_search_path) Tilde-expand one directory at a time.
389 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
391 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
392 get rid of non-Unixlike version of the code, which has probably
394 (fn_prepend_dir) Removed (dead code).
396 * filename.h: (macro DIR_SEPARATOR_STRING) New.
397 (macro PATH_SEPARATOR_STRING) New.
398 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
400 Continue reforming error message support. In this phase, we get
401 rid of VM() and the other msg() support for "verbosity", replacing
402 it by a new function verbose_msg().
404 * filename.c: (fn_search_path) Use verbose_msg() instead of
407 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
409 * sfm-private.h: Get rid of #defines after #error, which makes no
412 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
414 Get rid of our own int32 type in favor of the standard int32_t
417 * sfm-private.h: (int32 macro) Don't define this anymore. Do
420 * sys-file-reader.c: Use int32_t instead of int32 throughout.
422 * sys-file-writer.c: Use int32_t instead of int32 throughout.
424 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
426 Remove ill-considered file routines that are no longer used.
428 * filename.c: (fn_open_ext) Removed.
429 (fn_close_ext) Removed.
431 * filename.h: (struct file_ext) Removed.
433 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
435 * variable.c (var_is_valid_name): Move declarations before code
438 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
440 * filename.ch (fn_interp_vars): Fixed small buglet.
442 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
444 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
445 so as to modify the string inline. Thus makeing it easier to
446 destroy the results when no longer needed.
448 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
450 * category.c (cat_stored_values_destroy): Fixed memory leak.
452 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
454 Add some missing frees. Thanks to John Darrington for reporting
457 * any-writer.c (any_writer_close): Free writer.
459 * any-reader.c (any_reader_close): Free reader.
461 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
463 * por-file-reader.c: (error) Mark as NO_RETURN.
465 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
467 * settings.c: Changed default value of scompress to true.
469 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
471 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
473 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
476 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
477 here from pref.h.orig.
479 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
481 * sys-file-reader.c: Fixed bug reading compressed files.
483 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
485 * Numerous renames. See src/ChangeLog for details.
487 * Moved files from src directory