1 Mon Jan 15 16:18:10 2007 Ben Pfaff <blp@gnu.org>
3 * case.c (case_is_null): Change return type to bool.
5 Mon Jan 15 10:57:28 2007 Ben Pfaff <blp@gnu.org>
9 * case.c (case_clone) [DEBUGGING]: When debugging, don't use
10 reference counting to share data. This makes it easy for
11 valgrind, etc. to find accesses to cases that have been destroyed
12 but have been kept around by another user's ref-count. This often
13 happens when the data set is small enough to find in memory; if a
14 bigger data set that would overflow to disk were used, then data
15 corruption would occur.
17 Mon Jan 15 10:55:18 2007 Ben Pfaff <blp@gnu.org>
21 * case.c (case_unshare): Make it check internally whether the
22 ref_cnt is greater than 1, so that the callers don't have to.
23 Update callers not to check.
25 Mon Jan 15 10:53:01 2007 Ben Pfaff <blp@gnu.org>
27 Before, I was thinking that I might want to get rid of reference
28 counting at some point. Now, I'm pretty sure that it's here to
29 stay. Thus, because we have to store the value_cnt anyway for
30 reference-counted cases, we might as well expose it to users.
32 * case.c (case_get_value_cnt): New function.
33 (case_resize): Drop OLD_CNT argument. Update all callers. Only
34 resize case if its size actually changed.
36 * casefile.c (casefile_append_xfer): Use case_get_value_cnt
37 instead of peeking inside struct case directly.
38 (casefile_append): Ditto.
40 Mon Jan 15 10:50:22 2007 Ben Pfaff <blp@gnu.org>
42 Get rid of the inlines for the case functions, which made the
43 header file hard to read. (Also, in testing with "-O2 -DNDEBUG",
44 the inlines didn't speed up "make check" at all, which is not a
45 perfect benchmark but seems indicative.)
47 * case.c: Remove #ifdef DEBUGGING...#endif around many function
48 definitions. Remove some assertions on nonnull pointers that were
49 redundant with a pointer dereference soon after in the function.
51 (struct case_data): Move definition here from case.h.
55 (case_data_wr): Ditto.
57 Sun Jan 14 21:41:12 2007 Ben Pfaff <blp@gnu.org>
59 * automake.mk: Add casedeque.h to sources.
61 * casedeque.h: New file.
63 * procedure.c: (struct dataset) Change lag_count, lag_head,
64 lag_queue member into single struct casedeque member. Update all
65 users to use the casedeque instead.
68 Sun Jan 14 21:43:12 2007 Ben Pfaff <blp@gnu.org>
70 * procedure.c: Simplify lagged cases interface. Updated all
71 clients--well, the only client--to use the simplified interface.
72 (dataset_n_lag) Removed.
73 (dataset_set_n_lag) Removed.
74 (dataset_need_lag) New function.
76 Tue Jan 9 07:20:05 WST 2007 John Darrington <john@darrington.wattle.id.au>
78 * dictionary.c procedure.c: More changes to ensure that callbacks occur
79 whenever appropriate, but only when the dataset/dictionary is in a
82 Sun Jan 7 08:33:04 WST 2007 John Darrington <john@darrington.wattle.id.au>
84 * dictionary.c dictionary.h : Added callbacks for change of filter and
85 split variables. Refactored some code to ensure that callbacks get
86 invoked when appropriate.
88 * procedure.c (proc_cancel_temporary_transformations): Make sure that
89 replace_dict callback occurs when permanent_dict replaces the current
92 Wed Jan 3 11:02:11 WST 2007 John Darrington <john@darrington.wattle.id.au>
94 * dictionary.c dictionary.h : Added callback for when the weight
95 variable of a dictionary changes.
97 Mon Jan 1 10:36:26 WST 2007 John Darrington <john@darrington.wattle.id.au>
99 * dictionary.c dictionary.h : Added replace_source and replace_dict
100 callbacks, and functions to deal with them.
102 Fri Dec 22 13:56:08 2006 Ben Pfaff <blp@gnu.org>
104 Simplify missing value handling.
106 * missing-values.h (enum mv_class): New type.
107 (enum mv_type): Moved definition into missing-values.c and renamed
108 each MV_* to MVT_*, to distinguish them from the exposed mv_class
109 enums. Updated all uses.
110 (struct missing_values): Changed type of `type' from `enum
111 mv_type' to `int' because the definition is no longer exposed.
113 * missing-values.c (mv_is_value_missing): Add new enum mv_class
114 parameter. Update all callers.
115 (mv_is_num_missing): Ditto.
116 (mv_is_str_missing): Ditto.
117 (mv_is_value_user_missing): Removed. Changed callers to use
119 (mv_is_num_user_missing): Removed. Changed callers to use
121 (mv_is_str_user_missing): Removed. Changed callers to use
123 (mv_is_value_system_missing): Removed. Changed callers to use
125 (mv_set_type): Removed. Changed callers to use mv_clear.
126 (mv_clear): New function.
128 * variable.c (var_is_value_missing): Add new enum mv_class
129 parameter. Update all callers.
130 (var_is_num_missing): Ditto.
131 (var_is_str_missing): Ditto.
132 (var_is_value_user_missing): Removed. Changed callers to use
133 var_is_value_missing.
134 (var_is_num_user_missing): Removed. Changed callers to use
136 (var_is_str_user_missing): Removed. Changed callers to use
138 (var_is_value_system_missing): Removed. Changed callers to use
139 var_is_value_missing.
141 * casefilter.c (struct casefilter): Use enum mv_class in place of
143 (casefilter_variable_missing): Adapt to new member.
144 (casefilter_create): Change signature to take enum mv_class,
147 Fri Dec 22 20:08:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
149 * casefile-factory.h fastfile-factory.c fastfile-factory.h: New files.
151 * case-sink.c case-sink.h procedure.c procedure.h
152 storage-stream.c: Now uses the factory.
154 Sat Dec 16 22:05:18 2006 Ben Pfaff <blp@gnu.org>
156 Make it possible to pull cases from the active file with a
157 function call, instead of requiring indirection through a callback
160 * case-source.h (struct case_source_class): Change ->read function
161 to return a single case, instead of calling a callback function
162 for each case. Change ->destroy function to return an error
165 * case-source.c (free_case_source): Pass along the value returned
166 by the case_source ->destroy function.
168 * procedure.c (struct write_case_data): Removed.
169 (struct dataset): Added some members to track procedure state.
170 (procedure): Optimize the trivial case at this level.
171 (internal_procedure): Re-implement in terms of proc_open,
172 proc_read, proc_close.
173 (proc_open) New function.
174 (proc_read) New function.
175 (proc_close) New function.
176 (write_case) Moved into proc_read.
177 (close_active_file) Moved closing of data source into proc_close.
179 * storage-source.c: Rewrote to conform with modified
180 case_source_class interface.
182 * transformations.c (trns_chain_execute): Added argument to allow
183 starting execution from an arbitrary transformation. Updated
186 * transformations.h (enum TRNS_NEXT_CASE) Renamed TRNS_END_CASE.
188 Sat Dec 16 14:09:25 2006 Ben Pfaff <blp@gnu.org>
190 * sys-file-reader.c (read_display_parameters): Don't assume that
191 MEASURE_* and ALIGN_* have the same values found in system files.
193 * sys-file-writer.c (write_variable_display_parameters): Ditto.
195 * variable.h: Change MEASURE_NOMINAL, MEASURE_ORDINAL,
196 MEASURE_SCALE to be 0-based instead of 1-based. This also fixes
197 the value of n_MEASURES, which was off by 1 (at least from my
200 Sat Dec 16 12:17:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
202 * dictionary.c dictionary.h vardict.h variable.c: Added optional
203 callbacks which are invoked when the dictionary or its
204 variables are changed.
206 * missing-values.c missing-values.h value-labels.c: Tidied up
207 consistency checks, and made some of them return false
208 instead of assert-failing.
210 Wed Dec 13 19:30:11 2006 Ben Pfaff <blp@gnu.org>
212 * calendar.c (calendar_days_in_month): New function.
214 Mon Dec 11 07:53:39 2006 Ben Pfaff <blp@gnu.org>
216 * value-labels.c (hash_int_val_lab): Only hash as many bytes as
217 the value label's width.
219 Sun Dec 10 14:21:29 2006 Ben Pfaff <blp@gnu.org>
221 * sfm-private.h: Move contents into sys-file-writer.c, which is
222 the only remaining user. Removed Borland C++-specific directives.
224 * sys-file-reader.c: Clean up and rewrite entire file. The
225 rewritten version is simpler and better abstracted, and should be
226 easier to maintain and extend. It avoids using structures to read
227 file data, which is prone to padding variations among compilers.
228 It should also handle non-IEEE 754 system files, although I
229 haven't been able to find any. It has been tested against many
230 .sav files obtained from the Web and found to produce the same
231 results as the earlier version of the code, or in some cases
232 improved results. It is more tolerant of format variations found
235 * sys-file-reader.h (struct sfm_read_info): Removed `big_endian'
236 member, putting an enum integer_format in its place. New member
237 `float_format'. Changed `compressed' member to type bool.
239 Sun Dec 10 13:48:53 2006 Ben Pfaff <blp@gnu.org>
241 * dictionary.c (dict_delete_consecutive_vars): New function.
243 Sat Dec 9 20:08:25 2006 Ben Pfaff <blp@gnu.org>
245 * file-name.c (fn_search_path): Remove prefix arg that was unused
246 by any caller. Updated all callers.
248 Sat Dec 9 20:04:22 2006 Ben Pfaff <blp@gnu.org>
250 * format.c (fmt_dollar_template): Use user's decimal point
251 character. Add assertion.
253 Sat Dec 9 20:02:25 2006 Ben Pfaff <blp@gnu.org>
255 * format.c (fmt_dollar_template): New function, based on
256 dollar_format_template from var-type-dialog.c.
258 Sat Dec 9 18:05:59 2006 Ben Pfaff <blp@gnu.org>
260 * data-out.c (output_scientific): Fix bad assumption that "buf" is
263 Sat Dec 9 17:23:23 2006 Ben Pfaff <blp@gnu.org>
265 Finish converting struct variable to an opaque type. In this
266 phase, we add remaining setter and getter functions, convert the
267 remaining PSPP code to use them, and do a bunch of cleanup. The
268 resulting changes are pervasive but mostly trivial, and only the
269 notable changes are logged.
271 * automake.mk (src_data_libdata_a_SOURCES): Add the new source
274 * case.c (case_data): Renamed case_data_idx.
275 (case_num): Renamed case_num_idx.
276 (case_str): Renamed case_str_idx.
277 (case_data_rw): Renamed case_data_rw_idx.
279 * case.h (case_data): New function with old name and an interface
280 that takes a variable instead of an index, which is easier to
281 use. Updated all callers to use the new interface, or to use the
282 new *_idx function (see above).
285 (case_data_rw): Ditto.
287 * category.c (cat_stored_values_destroy): Changed interface to
288 take a struct cat_vals * instead of a struct variable *.
290 * dictionary.c (dict_clone): Use new vector_clone function.
291 (dict_clear) Use new var_destroy function.
292 (add_var) New function.
293 (dict_create_var) Rewrite in terms of dict_create_var_assert.
294 (dict_create_var_assert) Rewrite in terms of add_var.
295 (dict_clone_var) Rewrite in terms of dict_clone_var_assert.
296 (dict_clone_var_assert) Rewrite in terms of var_clone, add_var.
297 (dict_lookup_var) Use new var_create, var_destroy functions.
298 (dict_contains_var) Rewrite in terms of new vardict functionality.
299 (set_var_dict_index) New function.
300 (set_var_case_index) New function.
301 (reindex_vars) New function.
302 (dict_delete_var) Rewrite in terms of new vardict functionality.
303 (dict_reorder_var) Ditto.
304 (dict_reorder_vars) Ditto.
305 (rename_var) New function.
306 (dict_rename_var) Use rename_var.
307 (dict_rename_vars) Use pool to simplify code. Use rename_var.
308 (dict_get_compacted_idx_to_fv) Rename
309 dict_get_compacted_dict_index_to_case_index, update callers.
310 (dict_create_vector) Use new vector_create function.
311 (dict_clear_vectors) Use new vector_destroy function.
312 (set_var_short_name_suffix) Move here from variable.c, renamed
313 from var_set_short_name_suffix, make static, update caller.
315 * sys-file-private.c: New file.
316 (sfm_width_to_bytes) Moved here from variable.c, renamed from
317 width_to_bytes, update callers.
319 * sys-file-private.h: New file. Later it will supplant
320 sfm-private.h; for now it supplements it.
321 (macro MIN_VERY_LONG_STRING) New macro.
322 (macro EFFECTIVE_LONG_STRING_LENGTH) New macro, from value.h.
324 * sys-file-reader.c: Use MIN_VERY_LONG_STRING - 1 where
325 MAX_LONG_STRING was used before.
327 * sys-file-writer.c: Ditto.
329 * value-labels.c: Change the paradigm here to be that a null
330 pointer is OK for a struct val_labs * in most cases; it just
331 represents an empty set of value labels.
332 (val_labs_copy) A copy of a null set is a null set.
333 (val_labs_count) A null set has 0 labels.
334 (val_labs_replace) Change return type to void. Rewrite for
336 (val_labs_find) A null set does not contain the value.
337 (value_to_string) Moved to variable.c, renamed var_get_value_name,
338 transposed argument order, updated all callers.
341 (value_dup) Moved here from variable.c.
342 (compare_values) Ditto.
345 * value.h: (macro MAX_SHORT_STRING) Rewrote for simplicity.
346 (macro MAX_LONG_STRING) Removed, because it was only interesting
347 for system files, not for general code.
348 (macro MAX_VERY_LONG_STRING) Ditto.
349 (macro EFFECTIVE_LONG_STRING_LENGTH) Moved to sys-file-private.h.
350 (macro MAX_ELEMS_PER_VALUE) Removed, as it was unused.
352 * vardict.h: New file, for an interface between variables and
355 * variable.c: A lot of functions were moved around, for better
357 (struct variable) Move definition here, from variable.h.
358 (var_type_adj) Removed--makes i18n hard.
359 (var_type_noun) Ditto.
360 (var_create) New function.
361 (var_clone) New function.
362 (var_destroy) New function.
363 (var_set_name) Assert that variable is not in a dictionary.
364 (compare_var_names) Rename compare_vars_by_name and fix a couple
365 of callers who thought the args were strings.
366 (hash_var_name) Rename hash_var_by_name.
367 (compare_var_ptr_names) Rename compare_var_ptrs_by_name.
368 (hash_var_ptr_name) Rename hash_var_ptr_by_name.
369 (var_is_very_long_string) Removed, because it was only interesting
371 (var_set_missing_values) Allow the argument to be the wrong width,
372 as long as we can resize it. Simplify callers who were doing the
374 (var_get_value_labels) New function.
375 (var_has_value_labels) New function.
376 (var_set_value_labels) New function.
377 (alloc_value_labels) New function.
378 (var_add_value_label) New function.
379 (var_replace_value_label) New function.
380 (var_clear_value_labels) New function.
381 (var_lookup_value_label) New function.
382 (var_get_value_name) Moved here from variable.c, renamed from
383 var_get_value_name, transposed argument order, updated all
385 (var_to_string) Moved here, from variable-label.c.
386 (var_set_leave) New function.
387 (var_get_leave) New function.
388 (var_must_leave) New function.
389 (var_set_short_name_suffix) Moved to dictionary.c, renamed
390 set_var_short_name_suffix.
391 (var_get_dict_index) New function.
392 (var_get_case_index) New function.
393 (var_get_obs_vals) New function.
394 (var_set_obs_vals) New function.
395 (var_has_obs_vals) New function.
396 (var_get_vardict) New function.
397 (var_set_vardict) New function.
398 (var_has_vardict) New function.
399 (var_clear_vardict) New function.
400 (value_dup) Moved to value.c.
401 (compare_values) Ditto.
404 * variable.h: (enum NUMERIC) Rename VAR_NUMERIC, update all users.
405 (enum ALPHA) Rename VAR_STRING, update all users.
407 * vector.c: New file.
408 (struct vector) Moved here, from variable.h.
409 (check_widths) New function.
410 (vector_create) New function.
411 (vector_clone) New function.
412 (vector_destroy) New function.
413 (vector_get_name) New function.
414 (vector_get_var) New function.
415 (vector_get_var_cnt) New function.
416 (compare_vector_ptrs_by_name) New function.
418 * vector.h: New file.
420 Sun Dec 10 11:32:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
422 * casefilter.c (casefilter_variable_missing): Avoided comparision of
423 string variables to SYSMIS. Thanks to Ben Pfaff for reporting this
426 Sat Dec 9 07:18:03 WST 2006 John Darrington <john@darrington.wattle.id.au>
428 * value-labels.c (destroy_atoms): New function.
429 * value-labels.c (atom_create): Call destroy_atoms in atexit handler.
431 Thu Dec 7 17:38:26 2006 Ben Pfaff <blp@gnu.org>
433 Thanks to Jason Stover for pointing out this problem.
435 * data-out.c (output_number): Use gsl_finite from GSL, which is
436 portable, instead of isfinite, which is not.
439 Thu Dec 7 15:22:38 WST 2006 John Darrington <john@darrington.wattle.id.au>
441 * variable.c variable.h (value_dup): New function.
443 Mon Dec 4 22:20:17 2006 Ben Pfaff <blp@gnu.org>
445 Start converting struct variable to an opaque type. In this
446 phase, we add a bunch of setter and getter functions and convert
447 most of the PSPP code to use them. The resulting changes are
448 pervasive but mostly trivial, and only the notable changes are
451 * format.c (fmt_equal): New function.
453 * variable.c (var_type_is_valid): New function.
454 (measure_is_valid) Moved here, from format.c.
455 (alignment_is_valid) Moved here, from format.c.
456 (var_get_name) New function.
457 (var_set_name) New function.
458 (width_to_type) New function.
459 (var_get_type) New function.
460 (var_get_width) New function.
461 (var_set_width) New function.
462 (var_is_numeric) New function.
463 (var_is_alpha) New function.
464 (var_is_short_string) New function.
465 (var_is_long_string) New function.
466 (var_is_very_long_string) New function.
467 (var_get_missing_values) New function.
468 (var_set_missing_values) New function.
469 (var_clear_missing_values) New function.
470 (var_has_missing_values) New function.
471 (var_is_value_missing) New function.
472 (var_is_num_missing) New function.
473 (var_is_str_missing) New function.
474 (var_is_value_user_missing) New function.
475 (var_is_num_user_missing) New function.
476 (var_is_str_user_missing) New function.
477 (var_is_value_system_missing) New function.
478 (var_get_print_format) New function.
479 (var_set_print_format) New function.
480 (var_get_write_format) New function.
481 (var_set_write_format) New function.
482 (var_set_both_formats) New function.
483 (var_get_label) New function.
484 (var_set_label) New function.
485 (var_clear_label) New function.
486 (var_has_label) New function.
487 (var_get_measure) New function.
488 (var_set_measure) New function.
489 (var_get_display_width) New function.
490 (var_set_display_width) New function.
491 (var_get_alignment) New function.
492 (var_set_alignment) New function.
493 (var_get_value_cnt) New function.
494 (var_get_leave) New function.
495 (var_get_short_name) New function.
497 * variable.h: (struct variable) Removed "type" and "nv" members;
498 they are now computed from "width" where needed.
500 Mon Dec 4 21:38:40 2006 Ben Pfaff <blp@gnu.org>
502 * missing-values.c (mv_resize): Don't write beyond end of the
503 allocated buffer when resizing a long string.
505 Sat Dec 2 16:28:32 2006 Ben Pfaff <blp@gnu.org>
507 Clean up identifier code: don't require identifier enumerations to
508 be in a particular order; make better use of string library;
509 expose less of the internals.
511 * identifier.c: (lex_skip_identifier) Rename lex_id_get_length,
512 change interface. Updated all callers.
513 (lex_id_match) Change interface to use struct substring, update
515 (lex_id_match_len) Removed. Update callers to use lex_id_match.
516 (global array keywords[]) Make static, change form. Update all
517 users to use lex_id_name instead.
518 (lex_is_keyword) New function.
519 (lex_id_to_token) Change interface to use struct substring, update
521 (lex_id_name) New function.
523 * identifier.h: (T_FIRST_KEYWORD) Removed. Changed users to call
524 lex_is_keyword instead.
525 (T_LAST_KEYWORD) Removed.
526 (T_N_KEYWORDS) Removed.
528 Sat Nov 18 20:46:35 2006 Ben Pfaff <blp@gnu.org>
530 * format.c: (fmt_date_template) Distinguish characters for which a
531 space is output and any date delimiter is allowed on input, from
532 those for which a space is output and only a space is allowed on
533 input. The former is represented by X, the latter by a space.
534 Also, drop distinction between h and H, changing the former to the
537 * data-in.c: Completely rewrite internals to conform to SPSS input
538 formats as closely as possible.
539 (data_in) Changed external interface by replacing the structure
540 that was used as a single argument by a set of arguments. Updated
542 (data_in_finite_line) Removed. Converted all callers to use plain
544 (data_in_get_integer_format) New function.
545 (data_in_set_integer_format) New function.
546 (data_in_get_float_format) New function.
547 (data_in_set_float_format) New function.
549 * data-in.h: (enums DI_IGNORE_ERROR, DI_IMPLIED_DECIMALS) Removed.
550 (struct data_in) Removed.
552 * data-out.c: (output_date) Drop each component from the input as
553 it is output, to allow us to drop the distinction between h (a
554 count of hours) and H (the hour of day) template characters.
555 Also, handle new X template character.
556 (output_scientific) Follow more rational rule on when to drop
557 fraction introduced between SPSS 13 and 15. Updated test case to
560 Sat Nov 11 11:41:26 2006 Ben Pfaff <blp@gnu.org>
562 Fix buffer overflow reported by John Darrington.
564 * data-out.c (output_bcd_integer): In case of SYSMIS, etc.,
565 realize that DIGITS is a count of nibbles, not of bytes.
567 Sat Nov 4 15:59:56 2006 Ben Pfaff <blp@gnu.org>
569 * calendar.c (calendar_offset_to_gregorian) Also return the
570 year-of-day. Change callers to new interface.
572 * data-out.c: Completely rewrite internals to conform to SPSS
573 output formats as completely as possible.
574 (data_out) Change interface to put input parameters before output
575 parameters, for consistency with the style I now prefer. Update
577 (data_out_get_integer_format) New public function.
578 (data_out_set_integer_format) New public function.
579 (data_out_get_float_format) New public function.
580 (data_out_set_float_format) New public function.
582 * data-out.h: New file. Move prototype for data_out here, from
585 * format.c: (fmt_step_width) Use equality comparison instead of
586 bitwise and, for clarity.
587 (fmt_is_string) Ditto.
588 (fmt_input_to_output) Fix categories that are translated to F
591 Sun Nov 5 08:29:34 WST 2006 John Darrington <john@darrington.wattle.id.au>
593 * casefilter.c casefilter.h (new files), casefile.c casefile.h
594 casefile-private.h: Added casefilter to assist commands with missing
597 Sat Nov 4 11:47:09 2006 Ben Pfaff <blp@gnu.org>
599 Implement SET ERRORS, SHOW ERRORS. Fixes bug #17609.
601 * settings.c: (route_errors_to_terminal) New variable.
602 (route_errors_to_listing) New variable.
603 (get_error_routing_to_terminal) New function.
604 (set_error_routing_to_terminal) New function.
605 (get_error_routing_to_listing) New function.
606 (set_error_routing_to_listing) New function.
608 * settings.h: (SET_ROUTE_* enums) Removed, because unused.
610 Tue Oct 31 19:58:27 2006 Ben Pfaff <blp@gnu.org>
612 * format.c: Completely rewrite, to achieve better abstraction.
613 Rewrite all references to formats in other files.
615 * format.def: Rewrite and reorganize.
617 * settings.c: Move everything related to custom currency formats
618 into format.[ch], changing them in form, so as to group related
619 code and definitions better. Changed all references to use the
621 (static var decimal) Removed.
622 (static var grouping) Removed.
623 (static var cc) Removed.
624 (get_decimal) Removed.
625 (set_decimal) Removed.
626 (get_grouping) Removed.
627 (set_grouping) Removed.
631 * settings.h: (macro CC_CNT) Removed.
632 (macro CC_WIDTH) Removed.
633 (struct custom_currency) Removed.
635 Tue Oct 31 19:56:19 2006 Ben Pfaff <blp@gnu.org>
637 * data-in.c (data_in): Use switch statement instead of table, to
638 avoid dependence on the order of the FMT_* enums.
640 Tue Oct 31 19:35:36 2006 Ben Pfaff <blp@gnu.org>
642 * data-out.c: (num_to_string) Removed, because it was dead code.
644 Tue Oct 31 18:09:24 2006 Ben Pfaff <blp@gnu.org>
646 * data-in.c (parse_trailer): Fix error message.
648 Sat Oct 28 11:56:50 2006 Ben Pfaff <blp@gnu.org>
650 * format.c (fmt_is_binary): New function.
652 Thu Oct 19 22:59:56 WST 2006 John Darrington <john@darrington.wattle.id.au>
654 * procedure.c procedure.h: Encapsulated the static data into a single
657 Sat Oct 14 16:56:44 2006 Ben Pfaff <blp@gnu.org>
659 * casefile.c (casereader_read_xfer): Always initialize the case,
660 even on an error condition.
662 Wed Sep 27 09:37:49 WST 2006 John Darrington <john@darrington.wattle.id.au>
664 * procedure.c (case_limit_trns_proc): Fixed buglet which rendered the
665 entire function useless.
667 Mon Sep 25 17:11:46 WST 2006 John Darrington <john@darrington.wattle.id.au>
669 * casefile-private.h casefile.c casefile.h fastfile.c: Created new
670 casereader method casereader_clone.
672 * procedure.c pransformations.h: Introduced new type casenum_t
674 Thu Sep 21 07:00:30 2006 Ben Pfaff <blp@gnu.org>
676 * variable.c: (width_to_bytes) Rephrase code for clarify.
678 Sun Jul 16 19:52:03 2006 Ben Pfaff <blp@gnu.org>
680 * format.c: (fmt_type_from_string) New function.
681 (fmt_to_string) Include decimals in output if the format has
682 decimals, even if the format type does not. This way, we can
683 accurately reproduce incorrect formats in user output.
684 (check_common_specifier) Make the check for a bad format type an
685 assertion, so we get bug reports if they show up. Fix message.
686 Check for decimal places with a format type that doesn't allow
688 (check_input_specifier) Remove check for FMT_X, which has been
690 (check_output_specifier) Ditto.
692 * format.def: Remove FMT_T, FMT_X, FMT_DESCEND, FMT_NEWREC.
694 * format.h: (macro FMT_TYPE_LEN_MAX) New macro.
695 (struct fmt_desc) Use FMT_TYPE_LEN_MAX in definition.
696 (enum fmt_parse_flags) Removed.
698 Mon Jul 17 18:26:21 WST 2006 John Darrington <john@darrington.wattle.id.au>
700 * casefile.c casefile.h: Converted to an abstract base class.
701 * casefile-private.h fastfile.c fastfile.h: New files.
702 * automake.mk procedure.c scratch-writer.c storage-stream.c
704 Wed Jul 12 21:02:26 2006 Ben Pfaff <blp@gnu.org>
706 * procedure.c (internal_procedure): Create sink_case with only as
707 many values as the compacted dictionary.
709 Wed Jul 12 21:01:00 2006 Ben Pfaff <blp@gnu.org>
711 Remove "debugging" code that caused plenty of false positives and
714 * case.h (struct ccase): [DEBUGGING] Remove `this' member.
716 * case.c: Remove all references to `this' member.
718 Thu Jul 6 19:09:53 2006 Ben Pfaff <blp@gnu.org>
720 Fix link error noted by Jason Stover.
722 * storage-stream.c: Include <assert.h>.
724 Tue Jul 4 08:47:35 2006 Ben Pfaff <blp@gnu.org>
726 Fix bug #15766 (/KEEP subcommand on SAVE doesn't fully support
727 ALL) and additional underlying system file issues.
729 Thanks to John Darrington for review.
731 First problem: var_hash points to variables not owned by the
732 sys-file-reader, which the caller may free or modify. Use an
733 array of sfm_vars instead, as done earlier (e.g. CVS version
736 * sys-file-reader.c (struct sfm_reader): Remove var_hash, svars
737 members and remove all code that references it. Add vars, var_cnt
738 members. Remove fix_specials member, which was unused.
739 (struct sfm_var) Remove name member, which was unused.
740 (sfm_close_reader) Free vars member instead of var_hash.
741 (compare_var_shortnames) Removed.
742 (hash_var_shortname) Removed.
743 (sfm_open_reader) Fill out vars array.
744 (compare_var_index) Removed.
745 (sfm_read_case) Use vars instead of var_hash.
747 Second problem: we're confused about when we actually have very
748 long strings, causing us to choose incorrectly between slow path
749 and fast path in sfm_read_case.
751 * sys-file-reader.c: (sfm_open_reader) Only mark has_vls if we
752 have very long strings, not when we have long variable names,
753 which is an unrelated feature.
755 Tue Jun 27 12:06:49 2006 Ben Pfaff <blp@gnu.org>
757 * variable.h: Move var_set and variable parsing declarations to
758 new header, src/language/lexer/variable-parser.h. Modified lots
759 of files to include the new header.
761 Sun Jun 25 22:39:32 2006 Ben Pfaff <blp@gnu.org>
763 * value-labels.c (value_to_string): When there's no value label,
764 format the variable according to its print format, instead of
765 always effectively using A or F format.
767 Mon Jun 19 18:05:42 WST 2006 John Darrington <john@darrington.wattle.id.au>
769 * casefile.c (casefile_get_random_reader): Nasty hack to get around
772 * format.c: Removed tortological assertion.
774 Fri Jun 9 12:20:09 2006 Ben Pfaff <blp@gnu.org>
776 Reform string library.
778 * file-name.c (fn_interp_vars): Change interface to take a
779 substring as input. Updated all users.
781 Fri Jun 9 12:11:24 2006 Ben Pfaff <blp@gnu.org>
783 * format.c (measure_is_valid): Really return false when m >=
786 Tue Jun 6 18:46:26 2006 Ben Pfaff <blp@gnu.org>
788 Implement random access to casefiles, for use in GUI.
790 * casefile.c: (struct casereader) Add `random', `file_ofs',
791 `buffer_ofs' members.
792 (casefile_get_random_reader) New function.
793 (read_open_file) Break part into new function
794 seek_and_fill_buffer().
795 (fill_buffer) Update buffer_ofs, file_ofs.
796 (casereader_seek) New function.
798 Tue May 30 19:52:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
800 * settings.c: Added call to i18n{done, init}.
802 Tue May 9 21:09:17 2006 Ben Pfaff <blp@gnu.org>
804 * procedure.h: Add WARN_UNUSED_RESULT to procedure function
807 Tue May 9 21:08:05 2006 Ben Pfaff <blp@gnu.org>
809 * casefile.c: Convert many uses of `int' to `bool'.
811 Sat May 6 22:49:43 2006 Ben Pfaff <blp@gnu.org>
813 * transformations.c (trns_chain_destroy): Destroy chain's trns
814 member, to fix memory leak.
816 Sat May 6 22:48:30 2006 Ben Pfaff <blp@gnu.org>
818 * storage-stream.c (storage_source_decapsulate): Destroy case
819 source to fix memory leak.
821 Sat May 6 22:46:47 2006 Ben Pfaff <blp@gnu.org>
823 * scratch-reader.c (scratch_reader_read_case): Copy into existing
824 case passed as argument instead of initializing the argument as a
825 case. Fixes memory leak that showed up in
826 tests/command/aggregate.sh with scratch files.
828 Sat May 6 22:45:55 2006 Ben Pfaff <blp@gnu.org>
830 * procedure.c (proc_done): Destroy default_dict, to fix memory
833 Sat May 6 22:44:44 2006 Ben Pfaff <blp@gnu.org>
835 Simplify procedure_with_splits().
837 * procedure.c (struct split_aux_data): Removed case_count member.
838 (procedure_with_splits) Don't initialize case_count.
839 (split_procedure_case_func) Check whether prev_case is null
840 instead of case_count.
841 (split_procedure_end_func) Ditto.
843 Sat May 6 22:42:23 2006 Ben Pfaff <blp@gnu.org>
845 * case.c (case_move): Do nothing if dst and src are the same
847 (case_try_create) Merge two similar cases.
848 (case_copy) Unshare only if data must be actually copied.
850 Sun May 7 10:04:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
852 * data-in.c data-out.c dictionary.c sys-file-reader.c
853 sys-file-writer.c variable.c variable.h: Reworked very long string
854 support for better encapsulation.
856 Sat May 6 19:02:00 2006 Ben Pfaff <blp@gnu.org>
858 * value-labels.c (val_labs_can_set_width): New function.
859 (val_labs_set_width) Clear labels if increasing width to long
861 (val_labs_destroy) Remove unneeded test for null.
863 Sat May 6 16:14:08 2006 Ben Pfaff <blp@gnu.org>
865 * value-labels.h: Remove unneeded dependency on variable.h.
867 Sat May 6 15:58:36 2006 Ben Pfaff <blp@gnu.org>
869 Get rid of `char *c' member in union value, for cleanliness.
871 * value.h: (union value) Remove `c' member.
873 Sat May 6 15:36:59 2006 Ben Pfaff <blp@gnu.org>
875 Make dictionary compacting functions a little more general.
877 * sys-file-writer.c (sfm_open_writer): Use
878 dict_compacting_would_change().
879 (does_dict_need_translation) Removed.
881 Sat May 6 15:35:42 2006 Ben Pfaff <blp@gnu.org>
883 Make dictionary compacting functions a little more general.
885 * dictionary.c (dict_needs_compaction): Rename
886 dict_compacting_would_shrink(). Update all callers.
887 (dict_compacting_would_change) New function.
889 Sat May 6 14:25:49 2006 Ben Pfaff <blp@gnu.org>
891 * sys-file-writer.c: (does_dict_need_translation) Fix bug:
892 inverted return value (!).
894 Sat May 6 13:37:52 2006 Ben Pfaff <blp@gnu.org>
896 Continue reforming procedure execution.
898 * procedure.c: Search and replace "vfm" by "proc". Notably:
899 (static var vfm_source) Rename proc_source. Update all
901 (static var vfm_sink) Rename proc_sink. Update all references.
903 Sat May 6 12:38:55 2006 Ben Pfaff <blp@gnu.org>
905 Continue reforming procedure execution. In this phase, remove
906 PROCESS IF, which was deprecated anyway and can be easily
907 simulated with TEMPORARY followed by SELECT IF.
909 * procedure.c: (open_active_file) Don't call
910 add_process_if_trns().
911 (discard_variables) Get rid of redundant call to
912 proc_cancel_all_transformations().
913 (add_process_if_trns) Removed.
914 (process_if_trns_proc) Removed.
915 (process_if_trns_free) Removed.
917 Sat May 6 10:58:05 2006 Ben Pfaff <blp@gnu.org>
919 Continue reforming procedure execution. In this phase, add
920 `const' to the case passed to procedure()'s callback.
922 Updated all users of procedure() as well.
924 * procedure.c: (struct write_case_data) Add "const" to ccase
925 parameter for case_func member.
926 (procedure) Add "const" to ccase parameter for proc_func
928 (multipass_case_func) Make ccase parameter const.
929 (internal_procedure) Add "const" to ccase parameter for case_func
931 (split_procedure_case_func) Make ccase parameter const.
932 (multipass_split_case_func) Make ccase parameter const.
934 Sat May 6 10:30:33 2006 Ben Pfaff <blp@gnu.org>
936 Continue reforming procedure execution. In this phase, get rid of
937 the output code for SPLIT FILE groups in procedure.c, which really
938 shouldn't be doing any output. Move it into the individual
939 procedures instead. This also adds some flexibility.
941 Updated many users of procedure_with_splits() and
942 multipass_procedure_with_splits() to call
943 output_split_file_values() and to deal with increased use of
946 * procedure.c: (struct split_aux_data) Add "const struct ccase *"
947 parameter to begin_func member.
948 (procedure_with_splits) Add "const struct ccase *" parameter to
949 begin_func parameter. Make ccase parameter const in proc_func
951 (split_procedure_case_func) Don't dump split file group. Pass
953 (dump_splits) Moved to language/dictionary/split-file.c as
954 output_split_file_values().
955 (struct multipass_split_aux_data) Add "const struct ccase *"
956 parameter to split_func member.
957 (multipass_procedure_with_splits) Add "const struct ccase *"
958 parameter to split_func parameter.
959 (multipass_split_case_func) Save new SPLIT FILE case before
961 (multipass_split_output) Pass saved SPLIT FILE case to split_func.
963 Fri May 5 22:48:50 2006 Ben Pfaff <blp@gnu.org>
965 Continue reforming procedure execution. Change
966 internal_procedure() so that it calls open_active_file() and
967 close_active_file(), which isolates most of the actual procedure
970 * procedure.c: (struct write_case_data) Rename `proc_func' member
971 to `case_func' and update all references.
972 (procedure) Rewrite as one-line wrapper around
973 internal_procedure().
974 (struct multipass_aux_data) New.
975 (multipass_callback) Renamed multipass_case_func(). Use struct
976 multipass_aux_data as auxiliary data.
977 (multipass_end_func) New function.
978 (multipass_procedure) Rewrite as wrapper for internal_procedure()
979 that uses multipass_case_func, multipass_end_func.
980 (internal_procedure) Add `end_func' argument. Move optimization
981 of trivial case in here. Move call to open_active_file() and
982 close_active_file() in here. Now assert that vfm_source is
984 (procedure_with_splits_callback) Rename
985 split_procedure_case_func().
986 (split_procedure_end_func) New function.
987 (multipass_split_callback) Rename multipass_split_case_func.
988 (multipass_split_end_func) New function.
989 (discard_variables) No need to test for nonnull vfm_source.
991 Fri May 5 21:34:02 2006 Ben Pfaff <blp@gnu.org>
993 Continue reforming procedure execution. Get rid of unused member.
995 * procedure.c: (struct write_case_data) Remove `cases_analyzed'
997 (write_case) Don't increment cases_analyzed.
999 Thu May 4 21:50:11 2006 Ben Pfaff <blp@gnu.org>
1001 Continue reforming procedure execution. In this phase, move
1002 procedure.c and procedure.h from src to src/data. Update
1003 makefiles and #includes accordingly.
1005 * procedure.c: Moved here from src/.
1007 * procedure.h: Moved here from src/.
1009 Wed May 3 22:42:12 2006 Ben Pfaff <blp@gnu.org>
1011 Continue reforming procedure execution. In this phase, get rid of
1012 many global variables, consolidating procedure execution in
1013 procedure.c. Encapsulate transformations in new "struct
1014 trns_chain". Also, change implementation of N OF CASES, FILTER,
1015 and PROCESS IF from special cases to transformations.
1017 * automake.mk: (src_data_libdata_a_SOURCES) Add transformations.c,
1020 * dictionary.c: (global variable default_dict) Move to
1023 * variable.h: (TRNS_*) Move to transformations.h.
1024 (struct transformation) Move to transformations.c.
1026 Thu May 4 13:47:06 WST 2006 John Darrington <john@darrington.wattle.id.au>
1028 * sys-file-reader.c: Fixed invalid read problems.
1030 Tue May 2 15:57:10 2006 Ben Pfaff <blp@gnu.org>
1032 * storage-stream.c: Add missing function comments.
1034 Tue May 2 15:50:21 2006 Ben Pfaff <blp@gnu.org>
1036 Continue reforming procedure execution. In this phase, add some
1037 new, needed functionality to storage-stream.
1039 * storage-stream.c: (storage_source_decapsulate) New function.
1041 Tue May 2 15:43:36 2006 Ben Pfaff <blp@gnu.org>
1043 * variable.c (width_to_bytes): Declarations must precede
1044 statements for C90 compliance.
1046 Tue May 2 10:42:05 WST 2006 John Darrington <john@darrington.wattle.id.au>
1048 * data-out.c, data-in.c, variable.c, variable.h: New functions
1049 copy_mangle and copy_demangle for reading/writing cases; emulates the
1050 way SPSS deals with strings > 255 bytes.
1052 * sys-file-reader.c sys-file-writer.c: Added support for Record 7,
1053 subtype 14 needed for strings longer than 255 bytes.
1055 * dictionary.c, format.def, value.c : Updated to use MAX_STRING
1056 instead of literal values. Also fixed some constness issues.
1058 * format.h: Constness
1060 * sfm-private.h: Renamed the case_size identifier, since I discovered
1061 that SPSS's respect for this variable is very nominal.
1063 Mon May 1 15:45:42 2006 Ben Pfaff <blp@gnu.org>
1065 Change case limit type from int to size_t.
1067 * dictionary.c: (struct dictionary) Change type of case_limit
1069 (dict_get_case_limit) Change return type.
1070 (dict_set_case_limit) Change parameter type.
1072 Wed Apr 26 20:01:19 2006 Ben Pfaff <blp@gnu.org>
1074 * variable.h: (struct variable) Rename `reinit' member as `leave'
1075 and invert sense. Fix up all references.
1077 Wed Apr 26 19:39:28 2006 Ben Pfaff <blp@gnu.org>
1079 Continue reforming procedure execution. In this phase, break
1080 procedure.c into multiple files.
1082 * automake.mk: (src_data_libdata_a_SOURCES) Add all the new files.
1084 * case-sink.c: New file.
1086 * case-sink.h: New file.
1088 * case-source.c: New file.
1090 * case-source.h: New file.
1092 * storage-stream.c: New file.
1094 * storage-stream.h: New file.
1096 Wed Apr 26 14:55:19 2006 Ben Pfaff <blp@gnu.org>
1098 * variable.h: (struct variable) Remove `init' member and all
1099 references to it from other files. It was initialized in several
1100 places, but nothing really ever used it for anything worthwhile.
1101 Thanks to Jason Stover for pointing out how confusing this
1104 Sun Apr 23 22:04:45 2006 Ben Pfaff <blp@gnu.org>
1106 Continue reforming error message support. In this phase, get rid
1107 of message "titles" and put the message text in `struct error'.
1108 Now `struct error' encapsulates a message more properly.
1110 * casefile.c: (io_error) Use err_msg() instead of err_vmsg().
1111 Format message ourselves.
1113 * data-in.c: (vdls_error) Ditto.
1115 * por-file-reader.c: (error) Ditto.
1117 * sys-file-reader.c: (corrupt_msg) Ditto.
1119 Sun Apr 16 18:49:51 2006 Ben Pfaff <blp@gnu.org>
1121 GNU standards require "file name" instead of "filename" in
1122 documentation. It's nice for our code to follow the convention
1125 * casefile.c: (struct casefile) Rename `filename' member to
1126 `file_name'. Updated all references.
1128 * file-name.c: [!unix] (struct file_identity) Rename
1129 normalized_filename member to normalized_file_name. Updated all
1132 Sun Apr 16 18:35:33 2006 Ben Pfaff <blp@gnu.org>
1134 We don't really support anything but Unix-like environments well,
1135 so we might as well de-obfuscate by writing directory and path
1136 separators explicitly.
1138 * file-name.h: (macro DIR_SEPARATOR) Removed. Changed all usages
1140 (macro PATH_SEPARATOR) Removed. Changed all usages to just ':'.
1141 (macro DIR_SEPARATOR_STRING) Removed. Changed all usages to just
1143 (macro PATH_SEPARATOR_STRING) Removed. Changed all usages to just
1146 Sun Apr 16 18:28:35 2006 Ben Pfaff <blp@gnu.org>
1148 GNU standards require "file name" instead of "filename" in
1149 documentation. It's nice for our code to follow the convention
1152 * filename.c: Rename to file-name.c.
1154 * filename.h: Rename to file-name.h. Update all inclusions.
1155 Update header guards.
1157 * automake.mk: Update file names.
1159 Sun Apr 16 16:42:47 2006 Ben Pfaff <blp@gnu.org>
1161 * filename.c: (fn_dirname) Renamed fn_dir_name(), all references
1163 (fn_basename) Removed (dead code).
1164 (fn_absolute_p) Renamed fn_is_absolute(), all references updated.
1165 (fn_special_p) Renamed fn_is_special(), all references updated.
1166 (fn_exists_p) Renamed fn_exists(), all references updated.
1168 Sun Apr 16 16:33:58 2006 Ben Pfaff <blp@gnu.org>
1170 * filename.c: (fn_tilde_expand) Rewrite for cleaner code.
1171 Also, now it only tilde-expands file names, not paths.
1172 (fn_search_path) Tilde-expand one directory at a time.
1174 Sun Apr 16 16:28:06 2006 Ben Pfaff <blp@gnu.org>
1176 * filename.c: (fn_search_path) rewrite for cleaner code. Also,
1177 get rid of non-Unixlike version of the code, which has probably
1179 (fn_prepend_dir) Removed (dead code).
1181 * filename.h: (macro DIR_SEPARATOR_STRING) New.
1182 (macro PATH_SEPARATOR_STRING) New.
1183 Sun Apr 16 16:05:28 2006 Ben Pfaff <blp@gnu.org>
1185 Continue reforming error message support. In this phase, we get
1186 rid of VM() and the other msg() support for "verbosity", replacing
1187 it by a new function verbose_msg().
1189 * filename.c: (fn_search_path) Use verbose_msg() instead of
1192 Sat Apr 15 19:53:19 2006 Ben Pfaff <blp@gnu.org>
1194 * sfm-private.h: Get rid of #defines after #error, which makes no
1197 Sat Apr 15 19:48:57 2006 Ben Pfaff <blp@gnu.org>
1199 Get rid of our own int32 type in favor of the standard int32_t
1202 * sfm-private.h: (int32 macro) Don't define this anymore. Do
1205 * sys-file-reader.c: Use int32_t instead of int32 throughout.
1207 * sys-file-writer.c: Use int32_t instead of int32 throughout.
1209 Sat Apr 15 19:36:47 2006 Ben Pfaff <blp@gnu.org>
1211 Remove ill-considered file routines that are no longer used.
1213 * filename.c: (fn_open_ext) Removed.
1214 (fn_close_ext) Removed.
1216 * filename.h: (struct file_ext) Removed.
1218 Mon Apr 3 13:22:39 2006 Ben Pfaff <blp@gnu.org>
1220 * variable.c (var_is_valid_name): Move declarations before code
1223 Tue Apr 4 15:28:40 WST 2006 John Darrington <john@darrington.wattle.id.au>
1225 * filename.ch (fn_interp_vars): Fixed small buglet.
1227 Tue Mar 28 13:47:16 WST 2006 John Darrington <john@darrington.wattle.id.au>
1229 * filename.[ch] (fn_interp_vars): Changed the signature and semantics
1230 so as to modify the string inline. Thus makeing it easier to
1231 destroy the results when no longer needed.
1233 2006-03-25 Jason Stover <jhs@math.gcsu.edu>
1235 * category.c (cat_stored_values_destroy): Fixed memory leak.
1237 Fri Mar 24 18:15:41 2006 Ben Pfaff <blp@gnu.org>
1239 Add some missing frees. Thanks to John Darrington for reporting
1242 * any-writer.c (any_writer_close): Free writer.
1244 * any-reader.c (any_reader_close): Free reader.
1246 Mon Mar 20 16:33:53 2006 Ben Pfaff <blp@gnu.org>
1248 * por-file-reader.c: (error) Mark as NO_RETURN.
1250 Sat Mar 11 15:06:07 WST 2006 John Darrington <john@darrington.wattle.id.au>
1252 * settings.c: Changed default value of scompress to true.
1254 Sat Mar 4 13:22:51 2006 Ben Pfaff <blp@gnu.org>
1256 * sfm-private.h: Include variable.h, to get SHORT_NAME_LEN.
1258 * value.h: Remove check on MAX_SHORT_STRING, which I don't think
1261 * variable.h: Move definition of SHORT_NAME_LEN, LONG_NAME_LEN
1262 here from pref.h.orig.
1264 Sat Mar 4 12:50:48 WST 2006 John Darrington <john@darrington.wattle.id.au>
1266 * sys-file-reader.c: Fixed bug reading compressed files.
1268 Thu Mar 2 08:40:33 WST 2006 John Darrington <john@darrington.wattle.id.au>
1270 * Numerous renames. See src/ChangeLog for details.
1272 * Moved files from src directory